Add benchmark for https://github.com/YasserAsmi/jvar

I have written the test module for jvar.  However, I didn't figure out how to insert a link for the library itself like you have for other libs.  The lib can be found at https://github.com/YasserAsmi/jvar  and it should go into thirdparty/jvar.  Thanks

You can try at the project root:
git submodule add https://github.com/YasserAsmi/jvar.git thirdparty/jvar

And then add the change to this PR.

OK done--thanks

@YasserAsmi , I just found out that jvar cannot compile on VC2015, due to
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(406): error C3861: 'gmtime_r': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(412): error C3861: 'time': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(413): error C3861: 'localtime_r': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(421): error C3861: 'mktime': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(427): error C3861: 'strftime': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(432): error C3861: 'strptime': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(442): error C3861: 'timegm': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(448): error C3861: 'difftime': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(453): error C3861: 'difftime': identifier not found
1>c:\github\nativejson-benchmark\thirdparty\jvar\include\util.h(478): error C3861: 'usleep': identifier not found
...

I just checked the latest version seems to have the same problem. Will you check that?
I will temporarily disable the compilation of the test on VC temporarily.

@miloyip Sure I will check the VC2015


Fix incorrect behavior of just_pressed and just_released in Input<GamepadButton>

Objective

Fixes a bug where just_pressed and just_released in Input<GamepadButton> might behave incorrectly due calling clear 3 times in a single frame through these three different systems: gamepad_button_event_system, gamepad_axis_event_system and gamepad_connection_system in any order

Solution

Call clear only once and before all the above three systems, i.e. in gamepad_event_system

Additional Info

Discussion in Discord: https://discord.com/channels/691052431525675048/768253008416342076/1064621963693273279

bors r+


Deprecate FinalHandler and ErrorMiddlewareInterface

This patch will provide the forwards compatibility features for the next minor version of Stratigility that implement the RFC on FinalHandler and ErrorMiddlewareInterface removal.

[x] Create NotFoundHandler and ErrorHandler middleware

NotFoundHandler returns a basic 404 response, always.
ErrorHandler:

creates a PHP error handler that will throw any errors not in the current error_handler mask as ErrorExceptions.
Does a try/catch around $next()
Raises a new exception, MissingResponseException, if $next does not return a response.
Casts all Throwable/Exception items to error responses:

If a boolean true flag is passed to the constructor, it will use the stack trace in the response.
Triggers listeners on the instance with the exception/throwable, request, and response, for reporting purposes.

[x] Create a no-op final handler that returns the provided response on invocation, ignoring all other arguments.
[x] Update MiddlewarePipe to issue a deprecation notice if $out is omitted.
[x] Mark Dispatch as deprecated.
[x] Update Next to raise deprecation notice when receiving a non-null $err argument.
[x] Mark FinalHandler as deprecated.
[x] Mark ErrorMiddlewareInterface as deprecated.
[x] Write migration guide.

Notes

In order to return a response, each new middleware type (NotFoundHandler, ErrorHandler) accepts a prototype ResponseInterface instance to the constructor; this is then used to generate the returned response in 404/error conditions. This is done to allow re-use with any PSR-7 implementation.

Marked as a BC break, as it introduces deprecation notices. These are, however, documented, and the messages themselves point to online (not-yet-published, but included in this PR) documentation to assist users in making their code forwards-compatible.

Pinging @zendframework/community-review-team / @ezimuel / @michaelmoussa for review!

I think new ErrorHandler should have possibility to create response depending on content-type.
It may be optional, eg. any callable param in constructor. Thoughts?

@vaclavvanik I like the idea, but I think that belongs more properly in zend-expressive or its skeleton, and not in Stratigility. Stratigility is a foundation, and the expectation is that it provides only the minimum functionality; in fact, the docs I wrote even recommend replacing the ErrorHandler and NotFoundHandler in your own applications in order to provide your own features.

@vaclavvanik I've updated the implementation to provide an extension point in ErrorHandler, allowing developers to extend the class and provide a protected createErrorResponse() method. This allows a common workflow of:

creating a PHP error handler that casts to ErrorException
using a try/catch block to handle all exceptions/throwables and respond to them
generating an error response
providing listeners that can act on the final error, request, and response

This will provide a better starting point with flexibility for end-users, while still being minimalist.

@weierophinney Imo custom error response factory could be injected as optional callable into ErrorHandler constructor. This allow great flexibility when pulling ErrorHandler from container and createErrorResponse  method can be still private.
class ErrorHandler
{
    private function createErrorResponse($e, ServerRequestInterface $request, ResponseInterface $response)
    {
        if ($this->errorResponseCallback) {
            return call_user_func($this->errorResponseCallback, $e, $request, $response);
        }

        $response = $response->withStatus(Utils::getStatusCode($e, $response));
        $body = $response->getBody();

        if ($this->isDevelopmentMode) {
             $body->write($this->createDevelopmentErrorMessage($e));
             return $response;
        }

        $body->write($response->getReasonPhrase() ?: 'Unknown Error');
        return $response;
    }
}

$errorResponse = function ($e, ServerRequestInterface $request, ResponseInterface $response) {
  // do content negotiation and other things
  return $response;
};

$errorHandler = new ErrorHandler(new Response(), $isDevelopmentMode,  $errorResponse);

Ummm... thinking maybe whole error response factory could be moved to another class. So ErrorHandler constructor could look:
class ErrorHandlerResponseFactory
{
    public function __construct(ResponseInterface $responsePrototype, $isDevelopmentMode = false);
    public function __invoke($e, ServerRequestInterface $request, ResponseInterface $response);
}

class ErrorHandler
{
    public function __construct(callable $errorResponseFactory)
    {
        $this->errorResponseFactory = $errorResponseFactory;
    }
}

Thanks for your opinions.

Incorporated feedback from @vaclavvanik and @michaelmoussa .

@vaclavvanik I've adopted the idea of injecting a response generator via the ErrorHandler constructor; if none is provided, the default ErrorResponseGenerator is used, in production mode. Thanks for the suggestion!


Now using native proto3 BindVariable.

Instead of converting them to native type before use. Should avoid one
conversion and make it much simpler.
@sougou this is the second part of this change, to actually pass through the proto3 BindVariable.

@sougou this can now be submitted as the internal old code is gone.

This is not ready yet. A few places cannot yet handle *protopb.BindVariable, like:
go/vt/tabletserver/codex.go:96
go/vt/vtgate/router.go in selectIn
I will fix and add more tests for these.


Support for connect and disconnect commands

Support for commands like this:
$ANDROID_HOME/platform-tools/adb connect <IP_ADDRESS>:10002
connected to <IP_ADDRESS>:10001
$ANDROID_HOME/platform-tools/adb disconnect <IP_ADDRESS>:10002
disconnected <IP_ADDRESS>:10001

They allow to communicate with devices on non standard ports and even on other hosts

Resolved


Related model attributes not showing

Hi, thanks for the hardwork.
I am currently using this plugin on Filament V.3
I realized that the related model attributes is not showing on the view.

The setup from https://spatie.be/docs/laravel-activitylog/v4/advanced-usage/logging-model-events#content-logging-directly-related-model-attributes has been done correctly. Checked on database, it has a value below:

Is there any setup missing on my side?

No setup missing on your side. I think I just haven't covered that case yet.

If you override the "createFieldLabelMap" function in your own class, it works.
`protected function createFieldLabelMap(): Collection
{
$originalAttributeNames = parent::createFieldLabelMap();
    $newAttributeNames = collect([
        'name' => 'custom_text',
        'email' => 'custom_text',
    ]);

    return $originalAttributeNames ->merge($newAttributeNames);
}`

Should be fixed by #51


Unchecking Show Invisibles has no effect in js files

Version 0.177.0 (0.177.0)
Mac OS X 10.10.2
https://gyazo.com/5951801f91f908b6e370b6083eea9273
https://gyazo.com/e4f44be12c4c6199f12824f2c1461cb7

I'm having trouble reproducing this.
Can you reproduce this in safe mode? Is this happening only for some JS files or all JS files? Is it happening for other file types? Is this happening only in one project or all projects?

Just tried in safe mode, and the issue persists. This happens for all JS files, and no other file types. It also happens in all projects.

These config options for showing invisibles are available for individual languages as well. Are you changing the global option or the one for JavaScript?

Can you try changing the one in the language-javascript package?

Can you go to Settings > Packages > language-javascript and see if Show Invisibles is checked there? Each language grammar has its own editor settings.

Ah, silly me. Yes, that certainly did help. Thanks :smile:

Happy to hear that. :) Closing this then


Expose docker image public

Hello,
Can you please expose docker image somewhere ? Maybe here using ghcr ?
I'm planning to add k8s deployment manifest but I don't want to use my own registry ..
I believe that is better for everybody to have everything in one place ... :)

Yeah I figure it out looking into GitHub Actions. Yeah it would be nice if you can push it here in GitHub because we will have a "registry" button where everybody cand see current tag and so on ... :)
Thanks


Inference model trained on Multiple GPU

For multiple GPU train, the saved model ( in .meta file) is split to two clones.
So all the tensor names are changed by default like
source_ph --> clone_0/ source_ph
custom_generated_t_style_source --> clone_0/custom_generated_t_style_source
So, if anyone want to eval or inference on its own single GPU machine, please be careful when the pre_trained model is base on multiple GPU.
I recommend use this inference code
python inference/image_translation_infer.py \
--model_path="/PATH/TO/CHECHPOINT" \
--image_hw=128 \
--input_tensor_name="clone_0/sources_ph" \
--output_tensor_name="clone_0/custom_generated_t_style_source:0" \
--input_image_path="/PATH/TO/INPUT" \
--output_image_path="/PATH/TO/OUTPUT" \

And by the way, I am wondering why the inference speed is soooooo slow. Loading the weight take 5-10 second on my 1080Ti

Thank you for giving pointers to changes during multi-gpu inference!
I think the speed to load weights sounds acceptable given model size and hdd data reading speed. If you want faster inference, you can change the code to do batching.


Inline Client Subscriptions prototype

Following the discussion in #279 (Direct subscribe for embedded use case), I've put together a prototype implementation of inline subscriptions as a counterpart of the server.Publish method.
I thought about this for almost two weeks and implemented several different versions. There were three core solutions which met the requirements of the direct subscription feature:

Hook Model: An implementation which used the existing hook system and added an additional hook beside OnPublished. The user could add new 'subscriptions' - topic filters and callback methods, and then the hook would be triggered when a message is published. Any subscriptions on this hook would be iterated, and a new internal topic comparison method (i.e. does topic name match filter) would be used to determine if the message should be provided to the given callback.

Good: Fairly simple to implement. Purely observational approach - didn't meaningfully interact with any existing internal code.
Not so good: didn't meaningfully interact with any existing internal code, so most topic features were unusable (e.g. retained), not reflective of actual usage. Required implementation of an entirely new topic matching system, which is slow at scale.

Outbound channel: We already implement an outbound channel which receives messages that will be sent to the client. I had some ideas around exposing this channel for developers to access.

Good: Using channels would have felt 'proper' and 'sophisticated'.
Not so good: All subscribed messages would come through on the same source. Still requires topic matching on the developer side. No clear way to make the subscriptions.

Inline Client changes: We already use special 'inline' clients in order to publish messages directly (via server.Publish and server.InjectPacket. It seemed reasonable that we could also allow inline clients to have subscriptions too, which triggered callbacks instead of writing packets to the network.

Good: Works almost exactly as if the client was external. Can receive retained messages. Simple to understand.
Not so good: Weird things might happen if you injected a totally custom subscription packet via server.InjectPacket. However, this customisability may also be a benefit to some. More Inline Client specific code.

Ultimately, the inline client approach was the only implementation which made both technical and intuitive sense.
There are two new methods:

func (s *Server) Subscribe(cl *Client, filter string, id int, callback InlineSubFn) error, and
func (s *Server) Unsubscribe(cl *Client, filter string) error

id is an MQTTv5 subscription identifier. These methods are used like so:
callbackFn := func(cl *mqtt.Client, sub packets.Subscription, pk packets.Packet) {
  // do something ...
}
err = server.Subscribe(cl, "direct/#", 2, callbackFn)

and
err := server.Unsubscribe(cl, "direct/#")

I have added a new example file, examples/direct/main.go which demonstrates the behaviour, and when run, outputs the following:
 % go run examples/direct/main.go
11:17PM INF added hook hook=allow-all-auth
11:17PM INF mochi mqtt starting version=2.3.0
11:17PM INF inline client subscribing
11:17PM INF inline client received message from subscription payload="some other retained message" topic=direct/alternate/retained
11:17PM INF mochi mqtt server started
11:17PM INF inline client received message from subscription payload="retained message" topic=direct/retained
11:17PM INF main.go issued direct message to direct/publish
11:17PM INF inline client received message from subscription payload="scheduled message" topic=direct/publish
11:17PM INF main.go issued direct message to direct/publish
11:17PM INF inline client received message from subscription payload="scheduled message" topic=direct/publish
11:17PM INF main.go issued direct message to direct/publish
11:17PM INF inline client received message from subscription payload="scheduled message" topic=direct/publish
11:17PM INF inline client unsubscribing
11:17PM INF main.go issued direct message to direct/publish
11:17PM INF main.go issued direct message to direct/publish
^C11:17PM WRN caught signal, stopping...
11:17PM INF stopping hook hook=allow-all-auth
11:17PM INF mochi mqtt server stopped
11:17PM INF main.go finished

There are no tests attached to this PR, but will be added upon acceptance. It also contains a small commit fixing some typos. Feedback encouraged!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 39 (17.95%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 98.292%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server.go
7
39
17.95%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
5295

Relevant Lines:
5387

💛  - Coveralls

I'll take a look at this in the next few days. I think you went with the right approach with the inline client. I think it makes the most sense most technically and for DX.

LGTM, but ... :)
Is there any reason why InlineSubs are part of ClientConnection and not ClientState?
Current implementation leads to some inconsistency, regular clients subs are part of ClientState, inline subs are part of ClientConnection.
I would say that having all subs in one struct would be more elegant and clean.

LGTM, but ... :)
Is there any reason why InlineSubs are part of ClientConnection and not ClientState?
Current implementation leads to some inconsistency, regular clients subs are part of ClientState, inline subs are part of ClientConnection.
I would say that having all subs in one struct would be more elegant and clean.

Withdrawn in favour of #284


Update to pyarrow 1.0.0

Is your feature request related to a problem? Please describe.
The conda package is pinned to pyarrow 0.17.*, but I'd like to use pyarrow 1.0.0 functionality.
Describe the solution you'd like
Is it possible to remove the pin on 0.17.* and update the dependency to 1.0.0? I'm happy to help with testing if you need an extra set of hands.

Thanks for the note! We definitely want to support 1.0.0 ASAP. The current blocker is that we use the javascript library in reports to deserialize datasets. Although Arrow itself is at 1.0.0, I do not believe the current typescript/js library supports this, as it seems to still be on 0.17.0.
When they release this, we would absolutely love an extra set of hands - thanks! :)

closing as we've updated to pyarrow 2.0.0 in master - this should be released in the next week or so


Adding deprecation notices to the Packet provider, resources and functions

Fixes: #5151
This is able to be hard coded as we will no longer be generating the packet provider
but the provider will continue to work to allow users to migrate to the new
provider

All requested changes made @rawkode


echarts

Not sure if we’ll recommend it, but we can still make it easy if people want it.

Yeah, that didn’t work for me either. We could pin the npm:echarts version for now, and then remove the pinning if they fix it in the future (if we anticipate that it’s going to break immediately)?

Okay, pinned at 5.4.3 (for now).


Serfati

methods added to DB and ServerSystem classes
config.pro log4j.xml fixed
keep testing the DB
documentation added.
Shabat Shalom!

methods added to DB and ServerSystem classes
config.pro log4j.xml fixed
keep testing the DB
documentation added.
Shabat Shalom!


Added local simulation support

Server override shuts down the websocket thread and sets the following last-status properties:

Target: Red OR Green (left or right arrow)
isActive: true
colors: [ <current color (waits for read != UNDEFINED)>, BLUE, WHITE, YELLOW ]

cc: @sondrele, @havardh

Looks good to me.


Add MaxTrialsCallback class to enable stopping after fixed number of trials

Cherry picked https://github.com/optuna/optuna/pull/2612.

@Crissman could you review and check if this PR looks consistent with yours?

@Crissman , feel free to merge PRs with an approval in optuna-examples 🙂


Update links

Updates all link schemes of working links from "http" links to "https" and a few other old links.

version: V4 (4.0.0-beta-01)

this is released. Should remove "-beta" from title and line 3, and (4.0.0-beta-01) from version on line 5.

Refers to: _libraries/ODataJS-beta.md:5 in 8cb3b00. [](commit_id = 8cb3b00e0b69d2b9f1aa17eb1e95b0ed71233a64, deletion_comment = False)

version: V4 (4.0.0-beta-01)

Addressed in PR#338

In reply to:<PHONE_NUMBER>

Refers to: _libraries/ODataJS-beta.md:5 in 8cb3b00. [](commit_id = 8cb3b00e0b69d2b9f1aa17eb1e95b0ed71233a64, deletion_comment = False)


Great util!

wanted to add a few notes:

works in MacOS Monterey
can be used on Mac with internal BUS if enabling the IAC driver and creating custom bus, then using that bus as the output

Thanks!

Thanks, Evgeny! I'll add that to the readme :smile:


Can QAVit be applied to multi-turn conversations?

Thank you for your great work, but I think QA-VIT may have a small flaw.
For example, with models like LLaVA, in multi-turn conversations, you only need to input the image into CLIP-VIT once. However, with QA-VIT, since the questions in each round of conversation are different, you have to input the image and question into QA-VIT for each round, which can lead to lower training and inference efficiency.
Is my statement reasonable?

Hi,
Thanks for your appreciation of our work.
In general, I think that you are right. One can mitigate this by capitalizing on the fact that we incorporate the question embedding into the ViT using late fusion, enabling storing the intermediate representations that are not question-dependent.
Additionally, while we agree that this can be a limitation compared to regular ViT in the multi-turn setting, the image encoding phase is relatively fast compared to the application of the LLM.

Thank you for your response and your great work!
In multi-turn dialogue training, the previous hidden states are stored in past-key-value for later generation. This allows the image to pass through the ViT only once, and the image token only needs to go through the LLM once. However, when using QA-ViT, the image token needs to go through the LLM n times(assuming there are n dialogue turns), and this additional time cannot be reduced.
However, these minor limitations do not detract from the fact that this article is a very good one.


Improve logging

I have updated logging on my personal branch, but now I am going to do the same for master.

Fixed with PR #18


SceneGraph InputEvent doesn't take intto account viewports when converting scene coordinates to world coordinates

The input coordinates that a node receives in onInput when using a viewport that isn't the root is still the root viewports coordinates. Need a way to determine the canvas isn't the root and convert the scene coordinates to the viewports coordinates and any nested viewports so that it always receives the correct scene and local coordinates.

Fixed in #206


Try to fix wrong visibility in docs

the ` after * not detect in docs, and flip all the next sentence

@baruchiro : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

@baruchiro Thanks! I couldn't see how your PR changes the text, but approving to see what happens. We may have a bug in our html rendering.

OK, Thanks!
I hope it will correct what is in the picture.
By the way, this is my first open source contribution.
I contributed a Space character!


Fix Laravel version compatibility and documentation error

Description
This pull request addresses an issue related to Laravel version compatibility and provides an update to the documentation for the package. Specifically, it ensures that the package is compatible with both Laravel 8 and 10.
Changes Made

Fixed a "minimum stability constraint" error that occurred when using Laravel 10.
Updated the package's composer.json file to include a "version" key for clarity and compatibility.

Thanks @alphayowakarindi !

Thanks @alphayowakarindi !

Thanks @LarsWiegers, I'm truly delighted that I could contribute to improving the wonderful docs.


Empty modules ?

Why do I see no source code in these modules ?

Ok.
How does one purchase these modules ?

Support for Binary's can be provided using EULA

Can you give details on how to use and licence these premium modules ?
Also details on how to further customize these modules and support plans  ?

Can you give details on how to use and licence these premium modules ?

Published modules are currently available on nuget.org - you can start using them right away.  Planned modules are currently in development and not available publicly on nuget yet.

Also details on how to further customize these modules and support plans ?

Issues/feature requests are tracked on this repository and support is provided based on priority of the issue and subscription level. Modules are being built considering extensibility - Feel free to add feature request, or for extensibility that you are specifically  looking for a module and will be added to to backlog for development
IM gitter: @ns8482e  for modules and licensing details


additional edits with TMB visualization and additionalFeatures

Hello Anand,
Maftools is working wonderfully and I've presented it to the lab and they love it since the updates you've made. There were just two small edits we were wondering how we could change.

When adding CNAs to the oncoplot, the section on the top shows both the ratio of mutations and also CNAs per sample. However, when representing TMB, we want only to look at the mutations per sample. Is it possible to remove the CNAs altered and only include the mutations?

When implementing the additionalFeature option to show whether a sample shows loh, it shows a white dot. Though this function works well, is it possible to increase the size of the dot to make it more visible when printed?

Hi Simon,
I am glad that the updates have been helpful. Thanks for the suggestions, I have added arguments to oncoplot function.
additionalFeatureCol and additionalFeatureCex to control color and size.
includeColBarCN for TMB in top barplot.
Also, now you can also include expression (or any sort of numeric) data as a left side bar plot.


feature/SKOOP-34

Endpoint to allow authenticated user to join an open community.
Member list of a community is not shown to a user who is not a member of the community.
@svetivanova could you please take a look?

Codecov Report

Merging #37 into master will increase coverage by 0.43%.
The diff coverage is 78.94%.

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
+ Coverage     66.65%   67.08%   +0.43%
- Complexity      596      607      +11
============================================
  Files           130      131       +1
  Lines          2180     2215      +35
  Branches         66       68       +2
============================================
+ Hits           1453     1486      +33
- Misses          672      675       +3
+ Partials         55       54       -1

Impacted Files
Coverage Δ
Complexity Δ

...s/myskills/server/community/CommunityResponse.java
95.45% <100%> (+18.31%)
19 <1> (+4)
:arrow_up:

.../community/command/CommunityCommandController.java
92.68% <100%> (+0.37%)
10 <1> (+1)
:arrow_up:

...rver/exception/CommunityAccessDeniedException.java
100% <100%> (ø)
1 <1> (?)

...ver/community/command/CommunityCommandService.java
78.72% <53.33%> (-11.91%)
8 <2> (+2)

...rver/community/query/CommunityQueryController.java
95.23% <90%> (-4.77%)
7 <6> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00bb873...d3e256b. Read the comment docs.


Documentation refers to non-existent context property - userDisplayName

The migration table shows a non-existent context property:

Please delete it. This property does not and has never existed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89e79849-bf25-dd0a-4680-c1074966051b
Version Independent ID: fee94efc-fe9c-6460-1df8-f9bc97abf526
Content: Teams JavaScript client SDK - Teams
Content Source: msteams-platform/tabs/how-to/using-teams-client-sdk.md
Service: msteams
GitHub Login: @heath-hamilton
Microsoft Alias: surbhigupta

@surbhigupta12 - Can you please remove userDisplayName entry from https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/using-teams-client-sdk?tabs=javascript%2Cmanifest-teams-toolkit#updates-to-the-context-interface


update to golang.org/x/crypto v0.31.0

Which Issue(s) this Pull Request Resolves

Resolves #716
Release Note

upgrade to golang.org/x/crypto v0.31.0 to mitigate CVE-2024-45337

Notes for Reviewers

CVE-2024-45337 was published for golang.org/x/crypto versions < v0.31.0. The fix is upgrade to a version >= v0.31.0

pulled new commits from main so I can merge

did not mean to close this


New translations v0.8.0

New translations have been added in v0.8.0 - see strings.xml for the English strings that were added - feel free to create a PR or post translations here (sorry for not pasting them directly into this issue - there were a lot of things that were added/changed and the best tool for that is the Android Studio translations editor)
I'm going to create the new release tomorrow evening (America/New_York timezone)

I do not yet get how this is supposed to work. Say, I translate the XML. If I just do this and create a PR you'd loose the original text. So there has to be a language flag or the like.

Yeah, sorry - I still need to find a good way to get community translations in. Essentially there is a folder for each language and that's where the updated files go, so if they are just sent to me I can put them in where they belong.

Essentially there is a folder for each language

Probably prepopulate that from the English XML and giving a pointer might be easy enough, if people feel comfortable editing the XML (which AFAIK can be done right on github.)
(Note that I'd be fine with a PR as well as some other tools you mentioned.)
This issue seems superseeded by #213

Closing this in favor of #213


[robin-hood-hashing] Update to 3.7.0

https://github.com/martinus/robin-hood-hashing/releases/tag/3.7.0

LGTM, thanks for the update!


Syntax for SetupApplications.ps1 example needs updating

The the Service Fabric Entra ID documentation the example for executing SetupApplications.ps1 seems to be based against an older version of the ps1 script than is currently in GitHub master
The syntax given includes the line:
-WebApplicationReplyUrl $webApplicationReplyUrl `
this should be updated to:
-SpaApplicationReplyUrl $webApplicationReplyUrl `

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 51489a2b-fef9-86d8-117e-200d81cd0694
Version Independent ID: e371c257-18cb-aead-707a-3b1eed0c30a8
Content: Set up Microsoft Entra ID for client authentication - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-cluster-creation-setup-aad.md
Service: service-fabric
GitHub Login: @tomvcassidy
Microsoft Alias: tomcassidy

@delradie
Thanks for your feedback! We will investigate and update as appropriate.

@delradie
Thanks for reporting this! We have created a PR for this issue. Once the author review has done, the changes should go live soon.


kimchi completeness

For now, kimchi is not yet finished because of something wrong in verification algorithm (from this line https://github.com/NilFoundation/crypto3-zk/blob/27-implement-pickles/include/nil/crypto3/zk/snark/systems/plonk/pickles/verifier.hpp#L160, PolishToken::evaluate returns wrong values). The one single test is generated from https://github.com/o1-labs/proof-systems/blob/master/kimchi/src/tests/ec.rs#L16 with num_doubles = num_additions = num_infs = 10. Also, it's needed to

Check lookups
Make prover(verifier) index generation (https://github.com/o1-labs/proof-systems/blob/master/kimchi/src/prover_index.rs#L148)


Find the Pth term in A.P

Feature ✅
Description
Given mth and nth term of an AP, find the pth term
Example
Format: m n  mthterm nthterm p
Input: 6 10 12 20 5
Output: 10

Hi, which language can I code in?

@pratik-choudhari I would like to work on this issue.

Sorry to say but your question is wrong. If you want to find pth term then the output should be 10 and if you want to find sum of pth terms then the answer would be 30

My mistake @ankitgoel25, sum and term sounds good!

@vedanthv Python, Java, C, C++

Hi @pratik-choudhari , this is my first time contributing to Hactoberfest and open source as well. I made a pull request for the issue in C++ language. Please review my PR and do tell me if I need to do some corrections.
Thank You

Hey I would like to code the python version of it!

I would like to code the solution for this set in JAVA.

@DevanshD3 assigned for python, @instareasy assigned for java


Can this be used to add face masks like on snapchat?

sure, I will put a demo for that case

When can I expect to see the demo?

I'll try to hurry up.

Any update?

Busy doing other things these days🌚

Please tell me there's something now, I'm very desperate for this in my project 😞

I'll do it at this weekend.

just reminding you ☺

Any update on this? Its been pretty long...

@Mako96  The FaceTracker is not so good for that case.
The demo would be much better if you know(and change to) any better one (faster & better accurate)


Add support for optional parameters

Add support for optional parameters, similar to that of https://github.com/Benvie/JavaScriptNext.tmLanguage/issues/13.

Can't see any way to support brackets & commas, due to short methods.


zplug update: Unknown error if the repo is already updated

Problem Summary
Run zplug update. Then again. You'll get Unknown errors instead of Up-to-date.
System Information

uname -a

Linux fsociety 4.4.0-57-generic #78-Ubuntu SMP Fri Dec 9 23:50:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

zsh version

zsh 5.1.1 (x86_64-ubuntu-linux-gnu)

zplug version/commit

2.4.1

Minimal zshrc
source ~/.zplug/init.zsh

zplug "modules/history",    from:prezto
zplug "modules/utility",    from:prezto
zplug "modules/ruby",       from:prezto
zplug "modules/ssh",        from:prezto
zplug "modules/terminal",   from:prezto
zplug "modules/directory",  from:prezto

zplug "zsh-users/zsh-completions", defer:0
zplug "zsh-users/zsh-autosuggestions",          defer:2, on:"zsh-users/zsh-completions"
zplug load --verbose

Steps to Reproduce

Run zplug update. Then again. You'll get Unknown errors instead of Up-to-date.

Here's the log after running zplug update: http://pastebin.com/kFq6NhbE (it's quite big, ~300kb of logs).

Try again after running rm -i $ZPLUG_REPOS/sorin-ionescu/prezto/**/.git/index.lock.

Gonna try later but I doubt it will work. Prezto modules are in the same git folder and when you're trying to update them async, there are multiple git processes running in the same context (prezto folder) so them conflicts with each other. Since there are no plugins that lives in the same folder like prezto modules (each plugin uses its own folder), I think you should add some sort of smart prezto update.

Yeah I were right - there's no index.lock file after zplug update.

Same error here. After zplug update, no index.lock file exists.
But every plugin shows:
[zplug] Start to update 15 plugins in parallel

 ✘  Unknown error         lukechilds/zsh-nvm
 ✘  Unknown error         zsh-users/zsh-completions
 ✘  Unknown error         ~/.zsh
 ✘  Unknown error         junegunn/fzf-bin
 ✘  Unknown error         plugins/docker
 ✘  Unknown error         modules/ssh
 ✘  Unknown error         lukechilds/zsh-better-npm-completion
 ✘  Unknown error         bhilburn/powerlevel9k
 ✘  Unknown error         jimeh/zsh-peco-history
 ✘  Unknown error         zsh-users/zsh-syntax-highlighting
 ✘  Unknown error         b4b4r07/enhancd
 ✘  Unknown error         zplug/zplug
 ✘  Unknown error         peco/peco
 ✘  Unknown error         plugins/git
 ✘  Unknown error         jreese/zsh-titles

[zplug] Elapsed time: 11.6030 sec.
 ==> Updating finished successfully!

trace file shows plenty of:
{"pid":4457,"shlvl":1,"level":"ERROR","dir":"/home/<user>/.zplug/repos/b4b4r07/enhancd","message":"fatal: Unable to create '/home/<user>/.zplug/repos/b4b4r07/enhancd/.git/index.lock': File exists.\n\nAnother git process seems to be running in this repository, e.g.\nan editor opened by 'git commit'. Please make sure all processes\nare terminated then try again. If it still fails, a git process\nmay have crashed in this repository earlier:\nremove the file manually to continue.","trace":["__zplug::log::capture::error:8","__zplug::utils::git::checkout:45","__zplug::core::cache::plugins:10","__load__:52","__zplug::core::core::run_interfaces:14","zplug:12","/home/<user>/.zshrc:25","zsh:0"],"date":"2017-01-15T11:28:35+0100"}

I can't really see anything else than "Unknown error" since I installed zplug for the first time today. Seems though, as if zplug actually works despite it.

zplug update works for me, but I am getting "unknown error" with zplug status.

I'm not able to reproduce the issue anymore.

@Defman21 can you tell use, what you have done?
This error still exists for me

cd ~/.zplug && git pull --rebase origin master
Zplug version: 2.4.1
Git version: 2.11.1
uname -a: Linux fsociety 4.4.0-62-generic #83-Ubuntu SMP Wed Jan 18 14:10:15 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

This is ZSH 5.1.1 - zplug 2.4.1 - DISPLAY on :1

╭─ xxxx@xxxx   ~/xxxxx     master                                                                               ✓  100% 🔋  0.78    4893  19:36:19
╰─ zplug update
[zplug] Start to update 20 plugins in parallel

 ✘  Unknown error         lukechilds/zsh-nvm
 ✘  Unknown error         plugins/cp
 ✘  Unknown error         zsh-users/zsh-completions
 ✘  Unknown error         ~/.zsh
 ✘  Unknown error         junegunn/fzf-bin
 ✘  Unknown error         modules/ssh
 ✘  Unknown error         modules/rsync
 ✘  Unknown error         lukechilds/zsh-better-npm-completion
 ✘  Unknown error         bhilburn/powerlevel9k
 ✘  Unknown error         zsh-users/zsh-syntax-highlighting
 ✘  Unknown error         b4b4r07/enhancd
 ✘  Unknown error         plugins/z
 ✘  Unknown error         b4b4r07/zsh-gomi
 ✘  Unknown error         molovo/revolver
 ✘  Unknown error         k4rthik/git-cal
 ✘  Unknown error         plugins/extract
 ✘  Unknown error         zplug/zplug
 ✘  Unknown error         andrewferrier/fzf-z
 ✘  Unknown error         jreese/zsh-titles
 ✘  Unknown error         git-time-metric/gtm-terminal-plugin

[zplug] Elapsed time: 3.5270 sec.
 ==> Updating finished successfully!

uname -a: Linux xxxx 4.4.0-59-generic #80-Ubuntu SMP Fri Jan 6 17:47:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Your git version?

╰─ git --version
git version 2.11.0

Weird.

I have no problems on a fedora system with git version 2.9.3

Hey, guys.
Same happening here.
There is no .lock file and the solution provided from @Defman21 did'n work for me.
Any other ideas?
Thanks ;).

I had the same problem.
In my case, the unknown errors happened with both zplug update and zplug install.
I have solved the problem by install gawk.

I was having this problem just today and the solution from @youxkei to install gawk seems to have solved this for me

Thanks @youxkei!

@youxkei Thanks

@youxkei Thanks.
Solves my problem in Debian testing today.

@youxkei  thanks, solves the annoying problem in Debian stretch

zplug really should report that it is missing gawk instead of "unknown error"

many many thanks!

Installing gawk solves the problem though I do not know why :😂


Update to latest PouchDB tests and fix test failures

PouchDB has changed a bit since this code was written, so we need to update the tests. I also copied the tests into this repo, so we can have a stable target to test against.

Cool, okay, https://travis-ci.org/nolanlawson/worker-pouch/builds/105936578 passed, but it sure too awhile. Breaking into more tests.

This is passing.


issue-88: fix Extension type element not generated as List with max cardinality of '*'

Summary
Fixes issue #88

Added JUnit tests

@karthisuku, @amarvakul

Merged !


Microservices: Unexpected behaviour of Hasher & HashProcessor

Code Version
Satosa 8.2.0 (docker), running an saml2 frontend and oidc backend, proxy from OIDC to SAML
Expected Behavior

(1) Hasher and HashProcessor produce the same hash values (under the same input circumstances)
(2) Hasher and HashProcessor can produce a hash value of attribute values which came from primary identifier processor

Current Behavior
(1) Hasher and HashProcessor, e.g.

same input string, e.g.: 2b27510c-6297-311b-7004-ab7113390135
same salt, e.g.: qiAUwGorlHrKjbWSB68ZIelO7KC6VrZQ8wpoEVdzPb1D9ZhD
same hash alg, e.g.: sha224
but: Hasher and HashProcessor, both configured to hash that attribute containing the input string value, produce different output values (of course they were not used at the same time but tested separately) [this could be due to internals, e.g. prepending vs. appending salt, using different libs etc.]

(2) Trying to hash an attribute, which was scoped and generated by the processor "primary identifier", return unexpected results:

(2.1) HashProcessor: fails with type error

satosa|   File "/usr/local/lib/python3.11/site-packages/satosa/micro_services/attribute_processor.py", line 60, in process
satosa|     instance.process(data, attribute, **kwargs)
satosa|   File "/usr/local/lib/python3.11/site-packages/satosa/micro_services/processors/hash_processor.py", line 31, in process
satosa|     attributes[attribute][0] = value_hashed
satosa|     ~~~~~~~~~~~~~~~~~~~~~^^^
satosa| TypeError: 'str' object does not support item assignment

(2.2) Hasher: produces multiple hashed strings as output values, seperated with a semicolon, some of those are identical, some differ

Possible Solutions
(1) Align Hasher / Hashprocessor outputs with preserved backwards compatibility, e.g.  by providing a new parameter to align hash functions (rewrite/align/split internal hashing processes)
(2) There might be a fix for the "primary identifier" processor (which might be the root cause of that issue) - otherwise a fix for Hasher and HashProcessor could be provided
Workarounds
Of course own / modified / custom modules could be written. But usually I try to find a way with default functions.
(1) Use either or, not both. The issue is that Attribute Processor > HashProcessor cannot update/modify subject_id. In the microservice "hasher" the subject_id can be hashed as well among with the attributes. The HashProcessor seem only to be able to hash attributes from the internal map (I might be wrong here and would love to get feedback on that matter).
(2) Do not hash the target attribut produced from "primary identifier" with Hasher microservice but with AtributeProcessor > HashProcessor. There you could use "ScopeProcessor" appending an arbitrary string before hashing with the HashProcessor. This is a workaround as HashProcessor would fail otherwise.
Steps to Reproduce
(1)

Hash an input string with hasher and hashprocessor, using the same input string, salt and algorithm, compare outputs

(2)

Use microservice "primary identifier" with add_scope "issuer_entityid", e.g. producing '2b27510c-6297-311b-7004-ab7113390135https://host/oidc/auth', e.g. let the micrososervice place the generated identifier in attribute 'uid'
Then use Hasher or HashProcessor to hash the 'uid' to see results mentioned above

Hi, I think there is an assumption that those two micro-services should work the same way, but that is not true.

The HashProcessor seem only to be able to hash attributes from the internal map (I might be wrong here and would love to get feedback on that matter).

The Attribute Processor is about processing attributes. The subject_id element corresponds to the SAML Subject/NameID element value, which is not an attribute.

Use either or, not both.

It depends on what you are trying to achieve. Each has its place and its own behaviour. If you want to combine them, you can also do that. It all depends on your use case.
It is certain that they don't behave in the same way.

Thanks for having a look into this.
I'll dig a bit deeper:
This is also related to federational use cases with best practices for identifier migration and support in mind. Also I think this does not explain the mentioned errors related to processing the primary_identifier attribute, described in (2); (2.1); (2.2), this should not happen in the first place I guess.
Example use case (not exactly the same as the one I'm trying to achieve, but for relevance/illustration purposes):

Let's say SATOSA generates the SAML2 Name ID with Hasher from some input

Let's say SPs uses / used the persistent-id / SAML2 Name ID or [eduPersonTargetedID] (https://wiki.refeds.org/display/STAN/eduPerson+2020-01#eduPerson202001-eduPersonTargetedID) to identify a user (which are all deprecated)

A best practice, with migration purposes in mind, would be to use the same generated SAML2 Name ID and construct the SAML2 pairwise id attribute with it (e.g.  name id + scope), which is a replacement for the previously mentioned identifiers

But:

This would require you to construct the pairwise id with the same output results from the SAML2 Name ID generated by Hasher in this case;
The value cannot be optained from an attribute hashed by Hasher (as hashing the attribute fails, see 2);
The hashing cannot be reproduced in attribute processor (as hash processor delivers a different output);
If I use the same hash algorithm sha512 with the same salt at least I expect the functions to produce the same outputs, especially within satosa - but maybe thats just me; the errors described in (2) stop resolving this issue otherwise, e.g. not using attribute processor to hash but hasher itself for attributes

default limitations (without modifications / extensions / custom processors):

attribute processor cannot scope with issuer_entityid
(primary identifier is used for that and for detecting the input attribute of choice)
SAML2 Name ID value is not available in attribute processor (neither as target nor as source)
hashing a generated primary_identifier attribute in Hasher fails (see 2, especially 2.2)

At least the second part (2) should be considered a bug I guess
(if I did not do anything else wrong)

Identifier migration means that the value that used to be released to some attribute will now be released as the value of one or more additional attributes. Then, after some time, the old attribute may stop being released.
The easiest way to do this is to copy the value of one attribute to the other attributes that should have the same value.
The Hasher and the HashProcessor are different things. They work in a different way. You should not expect them to do the same thing. If they were identical we would not need both.

Having said this, (2) does sound problematic but it is a separate issye.
By (2) I am referring to:

(2) Trying to hash an attribute, which was scoped and generated by the processor "primary identifier", return unexpected results:

It looks to me that the primary_identifier plugin has a bug here:
https://github.com/IdentityPython/SATOSA/blob/754dcc2/src/satosa/micro_services/primary_identifier.py#L259
instead of setting the value directly, it should set it as the only element of a list.
-            data.attributes[primary_identifier] = primary_identifier_val
+            data.attributes[primary_identifier] = [primary_identifier_val]

Then, both issues mentioned with the Hasher and the HashProcessor should go away.
Can you make this change locally and confirm?

Any update on this @github-canni ?


Invalid target aggregation and index are accepted in Add Fragment dialog

Fix for #1513.

Changes ComboBox to Select control.

@zdravko-georgiev The newly created PR still has the problem with CLA..

@nikmace This commit is causing the CLA check to fail. If you create a new branch and cherry-pick all commits, but this one. The CLA check will pass. You can omit also the merge commits 😉


[Print deviation]  When pdf file has vertical page  and horizontial page at same time...

Link to PDF file (or attach file here):
Muli-size.pdf
Configuration:

Web browser and its version: Chrome 56.0.2924.87
Operating system and its version: window 7
PDF.js version: pdfjs V1.7.225
Is an extension:

Steps to reproduce the problem:

Open file in online website

2.Click print button to preview , deviation is happened

What is the expected behavior? (add screenshot)
When preview/print multiple size pages in a pdf file, want normal display/ print.
->pdfjs v1.6.210 has not same problem...
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Use another server  method already Solved it…
I am weak in javascript programming...but really hope pdf.js can clear it!
■server  method:
############################################
1.Add new print button overlay originally  print button
2.when click print button,kick off  a ajax communication with server
for check  this pdf file  have  vertical  and horizontal page
3.if not have,trigger originally  print event
4.if have,use server process(like Java/PHP...etc) to split pdffile to two files
(※one is all vertical  pages,another is all horizontal  pages )
5.popup new small window with pdf.js  to load splited file and auto print it
############################################

Fixed by PR #13120.


Use output text field as dynamic title instead

when the model changes, instead of changing output value in box, change a title above the chat dialogue container

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Twitter bridge - title and content, it's the same text, and it shouldn't be

Is your feature request related to a problem? Please describe.
Twitter doesn't have titles, so typing the entire twitt into both the title and the content is weird.
Clutters the RSS feed, prolongs scrolling.
Describe the solution you'd like
Twitter bridge option:
"Don't put twitt in the title (optionally add a short placeholder with e.g. twitt date)"
or/and
"Don't put twitt in the content"
Describe alternatives you've considered
Nothing can be done.
Additional context
Add any other context or screenshots about the feature request here.

@lukaszpolowczyk Can you give an example of what the feed item title should be?

@dvikan "Can you give an example of what the feed item title should be?"

E.g., the original date of the tweet.

E.g. The status id of the tweet.
It is important that it takes up as little space as possible. It is important that it does not clutter.

I have added an optional parameter in TwitterV2Bridge to use the Tweet ID as the Title. See PR #2612


macOS binary of releae 0.11.0 is only 130 bytes

The binary is only holding the top level directory without any files in it.
Please upload a full release, thank you.

Thanks for the heads up!.
On this release, we added the integration with bblfsh to generate ASTs from source code, and it contains some cgo bindings. We are working to cross-compile that automatically from the CI.
Meanwhile, you can obtain the binaries from source: https://github.com/src-d/gitbase#installing-from-source

I kind of depend on binaries ....

I just uploaded a 0.11 binary release for macOS. Let me know if you have any other issues with it.


Principled subst determination with re-exported Dict module

substituting let variables need some analysis on the nature of the target expressions. Especially, if the expression is Dict type, then we need to have special cares. Unfortunately, Dict can come from different modules from re-export and there are no easy ways to check the equality of those definitions. So in 15465, we have hard-coded two modules Data.Constraint and Barbies.Internal,Dicts, but some other cases may happen in the future, so this should be handled correctly.This may require some change in the ordering of our categorization steps and further module export analysis. So we want to postpone the work until when the approach becomes more clear.
AC:
No more hard-coded re-exported module check in isDictOrBarbiesDictTyCon but detecting such re-export in general way.
(Extricated from https://kitty-hawk.atlassian.net/browse/SW-3418)

Would it be possible to somehow apply Client.Rep and check that type? Barbies.Dict (and any other Dict-like that appears) should have Constraint.Dict as its Rep.
Also, point of clarity – Barbies.Dict isn't a re-export. They're different, roughly
ConstraintDict :: a => ConstraintDict a
BarbiesDict :: c a => BarbiesDict c a

An actual re-export should be trivially seen as Constraint.Dict.


navbar

Version info

Milligram:
Other (e.g. normalize.css, node.js, npm, bower, browser, operating system) (if applicable):
Test case

Steps to reproduce

Expected behavior

Actual behavior

What is the problem with navbar, can I work on it.


circular_source_labels?

There is an instance in our code examples in mne/simulation/source.py of circular_source_labels. I'm not sure where it comes from, since we don't have such a function. If anyone knows please say so. Otherwise I'll do some git blame work to track it down when I find time.

cc @nfoti found this one

@nfoti are you on it?

I'm happy to try to add it.

Apparently back in 2012 (!) we actually had such a function, which I found using blame on GitHub:
https://github.com/mne-tools/mne-python/commit/5e66a3890b851ca4ab6184d830579cb817ca8869
It looks suspiciously like grow_labels, so I suspect it's just a renaming that we missed:
https://github.com/mne-tools/mne-python/blob/5e66a3890b851ca4ab6184d830579cb817ca8869/mne/simulation/source.py#L259

Found it -- back in 2012 someone not-to-be named (hint: last name rhymes with shamdort) refactored circular_source_labels to grow_labels but must have missed a reference in the docstring, probably because the docstring wasn't written properly in the first place to execute as a doctest:
https://github.com/mne-tools/mne-python/commit/4c12dd9b60ec08690cb7b98a1bb15bc9a97b27c0

Found it -- back in 2012 someone not-to-be named (hint: last name rhymes
with shamdort) refactored circular_source_labels to grow_labels but must
have missed a reference in the docstring

naughty  shamdort....

It doesn't look like the docstring of grow_labels needs changing, I think you mean the docstring of simulate_stc. I'm not certain that grow_labels can be used though since it doesn't seem to actually fill in the value field of the generated Label (I could be mistaken about this though). I could add in an example that uses the new Label.center_of_mass function that will select the vertex closest to the center of mass. Basically the following, given a Label called label:
com = label.center_of_mass('sample', surf='white')
label.values = np.zeros_like(label.values)
label.values[np.where(label.vertices == com)[0][0]] = 1

I think you mean the docstring of simulate_stc

Yeah wherever had the circular_source_labels reference.

I'm not certain that grow_labels can be used though since it doesn't seem to actually fill in the value field of the generated Label (I could be mistaken about this though).

Ahh right, because you need it to be the distance away from the original seed? I think for filling in the values afterward you'll need to use dijkstra from SciPy manually. I can't think of a clean API to offer for the users that would see enough use to include it. It would be nice in an example, though.

Agreed. Do we just want to remove the reference to circular_source_labels from the simulate_stc docstring and close this?
The point spread example I'm writing for #3308 can demonstrate how to use the values in labels in simulate_stc as well as the new center mode for simulate_sparse_stc.

Yeah, please fix the docstring as part of your example, I forgot to do it.


React 16.3 doesn't like componentWillMount lifecycle hook

What version of React-Table are you using?
6.8.2
What bug are you experiencing, or what feature are you proposing?
I am using React 16.3 and they are going to deprecate the componentWillMount lifecycle hook in favor of either UNSAFE_componentWillMount or the new lifecycle methods. This creates arrors in the console saying to stop using componentWillMount, but I'm not using it outside of this library.
What are the steps to reproduce the issue?

make a basic app wih react 16.3 and react-table
look at the console errors

more info here:
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

We are aware of the changes and there are no current plans to retro fit the existing version.  @tannerlinsley is looking at a full refactor of ReactTable and it will happen during that process.

Closing due to issue age. If this issue was a question, please ask it again on https://spectrum.chat/react-table. If you think this issue needs to be reopened or if it should be turned into a pull-request, please check the latest version of React-Table for the issue or feature once more and reopen or create a PR if appropriate. Thanks!

https://fb.me/react-strict-mode-warnings

React Table doesn't use classes or lifecycles anymore. If you're using an older version that does, then you'll need to either upgrade or fork and fix

@tannerlinsley do you mean 7.0 (which is in alpha) doesn't use lifecycles? Because 6.10 definitely uses lifecycles.

https://github.com/tannerlinsley/react-table/blob/v6/src/lifecycle.js

Correct. V6 is EOL
On Aug 9, 2019, 1:02 PM -0600, GÁBOR Áron Zsolt<EMAIL_ADDRESS>wrote:

https://github.com/tannerlinsley/react-table/blob/v6/src/lifecycle.js
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks @tannerlinsley! :-)


Bad TPS

When using your plugin, the TPS server very often jumps.
Version: 1.19.2. Pufferfish
Spark Profiler: https://spark.lucko.me/x4xwvRF3aZ
Link: https://prnt.sc/Ejk-z2cc77J2

This is known - the plugin is much slower than vanilla. To minimise the problem, try to pregenerate and enforce a world border


python-jsonrpc-server: make version overridable

Motivation for this change
The way the version attribute was inserted into the postPatch script prevented it from being overridden via overrideAttrs or overridePythonAttrs. It would still use the original definition instead of the overridden one.
Things done
replace nix-based string substitution with bash-based string substitution

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Can we merge this also into 20.03?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/367

We can backport it if you open a PR.


Simplified environment file

Description
Nowadays the environment files you get after generating the Django skeleton with this cookiecutter-django is sometimes too much complex. Most of the times you end up with a folder per environment with folders with a environment file per Django app and another for the database inside. In some cases is more comfortable to have just an environment file in the root of the project to handle all the environment variables.
Rationale
For small projects and even the ones you don't need to configure a database with environment file it feels too much to handle and you end up deleting all the environment structure dumped by this cookiecutter to switch it to the file mentioned in the Description section to have it simplified.
Use case(s) / visualization(s)
I see this could be handled during the questions asked in the cookiecutter console prompt. A quiestion like this could be added to the cookiecutter.json file:

"simplified_environment_file": "n",

Then have the simple environment file or the current structure is nowadays.
Do you have this in the development road map? Are you open on having PR on this matter?

After reading again the documentation (https://cookiecutter-django.readthedocs.io/en/latest/deployment-with-docker.html) is everything clear. I'm going to close this issue


Variability in response times in a mixed cpu+io-bound application. Any way to improve ?

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
None

Description
We have a data intensive application exposed through FastAPI. Most endpoints do a mix of io-bound and cpu-bound work.
The whole app is using async clients to the datastores (asyncpg, aioredis), so it's coded in async all the way up to the endpoints.
It's deployed in bunch of containers behind a load-balancer (AWS ECS), so, following fastapi docs, we opted for uvicorn with 1 worker per container.
We notice a quite high variability in response time, and especially what seems to be "waiting times".
When the response time is short, the profile looks like this:

That is, the overall response time is a few ms more than the query time, so it's all good.
For some other calls, the profile looks like this:

The overall response time is much longer than the longuest query, there are much more waiting time, especially at the beginning of the call, where there's essentially no work at all (any cpu-bound work comes after the sql response).
(Note: I'm just picking 2 examples on a fairly simple endpoint, but we have more complex endpoints with many DB calls, and the same pattern emerges, with waiting time popping here and there)
My understanding so far is that what looks like waiting time is just work being done on other concurrent requests. And we're just hitting the limits of the GIL-based archi of python and async behavior.
Is this understanding correct ?
From other issues I read, there may be some things to test, but I'm unsure:

changing to gunicorn with n workers, to reduce the concurrency within the process ?
isolate the cpu-bound work from the main thread. What would be the better ? wrapping the identified bottlenecks in run_in_threadpool ? or outright force the use of another thread at endpoint start ?

Anything else ?
Are there any recommendation to improve the situation ?
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.78.0
Python Version
3.9.13
Additional Context
No response

My understanding so far is that what looks like waiting time is just work being done on other concurrent requests. And we're just hitting the limits of the GIL-based archi of python and async behavior.
Is this understanding correct ?

It very well could be, but it is impossible to firmly confirm nor deny without all the data.

changing to gunicorn with n workers, to reduce the concurrency within the process ?
isolate the cpu-bound work from the main thread. What would be the better ? wrapping the identified bottlenecks in run_in_threadpool ? or outright force the use of another thread at endpoint start ?

Running in K8S (which ECS basically is) means finetuning. There is not a single silver bullit, there are a few issues raised about this in this repo. I remember one guy doing some testing and he came to multiple workers per container, and multiple containers behind a LB for best performance. More workers (if they don't share the CPU cycles of course) would improve concurrency and reduce waiting time (if there is any right now!).
Isolating your CPU bound work from the main thread would not be helpful I guess. Any task running in a thread is bound by the same event loop and GIL, so it wouldn't make a lot of difference.
I'd guess you'd have to figure out if it really is waiting time because some other task is currently executing for another request. If that is the case, I would recommend starting with a bit more scale horizontally (e.g. more workers, either by increasing the amount of containers or increasing the amount of workers per container).

We faced a very similar issue, which forced us to completely migrate to synchronous routes (to contain production issue) as we spent time on tuning our deployment to support async properly.
Here are somethings we did:

We used base docker image of python and ran as per the examples given in FastAPI docs. - one worker per container.

We had our load balancer and HPA set up in Kubernetes.

We implemented health check APIs and configured auto restart for our pods.

Made sure there's absolutely no blocking code in Python. Even made our logger asynchronous.

Made sure we did not introduce memory leaks, connection leaks to DBs, increased session reusablity.

We made sure our middleware and dependency are async.

By performing above activities we were able to get predictable results with waiting time only increasing if all pods reach its maximum.
One issue we still face is, certain pods becoming unresponsive at times, which Health check API finds and restarts.
Finally an understanding which I got (may be wrong): Async never means parallel rather it's concurrent. And it's not guaranteed that you won't have wait times. Wait times begin to surface when enough tasks are scheduled to run on a thread.


change "crypt.." error into something more meaningful

and at the same time while in the errors file, there's a typo: "cannot decrypy empty string"


Add Ability Score Modifier fields to Ability Scores

Hello. I love the OSE Roll20 sheets, great work.
I'd like to see separate fields for modifiers in the Ability Scores sections.
For example:
STR 12 (0)
INT 17 (+2)
WIS 8 (-1)
DEX 10 (0)
CON 15 (+1)
CHA 18 (+3)
Many of my players are new to OSE / D&D and don't have these modifier ranges memorised, causing confusion and delay when I ask them to add their Ability Score modifier to a certain roll.
Cheers,
Paul.

Hey Paul, this would be easily done, but most of these modifiers are automatically applied (or shown) where applicable. Is it just a matter of giving your players an idea of how they translate into modifiers or are you using them for something?

Hey Paul, this would be easily done, but most of these modifiers are automatically applied (or shown) where applicable. Is it just a matter of giving your players an idea of how they translate into modifiers or are you using them for something?

Hey Wes, thanks for getting back to me.
In my OSE game, I often use '2d6 + ability score modifier' rolls for checks, rather than '1d20 roll under ability score'. If the modifier was present on the character sheet, it would allow the newer player to make that 2d6 + ability score modifier roll themselves without asking my input.
For example, in my Stonehell game recently, a Dwarf PC was trying to sweet-talk a Kobold work-crew leader. I asked him to roll 2d6 + CHA modifier. He didn't quite understand, rolled boxcars, added his CHA of 8, and told me that he got a 20!
Cheers,
Paul.

Hey Wes, thanks for getting back to me.
In my OSE game, I often use '2d6 + ability score modifier' rolls for checks, rather than '1d20 roll under ability score'. If the modifier was present on the character sheet, it would allow the newer player to make that 2d6 + ability score modifier roll themselves without asking my input.
For example, in my Stonehell game recently, a Dwarf PC was trying to sweet-talk a Kobold work-crew leader. I asked him to roll 2d6 + CHA modifier. He didn't quite understand, rolled boxcars, added his CHA of 8, and told me that he got a 20!
Cheers,
Paul.

FYI I'm not asking for you to program a 2d6 + ability score modifier function built-into the character sheet itself. Just having the modifier displayed would allow players to manually roll 2d6 + modifier.

FYI I'm not asking for you to program a 2d6 + ability score modifier function built-into the character sheet itself. Just having the modifier displayed would allow players to manually roll 2d6 + modifier.

No worries, I understand what you’re asking for 😄 and it makes sense. I’ll add it shortly. Shouldn’t be too tough.

No worries, I understand what you’re asking for 😄 and it makes sense. I’ll add it shortly. Shouldn’t be too tough.

Thank you, Wes. Have a nice day.

Thank you, Wes. Have a nice day.


Create Leaf component for Text component

I did look into putting this code into a plugin, but plugins are a way of editing the Editor and rendering is done by Editable.  After reading through the source/doc I don't think this is possible, but it also doesn't seem like a big loss.

@migueloller I thought I would throw this up. I am pretty confident in it, but I wanted to keep you in the loop about how I am imagining renderElement will look, and also just call out the comments above.


Error when compile

I just included bun.hpp
#include "blib/bun/bun.hpp"
and I try to compile it, but I get error:
blib/bun/impl/orm.hpp:1995:20: error: ‘type_conversion’ is not a class template
             struct type_conversion<SimpleObjHolder<T>> {
                    ^~~~~~~~~~~~~~~
blib/bun/impl/orm.hpp:1995:36: error: ‘SimpleObjHolder’ was not declared in this scope
             struct type_conversion<SimpleObjHolder<T>> {
                                    ^~~~~~~~~~~~~~~
blib/bun/impl/orm.hpp:1995:36: note: suggested alternative:
blib/bun/impl/orm.hpp:415:20: note:   ‘blib::bun::__private::SimpleObjHolder’
             struct SimpleObjHolder {
                    ^~~~~~~~~~~~~~~
blib/bun/impl/orm.hpp:1995:20: error: ‘struct blib::bun::__private::type_conversion’ redeclared as different kind of symbol
             struct type_conversion<SimpleObjHolder<T>> {
                    ^~~~~~~~~~~~~~~
blib/bun/impl/orm.hpp:1944:20: note: previous declaration ‘template<class T> struct blib::bun::__private::type_conversion’
             struct type_conversion {
                    ^~~~~~~~~~~~~~~
blib/bun/impl/orm.hpp:1995:53: error: expected unqualified-id before ‘>’ token
             struct type_conversion<SimpleObjHolder<T>> {
                                                     ^~
blib/bun/impl/orm.hpp:2105:14: warning: extra ‘;’ [-Wpedantic]
             };
              ^
blib/bun/impl/orm.hpp:2114:12: error: ‘type_conversion’ is not a class template
     struct type_conversion<blib::bun::__private::SimpleObjHolder<T>> {
            ^~~~~~~~~~~~~~~
blib/bun/impl/orm.hpp:2114:67: error: conflicting declaration of template ‘template<class T> struct soci::type_conversion’
     struct type_conversion<blib::bun::__private::SimpleObjHolder<T>> {
                                                                   ^~
In file included from /usr/local/include/soci/exchange-traits.h:11:0,
                 from /usr/local/include/soci/into-type.h:13,
                 from /usr/local/include/soci/blob-exchange.h:12,
                 from /usr/local/include/soci/soci.h:18,
                 from /home/mike/Documents/PROJECTS/C/blib/bun/impl/DbBackend.hpp:9,
                 from blib/bun/impl/orm.hpp:41,
                 from blib/bun/bun.hpp:3,
                 from main.cpp:12:
/usr/local/include/soci/type-conversion-traits.h:19:8: note: previous declaration ‘template<class T, class Enable> struct soci::type_conversion’
 struct type_conversion
        ^~~~~~~~~~~~~~~
In file included from blib/bun/bun.hpp:3:0,
                 from main.cpp:12:
blib/bun/impl/orm.hpp:1900:48: warning: ‘blib::bun::{anonymous}::unique_constraint’ defined but not used [-Wunused-variable]
             static blib::bun::UniqueConstraint unique_constraint;
                                                ^~~~~~~~~~~~~~~~~
In file included from /home/mike/Documents/PROJECTS/C/third_party/spdlog/formatter.h:44:0,
                 from /home/mike/Documents/PROJECTS/C/third_party/spdlog/sinks/base_sink.h:14,
                 from /home/mike/Documents/PROJECTS/C/third_party/spdlog/logger.h:15,
                 from /home/mike/Documents/PROJECTS/C/third_party/spdlog/spdlog.h:14,
                 from /home/mike/Documents/PROJECTS/C/blib/bun/impl/DbLogger.hpp:11,
                 from /home/mike/Documents/PROJECTS/C/blib/bun/impl/DbBackend.hpp:11,
                 from blib/bun/impl/orm.hpp:41,
                 from blib/bun/bun.hpp:3,
                 from main.cpp:12:
/home/mike/Documents/PROJECTS/C/third_party/spdlog/details/pattern_formatter_impl.h:148:27: warning: ‘fmt::MemoryWriter& nlohmann::detail::pad_n_join(fmt::MemoryWriter&, int, int, int, char)’ defined but not used [-Wunused-function]
 static fmt::MemoryWriter& pad_n_join(fmt::MemoryWriter& w, int v1, int v2, int v3, char sep)
                           ^~~~~~~~~~
/home/mike/Documents/PROJECTS/C/third_party/spdlog/details/pattern_formatter_impl.h:141:27: warning: ‘fmt::MemoryWriter& nlohmann::detail::pad_n_join(fmt::MemoryWriter&, int, int, char)’ defined but not used [-Wunused-function]
 static fmt::MemoryWriter& pad_n_join(fmt::MemoryWriter& w, int v1, int v2, char sep)
                           ^~~~~~~~~~
In file included from /home/mike/Documents/PROJECTS/C/third_party/spdlog/formatter.h:44:0,
                 from /home/mike/Documents/PROJECTS/C/third_party/spdlog/sinks/base_sink.h:14,
                 from /home/mike/Documents/PROJECTS/C/third_party/spdlog/logger.h:15,
                 from /home/mike/Documents/PROJECTS/C/third_party/spdlog/spdlog.h:14,
                 from /home/mike/Documents/PROJECTS/C/blib/bun/impl/DbLogger.hpp:11,
                 from /home/mike/Documents/PROJECTS/C/blib/bun/impl/DbBackend.hpp:11,
                 from blib/bun/impl/orm.hpp:41,
                 from blib/bun/bun.hpp:3,
                 from main.cpp:12:
/home/mike/Documents/PROJECTS/C/third_party/spdlog/details/pattern_formatter_impl.h:76:12: warning: ‘int nlohmann::detail::to12h(const tm&)’ defined but not used [-Wunused-function]
 static int to12h(const tm& t)
            ^~~~~
/home/mike/Documents/PROJECTS/C/third_party/spdlog/details/pattern_formatter_impl.h:71:20: warning: ‘const char* nlohmann::detail::ampm(const tm&)’ defined but not used [-Wunused-function]
 static const char* ampm(const tm& t)
                    ^~~~
In file included from /home/mike/Documents/PROJECTS/C/third_party/spdlog/spdlog.h:13:0,
                 from /home/mike/Documents/PROJECTS/C/blib/bun/impl/DbLogger.hpp:11,
                 from /home/mike/Documents/PROJECTS/C/blib/bun/impl/DbBackend.hpp:11,
                 from blib/bun/impl/orm.hpp:41,
                 from blib/bun/bun.hpp:3,
                 from main.cpp:12:
/home/mike/Documents/PROJECTS/C/third_party/spdlog/common.h:81:20: warning: ‘spdlog::level::short_level_names’ defined but not used [-Wunused-variable]
 static const char* short_level_names[] { "T", "D", "I", "W", "E", "C", "O" };
                    ^~~~~~~~~~~~~~~~~
/home/mike/Documents/PROJECTS/C/third_party/spdlog/common.h:79:20: warning: ‘spdlog::level::level_names’ defined but not used [-Wunused-variable]
 static const char* level_names[] { "trace", "debug", "info",  "warning", "error", "critical", "off" };
                    ^~~~~~~~~~~
<builtin>: recipe for target 'main' failed
make: *** [main] Error 1

I am trying it on ubuntu 18.04.
Makefile content:
LDFLAGS := -L/usr/local/lib -L/home/mike/Documents/PROJECTS/C/libs/socket \
-I/home/mike/Documents/PROJECTS/C/third_party/unqlite -I/home/mike/Documents/PROJECTS/C -I/home/mike/Documents/PROJECTS/C/third_party
LDLIBS :=  -lchilkat-9.5.0 -lpthread -lresolv -lsocket
EXECUTABLE := main
CXXFLAGS=-g -std=c++17 -Wall -pedantic

all: $(EXECUTABLE)

clean:
	rm -f $(EXECUTABLE) *.o

gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)
To compile program I just execute make command inside source folder.
I am newbie in C and  most of all it is problem not related to bun.. Probably my compiler is not right version ?

Can you tell me the compiler version you are using?


Add support for Tahoma consommation sensor

5 electrical sensors provide the electrical usage
1 climate component allows the user to force the heating off.
Description:
Implementation of Tahoma electrical module (implemented from a module manufactured by Atlantic)
provide the electrical sensors output
allow to override the heat pump to disable heeating.
Pull request in home-assistant.github.io with documentation (if applicable):
home-assistant/home-assistant.github.io#5150
Example entry for configuration.yaml (if applicable):
nothing
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Changed the  polling time from the server from 10 seconds to 10 minutes. 10 secs seems a very low value for a non-local server.

If the code communicates with devices, web services, or third-party tools:

No new dependencies

If the code does not interact with devices:

N/A (interracts with devices)

The climate platform requires documentation.

@fabaff Documentation was added and reviewed.

I would suggest removing the scan interval from the sensor document. A 60x increase seems like way too much for people who were using tahoma sensors before.

Yes, tahoma does indeed support getting every device status in 1 request. This is something that should be implemented and would fix lots of issues with tahoma. I don't have the time to do this unfortunately.

I can try to code that. How would you imagine that ? I would do :

Every device would add itself to a central list in the plateform, with a last update time
On a device update,
-- if the update time is too old, get the whole list and update everything, update the last update time
-- if the last update is recent enought, get the update status for this component without requesting the plateform

If that suits, I'll try to do that this month.

I'm not sure, maybe a maintainer can give some insight on how this should be done. self.controller.get_states([self.tahoma_device]) is the function that does the updating, and it supports an array, but currently we only pass 1 device every time.

Wrap the Tahoma api instance in a data class that has a method to get the state of all current devices. Add a throttle to this method. Call the method from each entity update method.

Is this PR still alive?

Not much... I need to take some time to try to provide a final fix for that, but my hassio raspi has turned dead...

Could you add "WIP" to the title and remove the indicator if you are done? Thanks! :-)

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


core/typesetter.lua: treat leading tabs as spaces in .sil

I like to indent lines within environment blocks, and typically indent using tabs. In LaTeX, leading whitespace is irrelevant. However, the following input results in a document with a slashed square representing a tab, rather than the line with no leading whitespace characters as expected.
Note: github, ironically, did remove the leading whitespace, so just imagine that there is, in fact, a tab in front of "Ha".
\begin{document}
\script[src=packages/pullquote]
\begin[author=Doctor Clayton Forrester]{pullquote}
Ha ha ha! Baseball! Great American pastime.
\end{pullquote}
\end{document}

I like the idea, but doesn't %s match a tab character?
> =(("\t"):match("%s") and "yes" or "no")
yes

OK. I can reproduce this, but it still confuses me! Maybe pullquote is doing something odd, because it doesn't happen when you start a normal paragraph with a tab.
But thinking about it, I wonder if, more generally, we should instead replace all tabs with spaces, and then if there are spaces at the start of a paragraph, discard them all. I don't know that it's useful to have tabs in a document, and of course it's more TeX-like. What do you think?

Hey, thanks for the response!
I think that when it comes to the normal document environment, there's no compelling reason to treat tabs and spaces differently. TeX treats leading ones/multiple ones between words as equally irrelevant, which I'd personally argue is the "Right Thing"™.
I don't know that it's good to do away with them altogether, though; the most important place to keep them intact would be in preformatted environments such as code listings.
I'll see if I can figure out what's happening in pullquote.

I'm sorry to say that although it's a short file, I have no idea what in pullquote is causing the problem.

This has nothing to do with the pullquote package or leading tabs. SILE is doing this for all tabs appearing inside a line. The existing code already strips them from the beginning of the line, but it just happens that when using the pullquote package the line is prefixed with something else, hence the tab is getting treated the same way one it the middle of a string does.
\begin{document}
Tab here>	<.
\end{document}

The solution is going to be to substitute tabs for spaces internal to all strings before shaping. Is there any reason we can't go ahead and do that?

If merged this will fix #561.

This is rightly failing tests because one of our tests has a tab in the body content (used to test escapes). @simoncozens if you think this is the right approach I'll rebase this on master and fix the test so it can be merged.

I redid this again because I realized my previous attempt would ruin multiple spaces being used for a purpose with obeyspaces set. This should treat tabs as a single space each.
I'm still working on making the test pass again. For some reason even using the font file from Ubuntu Xenial is resulting in different metrics for me. Arggg.

Coverage remained the same at 92.452% when pulling 163dfcbdf057c5356097622c9c02d5d91b8f3997 on escondida:fixtabs into 13da6d4e7436466088f654da497aa5c0e5ca77ef on simoncozens:master.


GEODE-4765: Add retries when retrieving cluster config

This helps when a locator is reconnecting to the distributed system and isn't
fully ready yet.
During reconnect, pass a fresh cache to the ClusterConfigurationService -
this fixes the 'DLock destroyed' issue.
Also fixes GEODE-4730

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Precheckin is green


[Web] Disable UNIX sockets

They are not supported anyway, emscripten has an emulation layer that implements them over WebSocket/WebRTC, which is really surprising for users, and also not very useful since we have proper WebSocket and WebRTC support.
This can make the build smaller, if we also disable the UPNP module (which will otherwise include a third party library referencing "socket" thus forcing emscripten to include the compatibility layer)
Fixes #98389

This should probably be documented in some places?

This can make the build smaller, if we also disable the UPNP module (which will otherwise include a third party library referencing "socket" thus forcing emscripten to include the compatibility layer)

What is the problem with disabling it? Something in web heavily depends on it?
It looks like it can be easily disabled like already disabled raycast module
https://github.com/godotengine/godot/blob/cf35f25c07d6de7ac93651f8b28822d0b12efa3f/platform/web/detect.py#L68-L75

@dustdfg unlike the raycast module, UPNP adds exposed types. This means that if your GDScript includes references to that type, the script will fail parsing, even if you don't actually use it in web builds.

Needs to be rebased now that #98969 is merged

@Repiteo I rebased this on top of #99167 (fixup on #98969)

Thanks!


Save highlights inline

Like the other hundreds of millions of Evernote users, I simply want to save the entire web page, with any highlights I make on it.  I don't want to extract the text of highlights and then store them only.  Saving pure text, highlighted markdown is adequate.
In the obsidian documentation, this page as well as this page, suggest that this should be possible, although they are vague at the "what to type" level.
I just spent 10 minutes trying to get this to work, but when it looked like I could spend another 10 minutes and still get nowhere, I moved on.
Note: what I really want to do is to save full, highlighted html web pages, like Evernote does, or like SingleFile or Zotero (for my use case, Obsidian's nearest competitor).

Saving inline highlights is on the roadmap.

Saving inline highlights is on the roadmap.

Thanks!  Good thing I gave up early.

Added in 0.9.8.


Sort recent builds by start_time rather than build_number

This should get rid of older builds showing up in the heatmap shortly after the Jenkins migration.
Also filtering by min_start_time so that we don't get builds that are "old".
Note: we should potentially add build_url as a parameter in the heatmap to avoid this issue altogether. But this will be a larger effort as we'll need an index on that field.

LGTM


NuGet: move from Client to CodeAnalysis

Port tests to xUnit.

consumers of XI.CA will be able to get NuGet support (a little more glue work needs to be done, but this is a necessary first step)
we did not have an existing XI.Client xUnit project


Use TechDocs Addon for Mermaid

Refactored to use the Mermaid TechDocs Addon as this looks to be a more reliable method then using the MkDocs markdown_inline_mermaid extension. Fixes #603

Nice work @awanlin!! 💯


Extension causes high cpu load

Issue type: Bug
Extension Name: LiveServer
Extension version: 5.6.0
Platform:  Windows 10 Pro, Version-1703, OS Build-15063.0
Visual Studio Code: 1.46.0

Log: ritwickdey.LiveServer-unresponsive.cpuprofile.txt

Same Here


⚠ HopeAlley Ecards has degraded performance

In f6379f3, HopeAlley Ecards (https://hopealley.com/ecards) experienced degraded performance:

HTTP code: 200
Response time: 6514 ms

Resolved: HopeAlley Ecards performance has improved in c07573a after 18 minutes.


Everlong Invariant Tests

Invariants:

total assets >= previewRedeem(totalSupply)
balanceOf(any account) <= totalSupply
(positive interest environment) vault share price always increasing or equal
sum of all balances == total supply
total assets >= asset.balanceOf(everlong)

This looks good. Let's make sure that we include testing for all of the different sandwich attacks between Hyperdrive and Everlong including sandwiching longs, shorts, and LPs around deposit and withdraw.
I'm also not sure about the idea of the vault share price always increasing. If I open large short on the underlying Hyperdrive market or remove my liquidity, the vault share price is going to decrease if Everlong has open longs.


usb request failed with 0000054f - usb webcam problem

Dear all,
We are trying to set up the USB webcam to an XfreeRDP on Linux with XFCE terminal emulator <IP_ADDRESS>.
The webcam test on chromium browser works perfectly, but the problem is when we try to connect to it via usb with the sudo xfreerdp.
The error message displayed is "usb request failed with 0000054f"
The device is recognized and set up correctly.
Also, we alredy adjusted the gpo to allow incoming video:https://stackoverflow.com/questions/33719489/how-to-enable-usb-redirection-in-windows-10/46628854
Any ideas on how to resolve this problem?
os: xubunto 20.04 freerdp version 2.2.0 string: ~$ sudo xfreerdp /v:<IP_ADDRESS> /usb:id,dev:046d:0836 /sound /microphone

@afroben0306

why are you running with sudo?
where does usb request failed with 0000054f occur?
Some logs please?

I shouldn't use sudo?
2-3. please see attached screenshot

No, never for a normal application
Ok, so looks like the device is either not compatible / has issues with libusb or you could try with more recent freerdp versions, maybe you´re running into a bug.

@afroben0306 there was #7109 which fixed a bug in usb channel.
Closing this, reopen/ping me if you still have issues.


registryv1 provisioner not creating CSV permission roles

When installing a bundle via the registryv1 provisioner, the provisioner creates a CSV from the unpacked Bundle. However, this CSV does not have all the permissions it needs to run successfully. Specifically, the spec.install.spec.permissions field on the CSV specifies some roles that should be granted to the operator that are not being created by OLM. Installing the same CSV via the typical OLM flow (subscription to a catalog) results in these permissions being granted to the underlying operator.
Interestingly, the clusterroles in spec.install.spec.clusterpermissions are being applied correctly by OLM when it sees the CSV, it's just the roles that are not being generated. Therefore the registryv1 provisioner will need to create the requisite permissions on the CSV in order to be able to provision registry+v1 bundles successfully.

Closing this as there are no concrete plans for a registryv1 provisioner at this point. May reopen in the future if/when the registryv1 provisioner is being developed.


Black borders

As you requested i'm creating an issue here about the black borders that are present in some resolutions.

info for me: add 'pixel-perfect' variable to config and to command line parameters

Not sure if the issue is actual because you can control color of the "black border" area
https://twitter.com/tic_computer/status/826846225324527619
You can define border color by 0x3FF8 address in the RAM, can be useful with creating "ambient lighting" effects :) pic.twitter.com/uJOddm6rBy— TIC-80 (@tic_computer) February 1, 2017

rendering is always pixel perfect without stretching and you can change color of black border
closing...


Occationally doesn't work with Dydx orders

Hello and thanks for creating this port of the Starkex signing logic.
Im trying to use it (currently on Georli Testnet) - Is there any reason why it would sometimes stop working. E.g. first 4 orders goes with success and then afterwards (same Order size and everything (even expiration timestamp)) it fails with the "Invalid signature for order" message.
Any ideas are most helpful. Thanks.

@sakib1361 Are you getting notifications from github? Just wondering if you saw my message? :)

Sorry didnt see the messages,
Can create a test app to see if it works on a ropsten market. Currently I still didn't test high speed orders.
The library should be stateless.

Hi, thanks for getting back to me. I found another solution now. Have a good day.


Should parameters and variables get different color in syntax highlithing ?

Is your feature request related to a problem? Please describe.
Do you think it will be better if those two get different colors in syntax highlighting. It will be easier to distinguish them when referenced and also in future intellisense.

We were thinking of changing an identifier color when it points to a valid symbol (param, var, resource, function), but that's an interesting suggestion.
In IntelliSense, we will be able to differentiate by icon as well as the detail text (and documentation text on functions).

Would be good if other folks join and say what they think. I am not sure how it is in other languages but in ARM template they are currently different thus the suggestion.

What do people think about parameters being bold and variables being regular font-weight? Our only concern is preserving the number of colors we have available to play with for other language constructs.

Won't be so obvious from my perspective but could be consensus. Bold or italic is better?

@alex-frankel may be we should close due to bicep now being at this stage.


Downshifting particles shader

Hi, Jaume!
Why do you have particle position multiplied by 18?
var positionsLength = curlNoiseModel.width * curlNoiseModel.height * 3 * 18;
var positions = new Float32Array( positionsLength );

var p = 0;

for( var j = 0; j < positionsLength; j += 3 ) {

    positions[ j ] = p
    positions[ j + 1 ] = Math.floor( p / 18 )
    positions[ j + 2 ] = p % 18
    p++;

}

geometry.addAttribute( 'position', new THREE.BufferAttribute( positions, 3 ) );

And can you give me a hint how to downshift particles shader for simple flat 2D sprite, like https://bl.ocks.org/vkuchinov/0942e561a993ce91d789299b44adfee0?

Because each cube is made up of 18 vertices: 3 faces, 2 triangles each, 3 vertices per triangle: 3 * 2 * 3.
Each cube is really a half cube, and faces are shifted to face the camera, because the rear part is not necessary. I'm not sure it adds a lot of improvement. That's why I call the method "pseudoinstancing".
I'm not sure what you're asking about downshifting, though. You're using Points in your example, so that's quite a different case.

I'm asking if it's possible to decrease position attribute by 18, so there would be just one vertex per particle and render it as a 2D sprite which would be always looking to camera.

You mean in my code? Yes, you could do that, but it would look completely different, and most of the code wouldn't make sense. But yes, there's billboard particle systems with curl noise out there. In fact, they're the "default" way of doing them...

Cheers. You can close this issue.


qemu-ga: add statedir option

Motivation for this change
Presently, starting qemu guest agent fails with the following error:
Feb 12 14:07:50 desktop systemd[1]: Started Run the QEMU Guest Agent.
Feb 12 14:07:50 desktop qemu-ga[21931]:<PHONE_NUMBER>.843292: critical: failed to write persistent state to /nix/store/p9nsjv5yw25h2bys7dqxzrcs9hsj21nh-qemu-5.1.0-ga/bin/../var/run/qga.state: Failed to create file “/nix/store/p9nsjv5yw25h2bys7dqxzrcs9hsj21nh-qemu-5.1.0-ga/bin/../var/run/qga.state.N6IVY0”: No such file or directory
Feb 12 14:07:50 desktop qemu-ga[21931]:<PHONE_NUMBER>.843309: critical: unable to create state file at path /nix/store/p9nsjv5yw25h2bys7dqxzrcs9hsj21nh-qemu-5.1.0-ga/bin/../var/run/qga.state
Feb 12 14:07:50 desktop qemu-ga[21931]:<PHONE_NUMBER>.843314: critical: failed to load persistent state
Feb 12 14:07:50 desktop qemu-ga[21931]:<PHONE_NUMBER>.843318: critical: error initializing guest agent

qemu-ga --help shows the reason for this
-t, --statedir    specify dir to store state information (absolute paths only, default is /nix/store/p9nsjv5yw25h2bys7dqxzrcs9hsj21nh-qemu-5.1.0-ga/bin/../var/run)

Adding a writable path as --statedir to the ExecStart command solves this issue.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

The underlying issue here will be fixed by #112886. Do you think we still need to add this option, once the default value is something sensible (/var/run)?

#112886 looks like a better solution to this problem. Closing this PR.


[Splash Screen] Hide mouse cursor

Extension
Splash Screen
Describe the solution you'd like
Hide mouse cursor during splashscreen image phase for a nicer presentation.
darklinkpower mentioned that they are uncertain if that's possible. I have the following suggestion that might be simple to implement:

right before the splashscreen image is activated, an ahk script will start that moves the mouse cursor to the bottom left corner of the screen, example:

SetMouseDelay,-1
CoordMode, Mouse, Screen
MouseMove, 0, A_ScreenHeight
return

this script could be either included as part of the Splash Screen extension, by default or with an option in the settings to turn it on/off
or allow users to insert their own custom powershell script right before splashscreen activates (just like it's implemented in playnite for each game or globally). This way the mouse hide ahk script can be enabled manually.

Done in https://github.com/darklinkpower/PlayniteExtensionsCollection/commit/08f0cbbfa5dd75764a9d5b63be8f0b5743660a66

That's great, thank you for adding it!


[BUG] Red Loading indicator on the wrong layers most weapons

Description
Minor issue with the layering on loading indicators of various weapon. This is a sprite work with a little bit of state management.
See affected list below:
##Scope
| Weapon | Red ammo indicator position | Mag-0 |
| --- | --- |
| M41AE2 | base | Ok |
| M39 | base | Ok |
| M79 | base | Missing |
| M92 | base | Missing |
Step to reproduce

Grab a loaded weapon (from the list above)
Unload the weapon

Expected behaviour
The red loading indicator update to show no mag.
Observed behaviour
Red indicator stays on.

I will try and solve this issue if you allow me.

Working on it here: https://github.com/amo020/CM-14/tree/Fix-red-ammo-indicator-layering

Correcting the M92 blinking behaviour require it's own issue