[BUG] Incorrect handling of new mutable OntologyAnnotation

I assume quite some functions still use OntologyAnnotation in a way, which expects it to be immutable.
This change was introduced to unify object handling in ARCtrl not only within f# type but also for native js objects.
The following code replicates the specific case i encountered, in which i create a table, add an empty column, then update the oa in one of the columns:
#r "nuget: ARCtrl, 2.0.0-alpha.6.swate"

open ARCtrl

let assay = ArcAssay.init("My Assay")
let table = assay.InitTable("My Table")

table.AddColumn(CompositeHeader.Input IOType.Source, [|for i in 0 .. 4 do CompositeCell.FreeText $"Source {i}"|])

table.AddColumn(CompositeHeader.Component (OntologyAnnotation.create("instrument model", "MS", "MS:424242")))

match table.Values.[(1,0)] with
| CompositeCell.Term oa ->
  oa.Name <- Some "New Name"
| _ -> failwith "Expected a term"

table

Expected outcome
First cell in second columns has updated name
Actual outcome
-------------
Input [Source Name]     |       Component [instrument model]
Source 0        |       New Name
Source 1        |       New Name
Source 2        |       New Name
Source 3        |       New Name
Source 4        |       New Name

Well in the case you provided I would expect exactly this behaviour 😅

By updating the name of cell (1,0) you would expect the table to update all cells in the same column?
match table.Values.[(1,0)] with
| CompositeCell.Term oa ->
  oa.Name <- Some "New Name"
| _ -> failwith "Expected a term"

How about we add some static members to OntologyAnnotation like we did with other types and make those function immutably. Additionally a CompositeCell copy might be helpful.

By updating the name of cell (1,0) you would expect the table to update all cells in the same column?
match table.Values.[(1,0)] with
| CompositeCell.Term oa ->
  oa.Name <- Some "New Name"
| _ -> failwith "Expected a term"

By updating the name of cell (1,0) you would expect the table to update all cells in the same column?
match table.Values.[(1,0)] with
| CompositeCell.Term oa ->
  oa.Name <- Some "New Name"
| _ -> failwith "Expected a term"

By updating the name of cell (1,0) you would expect the table to update all cells in the same column?
match table.Values.[(1,0)] with
| CompositeCell.Term oa ->
  oa.Name <- Some "New Name"
| _ -> failwith "Expected a term"

You're very explicitly not updating the name of the cell but the name of the OntologyAnnotation, making use of mutable patterns.
So yes, if I defined the table like you did I would expect it.

So yes, if I defined the table like you did I would expect it.

Please explain in detail, how you would expect this behavior on a column, added without any cells.

Okay nevermind, didn't notice this made use of FillMissingCells.


Updated Task-Cards to match Figma design

Overview
Redesigned the Task Cards based on the design from Figma
Details
-CSS to change the placement/colors/overall design of the cards:
-added hover animations to flip cards
-diagonal banner on front of card
-task.description truncated on back of card if longer than 80 characaters
-tags truncated if longer than 10 characaters
Notes
-The cards are fully functional as is, but there are still some things that need adjustments.
-Details can be seen on new Trello cards:
https://trello.com/c/PeF2U8EF
https://trello.com/c/I4DekBzP
Screenshots

-->

 Update and style the task card component


chore: add json example

@edmundhung can you explain to me how I might be able to get a JSON field working with conform? I've setup this example, but the .defaultValue of the input renders as a blank input value

Just pushed a commit to your PR.
There is no JSON field in Conform. Conform only understand string or File in an input. You will need to manually serialize it between string and JSON and make sure you serialize the value again when you update the field value (e.g. control.change(JSON.serialize(value)))

@edmundhung is there anyway to use the jsonSchema type I had? for my use case I want to allow someone to add any JSON data because we're mapping it back to a users DB so we don't know the shape of the data.

I have tested it once with your original type and it seems to recursively looping over and over again and crash. I am not sure why. It might be either a bug on the enableTypeCoercion helper in the conform zod package or something wrong with zod itself? Can you verify if the JSON schema works without passing to Conform?

@edmundhung yep the jsonSchema type is in the GitHub docs of zod and works as expected.

@lifeiscontent I have pushed up a fix to your branch. Let me know if this is what you were looking for.

@edmundhung is there a way I can try a prerelease version of this quickly? I can try it in the project I'm working in and get back to you.

@edmundhung is there a way I can try a prerelease version of this quickly? I can try it in the project I'm working in and get back to you.

Here you go :)

@edmundhung it works perfectly! :)

@edmundhung any chance the work you did here could get merged?


Fix map access in order

Fixes https://github.com/querydsl/querydsl/issues/1624
backport of https://github.com/querydsl/querydsl/pull/1623

I think it now looks good.


Clicking on Navigate raises a ValueError

Hi,
I followed your documentation and ran the following line:
ros2 run pyrobosim_ros demo.py
I saw a nice map. I clicked on Navigate and received the following error:
~/pyrobosim/pyrobosim$ ros2 run pyrobosim_ros demo.py [INFO] [1664361758.672906297] [pyrobosim]: World node started. [INFO] [1664361758.673251481] [pyrobosim]: Creating demo world programmatically. Navigating to desk0_desktop Exception in thread Thread-3: Traceback (most recent call last):   File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner     self.run()   File "/usr/lib/python3.8/threading.py", line 870, in run     self._target(*self._args, **self._kwargs)   File "/home/gabriele-plankton/pyrobosim/install/pyrobosim_ros/lib/python3.8/site-packages/pyrobosim/navigation/execution.py", line 56, in execute     (traj_t, traj_x, traj_y, traj_yaw) = interpolate_trajectory(traj, self.dt)   File "/home/gabriele-plankton/pyrobosim/install/pyrobosim_ros/lib/python3.8/site-packages/pyrobosim/navigation/trajectory.py", line 97, in interpolate_trajectory     [slerp(t).as_euler("xyz", degrees=False)[2] for t in t_interp]   File "/home/gabriele-plankton/pyrobosim/install/pyrobosim_ros/lib/python3.8/site-packages/pyrobosim/navigation/trajectory.py", line 97, in <listcomp>     [slerp(t).as_euler("xyz", degrees=False)[2] for t in t_interp]   File "/usr/lib/python3/dist-packages/scipy/spatial/transform/rotation.py", line 1757, in __call__     raise ValueError("Expected times to be specified in a 1 " ValueError: Expected times to be specified in a 1 dimensional array, got 0 dimensions.

Thanks for reporting this!
Are you on the latest main branch? I just modified this exact same demo.py to randomize the robot pose and plan a path to a random location in an infinite loop... and I don't see this error.
Does this happen to you consistently or was it that one time? Would appreciate more details so I can dig in.

Yes, I cloned the main branch (Ive done it maybe 30 min ago). The error keeps appearing every time. I tried also running the following command line in a separate terminal:
ros2 run pyrobosim_ros demo_commands.py
I got the same error again in the ros2 run pyrobosim_ros demo.py terminal.

Hmm, well the only other thought I had is you're on Python 3.8 while I developed on 3.10... So maybe the scipy version was different.
But I just started up a Docker container with Python 3.8 and everything seems fine on my end there too.
Just to make sure, what is your scipy version if you open up Python and enter the following?
>>> import scipy
>>> scipy.__version__
1.8.1.

Maybe you're on an older version of scipy which expects things in different format? Because even when I try pass in a 0-dimension time, even the error is different.
If that's the case, could you try a pip3 install --upgrade scipy on your system?
Or if you don't want to mess with your system, you could follow the recommended instructions in https://pyrobosim.readthedocs.io/en/latest/setup.html and make a virtual environment for pyrobosim:
cd /path/to/pyrobosim
setup/create_python_env.bash

That was it. It was an older version of scipy (1.3.x). Thanks!

Amazing, glad we got it solved! Enjoy pyrobosim, and let me know if anything else :)


Some more cleanup suggested by cargo clippy

This is a follow-on to https://github.com/smoltcp-rs/smoltcp/pull/395. I still have some more changes locally, but I can follow up with another pull request once I get them cleaned up a bit.

Very nice! Thanks!


Add "strict" option for numeric rule

(Now with the correct base branch and more description)
The numeric rule validates successful for values like NAN and INF. Although these are valid numeric values by specification (see http://php.net/manual/en/math.constants.php), I think it would be more intuitive when the validator fails for these values (because they are no real numbers).
This PR adds an optional "strict" option to the numeric rule.
Validator::make(['value' => 'numeric:strict']);

I was not sure about the naming, so "strict" was my first idea. Maybe something like "real" would be suitable, too.

Kindly provide tests for this

I don't know that I want to add a special case for this. I think it can handled in your own application.


Weave Support.

guessing this supercedes https://github.com/Capgemini/kubeform/pull/31/files

closing this in favour of network policies and network plugins with native kubernetes support


Resolve .env clash

Most likely jags will be used in a Solidity environment. The idea is to extract the private key and the network url from environmental variables required

Issue close. Reasons ==> refer to #8 comment


Remove the dask tutorial notebook for now

The dask tutorial notebook is not linked in the Mkdocs nav. Relevant discussion: https://github.com/nsidc/earthaccess/pull/568#discussion_r1597673850

Why was it removed from the nav? It wasn't! It was added as a comment to remind us to add it to the nav later when it was more complete.
Do we want to bring it back? Yes, but in a different form.
What needs to be done to bring it back? _@betolink working on it as part of smart_open (#527) work

Decision: Remove it for now!

The tutorial was never added as a nav item, it was always commented out: https://github.com/nsidc/earthaccess/commit/dab9da4b290424dc4de2bd2212a8d1212019b947
@betolink can you shed some light on this?

This was an initial toy example with Dask, I'm working on a version that works independently of Coiled but I don't think it will be ready until next month, hopefully by then we'll have smart_open=True released.

Should we remove this notebook so it can be replaced with the Coiled-independent version later?

I think so.

@mfisher87 Hey Matt, is this issue still relevant? If yes, do you any specific opinions regarding this?


add exports of ERC20Wrapper and OrderLibrary

Pull Request Test Coverage Report for Build 1044

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1040:
0.0%

Covered Lines:
301

Relevant Lines:
301

💛  - Coveralls


fix: null label fallback (release w/o name)

this undoes the suggestion in
https://github.com/prismicio-community/ruby-kit/pull/128/commits/d54dfecc727f5910e5b3e692496ae2aa1c968315 since it's fundamentally different behavior. fetch only fallsback to the second param if the key is missing. but there is a label key in our hash, so it returns nil, persisting the nil.downcase call. This makes it so the value properly falls back when nil.
It also doesn't downcase the id since that may actually be case sensitive.
I tested this fix against a codebase reproing the issue and all appears well.
Follow up to https://github.com/prismicio-community/ruby-kit/pull/128, true fix for https://github.com/prismicio-community/ruby-kit/issues/116
@alistairholt pinging you here just because I realized when testing that last PR it didn't quite fix the issue.
Would it be possible to set up CI to run on GitHub actions to ensure the test suite passes before PRs merge? :pray: Happy to lend a hand here if it's something y'all want.

Thank you! Good catch. We did have TravisCI but it doesn't seem like we have it in place anymore - I'm not sure why. We could absolutely use more maintainers on this gem. I haven't had good amount of time to devote to it for a long time. @faresd?

I can open a separate PR for the CI, I've got it working on my fork but would love to just run off this main repo. :smile:

@alistairholt @faresd any chance this can get merged to fix the issue that exists in master? Then I can get CI working and passing in #130.

@brettchalupa thank you!


filter having issue handling glaives

every glaive seems to result in being unable to detect itempower and itemtype resulting in them not being parsed by the filter
2024-10-11 | 11:10:30.036 | Thread-7 (_wrapper_run_loot_interaction_method) | WARNING | src.item.descr.read_descr:46 | Could not detect ItemPower and ItemType: "edgemaster's sharp glaive legendary glaive 750 item power
2024-10-11 | 11:10:30.994 | Thread-7 (_wrapper_run_loot_interaction_method) | INFO | src.loot_filter:75 | Retry item detection
2024-10-11 | 11:10:31.754 | Thread-7 (_wrapper_run_loot_interaction_method) | WARNING | src.item.descr.read_descr:46 | Could not detect ItemPower and ItemType: "elegant glaive ®f the expectant legendary glaive 750 item power
2024-10-11 | 11:10:33.772 | Thread-7 (_wrapper_run_loot_interaction_method) | INFO | src.loot_filter:75 | Retry item detection
2024-10-11 | 11:10:34.528 | Thread-7 (_wrapper_run_loot_interaction_method) | WARNING | src.item.descr.read_descr:46 | Could not detect ItemPower and ItemType: ‘flame glaive @f retribution legendary glaive 750 item power
2024-10-11 | 11:10:35.531 | Thread-7 (_wrapper_run_loot_interaction_method) | INFO | src.loot_filter:75 | Retry item detection
2024-10-11 | 11:10:36.330 | Thread-7 (_wrapper_run_loot_interaction_method) | WARNING | src.item.descr.read_descr:46 | Could not detect ItemPower and ItemType: jade glaive @f inevitable fate legendary glaive  750 item power

This is being addressed in this PR: https://github.com/aeon0/d4lf/pull/383


datepicker memory leak

Reproduction
Steps to reproduce:

go to https://material.angular.io/components/datepicker/examples
open datepicker and close multiple times
each open and close action generate 135KB memory leak.

The more times we open and close datepicker, the more memory are allocated.
Garbage collector does not clear all allocated memory.

Expected Behavior
datepicker without memory leaks
Actual Behavior
memory leaks
Environment

Angular: 8.2.14, 9.0.0-rc.5
CDK/Material: 8.2.3, 9.0.0-rc.5
Browser(s): Chrome 78.0.3904.108
Operating System: Fedora 31

related issue: https://github.com/angular/angular/issues/25744
it looks like the biggest leak comes from  @angular/animations module
after remove matDatepickerAnimations and rest of "animations" code from datepicker
each open and close action generate only 1.3KB of memory leak.

The animations leak is fixed by https://github.com/angular/angular/pull/34409.

Closing since this was caused by the framework and because the fix has been merged there.

it's look like the memory leak still exists.
I built and launched dev-app from 9.0.0-rc.6 tag.
inside DOM  the dev-app element  has attibute ng-version="9.0.0-rc.7"
Also inside animations-browser.umd.js i see changes from fix https://github.com/angular/angular/pull/34409.
So theoretically fix should work, but still each open and close action generate 130KB memory leak.

I can see the memory leak as well so the root cause probably wasn't angular/angular#34409. I spent some more time looking into it and I'm not sure exactly why it's happening, but here are some observations:

It only happens for datepickers in popup mode. There's still a smaller leak in dialog mode, but it only ends up leaking one datepicker worth of elements and it doesn't stack up like the current leak.
It seems to happen, because in popup mode we detach the overlay and we only dispose of it on destroy, but by that time the elements have leaked out already. If I switch to disposing it on every close, it starts behaving like dialog mode, but this isn't ideal because it breaks the closing animation.
The leak seems to be due to the fact that we remove the DOM nodes once the animation has finished here. If I switch it to remove the element immediately, it stops leaking. This is confusing, because I can verify that the callback always fires at the proper time and the elements do get cleaned up. There might be something further down the line that expects the elements to have been removed immediately.

it looks like it's getting worse with every version of angular and components.
Angular 7.1.4
Components 7.3.7
Leak: 11.8 KB

Angular 8.2.10
Components 8.2.3
Leak: 59.5 KB

Angular 9.0.0-rc.13
Components 9.0.0-rc.9
Leak: 122 KB

This may be part of the leak https://github.com/angular/angular/issues/35148

I would also suspect something in the framework, since we haven't made any major changes to overlays or datepicker lately.

<EMAIL_ADDRESS>provides significant improvement in memory profile

@angular/material 9.1.0solve memory leak in datepicker component


ci: add GitHub Actions workflow for testing

closes #436.

Problem
We can't tell if a change breaks tests without cloning changes locally.

How this change fixes it
CI automatically checks if tests pass, for us.

Oh i forgot we even no have tests on CI for this project. Nice work!
Btw, as i see CodeQL did not runned for this PR. Maybe because we no have changes in code (ts/js files).
Anyway, it means we have to setup CI analysis for non-code files. Any files that may affect on code execution must be analyzed, including workflow files

Oh i forgot we even no have tests on CI for this project. Nice work!

Thanks!


Tensorflow lite conversion fails for keras model in TensorFlow version: 2.16.1

1. System information

OS Platform and Distribution : Linux Ubuntu 22.04
TensorFlow installation (pip package or built from source): pip package
TensorFlow library (version, if pip package or github SHA, if built from source):  2.16.1

2. Code
import tensorflow as tf
import pdb
print("TensorFlow version:", tf.__version__)

class network(tf.keras.Model):
    def __init__(self):
        super().__init__()
        self.conv1 = tf.keras.layers.Conv2D(filters=2, kernel_size=3, strides=2, activation='relu')

    def call(self, x):
        x = self.conv1(x)

        return x

model = network()

inp  = tf.keras.Input(shape=(28, 28, 1))
out = model(inp)
model.build(input_shape=(None, 28, 28, 1))

model.summary()

converter = tf.lite.TFLiteConverter.from_keras_model(model)
tfliteModel = converter.convert()

Output
LLVM ERROR: Failed to infer result type(s).
Aborted (core dumped

ouptut.txt

The original issue is closed now

Hi @vmanoj1996 ,
Right now, TF2.16 has an issue with Keras 3.0. As a workaround install Keras 2 as follows.
pip install -U tf_keras # Keras 2
import os
os.environ["TF_USE_LEGACY_KERAS"] = "1"

Please check this gist  and let me know if the problem persists.


stubs: add explicit argument to allergies function

Anagram: add explicit arguments to stub function
Related to issue #473.
see also #496  #491

Considering that this PR had no activity in the last two weeks, I'll close it for now.
Of course, we can reopen it later if @mttakai decides to continue with it.


Refreshes standup docs.

This does a few things:

Adds a note for moving laptops away from the Zoom speakerphone.
Removes the announcement for writing office hours, since it robs me of an opportunity to really sell the event. It made sense to include in the template when I was running standup each week, but not anymore.
Corrects the Show & Tell time.

Nice one!! ❤


insert in reverse order

I.e., insert numbers from bottom (last line) to top (first line).
E.g., this 10 r with 4 lines (i.e. 4 cursors) would result in:
13
12
11
10

I can't use just 13--  because I don't know that 13 is the last number.
Use case: I copy N last commit lines from console via git log --oneline, which are in reverse order by default, and want to add commit order numbers to them, but I only know the number of the last previously-numbered commits, and don't want to count the lines and calculate the last commit number myself..
Yea, it's an edge case.

I'm closing this since it's better to just do a --reverse log, anyway.


missing ios build

it is best mobile client ever that i had used. missing ios version.
streaming capability make this app good cause deluge it self donot have streaming ability.
hope u people will release ios version soon

it is best mobile client ever that i had used. missing ios version.
streaming capability make this app good cause deluge it self donot have streaming ability.
hope u people will release ios version soon

ios version is under experiment it will release soon, thank you


[feature request] 12 hr rather than 24 hr

Title says it unless I missed the setting.
Thank you

Sorry for the late reply @BernSh19 but yep, see above ! Closing, feel free to reopen if you still have issues

🙏
Nice app. Wishing you much success!
Bern

On Aug 23, 2022, at 6:54 PM, Aiden Mitchell @.***> wrote:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


Update gh actions

Some actions have newer releases, we should use them.

TIP. You can automate action updates with dependabot nowadays.

@davidkarlsen I will have a look at this. That PR doesn't really make sense anymore if that's the case.


Hardware JPEG Compression via VAAPI

This adds code that will perform the compression of JPEG images using the intel integrated GPU. This will take load off the CPU and allow for faster compression rates for saving or sending to NUsight.
One downside is that this may compete with the VisualMesh for GPU resources and this will need to be factored in.
Also this code no longer does debayering for jpeg compression. It instead performs a permutation of the Bayer to make it easier to compress.
The resulting image is a black an white image which changes the order like so
RGRGRGRG  |  RRRRGGGG
GBGBGBGB  |  RRRRGGGG
RGRGRGRG  |  GGGGBBBB
GBGBGBGB  |  GGGGBBBB

NUsight2 will need to be modified with new shaders that can handle this format.

This goes along with https://github.com/NUbots/NUsight2/pull/298 which allows NUsight2 to decode and display the images properly


🐛 Does not support resolution-mode for typeof import

Environment information
CLI:
  Version:                      1.6.1
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.11.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              true
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

Declare a type that references an import, using resolution-mode. See example playground: https://www.typescriptlang.org/play?target=99&moduleResolution=99&ts=5.4.2#code/KYDwDg9gTgLgBDAnmYcBiBnOBeBzgQBmcAlgLaSwAUA5IRjQDRwDecA7iTABYBcrcGlGAYIAGwCuMEhAB2AWjIQAJsBr8a5SjBpwAvvoCUQA
Run biome format ., and receive a failure that there is no expected extra parameter to import. See playground https://biomejs.dev/playground/?code=ZQB4AHAAbwByAHQAIAB0AHkAcABlACAARgBzACAAPQAgAHQAeQBwAGUAbwBmACAAaQBtAHAAbwByAHQAKAAnAGYAcwAnACwAIAB7ACAAdwBpAHQAaAA6ACAAewAgACcAcgBlAHMAbwBsAHUAdABpAG8AbgAtAG0AbwBkAGUAJwA6ACAAJwBpAG0AcABvAHIAdAAnACAAfQAgAH0AKQA%3D&jsx=false

Expected result
Biome is able to successfully parse the resolution-mode part of import() and format as usual.
Note resolution-mode is now considered stable in typescript:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#stable-support-resolution-mode-in-import-types
Note that prettier also appears to be wrong in this handling, but I think this would count as one of the few cases where biome should diverge from prettier.
This type handling is actually necessary in some cases as well. It is hard to show on playground, but when writing types for a commonjs file that will dynamically import an ESM file, Typescript encourages using the resolution-mode.
my-cjs-file.cts
let nullishEsm: typeof import('my-esm-file', { with: { 'resolution-mode': 'import' } }) | null = null;
import('my-esm-file').then(val => {
    nullishEsm = val;
}).catch(() => {});

works!
But
let nullishEsm: typeof import('my-esm-file', { with: { 'resolution-mode': 'import' } }) | null = null;
import('my-esm-file').then(val => {
    nullishEsm = val;
}).catch(() => {});

fails with:
The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("my-esm-file")' call instead.

Code of Conduct

[X] I agree to follow Biome's Code of Conduct

This is a bug from our parser/grammar. The dynamic import assertion should not be parsed as a js block statement.

For anyone else getting hit by this, I managed to get past the typescript warnings using assert in the import.
import type * as Foo from 'my-esm-file' assert  { 'resolution-mode': 'import' };

// ...

let nullishEsm: typeof Foo | null = null;

Still consider this an issue worth fixing eventually, but definitely possible to work around (and actually appeases eslint rules like consistent-type-imports disallowTypeAnnotations

i want to try this~

@fireairforce are there any updates? If not, can we remove yourself and give this issue to someone else?

sorry i forget this issue, i will work on this week~

@fireairforce Any update?


Chore: csv back to comma delimited

@AllenFang excel default open is by comma delimited so it's annoying to open manually with tab delimited.
So I changed it back to comma delimiter with "" wrapped around to escape the commas in cell.

Great job:) Thanks

Note: Excel csv format depends on locale. Semicolon as a separator is very common, at least in Europe. We should probably externalize the whole csv function to a library which can configure the output better.


Open to accept DodStatsD types?

We are wondering if you are open to accept contributions to handle metric types which are particular to DogStatsD like for instance distribution https://docs.datadoghq.com/developers/metrics/dogstatsd_metrics_submission/?tab=go#distribution

Absolutely.
I've had vague thoughts about it in the past, and the main concern is how would a non-Datadog backend handle it. Ultimately I think it's fine to drop it, as long as it's expected behavior.
My rough thoughts about it would be:

Alias d to the Timer type (like Histograms), but add an extra 'magic' tag (such as gsd_distribution:true) when a Distribution is parsed.
In the aggregator, if a configuration option is enabled and the tag is present on a timer, then prepare the data as a distribution, otherwise treat it as a regular timer.

This allows for a sender that's not using the dogstatsd client to submit distributions by sending a regular timer/histogram with the magic tag.  It also means that the server has to have it explicitly enabled, so that code path would never occur unless the service owner has knowingly enabled it (which fulfills the "expected behavior" mentioned above).  Possibly a warning could be issued if the flag is enabled and there's a non-Datadog backend.
For the backends:

The Datadog backend handles it as expected
The stdout backend logs it in a semi-meaningful way.  Since this is usually more for debugging, knowing that the metric is being processed as a distribution is important.
The other backends explicitly drop it (maybe issuing a warning on first attempt? not sure)

Does that approach seem sane?

If you do want to contribute, it's a good idea to sign the CLA early as well, it's a bit of a manual process on the backend, so it'll save some time later :)

Yes, dropping/logging at backend level looks good to me.
And sure I'm signing the CLA and will starting contributing.


Can this just generate python project, not any language else?

I tried the project, giving an instruction of making a cms system using Elixir, but it still generates python code.

https://github.com/geekan/MetaGPT/issues/20 mentioned this.


Figure out Chromatic snapshot relevance

We've had Chromatic flag irrelevant snapshot differences, which means that the testing is not useful and there is a risk of approval fatigue/ignoring flagged changes.
We've had this issue before but it seems to have come back in force. At the time we played with diffThreshold, so it could be looked into again (there are many PRs of this sort), but I'm not sure it changes anything. I'd also reached out to Chromatic customer service at the time who had a few suggestions that it might be worth reaching to again.
I've made sure we were on their latest infrastructure and it doesn't seem to have changed anything.
I know we're looking at moving to Storybook 7. Will that change anything and if so, do we want to hold this ticket back until we do?
In the meantime, creating a ticket as it should be addressed either way.

Next step:

remove autoformat query parameter
use static images
use Chromatic ignore property to ignore images altogether

We were getting a lot of "padding at bottom is different" snapshots to approve too, so I sent them a message and Reuben from Chromatic replied with this - super helpful!
https://github.com/wellcomecollection/wellcomecollection.org/assets/110461050/b29b66de-7b54-4461-8e9b-0d773ce8a0a6
I think we might want to try delaying our stories for now, then look into how we can make this better as a next step. For example, maybe we should put the README somewhere else, especially if we're thinking of Figma as our source of truth in the future?

I've submitted a few PRs since and it's been fine? So I'll close this ticket and we can unarchive it should it happen again.


Adding "resume" lifecycle event

What problem does this feature solve?
Just a thought: Would it not be nice to have a "resume" lifecycle in vue-router? So adding an event callback by jumping back to a visited component?
What does the proposed API look like?
Just like "mounted" or "created".

You can already achieve this by using beforeRouteEnter, beforeRouteUpdate and the other hooks


limiting cores while training , training on 3 channel images

is there an option to limit core usage during training or do i have to do it by setting keras and
tensorflow environment variables
Is it possible to train on 3 channel images and 1 channel mask, i notice that an assert statement
checks for that
how do you generate 3 channel images of the mask, is it okay to do it by concatenating 1
channel mask images 3 times or does labkit have an option to do that

is there an option to limit core usage during training or do i have to do it by setting keras and tensorflow environment variables

You can limit the number of cores by setting the environment variable OMP_NUM_THREADS before importing everything else, like so
import os
os.environ["OMP_NUM_THREADS"] = "2"

Is it possible to train on 3 channel images and 1 channel mask, i notice that an assert statement checks for that

Yes, currently only single channel output (i.e. a single class of objects) is supported.

how do you generate 3 channel images of the mask, is it okay to do it by concatenating 1
channel mask images 3 times or does labkit have an option to do that

As before, having multi-channel masks is currently not supported.


Free otp unresponsive

I clicked the only otp I had in the app and it doesn’t work, at all, there’s nothing on the app the trouble shoot the issue either, need help

Hi Syunchua
Can you give more details to the developers? E.g. which version of the app and which version of iOS on which device type you're using?
Can you add another OTP Token and does that one work?
Best regards

I had a similar issue on iOS 15.2 when photo access was turned off.
FreeOTP would either not start (only show the splash screen) or freeze a few moments after opening.
Allowing access to some or all photos resolved the issue.
I have been unable to reproduce the issue on iOS 15.2.1 regardless of the photo access settings.

Please re-open this issue if any help is still needed.


Added three pip packages to python.yaml.

I added three pip packages (mightex_device, zaber_device, and modular_device) to python.yaml.

@peterpolidoro can you squash this? You have several merge commits and a cleanup commit which are extraneous.
Also, just so you know, pip only dependencies cannot be used when releasing a package because we cannot create .deb's which depend on pip packages.


Development Scripts

Experimented with Setup.hs and custom setup.
In hpack, there is build-type and custom-setup configuration for this purpose.
proto-lens is an example that uses custom setup script. It adds grpc code gen into the cabal build procedure. This is done through UserHooks which is similar to nix build phases and hooks where we can add custom scripts/instructions in to the different build stages.
https://hackage.haskell.org/package/proto-lens-protoc-<IP_ADDRESS>/docs/Data-ProtoLens-Setup.html
However this is different to what we are after, it does not add custom commands that can be run arbitrarily and manually.
Upon inspection into Cabal, it seems that cabal does not allow custom commands.
cabal's various defaultMain, defaultMainNoRead, defaultMain* functions all call into defaultMainHelper where the main logic is found.
defaultMainHelper hardcodes a set of commands that can be called.
defaultMainHelper :: UserHooks -> Args -> IO ()
defaultMainHelper hooks args = topHandler $ do
  args' <- expandResponse args
  case commandsRun (globalCommand commands) commands args' of
    CommandHelp   help                 -> printHelp help
    CommandList   opts                 -> printOptionsList opts
    CommandErrors errs                 -> printErrors errs
    CommandReadyToGo (flags, commandParse)  ->
      case commandParse of
        _ | fromFlag (globalVersion flags)        -> printVersion
          | fromFlag (globalNumericVersion flags) -> printNumericVersion
        CommandHelp     help           -> printHelp help
        CommandList     opts           -> printOptionsList opts
        CommandErrors   errs           -> printErrors errs
        CommandReadyToGo action        -> action

  where
    printHelp help = getProgName >>= putStr . help
    printOptionsList = putStr . unlines
    printErrors errs = do
      putStr (intercalate "\n" errs)
      exitWith (ExitFailure 1)
    printNumericVersion = putStrLn $ prettyShow cabalVersion
    printVersion        = putStrLn $ "Cabal library version "
                                  ++ prettyShow cabalVersion

    progs = addKnownPrograms (hookedPrograms hooks) defaultProgramDb
    commands =
      [configureCommand progs `commandAddAction`
        \fs as -> configureAction hooks fs as >> return ()
      ,buildCommand     progs `commandAddAction` buildAction        hooks
      ,showBuildInfoCommand progs `commandAddAction` showBuildInfoAction    hooks
      ,replCommand      progs `commandAddAction` replAction         hooks
      ,installCommand         `commandAddAction` installAction      hooks
      ,copyCommand            `commandAddAction` copyAction         hooks
      ,doctestCommand         `commandAddAction` doctestAction      hooks
      ,haddockCommand         `commandAddAction` haddockAction      hooks
      ,cleanCommand           `commandAddAction` cleanAction        hooks
      ,sdistCommand           `commandAddAction` sdistAction        hooks
      ,hscolourCommand        `commandAddAction` hscolourAction     hooks
      ,registerCommand        `commandAddAction` registerAction     hooks
      ,unregisterCommand      `commandAddAction` unregisterAction   hooks
      ,testCommand            `commandAddAction` testAction         hooks
      ,benchmarkCommand       `commandAddAction` benchAction        hooks
      ]

Creating our custom defaultMainHelper counter-part is blocked by non-exported functions.

From @nzhang-zh
But of course, we resolved this by just using scripts which is in the postgres branch.

Solved by 1aa3daf6460dd4b88d9c69ed88807524486ee764


Fix the chrome invalid arguments issue and others

Chrome doesn't allow "Host" and "Content-Length" headers to modify.
Fix the wrong body object when singing
Add an optional session token which used in the assumed short term token

Test on chrome 100.0.4896.75 and firefox 99.0

any updates?

Yall shoulda emailed me lol. I'm just seeing this! Lemme test real quick


The zrange option should affect heatmap's colorbar range

Heatmap uses the max&min of data as the colorbar range:
df = pd.DataFrame(data=np.arange(20).reshape(5, 4), columns=['A', 'B', 'C', 'D'])
df.iplot(kind='heatmap', colorscale='-rdbu')

However, when using diverging colormaps like rdbu, the colorbar should typically center at 0 (to show differences). With native Plotly, the code would be:
from plotly.offline import iplot
import plotly.graph_objs as go

trace = go.Heatmap(z=df.values.T, y=df.columns, zmin=-20, zmax=20, colorscale=cf.get_colorscale('-rdbu'))
fig = go.Figure(data=[trace], layout=go.Layout(width=600, height=400))
iplot(fig)

df.iplot() does have a zrange option, but it cannot be used for heatmap. (Although it works for scatter3d). The following code leads to an error.
df.iplot(kind='heatmap', colorscale='rdbu', zrange=[-20, 20])

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-273-f30cc0fd17fc> in <module>()
      1 df = pd.DataFrame(data=np.arange(20).reshape(5, 4), columns=['A', 'B', 'C', 'D'])
----> 2 df.iplot(kind='heatmap', colorscale='rdbu', zrange=[-20, 20])

~/Research/Computing/miniconda3/envs/geo/lib/python3.6/site-packages/cufflinks/plotlytools.py in _iplot(self, data, layout, filename, sharing, kind, title, xTitle, yTitle, zTitle, theme, colors, colorscale, fill, width, dash, mode, symbol, size, barmode, sortbars, bargap, bargroupgap, bins, histnorm, histfunc, orientation, boxpoints, annotations, keys, bestfit, bestfit_colors, mean, mean_colors, categories, x, y, z, text, gridcolor, zerolinecolor, margin, labels, values, secondary_y, secondary_y_title, subplots, shape, error_x, error_y, error_type, locations, lon, lat, asFrame, asDates, asFigure, asImage, dimensions, asPlot, asUrl, online, **kwargs)
    694                                                                 bargap=bargap,bargroupgap=bargroupgap,annotations=annotations,gridcolor=gridcolor,
    695                                                            dimensions=dimensions,
--> 696 								zerolinecolor=zerolinecolor,margin=margin,is3d='3d' in kind,**l_kwargs)
    697
    698         if not data:

~/Research/Computing/miniconda3/envs/geo/lib/python3.6/site-packages/cufflinks/tools.py in getLayout(kind, theme, title, xTitle, yTitle, zTitle, barmode, bargap, bargroupgap, margin, dimensions, width, height, annotations, is3d, **kwargs)
    266                                 layout['scene']['{0}axis'.format(r)].update(range=kwargs['{0}range'.format(r)])
    267                         else:
--> 268                                 layout['{0}axis1'.format(r)].update(range=kwargs['{0}range'.format(r)])
    269
    270         # Need to update this for an add_axis approach.

AttributeError: 'NoneType' object has no attribute 'update'

This was a good one. Thank you.
zrange is really for something different.
I have added the following options for heatmap and surface
                center_scale : float
			Centers the colorscale at a specific value
			Automatically sets the (zmin,zmax) values
		zmin : float
			Defines the minimum range for the z values.
			This affects the range for the colorscale
		zmax : float
			Defines the maximum range for the z values.
			This affects the range for the colorscale

So now you can do the following:
cf.datagen.heatmap().iplot(kind='heatmap',colorscale='rdbu',center_scale=0)

Which should give you the following:

With this you can choose at which value to center the scale, and/or define explicit zmin and zmax if you want to set a wider range than that defined by the values in the DataFrame.

Wow, thanks for reacting so quickly (also for all the other threads)!
As a big fan of Plotly, I really like this package.

nice one, unfortunately this is not working if there are missing values


WL-4677: Print issue on a Lessons page

More code coming to a PR near you soon!

Doesn't merge at the moment.


testport -P: /prefix always flagged as a leftover directory

Currently using Poudriere 3.2.2 and testing ports with a custom PREFIX via -P always fails with:
===========================================================================
=>> Checking for extra files and directories
=>> Error: Files or directories left over:
@dir /prefix
=>> This test was done with PREFIX!=LOCALBASE which may show failures if the port does not respect PREFIX. Try testport with -n to use PREFIX=LOCALBASE
build of devel/ksql | ksql-0.1.4 ended at Thu Dec  7 09:58:01 CET 2017
build time: 00:00:04
!!! build failure encountered !!!

I don't think that still having /prefix should be considered an error here.
I think the suggestion to use testport -n isn't that useful anymore.  It appears to be the default setting anyway.

I can't reproduce it anymore now.


Suggestion for your list :)

A bit of self-promotion I'm afraid, but I wrote an FSM you can find over here. It's well documented, so I hope it's a valuable addition.
Thanks for the Reddit thread, too! That's how I found your list. :)

Nice! Please open a PR let's add your project to the list.

Thanks! Just created one. Hope it's alright!

Merged!


Finetuning bloom with stanford_alpaca repo problem

In the https://github.com/LianjiaTech/BELLE/issues/26 it said that the finetuning script is from the stanford_alpaca. I want to ask a simple question:
What is the fsdp_transformer_layer_cls_to_wrap for bloom?
When I tried to fine tune with bloomz-7b1, the training stuck on 0%. And it's most likely because I dont set the right fsdp_transformer_layer_cls_to_wrap . But I cant find it in the bloom config.
Kindly need a help on this.
Thank you

The finetuning is done on a seperate repo we haven't released yet. Hopefully it will get released soon :)


Add MIT/Apache-2.0 license

This PR adds a MIT/Apache-2.0 license to this repository (previously, there was no license). Should not be merged until we get an approval from past contributors (https://github.com/rust-lang/surveys/issues/267).

+1 from me
thanks @Kobzol


Updated dungeon-crawl-stone-soup-console to version 0.19.0

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked that the cask was not already refused in closed issues.

Included in #26974


Bump k8s.io to v0.27.1

What type of PR is this?

/kind test
What this PR does / why we need it:
Bump k8s.io to v0.27.1
Which issue(s) this PR fixes:

Fixes #1942
Does this PR introduce a user-facing change?:

Bump k8s.io to v0.27.1

/ok-to-test

@shaneutt seems everything is pass now.

@shaneutt anything left?

Sorry for the slow responses, last week was Kubecon week and it was incredibly busy. I'll take another pass at this soon.

merge conflict needs fixing when you have a second, I resolved a couple of open comments :+1:

Looks good, would like a double check from another maintainer
/cc @youngnick @robscott

kindly ping @robscott , can this get in now?

Thanks @zirain!
/lgtm
/hold cancel


Composer in Dockerfile

Maybe change composer installation to COPY instruction from composer:2
Something like:
COPY --from=composer /usr/bin/composer /usr/bin/composer

Merged, thank you!


Add Dusk Ball as an Item which boosts speed

Its for fixing the Baton Pass clause in Enchanted Items, where Dusk Ball is the Enchanted Item for Speed boost.

Missing space


Support for public_url when building

What's the problem?
I'm using Zine version 0.2.1. I can't publish the build to Github Pages because the link to assets files are wrong.
When deploying to Github Pages, it's required that our assets url should be prefixed by the project name of our project.
How to reproduce the issue?

Initiate and build a simple zine project
use github action to publish the build, currently I'm using a really simple flow config file: https://github.com/DingDean/zine-blog-test/blob/master/.github/workflows/publish.yml
visit the github page link and you'll find the page is only rendered with raw html, without any css.

What's to be expected?
Can Zine provides a configuration public_url when building our magazine so that all the assets can be rightly prefixed?

Thanks for the feedback. We'll fix this ASAP.
Also, you can add a custom domain to Github pages to avoid path issues.


Auto scope

chore(package): add and update dependencies …
Update:
@cycle/core 3.1.x => 6.0.0-rc2
@cycle/dom 5.1.x => 8.0.0-rc2
Add:
@cycle/isolate 1.0.x
rx ^4.0.6
refactor(many): update with Rx and @cycle/dom …
Import named exports from Rx.
Use hyperscript helpers.
Rename list dataflow component to List.
feat(isolate): use isolate and rewrite to dataflow components …

Capitalize components and their respective files.
Isolate Item in itemWrapper.
Remove redundant name array.
Remove redundant CSS selectors in intent.

refactor(Item): use hyperscript helpers

Good job. When I was working on advanced-list-nest example, I noticed one way I can refactor the new dataflow component to not have any name or id secondary parameter. Like this https://github.com/cyclejs/cycle-examples/blob/auto-scope/advanced-list-nest/src/app.js#L56-L62 . Do you think you could update this PR to have the same approach? This way we don't leak parent concern ("do instances of my child dataflow component have ids attached to them so I can query them separately?") into the child ("I think I need an id for some reason").

Indeed.

Great, thanks


Error, no DATA reply

I always get "Error, no DATA reply". I tried time and again. The weird thing is: I already used this tool successfully two times. On this PC (Manjaro Linux). I even tried the same folder with the same flasher version (v57) again. For the life of me, I can't get it to work :-( I'm at a loss here. How can I debug this further? What could possibly be the reason for this. Manjaro is a rolling release Linux. Perhaps a new kernel, some permissions that got changed inadvertently?

Rnning in virtual machine? If yes that it might be isue between your host machine and virtual machine usb access. If not I'm sorry I have no idea and to be honest time for Manjaro Linux

No, I'm not running on a virtual machine and I'm already running as root. Fastboot, ADB etc. all run finde. But sure, totally understand you can't support any arbitrary system. Just thought the error message itself might point to something. Nevertheless: Thanks a lot for your answer and for making this tool.

I also run Manjaro and hit this error when trying to flash my Xperia 1 IV

What say your dmesg when you hit error?


Add release notes to README.md

These release notes are based on the git commit logs. They may be incomplete. They start at version 0.7.0 because that is the first release whose start and end are marked by git tags.
I wasn't sure which changes in 0.7.0 and 0.8.0 were breaking changes, but I'd like to add that information if possible.

Thanks, I put these on the releases page and added a link in 6abb248c15ffff8923a5bd23ec327a77d66dc25b.


Use Tag-Helpers

Addresses #1284

Hi @TravisBoatman, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@Rick-Anderson review

@TravisBoatman One minor change
Otherwise :shipit:

Excellent work, thanks Travis! 53f54c7ecb2b16568dcb159374d9e1d0d587a227


Envoy debug docker images do not contain debug symbols from v1.26.0

Title: Envoy debug docker images do not contain debug symbols from v1.26.0
Description:
Official envoy docker images with tags that have 'debug-' prefix do not have debug symbols from v1.26.0.
e.g. the image sizes of debug-v1.26.0 and v1.26.0 are the same(https://hub.docker.com/r/envoyproxy/envoy/tags?page=1&name=v1.26.0)
$ nm envoy
en: envoy: no symbols

Repro steps:
$ version=v1.26.0
$ docker pull envoyproxy/envoy:debug-${version}
$ containerID=$(docker create envoyproxy/envoy:debug-${version})
$ docker cp ${containerID):/usr/local/bin/envoy .
$ nm envoy

thanks for raising this @jparklab - i will take a look and see if i can see why this is happening

confirming that all 1.26 debug images are incorrect - including dev images - which kinda makes things easier as its not release specific

@jparklab afaict this is now fixed (not yet for releases tho)
$ docker run -ti --rm envoyproxy/envoy:debug-dev ls /usr/local/bin -lh
total 834M
-rwxr-xr-x 1 root root 469M Jan  1  2000 envoy
-rwxr-xr-x 1 root root 366M Jan  1  2000 envoy.dwp
-rwxr-xr-x 1 root root  19K Jan  1  2000 su-exec

thanks again for the report

@phlax Thanks for fixing this quickly. I see docker images on the official repo is still the same (https://hub.docker.com/r/envoyproxy/envoy/tags?page=1&name=v1.26.0). Will this fix be back-ported to the docker images, or will only be applied to new docker images?

Will this fix be back-ported to the docker images, or will only be applied to new docker images?

it has already been backported to the 1.26 branch and will be included in the next patch release - the existing images wont change


Contract Verification Error

Hello, I am having issues when I run the command to verify the deployed contract. I am running this command: yarn verify (ContactAddress) --network truffle. I deployed the contract successfully but verifying it I get this error:
Error in plugin @nomiclabs/hardhat-etherscan: The contract verification failed.
Reason: Fail - Unable to verify
How could I resolve this issue?

dont know what to do with this

Hi @Robcar-10 Check pinned post, Rinkeby network might be facing some issues due to high traffic. Patience is all that's needed


Vf activate doesn't cd to project directory

vf connect should also make vf activate automatically change directory into the project in the same way that workon does for virtualenvwrapper when a project directory has been set

@Kayra look into the "projects" addon, it's not core functionality of virtualfish but can be easily enabled. Just enable the plugin in your fish config:
eval (python -m virtualfish projects)

After enabling it, you can use
vf workon gigcomply

And it will cd to the configured project director.

I tried before using what I read in the docs but it didn't work. Works fine with your instruction, maybe I just didn't read correctly. Thank you.


ask for correct information for port of Skype for Business Online and Microsoft Teams

For 21vianet, 50K outbound port are still required for skype for business conference call.
Ask for correct information for port of Skype for Business Online and Microsoft Teams on this document.
Please contact me at<EMAIL_ADDRESS>
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0dd0d24e-7a31-8a50-ffdd-7823b6c6c01c
Version Independent ID: 601aeca3-2c5c-3dda-0402-e4fffaa98ae0
Content: URLs and IP address ranges for Office 365 operated by 21Vianet
Content Source: Enterprise/urls-and-ip-address-ranges-21vianet.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@officedocsbot assign @mypil

@XixiHuang333 - Thank you for submitting this feedback.
I will get this issue over to the Enterprise writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@JoeDavies-MSFT - Can you please share your insights on this issue?
Thank you.

@XixiHuang333 - Could you please assist us by suggesting how this content could be edited to incorporate your feedback? If you could suggest what the appropriate text and where it should be placed, I could assign one of our team members to create a Pull Request to get it added or you may also create a Pull Request to add in your suggestion and just link this issue so I can have the doc owner review and merge the content. Thank you.

HI Joyce,
Do you have previous document version of this?

From: Joyce Y<EMAIL_ADDRESS>Sent: Wednesday, May 22, 2019 10:01 PM
To: MicrosoftDocs/OfficeDocs-Enterprise
Cc: Xixi Huang; Mention
Subject: Re: [MicrosoftDocs/OfficeDocs-Enterprise] ask for correct information for port of Skype for Business Online and Microsoft Teams (#418)
@XixiHuang333https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FXixiHuang333&data=02|01|xixih%40microsoft.com|1fb30b7a92a64509297008d6debe0a56|72f988bf86f141af91ab2d7cd011db47|1|0|636941305131437463&sdata=Fvl6tBBZIDy1nBRBunzHEXNAjuOJTnYjBXyKRejXiq4%3D&reserved=0 - Could you please assist us by suggesting how this content could be edited to incorporate your feedback? If you could suggest what the appropriate text and where it should be placed, I could assign one of our team members to create a Pull Request to get it added or you may also create a Pull Request to add in your suggestion and just link this issue so I can have the doc owner review and merge the content. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-Enterprise%2Fissues%2F418%3Femail_source%3Dnotifications%26email_token%3DAJS4OUFBB2QPTYPCOY2GKZDPWVG47A5CNFSM4HOIVPT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV7EVOY%23issuecomment-494815931&data=02|01|xixih%40microsoft.com|1fb30b7a92a64509297008d6debe0a56|72f988bf86f141af91ab2d7cd011db47|1|0|636941305131447456&sdata=vVpOjPFKPS%2Fiw04%2BPFZm86EnetbQz8ybVbGHIOXEY1Y%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJS4OUDYWR4SRMDNQWVKY7LPWVG47ANCNFSM4HOIVPTQ&data=02|01|xixih%40microsoft.com|1fb30b7a92a64509297008d6debe0a56|72f988bf86f141af91ab2d7cd011db47|1|0|636941305131447456&sdata=zyoz9uhhmUpEIdqvompNBKPuohrzjQVImH%2FsYJ1%2FY4M%3D&reserved=0.

@XixiHuang333 - No, I don't have the previous document version. For this issue that you have, I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:  https://docs.microsoft.com/office365/admin/contact-support-for-business-products
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

@officedocsbot close

HI Joyce,
I am support engineer from Microsoft Office 365 support team. I have Office 365 21vianet customer who encountered skype for business call issue. I vaguely remembered 50K-60K should be allowed in previous version document of this page.
https://docs.microsoft.com/zh-cn/office365/enterprise/urls-and-ip-address-ranges-21vianet
There is no transport relay for Gallatin skype for business online.
Thus, we suggested customer allow the following port range then the issue was resolved.
TCP/443
UDP 3478-3481
TCP/UDP 50, 000 – 59, 000
In addition, Microsoft Teams is not available and there is no transport rely for Gallatin Office 365. Thus, the information of current version document is not accurate. As Office 365 support, we worry about more customer may be impacted by this.
Also CC technical writers. Sorry that if this is no appropriate way to loop you here.
Thanks,
Xixi
From: Joyce Y<EMAIL_ADDRESS>Sent: Friday, May 24, 2019 8:31 PM
To: MicrosoftDocs/OfficeDocs-Enterprise<EMAIL_ADDRESS>Cc: Xixi Huang<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-Enterprise] ask for correct information for port of Skype for Business Online and Microsoft Teams (#418)
@XixiHuang333https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FXixiHuang333&data=02|01|xixih%40microsoft.com|390431771f90497106e208d6e043bcaa|72f988bf86f141af91ab2d7cd011db47|1|0|636942978868385630&sdata=U5p39nJHovqmJhjr%2BPloaOpPqDY17C3fQMYmONxZOeE%3D&reserved=0 - No, I don't have the previous document version. For this issue that you have, I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products: https://docs.microsoft.com/office365/admin/contact-support-for-business-productshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Foffice365%2Fadmin%2Fcontact-support-for-business-products&data=02|01|xixih%40microsoft.com|390431771f90497106e208d6e043bcaa|72f988bf86f141af91ab2d7cd011db47|1|0|636942978868395622&sdata=3pw8UsFwpIe9cEfFbKJhaYbkzikHqx1spnd2SXtKGX8%3D&reserved=0
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-Enterprise%2Fissues%2F418%3Femail_source%3Dnotifications%26email_token%3DAJS4OUHK3I54VCNMCOXJXR3PW7NZ3A5CNFSM4HOIVPT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFFKWA%23issuecomment-495605080&data=02|01|xixih%40microsoft.com|390431771f90497106e208d6e043bcaa|72f988bf86f141af91ab2d7cd011db47|1|0|636942978868395622&sdata=TOzZdUmG8QWKg3Deh4sARWDUR0qD1hs9fdgBRuXiHxg%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJS4OUAWDMU4HABKELPJQNTPW7NZ3ANCNFSM4HOIVPTQ&data=02|01|xixih%40microsoft.com|390431771f90497106e208d6e043bcaa|72f988bf86f141af91ab2d7cd011db47|1|0|636942978868405617&sdata=YzqDvET47Iw8uZfiTJp9exRQhGlF%2FZg7O9AUMQ62U4c%3D&reserved=0.

@officedocsbot reopen

@XixiHuang333 - Thanks for sharing this additional information. I am reopening this issue to get this investigated. Please standby for further updates.

@MaratMussabekov - as discussed, kindly work on this issue. Thanks.

This is being investigated internally as a possible future update. Closing for now.


refactor: stop spreading challenge over the node

Instead of creating a Gatsby node with id of challenge.id, we create a
single node field that has all the challenge data.
While this makes the GraphQL queries more verbose, it means we're free
to create multiple nodes with the same challenge.id.
I think this is a smarter approach than https://github.com/freeCodeCamp/freeCodeCamp/pull/44418 which was my first attempt at this.

Cheers @nhcarrigan, @moT01 that's one massive blocker out the way. Thanks for all the help.


With attribution enabled for OSM

Description (required)
Fixes #2911
What changes did you make and why?
Enabled attribution as per https://docs.mapbox.com/help/how-mapbox-works/attribution/#mapbox-maps-sdk-for-android
Tests performed (required)
Tested on prodDebug
Screenshots showing what changed (optional - for UI changes)

I don't know why is travis still in progress. Will merge after it is done.

Actually travis has passed but somehow it wasn't able to notify Github about it. I saw the same happening for a few other PRs.

Weird... What should be our policy for such cases? I will go ahead and merge this time since changes probably safe.

I think it's OK to merge as long as the Travis site itself says the build passed.


Add Mina_stdlib

These functions keep being recreated in PRs against compatible. Lets just import the stdlib.

!ci-build-me

!ci-build-me

@mrmr1993 what about replacing usages of recreated functions introduced by other PRs with this new set, if you have certain PRs ready available in your memory?

what about replacing usages of recreated functions introduced by other PRs with this new set

The one I have in mind hasn't landed yet: https://github.com/MinaProtocol/mina/pull/14889. Nathan tells me that there have been others, but I don't care to find them atm.

Sure, ok


tsserver is not supporting module declaration overrides.

Hi!
I'm consuming declaration files from the node packages in my project so I'm not able to modify them.
Therefore I opted to override module definition.
I use redux and redux-thunk. Without this override of Dispatch type all my uses of dispatch will complain about wrong type (Correct behaviour). What redux-thunk does that it allows to dispatch to not dispatch object but also functions that can dispatch multiple objects.
TypeScript Version:
1.8.10
Code
// redux-dispatch-override.d.ts
import * as redux from 'redux';

declare module 'redux' {
    export interface Dispatch<S> {
        <R>(asyncAction: (dispatch: Dispatch<S>, getState: () => S) => R): R;
    }
}

Expected behavior:
Typescript compiler actually does accept this and will no longer throw errors which is very nice.
Actual behavior:
On the other hand there is a problem with tsserver.
In Webstorm tsserver will no longer consume definitions defined in redux node package. Instead it will try to find all definitions in this overriden declaration.

As far as i know webstorm does not use tsserver. what makes you believe it is a tsserver issue? do you see the same behavior on VSCode? what version of tsserver are you using?

Wow ! :)
It turns out you are right. VSCode behaves as expected!
I didn't know that WS is not using tsserver. Seems like a good default choice to use it.
Thanks for your reply!


Unavailable command can still be invoked and executed by clicking corresponding button

Should check for command availability.
That probably can be done in modal form. Also the state of the final button should be updated as user types values for command arguments

Yeah, the request for the command can be sent, but nothing happens, because the command is not available (no rule with ASG cells is satisfied). So that's not a problem at all, issue can be closed.


Update terragrunt.hcl

Ran Plan for dir: . workspace: default
Plan Failed: This project is currently locked by an unapplied plan from pull #15. To continue, delete the lock from #15 or apply that plan and merge the pull request.
Once the lock is released, comment atlantis plan here to re-plan.

atlantis plan

Ran Plan for dir: . workspace: default
Plan Failed: Pull request must be approved according to the project's approval rules before running plan.

Warning: The plan for dir: . workspace: default was discarded via the Atlantis UI.
To apply this plan you must run plan again.

atlantis plan

Ran Plan for dir: . workspace: default
Plan Error
running "/usr/local/bin/terraform plan -input=false -refresh -out \"/atlantis-data/repos/italorafaeltavares/Atlantis/17/default/default.tfplan\"" in "/atlantis-data/repos/italorafaeltavares/Atlantis/17/default": exit status 1
╷
│ Error: No configuration files
│
│ Plan requires configuration to be present. Planning without a configuration
│ would mark everything for destruction, which is normally not what is
│ desired. If you would like to destroy everything, run plan with the
│ -destroy option. Otherwise, create a Terraform configuration file (.tf
│ file) and try again.
╵


selectFilter is not filtering the table

Question
First of all many thanks for this project, it's great and provides so much functionality.
I have been trying to implement selectFilter but although the options appear in my select list, choosing an option results in no values being matched.
I have been able to implement textFilter without any issues.  I think that my issue is perhaps related to my selectOptions object, like the example it has 0,1,2 etc but, unlike the example, these values are not in the table.
  const selectOptions = {       0: "Rookie Ticket Variation RPS",       1: "Optics Season Ticket Red",       2: "Draft Picks College Bowl Ticket",       3: "Draft Picks Alumni Ink",       4: "Draft Picks Season Ticket Printing Plate Yellow",       5: "Rookie Playoff Ticket Variation RPS",       6: "Optics Season Ticket Gold",     };
Screenshots
Here is the table and filter select populated

And here is the empty table when an option is selected

codesandbox
This Sandbox demonstrates my issue

OK, I have found this example which demonstrates that key and value need to be the same in the object.  I'll modify my selectOptions  array to match this requirement


Angular 2 RC 4 Compatibility

Nice work on the library, but I can't use it in my project!...
Any chance of a release to support the up to date version of Angular 2?
Cheers.

That's because it's not yet finished yet, I'm very close to finalising an initial release, as soon as I do I'll publish it to npm!


Unexpected artifact in depth stream when capturing through transparent surfaces

Required Info

Camera Model
SR300

Firmware Version
multiple

Operating System & Version
Win 8.1 / Linux

Kernel Version (Linux Only)
4.4.0-101

Platform
PC

SDK Version
2.9.1

Description
We have been using different setups (PC, embedded platforms, etc) and various OS (Linux, Win) to test this behaviour and it is quite consistent (we tested on various SR300 firmwares and scanners, too).
We are trying to scan through transparent material, and we see a artifact, always at the same spot, when doing so.
We have tested on 3 different types of PMMA (obviously, glass is a no go since it's opaque to IR), including one that is opaque to visible light. For each test, we capture the scene that is after the material quite well (proportions, dimensions are respected and the model is as clean as if captured without the transparent material) BUT for a little spot in a specific place in the stream.
The PMMAs are clean and there is no default on the surface that could explain the artifact.
This "spot" is linked to the orientation of the transparent material : at orientations roughly > 45°, it gets out of the frustum and is not detectable anymore. But when the material is somewhat parallel to the lens, it's here.
We tested in a dark room too, to eliminate any visible light incidence.
I have attached pictures for 3 tests that we have done
(1) Transparent PMMA

(2) Opaque-to-Visible-Light PMMA

(3) Different Transparent PMMA

(1bis) Transparent PMMA at an angle (spot is no more visible)

My question is:

Do you guys have any idea why this happens ? It looks kind of a reflection of IR, but why would it only be a single spot ? The index of refraction differs between the two surfaces obviously but I don't see how the law of refraction would give such a result
Could this be a limitation of the library in itself ?
Can it be detected / removed by the lib ? We have tried to detect it and remove it via reconstruction algorithms (poisson, marching cubes etc) with smoothing parameters but it's not up to what we expect

Any suggestion welcome ;)
Thanks a lot
Best

Hi @tchapi
Could you please share the infrared images using the Viewer?
Also, I see you are using 2.9.1, please try with the latest release (2.11.0)

[Realsense Customer Engineering Team Comment]
hi @tchapi,
sorry, I want to confirm when you test, do you remove the lens cover?
just want make sure it's removed so we can continue.

somehow can't attach image from official account

Hi — Here it is with v2.11. The artefact is still very visible. I've attached the RAW file and the frame and intrinsic info (.raw.txt to rename → .raw) :

Frame
Info

Type
Depth

Format
Z16

Frame Number
41537

Timestamp (ms)
1394219.09

Resolution x
640

Resolution y
480

Bytes per pixel
2

Intrinsic
Info

Fx
476.389709

Fy
76.389709

PPx
315.013855

PPy
245.617447

Distorsion
Inverse Brown Conrady

Snapshot v2_Depth.raw.txt

Hi @tchapi,
Even though I'm not an expert, here is a small contribution.
I think your main problem is as you said :
"It looks kind of a reflection of IR [...]"
If this "blind spot" only appears when you try to scan special/reflective surfaces such as your PMMA, then I don't think you need to look any further. I'm pretty sure that the IR is somehow reflected by those surfaces and the camera is "blinding itself".
It's actually really easy to check, as @dorodnic said :
"Could you please share the infrared images using the Viewer?"
I would also suggest that you provide the RGB images, because you might simply see the reflection of the camera itself. If so, please check if the "blind spot" is actually superposed to the IR emitter location on the RGB image.
I might be wrong, but that's my best suggestion.
If the problem is not corrected, you could also try to adjust (if possible) this parameters :
Exposure
Gain
Laser Power
I would also point out :
"obviously, glass is a no go since it's opaque to IR"
I think this statement can be discussed because the SR300 laser wavelength is actually 860 nm, which is categorized as Near Infrared. The almighty Google says that this type of IR is not (or nearly not) affected by glass. Although, for greater wavelengths (such as those used for thermal imaging), you are right.
You might then be OK to do further tests with glass :)
Can somebody else confirm that ?

[Realsense Customer Engineering Team Comment]
Hi @tchapi,

It's a good check to IR/RGB images to understand the actual scene, not just review the depth image as @AntoineWefit and @dorodnic mentioned. 2. Those parameters @AntoineWefit said also affect the depth image.
Cover material can be PMMA or glass with AR coating to insure the high transmission rate. Higher than 92%@860nm recommended for better use range as you can review SR300 datasheet chapter 8.7.2.

Thanks for your valuable inputs.
Yes it's indeed the IR projector as we can see here and as I imagined :

In fact we had tested thick glass in the past (because we need a thick panel for our use case), and above 6mm it's literally opaque for the scanner, so I considered it a lost cause. Anti-glare / AR coating didn't help, and neither did polarised glass ... (we tested today)
Adjusting the laser power did not yield any result. As for gain and exposure, I haven't tested yet but I doubt this will improve things significantly since it will also have an effet on the quality of the scan itself (the model we want to scan behind the transparent surface).
So I guess I'm stuck with trying to remove this artefact programmatically. Any hint on how to do it ? I'm thinking about removing the dots "where the reflection is" (if ever I can find this easily) and then let Poisson do its magic to fill the hole, but any suggestion is welcome.
Thanks again for your time

I don't own an SR300 so I don't really know which parameters you can tune, but I think you should try 2 simple things that might solve your problem (under conditions), in order :

If your object-to-be-scanned if located at a fixed distance from the camera. -> Measure that distance precisely and set the value in the Intel RealSense Viewer software under Advanced Controls/Depth Table/Depth Clamp Min. What it's going to do is restricting the depth of the scanned area by ignoring anything below this distance. I understood that you want to see something behind a glass, and not something in front of it, correct ? By setting the correct distance, you could ignore anything, including the glass, "too close" to the camera, which is quite nice. The downside is that you are stuck with that distance and can't move your model/camera closer along the Z axis anymore. You'll get better results with the camera and the glass being parallel.
Be also aware that the units of the distance input is directly correlated with the value set under Controls/Depth Units (ie Depth Units : 0.001 -> Depth Clamp : [mm])

As I see, the artifact is pretty small. It's not that bad, so it should be easy to correct with some corrections, as you said. -> Go in the Intel RealSense Viewer software, and tick the Post-Processing box. In here, some options will impact the filling of the holes :

If you don't really care about the amount of vertices of your output, increase the Decimation Filter. From what I understood, the Filter Magnitude will divide the number of vertices by 2^(input value) (ie Filter Magnitude : 3 -> Output number of points = Max number of vertices/2^3). So basically, """less points = less artifact""" :P
Under Post-Processing/Spacial Filter/Holes filling, switch to 2, 4 or 8 pixels radius depending of the size of your holes. I wouldn't recommend to increase this value too much because it'll deteriorate your output, specially the border of your object.
Finally, under the Post-Processing menu again, there is the Hole Filling Filter. I find this one to be quite powerfull (a bit too much imho), but really difficult to use, so tune it with care.

Keep us updated and good luck !

Hello Antoine and thanks for your ideas.
I'll definitely test the depth clamp since the distance to the glass is mechanically fixed, so this could help a lot.
As for the post-processing options, it's hard to tune since we need a high number of points (and a good detail) for our use case, so I cannot decimate too much. I'll give it a go anyway (we already do heavy post-processing and fill holes to a certain extent).
Thanks again
Best

BTW, what is the easiest method to set depth clamp programmatically ? It seems it is doable in advanced mode but I only see this available for the D400 (not the SR300)?

As I don't own an SR300, I can't answer this question, sorry.

[Realsense Customer Engineering Team Comment]
Hi @tchapi,
"depthClampMin" parameter is not supported by SR300.

You can try the visual preset in realsense-viewer, like short range, mid range, etc to see how it affects. The major controls are accuracy, confidence and filter. You can have a try.
Probably, you can refer to the concept of rs-align code and have a kind of foreground removal based on the depth value you know to remove the near-range objects.

Thanks for this confirmation.
We have tried to fiddle with the presets but to no avail.
Just so anybody runs into the same problem, the easiest and most efficient way we found was to simply remove points near the "reflected IR center" before our reconstruction algorithm (Poisson). Fortunately this area was not a feature area for us.

YMMV but for us , this reflected IR center was located at {x: -0.0205f, y: 0.0100f } (in meters) and it had the shape of a rectangle (sort of) with dimensions {w: 0.0190f, h: 0.0160f}.

[Realsense Customer Engineering Team Comment]
Hi @tchapi,
Nice to hear that you resolved the issue. If no other question, will close this.


The page header vanishes if the content is taller than the screen

If there is a lot of content on a page, it will push out the page header.

Version<EMAIL_ADDRESS>

I can't reproduce this. Are you rendering Catalog inside some other content?

Does this happen here for you too? https://v4--catalog-docs.netlify.com/specimens/audio

Ah. I'm rendering from Next, which wraps the whole page inside a <div id="__next">. This has the style height: 100% by us, which is wrong and should be min-height: 100%.


Replace mlkit with zxing QR scanner

I wanted to give this as an option for #54. It works fine for me on the few devices I've tested, and the scanner documentation says it supports SDK 24+ by default, so there shouldn't be any problems. True, the interface is not quite as polished as the mlkit version, but for scanning a QR it's probably not a big deal.
This does not completely solve the file size issue. A large part of that is in RoboHash images, which would be fixed with my svg branch (needs a little work for PR). The other part of it would be doing a split APK for each platform. With this PR, replacing bitmap with svg robohash, and doing a split APK, the file size should go down to under 30 MB.

@vitorpamplona I missed this issue the first time round, but it seems everything is working now. I can scan dark/light/color QR codes with no issue from my old phone using this library.
Doing flavors is fine, but IMO it should be sort of the last choice, and this library seems to be working fine now with the correct settings.

I will test this tomorrow with my iPhones at the office

This now works great with Damus!


[BUG] Bloxstrap installing webview2 and taking so long

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?

How long have you waited for? It depends on the speed of your internet connection.

i experienced same thing but updating edge webview2 with winget seems to work
or just manually download microsoft edge webview2 installer and run it

fixed or not?

what version?

i've waited for three hours

i've waited for three hours

Open the %temp% folder, sort by date modified, and upload Bloxstrap's latest log file here.

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen.


Slippry slider plugin in joomla

Ive grown really fond Slippry and its really easy to use, but I'm changing CMS from pyrocms to joomla, and they only way it could work is as a module, is anyone willing to help with the project.

sounds very interesting, keep me posted :)

Here it is: https://github.com/ducklin5/Slippry-joomla
Again, its really simple. You have to input the code the way you normally would, but it allows you to use Slippry as a module in jommla. Its a way to avoid the code filtering. If anyone more experienced with joomla is interested, the module has alot of room for improvement.

Cool, thank you for this!


Support new download command

Is this why this plugin doesn't seem to be able to install new versions at the moment?
$ asdf list all k3d | wc -l
0
$ asdf list all k3d
$ echo $?
0

@MPV no should be unrelated - there's a new download command for asdf but there's compatibility. Mind opening a separate issue for the bug and I'll investigate

@MPV no should be unrelated - there's a new download command for asdf but there's compatibility. Mind opening a separate issue for the bug and I'll investigate

Yep, #3. Thanks.


Fix UI issue for image classification

When switch to NPU and choose model directly, it will throw error as the data type doesn't change correspondingly, fix it by clicking the correct data type if switch to NPU or CPU.

@mingmingtasd, @ibelem, PTAL, thanks!

LGTM, thanks! Good fix!


Update Istio app to use istioctl and 1.8

Update Istio app to use istioctl and 1.8
Expected Behaviour

Istio 1.18 is now available and is installed via a CLI (similar to how Linkerd works)
Current Behaviour

Still using the older helm chart
Possible Solution

Update https://github.com/alexellis/arkade/blob/master/cmd/apps/istio_app.go

Add istioctl as an app to arkade get (in tools.go)
Use istioctl to install Istio

In addition, consider using @stefanprodan's defaults from his Flagger e2e tests for a minimal installation.
https://github.com/fluxcd/flagger/commit/a2774d92da8cea75ad1dc0615338cef28143c6a0#diff-e608f1fdaeb7eddba9483ae06ebbc5eccf7ceaa4c6c5044084ebe8d4cef1242eR15-R17
Context
https://github.com/openfaas/faas-netes/issues/714#issuecomment-789156173

Any reason to prefer 1.8 vs 1.9?
let me know if you run into any issues

I will work on it.

Thank you @nitishkumar71


Supports Valibot's new pipe function

Compatible with Valibot's new pipe function
Valibot is expected to release a version with a new pipe function in the next version. The official change is scheduled for June, so we will need to make modifications to accommodate it.
https://github.com/fabian-hiller/valibot/pull/502

I am happy to help and answer questions.

valibot 0.31.0 or higher will support Node.js version 20 and above.
https://github.com/fabian-hiller/valibot/issues/596

This has been changed again to support Node.js 18.
https://github.com/fabian-hiller/valibot/issues/599


want to run task only once

e.g. git clone a repo

This feature request is not very useful.
Close


feat(generate): add directives

Closes #148

LGTM.

I'd suggest adding some information about the new generation in the readme as part of this PR

Yes, readme should be included.

Thanks for the feedback guys. I took the opportunity to improve the whole scaffolding session on the README. Please take a look and let me know if we can merge this in.

:+1: for aliases.

lgtm :+1:


Missing field transactionVersion

Following these docs: https://github.com/scs/substrate-api-client/tree/master/tutorials
Getting following error:
Running `target/debug/substrate-api-client-test`
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("missing field `transactionVersion`", line: 1, column: 317)', /home/dylan/.cargo/git/checkouts/substrate-api-client-9327f54164a9792a/999d407/src/lib.rs:163:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

our tutorial is outdated, I'm sorry. Please work with the examples. these should be up to date and tested by CI
src/examples

I did some research, seems like the this lib uses
[dependencies.sp-core]
version = '2.0.0-alpha.7'

Whilst the latest node template uses the rc versions..

@brenzi  the examples also don't work with latest node template

yes, this api client still depends on alpha.7 and only supports the template at alpha.7 state. Feel free to use our template fork.
We won't update the client until substrate 2.0.0 is finally released. Maintenance is too heavy.

@DylanVerstraete our master now supports 2.0.0-rc5, so your issue should be resolved now


Adding a second physics layer to a tilemap causes weird error and crash in certain situations

Godot version
4.0 beta 8 + Better Terrain Addon (Maybe relevant?)
System information
Win 10
Issue description
I added a second physics layer to my tilemap, then closed the editor via the top right close button, where a confirmation asked me what to do about unsaved work. I clicked Save and Exit which took a long time. During the, the console was spamming
ERROR: Index p_layer_id = 1 is out of bounds (physics.size() = 1).
   at: get_constant_linear_velocity (scene/resources/tile_set.cpp:5156)
ERROR: Index p_layer_id = 1 is out of bounds (physics.size() = 1).
   at: get_constant_angular_velocity (scene/resources/tile_set.cpp:5167)
ERROR: Index p_layer_id = 1 is out of bounds (physics.size() = 1).
   at: get_collision_polygons_count (scene/resources/tile_set.cpp:5183)
ERROR: Index p_layer_id = 1 is out of bounds (physics.size() = 1).
   at: get_constant_linear_velocity (scene/resources/tile_set.cpp:5156)

...repeatedly. Attempting to load this project then repeats this and it crashes.
If you instead save manually, it doesn't error out until loading the project.
Steps to reproduce

Download my project below (Does not appear to happen with new project)
Open World scene
Add a second physics layer to either Cliffs20 or Cliffs21 tilemap.
Close via [X]
`Save and Exit

You can manually save with no issue instead, however, next project load it will do the same thing.
Minimal reproduction project
HeartBeast ARPG.zip
I attempted to make an MRP from scratch but could not get the same error.

I am most suspicious about physics.size() = 1 in the error, along side the out of bounds error.

What do you mean by "add physics layer"? It's a property of TileSet.
In any case, I can't reproduce in beta 10.

"Adding a physics layer" is this:

I'll grab b10 and test, was putting it off until b11 as I figured it would be soonish and I didn't much over xmas break.

Am I able to reopen this? I'm now getting this randomly in the same project whenever I try to remove that second physics layer in b10

Okay, I've got what I believe is a non-sporadic bug example, but still not in an MRP.
Load the example (I'm in beta 11 now, but still same problem).
Run game - No console output
Add a second physics layer to TerrainLayer2 node
Run game - Console spam as above.
The tileset is not getting the correct Physics.size() set. You can also trigger the spam in other ways, such as selecting a different node and then going back to TerrainLayer2, but this is less reliable.
Example.zip


added a random number guessing game

guess a number between 1 and 10 and see if you're right!

Hacktober over / Cleaning up / No longer compatible in v3.0


chore: light mode for delete button, remove drop down

What does this PR do?
We cannot complete #376 because the issue to provide the component has stalled: https://github.com/containers/podman-desktop/issues/6898
In the meantime we can do two things:

Pick up light mode support by copying the current code from Podman Desktop.
Remove the menu property, so that we can remove the unused dependency on the the DropdownMenuItem component. (if we need dropdown support in the future, we should use/require the component)

Screenshot / video of UI
Minor - in light mode the delete button looks almost disabled before, with color variables it is black.
What issues does this PR fix or reference?
Related to #376.
Part of #536.
Fixes #371.
How to test this PR?
Just look at homepage in light mode.

Tested and LGTM!


not able to use the schedule module in the Windows server 2012 r2 edition ,

why I am not able to use the schedule module in the Windows server 2012 r2 edition ,
same code is working fine for me in the windows 10 desktop ,
But not in the windows server 2012

there could be multiple differences in how time is treated on OSs
Windows Server 2012 is too old and EOL
You need to upgrade at least to Server 2019


Persistence refactor

As prep work for introducing Facilities (no, honestly, that's why), pulled a bunch of common fields or to-be-common fields into base classes.

Person (and the upcoming Facility) is an EternalEntity that has a mandatory immutable Organization field: pulled that into OrganizationScopedEnternalEntity
TestOrder, TestEvent, and their NoJson doppelgängers have four common fields: patient, organization, deviceType, and result. These are pulled up into BaseTestInfo (rename suggestions welcome)

the result column is nullable in some cases but not in others: this is handled using an @AttributeOverride, which is a neat trick that I just discovered because I was sure it must exist
the deviceType foreign key relationship was previously optional in TestOrder, but per #75 and CDCGov/prime-central#151 it seems like it should be mandatory, so I did the first step suggested in #75 and made it mandatory.

As a consequence of that last bullet, organizations with no default device type will now be unable to create queue entries. That is not necessarily bad, but means we should potentially be more careful about making sure that the default device type is never accidentally cleared...

Just a couple of questions/comments on the PR. This is my favorite kind of PR, one that removes more code than it adds. 🥇

Sadly, my response to @nickrobison-usds made this into a zero-net-lines PR instead of a negative-net-lines PR.  Also at some point people may decide that we don't like the mandatory default-device rule, but until then, let's do this.


Footnote updates

This PR updates the format of all footnotes from LaTeX format to JB format. Partially addresses #643.
@rickecon

Codecov Report

Merging #650 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   84.30%   84.30%
=======================================
  Files          47       47
  Lines        6959     6959
=======================================
  Hits         5867     5867
  Misses       1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45743b1...c136d91. Read the comment docs.

Looks good to me.  Thanks @chusloj - are you ok with me merging?

@jdebacker Ready to merge.

Thanks @chusloj !


Close #259: Customize gradle-wrapper.properties

Summary

add new binding of type gradle-wrapper that allows the user to, for example, override the networkTimeout or distributionUrl.

Use Cases
for example when default timeout is not enough to dwonlaod the gradle distribution zip, of if the user wants to doanlod the distribution zip from a different url than gradle default url.
Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

see how to use in the samples: https://github.com/paketo-buildpacks/samples/pull/585


Project Files – Body Copy

Created by Jordan Lambrecht via monday.com integration. 🎉

@jordanlambrecht Kind of hate this copy but idk:
Expanding educational opportunities is more possible now than ever before with advancements in technology. PB believes open-sourcing our files is one of countless ways we can break down legal, financial, or technical barriers that prevent creativity and believe that everyone should have access to high-quality educational experiences and resources.


Validate does not detect missing field in required

Running with the validate command does not detect the case where the required field for a schema refers to a field that does not exist.
I had a model that looked like this.
components:
   schemas:
      Audit:
         properties:
             createDate:
                 type: string
         required: [ createDate ]

The schema was valid. I then changed the name of a property but forgot to rename the field in the required list and it validated successfully anyway.
components:
   schemas:
      Audit:
         properties:
             createDateTime:
                 type: string
         required: [ createDate ]

Got bitten by this bug, too.

Is anyone monitoring this…?

Stand by - there will be a pull request soon.


Refactor/flow profile

Flow Profile inherits from Action - instead of Compute

This PR will be superseded by a C++/CUDA implementation of flow profiling for performance.


Document height calculation seems inaccurate

It seems that $(document).height() and  document.documentElement.scrollHeight behave differently according to this following demo
http://codepen.io/hardfist/pen/oxaqrp?editors=1111

Yep, your are right, should be http://stackoverflow.com/a/1147768/1219343

I can submit a PR later on today

cool, that would be great


Update index.html

PR Description 📜
Added a copyright label in the footer
Fixes #3075

Mark the task you have completed ✅

[.] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[.] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[.] My changes generates no new warnings.
[ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[.] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸
Suggest any changes you want me to make

Thank you soo much for contributing to our repository 💗

Thank you @dishathakurata ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Please assign this issue to me under GSSoC '24
Thank you in advance @kunjgit 💗

you are not having significant changes in this PR you can assign yourself an issue as shown in instructions make sure that you are having proper changes then only making PR !

Thank you  @dishathakurata , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Panic when stopping infinite attack

ali/gui/keybinds.go:36

It's happening because of:
panic: send on closed channel

goroutine 84 [running]:
github.com/nakabonne/ali/gui.attack.func1(0x7ec980, 0xc00024a080, 0xc000254420, 0x7ffe01d5afea, 0x15, 0x32, 0x2540be400, 0x6fc23ac00, 0x7802fb, 0x3, ...)
	/home/brenol/goworkspace/src/github.com/brenol/ali/gui/keybinds.go:36 +0xd7
created by github.com/nakabonne/ali/gui.attack
	/home/brenol/goworkspace/src/github.com/brenol/ali/gui/keybinds.go:34 +0x19e


Missing of basecall_comb.py and Questions about the overlap parameter of the input channel

Hi @marcpaga , thanks for your great work! I'm current using your code to implement some basecaller with mix network architecture. But found two issue about that:

Missing Script in Repository: I noticed that the GitHub repository seems to be missing the ./scripts/benchmark folder, which should contain the basecall_comb.py script. This script is essential for the basecalling process of the mix architecture basecaller network. Could you please check and possibly update the repository with this script?

Inconsistency in Overlap Parameters: I've observed an inconsistency in the overlap parameters between the input and output. Specifically, in basecalling_architectures/src/classes.py, the BaseFast5Dataset class is initialized with a window size of 2000 and an overlap of 400 at the input channel. However, the default overlap for the output, corresponding to the 2000 chunk size (window size), is set to 200. This discrepancy seems to cause repeated bases in the resulting fastq file. After aligning the overlap size in the BaseBasecaller class to 400, as in BaseFast5Dataset, the issue was resolved. Does the difference overlap size between the input and output channel an expected situation?

https://github.com/marcpaga/basecalling_architectures/blob/f8686069c3021304aac03bf99bdb07849911ab00/src/classes.py#L1105-L1117
https://github.com/marcpaga/basecalling_architectures/blob/f8686069c3021304aac03bf99bdb07849911ab00/src/classes.py#L1275-L1277
Thanks in adavnce!

Hi @sparkcyf,

Missing Script in Repository: I noticed that the GitHub repository seems to be missing the ./scripts/benchmark folder, which should contain the basecall_comb.py script. This script is essential for the basecalling process of the mix architecture basecaller network. Could you please check and possibly update the repository with this script?

Sorry about this, there was a script called basecall_grid_analysis.py that does that. I have renamed it to basecall_comb.py as it is indeed a more appropiate name given he naming scheme. I have also updated its CLI interface. Please let me know if you run into any problems with this script.

Inconsistency in Overlap Parameters: I've observed an inconsistency in the overlap parameters between the input and output. Specifically, in basecalling_architectures/src/classes.py, the BaseFast5Dataset class is initialized with a window size of 2000 and an overlap of 400 at the input channel. However, the default overlap for the output, corresponding to the 2000 chunk size (window size), is set to 200. This discrepancy seems to cause repeated bases in the resulting fastq file. After aligning the overlap size in the BaseBasecaller class to 400, as in BaseFast5Dataset, the issue was resolved. Does the difference overlap size between the input and output channel an expected situation?

This is indeed an inconsistency in default parameters, it doesn't make much sense to have different parameters for this. I have changed the default to 200. Thanks for spotting this.

Thank you for clarfying this! I'll try to use the same overlap parameter at BaseFast5Dataset and BaseBasecaller for my further basecalling workflow.


feat(expr): support some date/time ops

Signed-off-by: Shmiwy<EMAIL_ADDRESS>I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
support these expr

date + int32
int32 + date
date + time
time + date
time - time

Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
#924

cc @BugenZhao would you please take a look? Thanks!

The cause of this error could be something like this， the parser we used is not support '24:00:00'
https://github.com/singularity-data/risingwave/blob/7808cacc85ebae4347469ac9a19c7700b1c0c570/src/expr/src/vector_op/cast.rs#L48
parse_from_str will return err  and the NaiveTime we inport in our project is not support 24:00:00;

Ok. That also makes sense. So we will never have a diff of two times larger than 1 day, right?

I tried it on my laptop. I think the error message is also not what we expected.
dev=> select TIME '24:00:00';
ERROR:  RPC error: Status { code: Internal, message: "Expr error: Parse(\"Can't cast string to time (expected format is HH:MM:SS[.MS] or HH:MM)\")", metadata: MetadataMap { headers: {"risingwave-error-bin": "CBwSWkV4cHIgZXJyb3I6IFBhcnNlKCJDYW4ndCBjYXN0IHN0cmluZyB0byB0aW1lIChleHBlY3RlZCBmb3JtYXQgaXMgSEg6TU06U1NbLk1TXSBvciBISDpNTSkiKQ"} }, source: None }

Ideally, it should be like "24:00:00"
dev=> select TIME '24:00:00';
Expr error: Can't cast string to time (expected format is HH:MM:SS[.MS] or HH:MM)

The related doc issue is https://github.com/singularity-data/risingwave-docs/issues/161.
Will update the doc PR once it's merged.