upgrade to support dbt-core v1.8.0

Background
Minor version v1.8 is targeted for final release within dbt Core on May 9, 2024.
As a maintainer of a dbt adapter, we strongly encourage you to release a corresponding minor version increment to ensure users of your adapter can make use of this new minor version.
As of dbt-core v1.8.0, we no longer need to encourage you to release a new minor version anytime we do. After following the linked upgrade guide, we guarantee your adapter will be forward compatible with all future minor versions of dbt-core (at least until v2.0 which is not yet planned).
Another major win: you can now make your adapter truly SemVer compliant, as you can release new versions of your adapter without needing to wait for a new dbt-core release. You can actually follow
How to upgrade
https://github.com/dbt-labs/dbt-core/discussions/9798 is an open discussion with more detailed information. If you have questions, please put them there!

This has been completed by @howareyouman as per #244


[models.base.Model] editable=False in Field will prevents save/update

This will permit us to use editable=False in readonly fields like:

memberOf = MultiValueField(db_column='memberOf', editable=False, null=True)
createTimestamp =  DateTimeField(db_column='createTimestamp', editable=False, null=True)
modifyTimestamp =  DateTimeField(db_column='modifyTimestamp', editable=False, null=True)
creatorsName = CharField(db_column='creatorsName', editable=False, null=True)
modifiersName = CharField(db_column='modifiersName', editable=False, null=True)

PPolicy field example:

pwdFailureTime = MultiValueField(db_column='pwdFailureTime', editable=False)
pwdChangedTime = TimeStampField(db_column='pwdChangedTime', editable=False)

CI failed because an import  that come from the original master branch code.
find . -type f -name "*.py" | xargs grep  "from django.conf import settings"
./ldapdb/__init__.py:from django.conf import settings

Could it be fixed by code mantainers?

Can you explain why you think rewriting this code completely as a for loop is necessary?

Also, do you think that is is correct? Setting editable=False normally only disables validation on the field and removes it from ModelAdmin views. It does not prevent the data from being changed or saved to the database. I don't think we should divert from that in ldapdb.

After thinking about this, I don't think ldapdb should add any semantics to attributes that exist in Django models itself. editable just removes the field from forms, so this is what should happen for LDAP models as well.
If you think this is important to have, I suggest adding a new attribute that makes a field truly read-only to Django upstream.
@rbarrois can of course override this decision ☺.

You spent 3 post to say nothing interesting.
I'd like instead to get some suggestion for a better semantic, to deal with this new feature...
but only useless words from you, as usual. Very boring!

Maybe you should refrain from contributing in the future. Thank you ☺!

For everyone who cannot follow along the discussion, here is a conclusion:
Setting editable=False right now does exactly the same in ldapdb models as it does in any other Django model ☺.


Updated Readme.md

Issue Resolved ! Please Review this and Merge

@AkshayPratapSingh09 Keep only those component in the readme which are present in this figma design for feature card
https://www.figma.com/file/qzwugAfEB1GL4FgWXw9R3Z/SeamLess-UI-Dev?node-id=0%3A1&t=qRahoepdI3B98cVA-1


Delete Animated option and add a new Aggregation method

When style is set as animated some things needs to happen:

if the style applied does not use any variable it should work like it's working with now

if we have one style using "by value"

if it's a category attribute: torque style should use cdb_mode([attribute]) as aggregation and use the turbocarto for the category
if it's a ramp attribute: torque style should use avg([attribute]) as aggregation and use the turbocarto for ramps

if we have more than one style attribute using "by value" -> we can't do anything with torque here since we don't have multivariable torque <- cc @saleiva. One solution would be to disable animated when this happen but not sure how hard is to explain that limitation to the user.

cc @xavijam

When having by value in size and color, we will just keep color. if having
just one, we will keep that one.
@urbanphes we need to edit the component to say "Animated maps only support
one variable by value - or something like that" when this happens.
2016-07-20 16:38 GMT+02:00 javi santana<EMAIL_ADDRESS>
cc @xavijam https://github.com/xavijam
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/9010#issuecomment-233969383,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIENajtFfdOHvS03wUUPsl9di32DSMRks5qXjMDgaJpZM4JQ1wy
.

--
Sergio Alvarez Leiva

@xavijam I'm going to do the style generation part

Ok!, but design is needed right?

yes, there are two parts of this issue:

style generation <- me
UI changes  <- design team and you

From the UI;

Delete the animated check in all parts.

Add new aggregation method ANIMATED (with its configuration)

cc/ @saleiva @javisantana @xavijam

dios os quiere

Top priority since this can help with
https://github.com/CartoDB/cartodb/issues/9097
https://github.com/CartoDB/cartodb/issues/9100
And many more...

This will need migration changes from old editor to new one, cc @juanignaciosl.

In order to cluster all the animated types under the same aggregation, we need to segment the type (heatmap or pixel):

Note that TYPE selector changes whatever fields it needs.

Further to torque categories, I've tried what @javisantana proposed but I can't make it work. After a talk with @rochoa, that cdb_mode thing should use CDB_Math_Mode, but in any case it doesn't take into account the ramp color, it just take the first one. The thing I've tried is:
Map {
  -torque-frame-count: 172;
  -torque-animation-duration: 60;
  -torque-time-attribute: "cartodb_id";
  -torque-aggregation-function: "CDB_Math_Mode(category_n)";
  -torque-resolution: 4;
  -torque-data-aggregation: linear;
}
#layer {
  marker-width: 7;
  marker-fill: ramp([category_n], (blue, yellow, red)); // category_n -> strings
  marker-allow-overlap: true;
  marker-line-width: 1;
  marker-line-color: #fff;
  marker-line-opacity: 1;
}
#layer[frame-offset=1] {
  marker-width: 9;
  marker-fill-opacity: 0.5;
}
#layer[frame-offset=2] {
  marker-width: 11;
  marker-fill-opacity: 0.25;
}

Avoid using // comment style.
What torque.js version are you using?

I added the comment in the code above, not in the real CartoCSS.
Torque version 2.15.1


Process data

In this milestone I;

Created models for comment, like, post, and user tables.
Added an application_record to be able to use ActiveRecord
Added custom methods to each model.

@julie-ify Thank you for reviewing my project. I will implement the changes before merging.


Moving changeset map controls to osmcha

Currently to filter by action and type requires to use the cmap options.
We would like to move them to osmcha to be better aligned with the design.

This was fixed in #58


add map

Description
Add a map method in the  NumArray class
Motivation and context
When dealing with a simple neural network, I need to apply a specific activation function on each value. At the moment only abs does apply a function to everything. Adding map allow the user to apply the function he wants. In my case sigmoid.
How has this been tested?
There is nothing much to test as most of the work belong to the user :)
Screenshots (if appropriate)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply.
Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes.
[x] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Hello @GregoireHebert
thank you very much for the PR. Would you like to merge the branch 1.1 again into your branch? As branch 1.1 was outdated, I made it passing Travis again.
Can you also please make your tests passing?
Best Regards
Gordon

Hey @GordonLesti :)
Sure I'll do that :)
And speaking of branches, I selected the 1.1 but it's an additional feature... I thought 1.2 was a best choice. WDYT ?
I'll do the merge in the train tonight.

Seems good to me :)

ping @GordonLesti  :D

Yup sure ! Fine to me :)

I have created a tag https://github.com/NumPHP/NumPHP/releases/tag/v1.2.0


Remove the useless import in response

Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Add or update relevant docs, in the docs folder and in code.
[x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[x] Add .. versionchanged:: entries in any relevant code docs.
[x] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

I've changed the target to 2.0.x.
Please rebase this to 2.0.x, and squash work into a single commit.
git rebase -i --onto origin/2.0.x origin/main
git push -f

@pgjones Done


chore: change order of tab on explore data panel

SUMMARY

show metrics before columns on explore data panel

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TEST PLAN

ADDITIONAL INFORMATION

[x] Has associated issue: #12316
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12335 (8be41aa) into master (076c31d) will decrease coverage by 15.55%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #12335       +/-   ##
===========================================
- Coverage   66.60%   51.04%   -15.56%
===========================================
  Files        1002      466      -536
  Lines       49330    16811    -32519
  Branches     5020     4321      -699
===========================================
- Hits        32855     8581    -24274
+ Misses      16333     8230     -8103
+ Partials      142        0      -142

Flag
Coverage Δ

cypress
51.04% <100.00%> (+3.51%)
:arrow_up:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rontend/src/explore/components/DatasourcePanel.tsx
88.23% <100.00%> (-2.01%)
:arrow_down:

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

superset-frontend/src/components/IconTooltip.tsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...end/src/SqlLab/components/ExploreResultsButton.jsx
8.00% <0.00%> (-84.00%)
:arrow_down:

... and 874 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076c31d...8be41aa. Read the comment docs.

Codecov Report

Merging #12335 (8be41aa) into master (076c31d) will decrease coverage by 15.55%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #12335       +/-   ##
===========================================
- Coverage   66.60%   51.04%   -15.56%
===========================================
  Files        1002      466      -536
  Lines       49330    16811    -32519
  Branches     5020     4321      -699
===========================================
- Hits        32855     8581    -24274
+ Misses      16333     8230     -8103
+ Partials      142        0      -142

Flag
Coverage Δ

cypress
51.04% <100.00%> (+3.51%)
:arrow_up:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rontend/src/explore/components/DatasourcePanel.tsx
88.23% <100.00%> (-2.01%)
:arrow_down:

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

superset-frontend/src/components/IconTooltip.tsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...end/src/SqlLab/components/ExploreResultsButton.jsx
8.00% <0.00%> (-84.00%)
:arrow_down:

... and 874 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076c31d...8be41aa. Read the comment docs.

OK for me after test!

OK for me after test!


November release notes

We need to publish November release notes article to give overview of changes made in Artipie during the month

here is list of all merged PRs for past 30 days:

#376 - Take not root keys into account @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/379
#376 - IT added @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/378
#376 - added subdirs to location in primary @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/377
#227 - temp dir is cleaned up @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/375
#227 - extend tests with invalid package @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/374
#323 - use XmlException for errors with xml metadata @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/373
#323 - created XmlException @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/372
#359 - use StorageHasRepoMd @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/371
#359 - Verify repomd.xml @olenagerasimova: https://github.com/artipie/rpm-adapter/pull/370
#139 - Fix tgz regex @genryxy: https://github.com/artipie/npm-adapter/pull/147
Public ctor in ContentAs @olenagerasimova: https://github.com/artipie/asto/pull/295
#293 - moved ContentAs class @olenagerasimova: https://github.com/artipie/asto/pull/294
#286 - CacheControl signature changed @olenagerasimova: https://github.com/artipie/asto/pull/292
#286 - changed Cache to use Remote @olenagerasimova: https://github.com/artipie/asto/pull/291
#286 - added Remote interface @olenagerasimova: https://github.com/artipie/asto/pull/290
#287 - Added FailedCompletionStage and it's usage @olegmoz: https://github.com/artipie/asto/pull/288
Updated rpm to 1.3.2 @olenagerasimova: https://github.com/artipie/artipie/pull/771
#606 - Add authentication push and install IT for Gem @genryxy: https://github.com/artipie/artipie/pull/767
#597 - Re-enabled NuGet and Docker proxy integration tests @olegmoz: https://github.com/artipie/artipie/pull/765
#680 - Fix for integration tests action @olegmoz: https://github.com/artipie/artipie/pull/764
#597 - Configs reading fixed @olegmoz: https://github.com/artipie/artipie/pull/762
#679 - NuGet upgraded to 0.4, tests enabled @olegmoz: https://github.com/artipie/artipie/pull/760
#597 - All repository config creation code duplication removed @olegmoz: https://github.com/artipie/artipie/pull/759
#606 - Verify push and install for Gem @genryxy: https://github.com/artipie/artipie/pull/758
#597 - Unified code for reading repository config by name @olegmoz: https://github.com/artipie/artipie/pull/757
#755 - docker-adapter upgraded to 0.6 @olegmoz: https://github.com/artipie/artipie/pull/756
#730 - use ContentAs from asto @olenagerasimova: https://github.com/artipie/artipie/pull/754
#607 - Verify whether index.yaml is present HelmIT @genryxy: https://github.com/artipie/artipie/pull/753
Updated asto, maven and python @olenagerasimova: https://github.com/artipie/artipie/pull/752
#730 - use RsJson from http @olenagerasimova: https://github.com/artipie/artipie/pull/751
#607 - Verify upload chart @genryxy: https://github.com/artipie/artipie/pull/749
#730 - artipie API slices changed @olenagerasimova: https://github.com/artipie/artipie/pull/748
#730 - user API @olenagerasimova: https://github.com/artipie/artipie/pull/747
#730 - storage and repo API @olenagerasimova: https://github.com/artipie/artipie/pull/746
#700 - Removed deprecated classes usage in ApiAuthSlice @olegmoz: https://github.com/artipie/artipie/pull/745
#730 - RepoPermissions signature changed @olenagerasimova: https://github.com/artipie/artipie/pull/744
#737 - pypi-proxy IT fixed @olenagerasimova: https://github.com/artipie/artipie/pull/743
fix #740 @iaroslavscript: https://github.com/artipie/artipie/pull/741
#712 - Add npmProxyIT @genryxy: https://github.com/artipie/artipie/pull/739
#700 - Extracted ApiAuthSlice @olegmoz: https://github.com/artipie/artipie/pull/736
#729 - remove IOException from Settings @olenagerasimova: https://github.com/artipie/artipie/pull/735
#700 - Extracted Cookies from AuthApi @olegmoz: https://github.com/artipie/artipie/pull/733
#729 - yaml mapping instead of string field in YamlSettings @olenagerasimova: https://github.com/artipie/artipie/pull/732
#700 - Extracted ApiPermissions from AuthApi @olegmoz: https://github.com/artipie/artipie/pull/731
#349 - Added UploadsLayout and it's default implementation @olegmoz: https://github.com/artipie/docker-adapter/pull/352
#349 - Added Layout, ManifestsLayout and it's default implementation @olegmoz: https://github.com/artipie/docker-adapter/pull/351
#349 - Added BlobsLayout and it's default implementation @olegmoz: https://github.com/artipie/docker-adapter/pull/350
#346 - Removed forced prefix "docker/registry/v2" @olegmoz: https://github.com/artipie/docker-adapter/pull/347
#344 - No blob overwrite in AstoBlobs @olegmoz: https://github.com/artipie/docker-adapter/pull/345
#341 - Changed target version to Java 8 @olegmoz: https://github.com/artipie/docker-adapter/pull/343
#341 - Using FailedCompletionStage @olegmoz: https://github.com/artipie/docker-adapter/pull/342
#261 - Extracted AuthSlice and AuthScheme from BasicAuthSlice @olegmoz: https://github.com/artipie/http/pull/265
#261 - Lazy authentication in BasicAuthSlice @olegmoz: https://github.com/artipie/http/pull/262
#258 - Added Permission.All @olegmoz: https://github.com/artipie/http/pull/259
#222 - support absent content @olenagerasimova: https://github.com/artipie/maven-adapter/pull/223
#219 - Fix MavenProxySlice response @genryxy: https://github.com/artipie/maven-adapter/pull/220
#117 - Repository made async @olegmoz: https://github.com/artipie/nuget-adapter/pull/122
#117 - Repository.versions made async @olegmoz: https://github.com/artipie/nuget-adapter/pull/121
#117 - Repository.nuspec made async @olegmoz: https://github.com/artipie/nuget-adapter/pull/120
#117 - Nuspec and Versions class changed to be async @olegmoz: https://github.com/artipie/nuget-adapter/pull/119
#117 - Nupkg and Hash classes changed to be async @olegmoz: https://github.com/artipie/nuget-adapter/pull/118
#149 - return 404 on absent content in proxy @olenagerasimova: https://github.com/artipie/pypi-adapter/pull/150
#147 - names normalization in proxy @olenagerasimova: https://github.com/artipie/pypi-adapter/pull/148
#145 - proxy redirects tests @olenagerasimova: https://github.com/artipie/pypi-adapter/pull/146
#77 - Verify metadata for same chart @genryxy: https://github.com/artipie/helm-adapter/pull/79
#77 - Verify added correct metadata for chart @genryxy: https://github.com/artipie/helm-adapter/pull/78
#41 - Verify digest from index.yaml @genryxy: https://github.com/artipie/helm-adapter/pull/76
#74 - Use eo-yaml library @genryxy: https://github.com/artipie/helm-adapter/pull/75
#10 - Post about how to configure maven repo @genryxy: https://github.com/artipie/blog.artipie.com/pull/11
#5 - October release notes @olenagerasimova: https://github.com/artipie/blog.artipie.com/pull/8
#2 - removed CredsConfigYaml @olenagerasimova: https://github.com/artipie/management-api/pull/11
#2 - RepoPerms.FromSettings removed @olenagerasimova: https://github.com/artipie/management-api/pull/10
#2 - Users.FromStorageYaml removed @olenagerasimova: https://github.com/artipie/management-api/pull/9
#2 - RepoPermissions.FromSettings removed @olenagerasimova: https://github.com/artipie/management-api/pull/8
#2 - FakeUsers implemented @olenagerasimova: https://github.com/artipie/management-api/pull/7
#2 - readme and rultor config @olenagerasimova: https://github.com/artipie/management-api/pull/6
#2 - actions added @olenagerasimova: https://github.com/artipie/management-api/pull/5
#2 - API slices moved @olenagerasimova: https://github.com/artipie/management-api/pull/4
Created release action @olenagerasimova: https://github.com/artipie/pypi-example/pull/3
Proper naming @olenagerasimova: https://github.com/artipie/pypi-example/pull/2
Initial commit @olenagerasimova: https://github.com/artipie/pypi-example/pull/1


GitHub App integration to Slack does not work with this repository

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Cannot establish the integration to Slack using GitHub App for Slack
Somehow this repository cannot be found using the GitHub App for Slack. I'd like to subscribe to the new releases using the GitHub App which would post a message to the slack channel when new release is published.
GitHub App uses the following syntax: /github subscribe microsoft/azure-pipelines-tasks releases
That command would work, but running the same command using this repository will fail. One can also paste the complete URL to the repo after keyword subscribe.
Could you please check if there is a setting in your repository that is disallowing (I assume this is using some kind of webhook) this operation? It would be nice to automatically get notified of new releases or issues. I understand this is not an issue in this module or code, but something that is nice to have and most likely just one setting that is preventing fans of this repo of using the GitHub App for Slack.

Steps to Reproduce

Install GitHub App on your Slack organization (https://github.com/integrations/slack#configuration)
Run /github subscribe microsoft/azure-pipelines-tasks to subscribe to the repo that works
Run /github subscribe azure/terraform-azurerm-caf-enterprise-scale to subscribe to this repo. Does not work.
Run /github unsubscribe microsoft/azure-pipelines-tasks to unsubscribe to the repo that worked before.

Screenshots
I assure that we have the GitHub App installed since it is working fine with other repositories.

Hi @tohov, Are you able to integrate with any repo in the Azure GitHub org out of interest? Say the main Enterprise-scale one? Azure/Enterprise-scale

No, actually I'm not. I tried Azure/Enterprise-scale and Azure/azure-quickstart-templates. Seems like there are different settings in Microsoft org and Azure org. Is there anyone you could escalate this issue to?

Hi @tohov,
Thanks for the quick response. So to confirm, you can for the the Microsoft org but cannot for the Azure org?
I have already started a discussion via our channels internally, but the above information would be really useful 👍
Let me know
Thanks
Jack

Yes, I confirm. I can use the feature for Microsoft org but cannot for the Azure org.

Something in this org and repository has been done right to allow the app to use webhook to post messages into Slack: https://github.com/microsoft/azure-pipelines-tasks

Cool thanks for the update. I have passed that on internally. Will keep you posted.
Thanks

Hey @tohov,
Could you try the integration again to this repo? Not saying it will work but may have enabled it based on internal feedback?
Let me know
Thanks

@jtracey93 It works now. Nice! Really awesome! Thank you so much. Following new releases just got so much easier for us.


Getting a ConnectionClose('ErrorCodes.UnknownError')

Please mention that in the documentation as to what it means.
I am using Python 3.7, running on Windows 10.
== Cut and Paste ==
import os
from azure.servicebus import ServiceBusClient
CONNECTION_STR="Endpoint=sb://personalservicebus.servicebus.windows.net/;SharedAccessKeyName=PersonalAccessKeyName;SharedAccessKey=personalAccessKey"
servicebus_client = ServiceBusClient.from_connection_string(conn_str=CONNECTION_STR)
exit
== Done Cut and paste of code ==
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfacc7cf-4224-9bd8-6211-29244cf60a83
Version Independent ID: a940a6f2-e1a9-d32b-4303-ab7705753942
Content: Azure Service Bus - messaging exceptions
Content Source: articles/service-bus-messaging/service-bus-messaging-exceptions.md
Service: service-bus-messaging
GitHub Login: @axisc
Microsoft Alias: aschhab

@kiranshashiny Thank you for your feedback! Since this channel is for driving improvements towards MS Docs, could you provide the details of the specific section in the documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team.

@kiranshashiny Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Yes, please close it.
I was unable to get the link from where I came here.
I will reopen or open a new one if I get the right links.
Appreciate your time in this.


Unable to Access Project on oss.gallery After Removing Self from Team Section

I recently tried to add the open-sauced/app project to the oss.gallery platform. After adding it, I noticed that my GitHub profile was listed as the founder in the team section, which was not accurate. I edited the project to remove myself from the team section. However, after doing so, I lost access to the project listing. When I tried to add the project again, I received a message stating that it was already added, but I can no longer see or manage it. I'm afraid this wouldn't allow addition from @open-sauced themselves 😢
The Project Listing - https://oss.gallery/projects/app
Expected Behavior
I should be able to re-add the project to oss.gallery after removing it from the team section, without encountering any issues. or better-still someone should be able to claim and manage a listing.
Steps to Reproduce

Add a project to oss.gallery.
Edit the project to remove yourself from the team section.

Proposed Solution
Implement listing claiming for listings on oss.gallery. This feature could verify if a user has at least write access to the project in question before allowing them to manage the listing. This would prevent situations where users inadvertently lose access to their project listings and allow listing claim from the appropriate owners.

Yeah! I also noticed this issue


Check shortcuts on MacOS 12

https://toolboxpro.app/blog/adding-shortcuts-to-an-app-part-three

Fixed by #144


Update README to match pre-commit config

See https://pre-commit.com/#2-add-a-pre-commit-configuration.
I received an error when using the current suggestion.

many thanks:)


[Thehive] single task is not added

Fixed: If tag is single is ignored
Sorry for black reformatting :angel:

Nice catch! I remember I dealt with the same for create_case_file, so I should've known there were outliers.
Thanks


How can I have grid editor

I see in your gallery you have grid editor. How can I have that grid editor

@Uysim
it is a paid plugin, the link to buy the plugin is here:
http://camaleon.tuzitio.com/store/plugins/camaleon_editor

@owen2345 ,
If possible can you please record your screen while using this editor, it would be helpful to understand this plugin usage.

I played with this plugin in demo site, its nice...I missed to read  this in plugin installation instructions.


Can't properly extend a Field with an Input as a child

Overview of the problem
Buefy version: 0.5.4
Vuejs version: 2.4.2
OS/Browser: Google Chrome 61
Description
I got some troubles with an Input component when I try to extend functionality of a Field component by a mixin. If I use the Field component with the Input component as a child all is okay. However if I extend a Field component by a mixin and then I try to add an Input component as a child I got problems with Input's message displaying - the message has excessive margin top as a result an empty row are formed between the message and input HTML tag above.
Steps to reproduce

Create new component then add a b-field tag as a root of a template tag with a default slot tag inside of it.
Use just created component with an Input component as a child whereever.
Add some message to the child Input component.
See broken displaying of the message :(

Expected behavior

Create new component then add a b-field tag as a root of a template tag with a default slot tag inside of it.
Use just created component with an Input component as a child whereever.
Add some message to the child Input component.
See  the properly displayed message (without a top margin) :)

Actual behavior
I think that the is-clearfix CSS class is unwanted on the

 tag.

@pdbq21 I don't understand very well the issue. Anyway I tried to create an example https://jsfiddle.net/p0usxmdw/. Is it right ?

@jtommy, just tested new version of buefy 6.0, looks like the issue was fixed. All works fine. Close the issue. Thanks!


test_runner: Update database ids to be human readable.

Before the Django 2.x upgrade, the DatabaseCreation
argument took an integer value.  To deal with running
mulitple test instances, we created a random start
range that could count up 100 workers until the next
random id.  Arbitrarily limiting the number of workers
to 100.
Post upgrade, we can now use string values. Enabling
the database + worker numbers to be more readable, as
well as removing the cap on the worker count.
Testing Plan:
tools/test-backened
manage.py dbshell
zulip_test=> \l

out >>
 zulip_test_template_4891304_1 | zulip_test | UTF8     | en_US.UTF-8 | en_US.UTF-8 |
 zulip_test_template_4891304_2 | zulip_test | UTF8     | en_US.UTF-8 | en_US.UTF-8 |
 zulip_test_template_4891304_3 | zulip_test | UTF8     | en_US.UTF-8 | en_US.UTF-8 |
 zulip_test_template_4891304_4 | zulip_test | UTF8     | en_US.UTF-8 | en_US.UTF-8 |
 zulip_test_template_4891304_5 | zulip_test | UTF8     | en_US.UTF-8 | en_US.UTF-8 |
 zulip_test_template_4891304_6 | zulip_test | UTF8     | en_US.UTF-8 | en_US.UTF-8 |

Made those changes; replaced all occurrences of random_id_range_start with get_database_id, and updated a comment.

Merged, thanks @whoodes!


implement typescript

tackling #39, here's my attempt to use this library with typescript.
I'm sure it's not perfectly typed since I'm not too familiar with the codebase but it works :)
Would love to hear your comments.

Why is this still not merged?

Wow....it's been over a year since this PR was opened....please merge it :)

So this will not be merged?

I made a PR on the DefinitelyTyped repository for this library.
The types and they are now available on npm or by doing:
npm i --save-dev @types/react-loading-overlay

Feel free to submit your own PR on DefinitelyTyped and modify the type definitions if I made a mistake.


flatpickr is not working on IE 9

flatpickr is not working at all on IE9.
My code as follow:
<input id="picker" type="text">

flatpickr("#picker", {
        inline:true
    });

This works on almost every browsers except on IE9 where it shows the following warning.
TypeError: Unable to get value of the property 'add': object is null or undefinedundefined

Your Environment

flatpickr version used:v2.5.1
Browser name and version: IE 9 Standard Mode
OS and version:Win7

I just got it working by adding a classList polyfill, though the weekdays style are broken.BTW, the examples on https://chmln.github.io/flatpickr/ works fine on IE9. So i am really not sure what went wrong.

@MaxZGYL include dist/ie.css for IE
<!--[if IE]>
<link rel="stylesheet" type="text/css" href=".../dist/ie.css" />
<![endif]-->

@chmln Thanks, got it working by include ie.css and classList polyfill.


No code found in URL

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Follow README steps

Any log messages given by the failure

(node:9112) UnhandledPromiseRejectionWarning: Error: No code found in URL
at Function. (C:\Users\chsuh\Documents\work\repos\ms-identity-javascript-nodejs-desktop\App\CustomProtocolListener.js:41:18)
(Use electron --trace-warnings ... to show where the warning was created)
(node:9112) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

Expected/desired behavior

I want to use the Sign In but it returns this error

OS and version?

Mac OS 12.4 (I have tried on Windows 11 as well)

Versions

{
"name": "electron-test-app",
"version": "1.0.0",
"description": "A sample Electron application that uses msal-node to acquire tokens",
"main": "Main.js",
"scripts": {
"start": "electron App/Main.js"
},
"keywords": [
"msal-node",
"electron",
"javascript"
],
"author": "",
"license": "MIT",
"devDependencies": {
"babel": "^6.23.0",
"electron": "^18.2.3",
"webpack": "^5.6.0"
},
"dependencies": {
"@azure/msal-node": "^1.0.0",
"axios": "^0.21.4",
"bootstrap": "^4.5.3",
"dotenv": "^8.2.0",
"jquery": "^3.5.1",
"popper.js": "^1.16.1"
}
}

Mention any other details that might be useful

Thanks! We'll be in touch soon.

@cssuh That's good news. I was just going to ask you to share your authConfig.js file. Let us know if you have any additional questions.


[SPARK-26390][SQL] ColumnPruning rule should only do column pruning

What changes were proposed in this pull request?
This is a small clean up.
By design catalyst rules should be orthogonal: each rule should have its own responsibility. However, the ColumnPruning rule does not only do column pruning, but also remove no-op project and window.
This PR updates the RemoveRedundantProject rule to remove no-op window as well, and clean up the ColumnPruning rule to only do column pruning.
How was this patch tested?
existing tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6244/
Test PASSed.

Test build #100274 has finished for PR 23343 at commit aad89d3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100274/
Test FAILed.

retest this please

Test build #100284 has started for PR 23343 at commit aad89d3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6254/
Test PASSed.

Test build #100284 has finished for PR 23343 at commit aad89d3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100284/
Test PASSed.

In general, we normally do not encourage the code refactoring in optimizer rules. Any change could introduce a perf regression in query planning. For this PR, I think it is safe although it could slightly increase the number of runs in the big optimizer batch.
LGTM. Please update the comment.

cc @dbtsai

retest this please

The final commit is only about adding a comment. I'll merge this to master. Thank you all.

@dongjoon-hyun thanks for pinging me. I'm working on ColumnPruning to add support of pruning nested fields. Since Optimizer.scala is such a huge file now, I'll go ahead to submit a PR to move ColumnPruning out as a separate file. Thanks!

@dbtsai It will make us hard to track the change history. Let us avoid moving the existing rules to new files.

@gatorsmile for example, we were refactoring ReplaceNullWithFalseInPredicate out from expressions.scala as it grows too big, https://github.com/apache/spark/pull/23139/files/8b0401c4440136e33d4580a3f8da80164de3d4b4
I'm wondering when we should or should not do such refactoring. I create an PR https://github.com/apache/spark/pull/23359 so we can discuss over there.

ReplaceNullWithFalseInPredicate  is a new rule in 3.0


Autoware Auto AVP Demo

Autoware Auto AVP setup tutorial

Follow the steps to get the Autoware Auto AVP sim demo working. You will have to figure out how to use it with another simulator (not LGSVL as they describe which is discontinued).

[ ] install Autoware Auto [guide]

[x] install ADE

[x] install docker
[x] install invidia-container-toolkit
[x] install and setup ADE itself

[ ] source Autoware Auto

[ ] try installing lgsvl given the discontinuation issues

[x] install a previous version without the WISE dependencies
[ ] try the WISE alternative linked in the comment below
[ ] use of another sim will require us to obtain vector map and associated data (can find this in the og autoware auto repo)

[ ] follow instructions to get the sim running

Note: I've imported the autoware auto gitlab into our github organisation (this issue is attached to it). But I couldn't import all the large files (e.g. pointcloud maps) as Github makes you pay for large files. So probably just use the gitlab and if it works well, then you can try to use this repository.

An attempt at re-implementing the WISE web interface can be found here
2020.6 version of LGSVL seems to also not depend on the WISE interface as per this comment on an issue

This tutorial also seems promising

Note: when installing AutowareAuto repo, use the avp-demo release and not 1.0.0

11-12-23
@AbBaSaMo to work on sensing from now on, don't bother with this issue
@m076em to work on sd_vehicle_interface
I will try have a go myself

https://husarion.com/tutorials/ros2-tutorials/autoware-auto-sim-demo/

https://husarion.com/tutorials/ros2-tutorials/autoware-auto-sim-demo/

Probably good to first set up a docker container with Ubuntu 22.04 and any other ADE dependencies

ADE itself is a containerisation tool built on top of docker. Would it be necessary to do this? We only need docker itself so ADE actually works given it uses it under the hood.


wrong PDF display

As reported in sumatrapdfreader/sumatrapdf#112, pdf.js-1.0.1185 displays wrong the following file:

http://www.alternativacivicacaino.it/files/2015-02-25-assemblea_pubblica.pdf

Here you have the mandatory screenshot:

evince-3.10 and mupdf-1.6 display the file right.

Reproduced in Fireox 36.0 on Linux. Looks good in Chromium 41.0.2272.77

I cannot reproduce, using: Windows 7 (64-bit), Firefox Nightly 39 (buildID:<PHONE_NUMBER>0233) with HWA on, and PDF.js 1.0.1185.
Perhaps a Linux (and Firefox) only issue? This is how PDF.js renders it on my computer:

I can confirm that this renders fine on Windows.

Slightly offtopic, but fow do you find v1.0.1185?
As far I can tell it would seem this repo on github makes no reference to that version, only v1.0.1149.

@wamatt You can always find the latest version number at https://github.com/mozilla/pdfjs-dist/releases which is updated everytime we merge a pull request. Note that this is only the development (alpha) version number: the stable and beta version numbers are listed on https://mozilla.github.io/pdf.js/getting_started/#download.

Ahh got it now, thanks @timvandermeij . I was having an issue with a Chinese character form, and the alpha seems v1.0.1185 to have sorted it out!
Will also keep in mind though that it's bleeding edge and may introduce new issues in future.

I can confirm that the original PDF is also broken in the same way on Arch Linux with Firefox 37.0.1.

Desarrolladores y líderes de Mozilla, que son travestis culo!
Alguien debe colgar ustedes para arriba en sus propias bolas y dejar que su perro muerda su caricatura de una polla!
Posteriormente deben ponerlo tiempo que sea necesario por la garganta hasta que traga a sí mismos en el suicidio!
Ustedes Mozilla está ... Estúpido de mierda coños!
Developers and leaders of Mozilla, which are shemales ass!

They should then put it long as needed by the throat until he swallows themselves in suicide!
You Mozilla is...

I also got an issue of "black" layer below some images. Here is the sample pdf : http://www.sstrn.fr/sites/default/files/pdf/sstrn_guide_des_services_aux_adherents_web.pdf
Below the coloured squares with text, 4 squares are black in FF, and not in chrome.

Closing as duplicate of #4648 and https://bugzilla.mozilla.org/show_bug.cgi?id=976322


Target [League\Flysystem\AdapterInterface] is not instantiable

Target [League\Flysystem\AdapterInterface] is not instantiable while building [League\Flysystem\Filesystem].
I use league glide laravel version

You need to open an issue against the laravel specific lib.


Spelling

This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/lunr.js/commit/0f4e0a4b18e27ba7415f4d66de6bf8fef08416bc#commitcomment-75570050
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/lunr.js/commit/b36293ddc2f044c6133bcfa4a0735c59d41ed229
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
I will be annotating this PR, and I fully expect to be asked to drop certain files.

% codespell --ignore-words-list=afetrall,ative,consol,egal,ist,knive,ment,nd,studi,ot,xdescribe --write-changes

https://pypi.org/project/codespell


⚠ Bofrost.at has degraded performance

In cf7a896, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2824 ms

Resolved: Bofrost.at performance has improved in cf0dad4 after 13 minutes.


Unable to read "marsyas/gtzan" data

Hi, this is my code and the error:
from datasets import load_dataset
gtzan = load_dataset("marsyas/gtzan", "all")

error_trace.txt
audio_yml.txt
Python 3.11.5
Jupyter Notebook 6.5.4
Windows 10
I'm able to download and work with other datasets, but not this one. For example, both these below work fine:
from datasets import load_dataset
dataset = load_dataset("facebook/voxpopuli", "pl", split="train", streaming=True)
minds = load_dataset("PolyAI/minds14", name="en-US", split="train")

Thanks for your help
https://huggingface.co/datasets/marsyas/gtzan/tree/main

Hi! We've merged a PR that fixes the script's path logic on Windows.

I have transferred the discussion to the corresponding dataset: https://huggingface.co/datasets/marsyas/gtzan/discussions/2
Let's continue there.


Update loading.attr, loading.class, etc on elements other than the current action element

loading.attr, loading.class, etc are handled in element.handleLoading(); Component.handleLoading only calls that on the targetElement. It should call it on all loading elements, the same as hide/show

I added another bug to this PR. When an event fires, it mutates the action name to fill in $event or $returnValue. For keyup, this makes $event.target.value useless as it overwrites with the value on the first keyup, and never updates it.

Thanks for this fix! 🎉


Is "Will" a reserved word?

Searching for in a text field for Will brings no results when it should.

Hi there @Felixls will is a stopword thus resulting in the correct outcome you refer above :) https://oss.redislabs.com/redisearch/Stopwords.html


1 fps at map "gm_Floatingworlds_3_v2", no other addons enabled.

As title says, when i tried to play this map (link) with every other mods disabled and installed vphysics 0.11 (0.10 do this too), i get around one fps. Why?

Does your framerate improve without vp-jolt enabled?

Does your framerate improve without vp-jolt enabled?

Of course, if i use vanilla .dll, i get 60+ fps looking at whole map


Version of Go is out of date

Thanks for creating this. Very useful.
I am getting a vulnerability report on my code via the GitHub action, but not when I run govulncheck locally. The vulnerability was fixed in Go 1.19.1, which I am using locally. Reading the logs from the GitHub action, it appears that Go 1.19 (thus. 1.19.0?) is hardcoded into the action. Is it possible to use the latest patch version of whatever version is specified in go.mod?

Hey @lmullen it takes the go version that's available.  That works for me. Thank you for explaining it.


Refactor/stefs observations

MatchTools opens with a default pattern and Pharo's code. So, if you click on Match button you will have an example.
Changed the instance variable name to patternLabel and the text to 'Pattern code' in MatchTool.
Deleted RBCustomTransformationRule class.
Improved the comments on all the classes.


Replication using CURP simply better than with Paxos or Raft

I can see Replicate vs Paxos or Raft in the roadmap, but I think it's overkill for replication as there seems to be an easier and faster way to accomplish that - see CURP (Consistent Unordered Replication Protocol).
What Paxos or Raft is good for is distributed transactions in a sharded environment (aka horizontal partitioning). In this case there is currently no known way how to do it more efficiently than using Paxos or Raft for updating a distributed ledger keeping the information about success or failure of such transaction (see FaunaDB as tested by Jepsen).

Normally a db is designed for clustering mode too, so probably using Raft you can sodisfy either replication either distributed transactions in a same consensus strategy no? is there a curp library for java or golang?

Normally a db is designed for clustering mode too, so probably using Raft you can sodisfy either replication either distributed transactions in a same consensus strategy no? else you have to use 2 different sockets for 2 different strategies.

I'm not sure if I understand correctly. CURP solves (very efficiently and simply) the failover scenario of one or more nodes (i.e. replication). Whereas Raft/Paxos solves a distributed transaction synchronization issue (i.e. sharding at the presence of transactions). Both technologies solve a different thing, thus being complementary and can be therefore used simultaneously (yes, you could use Raft/Paxos also for replication, but it's highly inefficient). Note also, that CURP is easy to implement compared to Raft/Paxos.

Anyway is there a curp library for java or golang?

Currently I don't know of any :cry:.


train my own data

Hi

My class
CLASSES = ('background',
'person', 'bicycle', 'car', 'motorcycle',
'bus', 'truck', 'traffic light', 'stop sign', 'dog'

run gen_model.sh 10

train.sh is
#!/bin/sh
if ! test -f example/MobileNetSSD_train.prototxt ;then
echo "error: example/MobileNetSSD_train.prototxt does not exist."
echo "please use the gen_model.sh to generate your own model."
exit 1
fi
mkdir -p snapshot
/home/sankim/caffe-ssd/build/tools/caffe train -solver="solver_train.prototxt"
-gpu 0

run demo.py
net_file= 'MobileNetSSD_deploy.prototxt'
caffe_model='mobilenet_iter_30000.caffemodel'

The train is over but the model performs incorrect detection
Do I have to add -weight MobileNetSSD_deploy.caffemodel to train.sh?

Were you able to train your model? If so please show me the steps... Thanks!

@sankim90 were you able to know what was the issue?

@soufianesabiri @ibrahimsherdil Nope, I did not use the MobileNet SSD because I thought the model was unreliable.


Support for form param by ignoring order

Question
I would like to match the request with form parameters
i.e
  make {
    request {
      method POST()
      urlPath('/oauth/token')
      headers {
        header(authorization(), anyNonBlankString())
        header(contentType(), applicationFormUrlencoded())
        header(accept(), applicationJson())
      }
      body([
          username  : 'user',
          password  : 'password',
          grant_type: 'password'
      ])
    }
    response {
      status 200
      headers {
        header(contentType(), applicationJson())
      }
      body([
          refresh_token: 'RANDOM_REFRESH_TOKEN',
          access_token : 'RANDOM_ACCESS_TOKEN',
          token_type   : 'bearer',
          expires_in   : 3600,
          scope        : ['task'],
          user         : [
              id      : 1,
              username: 'user',
              name    : 'User'
          ]
      ])
    }

I want to send 200 response only if the request body contains username = user, password = password & grant_type = password. The order of the arguments need not be guaranteed to be exact, i.e this should be similar to how json matching currently works.
Also, I would like to send a 401 response if any of the arguments does not match the request.
Is there a way to achieve this currently?

That's exactly what would happen right now. Have you actually tried to run this?

That's a bug. Which version of contract are you using?

Here is request
POST /oauth/token HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Authorization: Basic aHR0cGllOg==
Connection: keep-alive
Content-Length: 51
Content-Type: application/x-www-form-urlencoded; charset=utf-8
Host: localhost:9191
User-Agent: HTTPie/0.9.9

username=user&password=password&grant_type=password

That's a bug. Which version of contract are you using?

http://repo.spring.io/milestone/org/springframework/cloud/spring-cloud-contract-stub-runner-boot/2.0.0.M6/spring-cloud-contract-stub-runner-boot-2.0.0.M6.jar

Plus there are multiple additional issues.
I try to run ./gradlew generateClientStubs 200 & 401  compile the following contract, it fails to compile

When I try to generate client stubs via ./gradlew generateClientStubs  for 200 & 401 scenarios, build fails

Testcase
import static org.springframework.cloud.contract.spec.Contract.make

[
    make {
      request {
        method POST()
        urlPath('/')
        body([
            param1: 'val1'
        ])
      }
      response {
        status 200
      }
    },
    make {
      request {
        method POST()
        urlPath('/')
        body(notMatching([
            param1: 'val1'
        ]))
      }
      response {
        status 401
      }
    }
]

anyOf(applicationJson(), applicationJsonUtf8(), allValue()) does not work

Testcase
import static org.springframework.cloud.contract.spec.Contract.make

make {
  request {
    method GET()
    urlPath('/')
    headers {
      header(accept(), anyOf(applicationJson(), applicationJsonUtf8(), allValue()))
    }
  }
  response {
    status 200
  }
}

try to make a call with the following request
GET / HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: localhost:9191
User-Agent: HTTPie/0.9.9

HTTP/1.1 404 Not Found
Content-Type: text/plain
Server: Jetty(9.2.z-SNAPSHOT)
Transfer-Encoding: chunked

                                               Request was not matched
                                               =======================

-----------------------------------------------------------------------------------------------------------------------
| Closest stub                                             | Request                                                  |
-----------------------------------------------------------------------------------------------------------------------
                                                           |
GET                                                        | GET
/                                                          | /
                                                           |
Accept [matches] :                                         | Accept: */*                                         <<<<< Header does not match
^application/json$|^application/json;charset=UTF-8$|^*/*$  |
                                                           |
                                                           |
-----------------------------------------------------------------------------------------------------------------------

Can you show what exactly doesn't compile?

The first one does not compile, the second one does not match requests

I understood which one, I asked what exactly doesn't compile. Can you paste the compilation issue error?

Sorry. Here is the log
Picked up JAVA_TOOL_OPTIONS: -javaagent:/usr/share/java/jayatanaag.jar
:auth-server:copyContracts
:auth-server:generateClientStubs FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':auth-server:generateClientStubs'.
> Unable to make conversion of test.groovy

* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':auth-server:generateClientStubs'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:103)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:73)
	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.run(DefaultTaskGraphExecuter.java:256)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:199)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:110)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:249)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:238)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.processTask(DefaultTaskPlanExecutor.java:123)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.access$200(DefaultTaskPlanExecutor.java:79)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:104)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:98)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.execute(DefaultTaskExecutionPlan.java:663)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.executeWithTask(DefaultTaskExecutionPlan.java:597)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:98)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
Caused by: org.springframework.cloud.contract.verifier.converter.ConversionContractVerifierException: Unable to make conversion of test.groovy
	at org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter$_processFiles_closure1$_closure2.doCall(RecursiveFilesConverter.groovy:107)
	at org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter$_processFiles_closure1.doCall(RecursiveFilesConverter.groovy:67)
	at org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter$_processFiles_closure1.call(RecursiveFilesConverter.groovy)
	at org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter.processFiles(RecursiveFilesConverter.groovy:66)
	at org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter$processFiles.call(Unknown Source)
	at org.springframework.cloud.contract.verifier.plugin.GenerateWireMockClientStubsFromDslTask.generate(GenerateWireMockClientStubsFromDslTask.groovy:58)
	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
	at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:46)
	at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:39)
	at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:26)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:788)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:755)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:124)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:199)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:110)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:113)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:95)
	... 30 more
Caused by: java.util.regex.PatternSyntaxException: Illegal repetition
{"param1":"val1"}
	at com.github.tomakehurst.wiremock.matching.AbstractRegexPattern.<init>(AbstractRegexPattern.java:28)
	at com.github.tomakehurst.wiremock.matching.NegativeRegexPattern.<init>(NegativeRegexPattern.java:23)
	at com.github.tomakehurst.wiremock.client.WireMock.notMatching(WireMock.java:222)
	at com.github.tomakehurst.wiremock.client.WireMock$notMatching$2.call(Unknown Source)
	at org.springframework.cloud.contract.verifier.dsl.wiremock.WireMockRequestStubStrategy.convertToValuePattern(WireMockRequestStubStrategy.groovy:213)
	at org.springframework.cloud.contract.verifier.dsl.wiremock.WireMockRequestStubStrategy.appendBody(WireMockRequestStubStrategy.groovy:118)
	at org.springframework.cloud.contract.verifier.dsl.wiremock.WireMockRequestStubStrategy.buildClientRequestContent(WireMockRequestStubStrategy.groovy:76)
	at org.springframework.cloud.contract.verifier.dsl.wiremock.WireMockStubStrategy.toWireMockClientStub(WireMockStubStrategy.groovy:61)
	at org.springframework.cloud.contract.verifier.wiremock.DslToWireMockClientConverter.convertASingleContract(DslToWireMockClientConverter.groovy:36)
	at org.springframework.cloud.contract.verifier.wiremock.DslToWireMockClientConverter.access$0(DslToWireMockClientConverter.groovy)
	at org.springframework.cloud.contract.verifier.wiremock.DslToWireMockClientConverter$_convertContents_closure3.doCall(DslToWireMockClientConverter.groovy:50)
	at org.springframework.cloud.contract.verifier.wiremock.DslToWireMockClientConverter.convertContents(DslToWireMockClientConverter.groovy:48)
	at org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter$_processFiles_closure1$_closure2$_closure3.doCall(RecursiveFilesConverter.groovy:91)
	at org.springframework.cloud.contract.verifier.converter.RecursiveFilesConverter$_processFiles_closure1$_closure2.doCall(RecursiveFilesConverter.groovy:90)
	... 48 more

* Get more help at https://help.gradle.org

BUILD FAILED in 1s
2 actionable tasks: 2 executed

The form parameter is the new feature I've added.

anyOf(applicationJson(), applicationJsonUtf8(), allValue()) does not work

It doesn't work cause anyOf(...) accepts regular expressions. applicationJson(), applicationJsonUtf8(), allValue() are not regular expressions.

body(notMatching([param1: 'val1']))

notMatching accepts a regular expression. [param1: 'val1'] is not a regular expression

It doesn't work cause anyOf(...) accepts regular expressions. applicationJson(), applicationJsonUtf8(), allValue() are not regular expressions.

Can you rename the method appropriately so that people know this only works with regex

body(notMatching([param1: 'val1']))

Since this too is the common scenario, do u plan on supporting notMatching overload that accepts Map?

Can you rename the method appropriately so that people know this only works with regex

No, the method exactly says what it does

Since this too is the common scenario, do u plan on supporting notMatching overload that accepts Map?

No. AFAIR WireMock doesn't support it

No. AFAIR WireMock doesn't support it

Raised a question in their forum
https://groups.google.com/forum/#!topic/wiremock-user/tmPYeTDzPU0
Thanks


NotImplementedError: Cannot check isinstance when validating from json, use a JsonOrPython validator instead.

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
I'm attempting to save out an instance of my Pydantic model to json but encountering an error with no info in the traceback.
https://github.com/crim-ca/dlm-extension/blob/41cf8eaa768f41e988ddd693688fc9d795d58cf6/tests/test_schema.py#L11
the following fails with
In [1]: from stac_model.examples import eurosat_resnet
   ...: from stac_model.schema import MLModel
   ...: model_metadata = eurosat_resnet()
   ...: metadata_json = model_metadata.model_dump_json(indent=2)
   ...: model_metadata_validated = MLModel.model_validate_json(metadata_json)
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
Cell In[1], line 5
      3 model_metadata = eurosat_resnet()
      4 metadata_json = model_metadata.model_dump_json(indent=2)
----> 5 model_metadata_validated = MLModel.model_validate_json(metadata_json)

File ~/miniforge3/lib/python3.10/site-packages/pydantic/main.py:538, in BaseModel.model_validate_json(cls, json_data, strict, context)
    536 # `__tracebackhide__` tells pytest and some other tools to omit this function from tracebacks
    537 __tracebackhide__ = True
--> 538 return cls.__pydantic_validator__.validate_json(json_data, strict=strict, context=context)

this error is likely related to https://github.com/pydantic/pydantic/issues/8455 but I couldn't fix this by following this comment's guidance https://github.com/pydantic/pydantic/issues/8455#issuecomment-1873460962
I tried removing the only isinstance check I could find here and it didn't have any effect on the error.
Example Code
the package I'm working with can be installed with
pip install stac-model==0.1.1.alpha3
then the error can be reproduced with
from stac_model.examples import eurosat_resnet
from stac_model.schema import MLModel
model_metadata = eurosat_resnet()
metadata_json = model_metadata.model_dump_json(indent=2)
model_metadata_validated = MLModel.model_validate_json(metadata_json)

the model is defined here: https://github.com/crim-ca/dlm-extension/tree/21d1aa9947befc8fb2a46458ef84e9d183d50f48/stac_model
Python, Pydantic & OS Version
→ poetry run python -c "import pydantic.version; print(pydantic.version.version_info())"
             pydantic version: 2.6.2
        pydantic-core version: 2.16.3
          pydantic-core build: profile=release pgo=true
                 install path: /home/rave/.cache/pypoetry/virtualenvs/stac-model-YQXQDXJF-py3.10/lib/python3.10/site-packages/pydantic
               python version: 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:40:32) [GCC 12.3.0]
                     platform: Linux-6.5.0-21-generic-x86_64-with-glibc2.35
             related packages: typing_extensions-4.10.0 mypy-1.0.1
                       commit: unknown

@rbavery,
Could you provide a MRE for this issue? I'm not able to view the commit that you linked with the model. A boiled down version of this issue will help us to address your problem! Thanks.

For me this week, making an MRE would be too large of a project, I'm not sure how long it would take to reproduce the issue without the library I'm using. Since I don't know what causes the issue in the first place (there's no information in the traceback about where the issue occurred).
I just noticed the formatting was off in my original post, sorry about that.
My package source is here: https://github.com/rbavery/dlm-extension/tree/validate/stac_model
and it is pip installable and testable with the code provided above

the package I'm working with can be installed with
pip install stac-model==0.1.1.alpha3
then the error can be reproduced with
from stac_model.examples import eurosat_resnet
from stac_model.schema import MLModel
model_metadata = eurosat_resnet()
metadata_json = model_metadata.model_dump_json(indent=2)
model_metadata_validated = MLModel.model_validate_json(metadata_json)

@rbavery,
If we don't have a purely pydantic MRE, I don't think it makes sense to have this issue open here. I'd recommend opening an issue on the stac_model repo!
Thanks!

@sydney-runkle  I'm the maintainer of stac-model, and the primary dependency is pydantic.
https://github.com/rbavery/dlm-extension/blob/validate/pyproject.toml#L58

@sydney-runkle it actually looks like I provided a minimal repro back in December, sorry for forgetting to raise this in a new issue: https://github.com/pydantic/pydantic/issues/8189#issuecomment-1848226486
I just tested this with pydantic 2.3.2 and the issue still occurs
# rave at rave-desktop in ~/work/dlm-extension on git:validate ✖ [11:21:33]
→ pip install pydantic=="2.6.3"
Collecting pydantic==2.6.3
  Obtaining dependency information for pydantic==2.6.3 from https://files.pythonhosted.org/packages/ac/86/c98520827f58c8753783be4bf2286b4f73a18ac71c93ab597ae1aeb26fc8/pydantic-2.6.3-py3-none-any.whl.metadata
  Downloading pydantic-2.6.3-py3-none-any.whl.metadata (84 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 84.4/84.4 kB 1.4 MB/s eta 0:00:00
Requirement already satisfied: annotated-types>=0.4.0 in /home/rave/miniforge3/lib/python3.10/site-packages (from pydantic==2.6.3) (0.6.0)
Requirement already satisfied: pydantic-core==2.16.3 in /home/rave/miniforge3/lib/python3.10/site-packages (from pydantic==2.6.3) (2.16.3)
Requirement already satisfied: typing-extensions>=4.6.1 in /home/rave/.local/lib/python3.10/site-packages (from pydantic==2.6.3) (4.8.0)
Downloading pydantic-2.6.3-py3-none-any.whl (395 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 395.2/395.2 kB 3.1 MB/s eta 0:00:00
Installing collected packages: pydantic
  Attempting uninstall: pydantic
    Found existing installation: pydantic 2.3.0
    Uninstalling pydantic-2.3.0:
      Successfully uninstalled pydantic-2.3.0
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
fastapi 0.104.1 requires anyio<4.0.0,>=3.7.1, but you have anyio 4.2.0 which is incompatible.
lightly 1.4.23 requires pydantic<2,>=1.10.5, but you have pydantic 2.6.3 which is incompatible.
Successfully installed pydantic-2.6.2
(base)
# rave at rave-desktop in ~/work/dlm-extension on git:validate ✖ [11:24:18]
→ ipython
Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:40:32) [GCC 12.3.0]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.18.1 -- An enhanced Interactive Python. Type '?' for help.

   ...:     def validate_key(cls, v):
   ...:         if '//' in v:
   ...:             raise ValueError('Key must not contain double slashes')
   ...:         return v.strip('/')
   ...:
   ...: class ModelArtifact(BaseModel):
   ...:     path: S3Path | FilePath | str = Field(...)
   ...:     additional_files: Optional[Dict[str, FilePath]] = None
   ...:
   ...:     class Config:
   ...:         arbitrary_types_allowed = True
   ...:
   ...: class ClassMap(BaseModel):
   ...:     class_to_label_id: Dict[str, int]
   ...:
   ...:     @property
   ...:     def label_id_to_class(self) -> Dict[int, str]:
   ...:         return {v: k for k, v in self.class_to_label_id.items()}
   ...:
   ...: class ModelMetadata(BaseModel):
   ...:     signatures: ModelSignature
   ...:     artifact: ModelArtifact
   ...:     id: str = Field(default_factory=lambda: uuid4().hex)
   ...:     class_map: ClassMap
   ...:     runtime_config: Optional[RuntimeConfig] = None
   ...:     name: str
   ...:     ml_model_type: Optional[str] = None
   ...:     ml_model_processor_type: Optional[Literal["cpu", "gpu", "tpu", "mps"]] = None
   ...:     ml_model_learning_approach: Optional[str] = None
   ...:     ml_model_prediction_type: Optional[Literal["object-detection", "classification", "segmentation", "regression"]] = None
   ...:     ml_model_architecture: Optional[str] = None
   ...:
   ...:     class Config:
   ...:         arbitrary_types_allowed = True
   ...:
   ...: # Functions to create, serialize, and deserialize ModelMetadata
   ...: def create_metadata():
   ...:     input_sig = TensorSignature(name='input_tensor', dtype='float32', shape=(-1, 13, 64, 64))
   ...:     output_sig = TensorSignature(name='output_tensor', dtype='float32', shape=(-1, 10))
   ...:     model_sig = ModelSignature(inputs=[input_sig], outputs=[output_sig])
   ...:     model_artifact = ModelArtifact(path="s3://example/s3/uri/model.pt")
   ...:     class_map = ClassMap(class_to_label_id={
   ...:         'Annual Crop': 0, 'Forest': 1, 'Herbaceous Vegetation': 2, 'Highway': 3,
   ...:         'Industrial Buildings': 4, 'Pasture': 5, 'Permanent Crop': 6,
   ...:         'Residential Buildings': 7, 'River': 8, 'SeaLake': 9
   ...:     })
   ...:     return ModelMetadata(name="eurosat", class_map=class_map, signatures=model_sig, artifact=model_artifact, ml_model_processor_type="cpu")
   ...:
   ...: def metadata_json(metadata: ModelMetadata) -> str:
   ...:     return metadata.model_dump_json(indent=2)
   ...:
   ...: def model_metadata_json_operations(json_str: str) -> ModelMetadata:
   ...:     return ModelMetadata.model_validate_json(json_str)
   ...:
   ...: # Running the functions end-to-end
   ...: metadata = create_metadata()
   ...: json_str = metadata_json(metadata)
   ...: model_metadata = model_metadata_json_operations(json_str)
   ...:
   ...: print("Model Metadata Name:", model_metadata.name)
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
Cell In[1], line 100
     98 metadata = create_metadata()
     99 json_str = metadata_json(metadata)
--> 100 model_metadata = model_metadata_json_operations(json_str)
    102 print("Model Metadata Name:", model_metadata.name)

Cell In[1], line 95, in model_metadata_json_operations(json_str)
     94 def model_metadata_json_operations(json_str: str) -> ModelMetadata:
---> 95     return ModelMetadata.model_validate_json(json_str)

File ~/miniforge3/lib/python3.10/site-packages/pydantic/main.py:538, in BaseModel.model_validate_json(cls, json_data, strict, context)
    536 # `__tracebackhide__` tells pytest and some other tools to omit this function from tracebacks
    537 __tracebackhide__ = True
--> 538 return cls.__pydantic_validator__.validate_json(json_data, strict=strict, context=context)

NotImplementedError: Cannot check isinstance when validating from json, use a JsonOrPython validator instead.

Hey 👋 I ran into the same error message while using lambda powertools. E.g.

NotImplementedError: Cannot check issubclass when validating from json, use a JsonOrPython validator instead.

In this case it seems to be caused when a model with a field using the type type[BaseModel] is parsed from JSON.
Heres a minimal example:
import json

from pydantic import BaseModel

class MyWorkingModel(BaseModel):
    string: str
    submodel: dict[str, Any] | BaseModel

class MyFailingModel(BaseModel):
    string: str
    submodel: dict[str, Any] | BaseModel | type[BaseModel]

data = {
    "string": "string",
    "submodel": {"key": "value"},
}

MyWorkingModel.model_validate_json(json.dumps(data))  # works
MyFailingModel.model_validate_json(json.dumps(data))  # fails

I've already filed an issue to the Lambda Powertools repo here.
But I wanted to mention this here in case someone else is running into a similar issue (or if this is something that Pydantic wants to improve?).

Hi,
Thanks for the reproducible example! This is on us - will try to fix here soon.


Fix TestServerSource race condition

If we set the desired error after we start the stream, the stream could
have a real error before we get to setting the error.
Fixes https://github.com/istio/istio/issues/15798
[x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To complete the pull request process, please assign ayj
You can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS [ayj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Note: this is pretty hard to reproduce, I had to put it in a CPU constrained container and run it a lot
dk run -v "${PWD}":"${PWD}" -w "${PWD}" -e GOPATH=$GOPATH --cpus=1 golang:1.12.7 go test ./pkg/mcp/source -run TestServerSource -race -count 2000. But if you add a sleep after the stream start its pretty trivial to reproduce as well

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
2823f4f7b00358a51b13d2b85bb160bb7b19223a
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-racetest-master
2823f4f7b00358a51b13d2b85bb160bb7b19223a
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


docs: fix docs 404 in samples/docs

Fixes #312, @techpeace look reasonable?

[x] Tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Looks great, thanks @bcoe!


Pack all instance dicts in a struct

Currently applyPAP handles too few args, sometimes causing it to return NULL for functions with big arities such as the ones generated when a function has many constraints, eg. derived instances for records with lots of fields.
Immediate solution will be to add more cases to applyPAP, which should be done anyways, but long term solution would be to pack all instance dictionaries in a struct as first param in order to save lots of args and making most functions use only a few args.

Thanks to monomorphization this is no longer needed.


[Suggestion] Enable discussions tab

I'm not sure if this was considered before or not, but how do you guys feel about enabling discussions tab for the repo and pointing users with potential [Question] issues there instead, to try and keep issues cleaner?
I've been working with pixi for past 4 months and generally when I have questions I try to post them in stackoverflow, however response there is usually slow or non-existent. https://www.html5gamedevs.com is another alternative and Ivan is full on "beastmode" there answering questions, however it seems as if its only him and very few others.
Perhaps enabling discussions here and making it clear in readme / github issue template that questions and requests for help could be asked there might help a bit in terms of community and learning pixi?
If this sounds interesting I could try and help in setting up something like https://github.com/vercel/vercel/issues/new/choose this experience when creating an issue (it can point to either issues or discussions based on what users choose).

Great idea! I think GitHub Discussions is still in beta (we do not have an option to enable it), but I think that's a good shout and we should do that when it becomes more widely available.

Awesome, I believe this topic is where you can apply for a beta access https://github.community/t/can-one-apply-for-github-discussions-beta/121120 might help get it sooner.

Done! Thanks for the tip @IljaDaderko

Ivan is full on "beastmode" there answering questions

I'll keep this as quote, ok? :)

This is now in public beta and available here: https://github.com/pixijs/pixi.js/discussions


DotNetCore WindowsHosting URLs give 404s for 1.1.7 and 2.0.6

I hope I got the correct repository to file this.
We run automated OS builds that use the WindowsHosting.exe files to install the appropriate .NET Core runtimes.
This morning we noticed that our builds were failing. DotNetCore.1.0.10_1.1.7-WindowsHosting.exe and DotNetCore.2.0.6-1-WindowsHosting.exe are available and get downloaded, but their pointed to URLs https://dotnetcli.azureedge.net/dotnet/Runtime/1.1.7/dotnet-win-x<IP_ADDRESS>.zip and  https://dotnetcli.azureedge.net/dotnet/Runtime/2.0.6/dotnet-win-x<IP_ADDRESS>.zip, respectively, result in  an XML message stating ResourceNotFound, effectively a 404.
Can someone look into this?

See also dotnet/core-setup#4245

Something happed with the azure account which has been corrected. Should be good to go now.


Floor plan DWG color and shading?

We successfully uploaded our DWG and can search on our office spaces. However, MS Search translated our drawing to all black and white with no shading. We have colors and shading in our DWG. The very first example image on the Manage Plans guide shows a search result with a floor plan that clearly has colors. How is this accomplished in the DWG?
Guide link https://docs.microsoft.com/en-us/microsoftsearch/manage-floorplans
Image link: https://docs.microsoft.com/en-us/microsoftsearch/media/floor-plans/floor-plan-answer.png

@njmoroniti,
I'll update the image in the docs article to reflect the current style of a floor plan rendering. You can see the rendering style in this image:

This helps ensure all of the floor plan answers in your organization have a similar look even when the DWG files use different colors.

@njmoroniti, updated the manage floor plans article to remove the image of the answer with shading. Will be updating the other images to reflect the current answer UX.
https://docs.microsoft.com/microsoftsearch/manage-floorplans

This is disappointing that the image was a misrepresentation. We were hoping to accomplish color and shading. It is on the roadmap to be able to render color and/or shading? If not, how can I submit feedback to generate interest/movement? Thanks.

@njmoroniti I opened a suggestion/issue about enabling shading and coloring in floor plan answers for the feature team. To try to generate interest in this and other feature suggestions, you might also consider joining the Microsoft Search Tech Community or Microsoft Search Insiders groups.
Closing this issue with this comment.


Track our analytics into a new GA property

Pageviews get tracked in both NPR.org and the new one
Events only get tracked in the new one

Email out to Dan F. asking for a new property ID

Got a new property id: UA-5828686-75. Waiting on access to the dashboard.

Annnnd, it's there.


Fix item parsing of raw type 12

I had the problem that an eternal life potion could not be parsed correctly. The reason for this was that sub_ident had the value 655360016. Since the value was greater than 16, it was incorrectly assumed that this is a resource. However, it could not be parsed as a resource either, since in this case the value can only be between 17 and 21. As a result, this particular eternal life potion was parsed as ItemType::Unknown.
This only happened with one eternal life potion, other ones were working fine. It is possible that this item is very old because this character exists for many years and I only recently started using it again. But I'm not sure when exactly this potion was bought.

Thank you for taking the time to report and fix this! I think all branches except the gem path (which also does modulo on the sub_ident later down the line) now mask the sub ident in the match. I wonder if just masking the sub_ident once at the top would be a better thing to do, since it seems like the upper bits are always something else and not part of the actual subident.
Would also be interesting to investigate what the upper bits actually are. For your item the upper bits would result in '10000'. Might be some sort of resale value, metadata for the origin (calendar, coupon, etc), or something I am already using in the normal item parsing without realizing it.
Don't worry, I just mention this here so I don't forget to do this at some point, I don't require you to do any of that. Thanks again for the fix!


Naming conflicts after updating to 0.7

I'm using the plugin with directoryAsNamespace: true, option. So for example I have my component app-header stored at  components/app/header.vue. I worked fine until I've updated the version from 0.6.6 to 0.7.1. Now I have such errors in the console:
[vite-plugin-components] component "Card"(....../src/components/def/card.vue) has naming conflicts with other components, ignored.
[vite-plugin-components] component "List"(....../src/components/def/list.vue) has naming conflicts with other components, ignored.
[vite-plugin-components] component "Card"(......./src/components/link/card.vue) has naming conflicts with other components, ignored.
... and so on...

Looks like a bug. Or may be I need to make some changes to the config?

The only thing in 0.7.1 is the Vue 2 transformer and it should not affect the logic related to your problem. Can you share a minimal repro? Thanks,

@antfu no problem! https://github.com/DeFUCC/vite-min here's a minimal repro repo ) Two components work fine until you bump vite-plugin-components from 0.6.12 to 0.7.1

Should be fixed in 0.7.2. Thanks


Fixed byref local optimization

This fixes the issue here: https://github.com/Microsoft/visualfsharp/issues/5235
There are no tests because the ref scope PR: https://github.com/Microsoft/visualfsharp/pull/5240 will include them and also fail the code presented in the issue.

This doesn't seem trivial. Looking at the failing tests it breaks some optimizations for comparisons.

Closing this as we disallowed specific code (look here https://github.com/Microsoft/visualfsharp/issues/5235) in F# 4.5 where this optimization is a problem.


e2e: serial: kickoff tests for scheduler stall

The default scheduler framework setting watches pod not in terminal phase. On the node, the podresources endpoint does report also pods in  terminal phase, up until are deleted. This mismatch creates differences in PFP value, so the scheduler never reconciles, leading to a so-called "scheduler stall".
While workaround were provided (podExcludes), noone was deemed conclusive. The implemented for the short/mid term is to just have another separate independent informer watching pods in all states, just and only to serve the NRT scheduler plugins.
In this change we add tests to trigger scheduler stalls and exercise the code, making sure stalls are avoided.
The easiest way to create undeleted pods in terminal phase is to use jobs, so this is what we do.
Note this group of tests intentionally duplicates existing tests, adding jobs to the node conditions before to run them.
The alternative is to add yet another column in the test matrix for the existing case, which is not obviously better considering the purpose of these tests.

ready for review. This is the final PR needed for the scheduler stall prevention work.
Once this is merged, we need the final verification that https://github.com/openshift-kni/scheduler-plugins/pull/101 works as intended, possibly some further fixes, and we're done.

it seems a GH lane broke, but is not critical (and surely not for this PR)

/cherry-pick release-4.13

I'll handle any followup needed (if any)


Add Jakarta Persistence properties

With this change:
avap -v -l -p -c -s -constants cfg/AvailableSettings.class | grep javax.persistence.jdbc.driver
org/hibernate $  javap -v -l -p -c -s -constants cfg/AvailableSettings.class | grep jakarta.persistence.jdbc.driver
   #15 = String             #664          // jakarta.persistence.jdbc.driver
  #449 = Utf8               jakarta.persistence.jdbc.driver
  #664 = Utf8               jakarta.persistence.jdbc.driver
  public static final java.lang.String JPA_JDBC_DRIVER = "jakarta.persistence.jdbc.driver";
    ConstantValue: String jakarta.persistence.jdbc.driver

Without this change (e.g. currently):
javap -v -l -p -c -s -constants cfg/AvailableSettings.class | grep javax.persistence.jdbc.driver
   #15 = String             #449          // javax.persistence.jdbc.driver
  #449 = Utf8               javax.persistence.jdbc.driver
  public static final java.lang.String JPA_JDBC_DRIVER = "javax.persistence.jdbc.driver";
    ConstantValue: String javax.persistence.jdbc.driver

@ropalka are there any other TCK test fixes pending that we should try to include in a 1.0.2.Final for EE-9 WildFly alpha?  I would like to include this pull request.
For doing releases, have you just been doing mvn deploy?

I don't know about other pending fixes in Batavia.
For releasing artifacts I usually do:
mvn clean deploy -P gpg-sign,jboss-release -Dgpg.keyname=[PRIVATE-KEY-ID] -Dgpg.passphrase=[PRIVATE-KEY-PASSWORD]


0.14.19 Settings Changes Break Start Script

It looks like the moved several more of the command line args have been moved into the json.  Once again causing the script to fail to load.
It looks to be the auto save frequency and slots

There are already 3 pull requests open to move those to the json.

I noticed it right after I updated the issue. Was about to make one myself, but figured I should check the open ones first.

looks like all the pull requests have fixed this, I was able to get the script to start a 0.14.19 server just now - thnx for reporting these and kudos to all the nice ppl pushing the fixes this way


CF bridge routes are not secured when SECURED=true

The following routes into the CF bridge app:
/v1/cf/bridge
/batch

are not secured when SECURED=true.
When the SECURED env variable is true, these routes should require an OAuth token containing an abacus.usage.read scope, and reject unauthorized requests with an HTTP 401 status.

I'm currently re-factoring the bridge and as part of this I will remove the endpoint providing statistics. I will add the use of perf and a debug interval timer that will log statistics similar to this one: https://github.com/cloudfoundry-incubator/cf-abacus/blob/master/lib/utils/couchclient/src/index.js#L272-L280


Datetime updates

PR summary
This PR includes a re-gen of IAM Identity after recent changes to the API.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.14.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update using-the-hololens-emulator.md

loc header

Docs Build status updates of commit 20fcc6e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/using-the-hololens-emulator.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


command buffer helper

As regards the 127 this is a simple and efficient solution to the issue.
It's faster than the naive Vec approach.

Please respond to comments you've addressed, either marking them as resolved if you think you're done with them, or with a comment if you think additional attention is required.

I didn't realize I had to reply sorry 😅


Defect with HTMLDocument->forms property?

You might want to accept this one onto a new branch - or just reject it if I've got the wrong end of the stick on how the property should work.

No defect; not yet implemented
Tracked in #22 along with #16 for missing Element properties.


About error “more than one element of the written-to tensor refers to a single memory location.”

If I use ./extension/normalization/iterative_normalization.py directly, I get the error - "more than one element of the written-to tensor refers to a single memory location". This error occurs due to the PyTorch version update. I could find the solution here.
Basically,
change self.register_buffer('running_wm', torch.eye(num_channels).expand(num_groups, num_channels, num_channels) to self.register_buffer('running_wm', torch.eye(num_channels).expand(num_groups, num_channels, num_channels).clone()).

@danelee2601 ， thanks for your constructive comments.


controller

how do i begin the program with the tab in the middle ?

Not related to my lib, but you can set the initial tab when initializing tabController like this
_tabController = new TabController(length: 5, vsync: this, initialIndex: 2);

Ref. https://github.com/datdescartes/flutter_colorful_tab/blob/5d9fd1504ddf84e341ef9384a663537b4b15c012/example/lib/main.dart#L36


M3-23 Update and type doc sidebar.

Purpose
Type and style the documentation component (implemented in previous PR).

Coverage increased (+0.8%) to 45.357% when pulling 1d909a6fbd52e7d483f4c71a85856ddf01396c5a on rjstires:M3-26-doc-sidebar into c5dd967484a4e320103c941e72678411215e8156 on linode:voldemort.