Updates for proposed changes to Dramacool plugin

PR to improve speed of listing creation and to support functionality in https://github.com/groggyegg/plugin.video.dramacool/pull/41

Thanks, closing this PR, some of the changes has been moved to https://github.com/groggyegg/script.module.xbmcext/pull/2 while other parts is not relevant anymore.


Initial format changes and adding in required entity mappings

Fixes #
Proposed Changes

<EMAIL_ADDRESS>how can we be sure our yaml is valid? How did you find the error?
From: shainw<EMAIL_ADDRESS>Sent: יום ד 21 אוגוסט 2019 22:51
To: Azure/Azure-Sentinel<EMAIL_ADDRESS>Cc: Yaron Fruchtmann<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [Azure/Azure-Sentinel] Initial format changes and adding in required entity mappings (#233)
@shainw commented on this pull request.

In Detections/AWSCloudTrail/AWS_ConsoleLogonWithoutMFA.yamlhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F233%23discussion_r316371753&data=02|01|Yaron.Fruchtmann%40microsoft.com|867e4feb90b04ac9f7ee08d72670ed45|72f988bf86f141af91ab2d7cd011db47|1|0|637020138769883311&sdata=pLK%2BEKownTnr0DOTLvfKS%2B5N%2FAVdh0LwJCh5EMzBVjo%3D&reserved=0:

@@ -1,6 +1,9 @@

id: d25b1998-a592-4bc5-8a3a-92b39eedb1bc
name: Login to AWS Management Console without MFA.
-description: Multi-Factor Authentication (MFA) helps you to prevent credential compromise. This query looks for login to AWS Management Console without MFA. This is done by looking at eventName of ‘ConsoleLogin and looking in the AdditionalEventData field to check if MFA was used and then confirming from the ResponseElements field that the login was a success.
+description: |
fixed
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F233%3Femail_source%3Dnotifications%26email_token%3DALX3FJ763IKV7JFJU2DMQKLQFWMDHA5CNFSM4IOIDTZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCJHNBA%23discussion_r316371753&data=02|01|Yaron.Fruchtmann%40microsoft.com|867e4feb90b04ac9f7ee08d72670ed45|72f988bf86f141af91ab2d7cd011db47|1|0|637020138769883311&sdata=0tpJm6JHIC5UUO5yT4NJLfUITgB1XnHDu1DSS6F7isw%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALX3FJYD6OKYNOBVNO2O2HDQFWMDHANCNFSM4IOIDTZQ&data=02|01|Yaron.Fruchtmann%40microsoft.com|867e4feb90b04ac9f7ee08d72670ed45|72f988bf86f141af91ab2d7cd011db47|1|0|637020138769883311&sdata=lEFKkpcOmAzTJomkFP8xhzEGzEcCZIByCEiUJO61sVg%3D&reserved=0.


OnInitialize must run in order of declaration in construct_runtime (not in reversed as currently)

Currently OnInitialize is run in the reversed order of their declaration in construct_runtime.
construct_runtime expand AllModules to:
((last, (last-1, ..., (first,))))

and on_initialize for tuple is implemented using first and then second element.
The fix is:
diff --git a/frame/support/procedural/src/construct_runtime/mod.rs b/frame/support/procedural/src/construct_runtime/mod.rs
index d7529cd27..27fd4c3de 100644
--- a/frame/support/procedural/src/construct_runtime/mod.rs
+++ b/frame/support/procedural/src/construct_runtime/mod.rs
@@ -359,10 +359,11 @@ fn decl_all_modules<'a>(
                types.extend(type_decl);
                names.push(&module_declaration.name);
        }
-       // Make nested tuple structure like (((Babe, Consensus), Grandpa), ...)
+       // Make nested tuple structure like ((FirstModule, (SecondModule, (..., (LastModule)...))))
        // But ignore the system module.
        let all_modules = names.iter()
                .filter(|n| **n != SYSTEM_MODULE_NAME)
+               .rev()
                .fold(TokenStream2::default(), |combined, name| quote!((#name, #combined)));

        quote!(

But it needs tests and to make sure it doesn't break anything in kusama/polkadot.
Maybe this should be fixed with a flag in construct_runtime so it is opt-in for other chains.

maybe this should be into substrate 2.0

maybe one solution is to fix it and allow to keep old behavior with an attribute in construct_runtime:
construct_runtime!(
#[set_all_module_reversed_order]
pub enum Runtime where
Block = Block,
NodeBlock = node_primitives::Block,
UncheckedExtrinsic = UncheckedExtrinsic
{
...
})

I believe two of the consensus pallets' on_initialize is sensitive to their ordering.

IMO we will want to have the same order for all hooks, including on_runtime_upgrade.
Maybe we will want on_finalize in reverse order.

maybe we can use some on_finalize_requirement and on_initialize_requirement in hooks, those would return the required pallet to be executed before.
enum HookRequirement {
  PalletIndex(u32),
  Misc([u8; 8]),
}

impl Hooks for Pallet {
  fn on_finalize_requirement() -> Vec<HookRequirement> { ... }
}

issue is still relevant


use self for closure variable

After discussion at 9/15/16 developer meeting, PhET has standardized on the name used for the closure variable whose value is this:
var self = this;
Please update this repository accordingly.

I'm going to do this shortly.

Unit tests are passing before my changes:

Unit tests passing after fixing these:

Grunt is passing.
Built Blast is running fine.
Committing.

Fixed, closing.


If samples is not set for a parameter use start value

If a scan is only over a subset of the parameters then samples shouldn't need to be set for ever parameter and any parameter without samples should use start as the parameter value for every step in the scan.

This was done a long time ago. Not sure how it didn't get closed.


AWS Lambda - Read Only

Langchain trys to download the GPT2FastTokenizer when I run a chain. In a Lambda function this doesnt work because the Lambda is read only. Any run into this, or know how to fix this?

@3coins may be able to help with this.

That would be great if I could get some help with this, or some documentation!
Thank you!

Ah, I have also seen this issue. As I was mentioning on the langchain discord:
OpenAIChat uses GPT2TokenizerFast.from_pretrained("gpt2") for calculating the number of tokens, while tiktoken.get_encoding("gpt2") uses `tiktoken.
The first one is not usable when going serverless (AWS lambdas, or Google Cloud Functions). And it might represent a deal breaker for a more than valid use case. I'd even say a desirable use case, the serverless scenario.
So far I have been able to find a workaround, but it's not ideal and will be likely to suffer breaking changes as they continue updating langchain (which happens very frequently).
The workaround is to create a custom implementation of OpenAIChat overriding the problematic function.
class TikOpenAIChat(OpenAIChat):
    def __init__(self):
        super().__init__()

    def get_num_tokens(self, text: str) -> int:
        import tiktoken
        enc = tiktoken.get_encoding("gpt2")
        tokenized_text = enc.encode(text)
        return len(tokenized_text)

I hope this helps on your scenario @Joepetey , and let's aim for an official solution from @hwchase17

Alternatively we could continue using GPT2FastTokenizer but we need facilitate a way of selecting where are those models going to be stored, serverless functions has typically some available space on /tmp.
Now, having to download everytime (serverless is stateless) is going to make things very slow I believe.
I am talking btw without being an expert.

the problem is in this function https://github.com/hwchase17/langchain/blob/763f87953686a69897d1f4d2260388b88eb8d670/langchain/llms/openai.py#L421
encoder = "gpt2"         if self.model_name in ("text-davinci-003", "text-davinci-002"):             encoder = "p50k_base"         if self.model_name.startswith("code"):             encoder = "p50k_base"         # create a GPT-3 encoder instance         enc = tiktoken.get_encoding(encoder)`
this should fix it
if self.model_name.startswithl('gpt-3.5-turbo'):
enc  = tiktoken.encoding_for_model('gpt-3.5-turbo')
if you do not use this you are going to miscalculate the tokens from the role\user assistant part of the message.

I have opened a PR that would solve this issue.
https://github.com/hwchase17/langchain/pull/1457

Wow thank you @juankysoriano this is so helpful!

solved by https://github.com/hwchase17/langchain/pull/1457

Quick question, when can we expect this to be available in a release?

I don't know but the owner is typically very fast on doing releases, they are very frequent. It shouldn't take more than a couple of days in my experience. Will see

@Joepetey if the recent release, 0.0.102 solved your problem, the issue can be closed.

Alternatively we could continue using GPT2FastTokenizer but we need facilitate a way of selecting where are those models going to be stored, serverless functions has typically some available space on /tmp.
Now, having to download everytime (serverless is stateless) is going to make things very slow I believe.
I am talking btw without being an expert.

With AWS you can mount an EFS to a lambda to cache a pre-trained model.
Checkout this example https://github.com/aws-samples/zero-administration-inference-with-aws-lambda-for-hugging-face
Also if you're using HuggingFaceEmbeddings (which uses sentence_transformers.SentenceTransformer) you need to use SENTENCE_TRANSFORMERS_HOME env variable to download the model at a specific location

Thank you Juanky, it worked!


Make @KomapperProjection independent from @KomapperEntity

The class annotated with @KomapperProjection no longer needs to have @KomapperId.
Entity and Projection
@KomapperEntity
data class Person(@KomapperId val id:Int, val firstName: String, val lastName: String, val age: Int)

@KomapperProjection
data class PersonDto(val name: String, val age: Int)

Query
val p = Meta.person
val query: Query<List<PersonDto>> = QueryDsl.from(p)
  .selectAsPersonDto(
    name = concat(concat(p.fristName, " "), p.lastName),
    age = p.age,
  )

Looks great :smile: ! So this doesn't generate the extension on Meta unless annotated with @KomapperEntity too?
The only thing that would have been great is to take into consideration properties with default values or nullables and allow that to be used as default values in generated selectAsXXX functions, since that would allow re-use of certain projections when missing certain info to fill it in the query... I'm not sure how complicated that would be know that you seperated the projection generation from the entity generation...
Thanks for this PR!

Thank you for your comment.

So this doesn't generate the extension on Meta unless annotated with @KomapperEntity too?

No, it doesn't generate the extension on Meta.
However it generate the extension on ProjectionMeta.

The only thing that would have been great is to take into consideration properties with default values or nullables and allow that to be used as default values in generated selectAsXXX functions

Speaking of default values, it's not possible because KSP doesn't support it.
https://github.com/google/ksp/issues/642
What kind of support are you looking for regarding nullables?

Say I have:
@KomapperProjection
data class Foo(val bar: Int, val baz: String? = null, val baz2: String = "some value")

// Can this be generated? (I didn't write the types right, I know, it should be
fun ....selectAsFoo(bar: ColumnExpression<Int, Int>, baz: ColumnExpression<String, String>? = null, baz2: ColumnExpression<String, String>?  = null)
// If null is passed to any parameter or a parameter is not provided, then you can instantiate Foo with the default values. Ksp doesn't need to get the default values, you just need to be able to instantiate the class with them if they are not provided...

To decide whether to use default values for each instance, it is necessary to retrieve the default values in KSP. However, this is impossible to achieve as KSP does not support it. This discussion was carried out at
https://slack-chats.kotlinlang.org/t/16292178/why-is-a-komapperprojection-a-komapperentity-it-s-a-bit-conf#2639bf4d-50cc-4588-ab13-9edd029bde09

I have added two utility functions.

tranform
nullLiteral

@KomapperEntity
data class Address(@KomapperId val id:Int, val street: String, val version: Int)

@KomapperProjection
data class AddressDto(val street: String?, val comment = String)

val a = Meta.address
val query: Query<AddressDto> = QueryDsl.from(a)
  .selectAsAddressDto(
    street = nullLiteral(), // set a null to the street property of AddressDto
    comment = a.id.transform { "Comment for id: $it" }, // transform an id value to a string value
  ).single()
val dto = db.runQuery(query)
println(dto.street) // null
println(dto.comment) // Comment for id: 1

No, they will not default to null. I believe that in many cases, just because a field is nullable does not mean we would want its default value to be null.


feat: Add fgac samples and resolve stale test error

Add FGAC samples and resolve error with ReadStaleDataAsyncTest

Add FGAC samples and resolve error with ReadStaleDataAsyncTest

huioutgyyi8iiu88


onloadmore called when first call fails

onloadmore method is called even if its not end of page, I would like to understand in what condition onloadmore will be called
Thanks!

The key is to controll hasLoadedAllItems method in Paginate.Callbacks class , like:
@Override
public boolean hasLoadedAllItems() {
return hasLoadedAllItems;
}
then:
/**

list  is a page of data returned from the interface
ONE_PAGE_COUNT is request once data count specified by the interface
**/
public void setHasLoadedAllItems(List list){
if( list==null || list.size() < ONE_PAGE_COUNT){
this.hasLoadedAllItems=true;
}else {
this.hasLoadedAllItems=false;
}
}
this is success callback of interface
public void onGetWaitingListSuccess(List visitWaitingListBeans,boolean pullToRefresh) {
setHasLoadedAllItems(visitWaitingListBeans);
if(pullToRefresh){
mVisitWaitingListBeans.clear();
}
mVisitWaitingListBeans.addAll(visitWaitingListBeans);
notifyView();
}

onloadmore method is called even if its not end of page, I would like to understand in what condition onloadmore will be called
Thanks!

onLoadMore is called when the threshold (number of items not displayed at the end of the list) is reached. You can set a custom threshold via builder (default is 5).
Can you provide your code example of paginate initialization? Also, can you explain a bit more what behavior you are experiencing and what are you expecting?


Dedicated edit preview buttons

Summary
This PR includes the implementation of splitting the template logic of rendering of edit/preview buttons to dedicated edit/preview buttons using CMSToolbar items.
Documentation checklist

[ ] I have updated CHANGELOG.txt if appropriate
[ ] I have updated the release notes document if appropriate, with:

[ ] general notes
[ ] bug-fixes
[ ] improvements/new features
[ ] backwards-incompatible changes
[ ] required upgrade steps
[ ] names of contributors

[ ] I have updated other documentation
[ ] I have added my name to the AUTHORS file
[ ] This PR's documentation has been approved by Daniele Procida

Coverage remained the same at 77.671% when pulling e84e826edd104c4becb80a0f70d02a1b0a96eb90 on FidelityInternational:feature/dedicated-edit-preview-buttons into aa363d356667836ad553688be00e111324a29f1e on divio:release/4.0.x.

@czpython Changes have been made. Please review.

@malindap92 @chaosk will re-check soon. No later than end of week.


sriov-device-plugin config map created by SriovNetworkNodePolicy controller is never cleaned up

we set no OwnerRef so there is no cleanup.
also the Reconcile flow does not contain logic to explicitly clean it.
Suggestion: set SriovOperatorConfig "default" obj as its owner like set for sriov-device-plugin

@SchSeba @zeeke  WDYT ?
RE:

Suggestion: set SriovOperatorConfig "default" obj as its owner like set for sriov-device-plugin

That sounds good to me

#623

closed by https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/623


Radiolib bandwidth

https://github.com/richonguzman/LoRa_APRS_Tracker/blob/97122eec5be81d27e255bed83299cfee7fc4c12c/src/lora_utils.cpp#L95
https://github.com/richonguzman/LoRa_APRS_Tracker/blob/97122eec5be81d27e255bed83299cfee7fc4c12c/src/lora_utils.cpp#L48
In radiolib the bandwidth in kHz.

yes yes! I'm on it very soon!

corrected ;)


Synced repo with latest changes from TS SDK

Kudos to @Sudakatux, who made these changes. I was only cleaning up PRs and branches :)


Autocompletion isn't working in pug file

I am not getting windiCSS autocompletion when using pug in vscode :thinking:
Steps:

Create new project pnpm exec create-vite windi-int --template vanilla-ts
add windi & pug: pnpm add vite-plugin-windicss windicss pug-cli
Install WindiCSS IntelliSense extension
add vscode config:
Add vite config & windi import in main file according to docs: https://windicss.org/integrations/vite.html#install

{
"windicss.enableEmmetCompletion": true,
// Below setting is not working I guess. I don't know if this is even required or not
"windicss.includeLanguages": {
"*.pug": "html"
}
}
// vite.config.ts
import WindiCSS from 'vite-plugin-windicss'
export default {
plugins: [
WindiCSS(),
],
}
// main.ts
import 'virtual:windi.css'
import './style.css'
With this setup if I type .h in HTML file I am getting autocompletion but in .pug file with .h I am not getting autocompletion :thinking:
What I am missing here.
Regards.

Hi @alexanderniebuhr I tried that but it isn't working.
However, if we use file association config:
"files.associations": {
    "*.pug": "html"
  },

it shows suggestions but I lost pug features like syntax highlighting

Do you want me to provide GitHub repo?
I am happy to create one for you.

it would be great to get a very simple one pls

Hi @alexanderniebuhr
Here's the repo: https://github.com/jd-0001/windi-autocompletion-issue
and steps are mentioned in readme.
Regards.

Can we now remove the label "needs reproduction"?

@jd-0001 ok i can reproduce it now. Have to look into it in more detail to find a fix

@jd-0001
ok I was pretty stupid. the language identifier is jade not pug
so, this config should work.
    "windicss.includeLanguages": {
        "jade": {
            "type":"html",
            "patterns": [
                "(\\s+class(Name)?\\s*=\\s*{?\\s*[\"'`])[^\"'`]*$"
            ]
        }
    },

Hi, @alexanderniebuhr Have you tried that?
I updated settings.json according to provided snippet but the result is the same.

Yea I have tried it with the jade config and the latest update.

Hi @alexanderniebuhr
Sorry to say but I updated the settings according to your snippet as shown in the below commit: https://github.com/jd-0001/windi-autocompletion-issue/commit/e6cbe6fd3ce1db89095ae83e9a727437c9c7d29d but still autocompletion isn't working in .pug file :thinking:
I am also using the latest VSCode release and uninstalled & reinstalled windicss-intellisense extension.
As I have updated the settings in the sample repo, can you test it once again?
Regards.

'div(class="bg-' works for me.
If you need any other syntax to autocomplete, you need to add a custom pattern!

@jd-0001 sorry the release of yesterday version v0.21.2 was not published. It should work with that version. Also, I think you can try to change the pattern to:
"patterns": [
    "(\\s*class(Name)?\\s*=\\s*{?\\s*[\"'`])[^\"'`]*$",
    "\\.\\S*$"
]

Hey @alexanderniebuhr It's working with your latest patterns :heart_eyes:
For others below is full config as I will remove the repo from my github.
{
    "editor.quickSuggestions": {
        "strings": true
    },
    "windicss.enableEmmetCompletion": true,
    "windicss.includeLanguages": {
        "jade": {
            "type": "html",
            "patterns": [
                "(\\s*class(Name)?\\s*=\\s*{?\\s*[\"'`])[^\"'`]*$",
                "\\.\\S*$"
            ]
        }
    },
}

Thanks for taking the time to look into this.
I really appreciate that. :blush:


different letters being displayed

SWF: 860eab9472546d8b2b66079b2d926cd9523382bdf03753d6408d61c21515b6f2 (Direct Link)

Works for me now. Thank you.


master pod consumers extremely high vm resources when running 'alluxio fs ls '

Alluxio Version:
alluxio-2.3-fuse, with adls gen1 supported.
Describe the bug
With alluxio deployed on k8s, I mounted an adls gen1 folder (~4 TiB data, 8 files in total) and then run 'alluxio fs distributedLoad /adls' to preload data.
Then I observed vm (the node hosting the alluxio master pod) resource usage extremely high when running 'alluxio fs ls /adls' on alluxio master pod. I didn't figure out which usage is extremely high: network, memory, cpu, disk I/O. This behavior impacts k8s health status and causes livesite issues on our k8s.
The adls gen1 folder contains 8 files, 4TiB data in total.
Size of one file is 3.8 TiB, size of another file is 900 GiB. and the other files are all in GiB level.
To Reproduce

Deploy alluxio to k8s
mount an adls gen1 folder with big files.
on alluxio master pod, run 'alluxio fs distributedLoad '
on alluxio master pod, run 'alluxio fs ls '
At last step, extremely high resource usage observed. and command 'alluxio fs ls ' may return timeout error.

Expected behavior
all alluxio operations should not impact k8s health status.
Urgency
Blocking issue for our critical perf test.
Additional context
Add any other context about the problem here.

@chaowangnk1 after alluxio fs ls times out, can you download master and job_master log here? they should be located at your master pod at /opt/alluxio/logs/{master,job_master}.log.
I want to see if there is any error in the logs.
meanwhile, if you have threaddump of alluxio master process at that moment, that will also be very helpful.

@calvinjia FYI
Fixed by https://github.com/Alluxio/alluxio/pull/12315 as reported by @chaowangnk1
The reason is that master resource utilization was kept high in sending results to different client (FUSE) after fs ls, without being able to  release resource timely


add table in index .html

add a full fledge dynamic table

sure you can salso help

let me also try it !!

i can help you

I will help


Update for v1.0

Any chance there will be an update for Tailwind v1.0
I managed to hack something together to get it working temporarily in a project i needed it for, but official support would be great 👍

Hi @JayBizzle
Sure, once Tailwind hit v1 I will update it directly

Brilliant, thanks!

Here comes 1.0
https://tailwindcss.com/docs/upgrading-to-v1/

You will get it soon.

Hi @Knovour , @JayBizzle
The new version in live in next tag.
npm i tailwind-css-variables@next

Please check it give me a feedback.

it's live now.


Adição do delegate na documentação e expansão do on

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Default password

https://github.com/ngoduykhanh/wireguard-ui/blob/e74a3a808f5ab2c2cb68662742885c85d97126bf/util/config.go#L17
Hi,
It would be nice to implement availability to change default hardcoded password for user admin :)

Yes, it is requested in #45 :-).


Possible issue in Leader::ExternalRouteLookup()

I am not sure if this is really an issue/bug, but thought it'd be safer to mention it so it can be checked... :)
In Leader::ExternalRouteLookup() method, we go through the network data tlvs in mTlvs and check any PrefixTlv to see if prefix matches our destination, and if it does we then go through sub-tlvs of the prefix tlv and check for preference, rout cost , etc.
We use the variable cur in an outer loop to to go through all the tlvs and then in an inner for loop we use cur to go through the prefix sub-tlvs.  If I am not mistaken, at the end of the inner sub-tlv loop, the cur will be at the end of all sub-tlvs of the PrefixTlv which should be start of next tlv. When/If we go back to the outer loop, we will do a cur = cur->GetNext() as part of the loop iteration which is intended to jump over the PrefixTlv but I think it will skip the next tlv. @jwhui  is there something I am missing? Thanks.
If this is actually an issue, fix should be simple: We can use a different local var like subCur for inner loop.

Yes, good catch!  Feel free to submit a PR to fix this.  Thanks.

Fixed in #217.


Parent selectors

Parent selectors don't work as expected
a {
    & span { color: red; }
    div & { color: green; }
    p & span { color: blue; }
}

This should output something like the following:
a span { color: red; }
div a { color: green; }
p a span { color: blue; }

the LESSPHP version does something for this: http://leafo.net/lessphp/docs/#nested_blocks
I think the implementation detail is that when the parent selector is present, it's moved up a level or elevated in scope ( dropping ".a " from your ".a .a.a" rule) rather then being considered as a normal nested rule.
There'd be overhead maybe on a rule like "& .a" as it'd be the same result as a standard nested rule.


fix: properly cast the date in evm_setTime

Fixes #600
When calling evm_setTime through JSONRPC, this value is a string/number but blockchain.setTime expects it to be a date.
This cannot possibly have side effects since even if a Date is passed in there, new Date(date) will preserve the value

Coverage remained the same at 82.527% when pulling 1b23a0becad79306036b5906f30ce206df5b449f on AdExNetwork:develop into 18f11f75fc6bb048fcc44c9b40b1556a392f31d7 on trufflesuite:develop.

Coverage remained the same at 82.527% when pulling 1b23a0becad79306036b5906f30ce206df5b449f on AdExNetwork:develop into 18f11f75fc6bb048fcc44c9b40b1556a392f31d7 on trufflesuite:develop.

Coverage remained the same at 82.527% when pulling 1b23a0becad79306036b5906f30ce206df5b449f on AdExNetwork:develop into 18f11f75fc6bb048fcc44c9b40b1556a392f31d7 on trufflesuite:develop.


Standardize vesc speed to m/s conversion.

Before this commit the vesc_to_odom node and the ackermann_to_vesc_node were using a different formula for converting m/s to erpm.
The conversion from m/s to erpm is done here with the following formula:
servo_msg.data = steering_to_servo_gain_ * cmd->drive.steering_angle + steering_to_servo_offset_;

Inverting this formula leads to:
(servo_msg.data - steering_to_servo_offset_)/steering_to_servo_gain_  = cmd->drive.steering_angle ;

so for consistency, it would be better to remove the minus sign from the conversion in the vesc to odom node and use the vesc tool to configure the vesc to provide the information with the correct direction.

To add a bit more in the ROS2 branch, the sign inversion from the rpm ( as reported in https://github.com/f1tenth/vesc/issues/9 ) is removed see ( https://github.com/f1tenth/vesc/blob/153998df8545fe1781b975df88e411b4e71d4bfe/vesc_driver/src/vesc_packet.cpp#L250 ) .... while on the main is still there ( https://github.com/f1tenth/vesc/blob/main/vesc_driver/src/vesc_packet.cpp#L178 ) .
In this cleaning attempt also removing this other inversion makes sense.
As a remark, anyway, the user can change the sign of the gain in the ackerman package (we have 4 2 for the transform from ackermann to vesc and 2 for transforming back) or (maybe cleaner) modify the motor direction from the vesc tool.

@JWhitleyWork  any feedback here?

I'm OK with this in-theory. However, this is a breaking change because it could damage existing vehicles if they unkowingly upgrade, which I think is concern enough to leave it out. This would bug me too but I think the safety/property damge concern is enough to leave it as-is. If others disagree, I'm cool with changing it but we need to make notices in a lot of places.

Sorry I have just realized that in my first comment, I was wrongly referring to steering gain when the correct word is speed gain.
The ros2 version already differs from the ros1 version in the sign of the rpm (https://github.com/f1tenth/vesc/blob/main/vesc_driver/src/vesc_packet.cpp#L172) so in the past, you already somehow decided in favour of having a cleaner conversion of the data from the vesc. For this reason, upgrading from ros1 to ros2 will already face the user a problem in porting the configurations.
The PR here tries to finalize this attempt and makes the data more intuitive: with a correctly configured vesc (i.e. forward control return a forward spinning engine) this PR allows to share of the configuration between the Ackermann to vesc and vesc to odom. In the current situation inverting the sign of the speed gain is required.
Anyway, I understand your view. Since the ROS2 support was recently added maybe not many people are using it but I cannot quantify the number and I cannot quantify the impact of this change.
If you think that the risk is too big feel free to close this PR.

@JWhitleyWork  should we then close this?

Yes, closing. Thank you for the work and feedback.


Signature verification fails all the time on Probot v13

Bug Report
Current Behavior
Using latest Probot v13.2.0. Request signature verification fails all the time.
But it works with Probot v12.3.3
const probot = createProbot({
        overrides: {
            appId: credentials.appId,
            privateKey: credentials.pem,
            secret: credentials.secret,
            // logLevel: 'debug',
        }
    });

Environment

Probot version(s):  v13.2.0
Node/npm version: Node 20.12.0/npm 10.5.2
OS: MacOS 14.4.1

Possible Solution
Switching to Probot 12.3.3 made it work

Have you made sure to read through the release notes for v13?
I'm going to need more information on the environment used, NodeJS HTTP server, express?
How are you consuming Probot within your http server?
I'm going to need a full minimal reproducible example.

My webhook is running as part of Next.JS app using Pages router - unfortunately it looks like Probot does not have good support for the new App router, I could not find any information on that at all.
I looked at the release notes and the only thing attributable to this would probably be confguring NODEJS_HELPERS env. variable. I've tested that with v13+ and it does not work. As soon as I switch back to the latest v12, everything starts working.
My setup within the webhook route is super simple :
 const probot = createProbot({
        overrides: {
            appId: credentials.appId,
            privateKey: credentials.pem,
            secret: credentials.secret,
            // logLevel: 'debug',
        }
    });

    const processRequest = createNodeMiddleware(bot, {
        probot: probot,
        webhooksPath: `/api/ghapp/${id}/hook`,
    });

    processRequest(req, res)

Is your app running on Vercel or elsewhere

Currently I run locally and testing through https://ngrok.com/

That would explain why the env variable isn't working...
Have you taken a look at https://nextjs.org/docs/app/building-your-application/routing/route-handlers#webhooks
The error is most likely because you are parsing the payload before Probot receives it. You must pass it as a string to Probot

This helpful page will get you on your way: https://www.codedaily.io/tutorials/Stripe-Webhook-Verification-with-NextJS

Thank you! You comments pointed me to the right path.
It is possible to make it work with exported configuration on route, which looks like
export const config = {
    api: {
        bodyParser: false,
    },
}

This also removes the need for setting NODEJS_HELPERS variable.
Would you be able to point me to some resource which explains how to use Probot with the App router introduced in NodeJS 13+?


Add QC check if no reads are left after cutadapt

Problem
Recently had a project that had no reads left after trimming. The sample did not fail and continued downstream making it difficult to pinpoint where the sample had truly failed
Solution
After cutadapt add a check to ensure there are suitable number of reads to move on in the pipeline.

this can happen if a file contains only adapters -- make a unit test with adapters

add code to cutadapt rule. if the file is empty, throw an error

capture output from cutadapt summary
=== Summary ===

Total read pairs processed:              4,857
  Read 1 with adapter:                     555 (11.4%)
  Read 2 with adapter:                     604 (12.4%)
Pairs that were too short:                 604 (12.4%)
Pairs written (passing filters):         4,253 (87.6%)


Enhancing  Applicaition::setLocale

What is the reason behind this? Can you add some description?

While it may seem reasonable that Laravel used the built-in support for Locales in PHP; this isn't the way.
Locale::setDefault wants a BCP 47 locale (sv-SE), but Laravel has opted to use ISO 15897 locales (sv_SE) which is how you specify posix locales (and charmaps). They are not the same, albeit look very similar as long as you only using language+region definitions.
It all changed when the fire nation attacked... Also, when you start thinking about scripts. For example, I may have written a text in Swedish, but using braille, which would be sv-Brai-SE in BCP 47 and something you would cry over in posix locales...

@sisve  intl extension is compatible with both locale format please refer to its docs.


Added tests for start_workflow_execution.go

What changed?
Added new tests for start_workflow_execution.go
The coverage is around 73%

Why?
coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018f73fa-3e66-4cbe-9403-7401361c0be5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
240 unchanged lines in 16 files lost coverage.
Overall coverage decreased (-0.02%) to 69.154%

Files with Coverage Reduction
New Missed Lines
%

service/history/queue/timer_queue_processor_base.go
1
77.66%

common/task/weighted_round_robin_task_scheduler.go
2
88.56%

service/history/shard/context.go
2
68.91%

service/frontend/api/handler.go
2
62.2%

service/history/task/transfer_active_task_executor.go
2
72.9%

service/history/execution/context_util.go
2
89.31%

common/log/tag/tags.go
3
50.46%

service/history/task/fetcher.go
3
86.6%

common/archiver/filestore/historyArchiver.go
4
80.95%

service/history/engine/engineimpl/terminate_workflow_execution.go
4
73.33%

Totals

Change from base Build 018f738f-70da-4942-afab-552bc50965d4:
-0.02%

Covered Lines:
101605

Relevant Lines:
146926

💛  - Coveralls


Fix badges

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.926%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1242

Relevant Lines:
1516

💛  - Coveralls


refactor(@angular-devkit/core): refactor the DevServerBuilder to be e…

In order to be able to extend Builders, the webpack configuration needs to be overridable.
This pr make it possible to do that. (The same approach as the BrowserBuilder uses.)

@filipesilva done


WORDLE has made me sad, please help

Sample (which sample are you having trouble with)
WORDLE
What Should Happen

What Actually Happens
In line 3, the first "L" is highlighted yellow even though it only exists once in the word.

@FKatrin
Thank you for reporting this issue! I will investigate the cause.


Javascript Semantic Declaration order is not respected

The semantic declaration order is not respected in Pumascript. The testcase that must pass is the following one:
foo(2,3);

function foo(a, b) {
    return a + b;
}

Ema can you give me an example of a failing statement that I can use in the puma-editor?
I tried the following example and it worked fine I believe:
/** @meta */
function sum(a, b)
{
return pumaAst( $a +  $b);
}
sum(5, 6);

The problem is if you call some function that was not defined yet. This in JS works fine but in puma not.
If you see the example, you can use it to verify:
`foo(2,3);
function foo(a, b) {
return a + b;
}
`


UART4 & UART5 missing from stm32f103r_pinmap.h

The higher density stm32f103Rx chips (such as the stm32f103ret6) have UART4 & UART5. These UARTS are missing from the following pinmap:
https://github.com/apache/nuttx/blob/fac10b6ebdec6d98f8b833137153ec43e71d706d/arch/arm/src/stm32/hardware/stm32f103r_pinmap.h#L271
Adding the following lines would fix this issue:
#define GPIO_UART4_RX       (GPIO_INPUT|GPIO_CNF_INFLOAT|GPIO_MODE_INPUT|GPIO_PORTC|GPIO_PIN11)
#define GPIO_UART4_TX       (GPIO_ALT|GPIO_CNF_AFPP|GPIO_MODE_50MHz|GPIO_PORTC|GPIO_PIN10)

#define GPIO_UART5_RX       (GPIO_INPUT|GPIO_CNF_INFLOAT|GPIO_MODE_INPUT|GPIO_PORTD|GPIO_PIN2)
#define GPIO_UART5_TX       (GPIO_ALT|GPIO_CNF_AFPP|GPIO_MODE_50MHz|GPIO_PORTC|GPIO_PIN12)

However I am not sure if this would cause a breaking change on the lower density chips that do not have these UARTS.

Easy I think?
#if defined(ARCH_CHIP_STMxxx) || defined(ARCH_CHIP_STMyyy || etc
define GPIO_UART4_RX
etc
#endif
From: Andrew Brahim @.>
Date: Sunday, 22 January 2023 at 19:26
To: apache/nuttx @.>
Cc: Subscribed @.***>
Subject: [apache/nuttx] UART4 & UART5 missing from stm32f103r_pinmap.h (Issue #8218)
The higher density stm32f103Rx chips (such as the stm32f103ret6) have UART4 & UART5. These UARTS are missing from the following pinmap:
https://github.com/apache/nuttx/blob/fac10b6ebdec6d98f8b833137153ec43e71d706d/arch/arm/src/stm32/hardware/stm32f103r_pinmap.h#L271
Adding the following lines would fix this issue:
#define GPIO_UART4_RX       (GPIO_INPUT|GPIO_CNF_INFLOAT|GPIO_MODE_INPUT|GPIO_PORTC|GPIO_PIN11)
#define GPIO_UART4_TX       (GPIO_ALT|GPIO_CNF_AFPP|GPIO_MODE_50MHz|GPIO_PORTC|GPIO_PIN10)
#define GPIO_UART5_RX       (GPIO_INPUT|GPIO_CNF_INFLOAT|GPIO_MODE_INPUT|GPIO_PORTD|GPIO_PIN2)
#define GPIO_UART5_TX       (GPIO_ALT|GPIO_CNF_AFPP|GPIO_MODE_50MHz|GPIO_PORTC|GPIO_PIN12)
However I am not sure if this would cause a breaking change on the lower density chips that do not have these UARTS.
—
Reply to this email directly, view it on GitHubhttps://github.com/apache/nuttx/issues/8218, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANQZJKOH3CJEEYRJ2DO5GZ3WTWCWFANCNFSM6AAAAAAUDEVFNY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


elfeed fails on planet python feed

Getting these two errors when elfeed tries to download the feed from planet python
[2016-05-26 09:48:26] [error]: Elfeed fetch failed for http://planetpython.org/rss20.xml: (:error (error connection-failed "failed with code 111\n" :host "planetpython.org" :service 80))
[2016-05-26 09:48:26] [error]: Elfeed fetch failed for http://planetpython.org/rss20.xml: (:error (error connection-failed "deleted\n" :host "planetpython.org" :service 80) :error (error connection-failed "failed with code 111\n" :host "planetpython.org" :service 80))

A curl from the same box shows a success:
; curl -D- -o /dev/null -s 'http://planetpython.org/rss20.xml?foo=bar'
HTTP/1.1 200 OK
Server: nginx
Date: Thu, 26 May 2016 16:47:15 GMT
Content-Type: text/xml
Content-Length: 239262
Last-Modified: Thu, 26 May 2016 13:49:53 GMT
Connection: keep-alive
ETag: "5746ff01-3a69e"
Accept-Ranges: bytes

Using elfeed 1.40 on emacs 24.4.1 on Ubuntu 14.04

I suspect this is a local network issue on your end despite the fact
that curl is working fine with this URL. I'm unable to reproduce the
issue for myself. What happens when you fetch the feed directly via
url-retrieve?
(pop-to-buffer
 (url-retrieve-synchronously "http://planetpython.org/rss20.xml"))

Does this pop up a buffer with the expected RSS content?
And, by the way, thanks for including all your version information up
front. That helps to immediately narrow things down.

Yeah, url-retrieve shows an empty buffer with failed in the title. Weirdness abounds.
Sorry to trouble you. I was hoping it was something you had seen before. I have about 40 feeds going and this is the only one that has this problem. I'll dig into it a bit more on my side.
Thanks for elfeed! I use it daily.


There seems to exist unnecessary dependencies

Warning appears when attempting to install from pypi on VertexAI managed notebook (Tensorflow 2.6 image): "ignoring invalid distribution -yping-extensions"
Also additional dependency conflicts occur, but will need to add later. Largely conflicts with backend tensorflow extensions such as tensorflow-io and explainable-ai-sdk.

Need to set the dependency that this can install on a pre-existing, google managed tensorflow 2.X image without any conflicts.

This was resolved in the previous commit. (e9a7abf1f4ba0314fc1df4d8842bc18ee01b6a62)


Integrate TypeChain with the node

Provides TS support to Ethereum contracts
https://github.com/ethereum-ts/TypeChain

Most of the work was actually done in https://github.com/api3dao/airnode/pull/270


Stop the maven whinging

Windows Build 1506 is now running using a merge of 8549f02ec8a50a2b0d440839fb9613e5c2c0bacc

Linux Build 1954 is now running using a merge of 8549f02ec8a50a2b0d440839fb9613e5c2c0bacc

Core - Full Integration Build 1096 is now running using a merge of 8549f02ec8a50a2b0d440839fb9613e5c2c0bacc

Windows Build 1506 outcome was SUCCESS using a merge of 8549f02ec8a50a2b0d440839fb9613e5c2c0bacc
Summary: Tests passed: 3207, ignored: 71 Build time: 0:22:43

Linux Build 1954 outcome was SUCCESS using a merge of 8549f02ec8a50a2b0d440839fb9613e5c2c0bacc
Summary: Tests passed: 3207, ignored: 71 Build time: 0:25:45

Core - Full Integration Build 1096 outcome was SUCCESS using a merge of 8549f02ec8a50a2b0d440839fb9613e5c2c0bacc
Summary: Tests passed: 2877, ignored: 375 Build time: 0:49:21


about the hand dataset

hello,could you please tell me how to get the small datasets about hand which you mentioned in the paper?

After we have applied Openpifpaf on images, for each image, we check if at least one hand is fully detected which has all 21-joint 2D annotations. (These hands are not occluded, otherwise openpifpaf won't predict their positions). For such a hand we crop (x.min-50, y.min-50, x.max+50, y.max+50) region and reshape to 384x384 and save the cropped hand image, until we have enough number of samples we need (22k).
Same for the face

Thanks very much.

I would be grateful if you could post the dataset about the hand.

I am sorry I think I couldn't, since they are the cropped images from original videos of Human3.6m dataset, which their copy right says " This product may only be used by you, and you may not rent, lease, lend, sub-license or transfer the dataset or any of your rights under this agreement to anyone else."


Run code runs the code in non-writable output window

When Running code using the Run code (Ctrl+Alt+N) it always runs in output window which is non-writable. Consequently if the program expects an input then it cannot be done. There are three ways to solve it:

Enable the output window to receive the input for the program (Make it writable just for the input of the program). This would make it easy for the user to have the same interface irrespective of the program.
Detect that the program expects an input and disable the Run Code command and its triangle icon on the right top and force the person to use the terminal to execute the command for the program to run, and
Detect that the program expects an input and run it in the terminal instead of the output window.

I know the alternative is to run the program from the terminal. But most often one will use the Run Code and get stuck. Then force kill the run. Then move to terminal.

Have you tried running it under linux ? In my experience, in linux, run/debug sessions happen in the integrated terminal that can very well accept user input. Under windows, it shows either in external cmd console or else in debug console. The latter, indeed, does not accept user input. However, on my windows machine, I installed WSL and run "code ." from within WSL. This effectively means that even on the window machine, it runs as if it is under linux. This allows it to run in the terminal windows that is integrated.
If I understand correctly, one cannot run from a windows platform in the integrated terminal.

/extCpp

Debuggers have the ability to launch their programs in VS Code's integrated terminal, rather than purely in the REPL. If the debugger for the language you're using doesn't have this capability, please open an issue on that debugger extension.


Updating animelist with started_on and finished_on

The documentation does not reflect the POST or PUT changes to update records on our lists to add the dates.
I have tried the following fields with no luck:
start_date
end_date
started_on
finished_on
With data like 2016/08/08/ but my record still does not have start and finished dates.
EDIT: Also there doesn't seem to be a way to to change the private property in the post body.

started_on and finished_on should work with any dates like 2016/08/08 (YYYY/MM/DD), they work on the anilist site so they should work on the api (its the same thing). private is 0 or 1. Again you might be better off checking if/how its done on the anilist site by checking the network requests in the dev tools as it uses the exact same api for the most part.

I ultimately got it work with start_date and end_date. It kept failing because my MM and DDs didn's have leading zeroes.


Fix versioning

Implements #94

@Marius1311 - I think we will be able to put this on PyPI soon. However I'd like these to be merge before an official release:

[ ] https://github.com/theislab/cellrank/issues/222 (Marius) - is this straightforward?
[ ] https://github.com/theislab/cellrank/issues/219 (Marius) - I think this can be done pretty fast
[ ] https://github.com/theislab/cellrank/issues/141 (Michal) - I suggest requiring scanpy>=1.5 (scvelo does it as well) and save the transition matrix in .obsp
[ ] https://github.com/theislab/cellrank/issues/192 (Michal) - the problem seems to be with the bashuploader - I've changed the workflow, not using the codecov-actions, but only the uploader, and it still doesn't work (because the uploader detects whether we're in an Action or not) - I suggest doing it manually for now, until someone responds on codecov-actions with a solution.

Also we should start documenting the releases in our docs.

@Marius1311 Can you try downloading from PyPI test?
pip install -i https://test.pypi.org/simple/ cellrank==1.2.1a0

Thanks Mike! #222 is done. #219 mainly aims at our transition matrix to be the same as scanpy's in case we only use a ConnectivityKernel. I will open a PR for this with an associated test that makes this more obvious. I should be able to do this later today or tomorrow.

Re #141, fine by me to require scanpy>=1.5. Feel free to make the required changes and to close #144

Re #192, maybe Phil can help? manual would be fine with me for now as well.

Okay, running pip install -i https://test.pypi.org/simple/ cellrank==1.2.1a0 gives me
ERROR: Could not find a version that satisfies the requirement matplotlib>=3.0.3 (from cellrank==1.2.1a0) (from versions: 2.2.3)
ERROR: No matching distribution found for matplotlib>=3.0.3 (from cellrank==1.2.1a0)

I'm running python 3.6 in a new conda environment if that helps.

#219 is not super relevant at the moment, we can safely do this after pypi release.

Ok, let's do it as follows: I will fix #141 and post in on PyPI as pre-release (i.e. v1.0.0-alpha or similar). Once the manuscript is done (and other issues are fixed), we'll bump the version.

sounds good to me.


Style of Translations

Should we follow Microsoft Style Guide strictly in the translations?
We didn't follow the official Microsoft voice strictly in current version of Simplified Chinese translations in res_zh-CN.rc (since it's my native language so I can only check this one). As we are working on more languages (Japanese, Polish, Hebrew), we should set up a standard.

https://www.microsoft.com/en-us/language/StyleGuides

In terms of language probably except where it departs for the current style, does anyone have the 3x era equivalent of this document? (Was there one?)

One obvious example is "directory", in Hebrew 3.11 it was translated to the word equivalent to "library".
the term "library" means mostly (in computer terminology) software libraries.
Since then it got replaced by "folder" which is way more clear in the meaning.

Maybe we could use Fluent Design style to redesign this file manager :-)

@wbsdty331  No?

TL;DR: No redesign, please.
I see this as a retro tool. Redesigning would remove its main purpose to
exist, IMO.
On Wed, Jun 6, 2018 at 4:33 AM, Zander<EMAIL_ADDRESS>wrote:

@wbsdty331 https://github.com/wbsdty331 No?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/winfile/issues/151#issuecomment-395037189,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH_ipnkhC_7VWwjctOEQrsM0_RrwIGuks5t573xgaJpZM4TrrRZ
.

Note that not all language guides have underwent positive changes. Microsoft’s Spanish translations have gone really bad since Windows 8 (more unnecessary terminology calques instead of patrimonial equivalents, abuse of the familiar tú treatment, disregard of native punctuation rules…)

I think we should follow translation style as we did on VSCode. Its inherently better since we have people working over it.

It seems to be settled and maybe not so meaningful now since only some minor bugs left and few would like a totally rebuilding of the all these translations (a waste of time, right?).
I think it may be the time to close this issue.


GEODE-10434: Migrate to Github action

For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@rhoughton-pivot It was found that test order sequence was causing few tests to fail. These are related to how those tests are covering code that is setting static final constants which would not be reset. So I need to fix few tests in order for GH actions pipeline to pass.

I don't know where our concourse-ci is deployed.  it looks like the concourse-ci service is in an unavailable state.

We have to migrate from concourse-ci to Github actions. i am creating another PR that removes these required checks for timebeing.


Create Shield Blocking Handler

For New Contributors
How to contribute
Description

Create a handler that manages shield blocking animation and damage. This handler will handle internal and network events excluding any required Harmony patches
Intended Design

N/A
Location

Create a new branch based from arena-vertical-slice
Related Issues

N/A
Requirements

N/A
Additional information

N/A
Definition of Done

[ ] Class level comments exist for all new classes.
[ ] XUnit tests exist for every method that does not require the game to be ran.

Damage was handled by #520


How i can add function textFieldDidChange to SCLAlertView

The method addTextField() returns the UITextField that was created, from there you can assign textField.delegate with whatever implements the UITextFieldDelegate protocol.


Fix release

Error is happening here: https://github.com/gks-anvil/vrsix/actions/runs/11977457741/job/33395553805

Resolved for now in https://github.com/gks-anvil/vrsix/commit/ed79653016dcf9eace27f98f0a2fb700614d668e

a minor dependency is unable to compile in musllinux
something about windows is breaking -- I think because we're trying to compile thread-free by default with python3.13t and maybe that's not available for windows?


Merge Dev django serializers into main

I fixed the URL part please review it and let me know if there are still any issues.

URL can work correctly.

Please add CORS for http://localhost:3000, so that I can work on React.

I agree with Jullaphong.

Ok, I will open a new request after I add CORS.


Do you have any sort of tutorials on how to run a sklearn model with LEFTIST? [Q]

First of all i would like to thank the developers and researchers on building this framework. I have successfully used the LEFTIST explanation method with a tensorflow model and that is going to be of good use on my research, however when i implement a random tree classifier i am not able to run the model, i always get this error:
IndexError                                Traceback (most recent call last)
 in <cell line: 1>()
----> 1 explanations = leftist.explain(explained_instance,label)
/usr/local/lib/python3.10/dist-packages/TSInterpret/InterpretabilityModels/leftist/leftist.py in explain(self, instance, idx_label, random_state)
117
118         if self.mode == "feat":
--> 119             instance = instance.reshape(instance.shape[-1], instance.shape[-2])
120         else:
121             instance = instance.reshape(instance.shape[-2], instance.shape[-1])
IndexError: tuple index out of range
train_x has shape (150,150) and test_y shape (150), i have changed the shape from (150,150,1) in train x to fit the random forest classifier. I can give more details on my code if need be.

i Have tried to use the SVM model but unfortunately i can't, even when i try to reply this notebook: https://github.com/fzi-forschungszentrum-informatik/TSInterpret/blob/main/docs/Notebooks/Leftist_sklearn.ipynb

Oh i have found it here, i should use a timeseries SVC: https://github.com/fzi-forschungszentrum-informatik/TSInterpret/blob/main/docs/Notebooks/Ates_sklearn.ipynb
I am going to close this issue


why so long time require this two packages?

$ node app.js                                                                                [11:20:06]
require async and await elapsed time =======>54.539ms
Express server listening on port 14082
why so long time require this two packages?

I can't reproduce this and nobody else has commented about the issue. I think it's best to close it since its so old now. Feel free to re-open if you think this needs further investigation.


UniTest for CLI and API

Write UniTest for models/ RESTful API.
Write UniTest for modelhub CLI

Originally posted by @YuanmingLeee in https://github.com/cap-ntu/ML-Model-CI/pull/240#discussion_r592433645
Possible reference:
Save a model weights file in GitHub Action: https://github.com/marketplace/actions/get-file

This might be helpful: https://typer.tiangolo.com/tutorial/testing/


Use double quotes in html_renderer.cr, begin_code

It should use double quotes there instead of apostrophes. Because thats generating bad html code.
For example this is what glitch.com (glitch is an online html editor) says to an markdown crystal code block right now:
https://imgur.com/a/6nUKz
And other sources say too that double quotes are better.

hmm.. weird that CI failed

CI failed because you changed the behaviour so it doesn't match the spec anymore. You need to adjust the expected output in the spec as well.
Otherwise this is good.

hm it still fails. I edited markdown_spec.cr

That isn't a valid string; https://carc.in/#/r/3jt9
You need to escape the quotes or use the %() literal syntax.

ah thx now it works


Add credential refresh for GAR registries in kind

Previously if GAR access was configured for kind clusters using kne deploy, the credential would expire after 1hr. This PR adds refresh before a new topology creation if extra GAR docker creds are found in the kind cluster.

Still need to add the test cases for cluster/kind/kind_test.go
Other than that it should be ready for initial review


Duplicate contributor's profile under presetText

Greetings, I tried to duplicate the profile and paste it under the {PresetText}.

Hi @lefty93! Thank you once again for your time in looking into this issue and I will be reviewing later. Have a great day!

@lefty93 successfully mergered  and this pull request closes out the issue #78


Fix/emr eks team role name

Issue #, if available:
Description of changes:
Update the name of the IAM role for the execution role to ensure uniqueness in an account
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests


Include LICENSE file in wheels

The license requires that all copies of the software include the license.  This makes sure the license is included in the wheels.  See the wheel documentation here for more information.

I'd like to hold off merging this until #48 is finished. (The python packaging on master is currently incomplete; we're not building/distributing wheels or sdists at the moment.)


CLI arg to point at Tauri project dir

Is your feature request related to a problem? Please describe.
I have a main project dir with a [workspace] Cargo.toml, and a sub-directory which is one of the workspace members, and the Tauri project. I'm usually in the main dir, and can cargo build (all members including the Tauri project) from there, but if I want to cargo tauri dev I get:

thread 'main' panicked at 'Couldn't recognize the current folder as a Tauri project.', /.../tauri-cli-1.0.0-beta.7/src/helpers/app_paths.rs:29:

Describe the solution you'd like

Perhaps ideally, tauri-cli could run against any/all workspace members (iff $PWD is a workspace) that are detected as being tauri projects;
a global CLI argument that allows me to specify where the project is if not $PWD

Describe alternatives you've considered
I was using a package.json script (which included a call to tauri dev) which I could run as yarn --cwd=subdir dev. I decided I wanted to use build.rs and tauri.conf.json's beforeDevCommand as the entrypoints instead, but then found I couldn't do the same.
(Aside, I wouldn't suggest copying 'cwd' - perhaps it's meant to be 'change working directory' (though why not cd then 🤔 ) but I can't help but read it as 'current', which then just seems awkward and doesn't really make sense.)
Additional context

probably duplicate of #2752 and discussion at its PR #2765

Blimey that was fast. Indeed yes, pretty much, especially with your comment on its PR, sorry I didn't find that.
In my case though tauri --dir=subdir info would still be able to read package.json as normal, because I don't have an 'unusual structure' - I'm just trying to run tauri from a level up from where is.. 'usual' 😉.
i.e. in bash (cd subdir && tauri build/dev/info) would do what I need, a tauri-cli arg would just be more convenient. (Especially since I don't use bash, and this sent me down a rabbit hole opening a fish issue too 😄.)

would love to hear more of your suggestions over at the PR.


Media queries in css not showing in result using preserveMediaQueries option

Hi, I can't get to make juice.inlineContent(html, css) to put the media queries from css argument in a

If you can reproduce the issue on Tonic( https://runkit.com/npm/juice ), that would be best. If preserveMediaQueries and insertPreservedExtraCss are both true, then the extra CSS should get inserted.

I'm closing as this seems abandoned, but feel free to reopen if you can provide an isolated test case.

I'm aware this is ancient, but I just ran into the same issue. Test case is here: https://runkit.com/embed/kqul95ysqfxj
I worked around this issue by inserting the CSS in the HTML and using plain juice(html).

Just run into the same issue. The way I worked around it:
juice(html, {extraCss: css});

It would be nice if juice.inlineContent(html, css); did the same.


Selectable table quite impractical

I'm drawing a table which has enableSelectAll={true} multiSelectable={true} and it's hard to use it at all besides showing some data. My current issues so far:

users can't select any kind of text from the table since the row gets re-drawn when clicked and, besides the fact that the row gets selected/unselected, the selected text also is lost. Being able to perform basic tasks such as text copy from a table is crucial imho.
i have a button on each row that also activates the select when clicked, tried without luck to prevent that

Please use the search, there have been a number of related discussions/prs recently.


New ENV vars when introducing Kratos to secure the Admin UI

New env variables in the admin containers:

LOG_LEVEL: defaults to info
NODE_ENV: has no default. It is only used as a check to determine whether the logs should be in pretty print for dev environments.
KRATOS_CONTAINER_PULIC_URL: required for frontend package, no default values. This is the public Kratos endpoint in the form for a browser to understand.
KRATOS_BROWSER_PUBLIC_URL: required for frontend package, no default values. This is the public Kratos endpoint in the form for the admin container to understand.
KRATOS_ADMIN_URL: required to run user invitation script etc, no defaults. This is the admin Kratos endpoint in the form for a container to understand, since the admin endpoint should not be exposed.

New env variables in the kratos containers:

PATH_TO_KRATOS_CONFIG: is a Docker build arg to point to the kratos.config file that should be used.
DEV_MODE: used in the entrypoint script for running the kratos container to determine whether startup should be in dev mode or not.

See PR https://github.com/interledger/rafiki/pull/2588

@tadejgolobic SIGNATURE_VERSION (1) and SIGNATURE_SECRET (undefined) have also been added.

We also need to add in AUTH_ENABLED environment variable for Rafiki Admin. It defaults to true.


[sqlparser-0.21] Update planning of LIKE expressions

Which issue does this PR close?

Part of https://github.com/apache/arrow-datafusion/issues/3192
Builds on https://github.com/apache/arrow-datafusion/pull/3193
Rationale for this change

Keeping up with changes in sqlparser
What changes are included in this PR?

Like is now a top-level expression
Ignored a failing test that we cannot fix until we upgrade to a newer version of sqlparser

Are there any user-facing changes?

No

Codecov Report

Merging #3194 (97c486c) into sqlparser-0.21 (929eb6d) will decrease coverage by 0.03%.
The diff coverage is 51.35%.

:exclamation: Current head 97c486c differs from pull request most recent head 5f4d736. Consider uploading reports for the commit 5f4d736 to get more accurate results

@@                Coverage Diff                 @@
##           sqlparser-0.21    #3194      +/-   ##
==================================================
- Coverage           85.87%   85.84%   -0.04%
==================================================
  Files                 291      291
  Lines               52885    52898      +13
==================================================
- Hits                45415    45410       -5
- Misses               7470     7488      +18

Impacted Files
Coverage Δ

datafusion/core/tests/sql/expr.rs
99.84% <ø> (-0.01%)
:arrow_down:

datafusion/sql/src/planner.rs
80.75% <51.35%> (-0.50%)
:arrow_down:

datafusion/core/src/physical_plan/metrics/value.rs
86.93% <0.00%> (-0.51%)
:arrow_down:

datafusion/expr/src/logical_plan/plan.rs
77.60% <0.00%> (-0.18%)
:arrow_down:

datafusion/physical-expr/src/expressions/binary.rs
97.59% <0.00%> (-0.13%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I think this one needs to be rebased

@alamb This is now rebased


performance is very slow and fans are rotating very fastly

/needsPerfInfo

Thanks for creating this issue regarding performance! Please follow this guide to help us diagnose performance issues: https://github.com/microsoft/vscode/wiki/Performance-Issues
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Parser crash with skipSingle and string literals

Issue Kind
Parser Crash
Source Code
if p{""

Description
No response

rdar://104413423


Make speed benchmark support the SM3 hash algorithm.

test results:
[root@openssl]# /opt/openssl/bin/openssl speed sm3
Doing sm3 for 3s on 16 size blocks: 9657786 sm3's in 2.99s
Doing sm3 for 3s on 64 size blocks: 5748529 sm3's in 3.00s
Doing sm3 for 3s on 256 size blocks: 2468054 sm3's in 3.00s
Doing sm3 for 3s on 1024 size blocks: 817668 sm3's in 3.00s
Doing sm3 for 3s on 8192 size blocks: 113456 sm3's in 3.00s
Doing sm3 for 3s on 16384 size blocks: 57138 sm3's in 3.00s
version: 3.1.0-dev
built on: Thu Feb 17 08:15:18 2022 UTC
options: bn(64,64)
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSL_BUILDING_OPENSSL -DNDEBUG
CPUINFO: OPENSSL_ia32cap=0xfffa32034f8bffff:0x1c009c47ab
The 'numbers' are in 1000s of bytes per second processed.
type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes  16384 bytes
sm3              51680.46k   122635.29k   210607.27k   279097.34k   309810.52k   312049.66k
[root@openssl]# /opt/openssl/bin/openssl speed -evp sm3
Doing sm3 for 3s on 16 size blocks: 9624213 sm3's in 3.00s
Doing sm3 for 3s on 64 size blocks: 5728523 sm3's in 3.00s
Doing sm3 for 3s on 256 size blocks: 2451121 sm3's in 3.00s
Doing sm3 for 3s on 1024 size blocks: 815629 sm3's in 3.00s
Doing sm3 for 3s on 8192 size blocks: 112035 sm3's in 3.00s
Doing sm3 for 3s on 16384 size blocks: 56448 sm3's in 3.00s
version: 3.1.0-dev
built on: Thu Feb 17 08:15:18 2022 UTC
options: bn(64,64)
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSL_BUILDING_OPENSSL -DNDEBUG
CPUINFO: OPENSSL_ia32cap=0xfffa32034f8bffff:0x1c009c47ab
The 'numbers' are in 1000s of bytes per second processed.
type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes  16384 bytes
sm3              51329.14k   122208.49k   209162.33k   278401.37k   305930.24k   308281.34k
[root@AnolisOS-163 openssl]# /opt/openssl/bin/openssl speed -multi 2 sm3
Forked child 0
+DT:sm3:3:16
Forked child 1
+DT:sm3:3:16
+R:9561060:sm3:3.000000
+DT:sm3:3:64
+R:9552519:sm3:3.000000
+DT:sm3:3:64
+R:5618988:sm3:3.000000
+DT:sm3:3:256
+R:5595770:sm3:3.000000
+DT:sm3:3:256
+R:2444156:sm3:3.000000
+DT:sm3:3:1024
+R:2436615:sm3:3.000000
+DT:sm3:3:1024
+R:791236:sm3:3.000000
+DT:sm3:3:8192
+R:790780:sm3:3.000000
+DT:sm3:3:8192
+R:111181:sm3:3.000000
+DT:sm3:3:16384
+R:110760:sm3:3.000000
+DT:sm3:3:16384
+R:56391:sm3:3.000000
+R:56201:sm3:3.000000
Got: +H:16:64:256:1024:8192:16384 from 0
Got: +F:29:sm3:50992320.00:119871744.00:208567978.67:270075221.33:303598250.67:307970048.00 from 0
Got: +H:16:64:256:1024:8192:16384 from 1
Got: +F:29:sm3:50946768.00:119376426.67:207924480.00:269919573.33:302448640.00:306932394.67 from 1
version: 3.1.0-dev
built on: Thu Feb 17 08:15:18 2022 UTC
options: bn(64,64)
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSL_BUILDING_OPENSSL -DNDEBUG
CPUINFO: OPENSSL_ia32cap=0xfffa32034f8bffff:0x1c009c47ab
sm3             101939.09k   239248.17k   416492.46k   539994.79k   606046.89k   614902.44k

The sm3 benchmark is available with -evp sm3. I am not sure we want this.

The sm3 benchmark is available with -evp sm3. I am not sure we want this.

Just like other hash algorithm.

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

Do we want this alternative to the -evp option?

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 92 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 123 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 154 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 185 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 216 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 247 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 278 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 309 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 340 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 371 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 402 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 433 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 464 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 495 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 526 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 588 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 619 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 650 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 681 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 712 days ago

Closing this as benchmarking SM3 is supported by -evp sm3


Refer to the AGLDWG Roles vocab

When a role - submitter, creator, reviewer etc. - is mentioned in text/workflow, it should link to the Aust Govt. Linked Data Working Group's Roles vocab that will shortly be published.

Can this be sorted out at today's meeting (23/10/19) @nicholascar


listen $scope.$on('$destroy', ...) to hide keyboard

Unfortunately the input blur listener is removed on state change, so the keyboard does not hide.

The issue is related to ui-router, the $mdKeyboard.hide() service should be used instead.


properly check to ensure that the key exists in the dict

If the key does not exist in the settings dict, do not panic

Thank you for the contribution!
-vlado


Start/End tick label are incorrect for the Bar chart.

Version
5.1.2
Reproduction link
https://codesandbox.io/s/bar-chart-tick-label-eqzh7?file=/src/barChartData.js
Steps to reproduce
Created a time series graph with line and bar visualization. With the line chart, the xAxis tick labels are correct, as in as per the max/min and the data provided. But for the bar chart, the start/end labels are not correct.
In the sandbox link provided, try changing the series.tyle to "line", you'll see the correct time label in the chart.

What is expected?
The min/max axis label should be the same for the bar and the line chart with the same data and options.
What is actually happening?
The min/max labels are not correct when the type is "bar".

5.2.0 has fixed this bug. Please upgrade and check it again.

I tried with 5.2.0 as well. The issue seems to be still present. https://codesandbox.io/s/bar-chart-tick-label-v5-2-0-slsgo?file=/src/barChartData.js:41261-41264

Thanks. It should be a bug.

@plainheart Thanks. In the meantime, is there a way we could handle this via any other property?  any suggestions

Seems it's by design. We add an extra margin for the bar chart on time axis so it won't exceed the axis.
Related issues:
#6728 #4862
Related code:
https://github.com/apache/echarts/blob/master/src/coord/axisHelper.ts#L81

@pissang Yeah. A configurable option would be helpful.
Is there a way around this atm?

@shishiranshuman I'm afraid the only way is change the bar series to line series. Or changing time axis to category axis

@pissang @Ovilia Any updates on this issue? It's a very common use case. There should be some solution.

@pissang @Ovilia Any updates on this issue? It's a very common use case. There should be some solution.

Same issue here - any news?

I believe this issue is still open? Or is the behaviour configurable now, @pissang ?


Life of Pix

Fixes Issue
Closes #509
Changes proposed
Life of Pix provides free premium photos from skilled photographers worldwide with no copyright restrictions. It's perfect for genuine and attractive images.
Screenshots

Note to reviewers
Any kind of feedback would be appreciated.

Thanks Chrissy and Parma!


Reinstate README

Coverage remained the same at 100.0% when pulling c2e42e0c3ff85307c15fbc84dfd9e532859a73cc on readme into 5141b2f2765ba40994c19f38bad92c8318091456 on master.

Coverage remained the same at 100.0% when pulling 3165d292e8bf6dd6b3020ca0983f92001244c710 on readme into 5141b2f2765ba40994c19f38bad92c8318091456 on master.


Allow a broadcastChannel name to be properly set in the adapter

When I implemented this originally, I somehow managed to write a test which didn't test anything I was trying to achieve. No surprise that the feature didn't actually work.
This should remedy the issue.

Thanks Alex!


role_grants: update read to only use grants specific to the tf resource

The current behavior is to query Snowflake for all grants to the specified role when a role grant is read, updated, or deleted. This means the update or delete to applies to all grants to the specified role rather than just the grants that are part of the terraform resource. This causes issues when there are multiple resources handling grants to the same role, as well as when there is a role hierarchy (see issues linked below for more info).
These changes modify the role grant read to look at only the grants that are part of the specified terraform resource. This allows for more flexible use of terraform modules and eliminates issues with role hierarchies.
Test Plan

[x] acceptance tests
[x] unit tests

References
189
512

/ok-to-test sha=1a58fef

@cstkpk could you look at the errors and update your branch 😄


Is AzCopy info false

This article recommends Robocopy over AzCopy here https://learn.microsoft.com/en-us/azure/storage/files/storage-files-migration-robocopy#azcopy-vs-robocopy
Is that really the case? I find it hard to believe as in lots of other Microsoft Docs it only ever mentions AzCopy as the preferred method of transferring files to Azure.
Has this decision been reviewed against the current capabilities of AzCopy?
This article specifically mentions the limit of the AzCopy Sync command to Robocopy MIR command but that is incorrect. AzCopy has delete options now on the sync command and also the copy command
https://learn.microsoft.com/en-us/azure/storage/common/storage-ref-azcopy-sync
https://learn.microsoft.com/en-us/azure/storage/common/storage-ref-azcopy-copy

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 92efe892-298d-6e89-d2ee-f9cc8eb0aea4
Version Independent ID: 45081147-a2f8-2b3e-b633-c8558d138be0
Content: Migrate to Azure file shares using RoboCopy
Content Source: articles/storage/files/storage-files-migration-robocopy.md
Service: storage
Sub-service: files
GitHub Login: @khdownie
Microsoft Alias: kendownie

@thommck
Thanks for your feedback! We will investigate and update as appropriate.

@thommck thanks for the submission. I will review this with the product team after the new year and make the needed changes.

@khdownie
Thank you for your support.
@thommck
if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@thommck
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Enable Fluent-Bit 1.9.4

Feature Request
The fluent-bit 1.7.5 that is currently provided by the TCE is competitively lot older as the current head of the branch release is 1.9.4.
Describe alternatives you've considered
Using older 1.7.5 But it lacks some of the new behaviors/abilities that are useful otherwise.
Additional context
NA

/assign

closed by https://github.com/vmware-tanzu/community-edition/pull/4967


docs: add docs for serialization of DocList

Goals:

add docs for serialization of DocList
[x] check and update documentation, if required. See guide

weird that the CI is not triggered. Any idea why @nan-wang ? If you originally open the PR against the main branch and change it later to feat-rewrite-v2 then maybe you need to create a new PR it happened to me a couple of time that it messed up the CI


Once one pre-install,pre-update hook passes Helm do not wait for the other hooks statuses

Output of helm version: version.BuildInfo{Version:"v3.8.1", GitCommit:"5cb9af4b1b271d11d7a97a71df3ac337dd94ad37", GitTreeState:"clean", GoVersion:"go1.17.5"}
Output of kubectl version: Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.5", GitCommit:"5c99e2ac2ff9a3c549d9ca665e7bc05a3e18f07e", GitTreeState:"clean", BuildDate:"2021-12-16T08:38:33Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.5-eks-bc4871b", GitCommit:"5236faf39f1b7a7dabea8df12726f25608131aa9", GitTreeState:"clean", BuildDate:"2021-10-29T23:32:16Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): EKS
I configured the following objects with hooks(see below). one secret creation and one job creation, Helm creates the secret and the job, then it creates the new release without waiting for the job to succeed. In case of job failure, the release still gets deployed!
Someone already notice this in the past and a PR passed(raised here: https://github.com/helm/helm/issues/6874 and solved here: https://github.com/helm/helm/pull/6907) but as I see it, it did not get resolved. Maybe I misunderstood something.
apiVersion: v1
kind: Secret
metadata:
  namespace: {{ .Values.environment }}
  name: pre-job-secret
  annotations:
    "helm.sh/hook": "pre-install,pre-upgrade"
    "helm.sh/hook-weight": "0"
data:
  POSTGRES_ADDR: {{ .Values.secret.postgresAddress | b64enc }}
  POSTGRES_DB: {{ .Values.secret.postgresDB | b64enc }}
  POSTGRES_PASSWORD: {{ .Values.secret.postgresPassword | b64enc }}
  POSTGRES_USER: {{ .Values.secret.postgresUser | b64enc }}

---

apiVersion: batch/v1
kind: Job
metadata:
  namespace: {{ .Values.environment }}
  name: {{ .Chart.Name }}-db-migration-job
  labels:
    {{- include "backend.labels" . | nindent 4 }}
spec:
  backoffLimit: 2
  completions: 1
  parallelism: 1
  template:
    metadata:
      namespace: {{ .Values.environment }}
      labels:
        role: hook
      annotations:
        # This is what defines this resource as a hook. Without this line, the
        # job is considered part of the release.
        "helm.sh/hook": pre-install,pre-upgrade
        "helm.sh/hook-weight": "1"
        "helm.sh/hook-delete-policy": before-hook-creation

    spec:
      restartPolicy: "Never"
      containers:
        - name: {{ .Chart.Name }}-container
          {{- with .Values.migrateJob }}
          image: {{ .image.repository }}:{{ .image.tag | default $.Chart.Version }}
          imagePullPolicy: {{ .image.pullPolicy }}
          {{- if eq $.Values.debug true }}
          command: ["sleep"]
          args: ["10"]
          {{- else }}
          command:
{{ toYaml .command | indent 12 }}
          {{- end }}
          env:
          - name: PGSSLMODE
            value: disable
          - name: POSTGRES_ADDR
            valueFrom:
              secretKeyRef:
                name: pre-job-secret
                key: POSTGRES_ADDR
          - name: POSTGRES_DB
            valueFrom:
              secretKeyRef:
                name: pre-job-secret
                key: POSTGRES_DB
          - name: POSTGRES_PASSWORD
            valueFrom:
              secretKeyRef:
                name: pre-job-secret
                key: POSTGRES_PASSWORD
          - name: POSTGRES_USER
            valueFrom:
              secretKeyRef:
                name: pre-job-secret
                key: POSTGRES_USER
          resources: {}
      {{- with .nodeSelector }}
      nodeSelector:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      {{- with .affinity }}
      affinity:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      {{- with .tolerations }}
      tolerations:
        {{- toYaml . | nindent 8 }}
      {{- end }}

# end of with .Values.deployment
          {{- end }}

https://helm.sh/docs/topics/charts_hooks/#hook-resources-are-not-managed-with-corresponding-releases
Hooks are not tracked or managed as part of the release. Once Helm verifies that the hook has reached its "ready" state, it will stop tracking the hook's state. That is to say, it does not care whether the job reaches the "success" or "failed" state; it only cares that the job was started.

@bacongobbler two things:

If you only run a job as a hook the release does wait for the job to succeed and if the job fails the release is canceled with
How do you define ready, a job has the states: Failed and Complete. The pods behind it have the states: Pending, Running, Succeeded, Failed, and Unknown. What do you count as "ready"?

I would suggest reading the code to determine the answers yourself... I did not write Helm's wait logic.
https://github.com/helm/helm/blob/main/pkg/kube/wait.go

@bacongobbler two things:

If you only run a job as a hook the release does wait for the job to succeed and if the job fails the release is canceled with: "Error: UPGRADE FAILED: pre-upgrade hooks failed: job failed: BackoffLimitExceeded"
How do you define ready, a job has the states: Failed and Complete. The pods behind it have the states: Pending, Running, Succeeded, Failed, and Unknown. What do you count as "ready"?

I have not been able to make it blocking even with a Job, even if the job fails the main pod/deployment goes through. How did you make the job blocking as a pre-upgrade hook?


fix pattern matching for .gitignore parity

Not reallllly a bug but src should be valid to leave out the entire dir etc. re: #226
Maybe only dirs is what they read specially, I haven't actually read the gitignore docs haha.

I made some research and fnmatch has been replaced with custom function (wildmatch) in 1.8.4 https://github.com/git/git/blob/master/Documentation/RelNotes/1.8.4.txt
wildmatch source https://github.com/git/git/blob/8d530c4d64ffcc853889f7b385f554d53db375ed/wildmatch.c YAY

found JS version https://github.com/vmeurisse/wildmatch/blob/master/src/wildmatch.js

hahaha lovely, maybe it's not worth it, I suppose having a nicer way to preview what is in the function would help a bit

or https://github.com/rliebling/gitignorer

yeah, much better. I don't think that using this C func in Go should be a problem though.


Intellij IDEA IU plugin size is too big

Description
Intellij IDEA IU is required to support UTBot JS. However, .jar distributable is 190 MB, which seems too much for a plugin.
Expected behavior
Make distributable size less to make it more accessible for users.

Connected with

#1333


Stall-vs-Swap approach to atomic updates of large register banks, with fields wider than CPU bus

We are looking for a way to ensure atomic writes to registers wider than 32 bits (which is our CPU access bus).
Some control structures (such as crypto key routing table) must be updated as a whole (as partial update could cause unexpected behavior in the DataPlane Engine - DPE).
SystemRDL supports the write-buffered registers. They however seem inefficient for FPGA resources.
Here is an example that specifies a table of 16 records, each 224 bits in size, for the total of 3584 flops. that is control bits from the DPE viewpoint. However, the SystemRDL-generated RTL output expends almost 3x that number of flops!

one layer of flops stores the actual / live values that go out to the DPE.
the second layer stores the values as they arrive from the CPU / shadow.
the third part includes a bunch of bit-enable flops. Granted, these per-bit enables can be rationalized, and even completely eliminated when full 32 writes (w/o even the byte enables) are acceptable.

For maximum resource utilization, we are most seriously considering the option of stalling the DPE while CPU is updating its control registers. That would ensure access atomicity using ordinary, i.e. the least expensive SystemRDL reg types. Granted, this flop gain would be paid in BRAM loss, as the depth of RxFIFOs would now need to be enlarged to absorb the slack while the DPE processing is held off.
As an alternative, we are also assessing the cost of register bank swap method. This is similar to the Z80 register swaps. The first thought is to have SystemRDL create two full sets of ordinary registers: A and B. Then implement a mux in our RTL, outside of SystemRDL, so that A<->B swap can be instantly executed on CPU command.
Ideally, the SystemRDL would introduce the Swap register type, so that the user can define only one set, and flow under the hood creates the other set, along with a mux and register for selection of the bank.

I have updated README.md to include a description of the atomic CSR update mechanism. Here I will also present a draft of latency calculations and buffer sizing.

If we assume that the DPE just started processing a 1500B frame, PAUSE setup latency at the multiplexer can be expressed as:

T_PS = T_CLK + (1500/16)T_CLK = 95T_CLK

Furthermore, PAUSE to READY latency can be expressed as:

T_PR = T_PS + T_DC + T_CLK
where T_DC is a data path clearing latency.

For the cut-through pipeline:

T_DC1 (Header Parser) = 4*T_CLK
T_DC2 (WireGuard Assembler/Disassembler) = 4*T_CLK
T_DC3 (WireGuard Encryptor/Decryptor) = 4*T_CLK
T_DC4 (IP Lookup Engine) = 2*T_CLK
T_DC = T_DC1 + T_DC2 + T_DC3 + T_DC4 = 14*T_CLK

For the store-and-forward DPE (word-case scenario):

T_DC1 (Header Parser) = (1500/16)T_CLK = 95T_CLK
T_DC2 (WireGuard Assembler/Disassembler) = (1500/16)T_CLK = 95T_CLK
T_DC3 (WireGuard Encryptor/Decryptor) = (1500/16)T_CLK = 95T_CLK
T_DC4 (IP Lookup Engine) = (1500/16)T_CLK = 95T_CLK
T_DC = T_DC1 + T_DC2 + T_DC3 + T_DC4 = 380*T_CLK

Hence, PAUSE to READY latency can be calculated as follows:

T_PR = 95T_CLK + 14T_CLK + T_CLK = 110T_CLK (or 476T_CLK for S&F DPE)

Update latency per byte of written CSR data if a 32-bit bus is used:

T_CSR = (1/4) * T_CLK

Given that the Routing Table contains 16 entries of 300 bytes each, the update latency can be calculated as follows:

T_UPDATE = 16300T_CSR = 1200*T_CLK

Finally, the total CSR update latency can be calculated as follows:

T = T_PR + T_UPDATE = 1310*T_CLK = approx. 16us (or 21us for S&F DPE)

Since no packets are received in the DPE during the FCR handshake procedure, from the establishment of the pause until the completion of the CSR update, it is necessary to size the input FIFOs to at least:

C_FIFO = T * R = 16us * 1Gbps = approx. 2000 bytes (or 2625 bytes for S&F DPE)

Given that there are four Rx FIFOs connected to 1GbE interfaces, the total required capacity is equal to:

C_TOTAL = 4*C_FIFO = 8000 bytes (or 10500 bytes for S&F DPE)

As the CSR update latency has the biggest contribution to the total latency, we can conclude that the additional consumption of BRAM (needed for Rx FIFOs) is approximately equal to 2 bytes of memory for each byte of written CSR data.
If we want to support Jumbo frames, then each Rx FIFO must be at least 9000 bytes in size, which gives us a huge margin for CSR update latency (4-5 times more than needed).
Considering the large number of variables that will depend on the implementation details, I will make a spreadsheet for easier calculation of expected latency and necessary buffer sizes.

Number of VPN peers is an important element in the above calculations. It affects both:

T_DC4 (IP Lookup Engine)
T_UPDATE (CSR Walk-Through by the CPU)

The 16 that our first POC prototype will be built for is far below the number that a real-life apps need.
While a spreadsheet is a great idea that will facilitate design space exploration, could we, for the sake of an argument, also specify a ball park number of peers that the commercial products of this kind typically have, or need?!

Commercial-grade devices in this range (1Gbps) support up to 20-25 peers:

https://community.tp-link.com/en/business/forum/topic/651908
https://help.firewalla.com/hc/en-us/articles/1500004087521-WireGuard-VPN-Server-Configuration

As far as I have observed the experiences of users, the needs are mostly up to 100 peers, so commercial vendors are working to support that.


How to push another data

Hi,
could u say how to push message title, body, image and ect from php?

I am wondering about that too

Payload can be any string so you can send JSON and handle it client-side


update identity-apps version

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5852779773

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5853668690
Status: failure

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5852779773
Status: cancelled


Update rotmg interface to handle issue in OpenCL CPU support

To offer proper oneMKL support rotmg operator must support the possibility to have y1 argument passed as scalar value.
This PR enables this possibility by adding a check on its type and handling both cases: pointer/buffer or scalar.
Moreover, due to a bug in OpenCL the copy for DEFAULT target, that it generally used on CPUs, must be explicitly synchronized if using USM.

I think that src/interface/blas1/rotmg.cpp.in needs to be updated in order to consider the new rotmg interface. Probably, the unit test could be updated as well.

@pgorlani I added the new interface and modify the tests in 39016ea


can't load checked state from server

Hi, thank you so much for creating this component. I am now having an issue for passing the data from server to the liquor tree now,

I can load the node now, but I can't load the checked state, the response.data is :

Thank you so much for any help here!

Hi! Can you show me an example on https://codesandbox.io?


Design account settings page taking in consideration the google connect

How to show different accounts like twitter, mailchimp, google, google drive y dropbox with their options


stargzify: Pushing blobs fail with DIGEST_INVALID occasionally because of race

Sometimes, stargzifying an image fails with DIGEST_INVALID.
$ ./stargzify -upgrade <IP_ADDRESS>:5000/ubuntu:18.04
2019/10/13 14:37:24 No matching credentials were found, falling back on anonymous
2019/10/13 14:37:49 DIGEST_INVALID: provided digest did not match uploaded content; map[Digest:sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 Reason:map[]]

Especially when Writeing to the digester is slow, we can see this failure more frequently.
func (d *digester) Write(b []byte) (int, error) {
	time.Sleep(time.Duration(1) * time.Millisecond)
	n, err := d.h.Write(b)
	d.n += int64(n)
	return n, err
}

There is a race condition on the digester
The method layer.Compressed() calculates the digest(with Sum() method) immediately after the PipeWriter is unblocked.
func (l *layer) Compressed() (io.ReadCloser, error) {
	pr, pw := io.Pipe()

	// Convert input blob to stargz while computing diffid, digest, and size.
	go func() {
		w := stargz.NewWriter(pw)
		if err := w.AppendTar(l.rc); err != nil {
...
		if err := w.Close(); err != nil {
...
		l.digest = &v1.Hash{
			Algorithm: "sha256",
			Hex:       hex.EncodeToString(l.d.h.Sum(nil)),
		}
...
	}()

	return ioutil.NopCloser(io.TeeReader(pr, l.d)), nil

But even if the PipeWriter is unblocked, it isn't guaranteed that the TeeReader completes to write the data to the digester.
Accroding to the implementation of the TeeReader:
func (t *teeReader) Read(p []byte) (n int, err error) {
	n, err = t.r.Read(p)

        // ***** Region A *****

	if n > 0 {
		if n, err := t.w.Write(p[:n]); err != nil {
			return n, err
		}
	}
	return
}

Here, this TeeReader has the PipeReader as a reader and the digester as a writer.
In the Region A of the above, the write half(PipeWriter) is unblocked because reading from this PipeReader completes.
So the goroutine in the layer.Compressed() can immediately calculate the digest during the region A(before following t.w.Write() completes).
This race results in calculating an invalid(uncompleted) degest.

Fixed in #25. Thank you very much for merging.


Enable playing in vlc on other operating systems

This should do it.
@CrazyLemon ?

Works for me (Ubuntu 14.04) :+1:
P.s. Are you planing on any peer settings (limit # of peers) ? Or should i open another issue and ask the question there.

I was not planning on limiting the number of connections, but if you open an issue, we can talk about it.
After a quick look, we'd have to change the torrent library as the limiting property is private: https://github.com/anacrolix/torrent/blob/master/client.go#L448
The default is 80, which is a very sane, conservative value that should work everywhere.


Add support for ligation of partially overlapping overhangs

Right now only ligation of overhangs with total overlap is supported (we just checked whether the overlaps are equal). Partial overlaps should work too. There should be a parameter to set the tolerance or something like this when making a request from the frontend.
Total overlap:
AAA***     GGGAAAA
AAACCC     ***AAAA

Partial overlap:
AAA***     GGAAAA
AAACCC     **AAAA

The key here is to:

[ ] Add an extra argument to the function sum_is_sticky in dna_functions.py true\false to allow for partial overlaps.
[ ] Change sum_is_sticky so that if that argument is true, it tests for partial overlaps
[ ] Add the argument to all functions that use sum_is_sticky
[ ] Add a parameter to the ligation api endpoint true/false to set that.

To fully integrate this, there are two additional things to solve:

Allow assembly of partially sticky ends (pydna does not allow this yet.
Modify the frontend according to the desired use case.

Is the user supposed to decide whether partially overlapping sticky ends are allowed? In that case, what is the preferred way to ask the user? I can think of two options:

Add new input type True/False in the form
Add a different source option "Ligation with partially sticky ends"

Hi @dgruano sorry for the late reply.
I have created an issue for this in pydna: https://github.com/BjornFJohansson/pydna/issues/158
For the frontend, I think probably what's best is to have it in the same type of source, and have a checkbox "Allow partial ligation".
Also, you can make a PR with the function you showed me the other day even if the full thing is not implemented


test: add has been called check

Couple of minor fixes

Codecov Report

Merging #761 (a07a591) into main (2ad600c) will increase coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   86.86%   87.77%   +0.90%
==========================================
  Files         393      432      +39
  Lines        9226    12071    +2845
  Branches     1624     2257     +633
==========================================
+ Hits         8014    10595    +2581
- Misses       1153     1405     +252
- Partials       59       71      +12

Impacted Files
Coverage Δ

...dules/credentials/CredentialResponseCoordinator.ts
100.00% <ø> (+20.00%)
:arrow_up:

packages/core/src/modules/dids/DidsModule.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

.../connections/handlers/ConnectionResponseHandler.ts
86.84% <0.00%> (-13.16%)
:arrow_down:

.../core/src/modules/dids/repository/DidRepository.ts
88.88% <0.00%> (-11.12%)
:arrow_down:

.../modules/dids/domain/service/DidDocumentService.ts
89.47% <0.00%> (-10.53%)
:arrow_down:

...odules/discover-features/DiscoverFeaturesModule.ts
57.89% <0.00%> (-5.94%)
:arrow_down:

...e/src/modules/dids/methods/peer/peerDidNumAlgo0.ts
83.33% <0.00%> (-5.56%)
:arrow_down:

packages/core/src/agent/AgentMessage.ts
85.71% <0.00%> (-4.29%)
:arrow_down:

...core/src/modules/routing/messages/StatusMessage.ts
90.47% <0.00%> (-2.63%)
:arrow_down:

...re/src/modules/dids/services/DidResolverService.ts
97.56% <0.00%> (-2.44%)
:arrow_down:

... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad600c...a07a591. Read the comment docs.


stop importing cats.Functor in gen lens macros

fix #792

Nice, I haven't thought about this issue at all. Do you want us to make a bug release?

Yes please, I'm kinda blocked by this. Thank you!

We are having some issues regarding binary compatibility (see https://github.com/julien-truffaut/Monocle/pull/795)
Once we fix it, we will cut 2.0.1. I will let you know when it is ready.


to-sql cuts last character of operand if it contains a trailing or a leading + trailing  '*'

Hi,
thx for this nice library. I found a small bug when it comes to parsing the operands with wildcards (src/llb/to-sql.ts, line 137 - 143) which affects:

leading and the trailing: *foo*
the trailing: foo*

Replacing operand.length - 2 with operand.length - 1 would solve this issue.
The small program shows this:
/**
 *
 * @param operand
 */
function testmewrong(operand: string) {
  const leadingWildcard = operand.startsWith('*');
  const trailingWildcard = operand.endsWith('*');

  if (leadingWildcard && trailingWildcard) {
    console.log(`Both: %${operand.substring(1, operand.length - 2)}%`); // not correct
  } else if (leadingWildcard) {
    console.log(`Leading: %${operand.substring(1)}`);
  } else if (trailingWildcard) {
    console.log(`Trailing: ${operand.substring(0, operand.length - 2)}%`); // not correct
  }
}

testmewrong('*foo*');
testmewrong('*foo');
testmewrong('foo*');

// WRONG:
// Both: %fo%
// Leading: %foo
// Trailing: fo%

/**
 *
 * @param operand
 */
function testmecorrect(operand: string) {
  const leadingWildcard = operand.startsWith('*');
  const trailingWildcard = operand.endsWith('*');

  if (leadingWildcard && trailingWildcard) {
    console.log(`Both: %${operand.substring(1, operand.length - 1)}%`); // correct
  } else if (leadingWildcard) {
    console.log(`Leading: %${operand.substring(1)}`);
  } else if (trailingWildcard) {
    console.log(`Trailing: ${operand.substring(0, operand.length - 1)}%`); // correct
  }
}

testmecorrect('*foo*');
testmecorrect('*foo');
testmecorrect('foo*');

// CORRECT:
// Both: %foo%
// Leading: %foo
// Trailing: foo%

I have prepared a local bugfix branch (with fix and extended unit tests), but I cannot push it due to repo write access restrictions.
BTW, I am little bit confused, the repo shows v1.1.2 in package.json but v1.1.3 is published. Is this normal?

Thanks, I'll take a look at the bug.
I don't recall what state I left this in with respect to publishing releases. It's likely that I was trying to script the publish and it failed and I had to do it manually. I'll add this to the things to fix. I'll have time to look at this later tonight.