CPU usage slowly increases over time

I had previously used Application Insights, but no longer do, however the App Insights code remained in my app. I noticed when I recently migrated hosts and upgraded to .NET Core 2.1.0-rc1 that the CPU usage gradually increased over the course of a few days.

The drops back to 0 are Docker container restarts.
Removing Application Insights from the site results in a steady almost-zero CPU usage.
See also this Twitter thread, though there's not much more there.
Repro Steps

Add Application Insights (2.3.0-beta2) to an ASP.NET Core MVC app via NuGet and Startup.cs
app.AddApplicationInsightsTelemetry("{no-longer-valid instrumentation key}")
Setup some sort of synthetic monitoring to hit the site every minute
Wait a couple days ¯_(ツ)_/¯

Actual Behavior

CPU slowly creeps up over the course of a few days

Expected Behavior

CPU remains stable

Version Info
SDK Version : 2.1.0-rc1
.NET Version : 2.1.0-rc1
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) :
OS : Ubuntu 16.04
Hosting Info (IIS/Azure WebApps/ etc) : Azure VM

Thanks for reporting.  We'll try to setup a repro and investigate more.
What was the version of application insights SDK which you used?

2.3.0-beta2, running on an ASP.NET Core 2.1-rc1 app.
On Wed, May 23, 2018, 3:08 PM Cijo Thomas<EMAIL_ADDRESS>wrote:

Thanks for reporting. We'll try to setup a repro and investigate more.
What was the version of application insights SDK which you used?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/690#issuecomment-391462805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAL9OE-fJkMOt_09ld_JL3Tl9Vhj0MMoks5t1bPEgaJpZM4UFhGL
.

Left an app in .net 2.0 running for last 3 days. Dont see any increase in mem/cpu

Similar for app in .net 2.1 for last 3 days.

I'll setup something for linux now.

We got same issue on Ubuntu 16.04

After upgrade AspNetCore 2.1.0-rc1
Never got CPU issue with AspNetCore 2.0.x before
Not sure this caused by new AspNetCore 2.1.0-rc1 or new ApplicationInsights 2.3.0-beta2
Internally, we got few HttpClient failed a day, might related to https://github.com/dotnet/corefx/issues/29285

Before Upgrade:
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.2.1" />
<PackageReference Include="Microsoft.AspNetCore.ApplicationInsights.HostingStartup" Version="2.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.0.3" />

After:
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.3.0-beta2" />
<PackageReference Include="Microsoft.AspNetCore.ApplicationInsights.HostingStartup" Version="2.1.0-rc1-final" />
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.1.0-rc1-final" />

Thanks for reporting this. We will setup a linux test to do deeper investigation soon.

Have an asp.net core 2.1 app with AI SDK 2.3, running in ubuntu 16_04. A script is pinging the app once every 10 sec.
WIll let this run for few hours/day and check again.

6hours, no visible change in CPU load. CPU is constant around .39%
Load is 6Request/Sec
Will leave this overnight.

When we stop pinging, the CPU usage is no more keep constantly increase.

Same thing happening on Windows as well (Azure App service)
Not only CPU but also Garbage collector affected.
I upgrade my .Net core 2.0 site to .Net core 2.1 on Jun 3 afternoon. And yesterday I have removed AI Insight extension from my app service (Nuget package reference still in my project.)
You can see changes in attached images.

repro-ed on linux vm. Need to investigate more.

@stevedesmond-ca @mehmetilker @thohng I've seen a similar thing since upgrading to .NET Core 2.1 and not only does our CPU usage increase over time, but our open handles increase dramatically since the upgrade:

Could you take a look at your handle count and confirm if you have the same issue or not?

I'm recently having issues with increased memory usage. I checked it with dotMemory and I've seen many System.Net.Http related objects - e.g. open handlers that haven't been closed etc.
I'm not yet sure if it's Application Insights though (I will do some more tests next week) - but if it is, maybe this clue helps finding the issue.

I also have increasing CPU which seems to be from HTTP. It was not noticeable until I went to production which looked great after deployment, but a few hours later everything was redlined due to ever-increasing CPU demand as shown below. Unfortunately, this is a show stopper and is forcing me to rollback.
Runtime: core 2.1 Linux x64
Containers: YES Docker
OS: UBUNTU & CENTOS

We've downgraded Application Insights back to v2.2.1 and don't see the increasing CPU and memory usage anymore, so I can confirm that this is an issue with Application Insights.
@cijothomas Any chance this can be looked into? This basically makes version 2.3.0 not usable for production scenarios

@flagbug Thanks for helping narrow down to 2.3.0.  We will prioritize this investigation.

Related, maybe the cause as well: https://github.com/Microsoft/ApplicationInsights-dotnet/issues/594

Might want to see if HttpClientFactory solves the issue.  Static HttpClient is not without its issues. https://blogs.msdn.microsoft.com/webdev/2018/02/28/asp-net-core-2-1-preview1-introducing-httpclient-factory/

I now also ran our application without App Insights for a few days and I don't see any stale Http-related objects in memory so I'm also "blaming" Application Insights for now.
Could you please prioritize this? This has been open for more than a month and a profiler that leaks memory is a "really bad thing" ™...
/cc @SergeyKanzhelev @lmolkova (fyi, in case you didn't know about this yet)

@cwe1ss Were you facing issues in linux or windows or both?

My setup: Windows Server 2016 on Azure (Standard_D11_v2, 2 cores 16GB RAM); Single-node Service Fabric cluster (development system); I'm running ~ 60 .NET Core apps (~ 30 ASP.NET Core apps, 30 console apps); services are communicating via the Service Fabric HTTP reverse proxy. As it's a dev system, there's very little load on the system.
Here's some more details:
I see a similar pattern in overall CPU usage like the other reporters:

I took a process dump of one ASP.NET core Web API project. The process has been running for "2 days 20:49:36". dotMemory gives me the following overview. As you can see, the string value "dc.services.visualstudio.com" exists 23218 times.

Looking at the type list shows that "System.Net.Http"-related objects make up the top of the list.

I do not see a similar pattern in an app where I've disabled Application Insights.

@cwe1ss what are the back traces/call tree like on some of these objects?
11,613 object count ones are interesting; especially since it looks like there are 11,613 sets of HttpConnectionPoolManagers and 11,613 x List<HttpConnectionPool+CachedConnection>. That's not the number of cached connections; but the number of caches for connections.
HttpClientHandler probably would have the most informative backtraces? (as I assume all the others are allocated in it)

@benaadams can I get this from the process dump via dotMemory / WinDbg or do I need to trace this with PerfView / dotTrace ?

oh... I've seen the tabs in dotMemory... but they are empty and just say "No allocation info was collected during profiling". So I guess I need PerfView / dotTrace, right?!

I clicked around a bit more in dotMemory (I don't know much about it, sorry) and I've seen that you can get more details about the object instances. Here's some screenshots for a random instance of System.Collections.Concurrent.ConcurrentDictionary+Tables<System.Net.Http.HttpConnectionPoolManager+HttpConnectionKey, System.Net.Http.HttpConnectionPool>.

Hope this helps?!

I'm guessing the CPU increase is from the constantly increasing number of Timers which you memory dump seems to indicate. Timers also act as GC roots, which is why everything is probably hanging around, if their callbacks are capturing state.
Not sure why though...

Could this be an issue with how HeartbeatProvider uses Timer? See e.g. https://www.codeproject.com/Answers/185740/Threading-Timer-prevents-GC-collection#answer1 where the guy from "Solution 1" says:

The method must be static...
Conversely, if you use a non static method and you reference it using this.NameMethod, the System.Threading.TimerCallback will keep a reference to each MyTimerData object. So, despite your mtd=null instruction, it won't be free until the closing of the applicaton.
Your example is a circular reference:
mtd => m_timer => new System.Threading.TimerCallback(...) => mtd.TimerCall(o){}

@benaadams thank you very much for looking into this!!!

Could this be an issue with how HeartbeatProvider uses Timer?

Looks like its only created once though? Doesn't explain why there are 11,628 Timers in your memory capture.

True. 😕 Well, I'll leave it to the Application Insights guys then. Or do you think this could be something that's wrong in my application?
Thanks again, Ben. I always learn something new when you're involved! 😉 👍 🍺

My best guest on the second set of screenshots you provided is from Task.Delay with a CancellationTokenSource; but that might just be a low instance. (i.e. Task.Delay(cts.Token) tasks being created faster than they are completed)
Could you give from Types tab the lower pane, and open the call chain when you have Timer selected in the top panel?
e.g.

That should hopefully highlight the call chain that is allocating them

I currently only have a process dump (created from Task Manager) and I only get "No allocation info was collected during profiling" on the "Call Tree" tabs etc.
Do you know of a way to profile .NET Core apps on a Service Fabric cluster? Seems like Remote Attach doesn't yet work with .NET Core and I don't know of any way to start the profiling when Service Fabric is responsible for starting the program.

Do you know of a way to profile .NET Core apps on a Service Fabric cluster?

No, attach to running process doesn't work with DotTrace for a local process either.
However you could probably create a simple local app, add appInsights and profile that for similar effect?

No, attach to running process doesn't work with DotTrace for a local process either.

Too bad. I don't want to spend too much time on this so I'll wait for a response from the Application Insights team first.

@cijothomas @SergeyKanzhelev another ping. Could you please bring this to the attention of someone?
I'm sorry to be annoying but Application Insights is a paid service and a potential memory leak is a very bad thing for an APM product, so some update would be appropriate IMO. It's now more than 6 weeks since this issue has been created and I feel like no one has properly looked into this yet.

Though I haven't understood things fully yet, here's my findings from today's experiments.

Ran Asp.Net Core 2.1 App with AI SDK 2.2.  Their count kept increasing with time. (Similar to @cwe1ss 's snapshots.)

Ran Asp.Net Core 2.1 App with AI SDK 2.3. Same as # 1

Ran Asp.Net Core 2.0 App with AI SDK 2.2. Don't see any HttpConnectionPoolManager in memory.

Ran Asp.Net Core 2.0 App with AI SDK 2.3. Don't see any HttpConnectionPoolManager in memory.

Though the issue of one-HttpClient-per-transmission existed for long time in AI SDK Channel (https://github.com/Microsoft/ApplicationInsights-dotnet/issues/594), the issue exasperated with Asp.Net Core 2.1.
I validated this with a test app new-ing up HttpClient everytime it makes outbound call. It shows steady increase in HttpConnectionPoolManager counts in memory.
I'll make a fix to this issue: https://github.com/Microsoft/ApplicationInsights-dotnet/issues/594, and publish a beta SDK soon for others also to validate.
In my quick experiment with fixed SDK, the count of HttpConnectionPoolManager etc, is not increasing. (stays at 2 or 3 as expected).

Some folks mentioned that the issue occurs with AI SDK 2.3 but not with 2.2.1 is puzzling as there was no major change made to channel/transmission between these two versions. So there could be something else as well.
But I'll tackle the known issue(Microsoft/ApplicationInsights-dotnet#594)) first anyways.

@cijothomas thank you for looking into it! Let me know if there's anything else you'd like to see from my process dump!

fyi: With .NET Core 2.1, the default for HttpClient changed to the new SocketsHttpHandler (https://blogs.msdn.microsoft.com/dotnet/2018/02/27/announcing-net-core-2-1-preview-1/). So if this issue happens due to the upgrade of .NET Core instead of the upgrade of the Application Insights SDK, maybe that's something to look at?!

I think we're seeing this issue with Microsoft.ApplicationInsights.AspNetCore v 2.2.1 on .NET Framework 4.7 (460805). CPU increases over time. Increase seems to be linked to the rate of HTTP requests being serviced by our app. Performance profiling shows that CPU is being spent waiting for the lock in TimerQueue.FireNextTimers, presumably because timers are being leaked.

We were seeing this on version 2.3.0 when we updated to .Net Core 2.1. Yesterday, I downgraded back to version 2.2.1 on .Net Core 2.1 after reading this issues thread. However, we are still seeing this exact same issue. So I don't think it is directly related to version 2.3.0.

Thanks all for the help so far- as I mentioned, this is not because of AI SDK 2.2.1 to 2.3 upgrade - AI SDK had incorrectly used HttpClient for a long time, but now with some underlying change in .net core 2.1, this is causing the leak.
The leaked HttoConnectionPool things are all rooted to some Timer object (can't recollect exactly).
I'll provide a fix today.

The issue is fixed after upgrade to new version<EMAIL_ADDRESS><PackageReference Include="Microsoft.ApplicationInsights" Version="2.7.0-beta3" />
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.4.0-beta2" />
<PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.2" />
<PackageReference Include="Microsoft.AspNetCore.ApplicationInsights.HostingStartup" Version="2.1.1" />

Thank you!

@thohng Thanks for helping validate the fix in 2.7.0-beta3.
I am releasing Asp.net core sdk 2.4.0-beta3 today (which refers 2.7.0-beta3 of the base sdk containing the fix)

https://www.nuget.org/packages/Microsoft.ApplicationInsights.AspNetCore/2.4.0-beta3 - Please try this version and let us know if you still see issues.

Thanks @cijothomas , the<EMAIL_ADDRESS>is good
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.4.0-beta3" />
<PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.2" />
<PackageReference Include="Microsoft.AspNetCore.ApplicationInsights.HostingStartup" Version="2.1.1" />

Compare with the graph before

I have updated few of my aspnet core services to netcore21 and latest AppInsights SDK (2.1.1)
and the memory metrics in azure for my services are all creeping up every hour.
It used to be stable until before the update but is growing now.
I'll post more details later. Only change is to netcore 2.1 and app insights SDK (2.1.1)

@vigneshmsft can you upgrade you application insights sdk to the latest beta, and let us know if seeing this issue? (2.1.1 is not the latest, the latest stable is 2.3.0, and latest beta is 2.4.0-beta3)
https://www.nuget.org/packages/Microsoft.ApplicationInsights.AspNetCore

@cijothomas sorry I meant I am on 2.1.1 for the netcore sdk
Microsoft.AspNet.Core.App is 2.1.1
Microsoft.ApplicationInsights 2.6.4
Microsoft.ApplicationInsights.AspNetCore 2.3.0
And am not at liberty to update to beta version of any packages in production.

@vigneshmsft The fix for the incorrect HttpClient usage leading to leaking is available as a beta only today. We'll be releasing stable in next week most likely. I understand your concern about using beta in prod - if possible validate that this is the issue you are hitting by trying out the beta in non-prod environment.
( The issue occurs only on on NetCore 2.1. 2.0 did not have this issue from our experiments. )

@cijothomas any updates on when a stable version will be released?

@vigneshmsft In ~ 1 week.

Most likely by Wednesday next week.

Ours is a normal aspnet web api project. Please look at the package file. We too face the same CPU issue. Will this get resolved if i upgrade the application insights package to the  latest of 2.6.4 and 2.4.0 respectively. Please let  me know. This is not a .net core project but. This was created recently

@Meenakshise The issue we addressed here was specific to .NET Core apps only, so i don't think this will help you. Either way, we always recommend using the latest version to get all the bug fixes etc.
Could you try to use the latest stable/beta, and report back if you have high CPU usage issue.

updating to 2.4.0 has fixed the memory leak issue.

Any explanation on what was the issue?

@IanKemp
https://github.com/Microsoft/ApplicationInsights-dotnet/issues/594
https://github.com/Microsoft/ApplicationInsights-dotnet/pull/857

I upgraded to the 2.4.1 and it still has the leak which increases over time.
First screenshot showing 2 threads working only and constantly on the CPU leak, I found that the amount of threads depend on uptime of the process, so leak increasing in time and was not fixed in 2.4.1
Second screenshot showing the increase ratio where 600% is a hardware limit, after some time AspNetCore app working only on the leak.
@cijothomas Please advise here.

@Svisstack what version of .NET are you running on? High CPU usage in the HttpHeaders Dictionary'2.TryGetValue would suggest concurrent writes to the header dictionary.
.NET Core 2.1 will throw an exception when an infinite loop would previously occur due to this https://github.com/dotnet/corefx/issues/28123

@Svisstack what version of .NET are you running on? High CPU usage in the HttpHeaders Dictionary'2.TryGetValue would suggest concurrent reads+writes to the header dictionary.
.NET Core 2.1 will throw an exception when an infinite loop would previously occur due to this https://github.com/dotnet/corefx/issues/28123
It could happen if FrameworkSqlEventListner (or its chain in your callstack) if fired after/concurrently with the request end (when the Dictionary is cleared)

@benaadams I'm running this on the .NET Framework 4.7.2
If this is true it looks like a major bug in appinsights; why someone would put a SpinLock-like reader around the dictionary item which does not exist.

why someone would put a SpinLock-like reader around the dictionary item which could not exist.

The dictionary for the header collection is reused for each request on the same connection; so at the end of the request it is cleared. If that clearing happens while another thread is reading the header collection (e.g. it reads it outside of the normal request flow); then the read can go into an infinite loop as the arrays inside the dictionary are changed (Dictionary's are not threadsafe for a concurrent write with any other operation on it). In .NET Core 2.1 it will detect the infinite loop being formed and throw an exception; though it won't fix the concurrent use.

@benaadams Thanks for detailed explanation. I understand now what's happening, but didn't see a clear solution of this as it looks like the bug is actually in the AspNetCore which allows concurrent requests to the dictionary which is not thread-safe.

looks like the bug is actually in the AspNetCore which allows concurrent access to the dictionary instance

Well... even if concurrent access was prevented (at a performance cost); it still wouldn't help as the data it read would still be wrong.
If its conflicting with .Clear() this means there is a race condition and 3 outcome could happen (if concurrent access was prevented)

It could read the right data (pre clear)
It could read no data (post clear) wrong
It could read headers from the next request very wrong

At a guess... Looking at the stack from dotTrace, it could be a Sql query that's started as part of the Request; but not awaited as part of the request, so the response is sent before the Sql is completed. It could also be a Timer that's started to periodically poll and lazily started as part of a Request.
When it completes it would then be trying to log the shallow copied (i.e. reference to) the captured Request data as part of the Application Insight's Telemetry event; using the mutable Request information that has now changed and is no longer valid for the event.
I'm not entirely sure how FrameworkSqlProcessing.OnEndExecuteCallback accesses the Headers collection, though it looks to be part of the DependencyTelemetry object.
public void OnEndExecuteCallback(long id, bool success, bool synchronous, int sqlExceptionNumber)
{
    DependencyCollectorEventSource.Log.EndCallbackCalled(id.ToString(CultureInfo.InvariantCulture));

    var telemetryTuple = this.TelemetryTable.Get(id);

    if (telemetryTuple == null)
    {
        DependencyCollectorEventSource.Log.EndCallbackWithNoBegin(id.ToString(CultureInfo.InvariantCulture));
        return;
    }

    if (!telemetryTuple.Item2)
    {
        this.TelemetryTable.Remove(id);
        var telemetry = telemetryTuple.Item1 as DependencyTelemetry;
        telemetry.Success = success;
        telemetry.ResultCode = sqlExceptionNumber != 0 ? sqlExceptionNumber.ToString(CultureInfo.InvariantCulture) : string.Empty;
        DependencyCollectorEventSource.Log.AutoTrackingDependencyItem(telemetry.Name);
        ClientServerDependencyTracker.EndTracking(this.telemetryClient, telemetry);
    }
}

If its a Timer being kicked off that then runs Sql queries you will likely want to suspend ExecutionContext flow when creating that Timer so that the HttpContext doesn't get captured and become forever accessible via IHttpContextAccessor when it shouldn't be (e.g. its only via during that request)
Using a pattern similar to https://github.com/dotnet/corefx/pull/26075

Or aspnet's NonCapturingTimer helper https://github.com/aspnet/Common/pull/395

@benaadams Thanks, I actually found the Tasks which can and probably are ending after the requests is finished with the SQL code, I will wait on them and report about the state of the issue.
Based on your very useful input, I think it's still issued in the AspNetCore as it should not provide functions which delivering possible random data, if Headers dictionary is shared between requests then function for accessing that headers should have required some kind of request ID (GUID) based on which internal function could decide that these headers no longer exists.

I think it's still issue in the AspNetCore as it should not provide functions which delivering possible random data, if Headers dictionary is shared between requests

Its more the Headers for the connection as their can only be one active request on a connection at any time. If they are accessed via IHttpContextAccessor there is a change in ASP.NET Core 2.2 to invalidate the HttpContext and return null in the manner you described https://github.com/aspnet/HttpAbstractions/pull/1021
However, while that may help with the CPU issue; it would also mean the telemetry from OnStart would be disconnected from OnEnd; if its using anything in the headers or HttpContext to connect them (as OnEndXxx wouldn't have this information).
What should probably happen is Application Insights during OnStartXxx; which happens during the request, should deep copy the information it needs from the context/headers (e.g. key, values) as the strings will remain valid being immutable. Then OnEndXxx should use that same copied object to get the headers which were captured at the start of the event.
I'm not entirely sure how Application Insights is capturing/reading the headers so I can't provide code suggestions for the changes, alas...

@benaadams Removing the Tasks with SQL code that could end after the request solved the issue. Many thanks, I really appreciate your input here.
So it's no action needed here as there is a new interface which didn't have this issue? I want to make sure that we should fix that for the community, or at least in known Insights bugs should be information that no dependency should end after the request is already finished.

Well I do think AI should collect the information it needs on event start (i.e. key,value for headers); then use that collected information for event end; rather than rereading it from the HttpHeader collection; which should solve this issue more holistically.

@benaadams Can you then reopen this issue?

Can you then reopen this issue?

Nope, I don't work for MS or have rights to this repo

@Svisstack Can you open this issue in https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues?
From an initial look, the issue you are facing is from DependencyCollection module, which is in not in this repo. (This repo only has asp.net core extension methods, and request collection)
https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues

@cijothomas It's done.

@Svisstack thanks. Will discuss on othed thread.

@benaadams Thanks, I actually found the Tasks which can and probably are ending after the request is finished and they contain the SQL code, I will wait on them and report about the state of the issue after deploying the new version today.
Based on your very useful input, I think it's still issue in the AspNetCore as it should not provide functions which delivering possible random data, if Headers dictionary is shared between requests then function for accessing that headers should have required some kind of request ID (static long incrementing every new request) based on which internal function could decide that these headers no longer exists and throw an exception instead of providing random data.

Hi @Svisstack,
How did you solve that with this way? Could you share any code detail?

@Turgay I was able to wait on all the tasks or rewriting a sync code into the sync one before the request ended, in the future I could not probably do that then I believe migrating to the other lib or waiting for the fix are the only options.

On 14 Dec 2561 BE, at 00:32, Turgay<EMAIL_ADDRESS>wrote:
@benaadams Thanks, I actually found the Tasks which can and probably are ending after the request is finished and they contain the SQL code, I will wait on them and report about the state of the issue after deploying the new version today.
Based on your very useful input, I think it's still issue in the AspNetCore as it should not provide functions which delivering possible random data, if Headers dictionary is shared between requests then function for accessing that headers should have required some kind of request ID (static long incrementing every new request) based on which internal function could decide that these headers no longer exists and throw an exception instead of providing random data.
Hi @Svisstack,
How did you solve that with this way? Could you share any code detail?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@Svisstack I guess you meant @turgayozgur but not me :)


TypeError: Converting circular structure to JSON

Describe the bug
Handler with code
async (arg) => {
  return arg
}

Rejects with error:
{
  "stack": "TypeError: Converting circular structure to JSON\n    --> starting at object with constructor 'Object'\n    |     property 'Provider' -> object with constructor 'Object'\n    --- property '_context' closes the circle\n    at JSON.stringify (<anonymous>)\n    at stringify (/node_modules/express/lib/response.js:1150:12)\n    at ServerResponse.json (/node_modules/express/lib/response.js:271:14)\n    at file:///index.js:77:13\n    at Generator.next (<anonymous>)\n    at fulfilled (file:///index.js:4:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)",
  "message": "Converting circular structure to JSON\n    --> starting at object with constructor 'Object'\n    |     property 'Provider' -> object with constructor 'Object'\n    --- property '_context' closes the circle"
}

Workaround:
Use util.inspect:
async (arg) => {
  const util = await import('util')
  return util.inspect(arg, {depth: 15})
}

Expected Behavior
Handler to return that json
Current Behavior
Handler rejects with error
Steps to reproduce
No response
Environment
No response

https://stackoverflow.com/questions/10392293/stringify-convert-to-json-a-javascript-object-with-circular-reference

https://stackoverflow.com/questions/10392293/stringify-convert-to-json-a-javascript-object-with-circular-reference

I have already wrote workaround with util.inspect but should not provider do it itself for returnied value?


Update colors.fish

Added color support like colors.sh

Hey, thanks for the PR. I've completely forgotten about my PR to the upstream. I'll try to take care of it within next few days. Thanks!


What do you think about using Bitwise NOT Operator on line 8 ?

Now i got why not and what do you think about the "no-implicit-coercion" :+1:

Why would I make the code harder to read...


WIP: Adopt Ansible documentation model

use sphinx_ansible_theme

@webknjaz Please take a look at the outcome of this. We can use molecule as early adopter for the shared theme and once we are done with it we can do the same for the linter.
If you spot a bug in the theme, raise it directly to its repository. Thanks.


fix(show): Port --devel flag for show command

Port  PR #5141 to Helm v3 show command
Fixes #7658

Thanks @mattfarina for the review.  I got an OK to merge also from @bacongobbler on slack.


Hello, please add a description in English how to use your plugin

Hello, please add a description in English how to use your plugin

Hi! There’s a plan to translate the Chinese getting-started doc into English. Stay tuned :)

Finished with #35


Add a check to verify that relative markdown links are not broken

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

Failing build:

https://github.com/gradle/gradle/actions/runs/11295403820/job/31418031305?pr=30882


add "tennis" to ambiguous words

Simple one :)

Thanks!

@Hugo-ter-Doest any chance you publish a new minor version to npm soon? 🙏


More events

In Mosca, I've configured a custom bunyan-stream module to capture keepalive timeout & setting keepalive time events since these are logged using bunyan.
Can we add two more emits for these in aedes @mcollina ?

yeah, no problem in more emits.
Aedes and mosca v2 will use pino. It's 4-5 time faster than bunyan. I have
a snippet for mosca v1 if you want.
Il giorno ven 17 giu 2016 alle 19:41 Behrad<EMAIL_ADDRESS>ha
scritto:

In Mosca, I've configured a custom bunyan-stream module to capture keepalive
timeout & setting keepalive time events since these are logged using
bunyan.
Can we add two more emits for these in aedes @mcollina
https://github.com/mcollina ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mcollina/aedes/issues/55, or mute the thread
https://github.com/notifications/unsubscribe/AADL4_amHthFD4m-OtZO6QdWo-PiwZchks5qMtxDgaJpZM4I4lBA
.

Aedes and mosca v2 will use pino. It's 4-5 time faster than bunyan

And this is with high verbose levels? Or even if log level is ERROR?

I have
a snippet for mosca v1 if you want

What snippet?

Yes, you can high verbosity without a huge impact on perf: replacing
winston in a normal web app gives 20-50% throughput boost. I'm not at my
laptop, I'll send the snippet for mosca v1 soon.
Il giorno ven 17 giu 2016 alle 19:58 Behrad<EMAIL_ADDRESS>ha
scritto:

Aedes and mosca v2 will use pino. It's 4-5 time faster than bunyan
And this is with high verbose levels? Or even if log level is ERROR?
I have
a snippet for mosca v1 if you want
What snippet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mcollina/aedes/issues/55#issuecomment-226838363, or mute
the thread
https://github.com/notifications/unsubscribe/AADL4ziqXF_N99P4f9WqsowGi4-GPd7Hks5qMuBegaJpZM4I4lBA
.


How to stops training after specied number of steps?

I want to stop training after a specified number of steps automatically, does anyone knows how to do it?

By default, the number of epochs is set to indefinite, so it will keep on training till you kill the process.
You can kill the process and use the last checkpoint file.


Integrate Chimoney with Quickbooks to track transactions

Example:
Small business owners using QuickBooks to manage their finance can have all their Chimoney transactions, to be automatically recorded in QuickBooks.
Idea Flow:

[ ] Integrate Chimoney with QuickBooks.
[ ] Develop a sync mechanism to update QuickBooks with new transactions that take place via Chimoney.
[ ] Implement error handling for failed data transfers.
[ ] Test the integration with sample transactions.

Does this need to be a separate platform on it's own or just a quickbooks app that updated and syncs you chimoney transactions with quickbooks? Thanks
@phyleria

You can sync the transactions on a quickbooks app.

@phyleria
I would like to contribute on this issue. could you please assign me this issue.


Proxy

Hello Devbridge,
I cant get your tool running at my app :(
I think because i run my app on a custom .dev domain.
I have set the correct path in the setting: ["resources/assets/sass/base/_variables.scss"]
When i try to reach localhost:8889 the response i get is:
Error: Not Found    at /Users/**/workspace/***/node_modules/devbridge-styleguide/app.js:36:13    at Layer.handle [as handle_request] (/Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/layer.js:82:5)    at trim_prefix (/Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/index.js:302:13)    at /Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/index.js:270:7    at Function.proto.process_params (/Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/index.js:321:12)    at next (/Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/index.js:261:10)    at /Users/**/workspace/***/node_modules/devbridge-styleguide/app.js:27:3    at Layer.handle [as handle_request] (/Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/layer.js:82:5)    at trim_prefix (/Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/index.js:302:13)    at /Users/**/workspace/***/node_modules/devbridge-styleguide/node_modules/express/lib/router/index.js:270:7
My current project i am working on is laravel project with laravel elixir (https://laravel.com/docs/5.2/elixir)
For the BrowserSync function i needed to set a proxy to get this working:
    mix.browserSync({         proxy: 'project.app'     });
I think i need some sort of same approach for this to get it working?
I hope you guys can help me out :)

@fridzema
maybe this will help, from documentation:

@VaclovasV
Thanks!
This made me think to start the styleguide server on my vagrant machine.
Solved my question, though i think that a proxy option is a nice feature for this package!


SIGPIPE on error: pubsub: already have connection to peer

Related to #77 - this error:
[0;37m19:39:09.689 �[31mERROR �[0;34mipns-repub: �[0mRepublisher failed to republish: failed to find any peer in table �[0;37mcore.go:518�[0m

Seems to follow SIGPIPE signals in iOS, which apparently are related to using an already closed socket.
@andrewxhill reports a very similar issue in Android - bunch of closed socket warnings, right?

I think this is what we're seeing here:
https://go-review.googlesource.com/c/go/+/10010
Also related: "runtime: SIGPIPE is raised when using net.DialTimeout and timeout is reached"
https://github.com/golang/go/issues/17393
...which is apparently a dup of: https://github.com/golang/go/issues/17393
We're not crashing, just getting them stuck in lldb, you can ignore from then on with (lldb) process handle SIGPIPE -n false -p true -s false
Seems like some good fixed there if you're running a normal program, not sure how to deal with this is a gobind-ed lib. Anyway, not too worried for now

Closing this as the symbolic break point works fine


Cannot connect two Hue Bridges

Describe the bug
I am not able to setup two hue bridges - the config nodes are ok - but on any node it does not take inot account the selection of the bridge in the in individual nodes.

Can you please try it out again with the 4.0.4?

hi,
in the first test it look like that all works fine.
thanx a lot - i love this plugin an will spent some money next time per PayPal.
One question:
with this nodes:
[     {         "id": "3884b871.c06958",         "type": "hue-group",         "z": "4017e5c7.708454",         "g": "85bd5806753239e4",         "name": "Terrasse Garten",         "bridge": "63d7db56.1e617c",         "groupid": "5061ea86-c641-4ff3-9325-b3be5ad0e909",         "skipevents": false,         "initevents": false,         "x": 1070,         "y": 735,         "wires": [             [                 "4b92ee7a.66e6e8",                 "e44ae8e9.8b92e8",                 "e6e8f84e.d07538",                 "4eab36f1.8ba758"             ]         ]     },     {         "id": "4eab36f1.8ba758",         "type": "function",         "z": "4017e5c7.708454",         "g": "85bd5806753239e4",         "name": "Abfrage Helligkeit Sonneninsel",         "func": "\nif (msg.payload.on==true){\n    if(msg.payload.brightness<=10){\n        msg.payload=3;\n        return [msg];\n    }\n    if(msg.payload.brightness<=30){\n        msg.payload=2;\n        return [msg];\n    }\n    if(msg.payload.brightness>30){\n        msg.payload=0;\n        return [msg];\n    }\n} \nmsg.payload=1;\nreturn [msg];",         "outputs": 2,         "noerr": 0,         "initialize": "",         "finalize": "",         "libs": [],         "x": 1320,         "y": 715,         "wires": [             [                 "f5704047.15586"             ],             []         ]     },     {         "id": "4b92ee7a.66e6e8",         "type": "function",         "z": "4017e5c7.708454",         "g": "85bd5806753239e4",         "name": "Fake Lampe Gartenlich erstellen",         "func": "if (msg.payload.on == true){\n    msg.payload = {\"On\":1, \"Brightness\":msg.payload.brightness};\n}else {\n    msg.payload = {\"On\":0, \"Brightness\":msg.payload.brightness};\n}\nreturn [msg];\n",         "outputs": 1,         "noerr": 0,         "initialize": "",         "finalize": "",         "libs": [],         "x": 1320,         "y": 755,         "wires": [             [                 "88683a69a88fde3e"             ]         ],         "icon": "node-red/swap.svg"     },     {         "id": "63d7db56.1e617c",         "type": "hue-bridge",         "name": "HUE Garten",         "bridge": "<IP_ADDRESS>",         "key": "cAPkeqp1jX9YdYtvPjkRz0U4IM5kQv1SCHjN-j8G",         "disableupdates": false     } ]
i get the brightness form the lamps in a group an send it out. This not work at the moment. So is there a way to get the acutely brightness from  a group oder a room with lamps?

Hi,
I had the same problem. Now it seems to work. Thanks

Nice! Thanks for testing it out guys. There are so many different setups with this library, it’s nearly impossible for me to test every case on my own to find possible issues in advance

@Donni1966 Thanks for you donation :)! Unfortunately it's not possible with the newest API from Philips to get the current brightness from a Group / Zone.
The old API had this feature, now they removed it because groups / zones can contain different kind of devices besides lights. Not every device inside a group for example has the capabilities to set a brightness, different colors...
If they would, I also don't see what kind of values the bridge should output for the group if one light is set to 100% brightness and yellow, when another is set to 50% blue.
Should it be 75% brightness and green then? :S
I would suggest you to put a light node right after the group node where you know that it is linked with the group and get the brightness value from this light for the whole group, if you still need to access this value. It luckily happens all in real time without any overhead to your bridge when using multiple, additional nodes with the v4, so maybe this is a solution for you (and others relying to this previous features)?

Hello - it does not work for me.
Bridge seems to be connected, but trun off/on lights ends in an error
... "Error:
Request failed with status code 503"
(on the node it shows "executing command"
Am Mi., 12. Jan. 2022 um 19:20 Uhr schrieb Foddy @.***>:

Can you please try it out again with the 4.0.4?
—
Reply to this email directly, view it on GitHub
https://github.com/Foddy/node-red-contrib-huemagic/issues/272#issuecomment-1011328018,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKMRZMFC2TEVHXZYK43QEXDUVXBAPANCNFSM5LZHDWIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello - it does not work for me.
Bridge seems to be connected, but trun off/on lights ends in an error ... "Error: Request failed with status code 503"(on the node it shows "executing command"

node it shows "executing command"

in my case i relink the bridge a second time.

I would suggest you to put a light node right after the group node where you know that it is linked with the group and get the brightness value from this light for the whole group, if you still need to access this value. It luckily happens all in real time without any overhead to your bridge when using multiple, additional nodes with the v4, so maybe this is a solution for you (and others relying to this previous features)?

Jes, absolut no problem. i only ask for the brightness. in my case it is enough to read the brightness from one lamp of the room, so i have the group brightness thanx.


When both Basic Auth and HTTPS redirection are configured, auth is also required before redirection

Consider an LB configuration like this: https://github.com/leonidas/loki/blob/master/kontena.yml#L44-L55
It's supposed to redirect all http traffic to the matching https URL. Also it implements basic auth.
However, now when I access http://foo.example.com, it first asks for basic auth over unsecured HTTP, then only when supplied credentials over unsecured HTTP it redirects to secure HTTPS… and prompts for credentials again.
I would like to change it so that unsecured HTTP redirects to HTTPS without asking for authentication, and only HTTPS asks for authentication.
According to @jnummelin there is no direct solution to this problem at the moment. Please make the necessary changes to the load balancer and its documentation to facilitate such a setup so that

http://foo.example.com redirects to https://foo.example.com without asking for authentication over insecure HTTP first, and
https://foo.example.com asks for HTTP basic auth over encrypted HTTPS

As a workaround (and a general best practice) I will enable HTTP Strict Transport Security on https://foo.example.com so that after first time, even manually entering foo.example.com (without https://) at the address bar will take the user to the HTTPS version of the site.

When you get HSTS working, please share the needed configs. There are probably others, including me, interested in that. And we could probably also do that with a KONTENA_LB_HSTS flag in the future.

@jnummelin please find configuration for HSTS here:
https://github.com/leonidas/loki/blob/f43cb3f56d2b43bcb3bc262bc427e3d399b3b63f/kontena.yml#L49-L51
This does likely set the HSTS header on any successfully authenticated unencrypted HTTP response as well, but the spec instructs to ignore the header on unencrypted responses, so no harm done.


Filament Android project compilation fail

I am a Mac user who is building Filament for Android using the following instructions https://github.com/google/filament/blob/main/BUILDING.md

I tried both ./build.sh -p android release and ./build.sh -i -p android release

After building successfully I open the android/samples/hellotriangle project in Android Studio but the project compilation fails with error:  Could not find xxxx/xxxxx/xxxx/filament/out/release/filament/bin/matc. Ensure Filament has been built/installed before building this app.

Why is there no release/filament in the out/ folder?

So I tried downloading the compiled release for Mac filament-v1.8.1-mac.tgz from here https://github.com/google/filament/releases

I copied the bin folder to the root directory of filament, under out/release/filament. The Android project now compiles.

When I run it on my Android phone I see a crash similar to this https://github.com/google/filament/issues/1088

Logcat details:
**filament.hellotriangle E/Filament: Panic
in static filament::MaterialParser filament::FMaterial::createParser(backend::Backend, const void , size_t):514
reason: Material version mismatch. Expected 8 but received 7.
If it is the same issue described here  https://github.com/google/filament/issues/1088 and I am building Filament for Android with an older version of matc where can I get version 8?
Or is it another issue?

Okay I fixed it with this:
./build.sh -p desktop,android -i release

Okay I fixed it with this:
./build.sh -p desktop,android -i release

It works ,thanks


feat: Readonly root filesystem support in the Appsmith container

Fixes #26392.

reminder: get Keycloak to also use the new truststore, when there's custom CA certs to trust.
verify: test SAML, when Appsmith is exposed with HTTPS, with cert signed by custom CA.

Duplicate of #28290


Import existing resources and got CacheClusterNotFound error even it exists

What happened?
Hey Pulumi,
I have a few Elastic Clusters (on AWS) and I am trying to import them to Pulumi. The problem is that some of them are about to be detected by Pulumi and some are not. I am wondering why? Here is the example
admin-gateway and infra-storage-thai-test-v2 are both in same aws account and same region (us-west-2). Pulumi was able to generate code for admin-gateway:
thaipham@N9GK65GXW1 quickstart % pulumi import aws:elasticache/cluster:Cluster admin-gateway admin-gateway
Previewing import (dev)

View Live: https://app.pulumi.com/thailowki/quickstart/dev/previews/2189eee2-316c-4e2d-a50f-ab03a68c4194

     Type                        Name            Plan
 +   pulumi:pulumi:Stack         quickstart-dev  create
 =   └─ aws:elasticache:Cluster  admin-gateway   import

Resources:
    + 1 to create
    = 1 to import
    2 changes

Do you want to perform this import? details

but not for the other :
thaipham@N9GK65GXW1 quickstart % pulumi import aws:elasticache/cluster:Cluster infra-storage-thai-test-v2 infra-storage-thai-test-v2
Previewing import (dev)

View Live: https://app.pulumi.com/thailowki/quickstart/dev/previews/a5490dc5-985d-49d7-ad67-928e331dc742

     Type                        Name                        Plan       Info
 +   pulumi:pulumi:Stack         quickstart-dev              create     1 error
 =   └─ aws:elasticache:Cluster  infra-storage-thai-test-v2  import     1 error

Diagnostics:
  pulumi:pulumi:Stack (quickstart-dev):
    error: preview failed

  aws:elasticache:Cluster (infra-storage-thai-test-v2):
    error: Preview failed: resource 'infra-storage-thai-test-v2' does not exist

Here is the log file:
<EMAIL_ADDRESS>Steps to reproduce
Using the command pulumi import aws:elasticache/cluster:Cluster infra-storage-thai-test-v2 infra-storage-thai-test-v2
Expected Behavior
About to generate code to import existing resource.
Actual Behavior
pulumi:pulumi:Stack (quickstart-dev):
error: preview failed
aws:elasticache:Cluster (infra-storage-thai-test-v2):
error: Preview failed: resource 'infra-storage-thai-test-v2' does not exist
Output of pulumi about
CLI
Version      3.38.0
Go Version   go1.19
Go Compiler  gc
Plugins
NAME  VERSION
aws   5.9.2
go    unknown
Host
OS       darwin
Version  12.5.1
Arch     arm64
This project is written in go: executable='/usr/local/go/bin/go' version='go version go1.19 darwin/arm64'
Current Stack: dev
TYPE                             URN
pulumi:pulumi:Stack              urn:pulumi:dev::quickstart::pulumi:pulumi:Stack::quickstart-dev
pulumi:providers:aws             urn:pulumi:dev::quickstart::pulumi:providers:aws::default_5_9_2
aws:elasticache/cluster:Cluster  urn:pulumi:dev::quickstart::aws:elasticache/cluster:Cluster::gater
Found no pending operations associated with dev
Backend
Name           pulumi.com
URL            https://app.pulumi.com/thailowki
User           thailowki
Organizations  thailowki
Dependencies:
NAME                                 VERSION
github.com/pulumi/pulumi-aws/sdk/v5  5.9.2
github.com/pulumi/pulumi/sdk/v3      3.35.3
Pulumi locates its logs in /var/folders/wm/sqsss00j4l789_gkcqhtlr3w0000gn/T/ by default
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @thailowki
If you use the AWS CLi, are you able to describe both resources?
Paul

Hi @stack72 ,
I was able to describe admin-gateway and couldnt for infra-storage-thai-test-v2
thaipham@N9GK65GXW1 quickstart % aws elasticache describe-cache-clusters --cache-cluster-id admin-gateway
{
    "CacheClusters": [
        {
            "CacheClusterId": "admin-gateway",
            "ClientDownloadLandingPage": "https://console.aws.amazon.com/elasticache/home#client-download:",
            "CacheNodeType": "cache.m3.xlarge",
            "Engine": "redis",
            "EngineVersion": "3.2.10",
            "CacheClusterStatus": "available",
            "NumCacheNodes": 1,
            "PreferredAvailabilityZone": "us-west-2a",
            "CacheClusterCreateTime": "2019-05-08T20:36:40.725000+00:00",
            "PreferredMaintenanceWindow": "fri:10:30-fri:11:30",
            "PendingModifiedValues": {},
            "CacheSecurityGroups": [],
            "CacheParameterGroup": {
                "CacheParameterGroupName": "default.redis3.2",
                "ParameterApplyStatus": "in-sync",
                "CacheNodeIdsToReboot": []
            },
            "CacheSubnetGroupName": "default",
            "AutoMinorVersionUpgrade": true,
            "SecurityGroups": [
                {
                    "SecurityGroupId": "sg-34a9db52",
                    "Status": "active"
                }
            ],
            "SnapshotRetentionLimit": 0,
            "SnapshotWindow": "09:00-10:00",
            "AuthTokenEnabled": false,
            "TransitEncryptionEnabled": false,
            "AtRestEncryptionEnabled": false,
            "ARN": "arn:aws:elasticache:us-west-2:611706558220:cluster:admin-gateway",
            "ReplicationGroupLogDeliveryEnabled": false,
            "LogDeliveryConfigurations": []
        }
    ]
}

`thaipham@N9GK65GXW1 quickstart % aws elasticache describe-cache-clusters --cache-cluster-id infra-storage-thai-test-v2
An error occurred (CacheClusterNotFound) when calling the DescribeCacheClusters operation: CacheCluster not found: infra-storage-thai-test-v2`

Hi @thailowki
If the AWS CLI is not able to describe it then we are not going to be able to read it either I'm afraid. I think there's something incorrect with your configuration
I can close this out and if you still get the same behaviour when you get the CLI working, then w can revisit if Pulumi can't find it
Sorry to not be more help here
Paul


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.4.133",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d71dddeb5380613f9ef199f3e7368fd78fb1a46e"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "d71dddeb5380613f9ef199f3e7368fd78fb1a46e",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "wl1251: Fix possible buffer overflow in wl1251_cmd_scan\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.133 by commit d71dddeb5380613f9ef199f3e7368fd78fb1a46e. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001353


Resolve Issue #130 tooltips

Added tooltips, though ongoing maintenance may be a nightmare.
Reviewing is tough because of the size of the diff. I tried to figure out an automated way, but failed.

I don't have objections if this is felt to be too big to digest and either is broken up into multiples PRs by icon to keep the diff manageable, or even deferred while the workflow is rationalized to make sure future icons get tooltips.

As discussed in Slack and #130 we'll need to revisit this later. Merging and maintaining this with current workflow isn't something we can expect to sustain. Thanks again!

I agree that this is an appropriate resolution.


Create PRC process page

[x] Create rough draft of PRC processes page, outlining what is different between PRC and non-PRC content,
[x] Fred approved page
[ ] James approved page
[x] Naushin approved page
[ ] Rebecca approved page

https://elifeproduction.slab.com/posts/prc-processes-sijgc3ov


feat: update secret access key tips

What's the purpose of this PR
When the apollo version is upgraded to 1.9.0 and above, the secret key configuration variable is changed, APOLLO_ACCESSKEY_SECRET is changed to APOLLO_ACCESS_KEY_SECRET, apollo.accesskey.secret is changed to apollo.access-key.secret. When the apollo server is upgraded to 1.9.0+ and the apollo client is Using the version below 1.9.0, using the variables provided by the tips above 1.9.0 will cause the key variable to be inapplicable.For better use, we need to modify the contents of the Tips.
the original tips：

the modified tips：

Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Read the Contributing Guide before making this pull request.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[ ] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

I have read the CLA Document and I hereby sign the CLA

After merging PR #3754, I think the access key tips mislead some users who use the apollo java client version in [1.6.0, 1.9.0).
This PR looks good to me.

Codecov Report

Merging #4339 (68206a8) into master (4e000c5) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4339      +/-   ##
============================================
- Coverage     53.21%   53.17%   -0.05%
+ Complexity     2673     2672       -1
============================================
  Files           489      489
  Lines         15267    15267
  Branches       1576     1576
============================================
- Hits           8125     8118       -7
- Misses         6589     6597       +8
+ Partials        553      552       -1

Impacted Files
Coverage Δ

...framework/apollo/openapi/entity/ConsumerAudit.java
42.42% <0.00%> (-6.07%)
:arrow_down:

...mework/apollo/portal/component/PortalSettings.java
65.62% <0.00%> (-4.69%)
:arrow_down:

...ework/apollo/internals/RemoteConfigRepository.java
85.27% <0.00%> (-3.07%)
:arrow_down:

...mework/apollo/openapi/service/ConsumerService.java
53.38% <0.00%> (-1.70%)
:arrow_down:

...ervice/service/ReleaseMessageServiceWithCache.java
87.05% <0.00%> (+1.17%)
:arrow_up:

...work/apollo/biz/message/DatabaseMessageSender.java
64.58% <0.00%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e000c5...68206a8. Read the comment docs.


The linter is mis-reporting issues or is just really slow to update the editor

The error is a missing )

Please see my comment in #3140, closing this one.


Removes react-native-colo-loco by default

When we added react-native-colo-loco, we sort of violated one of the rules of Ignite -- that we would have battle-tested every component of Ignite in a real project before including it in Ignite.
To be clear, I still think react-native-colo-loco is awesome! I think everyone should use it. But I also don't want to violate the trust of our Ignite users by using something that isn't as battle-tested in our default stack.
Fixes #1845.

:tada: This PR is included in version 7.10.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add local registry support to test framework

Set using local registry as default option for running tests locally.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kimikowang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimikowang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang @hklai one more question to you for Option 3 at https://github.com/istio/istio/blob/master/tests/e2e/README.md#step-4-export-test-script-variables ，how can I get log of istio-presubmit.sh? Any steps can share with me? Thanks.

@kimikowang: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
9fb6a10a2f941d26a9e6ddd64301b63aefc53527
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
9fb6a10a2f941d26a9e6ddd64301b63aefc53527
link
/test istio-unit-tests

prow/istio-presubmit.sh
9fb6a10a2f941d26a9e6ddd64301b63aefc53527
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/istio-presubmit.sh
9fb6a10a2f941d26a9e6ddd64301b63aefc53527
link
/test istio-presubmit

prow/istio-unit-tests.sh
4ac9efca96601025543d3dfe8be963961617658f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
4ac9efca96601025543d3dfe8be963961617658f
link
/test istio-unit-tests

prow/istio-presubmit.sh
4ac9efca96601025543d3dfe8be963961617658f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/istio-presubmit.sh
4ac9efca96601025543d3dfe8be963961617658f
link
/test istio-presubmit

prow/istio-unit-tests.sh
7895ec484d0102adad121148f8301fd8f197914c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
7895ec484d0102adad121148f8301fd8f197914c
link
/test istio-unit-tests

prow/istio-presubmit.sh
7895ec484d0102adad121148f8301fd8f197914c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kimikowang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz
Assign the PR to them by writing /assign @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
98eb453f9665c86715aecfe2b6b92e8bf03dd125
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-simple

prow/istio-pilot-e2e.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kimikowang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wattli
Assign the PR to them by writing /assign @wattli in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-simple

prow/istio-pilot-e2e.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
de2fc0892628a7afe3d2b1c872b7a9eb9f5efb0b
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9b02b824ae84cf6dc170a24b6cfaafd655e17dcb
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
b19feca1dea480eac8fa047c73427d4ee0d9a1c5
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-simple

prow/istio-unit-tests.sh
eaf74a966de57808604228636ac1f9a0801a0958
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-simple

prow/istio-unit-tests.sh
eaf74a966de57808604228636ac1f9a0801a0958
link
/test istio-unit-tests

prow/istio-presubmit.sh
eaf74a966de57808604228636ac1f9a0801a0958
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-simple

prow/istio-unit-tests.sh
eaf74a966de57808604228636ac1f9a0801a0958
link
/test istio-unit-tests

prow/istio-presubmit.sh
ab207f6ccb308309f32373e918b1381e909c50ed
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-simple

prow/istio-presubmit.sh
ab207f6ccb308309f32373e918b1381e909c50ed
link
/test istio-presubmit

prow/istio-unit-tests.sh
ab207f6ccb308309f32373e918b1381e909c50ed
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-simple

prow/istio-presubmit.sh
ab207f6ccb308309f32373e918b1381e909c50ed
link
/test istio-presubmit

prow/istio-unit-tests.sh
a219d1bb827071e4b15886ea19981c3c57797288
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
281deac827685c45b02a77296b02327be0fb6d82
link
/test e2e-simple

prow/istio-unit-tests.sh
a219d1bb827071e4b15886ea19981c3c57797288
link
/test istio-unit-tests

prow/istio-presubmit.sh
a219d1bb827071e4b15886ea19981c3c57797288
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai, kimikowang
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimikowang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fe26a56b0b5a08409ce9620056aed767eafa93ea
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang just checking in ... let me know once you've addressed my comments, and I'll take another pass.

@kimikowang: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fe26a56b0b5a08409ce9620056aed767eafa93ea
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
fe26a56b0b5a08409ce9620056aed767eafa93ea
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kimikowang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fe26a56b0b5a08409ce9620056aed767eafa93ea
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
fe26a56b0b5a08409ce9620056aed767eafa93ea
link
/test istio-unit-tests

prow/istio-presubmit.sh
fe26a56b0b5a08409ce9620056aed767eafa93ea
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai we should probably find a new owner for this work, if we haven't already.

@nmittler yup @gargnupur has picked this up.


add mediaCapabilities hook

A proposal hook for #59 to see if there's any interest at this stage of the project.

@googlebot I signed it!

Oh, nice. I have not heavily used https://developer.mozilla.org/en-US/docs/Web/API/Media_Capabilities_API before but this looks like it could be an interesting consideration for a fit. I'll read up on the API and circle back here.

@wingleung would you be interested in moving the discussion of adding Media Capabilities API support over to https://github.com/GoogleChromeLabs/react-adaptive-hooks now that the hooks portion of the project lives over there?

@wingleung would you be interested in moving the discussion of adding Media Capabilities API support over to GoogleChromeLabs/react-adaptive-hooks now that the hooks portion of the project lives over there?

done


Make configureHTTP2AsyncSecureUpgrade public

Minor PR to make configureHTTP2AsyncSecureUpgrade  helper function public

@adam-fowler did you still want / need this change? (Apologies for missing this until now.)

Yes please. I currently have a copy of this function in Hummingbird. It would be preferable to use the original from swift-nio-http2.


[Question] epoll polling on an eventfd, while the eventfd is registered to io_uring. Is it possible?

Due to some reasons I have to keep using epoll to poll eventfd in the old program, and create a new posix thread to run io_uring, with eventfd registered.
Is this model possible to work?
And I found my epoll got notified right after the IO completes, rather than after I reap the CQE. Wondering if it's correct.

@axboe
My old program has another epoll instance, and its epoll_wait would sometimes fail with -1 and errno = EINTR, right after I submit the IO.
Why the newly added io_uring would affect epoll_wait ?  My test environment is kernel 5.15 upstream.


String parse format with preceding 0s for day and month

It seems there's no way to tell moment.js that the expected day and month has to have preceding 0s. For example:

07-09 12:12

In the docs it seems D and DD will be both parse to 1..31 and the same with M and MM.
Reproduction of the issue.
var momentDate = moment('7-9 12:40', 'DD-MM HH:mm');
alert("isValid: " + momentDate.isValid());  //output TRUE

I would expect it to return false. As I explicitly indicated I expect two numbers for the day and month.

My mistake:
Using the boolean at the end to specify the strict mode works as a charm.
var momentDate = moment('07-09 12:40', 'DD-MM HH:mm', true);

Moment's parser is very forgiving, and this can lead to undesired behavior. As of version 2.3.0, you may specify a boolean for the last argument to make Moment use strict parsing. Strict parsing requires that the format and input match exactly.


 I didn't update Native-base between today and yesterday nor did I touch the code...???

#1578


Error 404 in PythonAnywhere Console

As a member of the development team
I need identify the root cause of error 404 in the PythonAnywhere console
So that I can resolve the issue and ensure proper running of our system
Details and Assumptions

Error is a PythonAnywhere problem, not Qualtrics
Need to refer to PythonAnywhere API endpoints documentation

Acceptance Criteria
Given a developer tries to generate and send a pdf report using the system
When a 404 error occurs
Then the developer should analyze the logs to determine whether the error is due to a misconfigured endpoint, incorrect URL, or server downtime

Previous capstone team tried to use a PythonAnywhere API endpoint that is not supported


ta da

What is the problem that this PR is trying to fix?
What approach did you choose and why?
How can you make sure the change works as expected?
Would you like any additional feedback?

um, wtf is this


NEST-407: Update to newest packages

NEST-407

Doesn't this fix https://github.com/OrchardCMS/OrchardCore.Commerce/issues/261?


[Question] How to use logical operators in Form Build while using Js in Logic ?

Hi,
Im using Formio in my project and im calculating BMI succesfully . I also have second component which tell this BMI value is  thin or fat etc. In the Logic i create a trigger like this.

But after  save when i want to use it looks like in the builder.

After searching i know that i cannot use '<' or '<='  signs directly. I start replacing '>=' with '&gtt;=' in the renderer and builder components. First it worked but then randomly  start giving me '>=' this again.
How can i solve this ?

4.8.0

Hello @buseodaci, can you try testing using 5.0.0 and see if the issue still occurs?

@wag110894 Still same.


Prevent comments being flagged as spam by akismet

It's very difficult to get akismet to approve of a mechanically posted
comment because all the various capchas and java script tests have to
pass.  So, instead of trying to make everything right, simply turn off
akismet for Activitypub comments (this means you should set your
default policy to moderate all comments which don't have one approved
just in case some bot works out how to spam via activitypub).
Signed-off-by: James Bottomley<EMAIL_ADDRESS>

Hey @jejb ! Thanks for your MR!
We discussed that here #62 and here #66 !
I would prefer using a more generic method like the wp_set_comment_status introduced in #66, because Akismet is not the only Spam Protection plugin (Antispam Bee is very popular in Europe, because of GDPR reasons) but this disables the spam protection completely.
I would love to have both of both worlds: Antispam Plugins filtering spam, but not ActivityPub completely.

On Wed, 2021-02-10 at 09:53 -0800, Matthias Pfefferle wrote:

Hey @jejb ! Thanks for your MR!
We discussed that here #62 and here #66 !
I would prefer using a more generic method like the
wp_set_comment_status introduced in #66, because Akismet is not the
only Spam Protection plugin (Antispam Bee is very popular in Europe,
because of GDPR reasons) but this disables the spam protection
completely

That doesn't work for me because akismet still marks the comment as
spam, which excites my fail2ban filter.  Also once the comment gets
marked as spam, you don't get a notification email that it's pending.

I would love to have both of both worlds: Antispam Plugins filtering
spam, but not ActivityPub completely.

All spam plugins go to great lengths to detect that a human actually
sent in the comment via a web browser, so they add javascript puzzles
and nonces.  Activitypub comments, by their nature, aren't generated by
humans, they're emitted by rest endpoints after the human submitted the
comment, so none of those tricks are ever going to pass.
One possible way out is to mimic standard mechanically generated
content, which would be pingbacks, but you'd basically have to submit
the comment as a pingback and then flip the type to comment after it
was added to the database, which sounds like a nasty hack.
James

In light of all of the newer protocols, such as activityPub, I am quite surprised that more changes haven't been made to spam blocking facilities to accommodate the changing landscape, so it seems that it will take both sides of this working together to fix the issue completely.


grammerfixed

fixed grammar and added some section

Looks much better, but will still keep the issue open incase people can improve it further so not linking the PR to #1