fix/hyperliquid_recreates_reversing_order_on_close

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing:

commit 8dfc7f0
Test performed:

Cloned PR7013
Set up dmanv3 controller using hyperliquid and config from #6948
Review issue not reproduced during 22 hours
no errors showed during the run

Pending: ongoing longrun

@yancong001 could you add tests to this one?

added

https://github.com/hummingbot/hummingbot/issues/7024
Reproduced on this PR as well
@yancong001 could you have a look?

The problem has been solved

I've been testing this and noticed the same as nikspz. Now the script isn't working on Hyperliquid.
Last week I was able to place order, but they reversed again after a while. Now the orders aren't submitted to Hyperliquid (no  data in "Order history")
The logs are attached. If you need more info just let me know.
logs_hummingbot.log

I've been testing this and noticed the same as nikspz. Now the script isn't working on Hyperliquid. Last week I was able to place order, but they reversed again after a while. Now the orders aren't submitted to Hyperliquid (no data in "Order history")
The logs are attached. If you need more info just let me know. logs_conf_v2_generic_with_controllers_HL-dman.log

The issue was fixed at #7027


How to add new themes on ghost/openshift-quickstart?

Hi,
I installed ghost locally (not from the quickstart) and created a theme, which works fine on my local install. I tried cloning this theme (which for the moment is just a copy of casper with a different name and version) in the /content/themes folder from the repo openshift gave me. After pushing, I can see in my openshift ghost blog that the new theme is there, but the theme is broken.... so it displays only the name, not the version. and of course if I select it, it displays a 500 error on the front page:
Failed to lookup view "index" in views directory "/var/lib/openshift/559eec785004461bd30000e2/app-root/runtime/repo/content/themes/starticsghost"

Am I missing something? How exactly should I proceed in order to upload new themes to my ghost blog there? Thanks for the help, it's driving me nuts!

Hi @camilodelvasto
Is there any way to share the theme you are trying to install with me?
It sounds like a file missing or theme configuration issue.
Thanks

HI @MunGell, thanks for your answer. Here you can see the theme I'm trying to install: https://github.com/camilodelvasto/starticsghost.git - just a clone from casper with an addition on css. The theme works locally.
I also tried to install another free theme that I found but got the same error, so I'm definitely missing something.... thanks!

Thanks, I will take a look and come back to you

Hey @camilodelvasto
Your theme is working on my local machine as well, could you please copy all the files of your theme to repository's content/themes directory and try to redeploy your application?
It looks like you actually missing some files on the server (may be there was a merge conflict or you haven't committed all of them first time). Please, make sure that index.hbs is present in the repository that you are pushing to production.
Let me know if redeployment didn't work.

Hey @MunGell
I did that, actually just cloned my theme in the content/themes directory, pushed the changes and got the same... but after rhc-ing in the server I'm seeing the theme folder is empty. So, perhaps the folder gets removed during the deployment? Checked .gitignore and the themes are not there, so they should exist in the repo.... any clue? thanks for your help!

@MunGell it works now... I just had to remove the .git directory before pushing!

Cool, you are welcome!


Unable to create a project in Windows environment

When I try to create a flogo project in my windows environment, I get the following error:
>flogo create testing
Creating Flogo App: testing
installing core
Error: open examples\engine\flogo.json: The system cannot find the path specified.

my go version :
go version go1.10.5 windows/amd64
My Windows environment:
Windows 10 Pro @2018

The same is an error when I try creating the project by flogo create -f mode.

Can you upgrade the Go version to 1.11 or above?
Thanks

@skothari-tibco Upgrading my go version to v 1.11+ solved the issue. Thank you. Can you please confirm if we need to consider go v1.11 as minimum supported version for the new cli?

Yeah, I have it in the docs. We will have the docs on the repo soon. In meanwhile you can refer this link


fix: use min go1.22.0

As the linter is used as a lib it is better not to use a patched version.
Golangci-lint can be used with the "tools pattern", so it's better if we don't force the usage of a specific patched version if possible.
Related to https://github.com/golangci/golangci-lint/pull/4970

Thanks! I published v0.5.2 containing your patch 👍🏻


[main] Format markdown

Cron -knative-prow-robot
/cc knative-sandbox/eventing-writers lberk
/assign knative-sandbox/eventing-writers lberk
Produced by: knative-sandbox/knobots/actions/update-markdown
Details:
CONTRIBUTING.md 57ms

/lgtm
/approve


j/k held down keep moving cursor

First off thanks for this! Couldn't survive without it!
Maybe this isn't best practice but something that really been bugging me is that you're not able to keep j/k held down keep moving the cursor. Is there something obvious that I missed or is this possible to implement?

Something like what's described here worked for me: https://www.idownloadblog.com/2015/01/14/how-to-enable-key-repeats-on-your-mac/

@benlindsay thank you for the suggestion. Could you elaborate how you make use of this article? I'm on a mac as well but pressing down h/j/k/l works natively in vim and already bumped up key repeat to fast and delay until repeat to short.

If you did step 2 that says to enter the command defaults write NSGlobalDomain ApplePressAndHoldEnabled -bool false and restarted any applications you want to use repeated keys in, and it still doesn't work, then I don't know what else to do

This worked for me as well. Thank you


Can't use Dbeaver on Rocky9

Description
Hello,
I tried to use DBeaver on an fresh installation of Rocky9 with the RPM provided on the official website, but it didn't work. I have this kind of error : Could not load SWT library. (complete log in attachment).
dbeaver_log.txt
I tried multiple version (the last one too, but not working).
Thanks for your help,
Regards
DBeaver Version
23.3.5 and higher
Operating System
Rocky9.3
Database and driver
No response
Steps to reproduce

install the RPM from official website
Just launch dbeaver-ce
Failed at start

Additional context
No response

Thank you for bug report. Judging by the logs, he issue is the same is in #34034

@jef66 It sounds like an issue with one of our dependencies. Can you please try the flatpak version and see if it runs?

Hello, same error with the flatpak version

@jef66 , got it working on a fresh Rocky 9.4 install, with Dbeaver 24.1.0. Could you try upgrading your Rocky to 9.4?

I resintall the server with rocky 9.4 and still have the issue. Do you have installed any additionnal package or just the RPM ?
Is that possible to have the list of RPM package from your instance to check if I miss something ?
Thx

I've installed Java 21 (java-21-openjdk), and then the Dbeaver RPM. You'll find atached all my installed packages (dnf list installed).
installed-packages.txt

Unfortunately, after upgrading to Eclipse 2024-06, seems that this OS are no longer supported, along with Windows 7, 8, macOS 10, and Windows Server 2012 and some unix OSes. This issue is not on DBeaver side, you can see the details here: https://github.com/eclipse-platform/eclipse.platform.swt/issues/1252.

@E1izabeth The page you're referencing explicitly says that RHEL 9 is supported. Rocky Linux is bug-to-bug compatible with RHEL. It must be a different issue.

This error can happen for different reasons. For example, you'll see the same error if you install the latest Ubuntu on WSL2 and try to launch DBevaer there without installing any additional packages. That's because Ubuntu on WSL comes without libgtk. Installing something like Nautilus fixes the issue there.
I have a gut feeling the issue can be resolved by installing some additional packages.

But what's really odd is that the Flatpak version doesn't work either.

I installed Rocky 9.4 aarch64 using Boot ISO, installed java 17 with sudo dnf install java-17-openjdk, and everything worked fine.

@jef66 Can you confirm that you use java-17-openjdk and not java-17-openjdk-headless?

Hello, I tried on a fresh Rocky9.4 on my sandbox and it works.
Try again in my enterprise and failed.
Tried with the tarball without Java included, then dnf install java-17-openjdk and it works !
Maybe be something on my server is blocking the loading of the library, I don't know, I will investigate.
Thx for your help !

@jef66 I'm glad to hear that!
I suspect that some dependency of java-17-openjdk is a hard requirement for DBeaver, and it's not installed on your enterprise machine.


Missing header files in j2objc 2.3 JRE.framework (android/icu/text/UForwardCharacterIterator.h)

Hi,
we upgraded to j2objc 2.3. After clean recompile of our project we got compilation error related new support of Android ICU. It looks like, that some referenced header files are not included in JRE.framework. We are using precompiled zip file downloaded from j2objc site.

But there is no UForwardCharacterIterator.h in JRE.framework in android/icu/text/UForwardCharacterIterator.h.
Thanks,
Jindrich

Hi,
I see, this class is hidden in the Android ICU version:
https://android.googlesource.com/platform/external/icu/+/oreo-release/android_icu4j/src/main/java/android/icu/text/UForwardCharacterIterator.java#58
But in our case, we should expose the header file because UCharacterIterator implements UForwardCharacterIterator.
In case I am missing something, your project should be using this new functionality somehow, maybe through a java.time class? Could you share the list (stack) of include files that lead to UCharacterIterator?
Thanks,
Antonio.

Hi,
I don't use any new functionality, but this happen when nothing more but using framework JRE provided by j2ObjC distribution:
@import JRE;
This UCharacterIterator.h is in JRE.framework, not in my generated code. And it references to non-existing file in this framework.
Have a nice day,
Jindrich

Thanks for the additional details! I'll make sure the header is included in the next release. In the meantime, please copy the attached header (rename to .h)
UForwardCharacterIterator.txt
to the following locations inside the J2ObjC distribution folder:
include/android/icu/text/UForwardCharacterIterator.h
frameworks/JRE.framework/Versions/A/Headers/android/icu/text/UForwardCharacterIterator.h


Aptos ZKFP Example

Summary
Proposing merge for collaboration viz #36 .

We've discussed offline, but just commenting for completeness. I agree with the above. This is not intended to be merged in. It's just open for collaboration.

To take away from the same discussion, we should run this as a feature branch and sync with the mainline from time to time.


fix Fix test no_await

Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Can't find any way for Single selection.

Not an issue though
As per the documentation, there's an option for single selection.
But I'm not aware how to achieve that using in-built methods.
Can anyone help me here?

Please see the updated README

Please see the updated README


Thank you!

Hi,
I just wanted to say thank you for sharing your code and the pretrained weights. It's a super cool work! :)

Hi!
Thank you for the really nice comment, I highly appreciate it! Glad you like the work, do not hesitate to ask any questions related to the code o the paper.

Hi @alexlopezcifuentes,
Could you tell me what you used to draw the figure of the architecture?

Hi, sorry to disappoint you if you were expecting a fancy application but I just used PowerPoint for the drawings...

Ah, I see. It looks great! :o)
Thanks for the answer.


Added basic support for Atuin

Atuin is shell history on steriods and is commonly used as an enhancement of the existing shell history. Unlike Bash or Zsh, Atuin uses an SQLite database to store the command history.
The nice thing about this however is that this makes Atuin shell agnostic, so all we've done is add a basic check in the generic shell class to check to see if the user provided a path to the Atuin database. If so, then we check the database instead of the default location.
Right now this system has an issue where it'll reconnect to the database multiple times, which may cause performance issues. The point however is that this works, and that we can search the Atuin database.

Problem is that (as far as I know) Atuin doesn't provide a way to export commands to shell history

Ok turns out Atuin already exports to the shell history, I'll close this now


Initial integration test for starring topics

Closing this for now but let's hold onto the branch so this can be applied externally in a plugin.


Lost from ToC

This page is linked to from the soft delete docs, but it doesn't appear in the ToC. Is it replaced by something else, or did it just lose its ToC spot?
https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-soft-delete

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f8c3f68c-207a-8fec-4b05-bccb68b260a0
Version Independent ID: bb0fe645-097e-2cce-c639-852d0e1d159d
Content: Create a read-only snapshot of a blob in Azure Storage
Content Source: articles/storage/blobs/storage-blob-snapshots.md
Service: storage
Sub-service: blobs
GitHub Login: @tamram
Microsoft Alias: tamram

@dcbrown16 Thanks for your question. We are checking on this and will respond to you soon.

@dcbrown16 Can you please elaborate bit more on this topic?
Are you referring to Total Cost of Ownership (TCO) Calculator?

@SumanthMarigowda-MSFT no, the Table of Contents. Typically, active pages should show in the navigation menu on the left, for example this one should probably be under How-To somewhere.

@dcbrown16 Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@dcbrown16 - This is fixed now, thanks for your feedback.
#please-close


Update color scheme graphics

@gongjason
If you drag the image asset into a text field on Github a new issue, or new comment field), it will upload it and generate a markdown image with URL. That URL is valid indefinitely: You can then just copy-paste that into the README and we won't have to store the README assets in the repository.

@jamilbk assets uploaded to GH + removed them from the repo


There is no operation "Enter server credentials to connect 'xxx'" after expanding "postgres" node on another machine

OS: Win10
Build Version: 20240112.17
Regression: Previous release
Repro Steps:

Create a PostgreSQL Flexible server.
Expand the PostgreSQL Flexible server on another machine -> Expand "postgres" node.
Check whether there is an operation "Enter server credentials to connect 'xxx'".

Expect:
There is an operation "Enter server credentials to connect 'xxx'".

Actual:

There is no operation "Enter server credentials to connect 'xxx'".

Prompt to enter server credentials to connect 'xxx'.

More Info:
This issue doesn't reproduce for the PostgreSQL Single server.

I wasn't able to reproduce and I have zero idea how this could happen. The code for showing the warning and the code for showing the "enter credential node" are literally next to each other. If you can get a reproducing server, could you share it with me and let me try it?

We did some more investigation offline. The root cause is that our auto firewall configuration detects that the current IP is already included in the IP whitelist but still get an IP address blocked error. This can happen if the client is under an uncooperative NAT that uses different IP addresses to connect to database server.


Enforce exact matching for GitLab groups

fix #2922
Until now, GL groups were matched partially. This caused an issue in the following case:

In a new instance with only subgroup repos enabled
Enable a non-subgroup repo
Partial match for the first owner/subgroup of the existing orgs
Attempt to (re)create owner/subgroup although it already exists -> error

By enforcing an exact match, the query returns nil for a non-existing top-level group and will attempt to (correctly) create a new WP org for it, letting the overall repo add operation succeed.
Fix has already been tested to work.
I don't think there should be any potential downsides when switching to exact matching.
Besides, I also updated the error message wording I encountered.
Should be backported.

that should be backported, wana do it or should I cherry pick?


Update the CUDA implementation of CudaLuDecomposition with the CUDA matrix class

This PR updates the input type for the CUDA implementation of LuDecompose function with the CudaSparseMatrix class.
All the 42 tests all passed on Derecho's A100 GPU by using nvhpc/23.7.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.36%. Comparing base (fe471cb) to head (74a0cf7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   94.36%   94.36%
=======================================
  Files          38       38
  Lines        3126     3126
=======================================
  Hits         2950     2950
  Misses        176      176

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Standardize readme

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: djones6:white_check_mark: helenmasters:x: Travis CI UserTravis CI User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add generated props files to CI artifacts

These are useful for debugging CI builds.  e.g. PackageVersions.props, RestoreSources.props, git-info folder, HostInformation.props, TargetInformation.props.

@oleksandr-didyk - capturing the PackageVersions.props would solve the prebuilt UX issue we discussed earlier about how to easily find which packages and versions are produced by source-build.

@MichaelSimons thanks, makes sense. Should this issue have higher priority and be implemented after the docs are finished?


[DO NOT MERGE] Run Python RC Validation Tests

Run Python ReleaseCandidate

Run Python ReleaseCandidate

2.36.0 release is complete. Closing this. Thank you Emily.

Run Python ReleaseCandidate

Run Python ReleaseCandidate


Update NGSI Go to 0.11.0

Proposed changes
This PR updates NGSI Go to 0.11.0.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[ ] I have updated the change log (CHANGELOG.md)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Codecov Report

:exclamation: No coverage uploaded for pull request base (v0.10.0-next@27232ef). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             v0.10.0-next      #140   +/-   ##
================================================
  Coverage                ?   100.00%
================================================
  Files                   ?         2
  Lines                   ?      1597
  Branches                ?         0
================================================
  Hits                    ?      1597
  Misses                  ?         0
  Partials                ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27232ef...1ea84e7. Read the comment docs.


Reintroduce ConfigTest#testValidTemplateConfig

As it tests valid check operation. Removed as a part of #127.

Sorry for that i will take that one when I finish issue https://github.com/jboss/tyr/issues/120


Fixed a spelling mistake

Nice work on this add-on, I may be using it for a client here soon! :+1:

awesome! thx for the pr :-)

It's hard for PRs to get any smaller ;-)


Removed "downloaded" from phrase "downloaded loaded"

I was momentarily confused by the wording. Hopefully this wording is now clearer.

Lol!


[ECard Transactions] Design - Get Assets for eReceipts

Assets Needed
We need:

[ ] eReceipt background SVG in all colorways
-
-

OR Is it possible to set up the SVG so the background image uses the fill and we can set the background color with backgroundColor? I think we would need it to look like the workspace avatars:

note: I did this myself originally, so I may be able to do this again!

[ ]  All 12 New MCC Icons

[ ]  The receipt icon

Yo @grgia! I tried to do some wacky SVG stuff to make it to where the background pattern/image did not include a background so that we can set the background color on the eReceipt itself. Hopefully it will work out the way we want it to, but if not let me know and we'll adjust.
This ZIP contains everything you mentioned in the assets needed, but let me know if you need anything else or if something doesn't seem right.
eReceipt SVGs.zip
Also since we're going to try to set the background colors outside these SVGs, here they are for reference:
eReceipt Background Colors:

Purple: Purple 800
Ice: Blue 800
Orange/Tangerine: Tangerine 800
Gold: Yellow 600
Green: Green 800
Blue: Blue 400

@dannymcclain I think we're just missing the Utilities MCC icon!
Going to test the background svgs now, I'll update if we're good to go there

Oops @dannymcclain I lied, it was totally in there.


Wrong JDK ???

What version JDK  isrequired for the build ?
[warn] use -help for a list of possible options.
[error] javac: invalid source release: 1.8
[warn] javac exited with exit code 2
[error] (Compile / compileIncremental) javac returned non-zero exit code
[error] Total time: 55 s, completed Oct 5, 2018 12:02:36 AM
Thanks !

Did you figure this out and that’s why you closed the issue?
In any case Java 8 is the correct JDK.

Oh I see, I’m guessing the issues was resolved in #907

Yeah, I had the correct JDK, but installed an older jdk-development kit by accient ...
Sorry about this ;)

No worries! Glad you were able to solve the issue!


Nillable() method not available on jsonBuilder for JSON fields

ent version:  v0.13.1
What did you do?
I attempted to define a JSON field with Nillable() in my schema:
field.JSON("selected_dates", [][]string{}).     Optional().     Nillable()
What did you expect to see?
I expected Ent to allow Nillable() on this JSON field so that null values could be stored in the database and my generated Go field would be a pointer type (allowing it to be nil).
What did you see instead?
I received the following compiler error:
field.JSON("selectedDates", [][]string{}).Optional().Nillable undefined (type *"entgo.io/ent/schema/field".jsonBuilder has no field or method Nillable)
My Aim
Store value like that in the db
[["2021-01-01", "2021-01-10"],["2021-02-01", "2021-02-15"]]
Thank you for your help!

JSON fields inherently support null values, so there’s no need to mark them as nullable.


In One Light/Dark UI Theme Tab Icon and File Name are Overlapping

Hi,
In One Light/Dark UI theme tab icons and file names are overlaping in tab. How do I fix this issue?
Also could this be related to the "file icons" package? I have added and removed this package before?
Plus, I've runned the Atom with safe mode. At the result there are no icons on tabs: https://cl.ly/koEp
How it could be? I've uninstalled the File Icons package already.
[Atom 1.17.2 + One Light UI 1.10.3]

tab icons and file names are overlaping in tab.

Could you post a screenshot? With file-icons installed, it should look like this:

It's working well with File Icons package. Screenshot: https://cl.ly/kosQ

Hmm.. I don't see any overlapping in that screenshot? Do you mean the problem is fixed?

But I don't want to use File Icons package. If I uninstall the File Icons package, tab text and tab icons become overlapping (which I mentioned first comment of this issue).

Sorry, I understand now:

With file-icons it looks ok
With safe mode it looks ok, it has no icons

This can only mean that another package adds icons that look overlapped. Do you have any other packages installed that might add icons?
If you run the apm list command, it should show a list of all your Atom packages.

Sorry, I understand now:

With file-icons it looks ok
With safe mode it looks ok, it has no icons

Exactly.

This can only mean that another package adds icons that look overlapped. Do you have any other packages installed that might add icons?

I didn't installed anything else File Icons package for customizing icons or tabs.

If you run the apm list command, it should show a list of all your Atom packages.

    I can reproduce by installing pinned-tabs and the overlapping icon goes away once I disable it.  If you can confirm, I'd recommend opening an issue in the project's issue tracker: https://github.com/ericcornelissen/pinned-tabs-for-atom.
For future reference, if things work in safe mode, one approach is to disable all community packages and enable them one-by-one to find the one causing the issue.  But I went ahead and did a quick scan of your community packages to see if anything seemed related to icons or tabs which made me take a look at pinned-tabs.
I'll go ahead and close this for now but let us know if disabling pinned-tabs doesn't resolve things for you :v:

@rsese Yes, I can reproduce it with pinned-tabs too. Thanks for finding the pin in the haystack. :grin:

Thank you guys for your interests. I can confirm that problem related with pinned-tabs package and writed a new issue under Pinned Tabs package repo.


keep display off -S command now works, but, on wake up, device screen resumes playback

I used the turn display off function, now it works correctly on my phone, only problem is that, on device wake up after sleep, The device screen starts woking again.

See #735

Can we add adb shell svc power .. functionality. I saw it in one of the stackoverflow questions, and in one of the issues.
I can easily implement it in guiscrcpy by starting a subprocess in Python, but I checked your code and I thought of adding a pull request, but seems like I have no idea of C. I don't even know how to compile it..

Can we add adb shell svc power

https://github.com/Genymobile/scrcpy/issues/631#issuecomment-622621215


Front-end Set-up

Front-end Setup

Initialize repository
Setup node dependencies (redux toolkit, react-dom-router, Axios, SCSS & CSS, createThunk, font-awesome.)
Add linters
-Edit README file

🟢 STATUS: APPROVED 🟢
Hello @franclobo, @Draxeytina, @fibini 👋,
Your project is complete! You followed all the requirements, feel free to merge it! 😄
Congratulations! 🎉

Highlights
✔ React & Redux correctly set up.
✔ No linter errors.
✔ Added node dependencies. Well done!
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


The JSON string is invalid for CFPaymentsEntityMethod with oneOf schemas

I am trying to get payments for an order as follow:
    @SneakyThrows
    public List<CFPaymentsEntity> getPaymentDetails(String orderId) {

        ApiResponse<List<CFPaymentsEntity>> payments = cfPaymentGatewayService.getAllPayments(cfConfig, CFHeaders.builder().build(), orderId);
        if (payments.getStatusCode() != 200) {
            throw PaymentServiceException.create(ResponseCode.PAYMENT_GATEWAY_ERROR);
        }

        return payments.getData();
    }

But failing with following error
ERROR [2023-04-16 18:13:48,302] io.dropwizard.jersey.errors.LoggingExceptionMapper: Error handling a request: ef1d9d7910353068
! java.io.IOException: The JSON string is invalid for CFPaymentsEntityMethod with oneOf schemas: CFPaymentsEntityAppPayment, CFPaymentsEntityCardPayment, CFPaymentsEntityCardlessEMIPayment, CFPaymentsEntityNetbankingPayment, CFPaymentsEntityPaylaterPayment, CFPaymentsEntityUPIPayment. 0 class(es) match the result, expected 1. Detailed failure message for oneOf schemas: [Deserialization for CFPaymentsEntityAppPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityAppPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityCardPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityCardPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityCardlessEMIPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityCardlessEMIPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityNetbankingPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityNetbankingPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityPaylaterPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityPaylaterPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityUPIPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityUPIPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`.].  Causing: com.google.gson.JsonSyntaxException: java.io.IOException: The JSON string is invalid for CFPaymentsEntityMethod with oneOf schemas: CFPaymentsEntityAppPayment, CFPaymentsEntityCardPayment, CFPaymentsEntityCardlessEMIPayment, CFPaymentsEntityNetbankingPayment, CFPaymentsEntityPaylaterPayment, CFPaymentsEntityUPIPayment. 0 class(es) match the result, expected 1. Detailed failure message for oneOf schemas: [Deserialization for CFPaymentsEntityAppPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityAppPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityCardPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityCardPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityCardlessEMIPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityCardlessEMIPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityNetbankingPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityNetbankingPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityPaylaterPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityPaylaterPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`., Deserialization for CFPaymentsEntityUPIPayment failed with `The field `others` in the JSON string is not defined in the `CFPaymentsEntityUPIPayment` properties. JSON: {"others":{"card_number":"XXXXXXilure@gocash","card_country":"","card_network":null,"payment_mode":"UPI_CREDIT_CARD","bank_number":null,"upi_id":null,"bank_account":""}}`.].


Question about loss function and Hungarian part

Good morning,
I am recoding your work using pytorch to use it as a baseline in my work. I am at the end of the loss part trying to implement the Hugarian function. I am trying my code with a simple toy example with a maximum number of predicted bounding boxes of 10 and a groundtruth of 5 bounding boxes and pass to the Hungarian function a cost matrix of shape (H*T) where H is the number of predicted BB and T the number of boxes in the ground truth. However in the following part :
unmapped = num_instances - ins_count
if unmapped > 0:
   rest = np.array(range(ins_count, num_instances))
   row_ind = np.concatenate([row_ind, rest])
   unmapped_ind = np.array(list(set(range(num_instances)) - set(col_ind)))
   col_ind = np.concatenate([col_ind, unmapped_ind])

col_ind and row_ind are transformed to 10 of length arrays and on the line :
loss_total += cost[idx][row_ind, col_ind].sum()
I get out of bound error as cost is a (105) matrix and not (1010).
Am I missing something?
Yours faithfully
J

Hi @lelouedec, the released code only deals with the case where the number of pred bbox is equal to the number of gt bbox. It's easy to slightly modify it to deal with your case.
def hungarian(loss_matrix, bb_gt):
    box_mask = np.array([[0, 0, 0], [0, 0, 0]])

    def assign_mappings_valid_only(cost, gt_boxes):
        # return ordering : batch_size x num_instances
        cost_total = 0.
        batch_size, num_instances_gt, num_instances_pred = cost.shape[:3]
        ordering_4_pred = np.zeros(shape=[batch_size, num_instances_pred]).astype(np.int32)
        ordering_4_gt = np.zeros(shape=[batch_size, num_instances_gt]).astype(np.int32)
        for idx in range(batch_size):
            ins_gt_boxes = gt_boxes[idx]
            ins_num_gt_valid = 0
            for box in ins_gt_boxes:
                if np.array_equal(box, box_mask):
                    break
                else:
                    ins_num_gt_valid += 1
            valid_cost = cost[idx][:ins_num_gt_valid]
            row_ind, col_ind = linear_sum_assignment(valid_cost)

            ## ins_gt order
            unmapped_ind_gt = np.array(list(set(range(num_instances_gt)) - set(row_ind)))
            row_ind_gt = np.concatenate([row_ind, unmapped_ind_gt])

            ## ins_pred order
            if num_instances_pred - ins_num_gt_valid > 0:
                unmapped_ind_pred = np.array(list(set(range(num_instances_pred)) - set(col_ind)))
                col_ind_pred = np.concatenate([col_ind, unmapped_ind_pred])
            else:
                col_ind_pred = col_ind

            cost_total += cost[idx][row_ind, col_ind].mean()
            ordering_4_pred[idx] = np.reshape(col_ind_pred, [1, -1])
            ordering_4_gt[idx] = np.reshape(row_ind_gt, [1, -1])

        return ordering_4_pred, (cost_total/float(batch_size)).astype(np.float32)

    ######
    ordering_4_pred, cost_min = tf.py_func(assign_mappings_valid_only, [loss_matrix, bb_gt], [tf.int32, tf.float32])

    return ordering_4_pred, cost_min

ohh so it makes sense after all, as I had to modify the code at one or two other places to make it work for a different number of bounding boxes in ground truth and prediction.
Thanks a lot for this answer

I get stuck (again) in the loss part, where you have :
 ##### 1. get ce loss of valid/positive bboxes, don't count the ce_loss of invalid/negative bboxes
        Y_bbox_helper_tp1 = tf.tile(Y_bbox_helper[:, :, None], [1, 1, points_num])
        bbox_loss_ce_all = -points_in_gt_bbox_prob * tf.log(points_in_pred_bbox_prob + 1e-8) \
                       -(1.-points_in_gt_bbox_prob)*tf.log(1.-points_in_pred_bbox_prob + 1e-8)
        bbox_loss_ce_pos = tf.reduce_sum(bbox_loss_ce_all*Y_bbox_helper_tp1)/tf.reduce_sum(Y_bbox_helper_tp1)
        bbox_loss_ce = bbox_loss_ce_pos

as points_in_gt_bbox_prob and points_in_pred_bbox_prob are no the same shape, hence cannot be broadcasted together.
Shall I change their shape and tile them to have them B,T,H,nbpoints ? where T is the number of boxes in ground truth and H the predicted ?

@lelouedec in your case where the number of gt bbox(T) is less than pred bbox(H), you need to use "the matched top T bbox" from the pred bbox to caculate loss, instead of using all H pred bbox to compute loss.

Good morning,
I followed your instructions and used the matched T boxes. However, even if Pointnet semantic segmentation algorithm is converging an output a segmentation mask close to reality the bounding boxes regression is never converging. I  tried using all the different criteria (l2 only, ce etc.. ) but no luck. Any idea?
I haven't made many changes to the code other than what you proposed.

Hi @lelouedec, according to ur code,  u already made "significant" changes.  Your approach is to sort all predictions based on the predicted bbox scores, while our network is to sort all predictions based on the optimal assignment.

Good evening,
I ended up going back to your code and revert my changes, but I still can't
achieve the behavior from the paper where the number of ground truth
bounding boxes is different from the number of predicted ones as it is not
possible to know how many objects there might be in the scene.
Do you plan on releasing the code achieving the paper performances and
behavior ?
Having a version of your code running in pytorch could be beneficial and I
would be very thankful if I could use your work as a baseline on our
dataset.
On Mon, 30 Sep 2019, 20:26 Bo Yang<EMAIL_ADDRESS>wrote:

Hi @lelouedec https://github.com/lelouedec, according to ur code, u
already made "significant" changes. Your approach is to sort all
predictions based on the predicted bbox scores, while our network is to
sort all predictions based on the optimal assignment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Yang7879/3D-BoNet/issues/11?email_source=notifications&email_token=AD235FMSKBMT2IHJNRUDN53QMJHIBA5CNFSM4I2YL7R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76Z3PQ#issuecomment-536714686,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD235FJFGDME62NPK5GMRA3QMJHIBANCNFSM4I2YL7RQ
.

Hi @lelouedec , essentially, the released code deals with the cases where the real number of gt bbox is not equal to that of pred bbox. To be specific, in data processing, all gt data are zero-padded to be a same number of bbox (T), but in loss cacluation, those zero-padded bbox are not counted. This implementation allows the batch-size to be more than 1 during training.
Unforturnately, I can only explain the logics of the our algorithm, but unable to implement a pytorch version.

Ok now I understand how you go up until the loss computation by zero
padding the gt bounding boxes. However I am not sure to get where in the
code of the loss function you get rid of these zero padding and keep the
H-T boxes only (How you wrote it in the paper )
On Mon, 30 Sep 2019, 22:01 Bo Yang<EMAIL_ADDRESS>wrote:

Hi @lelouedec https://github.com/lelouedec , essentially, the released
code deals with the cases where the real number of gt bbox is not equal to
that of pred bbox. To be specific, in data processing, all gt data are
zero-padded to be a same number of bbox (T), but in loss cacluation, those
zero-padded bbox are not counted. This implementation allows the batch-size
to be more than 1 during training.
Unforturnately, I can only explain the logics of the our algorithm, but
unable to implement a pytorch version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Yang7879/3D-BoNet/issues/11?email_source=notifications&email_token=AD235FL6QXKOGLWZSDJBSODQMJSKHA5CNFSM4I2YL7R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD77CVYI#issuecomment-536750817,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD235FIZQ3VWZVLV5QBMHCLQMJSKHANCNFSM4I2YL7RQ
.

@lelouedec  https://github.com/Yang7879/3D-BoNet/blob/07c99e58f7f1a646c211c150cb7b3c363fdd69d9/helper_net.py#L252

I understand a bit better now, still not sure why the bounding boxes regression is not converging at all even with a code nearly 100% similar to yours.
Here a compiled version of the pytorch implementation I did :
https://gist.github.com/lelouedec/5a7ba5547df5cef71b50ab306199623f
In case someone wants to have a look of needs it in the future.
The pointnet backbone works as I am using it on my dataset for semantic segmentation successfully.

hi @lelouedec Thanks for sharing. Will check it out once I finish my task at hand.


error from HTML pipeline while attempting to trunk serve "Getting Started: Web" guide

Problem
When I run the code specified in the Getting Started: Web documentation, I end up receiving an error after running trunk serve:
   Compiling demo v0.1.0 (/Users/edouard/Developer/learning-rust/demo)
    Finished dev [unoptimized + debuginfo] target(s) in 13.82s
2022-05-09T19:02:58.060709Z  INFO fetching cargo artifacts
2022-05-09T19:02:58.136215Z  INFO processing WASM for demo
2022-05-09T19:02:58.145251Z  INFO downloading wasm-bindgen version="0.2.80"
2022-05-09T19:02:58.145628Z ERROR ❌ error
error from HTML pipeline

Caused by:
    0: error from asset pipeline
    1: failed downloading release archive
    2: unsupported architecture
2022-05-09T19:02:58.147266Z  INFO 📡 serving static assets at -> /
2022-05-09T19:02:58.147321Z  INFO 📡 server listening at http://<IP_ADDRESS>:8080
2022-05-09T19:02:58.147608Z  INFO 📦 starting build
2022-05-09T19:02:58.147744Z  INFO spawning asset pipelines
2022-05-09T19:02:58.213682Z  INFO building demo
    Finished dev [unoptimized + debuginfo] target(s) in 0.02s
2022-05-09T19:02:58.284775Z  INFO fetching cargo artifacts
2022-05-09T19:02:58.358736Z  INFO processing WASM for demo
2022-05-09T19:02:58.365568Z  INFO downloading wasm-bindgen version="0.2.80"
2022-05-09T19:02:58.365883Z ERROR ❌ error
error from HTML pipeline

Caused by:
    0: error from asset pipeline
    1: failed downloading release archive
    2: unsupported architecture

Steps To Reproduce
Steps to reproduce the behavior:

Navigate to this Dioxus walkthrough
Follow all of the steps listed
Run trunk serve where indicated
If you receive the build error above, you're seeing what I'm seeing

Expected behavior
I expected this tutorial/getting started documentation to resolve to a working example.
Screenshots

Environment:

Dioxus version: { version = "0.2.4", features = ["web"] }
Rust version: rustup 1.24.3 (ce5817a94 2021-05-31)
OS info: MacBook Pro (14-inch, 2021) – Apple M1 Max – macOS Monterey – 12.3.1 (21E258)
App platform: web

OK so after digging around Trunk's github, I uncovered an issue with trunk in which wasm-bindgen-cli isn't correctly being set up by trunk.
I've solved my own issue by manually installing wasm-bindgen-cli per these instructions:
cargo install -f wasm-bindgen-cl


width/height/font errors in console

Noticed some of these are related to knobs, some are related to contextmenu.

Found and fixed another one of these.


Feature/issue 735

The collection of invalid block header hashes has been separated from ChainState into its own class. The store of hashes now has a capacity of 1000 entries and once this is reached, oldest entries are removed. This eliminates the attack vector described in #735.
Tests are included.
Fix #735

i've just merged the latest master to this branch to see if i can get green build

ok, i've confirmed that my issue had nothing to do with this PR and can be seen with master, so this is unreleated


Improve Compose

Add picker for different compose options
Improve text compose, multiline, autoresize, better button
Add image picker from camera roll
Add MessageFormattingHelp component

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


require #[pyclass] to be Sync

For #4265
A brief attempt to add a compile error to require #[pyclass] values to be Sync. I allow this constraint to be opted-out with the existing #[pyclass(unsendable)] option.
Mostly here I've focused on implementing the compile error with a reasonable diagnostic, I think there's a lot of documentation to add too.

I rebased this and am looking at resolving the test failures.
The first thing I hit was test_getter_setter::cell_getter_setter, which is mostly testing that IntoPyObject for Cell<i32> works correctly. I think in order to get to a similar level of ergonomics for atomics and mutexes, we'll need to add IntoPyObject<py>impls for all the atomic types and maybe forMutexandRWLock`?
Let me know if anyone thinks alternate approaches would be better.

Although that said, this might also be a separate issue:
error[E0277]: the trait bound `AtomicI32: PyFunctionArgument<'_, '_>` is not satisfied
   --> tests/test_getter_setter.rs:219:1
    |
219 | #[pyclass]
    | ^^^^^^^^^^ the trait `Clone` is not implemented for `AtomicI32`, which is required by `AtomicI32: PyFunctionArgument<'_, '_>`

The latest push switches members that use Cell for interior mutability or have Box members to atomics and mutexes. Now the only remaining issue with the cargo tests is the problems raised by test_getter_setter described above.

If I add an IntoPyObject impl for AtomicI32 I still get the error about a missing Clone impl. However based on this answer to a similar question, I'm now thinking that the real issue is the generated get and set methods should be taking references to the inner value. I'm currently trying to understand how the get and set descriptors actually get set up inside the pyo3 proc macro, but it's pretty complicated.

This ultimately comes down to the implementation of the PyClassGetterGenerator class. It delegates in this case to a function called pyo3_get_value_into_pyobject which has a Clone bound on the FieldT parameter. Since atomics aren't Clone, this leads to the compilation error I'm seeing.
I think a way forward is to expand this machinery to recognize fields that are atomics (maybe via a macro to generate all the necessary code for each atomic type?).
I'm going to stop here because this is getting pretty far afield and someone with more rust expertise might be able to give an alternate path forward.

Can you try implementing IntoPyObject for &AtomicI32? I think this should fix the error. #4449 has the list of priorities for pyo3(get).

I think the problem will be what kind of atomic ordering should we use? I guess Relaxed might be enough here.

Can you try implementing IntoPyObject for &AtomicI32

I tried adding impls for both and am still getting the same error, see last push. I get the same error if I do the impl for either of or both &AtomicI32 and Atomic32.

I get the same error if I do the impl for either of or both &AtomicI32 and Atomic32.

Actually this is not the same error. We fixed the issue in the GetterGenerator but now there's a different issue in the argument extraction.

Actually, I had a better idea; let's not worry about atomics in this PR and instead just add unsendable designator to this class for now.

I think there is copy that needs to be added to the migration guide and also maybe class.md where we talk about Send, we should probably now also talk about Sync. I can try to have a push at getting the docs done tonight.

Thanks for taking this on! I added a WIP changelog entry that should link to this.

Woohoo, tests are green! Just needs docs I think. I may try to write something if David doesn't get to it.

Is there a way to reduce that?

I think the most straightforward way to get a shorter error message is to mark the pyclass itself with on_unimplemented for Sync. But according to the RFC for diagnostic::on_unimplemented adding this on types is a "future possibility", and I don't think it's not currently possible right now.
Maybe it's possible to refactor this so that there's a little less indirection though and maybe get rid of one of the frames in the error message? I don't immediately see how.

I tried refactoring this to avoid the long error and couldn't figure it out. I hoped that if I made PyClassSync have a blanket impl for Sync that I might be able to generate the diagnostic but it looks like the compiler ignores PyClassSync in that case, so the default generics trickery used here or something like it does seem to be necessary to get on_unimplemented to trigger.

I think the big to-do here is docs. @davidhewitt would you like me to take a look at that sometime this week or do you still want to take a crack at it yourself?

I hope to make various progress on release prep & final pass over docs tomorrow, but feel free to push here if you have time.
Otherwise maybe I'll merge this PR as is and we can have one or more docs follow ups to round off the release 😁


Reference links are rendered with the note title in V2

Please select the area your Bug applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[ ] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[x] Publish. Sharing your repo with the world
[x] Misc (Choose this if your not sure)

Describe the bug
A reference link is always rendered with a note title in V2 preview/publishing; in V1, the note title is omitted.
To Reproduce
Steps to reproduce the behavior:

Create a reference link
Preview in V1 and V2
Compare how the reference is rendered.

Expected behavior
The note title (#) shouldn't be rendered as in V1.
Screenshots
V1 (https://wiki.dendron.so/notes/f1af56bb-db27-47ae-8406-61a98de6c78c.html#commands)

V2 (https://wiki-next.dendron.so/notes/f1af56bb-db27-47ae-8406-61a98de6c78c/#commands)

Desktop (please complete the following information)

Version 0.55.1

Additional context
Also, the "From" value in V2 uses the note's filename, while in V1 it's the note's title. ("From Commands" vs "From dendron.topic.commands").

Timely ticket. we are fixing this in the v56 release which is coming out now :)

let me know if this is still an issue after 0.56, otherwise this issue will autoclose in 3 days


How to optionally provide an implementation?

Is there a way for a HAL (or similar) to provide a critical-section by default, with the option to disable it if needed?
This would be the most user friendly behavior I can currently think of:

the HAL crate should provide an implementation by default, so users just need to depend on the HAL to have the implementation activated. (A HAL usually knows the hardware and therefore knows quite well what critical-section implementation would be safe.)
an optional feature custom-impl would disable that default impl. That way, in some special cases, a user might provide an own implementation, eg. if the target is multicore, but the firmware only uses a single core, so a complex and expensive critical-section could be replaced by just disabling interrupts

However, this doesn't work: To be able to implement the critical section, the HAL would need to select on of the restore-state-* features of critical-section. It is not possible to disable that feature when custom-impl is selected. Cargo just provides no way to say "enable this feature of a dependency only if this other dependency is not enabled" (or does it, somehow?).
The second best approach would be:

the HAL crate should provide an implementation if a default-enabled feature provide-critical-section-impl is selected, so users still just need to depend on the HAL to have the implementation activated.
to be able to provide a custom impl, the dependency on the HAL would need to be declared with default-features = false.

This would work, but not well: It's not uncommon that several crates in the dependency tree depend on the HAL. If only one of those forgets to set default-features = false, the implementation is included. So a user who wants to provide a custom impl would not only need to add default-features = false in one dependency, but might have to hunt down unintended activation of the feature via indirect dependencies.
The remaining option is to just not provide the impl by default, but require a feature to be activated manually. So every binary (but not libraries!) depending on the HAL would need to add features = [ "provide-critical-section-impl" ].
Did I miss any other options? Which approach would meet the intentions of the critical-section authors?

I'd say the sanest option is the last one, yes. For all crates that provide an impl, always feature-gate it behind a critical-section-* Cargo feature, and not enable it by default.

For rp2040, we implemented it this way:

rp2040-hal provides the implementation, feature-gated by the non-default feature critical-section-impl
the BSPs also have a feature with that name, and forward it to the HAL: critical-section-impl = ["rp2040-hal/critical-section-impl"]

for the BSPs, this feature is default-enabled. The idea is that it's highly unlikely for any crate but the top-level binary to depend on a BSP, so it's easy to disable the default-feature in case it is needed.

That way, we hope to combine good usability for the common case with easy customization for unusual setups.


Add Laragon to Developer Tools

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX - n/a

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


[Panic] new cache code causing panic in 0.0.273

Running RUST_BACKTRACE=full ruff <file> on 0.0.273 resulted in this output:

error: `ruff` crashed. This indicates a bug in `ruff`. If you could open an issue at:

https://github.com/astral-sh/ruff/issues/new?title=%5BPanic%5D

quoting the executed command, along with the relevant file contents and `pyproject.toml` settings, we'd be very appreciative!

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', crates/ruff_cli/src/commands/run.rs:112:65
stack backtrace:
   0:        0x102bd4718 - _rust_eh_personality
   1:        0x10260fc84 - _main
   2:        0x102baf69c - _rust_eh_personality
   3:        0x102bd6108 - _rust_eh_personality
   4:        0x102bd5d48 - _rust_eh_personality
   5:        0x102bd5a8c - _rust_eh_personality
   6:        0x102a7d280 - _main
   7:        0x102bd6a30 - _rust_eh_personality
   8:        0x102bd67f0 - _rust_eh_personality
   9:        0x102bd6784 - _rust_eh_personality
  10:        0x102bd6778 - _rust_eh_personality
  11:        0x102c5093c - __rjem_je_witnesses_cleanup
  12:        0x102c509dc - __rjem_je_witnesses_cleanup
  13:        0x102a66e84 - _main
  14:        0x102a50cf0 - _main
  15:        0x102a2e424 - _main
  16:        0x102a26708 - _main
  17:        0x102591038 - __mh_execute_header
  18:        0x10258d788 - __mh_execute_header
  19:        0x102592328 - _main

My .ruff_cache looks like this:
$ tree .ruff_cache
.ruff_cache
├── CACHEDIR.TAG
└── content

2 directories, 1 file
$ cat .ruff_cache/CACHEDIR.TAG
Signature: 8a477f597d28d172789f06886806bc55

Unfortunately I cannot provide the file that triggered this. This was run in a project without ruff configured, although it does have a pyproject.toml. This happens using the --isolated flag as well. Running on AArch64 macOS.
Here is the code snippet:
https://github.com/astral-sh/ruff/blob/fde5dbc9aa967b086347f87fc61511c8dfe7ad0e/crates/ruff_cli/src/commands/run.rs#L109-L112
Last modified in 17f1ecd56e376a75d66e01be47029f1b1b29c0aa.

Looks like #5225 was created while I wrote this, seems to be the same issue

Sorry, yeah, I'll cut a fix for this tonight. I'm just trying to reproduce first.


Is there a way can config editor to support @arangodb module?

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[x] 3.3

Foxx
For now when we write foxx, use the require('@arangodb') but can not get any IntelliSense provided by many nowadays editors like when we use other npm modules. I have to check the manual again & again to see what methods are this module provide. Wished there is a better experience to write foxx services.

If your editor supports TypeScript, you can add @types/arangodb to your node modules, which defines TypeScript interfaces for the most common ArangoDB modules when working with Foxx.

I'm closing this as answered for now since it's been over two years since the question was asked but feel free to reopen this issue if you need additional information or would like to expand your question.


Stack overflow getting result iterator in Arrow backend

@marin-ma please review, thx

Verified. Thanks!


Can't pickle array_namespace

Describe your issue.
I'm experimenting with working in a certain multiprocessing context. I have an object in which I'd like to store an array namespace. However, array namespaces don't appear to be pickleable, which prevents my object being serialised to a pickle. I can work around this, but the workaround will require a large volume of calls to array_namespace.

is there another way of storing the array_namespace which is pickleable?
OR
can the namespace be altered to permit this kind of serialisation?

Reproducing Code Example
import numpy as np
from scipy._lib._array_api import array_namespace
import pickle

x0 = np.array([1., 2, 3])
xp = array_namespace(x0)
pkl = pickle.dumps(xp)

Error message
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[5], line 7
      5 x0 = np.array([1., 2, 3])
      6 xp = array_namespace(x0)
----> 7 pkl = pickle.dumps(xp)

TypeError: cannot pickle 'module' object

SciPy/NumPy/Python version and system information
HEAD

Seems to be propagating from upstream:
In [1]: import torch

In [2]: import pickle

In [3]: import numpy as np

In [4]: pickle.dumps(np)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[4], line 1
----> 1 pickle.dumps(np)

TypeError: cannot pickle 'module' object

In [5]: pickle.dumps(torch)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[5], line 1
----> 1 pickle.dumps(torch)

TypeError: cannot pickle 'module' object

Googling around seems to indicate it's a known problem, which dill works around. But that doesn't have multiprocessing, I suppose.

pathos is a fork of multiprocessing that works with dill, I have had success with it previously

Background is that I'm investigating making the internals of some optimise functionality parallelisable. The majority of people would use multiprocessing so classes and functions need to be pickleable.

You can't pickle modules so far as I know. But you can write a write custom pickle implementation on an object with __getstate__ and __setstate__, which could serialize xp with a string or something.

Question after a quick glance at gh-22119: I assume the problem is this line?
self.xp = xp = array_namespace(x0)

That's probably not ideal because of picking (even without introducing a workers= option) - passsing on xp in a functional fashion seems preferable. Can't it be propagated normally through function/method calls?

See #22141 for what I'm looking at. approx_derivative can be parallelised in a relatively straightforward manner. It's just that things to do with multiprocessing are fussy about pickling. A lot of the wrappers we use for calling the objective function aren't suitable. I prefer to use a class-based __call__ pattern that can make use of attributes that a function/method with more arguments.

Would it work to attach a namespace at unpickling time, in __setstate___ or some such?
Alternatively, maybe it's something for the Pool object to have and propagate to the workers?

If array_namespace is cheap, then I probably won't have to do anything. __setstate__, and functools.partial are probably good alternatives.


Terraform Provider Documentation not available anymore

The terraform provider documentation is not available here: https://registry.terraform.io/providers/dynatrace-oss/dynatrace/latest

Can you please check what's wrong?

Turns out ublock origin and ghostery block the access to the documentation


istioctl analyze - report success when no messages found

analyze currently only reports failures, making the output a bit questionable when no problems are found.  Can we add a success message?

The current version reports
✔ No validation issues found when analyzing all namespaces.

Does that mean this work is complete?


resolve test-related issue when running diffdock in container

this should be relatively easy to address
Precomputing and saving to cache SO(3) distribution table
Precomputing and saving to cache torus distribution table
100%|██████████| 201/201 [01:37<00:00,  2.07it/s]
100%|██████████| 201/201 [01:55<00:00,  1.75it/s]
/root/utils/torus.py:39: RuntimeWarning: invalid value encountered in divide
  score_ = grad(x, sigma[:, None], N=100) / p_
Reading molecules and generating local structures with RDKit (unless --keep_local_structures is turned on).
1it [00:00, 2113.00it/s]
Traceback (most recent call last):
  File "/opt/conda/envs/DiffDock/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/conda/envs/DiffDock/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/root/inference.py", line 81, in <module>
    test_dataset = PDBBind(transform=None, root='', protein_path_list=protein_path_list, ligand_descriptions=ligand_descriptions,
  File "/root/datasets/pdbbind.py", line 102, in __init__
    self.inference_preprocessing()
  File "/root/datasets/pdbbind.py", line 227, in inference_preprocessing
    if not os.path.exists(self.esm_embeddings_path): raise Exception('ESM embeddings path does not exist: ',self.esm_embeddings_path)
Exception: ('ESM embeddings path does not exist: ', 'data/esm2_output')
Failed to read molecule  /test/test.sdf  We are skipping it. The reason is the exception:  File error: Bad input file /test/test.sdf
Reading language model embeddings.

pushed a change to main that fixed the test path


Firefox 40+: this.callbacks is undefined

i'm getting a
TypeError: this.callbacks is undefined

error in recent simplewebrtc builds when using firefox.
This seems to come from https://github.com/HenrikJoreteg/wildemitter/blob/master/wildemitter.js#L98
but that looks ok?
Unfortunately, when trying to debug this, Firefox crashes.

@HenrikJoreteg @legastero?

ah... the constructor was called too late.

Could you please tell how does it happen?

@tgabi333 see https://github.com/HenrikJoreteg/SimpleWebRTC/commit/da54264b76b9cd59d48bdd3874b281ca2b47e77c -- in some cases the emtiter functionality was used before the constructor was called.

Thanks @fippo, but what cases exactly?


Add an isPrivateOk boolean to call intrinsics

Add a fourth argument to callWithBlock, callWithSplat and callWithSplatAndBlock that identifies whether or not the original send would be valid for a private method send. This mirrors the behavior of Send::isPrivateOk, but for the intrinsics that are proxying the real send.
Motivation

Pre-work for better handling of private methods.
Test plan

See included automated tests.

Let's add a test?

The exp files already caught the changes. I'm not sure how else to test this one.

This was a red herring for the bug I was working on. Closing, as it's not necessary.


QA CI failing on master branch

The action with the deployment to QA is failing on this commit, see here
Run ssh -i ~/.ssh/id_metriq $SSH_USER@$IP_ADDRESS ./GitHub/metriq-api/metriq-pull.sh
ssh: connect to host *** port 22: Connection timed out
Error: Process completed with exit code 255.

@nathanshammah @vprusso The deployment pipeline is on main branch, and I'm going to go ahead and test it there, since there's no other automatic live deployment, except QA. I'll check and clear any failed logs that expose secrets, (and you should, too,) but I don't expect any such problems.

The QA IP address is shown in the logs, but we only discourage users from visiting it, not forbid them. This issue ticket can be closed.


CI: Test with HYMLS on macOS

Closing since Trilinos on macOS seems to always become broken within a month.


Added cmake dependencies.

This adds VecCore and VecGeom as dependencies for the project. It adds also automatic recording and generation of a script to replay the last build command. The README file was updated.

Looks like the REUSE compliance check works properly, failed before adding the licence/copyright header :-)

Looks like the REUSE compliance check works properly, failed before adding the licence/copyright header :-)

As it should 😄


Unable to update Socially Tutorial to Angular4

The following Socially App Step19  _**https://github.com/cesargalindo/socially-step19-ang2.4.8**_ uses Angular 2.4.8 and Meteor <IP_ADDRESS> works fine.
I updated the app to Angular 4.0.1 by updating the npm modules in the package.json file.   After performing an npm install I get the warnings listed below.  Thinking these Meteor npm modules need to be updated?
WARNINGS
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

According to angular2-google-map forums, Google Maps stills works. However it's not an issue related to Meteor.

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

When I attempt to run meteor I get the following errors in the console.  There appears to be an issue with angular2-compilers?  A copy of the Angular4 Meteor app can be found here _**https://github.com/cesargalindo/socially-step19-ang4.0.1**_ I haven't investigated it further than this:

meteor

ERRORS
Unable to resolve some modules:

  "@angular/animations" in<EMAIL_ADDRESS>(web.browser)

If you notice problems related to these missing modules, consider running:

  meteor npm install --save @angular

server/imports/publications/parties.ts (2, 24): Cannot find module 'meteor/tmeasday:publish-counts'.
=> Errors prevented startup:

   While processing files with angular2-compilers (for target web.browser):
   /client/main.scss: Scss compiler error: File to import: {}/node_modules/@angular/material/core/theming/all-theme not found in file:
   /Users/cesargalindo/Downloads/SOCIALLY/socially-19b/{}/client/main.scss

=> Your application has errors. Waiting for file change.

Same issue here, it appears that angular2-meteor has a lock on 0.7.1. This causes not being able to update to angular 4 and also not being able to install ionic per tutorial since npm install ionic appears to be updated to ionic 3 which requires angular 4. Any plans to update the angular2-meteor package to align with angular 4?

While making the changes it would be good to bump to the latest angular2-meteor-polyfills which is now at 0.2.0 (though there wasn't a huge change from 0.1.1).

+1

+1

+1

+1

+1

+1

+1

+1

Since it looks like all standard packages are far ahead (@ angular is at 4.1.3, @ionic-native is at 3.9.2 and ionic-angular at 3.2.1) and I would like to follow at least ionic-angular quite closely I tried an update of a quite young meteor-angular2 project as well. Unfortunately without luck. After dropping angular2-google-maps and adjusting to the new @ionic-native naming convention things were still failing. For testing purpose I also remove all @ioinc-native parts but the app is even still failing on the browser with some "ERROR Error: No provider for ApplicationInitStatus!" in the modules.js.
This probably could be troubleshooted further but for someone without meteor-angular2 package insights this is tedious.
So maybe someone with those insight (or @Urigo ) could shed some light on the current problematic that causes the incompatibility. Is it even related to meteor-rxjs or angular2-compilers? And if so where lies the problem? I'd really love to stick with the meteor-angular2 packages but if following upstream updates is very complex and therefore may or may not happen, I would consider using less sophisticated but also less complex approaches.
Anyways, it would be great to hear something on this topic!

@tehXor  We have been through this ourselves and what does indeed work when trying to use the latest Ionic + Ang 4 is: Use the Ionic CLI + build process (just following the meteor steps from the sample in our own project). It seems that right now the Meteor build pipeline creates issues due to version conflicts with TypeScript. The Ionic build process seems to be updated already.
This was our LAST resort. We don't like having 2 build processes for server ü client But meddled with the meteor CLI for way to long until we decided that right now it simply doesn't work without major surgery or superb understanding of what to change.

I see a lot of people that are having issues updating for ng2 to ng4 with meteor. I also had issues but I eventually got it to work (socially didnt work at first). I all by issues were in the modules.ts and main.ts where the AOT caused a lot of red herring exceptions. Just writing that to give assurance that meteor works with ng4.
Sent from my iPhone

On May 19, 2017, at 2:32 AM, ntziolis<EMAIL_ADDRESS>wrote:
@tehXor We have been through this ourselves and what does indeed work when trying to use the latest Ionic + Ang 4 is: Use the Ionic CLI + build process (just following the meteor steps from the sample in our own project). It seems that right now the Meteor build pipeline creates issues due to version conflicts with TypeScript. The Ionic build process seems to be updated already.
This was our LAST resort. We don't like having 2 build processes for server ü client But meddled with the meteor CLI for way to long until we decided that right now it simply doesn't work without major surgery or superb understanding of what to change.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I was able to get it to work with the ionic CLI, but not with the Meteor CLI. Can anyone confirm they have been able to get the Meteor CLI + Ionic 3 + Ang 4 to work?

My goal: make it work in web and android
I have had all this week trying to make it work without success, this is my history log:
- Ionic 3 + Angular 4 + Meteor-Client-Bundler (api) 1.4 = Best approach, bootstrap well in browser / Android, then i have removed mys:accounts-phone and added accounts-password for login purpose and works good for web, hurray!!... but not in Android (using ionic CLI > ionic cordova run android), it just did not connect to my api.
- Meteor 1.4 + Ionic 3 + Angular 4 = After many hours of reading changes logs of one each framework for breaking changes and fixing packages versions trying avoid npm ERR! or unmet peer dependency.. not work for web and android, i cannot get rid of the error "Cannot read property 'meteorInstall' of undefined"or "Maximum call stack size exceeded " this last error on angular 2.4.8.
Conclusion:
Reading change logs is a "must do" always and definitely the need to get more involved because it's really frustrating to spend hours trying to figure something out without the proper knowledge.
For example, to know that Meteor(<IP_ADDRESS>) use node 4.8.2 and ionic(3)  use node 6+ makes a lot advantage when you are using npm install or meteor npm install.

Just in case anybody else is interested: We still went with Meteor and Ionic/Angular for our current project but we tried to avoid as much complexity from the angular-meteor project(s).
So we installed a separate Meteor and a separate Ionic project which do not share any code. This means we have to define collections in both projects and our only 'glue' is meteor-rxjs and meteor-client-bundler where we make use of the options to specify an external Meteor project and an external URL.
This also means we have two build processes but we are very close to the 'original' Meteor and Ioinc ecosystem and have zero individual compilers (we also left out barbatus:typescript for Meteor) as it seems those add a lot of complexity for upstream updates, while wrapping Meteor functions and collections in rxjs observables (done by meteor-rxjs) and adding a meteor client (meteor-client-bundler) is less complex and updates will be required less often.
This seems to be fairly stable and personally I would appreciate it, if this project would as well remove the approach with two 'ways' (a Meteor CLI as well as a Ionic CLI) and instead focus on one way, maybe also with less complexity were only the very basics needed to combine Meteor with Ionic/Angular are maintained. The idea and also code of this project is great, however the past quite clearly shows that it is very poorly maintained in terms of reaction time. This makes using it as it is in projects meant for production impossible. Reducing the complexity greatly could allow a production-ready angular-meteor project without a great increase of maintenance time. But that's just imho ;-)

@tehXor is that using angular 4?

@tehXor, this solution is not bad at all.. I want to give it a try. Do you mind sharing a repo to illustrate how you did it.

It works now!  After reading various posts that Angular 4 works with Meteor, I decided to give it another try.
I added the latest version of Meteor 1.5 and Angular 4.2.0-rc.2 to the Socially tutorial and it worked.
Here's a git repo of the working project.
https://github.com/cesargalindo/socially-step19-ang4.2.0-rc.2

We've released angular2-meteor version 0.8.0 to support the latest versions of Angular (4 and 5).
Thanks to this PR from @darkbasic .
Just a note, that we've updated this API even though we consider it a deprecated API, and you should probably slowly migrate your data solution to meteor-rxjs.
we've also published new angular-compilers package that supports all the features the Angular CLI gives you:

Typescript compilation
Assets compilation (HTML, styles)
Angular's AoT compilation
Rollup's bundling with Tree Shaking

and added a lot of examples with for all those features plus an example with Angular CLI if you want to use it instead of the Meteor CLI:
https://github.com/Urigo/angular-meteor/tree/master/examples
We've also updated all the latest versions including the latest Angular 5 RC and Meteor 1.6.
Please open a new issue if you encountered one.
We've updated the Ionic CLI tutorial and in the process of updating the Meteor CLI one.


Add the default values to the Citadel and Node Agent command usage instructions

To allow the users to get the default value of a command line option, add the default values of the command line options of Citadel and Node Agent to their command usage instructions.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: diemtvu
If they are not already assigned, you can assign the PR to them by writing /assign @diemtvu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @sdake

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
c7914eacbc0fa30195bec39c4e6c124361377c35
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I thought the default values are included automatically in doc and command output:
$ ./node_agent -h
Istio security per-node agent

Usage:
  node_agent [flags]
  node_agent [command]

Available Commands:
  help        Help about any command
  version     Prints out build version information

Flags:
      --ca-address string             Istio CA address (default "istio-citadel:8060")
      --cert-chain string             Node Agent identity cert file (default "/etc/certs/cert-chain.pem")
      --env string                    Node Environment : unspecified | onprem | gcp | aws (default "unspecified")
  -h, --help                          help for node_agent
      --key string                    Node Agent private key file (default "/etc/certs/key.pem")
      --key-size int                  Size of generated private key (default 2048)
      --log_as_json                   Whether to format output as JSON or in plain console-friendly format
      --log_caller string             Comma-separated list of scopes for which to include called information, scopes can be any of [default]
      --log_output_level string       The minimum logging level of messages to output,  can be one of [debug, info, warn, error, none] (default "default:info")
      --log_rotate string             The path for the optional rotating log file
      --log_rotate_max_age int        The maximum age in days of a log file beyond which the file is rotated (0 indicates no limit) (default 30)
      --log_rotate_max_backups int    The maximum number of log file backups to keep before older files are deleted (0 indicates no limit) (default 1000)
      --log_rotate_max_size int       The maximum size in megabytes of a log file beyond which the file is rotated (default 104857600)
      --log_stacktrace_level string   The minimum logging level at which stack traces are captured, can be one of [debug, info, warn, error, none] (default "default:none")
      --log_target stringArray        The set of paths where to output the log. This can be any path as well as the special values stdout and stderr (default [stdout])
      --org string                    Organization for the cert
      --platform string               The platform istio runs on: vm | k8s (default "vm")
      --root-cert string              Root Certificate file (default "/etc/certs/root-cert.pem")
      --workload-cert-ttl duration    The requested TTL for the workload (default 2160h0m0s)

Use "node_agent [command] --help" for more information about a command.

so probably you don't need to explicitly specify them in the description?

@yangminzhu Good point. I will close this PR accordingly.

The command line is for node agent not CA, but the doc makes sense :)


Sensors activity won't update after v1.6.0

My sensors stopped working after udpate v1.6.0
Had to rollback to v 1.5.0
Any ideas?

Same problem.


ARROW-8668: [Packaging][APT][Yum][ARM] Use Travis CI's ARM machine to build packages

If we use QEMU on GitHub Actions, it takes 6h+.
If we use ARM machine on Travis CI, it takes 30-40m.
This change adds Docker image caching to
apache/arrow-dev:${ARCH}-{DISTRIBUTION}-${CODE_NAME_OR_VERSION}-package-${PACKAGE_NAME}-llvm-${LLVM_VERSION}. It
refers .env at the top directory. So we can override the
"apache/arrow-dev" by the REPO environment variable for testing.
This change disables Gandiva for Debian/Ubuntu ARM packages because
apt.llvm.org doesn't provide packages for ARM.
This change disables Gandiva for CentOS 8 ARM packages because we
don't have enough disk space to build it. We may need to disable
Flight later.
This change adds ARM package builds to nightly jobs. If they are
fragile, I'll remove them.

@github-actions crossbow submit -g linux

@github-actions crossbow submit -g linux

@kszucs I want to set DOCKERHUB_USER and DOCKERHUB_TOKEN in https://travis-ci.org/github/ursa-labs/crossbow . Which user should we use for this?
It seems that we use them for https://hub.docker.com/u/asfjenkins on GitHub Actions.

@kou yes we use asf provided credentials on github actions to upload the images. We need a user with write access to that repository with a custom dockerhub token. Just granted you admin rights on ursa-labs/crossbow so you can set it yourself (or I can do it later if you want me to).

Thanks! I set mine to https://travis-ci.org/github/ursa-labs/crossbow and https://github.com/ursa-labs/crossbow.

@github-actions crossbow submit -g linux

@github-actions crossbow submit -g linux

+1
Most builds are about 5m faster than before.

Thanks for setting this up, nice improvement!


[VC] Adding support for vn-agent to have featuregates via flags

This adds support for the vn-agent to support getting featuregates in later PRs I'll have a new feature added into the vn-agent for customized native vnode objects.
Signed-off-by: Chris Hein<EMAIL_ADDRESS>

/assign @Fei-Guo

/cc @charleszheng44

/lgtm
/approve


Create API endpoints to serve data to applications

Once we've designed our API (#5), we need to actually create the endpoints. This will be done through an API controller, which essentially accesses the database through the models and returns the data requested.
Requires: #5 completed.
DoD: All GET endpoints within /api/ created, returning data with expected schema. Unit tests to make sure everything works correctly.

Initial implementation of this is complete. Work may need to be done to make things nicer, though.


Keep Longitude between +180° eastward and −180° westward.

If you move the map one or more turns around the earth, You can see the the longitude of bounds exceeded ±180

This is the wanted behaviour.
You can use worldCopyJump: true in the map options to prevent this. Docs


vstack and hstack not working as intended

Describe the bug
It doesn't seem like the behavior of vstack and hstack is working from version 0.4.7 to 0.4.9 as far as I can tell. In the example below only the first chart in the stack (whether it is an hstack or vstack) is visible. Sorry if I'm missing something and thanks for the help!

Environment
requirements.txt
altair==5.3.0
arrow==1.3.0
marimo==0.4.9
numpy==1.26.4
pandas==2.2.2
polars==0.20.23
pyarrow==16.0.0
black==24.4.2

Code to reproduce
import marimo as mo
import altair as alt

counts = pl.DataFrame(
    {
        "category": ["C1", "C2", "C3", "C4", "C5", "C6", "C7", "C8", "C9", "C10", "C11"],
        "count": [10, 20, 30, 40, 50, 60, 70, 80, 90, 100, 110],
    }
)

chart1 = (
    alt.Chart(counts.to_pandas())
    .encode(
        y="count",
        x=alt.X(
            "category",
        ),
    )
    .mark_bar(color="blue")
)

chart2 = (
    alt.Chart(counts.to_pandas())
    .encode(
        y="count",
        x=alt.X(
            "category",
        ),
    )
    .mark_bar(color="red")
)

mo.vstack(
    [
        chart1,
        chart2
    ]
)

A simpler example without plots does seem to display properly in case that's helpful info:
import marimo as mo

mo.vstack(
    [
        mo.md("shown"),
        mo.md("also shown")
    ]
)```

![image](https://github.com/marimo-team/marimo/assets/4791811/6046764c-9e41-4cf2-84b7-a5adab301694)

agh i made a pretty sneaky mistake - pushing up a fix now and will cut a release

awesome, thank you!

Fix is in 0.4.10 - thanks for the help reporting this


REST API versioning

We should think about versioning the rest api in order to keep compaitbility between changes on versions.

API we create are just for webUI usage and not generically exposed towards other potential users.
The WebUI is a separated component, but part of the system do we think to release them independently?
Even if versioning the API does not create particular complexity it does not seem to add much value here.
The problem could arise with processes behind some APi and here we need a bit of thinking more.

We need a decision

I think we can discard this change. For me you can close this issue.


multiface swap

Like the swap_one method there should be an intuitive way to swap many faces 2 many faces.

Kinda implemented now. Is if you have an image with two faces the embedding will have both saved. If there's an image with multiple faces they should be applied in that order. Needs to be battle proved and feature improved.

Working on a sophisticaed better version now.
Will use a distance metric between the detected faces.


release/downloadIstioCandidate.sh: check tarball url before download

Signed-off-by: Xiang Dai<EMAIL_ADDRESS>Please provide a description for what this PR is for.
Fix #28582
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@daixiang0: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7ba96b2eb3fa7a8af221f044285847e4e06c1279
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

small nit: could we do set -e on this script like we do with most of our bash scripts and then do something like https://stackoverflow.com/a/19622569 to give user-friendly error?

@daixiang0: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
02912d3027f6357223023391dc074405f169af27
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
02912d3027f6357223023391dc074405f169af27
link
/test release-notes_istio

integ-pilot-k8s-tests_istio
02912d3027f6357223023391dc074405f169af27
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
02912d3027f6357223023391dc074405f169af27
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
02912d3027f6357223023391dc074405f169af27
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
02912d3027f6357223023391dc074405f169af27
link
/test release-notes_istio

integ-pilot-k8s-tests_istio
02912d3027f6357223023391dc074405f169af27
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@daixiang0: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
02912d3027f6357223023391dc074405f169af27
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
4a6da25b548aa1a0e2aacc255d8da27afbd20d6a
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

/cc @carolynhu


Cannot read properties of null (reading 'bait_id')

Got this error when setting up the "Favourite setup" menu. Error still appears after reloading the page and disabling/enabling the script.

Disabling and enabling favourite setup in settings solve the issue, but I lost all my saved setups.


Add contributor guide link to Community page

It seems logical that someone might click Community if they wanted to find their way to either the contributor guide and/or code of conduct. Adding a link to https://jupyter.readthedocs.io/en/latest/contributor/content-contributor.html and/or https://jupyter.readthedocs.io/en/latest/community/content-community.html probably in the Community list probably makes sense.

In the name of Hacktoberfest, I'll take a crack at it. Very new to open source contributing, but I'd like to try this out. It seems simple enough!

Fixed by #230


Add xmobarFont

Description
xmobar allows you to define a list of additional fonts (additionalFonts) and to use the fn tag to choose between them (by passing in the index of the font to use). xmobarFont is essentially the same as the existing xmobarColor function, but for fonts.
Specifically, I use this to use an icon font for my workspaces, but I imagine this can be useful for other situations as well.
Checklist

[x] I've read CONTRIBUTING.md

[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: manually - this is a very small change that rests almost entirely on the wrap function.

[x] I updated the CHANGES.md file

[x] I updated the XMonad.Doc.Extending file (if appropriate) - N/A

Awesome work :tada:  Thank you for your contribution!


[WIP] feature: Added RM transaction hook, support global and local

Ⅰ. Describe what this PR did
新功能：添加RM事务的钩子。
目前仅做了commit和rollback的钩子，register等等的钩子未做。
另外一个优化global-tm-hook的PR：#2673
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2796 into develop will decrease coverage by 0.85%.
The diff coverage is 26.58%.

@@              Coverage Diff              @@
##             develop    #2796      +/-   ##
=============================================
- Coverage      50.48%   49.62%   -0.86%
- Complexity      2921     2929       +8
=============================================
  Files            572      586      +14
  Lines          18616    18906     +290
  Branches        2245     2227      -18
=============================================
- Hits            9398     9382      -16
- Misses          8288     8566     +278
- Partials         930      958      +28

Impacted Files
Coverage Δ
Complexity Δ

...m/src/main/java/io/seata/rm/AbstractRMHandler.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...ava/io/seata/rm/transaction/RMTransactionHook.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...seata/rm/transaction/RMTransactionHookAdapter.java
14.28% <14.28%> (ø)
1.00 <1.00> (?)

...seata/rm/transaction/RMTransactionHookManager.java
74.07% <74.07%> (ø)
9.00 <9.00> (?)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

... and 44 more

为什么还是WIP?还没写完吗？什么时候可以合并到正式版本呢？

为什么还是WIP?还没写完吗？什么时候可以合并到正式版本呢？

最近都比较忙，进度比较慢，也不一定会在1.4.0里合并此PR。我本地也还没有测过。
如果你有兴趣的话，可以帮忙测一下。

Codecov Report

Merging #2796 into develop will decrease coverage by 0.40%.
The diff coverage is 38.98%.

it is necessary to think

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: slievrly:x: wangliang181230:x: a364176773You have signed the CLA already but the status is still pending? Let us recheck it.


fix: Corrected the name of a dev profile

they choose their name by themself we cant change someone else profile

okay 👌


Improve Sample

Create client that uses all available endpoint types.

https://github.com/TypedRest/Sample-DotNet/


Galactic Alphabet Decoder cannot handle 'x' when it's surrounded by other letters.

When running ciphey with an input that's encoded in the Standard Galactic Alphabet, it applies my SGA decoder. If that input string contains a word that has an 'x' surrounded by other letters (no whitespace in between), it fails to do the replacement correctly and leaves a Unicode diacritical mark (Updot) as an artifact. I'm still working on a fix for this.
This is the character:  ̇  (U+0307, 'Combining Dot Above', https://www.compart.com/en/unicode/U+0307)
It is part of the multi-character representation of the SGA's 'x' letter.
Example:
poetry run ciphey -t "𝙹 ̇/⎓𝙹∷↸ ℸ ̣ ⍑ᒷ  ̇/ ╎ᓭ ╎リ ℸ ̣ ⍑ᒷ ᒲ╎↸↸ꖎᒷ ℸ ̣ ⍑ᔑℸ ̣ ᓭ ∴⍑|| ╎ℸ ̣  ⎓ᔑ╎ꖎᓭ"
Format used:
  reverse
  galactic
  atbash
  reverse
  atbash
Final result: "o ̇ford the x is in the middle thats why it fails"

Versions:

OS/Distro: Windows 10 1909 (in Windows Terminal)
Python version: 3.7.4
Ciphey versions: 5.0.0

See tests\test_main.py -> test_galactic_Xproblem()

I was confused :D