redpanda: low latency mode

hi @adamw  - i saw the post (https://github.com/softwaremill/mqperf/commit/8873fa57cf554c720488b5ba5a09dfab92dd23d6?short_path=e28ac69#diff-e28ac696dc377acf5d4494af8b82c2fa6467c86cfea831bdd149c1d124eb5edf) when i was looking up redpanda projects.
We just introduced a patch for even lower latency (at expense of lower throughput): https://github.com/vectorizedio/redpanda/commit/1b0f027dc0f61fbdbf06bf77440a1e863cc2e87e
but also, the post talks about gp2 as the ebs volumes. In this setup (while I think is good to keep setup the same) you will be bottlenecke'd by IOPs, not by throughput. In fact is a bit disadvantageous to redpanda in that mode if you care about performance in that we issue a bit higher IOPs. For example, in order to gain performance improvements on local NVMe ssd devices we leverage sparse file system support ( dispatch of iocb in order 1, 2, 3, 4 but reap events from the kernel in order of 3, 2, 1, 4 - as one example)
Just wanted to add the 2 cents there.
Let me know if you want to brainstorm help to tune your setup on vectorized.io/slack always happy to help folks benchmarking.

Thanks for the feedback! I think I did monitor IOPS for this test as well, but I don't have a hard record of it, so I can't be 100% sure. We should probably add this metric to the data we save for each test :)
We periodically re-run the tests with newer versions, I'll let you know here when this happens.


PyPI tf-nightly version incompatible

setup.py extra installation requirements for tf-nightly==2.4.0.dev20200708 is no longer available in PyPI.
pip install dm-acme[tf] and dm-acme[reverb] fails in finding the required version.

Hi @colingwuyu, thanks for raising this issue. We're releasing Acme v0.2.0 which will fix this. We will update this bug when it is available on pypi.

@fastturtle thank you for the swift response.

dm-acme 0.2.0 has been released on pypi, you should now be able to install the new version correctly :)


The same smart block leaves the trigger word when I run it but does not when my friend runs it.

I have explained the problem extensively in the following slack thread:
https://roamresearch.slack.com/archives/C0190JLGDUJ/p1614815779272300

I just saw Chris's new video demonstrating the new sidebar functionalities. He mentioned there that when you leave a blank line at the beginning of the Smartblock it will prevent the trigger keyword from being left behind. And it solved the problem that I was having.


Offline management

Add the ability to choose either the offline mode is available for an event (device ?) or not

Fixed by #251


Ensure quotes and new lines are escaped in echo

So, we had previously made this a bit more resilient to weird new lines in environment variables not being loaded properly in docker by adding them to command line args instead. But, with the right order or quotes/newlines/etc, we can still run into issues at the echo statement before the actual command is executed. This adds escaping for the double quotes as well as calling echo -e so that the escaped characters are expanded properly when printed.

@tpetr , renamed the helper to be more descriptive here


[CHORE] rework internal state to connection class, more tests

Codecov Report
Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (dcc31f9) 2.77% compared to head (52a71d1) 5.46%.

Files
Patch %
Lines

.../bmarwell/sipper/impl/proto/SipMessageFactory.java
0.00%
7 Missing :warning:

...l/sipper/impl/internal/ConnectedSipConnection.java
0.00%
6 Missing :warning:

.../impl/internal/DefaultRegisteredSipConnection.java
0.00%
4 Missing :warning:

...ell/sipper/impl/internal/SipConnectionFactory.java
0.00%
4 Missing :warning:

...java/io/github/bmarwell/sipper/impl/ip/IpUtil.java
77.77%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #28      +/-   ##
==========================================
+ Coverage     2.77%   5.46%   +2.68%
- Complexity       8      13       +5
==========================================
  Files           18      18
  Lines          432     439       +7
  Branches        18      18
==========================================
+ Hits            12      24      +12
+ Misses         419     414       -5
  Partials         1       1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[FIX] infinite waiting for upload progress due to english words selector

Replacing of english words selectors by class name selectors. In the scope of upload progress waiting

LGTM!


[WFCORE-6493] Add Guava as a test dependency to the Test Suite.

Issue: https://issues.redhat.com/browse/WFCORE-6493

Thanks @ivassile


onStateChange does not work

Hello,
I'm trying to use onStateChange, but it does not work:
<YouTube
  ref="YoutubeVideo"
  url={videoLink}
  onPlay={this.onPlay}
  onStateChange={this.onStateChange}
  onReady={this.onReady}
/>

Am I doing something wrong?

It's not exposed, the  ending, playing and paused events from it are exposed via onEnd, onPlay and onPause though.
onStateChange will probably be exposed if I get around to implementing #29 though, which will hopefully be soon.
Sorry about that.


Possible issue during gradlew assembleRelease for netinfo library checks

Environment

System:
OS: macOS 14.4.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 41.61 MB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.15.1
path: ~/.nvm/versions/node/v20.15.1/bin/node
Yarn:
version: 1.22.19
path: /usr/local/bin/yarn
npm:
version: 10.7.0
path: ~/.nvm/versions/node/v20.15.1/bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.15.2
path: /Users/admin/.rvm/gems/ruby-2.7.5/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.5
- iOS 17.5
- macOS 14.5
- tvOS 17.5
- visionOS 1.2
- watchOS 10.5
Android SDK: Not Found
IDEs:
Android Studio: 2023.3 AI-233.14808.21.2331.11709847
Xcode:
version: 15.4/15F31d
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.2
path: /Users/admin/.sdkman/candidates/java/17.0.2-zulu/bin/javac
Ruby:
version: 2.7.5
path: /Users/admin/.rvm/rubies/ruby-2.7.5/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Platforms

Android
Versions

Android:
iOS:
react-native-netinfo:
react-native:
react:

Description

Hey folks! I think there's a possible issue with assemble release / app:checkReleaseAarMetadata
I'm trying to build my app with  ./gradlew assembleRelease and the  result is:
* Exception is:
org.gradle.internal.execution.WorkValidationException: A problem was found with the configuration of task ':app:checkReleaseAarMetadata' (type 'CheckAarMetadataTask').
  - Gradle detected a problem with the following location<EMAIL_ADDRESS>
    Reason: Task ':app:checkReleaseAarMetadata' uses this output of task ':@react-native-community_netinfo:writeReleaseAarMetadata' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':@react-native-community_netinfo:writeReleaseAarMetadata' as an input of ':app:checkReleaseAarMetadata'.
      2. Declare an explicit dependency on ':@react-native-community_netinfo:writeReleaseAarMetadata' from ':app:checkReleaseAarMetadata' using Task#dependsOn.
      3. Declare an explicit dependency on ':@react-native-community_netinfo:writeReleaseAarMetadata' from ':app:checkReleaseAarMetadata' using Task#mustRunAfter.

    For more information, please refer to https://docs.gradle.org/8.6/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

Building the project with ./gradlew bundleRelease , ./gradlew app:assembleRelease, npx react-native run-android works fine, just this command ./gradlew assembleRelease  is failling. I have tried to switch between netinfo version having always same result. Could you please give a support here? I appreciate.
Reproducible Demo

Same issue here, the error also happens to me with ./gradlew assembleDebug

@engineeringcontractorstockpile
Maybe this will work for you, it worked for me with ./gradlew assembleDebug and assembleRelease
https://github.com/react-native-netinfo/react-native-netinfo/issues/684#issuecomment-1722130238

In the case anyone wants to use assembleDebug, just change every part of the code that says "Release" to "Debug"
Also i had to comment the last 2 lines
//tasks.findByPath(':react-native-community_netinfo:verifyReleaseResources').dependsOn tasks.findByPath(':@react-native-community_netinfo:mergeReleaseResources')
//tasks.findByPath(':react-native-community_netinfo:verifyReleaseResources').dependsOn tasks.findByPath(':@react-native-community_netinfo:processReleaseManifest')

Finally, as KrushnaNaghate mentioned in the comment "...it may not be a permanent fix, and you should consider investigating the root cause of the issue for a more stable resolution."


Latest Lasair long-term plan

14/JUN/23

@andyxerxes drafting this

Terry
hows this for better ARIC wording?
We set individual responsibilities for Lasair using a ARIC model, i.e. specifying who is {\em Accountable}, i.e. to the Consortium, and to STFC, for seeing that the deliverables are achieved; who is {\em Responsible}, i.e who will in practice undertake the work; who should be {\em Informed}, i.e. kept abreast of progress, key changes, etc; and who needs to be {\em Consulted}, i.e. parties affected by changes in Lasair, who should therefore be made aware of such changes, especially ones they may need to have input into.
andy
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.

Terry hows this for better ARIC wording? We set individual responsibilities for Lasair using a ARIC model, i.e. specifying who is {\em Accountable}, i.e. to the Consortium, and to STFC, for seeing that the deliverables are achieved; who is {\em Responsible}, i.e who will in practice undertake the work; who should be {\em Informed}, i.e. kept abreast of progress, key changes, etc; and who needs to be {\em Consulted}, i.e. parties affected by changes in Lasair, who should therefore be made aware of such changes, especially ones they may need to have input into. andy The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.

@andyxerxes - yes, looks good to me.

ok cool
From: Terry Sloan @.>
Reply to: lsst-uk/lasair-project-management @.>
Date: Wednesday, 14 June 2023 at 12:18
To: lsst-uk/lasair-project-management @.>
Cc: Andy Lawrence @.>, Mention @.***>
Subject: Re: [lsst-uk/lasair-project-management] Latest Lasair long-term plan (Issue #295)
This email was sent to you by someone outside the University.
You should only click on links or attachments if you are certain that the email is genuine and the content is safe.
Terry hows this for better ARIC wording? We set individual responsibilities for Lasair using a ARIC model, i.e. specifying who is {\em Accountable}, i.e. to the Consortium, and to STFC, for seeing that the deliverables are achieved; who is {\em Responsible}, i.e who will in practice undertake the work; who should be {\em Informed}, i.e. kept abreast of progress, key changes, etc; and who needs to be {\em Consulted}, i.e. parties affected by changes in Lasair, who should therefore be made aware of such changes, especially ones they may need to have input into. andy The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.
@andyxerxeshttps://github.com/andyxerxes - yes, looks good to me.
—
Reply to this email directly, view it on GitHubhttps://github.com/lsst-uk/lasair-project-management/issues/295#issuecomment-1590997376, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFC4AQWD4WBEFQZO2IYPK3DXLGMXNANCNFSM6AAAAAAZGDRNCE.
You are receiving this because you were mentioned.Message ID: @.***>

Substantially complete draft completed and discussed at Zoom 2023-07-19. Follow on discussion by Roy and Andy, and Roy has made further changes

30/AUG/23

made publicly available from LSST:UK Confluence wiki at
https://lsst-uk.atlassian.net/wiki/download/attachments/1146928/LUSC-C02-Lasair-LongTermPlan-V1.pdf?api=v2


[cloud_firestore] snapshots() should have a changed filter

Is your feature request related to a problem? Please describe.
Right now listening to a query always return all documents:
query.where(...).snapshots().listen(...)
when the collection grows huge this will be a problem
Describe the solution you'd like
Is it possible to add a flag in the snapshots() function to filter only the documentChanges to be sent across the wire?
.snapshots(changed: true)
Additional comments
Moved here
https://github.com/flutter/flutter/issues/54042

It's only possible to request document changes via includeMetadataChanges, however this still returns all documents WITH the changes.
I'll close this off as it's a native SDK limitation rather than this library.

That being said, it is technically does make sense to ignore the actual documents being sent from native which would help speed things up - the actual reads would still happen though.
I'll bring this one up as it would require non-standard API changes.


Invalid key mapping with azerty keyboard and ctrl modifier

With latest prerelease package (0.7.0-build429-beta), on OSX, when I press Ctrl+A, Key_Up event (or other key events) send me an Avalonia.InputKeyEventArgs.Key == Avalonia.Input.Key.Q
Common shortcut like undo/redo (ctrl+z/ctrl+y) are also map on querty schema instead of azerty.
But inside a textbox the mapping is correct.

@danwalmsley is this still a problem?

Hey there,
I'm experiencing kind of the same problem on v. 0.10.18.
My keyboard is an azerty one. When I run my app on Windows the mapping is correct, but when I run it on mac it maps like a qwerty (so my A key raises a Q key pressed event for example).
Any idea on how to make it work correctly?


fix(v2): properly scale logo on IE 11

Motivation
Add missing viewBox attr for SVG logo. See https://stackoverflow.com/questions/27970520/svg-with-width-height-doesnt-scale-on-ie9-10-11 for details.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Current bug in action:

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Unfortunately, there are still a lot of bugs on IE 11 :(


Produce Presentation for Cross-Program Strategies

Need a quick ~5 minute intro to the RR tool for the meeting on Monday (Jan 16th)

[x] Where to save? MAR Spatial Planning or IMRP Teams?
[x] Pull some slides from RAP 2022-2023 presentation
[x] Add additional slides giving context into where the tool currently stands
[x] Get list of links ready for the meeting chat (Github, tech report, strategic RAP board, etc)
[x] Have the app up and running and a sample report link for the chat
[x] Present and field questions on RR tool

Presentation given


Testing en spike and step

Finishes the first pass at testing EN_spike_and_step I started in #58. Notice the build is currently breaking in two places on condition C (steps):

a step is getting flagged when it should be permitted by the interpolation condition C(i)
a step at the end of the profile isn't getting flagged at all, breaking the test for condition C(iii). I think this is because the indices in conditionC() are one behind where they should be - meaning they check everything correctly, except one step behind in the loop, meaning the index never actually hits the last element in dt.

Will push another commit to this branch with my fixes for these, but wanted to keep it separate unless @s-good can let me know why things are actually correct the way they are.

c06e579:
Moves the indices as I suggested and checks for being at the end of the profile - Ciii test passes.

aca14da:
adds the interpolation check to avoid rejecting steps, per rule C(i).
(one thing to note - the test for this also illustrates that a smooth decline to the end of the profile, if steep enough, will look like a 'step' - not a problem I guess, since it's consistent with the text - just a bit of a weird edge case).

oh wait, I see what you're doing - that offset index I moved in c06e579 that misses steps at the end is supposed to be handled by that block
    # Step or 0.0 at the bottom of a profile.
    if isData[-1] and dt.mask[-1] == False:
        dTTol = determineDepthTolerance(z[-1], np.abs(p.latitude()))
        if np.abs(dt[-1]) > dTTol:
            qc[-1] = True
    if isTemperature[-1]:
        if t[-1] == 0.0:
            qc[-1] = True

which isn't doing it's job atm. Let's do it your way - I'll put the indices back how you had them (since just changing them in C puts them out of step with everything else anyway....) and get that block quoted above to pass the test.

Alright, that ought to do it - the factorization is a bit odd around Ciii, but the build is passing and this branch is ready for merge.
I'd still like to understand the wt1 parameter a bit more; it doesn't seem to be part of EN_spike_and_step as written, unless I'm just missing it. I could probably refactor the whole function so we don't need an edge case for trailing steps, but I'm reluctant to do so without understanding this additional calculation; but now I'm picking on really small things.


Expose RLMArray constructor for creating Primitive type Array using Swift with realm-objective C

How frequently does the bug occur?
All the time
Description
Hey, I am working on the project that has the combination of both objective-c and Swift. While working with realm-coca, using the swift language in same project , i found that below mentioned constructor is not exposed in RLMArray.h file to create the primitive type Array.
- (instancetype)initWithObjectType:(RLMPropertyType)type optional:(BOOL)optional;
Only - (instancetype)initWithObjectClassName:(NSString *)objectClassName; is exposed to create the array of RLMObject.
As With the requirement of project ,we require this constructor to be exposed .
Stacktrace & log output
No response
Can you reproduce the bug?
Yes, always
Reproduction Steps
No response
Version
10.19
What SDK flavour are you using?
MongoDB Realm (i.e. Sync, auth, functions)
Are you using encryption?
No, not using encryption
Platform OS and version(s)
MAC OS big sur (11.5.1)
Build environment
Xcode version: 12.5.1
Dependency manager and version: cocapods (1.10.1)

Hi @tusharmutreja200 you don't need to import anything else in Objective-С.
To create a Realm array of primitives you can define it like following:
@interface PrimitiveArray : RLMObject
@property RLMArray<RLMInt> *intObj;
@end

Please refer to example in our tests
declaration
initialization
You can find more in the Realm documentation

@pavel-ship-it I understand if we are writing using objective-c language then there is no need. But what if we need create an  array of primitive array using swift language.
please refer to this comment of @jsflax   https://github.com/realm/realm-cocoa/issues/7517#issuecomment-963067
As I found the solution for this too , And also created the PR for the same.
PR link: https://github.com/realm/realm-cocoa/pull/7537
please look into it once, As this issue is blocking our development.

Can you explain the use case a bit more please?
You can have array of primitives in both ways.
// obj c
@import Realm;

@interface PrimitiveArrayObjC: RLMObject
@property RLMArray<RLMInt> *intObj;
@end

RLMRealm *realm = [RLMRealm defaultRealm];
[realm beginWriteTransaction];
[realm addObject: [PrimitiveArray new]];
[realm addObject: [PrimitiveArrayObjC new]];
[realm commitWriteTransaction];

// swift
import Realm
import Realm.Private

class PrimitiveArray: RLMObject {
    @objc dynamic var intObj = RLMArray<NSNumber>(objectType: RLMPropertyType.int, optional: true)
}

let realm = RLMRealm.default()
realm.beginWriteTransaction()
realm.add(PrimitiveArray())
realm.add(PrimitiveArrayObjC())
try! realm.commitWriteTransaction()

Hey @pavel-ship-it, I have a use case in which I need to create Realm array of primitive types in Swift file. And configuration of the project like this

Base of the the project is in Objective-c and mix of Swift files too
Using realm-objective c as a library
But using Swift language to create the realm Schema via bridging

Problem : We are not able to access the - (instancetype)initWithObjectType:(RLMPropertyType)type optional:(BOOL)optional this constructor in our swift file to create an array of primitive type.
And based on my analysis I found that initWithObjectType is not exposed from the file RLMArray.h file like  initWithObjectClassName , thats y we are not able to access in our swift file.
As you can check in PR: https://github.com/realm/realm-cocoa/pull/7537 too that I just added this constructor and everything works, I think it might be a miss.
And also I have tried your solution in swift file, but it gives an error as we are importing realm from bridging header file.

Error after applying  above solution

Error after not applying  above solution

And it goes away if we add initWithObjectType in RLMArray.h file. And it doesn"t
requires to import anything in swift file

please have a look into PR and let me know if you have any pointers

The code above should work without the fix you're added in the PR.
Is there a reason to import Realm in bridging header?
fyi - after adding @objcMembers you can remove @objc from properties.

@pavel-ship-it thanks for the update.
We are importing realm in bringing header, so that we can use  realm properties in swift files.
You can test this scenario at your end too.
Just need to create objective-c project and install pod realm 10.19 and try to create the schema in swift file.
You will face this issue.

You can test this scenario at your end too.

That case is working good for me. Probably there is the issue with a project?
Can you try this project on your environment? https://github.com/pavel-ship-it/support-realm-cocoa-7536

@pavel-ship-it I understand the scenario that why it works fine at your end because you are using the dynamic framework as I have checked in your project you didn't comment the  use_frameworks! in Podfile, but in our project, we have limitations that we can't use dynamic framework and we have commented use_frameworks! in Podfile while installing the pods.
Please suggest a way that we can use the same functionality via Static framework of realm

@tusharmutreja200
Yes, you can use Realm as a static library. Please refer to the documentation here

Thanks, @pavel-ship-it for the update. This issue does"t  exist when we use the Static IOS framework via Drag-drop way eg. by dragging Realm.xcframework into the project.
But this issue exists when we install a realm static framework via Pods. For now, I can use the drag-drop way, please check once why this issue exists when we use realm static framework via Cocoapods.

@pavel-ship-it Any update on it, Can we merge that pull request.

@tusharmutreja200 have you tried adding use_modular_headers! to your Podfile

@leemaguire  yes, it works perfectly fine with it.

@tusharmutreja200 good to hear! On that note I will close this issue.

@leemaguire But we have to fix this for CocoaPods too

I will bring the PR to the teams attention. In the meantime you can declare a category in your project and building with Cocoapods will work.
@interface RLMArray (SwiftExtensions)
- (instancetype)initWithObjectType:(RLMPropertyType)type optional:(BOOL)optional;
@end

I declared this in the bridging header just for test purposes and it allowed the project to build & run normally.


[BUGFIX] Use the static versions of Arrow and Parquet libs

With our current build system, if we use a shared thirdparty library, the resulting binary (executable or shared library) depends on the absolute path of the shared library. This means that it might not be possible to run Daphne on a host other than the one we built it on.

I can not confirm this. Maybe you did not properly set up your linker environment (LD_LIBRARY_PATH) ?

Yes, sorry, it's not the absolute path, setting the LD_LIBRARY_PATH works, but we should maybe document it. We could consider "installing" / copying the thirdparty shared libraries we link against under lib/, so that having bin/ and lib/ is enough to run Daphne (now the thirdparty/ folder is also a runtime dependency instead of a build-only dep). Although, if the static versions are small enough, we could switch to them in any case.

The only place I ever documented it was in the download page of release 0.1 :blush: When using the interactive container all dependencies are in /usr/local/lib - that is conveniently one of the default locations that is searched anyway ;-)
I can see the benefits of linking statically and I'm not opposing it right away. But linking Arrow/Parquet would probably increase libAllKernels.so's size to more than double (libAllKernels.so is 40mb, libarrow.a is 55mb and libparquet.a is 9mb). Next up in the latest dependency additions will be Eigen, PAPI, OpenMPI and spdlog. As you can see this quickly gets out of hand imho, so documenting the linker setup might be more scalable.

k, closing this PR then. I'll also probably modify the profiling PR to link PAPI dynamically instead of statically.


Add TF summary logging for validate loss

I know it's ugly but this serves the purpose I need. Having few data to work on, training loss and validate loss do not always go hand-in-hand, and this gives me an easy way to have an overview on how validation loss is performing (and infer how likely the model is to be successfully updated in the near future).

However, I'm starting to suspect that the eval_combined_loss I used is not what I think it is, but just the evaulation of the loss on the training dataset, hence defies my purpose :(
I'm not seeing any real difference in the cases i'm trying to reproduce

Nevermind, i'm adding a feature request since I'm not able to find the real value...


[mgmt] network release

https://github.com/Azure/sdk-release-request/issues/4919

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/arm-network


Interface to deque type

I'm a bit unclear on how deque works, it seems implemented in c but isn't (as far as I can tell) exposed via the c-api.
Is there any possibility that pyo3 could expose a PyDeque type? Or should I use
let deque = py.import("collections")?.getattr("deque")?;
...

?

You are right, it is not exposed in the C API, the type object is private and all its methods are static.
PyO3 couldn't give you more than going via the generic Python API (using getattr, call_method, get_item etc.), so I don't think we should pretend otherwise.

Agreed, thanks for confirming.


Hello

After testing all of the C++ Redis libs I've stayed with the yours one. :) Simple and powerfull!
However I have experience one problem - after client got disconnected from redis it is not possible to reconnect back to redis server. After calling connect() the application freeze.

Thank you for the information.
I've quickly looked at this issue and it seems it is related to boost::asio io_service.
I'll develop a fix as soon as possible.

Thank you very much! :) Also I've experienced the application freeze on the first connection but only once.
Anyway got a question: Is it possible to send sync requests to redis ? thank you :)

I can handle the sync requests with by passing some parameters to callbacks. But I do now know how to do that, can u give some help ? As ilustration I send you some of my code. I would like to use the parameter playerId which was used in the previous function.
http://pastebin.com/9mQrYbHD

Heya,
Idk why but the app freeze even if I publish smth to redis using:
redis_client->send({"PUBLISH" "PTP-CHAT-EXTERNAL" "asd"});
The message won't even reach redis and app freeze.

Hi,
Could you provide me complete examples of what you've done to get these errors.
This would help me to reproduce these issues and to correct them.

I use 2 instances, one for subscribe and one for client.

I connect  to both of them.
I subscribe to 2 channels with proper callbacks.
I use 2 functions with GET command which work properly
One function use PUBLISH and this will cause freeze after calling 2-3 times - the publish command even does not reach Redis.

redis_client.send({"PUBLISH" "PTP-CHAT-EXTERNAL" "asd"});

Hi, thanks again for having take the time to open an issue.
I've been a little bit busy the past weeks, so I apologize for the time I've taken before inspecting this issue.
After working on it, I think the problem was caused by the run loop of the boost::asio io_service which was stopped to early. So, nothing was sent or received after the loop has been broken. I've added a boost::asio::io_service::worker to maintain the run loop alive.
In my tests, the issue seems to be solved with this modification. Could you please confirm it too?


ListUsers API

Description
Introducing the ListUsers API which answers the question "what users are related to a specific object?". To learn more about this feature, refer to the ListUsers RFC.
A ListUsers request is composed of three main properties:

user_filter – the type of user (subject) targeted for the response. This can either be a terminal type (e.g. user) or a userset (e.g. group#member). Only one user filter can be provided at this time.
relation – the target relation that subjects need to the specified object
object – the target resource that subjects need to be related to

Example:
Consider this model and tuples:
model
  schema 1.1

type user

type group
  relations
    define member: [user]

type document
  relations
    define viewer: [user, group#member]

#   document:1, viewer, user:maria
#   document:1, viewer, user:will
#   document:2, viewer, user:jon
#   group:A, member, user:christy
#   document:1, viewer, group:A#member

If we want to return all subjects of type user that have the viewer relation on document:1 we would call
ListUsers(user_filter=user, viewer, document:1) which would return the following:
{
    "users": [ "user:maria", "user:will", "user:christy" ]
    "excluded_users": []
}

Note: This API will initially be released in an experimental capacity. It can be enabled by setting OPENFGA_EXPERIMENTALS=enable-list-users
References

ListUsers API Docs
ListUsers RFC
ListUsers Roadmap Item
API Protobuf Definitions
Related Issues:

https://github.com/openfga/openfga/issues/1215
https://github.com/openfga/openfga/issues/406

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

Not sure we should be treating this like a user. It's a string of format type#relation where #relation is optional. Treating it as a user is a hack. It should have a unique representation and converters to/from proto. Not sure that belongs in this package listusers either, but we can revisit that later. We're probably missing a pkg/types package where human readable helpers can convert to/from protos?

Lets not look too much into the argument name. We're just using an established convention to specify type and optional relation, why would we create a whole new system for this? It's only to facilitate our integration testing too.


Adds usage metrics for local run/debug and starting a new project.

Fixes #842

@etanshaul @patflynn @aslo
This captures metrics for local run/debug and new project with GAE facet.
It doesn't capture adding the GAE facet to a project because I didn't locate anywhere in our code we have control when a facet is added. Is this metric that important that warrants extra time spent on it?
I also didn't test run this change because I don't know how to. I'll wait for @chanseokoh to come back to point me to where I would see my pings.

@etanshaul @aslo PTAL.
Regarding project imports, the typical way to add GAE support is to click on the Configure popup link. We only have control at AppEngineFacetType.createFacet(), AppEngineFacetType.createDefaultConfiguration() and AppEngineFacet(), which are also used by the other ways of adding facets to modules and give us no way of distinguishing what spawned that facet creation, e.g., explicitly adding a facet, clicking the configure button, new project wizard, etc.
I would suggest adding tracking at the AppEngineFacet() level, which tracks every possible way of adding facets, but a face that is constructed isn't necessarily added to a module, so this kind of tracking would possibly not provide very reliable results...

is there a hook we can use to track new project wizard invocations that use app engine?

The one hook I was able to find is AppEngineSupportProvider.addSupport(), which is where I added the current new project/module tracking.

@etanshaul @patflynn I'd like to submit today if possible. I think all comments were address, but let me know if there's anything I've missed.

:ship:


Please close all Chrome windows open

Bug report
Your Environment

Netflix add-on version: Authenticator
Operating system version/name: Windows10

Used Operating system:

[ ] Android
[ ] iOS
[ ] Linux
[ ] OSX
[ ] Raspberry-Pi
[x] Windows

Describe the bug

The authenticator won't go further than "Please close all Chrome windows" even if there are none

Expected behavior

The authenticator should run
Actual behavior

the authenticator gets stuck with this improper error
Steps to reproduce the behavior

open the authenticator app
click Run
get the error

Possible fix

Debug log

The debug log can be found from this link:
Additional context or screenshots (if appropriate)
Installation

[ ] I'm using other Netflix Repo
[ ] I'm using a different source

Other information

Screenshots

Thank you for your interest in this add-on development,
this is an automatically generated message by our Bot
It seems that you have not full followed the template we provide and require for all bug reports.
Attach the debug log is mandatory for a bug report, the log rules are explained in the Issue creation page or in the ReadMe.
Please edit your Issue message to follow our template. The issue will be closed after about one week has passed without satisfactory follow-up from your side.
If you believe it was sent in error, please say so and a team member will remove the "Ignored rules" label.

open task manager
go to Details page and terminate all Chrome.exe


feat: implement remaining functionalities

Changes Unknown when pulling 9eebd96fa7c3bdfc9ed504618b91c5e30cc738f5 on implement-functionalities into ** on master**.


IOFramework - ignore the back and volume buttons

GearVRf-DCO-1.0-Signed-off-by: Rahul Rudradevan
<EMAIL_ADDRESS>

Should fix https://github.com/Samsung/GearVRf/issues/1074.

Works as expected. Will merge Monday morning.


Example compile error

Try to compile clock and receive next on error:
error[E0050]: method `update` has 2 parameters but the declaration in trait `iced::Application::update` has 3
  --> src/main.rs:44:15
   |
44 |     fn update(&mut self, message: Message) -> Command<Message> {
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 3 parameters, found 2
   |
   = note: `update` from trait: `fn(&mut Self, <Self as Application>::Message, &mut Clipboard) -> iced::Command<<Self as Application>::Message>`

Are you relying on 0.3.0 or master?
master contains breaking changes. All the examples compile correctly on our CI pipeline.

Documentation version mark is 0.3.0 and as I can see no Clipboard in Counter example (i.e. second source code block).
My source code is Clock version in my Cargo.toml use 0.3 version provide error.
I think that documentation compile on master and pushed on 0.3.0 version. Please check.

Which Counter example are you specifically referring to? The overview just implements a Counter without referencing the Application trait.

If you are relying on the 0.3.0 version, please grab the proper example source code from the 0.3.0 tag in the repository:
https://github.com/iced-rs/iced/tree/0.3.0/examples

If the issue you are referring are the outdated links in the docs. The issue has been fixed in master by #915.

OK. Thanks.

Dut documenataion for 0.3.0 contain modern contract in https://github.com/iced-rs/iced/blob/0.3/src/lib.rs#L147


Joint visual

🎉 New feature
Summary
Adds joint visual consisting of an axis and an arrow visual.
Gazebo Classic's implementation can be found here - https://github.com/osrf/gazebo/blob/gazebo11/gazebo/rendering/JointVisual.cc

Test it
I have added an example in the visualization_demo folder.
To test it with Ignition Gazebo use the visualize_joints branch.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Part of https://github.com/ignitionrobotics/ign-gazebo/issues/106

@iche033 do you mind to review it ? I would love to include this on Fortress

@iche033 do you mind to review it ? I would love to include this on Fortress

yep, I'll get to this soon

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/google-summer-of-code-2021-new-gui-widgets-in-ignition-gazebo/1081/1


fixing location issue

(ﾉ◕ヮ◕)ﾉ✲ﾟ｡⋆ You've made a PR!
Before the code PR is merged, please ensure that the following checklist is completed.

[ ] Branch name details the work done for the PR
[ ] CI tests have passed
[ ] An admin has reviewed and accepted the PR
[ ] Clang format has been run on changes (run format.sh)

Please be sure that the code follows the style as follows:

Everything in snake_case
Classes end in _c (unless its an interface, then end in _if)
Structs end in _s
Enumerations end in _e
Type names that are redefined via using end in _t (always use using - not typedef)

Description of work:
Please enter a description of your work here:

https://github.com/bosley/sauros/issues/94


It seems that .zcompcache does not work

I have completion module enabled, and it creates .zcompdump file. However, directly (file?) .zcompcache is not created.
I'm trying to get the completion for brew for instance. It shows up after a second delay each time, no caching.

HI! I remember having this issue a while ago. It had something to do with where was the function zrecompile being called or whether it was being called at all
if you have your dotfiles in a repo, around here, just make sure it's synced with your local version and let me kow, i can look into it.
Also the output from reporter could be of help =)

Thanks for reporting this. Unfortunately, I think this is an issue with homebrew and not prezto.
It looks like the _brew completion included with homebrew doesn't actually call any of the _store_cache, _retrieve_cache, or _cache_invalid functions (those are the functions which actually use the cache file you mentioned) so it makes sense that it wouldn't be created.
If you'd like improved zsh completions for homebrew, your best bet would be to file a bug against homebrew as we don't actually include any homebrew completion files with prezto.


Only show pending orders which belong to the current logged in wallet

Addresses https://github.com/Leasehold/ldex-ui/issues/20

Looks good, working on my local : )

I made it inline


fix(cli): Use an IPV6-enabled network in CLI's compose file

This PR changes two things:

Removes one of the compose files, reducing duplication. Now we can no longer get into a situation where the sync service definition is updated in one file but not in the other one.
Adds an IPv6-enabled network definition to the compose file and makes the electric service use that network.

Background
Beyond requiring support in the OS, the network router and the ISP, there are two more problems with using IPv6 for database connections:

it's not automatically enabled in Docker
an explicit network configuration needs to be added to the compose file when the sync service is started by docker compose

The first problem is relevant to those users who utilize docker run to start the sync service. The second problem currently makes our CLI unusable with IPv6 because the compose file bundled with it has no provisions for IPv6 networking. This PR address the latter.
Testing
I have tested connectivity from the sync service to a Supabase database over IPv6 and to a DigitalOcean Managed PostgreSQL over IPv4. Here's what I've learned:

Once IPv6 support has been enabled in the Docker daemon, it seems to persist even after the configuration file is removed and the daemon is restarted. For example, with IPv6 disabled in the Docker daemon (such that docker run ... curlimages/curl -6 https://ifconfig.co/ip fails to connect to the remote host) it is still possible to define an IPv6-enabled network in a compose file and the services started by docker compose will be able to connect to remote hosts over IPv6.
The compose file may include a minimalistic network definition that only includes the enabled_ipv6: true line. But for this to work, the Docker daemon must be configured with an IPv6 default pool. Otherwise, the network definition in the compose file has to include a subnet definition.
Alternatively, the network definition in the compose file may be marked with external: true to instruct docker compose to use a user-created Docker network instead of creating a new one.
The CIDR prefix configured in Docker daemon's default pool(s) and the subnet in the compose file do not need to match.
An IPv6-enabled network also supports IPv4 connectivity.

In summary, including a default IPv6-enabled network definition in our packaged compose file should work regardless of how users have their Docker daemon configured.
There is a potential for conflict, though. If there's already a Docker network on the machine that has an overlapping subnet with the one we define in our compose file, docker compose up will fail. To minimize the chances of conflicts, I have chosen a subnet with randomly generated groups that has the size of only 4 address. To make it fully conflict-proof, the compose file has three environment variables that can be used to either redefine the subnet or instruct docker compose to use a different, user-created Docker network by name.
Fixes #863.

I've tested the update implementation in the following scenarios, running a starter app on an Ubuntu DO droplet:

connect to Supabase using host networking by setting ELECTRIC_DOCKER_NETWORK_USE_EXTERNAL=host
connect to Supabase using a Compose-created network (default behaviour)
create a standalone Docker network with docker network create --ipv6 --subnet 2001:db8::/64 ip6net and connect to Supabase using the setting ELECTRIC_DOCKER_NETWORK_USE_EXTERNAL=ip6net
connect to a Crunchybridge database over IPv4, with DATABASE_USE_IPV6 set to either true or false

Also, we might want to switch the ELECTRIC_WRITE_TO_PG_MODE default to direct_writes rather than logical_replication since we're shifting to that soon (see #1342 and we've already updated examples and docs to use direct writes), cause when the --with-postgres flag was not detected the error I got was the LOGICAL_PUBLISHER_HOST not being set which can be confusing (as opposed to the "check your DATABASE_URL" error in direct_writes mode) - feel free to ignore this for this PR though

This needs to be addressed separately.

@alco fwiw I think this is ready to merge, if you're happy with it too!


Alter Wordsearch css to make solution a little easier to see

Based on this post https://www.xerte.org.uk/index.php/en/forum/accessibility/2255-word-search#6954 people are using wordsearch page but perhaps finding some aspects challenging.
John

Hi @FayCross @ronm123
Can you take a look at these changes when you get a chance to make sure that they work for you and please feel free to make any changes to aid accessibility - might not be best that it is so colourful but not really sure how else to address the issue that people were unable to locate their words when the Wordsearch is solved...

@JohnSmith-LT @FayCross I've just been testing this and I have to confess it's not a page type I've used much myself so apart from our page types demo examples I don't have much memory of using or testing this but noticed a few things...
When getting all the answers correct the whole grid turns green - has that always been the case? e.g. you get all the words and see them as strikethrough on the list of words but lose all indication of them in the grid itself because it's now just white letters on green squares. That doesn't seem right to me. Should the correct words just become white on green and the other squares remain black on white? I can see that we've got #puzzle .complete where the green can be changed but I'm not sure how we for instance change that to black text on white for the unused letters and perhaps white on green for the correct words?
There is a colours optional property with colour options for Select, Found, Complete and Solved but the main accessibility issue seems to be the #puzzle .highlight colour which is white text on yellow background by default and not part of the colours optional property. The yellow on my test is different to the yellow in your screenshot John but in both cases white on yellow isn't enough contrast so we should change that yellow and/or make it one of the optional properties so it's also under author control.
This also raises the question about what we should do for the high contrast and black on yellow themes? I guess the easiest would be to improve the contrast of the default colours (particularly the yellow) and not try to override these in the two accessibility themes.

@JohnSmith-LT @ronm123 The issue that Ron mentions with whole grid going green when you solve it (manually, not by clicking solve puzzle button) is a new bug. It works as expected in 3.10.5

Thanks @ronm123 and @FayCross for the feedback. So i've committed a fix for the contrast issues and I also noticed that when you tried to select a box that was already part of a solved clue then it didn't change to orange - fixed both
Regarding the letters all changing to green, I still don't know why that was happening but didn't before because the line that was doing it was indiscriminate and was in a file that I didn't even change... i've just commented it out for now...
Also, @ronm123 I didn't notice the Colours optional property before but I see that it works for the letter colours but something funky happens when solved and the word list changes to all of the same colours. I assume it's desirable to have these mixed also to show which were solved and which weren't? I'll work on t hat and also on adding the highlight as a colour option.
Here's what I see now when solved manually:

@JohnSmith-LT I duplicated my test page and removed some of the places for testing more quickly. With the default theme selected and no colours added I'm not getting the same colours as you e.g. no green  but purple and dark yellow when using the solve option and blue when solving manually. So manually correct looks like the following:

But I did also get an instance where I manually completed but the word on the right didn't strikethrough:

Hi @JohnSmith-LT all sounds good! Have run out of time today but will try to test again tomorrow and respond once I've tested.

@JohnSmith-LT @FayCross I've been testing this but have to go offline for an hour or so now so a few comments before I do...
With the custom colours added I get the following:
selecting - I get the select colour
on finding a word I get the found colour
after clicking solve puzzle any words not yet manually found become the complete colour and manually solved remain the found colour
Manually selecting and finding all the correct words the words become the found colour, the list of words are strikethrough and all the other tiles remain black on white.
Questions:
Is the above correct?
I see the highlight colour option in the editor but not when interacting with the page - what triggers the highlight colour?
Previously when the puzzle was manually solved all the tiles turned green. I think it's better now that the unused letters remain black on white and the solved words are still visible in the found colour but there isn't a more noticeable change or feedback that the puzzle is complete. Should the found words change to the complete colour after all the words are found? Should there be a feedback text option to display feedback/next steps etc?

@ronm123 I see this:

select: highlights letters as you click & drag with mouse to select words
found: the letters in the words I've found
complete: the words that I didn't find after clicking solve
solved: not used?
highlight: after whole puzzle complete (manually or solved on btn click) clicking a word will highlight the letters in the word on the grid

I think adding tooltips would make the purpose of each colour clearer. I'm not sure the solved colour is needed at all now - if we add some feedback text to say the activity is complete then that works better than relying on colour anyway.

If you add hide words optional property then you have no idea when the puzzle is solved (as you can't see crossed out word list and letters no longer turn green). Even if we don't add feedback then maybe something simple like a tick at bottom right of grid would indicate it's complete.
Also, when word list is hidden the layout isn't quite right as the space for the list is still there, just empty.

Hi @ronm123 ,so to add to what @FayCross has added:
I changed the solve/ended state to keep any that you found and any found using solve as different colours - that is different from before (but easy to change back) and thought it might be useful - I do notice though that the actual words list does just change to all the same colour and wondered whether similar functionality should be there.
When all found or solve clicked you are able to click a word or tab through the words to see them each highlighted - that perhaps does need conveyed to the users somehow as well as what the colours do mean...
I did also notice the issues with "hide words" and wondered whether simply showing the list once complete was enough to know that you had finished? That would also solve the layout issue. Or you could hide the words and show them each one by one once they are found?
Still work to do by the looks of things but it's improving...
I also did wonder about the colours at all, especially for accessibility purposes - I thought about 2 possible solutions:

Put a transparent canvas over the wordsearch and draw lines or bubbles on the canvas where the words are... the lines could be redrawn instead of a highlight with say a dotted or dashed line?

Or we could float a div for each word and rotate/position over the wordsearch for each word - the div could then be styled with round corners etc and dotted/dashed

I think each method could be made to work....

Sounds like a plan @ronm123


feat(paeckchen-cli): show update step and rebundle time

Coverage decreased (-0.5%) to 99.508% when pulling a84cc7676810a35335b6d9b6e79859de6e3ecb90 on cli/progress into 12048f76b9efb2ee2b5b7c1311ae3a303b957560 on master.

Coverage decreased (-0.5%) to 99.515% when pulling 3761b1b760b7ddef4387470bd6056f8d8efd59b9 on cli/progress into bb036babb38de663ccfb8d17dcdaf5ec598bb79b on master.


Can not support datetime with milliseconds?

I have a sqlite3 database have some records saved by Node.js. With an datetime column like 2017-04-23 10:53:11.252 +00:00  go-sqlite3 can not scan it to an time.Time variable, even can not scan to a string variable.

go-sqlite3 support following formats for timestamp.
https://github.com/mattn/go-sqlite3/blob/master/sqlite3.go#L129-L137

Closed


Include cartopy downloaded resources in GitHub Actions cache

Fixes #646
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

[ ] Documentation has been updated to reflect change.
[ ] New code has tests, and affected old tests have been updated.
[x] All tests and CI checks pass.
[x] Added an entry to the top of docs/source/changelog.rst
[ ] Conda lock files have been updated if dependencies have changed.
[ ] Attributed any Generative AI, such as GitHub Copilot, used in this PR.
[x] Marked the PR as ready to review.

I'm still a little concerned that there is a race condition if the documentation build finishes first, as then the cartopy resources won't be downloaded. Its probably fine though, as then we just fall back to what we had.

Eh, its probably fine. Worst case we can separate the docs cache from the other cache, but that would slow things down a bit.

Merging without review as this is a performance GH Actions tweak, and has no impact on CSET code.


HHVM-3.30 binary for Ubuntu

Due to upload size limit, we have to split the package into two. Therefore, if you are using Ubuntu and would like to install HHVM-3.30 for Mediawiki benchmark, please download hhvm-3.30-multplatform-binary-ubuntu.tar.xz in https://github.com/facebookresearch/DCPerf/releases/tag/hhvm

Could you please include the link in the README?

Fixed in ce4d59d


upgrade Python to v 3.8

Description of the change:
Upgrade Python to version 3.8 to facilitate local development (i.e. without having to resort to deadsnakes repos and suchlikes) and benefit from performance enhancements in more recent versions of Python (with 3.6 functionally mothballed now)
Motivation for the change:
The Ansible operator uses an outdated version of Python that hampers local development and reproducible builds as it requires you to keep around an old version of Python. Since many recent distros don't ship Python 3.6 in their standard packaging repositories anymore, this requires a manual install, or alternate package repositories.
Note: this is a first pull request to start addressing the issues mentioned in #4237
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[x] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

Re-committed to fix DCO signoffs

Re-committed to fix DCO signoffs

And what about the use of latest in the base image FROM registry.access.redhat.com/ubi8/ubi:latest?
Instead of pinning to a specific version I mean, for reproducibility purposes.
Tag 8.3-227 is at the moment the latest release: https://catalog.redhat.com/software/containers/ubi8/ubi/5c359854d70cc534b3a3784e.

And what about the use of latest in the base image FROM registry.access.redhat.com/ubi8/ubi:latest?
Instead of pinning to a specific version I mean, for reproducibility purposes.
Tag 8.3-227 is at the moment the latest release: https://catalog.redhat.com/software/containers/ubi8/ubi/5c359854d70cc534b3a3784e.

@dalbani that's a reasonable request. If ansible's base image is being pinned, helm's should as well. This should be done in a separate PR though.

@dalbani that's a reasonable request. If ansible's base image is being pinned, helm's should as well. This should be done in a separate PR though.

Great, thanks


PythonConsoleLexer bug: reordered traceback text

Example:
Lexer: PythonConsoleLexer (Python console session)
Input:
Traceback (most recent call last):
    ...
KeyboardInterrupt

Result:

KeyboardInterrupt
Traceback (most recent call last):
    ...

👆 Notice how the KeyboardInterrupt gets moved up above the Traceback line in the output
Versions

pygments version: 2.14.0
Also tested on https://pygments.org/demo/ 2023-01-31

Might be related to #2226?

Thanks for the report!


Research and decisions around which API to use in looking up OA copies based on DOI

We have discussed the use of two different API’s (unpaywall and open access button) for retrieving manuscripts which may be related to a provided DOI. There’s been some discussion around how the shape of the data looks from both API’s but there’s not been a decision yet as to which API to use (or if we’ll try to accommodate both). So there is a bit more discussion necessary.

Seems we've decided to focus on integrating only Unpaywall for an initial release. We could potentially add OpenAccessButton at a later time


Serve static assets from cloudfront

Changes in this PR
Serve static assets from cloudfront
JIRA ticket
https://national-archives.atlassian.net/browse/AYR-873

Looks good, noticed we haven't specified a region which it will use the default instead

Yeah I think thats just used if you havent already created the bucket, so I think its fine to omit here


new rule: single line block comment

All single line block comments should be // comments instead
/* this is pointless and only causes problems in nesting */
// this is how single line comments should look

I think that's a good idea.
But, for a friendly against vocode-tslint, please be aware of the performance.
The performance of the following TSLint-buildin-rules was slower than {no-regex-spaces or no-constant-condition }.
{whitespace,no-trailing-whitespace,no-consecutive-blank-lines,jsdoc-format,comment-format}
Maybe,  Lint.scanAllTokens(ts.createScanner） is 10 times slower than traversing  the AST-node.

I expect to Youres exemplary code that is better use of "typescript language service API".

👋 It would be nice indeed if that rule was not flagging JSX comments {/* ... */}.

Is this issue resolved with https://github.com/Microsoft/tslint-microsoft-contrib/commit/766aaa6465e69fdb909bf04c2a5db6d476d67bd0 ?

It should be 🙌


asking repeatedly to install net.core, tcc won't work

hi, everytime i open tcc, application says that needs net.core , i also tried to install both versions for windows ( 64 and 32 bit) but it won't work and everytime i open tcc, it always shows me that needs net.core. i tried to do a fresh installation, it won't work

You need to install the correct package - x64 Desktop Runtime: https://dotnet.microsoft.com/download/dotnet-core/thank-you/runtime-desktop-3.1.5-windows-x64-installer

ok, thank you very much. gonna try and then i'll write here if it's worked.

now it works! thanx again, cya!


Maven repo URL is outdated

The Maven plugin uses an outdated repo URL. This has started causing problems as the SSL cert for the outdated URL is incorrect.
The recommended URL for the Maven repository is https://repo.maven.apache.org/maven2/ - see
https://maven.apache.org/repository/

Thanks for reporting. Sonatype is working on a fix right now: https://issues.sonatype.org/browse/MVNCENTRAL-2870. Nevertheless, Gradle should use the URL for Maven Central that's recommended by Sonatype.

Working on MR now! 👍  First PR to Gradle so would need some review.

@kbarrette Could you point me to the piece of Maven documentation that states the canonical repo URL? I do not see it in the link you provided.

@bmuschko terribly, it's in the image map - "central CDN" in the central block.

@kbarrette Thanks, I would have never found it. ;-)

No problem - I would have submitted a PR, but for a one-line change like this, filling out the licensing release, etc seemed a bit heavy-weight :)

Should this fix get backported to previous major release numbers as well?

@JLLeitschuh I don't think we'll backport this change. repo1.maven.org is back in commission and should work as before. Any build stuck on an older version of Gradle can still use the canonical Maven repo URL by spelling it out via maven { url 'https://repo.maven.apache.org/maven2/' } instead of using the mavenCentral() shortcut if needed.

This is what Sonatype says at http://central.sonatype.org/pages/consumers.html
The canonical URLs for accessing Central are
HTTP: http://repo1.maven.org/maven2
HTTPS: https://repo1.maven.org/maven2

@twogee This is what the official Maven documentation says:
https://maven.apache.org/guides/mini/guide-mirror-settings.html

Note: The official Maven 2 repository is at http://repo.maven.apache.org/maven2 hosted in the US, or http://uk.maven.org/maven2 hosted in the UK.

The Sonatype docs might be outdated.

Just picking the nit: Sonatype docs say "canonical", Maven docs say "official" 😄


feat(Storage): GCS Retry- object uploads

Precondition and custom retry functions passing enabled while uploads.

Note: This PR is dependent upon storage-resumable-downloads as it uses Rest::addRetryheadersCallback which is defined in storage-resumable-downloads PR. Thus unit tests are expected to fail saying that function is undefined.


Threats, Risks, and Mitigations in the Open Source Ecosystem v1.1 [Markdown version]

This is a copy of the document "Threats, Risks, and Mitigations in the Open Source Ecosystem" (v1.1) written in Markdown. I hope there aren't any typos.
Feel free to contribute 🦄 🌈

I have improved the quality of the images and I have added alternative texts to the images. I'm not sure if my choices to make the document more accessible are good, but I have tried to follow these two guidelines:

"Accessibility For Everyone" by Laura Kalbag (Chapter: Graphs and infographics, page 81)
WebAIM, web accessibility in mind

Every contributes to improve this document and make it more accessible is welcome 🏳🌈

This really looks great, @luigigubello!


squeeze image

Could you please push an official squeeze image on github with sources.list pointing to archive.debian.org?

I worked with @paultag on this and together we put together https://hub.docker.com/r/debian/eol/ which contains every release from squeeze back to potato (which was the first release to fully use APT, and thus the earliest release debootstrap can create us a simple chroot for). :+1:
(Now I think it'd probably be prudent for us to add a link to that repo over on the README for the debian image. :smile:)

https://github.com/docker-library/docs/pull/535 :+1:


Make errorCode of InsertTimeOutOfBoundsFault consistent with others

The errorCode of this fault when serialized over the wire was being set to the name of the class InsertTimeOutOfBoundsFault instead of the CODE InsertTimeOutOfBounds. All other faults' errorCodes are serialized as the respective Fault's code, so making consistent here as well. I checked all existing fault's at the moment, and this was the only one I found to be inconsistent.
This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Nice catch, thanks @zachjsh.

https://tenor.com/view/thanks-american-psycho-christian-bale-gif-13090772

Nice catch, thanks @zachjsh.

Nice catch, thanks @zachjsh.


Fix mypy errors (pulse)

Summary
Following discussion, I'm splitting https://github.com/Qiskit/qiskit-terra/pull/8187 by module.
Details and comments
There is a set of fixes to comparators which should take object rather than specific type.

Another chunk of errors is due to the fact that Union[int, ParameterExpression] is appearing in different places where the experssion is considered to be int. I'm not sure whether it is annotation error, some runtime guaraties, or just type error. Example of those can be found in qiskit/pulse/library/parametric_pulses.py.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

125 of 130 (96.15%)  changed or added relevant lines in 17 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 85.409%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/pulse/channels.py
8
9
88.89%

qiskit/pulse/library/pulse.py
3
4
75.0%

qiskit/pulse/library/waveform.py
3
4
75.0%

qiskit/pulse/library/parametric_pulses.py
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

qiskit/pulse/library/parametric_pulses.py
1
47.09%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
67464

Relevant Lines:
78989

💛  - Coveralls

Not sure why I get TypeError: unsupported operand type(s) for |: 'type' and 'NoneType' even thought there is future import there

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

272 of 279 (97.49%)  changed or added relevant lines in 29 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 86.938%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/pulse/channels.py
8
9
88.89%

qiskit/pulse/transforms/canonicalization.py
10
11
90.91%

qiskit/pulse/transforms/dag.py
8
9
88.89%

qiskit/pulse/library/parametric_pulses.py
19
21
90.48%

qiskit/pulse/library/pulse.py
7
9
77.78%

Files with Coverage Reduction
New Missed Lines
%

qiskit/pulse/library/parametric_pulses.py
1
47.7%

crates/qasm2/src/lex.rs
2
91.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
74411

Relevant Lines:
85591

💛  - Coveralls

Ping @eggerdj @wshanks

@Randl You might be interested to know that this PR added a typing usage added in Python 3.11 but our requirements only had typing_extensions; python_version<3.11. We didn't catch that because on PRs we only run 3.8 and 3.12 tests. https://github.com/Qiskit/qiskit/pull/11487 installs typing_extensions unconditionally, so no other action is needed now and this issue shouldn't happen again.


Add staking endpoints

https://binance-docs.github.io/apidocs/spot/en/#staking-endpoints

PR  #234  with some implementation!! 3 endpoints todo:
https://binance-docs.github.io/apidocs/spot/en/#purchase-staking-product-user_data
https://binance-docs.github.io/apidocs/spot/en/#redeem-staking-product-user_data
https://binance-docs.github.io/apidocs/spot/en/#set-auto-staking-user_data


Create fold_array_unique aggregate function

Use case:
Users might want to get only unique values across all arrays in all rows.
Workaround SELECT DISTINCT UNNEST(array_column) FROM tab; in some cases not good as UNNEST gets applied first and DISTINCT has to operate with huge amount of data - and if final number of unique values is small keeping aggregated state small can leverage that to reduce memory usage.
If final number of uniques is very low, like 100-1000 and total amount of rows*elements_per_row is much more than that we can significantly reduce memory usage with some small overhead of adding into small HashSet.
Feature description:
fold_array_unique(column:array of comparable)
SELECT fold_array_unique(array_col) FROM tab returns same result as  SELECT DISTINCT UNNEST(array_col) FROM tab
['a','b','c']
['b','c']
['a']
['d']

would result to
['a','b','c','d']
fold_array_unique works like if array_agg had unique parameter and unfolded arrays like flatMap does in Java.
If users know that almost all values across all rows are unique than DISTINCT UNNEST might be better as overhead for keeping state unique would be also big.

I don't think there is much to be gained by a fold_array_unique function. At least not as a means to optimize SELECT DISTINCT UNNEST(array_column) FROM tab;
unnest operates lazy (one row at a time is projected into a set of rows). The distinct is consuming the source lazy as well. So there is no unnecessary intermediate materialization happening.
Think of it as xs.stream().flatMap(unnest).toSet(). If anything, a dedicated array-uniqueness function in-between would add redundancy and could end up slowing down the whole operation.


Update README.md

Fix to typos

Thank you for the PR. I will approve it soon. (I have no access to my GitHub at the moment.)
Sicher versendet mit Proton Mail.
Luca Fabbri @.***> schrieb am Sonntag, 30. Juni 2024 um 14:18:

Fix to typos

You can view, comment on, or merge this pull request online at:
https://github.com/Wervice/zentrox/pull/9
Commit Summary

1ca35d4 Update README.md

File Changes
(1 file)

M README.md (4)

Patch Links:

https://github.com/Wervice/zentrox/pull/9.patch
https://github.com/Wervice/zentrox/pull/9.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


fix: Change in CI main and cd-pages files

:tada: This PR is included in version 2.49.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.49.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Expectations to address

[x] Identify the question that survey will answer.
[x]  Identify the other questions that is planned to ask in the survey to identify confounding variables and  justify/explain why we plan to include them.
[x] Plan to analyze the survey results.
[x] Discuss the aspects of the UBC Office of Research Ethics document on Using Online Surveys that are relevant to our proposed survey.

Items addressed on Milestone 1 release


What version of SW do you use?

I use Solidworks 2016. But you are right that is it not clear. I'll note it in readme and add STEP files as well.

Thank you for your answer.


Use node-fetch over got for postinstall?

node-fetch is smaller, and we don't need these request libraries other than downloading youtube-dl

what's code size for node-fetch?

The main reason got is used is because it's one of the most used npm packages in the ecosystem and very actively maintained.
So fortunately at least one of your dependencies is going to install got and the cost will be 0.

If it's by download usage got stills behind node-fetch, I love got, I used it too, but node-fetch is a better option IMO.
Also @mapbox/node-pre-gyp now uses node-fetch instead of needle, plus I saw youtube-dl-exec usage increasing by discord.js bot developers where discord.js also uses node-fetch

what's the code size for node-fetch? asking because bundlephobia can't report the size

npm's reporting 75.9 kB for v3, but GNU/du is reporting 136K, unfortunately, node-fetch v3 is now pure ESM, meaning it can't be imported from commonjs directly (this is probably why bundlephobia can't report its size, probably it didn't support ESM packages, yet).
For node-fetch v2 npm's reporting 149 kB and GNU/du is reporting 172K, and this is the bundlephobia results

Thanks for clarifying!
Can you make a PR switching from got to node-fetch@2? 🙂

Thanks for clarifying!
Can you make a PR switching from got to node-fetch@2? I will be happy to merge it 🙂

Ah sorry for the late response, I can but seeing #38 is already opened, then we'll use that


[Feature] paimon-mysql-cdc supports parsing gh-ost ddl records

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
gh-ost is a triggerless online schema migration solution for MySQL.
When we use the gh-ost tool, it generates multiple DDL statements. For example, when adding a column c to table tb1 using the gh-ost tool, these DDL statements demonstrate how gh-ost works.
DROP TABLE IF EXISTS `menghuiyu`.`_tb1_gho`
DROP TABLE IF EXISTS `menghuiyu`.`_tb1_del`
DROP TABLE IF EXISTS `menghuiyu`.`_tb1_ghc`
create /* gh-ost */ table `menghuiyu`.`_tb1_ghc` (\n\t\t\tid bigint auto_increment,\n\t\t\tlast_update timestamp not null DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,\n\t\t\thint varchar(64) charset ascii not null,\n\t\t\tvalue varchar(4096) charset ascii not null,\n\t\t\tprimary key(id),\n\t\t\tunique key hint_uidx(hint)\n\t\t) auto_increment=256
create /* gh-ost */ table `menghuiyu`.`_tb1_gho` like `menghuiyu`.`tb1`
alter /* gh-ost */ table `menghuiyu`.`_tb1_gho` add column c varchar(255)
create /* gh-ost */ table `menghuiyu`.`_tb1_del` (\n\t\t\tid int auto_increment primary key\n\t\t) engine=InnoDB comment='ghost-cut-over-sentry'
DROP TABLE IF EXISTS `menghuiyu`.`_tb1_del`
rename /* gh-ost */ table `menghuiyu`.`tb1` to `menghuiyu`.`_tb1_del`
rename /* gh-ost */ table `menghuiyu`.`_tb1_gho` to `menghuiyu`.`tb1`
DROP TABLE IF EXISTS `menghuiyu`.`_tb1_ghc`
DROP TABLE IF EXISTS `menghuiyu`.`_tb1_del`

MySQL CDC captures these DDL statements and synchronizes them to the sink, the sink cannot recognize the gh-ost tables (_tb1_gho, _tb1_ghc, _tb1_del) in these DDL statements and we only need to synchronize the alter operation to the sink. Therefore, we need to extract the alter statement and restore the gh-ost tables to the original table tb1.
The above is referenced from #7750 of apache-inlong
Currently paimon cannot handle this situation, related issue：#3364、#3450
Solution
No response
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Is there any progress on this feature？
@MOBIN-F


Change size of span

Does new DotSpan(5, color) and new DotSpan(1,color) have a difference in radius ? cause when i implement those Object into dayViewFacade, i get the same size of DotSpan around the date.
I also want to set the size of span ( drawable / dotspan ) but where can i found the setting of span size at this lib ?

Hi @byanjati, I just tested changing the size of the DotSpan and it works. The constructor takes a radius in pixels, so if you are on a high density device it might look the same.
Could you post the code for your decorator? That might help.


Update index.html for the theme animation and reponsive design

New Theme
First and foremost, I’ve completely revamped the theme of the application. The new color scheme incorporates a striking blend of purple, blue, and black, creating a modern and visually appealing interface. I aimed for a balance between aesthetics and readability, ensuring that the colors are not only stylish but also easy on the eyes.
Added Animations and Transitions
In addition to the new theme, I’ve introduced various animations and transitions throughout the app. These enhancements provide a more dynamic feel as users interact with the to-do list. For instance, items now smoothly fade in and out when added or removed, and there are subtle hover effects that make the interface feel more responsive. I believe these additions will make the user experience more enjoyable and engaging.
Responsive Design
I’m also pleased to announce that the to-do list is now fully responsive. This means that it will adapt seamlessly to different screen sizes, whether users are on a desktop, tablet, or mobile device. I prioritized functionality on smaller screens, ensuring that users can easily navigate and manage their tasks regardless of the device they’re using.
Description
New Theme: The design now features a sleek purple, blue, and black color palette.
Animations and Transitions: I’ve added animations to enhance the user experience and make interactions smoother.
Responsive Design: The to-do list is now fully responsive, ensuring a great look and feel on all devices.
Fixes #(55)
Type of change
UI change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change)
[ ] New feature (non-breaking change)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so that they can be reproduced.

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

It's working on mine
On Sat, 12 Oct, 2024, 2:09 pm Ansh Grover, @.***> wrote:

@Bhumika-00 https://github.com/Bhumika-00 please try to run npm run lint
and npm run format because checks are failing here.
—
Reply to this email directly, view it on GitHub
https://github.com/Groverio/To-Do-List/pull/69#issuecomment-2408460028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVVHVPVEWQN3UBECDF3Z3DN3ZAVCNFSM6AAAAABP2GTDS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGQ3DAMBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

You are just rejecting everyone 's work you could have wait for sometime
On Sat, 12 Oct, 2024, 2:14 pm Bhumika Sharma, @.***>
wrote:

It's working on mine
On Sat, 12 Oct, 2024, 2:09 pm Ansh Grover, @.***>
wrote:

@Bhumika-00 https://github.com/Bhumika-00 please try to run npm run
lint and npm run format because checks are failing here.
—
Reply to this email directly, view it on GitHub
https://github.com/Groverio/To-Do-List/pull/69#issuecomment-2408460028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVVHVPVEWQN3UBECDF3Z3DN3ZAVCNFSM6AAAAABP2GTDS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGQ3DAMBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

That's highly unprofessional behaviour
On Sat, 12 Oct, 2024, 2:15 pm Bhumika Sharma, @.***>
wrote:

You are just rejecting everyone 's work you could have wait for sometime
On Sat, 12 Oct, 2024, 2:14 pm Bhumika Sharma, @.***>
wrote:

It's working on mine
On Sat, 12 Oct, 2024, 2:09 pm Ansh Grover, @.***>
wrote:

@Bhumika-00 https://github.com/Bhumika-00 please try to run npm run
lint and npm run format because checks are failing here.
—
Reply to this email directly, view it on GitHub
https://github.com/Groverio/To-Do-List/pull/69#issuecomment-2408460028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVVHVPVEWQN3UBECDF3Z3DN3ZAVCNFSM6AAAAABP2GTDS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGQ3DAMBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have made the new files and still there is workflow issue I really don't
know what the problem with the code because its running on my device
smoothly now I have done my task in all possible manner now I would like to
you review it if the pr can get accepted or not
On Sat, 12 Oct, 2024, 2:15 pm Bhumika Sharma, @.***>
wrote:

That's highly unprofessional behaviour
On Sat, 12 Oct, 2024, 2:15 pm Bhumika Sharma, @.***>
wrote:

You are just rejecting everyone 's work you could have wait for sometime
On Sat, 12 Oct, 2024, 2:14 pm Bhumika Sharma, <
@.***> wrote:

It's working on mine
On Sat, 12 Oct, 2024, 2:09 pm Ansh Grover, @.***>
wrote:

@Bhumika-00 https://github.com/Bhumika-00 please try to run npm run
lint and npm run format because checks are failing here.
—
Reply to this email directly, view it on GitHub
https://github.com/Groverio/To-Do-List/pull/69#issuecomment-2408460028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKOHTVVHVPVEWQN3UBECDF3Z3DN3ZAVCNFSM6AAAAABP2GTDS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGQ3DAMBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Multiple code preview toggles not working

Hi,
I have included a MyButton.md file along side a MyButton.vue file and included a few code examples in it. The VUE|HTML toggle only renders for the first example.
Does this happen for just myself or is it a bug? Seems like a bug because it happens if I include multiple examples in a markdown file or Vue file?
Thanks
Andy

On coming back to this, it creates buttons for all the examples but places them all in the first example. I've had a go at trying to fix it but my skills and time aren't the best at the moment.
Seems to have gone quite of this repo, so I'll carry on trying to fix it myself.


Boolean property of FormulaPropertyValue class can be Nullable

Boolean property in Src/Notion.Client/Models/PropertyValue/FormulaPropertyValue.cs class can be Nullable.

Related #43


fixed reader logic to support chunked messages

Fixed reader logic to support the case when between chunks of one message the reader receives the chunks from another message or not chunked message.
more info https://github.com/grafana/loki/issues/5644
Notes for Reviewers

[ ] The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
[ ] Sync up with the author before merging

Yep, thanks. I have fixed all issues in reader and reader_test files.
The rest of the issues are not related to this PR. I decided to not fix it here to not add redundant changes to this RP.
 golangci-lint run
gelf/tcpreader.go:115:19: Error return value of `conn.SetDeadline` is not checked (errcheck)
                conn.SetDeadline(time.Now().Add(2 * time.Second))
                                ^
gelf/udpwriter_test.go:244:12: Error return value of `io.Copy` is not checked (errcheck)
        go io.Copy(ioutil.Discard, r)
                  ^
gelf/udpwriter_test.go:252:17: Error return value of `w.WriteMessage` is not checked (errcheck)
                w.WriteMessage(&Message{
                              ^
gelf/udpwriter_test.go:270:12: Error return value of `io.Copy` is not checked (errcheck)
        go io.Copy(ioutil.Discard, r)
                  ^
gelf/udpwriter_test.go:278:17: Error return value of `w.WriteMessage` is not checked (errcheck)
                w.WriteMessage(&Message{
                              ^
gelf/udpwriter_test.go:296:12: Error return value of `io.Copy` is not checked (errcheck)
        go io.Copy(ioutil.Discard, r)
                  ^
gelf/udpwriter_test.go:304:17: Error return value of `w.WriteMessage` is not checked (errcheck)
                w.WriteMessage(&Message{
                              ^
gelf/writer.go:21:2: `addr` is unused (structcheck)
        addr     string
        ^
gelf/writer.go:23:2: `hostname` is unused (structcheck)
        hostname string
        ^
gelf/writer.go:25:2: `proto` is unused (structcheck)
        proto    string
        ^
gelf/tcpreader.go:13:2: `conn` is unused (structcheck)
        conn     net.Conn
        ^

Yep, thanks. I have fixed all issues in reader and reader_test files. The rest of the issues are not related to this PR. I decided to not fix it here to not add redundant changes to this RP.

Yes do not worry about pre-existing linting issues :slightly_smiling_face: