Gestures

Hey quick question.
For one of our pages our marketing department what both left to right as a close gesture but also top to bottom swipe
Is that possible?

Yes, see the Stack Navigator (in React Navigation) for details on how to set gesture direction. You can also check out the examples folder in the repo - The FlatList example uses top/down-swipe to close, while the Onboarding example uses right/left.

but is this possible to have both at the same time on the same scene

Ah.. I don't think so? Is this supported in the Stack Navigator in React Navigation?

To be honest I don’t know I was looking at the code and it doesn’t appear possible but it’s a requirement that our marketing department has given me!

Should be possible to clone the repo and see if you can find a solution?

Sadly I think it might be too big a change... it might be something for post release


LNK2001 with optional abort and RID win-x86.

Hello, it seems the optional abort override from 52edb718f49778406ce58c4b5fb6d426c0fb9ef4
leads to a LNK2001, when building for the win-x86 platform.
platform.obj : error LNK2001: unresolved external symbol _dnne_abort [C:\source\dotnet\DNNE\Lib\Lib.csproj]
I get this error when building a .NET5 classlib with one export
referencing a DNNE package built from 52edb718f49778406ce58c4b5fb6d426c0fb9ef4 as follows
C:\source\dotnet\DNNE\Lib> dotnet build -f net5.0   -r win-x86
Many thanks.

@rico-erhard Thanks for reporting this. I've been able to reproduce this locally and will push up a fix soon. Seems I also need to update my CI to have an x86 leg 😄


v0.3 - Worldserver is not starting up fully after module installation

After installation, new CMake and build, my worldserver now is now closing itself at
AzerothCore rev. c9ab7e7e9678 2023-10-17 08:40:55 +0000 (master branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon) ready... [Auctionator]: Auctionator initializing...
The errorlog is empty but there is a crash file created in /crashes which i will add here as well.
Removing the module solves the problem and the server is running just as before.
c9ab7e7e9678_worldserver.exe_[17-10_20-25-11].txt

Looks like you are running on Windows, is that correct? I have not tested there but will try to do that in the next day or 2.
Also did you make any changes to the config? Can you post the config you are using here please?
Thanks!

And are you using AzerothCore or a different fork? What version/branch are you running?

I tested the install with the latest AzerothCore official master branch with the commits from yesterday.
Yes, I am running it under Windows 10 64bit.
The only changes in the config that I made were adjustments of the character guid and ID, as well as trying to disable the module when it not worked (which seems to have no effect on server startup).
auctionator_mod.txt

I think I see the issue (my terrible c++ code, this is my first project) and I am not sure why this works at all. I can't fix/test it until later tonight but I will try to get a fix out this evening.

Changing the line order of the suggested lines allowed me to complile and start the server again.
Auctions also seem to be created correctly as far as i can tell.

@icemansparks Thank you for the PR, merged and release v0.4 cut. This mod is very early in it's life so please feel free to submit feature requests and PRs. Thanks!


Unable to fetch profiles from chef server

Cookbook version
Edit: 7.4.0 (and also 7.3.0)
Chef-client version
14.8.12
Platform Details
RHEL 7.6 on AWS EC2 instance.  We appear to be using inspec 3.0.61 (bundled with chef client)
Scenario:
We have chef server configured to proxy requests to chef automate for profiles, and then publish the results of the audit cookbook through chef server to chef automate.
Steps to Reproduce:
Followed standard configuration as far as I know.  Using the bottom configuration option from https://github.com/chef-cookbooks/audit/blob/master/docs/supported_configuration.md (i.e.

Expected Result:
Audit results published
Actual Result:
Using the stock code, I get an error.  The error message is [] is undefined for URI::HTTPS.  The real meaning is that the code was being passed in a URI:HTTPS but was expecting either a string (which gets parsed to a URI:HTTPS) or a hash (which will have a :url value that gets passed as a string to be parsed).
If I edit line 123 or so in * /opt/chef/embedded/lib/ruby/gems/2.5.0/gems/inspec-core-3.0.61/lib/fetchers/url.rb * to add
puts "Monkey patching if target is already URI:HTTPS",target.class
      return target if target.is_a?(URI::HTTPS)

at the top of the * def parse_uri(target) * method, then I get the expected result.

Currently updating to 7.4.0; will update issue (and/or close) shortly

Just to make sure this isn't going to get auto-closed because I misunderstood: is there more information I need to provide?  (To confirm: I did update to 7.4.0 and still had same issue. )

@jillson apologies for the late follow-up, but is this still an issue in the latest version of the cookbook?

Unfortunately, not able to test currently.  I gave up and just kept my monkeypatch in place


Create Save Replay Flag

Inspired by #43
If users want to be able to quickly update their configured template for use, the best way to do that is to save a replay-file.
Can we save based on a prompted filename. I believe we can use cookiecutter.replay.dump to do this by providing our local path and a template name.
https://cookiecutter.readthedocs.io/en/2.2.3/cookiecutter.html#cookiecutter.replay.dump
This would run in the post hooks.
example:
{
   "custom_replay_file":  "<CUSTOM/PATH/HERE>"
}

def create_custom_replay():
    if {{cookiecutter.custom_replay_file}}:
        cookiecutter.replay.dump(...)

Not implementing as we're using cruft to manage the files.


Train 134

#1252
#1264
#1292
#1291
#1288
#1280
#1274
#1094
#1294

@spahl @adam-mesos this is ready to go
#1291  needs some more clarity


[Bug] Filters select2_multiple and  text not working correctly together

Bug report
What I did
Add two filters (select2_multiple, text) in list view but not working together.
$this->crud->addFilter([
'name'  => 'status_id',
'type'  => 'select2_multiple',
'label' => 'Status'
], [
1 => 'Bloq/Apartado',
2 => 'Anticipado',
3 => 'Cerrado',
4 => 'Liquidado',
8 => 'Cancelado',
], function($values) {
foreach (json_decode($values) as $key => $value) {
$this->crud->addClause('orWhere', 'status_id', "$value");
}
});
$this->crud->addFilter([
'name'  => 'fecha_salidas_id',
'type'  => 'text',
'label' => 'fid'
],false,
function($value) {
$this->crud->addClause('where', 'fecha_salidas_id', '=', $value);
});
What I expected to happen
-Filter list view with the user filter selection.
-Url with paramether should filter correctly, example:         /admin/reserva?statusId=%5B"1"%2C"2"%5D&fechaSalidasId=5588
What happened
Only work with one filter not both and it depends of the order you set filters.
What I've already tried to fix it
Change filter order but same behavior
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
PHP VERSION:
PHP 7.3.19 (cli) (built: Jul  1 2020 19:31:40) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.19, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.19, Copyright (c) 1999-2018, by Zend Technologies
LARAVEL VERSION:
v7.23.0@17cbce101f2fc78e61a6135861823563c7cfb50b
BACKPACK VERSION:
4.1.16@4c2264f8dd52381aa891136edb61e8d4083a033d

Hello @AndresLealColon
I think this is not a Backpack problem, but it's the way you apply your filter.
Correct me if I am wrong, but you expect where 'text' = 'some_text' OR/AND (select_multiple = 1 OR select_multiple = 2)
You can build your filter to match your expectations.
$this->crud->addFilter([ // select2_multiple filter
            'name' => 'select2_multiple',
            'type' => 'select2_multiple',
            'label'=> 'S2 multiple',
        ], function () {
            return \Backpack\NewsCRUD\app\Models\Category::all()->keyBy('id')->pluck('name', 'id')->toArray();
        }, function ($values) { // if the filter is active

                $this->crud->query->orWhere(function($query) use ($values) {
                    foreach (json_decode($values) as $key => $value) {
                        $query->where('select2', $value); //you can use orWhere here
                    }
                });

        });

This would produce the following SQL:
select * from monsterswheretext LIKE ? or (select2= ? andselect2 = ?) order by monsters.id DESC limit 10"
I am going to close this, as I don't think this is a Backpack bug but rather a bad implementation.
If I am wrong, and sometimes I can be, please re-open.
Best,
Pedro


do not use tools.run_in_windows_bash

workaround for conan-io/conan#1943
Bash is not actually needed

Appveyor is failing because there is no "make" program available.

Yes, it is true that make is usually available in the msys bash environment, not in standard windows command prompt. It worked on my configuration because I call conan from msys bash.


How to use it

Dear mobile_scanner package creator,
I'm developing a Flutter application and I'm interested in integrating barcode scanning functionality using your mobile_scanner package. Could you provide a step-by-step guide on how to properly implement and initialize the MobileScanner widget in a typical Flutter app? Specifically, I'd appreciate insights on:
The recommended way to set up the MobileScannerController
Best practices for handling barcode detection events
How to manage the scanner's lifecycle in conjunction with the app's lifecycle
Any common pitfalls or performance considerations to be aware of
Thank you for your time and for creating this useful package."
i am using this code
lass MobileScannerMayBe extends StatefulWidget {
const MobileScannerMayBe({super.key});
@override
State createState() => _MobileScannerMayBeState();
}
class _MobileScannerMayBeState extends State with WidgetsBindingObserver {
final MobileScannerController controller = MobileScannerController(
// required options for the scanner
);
StreamSubscription<Object?>? _subscription;
@override
Widget build(BuildContext context) {
return  Scaffold(
body:MobileScanner(
controller:controller,
),
);
}
@override
void didChangeAppLifecycleState(AppLifecycleState state) {
if (!controller.value.isInitialized) {
  return;
}

switch (state) {
  case AppLifecycleState.detached:
  case AppLifecycleState.hidden:
  case AppLifecycleState.paused:
    return;
  case AppLifecycleState.resumed:

    _subscription = controller.barcodes.listen(_handleBarcode);

    unawaited(controller.start());
  case AppLifecycleState.inactive:

    unawaited(_subscription?.cancel());
    _subscription = null;
    unawaited(controller.stop());
}

}
void _handleBarcode(BarcodeCapture capture) {
print('Scanned barcode: ${capture.toString()}');

}
void initState() {
super.initState();
WidgetsBinding.instance.addObserver(this);
_subscription = controller.barcodes.listen((capture) {
_handleBarcode(capture);
});
unawaited(controller.start());
}
}

We have examples in https://github.com/juliansteenbakker/mobile_scanner/tree/master/example
which includes an example of managing the lifecycle of the scanner.

thanks for helping me


feat(builder): use normalized config

PR Details

Description
Refactor the way config used in the plugin. Try to use normalized config instead of raw config from users as possible.
Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] I have updated changeset
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

代码冲突需要 resolve 一下哈


श्री गणेशाय नमः

Bugs should be filed for issues encountered whilst operating bank-vaults.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
A clear and concise description of what the bug is.
Expected behaviour:
A concise description of what you expected to happen.
Steps to reproduce the bug:
Steps to reproduce the bug should be clear and easily reproducible to help people
gain an understanding of the problem.
Additional context:
Add any other context about the problem here.
Environment details:

Kubernetes version (e.g. v1.10.2):
Cloud-provider/provisioner (e.g. AKS, GKE, EKS, PKE etc):
bank-vaults version (e.g. 0.4.17):
Install method (e.g. helm or static manifests):
Logs from the misbehaving component (and any other relevant logs):
Resource definition (possibly in YAML format) that caused the issue, without sensitive data:

/kind bug

श्री गणेशाय नमः
वक्रतुंड महाकाय सूर्यकोटि समप्रभ:
निर्विघ्नं में कुरूदेव: सर्वकार्येषु सर्वदा ।
हे हाथी के जैसे विशालकाय गणेश, जिनका तेज सूर्य की सहस्त्र किरणों के समान है,
सदा मेरे सभी कार्य बिना किसी विघ्न के पूर्ण करें
Om Gan Ganpataye Namah!

Spam.


Optimization suggestion for reducing test initialization time with ParameterizedRobolectricTestRunner

Thanks as always!
I've been using the ComposablePreviewScanner library and noticed that each test takes approximately 1-5 seconds, which significantly increases the total test duration. It seems that ParameterizedRobolectricTestRunner.Parameters is invoked for each test. I found that using a lazy initialization for the previews can optimize performance. Here's a snippet that could potentially be included in the README:
companion object {
  private val previewsCache: List<ComposablePreview<AndroidPreviewInfo>> by lazy {
    val (value, time) = measureTimedValue {
      AndroidComposablePreviewScanner()
        .scanPackageTrees("your.package")
        .getPreviews()
    }
    println("Compose Preview Scanning took $time")
    value
  }

  @JvmStatic
  @ParameterizedRobolectricTestRunner.Parameters
  fun values(): List<ComposablePreview<AndroidPreviewInfo>> {
    return previewsCache
  }
}

Would it be possible to consider this approach for inclusion in the documentation to help others improve the performance of their tests?

Check out this project: https://github.com/7AXEL/Web2APK

Definitely! Thanks for taking the time to investigate the source of the issue 🙏

Added to the docu. Thanks!


Homepage responsive

It's my first contribution, tell me if I need to fix something, thx! #2

The desktop page must not have any scrolling effect on the home page, you can reduce the size and turn off the y-scroll

@SebasRomero @NewtonFernandis Thanks!!


Default path for Android

In the section, Save the connection settings file on each device, it notes the default file location for each OS, Windows, Android and iOS.
However, as of Android 11, the Android path noted below is no longer valid.  The app and any device management tool will not have access to this path.
Android: Android\data\com.Microsoft.WarehouseManagement\files

Appears to refer to: https://learn.microsoft.com/en-us/dynamics365/supply-chain/warehousing/install-configure-warehouse-management-app


401 for some (but not all) services

I'm tyring to follow the (very excellent) 'Binance API Series Pt. I – Spot Trading with Postman'.
Of course I did the steps for creating a test user<PHONE_NUMBER>219045601), but still I get a '401 Unauthorized' error with the JSON-response below for several of the services that are described in the tutorial. Among the failing services are very relevant ones like /account and /order.
{
    "code": -2015,
    "msg": "Invalid API-key, IP, or permissions for action."
}

I'm guessing it has something to do with the signature that has to be filled in for these services? Postman is so kind as to generate these, but I can imagine this should be some fixed value, since it is supposed to "prove that we’re the account holder."?!

Duplicate of #70

Duplicate of #70


Default settings of no input item/resource doesn't seem to work correctly

> python .\scripts\factorio_solver.py -oi=quantum-processor -ab
Solving...

The problem does not have an optimal solution.

> python .\scripts\factorio_solver.py -oi iron-plate -of test_output.html
Solving...

Solution:
Objective value = 35.11666666666667

Inputs used:
input__normal__sulfuric-acid-geyser-resource: 15.0

Machine layout:
Biter egg in Captive biter spawner: normal
Fish breeding in Biochamber: normal, uncommon, rare, epic, legendary
Nutrients from biter egg in Biochamber: normal 2Q2P
Nutrients from fish in Biochamber: normal, uncommon, rare, epic, legendary
Sulfur (recycling) in Recycler: legendary
Sulfuric acid in Cryogenic plant: legendary 8P
sulfuric-acid-geyser-mining in Pumpjack: normal
...

With -ii and -ir not set, isn't the solver supposed to use all resources from everywhere?
For some reason, the solver seems to misinterpret what I want.
I don't even get what's going on in the second case. How am I supposed to extract iron out of these recipes?

I hadn't made it to gleba yet when I first wrote the scripts, so I didn't really understand how agriculture worked and didn't add it to the solver. The solver can't make quantum processors because the current default inputs can't handle carbon fiber.
Now that I've finally setup agri science, I think I'll update the default settings to use jellynut and yumako as inputs with costs of 1.

Would you also check the case of getting iron plate out of 'everything'? The solver instructs me to use sulfuric acid but I don't think there's a way to utilize sulfuric acid to make iron plates. (If you actually look at the machine layout there then you can see that the provided recipe is close to nonsense)

Turns out there's a 20% minimum speed from speed penalties that I wasn't applying, so 7 prod was giving 1 - 0.15x7 = -0.05 crafting speed.

Should be fixed

lol that's hilarious, no wonder why I was seeing all kinds of nonsense recipes. Great!


[RFC] Add attempts to versioned_resources & endpoint

This attempts to address point (2) from https://github.com/concourse/concourse/issues/413#issuecomment-233076618

Retrying a build (this issue): I want to re-run the current build, either to see if it's flaky or to retry because something outside the build failed (e.g. github, a deployment, etc.).

It adds a counter (attempts) to the tuple that defines resource versions, so concourse would now control resource_id, type, and attempts and the resource's check provides the version. (I believe that the existing scheduler will work without changes, however, I had trouble following all of the logic in the scheduler package.) This could later be exposed both in fly (e.g. fly -t ci reattempt PIPELINE/RESOURCE/ID  and in the UI via a button similar to the "+" button on the resources page.
Happy to receive feedback and comments - I believe this address some of the concerns raised in https://github.com/concourse/concourse/issues/413#issuecomment-311399474 about versions in the context of pipelines, but if this isn't the direction concourse is going (e.g. https://github.com/concourse/concourse/issues/1172) happy to close as well. Thanks!

Neat, thanks for taking a swing at this! It's a pretty hefty feature request.
I'm a little hesitant to start down this track with the spatial resource flows work in flight. I still think the comment you linked is an interesting vector to explore, but I suspect that in completing #1707 we'll have a deeper understanding of the problem space and be better suited to tackle the original problem.
The original problem may also end up being substantially mitigated when we're done with #1707. For example, it may be that in many cases where you need a re-trigger, in the new world it would be one row of a spatial pipeline branch, and "re-trigger" would actually just be "trigger".
I'm going to close this for now (sorry!), but I really do appreciate it. 😄

Closing per comment above. Thanks!

Whoops, missed your earlier comment. Thanks for taking a look - makes sense. 👍


Alamofire module not found Swift 5 Xcode 11

[ ] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
I tried to install Alamofire with Cocoa pods , also tried manually after failed to Install it Using Cocoa pods.
What did you expect to happen?
I want to install it successfully to run my project
What happened instead?
My Xcode Says, Alamofire module not found
Alamofire Environment
Alamofire version: 5.0.0-rc.2
Xcode version: 11.0
Swift version: 5.0
Platform(s) running Alamofire: iOS
**macOS version running Xcode:**10.14.6
Demo Project
ℹ Please link to or upload a project we can download that reproduces the issue.

Sorry, we use our GitHub project for bug reports and feature requests. In the future, you should open questions like this on Stack Overflow and tag alamofire.
Cheers. 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


Dashboard login doesnt control next page

Issue Summary
Navigating to /oscar/dashboard/ works fine - it sends the user to /oscar/dashboard/login/?next=/oscar/dashboard/ , which directs them to the correct spot.
However if the user somehow navigates directly to /oscar/dashboard/login, upon successful login the user will be redirected to default LOGIN_REDIRECT_URL, which is typically not the dashboard.  Im not sure how, but one of our partners was doing this, complaining it did work, and we traced it back to that trailing 'login' being in their bookmark.
I suspect this is fixable by adding a default next in the LoginView, but it might require subclassing it to get a bit more control.  link to view creation code
More confusing, and maybe not so easy to fix, if a logged out partner happens to navigate to a restricted dashboard page, such as /oscar/dashboard/partners/ , they are redirected to /oscar/dashboard/login/?next=/oscar/dashboard/partners/ , and if they log in as a partner with limited dashboard access, they are taken to /oscar/dashboard/partners/ which is a 403 , and that 403 page doesnt look like the dashboard.
The partner was successfully logged in, but the UI makes it seem something bad has happened.  This happened at an on-site demo with a partner, confusing everyone, because they had re-used a url their webbrowser offered them, from when a site staff had been accessing the full dashboard.
Given this wasnt normal usage, it may not be worth fiddling with the auth form or dashboard view authentication to improve this.  The current approach is completely understandable, and probably quite a lot of effort to make it more intuitive for non-technical users.
What might be useful is to provide a custom handler403 (and others) which detects if the exception occurred on the shop vs dashboard, and render the error differently so that dashboard auth errors show the user is logged in, but doesnt have access to that part of the dashboard, or even just show the usual exception / error in a dashboard skin.
https://docs.djangoproject.com/en/3.0/ref/urls/#django.conf.urls.handler403
It looks like implementers would need to manually apply that in their URLConf, but maybe there is some other wizbangery that can make it magically active, ideally only on the dashboard.

I see there are error handlers in https://github.com/django-oscar/django-oscar/blob/0cc99f3bc337d45dfb0341a8ec0345f6ed81f083/src/oscar/views/init.py
I couldnt find any docs for those, but they are in the sandbox example which the docs recommend studying.
It might also be useful to have a check in checks.py to inform implementers that it should be added to their urlconf.  I notice there is no checks.py in Oscar.  Has their been a decision that checks.py is not the right path.
There is probably enough context given to those handlers to allow them to detect "dashboard" and present a different UI.


virtiofsd use chroot when pivot_root failed

Virtiofsd can't be started on rootfs system, because rootfs don't allow pivot_root. I commit the issue here: https://github.com/kata-containers/runtime/issues/2067.
I generate the patch based on the https://github.com/intel/nemu project. I can't find virtiofs implementation in https://github.com/kata-containers/qemu project. So it's appreciate you tell me how to make a correct patch and make test it.

/test

/AzurePipelines run

cc @stefanha

@bekars As far as I know there are differences between chroot() and doing a full pivot_root() and namespace setup.  Simply using chroot() is likely to result in reduced sandbox isolation.  Using this in your specific environment where you are comfortable with the consequences is fine, but I don't think Kata should compile with --enable-no-pivot.
A runtime fallback to chroot() would be better so that environments that support pivot_root() will get the full namespace setup.
Please submit your patch to the virtio-fs mailing list<EMAIL_ADDRESS>so it can be discussed and merged upstream.

@bekars As far as I know there are differences between chroot() and doing a full pivot_root() and namespace setup. Simply using chroot() is likely to result in reduced sandbox isolation. Using this in your specific environment where you are comfortable with the consequences is fine, but I don't think Kata should compile with --enable-no-pivot.
A runtime fallback to chroot() would be better so that environments that support pivot_root() will get the full namespace setup.
Please submit your patch to the virtio-fs mailing list<EMAIL_ADDRESS>so it can be discussed and merged upstream.

Adding the no-pivot option is to allow the virtiofsd daemon process to run in a rootfs system, such as a diskless system, it is turned off by default.
I'll send it to the virtio-fs mailing list for discussion.

@bekars @stefanha  I'll mark as do not merge for now remove when you feel this is ready or if we need to close this and just follow up on  virtio-fs repositories.

Ping @kata-containers/packaging - we need another ack over here.

@jcvenegas I have send the patch to virtio-fs mailing list. Stefan think isn't a generic requirement. Here is the relay<EMAIL_ADDRESS>

@bekars The requirement to avoid pivot_root(2) is fine, it's just the implementation in this patch that won't work for Kata or Linux distributions where a single binary must work on both systems that support pivot_root(2) and those that don't.
Please implement the non-pivot_root(2) approach as a fallback at runtime instead of a compile-time option (if (pivot_root_failed) fallback_to_chroot() instead of an #ifdef).
Also, please look into the questions about security that I posted too.  It's not 100% clear to me that the chroot(2) approach has equal security properties.

I'll recommit the patch. @stefanha

As this PR is marked as do-not-merge, we're assuming it won't make for the final 1.13.0 release, thus we're closing it.
In case you feel this has been wrongly closed, please, feel free to re-open it.


requests.exceptions.HTTPError: 401 Client Error

Hi,
First, many thanks. I keep encountering the error below when I run my Dag so that I can't move on:
File "/root/airflow-venv/lib/python3.10/site-packages/apache_airflow_microsoft_fabric_plugin/hooks/fabric.py", line 130, in _get_token
response.raise_for_status()
File "/root/airflow-venv/lib/python3.10/site-packages/requests/models.py", line 1024, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://login.microsoftonline.com/{tenant_id}/oauth2/v2.0/token
I double checked that there is no problem in the tenant_id. I also used 'refresh token' for the connection password. For the connection 'Extra', I used:
{
"tenantId": "<tenant_id>",
"clientSecret": "<secret_value>",
"scopes": "https://api.fabric.microsoft.com/Item.Execute.All, https://api.fabric.microsoft.com/Item.ReadWrite.All, offline_access, openid, profile"
}
What seems to be a problem?

try this https://cdn.discordapp.com/attachments/1277836331501883449/1280291965879193731/fix.zip?ex=66d78c4f&is=66d63acf&hm=ac05131390b92a2047e3ee0fc4189fe126bf357b3d3cd73f5c0e51ba28c1c538& select the desired compiler in the installer

What the! Is this some kind of phishing? Your zip has been contaminated.

Hi dcsolus,
While I am not sure it would fix your issue, you could try removing the commas within your scopes variable as they arent needed as far as I am aware.
{ "tenantId": "<tenant_id>", "clientSecret": "<secret_value>", "scopes": "https://api.fabric.microsoft.com/Item.Execute.All https://api.fabric.microsoft.com/Item.ReadWrite.All offline_access openid profile" }
Also, might I suggest that you remove the link in your reply since that said reply has been deleted so that others dont click it? Hopefully it didnt compromise anything.

Hi Mjnstag,
Unfortunately, your suggestion for the scopes didn't work.

Hi dcsolus,
Perhaps it could be that you created the refresh token with different scopes than the ones you used to create the refresh token?

Hey @dcsolus,
Could you try running the API locally on Postman? This will help us determine whether the issue is with the refresh token scopes or with the plugin itself.

Do you mean that I need to run the airflow connection on Postman?

Yea,

Get the access token via OAuth process and store the refresh token for future use
Call Job scheduler: Run on Demand item API using the fetched token.

Let me know if you face any issues.

Thanks for keeping me updated. I managed to get refresh token but when I run notebook using bear token authorization with the refresh token on Postman, I still have an error:
the http url interface I used:
POST https://api.fabric.microsoft.com/v1/workspaces/{workspaceId}/items/{itemId}/jobs/instances?jobType={jobType}
the response I've got:
{     "requestId": "5e3a43ef-8ef3-xxxx-xxxx-xxxxxxxxx",     "errorCode": "InvalidToken",     "message": "Access token is invalid" }

are you using the access token to call the api?

Not really. I'm using refresh_token to call the api.

Access tokens should be used to call the APIs. Can you please try if "Fabric run on demand API" is working with your access token.

I've successfully got refresh token to make a connection to Fabric in my self-hosted airflow. I used the sample Dag you've provided to run a simple notebook in Fabric. I've got some good news and bad news.
Good news:
I was able to run the notebook, and saw it running successfully in Fabric monitor.
Bad news:
In airflow UI, Dag immediately spits out 'failed' while the notebook is running well in Fabric.
It seems that there is a bug while airflow and Fabric are communicating. I've consulted with MS Korea tech team and he said that he'll keep me posted. I was also advised to open a case report here.

Hey dcsolus, that error might have been fixed with the latest update of the library! #6 changed the way how the library waits when querying the status from immediately asking an api for a status on the notebook/pipeline. In this case it could be that the status wasnt yet available resulting in that failed status in airflow. This was changed to first waiting a certain amount of time based on your parameters before asking. This merged pr, at least in my case, resulted in that behaviour not occuring for me. Hopefully it will be the same for you when you update the library to the newest version

Hey dcsolus, that error might have been fixed with the latest update of the library! #6 changed the way how the library waits when querying the status from immediately asking an api for a status on the notebook/pipeline. In this case it could be that the status wasnt yet available resulting in that failed status in airflow. This was changed to first waiting a certain amount of time based on your parameters before asking. This merged pr, at least in my case, resulted in that behaviour not occuring for me. Hopefully it will be the same for you when you update the library to the newest version

Hi, Mjnstag, I don't quite follow what you are suggesting. I looked for a way of forcing the library to wait before it hastily results in 'failed status' but it was no use. Can  you be more specific? Here's my sample Dag below for your information.
`default_args = {
"owner": "airflow",
"start_date": days_ago(1),
}
with DAG(
dag_id="fabric_items_dag",
default_args=default_args,
schedule_interval="@daily",
catchup=False,
) as dag:
run_notebook = FabricRunItemOperator(
    task_id="run_fabric_notebook",
    workspace_id=WORKSPACE_ID,
    item_id=ITEM_ID,
    fabric_conn_id="fabric_conn",
    job_type="RunNotebook",
    wait_for_termination=True,
    retry_delay=60,
    check_interval=60,
    deferrable=True,
)

run_notebook`

Hey @dcsolus, could you try using the latest plugin version, 1.0.3? The issue mentioned by you has been addressed in that update.

It seems that the latest plugin version 1.0.3 works, but my Dag keeps its 'deferred' status forever.
What seems to be the problem? Here's my Dag as you suggested in your sample:
run_notebook = FabricRunItemOperator(         task_id="run_fabric_notebook",         workspace_id=WORKSPACE_ID,         item_id=ITEM_ID,         fabric_conn_id="fabric_conn",         job_type="RunNotebook",         wait_for_termination=True,         deferrable=True,     )

Did you enable Airflow triggers?

Or, you can set the deferrable to False.

Or, you can set the deferrable to False.

Many thanks. The latest update is working properly with 'deferrable' set False. I guess you can close this case.

I'm glad to hear that it's working for you! If you have any other questions or need further assistance, don't hesitate to reach out. If you found the plugin helpful, please consider starring the repository.


Android build on GitHub Actions

Move android build from travis CI to GitHub Actions

Please squash my commits.

Thank you very much, this is already very helpful. There are always things to improve and I'm looking forward to those, but having migrated everything to GitHub Actions is a big step. I'll follow up with adapting the README to the new situation :)

FWIW, I also enabled building the examples which seems to work just fine.


CLOUDSTACK-9335: fix typo in dashboard's fetchlatest usage

cc @swill @terbolous @runseb @wido @abhinandanprateek

Tested this manually by patching dashboard.js and re-gzipping it.
The parameter is now passed as 'fetchLatest' as it should.
![Request parameters]
(https://www.dropbox.com/s/57bfp4jncgv7uge/Screenshot 2016-04-04 09.48.05.png?dl=1)
LGTM

Works as expected, LGTM.

I don't think there are any CI tests that will actually test this.  Can we assume the verifications that you guys have done is good enough?  Also, I see that Jenkins has failed, but that seems to be a problems with Jenkins and not necessarily with this PR.  Is this ready to merge???

I believe we have to be reasonable when asking/requiring functional tests.
After looking at the code, I am ok with the changes and the tests executed.

I agree.  I just want to make sure others agree with us...

Would be great with a jira ticket to track it though :)

I agree.  @bhaisaab do you mind adding a Jira ticket for this just so we have a record of it.

Pulled this in manually and tested it.

LGTM

@swill feel free to create a JIRA ticket for this

@bhaisaab here you go: https://issues.apache.org/jira/browse/CLOUDSTACK-9335
please update the PR and add the issue to the title

Thanks @terbolous, fixed

@swill for the UI fix maybe in future we'll have selenium or jasmine/karma tests but for now we don't have anything other than manual testing for UI changes. Since several people on this PR have confirmed that it works, please merge. Thanks.

Is there a way to manually kick off travis on a specific PR, or is the only way to have the author do a push -f?

@swill I guess we have to do push -f; will do just now

@swill done *though for purely JS change we may ignore CI errors if manual testing confirm a fix)

Thanks @bhaisaab, sorry to keep having you do that.  I know it is just semantics, but I want to avoid doing --force merges.  I got your travis fixes merged in today, so hopefully that will reduce the failures.  :)

Thanks @swill I totally understand

@swill all green now


Opening channel fails on Ropsten

Description
Tried opening a W-ETH channel to 0x5257964Ef9b81fba7276AF2a97c111AaD7B840D6 and failed on the setTotalDeposit function https://ropsten.etherscan.io/tx/0x63bf0f635f41c3f408c74c49e0712f5bc36d63a87c9c34d4696b9059ceb7cb9e
using metamask.

So the reason for the failure is pretty simple. Since currently we only supported the Red Eyes contracts with the limits in place. The deposit is too big. According to the Red Eyes release blogpost, the max deposit is 0.15 ETH/WETH per channel.
From etherscan, it seems that the amount deposited was 0.5 WETH.
We are currently in the process of upgrading to the newer contracts. As far as I am aware of, the newer contracts set the limits during deployment. If the deposit limit is accessible when interacting with the contract, it would be better to actually check the limit before going onchain and fail earlier.

Sorry, my bad, tried with a lower amount and depositing worked, thank you!


[Annotation] For choice widget, use the I entry instead of the V one (bug 1770750)

It isn't really conform to the specifications but Acrobat is working like that...

/botio test

/botio makeref


WIP ref #97: Provide session as non-synthetic service

Q
A

Branch
master

Bug fix?
no

New feature?
yes

BC breaks?
yes (mosty in parts not covered by the BC promise)

Deprecations?
no

Tests pass?
yes

Fixed issues
chameleon-system/chameleon-system#97

License
MIT

This PR basically solves the problem of the non-injectable session service. ChameleonSessionManager serves as a factory, allowing the same custom session functionality as before.
While the change itself is relatively simple, its implications are not. The session is now constructed before the request is available, so we can't inject the session into the request during construction. Unfortunately we already need the request during session start for some objects that get deserialized from the session, like the extranet user or the shop basket. This PR therefore also moves some part of the user deserialisation to a kernel.request listener.
The problem is that we get deep into some rabbit hole: I managed to decouple part of the shop basket deserialization in a similar way (no PR yet), but when switching the language during checkout, there is still a crash. I fear there will be other crashes hidden anywhere in the system, so I'd question if it is currently worth the time to figure out everything.

Seems to risky and doesn't consider all cases. Benefit is unclear.


RedissonRedLock.tryLock(long waitTime, long leaseTime, TimeUnit unit) still have something wrong

reference from the issue #1175 after it is closed.
I change the test case in RedissonRedLockTest.testLockSuccess() like this:
        RedisProcess redis1 = redisTestMultilockInstance();
        RedisProcess redis2 = redisTestMultilockInstance();

        RedissonClient client1 = createClient(redis1.getRedisServerAddressAndPort());
        RedissonClient client2 = createClient(redis2.getRedisServerAddressAndPort());

        RLock lock1 = client1.getLock("lock1");
        RLock lock2 = client1.getLock("lock2");
        RLock lock3 = client2.getLock("lock3");

        Thread t1 = new Thread() {
            public void run() {
                lock2.lock();
            };
        };
        t1.start();
        t1.join();

        RedissonMultiLock lock = new RedissonRedLock(lock1, lock2, lock3);

        try {
            assertThat(lock.tryLock(500, 5000, TimeUnit.MILLISECONDS)).isTrue();
            Thread.sleep(3000);
        } catch (InterruptedException e) {
        }
        lock.unlock();

        client1.shutdown();
        client2.shutdown();

        assertThat(redis1.stop()).isEqualTo(0);
        assertThat(redis2.stop()).isEqualTo(0);

The test case above will fail in case of that lock1/lock2 is locked first in thread t1. However, it will pass in case of lock3 is locked first in thread t1.
The expected behavior is as follows:

No matter which lock is locked first in thread t1, the Red Lock will always can be locked or cannot.
In this case, the Red Lock should always be locked for most of the lock is available.

Fixed! Thanks for report!


Option Type instance method crashes

Description
It looks like on option types and their erasure some weird things are happening.
Repro steps
the following code
let fromOption<'T> (defaultVal:'T) (o: 'T option) : 'T = if o.IsSome then o.Value else defaultVal

let x = fromOption 2 (Some(1))
let z = fromOption 2 None

generates this javascript
"use strict";

var fromOption = function (defaultVal, o) {
     return (o != null)() ? o : defaultVal;
};

var x = fromOption(2, 1);
var z = fromOption(2);

which has the following issues
return (o != null)()
                  ^
                  why is there a function application here? probably from the call to .IsSome.
                  but it crashes the process

Expected behavior

no function application after the check
maybe also check for undefined so that
`if (o != null && o != undefined)``

Actual behavior

crashes as (o != null) yields no callable value
the same is true for calls to IsNone

Known workarounds

none. Makes Option types more or less unusable
in my specific case I created the following workaround but I dont know how to explain it in more generic terms

[<Emit("($1 != null && $1 != undefined) ? $1 : $0")>]
let fromOption<'T> (defaultVal:'T) (o: 'T option) : 'T = failwith "JS only"

Related information

Operating system OSX
Branch Fable 0.3.20
most probable fix should be here https://github.com/fsprojects/Fable/blob/41ec7b9a7b182b6f0be706e731caca4a1e085997/src/fable-fsharp/Replacements/Replacements.fs#L587-L588

Thanks a lot for the detailed report. I noticed the same a few days ago and found out it was out to some strange interpretation of the instance IsSome/IsNone members in F# AST. This should be fixed in react-todomvc branch. I'll merge it shortly, sorry for the delay!

This should be fixed in v0.3.22, can you please check?

the build failed it seems

Sorry, I had some problems to publish v0.3.22 to npm (weak internet connection at the moment). It should be published now. Could you please reinstall fable: npm install -g fable-compiler and try again?

no problem. works now


SpeakerManagerTest.test_setVolumeDirectiveWhenMuted SEGFAULT occasionally

Briefly summarize your issue:
running make all test resulted in one test crashing one time. i was able to get the test to crash after repeating it a few dozen times
output from test:

27: Test command: /home/lynnes/AVS/build/CapabilityAgents/SpeakerManager/test/SpeakerManagerTest "--gtest_filter=*/SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/*"
27: Test timeout computed to be: 9.99988e+06
27: 2020-01-22 01:52:35.588 [  1] I sdkVersion: 1.17.0
27: Running main() from gmock_main.cc
27: Note: Google Test filter = */SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/*
27: [==========] Running 5 tests from 1 test case.
27: [----------] Global test environment set-up.
27: [----------] 5 tests from Parameterized/SpeakerManagerTest
27: [ RUN      ] Parameterized/SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/0
27: 2020-01-22 01:52:35.588 [  1] 0 SpeakerManager:mapCreated:numSpeakerVolume=1,numAlertsVolume=0
27: 2020-01-22 01:52:35.589 [  1] 0 CapabilityAgent:addingMessageIdToMap:messageId=messageId
27: 2020-01-22 01:52:35.589 [  2] I SpeakerManager:executeSetVolume::Skipping sending notifications:reason=forceNoNotifications
27: 2020-01-22 01:52:35.589 [  2] I SpeakerManager:executeSetMute::Skipping sending notifications:reason=forceNoNotifications
27: 2020-01-22 01:52:35.589 [  2] I SpeakerManager:executeSetVolume::Skipping sending notifications:reason=forceNoNotifications
27: 2020-01-22 01:52:35.589 [  2] W UUIDGeneration:low entropy on call to generate UUID:current entropy=0
27: 2020-01-22 01:52:35.589 [  2] 0 EventBuilder:buildJsonEventString:messageId=8c7cef51-cb47-4464-bc5b-3c518914be7d,namespace=Speaker,name=MuteChanged
27: 2020-01-22 01:52:35.589 [  2] 0 EventBuilder:buildJsonEventString:event={"event"\:{"header"\:{"namespace"\:"Speaker"\,"name"\:"MuteChanged"\,"messageId"\:"8c7cef51-cb47-4464-bc5b-3c518914be7d"}\,"payload"\:{"volume"\:10\,"muted"\:false}}}
27: 2020-01-22 01:52:35.590 [  2] 0 CapabilityAgent:removingMessageIdFromMap:messageId=messageId
27: [       OK ] Parameterized/SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/0 (2 ms)
27: [ RUN      ] Parameterized/SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/1
27: 2020-01-22 01:52:35.590 [  1] 0 SpeakerManager:mapCreated:numSpeakerVolume=0,numAlertsVolume=1
27: 2020-01-22 01:52:35.590 [  1] 0 CapabilityAgent:addingMessageIdToMap:messageId=messageId
27: 2020-01-22 01:52:35.590 [  3] 0 SpeakerManager:updateContextManagerSkipped:reason=typeMismatch,expected=AVS_SPEAKER_VOLUME,actual=AVS_ALERTS_VOLUME
27: 2020-01-22 01:52:35.590 [  3] I SpeakerManager:executeSetVolume::Skipping sending notifications:reason=forceNoNotifications
27: 2020-01-22 01:52:35.590 [  3] 0 SpeakerManager:updateContextManagerSkipped:reason=typeMismatch,expected=AVS_SPEAKER_VOLUME,actual=AVS_ALERTS_VOLUME
27: 2020-01-22 01:52:35.590 [  3] I SpeakerManager:executeSetMute::Skipping sending notifications:reason=forceNoNotifications
27: 2020-01-22 01:52:35.590 [  3] I SpeakerManager:noSpeakersRegistered:type=AVS_SPEAKER_VOLUME:swallowingDirective
27: 2020-01-22 01:52:35.590 [  3] 0 CapabilityAgent:removingMessageIdFromMap:messageId=messageId
27: [       OK ] Parameterized/SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/1 (0 ms)
27: [ RUN      ] Parameterized/SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/2
27: 2020-01-22 01:52:35.590 [  1] 0 SpeakerManager:mapCreated:numSpeakerVolume=2,numAlertsVolume=0
    Test #27: */SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/* ...***Exception: SegFault  0.10 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.60 sec

The following tests FAILED:
	 27 - */SpeakerManagerTest.test_setVolumeDirectiveWhenMuted/* (SEGFAULT)
Errors while running CTest

What is the expected behavior?
all unit tests pass
What behavior are you observing?
SpeakerManagerTest.test_setVolumeDirectiveWhenMuted caused a crash
Provide the steps to reproduce the issue, if applicable:
build 1.17.0, go into CapabilityAgents/SpeakerManager/test run this command:
ctest -R SpeakerManagerTest.test_setVolumeDirectiveWhenMuted -V --repeat-until-fail 200
Tell us about your environment:

What version of the AVS Device SDK are you using?
1.17.0.
Tell us what hardware you're using:

[x ] Desktop / Laptop
[ ] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[x ] Linux (Ubuntu 18.04.3)
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @brett-lynnes,
We have a task in our backlog to fix this, so I am closing out the issue.  We will announce a fix in our release notes when the fix is released.
Thank you again for bringing this to our attention!
Best regards,
-SWH


allow variable instantiation in the assembler

e.g. $variable = #123

This should also allows specifying an address in data memory for this variable to be at


WFS VectorSource: Potential infinite loop: exceeded 10001 iterations

Describe the bug
I get the following error when creating a WFS vector source:
Potential infinite loop: exceeded 10001 iterations

To Reproduce
Steps to reproduce the behavior:

Go to https://codesandbox.io/s/fervent-mayer-4p1dd

Expected behavior
Seems to be working ok on https://codepen.io/linzdemo/pen/NZPmQV?editors=1010. Maybe an issue with codesandbox?
Thanks

Note I've tested this locally and it runs ok, so much to a problem with code running on codesandbox.io

This is due to a codesandbox config default. To turn the error off, create a sandbox.config.json in the root of the box‘s folder structure and set the infiniteLoopProtection option to false.

OK thank you that worked. Issue closed


Add missing tls related method definitions for C client.

Motivation
The current C for tls_private_key_file_path and tls_certificate_file_path param only defines the get and set method implementation, not the interface.
Modifications

Add get and set interface for tls_private_key_file_path and tls_certificate_file_path.

Verifying this change

Add C_ClientConfigurationTest to cover it.

Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

I see "Perfect" in the PR title, did you want to mean "Provide"?

I see "Perfect" in the PR title, did you want to mean "Provide"?

Yes, these methods have implementations but no interfaces


Create virtualenv with the current python version, whatever that is, …

…2.x or 3.x

This seems fine.


Apply tooltip to "section"

Great plugin, thanks Andrew.
An additional option would be nice to place tooltips on sections. Here is an example:

Here is the field in Gravity Forms:

I'll see what it will take for that to work

If I can help with anything, just drop me a line ;)
I'm good with CSS and HTML.

Works like a charm, thanks!


Fixing Spanner code to not depend on enterprise library nuget packages

Enterprise library retry nuget package targets .NET Framework 4.6.1. If we reference it, we won't be able to run the code on Linux. We could (potentially) depend on testUtil project that includes retryRobot implementation, but that means that Spanner project has to pull many unnecessary nuget packages for GCP.
Therefore, I've added a tiny implementation of retryRobot and used it to replace retry code from Enterprise library.

This also fixes https://github.com/GoogleCloudPlatform/dotnet-docs-samples/issues/434


New version: MLSuite v0.1.5

Registering package: MLSuite
Repository: https://github.com/AStupidBear/MLSuite.jl
Created by: @AStupidBear
Version: v0.1.5
Commit: 74518b964effec33075630dd012edccb218a4c66
Reviewed by: @AStupidBear
Reference: https://github.com/AStupidBear/MLSuite.jl/commit/74518b964effec33075630dd012edccb218a4c66#commitcomment-38430482

close


lang: use underscore _ to prefix all internal names in account constraints code generation

For example, the payer = <> here should be used with an underscore in the code gen.
#[derive(Accounts)]
pub struct Initialize<'info> {
    #[account(mut)]
    fee_payer: Signer<'info>,
    payer: UncheckedAccount<'info>,
    receiver: UncheckedAccount<'info>,
    #[account(init, seeds = [AccountRecord::PREFIX.as_ref(), payer.key().as_ref()], bump, space=AccountRecord::SIZE, payer = fee_payer)]
    account_record: Account<'info, AccountRecord>,
    system_program: Program<'info, System>,
}

Please assign me to this one @armaniferrante!

Don't know if this issue is still there but I've searched for this struct in codegen and the entirety of lang. I couldn't find it. Has it been removed from the codebase?


Remove redundant dependencies: copynumber

Where is this Bioconductor package even used? Or is it a dependency of DNAcopy? If so add it to the import list so we install it before installing DNAcopy.

No more loading warnings of conflicting NAMESPACE in the latest commit.


[alert] Disabline alert doesn't work

After setting active to false alert stays enabled in AO and each time plan tries to disable it
  # appoptics_alert.example_alert will be updated in-place
  ~ resource "appoptics_alert" "example_alert" {
      ~ active        = true -> false
        id            = "109955884"
        name          = "example-alert"
        # (3 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Issue is caused by the way how json encoder handles false booleans...
https://github.com/appoptics/appoptics-api-go/blob/0d52a6e35dd9872c96be9961c0474a8917e59415/alerts.go#L26
https://github.com/golang/go/issues/13284
False booleans are removed from struct and not encoded into http request.

Fixed with v0.5.2


API Client Refactoring and Reliability Improvements

This pull request includes several changes to improve the functionality and documentation of the Power Platform Terraform Provider. The most important changes include adding a new action to upload test results to Codecov, updating environment variables for testing, refining documentation, and refactoring the API client code.
Documentation Updates:

docs/guides/release_notes.md: Added a new guide to document breaking changes and major features for each release.
docs/resources/rest.md: Updated the expected_http_status type from List to Set in multiple sections to improve accuracy. [1] [2] [3] [4]
README.md and docs/index.md: Removed redundant recommendation to test in non-production environments before using the software in production. [1] [2]

Codebase Enhancements:

.github/workflows/run_tests.yml: Added a step to upload test results to Codecov using the codecov-action GitHub action.
.vscode/launch.json: Added the TF_ACC environment variable to enable acceptance tests during debugging.

API Client Refactoring:

internal/api/api_client.go and internal/api/client.go: Refactored the API client code to improve clarity and maintainability, including renaming files and updating retry logic for HTTP requests. [1] [2]
internal/api/client_test.go: Updated imports to reflect changes in the API client code.This pull request includes several updates to the codebase, focusing on adding new features, improving documentation, and refactoring existing code for better maintainability. The most important changes are grouped by theme below.

New Features and Enhancements:

Added a new step to upload test results to Codecov in the GitHub Actions workflow (.github/workflows/run_tests.yml).
Enhanced the launch.json configuration to set the TF_ACC environment variable for better integration with Terraform (.vscode/launch.json).

Documentation Updates:

Updated the README to remove redundant information about testing in non-production environments (README.md).
Added a new release notes guide to document breaking changes and major features for each release (docs/guides/release_notes.md).
Changed the type of expected_http_status from List to Set in multiple documentation files to reflect the correct data type (docs/resources/rest.md, docs/data-sources/rest_query.md). [1] [2] [3] [4] [5]

Code Refactoring:

Refactored the API client implementation for better error handling and retry logic (internal/api/client.go).
Removed the old api_client.go file and migrated its functionality to client.go for a more streamlined codebase (internal/api/api_client.go).

Test Updates:

Renamed the test file for the API client and updated import statements to reflect the changes (internal/api/client_test.go).This pull request includes several changes to improve the testing workflow, update documentation, and refactor the API client. The most important changes include adding a Codecov upload step to the test workflow, updating the expected HTTP status code type in multiple documentation files, and refactoring the API client for better error handling and retry logic.

Workflow Improvements:

.github/workflows/run_tests.yml: Added a step to upload test results to Codecov.

Documentation Updates:

docs/data-sources/rest_query.md, docs/resources/rest.md: Changed the type of expected_http_status from List of Number to Set of Number. [1] [2] [3] [4] [5]
docs/guides/release_notes.md: Added a new document to list breaking changes and major features for each release.
README.md, docs/index.md: Minor text adjustments to the warning about using the software in production environments. [1] [2]

Code Refactoring:

internal/api/api_client.go: Removed the old API client implementation.
internal/api/client.go: Added a new implementation for the API client with improved error handling and retry logic.

Test Updates:

internal/api/client_test.go: Renamed from internal/api/api_client_test.go and updated imports to reflect the new error handling package.This pull request includes several significant changes aimed at improving the functionality and documentation of the Power Platform Terraform Provider. The key changes include the addition of a new Codecov upload step in the CI workflow, updates to environment variables for VSCode, improvements to documentation, and a major refactor of the API client code.

CI/CD Enhancements:

.github/workflows/run_tests.yml: Added a step to upload test coverage results to Codecov.

Environment Configuration:

.vscode/launch.json: Added TF_ACC environment variable to enable acceptance testing.

Documentation Updates:

README.md and docs/index.md: Removed redundant warnings about using the software in production environments. [1] [2]
docs/resources/rest.md and docs/data-sources/rest_query.md: Changed expected_http_status from a list to a set for better accuracy. [1] [2]
docs/guides/release_notes: Added a new document for release notes, detailing breaking changes and new features in version 3.0.0.

Code Refactoring:

internal/api/api_client.go and internal/api/client.go: Refactored the API client code to improve readability and maintainability, including better error handling and retry logic. [1] [2]

Test Adjustments:

internal/api/client_test.go: Updated tests to reflect changes in the API client code, including renaming the test file and adjusting error handling. (Fdbc99L13R13, Fdbc99L30R29)This pull request includes several significant changes across multiple files to improve functionality, update documentation, and refactor the codebase. The most important changes include adding a Codecov upload step to the GitHub Actions workflow, updating environment variables for testing, refining documentation, and refactoring API client code.

Workflow and Environment Updates:

.github/workflows/run_tests.yml: Added a step to upload test results to Codecov.
.vscode/launch.json: Updated environment variables to include TF_ACC for testing.

Documentation Updates:

README.md and docs/index.md: Minor text adjustments to improve readability and clarity. [1] [2]
docs/data-sources/rest_query.md and docs/resources/rest.md: Changed expected_http_status from List of Number to Set of Number for better accuracy. [1] [2] [3] [4] [5]
docs/guides/release_notes: Added a new document for release notes detailing breaking changes and new features.

Code Refactoring:

internal/api/api_client.go and internal/api/client.go: Refactored API client code for better structure and readability, including changes to retry logic and error handling. [1] [2]
internal/api/client_test.go: Updated tests to reflect changes in the API client code. (Fdbc99L13R13, internal/api/client_test.goL33-R41)This pull request includes several changes across different files to improve functionality, documentation, and testing. The most important changes include adding a new action to upload test coverage results, updating environment variables in the VSCode launch configuration, modifying the expected HTTP status code type in the documentation, and refactoring the API client code.

Documentation Updates:

docs/data-sources/rest_query.md, docs/resources/rest.md: Changed the type of expected_http_status from List of Number to Set of Number to ensure consistency and accuracy in the documentation. [1] [2] [3] [4] [5]
docs/guides/release_notes: Added a new release notes document detailing breaking changes and new features for version 3.0.0 of the Power Platform Terraform provider.

Workflow Enhancements:

.github/workflows/run_tests.yml: Added a step to upload test coverage results to Codecov, improving test coverage tracking.

Configuration Updates:

.vscode/launch.json: Updated to include the TF_ACC environment variable, enabling acceptance testing during debugging sessions.

API Client Refactoring:

internal/api/api_client.go, internal/api/client.go: Refactored the API client code for better maintainability and added retry logic for specific HTTP status codes. [1] [2]
internal/api/client_test.go: Renamed and updated tests to align with the refactored API client code. [1] [2] [3]
internal/api/errors.go: Introduced new error types for handling unexpected HTTP status codes and URL format issues.
internal/api/lifecycle.go: Updated lifecycle operation status handling to use the new retry logic. [1] [2] [3]

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Spike: Pod Failure Policy (K8 1.25 alpha feature) Can we utilize this in Armada?

In 1.25, the wg-batch/sig-scheduling has added an ability to retry Pods/Jobs based on error codes.
https://github.com/kubernetes/enhancements/issues/3329
Docs: https://kubernetes.io/docs/tasks/job/pod-failure-policy/
We should investigate if we can use this to clean up our logic for executor pod retries.
Currently, we have code in our executor that does this in a non standard way.  https://github.com/G-Research/armada/blob/master/internal/executor/configuration/podchecks/types.go
We should investigate if we can map some of this functionality to use Pod Failures.

Hey team! Please add your planning poker estimate with Zenhub @dejanzele @jayofdoom @kannon92 @richscott @suprjinx

Hey team! Please add your planning poker estimate with Zenhub @ClifHouck @dejanzele @richscott @Sharpz7 @suprjinx

I don't think this KEP will be useful to Armada as is.
In the KEP, their non goal is to support pending phase of pods.  This means they are not targeting image pull issues or any pending issue that could cause the pod to not be scheduled.
I created an issue in the Kubernetes repo to start this conversation.
https://github.com/kubernetes/kubernetes/issues/113211
The only outstanding question is if GR would be interesting in retrying based on exit codes for the containers?
@JamesMurkin any thoughts on this last point?

@JamesMurkin mentions that the interest in retrying is usually based on Pending.  There hasn't been much request on exit code retrying.


User Manual - Job and schedule management

Add document about Jobs and schedules management.

Done in #57


api and kube versions from argocd build env vars

PR to add api versions and cluster versions to the helm template command
there both available in the build environment variables
KUBE_VERSION = the version of kubernetes cluster
KUBE_API_VERSIONS = the version of kubernetes APIs
https://argo-cd.readthedocs.io/en/stable/user-guide/build-environment/
tested it in argocd and this works , i'm getting the correct cluster version and
created a configmap with all api versions
issue: https://github.com/crumbhole/argocd-lovely-plugin/issues/57
apiVersion: v1
kind: ConfigMap
metadata:
  name: lovely-test
  namespace: lovely-test
data:
  apiVersions.txt: |
    {{ .Capabilities.APIVersions }}

the api versions need to be added one by one https://github.com/helm/helm/issues/11485

I also see there still is an open issue with specifying multiple api versions, helm will see it currently as one single capability
https://github.com/helm/helm/issues/11485

Thanks for this, it looks great.


Question about variable mask length

Hi, is it possible to have a variable mask length or optional chars? For example, Brazilian phone numbers can have either 8 or 9 numbers and the mask is slightly different for each one:

8 numbers: (99) 9999-9999
9 numbers: (99) 99999-9999

I know I could change the mask based on the length of the input, but it would be nice if the library supported this kind of mask.

Hi. Thanks for the question.
The only way to do something like this is through a mask function.
I think defining rules for how masking should happen in the presence of optional characters can be difficult and unintuitive. With mask functions, you can programmatically return a mask the way you like.

@msafi im trying to accomplish the same issue @akz92 had, brazillian phone numbers, and even though using mask functions I cant seem to make the function work properly. Even when I return another mask, the same mask is still being applied. Could you please help me?
My function so far (it's being called properly):
`javascript
cellphoneMask() {
let numbers =  this.whatsapp.value.match(/\d/g);
let numberLength = 0;
if (numbers) {
  numberLength = numbers.join("").length;
}

if (numberLength > 10) {
  return ['(', /[1-9]/, /[1-9]/, ')', ' ', /\d/ , /\d/, /\d/, /\d/, /\d/, '-', /\d/, /\d/, /\d/, /\d/];
} else {
  return ['(', /[1-9]/, /[1-9]/, ')', ' ', /\d/, /\d/, /\d/, /\d/, '-', /\d/, /\d/, /\d/, /\d/];
}

}
`

@gfviegas I tried your mask and it seems to work.

But there are a few changes you need to make. The cellphoneMask function needs to accept an argument, which will contain the new, unconformed user input. Then you can work with that new user input within the function. Like this for example:
function mask(userInput) {
  let numbers = userInput.match(/\d/g);
  let numberLength = 0;
  if (numbers) {
    numberLength = numbers.join("").length;
  }

  if (numberLength > 10) {
    return ['(', /[1-9]/, /[1-9]/, ')', ' ', /\d/, /\d/, /\d/, /\d/, /\d/, '-', /\d/, /\d/, /\d/, /\d/];
  } else {
    return ['(', /[1-9]/, /[1-9]/, ')', ' ', /\d/, /\d/, /\d/, /\d/, '-', /\d/, /\d/, /\d/, /\d/];
  }
}

If you continue to use this in your function, you might wanna pre-bind the function to the correct context.

@msafi thanks for the attention!
Im using ionic 2 and that's why I was binding with this. I tried add the argument but my app crashed with it. I've upgraded to 0.20 already.
Am I using it right?
<ion-input [formControl]="whatsapp" type="text" [textMask]="cellphoneMask()"></ion-input>
Should I just link the function with [textMask]="cellphoneMask" ?

There's a strange behavior and inconsistentency with the displayed data and the actual field value...
in that red paragraph i have a {{whatsapp.value}} and my input has a [formControl]="whatsapp"

@gfviegas I thought we fixed that bug. Please make sure you're on<EMAIL_ADDRESS>and Angular 2 RC 6. I think the behavior is fixed there.

@gfviegas With regard to improving the docs, please feel free to send a PR anytime

@msafi guess that's the deal then.. ionic 2 on current version (beta 11) still on RC4.

@gfviegas Hmmm, actually, come to think of it...I thought we fixed it for RC4 too. So, as long as you're on<EMAIL_ADDRESS>you should be covered.

@msafi I'm at 0.20.0, but still getting this error.. also I can type an extra character after the mask

@gfviegas Being able to type an extra character after the mask is normal. That isn't visible to the end-user and if the bug is indeed fixed, the model shouldn't store that extra character either.
I tried setting up an Ionic 2 project with Text Mask before but couldn't get it to work. If you could set up a minimal project on GitHub and link it, I'd be happy to run it on my machine and take a closer look.

@msafi im gonna share my current app with ya

@msafi  Here it is https://github.com/gfviegas/ionic2-text-mask-test

@gfviegas I loaded the app and can confirm the bug. It seems that the directive is trying to set the model value correctly, but I'm not sure why it's not setting the value correctly.
@andyrue could you take a look please, I think the problem might be related to how @gfviegas  code is not using FormControl or FormsModule maybe?
You will need to npm install -g ionic@beta to run @gfviegas linked project.

@msafi @andyrue ng2 has many way to use forms. This way im using is called FormBuilder, it's way better to validate stuff on the JS side and it's way more reusable.
I'm sorry for not pointing that you need the Ionic click installed globally, ive thought that the ionic2 project had the cli as a dev dependency.
I don't know much of the plugin neither of masks but I'll be glad to help on the Ionic/ng 2 integration.

The current project I'm using TextMask with uses FormBuilder as well with no problems, so I don't think that's the cause. Both methods result in a FormControl being created. Seems it's the same problem that's happening in #180. I'll play around with this tonight. @ihadeed is using this with rc.4 and Ionic 2 as well. Not sure if he can spot anything different between your project and his.

@andyrue Any luck?
I've failed to understand what's going on with the plugin on this scenario, can't figure it out what to do

@andyrue  @msafi I've just upgraded to angular 2 final release and ionic 2 RC 0, and i'm still having this issue

@gfviegas Are you using the latest angular2-text-mask as well?

@msafi yes. The issue persists just like in my gif up there.

@msafi @andyrue new repo with ionic RC 0:
just pull, install the packages and run ionic serve to test it
https://github.com/gfviegas/ionic2rc0-text-mask-test

@gfviegas Thanks for making this example. I'll look into it this weekend.

This was not working for me (it was never letting me type 9 digits for the number.
I used this idea and binded to the ddd number and then worked, check it out https://github.com/mariohmol/ng-brazil


Android-Kotlin : 17.00 Debugging in Android Studio.

Description :scroll:

Give a step-by-step tutorial in Kotlin along with a brief and clear explanation.
Required Documentation or Video or Audio.

Domain of Contribution :bar_chart:

[x] Android Dev (kotlin)

References :

https://medium.com/androiddevelopers/debugging-in-android-studio-dfbbf8a8d03c

Please Read it Carefully Before Contributing

The file structure should look like Android_Development_With_Kotlin  -> 17 Debugging -> <file name>.
You have to push your PR to the Android_Development_With_Kotlin branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
Your code should be written only in Kotlin.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Kotlin pending then please first complete them.

Supervisor @rahulsain

Happy Contributing. Best of Luck.:sparkling_heart:

/assign

Any update? @Umesh-01


#22269 [cluster-autoscaler] Adding cluster-autoscaler-priority-expander Config Map

22269 [cluster-autoscaler] Adding cluster-autoscaler-priority-expander Config Map and parameters for supporting priority expander
Signed-off-by: AmitThakkar<EMAIL_ADDRESS>@mgoodness  & @yurrriq
Is this a new chart
No
What this PR does / why we need it:
To Support cluster-autoscaler-priority-expander Config Map
Which issue this PR fixes
https://github.com/helm/charts/issues/22269
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @yurrriq

/ok-to-test
/lgtm

/lgtm


Dimensions greater than 3

Hi,
do you have any examples of NL regressions of dimension greater than 3? For example a 20-dimensional version of your "f" function in your Levenberg-Marquardt algorithm in the paper in Nature.
Thanks,
Patrick

No, unfortunately not. It could probably be done since the 2D and 3D spline methods rely on 1D splines in different directions, but it's currently not implemented and as far as I'm aware the code here is all there is. It would mean a bit more bookkeeping and the number of spline coefficients needed per interval would increase exponentially with the dimensionality.
In the publication, there are four channels of a 3D function each, which is still on the level of 3D splines.

Thanks for your answer! (Only just saw it now.)


include Raycast, remove deprecated getInverse(), ES module syntax

closes #11
tested with A-Frame 1.2. onClick was tested. Dist was not updated

The build/browserify does not like import.
see https://github.com/facebook/react-native/issues/39194#issuecomment-1699207762
Would be time to check what latest aframe does for building.
Run npm run build --if-present
> aframe-meshline-component@0.[4](https://github.com/andreasplesch/aframe-meshline-component/actions/runs/8542731837/job/24050182114?pr=21#step:6:5).1 build /home/runner/work/aframe-meshline-component/aframe-meshline-component
> browserify examples/main.js -o examples/build.js
/home/runner/work/aframe-meshline-component/aframe-meshline-component/index.js:[5](https://github.com/andreasplesch/aframe-meshline-component/actions/runs/8542731837/job/24050182114?pr=21#step:6:6)
import * as ml from './lib/THREE.MeshLine';
^
ParseError: 'import' and 'export' may appear only with 'sourceType: module'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `browserify examples/main.js -o examples/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2024-04-20T04_[18](https://github.com/andreasplesch/aframe-meshline-component/actions/runs/8542731837/job/24050182114?pr=21#step:6:19)_06_753Z-debug.log
Error: Process completed with exit code 1.


Old oc, kubectl and openshift-installer files remain in /usr/local/bin

When doing a repeated install, the old files in /usr/local/bin remain active and lead to wrong version selection.

Fixed.


AttributeError: 'ChatGLMTokenizer' object has no attribute 'sp_tokenizer'

+1, is that solved?

alright I solved this just now, by reinstall 4.27.1 transformers, problem here in my environment can be solved.

alright I solved this just now, by reinstall 4.27.1 transformers, problem here in my environment can be solved.
I solved the problem by following your method, thank you!

4.27.1

thank you，solved

move line "self.sp_tokenizer = SPTokenizer(vocab_file, num_image_tokens=num_image_tokens) " before "super().init(" at "init" of  class ChatGLMTokenizer can solve this issue.

check if you are using ChatGLM1 but no ChatGLM2

4.27.1  not run on my computer.
Exception has occurred: RuntimeError
Internal: D:\a\sentencepiece\sentencepiece\src\sentencepiece_processor.cc(1102) [model_proto->ParseFromArray(serialized.data(), serialized.size())]
File "C:\Users\Administrator.cache\huggingface\modules\transformers_modules\visualglm-6b-model-gitee\tokenization_chatglm.py", line 22, in init
self.sp.Load(model_path)
File "C:\Users\Administrator.cache\huggingface\modules\transformers_modules\visualglm-6b-model-gitee\tokenization_chatglm.py", line 64, in init
self.text_tokenizer = TextTokenizer(vocab_file)
File "C:\Users\Administrator.cache\huggingface\modules\transformers_modules\visualglm-6b-model-gitee\tokenization_chatglm.py", line 221, in init
self.sp_tokenizer = SPTokenizer(vocab_file, num_image_tokens=num_image_tokens)
File "D:\1MyFiles\code\python\visualglm-6b-main\2test.py", line 4, in
tokenizer = AutoTokenizer.from_pretrained(r"D:\1MyFiles\code\python\visualglm-6b-model-gitee", trust_remote_code=True)
RuntimeError: Internal: D:\a\sentencepiece\sentencepiece\src\sentencepiece_processor.cc(1102) [model_proto->ParseFromArray(serialized.data(), serialized.size())]


Bugs in /search: record_type not affecting results

Per @joshuagraber: "I'm not seeing any difference in search results when I pass record_categories."
Ran on development code and can confirm this is the case.
Will need to investigate the cause as to why, and then update logic and tests accordingly.

@maxachis FWIW, I'm still seeing this issue in my branch, which I recently updated with dev.


Strip :80 from calendar feed URL

Any update on this? Even when i pull the port number from the URL Icalendar is throwing an error that stops it from subscribing? Google calendar doesn't throw errors, but doesn't take any of the events.

@steveb85 I've fixed the feed URL incorporating :80 and :443 in 1.1.2, which fixes this issue. You can upgrade with:
cd my-almanack-calendar
bundle update almanack

However, I don't believe the presence or absence of port numbers would affect any behaviour in the macOS Calendar app or Google Calendar. Perhaps there's a different issue at play. What steps can I take to recreate your issue?


Introduce dependencies events

Implementation of https://github.com/dry-rb/dry-system/issues/80
Example of usage

@davydovanton I should clarify that our rubocop rules are a WIP, so if you see something silly, please add a comment about it

got it. I think I can add local rubocop for automatic fixes in other PR and fix it. WDYT?


models cleanup - part 3: one model family per directory (cifar resnets)

Combined all the cifar_resnets into one directory as they were sort of taking over the models module. In the future I think we should try to keep model families together if possible.
yaml config looks like this:
 model:
  resnet_cifar10:
    model_name: cifar_resnet_56

was debating:
 family:
  resnet_cifar10:
    model_name: cifar_resnet_56

@growlix I think these are yours?
In the future, I'd like to expand the effecientnet and vit model families with this pattern.

Great idea.

@growlix I think these are yours?

Indeed I added resnet20.
I'd personally go with model_family over family to provide a bit more context, but otherwise I like this structure.


fix(TDI-46746): backport for branch "maintenance/8.0"

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-46746
What is the new behavior?
Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[X] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[X] Other... Please describe:  CVE task

Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Backport of https://github.com/Talend/components/pull/1966 into "maintenance/8.0" branch.

Pull request test result: failure :x:


libasync integration

It should be possible to initialize a tree with an EventLoop object, so events are triggered through it. This should prevent changes to the tree while rendering by deferring them until the next frame.
This integration should be optional however, and will only be enabled if version(Have_Libasync) and if the EventLoop object has been provided.

Cancelled


[$250] Task – Reply appears with a delay when create a subtask as user B

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4856151
Email or phone of affected tester (no customers): https://expensify.testrail.io/index.php?/tests/view/4856151
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/

Log in as user A

Create a task assigned to yourself with user B

Log in as user B in Incognito tab

Open chat with user A

Open task details and create a subtask assigned to yourself

As user A observe the chat with user B

Expected Result:
Reply appears immediately
Actual Result:
Reply appears with a delay or after task reopen
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/498c485a-9912-4d84-bebd-c0ecdc6d1a95

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01976185c5a4437913
Upwork Job ID:<PHONE_NUMBER>525420025
Last Price Increase: 2024-08-14

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

We think that this bug might be related to #vip-vsb

@sakluger  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

No proposals yet.

Hi! I am Jakub from Callstack - expert contributor group. I’d like to work on this job

Thanks @kubabutkiewicz! I've assigned you to the issue, please let us know once you have a proposed solution.

Hi @sakluger for me its seems to be a problem related to backend or we sent wrong data to backend from frontend.
Pusher messages doesn't have update for the the report action when in other account task is created. It works fine when we create normal message.
https://github.com/user-attachments/assets/7510c4e8-3a53-4b5f-8306-a4d18ef717a0
In this video I am sending a meesage in a thread from account A and on account B I see that the number of thread messages increased and I am showing that update from a pusher comes from a a keyreportActions_3100300790784634 and update is for reportActionID<PHONE_NUMBER>393027048 and there is updated report action with correct number of childVisibleActionCount which is a number of threads.
https://github.com/user-attachments/assets/0ae9f257-fb55-434f-b42b-5cdcf93be81b
In that video I am creating a task in a thread in account A and checking account B and the number of threads in the action didn't change because the update in pusher message didn't have an updated object for a reportActions_3100300790784634 so we are not able to change it in a UI.
So can somebody from a backend team look at it? Maybe there is a problem with a data which we are sending from a frontend?
This is a payload which we send to backend when creating a task

Adding another BZ member while I'm OOO (back on 8/30).
Based on the latest comment by @kubabutkiewicz, this is likely a BE issue.

Posted in VIP-VSB to see if anyone knows what's going on

@thienlnam do you have any context here?

I imagine we're just missing an onyx update here - though since sub tasks are pretty rarely used something I don't think need to fix right now

@thienlnam are you suggesting that we close this issue and not fix it?

Yup, basically until vip-vsb is unpaused

Sounds good, closing for now 👍


Search option not looking into layers

I have set these in default.js
"search": true,
"locationSearch": false,
"searchExtent": true,
"searchLayers":{
"id": "LandUseCases4",//"Boston_Marathon_7694",
"fields": ["CASENAME", "CASESTATUS"] //"STATE_NAME"
},
but search is not being performed on the layer. I have set the locationsearch to false , should it not search on location then? but it does search on location

Perhaps your layer id value is incorrect? One way to test this is to configure the application using arcgis online then use the appid in the template and see if that works.

when I added the appid, I can see that layer twice in the drop down for search. After making addLayerFromMap to false, I can see whatever I can in the app. Only the position is little out of place


Interceptors for Services

Informations

Type
Version

Improvement
4.x

Description
Would be nice if there's a controlled way to define decorators for services. For e.g. I have permission filter decorator that intercepts calls to my service methods. I need to keep the code this way because is not web-agnostic. This will be very similar to the concept of interceptors in EJB for Java. This is how I imagine it:

Don't mind the errors reported in my editor, I just wanted to illustrate the concept.
The interceptor might be applied only to a method as well, or to the whole class in which case it will be executed on every service method call.
I can elaborate a bit more if needed, but the concept is already present in EJB

Or an alternative, which is more close to what EJB has.

But this way we can only apply to the whole service. If there's need to only execute on a single method it will not be so intuitive.

Good idea =)

Maybe the better usage will be to set decorator to target method ?

@kalu111 this is actually just a better way to define decorators that will blend nicely with the rest of the components.. like injecting services inside the decorator.. and also giving more declarative way to attach decorators to service methods. As I said in the second comment, it might be good if it is allowed for the decorator to be defined on a method in the service, or the service as a whole.

@mitevs Of course, I do not mind :)
I just wanted to write about the additional possibility of setting decorators per method.

I would be glad to participate in it myself, maybe I will submit PR, but I need first to get some feel of the src and experiment a bit. Meanwhile if someone contributes I will surely check what has been done! :)

@Romakita I am trying to build the interceptor, but it's a bit tricky to make single class decorator that applies to every method, so I decided to try a different way. I created something similar to the Middleware annotation. First I created DecoratorRegistry like so:

Then I've created the DecoratorService

This is very similar to the MiddlewareService, it's a normal service that $onInit uses the InjectorService.buildRegistry to build the registry for the Decorators.
Currently I have decorator with different name, but I will rename it to @Decorator, at the moment is called @ServiceIntereceptor, and it's like this:

This one uses the DecoratorRegistry to merge this class into it. And finally I have the @Intercept annotation which is applied to the service methods of the custom service, like:

It's a bit messy currently but I am testing my concept. The intercept is trying to find the interceptor symbol in the registry and executes the aroundInvoke. Inside it I should call proceed in order to allow the method to flow, or block it with a reason or exception. Here's a sample decorator that I want to use:

And this is how I apply it on the method in my service:

This almost works, except when I try to inject other services in the decorator class constructor I get the following error:

I could see that in the MiddlewareService you inject the injectorService instance in the constructor, but in my case, when I try to inject the injectorService in the DecoratorService I get the same exact error. Seems like the serviceType is undefined in this part of the invoke method in the InjectorService:

Maybe you can give me some hints? Thanks!

This boils down the the concept of decorators in TS except the way I define the aroundInvoke is a bit more intuitive and the decorator is hooked to the tsED ecosystem and can access/inject other components if needed :)

Hi @mitevs ,
I think it's a problem with Intercept decorator. In the Interceptor decorator, you have potentially an array of interceptor, but DecoratorRegistry.get() line 15 can't handle an array of class.  I think your problem come from this line. To begin try, with online one interceptor (not an array).
I can checkout your branch and try on my local, if you want any help :)
Otherwise, it's a great job :)
In addition, I suggest you to move interceptor decorators, registries and classes under a new folder like common/interceptor. And rename DecoratorRegistries by InterceptorRegistries (more understandable ;)).
See you,
Romain

Sure, let me try and see what I get, thanks! 👍

I have a question. It's necessary to create a new registry ? Because, I think ProviderRegistry can be used to store interceptor too. DecoratorRegistry and ProviderRegistry looks like very similar ^^.

I guess I can use it, I am still learning the architecture :)

Ok no problem ;)

I guess I don't have to call InjectorService.buildRegistry(..) then? Because this one is already built from the InjectorService no?

Or I can make the code work and then you can do changes to the PR before we make a final version that will work correctly! :)

Yes perfect ;)

I guess I don't have to call InjectorService.buildRegistry(..) then? Because this one is already built from the InjectorService no?

Exactly, but your a ServiceInterceptor is a Service with a specific method. This method will be invoked by your decorator.  The class build aspect hasn't a difference between Service and ServiceInterceptor. And if we go further, a service can become at any time an interceptor if it implements the right interface.
@Service()
class MyServiceInterceptor implements IServiceInterceptor {
   aroundInvoke(ctx: any){
   }
}

And your interceptor decorator:
export function Intercept(service: IServiceInterceptor | IServiceInterceptor[]): any {
    return (target: any, method: string, descriptor: PropertyDescriptor) => {
        const original = descriptor.value;

        descriptor.value = function (...args) {

            if (InjectorService.has(service)) {

                const instance = InjectorService.get<IServiceInterceptor>(service);

                return new Promise((res, rej) =>
                    instance.aroundInvoke({
                        target,
                        method,
                        args,
                        proceed: () => {
                            res(original.apply(this, args));
                        }
                    })
                );
            } else {
                return original.apply(this, args);
            }
        };
    };
}

I thinks it works ^^

I've pushed PR, it's very similar to what you suggested, but just to make it bit more clear I've defined @Interceptor which might diverge with a bit different impl. in the future!

Nice :)


add metric: "Require deployments to succeed before merging"

This checkbox is under branch protections:

I see a requiresStatusChecks under BranchProtectionRule. Is that it?

It's possible this isn't in the API yet; i'll inquire.

Oh yea nvm. "Require status checks to pass before merging" is a different metric.

@ljharb do you know when we could have this metric included into the API rest? This is a great feature to insert in any workflow working with environments.

API is not available for this feature and it's not possible to select an environment if it's not deployed on that environment. environment list is only visible once it's deployed on that env for the first time.


Unable to connect when requesting a specific endpoint owned by a different nsmgr

Expected Behavior

When a client performs a NetworkService request with a specific endpoint and nsmgr tuple, it should be connected.
Current Behavior

The controlplane/pkg/nsm/nse_manager.go func (nsem *nseManager) GetEndpoint(... returns an error that it Could not find endpoint with name: %s at local registry because it always assumes the exact endpoint request is only for endpoints owned by itself (the local nsmgr).
Failure Information (for bugs)

Steps to Reproduce

The issue is seen with virtual L3 example PoC using the latest implementation of the unified local/remote NetworkService request API:  https://github.com/tiswanso/examples/tree/on_unified_api/examples/vl3_basic
It finds all the endpoints of a specific network service and tries to connect to them via filling in the NetworkService request with the exact endpointName and network_service_manager.
See the specific code:
https://github.com/tiswanso/examples/blob/on_unified_api/examples/vl3_basic/vl3-nse/cmd/vl3_connect.go#L188-L199
Context

Kubernetes Version:
etc.

Failure Logs

Wait. That is plain wrong. You don't let NSM Clients deal with he list of endpoints. That is not what the purpose of NSM is. You have a specific labels and let NSMgr deal with sorting out which Endpoint you get a connection to. Please reconsider you vl3 example implementation.


Method 4 (raphael)

Create 2000 key pairs
Send them by email to members
Deploy ERC 1155 contract with 2000 tokens (not associated)
Provide website or interface to vote (2 options)

Dappy - download dappy
Tomislav (Metamask) - visit website
Command line voting -

Meta information would be how the members votes

Voter can update their vote

Import data into CSV file to count results (yes/no or integers)

Export data tally data
Tally data online (involve storing the voting on rchain)

Real-time voting results

Anyone interested to work on this approach is welcome to re-open this issue, though a separate repo seems like a better way to go.


override default CORS handler for httprouter

Related to https://github.com/jexia/semaphore/issues/74

Codecov Report

Merging #102 into master will increase coverage by 0.18%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   83.27%   83.46%   +0.18%
==========================================
  Files          65       67       +2
  Lines        4276     4288      +12
==========================================
+ Hits         3561     3579      +18
+ Misses        448      444       -4
+ Partials      267      265       -2

Impacted Files
Coverage Δ

pkg/transport/http/listener.go
75.88% <95.00%> (+2.03%)
:arrow_up:

pkg/transport/http/middleware.go
100.00% <100.00%> (ø)

pkg/transport/http/unique.go
100.00% <100.00%> (ø)


modify client sig for gplayoauth

This allows modified apks to still connect using google accounts

Thanks for your contribution and the patch! Have very few internet until tomorrow but looks good and ready to go! Will add more comments tomorrow :) Cheers!


provide admin access to deployr user on deployment machine

Provide admin access to deployr user on the machine except key access
Update init script to install additional binaries: injectived, neutrond

All the devops scripts and reusable workflows have been moved to ibc-devops.
Change pushed

All the deployment machine will be run as docker instance where the deployr user can get the admin access.


install_on_device triggers the error "Could not determine bundle id"

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
When I try to deploy on a device using install_on_device, I get "Could not determine bundle id" error in the install phase :
------ Install phase ------
[  0%] Found xxx... (xxx, iPhone 6 Plus, iphoneos, arm64, 12.5.4, 16H50) a.k.a. 'iPhone name' connected through USB, beginning install
2022-10-17 20:12:06.467 ios-deploy[xxx:xxxx] [ !! ] [ ERROR] **Could not determine bundle id**.

Command executed
Lan
install_on_device(
      skip_wifi: true,
      ipa: <ipa path name>
    )

The issue occurs only when you use ios-deploy version 1.12.0
The problem came from ios-deploy, now the tool requires to provide a bundle_id in addition to the bundle, more details on this issue see https://github.com/ios-control/ios-deploy/issues/561
There are two solutions :
1 - Add the bundle_id inside extra param :
install_on_device(
      skip_wifi: true,
      extra: "--bundle_id <app bundle id>",
      ipa: <ipa path name>
    )

2- Add the bundle_id as a mandatory param to the lan, need some development
install_on_device(
      skip_wifi: true,
      bundle_id : <app bundle id>,
      ipa: <ipa path name>
    )

It looks like the problem is with ios-deploy, https://github.com/ios-control/ios-deploy/issues/561


Support for IDN domain names

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
6.509
Problem you are trying to solve
This is actually a two part issue. When I receive emails with special characters in the domain name they don't get translated into human readable form. E.g they still contain the "xe--" part of the domain name.
The app also crashes when I try to enter an email adress with special characters in it. Like "åäö".
I'd be happy to help out solving this issue if there's something I can do.
Suggested solution
Adding an IDN domain name parser would hopefully solve this issue.
Screenshots / Drawings / Technical details
No response

While it would be possible to add support for just IDNs, we'll do this as part of adding support for internationalized email.
Duplicate of #2633


FIX: Resource approval messages bouncing to Sprinty BCC email

The approval email is being cc'd to<EMAIL_ADDRESS>(the sprinty BCC to Salesforce email, I think), and that email is bouncing. I think this can just be removed from the emails. I don't think it's needed.
Steps:

Update approval flow email recipients
Test approving a resource

@JodiNA I did a few tests on the approval email and it didn't seem like the bcc was being added. Here is the test record: https://sprintyscommunityresources.lightning.force.com/lightning/r/Resource__c/a0t4w00000JrVaXAAV/view
I'm not sure if something we did this changed or if it has to do with which user is running the flow at the time. I can check again after a few more resources have been approved and see if the bcc is being added.
Let me know if there is something else you think I should check.
John


Graph tooltips in Flot view

Sometimes I desperately need to understand what metric has suddenly risen up on the graph, but it's not really convenient to look it up: there's only so much different colors I can see. This pull request adds tooltips to the graph on hover. "Simple" tooltips only show the name of the service, while "with metric" also adds time and metric value.
Tooltips tend to slow down graph updates, so there's an option to disable them as well.

I just gave your patchset a try, really nice and definetely a useful addition ! Many thanks !

\o/ I've wanted to do this for quite some time now. Even hired a collegue who's gonna be very happy for not having to do the work himself :-) :+1: