[M:grammar.md] doc: added Python-style comments.

To go with #1230 .
Cheers

Actually, though the change is trivial, since it affects syntax, should the doc mention the version in which # became valid, to avoid confusion from users reading the doc online but with an older version of Lark installed?

Hmm yeah, that's probably a good idea to mention it's starting from version 1.1.6

Done.
Not sure why github bugs me with an email about ".github/workflows/codecov.yml: No jobs were run" upon pushing :confused:

Thanks!

Not sure why github bugs me with an email about ".github/workflows/codecov.yml: No jobs were run" upon pushing

It's just badly configured, used to work but now broken. I was too lazy to fix it, but maybe I should get it out of the way.


Generated C# code contains invalid casts

We have documented response types and error types in our swagger. I've added the x-ms-error-response extension to all responses except the 200/OK response.
The generated code now picks up the correct type in the signature, but tries to assign all responses, incl. the errors to a field of the type of the OK response.
I generated the code with autorest --csharp --input-file=Desktop\swagger.json
Is there any other switch I need to set here?
Generated code:
if ((int)_statusCode == 200)
{
_responseContent = await _httpResponse.Content.ReadAsStringAsync().ConfigureAwait(false);
_result.Body = SafeJsonConvert.DeserializeObject<IList>(_responseContent, DeserializationSettings);
}
if ((int)_statusCode == 401)
{
_responseContent = await _httpResponse.Content.ReadAsStringAsync().ConfigureAwait(false);
_result.Body = SafeJsonConvert.DeserializeObject(_responseContent, DeserializationSettings);
}
Both types are assigned to the same field, which will of course not work. Any clue how I can generate correctly compiling code?

Not sure why my reply earlier was deleted. I recommended giving NSWag a try before the issue gets addressed in Autorest.


Transform from camera frame to horizontal coordinates in optical error source

The optical error source currently makes the assumption that the x-axis corresponds to azimuth error and the y-axis corresponds to altitude error. Furthermore it assumes that this mapping is a linear relationship. This approximation is good at low altitudes but breaks down at higher altitudes. I have noticed that it can take a long time for azimuth to converge when using optical tracking on stars at higher altitudes. I believe this is because the azimuth error can be fairly large even though the star is not very far from the center of the frame in the x-axis. The error signal is smaller than it should be, and thus the control loop takes a longer time to converge than it should.

The challenge here is that the proper coordinate transform requires knowledge of the mount's current altitude (or at least approximate knowledge of this). There are a couple of problems with this:

The optical tracking loop should be able to function without any such knowledge. For example, it should still work even when alignment has not been performed. One option would be to only do the proper coordinate transformation when position knowledge is available and fall back on the current approach when it's not available.
It takes tens of milliseconds to read it from the mount which is expensive.

This might be somewhat less troublesome with the G11 mount for the following reasons:

Even without performing alignment, as long as the mount is started up in the recommended position (counter weight down) the mount's knowledge of its position relative to the pole will be pretty decent.
Reading position from the Gemini 2 is fast, only a few ms

I think this should be implemented in a manner such that it will use absolute position data to do the proper coordinate transform if that information is available, but if not it will fall back on the current approximation.

As of May this was implemented but it was not thoroughly tested and there may still be corner cases that don't work quite right, such as #74 and #86. I think at least a few manual tests of specific cases should be performed to confirm that the error magnitudes in different parts of the sky including near the celestial pole match the expected values.

Since much of the coordinate system code has been rewritten this needs to be redone.

Redone as part of https://github.com/seeing-things/track/pull/154 but not tested at all yet

I did some testing today and found the following:

Needed to apply a sign change or two in the optical error source. Once this was corrected, a camera rotation value in the mount model parameter set of 0 corresponded to the bottom of the camera (USB connector size, for ZWO) pointing in the same direction as the counterweight shaft.
Optical error source was not correctly accounting for camera binning in transforming from pixels to degrees
A couple of times the software paused for nearly a second before continuing. I don't know what caused that, but I suspect it must have been a ZWO camera issue.
Rotation of the camera by 90 degrees counter-clockwise from 0, when viewed from behind the camera, corresponded to a value of -90 degrees in the mount model parameter set.

Three of the four issues found during recent testing as noted in the previous comment were fixed in https://github.com/seeing-things/track/pull/185.
Outstanding:

[ ] Find root cause of long pauses
[ ] Confirm that transformations are correctly scaling the right ascension axis error term as a function of the declination axis position

On 25 April 2020 I performed testing of optical tracking where I had access to the full sky. I noted that I was able to successfully track Venus west of the mount meridian with an appropriate value for the guidescope camera orientation in the mount model parameter set (-90 degrees in my case, which corresponded to the ZWO ASI178MC oriented such that the USB connector was facing to the right when viewed from behind). However, tracking did not work east of the mount meridian for the same value--the target was pushed out of the field of view.

[ ] Fix / test tracking on both sides of mount meridian

I performed further testing on 26 April 2020 on both sides of the meridian and found optical tracking to be working as expected. This was after refactoring a bit of the code and after fixing a couple of sign changes in the process. Not known for certain whether the issue encountered on the 25th was fixed in the process, but it was working with the code I refactored.
I also did some testing with a manufactured target at a fixed offset in the camera frame to test whether the encoder error terms were scaled appropriately based on the declination axis position, and I found that they were indeed being scaled as I expected. Closing this out. Will open a separate issue for the long pauses if that issue recurs.

Welp. Testing of optical tracking of Venus out in the field on 3 May 2020 was unsuccessful. For that test the mount was cold-started and no alignment was performed, so optical tracking was using a default mount model. While debugging in the field I thought that perhaps the problem was that the mount pole altitude was set to 90 degrees, but editing this to 38 degrees to more closely match the hardware did not solve the problem. Telemetry showed:

even though the declination axis was far from the pole, the error terms for the mount axes were very large (dozens of degrees) when neither should have been more than a degree or two
error direction and magnitude in camera frame looked correct
mount encoder positions looked believable (about the right difference from the 180-degree startup positions) but these were not checked in detail.

I also tried to rule out how meridian side is handled for optical tracking as a source of the problem by re-starting the program several times while already pointed near Venus. Optical tracking detects the meridian side at startup and continues using this same side from that point forward, so re-starting the program should have detected the correct side.
The evidence suggests that the problem is in the transformation from camera frame to mount encoder positions. There should be sufficient telemetry available to reproduce.

On further investigation I found that I was able to reproduce the large error terms. I traced the root cause to a mistake I made when hand-editing the mount model parameters to account for the orientation of the guide scope camera. Since there was no way to specify this orientation when running optical_track without performing an alignment I edited the body of model.load_default_model() but instead of modifying guide_cam_orientation I mistakenly changed camera_tilt from 0 to -90 degrees. Oops! Clearly I need to provide a way to specify this from the command line or config file when optical_track is run with the default mount model. Opened #190 to address this.
Closing again with the assumption that the problems observed on 3 May were not the result of a bug in the code.


Add executor does not update root lock if project is in dependency group

Current Behavior
If a project is listed in the root pyproject.toml as part of a dependency group (not in the rootPyprojectToml.tool.poetry.dependencies collection) then updateDependencyTree fails to detect that the root pyproject requires re-locking when running the add target
Expected Behavior
Running the add target for any python project depended on in the root pyproject causes that pyproject to be relocked.
Steps to Reproduce

Create new shared venv workspace
add new python project with a root dependency group (anything other than blank)
add a non-local dependency to the app
see that root poetry.lock does not contain the added non-local dependency

Nx Report
Node   : 20.11.1
OS     : darwin-arm64
npm    : 10.2.4

nx             : 18.1.2
@nx/js         : 18.1.2
@nx/workspace  : 18.1.2
@nx/devkit     : 18.1.2
@nrwl/tao      : 18.1.2
typescript     : 5.4.3
---------------------------------------
Community plugins:
@nxlv/python : 18.0.0

Failure Logs
No response
Additional Information
I have a fix, PR coming shortly

While working on the PR for this, I discovered that mock-fs is broken for Node 20, FYI


repo_utils: support github pull request branches

This adds possibility to checkout github pr providing special purpose ref spec (like refs/pull/X/merge and refs/pull/X/head) as branch parameter to teuthology, for example, "teuthology-suite -t".

@susebot run deploy

@susebot run deploy

@susebot run deploy

@susebot run deploy

@susebot run deploy

Interesting!  How does this work without all the packaging CI (Jenkins/shaman/chacra)?

Interesting! How does this work without all the packaging CI (Jenkins/shaman/chacra)?

This is supposed to be useful for --teuthology-branch, and I guess for --suite-branch too. However, the --ceph could theoretically work with --newest, but I'm not sure.
But again, this is mainly for testing teuthology PRs.

Interesting! How does this work without all the packaging CI (Jenkins/shaman/chacra)?

This is supposed to be useful for --teuthology-branch, and I guess for --suite-branch too. However, the --ceph could theoretically work with --newest, but I'm not sure.
But again, this is mainly for testing teuthology PRs.

Ah, okay.  Gotcha.  I misunderstood the purpose.


Version 0.15 installer crashes explorer.exe upgrading from 0.14.1

Environment
Windows build number: 10.0.19577.1000
PowerToys version: 0.15.0
PowerToy module for which you are reporting the bug (if applicable): Setup (MSI x64)

Steps to reproduce

Start with PowerToys 0.14.1 installed.
Launch x64 MSI installer for version 0.15.
Toward end of installation, installer attempts to restart explorer.exe.

Expected behavior

Installation should close explorer.exe and restart it again.  (Taskbar will briefly disappear then reappear.)

Actual behavior

Explorer stopped (taskbar disappeared) but never restarted.  I had to open Task Manager and manually start explorer by using File > Run New Task > explorer

Screenshots
Unfortunately, no screenshots or log files are available.

Hi @schumatt-msft
the MSI installation completed?
Were you able to start PowerToys after manually restarting Explorer?

@enricogior The install did complete successfully, and I believe PowerToys was actually running once I started Explorer.

Can you check the event log for Explorer errors?
In case it would be interesting to retry the update.
Since we are releasing 0.15.1 for another issue, let us know if installing 0.15.1 on top of 0.15.0 has the same problem.

Nothing in App or System logs around the same time, just the MsiInstaller for the completion:

Windows Installer installed the product. Product Name: PowerToys (Preview). Product Version: 0.15.0. Product Language: 1033. Manufacturer: Microsoft. Installation success or error status: 0.

I did try removing, reinstalling 0.14.1, then upgrading again, but that completed as expected.  Once 0.15.1 is available, I'll try that on top of 0.15.0 with the logging switches for msiexec.

OK, thank you.

Explorer is killed when uninstalling too, and PowerToys is not uninstalled. Tried it twice. I've never been able to get it to work, always get the WebView error when trying to open Settings.

@BeecherNetworks are you trying to uninstall PT via legacy control panel or Win10 Settings->Apps?

I used Start Menu > Power Toys > right-click > Uninstall, which took me to the legacy panel, and I uninstalled from there. Didn't even think of Apps, sorry, try to avoid the new control panels. :) I was eventually able to uninstall by right-clicking on the MSI installer. I'll try a fresh reinstall shortly, the last install was over the previous version.

@BeecherNetworks
the legacy Control Panel seems to not uninstall PowerToys correctly, while the new Apps uninstaller does work just fine.

We're currently relying on a registry key Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon\AutoRestartShell for explorer.exe to be restarted, which is 1(true) by default. Could you folks please check if it's set to 0 on your machine? @BeecherNetworks @schumatt-msft
If that's the case, as far as I know, there's no way to toggle this flag from Control Panel UI, so it must be set by some third-party, and we could solve the issue by detecting from wix if that registry flag is unset and restart explorer manually.

That's set to 1 on my PC.

@yuyoyuppe The registry value is set to 1 on my PC.  Also wanted to mention that the upgrade from 0.15 to 0.15.1 on my PC worked as expected. Explorer did close during the setup, but it restarted on its own as expected.  The problem during the 0.14.1 to 0.15.0 upgrade may have been an isolated incident in my case.

Is there any way of using FancyZones without being able to access settings? I'm currently using AquaSnap but I'd love to try FZ.

@beecherNetworks, WinKey + ` will trigger the editor where your mouse is

is this still happening?  if so, please open reopen it.


MudSwitch EventCallback with ValueChange causes build errors

Bug type
Component
Component name
MudSwitch
What happened?
There is no way I can pass a callback method to ValueChanged parameter, regardless of how I am doing it:

Callback method without parameter
Callback method with boolean
Callback via lambda

I always get different build errors:

cannot convert from 'method group' to 'Microsoft.AspNetCore.Components.EventCallback'
cannot convert from 'Microsoft.AspNetCore.Components.EventCallback' to 'Microsoft.AspNetCore.Components.EventCallback< bool >'
cannot convert from 'object' to 'bool'

I also tried simply with "@onchange" but there is no method invokation during runtime when i toggle the switch :-/
Expected behavior
Build should be successful with ValueChanged.
Or method should also be invoked using @onchange Attribute.
Reproduction link
https://try.mudblazor.com/snippet/cYwSucmzKEgDqtXQ
Reproduction steps
Please check TryBlazor
Relevant log output
No response
Version (bug)
6.16.0
Version (working)
No response
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi.
If you are not going to use @bind-Value="@XYZ" but Value="@Value" ValueChanged="OnValueChanged" as alternative, then if the component accepts generic there is need to explicitly set the T -> MudSwitch T="bool" to help the razor compiler to understand the type.
Working example:
https://try.mudblazor.com/snippet/mOQIkcwzglchToji

Solved in this thread https://github.com/MudBlazor/MudBlazor/discussions/8237


Add author, categories, tags to frontmatter.

updated the coverimage to includes secnarios that coverImage does not (parent ID)
Add jpeg to list of images to get
Improve image requests by encoding the uri

Majority of the code taken from this fork and then improved: https://github.com/hao-hao-hao/wordpress-export-to-markdown

Closing, I just realized this has other PRs and the author is unresponsive.


PartialPayment feature resulting in integration bugs

Hi all,
the documentation for the XRPL states:
"Partial payments can be used to exploit naive integrations with the XRP Ledger to steal money from exchanges and gateways." https://xrpl.org/partial-payments.html
This seems to be a big problem lately. Many exchanges did not integrate the XRPL properly and are/were vulnerable to PartialPayments. This is such a big issue, that pointing to the XRPL-documentation seems not to be enough.
It would be useful to add a new AccountRoot flag "lsfAllowPartialPayment" which defaults to "false".
This way, sending a partial payment transaction is failing with "tefPARTIAL_PAYMENT_DISALLOWED" on accounts which not actively allowed PartialPayments.
Allowing/Disallowing PartialPayments can be done by an AccountSet-Transaction with a new Flag: "asfAllowPartialPayment".
The benefits are:

much easier integration of XRP into other systems
partial payments cannot be exploited anymore (if an account has disabled them)

I think disallowing them by default would benefit a big user base of XRP and negatively affect just a few.

there was a plan to do so.
https://github.com/nbougalis/rippled/commit/52d04bfcb0f63ffad58fdd495c036497c78f695c

Is there any chance this can make it as an amandment?
I saw it was already developed back in August 2018 but I actually never heard of it nor it is a known amandment yet.

some discuss here, https://www.xrpchat.com/topic/26897-reject-incoming-partial-payments-by-default/
but don't know when will be merged.

Partial payments are a very useful feature and defaulting it to "off" would mean a very drastic change for every single (existing!) account on the ledger that is unexpected and unilateral - users have no way to veto this.
I'd like to see some concrete numbers for your claims that: "This seems to be a big problem lately. Many exchanges did not integrate the XRPL properly and are/were vulnerable to PartialPayments. This is such a big issue, that pointing to the XRPL-documentation seems not to be enough."

Why is this a problem "lately", if the first public case was about 5 years ago? https://xrpl.org/blog/2014/gateway-advisory-on-partial-payment-flag.html is old enough that Ripple even removed their whole wiki since then. (It probably should link to https://ripple.com/files/GB-2014-06.pdf and make these a bit more prominent @mDuo13 ?)
How many off-chain exchanges were affected so far?
How many are still vulnerable?

Cutting out useful features because people copy-paste code or don't read documentation when handling customer funds (and don't publish their code or pay someone competent to audit it) is a weak reason in my book - after all, PartialPayments are especially useful for someone to SEND, not exactly something you need to think about to RECEIVE. There's a big chance that people will just leave this at the default, essentially killing the feature (just like the NoFreeze flag, which used to be default and then got pushed onto the network unilaterally).

Not relating to exchanges only.
Recent vulnerabilities (exploited or not) were BitPro (exchange), R3 CordaSettler, Beaxy (exchange). And I know the XRPCommunity "tested" other exchanges and reported if they were vulnerable.
I agree with you that a default to "disallow" partial payments could kill the feature. So maybe we should  think of another way to mitigate the problem. In @yxxyun's link there was a suggestion of a separate "PartialPayment" transaction. Maybe this could be a solution?! (I just want to force some discussion to this topic here).
What I disagree with you is blaming people "not reading" the documentation. You might be right that they should have done their audit and find proper "XRPL"-Integrators and they may should have read the documentation. But this happened many times now already.
What if adaoption really takes place?
At the moment we are quite early adoption wise. If those few adopers already make many mistakes in this regards, what if more and more people will adopt the XRPL?
There seems to be a problem with partial payments and that they can be used to exploit bugs in 3rd party software. It happened 5 years ago and it still happens nowadays.
I think the XRPCommunity should think of a way to make the integration of the XRP-Ledger more easy and more fail safe. Where people work, mistakes are going to happen. Blaming them for not reading the docs does not help them nor the customers -> it will be a bad experience for both and that is something we need to mitigate.

So far there has been about 1 case per year of someone implementing things incorrectly. I wouldn't call this "many" (or "quite early" for that matter).  If you want a walled garden or sandbox with rounded corners and limited functionality, then maybe XRP is not the right choice?
Also there sorta is already a separate "PartialPayment" transaction: It is a Payment transaction that has the tfPartialPayment flag enabled. Since the handling on the receiving end is just the same as for non-partial payments (look at the delivered amount and credit the user) I don't see many benefits in renaming this type of transaction to make it into its own thing...

Any change to the way partial payments work today is likely to require changes for the (many!) institutions who have correctly implemented them today. And, although Ripple does not push the "gateway" business idea much these days, it's still something that can be done with the XRP Ledger, and partial payments are more relevant for that use case for returning issued currency payments. Breaking partial payments (e.g. by the proposed change of making it so new accounts can't receive them unless they opt in) would especially hurt the businesses that use the XRP Ledger's decentralized exchange today.
I'm always adding more warnings to the documentation about this issue, but that only helps people who read the documentation. Those who read the API messages and assume how they work, I can't help.

To reiterate: The solution is to always use the deliveredAmount (or delivered_amount) field to determine the amount that the transaction delivered. When using the recommended higher-level library ripple-lib, it's infeasible for this bug to occur because ripple-lib automatically hides the amount field, leaving the deliveredAmount as the only available field to check.
(As of ripple-lib 1.0.0, 2018-08-30)


chore: added config scripts

Description

Fixes #

Checklist:

[ ] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

this is merged in develop and rc-16


30JUN20 commit for CyberArk Sentinel integration

I do not understand what is going on with the Playbooks/Get-MDATPVulnerabilities/report_template.docx  I have added it to my local repo and no matter what I do it picks up on it missing, I do not understand why.

Cleared JSON Validation errors

One more try

Reopening to attempt to navigate past cancelled pipeline run


Update how-to.md to fix gramatical issues

Jonathan, thank you for cooperation!
I have made some small fixes to the wording based on your propositions while retaining the initial meaning, and also added a couple of markdown paragraphs instead of spaces: they were lost in the process of migration to the new Help. Thanks again for finding all these problems.

@mkjetbrains Glad to help! Thanks for making the guides so easy to contribute to!


Thank you!

Hi Doug,
First, I want to say thank you for all of the hard work that you do!
I am trying to push this into salesforce from github and am getting this error:
Deployment CompleteTest failure, method: DeleteBatchTest.coverageAll -- System.AssertException: Assertion Failed: Expected: 0, Actual: 3 stack Class.DeleteBatchTest.coverageAll: line 29, column 1
Am I doing something to cause this? Thank you again!

Hi @nicmcbride,
Thanks for the appreciation!
Based on the error message, it seems your org has an Apex class named DeleteBatchTest which is failing at around line 29. You may need to review that code and make adjustments.
Unless you are wanting to customize the behavior of the notes conversion tool, try installing my managed package offering which will let you bypass the unit test issues.
At the moment, the latest version is 1.1:

Sandbox
Production / Developer

Thanks,
Doug


don't use curl progress bar since it looks bad in IDEA console window

Won't that mean we just sit there with no indication that anything is happening?
I'm not a fan of the way curl does these either but at least it shows something is in progress...

Without this flag, it shows progress via increasing numbers instead of a progress bar. For some reason, the IDEA console seems to be okay with that.
(So far only tested on Mac, though.)

What does it mean that "flutter-build" failed? How do I get more info?

Example output in IDEA:
/Users/skybrian/tmp/flutter8/bin/flutter --no-color --version
Downloading Dart SDK 1.23.0-dev.11.11...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 48.5M  100 48.5M    0     0  2421k      0  0:00:20  0:00:20 --:--:-- 2584k
Building flutter tool...
Flutter • channel fixprogress • /Users/skybrian/dart/work/flutter
Framework • revision 60cd2ff15c (3 hours ago) • 2017-04-21 17:01:20 -0700
Engine • revision a5b64899c9
Tools • Dart 1.23.0-dev.11.11
Process finished with exit code 0

That output looks fine to me.  The red "flutter-build" means our build bots are currently red, so the only checkins allowed are those that fix the breakage.

If there's still progress, I'm happy. Thanks! :-)

I think the output's actually pretty bad on the command line (it's multiple lines of noise), but we can improve that in m3. Maybe we can use --machine to give a machine-readable notion of progress for IDEA and it can display a real GUI progress bar?

This script can run before any Flutter command, and we don't always pass in --machine (not all subcommands support it).
But perhaps we could have a separate command that just does the upgrade? IDEA could run that first, ensuring that curl progress doesn't show up later.

Well we could just make all the commands the IDE calls support --machine. :-)


better error message when compiled without -parameters

if you (like me) forget to add -parameters to your jbang project then quarkus langchain4j shows this error:
java.lang.NullPointerException
        at java.base/java.util.Objects.requireNonNull(Objects.java:233)
        at io.quarkus.qute.TemplateInstanceBase.data(TemplateInstanceBase.java:45)
        at io.quarkiverse.langchain4j.QuarkusPromptTemplateFactory$QuteTemplate.render(QuarkusPromptTemplateFactory.java:67)
        at dev.langchain4j.model.input.PromptTemplate.apply(PromptTemplate.java:102)
        at io.quarkiverse.langchain4j.runtime.aiservice.AiServiceMethodImplementationSupport.prepareSystemMessage(AiServiceMethodImplementationSupport.java:502)
        at io.quarkiverse.langchain4j.runtime.aiservice.AiServiceMethodImplementationSupport.doImplement(AiServiceMethodImplementationSupport.java:140)
        at io.quarkiverse.langchain4j.runtime.aiservice.AiServiceMethodImplementationSupport.implement(AiServiceMethodImplementationSupport.java:122)

would be great if it would provide hint that the reason for NPE is that parameters are missing names and should add -parameter to the compilation.

Yeah, it makes sense to see what we can better on the Quarkus LangChain4j side, but doesn't it also make sense to have JBang invoke javac with -parameters by default?

Actually, we do have a warning message, it should be:
The application has been compiled without the '-parameters' being set flag on javac. Make sure your build tool is configured to pass this flag to javac, otherwise Quarkus LangChain4j is unlikely to work properly without it.

did you not get that at all?


Multiple Chart Enhancements and Bugfixes

This update addresses a number of the outstanding bugs and requests for working with Charts.
Issue #858 :

Added a new configuration option: serAxisLineColor
Added support to use schemeColor on Category Axis Label (catAxisLabelColor)
Added support to use schemeColor on Category Axis Line (catAxisLineColor)
Added support to use schemeColor on Value Axis Label (valAxisLabelColor)
Added support to use schemeColor on Value Axis Line (valAxisLineColor)
Added support to use schemeColor on Series Axis Label (serAxisLabelColor)
Added support to use schemeColor on Series Axis Line (serAxisLineColor)
Added support to use schemeColor on Chart Title (titleColor)
Added support to use schemeColor on Category Axis Title (catAxisTitleColor)
Added support to use schemeColor on Value Axis Title (valAxisTitleColor)
Added support to use schemeColor on Series Axis Title (serAxisTitleColor)

Issue #837 : This has already been patched. Patch is still in this release and issue should be able to be closed.
Issue #747 : Added support for catAxisMajorUnit and catAxisMinor unit to function correctly with double value axis chart types (Scatter Chart + Bubble Chart)
Issue #662 : Fixed issue for dataLabelFontBold to correctly bold data labels.
Issue #815 : This was an invalid input that should no longer be allowed after this PR
Issue #788 : This was an invalid input that should no longer be allowed after this PR
Issue #768 : This was an invalid input that should no longer be allowed after this PR
Additional Enhancements:

Added serAxisLabelFontBold to the code so that it functions as per the documentation.
Added Italic support for chart labels:
2.1. New configuration: catAxisLabelFontItalic
2.2. New configuration: serAxisLabelFontItalic
2.3. New configuration: valAxisLabelFontItalic
2.4. New configuration: dataLabelFontItalic

Additional Issues Reviewed, but not specifically in this release:
Issue #441 : This feature has already been implemented and should be safe to close.
Issue #291 : This feature has already been implemented and should be safe to close.
This PR replaces PR #794 which can be cancelled / closed
Everything has tested successfully against the full demo build.

Thank you very much @ReimaFrgos ! The backlog was becoming daunting.


.Net Core 3.0 - ElmahExtensions.RiseError not logging

I am using ElmahExtensions.RiseError in my global error handler.   Since .net Core 3.0 it's not working anymore.  The call is made to RiseError, I do not get an exception, but nothing is logged and I don't receive the email.  If I remove the Global exception handler and throw an exception, Elmah sends the email correctly.
public override void OnException(ExceptionContext context) {     ...     ElmahExtensions.RiseError(context.Exception);     base.OnException(context); }
I also tested ElmahExtensions.RiseError directly in my controller and I have the same issue.  Nothing is logged.

try to use
HttpContext.RiseError(ex)

I am having the same issue. HttpContext.RiseError(ex) will only work if there is an HttpContext avaialable. ElmahCore  without HTTPContext ElmahExtensions.RiseError does not work.

Any updates on this?

On .Net Core 3.1, it not working

i can solve this problem with use ElmahExtensions class in my controller
ElmahExtensions.RiseError(new Exception("your msg"));


Localfiles

This is a pull request to get the master up to date with what Tyler and I have been doing.

Thanks @JohnHadish and @biggstd !!


Update documentation to add skills plugin to bundled plugins

Description
Update documentation to add skills plugin to bundled plugins
Issues Resolved
Checklist

[ ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks, @zane-neo ! I'll post the link in the forum once it gets published.


Updates/networks

Small PR:

StaticNet raises appropriate error if it receives nx null_graph generator -- this genrator does not take n as argument.

NullNet is a specific instance of a network with a single contact per agent (self-connection) with weight zero. Main motivation to have this class is debugging purposes, models that do not use networks but may in the future (FPsim?); and perhaps enabling some network-based visualisations for models that don't really use networks.

Empty networks (empty contact arrays) can be achieved with

empty_net_static = ss.StaticNet(nx.empty_graph)
empty_net_rand = ss.RandomNet(n_contacts=0)

@kaa2102 Resolved the merge conflicts. Sorry for the delay!


Can not toggle reward

@bruno-f-cruz
Hi Bruno,
I just found the new workflow can't set the reward duration. When there was a "Manual Water_Left" or "Manual Water_Right" coming in, the reward was just turned on or turned off. It seems that it never uses the "LeftValueSize" or "RightValueSize". This issue only exists for the updated workflow, not in the previous workflow. I am not sure if it relates to the update of the API.

At some point, you added the pulse mode to the DO responsible for the cue
no? When you define the value of this register you must pass all the flags
that correspond to the pins you want to use in pulse mode. You need to add
the masks of these outputs as well to that message.
On Wed, 17 May 2023 at 00:03, XX-Yin @.***> wrote:

@bruno-f-cruz https://github.com/bruno-f-cruz
Hi Bruno,
I just found the new workflow can't set the reward duration. When there
was a "Manual Water_Left" or "Manual Water_Right" coming in, the reward was
just turned on or turned off. It seems that it never uses the
"LeftValueSize" or "RightValueSize". This issue only exists for the updated
workflow, not in the previous workflow. I am not sure if it relates to the
update of the API.
[image: image]
https://user-images.githubusercontent.com/109394934/238789475-c7329a21-00f8-4f22-b234-327171594682.png
—
Reply to this email directly, view it on GitHub
https://github.com/AllenNeuralDynamics/dynamic-foraging-task/issues/5,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVZBB43BQ4OMIZLNLQKOATXGQBTRANCNFSM6AAAAAAYEJGO5A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you also modify this workflow and make a pull request?

It solved the problem. Thanks!


Remove unused params param  in resolveRedirect example

Why is it there? The docs say params is part of context object. In any case it is unused in the example.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #207 (f4cbd6c) into main (ea82159) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          229       229
  Branches        66        66
=========================================
  Hits           229       229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea82159...f4cbd6c. Read the comment docs.

Thank you!


Exec for each video in playlist and passing template strings to command

Checklist

[x ] I'm asking a question
[x ] I've looked through the README and FAQ for similar questions
[ x] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
Hi,
is there a way, while downloading a channel or playlist, to exec a command after each video downloaded and passing the variables used in the output template?
Namely I'd like to run chat_downloader for each video and pass the path and filenames that youtube-dl is using to save the videos so the filename for the chat file is in the same place and named consistently.

Have a look at --exec. You cannot pass arbitrary fields to it, but can pass the filepath (including name) which should be enough for your needs


Error pulling image

Error pulling image (latest) from ryan kennedy io/deep dream, Untar re-exec error: exit status 1: output: unexpected EOF

this seems like a problem with that user's particular docker image


custom_jvp does not work when first jvp rule is None

Here is a repro code
from jax import grad, custom_jvp

@custom_jvp
def f(x, y):
  return x ** 2 * y

f.defjvps(None, lambda x_dot, primal_out, x, y: 2 * x * y * x_dot)
print(grad(f, 1)(2., 3.))

Thanks for finding this, and the clear repro. #3390 should squash it!
Always a pleasure to see you pop up on the issue tracker, @fehiepsi :)

Thanks for a quick fix, @mattjj! (this issue happened in PR #3385.)


Wrong spacing after \right

Issue Summary
There should be some extra spacing before and after \left(\right), but MathJax only implemented the desired spacing before \left, instead of both that before \left and that after \right.
$$a\left(b\right)c$$

$$a(b)c$$

This is the result rendered by MathJax:

This is the result rendered by LaTeX:

As can be seen, the spacing between ")" and "c" are different in the two results.
Steps to Reproduce:
Technical details:

MathJax Version: 3.2
Client OS: Ubuntu 20.04
Browser: Chrome 110.0.5481.177

I am using the following MathJax configuration:
MathJax = {
	tex: {
		inlineMath: [['$', '$'], ['\\(', '\\)']],
		processEscapes: true,
		tags: 'ams',
		packages: {'[+]': ['ams', 'autoload']}
	},
	loader: {load: ['[tex]/ams', '[tex]/autoload']}
};

and loading MathJax via
<script id="MathJax-script" async<EMAIL_ADDRESS>
Supporting information:

Thanks for the report.  I will make a pull request to fix it in the next release.


WIP communities: add community logo feature

Enables possibility to add community logo.
(addresses zenodo/zenodo#112)

Signed-off-by: Adrian Pawel Baran<EMAIL_ADDRESS>

cc @lnielsen

@jirikuncar, in response to comments connected either with inline style attr or scripts mixed in html files. Currently I'm working on adding sharing community feature, which (work) includes a lot of refactoring in both groups and communities modules (i.a. creating bundles for views). So this is something which will come soon. It would be nice then if we could merge it for now without introducing changes to inline scripts and styles - for sure it will be done in upcoming PR.

@bouzlibop please reopen in inveniosoftware/invenio-communites.


sealer upgrade failed

What happen?

sealer -d  upgrade kubernetes:v1.21.5 --cluster my-cluster
find errors sea.hub:5000/coredns:v1.8.0 not found
by sealer inspect ,find imageList
edit the coredns image version to 1.7.0 from imageList file
retry " sealer -d  upgrade kubernetes:v1.21.5 --cluster my-cluster"
find error,also "sea.hub:5000/coredns:v1.8.0 not found"

Relevant log output?
[preflight] Running pre-flight checks.
[upgrade] Running cluster health checks
[upgrade/version] You have chosen to change the cluster version to "v1.21.5"
[upgrade/versions] Cluster version: v1.20.10
[upgrade/versions] kubeadm version: v1.21.5
[upgrade/prepull] Pulling images required for setting up a Kubernetes cluster
[upgrade/prepull] This might take a minute or two, depending on the speed of your internet connection
[upgrade/prepull] You can also perform this action in beforehand using 'kubeadm config images pull'
[preflight] Some fatal errors occurred:
	[ERROR ImagePull]: failed to pull image sea.hub:5000/coredns:v1.8.0: output: Error response from daemon: manifest for sea.hub:5000/coredns:v1.8.0 not found: manifest unknown: manifest unknown
, error: exit status 1
[preflight] If you know what you are doing, you can make a check non-fatal with `--ignore-preflight-errors=...`
To see the stack trace of this error execute with --v=5 or higher
2023-03-15 09:09:39 [DEBUG] [sshcmd.go:114] failed to execute command(kubeadm upgrade apply v1.21.5 -y) on host(<IP_ADDRESS>): error(failed to execute command(kubeadm upgrade apply v1.21.5 -y) on host(<IP_ADDRESS>): error(exit status 2))

What you expected to happen?
upgrade successful
How to reproduce it (as minimally and precisely as possible)?
apiVersion: sealer.cloud/v2
kind: Cluster
metadata:
  annotations:
    ClusterfileName: /root/.sealer/my-cluster/Clusterfile
  creationTimestamp: null
  name: my-cluster
spec:
  hosts:
  - ips:
    - <IP_ADDRESS>
    roles:
    - master
    ssh: {}
  image: registry.cn-qingdao.aliyuncs.com/sealer-io/kubernetes:v1.22.15
  ssh:
    encrypted: true
    pk: /root/.ssh/id_rsa
    port: "22"
    user: root

Anything else we need to know?
No response
What is the version of Sealer you using?
{"gitVersion":"v0.8.6","gitCommit":"884513e","buildDate":"2022-07-12 02:58:54","goVersion":"go1.16.15","compiler":"gc","platform":"linux/amd64"}
What is your OS environment?
NAME="Debian GNU/Linux" VERSION_ID="11"
What is the Kernel version?
Linux debian8 5.10.0-18-amd64 #1 SMP Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux
Other environment you want to tell us?
current version
root@debian8:~# kubectl  get node
NAME      STATUS                     ROLES                  AGE   VERSION
debian8   Ready,SchedulingDisabled   control-plane,master   9d    v1.20.10

@wizardlyk ,could you help us to troubleshoot this issue ?


v2.2.0 - Not using specified API endpoint as IP address

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Run ansible playbook https://github.com/TheShellLand/antsable/blob/master/playbooks/rancher2.yml
Set API endpoint to https://<IP_ADDRESS>:8443

Result:
Wrong IP addressed used for Node
Other details that may be helpful:
ip r
vagrant@rancher1:~/antsable$ ip r
default via <IP_ADDRESS> dev enp0s3 proto dhcp src <IP_ADDRESS> metric 100
default via <IP_ADDRESS> dev enp0s8 proto dhcp src <IP_ADDRESS> metric 100
<IP_ADDRESS>/24 dev enp0s3 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS> dev enp0s3 proto dhcp scope link src <IP_ADDRESS> metric 100
<IP_ADDRESS>/16 dev docker0 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS>/24 dev enp0s8 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS> dev enp0s8 proto dhcp scope link src <IP_ADDRESS> metric 100

hostname -I
vagrant@rancher1:~/antsable$ hostname -I
<IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.0
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): custom
Machine type (cloud/VM/metal) and specifications (CPU/memory): vagrant
Kubernetes version (use kubectl version): na

(paste the output here)

Docker version (use docker version):

Client:
 Version:           18.09.3
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        774a1f4
 Built:             Thu Feb 28 06:40:58 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.3
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.8
  Git commit:       774a1f4
  Built:            Thu Feb 28 05:59:55 2019
  OS/Arch:          linux/amd64
  Experimental:     false

The IP address(es) for the node can be specified using flags described at https://rancher.com/docs/rancher/v2.x/en/cluster-provisioning/custom-clusters/agent-options/#ip-address-options.
If that doesn't work, please share the exact command used to add the node.


serbian input

Steps to reproduce
vim runtime/lang/menu_sr_rs.utf-8.vim
try to make a search or go to insert mode and try to type
text will be recognized as serbian even if you have english keyboard on
Expected behaviour
normal input
Version of Vim
source
Environment
arch
Logs and stack traces
No response

it is because of keymap=serbian in the end i will remove it in my next pr

:setlocal keymap&


New Diffusion-Consensus function for caught-up-ness

PR input-output-hk/ouroboros-network#4555 adds a new function to the interface that the Diffusion Layer demands from the Consensus Layer. See Issue input-output-hk/ouroboros-network#4530 for the underlying motivation.
This task is to implement that function.
The interface we discussed with the Networking Team serves two purposes simultaneously.

It parses a recent ledger state in order to extract information about the registered stake pools (eg relative stake, relay node IP addresses, etc).

It decides whether the Diffusion Layer can currently safely sample a root peer from those ledger peers instead of the trusted public root peers (since Genesis is not yet deployed).

We anticipate the parsing will be simple. But the exact decision rule deserves more discussion. It has three constraints:

The node should not sample its root peers from a ledger state that is too old, since the contained stake distribution, IP addresses, etc may no longer match the current state of the real world.

The node should not sample its root peers from a ledger state when the node's immutable tip is too old, since there's a significant probability that one of its peers is adversarial and so could be performing a long-range attack. (Genesis will supplant this concern.)

Otherwise, the node should sample its root peers from the ledger state when possible, to reduce load on the trusted public roots. (ChainSync Jumping will help this, but not supplant it.)

Constraint (2) dominates constraint (1), and constraint (3) is merely saying constraint (2) should not be excessively conservative. So it's really constraint (2) that this issue must design and implement.
See my contribution to the description of Issue input-output-hk/ouroboros-network#4530 for the approach to satisfying constraint (2). I suspect the implementation will provide a specific threshold of the immutable tip age to use during each era.
Recall that the HFC can always determine the UTC time stamp of a block's ledger state: the ledger state itself must contain suffici information for the time translation to succeed. Thus the node can always determine the age of the immutable tip by mapping it to a UTC time and subtracting it from the wall clock.

Should split this Issue in two: one for the design work, one for the implementation work. We've started the design work, but not the implementation work. EG It may end upthat two separate people do them.

@nfrisby we will need a similar API when switching between Genesis and Praos mode to change the number of big ledger peers which the diffusion is using.  The design could also answer if they differ or not (which is not obvious to me), or maybe this deserves a separate issue.

Implemented in #808


Use typed mocks

Area for Improvement
We can update our use of gomock to generate typed functions by passing in -typed.
From the command line help:
  -typed
    	Generate Type-safe 'Return', 'Do', 'DoAndReturn' function

Observed behavior
We don't pass in -typed so none of the gomock generated code is strongly typed. This slows down development for us, because it's possible to get the wrong signatures.
Desired behavior
Use -typed everywhere we create a mock. This shouldn't break us if we already wrote correct code.
Proposed Fix

Do a search for //go:generate mockgen. Replace with //go generate mockgen -typed.
Run make generate-go.
Run the tests (should work).

rad Version
asdf
Operating system
No response
Additional context
No response
Would you like to support us?

[ ] Yes, I would like to support you

AB#12367

/assign @superbeeny

@superbeeny could you comment on this with /assign to assign this issue to yourself, since you have a PR for this :)

/assign


A test Bounty

Is your feature request related to a problem? Please describe.

[!TIP]
Bounty: 10 LPT
Issued by: @rickstaa (AI SPE)

i need bounty how can i get

Hey @Anshgrover23,
Great to see your interest in contributing to the Livepeer AI project! The software bounties mentioned in the AI SPE Phase 2 proposal are not yet active. This was a test issue to ensure our automation is functioning correctly 🤓.
To stay updated on the bounties' launch, please join the ai-video channel on our Discord server. In the meantime, you can get ready to work on the AI subnet by familiarizing yourself with the Livepeer AI Subnet and our documentation.
Looking forward to your contributions 🚀!

@Anshgrover23 the bounties for the Livepeer system are found on https://github.com/livepeer/bounties 🚀.


decouple external from shelf temperature

Yes, this is indeed a good thing to integrate. It will be very useful to work with different external temperatures, maybe even make it vial specific. That would allow us to integrate some anisotropy (i.e. the side close to the door will experience a higher Text).


Bug fix

Overview

Fixed bug relating to no dentist.txt file
Fixed bug relating to no data folder
Fixed bug relating to recordedit

Coverage increased (+0.1%) to 52.832% when pulling 739d3f7e601084233e4cecad7adfe02d64e3e9af on wSemis:master into 5ecab0f6e6641dc19d7422baeead53d4e123b57a on CS2103-AY1819S2-W17-2:master.

Issues resolved: [Resolve #164],


It would be nice to be able to modify the command line for the compiler

E.g. Seems like it is not possible to modify -O3. Would be nice feature!

Hi, you could just enter the optimization flag in the "compilerArgs" field, the standard one should be overwritten.
https://godbolt.org/z/obeqbrdYv

I tried the compilerArgs already, what happened in command line was the following:
clang++ ... -O3 ... -O1
It compiled without errors but I think the second parameter was simply ignored

At least in the Compiler Explorer link, the first argument is overridden.

Ok thanks, seems to work. Now the only issue is that the same command line parameters are applied to debug and release.


linker: add iterable section macros

For iterable areas defined with Z_STRUCT_SECTION_ITERABLE(),
the corresponding output section in the linker script is just
boilerplate. Add macros to make these definitions simpler.
Unfortunately, we have a fair number of iterable sections not
defined with Z_STRUCT_SECTION_ITERABLE(), this patch does not
address this.
The output sections are all named <struct name>_area, update
sanitylib.py with this.
sys_sem with no userspace, and k_lifo/k_fifo are special cases
where different data types that are all equivalent need to be
put in the same iterable area. Add
Z_STRUCT_SECTION_ITERABLE_ALTERNATE() for this special case.
Signed-off-by: Andrew Boie<EMAIL_ADDRESS>

Checkpatch issues are false positives, we are using the preprocessor here for something that is not C code.

This PR seems to reorder the handles of the services completely (i.e. the service that has the lowest handle number in master has the highest in this PR).
@Vudentz could you take a look?

I think I know what this is. I dropped the SORT directives in the macros, but it seems this is necessary for this piece. Thanks for helping check this out!


[test][broker]auto relealse connection when use proxy

Motavitions
There are some test cases that are not covered in PIP-165: When the Pulsar Proxy is deployed, the client automatically releases free connections

#16165

Modifications
Append test case.
Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


App Management at Startup

The current app loading strategy is a bit of a mess, and it makes development difficult.  There are two scenarios:

More sophisticated built-in apps such as the job manager or the app manager require iteration and development
User apps need to be deployed and iterated upon.

Currently, apps are all copied to a temporary directory from which they are hosted.  Built-in apps are copied from the installation directory, and the user apps are copied from an installed apps directory.  There is no need to do this copy operation every time, but we do want updated apps to be copied from the installation when new versions are installed, and user apps will be updated routinely, and need to be copied over.  In addition, it's advantageous to be able to edit the apps in place, in their temporary hosted location, but of course these changes don't take effect unless the app contents are manually copied from the temp directory back to the app installation location.
We need a way to

Facilitate development of internal and user apps by allowing edits to "live" apps that are preserved
Speed up the app loading process if no new apps are to be installed/changes to be made.

One strategy might be to:

Scan all the installed apps, if an app isn't installed, install it.
Have a special flag in an app launch that "reabsorbs" apps into the system app tree, that way apps can be edited live, and maintained in the tree.

I dunno.  More to think about here.

This is fixed from 4b1243d6c137cac851f on


Refactor c/i/image

This vendors in https://github.com/containers/image/pull/122 and updates for API changes.

@runcom ACK please?

:+1:


Truncated shebang command help description

Version(s)
0.1.0
Describe the bug
Command-line help for shebang command currently states:
This command is an equivalent of `run`, but it changes the way how

Apparently the description is incomplete and seems to have been truncated.
To Reproduce
Run:
scala-cli --help

Look for the line mentioning the shebang command.
Expected behaviour
The command description is complete.

@lwronski Thank you


[SD-1871] Add a write-through cache interpreter to KeyValueStore

Adds a transformation from KeyValueStore into Free[Coproduct[Cache[KeyValueStore, ?], KeyValueStore, ?], ?]. This allows any KeyValueStore implementation to be used as a cache for another.
This particular cache is write-through and only caches reads, however it caches all reads (a read will never be sent to the backing store, even on miss) and thus must be pre-warmed in order to return existing values, otherwise it will only return values that have changed.

[Current coverage][cc-pull] is 74.17%

Merging [#1268][cc-pull] into [master][cc-base-branch] will increase coverage by 0.11%

@@             master      #1268   diff @@
==========================================
  Files           192        193     +1
  Lines         11005      11033    +28
  Methods       10773      10801    +28
  Messages          0          0
  Branches        105        103     -2
==========================================
+ Hits           8151       8184    +33
+ Misses         2854       2849     -5
  Partials          0          0

Powered by Codecov. Last updated by [a7eb0a7...9ee3992][cc-compare]
[cc-base-branch]: https://codecov.io/gh/quasar-analytics/quasar/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/quasar-analytics/quasar/compare/a7eb0a775913f8ee59bf63847876490e6169ec09...9ee399226d4af6c9a2f9eafe51722ec71cc8cfbb?src=pr
[cc-pull]: https://codecov.io/gh/quasar-analytics/quasar/pull/1268?src=pr

@wemrysi Does this improve the performance of Cloud?

@jdegoes It will be used to in quasar-advanced, yes.

Not having much success with this approach, going to try a different direction.


Reserve space in Node for children

I'm trying to populate tables with a lot of children and thought that the ability to use Vec::reserve on El::children could be very useful in cases like these.

Do you have an example so we can try it to see difference between both versions (with or without reserve?)

Something like this:
fn view(model: &Model) -> impl View<Event> {
    let table = table![];
    table.reserve_children(1000);

    for row_index in 0..1000 {
        let row = tr![];
        row.reserve_children(10);

        for cell_index in 0..10 {
            row.add_child(td![cell_index.to_string()]);
        }

        table.add_child(row);
    }

    return table;
}

I made a complete benchmark here: https://gist.github.com/daxpedda/79bdb173fad9cc2050acbd09be706304
The difference for this example on my computer is a 20 - 25% speedup.

On a sidenote, if this is too much of a niche use case, considering that all members are public an additional API is not absolutely necessary.
For example something like this can be used:
let mut table = table![];

if let Node::Element(el) = table {
	el.children.reserve_exact(1000);
}

if this is too much of a niche use case, considering that all members are public an additional API is not absolutely necessary.

I agree with this ^. If it turns out to be too painful, we can reopen this issue and design more universal API for similar cases.

Alright.


preview post mode Twitter

Describe the feature
Fazer o preview post mode para rede social twitter/X.
Use Case
[Explain the use for this feature and how it might benefits the project.]
Implementation Details
[Provide any details or suggestions on how this feature could be implemented.]
Visual Concepts
[Does it imply any visual changes to the application? Visual elements are required in the issue]
Additional Information
[Provide any additional information, such as context that might be relevant to the implementation of this specific feature.]

Obrigado por abrir a issue
Verifique os nossos guidelines:

Código de conduta
Contribuição
Guia de Estilo

Eu quero!!!


add search to localhost

this pr adds search to our localhost env for easier testing
asana task
tested and it works!

Hey @mirnawong1, .env files are intended on being used locally without being pushed to Git. In most cases they are used for storing private API keys locally. Then once the code is being served in production, it pulls the env variables from the hosting provider (Vercel in our case).
Although we don't have any sensitive API keys here, I would prefer we continue to keep the .env files out of Git.
.env files are often marked in the .gitignore file, which prevents certain files from accidentally being pushed to Git.


Cannot toggle between tabs after closing an open tab

I am currently using Chrome and a keyboard shortcut to toggle tabs. If I'm toggling between tab A and tab B and I open new tab C then immediately close it, I can no longer toggle between tab A and tab B.
I remember it used to work but recently stopped working.
If i click on the icon nothing happens, but if I use the button in the dropdown the closed tab will reopen. That's not the behavior I was expecting or hoping for. I want the last viewed and open tab to be toggled to.

Thanks @davzhou labelled as enhancement. It used to be a feature. I removed it to revert to the original functionality of this extension (toggle only between two tabs. Nothing more, nothing less).

@davzhou can you confirm that this is solved after updating to ver.9

@davzhou for me it's working and remembering the last tab before the two recent tabs, for what it's worth.

Yup, looks good, thanks!


[PSRule] Fix Rule Azure.VM.AMA

Solve PSRule error AZR-000345: failed Azure.VM.AMA. Use Azure Monitor Agent for collecting monitoring data.
https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.VM.AMA/
To deploy virtual machines that pass this rule:

Deploy an extension sub-resource Microsoft.Compute/virtualMachines/extensions.
Set properties.publisher to Microsoft.Azure.Monitor.
Set properties.type to AzureMonitorWindowsAgent (Windows) or AzureMonitorLinuxAgent (Linux).

Hey @rahalan,
just migrated this issue from CARML. Please take a look if it's still relevant and triage :)

Already fixed in AVM


final newline character via .editorconfig

This PR tries to address #63 by moving the insert final newline character logic to an editorconfig post process function. The post processor will insert a final newline only if the insert_final_newline is set to true.

It merged. thanks! https://github.com/vvakame/typescript-formatter/commit/2df1f7aea4c61134f42cff1c8e7400d77fc57f07
I released 3.1.0 to npm.

Thanks


exiftool: 13.00 -> 13.10

Fixes #367350

Upgrade exiftool to 13.10 (latest production release)

See https://exiftool.org/history.html

Add perlPackages.IOCompressBrotli package to nixpkgs

Fix missing Brotli support and add missing ArchiveZip, CompressRawLzma, IOCompress, IOCompressBrotli, UnicodeLineBreak required dependencies

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

$ nix run .#exiftool -- -ver -v
ExifTool version 13.10
Perl version 5.040000 (-C0)
Platform: linux
Optional libraries:
  Archive::Zip                 1.68
  Compress::Zlib               2.206
  Digest::MD5                  2.58_01
  Digest::SHA                  6.04
  IO::Compress::Bzip2          2.206
  Time::Piece                  1.3401_01
  Time::Local                  1.35
  Unicode::LineBreak           2019.001
  Compress::Raw::Lzma          2.206
  IO::Compress::RawDeflate     2.206
  IO::Uncompress::RawInflate   2.206
  IO::Compress::Brotli         0.019
  IO::Uncompress::Brotli       0.019

Adding perlPackages.IOCompressBrotli is a resolution to read metadata from Brotli-compressed files:
$ nix run .#exiftool -- ~/tmp/exiftool/t/images/JXL2.jxl
ExifTool Version Number         : 13.10
File Name                       : JXL2.jxl
Directory                       : .


Forcing use of make_value, make_table, make_array, etc.

Because of std::enable_shared_from_this created factory functions make_value, make_array, make_table, and make_table_array to force the user to create shared_ptr<ELEMENT>.
Additionally this changes the return value of parser::parse() and parse_file() to std::shared_ptr<table>.
This cleans up the interface and prevents user error when creating cpptoml documents in code.

As a note, I would think after this commit you could consider cpptoml to be a full-fledged decoder/encoder of TOML and note this in the toml-lang/toml README.md.

I'll probably write up a harness for the toml-test suite to run the encoding part through its paces, and then I'd agree. Thanks!


ReplaceFragment

A bunch of redundant code, needs to be improved

this has been fixed was just created du to now knowing how pull requests work when you improve the code before it's been accepted

.

This has been fixed was just created du to now knowing how pull requests work when you improve the code before it's been accepted


Update role binding for secret viewer

it should be able to see all secrets in the namespace

Coverage remained the same at 68.44% when pulling 36192c9535207eab34ed09ec8c12c8baae7c8d3a on pankrator-patch-1 into 280a8aa291502bf3fda15dd874adae2dc9887665 on master.


now contacts list will appear sorted by name

• Now contact will appear sorted by name.
• On searching the contact the searches will also appear sorted by name.

Good Work, bro !
Had great time working with you @MayankUjawane, @priyalbhatewara123 and all other contributors!

Same here! You guys were amazing throughout. ✨
Remember open source is not limited to any program , if you wish to contribute more to this project then you are most welcome.❤

Good Work, bro !
Had great time working with you @MayankUjawane, @priyalbhatewara123 and all other contributors!

Thank You to both of you @codeDamon and @priyalbhatewara123 I learned a lot from both of you.


[JENKINS-30013] Add support for later versions of config-file-provider-plugin

More recent version (starting with 2.8.1) have a different constructor signature for MavenSettingsConfig causing the DSL plugin to fail with later version of the plugin (was failing yesterday with 2.9.2).
Switched to using a data binder similar to StaplerRequest.bind to support any constructor signature as long as it is annotated with @DataBoundConstructor. Constructor parameters are now provided as a Map and all supported parameters will be passed to the constructor.

Ok, there are some code style issue as the code for the databinder is mostly inspired by org.kohsuke.stapler.RequestImpl that should be easy to fix but I'd be interested to know if that's the right approach to solve that issue.
Thanks!

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Thanks for reporting this issue.
I would like to go for a simpler solution. Update the config file provider plugin dependency to 2.8.1 and use the new constructor.
https://github.com/jenkinsci/job-dsl-plugin/blob/751df8866a8a84a94122640554da4434107a6c73/job-dsl-plugin/build.gradle#L65
We do not need to care about compatibility here in the same way as for generating the XML. When we change the XML to use a new plugin version, it will fail silently for all users who use an older version. But when updating the dependency, Jenkins makes sure that a compatible version of the plugin is installed and nothing will fail.

OK.
Should I also update https://github.com/jenkinsci/job-dsl-plugin/blob/c7dd785d482500484c86dd8c1ae8c159d7ab6406/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy#L267 to indicate a minVersion?

No, it's not necessary. Jenkins will automatically install the required minimum version, so the warning would never be shown.

OK, get it!
So you mean something like this?

Great, thanks!


vue-cli-service doesn't reload /recompile when new file is created

Version
3.9.2
Environment info
Ubuntu 18.04

fs.epoll.max_user_watches = 13489745
fs.inotify.max_user_watches = 524288

$ node -v
v8.10.0

Steps to reproduce
Create project with many .vue files
after some time while files were increasing we had to change the below system params:
fs.epoll.max_user_watches = 13489745
fs.inotify.max_user_watches = 524288
then after some time we faced the issue again but problem not solved even if we increased the above limits.
If we create then a new file, this new file is not recognized and npm run serve doesn't recompile this file code on the fly as it should.
We have even tried latest alpha vue-cli versions and older ones too but the problem is still the same.
Our src folder contains 129 files.
What is expected?
on every new file created the npm run serve should recompile the code automatically.
What is actually happening?
on every new file created the npm run serve doesn't recompile the code automatically.

it seems that we have reached some kind of limitation on vue-cli serve side.
Do you have any idea for this?
thank you in advance

We found out that doing commit -a on git solved the problem for us.....


Add async-http-client plugin

Please answer these questions before submitting a pull request

Why submit this pull request?
[ ] New feature provided
Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

need to fix


Replace host.ReportFatalError with ReportStatus in rcvr_unixsocket

https://github.com/open-telemetry/opentelemetry-collector/pull/9506 removed deprecated codepath for fatal errors in reciever setup so need to replace to have compatibility with newer otel
I've tested this with an invalid socket path and bumped the dependencies too in a seperate commit https://github.com/open-telemetry/opentelemetry-collector-releases/releases
error   trace2receiver@v0.5.1/rcvr_unixsocket.go:173    could not create socket: listen unix /usr/trace2.socket: bind: operation not permitted  {"kind": "receiver", "name": "trace2receiver", "data_type": "traces"}
github.com/git-ecosystem/trace2receiver.(*Rcvr_UnixSocket).openSocketForListening
        github.com/git-ecosystem/trace2receiver@v0.5.1/rcvr_unixsocket.go:173
github.com/git-ecosystem/trace2receiver.(*Rcvr_UnixSocket).Start
        github.com/git-ecosystem/trace2receiver@v0.5.1/rcvr_unixsocket.go:46

Hey Alex, thanks for the PR.  Let me take a look and get back to you.


[ODB] lefout: Fix typo

LGTM other than the build failure.

if you merge master the mac problem should go away (GH changed their mac setup and I had to fix a bunch of things to make it happy)

Out of curiosity how did you find this bug? I didn't know anyone was using the abstract lef support.

@QuantamHD https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/312 was opened. I suggested using this instead and deprecating the script. I was skimming through the code to see if it handled the issue and I spotted this.
To be fair, many origins are centered at (0, 0) so the bug infrequently manifests.


Update CI check for integ-test-with-security to run all integ tests with security

Description
This updates another instance where the client is used instead of adminClient which results in an integ test failure when the security plugin is installed.
Mitigates this test failure observed in ShrinkActionIT
REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.indexmanagement.indexstatemanagement.action.ShrinkActionIT.test allocation block picks correct node with exclude node" -Dtests.seed=171CE8075C46FB4E -Dtests.security.manager=false -Dtests.locale=ru -Dtests.timezone=Etc/GMT -Druntime.java=21

2> org.opensearch.client.ResponseException: method [PUT], host [https://localhost:9200/], URI [.opendistro-ism-config/_settings], status line [HTTP/1.1 403 Forbidden]

{"error":{"root_cause":[{"type":"security_exception","reason":"no permissions for [] and User [name=admin, backend_roles=[admin], requestedTenant=null]"}],"type":"security_exception","reason":"no permissions for [] and User [name=admin, backend_roles=[admin], requestedTenant=null]"},"status":403}

Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Created a backport PR for 2.17 https://github.com/opensearch-project/index-management/pull/1244
Someone please take care of failed backport of 2.x to avoid commits diff.
@tandonks @vikasvb90


execute-job/comment-from-wrong-user-on-pr/b215989a-8ba8-4fe0-9117-c7fbf2b8584b

PR for testing 97552b5b5db06053d5bf52c56fea45e477213478

/canonical/self-hosted-runners/run-workflows 97552b5b5db06053d5bf52c56fea45e477213478


More specific logging in gather_for_metrics

Problem
When accelerate.prepare()-ing a DataLoader for an IterableDataset, the prepared dataloader is a DataLoaderDispatcher. A DataLoaderDispatcher only knows its remainder when it is at the end of its iteration. As the current behavior of gather_for_metrics is to log whenever there's a remainder not set (and has the default value of -1), this means that there will be a ton of log messages from gather_for_metrics about a remainder not being set, even when not at the end of the dataloader.
Solution

Update gather_for_metrics to only check for a unset remainder when we're at the end of the dataloader
Add test case to test_ops that captures this case (fails without this change) by asserting on the number of log messages

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[DO NOT LAND] Testing CI

Pull Request Test Coverage Report for Build #1085

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.042%

Totals

Change from base Build #1082:
0%

Covered Lines:
5509

Relevant Lines:
5921

💛  - Coveralls


[odin bindings] Exclude 'NUM' enum values

There is no reason to have a NUM field at the end of an enum in Odin. Because unlike in C, Odin supports len(My_Enum). And the additional enum field also interferes with things like enumerated arrays and bit_sets.

Thanks! I'll try looking at your other PRs later today.

Thank you! The other PRs I've submitted were mostly things I ran into while working on my game. But I never got around to submitting them upstream, so I did that now all at once :)


Blackbricks forces indentation of two spaces, even when user/notebook setting set to four spaces

By default, yes. The default is 2 spaces because that is what Databricks used to force on you. Now they let you choose, but to be backwards compatible the default used by blackbricks is still 2 spaces. To my knowledge Databricks does not expose notebook settings through any API either, so not much that blackbricks can do about it.
You'll just have to use the command line option to disable 2 space indentation, and that will work fine.


[SANV2-138576][V3.1.1] - fix deploy and promote jobs

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

The jobs deploy and promote use sed command to change image.tag deployment and some projects has more than one image in template and this approuch broke the pipeline
Issue Number: SANV2-138576
The new version
New release version candidate: v3.1.1

Reviewers, please check if the release candidate is present in the changes of this PR in the examples section!

What is the new behavior?
Now those jobs, deploy and promote uses yq command to precisely change only .helmCharts[0].valuesInline.image.tag data
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
The capability of use yq as change tool is set as default but the old approch still available to cover legacy scenarios

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/dafiti-group/orb-standard-pipeline?version=dev:f464ab6e30c37b5d85cfbfc410e7035a7a32457a

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/dafiti-group/orb-standard-pipeline?version=dev:ec69841d727116ff0aa61bbefd77692b5ad40724

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/dafiti-group/orb-standard-pipeline?version=dev:21ae779bc05912daf52c434162ee42aedf94efbb

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/dafiti-group/orb-standard-pipeline?version=dev:71bf185842c336769e4a0df6b839500928615b2c

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/dafiti-group/orb-standard-pipeline?version=dev:71bf185842c336769e4a0df6b839500928615b2c

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/dafiti-group/orb-standard-pipeline?version=3.1.1


[sil] Add an option (disabled by default) to turn off TypeLowering's …

…ConstantInfo cache.
When debugging in SILGen, one often times will want to examine why a specific
SILConstantInfo is being generated. If the value is already generated (and thus
one hits the cache), this is impossible.
rdar://34222540

@swift-ci smoke test and merge

@swift-ci smoke test and merge

@swift-ci smoke test and merge


Cut release v0.25.0

closes https://github.com/KittyCAD/modeling-app/issues/3757
What's Changed

We migrated desktop app platforms! and we wrote 50+ new tests to celebrate 😄
Lofts are now available in KCL code (#3681)
KCL now allows multi-line comments in |> expressions (#3731)
KCL breaking change: replace tanArc(to) with tanArcToRelative (#3729)
Execution now halts when swapping files (#3703)
Newly redesigned sign-in page (#3684)
Too many bug fixes, tests, and deep system improvements to count
And official welcome to the frontend team for Kevin, Lee, and Jon ❤

Full Changelog: https://github.com/KittyCAD/modeling-app/compare/v0.24.12...v0.25.0

just wanna make sure we wait on the 4 things pending here :) https://github.com/orgs/KittyCAD/projects/32/views/1

Got three actions to look at for updater tests:

https://github.com/KittyCAD/modeling-app/actions/runs/10692379931 a 0.25.0 electron build pushed to a test side of the bucket
https://github.com/KittyCAD/modeling-app/actions/runs/10692413196 an update that should pop up on that 0.25.1 build
https://github.com/KittyCAD/modeling-app/actions/runs/10692410056 a tauri build of the latest branch pointing to that test side of the bucket

Should test the whole tauri-to-electron-to-electron flow

Nevermind, two new test builds to look for:

https://github.com/KittyCAD/modeling-app/actions/runs/10693616319
https://github.com/KittyCAD/modeling-app/actions/runs/10693626212

Confirmed with:

https://github.com/KittyCAD/modeling-app/tree/pierremtb/issue3528-updater-tauri-to-electron
https://github.com/KittyCAD/modeling-app/tree/cut-release-v0.25.0-updater-test-build-1
https://github.com/KittyCAD/modeling-app/tree/cut-release-v0.25.0-updater-test-build-2

that the auto update flow worked as expected on macOS from tauri to electron build 1 to electron build 2

Smoke tested the whole updater loop: tauri to electron to electron + 1 on macOS and Windows, all looking good.


[ART-3429] gen-assembly: include upgrades field

Rebased

The return of the curious test failure :/

/lgtm

Hey @vfreex , this story came out a few days ago, after we messed up an in_flight_ prev https://issues.redhat.com/browse/ART-3705
Basically the rationale is - right now in_flight_prev is lost in that long list of edges, and it's hard to review.
So we would like it to be a separate required field - could be any sensible name "in_flight_prev" is probably
the easiest. Schema wise could be a subkey of "upgrades", don't have a strong preference.
But basically making in_flight_prev explicit would be good for 1) review + 2) promote job validation - check if the assembly definition is the latest/greatest in releases.yaml
Would appreciate your thoughts.

/lgtm


Update home page link in every directory.

In every project directory, the link for the main index.html file is not set. Change the "a" tag in the index files of the projects directory.

i want help

is the task put forward slash in projects index.html which are not back home when click the home?

@dastonrajapboyev Yes, The link for the home page needs to be updated.


Remove keys from User toString

Override toString for User to not include access and secret keys, and validate it doesn't show up in any log statements. User keys are encrypted by default but no point in showing them in possible output

Let's do it (if it isn't already done)


Ghost events with Aqara vibration Sensor

Hi,
I having a Aqara Vibration Sensor for over 2 weeks now and everything was fine for about 1 1/2 weeks.
Recently the sensor triggers even when there is no reason for it. Can you see something in the logs or is the sensor simply broken?

19:25:49:361 0x00158D00039D694B: 0x0101/0x0505: vibration strength: 2
19:25:49:362 no button handler for: lumi.vibration.aq1 ep: 0x01 cl: 0x0101 cmd: 0x0A pl[0]: 0x05
19:25:49:362 ZCL attribute report 0x00158D00039D694B for cluster 0x0101, ep 0x01
19:25:55:844 ZCL attribute report 0x7CB03EAA00B26CE7 for cluster 0x0006, ep 0x03
19:26:27:609 Current channel 25
19:26:27:617 Device TTL 6419 s flags: 0x7
19:26:58:147 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0000, ep 0x01
19:27:27:609 Current channel 25
19:27:27:617 Device TTL 6359 s flags: 0x7
19:27:33:618 GW firmware version: 0x264a0700
19:27:33:618 GW firmware version is up to date: 0x264a0700
19:28:27:608 Current channel 25
19:28:27:616 Device TTL 6299 s flags: 0x7
19:29:12:032 ZCL attribute report 0x7CB03EAA0A003CDF for cluster 0x0006, ep 0x03
19:29:12:036 no button map for: lumi.weather ep: 0x01 cl: 0x0405 cmd: 0x0A pl[0]: 000
19:29:12:036 ZCL attribute report 0x00158D00036D5AD1 for cluster 0x0405, ep 0x01
19:29:12:075 no button map for: lumi.weather ep: 0x01 cl: 0x0403 cmd: 0x0A pl[0]: 000
19:29:12:075 ZCL attribute report 0x00158D00036D5AD1 for cluster 0x0403, ep 0x01
19:29:27:608 Current channel 25
19:29:27:616 Device TTL 6239 s flags: 0x7
19:30:27:610 Current channel 25
19:30:27:618 Device TTL 6179 s flags: 0x7
19:30:48:885 0x00158D00039D694B: 0x0101/0x0505: vibration strength: 2
19:30:48:887 no button handler for: lumi.vibration.aq1 ep: 0x01 cl: 0x0101 cmd: 0x0A pl[0]: 0x05
19:30:48:887 ZCL attribute report 0x00158D00039D694B for cluster 0x0101, ep 0x01
19:30:49:940 0x00158D00039D694B: 0x0101/0x0055: event: 1
19:30:49:942 button 1007 Shake
19:30:49:942 ZCL attribute report 0x00158D00039D694B for cluster 0x0101, ep 0x01
19:30:50:489    0x000D6FFFFE464DC2 force poll (2)
19:30:50:493 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0006, ep 0x01
19:30:50:572    0x000D6FFFFE464DC2 force poll (2)
19:30:50:594 Set sensor check interval to 100 milliseconds
19:30:51:573 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:30:52:093 delay sending request 90 dt 1 ms to 0x000D6FFFFE464DC2, cluster 0x0300
19:30:52:134    0x000D6FFFFE464DC2 force poll (2)
19:30:52:214    0x000D6FFFFE464DC2 force poll (2)
19:30:53:217 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:30:54:092    0x000D6FFFFE464DC2 force poll (2)
19:30:54:171    0x000D6FFFFE464DC2 force poll (2)
19:30:55:175 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:30:58:024 delay sending request 138 dt 0 ms to 0x000D6FFFFE464DC2, cluster 0x0300
19:30:58:024 delay sending request 140 dt 0 ms to 0x000D6FFFFE464DC2, cluster 0x0006
19:30:58:086    0x000D6FFFFE464DC2 force poll (2)
19:30:58:094 delay sending request 140 dt 1 ms to 0x000D6FFFFE464DC2, cluster 0x0006
19:30:58:171    0x000D6FFFFE464DC2 force poll (2)
19:30:58:175 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:30:58:257    0x000D6FFFFE464DC2 force poll (2)
19:30:58:261 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0006, ep 0x01
19:31:27:607 Current channel 25
19:31:27:615 Device TTL 6119 s flags: 0x7
19:31:28:938 Announced to internet https://phoscon.de/discover
19:31:33:618 GW firmware version: 0x264a0700
19:31:33:618 GW firmware version is up to date: 0x264a0700
19:31:54:994 sensor 8 (lumi.vibration.aq1): disable vibration
19:31:55:193 Set sensor check interval to 1000 milliseconds
19:32:27:607 Current channel 25
19:32:27:615 Device TTL 6058 s flags: 0x7
19:33:27:610 Current channel 25
19:33:27:618 Device TTL 5998 s flags: 0x7
19:34:04:938 ZCL attribute report 0x7CB03EAA0A003CDF for cluster 0x0006, ep 0x03
19:34:22:733 no button map for: lumi.weather ep: 0x01 cl: 0x0000 cmd: 0x0A pl[0]: 001
19:34:22:733 ZCL attribute report 0x00158D00036D5AD1 for cluster 0x0000, ep 0x01
19:34:22:733 0x00158D00036D5AD1 extract Xiaomi special attribute 0xFF01
19:34:22:733    01 battery 2995 (0x0BB3)
19:34:22:733    04 unknown 13224 (0x33A8)
19:34:22:733    05 RSSI dB (?) 13 (0x000D)
19:34:22:734    06 LQI (?)<PHONE_NUMBER> (0x0100000000)
19:34:22:734    64 temperature 2871
19:34:22:734    65 humidity 2997
19:34:22:734    66 pressure 1008
19:34:22:734    0a unknown 13463 (0x3497)
19:34:27:608 Current channel 25
19:34:27:618 Device TTL 5938 s flags: 0x7
19:35:27:610 Current channel 25
19:35:27:618 Device TTL 5878 s flags: 0x7
19:35:33:617 GW firmware version: 0x264a0700
19:35:33:618 GW firmware version is up to date: 0x264a0700
19:35:48:981 0x00158D00039D694B: 0x0101/0x0505: vibration strength: 3
19:35:48:983 no button handler for: lumi.vibration.aq1 ep: 0x01 cl: 0x0101 cmd: 0x0A pl[0]: 0x05
19:35:48:983 ZCL attribute report 0x00158D00039D694B for cluster 0x0101, ep 0x01
19:35:49:549 ZCL attribute report 0x7CB03EAA00B26CE7 for cluster 0x0006, ep 0x03
19:35:50:036 0x00158D00039D694B: 0x0101/0x0055: event: 1
19:35:50:039 button 1007 Shake
19:35:50:039 ZCL attribute report 0x00158D00039D694B for cluster 0x0101, ep 0x01
19:35:50:094 Set sensor check interval to 100 milliseconds
19:35:50:593    0x000D6FFFFE464DC2 force poll (2)
19:35:50:597 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0006, ep 0x01
19:35:50:678    0x000D6FFFFE464DC2 force poll (2)
19:35:51:680 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:35:52:093 delay sending request 184 dt 1 ms to 0x000D6FFFFE464DC2, cluster 0x0300
19:35:52:129    0x000D6FFFFE464DC2 force poll (2)
19:35:52:207    0x000D6FFFFE464DC2 force poll (2)
19:35:53:211 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:35:54:089    0x000D6FFFFE464DC2 force poll (2)
19:35:54:170    0x000D6FFFFE464DC2 force poll (2)
19:35:55:170 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:35:58:025 delay sending request 233 dt 0 ms to 0x000D6FFFFE464DC2, cluster 0x0300
19:35:58:025 delay sending request 235 dt 0 ms to 0x000D6FFFFE464DC2, cluster 0x0006
19:35:58:088    0x000D6FFFFE464DC2 force poll (2)
19:35:58:094 delay sending request 235 dt 1 ms to 0x000D6FFFFE464DC2, cluster 0x0006
19:35:58:175    0x000D6FFFFE464DC2 force poll (2)
19:35:58:179 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0300, ep 0x01
19:35:58:259    0x000D6FFFFE464DC2 force poll (2)
19:35:58:263 ZCL attribute report 0x000D6FFFFE464DC2 for cluster 0x0006, ep 0x01

I have removed the sensor, reset and paired it again.
In the first line of the log you can see "vibration strength: 2" but it did not trigger there. But it triggered at 19:30:48 and 19:35:50.
Any help would be appreciated.

This is not an issue specific to the Docker image. Please open an issue on this repo: https://github.com/dresden-elektronik/deconz-rest-plugin.


add global_phase to QuantumCircuit class

Summary
Adds phase property to QuantumCircuit.
Details and comments
This is an adaptation of #3930.
Depends on #4622.

It this PR addressing https://github.com/Qiskit/qiskit-terra/issues/3304 ?

@1ucian0 That depends on whether to_matrix is supposed to agree with its definition and/or the associated EquivalenceLibrary circuit. If just the later, then this should resolve 3304. If it also needs to support definition then it may be handled in a separate pr.

@1ucian0 That depends on whether to_matrix is supposed to agree with its definition and/or the associated EquivalenceLibrary circuit. If just the later, then this should resolve 3304. If it also needs to support definition then maybe not.

I think it should agree with the definition (the matrix is what defines a gate).

Can you add a release note about this and emphasize that the phase only attaches to circuits (which are mutable) and not gates (which are not), and that the phase is in radians.
Also can you add a test of what happens if I have a circuit that is just a CX and a phase attached to it, and I try to control it. It should become a circuit that is a CCX plus single qubit rotations on the controls.

Also phase could be confused with the phase gate that is going to be added to replace u1 (#4106 ), so can we call this circuit property global_phase?

Ok nice it seems to work well now:
theta = 0
circ = QuantumCircuit(2, global_phase=theta)
circ.cx(0, 1)
print(circ.to_gate().control().definition)

control_0: ──■──
             │
 target_0: ──■──
           ┌─┴─┐
 target_1: ┤ X ├
           └───┘

circ.global_phase = np.pi/2
print(circ.to_gate().control().definition)

                ┌──────────┐
control_0: ──■──┤ U1(pi/2) ├
             │  └──────────┘
 target_0: ──■──────────────
           ┌─┴─┐
 target_1: ┤ X ├────────────
           └───┘

print(circ.to_gate().control(2).definition)

control_0: ──■───■─────
             │   │pi/2
control_1: ──■───■─────
             │
 target_0: ──■─────────
           ┌─┴─┐
 target_1: ┤ X ├───────
           └───┘

print(circ.to_gate().control(3).definition)
control_0: ──■───■─────
             │   │
control_1: ──■───■─────
             │   │pi/2
control_2: ──■───■─────
             │
 target_0: ──■─────────
           ┌─┴─┐
 target_1: ┤ X ├───────
           └───┘

Just so this is noted somewhere: BasicAer doesn't get the phases right (neither does Aer, but that'll be fixed within Aer I presume). The tests using BasicAer, which I think is only test_to_matrix in test_extensions_standard works by coincidence because the rotation angles are 0 and thereby the phase difference is e^{i0} = 1.
>>> qc = QuantumCircuit(1)
>>> qc.rz(0.2, 0)
>>> Operator(qc)
Operator([[0.99500417-0.09983342j, 0.        +0.j        ],
          [0.        +0.j        , 0.99500417+0.09983342j]],
         input_dims=(2,), output_dims=(2,))
>>> execute(qc, Aer.get_backend('unitary_simulator')).result().get_unitary()
array([[1.        +0.j        , 0.        +0.j        ],
       [0.        +0.j        , 0.98006658+0.19866933j]])
>>> execute(qc, BasicAer.get_backend('unitary_simulator')).result().get_unitary()
array([[1.        +0.j        , 0.        +0.j        ],
       [0.        +0.j        , 0.98006658+0.19866933j]])

BasicAer doesn't get the phases right (neither does Aer, but that'll be fixed within Aer I presume).

Do you mind submitting issues to terra and aer about this for better tracking?

Sure 👍  See #4805.

I apologies if my comment is out of place but I'm not sure I understand this pr correctly. Would you please help me understand the following points:
First, when building a controlled gate (add_control.py), you add phase gates to the control wires. As I understood it, this is to account for the global phase in the gate's circuit definition . However when you do that, you also add the accumulated phase from the gates you unrolled (lines 168 & 170). If I understand this correctly, shouldn't you subtract the accumulated global phase and not add it? Because if a gate/circuit has a global phase of say theta, then you unroll it, but the new set of gates adds a controlled global phase of say phi, then you only need to account for theta - phi and not theta + phi.
Second,  this pr adds global phase of -theta/2 to Rz's definition (line72 in rz.py). however, there are other standard gates which use Rz in their definitions, but do not inherit the global phase of Rz. Namely:
RXXGate, RYYGate, RZXGate, RZZGate and MSGate (there might be others).
Would it be appropriate to add global phase to those gates?
Finally, it's mentioned in the documentation, and in the discussion that global phase should be attached to circuits and not gates. Furthermore, that circuit_to_gate would lose the global phase. If that is the case, why then the global phase needs to be accounted for when building a controlled gate? (notice that circuit.control() converts a circuit to a gate, controls that gate, then creates a new circuit with the controlled gate). If however, you need to account for the phase when directly controlling a circuit, then this should be done outside the scope of building the controlled gate.
I apologies again if my comments are inappropriate, I'm working on another pr and I don't want to step on anyone's toe by making changes that would interfere with this pr.

Second, this pr adds global phase of -theta/2 to Rz's definition (line72 in rz.py). however, there are other standard gates which use Rz in their definitions, but do not inherit the global phase of Rz.

RZ was a bit a special case since before this PR it was not implementing the matrix you would expect exactly, but only up to a global phase of -theta/2. Since that doesn't matter on measurements we could still define RZ this way and all other gates that use it, like RZZ etc. The problem was just, that all the matrices of these gates were also incorrect. Now that RZ is fixed, all these are fixed automatically. They don't need an additional global phase, since RZ is correct now.

Finally, it's mentioned in the documentation, and in the discussion that global phase should be attached to circuits and not gates. Furthermore, that circuit_to_gate would lose the global phase. If that is the case, why then the global phase needs to be accounted for when building a controlled gate?

If we have a NxN matrix that represents the action of the circuit the measurement outcome will be the same even if we multiply this entire matrix by a factor exp(i theta). This theta is the global phase. However if we only multiply a sub-part of the matrix with this factor, the results change. E.g. if you have a global phase on a single qubit gate, the 2x2 matrix of the gate, say G, becomes phase * G. If you control that gate what you get is
( I |          )             ( I |   )
(   | phase * G)  != phase * (   | G )

Since we cannot pull phase out of the matrix the global phase matters and therefore we need to account for the global phase if we control a gate/circuit.

I'm not sure my points were clear. This PR implements "to_matrix()" for Rz with the correct matrix. Thus, Rz's matrix and the matrices for gate/circuits that uses Rz are indeed correct now. But what is used in running the circuit is the gate's circuit definition. Not the matrix representation.
The global_phase variable used in Rz circuit definition doesn't actually affect Rz. It just gets tracked.
If you control a gate with Rz in it's definition, it will give the correct gate if and only if it get's unrolled to Rz in add_control.py. Which shouldn't be the case, as long as you unroll to universal set of gates.
I apologies again, I just wanted to make sure I understand this PR correctly.
I will link to a dummy branch with what I thought this PR would do to help make my point clearer. Meanwhile, I'll assume that what is in this PR is the intended behavior and move on.
Dummy branch
Implements global_phase as gates once circuit is converted to gate/dag. (as mentioned in this pr's documentation), controls Rz correctly and adds controlled phase to the circuit, not the gate (in circuit.control() ).
As a result, it solves the the issues with BasicAer (matrix definition matches unitary simulator when optimization level=0) and other inconsistencies in the current implementation.
note: This is not a rigorous implementation and only meant to clarify my point