Pb with space in the local directory

When there is a space un the local directy, the git init failed
PS ....\visual studio Code> cd c:\Users\DXPC9379\visual studio Code\projet
Set-Location : Impossible de trouver un paramètre positionnel acceptant l'argument « studio ».
Au caractère Ligne:1 : 1
+ cd c:\Users\DXPC9379\visual studio Code\projet ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument : (:) [Set-Location], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.SetLocationCommand

PS ....\visual studio Code> git flow init -f
Fatal: Working tree contains unstaged changes. Aborting.

The actual error is Fatal: Working tree contains unstaged changes. Aborting.. You have to commit all changes first.

Yes but the firs error is 👍 cd c:\Users\DXPC9379\visual studio Code\projet
Set-Location : Impossible de trouver un paramètre positionnel acceptant l'argument « studio ».
There is a space in the directory
So the commande is not execute in the good directory.

 Did it solve problem?

To solve the problem, I go manualy in the directory and run the command.

Do you use WSL?

What is WSL ?

You run VS Code on windows, right? Do you have WSL on your windows machine? If you do not know what it is most [probably you do not. But I would strongly recommend to investigate this if you are developer.

I haven't

I try to solve it. I made few changes. Can you manually install extension and test if error is gone?
vscode-gitflow-0.5.10.zip


Connectivity matrix for sensor-space based spatio-temporal clustering

Is there currently a way to calculate a connectivity matrix of the sensors for systems that don't have neighborhood matrices in mne.channels.data.neighbors?

Nope. See Fieldtrip docs for additional info on how to do that.
Or define a layout by hand (seriously).

On 11 May 2015, at 15:21, Teon L Brooks<EMAIL_ADDRESS>wrote:
Is there currently a way to calculate a connectivity matrix of the sensors for systems that don't have neighborhood matrices in mne.channels.data.neighbors?
—
Reply to this email directly or view it on GitHub.

but why do we offer sensor-space spatio-temporal clustering if we don't support it for all the systems we support? I just went over to fieldtrip and they offer three different methods:
FT_PREPARE_NEIGHBOURS finds the neighbours of the channels based on three
  different methods. Using the 'distance'-method, prepare_neighbours is
  based on a minimum neighbourhood distance (in cfg.neighbourdist). The
  'triangulation'-method calculates a triangulation based on a
  two-dimenstional projection of the sensor position. The 'template'-method
  loads a default template for the given data type. prepare_neighbours
  should be verified using cfg.feedback ='yes' or by calling
  ft_neighbourplot

maybe we should port over their triangulation method since we have the capability to project sensor data to 2d.

connectivity matrices added for KIT. currently this is handled in fieldtrip and ported over


doc site: when going between pages the ToC repositions to the top

On 0.20, the site uses # browsing, so the position of the ToC doesn't change when you go to view a new page.  On -next, it is a full page system(apparently), so any time I click an item from the ToC it moves back to the top.  This provides a poor experience, and makes reading the docs more difficult than it needs to be.

Duplicate of #9436

Right, my bad.  I up voted the other issue.


Compact multiselect ChoiceSet

At the moment a ChoiceSet with isMultiSelect: true is rendered as a group of checkboxes regardless of the style property. For style:compact in html contexts shouldn't that be a <select multiple> instead?

We think the checkbox UI is a lot more approachable for end users. <select multiple> forces the user to use CTRL or SHIFT to select multiple items; it isn't as straightforward as checkboxes.

Oh I see. I guess what you're saying isn't that the CTRL+click multi-selection model is better, but that for long lists it would be great to have a way to not list all of the options one after the other (and end up with a massive card) Maybe we could honor the "style": "compact" property by grouping the checkboxes into an embedded scrolling area, maybe with its own border?

Yeah, that would probably work better from a usability standpoint.

Will definitely keep that in mind, seems like it could indeed be an improvement. The only question mark is, how many scenarios are there that already set "style": "compact" even though it has no effect, and would it be ok for these scenarios to see their UI change suddenly. In any case we'd have a threshold, e.g. the ChoiceSet would have to have at least 4 entries or something before we apply the compact mode.
Thanks for the suggestion and for pointing out this issue!

Why was this closed? Was the proposed solution of "grouping the checkboxes into an embedded scrolling area" undesirable for some reason?


Standardize versions and specifiers to pip classes

Switch all version functions to use pip._vendor.packaging.version.Version
Switch all storage of dependencies from current format to format employing pip._vendor.packaging.specifiers.SpecifierSet strings (e.g. ['bar', [['>', '5.0'], ['<=', '7.0.1']]] should instead be ['bar', '>5.0,<=7.0.1'], so that the version specifiers can be fed directly into SpecifierSet and dealt with that way. That should also clean up the code.

In the case of 1, this returns the normalized version number as pip sees it:
str(pip._vendor.packaging.version.Version(raw_version_string))
For example:
raw_version_string = '1.0beta'
v = pip._vendor.packaging.version.Version(raw_version_string)
   <Version('1.0b0')>
str(v)
   '1.0b0'

That value is what I should use everywhere, to avoid various minor bugs that have plagued me. /: (It may introduce its own, but at least then I'm performing as pip would.)

2 can be started by editing awwad/pip:develop pip.req.req_set.py:841 to use str(subreq.specifier) instead of subreq.specs. That's where all the info starts. I would then need to make the downstream changes at many points in my code.

2 was done with this: https://github.com/awwad/depresolve/commit/b0ba75cffb40b2dd1945c089a5e5fc6121b057ca
1 was done with this:


[feature request] Openyurt does not support k8s-1.19 version, but our product use k8s-1.19 version, we need openyurt supporting k8s-1.19 version, thanks a lot!

https://github.com/openyurtio/openyurt/blob/02a5cfb4f9f0c9e1757457068e7a58d4de1321f4/pkg/yurtctl/util/kubernetes/util.go#L84

@dingsihua Thank you for filing issue.
I think that openyurt components can work with kubernetes v1.19 version , but we have not checked kubernetes v1.19 carefully,  so version v1.19 is not added into supported version list. maybe you can revise the ValidServerVersions and add v1.19, then make up a new yurtctl tool and run convertion.

@dingsihua Would you make a pull request to revise the supported version list and add v1.19

@dingsihua I think k8s v1.19 is already supported by yurtctl tool.


fix some UselessAssignment cases

some UselessAssignments identified by chefstyle

@chef/client-core i'm going to break this up and could use some eyeballs.  pay particular attention to the knife subcommand loader one.

travis may fail, seeing some really weird spec failures locally...

:+1: I don't get why there's some and/or stuff straggling but the changes aren't wrong so NBD.

yeah, its my editor config, long story...

whoah reaction emojis directly on the messages...


[FEATURE] Add support for RuleActionOverrides for WAF using TypeSafeApi constructs

Describe the feature
Rule Action Overrides allow customizing WAF rules.  It seems this support is missing from PDK:
https://github.com/aws/aws-pdk/blob/83d1dbfeec047c078b38801b8df2c9e8caf4e9b0/packages/static-website/src/webacl_event_handler/index.ts#L98
Here is a link to Rule Action Overrides: https://docs.aws.amazon.com/waf/latest/APIReference/API_RuleActionOverride.html
Use Case
The current configuration lets me specify which WAF rule I wish to use:
Api(self, id,     web_acl_options=TypeSafeApiWebAclOptions(         cidr_allow_list=CidrAllowList(             cidr_type="IPV4",             cidr_ranges=["<IP_ADDRESS>/5"]         ),         managed_rules=[ManagedRule(vendor="AWS", name="AWSManagedRulesSQLiRuleSet")]     ),     ... )
But it doesn't provide the ability to customize the managed rule, despite the documentation indicating it supports these fields:
`import aws.pdk.type_safe_api
aws.pdk.type_safe_api.ManagedRule(
name: str,
excluded_rules: typing.Union[IResolvable, typing.List[typing.Union[IResolvable, ExcludedRuleProperty]]] = None,
managed_rule_group_configs: typing.Union[IResolvable, typing.List[typing.Union[IResolvable, ManagedRuleGroupConfigProperty]]] = None,
rule_action_overrides: typing.Union[IResolvable, typing.List[typing.Union[IResolvable, RuleActionOverrideProperty]]] = None,
scope_down_statement: typing.Union[IResolvable, StatementProperty] = None,
version: str = None,
vendor: str = None,
vendor_name: str = None
)`
Proposed Solution
Add support for the additional arguments.
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

PDK version used
0.23.43
What languages will this feature affect?
Python
Environment details (OS name and version, etc.)
MacOS, Sonoma 14.3

Hi David,
Sorry this was auto-closed - just back from leave!
The code you linked here is for the static website web ACL, but your issue is mentioning Type Safe API's web ACL - I just wanted to check that it's the Type Safe API one you're having issues with?
The rule action overrides should be configurable for Type Safe API - support was added in https://github.com/aws/aws-pdk/pull/712
I notice you're using python - do you definitely have the dependency on PDK 0.23.43 in your python infrastructure package?
Cheers,
Jack

Hey @dbryson!
Hope you're well! :)
Had a bit of time to look at this again just now - I was able to customise rule action overrides in Python with the following:
from constructs import Construct
from api_python_infra.api import Api
from api_python_infra.mock_integrations import MockIntegrations
from aws_cdk import Stack
from aws_pdk.identity import UserIdentity
from aws_pdk.type_safe_api import Authorizers, TypeSafeApiWebAclOptions, ManagedRule
from aws_cdk.aws_apigateway import CorsOptions, Cors
from aws_cdk.aws_wafv2 import CfnWebACL
from aws_cdk.aws_iam import AccountPrincipal, AnyPrincipal, Effect, PolicyDocument, PolicyStatement

# Infrastructure construct to deploy a Type Safe API.
class MyApi(Construct):
    def __init__(self, scope: Construct, id: str, user_identity: UserIdentity, **kwargs) -> None:
        super().__init__(scope, id, **kwargs)

        self.api = Api(self, id,
            default_authorizer=Authorizers.iam(),
            cors_options=CorsOptions(
                allow_origins=Cors.ALL_ORIGINS,
                allow_methods=Cors.ALL_METHODS
            ),
            integrations=MockIntegrations.mock_all(),
            web_acl_options=TypeSafeApiWebAclOptions(
                managed_rules=[
                    ManagedRule(
                        vendor_name="AWS",
                        name="AWSManagedRulesCommonRuleSet",
                        rule_action_overrides=[
                            CfnWebACL.RuleActionOverrideProperty(
                                name="SizeRestrictions_BODY",
                                action_to_use=CfnWebACL.RuleActionProperty(
                                    allow={}
                                )
                            )
                        ]
                    )
                ]
            ),
            policy=PolicyDocument(
                statements=[
                    # Here we grant any AWS credentials from the account that the prototype is deployed in to call the api.
                    # Machine to machine fine-grained access can be defined here using more specific principals (eg roles or
                    # users) and resources (ie which api paths may be invoked by which principal) if required.
                    # If doing so, the cognito identity pool authenticated role must still be granted access for cognito users to
                    # still be granted access to the API.
                    PolicyStatement(
                        effect=Effect.ALLOW,
                        principals=[AccountPrincipal(Stack.of(self).account)],
                        actions=['execute-api:Invoke'],
                        resources=['execute-api:/*']
                    ),
                    # Open up OPTIONS to allow browsers to make unauthenticated preflight requests
                    PolicyStatement(
                        effect=Effect.ALLOW,
                        principals=[AnyPrincipal()],
                        actions=['execute-api:Invoke'],
                        resources=['execute-api:/*/OPTIONS/*']
                    )
                ]
            ))

        user_identity.identity_pool.authenticated_role.add_to_principal_policy(
            PolicyStatement(
                effect=Effect.ALLOW,
                actions=['execute-api:Invoke'],
                resources=[self.api.api.arn_for_execute_api('*', '/*', '*')]
            )
        )

I'm going to close this, but feel free to reopen if there's still something missing :)
Cheers,
Jack


Question about  'fix everything'

Hi! Thanks for your great work. I find there are some random things in TinyLLaVA(eg, the dataloader). I wonder is there any setting I can change to fix the random seed?

Hi, please set random seed just like other programs do, e.g. in the beginning of the train() function in tinyllava/train/train.py

You don't need to manually set the random seed. The Trainer in transformers will help to set the seed. For the specific code, see line 398 in the trainer.py (the default value of full_determinism is False). You can set the seed value in args.

You don't need to manually set the random seed. The Trainer in transformers will help to set the seed. For the specific code, see line 398 in the trainer.py (the default value of full_determinism is False). You can set the seed value in args.

Thanks, I solved it.

Issue has been solved


[KOGITO-4889] - Proposal: spliting integration and unit tests

Many thanks for submitting your Pull Request :heart:!
See: https://issues.redhat.com/browse/KOGITO-4889
In this PR we introduce a new profile quick-build:
mvn clean install -Dquickly

It will run only unit tests and formatting validation. It takes 7 minutes to run from the parent kogito-runtimes project (was 30 min before).
Integration tests are segregated and now only run on integration-test or verify phases. Ideally, CI could run first with -Dquickly, and then the full cycle with integration tests:
# phase 1
mvn clean install -Dquickly

# phase 2 (install has already run)
mvn verify

Next steps:

[ ] Peer review consolidation
[ ] Jenkins pipeline review (ideally IT would run separately, so we can replay in case of infra failure)

In the future we may consider classifying ITs, so it would make it easier for us to replay specific modules/scenarios.
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Your code is properly formatted according to this configuration
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Pull Request
Please add comment: Jenkins retest this

Quarkus LTS checks
Please add comment: Jenkins run LTS

Native checks
Please add comment: Jenkins run native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

Many thanks for your suggestion, @radtriste.
Now, by running mvn clean install -Dquickly, the entire build takes ~1min. With tests enabled (-DquickTests), everything is finished in ~7min.
Some tests in the jbpm-flow module are taking too long because of the test case's sleeps. I tried to fork and run and parallel, but no luck. Forking broke the test, and honestly, I don't have too much time to take a look.
We can try to run some modules in parallel, though. But that will be an improvement for another JIRA. :)

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

Jenkins retest this

Jenkins retest this

The Linux check has failed. Please check the logs.

Jenkins retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

Jenkins retest this

@elguardian you may want to keep an eye on this, since you are refactoring test cases -- not sure if it may have an impact

Can we ignore Sonar? I haven't change a single line of code. :thinking:

@evacchi for now that is frozen... till finishing marshalling

jenkins please retest this

The Linux check has failed. Please check the logs.

Rebased, IT passed locally.
@radtriste, wanna take a final look?
@jstastny-cz, I've incorporated your changes. Can you please take a look? How do we validate?

The Linux check has failed. Please check the logs.

jenkins please retest this

The former run failed because of docker. The current CI run is stuck in the containers test again for the past 5 hours.

The Linux check has failed. Please check the logs.

Regarding to Sonar, please don't ignore that, I would encourage for closer assessment of what this refactoring means towards reported metrics.

That's funny. I just moved the code from one package to another, and Sonar complained because of the new code? That's it? But it was an ok change in a code with more than 11 years. But you're right, we need to take the opportunity to raise our quality level.
I think for this kind of scenario, we should fix the first time we forked or at least opened JIRAs to tackle the technical debt. Fixing this kind of bug in PRs like this is out of scope, IMO.

Regarding to Sonar, please don't ignore that, I would encourage for closer assessment of what this refactoring means towards reported metrics.

That's funny. I just moved the code from one package to another, and Sonar complained because of the new code? That's it? But it was an ok change in a code with more than 11 years. But you're right, we need to take the opportunity to raise our quality level.
I think for this kind of scenario, we should fix the first time we forked or at least opened JIRAs to tackle the technical debt. Fixing this kind of bug in PRs like this is out of scope, IMO.

The Linux check has failed. Please check the logs.

@ricardozanini yeah, I was nitpicking on the word "ignore" :-) if we review and add possible future task in Jira it's I think just about what we can do as part of this effort.

Seems like we had some kind of connectivity problems?
17:17:55,512 [INFO] -------------------------------------------------------
17:17:55,512 [INFO]  T E S T S
17:17:55,512 [INFO] -------------------------------------------------------
17:17:56,522 [INFO] Running org.kie.kogito.integrationtests.quarkus.TopicInformationResourceIT
Cannot contact kie-psi-rhel7-xlarge-2606: java.lang.InterruptedException

@mareknovotny @mbiarnes FYI ^
Jenkins retest this please

@ricardozanini yeah, I was nitpicking on the word "ignore" :-) if we review and add possible future task in Jira it's I think just about what we can do as part of this effort.

No problem! Can you please review it then? :)

The Linux check has failed. Please check the logs.

Errors:
10:50:05.898 [main] ERROR ?.k.k.0.0-SNAPSHOT] - Failed to pull image: org.kie.kogito/trusty-service-infinispan:2.0.0-SNAPSHOT. Please check output of `docker pull org.kie.kogito/trusty-service-infinispan:2.0.0-SNAPSHOT`
com.github.dockerjava.api.exception.InternalServerErrorException: Status 500: {"message":"Get https://org.kie.kogito/v2/: dial tcp: lookup org.kie.kogito on <IP_ADDRESS>:53: no such host"}

	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:247) ~[testcontainers-1.15.1.jar:na]
	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocat

Not sure if it's related to this PR. @radtriste @r00ta can you guys help?

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

Timeout on SB Integration tests :face_with_head_bandage:
jenkins please retest this

Stuck again:
0:24:37,765 [INFO] Running org.kie.kogito.integrationtests.quarkus.OASIT

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins retest this

The Linux check has failed. Please check the logs.

Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=org.kie.kogito/trusty-service-infinispan:2.0.0-SNAPSHOT, imagePullPolicy=DefaultPullPolicy())

jenkins retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins retest this please

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

jenkins please retest this

jenkins please retest this

The Linux check has failed. Please check the logs.

Nice
Status 500: {"message":"toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit"}
jenkins retest this please

The Linux check has failed. Please check the logs.

Network error
08:23:02,526 [INFO] [ERROR]     Non-resolvable import POM: Could not transfer artifact io.quarkus:quarkus-bom:pom:1.13.3.Final from/to mirror-central (https://bxms-qe.rhev-ci-vms.eng.rdu2.redhat.com:8443/nexus/content/groups/kogito-runtimes-pr-artifacts-group/): Connect to bxms-qe.rhev-ci-vms.eng.rdu2.redhat.com:8443 [bxms-qe.rhev-ci-vms.eng.rdu2.redhat.com/<IP_ADDRESS>] failed: Connection refused (Connection refused) @ org.kie.kogito:kogito-quarkus-bom:2.0.0-SNAPSHOT, /home/jenkins/workspace/KIE/kogito/pullrequest/kogito-runtimes/integration-tests/integration-tests/integration-tests-kogito-plugin/target/local-repo/org/kie/kogito/kogito-quarkus-bom/2.0.0-SNAPSHOT/kogito-quarkus-bom-2.0.0-SNAPSHOT.pom, line 20, column 19 -> [Help 2]
jenkins retest this please

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

@danielezonca we are green on GHA side. :)

The Linux check has failed. Please check the logs.


Fix broken "openssl genrsa" and other misc option issues

genrsa is missing a break; statement after capturing the out file argument and as such many spurious warnings about missing engines are displayed (at least on Mac OS X systems, I didn't see these warnings on Linux earlier today).
A quick grep revealed 2 other similar issues.

fixed thanks!


Spevacus: Watch moneyprinters.net

Spevacus requests the watch of the watch_keyword moneyprinters\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

moneyprinters\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by NobodyNada in Charcoal HQ


AllContributors

Using this issue to add contributors

@all-contributors please add @threepointone for ideas

@allcontributors[bot] please add @alex-saunders for code, design, infra, ideas and reviews

@allcontributors[bot] please add @Tolsee for code

@allcontributors[bot] please add @neutrino2211 for code


Would you be open to consulting on implementing this bracket manager in our website?

Sorry for the unconventional method of reaching out, but I didn't see any other way to contact you. We are building a sports management tool that could greatly benefit from the bracket manager/viewer that you built! I am sure we can figure out how to integrate with it, but it would go a lot faster if we had your help! Do you have any time? Would you be willing to consult/help with implementing this?

I don't have the bandwidth to do consulting.
However you can use the Discussions of this repository to ask questions for the benefit of everybody!

Closing this issue.
If you have any questions, please create a new discussion with an appropriate title


Missing claim: 'iat'

Missing claim: 'iat'
Summary
I'm using Keycloak Gatekeeper with IdentityServer4 as OIDC provider, and hit the error below.
unable to verify the id token	{"error": "oidc: JWT claims invalid: missing claim: 'iat'"}

I have the same issue, the iat claim is issued only for id_token, for access_token the claim auth_time is used...
In the meanwhile, did you find a workaround?

@Adriien-M: Not really, except a brutal way to suppress the iat error in Gatekeeper, which I'm unsure whether it violates OIDC specs... What about you?


Fix parse location of FunctionCallBlock

Expression::FunctionCallBlock location does not surround entire
expression, and this fixes that by moving the location start to the
beggining of the expression. This also adds pretty_assertions
for easier debugging of dot files in tests

ref #839

pretty-assertions is very nice!
github actions is playing up, I'll if I can restart the failed jobs


Do we need more labels?

I have already added these labels:

security
i18n
do not merge
urgent

Do we, perhaps, want some of these?

p1 "Priority-1, important"
p2 "Priority-2, in need of prompt attention"
p3 "Priority-3, can wait"

I mean, we could just use milestones.
In addition, we could add

text

To mark issues purely about text.
Can anyone think of any other labels we could use (either for PRs, or issues)

The use of "Feature Request" AND "feature" is a bit meh. ⚡ For purge "Feature Request", 💯 For purge "feature", 👎 for Don't Purge.


File explorer pane - text/text highlight color issues

Obsidian version: 1.6.7
Theme version: 1.4.81
In the file explorer pane, on selecting a file, the text highlight appears to be using the same theme color as the text. Both change when setting the "Foam" color via Style Settings. This applies regardless of light/dark mode.
Related, in the file explorer pane, when attempting to click-and-drag a file, the highlight color is different, but is not a good match for the text color. It either makes the text unreadable, or the combination is not very nice. This applies to every predefined light and dark theme save "Underwater Octopus" - where it's instead somewhat hard to read.

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Analyzing files does not work properly in some cases

In some cases analyzing files does not work properly and simply return empty lines, for example when trying to analyze the included files CONTACT and REQUIREMENTS (which does not really make sense, but leads to the bug):
./salomon.sh --analyze -i CONTACT -i REQUIREMENTS

Fixed in version 1.15.0.


Support for quantized models (following)

Following this discussion about quantized model support
Sorry for the late reply, I needed to discuss with the team to understand a bit more our needs.
I think what we'd like to know is whether nntrainer has to work with float32 (at the cost of some performances) or if it can train directly a quantized model, or maybe a mixture of both (like having non trainable part quantized and trainable part float32).
What isn't clear as well is wether there can be a difference in the format during inference and training, does nntrainer even have an api for inference or is it only used for training?
Our goal is to get the best performances possibles and we'd like to minimize the use of float32.

:octocat: cibot: Thank you for posting issue #909. The person in charge will reply soon.

:octocat: cibot: Thank you for posting issue #909. The person in charge will reply soon.

@nscotto Thanks for the query.

I think what we'd like to know is whether nntrainer has to work with float32 (at the cost of some performances) or if it can train directly a quantized model, or maybe a mixture of both (like having non trainable part quantized and trainable part float32).

Of course, supporting quantization is important from a performance perspective and we do have plans.

Inference with Quantized Model
Train after de-quantized Model (only for the trainable part) and generate a quantized model for inference.
Train Quantized Model Directly

We are currently working on 1 and will be released soon.

What isn't clear as well is wether there can be a difference in the format during inference and training, does nntrainer even have an api for inference or is it only used for training?

We do have C/C++ APIs.
C and C++ APIs will be updated including inference API.

@nscotto Thanks for the query.

I think what we'd like to know is whether nntrainer has to work with float32 (at the cost of some performances) or if it can train directly a quantized model, or maybe a mixture of both (like having non trainable part quantized and trainable part float32).

Of course, supporting quantization is important from a performance perspective and we do have plans.

Inference with Quantized Model
Train after de-quantized Model (only for the trainable part) and generate a quantized model for inference.
Train Quantized Model Directly

We are currently working on 1 and will be released soon.

What isn't clear as well is wether there can be a difference in the format during inference and training, does nntrainer even have an api for inference or is it only used for training?

We do have C/C++ APIs.
C and C++ APIs will be updated including inference API.

Our goal is to get the best performances possibles and we'd like to minimize the use of float32.

As @jijoongmoon clarified, support for quantized models would be available soon. However, please note that, for now, the weights which are being trained will be using float computations (non-trainable computations can happen in float) during training (not inference).

Our goal is to get the best performances possibles and we'd like to minimize the use of float32.

As @jijoongmoon clarified, support for quantized models would be available soon. However, please note that, for now, the weights which are being trained will be using float computations (non-trainable computations can happen in float) during training (not inference).

We do have C/C++ APIs.
C and C++ APIs will be updated including inference API.

C++ API is planned to be ready at the latest 3 Feb.
C API is on the process and will be ready with Tizen 6.5 M1 release.

We do have C/C++ APIs.
C and C++ APIs will be updated including inference API.

C++ API is planned to be ready at the latest 3 Feb.
C API is on the process and will be ready with Tizen 6.5 M1 release.

Following this discussion about quantized model support
Sorry for the late reply, I needed to discuss with the team to understand a bit more our needs.
I think what we'd like to know is whether nntrainer has to work with float32 (at the cost of some performances) or if it can train directly a quantized model, or maybe a mixture of both (like having non trainable part quantized and trainable part float32).

You may contribute such features directly to nntrainer as well. :)

What isn't clear as well is wether there can be a difference in the format during inference and training, does nntrainer even have an api for inference or is it only used for training?

For inferences, you may use nntrainer directly or ML-API/nnstreamer with nntrainer subplugin.
The code in nntrainer.git /nnstreamer/tensor_filter/* is the nntrainer subplugin for nnstreamer, which is also a usage example of inferencing with nntrainer.

Following this discussion about quantized model support
Sorry for the late reply, I needed to discuss with the team to understand a bit more our needs.
I think what we'd like to know is whether nntrainer has to work with float32 (at the cost of some performances) or if it can train directly a quantized model, or maybe a mixture of both (like having non trainable part quantized and trainable part float32).

You may contribute such features directly to nntrainer as well. :)

What isn't clear as well is wether there can be a difference in the format during inference and training, does nntrainer even have an api for inference or is it only used for training?

For inferences, you may use nntrainer directly or ML-API/nnstreamer with nntrainer subplugin.
The code in nntrainer.git /nnstreamer/tensor_filter/* is the nntrainer subplugin for nnstreamer, which is also a usage example of inferencing with nntrainer.


Start emulator on flow dev with flag

Closes #1392

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report
Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 40.17%. Comparing base (bec4f7d) to head (18709b3).

Files
Patch %
Lines

internal/super/dev.go
0.00%
37 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
- Coverage   40.62%   40.17%   -0.45%
==========================================
  Files          47       47
  Lines        2597     2626      +29
==========================================
  Hits         1055     1055
- Misses       1417     1446      +29
  Partials      125      125

Flag
Coverage Δ

unittests
40.17% <0.00%> (-0.45%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Internals] Few simplifications

Hey I tried to do a bit of simplifications of the fit() code, I hope its more readable like that.

@rimhajal Now the docs are adapted so this should also be good to go.


Add example to create JSON string without escaped characters

Kind of obvious but it did not occur to me at first and I struggled with this for a second (“How do I make it print to console without escaping the characters?!”)

Merged, thanks!


[TextField] Make variant prop optional for all cases

Closes #20716
@eps1lon could you please provide me more info about problems for this solution? It just fixes all the problems.

[x] I have followed (at least) the PR section of the contributing guide.

Make sure that tests are failed because of they cover incorrect behavior. I am not really sure about the problem you are trying to solve, so will wait for additional comments.
Tests reporting this error. There should not be any error because property variant is optional
  Property 'variant' is missing in type

Thanks, @eps1lon I figured out the problem.
Tried to experiment with new generic type for component, but it as expected any HOC is breaking generic type inference. Those typescript generics....
Going to experiment a little bit more, maybe I`ll be able to get the right typings

@dmtrKovalenko Any progress on this end? What should we do with it?

Let me experiment with it a little bit more. We can close PR for now.

For v5 I want to revisit this issue again. If these props only differ in their implemented classes then we should loosen up type safety a bit for better type ergonomics. In the end an extraneous class won't do anything harmful in prod. It's just a few potentially wasted bytes. For dev you even get a warning about it.


Error on 3.3.2

(Required) What is your Quests version / build number (do not say "latest")?
3.3.2
(Required) Please describe the problem and how to replicate it. Any console errors?
This error has been spamming in my console. I don't know what caused it.
https://pastebin.com/U1eN4hX9
(Optional) Can you provide an example quest from quests.yml using Pastebin.com?
https://pastebin.com/2Z7GKXCH

Need the portion of the error following the last line in your Pastebin. In other words, everything after
27.04 05:31:19 [Server] INFO Caused by: java.lang.NullPointerException

Just to confirm, I'm getting the same: https://pastebin.com/UvGkvd9U
Using Quests 3.3.2b311 on Spigot 1.12.2 (latest).

@mercurialmusic Your error stops there, too? Will try to replicate this.

Not fixed. Still having the same issue
https://pastebin.com/ArmAFVzz
For the last part, i can't find the 25 more messages.

My mistake, I posted the wrong link. Should've been:
http://ci.ac3-servers.eu/job/Quests/312/

Sorry, missed the emails, but yes, my error did cut off there as well. Initial tests of that build seems like it's been solved, at least for me. Thanks!

The previous error was solved.
This time a new error came to console instead.
https://pastebin.com/uaP2W3kN

Even when downgraded to 3.27, it now cause the same issue. Have to temp disable quests from my server.

@PengBread Original error has been solved. If you are still experiencing that second error, please make a new ticket.


Refactor Loads Model for  v2 architecture

We must improve the model and refactore the tests.

Done in PR #90


Reload

If yargs.argv have been saved to a file can they be reloaded during the runtime?
Thanks.

@przemyslawpluta if you save configuration settings as a .json file, you can reload them using the config option:
https://github.com/chevex/yargs#configkey


[DEVO-851] set repo from nexus to artifactory

DO NOT MERGE!  Will be merged by automation after validation

:white_check_mark: Build finished in 1h 3m 57s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 4856, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Releases are not atomic if not logged in to NPM

I share my experience of using xyz. Not sure the behavior worth fixing, feel free to close the issue if it is a feature, not a bug.
Steps to reproduce

Make sure you are not logged into npmjs.org with npm CLI¹
Run xyz --repo <your_repo> --increment patch

¹ npm logout should exit with a non-zero code:
$ npm logout

$ npm logout
npm ERR! Not logged in to

Expected behavior

No commits or tags are created
No pushes to GitHub are done
xyz fails telling I am not logged in to NPM

Actual behavior

A commit and release are created on GitHub
xyz forwards the message about being not logged in, but it’s too late

How to fix
One possible solution is checking the exit code of npm whoami before the steps with side effects to verify the authentication.

Running npm whoami is a good idea. I'll investigate this.
The good news is that only the very last line of the script will have failed. After logging in, you should be able to run npm publish manually.


XGBoost modelhandler implementation

This PR contains the implementation of the XGBoost model handler. The model handler supports input data in the form of a Numpy array, Pandas dataframe, Datatable dataframe and a SciPy matrix. The PR also contains tests and an example.
TODOs:

[ ] If the code is approved, the input and output files for the integration tests should be moved to the proper location on GCS

[ ] Write documentation and example for the website once code has been approved

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@damccorm @AnandInguva Could you take a look at the code ?

@damccorm @AnandInguva Could you take a look at the code ?

I was in the process of reviewing :) looks great, thank you!

stop reviewer notifications

Run Python PreCommit

Also, looks like the formatter/lint/RAT precommit checks are failing.
Formatter/lint exceptions should be visible in the "details" link, along with a command you can run locally to fix.
RAT exceptions are due to missing a license header (looks like you're missing a license on xgboost_tests_requirements.txt)

@damccorm I think the pipelines succeeded

Run Python 3.7 PostCommit

Run Python_Coverage PreCommit

Run Python_PVR_Flink PreCommit

@damccorm all checks passed except for codecov, I don't know if how to fix that one.

Run Python 3.7 PostCommit

Run Python 3.7 PostCommit

Test failures so far seem to be from jenkins issues

Run Python_Transforms PreCommit

Run Python_Transforms PreCommit

Run Python 3.7 PostCommit

Looks like a Jenkins flake caused the postcommit failure, but tests are passing. Running again to make sure, but I think this should be ready to go in.


Switch signing-job log archiver to use rclone

Previously we used rsync. Lately we've seen the time require for the
signing job to increase to several hours. Virtually all of that time
is during the log syncing part of the job.
This switches the log archiving to use the rclone tool. This should
speed things up for several reasons:

No more s3fusefs abstraction layer implementing unnecessary system
calls against the 'mounted' s3 bucket
Only considering files created in the last week to copy
rclone seems very fast in general

The required rclone configuration has been stored in bitwarden

I chose 1 week for the syncing period consideration because I am fairly certain we try to sign something at least once a week. I considered 72h originally but thought this would be safer. Thoughts?

1 week is fine. we sign pre-releases several times a day so we could tighten it a bit if it matters but i bet it won't.

LGTM but would like to see a test run before slamming it in there... i worked hard to make this job fully testable :)

Caaaaaaaaaaan do. The dry-run part should accomplish that. I'll get back with a log real quick.

LGTM but would like to see a test run before slamming it in there... i worked hard to make this job fully testable :)

Caaaaaaaaaaan do. The dry-run part should accomplish that. I'll get back with a log real quick.

As discussed on slack, I ran into issues with this due to jenkins automatic path shortening so I couldn't fully test it out. I'm merging this. We can revert if it actually does create issues.


[ConstraintSystem] Don't propagate holes through supertype inference

Disallow holes to be inferred as supertype bindings  while inferring
bindings from other type variables (based on transitivity of subtype
conversions), otherwise it would be possible to record a hole without
recording associated fix.
Resolves: rdar://problem/64368545

@swift-ci please smoke test

@swift-ci please smoke test macOS platform

@swift-ci please smoke test Linux platform

@swift-ci please smoke test macOS platform

@swift-ci please smoke test Windows platform


Add HTTP2

Adds the HTTP2 configuration to nginx, as described in azure920

@loics2 Please set a release version & date (or target a release branch).


getToggleAllRowsSelectedHandler is selecting not allowed rows.

Describe the bug
Hello!
The table method getToggleAllRowsSelectedHandler is selecting all rows, even the ones which return false for the getCanSelect row check. I don't know if this is either a bug or intended behaviour though.
Your minimal, reproducible example
https://codesandbox.io/s/romantic-silence-sh1x95
Steps to reproduce

First, notice that by table definition in line 115,  only rows with age greater than 18 should be able to be selected. enableRowSelection: (row) => row.original.age > 18,
Check that the checkboxes for ages smaller than 18 are disabled.
Tick select all. All the boxes will be checked, even the disabled ones.

Expected behavior
The disabled checkboxes should not be checked.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
React 18, Chrome 103, Windows 10.
react-table version
8.2.0
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

hey @jpedroh, @tannerlinsley!
@tannerlinsley is this just a matter of a missed call to row.getCanSelect() in the RowSelection.ts:111?

Unfortunately, I didn't have the time to check the source code for Row Selection, but looking from outside, it indeed looks like a missing filter in the selectAll method.

All right, had the time to give the code a look. I agree with @LetItRock solution. However, I believe there's room for improvement in also adding this check in the mutateRowIsSelected function itself - so this bug is avoided in other places as well (toggleAll does not use it). I've opened a PR so we can discuss these changes there.

Not so fast on this one! This change introduced a bug in getIsAllRowsSelected, since the method also doesn't use a filter to only match the rows which are allowed to be selected. This breaks the toggle selection feature, because the toggle method - which was patched - calls this method.
Let's make this right. I would like to implement some tests to assert this behaviour is correct on my next PR. @tannerlinsley is it ok if I implement a test for this feature in the react package or would you rather have a test implemented in the core one? Perhaps setting up infrastructure for the core package will be a little bit trickier because of state management?

Test wherever is easier. The react package already has some tests and yes, it’s easier there.

Hi @jpedroh !
Did you had the chance to fix getIsAllRowsSelected ?
I still have the issue where the return value is never true if i have some disabled rows so the toggle between all/none selected is broken

Hi @ThomasLeveque. Yes I've had! I've implemented some test using React and it seems to be working as it should now. There were some substantial changes though and I'm afraid that might possibly break another behaviour. Unfortunately, I won't have much of the time to work in it until next week, but I will open a draft PR and feel free to proceed with implementation if you wish.


Fix the pre-processing loader error

Issue weex-toolkit #272
Issue weex-vue-loader #23
@erha19 @Hanks10100

Thank u so much.But maybe there is no one maintaining it

Please merge it as soon as possible if it work fine
@Hanks10100


In tsc cli can't override declaration to false when tsconfig.json contains declarationDir option?

TypeScript Version:  2.6.2 xxxxx

Search Terms:
"Option 'declarationDir' cannot be specified without specifying option 'declaration'"
Code
Assuming have tsconfig.json like this:
{
  "compilerOptions": {
    "module": "esnext",
    "target": "es6",
    "lib": ["es6", "dom"],
    "moduleResolution": "node",
    "declarationDir": "dist/types",
    "declaration": true,
  }
}

Expected behavior:
In terminal:
tsc --declaration false

or
tsc --declaration false ----declarationDir ''

wroks.
Actual behavior:
In terminal:
tsc --declaration false

reports: "error TS5052: Option 'declarationDir' cannot be specified without specifying option 'declaration'."
tsc --declaration false ----declarationDir ''

reports: "error TS6044: Compiler option 'declarationDir' expects an argument."
Playground Link:
Related Issues:

TS6044  because empty string is falsey   https://github.com/Microsoft/TypeScript/blob/master/src/harness/unittests/commandLineParsing.ts#L227
has a unit test similar for it

Looking at this again, I do not think we want to change this behavior really.. tsconfig.json allows for such overrides using extends and using null as an override value. i do not think the value we get from allowing this on the command line is wroth handling empty strings in all of our compiler options.

@mhegazy Consider this issue and its fix: https://github.com/ezolenko/rollup-plugin-typescript2/issues/52#event-1454368988. Not only rollup-plugin-typescript, other plugins, e.g. ts-loader,  which provide override feature and it calls tsModule. parseJsonConfigFileContent from tsproxy inside, have this issue that once we specified the declarationDir in a base tsconfig.json we have no other way to cancel it.
rollup-plugin-typescript2 fixed it after this issue submitting by re-writing the parsed value of  declarationDir to null if ppl try to override it by setting a null declarationDir, the procedure is consuming user's overrides and then call tsModule. parseJsonConfigFileContent to get parsed configs, modify the parsed declarationDir option if ppl setted declarationDir to null.
ts-loader also can't cancel declaration:
// webpack segment:

rules: [{
      test: /\.ts$/,
      loader: require.resolve('ts-loader'),
      options: {
        configFile: configFilePath,
        compilerOptions: {
          declaration: false,
        },
      },
    }],

Maybe there are many other plugins have the same issue, it is exhausted to fixing one by one. moreover, declaration cancelation is not documented by official site(seems only exists in this pr:https://github.com/Microsoft/TypeScript/pull/18058), normal users don't know the right way to cancel the declaration through tsconfig.json extending(json scheme defined it as string type, it is also a problem, need official document to back to update it), and plugin authors don't sure the right way to generated the final TS configs to feed to next procedure.

parseJsonConfigFileContent third argument is a set of overrides.. why is not sufficient for this scenario.. i.e.:
import * as ts from "typescript";

const optionsFromTsconfig = {
    compilerOptions: {
        declaration: true,
        declarationDir: "./declarationOut"
    }
};
const host = {
    fileExists: ts.sys.fileExists,
    readDirectory: ts.sys.readDirectory,
    readFile: ts.sys.readFile,
    useCaseSensitiveFileNames: false
}

const parsedOptions1 = ts.parseJsonConfigFileContent(optionsFromTsconfig, host, "./", { declaration: false });
const program1 = ts.createProgram(["./a.ts"], parsedOptions1.options, ts.createCompilerHost(parsedOptions1.options));
console.log(JSON.stringify(program1.getOptionsDiagnostics(), undefined, 2));  /// "Option 'declarationDir' cannot be specified without specifying option 'declaration'."

const parsedOptions2 = ts.parseJsonConfigFileContent(optionsFromTsconfig, host, "./", { declaration: false, declarationDir: null });
const program2 = ts.createProgram(["./a.ts"], parsedOptions2.options, ts.createCompilerHost(parsedOptions2.options));
console.log(JSON.stringify(program2.getOptionsDiagnostics(), undefined, 2));  /// no error

Hi @mhegazy

Looking at this again, I do not think we want to change this behavior really.. tsconfig.json allows for such overrides using extends and using null as an override value.

I'd like to ask to reconsider. First, it is not obvious that one can use null. Second, VS Code warns about null: Incorrect Type, expected "string".
The whole behavior is quite confusing. It would be really nice if simple and obvious declaration: false turned off the generation of declarations, without the need to investigate, search the web, find some issues on Github and comment on those! :)

First, it is not obvious that one can use null

That is a JSON feature really. we would be happy to take a PR to the docs to make that clear as well.

VS Code warns about null: Incorrect Type, expected "string".

This is coming from the schema in https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/tsconfig.json. Feel free to send a PR to update it, and tag me on it.

Thanks for quick response, much appreciated!
And now, also gulp-typescript doesn't work with "declarationDir": null, complains (see below). And changing docs and fixing schema is not a proper solution to the whole thing, in my opinion, we just cover up the actual problem: When user states in tsconfig that he/she doesn't want declarations via declarations: false, that should be enough, there is no need for tricky and unobvious extra actions, such as changing declarationDir for some reason. Please reconsider. At the moment: it is unobvious to user how to deal with this issue: 1. Confusing command-line 2. Unexpected and not recommended by VS Config tsconfig.json modification 3. Failing gulp-typescript.
This issue  affects things all over the place :)
error TS5052: Option 'declarationDir' cannot be specified without specifying option 'declaration'.
error TS5052: Option 'declarationDir' cannot be specified without specifying option 'declaration'.
TypeScript: 1 options error
TypeScript: 1 emit error
TypeScript: emit failed
events.js:183
      throw er; // Unhandled 'error' event
      ^

so that rational works for --declaration but what about --outDir? what about --outFile? should these also have a flag that say --outDirEnabled?

I think these are very different cases. For declaration/declarationDir, they can't exist without each other. outDir and outFile can stand on their own.
To me, it is very natural that declarationDir should be required only when declaration is true. When declaration is false, it doesn't matter what the value of declarationDir.
Here's my use case. We have a parent, core project, where we generate declarations for sub-projects to consume. In sub-projects we have tsproject.json files that extend the parent one, but set declaration to false. And we get the error for same reason. To me this is clearly a bug.
I am not sure why we are even debating this. I am probably missing some insight, but the current behavior is so weird and blatantly incorrect (to me, at least). I have to be missing something! :)

I am not sure why we are even debating this.

i am not sure either :) I believe we have a feature that accomplish the task in general fashion for all options. you are arguing that this should be done differently on a one-per-one basis.

I believe we have a feature that accomplish the task in general fashion for all options

With all respect, I'd disagree. You are not fully accomplishing the task, since users cannot adjust the configuration via command line properly. If the config file states that declarations must be created, and user don't want them, he/she CANNOT override this behavior via command line switch. This is a problem. One have to go to the config file and comment those settings out, which is not good for the command line use-case.... :)


STM32WL ADC doesn't work with power management

Describe the bug
If enabled CONFIG_ADC and CONFIG_PM, you can read just once using adc_read(), then Zephyr halts.
To Reproduce
Steps to reproduce the behavior:

add the nucleo_wl55jc.overlay to samples/drivers/adc/boards

/ {
	zephyr,user {
		io-channels = <&adc1 11>;
	};
};

&adc1 {
	pinctrl-0 = <&adc_in11_pa15>;
	status = "okay";
};

add configs to the sample project

CONFIG_PM=y

build and flash with nucleo_wl55jc board
see the log

Expected behavior
It should show the ADC reading every second.
Logs and console output
Before enabled CONFIG_PM, could see the ADC value every second.
After enabled CONFIG_PM, only could see the ADC value one time, then not running.
Environment (please complete the following information):

Ubuntu 18.04
Toolchain: 0.12.4
Zephyr v2.6.99

[UPDATED]

Zephyr commit SHA-1:  57690f5

There is only a AN5568 . Could the situation apply in this sample ?
"The STM32WL devices embed a multiple 12-bit/2.50 Msps ADC. This very fast and accurate converter can jeopardize the battery lifetime if left powered-up. As the ADC consumption is roughly proportional to the acquisition frequency (around 200 μA/Msps), from a consumption standpoint, the application can choose between the following solutions:
– Perform the acquisition at low speed to limit the maximum current.
– Perform the acquisition at the maximum speed to switch back to ultra-low-power mode quickly.
When the acquisition is performed slowly, the ADC consumption itself can go down to few tens of a μA, drastically limiting the maximum current. This may be mandatory when the power source provides a limited current. If the CPU has no other task to perform during that time, this slow acquisition increases the time spent by the system in Run, Sleep, LPRun or LPSleep mode, versus the time spent in Stop or Standby ultra-low-power mode."
Otherwise, even if the stm32wl is close to the stm32wb serie, the sequence to switch to HSI before entering Stop Mode is not mentioned for the stm32wlx. When testing the samples/drivers/adc on nucleo_wb55rg with CONFIG_PM is correct.

Can you confirm that you have the power.c for the ./soc/arm/st_stm32/stm32wl
--> the PR   https://github.com/zephyrproject-rtos/zephyr/pull/36574 has introduced the power management for the stm32wl soc serie.

Zephyr v2.6.99 doesn't exist. Do you mean 1.6.99 ?
I tested on my side and it is working well:
board: nucleo_wl55jc
sha1 : 17d2e9d084b2f02f8d39cd38eecdd7c0b5af59a2
I follow your To Reproduce steps

@honestech74 Can you confirm that you have the power.c for the ./soc/arm/st_stm32/stm32wl
--> the PR #36574 has introduced the power management for the stm32wl soc serie.

Zephyr v2.6.99 doesn't exist. Do you mean 1.6.99 ?

@ABOSTM Sorry for the confusing version. I am in master branch and you can check the version from this file.
https://github.com/zephyrproject-rtos/zephyr/blob/main/VERSION#L1-L5
Also commit SHA1: 57690f5

Can you confirm that you have the power.c for the ./soc/arm/st_stm32/stm32wl

@FRASTM Sure, I have it and it works well for boards/stm32/power_mgmt/blinky

Zephyr v2.6.99 doesn't exist. Do you mean 1.6.99 ?
I tested on my side and it is working well:
board: nucleo_wl55jc
sha1 : 17d2e9d
I follow your To Reproduce steps

@ABOSTM I have double checked on your commit sha, but couldn't get running and same in last commit of main branch.
If you followed Reproduce and got running, please check your SHA. I guess you are in another branch or miss CONFIG_PM?
I have another issue on I2C with CONFIG_PM.

@honestech74 ,
Let me change a bit the status of my tests:
After flashing the board (west flash with openOCD), it is working fine, even after pressing reset button, it works
But if I unplug and replug the board (ST-link usb powered), then it fails, ADC reading: xxx Displayed  only once in console.

@ABOSTM
You are right, I can see it's running when flash using stm32cubeprogrammer with openocd, but stopped after unplug and replug.
Even if it's running, getting 1.2mA power consumption and there are high peaks every a second(there is k_sleep(1000) in sample) Is it reasonable?

I'd like to use J-Link so tested with it until now. It's stopped after show one ADC log.
I never saw this difference between programmers, I can't trust the result when using stm32cubeprogrammer.

@ABOSTM Can you test it using J-Link? It seems like there is something wrong in ADC driver. I've tested ADC without CONFIG_PM but stopped SoC using LL library and init the clock after wake up. But it's not running after wake up.

I could get ADC running with STOP0/1/2 mode with HAL library. I could stop SoC using LL_PWR_* functions and wake up the counter(RTC). But there are some operations to make it working. Before entering STOP mode, I have disabled ADC. When wake up, enabled ADC. I am not sure whether ther is any specification on ST datasheet and reference manual.

It is mentioned that the content of the ADC registers is retained in STOP0/1 but not in STOP 2, so to be re-initialised.

This seems specific to stm32wl55jc low power STOP2 mode, probably because "The content of all other peripherals is reset and must be reprogrammed."
&cpu0 {
	cpu-power-states = <&stop0 &stop1>;
};

@FRASTM Thank you for your work.
I have understood that ADC registers are not retained in STOP2 mode and decided to use HAL instead of Zephyr PM.
If I stick to using Zephyr PM, can we have some hook for it? E.g. if we can register the callbacks for PM (maybe in power.c), users can register their custom code for ADC and other peripheral for STOP2 mode, and PM will call the callbacks before suspending and after wake up. So user can handle all peripheral without any issue with CONFIG_PM. I am not sure if Zephyr PM has such specifications.

@FRASTM Thank you for your work.
I have understood that ADC registers are not retained in STOP2 mode and got working by using HAL instead of Zephyr PM.
If I stick to using Zephyr PM, can we have some callbacks for it? E.g. if we can register the callbacks for PM (maybe in power.c), users can register their custom code for ADC and other peripheral for STOP2 mode, and PM will call the callbacks before suspending and after wake up etc. So user can handle all peripherals without any issue with CONFIG_PM and pure Zephyr style. I am not sure if Zephyr PM has such specifications.

Yes, more or less, for each peripheral, entering/exiting STOP2 mode.
I guess this is the purpose of the pm_device Pointer to the device's power management resources,
which appears in the DEVICE_DEFINE
like PM_DEVICE_DT_DEFINE(SPI(idx), gpio_stm32_pm_action);

I believe I am also running into this issue with the LoRa E5 Dev Board (STM32WLE5JC), where it will just halt during adc_read() and fails to print anything (including ADC Reading:). Is this related to this issue?

@nobodywasishere Do you enable PM ?

@erwango PM is not enabled, no

@erwango PM is not enabled, no

So likely it is another issue. Please raise a dedicated ticket giving any information that would help.

The issues seems to still be present.

The issues seems to still be present on STM32WL series. I managed to solve the issue based on what @sense-Jo has done.
Changes are minor since the file adc_II_stm32.c evolved:

Adding   /* enable device runtime power management */  err = pm_device_runtime_enable(dev);  if ((err < 0) && (err != -ENOSYS)) {  	return err;  }
at the end of static int adc_stm32_calibrate(const struct device *dev) in adc_stm32_pm_action.

Adding    error = pm_device_runtime_get(dev);   if (error < 0) {   	return error;   }
in adc_stm32_read

Adding pm_device_runtime_put(dev);
at the end of  adc_stm32_isr(const struct device *dev)`

What do you think about the changes ? Can it be interesting to make a PR ?

@Djammall Sure, go ahead, please make a PR. @gautierg-st will be able to provide guiding during the review


Do you have any plans to introduce support for AWS SQS/SNS?

Just like there's storage support for Azure Blob and S3, it would be quite nice to have the opportunity to be cloud-agnostic in what regards to Queues.

We did have a PR for SQS which was merged https://github.com/exceptionless/Foundatio/pull/85, but the target branch (release/5.1.0) seems to have disappeared, @niemyjski?

We are working on SQS queues and Cloudwatch metrics in the cloud watch branch, we have a few apps that will be using both of these in production and they are available in our nightly nuget feed on myget: https://www.myget.org/gallery/exceptionless We currently don't have support for SQS/SNS but would be more than happy to accept a pr for this :)

sorry, getting a bit confused.
You mean that you are adding SQS support on a feature branch for now, but that SNS is not in the horizon? Hence, why you wouldn't mind welcoming a PR?

We have the SQS queue implementation working pretty well now. We have a couple apps using it. I would love to see a pull request for supporting SNS. I think SNS would be a IMessageBus implementation, correct?

Our most urgent need here is to integrate with SQS, so that's actually great news.
SNS is not far on the horizon though, so if I can get things to work with our setup.
I don't see why we couldn't help out with the SNS implementation 👍

I'm closing this as we have SQS support now. If you want to add a request for SNS separately or even better submit a PR that would be great!


set containerSecurityContext on EVP2 Hub ThingsBoard

in evp1 we had this:
https://github.com/midokura/thingsboard-private/blob/3932b1c4497f83f3cc9c8e65cc53d1fc0b2e996f/k8s/charts/thingsboard/values.yaml#L241
any reason not to enable it for evp2? is it already enabled by default maybe?

moved to https://github.com/midokura/evp-chart/pull/600


How to change background color?

How can I change background color?

Check out these colorgroups, you might also need to unset these groups in your theme, as otherwise they might get overwritten.

You can use the highlight group WhichKeyFloat for this. See the readme

You can use the highlight group WhichKeyFloat for this. See the readme

thanks, what about border color? (light gray on screenshot). Didn't find any HG for it so far

@xbladesub just pushed a new update that makes this also configurable. Use WhichKeyBorder


Add key bindings to buttons in dialog.js

Something i noticed in search/replace, but i think it might belong to dialog.js?
(Testing at https://codemirror.net/demo/search.html, using chrome 47 win7_64)
On search/replace, the YES button is active, so i just need to hit enter for yes. But it seems there's no way via keyboard to use the other buttons like NO etc.

There could/should be Keybindings for the buttons, visualized with underlinded Cars
(can only do bold here) Yes No All Stop

Cursor keys should/could allow to move between buttons.

Don't tab and shift-tab, the standard way to move between browser controls, work?

Ah i see, yes it does, but...
Rab-ing after the last button exits the dialogue, i think it should cycle through it.
I had windows dialogues in mind, there you can move the focus with cursor keys (stops at end) and with tab (loops to the first button after last).
That's why i also had the idea of direct keybindings.
PS:
Tab-ing on the "replace" and "with" steps, aborts the dialogue.
I think that's wrong from the user-experience. It should... hmm, do the same as enter?

yes it does, but...
Tab-ing after the last button exits the dialogue, i think it should cycle through it.
I had windows dialogues in mind, there you can move the focus with cursor keys (stops at end) and with tab (loops to the first button after last).
That's why i also had the idea of direct keybindings.

I think being able to tab out of the dialog is a feature (locking users out of expected browser behavior is generally a bad idea).
Also, tabbing out of the dialog seems like a very different action than confirming it, so no, I don't think that should do the same as enter.
In general, if you want a different search UI, you can implement your own on top of searchcursor.js and (optionally) dialog.js.

Ok i see.
In my view, i just saw the dialogue more as a DIALOGUE than a part of the page. And on dialogues, browsers don't leave them with tab either i think.
For aborting, i thought ESC. was enough, and very standard.


python310Packages.potentials: 0.3.4 -> 0.3.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.potentials is: "Python API database tools for accessing the NIST Interatomic Potentials Repository"
meta.homepage for python310Packages.potentials is: "https://github.com/usnistgov/potentials"
meta.changelog for python310Packages.potentials is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.5 with grep in /nix/store/qzx2mkmxxfw0b460wa057d8d8y7zdmag-python3.10-potentials-0.3.5
found 0.3.5 in filename of file in /nix/store/qzx2mkmxxfw0b460wa057d8d8y7zdmag-python3.10-potentials-0.3.5

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.atomman
python310Packages.potentials
python39Packages.atomman
python39Packages.potentials

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qzx2mkmxxfw0b460wa057d8d8y7zdmag-python3.10-potentials-0.3.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.potentials https://github.com/r-ryantm/nixpkgs/archive/8e9a9bc7d19382fba5ab5fa401e9ad69f9fbabd9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qzx2mkmxxfw0b460wa057d8d8y7zdmag-python3.10-potentials-0.3.5
ls -la /nix/store/qzx2mkmxxfw0b460wa057d8d8y7zdmag-python3.10-potentials-0.3.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

python310Packages.atomman
python39Packages.atomman

2 packages built:

python310Packages.potentials
python39Packages.potentials

Maintainer pings
cc @fabaff for testing.

Version update is done by #194401


Add a physical scale widget and measurement tool

Suppose I want to draw a mockup of my architecture/interior design idea or do scene blocking for plays, movies, or videos. It would be great to have an overlay that shows a physical scale that resizes with zoom, like on Google Maps. A measurement tool that computes and displays the distance as a straight line or with multiple points would also be really useful. This would allow me to build my scene to scale and with the right distances!

For now I'd suggest using a combination of the grid mode (right-click on canvas) and custom elements for better orientation:

I've tried using the grid mode and some elements of different sizes but it's challenging to do that for things like floor plans that can have some really large objects and some really small ones. If Excalidraw adds some tools like this it would fill a large gap in simple drawing applications that let you draw to scale.


Replace stylelint-use-logical with stylelint-use-logical-spec

The original stylelint-use-logical seems to be effectively unmaintained, and is causing problems with its old stylelint peer dependency; its fork stylelint-use-logical-spec seems reasonably active, has a comparable number of downloads, and is compatible with newer stylelint.

Inspired by<PHONE_NUMBER>5961c64aa5ceef2a1b7252a398c291, seen on the next-updateVueCli branch.

This could also be done on the master branch, I suppose.

The new version also complains about width/height (wanting them replaced
with inline/block-size), but at least one of these replacements is not
trivial (in OptionsMenu, the max-width involves the vw unit), so disable
this for now.

I’m not sure how I feel about this part of the change, to be honest… but if we want to replace width/height as well, I suppose we could at least do that separately, and still merge this.

The new version also complains about width/height (wanting them replaced
with inline/block-size), but at least one of these replacements is not
trivial (in OptionsMenu, the max-width involves the vw unit), so disable
this for now.

I’m not sure how I feel about this part of the change, to be honest… but if we want to replace width/height as well, I suppose we could at least do that separately, and still merge this.

No, I think this is a good call. Overall, I'd like to limit the work we put into wikit to what is necessary for our immediate use case. Codex seems to be getting stable fast and so there is probably no point in doing long-term focused maintenance work on wikit.


SHIFT key not recognized in editor with official v3.2-alpha1_x11.64 build

Godot version:
v3.2-alpha1_x11.64
... and latest Git commit (74ab8be) compiled from source
OS/device including version:
Ubuntu 18.04
Issue description:
I downloaded the v3.2-alpha1_x11.64 build and run it under Linux. The SHIFT key seems to not be recognized - if I hold it the letters don't become capital and the numbers don't turn into symbols like !@#$(). This makes typing GDScript very difficult :-)
I also tried building the latest Git commit from source (just in case it had already been fixed), but that also had the same problem.
For comparison, the official 64-bit X11 build of Godot 3.1.1 works fine for me.
Steps to reproduce:

Download v3.2-alpha1_x11.64
Run it
In the Project Manager, try to type some capital letters in the search box - they all come in lower-case! (It doesn't seem to matter where you try, you could even create a new project and use the GDScript editor, and you can't type capital letters there either)

Minimal reproduction project:
n/a

Eep! Sorry, I search earlier but didn't find this existing issue until now #32268


Fixed typo with misspell

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Description
I found the some of typos in fastlane directory and fixed them.

@googlebot I signed it!


Example from docs doesn't work can't import from pydantic.env_settings import SettingsSourceCallable

https://docs.pydantic.dev/1.10/usage/settings/#changing-priority
from pydantic import BaseSettings, PostgresDsn
from pydantic.env_settings import SettingsSourceCallable

class Settings(BaseSettings):
    database_dsn: PostgresDsn

    class Config:
        @classmethod
        def customise_sources(
            cls,
            init_settings: SettingsSourceCallable,
            env_settings: SettingsSourceCallable,
            file_secret_settings: SettingsSourceCallable,
        ) -> tuple[SettingsSourceCallable, ...]:
            return env_settings, init_settings, file_secret_settings

print(Settings(database_dsn='postgres://postgres@localhost:5432/kwargs_db'))
#> database_dsn=PostgresDsn('postgres://postgres@localhost:5432/env_db', )

It looks like pydantic.env_settings is empty? I can't import SettingsSourceCallable from it.

Im dumb was looking at all old docs


"pybabel extract" gives "NameError: name 'SQLLAB_TIMEOUT' is not defined"

Running pybabel extract -F superset/translations/babel.cfg -o superset/translations/messages.pot -k _ -k __ -k t -k tn -k tct . as suggested within CONTRIBUTING.md#translating is not working for me.
Expected results
The template file superset/translations/messages.pot is updated with current application strings.
Actual results

I get an error NameError: name 'SQLLAB_TIMEOUT' is not defined.
messages.pot is emptied

How to reproduce the bug
Follow CONTRIBUTING.md#extracting-new-strings-for-translation
Environment

superset version: 1.3.0
python version: 3.8.10
pybabel version: 2.9.1

Checklist

[ x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ x ] I have reproduced the issue with at least the latest released version of superset.
[ x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Full logs:
$ pybabel extract -F superset/translations/babel.cfg -o superset/translations/messages.pot -k _ -k __ -k t -k tn -k tct .
extracting messages from superset/__init__.py
extracting messages from superset/app.py
extracting messages from superset/cli.py
extracting messages from superset/config.py
extracting messages from superset/constants.py
extracting messages from superset/dataframe.py
extracting messages from superset/errors.py
extracting messages from superset/exceptions.py
extracting messages from superset/extensions.py
extracting messages from superset/forms.py
extracting messages from superset/jinja_context.py
extracting messages from superset/legacy.py
extracting messages from superset/result_set.py
extracting messages from superset/schemas.py
extracting messages from superset/sql_lab.py
Traceback (most recent call last):
  File "/home/admin/superset_translation/venv/bin/pybabel", line 8, in <module>
    sys.exit(main())
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/frontend.py", line 929, in main
    return CommandLineInterface().run(sys.argv)
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/frontend.py", line 853, in run
    return cmdinst.run()
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/frontend.py", line 481, in run
    for filename, lineno, message, comments, context in extracted:
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/extract.py", line 149, in extract_from_dir
    for message_tuple in check_and_call_extract_file(
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/extract.py", line 207, in check_and_call_extract_file
    for message_tuple in extract_from_file(
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/extract.py", line 243, in extract_from_file
    return list(extract(method, fileobj, keywords, comment_tags,
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/extract.py", line 325, in extract
    for lineno, funcname, messages, comments in results:
  File "/home/admin/superset_translation/venv/lib/python3.8/site-packages/babel/messages/extract.py", line 487, in extract_python
    value = eval(code, {'__builtins__': {}}, {})
  File "<string>", line 2, in <module>
NameError: name 'SQLLAB_TIMEOUT' is not defined

Linked issue: https://github.com/apache/superset/issues/16550

Thanks a lot @hushaoqing : I've applied locally your change and it works!
Note:

I had a remaining issue because pybabel extract -F superset/translations/babel.cfg -o superset/translations/messages.pot -k _ -k __ -k t -k tn -k tct . crashed again logging ValueError: Unknown extraction method 'jinja2'. It turns out that running pip install jinja2 resolved the issue: maybe it should be documented at https://github.com/apache/superset/blob/master/CONTRIBUTING.md#translating
I can create a dedicated issue if it seems relevant to you

@audour
jinja2 has been included in the requirements.
https://github.com/apache/superset/blob/c66f278b42e4de8f3aeb10066af259acb6eae041/requirements/base.txt#L129
Have you tried to run pip install -r requirements/testing.txt?
(documented at https://github.com/apache/superset/blob/master/CONTRIBUTING.md#flask-server)

No, I haven't follow CONTRIBUTING.md#setup-local-environment-for-development because it seemed useless for me as I just wanted to improve French translation. But ok I understand that it was documented.


#1238 | Fix flag redefined: kubeconfig in out-of-cluster-client-confi…

…guration

Inspired by this stackoverflow answer https://stackoverflow.com/a/49195212/9431161 about that every flag may only be registered once.

Sorry, we do not accept changes directly against this repository, unless the
change is to the README.md itself. Please see
CONTRIBUTING.md for information on where and how to contribute instead.

Thanks for the pull request, but the current code makes sense for a main package, which is only invoked once per process.
Making this conditional on a flag lookup only makes sense in a library, which is called from other main functions.
If you wanted to add a comment about that distinction instead of changing the code, that could be ok, although pull requests should be open against the main kubernetes/kubernetes repository, not here


Mine with multiprocessing, but with nicer stats output

This PR takes changes from @dend456 on his branch (PR #20) and adds:

some messaging with a queue to allow nicer output with multiprocessing, just as in my nice-output PR
changes the miner function into a class, to split functionality into smaller functions that are easier to read and maintain.

Sample output:
2021-05-16 17:45:28 | uptime: 0:03:43 |  45 hash/sec | mined:   0 SKEPTI |  0.00 SKEPTI/h
2021-05-16 17:45:29 | uptime: 0:03:44 |  46 hash/sec | mined:   0 SKEPTI |  0.00 SKEPTI/h

During loading of the chain the output is a big mess, but I don't think that should be addressed in this PR.

@sashimi-houdini I don't understand what flake8 is complaining about in CI. When I run flake8 . --show-source --statistics locally, it doesn't find the remaining issue. Furthermore line 222 of  skepticoin/explorer.py doesn't even exist on my PR. I did not even touch that file in this PR. Do you have an idea what's happening?

I don't understand what flake8 is complaining about in CI.

I do, and it's my fault. I'll fix it.
I guess github performs its actions on the merge point of your PR and master, and the problem is on master (introduced by yours truly)

@sashimi-houdini I addressed all your comments, so I think this is ready to be merged.


Add debug formatting to ReadState

This is useful when one wants to wrap decoder.read(...) into dbg!().

Thanks for the quick merge 🙂


The descriptions are incorrect in the 'Undelete' dialog against one folder

Storage Explorer Version: 1.24.0-dev
Build Number: 20220421.6
Branch: rel/1.24.0
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Monterey 12.3 (Apple M1 Pro)
Architecture ia32\x64
How Found: Ad-hoc testing
Regression From: Previous release (1.20.1)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Create a folder -> Upload one blob to the folder.
Right click the folder -> Click 'Undelete -> Undelete Selected'.
Observe the descriptions in the 'Undelete' dialog -> Check whether the descriptions are correct.

Expected Experience
The descriptions are correct.

Actual Experience
The descriptions are incorrect.

The change of the string is intentional. We decided to make the strings more concise even though they may not be as explicit as the previous ones. The previous strings are too verbose to be effective.

@JasonYeMSFT Thank you for the response!
The current description doesn't make sense to me.
Now I select one folder and execute 'Undelete Selected'. The folder contains one active blob. also the active blob has a soft-deleted blob snapshot.
Refer to the description, 'For blobs in Selected Folders, they and their deleted versions or snapshots will be undeleted'.
In this case, the soft-deleted snapshot is not undeleted. Could you help to take a look?
https://user-images.githubusercontent.com/41351993/164587860-56c0f43e-6986-4532-85c6-c22b1f7fe678.mov

That's true, I should make it say "For deleted blobs in selected folders, ......".

Verified this issue on the build main 20220505.5. The descriptions have been updated. So, close this issue.


Remove item

With orphan-removal="true" always the last item(s) is(are) removed. Is there a solution? Thank you.

Hello,
Thanks for your report.
Can you provide a reproducible case?
Cheers,

Hello.
I'll try...
The problem was much more serious. I suspect that it's my fault.
When I change the order of items in the collection and save form, they(items) change their IDs. When putting a new item between existing items, after saving a new item replaces the next one.
Relations are set up correctly, it works in SonataAdmin (sonata_type_collection), but slowly, so I think on custom admin for big collections.
Relation (Parent entity Project and image collection "shots" of Projectgallery entity):
        <one-to-many field="shots" target-entity="Projectgallery" mapped-by="project" orphan-removal="true">
            <cascade>
                <cascade-persist />
                <cascade-remove />
            </cascade>
        </one-to-many>

Controller with parent FormBuilder (submitted data is not validated so far):
...
$form = $this
            ->createFormBuilder($project)
            ->add('shots', 'collection',
                array (
                    'type' => new ProjectgalleryType(),
                    'label' => 'Add, move, remove values and press Submit.',
                    'options' => array (
                        'label' => 'Value',
                    ),
                    'allow_add' => true,
                    'allow_delete' => true,
                    'prototype' => true,
                    'required' => false
                ))
            ->add('submit', 'submit')
            ->getForm()
        ;

        $form->handleRequest($request);

        if ($form->isSubmitted()) {
           // Validate!

            $em->persist($project);

            $i=0;
            foreach ($project->getShots() as $shot) {

                // New item and UploadedFile
                if ($_FILES['form']['tmp_name']['shots'][$i]['image']['file'] && !$shot->getImage() instanceof UploadedFile ) {
                    $shot->setImage($this->transformToUploadedFile(
                        $_FILES['form']['name']['shots'][$i]['image']['file'],
                        $_FILES['form']['type']['shots'][$i]['image']['file'],
                        $_FILES['form']['tmp_name']['shots'][$i]['image']['file'],
                        $_FILES['form']['error']['shots'][$i]['image']['file'],
                        $_FILES['form']['size']['shots'][$i]['image']['file']
                    ));

                    $shot->setProject($project);
                    $shot->setVisible(1);
                }

                $shot->setPosition($i+1);
                $i++;
            }

            #dump($_FILES, $_POST, $project->getShots());
            #die();

            $em->flush();

            $this->get('session')->getFlashBag()->add('success', 'Gallery updated');
            return $this->redirect($this->generateUrl('AcmeAdminProjectgallery_keyartlist', array( 'project_id' => $project->getId() )));
        }

...

class ProjectgalleryType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('id', 'hidden')
            ->add('title', null, array('label' => 'Title', 'required' => false, 'attr' => array('class' => 'form-control')))
            ->add('kind', 'choice', array(
                    'choices' => Projectgallery::$imageType,
                    'label' => 'Type',
                    'empty_value' => '-',
                    'empty_data'  => null,
                    'attr' => array(
                        'class' => 'form-control'
                    ),
                    'required' => true,
                    'by_reference' => false)
            )
            ->add('copyright', null, array('label' => 'Copyright', 'attr' => array('class' => 'form-control')))
            ->add('visible', null, array('label' => false, 'attr' => array('class' => 'form-control')))
            ->add('image', 'iphp_file', array('label' => false))
            ->add('position')
            #->add('save', 'submit')
        ;
    }

    public function getName()
    {
        return 'projectgallery';
    }

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(array(
            'data_class' => 'Acme\ProjectBundle\Entity\Projectgallery',
        ));
    }
}

I use environment of SonataAdmin, so js block has 4 jquery files:

Maybe because of this there is a conflict...
And view:
{% extends 'SonataAdminBundle::layout.html.twig' %}

{% block stylesheets %}
    {{ parent() }}
    <link rel="stylesheet" href="{{ asset('bundles/acmeadmin//css/collections.css') }}" type="text/css" media="all" />
{% endblock %}

{# ################# macros ######################## #}
    {% macro shotCollectionItem(formData) %}

{{ form_row(formData.title) }}
{{ form_row(formData.copyright) }}

                {{ form_row(formData.kind) }}

{{ form_row(formData.image, {'deleteButton': false}) }}

{{ form_row(formData.visible) }}

            {{ form_row(formData.id) }}

    {% endmacro %}

    {% macro newShotCollectionItem(formData) %}

{{ form_row(formData.title) }}

{{ form_row(formData.kind) }}

                    <input type='file' id='form_shots___name___image_file' name='form[shots][__name__][image][file]' />

    {% endmacro %}
{# ################# // macros ######################## #}

...

{{ form_start(pForm) }}

                                            ***

                                                {% for shot in pForm.shots %}
                                                    {{ _self.shotCollectionItem(shot) }}
                                                {% endfor %}

                                    {# Token CSRF #}
                                    {{ form_widget(pForm._token) }}

                                        <button type="submit" name="submit" class="btn btn-primary btn-lg pull-center">Save</button>

                                </form>

...

    {% block script %}

    {% endblock %}

Sorry for the big post.

In my case, change the order of the elements causes a change in their key parameters.
For example
"id" => "form_shots_0"
"name" => "0"
 "full_name" => "form[shots][0]"

becomes
"id" => "form_shots_1"
"name" => "1"
 "full_name" => "form[shots][1]"

However, the data ("data" => Projectgallery) remains in its place. And the data that belonged to form_shots_0 are saved to form_shots_1 and vice versa.
It is no matter when form is simple. In my case entity has ralations with other entities.
Is there any way to avoid this data exchange?

That's the key point: if you change an element's position, you'll "swap" the element contents, not the element itself.
Imagine you have a list of 3 values "a", "b", "c", if you move "a" to the bottom once, you'll end up with "b", "a", "c', with "b" having offset 0, "a" having offset 1, and "c" having offset 2.
Else, Symfony would not care about the order form elements are sent, it will just use the offsets on names and it will be processed as if you hadn't changed the positions at all.
If you want to keep element names inchanged, that's quite easy in native jquery. I hadn't imagine an option for that as this is really easy to do it.
I'm confused; do you really need to keep positions inchanged when posting, as soon as you moved elements on the ui?...

Thank you! I think I begin to understand what the problem is.
After submitting the form data is mixed (half from form_shots_0, half from form_shots_1). I'll try to include all entity fields in the form.

Hello,
I just deployed the "doctrine" demo: http://symfony-collection.fuz.org/advanced/usageWithDoctrine
There are a few bugs if you try to update the "name" field, will fix that later.
Anyway, what you'll see is the expected behavior in my point of view, if you think this may create data inconsistency in the database, please let me know what's the functional context you're working on, so I'll be able to think about a solution.
Alain

I just fixed the doctrine demo which now works well, don't hesitate to test it and read its source code to eventually find some options or other stuffs missing in your code.
As soon as I didn't find any issue,I close this, but feel free to reopen if you can reproduce a case where it doesn't.

Sorry for the silence.
I did as you advised - "... quite easy in native jquery".
Initially I chose the wrong method. Your bundle for other purposes.
Now I can not imagine for what purpose I can use it, but when come across with such a task, I will definitely use.
Thank you for your attention!

You're welcome.
You'll need this plugin when the order of your items will be important.

a list of tasks ordered by priority
a set of rules executed in the right order
a simple list in a cms if they need to be displayed in the given positions
...

And as I am lazy, I also use it when I just need to add and remove elements; I "like" the fact that it will send the list in the right order to Symfony.


~rignet-bicteg

"hey hey
because I'm a student I talked with student council and I can get a venue for 20 people in meatspace while handling and overflow through livestreaming
my plan is to make a meetup.com group, and start spamming it on various sites once I know the arrangements are secure"

provided feedback on draft of presentation deck on 11/4

web+urbitgraph://group/~datwet/the-collapse/graph/~datwet/florence-culture-theory-3356/170141184505357798579163418047868305408

reached out 1/31


minor: NoSuperfluousPhpdocTagsFixer - Attribute handling

closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/6349

Coverage increased (+0.002%) to 92.874% when pulling 3bb2700edfd7d45c16bae0231e0c5848e32fd77d on SpacePossum:master_6349 into f736dc928cd803c93bcaadaef24b738e2a0548e4 on FriendsOfPHP:master.

rebase on latest, resolved conflict, no other changes made

Thank you @SpacePossum.


404 Client Error

Hi,
When I run your example code, why did I get the 404 Client Error which indicates:
CRITICAL:newspaper.network:[REQUEST FAILED] 404 Client Error: Not Found for url: http://edition.cnn.com/feeds
CRITICAL:newspaper.network:[REQUEST FAILED] 404 Client Error: Not Found for url: http://edition.cnn.com/feed
I am very confused and hope to get an answer.
Thx!

I get the same problem. Newspaper version 0.2.5, python 3.5.2 (64 bit).
Have tried several different cnn seed urls, all fail to fetch feeds. Also, can not "build" for nbcnews due to the same type of error (404) fetching feeds url.
Here are some of the variations I tried.
cnn_paper = newspaper.build('http://cnn.com')
cnn_paper = newspaper.build('https://www.cnn.com')
nbcCong = newspaper.build('https://www.nbcnews.com/politics/congress')
nbcCong = newspaper.build('https://www.nbcnews.com/politics/')
nbcCong = newspaper.build('https://www.nbcnews.com/')
cnn_paper = newspaper.build('http://edition.cnn.com')
cnn_paper = newspaper.build('https://edition.cnn.com')
Always get errors like the folowing
2017/10/17 12:04:53 CRITICAL network send [REQUEST FAILED] 404 Client Error: Not Found for url: https://edition.cnn.com/feeds

@korycins thanks that is a good answer.
thanks for filing this bug @Zhujunnan We should improve the error logging in this library, it should not be firing log criticals for failing to find RSS feeds, I will work on this

I think it should always fail silently, by all means throw an exception, but don't spit stuff into STDOUT without my consent.

Is this still considered an enhancement?
I am currently getting tons of this in my logs, is a fix on the horizon?