Allow quick open to filter on folder names by typing folder name after the file

Quick Open (using Command P) is a great tool. However, if you are in a framework like Rails, you'll often have files that are named the same across many different folders, particularly for views. You may have 10s or 100s of index.html.haml or index.json.jbuilder files. Being able to narrow down the file is practically impossible with VSCode without the ability to also narrow down the folder, which provides a more descriptive name.
It would be great to have Quick Open use the filter to search the names of folders to help narrow down the list and find the file quickly.

@enozero you can type the folder name (before the file name) and it should narrow down, does that not work for you?

Ah... interesting. I hadn't ever thought to try the folder before the filename in the quick open tool. My mind automatically thinks of the file name then to narrow down the search from there once I see that the search has too many listings and that I can just keep typing to narrow down the search. Is there a way to allow searching the folder names after the file name? If not, that would be a fantastic addition.

I think it is the filter for files and folders in explorer pane kinda like we have it in Xcode's project navigator.

What about treating : as a special character that begins to apply an additional fuzzy filter against the existing results for any additional characters? so you type inhtm then you see that there are 100 index.html.haml files and you realise you need to filter on directory as well. You could then type :foo to filter the existing results and push foo/index.html.haml to the top of the result list?
You can probably achieve the same thing now by jumping the cursor back to the beginning of the quick open input field, but this might be a bit quicker to type (and you could then even apply further filters again).

miss this feature so bad

xcode files filter is very useful, it will show some files always listed in sidebar, but in vscode must Command P everytime when i want to open some files

This feature definitely super useful. But, I bet this features will be added after ten years.

I think that directories should be treated as first-class citizens on the quick open. As the requester of this feature, first I think on the file name, then on the folder name. Having to add the folder as a prefix is not practical, and it is not even fuzzy, you need to make a perfect match. Emacs has this feature and it is just wonderful.
To give you an example, to narrow down to a file on core/api/assignments/edit.js I want to be able to write edt assapi

Pushed a change so that quick open now runs a search over each segment of the input that is separated by space. This allows to further narrow down the results based on additional values. These additional values can either match on the label or description part and their scores will add up for each match:


[Design] Menu management

This issue is to track requirements for the Menu module. I think we should keep it very close to what is in O1 as it doesn't seem to a source of pain for anyone.
O1 Challenges

Performance https://github.com/OrchardCMS/Orchard/issues/4867
Breadcrumbs https://github.com/OrchardCMS/Orchard/issues/3537

For this one I suggest we create a different module with html helpers and services, that could also use some data from menus.

Content items as menu items https://github.com/OrchardCMS/Orchard/issues/4630

We should not allow content items to be menu items, for the related issue, and also for performance reasons. Just logical content menu items should be allowed, so when a content is deleted, the menu would either be removed or return a 404, and would have no impact if the menu item is deleted.

Accessibility https://github.com/OrchardCMS/Orchard/issues/4461

For anything that is highly client side driven (Menu, Layout, ...) we should make an extra effort to support keyboard shortcuts and make it aria compliant.

Drafts

I think @jagraz mentioned it, we should be able to have draftable menus. This should be easy if we choose to make menus content items.

Menu Items
In O1 are content items. I adds complexity and performance issues. We had content items to make menu items extensible, for instance by being able to add a CSS field. I don't see any other usage than css, or maybe other simple fields for custom properties but it's very limited. Usually menu item types are dedicated implementations like Query, Taxonomy, ... which come with their own UI and content. However I think we'll need to keep it this way, and I will propose a better design to fix the drawbacks.
Suggested design

Localization will follow the current model from O1, which is that nothing has to be done and let it handled by widgets ;)
Menu will be a content type, and the editor will be based on the default content editor, allowing drafts or scheduled publishing
Menu items are content items. Their types have the MenuItem stereotype.
We will make use of the Dynamic Cache feature to cache menus independently. we might also decide that response caching is sufficient.
Use the same JavaScript library to edit the menu

Storage
I suggest that we store the full menu hierarchy, including all menu items (content items) in the menu document. This will solve the major performance issue as their will be a single document to load, whatever the complexity of the menu (not taking into account other menu item sources like queries).
The idea is that we would create a custom Content__MenuItem_Edit shape to edit the menu items (or a custom controller) and return the content item document instead of persisting it. This way we can still reuse content definitions, parts and fields, but we would ignore the storage and indexing of menu items.

@sebastienros Maybe this issue should be in the O2 repo?
Anyway, I have worked on several projects where we have used the extensibility of menu items heavily. CSS is a common requirement, but we also commonly use it to:

Add images or icons
Add text fields to categorize menu items
Render menu items as separate headings and body texts
Add SEO elements to menu items

So the decision to keep this extensibility is quite important IMO.

Ouch, I am moving it to O2, can you copy your comment?


Android app should remove location updates when MainActivity is not visible

The Android app does not remove the location update listener when the MainActivity is closed or moved to the background. The app must be killed to stop listening to location updates.
Location updates should be registered in Activity.onResume() and should be unregistered in Activity.onPause().

Whoops, you're quite right. This change might add a delay before pins are updated when the app is re-opened, but it's well worth it to save battery life / avoid leaking location data.
This will be fixed in the next release.

Do you need any help here? I can try to support you with that issue.

Yes, that would be great! We would love the help.

I created a PR for this change. I tested it and now the app stops requesting the location. It automatically resumes the location updates on resume. I haven't experienced any delay on resume.


nil Error patter

Typical pattern for error is:
stmts, st, newPre, newPost, err := transpileToExpr(n.Children[0], p)
if err != nil {
return nil, "", nil, nil, err
}

What we can do with that:

If error is error, then we can add Warning about that error
If error is not error, then we can add coverage test for that case.

Please explain further why this issue was raised?


Adding lastEpochBlock to random.sol

Description
Adding an index tracker of the last block of a given epoch for the randomness contract. This ensures that when we call getBlockRandomness with the last block of the epoch, it always gives us the randomness, protecting us in case the epoch size is greater than the randomness history window.
Effectively adds another slot into the history reserved for lastEpochBlock
Tested
CI test suite.
Other changes
Added unit tests
Related issues

Fixes #2625

Backwards compatibility
Yes

Please add tests!

Tested this with nambrot/historical-randomness on geth and was able to sync nodes without any error messages around failing to fetch randomness, hoping that means its good to go.

🚢


Point webassembly.js at its new location in latest closure-compiler

Without this, elemental2 will not build after a bazel sync/bazel clean --expunge.

Sorry I've fixed that in 0c8615c8fbb65726c257db6b6049ff6c997d8817 without seeing this PR.
Yes we should use the com_google_closure_compiler version once a release of the closure compiler containing the extern is created and this version in use in bazel closure rule.


[WIP] Feat/notification gw handler and webhook

Related issues
https://github.com/solid/community-server/pull/1074
Depends on https://github.com/solid/community-server/pull/1075
Description
This is a draft implementation to support WebHookSubscription2021.
We opened this pull request to document and serve as subject for discussion during the upcoming architectural discussion for Solid Notifications held 9th of December.

Thanks for posting @ixuz ! Do you have a components.js config file that works with these classes yet?

@jaxoncreed I don't have a components.js config file at hand, but let's see if my colleague @TamSzaGot might have one.

I have to test the configurations before I submit them. I'll do it today.

Sorry I didn't have enough time to push the configuration files today. Since the implementation moved a bit since I had the server up and running with notifications I had to adjust the config files a bit and when I eventually had the server up and running with the notifications configured it didn't behave as expected. I'd like to debug and fix the issues before I push something. Will do as soon as possible.
Another thing to note is that the files oushed by ixuz are based on an early version of https://solid.github.io/notifications/protocol#webhooksubscription2021 and nothing from the https://github.com/solid/notifications-panel/blob/main/proposals/solid-webhook-notifications.md has been implemented. (Since we just recently came over that proposal).

@TamSzaGot That's fine.  I can help implement the new notifications stuff. I can get started on that once you push your configuration. Looking forward to it!

Hey @ixuz @TamSzaGot. Is there any progress on getting the configuration?

@jaxoncreed The configuration files will be pushed in an hour or so to this branch.

I'm making a PR to this branch here (https://github.com/individdata/community-server/pull/1). I'll continue to work on this.

I'm making a PR to this branch here (individdata#1). I'll continue to work on this.

Thank you @jaxoncreed! We'll closely collaborate together on this PR you've opened.

Odd, looks like one of the checks failed with a socket timeout. Re-running the CI workflow might be necessary.

Brief update: This PR is still in progress and we'll push new code to the branch soonish... 😉

This PR is superseded by PR https://github.com/CommunitySolidServer/CommunitySolidServer/pull/1388


Add toml file

Context:
make format does a black --check -l 100 which is not black default line length
Description of the Change:
Add a pyproject.toml file which sets black line length to 100.
Benefits:
Contributors running black on their contributions will get the results expected by make format.
Possible Drawbacks:
Contributors used to black defaults may at first be puzzled by the reformatted files.
Related GitHub Issues:
None.

It's worth noting that pyproject.toml is not included in the XCC wheel but that's probably not an issue.

Yes, it would be useless in the wheel, only matters to someone who checks out the tree to develop.


Fix PortServer disconnect crash in Python 3

Fixes #290.  More info is available here.

+1 for this fix. Thank you @kyleclaassen. This also fixes other subsequent issues, such the first message received on the server being dropped (in your example, only 4 messages are received by the server), as well has note_on being sent and note_off being received (not shown in your example, but I experience it).
Why almost year later this isn't merged?

Thanks @phyordia for confirming the fix is effective.
To answer why it hasn't been merged: unfortunately mido's maintainer (@olemb) has been MIA since mid 2021 for personal reasons and afaik is the only one to have the permissions.
We may need to fork the project at some point to ensure its future.

Gotcha! Hope everything is ok with him. I made a fork and implemented your fix plus another one(s)... definitely users should converge on an official active fork that everyone contributes to... anyway, thanks again for this

Thank you for the fix!


Fix for shr sequence cloberring the source reg value

fixes #940

@nmostafa  FYI a PR submitted for #940 (msft) / # 95 (intel-chakra)

@MikeHolman , can you review this ?

lgtm


Single OBSID Selection not resolving

When entering a single OBSID into the autonicer prompt it isn't resolving with the HEASARC query table output.
Example<PHONE_NUMBER> will give a OBSID not found message, while selecting cycle 3 will que up the<PHONE_NUMBER> OBSID

Initial investigation show a pd.Series with no values coming back in line 129 of autonicer/autonicer.py.
Most likely an error with a new version of pandas

Resolves perfectly fine for src ="crab pulsar" pandas v1.2.5
Broken with src=

"crab"
"PSR_B0531+21"
"PSR B0531+21"

Is still being queued up with the cycle 3 command for all the above src queries, still indicating an issue with pandas

Tested issue out with src=SAX J1808.4-3658 and am duplicating issue.
Additionally reverted back to pandas v1.2.4 the original pandas version used for development so this is not a pandas version issue.

This issue has been fixed with the release of v1.1.3.
The fix for this issue was in line 91 of AutoNICER.callnicer() where we replace any spaces in the OBSID.
See pull requests #21 and #22


new option IMPF: importable fields

new option IMPF introduced: describes fields to be imported into the table(s), default nr,nf,0-), can be used to exact specifying which fields should be imported from input (increases import performance, minimizes overhead and simplifies output of statements like select * from a, if e. g. fields like anr, anf and a0 are not necessary or too many input fields available).
Examples:
# with `-IMPF nr,1-2` - select anr, a1, a2 only:
echo -e "A B C D\nA B C\nA B" | sqawk -FS " " -IMPF nr,1-2 -output json "select * from a"

[{"anr":"1","a1":"A","a2":"B"},{"anr":"2","a1":"A","a2":"B"},{"anr":"3","a1":"A","a2":"B"}]

# without `-IMPF` - select anr, anf, a0 (whole record) and 10 fieds (default):
echo -e "A B C D\nA B C\nA B" | sqawk -FS " " -output json "select * from a"

[{"anr":"1","anf":"5","a0":"A B C D","a1":"A","a2":"B","a3":"C","a4":"D","a5":"","a6":"","a7":"","a8":"","a9":"","a10":""},{"anr":"2","anf":"4","a0":"A B C","a1":"A","a2":"B","a3":"C","a4":"","a5":"","a6":"","a7":"","a8":"","a9":"","a10":""},{"anr":"3","anf":"3","a0":"A B","a1":"A","a2":"B","a3":"","a4":"","a5":"","a6":"","a7":"","a8":"","a9":"","a10":""}]

I like the idea of having this functionality and your code looks fine but I am not sure the design of the feature is right. Some thoughts:

Setting -snf and enabling/disabling the special columns may be better as separate options.
Alternatively, you could give the user a general way to map the columns returned by the parser to the fields in the table, like a generalized version of columns=. E.g., let the user say something like "map column 2 to field a1, column 1 to field a2, column 5 to field a3, drop columns 3-4 and 6-end". It would replace two or more of -IMPF, columns= and merge=. (I think merge= may be overcomplicated as it is now.)
I can see the benefit of disabling a0 but I don't think there is a performance reason to disable anr and anf. While it makes the result of select * prettier a better way to handle this case may be to build a special SQL function into Sqawk that selects all columns except for the ones named (except for the empty ones?).

I'm very interested in ideas to do with the second point.

I like the idea of having this functionality and your code looks fine but I am not sure the design of the feature is right. Some thoughts:

Setting -snf and enabling/disabling the special columns may be better as separate options.
Alternatively, you could give the user a general way to map the columns returned by the parser to the fields in the table, like a generalized version of columns=. E.g., let the user say something like "map column 2 to field a1, column 1 to field a2, column 5 to field a3, drop columns 3-4 and 6-end". It would replace two or more of -IMPF, columns= and merge=. (I think merge= may be overcomplicated as it is now.)
I can see the benefit of disabling a0 but I don't think there is a performance reason to disable anr and anf. While it makes the result of select * prettier a better way to handle this case may be to build a special SQL function into Sqawk that selects all columns except for the ones named (except for the empty ones?).

I'm very interested in ideas to do with the second point.

I'm closing this pull request because the functionality it adds (other than disabling nr and nf) has been implemented in 1fa13f76261535975bef6cbe6b929aa53b51d1c2 and b361f57ca231765f9800848e204052722102301c through the file options skip and F0. I would be glad to hear your feedback on those. (Note that they are not final for version 1.0 and I may still replace them with a single option like map.)

Well, although looks not bad, but ...
Partially I don't like it, e. g.:
echo -e "A B C D\nA B C\nA B" | sqawk -FS " " -output json "select * from a" NF=1 MNF=crop skip=3-10 F0=0
[{"anr":"1","anf":"3","a1":"A","a2":"B"},{"anr":"2","anf":"3","a1":"A","a2":"B"},{"anr":"3","anf":"3","a1":"A","a2":"B"}]

Cons that I see:

negative handling (I should specify not what I'll see, but what I'll NOT see)
too wordy and too not understandable, just compare:
NF=1 MNF=crop skip=3-10 F0=0 with suggested -IMPF nr,1-2
I miss the possibility to skip anr and anf (e. g. target json is strict and should not have free fields at all). And when it'll be implemented, the command line will be still longer (syntax yet wordy)...
I miss the possibility to disable all fields except 1 and 2 (something like skip=3-), so if we don't know how much fields in the input file (dynamical) we should write something like skip=3-10000

On the whole, I find my solution better (and I will continue to use it)...

Thanks for the feedback! To me, the points about the negative handling and the wordiness seem especially strong. My primary reason for rejecting -IMPF was that it would result in three different column/field numberings used at different points, which could be confusing, particularly if I extended IMPF to support multiple ranges. E.g., if you said IMPF=nr,5-7,9-15 merge=5-7 'select a5, a7 from a' the numbers 5 and 7 would refer to different fields/columns in each of the two options and in the query. Using skip avoids that problem but, as you point out, the way skip works may itself be pretty confusing.
Ultimately, the problem might lie in trying to cram into a few command line options the kind thing that requires nothing less than a scripting language than to handle fully and well (a-la Greenspun's tenth rule).
As for shaping JSON output, I do not consider that Sqawk's job. What I found was that, in practice, you'd sooner or later need a specialized tool like jq for it. (I highly recommend jq; it was an inspiration for Sqawk in the first place.) In your example you could use jq like this:
echo -e 'A B C D\nA B C\nA B' \
| sqawk -FS ' ' -output json 'select * from a' NF=1 MNF=crop skip=3-10 F0=0 \
| jq 'map(del(.anr) | del(.anf))'

For a more advanced example (converting JSON to Tcl dictionaries with jq) check out https://github.com/stedolan/jq/pull/1228.
Another thing to note is that it's unfortunate that you have to maintain a fork of Sqawk if you want to use the functionality that isn't accepted into the core. Sqawk may need a plugin interface.
Once again, I appreciate your feedback. I've created an issue (#9) for revising these options.


Append option to append calendar to different element (body)

The calendar should be appended to body, this will prevent it to be hidden if placed inside overflow hidden container.

resolved in 0.6.0


Disable Android performance tests

See https://github.com/gradle/gradle-private/issues/4085

The merge queue build has started. Click here to see all failures if any.


[Parallels] Cannot Create Virtual Disk

While creating a peer on MacOS using parallels, there is an error with disk size. Parallels cannot create disk size.
Parameters of peer:
SUBUTAI_RAM : 4096
SUBUTAI_CPU : 1
SUBUTAI_ENV : master
DISK_SIZE : 200
BRIDGE : “en0”
pwd: /Users/admin/untitled folder/Subutai-peers/subutai-peer_fdvdffdvfd
Screenshot:

How to reproduce:

Bring a peer up on MacOS and monitor the process of creation

Successfully brought a peer up on macos:

Fixed in master

Tested in prod.


Lean In by Sheryl Sandberg

Congrats on starting Lean In by Sheryl Sandberg, I hope you enjoy it! It has an average of 3.5/5 stars and 3,751 ratings on Google Books.

Book details (JSON)
{
  "title": "Lean In",
  "authors": [
    "Sheryl Sandberg"
  ],
  "publisher": "Knopf",
  "publishedDate": "2013-03-11",
  "description": "The #1 international best seller In Lean In, Sheryl Sandberg reignited the conversation around women in the workplace. Sandberg is chief operating officer of Facebook and coauthor of Option B with Adam Grant. In 2010, she gave an electrifying TED talk in which she described how women unintentionally hold themselves back in their careers. Her talk, which has been viewed more than six million times, encouraged women to “sit at the table,” seek challenges, take risks, and pursue their goals with gusto. Lean In continues that conversation, combining personal anecdotes, hard data, and compelling research to change the conversation from what women can’t do to what they can. Sandberg provides practical advice on negotiation techniques, mentorship, and building a satisfying career. She describes specific steps women can take to combine professional achievement with personal fulfillment, and demonstrates how men can benefit by supporting women both in the workplace and at home. Written with humor and wisdom, Lean In is a revelatory, inspiring call to action and a blueprint for individual growth that will empower women around the world to achieve their full potential.",
  "image": "http://books.google.com/books/content?id=y9_mxZLYiiMC&printsec=frontcover&img=1&zoom=1&edge=curl&source=gbs_api",
  "language": "en",
  "averageRating": 3.5,
  "ratingsCount": 3751,
  "categories": [
    "Biography & Autobiography"
  ],
  "pageCount": 240,
  "isbn10": "0385349955",
  "isbn13": "9780385349956",
  "googleBooks": {
    "id": "y9_mxZLYiiMC",
    "preview": "http://books.google.com/books?id=y9_mxZLYiiMC&printsec=frontcover&dq=intitle:Lean+In+by+Sheryl+Sandberg&hl=&cd=1&source=gbs_api",
    "info": "https://play.google.com/store/books/details?id=y9_mxZLYiiMC&source=gbs_api",
    "canonical": "https://play.google.com/store/books/details?id=y9_mxZLYiiMC"
  }
}

When you're finished with reading this book, just close this issue and I'll mark it as completed. Best of luck! 👍

I'm on page 200


Connection closed before full header was received

GetConnect
Connection closed before full header was received

I can confirm that GetConnect works perfectly. I'm closing this issue for not respecting the issue opening template (reproduction code, environment details, etc.)


iOS Crash - PresentViewController

Calling presentViewControllerAnimatedCompletion on the UIViewController instance is crashing the application on iOS 11 with SIGABRT.
I tried the call on iOS 10 and it’s working correctly. However, on iOS 11 it just crashes. There’s no stack trace or some error message. I tried this on iOS 11.0.3 and on iOS 11.1 beta and it’s the same.

Has there been any fis?


Support for Immutable.js types

I've been trying to use Immutable's List type in my t.match function, but it doesn't seem to work and I get this error.

Others, like Record, do work, though. I used a Refinement type for the List type for now, but I wanted to draw attention to these types and wondered how to support these types more easily...
Here is my code
type ListA = Obj & $Refinement< typeof I.List.isList >
type MapA = Obj & $Refinement< typeof I.Map.isMap >
type RecordA = Record

@volkanunsal it seems an issue with tcomb's match which currently accepts only types https://github.com/gcanti/tcomb/issues/248


Add markdown support

I've been working styling the information panel (issue #801).
One thing that I've noticed is that a number of package long descriptions are not coming through with the correct formatting:

The first is clearly markdown, the second, I am not sure, but I have noticed a number of other packages using the same syntax.
Obviously, it would be great to render these out to HTML so the new styles will work.

The first is Markdown and the second is reStructuredText.
Current PyPI does not render long descriptions in Markdown. For example, here is the project from your first screenshot on the current PyPI. There is a related discussion over on the PyPI repo that you should probably look at.
Here is the project from your second screenshot on the current PyPI. The long description renders correctly since the current site supports RST.

Thanks @nchammas - looks like I walked into a minefield on that one :P
So from that thread I take it that Markdown support is unlikely in the short term.
On the RST side - do we have plans to support this (ping @dstufft) - I assume we will want to do this to provide parity with the current site?

Hmm, we should be using the exact same code to render descriptions as PyPI is. Sounds like a bug of some sort.

Looking at this again, it appears RST rendering is working the same as it does in the legacy site. I think the confusion comes from the fact that our test data comes from TestPyPI not from PyPI so you need to compare to https://testpypi.python.org/pypi/django-excel-response3/ which also has broken display. My guess is they fixed some broken RST and didn't update TestPyPI with the fix.

I'm going to drop this from "Become PyPI". We don't currently support Markdown and actually doing so properly is more effort than it's worth to try and get it into our initial launch.

Ok, this makes sense... thanks for the follow up @dstufft

I've recently had a lot of problems getting the rST to work on pypi. Some problems were fixed by running the check command in setup.py, but one error I had didn't show up there: I had the string 'foo__' which is a reference in rST. This error didn't show up when running the check command so I had to do a binary search of the description to find it :P
Clearly some work on improving the error checking on this would be nice, but isn't strictly a part of warehouse although warehouse suffers from it.

Could you elaborate a bit more about why it's a lot of effort to support Markdown ?
A lot of pypi packages are hosted on github where they have a Markdown README file. Maintaining an alternative README file in .rst for pypi seems to be a lot of work for nothing... That is why most of developers (me included) don't bother converting the description field and let it as Markdown.
It follows that a lot of packages does not have a nicely formated page on pypi.
As the future platform for Python packages, don't you think it's worth trying to put some effort in it ?

I just see that some work is undergoing there https://github.com/pypa/readme_renderer/pull/3

Please see https://github.com/pypa/python-packaging-user-guide/pull/258 for a more complete overview.

By reading this thread, it seems to me this feature is pending on the completion of the PR mentioned by @hadim ?
https://github.com/pypa/readme_renderer/pull/3
as this README rendereding lib is used by warehouse: https://github.com/pypa/warehouse/blob/master/requirements/main.in#L37
Is that correct ?

+1 fo markdown.. I would like to help with coding if supporting markdown is an option

I’ll also help implement support for Markdown or other languages! I think one of Github’s strengths is strong markup-language support. (Github currently supports nine different languages!)
I think it would make sense to implement the documentation as a subset of HTML rather than any one markup language; one of RST’s big problems is that there’s no support for nested inline styles, such as code links or bold italics, and we could avoid the inflexibilities of any particular markup language by supporting several or a superset of all of them.

pypa/readme_renderer#51 implements Markdown Support and making it easier to add support for more languages in the future (I guess?).
It still needs to be reviewed AFAICT.

Ehm, while understanding that feature requests can lead to discussion which can lead to better solutions, i am a bit lost on why this is complicated, especially compared to the value it adds. Seems that find a way to indicate what format to render and render it that way does not have to take 3 years.
I have seen loads of suggestions for solutions (e.g. add long_description_format to setup) that might for some reason or other not be perfect, but all are better than the current state.
My personal experience:

oh, pypi does not render markdown,
hm, google, maybe there is an automatic converter,
read about pypandoc,
install  pypandoc,
change an run setup.py,
re-upload to pypi,
check doc, hm, mostly ok, but conversion is not perfect,
change markdown,
2 or 3 versions further: all good (i think, getting tired of rereading the readme).

And i am pretty sure that pypandoc is the easiest way to go and this took me about 3 hours for a simple project. Multiply by number of uploaders ...
Anyway, bit ranty, sorry about that, is there an eta yet?

It's Open Source Software, the ETA is that it'll get done whenever someone has to motivation to do it. Someone took the effort to go through and get agreement on the mechanism to indicate what format to render things in, now someone needs to go through and add support for that to setuptools, twine, and Warehouse.

@dstufft What about pypa/readme_renderer#51?

@dstufft @nlhkabu  seems this is the last bit to have markdown support, can you give some pointer to what needs to be done so we can give a hand?
Thanks :)

@yohanboniface Currently Markdown support in Warehouse is blocked by the following things:

[ ] A PR to Warehouse (There is a PR open here); which is blocked on:
[ ] An update to twine (There is a branch ready here); which is blocked on:
[ ] An update to pkg-info (there is an open merge request here which is blocked on the PEP); which is blocked on:
[ ] A PEP to specify the Version 1.3 Metadata as described here

I'm currently working on the PEP, and hope to have it finished soon, to unblock the rest of the changes necessary.

Great news :)
So if I summarize, once the PEP is out and blessed, everything else is ready?
Is there anything we can do to help on the PEP side?

I don't think we need a PEP, we did an adhoc spec for it already: https://packaging.python.org/specifications/core-metadata/#description-content-type-optional
The primary blockers at this point is just plumbing that new value through the various tools.

The primary blockers at this point is just plumbing that new value through the various tools.

According to our tests, if you add the long_description_content_type argument to setup, and if you use a setuptools >= 36.4.0, the Description-Content-Type ends up in the PKG-INFO, see for example this package in test.pypi
So it seems like it's a matter of passing this metadata to readme_renderer, which is already capable since https://github.com/pypa/readme_renderer/pull/55 AFAIK.
So is https://github.com/pypa/warehouse/pull/2373 that missing bit? Or is there something else that needs to be done to consume that metadata when available?

@yohanboniface The issue isn't getting it into the PKG-INFO, it's getting it out. Twine uses the pkginfo package to extract the metadata and pass it to Warehouse. The maintainer(s) of pkginfo didn't want to add the Version 1.3 metadata without a PEP.

Or is there something else that needs to be done to consume that metadata when available?

You're right, there will also need to be a small PR to use the fields added in #2373 to determine the renderer readme_renderer uses, but that will have to come after #2373 is merged.

Great! @di, please let me (or others!) know if there’s anything you need help with in getting the PEP ready; I know several of us are more than happy to help.

Why can't PyPI try to render as markdown if the normal renderer fails? The default now to fall back to plain text is almost always wrong.

I've mentioned it elsewhere, but the reason is because it's just a crappy user experience.
There exists documents that are both valid markdown and valid rST but which render completely differently in the two systems. So if you have a description that is written in Markdown, you have to be careful to ensure that not only is it valid markdown, but it is invalid rST. This is likely to lead to having to have some silly little syntax quirk laying around somewhere in your README that exists entirely to fool the parser. This problem gets worse for each additional parser we add into the chain.
There is another, related problem that for many people they don't know that their description isn't going to render correctly until after they've uploaded to PyPI. It would be great if PyPI could validate this field like it validates other fields, and reject the upload if it fails. However we can't do that with the fallback behavior as it currently stands, because the fallback behavior will always succeed in the end. Now this isn't strictly related to allowing markdown rendering, but since the solution to the first problem is best served by allowing a project to indicate what language their description is written in, that means that same solution unblocks the ability to start validating descriptions on upload. Thus making it a sort of kill two birds with one stone kind of issue.
Ultimately we've already decided on the mechanism that this will work with, somebody just needs to do the work to plumb it through the various projects.

@dstufft The main problem seems to come down to pip/pypi only accepting a single description text field. The user experience shouldn't have to be crappy because of that internal detail. The user experience should be, user has README.rst -> renders in rst, user has README.md -> renders in markdown.
Legacy behaviour can be retained, but to be honest, I wonder if that's even a good idea. RST stops rendering on the tiniest of issues which, compared to Github is a very poor user experience.
Personally, I've given up on using RST and just use a README.md on all my projects. PyPI is just a file host at this point and I point users to Github so they can read a documentation intro document that doesn't require me to run a test suite on...

I mean, the agreed upon solution is quite literally to add a second field that indicates if it's rst, markdown, or plaintext. We're not going to read a file from the tarball (that file doesn't even exist inside of a wheel for instance) over using the structured metadata that already exists.
Like I said, the mechanism to support that has already been agreed upon, all that is required now is someone to put in the effort to plumb it through the various tools. The people working on these tools are largely volunteers or have other priorities at this moment, so you can either wait for this to bubble up to the surface of those people, or well:

I don't understand what's needed:

The pkginfo PR isn't blocked, it's just waiting for @tseaver to hit the merge button.
twine already monkeypatched support for METADATA 2.0, and given the pain this is causing, I don't see a reason not to monkeypatch pkginfo in twine (especially since launchpad/bzr is difficult to use).
Surely the PR for warehouse is backwards-compatible with older twine versions? Meaning that it could be merged now (if it does what it claims to do).

A quick update: the PEP is in draft status here: https://www.python.org/dev/peps/pep-0566/
There is an RFC here: https://mail.python.org/pipermail/distutils-sig/2017-December/031788.html

PEP 566 has been accepted, so tool authors are now likely to accept the PRs adding Description-Content-Type support :)

Hi All
Is there any reason we are not using client-side JavaScript to automatically detect the format and render it?

@sayanarijit see https://github.com/pypa/readme_renderer/issues/1 and https://github.com/pypa/readme_renderer/pull/51, TL;DR: "Since we now have a way for the user to explicitly describe the content-type of their README, being able to infer it isn't necessary.".
Also, infering is hard, and can fail. FWIW see https://github.com/JulienPalard/mdorrst

@JulienPalard Thanks for the information. I was not aware of this. However I just tried updating one of my packages listed on pypi: pidlock after mentioning 'Description-Content-Type' as 'text/markdown' using setuptool's long_description_content_type argument. But it seem it failed to convert the markdown.

@sayanarijit It's still WIP (note this issue is still opened) but as the PEP has been accepted we're now sure it's the right way to do it, it's a good first step.

With https://github.com/pypa/warehouse/pull/3296 merged and a pre-release of twine available, it is now technically possible to publish descriptions on PyPI using Markdown. 🎉
For example, see https://pypi.org/p/markdown-description-example/
Here's a step-by-step guide with everything necessary to make this work for your new or existing project: https://dustingram.com/articles/2018/03/16/markdown-descriptions-on-pypi
I'll leave this issue open until @brainwane makes the official twine release is made on Monday. Please feel free to comment here if you try this and are having issues.

I'd love for people to start preparing PRs for documentation improvements for the sample project used in the official package distribution guide, and for that guide itself.

Also, per Dustin's guide, if you're testing this, make a source distribution (sdist), not a wheel. Wheel support may depend on pypa/wheel#231 being resolved.

@di Will this work now if we deploy to pypi from travis?
https://github.com/PyGithub/PyGithub/blob/master/.travis.yml

I’ve created a PR for the sample project (pypa/sampleproject#66) and I’m working on one for the guide as well. What versions of twine, wheel, distutils, and so on support the content-type field so far? It might be good to have version numbers inline in the documentation.

Thanks for your PR, @9999years! Versions: pkginfo 1.4.2, Twine 1.11.0 (right now 1.11.0rc1 will work), setuptools 38.6.0, and I'm not entirely clear regarding wheel since wheel support does not work yet as of wheel 0.30.0. Dustin's blog post mentions some of those. I am not sure about Python versions (distutils being part of the Python standard library). Twine 1.11.0 requires the relevant version of pkginfo.
There's an open issue for the packaging docs.
@sfdye I see you're creating both a wheel and a source distribution but it looks like you only upload an sdist so I think you'll be fine, but of course I defer to @di here. (I'm experimenting with Markdown support with this test project and Markdown support works if I upload only an sdist, but if I upload a wheel, or an sdist and a wheel, then Markdown support does not yet work.)
Those of you who want to use GitHub-flavored Markdown (beyond what's in the CommonMark specification), please go over to packaging-problems#126 to find out what's necessary, again, in a few different codebases.

Okay, the guide PR is at pypa/python-packaging-user-guide#457.

For the time being, we don't have any plans for distutils itself to support metadata versions beyond 1.1 - the guidance for a number of years has been to use setuptools instead (regardless of Python version), and this is just one more reason to continue that recommendation.
However, I think the existence of the standard library distutils API implementation is a genuine problem given that we don't really want people to be using it, so I filed https://github.com/pypa/packaging-problems/issues/127 to discuss how we might manage the process of making setuptools the reference implementation of the traditional distutils API.

and I'm not entirely clear regarding wheel since wheel support does not work yet as of wheel 0.30.0

Yes, per https://github.com/pypa/wheel/issues/231 we will need to instruct users wanting to build wheels to use an as-of-yet-unreleased version of wheel (working on this now).

Twine 1.11.0 is now out and includes some fixes that'll stop users from trying stuff that won't work anymore.
We're leaving this issue open till @di's pypa/wheel#232 is merged & released, so users can upload Markdown READMEs in their wheels.
(You can thank Dustin in person at PyCon in May, where he's speaking and sprinting.)

@di does https://github.com/pypa/wheel/compare/0.30.0...0.31.0 and https://pypi.org/project/wheel/0.31.0/ mean we can close this issue?

Yep! Thanks everyone for your patience w/ this issue.


Update Dockerfiles

Deliverable 0d.
We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone.
There is a need to update Dockerfile(s) after developing new functionality in Milestone 2.

https://github.com/eigerco/pallet-move/pull/131


Lahiri Ayanamsa doesn't work

https://api.vedastro.org/Calculate/AllHouseData/HouseName/House1/Location/Kanpur,UttarPradesh,India/Time/17:15/19/11/2002/+05:30/Ayanamsa/Lahiri

Returns:
{'Status': 'Fail', 'Payload': "The input string 'Lahiri' was not in a correct format."}

Thank you for raising this issue. It has been fixed ✅
Rebuild your API URL using latest API Builder --> vedastro.org/APIBuilder


Test file and Fault tolerance

Glad you managed to sort things out with the imports!
I've had a chance to run your code, and unfortunately I get this error:
bruno@bruno-lenovo:~/DEIB_Dropbox/aml/aml_fork$ python3 test/fault_tolerance_test.py

Fault tolerance test: iteration 1

python3: can't open file '/home/bruno/.dropbox-deib/Dropbox (DEIB)/aml/aml_fork/fault_tolerance_slave.py': [Errno 2] No such file or directory

The other one (test.py) runs fine, but faas_test_xgboost_fs takes waaaay too long, and I'd like for it to last seconds rather than minutes. I think this is because it uses the default grid from data_preparation/xgboost_feature_selection.py. You can solve this by just adding a custom, smaller grid to the test input dictionary.
While we're at it, can you rename test.py to a more significant name? test_configurations comes to mind, for example. Thanks!

There was an issue with the command executed by fault_tolerance_test.py, now it should be fixed using absolute paths. Moreover, I've shortened faas_test_xgboost_fs and renamed test.py.
Let me know if you find any other issue!


#883 patch,Roles displayed

#883 Issue fixed.

You should not change the actual roles themselves but rather how they are displayed in the form. The only file you should be changing is forms.py - https://github.com/Cal-CS-61A-Staff/ok/blob/master/server/forms.py#L161
The documentation on the form library is here: http://wtforms.simplecodes.com/docs/1.0.1/crash_course.html

@Sumukh So you mean to say that i should not change the text of the already given choices, instead add more choices ?

Not quite. The strings in the constants.py file should not be changed. If you look at line 170 of forms.py (https://github.com/Cal-CS-61A-Staff/ok/blob/master/server/forms.py#L170) you can see how the fields are rendered. Current it's [r, r.title() for r in roles ]  which results in [('student', 'Student'), ('grader', 'Grader')...] That second value is what's rendered in the form.
We should keep the raw values of the roles (['student', 'grader', ...]) the same.
Here's one approach that could work. Define a dictionary of role_names in constants.py that maps each of the role to the desired name
role_names = {
   'grader': 'Tutor',
   'student': 'Student',
    ...
}

and then in the form you can do [(r, role_names[r]) for r in VALID_ROLES)

@knrafto I've made all the changes as requested.


spring-modulith-observability breaks RestControllers implementing an Interface

When the spring-modulith-observability dependency is present, RestControllers that implement any interface are no longer serving their endpoints or apear in the OpenAPI documentation (Swagger).
This is not limited to interfaces with Rest Annotations (like @GetMapping), or OpenAPI Annotations, but also to interfaces that are not related to the REST API, including empty marker interfaces.
The expected behavior is, that the spring-modulith-observability doesn't have an effect on the availability of RestControllers implementing an interface.
Reproducer https://github.com/gmuecke/spring-modulith-observability-reproducer
Spring Modulith: 1.2.0, 1.1.5
Spring Boot: 3.3.0, 3.2.6
JDK 21

In the reproducer Module1Controller is not implementing an interface, Module2Controller and Module3Controller however are implementing an interface.
For the Module1Controller bean  the ModuleTracingBeanPostProcessor.postProcessAfterInitialization returns a Spring CGLIB Proxy, which is then processed by the other BeanPostProcessor instances.
For the controllerModule2Controller and Module3Controller beans a JdkDynamicAOPProxy instance is returned.
Unfortunately I'm not sure whether this is the desired behavior or not, but maybe this first analysis helps you @odrotbohm with identifying a fix.


Fix EBADF in case of a reopen() while an open was in progress.

Fixes https://github.com/pinojs/pino/issues/710

@thw0rted can you please confirm this solves your issues in https://github.com/pinojs/pino/issues/710?

This resolves the error I was seeing in my actual project.  I also tested it in the repro and it's fixed there as well.


Protocol error Invalid InterceptionId on cancelled requests

Component
Version

Operating system
kali 1.0

Node.js
v8.11.1

Chrome/Chromium/...
HeadlessChrome/66.0.3359.139

chrome-remote-interface
0.25.5

Is Chrome running in a container?  NO
when i am using the Network.requestIntercepted, i got an error
(node:6141) UnhandledPromiseRejectionWarning: Error: Invalid InterceptionId.
    at /root/Desktop/node_modules/chrome-remote-interface/lib/chrome.js:96:30
    at Chrome.handleMessage (/root/Desktop/node_modules/chrome-remote-interface/lib/chrome.js:297:13)
    at WebSocket.<anonymous> (/root/Desktop/node_modules/chrome-remote-interface/lib/chrome.js:274:27)
    at emitOne (events.js:116:13)
    at WebSocket.emit (events.js:211:7)
    at Receiver._receiver.onmessage (/root/Desktop/node_modules/ws/lib/WebSocket.js:141:47)
    at Receiver.dataMessage (/root/Desktop/node_modules/ws/lib/Receiver.js:389:14)
    at perMessageDeflate.decompress (/root/Desktop/node_modules/ws/lib/Receiver.js:349:40)
    at _decompress (/root/Desktop/node_modules/ws/lib/PerMessageDeflate.js:306:9)
    at _inflate.flush (/root/Desktop/node_modules/ws/lib/PerMessageDeflate.js:386:7)
(node:6141) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 5)

it trigger when i am clicking the html like that:

if click so fast   like node.click();
it turns out the request which cause the error has "canceled" status.
What I suspect is when I called interceptedRequest.continue(), the underlying Chromium process already "lost" the interception, which cause it to return this error.
if i want ignore these error, what need i do?

Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch().

Just properly handle the errors in promises. If you provide your code I can be more specific.

`Network.requestIntercepted(async (result = {}) =>{
if(result.isNavigationRequest === true  && global.i ==0){
global.i++;
Network.continueInterceptedRequest({interceptionId:result.interceptionId});
}else if(result.isNavigationRequest === true){
Network.continueInterceptedRequest({interceptionId:result.interceptionId,errorReason:'Aborted'});
}
}
...`
i make it cuz i just want block other NavigationRequest ,just let the first NavigationRequest pass .

I strongly suggest you to read about Promises and their relative error handling, anyway you can do something like:
let firstTime = true;

Network.requestIntercepted(async ({interceptionId, isNavigationRequest}) => {
    if (isNavigationRequest) {
        try {
            await Network.continueInterceptedRequest({
                interceptionId,
                errorReason: firstTime ? undefined : 'Aborted'
            });
        } catch (err) {
            console.error(`ERROR: ${err}`);
        } finally {
            firstTime = false;
        }
    }
});

i just did await Network.continueInterceptedRequest({interceptionId:result.interceptionId,errorReason:'Aborted'}).catch((error) => {console.log(error)});
i got it ~ thanks alot


Deprecation warnings

Hi! When build an apk with your lib i got 22 warnings like this
[deprecation] Camera in android.hardware has been deprecated
import android.hardware.Camera;

[deprecation] Camera in android.hardware has been deprecated
                .setFlashMode(useFlash ? Camera.Parameters.FLASH_MODE_TORCH : null)

Hi, @Thegrep01
Probably I need to implement Camera2, but I don't know if the Google Mobile Vision will support it.


[CSPM] Enable host_benchmarks by default

What does this PR do?
This changes enables host_benchmarks by default when running the security-agent compliance module.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Cut PPP

Codecov Report

Merging #312 (129596f) into master (72b20ac) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #312   +/-   ##
=========================================
  Coverage     78.07%   78.07%
  Complexity      993      993
=========================================
  Files           119      119
  Lines          3033     3033
  Branches        417      417
=========================================
  Hits           2368     2368
  Misses          540      540
  Partials        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b20ac...129596f. Read the comment docs.


Language review needed on page

Description:
There are some typos on page  https://apim.docs.wso2.com/en/latest/develop/customizations/customizing-the-developer-portal/styling-api-details-info-section/
Suggested Labels:
Documentation
Suggested Assignees:
Mariangela Hill, Shani Ranasinghe, Ruthryi Kulasekaran
Affected Product Version:
3.1

@ruthryi , please review page [1] in 3.1.0 and 3.2.0 only after you have finished the current tasks that you are working on.
[1] https://apim.docs.wso2.com/en/latest/develop/customizations/customizing-the-developer-portal/styling-api-details-info-section/


Clicking View Traceback in the status notification (GUI) is really slow

🐛 Bug Report
If you get a traceback while using the GUI you get the small notification about it.
It has View Traceback button that brings up a nicely formatted traceback you can copy paste.
However, on my machine, from click to getting that window is ~1 min. with everything blocking.
This is really aweful!
💡 Steps to Reproduce
Run napari from terminal.
Trigger traceback, e.g. drag-n-drop a folder that doesn't contain images.
💡 Expected Behavior
The window should spawn within a few seconds at most.
🌎 Environment
napari: 0.4.19.post1
Platform: macOS-14.4.1-arm64-arm-64bit
System: MacOS 14.4.1
Python: 3.11.7 | packaged by conda-forge | (main, Dec 23 2023, 14:38:07) [Clang 16.0.6 ]
Qt: 5.15.8
PyQt5: 5.15.9
NumPy: 1.26.3
SciPy: 1.12.0
Dask: 2024.1.1
VisPy: 0.14.1
magicgui: 0.8.1
superqt: 0.6.1
in-n-out: 0.1.9
app-model: 0.2.4
npe2: 0.7.4
OpenGL:

GL version: 2.1 Metal - 88
MAX_TEXTURE_SIZE: 16384

Screens:

screen 1: resolution 2056x1329, scale 2.0
screen 2: resolution 2560x1440, scale 1.0

Settings path:

/Users/sobolp/Library/Application Support/napari/napari-419_9f9c3b1d4cb071ffa9c3954dc49db19675ab479f/settings.yaml

💡 Additional Context
No response

I think that makes sense, @Czaki any thoughts? you wrote it 😉
Also, this looks to have been up-streamed to superqt:
https://github.com/pyapp-kit/superqt/blob/0ec5cd3a2f967f04f0240e2421a6fd2f2f7fcf25/src/superqt/utils/_code_syntax_highlight.py
Maybe we should fix there and then use superqt version in napari?

Maybe we should fix there and then use superqt version in napari?

I think that this will be best, solution

Should this be closed/marked as closed by #6938 @psobolewskiPhD ?


Clickhouse just broke itself

Hey,
I found out that Clickhouse stopped working yesterday afternoon. For some reason the pidfile cannot be opened anymore since then.
Aug  5 22:15:57 sentry-clickhouse-1 clickhouse-server[4544]: Code: 76, e.displayText() = DB::ErrnoException: Cannot open file /run/clickhouse/clickhouse-server.pid, errno: 2, strerror: No such file or directory, Stack trace (when copying this message, always include the lines below):
Aug  5 22:15:57 sentry-clickhouse-1 clickhouse-server[4544]: 0. DB::throwFromErrnoWithPath(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, int) @ 0x7b5e959 in /usr/bin/clickhouse
Aug  5 22:15:57 sentry-clickhouse-1 clickhouse-server[4544]: 1. DB::StatusFile::StatusFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::function<void (DB::WriteBuffer&)>) @ 0x7bceedc in /usr/bin/clickhouse
Aug  5 22:15:57 sentry-clickhouse-1 clickhouse-server[4544]: 2. void std::__1::__optional_storage_base<DB::StatusFile, false>::__construct<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::function<void (DB::WriteBuffer&)>&>(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&, std::__1::function<void (DB::WriteBuffer&)>&) @ 0x7c3c171 in /usr/bin/clickhouse

I found out that there is a systemd daemon and an old init.d file with different settings. Does OpsWorks update stuff? Did the mess up happen then? I did not touch my Sentry stack for a longer time.
I fixed it by manually setting the pidfile to /tmp/... in the /etc/systemd/system/clickhouse-server.service file:
[Unit]
Description=ClickHouse Server (analytic DBMS for big data)
Requires=network-online.target
After=network-online.target

[Service]
Type=simple
User=clickhouse
Group=clickhouse
Restart=always
RestartSec=30
RuntimeDirectory=clickhouse-server
ExecStart=/usr/bin/clickhouse-server --config=/etc/clickhouse-server/config.xml --pid-file=/tmp/clickhouse-server.pid
LimitCORE=infinity
LimitNOFILE=500000
LimitNPROC=40960
CapabilityBoundingSet=CAP_NET_ADMIN CAP_IPC_LOCK CAP_SYS_NICE

[Install]
WantedBy=multi-user.target

Perhaps you have an idea.
Cheers.

Hey,
Sorry for the long reply.
I literally have no idea and it never happened to me.
Maybe someone else touched it .... ?


move as much as possible into pre-req steps

@rgardler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Move prefetch devs out of the larger build team

They generally don't maintain anything in the build pipeline except for
the prefetch task.
Also: Don't run e2e-tests just for OWNERS changes (note that the e2e-tests will trigger on this PR because it changes a file in .tekton)

Added. I didn't add @eskultety to any team. We can do that too if desired.

Added. I didn't add @eskultety to any team. We can do that too if desired.

Good point, https://github.com/orgs/konflux-ci/teams/build-maintainers please :pray:

/retest

/verify-owners


link for example app for integration (2048 game) is broken

Description

link for app for integration is broken in Adding React Native to your app docs
https://reactnative.dev/docs/next/integration-with-existing-apps?language=swift#adding-react-native-to-your-app
https://reactnative.dev/docs/next/integration-with-existing-apps?language=objc#adding-react-native-to-your-app

I think we should either remove those links/section entirely, or find a proper replacement + retake all the screenshtos

@tarunrajput Would you be interested in investigating where the link for the app integration is? My preference is also slightly removing these instructions. cc @cortinico thoughts?

related to https://github.com/facebook/react-native-website/pull/4076


Cannot move to another page's anchor

🐛 Bug Report
Cannot move to another page's anchor when clicking the link.
Have you read the Contributing Guidelines on issues?
yes
To Reproduce

Add a page named "doc1" with the following contents

## foo
here require large contents enough to scroll
 ...
 ...
 ...
 ...
 ...

## bar
some contents

Add a page named "doc2" with the following contents

  [link to another page's anchor](doc1#bar)

Build the pages and open the browser
Click the link at the page "doc2"

Expected behavior
Move to the "bar" on the page "doc1"
Actual Behavior
Just move to the page "doc1", but the scroll position is incorrect (=top).
Your Environment

Docusaurus version used: ^2.0.0-alpha.55
Environment name and version (e.g. Chrome 83.0.4103.97, Node.js 12.14.0):
Operating system and version (desktop):

Reproducible Demo
https://shinout.github.io/docusaurus-incorrect-anchor-move-repro/docs

Click the link doc1#Images at Document Number 2(doc2)

This should work as intended if you use lowercase, i.e. doc1#images instead of doc1#Images

Indeed! Anchor links are slugified hence will become lower case. Thanks Teik Jun! Hi there fellow 🇸🇬 -ean!

Hi Yangshun! :D

Thank you for your help.
Then I'm wondering how to link multibyte strings. I use Japanese and this happens when an anchor contains some Japanese characters. It won't work well.

Hi @shinout, if you think we should reopen, can you make a repro please?

I've made a repro for the issue mentioned by @shinout
To Reproduce:

Visit https://docusaurus-anchor-repro.now.sh/docs/doc2
Click "go to a header written in japanese" link

It goes to the start of the page instead of the header
Reproducible Demo:
Repo: https://github.com/teikjun/docusaurus-anchor-repro

@teikjun Thank you for that! Btw are you an MLH fellow? Just wondering about the increased interaction here 😃

Yup, I'm an MLH Fellow! I heard about the fellowship from your tweet 😄

Oh that's great! Look @JoelMarcey I hired a fellow without knowing 🎉

@teikjun Thank you for preparing reproduction!
@yangshun Thanks for reopen the issue.
Should I add to the title of this issue when using multibyte string ?


seek function doesn't work on Android

Bug
When the seek function is used on Android it always skips to the start of the video
Platform

Android ExoPlayer

Environment info
React Native version: 0.63.3
Library version: 5.1.0-alpha8
Steps To Reproduce

Run seek function with any argument on Android
The video seeks to 00:00

Expected behaviour

The video should seek to the desired time

I tried it today with 5.1.0-alpha8 and indeed the seek function still not working properly with Android MediaPlayer, but it works with ExoPlayer.
Sample Code
I tested it with three different videos (one local file and two from Internet).

Click to expand
import React from 'react';
import {StyleSheet, View} from 'react-native';
import Video from 'react-native-video';

export default () => (
  <View style={styles.container}>
    <Video
      source={{
        uri:
          'https://www.sample-videos.com/video123/mp4/720/big_buck_bunny_720p_20mb.mp4',
      }}
      controls
      onSeek={(data) => console.log('onSeek', data)}
      style={styles.video}
    />
  </View>
);

const styles = StyleSheet.create({
  container: {flex: 1},
  video: {width: '100%', height: 220},
});

Default behavior
Android MediaPlayer (imprecise seek)
https://user-images.githubusercontent.com/11046907/103314418-f120dd00-4a1a-11eb-814a-929077256ba4.mp4
ExoPlayer (seek seems to be working fine)
https://user-images.githubusercontent.com/11046907/103313934-6db2bc00-4a19-11eb-9861-32b542d3873f.mp4
Fix for Android MediaPlayer
Currently, this lib use seekTo without mode param and I played around the other modes available and the one that seeked properly was SEEK_CLOSEST (pay attention to its description).
So the change done was in android/src/main/java/com/brentvatne/react/ReactVideoView.java on the line 640:
- super.seekTo(msec);
+ super.mMediaPlayer.seekTo(msec, MediaPlayer.SEEK_CLOSEST);

I'm aware that's not look too to access a super class member attribute, but we just have access to the seekTo method with a single parameter.
Here is the same sample as above with the fix.
https://user-images.githubusercontent.com/11046907/103313932-6db2bc00-4a19-11eb-9439-9b01a2f71971.mp4

Related issues

#1476
#1550
#1717
#1908

I needed to show the exact time of the video to the user according to the sliding of the trim slider.
I was facing a similar issue and I got to manage a workaround in my case. I hope it's helpful to anyone facing a similar issue.
const [check, setCheck] = useState(true)
onProgress = {onProgress}

const onProgress = ({currentTime}) => {
    if (Math.round(currentTime) === 0 && checked) {
      if (player) {
        player.current.seek('jump to your desired value');
        setChecked(false);
      }
    }

   if (Math.round(currentTime) > 0) {
      if (checked) {
      } else {
        setChecked(true);
      }
    }
}

I needed to show the exact time of the video to the user according to the sliding of the trim slider.
I was facing a similar issue and I got to manage a workaround in my case. I hope it's helpful to anyone facing a similar issue.
const [check, setCheck] = useState(true)
onProgress = {onProgress}

const onProgress = ({currentTime}) => {
    if (Math.round(currentTime) === 0 && checked) {
      if (player) {
        player.current.seek('jump to your desired value');
        setChecked(false);
      }
    }

   if (Math.round(currentTime) > 0) {
      if (checked) {
      } else {
        setChecked(true);
      }
    }
}

I tried it today with 5.1.0-alpha8 and indeed the seek function still not working properly with Android MediaPlayer, but it works with ExoPlayer.
Sample Code
I tested it with three different videos (one local file and two from Internet).
Click to expand
Default behavior
Android MediaPlayer (imprecise seek)
video_2020-12-29_21-14-58.mp4
ExoPlayer (seek seems to be working fine)
video_2020-12-29_21-04-12.mp4
Fix for Android MediaPlayer
Currently, this lib use seekTo without mode param and I played around the other modes available and the one that seeked properly was SEEK_CLOSEST (pay attention to its description).
So the change done was in android/src/main/java/com/brentvatne/react/ReactVideoView.java on the line 640:
- super.seekTo(msec);
+ super.mMediaPlayer.seekTo(msec, MediaPlayer.SEEK_CLOSEST);

I'm aware that's not look too to access a super class member attribute, but we just have access to the seekTo method with a single parameter.
Here is the same sample as above with the fix.
video_2020-12-29_21-04-15.mp4

Yeah @kaioduarte, just to add on to your nice workaround. I noticed that there already exists a separate mMediaPlayer object in ReactVideoView.java, so we could write:
mMediaPlayer.seekTo(msec,3);  // 3 or MediaPlayer.SEEK_CLOSEST
instead of accessing from the super class.

If someone wants to open a PR, that would be great !

I tried it today with 5.1.0-alpha8 and indeed the seek function still not working properly with Android MediaPlayer, but it works with ExoPlayer.
Sample Code
I tested it with three different videos (one local file and two from Internet).
Click to expand
Default behavior
Android MediaPlayer (imprecise seek)
video_2020-12-29_21-14-58.mp4
ExoPlayer (seek seems to be working fine)
video_2020-12-29_21-04-12.mp4
Fix for Android MediaPlayer
Currently, this lib use seekTo without mode param and I played around the other modes available and the one that seeked properly was SEEK_CLOSEST (pay attention to its description).
So the change done was in android/src/main/java/com/brentvatne/react/ReactVideoView.java on the line 640:
- super.seekTo(msec);
+ super.mMediaPlayer.seekTo(msec, MediaPlayer.SEEK_CLOSEST);

I'm aware that's not look too to access a super class member attribute, but we just have access to the seekTo method with a single parameter.
Here is the same sample as above with the fix.
video_2020-12-29_21-04-15.mp4

Yeah @kaioduarte, just to add on to your nice workaround. I noticed that there already exists a separate mMediaPlayer object in ReactVideoView.java, so we could write:
mMediaPlayer.seekTo(msec,3); // 3 or MediaPlayer.SEEK_CLOSEST
instead of accessing from the super class.

Do we have same solution in iOS?


Don't Merge! PR real time test for target branch full build

OPS Build status updates of commit 58d2f27:
:clock10: Full build: the average full build time is 6 min(s) 8 sec(s), this is based on the last 237 build(s) for this repository.
:warning: This is a FULL build due to the 'pr-basebranch' branch had a configuration change, normally no action is required on your part. In the result that you find subsequent builds still performing full builds, please contact your repository admin to manually perform a full build on the 'pr-basebranch' branch. For more detailed info, please click here.

OPS Build status updates of commit 58d2f27:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


tosca dataset

Hello, could you please share a TOSCA dataset with me? tosca officials seem to have canceled the resource download

Please refer here- https://github.com/niladridutt/Diffusion-3D-Features/issues/4


this may fix #51458

Hi @rebornix,
😭This commit may or may not fix #51458. I cannot yarn install and build VSCode due to vscode-ripgrep installation error. There are too few solutions around and time wasting.
😭Just by looking at code and make sure there isn't a TypeScript linter warning or error. Also unit tests are not written.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: zhangkaiyulw sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


chore(Dashboard): Implement dedicated message for missing dataset

SUMMARY
Implements a dedicated "Missing dataset" message to replace the generic "Unexpected error".
BEFORE

AFTER

TESTING INSTRUCTIONS

Open a Dashboard with a dataset that does not exist
Observe the error message

ADDITIONAL INFORMATION

[x] Has associated issue: Fixes #16938
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

LGTM! Thanks for the improvement!


[TEST][CUDNN] xfail SDPA on pre-Ampere

All tests in test_cudnn_executor.py fail on Volta (and older) GPUs with the following message:
RuntimeError: No valid engine configs for Matmul_MUL_GEN_INDEX_GEN_INDEX_CMP_GE_BINARY_SELECT_Reduction_SUB_EXP_Reduction_LOG_ADD_DIV_Matmul_

This PR simply adds the xfails as CUDNN SDPA requires Ampere+.

cc @mruberry


[BUG] API diagnostics are not being updated on deployment

Release version
V<IP_ADDRESS>
Describe the bug
When deploying an API, the value from the JSON file is being used and the value from the configuration file is being ignored. This is causing deployments to fail if the API has the diagnostic settings enabled. This is the same issue that was reported in #672
Expected behavior
Be able to deploy APIs with diagnostic settings into other environments
Actual behavior
The deployment fails out with error it cannot find the logger ID in that environment
Reproduction Steps
Check the box in the settings of the API to enable diagnostics on the API
Extract the API and ensure it has a diagnostics folder with it
Update the config file to have the diagnostics setting for the environment you are deploying to
Run the publisher and wait for the error

I can confirm it seems that issue still exists in newest release

This issue is also blocking is from upgrading to APIOps v6

+1 also seeing this


Feature: allow user to disable info fields with flag --disable

I implemented the feature using the package Strum to work with the new InfoFields enum. The package allows iteration over enums and creates static str for each value in the enum essentially allowing us to create a vector of selected values from the enum (less code). In this case, I hid a enum value UnrecognizedField as the end user should not see that value in the output of possible values. That value is used to filter out the default value which is an empty string allowing all info fields to be shown.
Use:
Overrides showing the dominant language ascii logo
--disable <disable_field>...         Disable fields to show
                                     Possible values: ["project", "head", "version", "created", "languages",
                                     "authors", "last_change", "repo", "commits", "lines_of_code", "size",
                                     "license"]`

Examples:

Flag used with no value provided, defaults to showing all info

Flag used with unrecognized field, CLI errors out

Flag used with recognized field, shows all info except that field

Flag used with multiple recognized fields in different cases, shows all info except those fields

Flag used with languages, shows all info except languages and ASCII logo still shows

Flag used with recognized and unrecognized fields, CLI errors out

Flag used with all recognized fields, no info shows

Addresses issue #73.

Actually, I realized I could simplify the code a bit more by removing the default value for --disable which fully utilizes the conditional assignment to disable_fields variable. Since there's no use for UnrecognizedField value in the enum anymore, I can just use EnumVariantNames which implements variants method on the enum and returns an array of &'static str of values from the enum. The behaviour is still the same as above except case 1 now errors out as shown:

Very Impressive @ktsuench,
Still, I think It would be a better user experience, if the program would not fail if the info name(s) inputed by the user is either missing or not included in the possible values.

Case 1: onefetch --disable created head not_a_valid_input repo --> doesn't fail and shows all info names except head created and repo
Case 2: onefetch --disable -->  doesn't fail and shows all info names
Case 3: onefetch --disable not_a_valid_input  -->  doesn't fail and shows all info names

What do you think ?

I agree with you on that. Using my first solution we could do that by removing the set of possible values and just have unrecognized values fall back to UnrecognizedField which will get filtered out.

Reverted my last commit and updated to allow any value but values are checked afterwards.

Flag used with no value provided, defaults to showing all info

Flag used with unrecognized field, defaults to showing all info

Flag used with recognized and unrecognized fields, ignores unrecognized fields and hides recognized ones


Stabilizing eden integration tests

This PR contains 3 commits that are addressing at least some issues that we are frequently seeing in the eden integration testing.
Make domainmgr skip DNS with empty DPCKey
Do not activate PhysicalIOAdapterList subscription until NIM receives
a DPC and publishes corresponding DNS.
NIM can publish DNS even before it receives first DPC. In such case
DPCKey is empty.
The goal is to avoid assigning network ports to PCIBack if they are going to be
used for management purposes. This way we avoid doing unintended port assignment
to PCIBack that would be shortly followed by a release, therefore mitigating
the risk of race conditions between domainmgr and NIM.
Increase timeout for containerd client connection
This is mostly to address error frequently seen when run eden tests on
(slow) github runners:
Rebooting EVE. Reason: Reboot from agent zedbox[1468] in partition IMGA at EVE version pr3184-kvm-amd64 at 2023-05-02T23:53:59.207011689Z: fatal: agent zedbox[1468]: couldn't initialize containerd (this should not happen): initContainerdClient: could not create containerd client. failed to dial "/run/containerd/containerd.sock": context deadline exceeded: failed to receive server preface within timeout. Exiting.

I have not seen this when running tests locally or when running EVE
on bare-metal devices.
Note that default timeout for containerd client to connect is 10
seconds. Increasing this to 30 seconds should not have any negative
unintended consequences.
Update eden tests
Bring in patches done in the eden repository to address some
unstable eden tests.

The only fail that we caught here is something that I'm aware of but couldn't yet find the root cause.
It is some mysterious reboot that EVE thinks is kernel crash but there is no kdump. Happens fairly often in dev_local_info test.
        === RUN   TestReboot
            reboot_test.go:162: time: 2023-05-14T23:00:56.920564214Z out: Wait for state of 1e7471c7-016d-4cfb-91b3-0428d370159c
            testContext.go:380: done waiting for State
            reboot_test.go:166: time: 2023-05-14T23:00:56.920591815Z out: timewait: 1h40m0s
            reboot_test.go:167: time: 2023-05-14T23:00:56.920598515Z out: reboot: false
            reboot_test.go:168: time: 2023-05-14T23:00:56.920603715Z out: count: 3
            reboot_test.go:172: time: 2023-05-14T23:00:56.920611515Z out: LastRebootTime: 2023-05-14 19:12:29.340669651 +0000 UTC
            reboot_test.go:174: time: 2023-05-14T23:00:56.920617615Z out: LastRebootReason: NORMAL: First boot of device - at 2023-05-14T19:12:29.340669651Z
        rebooted with reason NORMAL: controller reboot at EVE version 0.0.0-pr3208-c0d54d46-kvm-amd64 at 2023-05-14T23:15:50.070481583Z
         at 2023-05-14 23:15:50.149733256 +0000 UTC/nrebooted with reason NORMAL: local profile server power off at EVE version 0.0.0-pr3208-c0d54d46-kvm-amd64 at 2023-05-14T23:27:34.443011196Z
         at 2023-05-14 23:27:34.964623967 +0000 UTC/nrebooted with reason Reboot reason - kernel crash (no kdump) - at 2023-05-14T23:40:08.888905598Z at 2023-05-14 23:40:08.888905598 +0000 UTC/n    testProc.go:84: time: 2023-05-14T23:41:33.675024866Z out: projects.ProcInfoFunc done with return: abnormal reboot: Reboot reason - kernel crash (no kdump) - at 2023-05-14T23:40:08.888905598Z
            testContext.go:271: done for device 1e7471c7-016d-4cfb-91b3-0428d370159c
            reboot_test.go:186: time: 2023-05-14T23:41:33.675099367Z out: Number of reboots: 2

        --- PASS: TestReboot (2436.75s)
        PASS
        [stderr]
        time="2023-05-14T23:41:33Z" level=info msg="time: 2023-05-14T23:41:33.675024866Z out: projects.ProcInfoFunc done with return: abnormal reboot: Reboot reason - kernel crash (no kdump) - at 2023-05-14T23:40:08.888905598Z"


mining progress is reset with mending

when mining with mending and collecting experience the mining progress keeps resetting until all xp has been collected. this seems to be more noticeable with faster mining speeds, because you have to let your hammer finish repairing to continue mining

Spent some time poking into this, and it turns out it's actually a vanilla issue! My guess is NBT updating is preventing you from breaking stuff. Here's a demo: https://streamable.com/quky3i
I might try to make a patch mod for this in a few days.

Relates to MC-176559

Ahh, so it's Mending that does it? It's been driving me nuts.


Upload sdist to PyPI

I'm looking to get thop onto conda-forge using grayskull, but that relies on an sdist being available for thop on PyPI (which is currently not the case).
Fixes #203.

I'm joining the crowd waiting for sdist on pypi


Smarter deploy:unlock

Q
A

Issue Type
Feature Request

Deployer Version
Next

Local Machine OS
N/A

Remote Machine OS
N/A

Description
Run deploy:unlock on failure only if it was locked before.

No need in this feature any more.


Fix for invalid parameter names.

Fixes #2783
Microsoft Reviewers: Open in CodeFlow

This doesn't cover setting the values directly into the dictionary.

No, it doesn't. We would need to either sub-class Dictionary<K, T> for that or perhaps add the following methods to the class and not expose the underlying dictionary. We'd need SetParameter(...), GetParameter(key)andGetParameters()`.


Lots of Warnings after upgrading react-native version 0.76.3

Description
After upgrading expo from version 51 to 52, which requires upgrading react-native to version 0.76.3. When I open the app, a lot of warnings are displayed, making the app seem to hang for a while. This error comes from the react-native library

Steps to reproduce

Install react-native version 0.76.3
Run app

React Native Version
0.76.3
Output of npx react-native info
System:
  OS: Windows 10 10.0.19045
  CPU: (8) x64 12th Gen Intel(R) Core(TM) i3-12100
  Memory: 1.27 GB / 15.72 GB
Binaries:
  Node:
    version: 20.10.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
  Yarn:
    version: 1.22.22
    version: 1.22.22
    path: ~\AppData\Roaming\npm\yarn.CMD
    path: ~\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 10.2.3
  npm:
    version: 10.2.3
    version: 10.2.3
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
  Watchman: Not Found
SDKs:
SDKs:
  Android SDK: Not Found
  Android SDK: Not Found
  Windows SDK: Not Found
  Windows SDK: Not Found
IDEs:
IDEs:
  Android Studio: AI-233.14808.21.2331.11709847
  Visual Studio: Not Found
Languages:
  Java:
    version: 19.0.1
    path: /c/Program Files/Common Files/Oracle/Java/javapath/javac
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli":
    installed: 15.1.2
    wanted: ^15.1.2
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.3
    wanted: 0.76.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

info React Native v0.76.5 is now available (your project is running on v0.76.3).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.76.5
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.76.3&to=0.76.5
info For more info, check out "https://reactnative.dev/docs/upgrading?os=windows".

Screenshots and Videos

I upgraded to the latest version of React-native but still having the same problem

This doesn't happen on a empty project.

Install react-native version 0.76.3
Run app

Please provide a valid reproducer

This is a company project and I cannot provide further information. My problem was after I upgraded expo from version 51 to 52, which required updating version of react native.  My problem was after I upgraded expo from version 51 to 52, which required updating version of react native. Specifically, my package.json file looks like this:

Then please

use this template: https://github.com/react-native-community/reproducer-react-native
add all your dependencies
make sure you can recreate the same error you're seeing
share it here

Does the error in the app, or error in RN DevTools show more context? The end of the warning in the screenshot started saying "Component stack", and that's the thing that would point to what code or library is causing this error.

Thank for reply. I detected the isssue. It's from react-native-drax library. This lib was quite old

This is a company project and I cannot provide further information. My problem was after I upgraded expo from version 51 to 52, which required updating version of react native. Specifically, my package.json file looks like this:

Then please

use this template: https://github.com/react-native-community/reproducer-react-native
add all your dependencies
make sure you can recreate the same error you're seeing
share it here

Thank for reply. I detected the isssue. It's from react-native-drax library. This lib was quite old

Thank for reply. I detected the isssue. It's from react-native-drax library. This lib was quite old

Closing as per this last comment


[minor] please round 2 pressure tyre

may you round 2 tyre pressure, so have like 2,61bar and not 2,6bar
ref: https://github.com/msp1974/homeassistant-jlrincontrol/blob/1f9dbbb7d6c5c0fc2b44694fb10669413caac8d5/custom_components/jlrincontrol/sensor.py#L152
and line 160.
tnx

Will add to next release

v2.0.0beta released via HACs which fixes this issue.  Please can you test and let me know.

good. tnx


unfreeze scalafix (and scalameta and scalapb and jackson-module-scala)

now that we are on latest scalafmt, we should try to do the same for scalafix
this will be more fun than having a family of ferrets in your pants, for sure

test run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/2989/consoleFull (404 for now)

hmm, there is a scalapb compilation error where it seems to not be picking up the right Scala-version-specific source directory. surely some trivial thing. I'll come back to it

let's check the current status. queued: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/3044/ (404 for now)

Tell us, run 3044! Where did you go? What did you see?
[info] >>> The dbuild result is----------------: FAILED (failed: scalatest-tests, lagom, scalapb)

the scalatest-tests and lagom failures are presumably intermittent/unrelated.
but scalapb failing took out the downstream projects we were interested in.
and scalapb failed because I made a silly mistake in extra.commands
try again: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/3047/ (404 for now)

scalapb is green now.
I had to add more scalameta subprojects that scalafix and/or scalafmt now need.
one of the newly added scalameta subprojects uses geny, but it needs an older version, geny master has a source-incompatible change.
currently trying freezing geny at the older version. if that works, great. (but if it breaks something else, I should probably submit a scalameta PR upgrading the new version.)

@olafurpg seems likely I'll succeed here. however, I still have separate metaconfig_old and metaconfig_new spaces in dbuild since scalafix and scalafmt are on different metaconfig versions. would it be difficult to get them both onto v0.8.x?

Hmm, I should be able to have them use the same metaconfig version. I will look into it in the coming days.

the ferret family has been evicted

fyi @thesamet on scalapb (P.S. very nice talk at Scala Days NYC!)

this needs one little bit of extra work, semanticdb-sbt is failing, we probably just need to refresh our fork

semanticdb-sbt is no longer a dependency of scalafix, the project had been archived and is no longer under development.


[Mono] change function names to PascalCase and set abstract classes as abstract

The first part of the PR addresses #17212, there should not be any snake_case named functions in the API.
Second part is to avoid #17121 and similar issues. Now that abstract classes are really abstract, intellisense will raise an error when trying to instantiate one.
Here's the list of classes that have been made abstract.

Can you squash the first and last commit together?
Also, please modify the BINDINGS_GENERATOR_VERSION constant at the top, because the bindings generator output changed as well.
Thanks :)

Ah, here it is! Felt weird to only have a version in the cs_files/ folder.

Cherry picked into 3.0.3


Deprecate *LinkedNodesHierarchy queries

Background
The current getLinkedNodeHierarchy and batchGetLinkedNodeHierarchy GraphQL queries are the main way the frontend adds resources to a diagram. getLinkedNodeHierarchy takes as its input an id (the backend uses ARNs as ids in Neptune) and finds the first order relationships (plus second order relationships that are VPCs or subnets) of the resource associated with that id and returns them to the client in a hierarchical data structure. This data structure is based off account/region/vpc/availability zone/subnet as shown. batchGetLinkedNodeHierarchy accepts a list of ids and uses the same code as getLinkedNodeHierarchy to return multiple hierarchies thus reducing the number of calls the frontend needs to make to retrieve multiple resource relationships.
Issue:
The hierarchy these APIs produces is very verbose, meaning that when using the batchGetLinkedNodeHierarchy query, results can exceed the Lambda payload limit when a large number (50-100) of ids are sent to the backend or if a resource being added has a large number of children (e.g., a VPC).
Proposal
Backend
We should introduce a new GraphQL query called getResourceGraph that takes a list of IDs as an input and returns a list of the resources and a list of the relationships between them and deprecate the getLinkedNodeHierarchy/batchGetLinkedNodeHierarchy queries.
Frontend
Returning a list of nodes and edges like this allows us to paginate the query, reducing the chances of encountering the lambda payload too large error. The client can make a request with a reasonable page size and stop paging once both the nodes and edges lists are empty. If the client encounters the payload too large error it could retry the request with the page size halved as we do in the Discovery process:
https://github.com/aws-solutions/workload-discovery-on-aws/blob/1bcf4a5e23dfeb8cf6e8e89cb5fe3bfe978dc499/source/backend/discovery/src/lib/apiClient/appSync.js#L62-L87

This was done in v2.1.0.


Fix NPE in Kafka Streams binder

Fix NPE when user provided consumer properties are missing in kafka streams binder
Resolves #343

@artembilan i had that with new initially, but then there is no need for that as I can get by without creating that object. Basically, if the user doesn't provide a consumer property, there isn't really a need for that as we can infer the information through other means. But if you insist, I will switch to using new.  I will make a test.

Well, there must be some consistency though.
If we open, for example KafkaExtendedBindingProperties, it is similar to the mentioned BindingServiceProperties:
@ConfigurationProperties("spring.cloud.stream.kafka")
public class KafkaExtendedBindingProperties
		implements ExtendedBindingProperties<KafkaConsumerProperties, KafkaProducerProperties> {

private Map<String, KafkaBindingProperties> bindings = new HashMap<>();

Then when we jump into that KafkaBindingProperties, will see this:
private KafkaConsumerProperties consumer = new KafkaConsumerProperties();

private KafkaProducerProperties producer = new KafkaProducerProperties();

So, why here we have a new, but you insist that we should not in the BindingServiceProperties?
My apologies that I am so nasty, but I can't merge a fix without some ground of explanation and without understanding why do we have it from the first place at all.
Also an interesting observation: on the BindingServiceProperties we have this API:
public ConsumerProperties getConsumerProperties(String inputBindingName) {

Which protects us from this NPE as well:
ConsumerProperties consumerProperties = bindingProperties.getConsumer();
if (consumerProperties == null) {
	consumerProperties = new ConsumerProperties();
	bindingProperties.setConsumer(consumerProperties);
}

So, meanwhile we try to come up with the middle ground for the new or not new subject, I would suggest do not use getConsumer()/getProducer() API at all.
My main point that I know it is about configuration properties, so Spring Boot will provide it for me this or other way without null. But that's not true in this case. Therefore for confuse with consistency.

@artembilan I will use BindingServiceProperties.getConsumerProperties(...) as that seems to be a compromise here.

OK. I agree with that as state for the current code base.
Nevertheless are you going to raise an issue against Core to revise that BindingProperties for consumer/producer properties with new ?
Thanks

@sobychacko ,
I missed to ask: do we backport this into the 1.3.x branch ?

@artembilan No need to backport. Kafka streams binder has significantly changed in 2.0 and it doesn't make much sense to backport.


Submit a Cloud Definition - Docker

Word [REQUIRED]: docker
Content [REQUIRED]: Docker is an open-source platform for automating application deployment, scaling, and management as containers. Containers are executable packages that include everything needed to run a piece of software, including the code, runtime, libraries, environment variables, and more.
Author Name [REQUIRED]: Rishab Kumar
Author Link [REQUIRED]: https://twitter.com/rishabk7
Learn More URL [REQUIRED]: https://docs.docker.com/get-started/overview/
Category [REQUIRED, select one]: devops
Abbreviation [OPTIONAL]: If the word is commonly abbreviated, please provide it. For example, command line interface is often abbreviated as CLI.

Thank you! added.


Docs(web-twig): Demonstrate composition of Header with Dropdown

Description
Demonstrate the composition of Header and Dropdown.
Additional context

Issue reference
N/A

👏 Great. But consider usage of the button instead of the link for dropdown trigger :-)

coverage: 96.46%. remained the same when pulling 8aaf9007b76368b7e7791092787117c6231ee224 on docs/header-with-dropdown into cce1910a1cd7d67538815d647a60e23f022a122d on main.

Closing because we are already working on a new Header component.


transpile sql between dialects

implement the bot.transpile_sql (currently called translate_sql, recommend renaming) method likely just using SQLGlot directly
takes a SQL string as input. along w/ #53, good motivation for better attachment methods (get last SQL Attachment, get a SQL attachment by some input text, etc.)

was resolved by https://github.com/ibis-project/ibis-birdbrain/pull/58


Implemented previous method for occurrence

Added prev implementation for occurrence.
It is now possible to get previous datetime based on the cron.
prev_dt = cron.occurrence(dt).prev()

It needs more work. Will raise once completed.


Any method to read excel cell comments content?

excel cell comments or cell annotation

It's on my To-Do list. Maybe January :)


Parse error on non typed types

First off, thanks for the package. I've been evaluating it and I think it can work for me, which would save me a ton of time.
I'm running into a few issues, though, and this seems related to #27 since I was able to use the same workaround, but this fails to parse:
// UserProfile represents the user profile
type UserProfile struct {
	ID          int32             `json:"id"`
	Email       string            `json:"email"`
	Name        null.Val[string]  `json:"name"`
	Phone       null.Val[string]  `json:"phone"`
	Avatar      null.Val[string]  `json:"avatar"`
	Roles       []rbac.Role       `json:"roles"`
	Permissions []rbac.Permission `json:"permissions"`
}

But updating it to this, it parses fine:
type roles []rbac.Role
type permissions []rbac.Permission
type nullstring null.Val[string]

// UserProfile represents the user profile
type UserProfile struct {
	ID          int32       `json:"id"`
	Email       string      `json:"email"`
	Name        nullstring  `json:"name"`
	Phone       nullstring  `json:"phone"`
	Avatar      nullstring  `json:"avatar"`
	Roles       roles       `json:"roles"`
	Permissions permissions `json:"permissions"`
}

Unfortunately, refactoring to use typed values like this won't work for me since I have a bunch of generated models.

hi, thanks for the report. gonna check it out

fixed?


python3.8-hdlparse: Init at 1.0.4

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

please squash all the commits, should be two:
Please make this into a separate commit:
maintainers: add elliottvillars
python3Packages.hdlparse: init at 1.0.4


How to get the example status in after (:suite)

How to get the example status(faled/passed/skipped) in after (:suite).
I tried with custom formatters. but could not able to do it.  I want to use the example status in after (:suite). Please let me know how can I configure it

This should be available in a custom formatter by defining example_failed/example_passed/example_pending methods. Can you please provide some example of your custom formatter?

This is my custom formatter, I am able to print the value in custom formatter as shown beow:
class StatusFormatter
RSpec::Core::Formatters.register self, :example_passed, :example_pending, :example_failed
def initialize(out)
@out = out
end
def failedcount
@out.length
end
def example_finished(notification)
example = notification.example
result = example.execution_result
stat = result.status
if stat === 'failed'
p "status is #{stat}"
@out<< stat
end
end
alias example_passed example_finished
alias example_pending example_finished
alias example_failed example_finished
end
RSpec.configure do |config|
config.add_formatter StatusFormatter
.
.
.
.
etc
config.after(:suite) do
out=Array.new
count= StatusFormatter.new(out).failedcount
p "execution_result:#{count}"
end
end
Here I want the status and number of failures inside after(:suite) method. Please help me and let me know if still needed any details.

Fromatter protocol docs are pretty good, you may want to check them out.
Think of a formatter as something that accumulates data. Its methods are called when events happen, e.g. an example fails.
But since you only need counts, this is already provided by SummaryNotification passed to formatter's dump_summary.
So, your formatter should look like:
class StatusFormatter
  RSpec::Core::Formatters.register self, :dump_summary

  def initialize(output)
    @output = output
  end

  def dump_summary(summary)
    @out << "failed: #{summary.failed_count}"
    @out << "pending: #{summary.pending_count}"
    @out << "total: #{summary.example_count}"
  end
end

You don't need a config.after(:suite) to output the results, but still need to add it:
config.add_formatter StatusFormatter

Hope that helps.

I am doing some activity in after(:suite) based on the failed count.so I
need it in after(:suite).please let me know how can I get formatter's
methods/ variables in my after(:suite)
On Wed, May 22, 2019, 17:23 Phil Pirozhkov<EMAIL_ADDRESS>wrote:

Fromatter protocol docs
http://rspec.info/documentation/3.8/rspec-core/RSpec/Core/Formatters/Protocol.html
are pretty good, you may want to check them out.
Think of a formatter as something that accumulates data. Its methods are
called when events happen, e.g. an example fails.
But since you only need counts, this is already provided by
SummaryNotification
http://rspec.info/documentation/3.8/rspec-core/RSpec/Core/Notifications/SummaryNotification.html
passed to formatter's dump_summary
http://rspec.info/documentation/3.8/rspec-core/RSpec/Core/Formatters/Protocol.html#dump_summary-instance_method
.
So, your formatter should look like:
class StatusFormatter
RSpec::Core::Formatters.register self, :dump_summary
def initialize(output)
@output = output
end
def dump_summary(summary)
@out << "failed: #{summary.failed_count}"
@out << "pending: #{summary.pending_count}"
@out << "total: #{summary.example_count}"
end
end
You don't need a config.after(:suite) to output the results, but still
need to add it:
config.add_formatter StatusFormatter
Hope that helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rspec/rspec-core/issues/2626?email_source=notifications&email_token=ADLGCKCYZGRFRWBVUWQYP6TPWUX37A5CNFSM4HOLFDV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV6ZSNQ#issuecomment-494770486,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLGCKB4SX7EY6NLFEYOOVTPWUX37ANCNFSM4HOLFDVQ
.

Can you provide more details on what you are doing exactly in after?

Hi, I am trying to use headless gem where I am recording a video and saving
the video in after(:suite) if the failure happens otherwise do not save and
just discard the recorded video. So I required failed count in
after(:suite).
Headless gem: https://github.com/leonid-shevtsov/headless
$headless_server_video.stop_and_save("#{tests_to_run}.mp4")
where stop_and_save is a method in headless gem to save the video.
Let me know if you need any further information
On Wed, May 22, 2019, 18:44 Phil Pirozhkov<EMAIL_ADDRESS>wrote:

Can you provide more details on what you are doing exactly in after?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rspec/rspec-core/issues/2626?email_source=notifications&email_token=ADLGCKDS4AWVIEBYK5ATI7TPWVBNFA5CNFSM4HOLFDV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV7AAQQ#issuecomment-494796866,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLGCKD6KPRXWPAUFZTPCGTPWVBNFANCNFSM4HOLFDVQ
.

You can do your stop_and_save in the formatters hook instead...

I don't think this is a rspec-core issue but some help to properly use a formatter. I think we can close the issue but keep having a discussion if need more help @Tejareddy1


add new favicons

resolve https://github.com/codeigniter4projects/website/issues/303

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.923%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
220

Relevant Lines:
286

💛  - Coveralls