socketLB.enabled can't take effect with false

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
with the helm chart, we can see the socketLB.enabled with the default value is false. but once deploy done:
why the helm chart and cilium status --verbose mismatch?
helm install cilium cilium/cilium --set k8sServiceHost=$controller_node_ip --set k8sServicePort=6443 --version 1.14.0-rc.0 --namespace kube-system --set debug.enabled=true --set debug.verbose=datapath --set monitorAggregation=none --set ipam.mode=cluster-pool --set cluster.name=cilium-kubeproxy-replacement --set kubeProxyReplacement=true --set tunnel=disabled --set autoDirectNodeRoutes=true --set ipv4NativeRoutingCIDR="<IP_ADDRESS>/8"

root@2204:~/wcni-kind/split/cilium/cilium-kubeproxy-replacement/1-direct-routing# kk exec -ti ds/cilium -- cilium status --verbose
Defaulted container "cilium-agent" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), clean-cilium-state (init), install-cni-binaries (init)
KVStore:                Ok   Disabled
Kubernetes:             Ok   1.27 (v1.27.3) [linux/amd64]
Kubernetes APIs:        ["EndpointSliceOrEndpoint", "cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "cilium/v2alpha1::CiliumCIDRGroup", "core/v1::Namespace", "core/v1::Pods", "core/v1::Service", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement:   True   [eth0 <IP_ADDRESS> (Direct Routing)]
Host firewall:          Disabled
CNI Chaining:           none
Cilium:                 Ok   1.14.0-rc.0 (v1.14.0-rc.0-08239f59)
NodeMonitor:            Listening for events on 12 CPUs with 64x4096 of shared memory
Cilium health daemon:   Ok
IPAM:                   IPv4: 5/254 allocated from <IP_ADDRESS>/24,
Allocated addresses:
  <IP_ADDRESS> (router)
  <IP_ADDRESS> (kube-system/coredns-5d78c9869d-v75lg)
  <IP_ADDRESS> (kube-system/coredns-5d78c9869d-xq99b)
  <IP_ADDRESS> (health)
  <IP_ADDRESS> (local-path-storage/local-path-provisioner-6bc4bddd6b-5qnbk)
IPv4 BIG TCP:           Disabled
IPv6 BIG TCP:           Disabled
BandwidthManager:       Disabled
Host Routing:           Legacy
Masquerading:           IPTables [IPv4: Enabled, IPv6: Disabled]
Clock Source for BPF:   jiffies   [250 Hz]
Proxy Status:            OK, ip <IP_ADDRESS>, 0 redirects active on ports 10000-20000, Envoy: embedded
Global Identity Range:   min 256, max 65535
Hubble:                  Ok   Current/Max Flows: 2515/4095 (61.42%), Flows/s: 11.70   Metrics: Disabled
KubeProxyReplacement Details:
  Status:                 True
  Socket LB:              Enabled      ## enable
  Socket LB Tracing:      Enabled  ## enable
  Socket LB Coverage:     Full
  Devices:                eth0 <IP_ADDRESS> (Direct Routing)
  Mode:                   SNAT
  Backend Selection:      Random
  Session Affinity:       Enabled
  Graceful Termination:   Enabled
  NAT46/64 Support:       Disabled
  XDP Acceleration:       Disabled

Cilium Version
1.14.0-rc.0
Kernel Version
root@2204:~/wcni-kind/split/cilium/cilium-kubeproxy-replacement/1-direct-routing# dip
NAME                                         STATUS   ROLES           AGE     VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                         KERNEL-VERSION      CONTAINER-RUNTIME
cilium-kubeproxy-replacement-control-plane   Ready    control-plane   3m22s   v1.27.3   <IP_ADDRESS>    <none>        Debian GNU/Linux 11 (bullseye)   5.19.0-46-generic   containerd://1.7.1
cilium-kubeproxy-replacement-worker          Ready    <none>          3m3s    v1.27.3   <IP_ADDRESS>    <none>        Debian GNU/Linux 11 (bullseye)   5.19.0-46-generic   containerd://1.7.1
cilium-kubeproxy-replacement-worker2         Ready    <none>          3m2s    v1.27.3   <IP_ADDRESS>    <none>        Debian GNU/Linux 11 (bullseye)   5.19.0-46-generic   containerd://1.7.1
root@2204:~/wcni-kind/split/cilium/cilium-kubeproxy-replacement/1-direct-routing#

Kubernetes Version
root@2204:~/wcni-kind/split/cilium/cilium-kubeproxy-replacement/1-direct-routing# dip
NAME                                         STATUS   ROLES           AGE     VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                         KERNEL-VERSION      CONTAINER-RUNTIME
cilium-kubeproxy-replacement-control-plane   Ready    control-plane   3m22s   v1.27.3   <IP_ADDRESS>    <none>        Debian GNU/Linux 11 (bullseye)   5.19.0-46-generic   containerd://1.7.1
cilium-kubeproxy-replacement-worker          Ready    <none>          3m3s    v1.27.3   <IP_ADDRESS>    <none>        Debian GNU/Linux 11 (bullseye)   5.19.0-46-generic   containerd://1.7.1
cilium-kubeproxy-replacement-worker2         Ready    <none>          3m2s    v1.27.3   <IP_ADDRESS>    <none>        Debian GNU/Linux 11 (bullseye)   5.19.0-46-generic   containerd://1.7.1
root@2204:~/wcni-kind/split/cilium/cilium-kubeproxy-replacement/1-direct-routing#

Sysdump
cilium-sysdump-20230711-094644.zip
Relevant log output
N/A

Anything else?
N/A
Code of Conduct

[X] I agree to follow this project's Code of Conduct

:wave: as you have --set kubeProxyReplacement=true, I believe this part in the upgrade guide applies:

The kube-proxy-replacement option’s values strict, partial and disabled are deprecated and will be removed in v1.15. They are replaced by true and false. true corresponds to strict, i.e. enables all kube-proxy replacement features. false disables kube-proxy replacement but allows users to selectively enable each kube-proxy replacement feature individually.

👋 as you have --set kubeProxyReplacement=true, I believe this part in the upgrade guide applies:

The kube-proxy-replacement option’s values strict, partial and disabled are deprecated and will be removed in v1.15. They are replaced by true and false. true corresponds to strict, i.e. enables all kube-proxy replacement features. false disables kube-proxy replacement but allows users to selectively enable each kube-proxy replacement feature individually.

that means if with kpr, the socketLB will be enabled always, rt?

Thanks a lot.


Disable minting with LSTs

Changes:

Disables minting with LSTs

Adds a new _mint internal method, since super.mint() won't be possible because it's external and also will have to remove nonReentrant modifier from the inherited contract

Removes payable from fallback() since neither VaultCore or VaultAdmin have a receive() method and we don't expect the Vault to hold ETH directly either

Deployment:

OETHVaultCore implementation (upgraded): 0x9535413B1B9862D0123A36F55e9bf20EBA4b152e
Deployer: 0x58890a9cb27586e83cb51d2d26bbe18a1a647245

Governance Proposal:

Proposal ID:<PHONE_NUMBER>1051679346398237778682113450913991391551128830137727748559915078301
Proposal Tx: 0xbfdd55ea8376042a6899c9df47ce0e62a7308cb62b48b89c6e9832d16183aea0
Proposer: 0x6a6D776120f7e4a8dba5F6bF49b85cb340Cfe241

If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist:

[ ] Code reviewed by 2 reviewers.
[ ] Copy & paste code review security checklist below this checklist.
[ ] Unit tests pass
[ ] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

I've verified that:
✅  the governance proposal with id 72....8301 matches the deploy script
✅ OETH vaultCore is upgraded to the new implementation
✅ The published code of the new implementation matches the one in this PR

Deploy review:

[x] All deployed contracts are listed in the deploy PR's description
[x] Deployed contract's verified code (and all dependencies) match the code in master
[x] The transactions that interacted with the newly deployed contract match the deploy script.
[x] Governance proposal matches the deploy script
[ ] Smoke tests pass after fork test execution of the governance proposal (will do as a part of code review)

Smoke fork tests check out.
from world import *
NEW_IMPL = "0x9535413b1b9862d0123a36f55e9bf20eba4b152e"
VAULT_CORE_PROXY = "0x39254033945AA2E4809Cc2977E7087BEE48bd7Ab"
proxy = Contract.from_explorer(VAULT_CORE_PROXY, as_proxy_for=VAULT_CORE_PROXY)
proxy.upgradeTo(NEW_IMPL, {'from': TIMELOCK})

WETH_WHALE = "0x2fEb1512183545f48f6b9C5b4EbfCaF49CfCa6F3"
weth.approve(oeth_vault_core, 1e70, {'from': WETH_WHALE})
oeth_vault_core.mint(WETH, 1e18, 1e18, {'from': WETH_WHALE})
print(oeth.balanceOf(WETH_WHALE))
print(oeth.balanceOf(WETH_WHALE) / 1e18)

STETH_BAGS = "0x5fEC2f34D80ED82370F733043B6A536d7e9D7f8d"
steth.approve(oeth_vault_core, 1e70, {'from': STETH_BAGS})
oeth_vault_core.mint(steth, 1e18, 0, {'from': STETH_BAGS})

oeth_vault_core.redeemAll(0, {'from': WETH_WHALE})


Lack of easy way to append to text files.

After reading though https://github.com/lunduniversity/introprog/issues/782 I think that some of the issues associated with Bank's saving and loading could be addressed by introducing a method that lets the user easily append to text files (since it might feel natural to do so in doEvent.)
I propose that a method be added for appending lines.

Thanks for contributing! For completeness there should also be an appendString method that appends a string, similar to how saveLines also has a counterpart saveString.
Ideally this would use the underlying appendability in java.io, see e.g. https://stackoverflow.com/a/24982850
See also https://github.com/lunduniversity/introprog-scalalib/issues/47

@trilleplay You may want to see the correct implementation here to handle both empty seq and trailing newline: https://github.com/lunduniversity/introprog-scalalib/commit/482dcceaa4395504f4b10d9551391874ac313264

I have also added some tests: https://github.com/lunduniversity/introprog-scalalib/commit/c80904a2da4899c33d66449eac5e1dc4a01ccec6


fix(questions route): add black class to mobile nav button

Fixes: #531
From the figma, I think this colour should be cool grey 900

But from the css, cool-grey-900 is defined to be the same as black. And as we have a class for black but no class for cool grey 900, I figured I would go ahead with adding the black class.
I tested fix on safari on Iphone (where I was able to reproduce this error previously).

@jrhender thanks! I think we do have a class for both, though. The engineers added black because they were confused by cool grey 900 so I let it fly lol.


Upgrade/Install PHP7x on older version of OSX with Homebrew

Steps to upgrade
brew tap homebrew/dupes
brew tap homebrew/versions
brew tap homebrew/homebrew-php
brew unlink php5x
brew install php7x

If you are able to unlink the older version of PHP, check if there is a symbolic link named for the older version:
ls -la /usr/local/php*
unlink the older version
sudo unlink /usr/local/php5*
sudo rm -rf /usr/local/php5*-*

Create a symbolic link for PHP7x
cd /usr/local
ln -s <source-file> <new-symbolic>

e.g.
ln -s /usr/local/opt/php7x php7x

Update $PATH variable for php7x in .bash_profile using vim.  To ensure you are using the brew version, by placing /usr/local/bin before /usr/sbin in your PATH:
PATH="/usr/local/bin:$PATH" or replace manually
Restart the service
sudo apachectl restart

✩✩✩✩ Extensions ✩✩✩✩
If you are having issues with custom extension compiling, ensure that you are using the brew version, by placing /usr/local/bin before /usr/sbin in your PATH:
  PATH="/usr/local/bin:$PATH"

PHP70 Extensions will always be compiled against this PHP. Please install them using --without-homebrew-php to enable compiling against system PHP.
✩✩✩✩ PHP CLI ✩✩✩✩
If you wish to swap the PHP you use on the command line, you should add the following to ~/.bashrc, ~/.zshrc, ~/.profile or your shell's equivalent configuration file:
export PATH="$(brew --prefix homebrew/php/php70)/bin:$PATH"
✩✩✩✩ FPM ✩✩✩✩
To launch php-fpm on startup:
mkdir -p ~/Library/LaunchAgents
cp /usr/local/opt/php70/homebrew.mxcl.php70.plist ~/Library/LaunchAgents/
launchctl load -w ~/Library/LaunchAgents/homebrew.mxcl.php70.plist
The control script is located at /usr/local/opt/php70/sbin/php70-fpm
OS X 10.8 and newer come with php-fpm pre-installed, to ensure you are using the brew version you need to make sure /usr/local/sbin is before /usr/sbin in your PATH:
PATH="/usr/local/sbin:$PATH"
You may also need to edit the plist to use the correct "UserName".
Please note that the plist was called 'homebrew-php.josegonzalez.php70.plist' in old versions of this formula.
With the release of macOS Sierra the Apache module is now not built by default. If you want to build it on your system you have to install php with the --with-httpd24 option. See  brew options php70 for more details.


Inventory api mocks

fixes #30
@dfaulken might want to look as these mocks to see if they conform to his api

lots of code climate issues, should probably correct those

oh woops
i accidently the pull request

adding tests, but for now this should help with building the code that relies on this

Our README is current, so if this matches that, then it's fine. I'm not sure that an ActiveRecord model is necessarily the best way to go about mocking an API, but that's a decision for your team to make.

@dfaulken being an active record was an accident (force of habit i suppose).  Its just a plain old model.  Is it to early to know the final resting point for the production api?

At this point it's only going to change if you all need it to.


Troubleshooting .spi.yml

Hello, I'm a fan and user of SPI as well as https://github.com/tgrapperon/swift-dependencies-additions/
I noticed that it has documentation on SPI but it only has the first page. Nothing else. So I raised an issue on his repo.
I also forked it and tried to fix his .spi.yml but everything looks right according to the SPI documentation. I see that there is an included validation executable, however the link appears to be broken on that documentation page.
How can I find out more about how to use this validation executable?

Thanks for reporting this, @DandyLyons .
The best way to verify documentation is via the online checker and Thomas' .spi.yml validates ok.
This seems to be an build/doc gen issue. I can see a missing theme-settings.json file being reported in the console when viewing the docs:

I'll look into this, thanks again for the report!

Looks like this is a red herring, theme-settings.json is also missing for SemanticVersion for example:
[Error] Failed to load resource: the server responded with a status of 404 () (theme-settings.json, line 0)

This is new. 0.3.3 for example has a theme-settings.json file in the bucket, as does 0.3.4. 0.3.5 is the first release without it. According to our GH releases page, 0.3.4 and 0.3.5 were tagged on the same day. So it's unlikely to be related to the move to 5.9 as the doc generator.

I just wanted to generate the docs locally and I found the command for DependenciesAdditions in my shell history. Turns out this is a known issue: 2353. (The situation seems slightly improved but I believe it's still the same underlying issue.)
I'll close this issue then but re-open one regarding the theme-settings.json files.

In case this is relevant to you:
The documentation for swift-dependencies-additions does build on my machine. Not sure if there's a difference between that and DocC preview.
Just mentioning because I think you said it wasn't building locally for you here:
https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/issues/2353#issuecomment-1519991683

Thanks, @DandyLyons !
To clarify: the docs are building ok but the hosted docs look exactly the same as when I generate them locally. So it doesn't seem to be an issue with doc generation in our build system.
Hosted:

Local:

FWIW, the command I used to generate the docs locally is:
swift package --disable-sandbox preview-documentation -p 8080 --target DependenciesAdditions

This is essentially what we're doing in our build system.


Re-open vulnerability (Mitigated to Active) should set Endpoints to Active too

Slack us first!
Details about the bug: https://owasp.slack.com/archives/C2P5BA8MN/p1661952617478849
Be informative
When a vulnerability is re-opened: Inactive, Mitigated to Active , DefectDojo should set the Endpoints from Mitigated to Active too.
Bug description
Endpoints doesn't change the status after the changes of state of a vulnerability (Inactive, Mitigated to Active)
Steps to reproduce
Steps to reproduce the behavior:
When a vulnerability is re-opened: Inactive, Mitigated to Active , DefectDojo doesn't set the Endpoints from Mitigated to Active.
Deduplication = ON
Close old findings = ON
Aug. 28, 2022 - 1º Upload a scan with 2 assets with port 3306 open -> Vulnerability Open Port: 3306/TCP Active
Aug. 29, 2022 - 2º Upload a scan with 1 asset with port 3306 open -> The vulnerability created in step 1 (Aug. 28, 2022) is set to Inactive, Mitigated and the assets is set to Mitigated
New vulnerability created (Aug. 29, 2022) with only 1 vulnerable asset with the vulnerability Active.
Aug. 30, 2022 3º Upload again a scan with 2 assets with port 3306 open (the same scan in the step 1)
It reopens the vulnerability in step 1 (Aug. 28, 2022), marks it as Active but the assets appear as Mitigated
Expected behavior
When a vulnerability is Re-open -> Inactive, Mitigated to Active
The Endpoints should set from Mitigated to Active too.
Deployment method (select with an X)

[X ] Docker Compose
[ ] Kubernetes
[ ] GoDojo

Environment information

Operating System: [Kali 2022.3]
DefectDojo version 2.13.1

Screenshots
https://owasp.slack.com/archives/C2P5BA8MN/p1661952617478849

In my environment, once the finding is set to active and verified, then the endpoint is marked as active again as well.

We have version 2.14.1 and when the vulnerability is reopened (closed to active) only the list of "Mitigated Endpoints / Systems" is displayed, not the list of "Vulnerable Endpoints / Systems".

What happens when you mark the active finding as verified?

The same

@advidsec could you please retest this issue with the latest release if this issue is still open?

I have similar problem on the newest version v. 2.32.3. On the finding (that was reopened) view there is section "Mitigated Endpoints / Systems" it says that endpoint is mitigated but when you click on the endpoint name then you are moved to endpoint view and you see that it is vulnerable and you see the vulnerability you have just moved from on the list.
So it seems that when you reopen vulnerability the endpoints view/sections (inside vulnerability) are not refreshed.


Replace logging abstractions with tracing

AFAICT tracing already provides the kinds of dependency injection that the logger/logging factory/logging factory builder code provides. For consuming applications or libraries it feels unnecessary to wrap tracing in some other logging framework.

Removing logging is a bit more involved if we also go after Reporters in general. The statistics gathering function of SimpleReporter could probably be fulfilled by storing some metrics struct in a tokio Span and updating it where the reporter methods are being invoked.


Buttons in Construction tab do nothing.

Expected Results
Possibly upgrade the respective buildings / show insufficient funds.
Actual Results
Does nothing.

Steps to Reproduce
Go to the Construction tab and click on any of the 3 upgrade buttons.
App Version
0.1
Error Logs
No response
Is there an existing issue for this?

[X] I have searched the existing issues before opening this issue.
[X] I have provided all relevant details regarding this issue.
[X] I have removed my API Key from display, if visible.

Additional Context
No response

Fixed with b3c8a0b


Disable deploy for pull request

Coverage remained the same at 41.592% when pulling 796ae2ecf3576d11b443e0874b35bd99ef801dd3 on features/pull-request-without-deploy into a78de4f0a3d210cf9a8410d658051b898de98fcc on master.


[FancyZones] auto snap feature

Description of the new feature / enhancement
pressing a keycombo, all the opened windows will set into position of the defined fancyZones layout.
In latest version, it is available to set the layout pressing Ctrl + Win + Alt + [0-9] but setting the layout is only half way. The next step is to move every window into position.  Not very productive I think.
Scenario when this would be used?
having to move windows one by one is not nice when talking about productivity , coming from Window Managers like i3 or bspwm, the usual behaviour is to adjust the window to their position the very same moment it is opened.
As a workaround, would be sufficient to place the windows into position pressing a key combination.
Supporting information
No response

Duplicate of #2694


Lint on maxUnavailable in rollingUpdate showing on correct numbers

Issue Type: Bug
Looking at a deployed Deployment YAML file on Kubernetes, with:
maxSurge: 25%
maxUnavailable: 0
I get a lint error on the 0 in maxUnavailable although there shouldn't be:
Incorrect type. Expected "string".
Extension version: 1.0.4
VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:31:32.854Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.98GB free)

Process Argv

Screen Reader
no

VM
0%

Thanks for reporting this.  This looks like a mismatch between the OpenAPI schema reported by the cluster and what RedHat YAML is willing to treat as a string.  I'll investigate further and raise it upstream if necessary.

@shacharSilbert I believe this is due to incorrect handling of the k8s IntOrString type by the Red Hat YAML extension.  I can try to patch this while we request an upstream fix, but at the moment I can't reproduce it in my dev environment.  Can you let me know what OS you're on and the version of the YAML extension you have installed, please?  I'm trying to isolate a repro scenario so I can verify a fix.  Thanks!

@itowlson I'm using MAC with latest
Extension data:
Name: YAML
Id: redhat.vscode-yaml
Description: YAML Language Support by Red Hat, with built-in Kubernetes and Kedge syntax support
Version: 0.5.3
Publisher: Red Hat
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml
VSC data:
Version: 1.39.1
Commit: 88f15d17dca836346e787762685a40bb5cce75a8
Date: 2019-10-10T23:35:11.314Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

Fix on its way (#636) - thanks for your patience!


Windows installer dist files confusion

Using 2.8.6 when i run npm run dist on windows I get the following file structure under the dist directory and it makes me wonder...
under the win directory there are to identical RELEASE files one named RELEASE-ia32 which both reference a AppName-version-full.nupkg file
on the other hand in win-x64 directory there is a RELEASES file that references a  AppName-version-full.nupkg which doesn't exist and that is because the nupkg filename contains the arch AppName-version-arch-full.nupkg
Is there something wrong here or there is something that I am missing?
I would be glad to help out if needed.
Thanks

one named RELEASE-ia32

Please see #190

references a AppName-version-full.nupkg which doesn't exist

I will check, thanks.


 A map/list/set which is a child of a symbol-layout block
b. A symbol-layout block that recursively points to the symbol-layout block which is the parent of the map/list/set
Garbage collection does not copy the symbol which is the parent of the map/list/set when tackling root 1a above. It merely tackles the internal memory allocated by that map/list/set.
Garbage collection moves the block to the new allocation semispace. The root pointer to the map/list/set still points to the collection semispace.
Garbage collection ends, leaking a pointer into the collection semispace. This memory has been corrupted by storing forwarding pointers to the allocation semispace.
The backend tries to read the map/list/set, but its length field is corrupted by the forwarding pointer, leading to a segfault.

In order to fix this, we annotate each map/list/set child of a block with a "base pointer offset". This offset is an integer that, when added to the address of the map/list/set pointer which is 8 bytes following it, will return the address of the block header of the containing block. We do not try to modify get_value_type since that would be very intrusive as a change; instead we only modify the logic which selects children of blocks using llvm getelementptr instructions, as well as the code that creates map/list/set children in blocks in the first place.
Once these annotations have been applied, which is the subject of the first 5 commits in this PR, we modify the garbage collector to use them in order to reconstruct the base pointer when it receives a garbage collection root. We refactor out a migrate_root function which handles GC roots, and rename migrate_roots to migrate_static_roots to avoid confusion. Then we modify migrate_root to reconstruct the base pointer, migrate the base pointer, and then write the updated derived pointer back to the array of gc roots.
We no longer need to call migrate_map, migrate_set, or migrate_list on the resulting map/list/set because this will now occur for us during evacuation of the relevant parent block.
Code to handle the case where a map/list/set pointer is bare on the alwaysgcspace rather than a child of a block remains largely unchanged, except that we need to modify how we convert those collection to the kore heap in order to accommodate the new memory layout.
Finally, we add a test. I ran the test on the master branch of K and it failed.

This is ready for review, but don't merge it yet. I'm still investigating why I seem to be getting some new test failures in KEVM. I want to make sure I haven't introduced a regression.

Should be ready to merge now once it's been reviewed. I fixed all of the bugs I was able to find.


commsTraceReplay failing due to missing import

I used torch.profiler.profile to collect some traces and replay them using commsTraceReplay. I encountered the following error:
Traceback (most recent call last):
  File "./commsTraceReplay.py", line 1247, in readTrace
    import commsTraceParser
ModuleNotFoundError: No module named 'commsTraceParser'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./commsTraceReplay.py", line 1329, in <module>
    main()
  File "./commsTraceReplay.py", line 1325, in main
    traceBench.runBench(commsParams)
  File "./commsTraceReplay.py", line 1000, in runBench
    self.readTrace(remotePath=self.trace_file, rank=global_rank)
  File "./commsTraceReplay.py", line 1250, in readTrace
    self.comms_trace = extractCommsInfo(self.comms_trace)
  File "./commsTraceReplay.py", line 1266, in extractCommsInfo
    newComm.comms = paramToCommName(curComm["comms"].lower())
TypeError: string indices must be integers
Traceback (most recent call last):
  File "./commsTraceReplay.py", line 1247, in readTrace
    import commsTraceParser
ModuleNotFoundError: No module named 'commsTraceParser'

Looks like there is no module named commsTraceParser in the entire repo.

cc: @shengbao-zheng

Thanks @harisj-xlnx, we are aware of the issue and looking into it.

Looks like it's been fixed.


Apps cannot running when it downloaded directly

Hi, i want to try download directly this apps from github(without using CocoaPods or Carthage). When i want to build it, it successfully run but iPhone simulator does not appear. Is that anything wrong to me? can you explain how?

I'm not really sure I understand what you are trying to do, are you trying to run the demo project? If so, is it set to the Demo scheme with a simulator that you want to run it on? There might be some Xcode tutorials out there if you're unsure how this works.

Thank you, the problem was solved! Thank you too for the information.


Syntax for DATE_BUCKET: origin should be optional

The Syntax section should be updated to clarify that the origin parameter is optional. It already says so in the first paragraph of the article (and in the Arguments section), but the Syntax section should specify this parameter between square brackets.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 44a3bf44-c67c-9cf0-ba4f-442ad6eb814e
Version Independent ID: 44a3bf44-c67c-9cf0-ba4f-442ad6eb814e
Content: DATE_BUCKET (Transact-SQL) - SQL Server
Content Source: docs/t-sql/functions/date-bucket-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @kendalvandyke
Microsoft Alias: kendalv

Thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


[generic-specializer] Fix for specializations which are no-return functions

Fixes rdar://31758579

@swift-ci please smoke test

Linux swiftpm failure seems to be unrelated.

@swift-ci please smoke test Linux


remap exhibitions to installations

Ref #3738
Remap installations to exhibitions.
Make sure they're delisted.
Next step: Add exhibitions to exhibitions.

The adding of the Installation format has been done manually.


Implemented: scanned successfully toast message missing upon product scan(#309)

Related Issues

Closes #309
Short Description and Why It's Useful

Screenshots of Visual Changes

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

Handled in following PR: https://github.com/hotwax/receiving/pull/323


feat(slider): vertical slider

Feature Description
slider seems to be only horizontal
for material for angular js, a "vertical" property existed for mat-slider
Use Case
chose orientation for mat-slider

Any update on this feature?

Given that

The legacyslider will be deprecated this priority should be higher? @wagnermaciel

@jelbourn Is this still a feature we are considering adding?

I discussed this with the team and the unfortunate conclusion is that this is not something we plan on implementing
Context
The new mdc-based slider is built following the Material Design Component's html structure and directly using their styles (IMPORTANT: This is not owned by us). The reason why the vertical option was removed from our library is that the Material Design Slider spec & implementation do not include a vertical slider.
Why not provide one anyway?
Since we are Angular Material Components, we already have incentive not to diverge from the Material Design spec. On top of this, if we were to try to implement this on our end (on top of MDC's styles) it would be a hacky workaround at best and make it more difficult to maintain the interface between our library and theirs.
Conclusion
As long as the Material Design Spec does not include a vertical slider, our library will not be implementing one.
If you'd like to advocate for a vertical slider to get added to the Material Design Spec, please feel free to visit https://m2.material.io/components/sliders. At the bottom of the page, there is a feedback link which you can use to request this feature.
If a vertical slider is ever added to the Material Design Spec, I am more than happy to reopen this issue


[FEATURE] New providers de_CH, fr_CH, it_CH

This is a very first release of providers for Switzerland.

Fixed the error. Now passing unit test on my local development environment.

Code splitted to lines for easier reading.
Add missing static method for streetPrefix.
I choosed a format with "short" and "name" key for accessing the values more easy for a canton name and short name pair.
Otherwise you must use some sort of array_keys($canton) to get the short name of the pair.
If you like just one of them, then you can use the convenience methods cantonName or cantonShort.
If you prefer the key => value pair, I will change that.

For the text providers, please extend the providers from other locales rather than copying them.

yes, please switch to key/value paris for cantons

Copied providers from other packages now extend these instead of duplicate code.
Text provider in package de_CH is still a copy because in Switzerland we don't use the char ß.
Lines to long: which package is a good example? Or max 80 chars?

Should I do still some changes to the code?


[scpproxy] pynetdicom <-> scpproxy <-> Orthanc interop

Hi again @Enet4 another one :-)
Tested with both dicom-storescu and pynetdicom storescuas clients, and Orthanc as a server.
Regards

Hi @Enet4 I took your suggestions into account. The only remaining one is about short display for PDUs.
I added a --strict option to scproxy.
Let me know what you thing of it.

+1 Thank you very much for your continued efforts, @charbeljc.

You are welcome, It's a pleasure to contribute to such projects, having quick code reviews and fast paced merges!


Add JS integrations to thanks page

Check what JS code runs on current thanks page (e.g. sharebandit integration, optimize code, Facebook code, Twitter code) and add it all to new page.

done


Feature request: TestLast on save

Could be a nice feature, to run the last test on saving any project file.

A PR is already open for making it easy to add such and autocommand, I will notify you when it's merged.

If you want to run the last test on saving any project file, you can setup the following autocommand:
augroup test
  autocmd!
  autocmd BufWrite * if exists('g:test#last_command') | TestLast | endif
augroup END

Alternatively you can use test#exists() for a more conservative approach, see the Autocommands section.


How to remove 'No value for search_text was available on provided input'

Using the chatbot version 1.5.2b0
ChatterBot 1.0.1
chattebot-corpus 1.2.0

We can also save our logs to external file so that while running the code everything is saved in that file.
import logging
logging.basicConfig(filename='example.log',level=logging.DEBUG)
You may also change the logging levels in level argument


Fix for #2167

Fixes #2167

@darrelmiller Thanks for approving, whom should I contact to get the PR merged?

Merging as discussed in TSC call today.


Removing empty dependencies properties

Would you accept a PR that would remove empty dependencies fields before saving the file.
So
{
  "name": "foo",
  "version": "1.0.0",
  "dependencies": {}
}

would be saved as
{
  "name": "foo",
  "version": "1.0.0"
}

Empty dependencies, devDependencies, optionalDependencies, peerDependencies would be removed.

I have the problem in Lerna.


fix typo: statrs::distribution::Gamma sample_unchecked

I might find a mistake of sign in the random value generation function in statrs::distribution::Gamma.
Please refer to another implementation of "Marsaglia and Tsang’s Method", for example
https://gist.github.com/fasiha/f289c1d4b9c244a42abee54d1d6206ed
or
https://www.hongliangjie.com/2012/12/19/how-to-generate-gamma-random-variables/

For what it's worth, the sign proposed in this PR is the one that the Rand implementation used until we switched to a different algorithm.
@boxtown Does it make sense for statrs to use sampling algorithms in rand_distr?


The search function should return every file that contains the search-string

Right now it just searchs for files, that are exactly like the string you searched for

Also it should search in every subfolder


[New] 申请

😀 申请人 Applicant

GitHub: kevcui

🌏 领养宠物 Adopt pets

bat
sheep
honeybee

🌈 Tip

After completing the adoption, it is recommended to close the issue yourself. 完成领养后，建议自行关闭 issue。
How to show? 如何展示？
What we can? 我可以做什么？

Invited. Please check your email.


LATIN-tuning

Will you opensource your implementation for Alpaca LATIN-tuning? :)

We are currently working on the new version of LATIN-Tuning and will open-source it once the new version is completed.


unify sign key default value, fixes #1114

Melange Pull Request Template

Functional Changes

[X] This change can build all of Wolfi without errors (describe results in notes)

Notes:
SCA Changes

[ ] Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:
Linter

[ ] The new check is clean across Wolfi
[ ] The new check is opt-in or a warning

Notes:

Enforce - Commit Signing seems not to support ssh based git signing. Is that a problem?


Transactions with AsyncIO

I wan to make use of this ORM lib with aiohttp( https://github.com/KeepSafe/aiohttp )
since there is only one thread which is doing everything (reactor pattern)
Are there any side effects from transaction point of view ?

transactions are thread local, you will need to make sure you open and close your transaction before yield. This is common to transaction handling, same goes to Django ORM etc.

I've fixed the above issue so theres no reason why this should not work, infact it should be a lot quicker now via bolt also. If you have any issues please re-open the issue


Add example application

Allows people to see and play with an already constructed application.

@mbarquin are you happy for this to get merged in as I am working on another branch and don't want to get out of date? :smile:

Hey @mbarquin, just wondered if this project was still active and if I should close this PR?


Telling when a sound ends

Hi,
I'm running play() without blocking, how can I tell when playback finishes?

The only think you can do is to use wait(). If playback is already finished, this returns immediately. If not, it waits until playback is finished.
If you write your own callback function with sounddevice.OutputStream, you can use the finished_callback argument.
What is your use case?

@lukeoftheaura Does it work now for you, or do you need more help?

Yeah, works now, thanks!


[AVM Question/Feedback]: version constraint ~> 1.9 kick out OpenTofu

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
Hi,
I am just trying to get avm modules used in a project with OpenTofu. Making progress but now the latest 0.9.0-beta version of this module is not OpenTofu compatible because of the version constraint `~> 1.9'
OpenTofu is discussing this issue internally how to avoid situation, like this that an required module is pointing the a version string, OpenTofu does not fulfill. Currently there is no way to work around this to my knowledge :-(
Is there a reason why this module depents on terraform 1.9+?

Thank you for your response! First and foremost, I want to clarify that I didn’t mean to imply you were intentionally excluding OpenTofu 😃.
After a quick review of the latest release, I couldn’t find an explanation for the version jump from 1.6 to 1.9.
I am always happy to consider alternatives, but the only feasible solution I see for this is OpenTofu needs to implement all changes made to the Terraform API more quickly. Otherwise, this totally feels like playing the lottery 😄
Until a resolution is available, I’ll continue using version 0.8.1 of your fantastic module.

I can see two resolutions, as you say we do not use the cross-var validation features of 1.9 at the moment.
Therefore is a move back to ~> 1.8 workable for you?

I was not aware of this override "feature" in OpenTofu 🙈. In my opionion, using override would sound as the cleanest solution but a little bit more maintenance for you. But with that you could override the variable blocks using cross-referencing input validation and also the terraform block / the required_version constraint. Someone using terraform is not affected by this quirk.
If you like I can create a PR with this change and can keep an eye on the override.tofu file?

fixed by #123


Roll engine 995e3247fe50..8b35c97c132e (6 commits)

https://github.com/flutter/engine/compare/995e3247fe50...8b35c97c132e
git log 995e3247fe50..8b35c97c132e --no-merges --oneline
8b35c97c1 Roll src/third_party/skia 0c1592291580..197b1f7900a2 (2 commits) (flutter/engine#7333)
544e5bcd2 Roll src/third_party/skia 3b0a332fd970..0c1592291580 (1 commits) (flutter/engine#7332)
d2eb6efeb Roll src/third_party/skia a5d2a9486fed..3b0a332fd970 (1 commits) (flutter/engine#7331)
e2ca868c3 Roll src/third_party/skia 3dc21675b05a..a5d2a9486fed (1 commits) (flutter/engine#7330)
cdc7cc8d3 Roll src/third_party/skia 739b760deaa6..3dc21675b05a (1 commits) (flutter/engine#7329)
e548f12e4 Roll src/third_party/skia aec8c7e280cb..739b760deaa6 (1 commits) (flutter/engine#7328)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.

@liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6384798782193664 , https://cirrus-ci.com/task/4977423898640384 , https://cirrus-ci.com/task/6103323805483008


[WIP] Package refactoring

For my purpose, I needed the package to be installed.
I made a couple of changes. If you can let me know if it is interesting you, I could push to finalize the PR.

@glemaitre Sorry, it seems that there is some problem with this code. Could you resolve it?
Thanks

@shahlaebrahimi can you be more specific?

@glemaitre Could you please look at the issues related to this code? Seemingly, there is some problem with automatic selection, especially when MRMR is tested on large or small data sets.

Ok but this is not related with my PR, isn't?

Hi,
Really sorry for my long absence. Thanks a lot for this PR. Could you please explain what's the benefit of the makefile? Also could you please revert the readme file to it's previous version? Then I can accept this PR. Many thanks!

@danielhomola The benefit of the make file is to automatize the test, the doc, and clean the folder with pyc. I will change the README. I don't remember exactly why it is interesting to have an rst instead of an md. If I recall well, on pypi rst is interpreted and not md.

Normally, I removed the doc from the README since that you can automatically create it with sphinx now. I will add it again and you can see if you want to remove it afterwards.

@danielhomola Look good on my side

thanks a lot for this work! we'd need to write tests as well for this package to be truly robust.. will try and do that in the coming months..


Update to Aframe 0.8.0

Any plan for an update for Aframe 0.8.0 version? Thanks 👍

Agree!

Managed to get it working by a hack
https://codepen.io/omolds/pen/JaGKQz
Images not working yet do

Hacked it fixed
https://codepen.io/omolds/pen/JaGKQz
but its just a hack in html by fixing the show() function position and preloading the assets.

It seems this project is dead. That's a pity. Anyone?


What is the equivalent of gtag('consent', 'update', {'ad_storage': 'granted'}

If I want to perform the following gtag('consent', 'update', {'ad_storage': 'granted'} GTM preview will list Consent like this:

What is the equivalent using TagManager.dataLayer() ?
Or perhaps I should use another method?

I am looking for the same thing, were you able to find a solution for consent management?

@jkohlin I am looking for the same thing, were you able to find a solution for consent management?

Yes, sorry. Forgot about this question.
This works:
TagManager.dataLayer({dataLayer: ['consent', 'update', { ad_storage: 'granted' }]})

@jkohlin does it though? when I use tag assistant to inspect, I don't see consent events being fired by just passing an array. An array is not equivalent to an arguments object passed into the data layer by the gtm examples. I needed to implement a helper to make this work for me.
gtag.ts
import TagManager from "react-gtm-module";

export function gtag(...args: any[]) {
  TagManager.dataLayer({ dataLayer: arguments });
}

@dopry I don't remember how we set this up in tag manager and I don't have access to it anymore but this worked in our case anyway.

Just passing by to understand if someone still recommends this solution?


bug(mat-slider): Ticks are not visible after changing step size

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Ticks are not visible after changing step size
Before changing step size -

After changing step size -

Reproduction
Steps to reproduce:

Go to https://material.angular.io/components/slider/examples
Check Show ticks option
Change Tick interval to 25
Hover on the slider, You will be able to see Ticks
Change the step size to 25
Hover on the slider, Ticks are gone

Expected Behavior
Even after changing the step, Ticks should be visible
Actual Behavior
After changing the step, Ticks are not visible
Environment

Angular:  "^12.2.7",
CDK/Material: "^12.2.7"
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

The points are calculated based on the stepSize. The tikInterval is basically "show a point at every {tikInterval} step". You set the tikInterval to 25 and you have your step at 25 and max at 100. You would have a point at value 25*25 = 625.

Can't swipe on your phone


KOGITO-6449: [DMN Designer] Regression for setting name/dataType for BKM nodes, after KOGITO-4195

I found out another issue during the development of this ticket, but it requires more time so I decided to create another ticket:
Undo/Redo does not work for BKM nodes..

@vpellegrino FYI

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

Should we review this PR or reopen for kogito-tooling once monorepo migration is done?

@jomarko @danielzhe Considering Daniel is on PTO until next week, I don't see a reason to manage this PR in this repo. I suggest to ignore it, and wait to manage this in kogito-tooling

Thank you, guys! I'm closing this PR and creating a new one in monorep.


honor dynamic context name on Android

Current dependencies on/for this PR:

main

PR #822   👈

This stack of pull requests is managed by Graphite.


The chat is not working

Type: Bug
I am asking for help. And it starts to generate the answerd. and never ends.
Sorry, the response was filtered by the Responsible AI Service. Please rephrase your prompt and try again
Extension version: 0.23.2024102903
VS Code version: Code - Insiders 1.96.0-insider (Universal) (4a98be2738be4ad8647feb52d1e6845e06515dea, 2024-11-08T09:56:49.748Z)
OS version: Darwin arm64 22.6.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
1, 2, 2

Memory (System)
16.00GB (0.10GB free)

Process Argv
--crash-reporter-id 90342982-7026-4c83-a858-b3626b12f576

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:31024238
vscaat:30438846
c4g48928:30535728
962ge761:30841072
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
cppperfnew:30980852
pythonait:30973460
724cj586:31013169
dvdeprecation:31040973
dwnewjupytercf:31046870
nb_pkg_only:31057982
nativerepl1:31134653
pythonrstrctxt:31093868
nativeloc1:31118317
cf971741:31144450
e80f6927:31120813
i21gd607:31141543
iacca1:31150324
notype1:31143044
dwcopilot:31158714
h409b430:31177054
3d9ag387:31176402

Thanks for creating this issue! We figured it's covering the same as another one we already have: https://github.com/microsoft/vscode-copilot-release/issues/2625. Please refer to that one for updates and discussions. Feel free to open a new issue if you think this is a different problem.


Replace std::pair by auto to avoid copy

this change speeds up loading time 75-80% for both debug and release build

Very good explanation here:
https://stackoverflow.com/questions/38881707/functor-for-find-if-and-map-avoid-copy-of-value

Very good explanation here: https://stackoverflow.com/questions/38881707/functor-for-find-if-and-map-avoid-copy-of-value

Oh wow, that's interesting.


Add CodyMakk's file

eel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request

ok


New Release

Minor Fixes for Timesheet

Changes Unknown when pulling 3e7ce5412c592a4e50828e24f5d7f7c5678cc17d on develop into ** on master**.

Changes Unknown when pulling 3e7ce5412c592a4e50828e24f5d7f7c5678cc17d on develop into ** on master**.


Latest AppImage version closes unexpectedly with "bus error" message

As the title says, browser closes unexpectedly after startup (roughly a minute in) no matter what i do. But i can make it crash faster if i try load a very heavy website like youtube. Open in it up in a terminal, it throws the "bus error" message when it crashes.
I have no extensions installed nor any flags changed
My system is:
Debian 12 with KDE Plasma 5.27.5
Intel Core i3-6006U with 4GB of RAM

PD: If it's worth something, i use the X11 session of Plasma, but crashes all the same in the Wayland session.

@Jarmund5 Can you test with latest release? ALso if issue persists, file this same bug in the main repo, as I am deprecating this repo as per the latest releases here. > https://github.com/Alex313031/Thorium-Linux-AVX2/releases/tag/M121


Feature request: Play sound in OSX notifications

First of all: Even if this is beta, it works better than some released product. Kudos for that!
What I really like to see in one of the next versions of the OS X app is playing a sound when something happens. Like Apple's built-in message app does.

A general sound notification for incoming chat messages would be much appreciated. In any case, great piece of software!

I'm loving Keybase so far, but it is very surprising that there are no desktop sound notifications.  That kind of makes it unusable, doesn't it?  Am I missing something?

Ditto for linux, it would be great.


Feature Photo is Automotive Suppliers directory should not be stretched, but fit.

Now the all logos will be not stretched out...


SCP-1816 Make builtin strings be backed by Text

Pre-submit checklist:

Branch

[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

I fixed up a couple of things in the plugin, in particular the extremely fiddly bit where we match on fromString invocations, which required some more creative obfuscation :roll_eyes:

I was waiting for stuff to compile so I fixed the other small things too. Please review what I did, but I think this is good to go now!

@jmchapman please look at the neat NEAT stuff when you get back. Not sure how you want to construct String now that there's no Char.

Yeah, James is going to have some catching up to do :)


perfect-numbers: estimate difficulty and move to appropriate position within track

The exercise perfect-numbers was added after we'd already re-ordered the track. By default, new exercises are scored with difficulty 1 and located at the end of the track. We should use this issue to discuss and determine an estimated difficulty for perfect-numbers, then submit an associated PR that moves perfect-numbers to the appropriate position within the track based on that difficulty.

Maybe 3 would be an okay difficulty?

Sorry for the long delay... I'm working my way through my personal xJava backlog.  Likely tomorrow (with the other estimations).

This shouldn't be closed as we haven't estimated it yet.

Closed by #619!


How to support two components?

I want to add two components on your picker view.
Example:
A | 1
B | 2
C | 3

I need this too.


Rework weapon balance and mechanics for competetive CTF

Background
At the moment competitive CTF in Titanfall2 is absolutely dominated by the CAR SMG due to that gun being meta. As such for the Competetive CTF mode that we have in Northstar, it would be nice to work together with the competitive community to rebalance some of the weapons to slightly shift the meta away from the CAR SMG and allow for more varied gun gameplay.
Some proposals
From DMs between @MrBlaBlak and me:

My biggest recommendation for CTF is to completely remove aimpunch mechanics from Pilots. Aimpunch is a significant issue for two main reasons:

ARs become inferior to SMGs: Aimpunch is a much more severe problem when aiming down sights (ADS) with ARs. This disadvantage makes them less competitive compared to SMGs.
Potential desync due to "aimpunch dust": On top of regular dust effects, "aim punch dust" might be causing desynchronization between the client and server. This can lead to a frustrating feeling of hitting your target on the client-side, while the server-side aimpunch throws your aim off. While the exact reason is unclear, it seems to be connected to aimpunch mechanics.

Regarding the CAR's dominance among SMGs:
The recent health change to 120 HP has certainly buffed the R-97 (now down to 6 shots to kill) and the Alternator (with 3-shot potential with a headshot). While these are all viable options, the CAR remains the most popular choice. It might be worth investigating balance changes for other SMGs in the future, but first, it would be interesting to see the impact of removing aimpunch entirely.
Specifically for the Volt:
One SMG that struggles to compete is the Volt. Here's a suggestion: a slight damage buff at mid and long range. This would better suit its laser-like design, encouraging players to utilize it for long-range fire (e.g., mid-range damage increased from 15 to 17, long-range damage increased from 12 to 14).

Useful links
Webapp for comparing weapon damage under the current meta: https://ranking-system-fullstack-nextjs.vercel.app/weapons

Actually i gathered with the Competitive CTF players and they decided that weapon rebalances and mechanics will be better done as mods.


Remove traces of waitUntilDone

Description
This PR removes invalid test waits that rely on waitUntilDone()
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have tested this code
[ ] I have updated the README and other relevant documents (guides...)
[x] I have added sufficient documentation both in code, as well as in the READMEs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: dbrajovic:x: zivkovicmilosYou have signed the CLA already but the status is still pending? Let us recheck it.

I have read the CLA Document and I hereby sign the CLA

recheck

I have read the CLA Document and I hereby sign the CLA

recheck


feat: AU-2535, E2E: Confirm that the tests reach the correct profile form and bug fixing

AU-2216
What was done
This pull request implements a check to ensure that the profile form tests reach the correct profile form. The test verifies this by checking for a specific class on the page that corresponds to the profile type for which the form is being filled.
Other changes
Refactors of the /katso page recently broke the E2E tests (some values we're not printed at all, and some lost their wrappers). This issue has also been fixed.
How to install
Make sure your instance is up and running on correct branch.

feature/AU-2535-e2e-log-profile-form-type
make fresh
make drush-cr

How to test

Set ENABLED_FORM_VARIANTS="draft" in the .env file.

Run make test-pw-p PROJECT=forms-48-registered forms-62-registered forms-53 forms-52. Make sure the tests pass, and that you see this output during the profile form tests:

Works on my machine


[Cosmos DB] Introduce new api version 2021-04-15

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changes in this PR
This PR introduces a new resources for Cosmos DB data plane RBAC (SqlRoleDefinition and SqlRoleAssignment), and this is the only change compared to the old 2021-04-15.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. -- Service changes are already in Prod, awaiting Swagger rollout
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. -- Mid April
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[x] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

"CloudError": {

Is there a reference to this CloudError definition?

Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2021-04-15/cosmos-db.json:5233 in fa5f3f9. [](commit_id = fa5f3f958b720cd1cca0eeb2e5e5a8bff6f1148e, deletion_comment = False)

The new APIs in rbac.json looks good. Please check out linter errors mostly coming from included referenced swaggers. There are errors for not supporting "SystemData" property. Here's RPC document about it: https://github.com/Azure/azure-resource-manager-rpc/blob/2e1f2c11ce4cfdf309f9cc8ae71575cb8fb83319/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources

one more question - @nichatur have you discussed the RBAC additions with Identity team?

/azp run

one more question - @nichatur have you discussed the RBAC additions with Identity team?

Yep we have, the resources exposed here are already in Public Preview

"CloudError": {

Is there a reference to this CloudError definition?
Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2021-04-15/cosmos-db.json:5233 in fa5f3f9. [](commit_id = fa5f3f9, deletion_comment = False)

We are following the same pattern as  Microsoft.Storage
This error model allows RPs to transition from the legacy error format to the new one without breaking the swagger spec

The new APIs in rbac.json looks good. Please check out linter errors mostly coming from included referenced swaggers. There are errors for not supporting "SystemData" property. Here's RPC document about it: https://github.com/Azure/azure-resource-manager-rpc/blob/2e1f2c11ce4cfdf309f9cc8ae71575cb8fb83319/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources

There will be RP wide changes that will introduce systemData for all Cosmos DB resources, since pretty much all of them lack this as of now

Please double check error reported in Cross Version BreakingChange

We are aware of those errors. The difference between preview and GA version is intentional. We have gotten a breaking change approval in lieu of that.

@nichatur
Good. Let me know when you need it merged.

/azp run


Create config migration script

The goal here is to have a script that can detect configuration which was deprecated in a particular version of FireFly and then convert it to the newest format. By progressively iterating through versions, a config file may be brought up to date with the latest expected format.
The secondary goal is for this script to be as easy to maintain as possible. I've prototyped a partial solution in both Python and Go. Both have their advantages, so I'm looking for input on the final choice. In the end, the Python solution was not significantly simpler than the Go version, and would introduce a new language, packaging system, etc. I've decided to stick with Go.

Codecov Report

Merging #934 (cf2bee9) into main (e22d84a) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head cf2bee9 differs from pull request most recent head 5a1ddd7. Consider uploading reports for the commit 5a1ddd7 to get more accurate results

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   99.98%   99.97%   -0.02%
==========================================
  Files         299      299
  Lines       19478    19478
==========================================
- Hits        19475    19473       -2
- Misses          3        4       +1
- Partials        0        1       +1

Impacted Files
Coverage Δ

internal/tokens/fftokens/fftokens.go
99.53% <0.00%> (-0.47%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.


[release calendar] Add React and Webpack for client side

To debug, run npm run client which bundles the files in src/client/ and serves the website on localhost:9000 using webpack-dev-server.
Closes https://github.com/ampproject/amp-github-apps/issues/723

We'll find out :)
On Thu, Mar 5, 2020 at 3:14 PM Esther Kim<EMAIL_ADDRESS>wrote:

@estherkim commented on this pull request.
In release-calendar/package.json
https://github.com/ampproject/amp-github-apps/pull/736#discussion_r388537942
:

},
"dependencies": {

"dotenv": "8.2.0",

It's to replace process.env variables. One way is to run it at app start
like require('dotenv').config() so maaaaybe you need it in dependencies?
But I used the CLI way and put it in a node script like node -r
dotenv/config ./dist/app.js. So as long as the variables get replaced
before dist/ is deployed then I think it's okay. I thiiiink
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amp-github-apps/pull/736?email_source=notifications&email_token=AAOBE6UWIWVUMVE5DHHJE4DRGAB25A5CNFSM4LCQ2XG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYF7CRA#discussion_r388537942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOBE6UPMWHOLIPEVLFXO3LRGAB25ANCNFSM4LCQ2XGQ
.


How can I customize elasticsearch.yaml

Hello every one ,
i'm working on kubernetes and elasticsearch
i followed this link :https://github.com/kubernetes/examples/tree/master/staging/elasticsearch
what i want is to add a volume to be like this on :
folder_path/config/elasticsearch.yml:/root/config/elasticsearch.yml

Please ask questions on kubernetes Slack (http://slack.k8s.io/) or the mailing list (https://groups.google.com/forum/#!forum/kubernetes-users).

Thank you for the help


Faster dev build

Removes 30 dependency packages in Cargo.lock over and above the 12 dependency packages removed in the target branch.
Makes the dev build faster
Introduces 'just check' for quick checks of buildability

Approve


how to hide status top bar view?

@meanreaksmey You mean the topView of PlayerView? By default, there is no hiding, you can customize the view, and then delete or hide it.
Or the default directly remove example:  player.displayView.topView.removeFromSuperview()

thanks you now it work.

@meanreaksmey You can set the gesture directly to enable = false.


Single File Components Use

Hi @egoist — thanks for your contributions to the Vue community <3
I'm just wondering whether this works with an app using Single File Components (with Vite)?
I've installed, however am running into the error:
[Vue warn]: Component is missing template or render function.
  at <QuickLink to="/about" >
  at <Menu>
  at <App>

and
index.esm.js:181 Uncaught TypeError: Failed to execute 'observe' on 'IntersectionObserver': parameter 1 is not of type 'Element'.

Keen to hear your thoughts!

Hello,
I faced the same issue with vue 3, be sure tu use yarn add vue-router-prefetch@^2.
I simply ran yarn add vue-router-prefetch and it installed<EMAIL_ADDRESS>

Hello,
I faced the same issue with vue 3, be sure tu use yarn add vue-router-prefetch@^2.
I simply ran yarn add vue-router-prefetch and it installed<EMAIL_ADDRESS>

I'm using vue-router-prefetch@^2 and Vue 3, but getting the same error when using the "custom" prop on router-link components.

+1, using @^2 (2.0.2), getting:
Uncaught TypeError: Failed to execute 'observe' on 'IntersectionObserver': parameter 1 is not of type 'Element'.     at Proxy.observe (index.esm.js:181:18)
I also mostly uses router-link with custom prop.


GitHub: Invite member

Who should be invited to Catena-X ng
GitHub User:
@mzohaib-elastica
@tonyrajan
Vouching person: @lucaloeffler

Invites sent. Let me know if there is anything else needed.


Test & Document Quark Server with H2 in file

Tests use H2 in memory. Need to make sure that it works with H2 on file and data is available between restarts. Also a doc is required on how to set it up.

Server works perfectly with H2 on file. No setup is required, changing the database-url to use file instead of memory will work.


[JOSS REVIEW] BSD 4-Clause License is not OSI approved

According to https://opensource.org/licenses/?ls=BSD BSD 4-Clause is not OSI approved which is a requirement for JOSS.
This is related to https://github.com/openjournals/joss-reviews/issues/5744

Thanks for pointing to this. I now moved the code to the MIT license.


[Sept Sprint] Improve Logs logs logs

This is part of our September Spring to get the Go Track in shape. Please read the Overview issue for more details. This exercise is claimed by
@sudomateo .

Logs Logs Logs
"Logs logs logs" will no longer teach basic strings (this will be poetry club instead), but instead will focus on Runes and string slices.

This exercise should be introducing the strings-package concept. It should show how to access things from the package and show one usage example and a table with commonly used functions from the package. The concept about page should link to the full list of functions from the docs.
[ ] This exercise should be introducing the runes concept and must use ranges.
[ ] https://github.com/exercism/go/issues/1596
[ ] https://github.com/exercism/go/issues/1595
[ ] https://github.com/exercism/go/issues/1594

@iHiD I'll snag this.

@sudomateo Great. Thanks! :)

@sudomateo There was a mistake in the issue description here. The concept strings-package will be introduced in this exercise: https://github.com/exercism/go/issues/1613 If you have already written any content for this, please paste it as a comment into the other issue so the person working on this can use it. You can fully concentrate on runes in this concept and exercise.

@junedev I haven't started working on this yet as I was traveling. I will fully concentrate on runes. Thank you for informing me!

Just a reminder to myself to implement the work done in https://github.com/exercism/go/pull/1670.

Just a reminder to myself to implement the work done in https://github.com/exercism/go/pull/1670.

I'm all good! Just added content to the runes concept today. I'll finish up the exercise content tomorrow or the next day. All the work is in https://github.com/exercism/go/pull/1707.

Great! Let me know when you'd like a review.

@ErikSchierboom #1707 is ready for review!


PyraMiD-LSTM in Keras

Hi,
I would like to implement the PyraMiD-LSTM: link in Keras.
Is there an easy way? because i don't see a way with the built in "functions"
Thanks

Hi,
Have you finished pyramid-lstm implementation?
Thanks.

hi @MinaRe , did you find out that how to make .mat file for MNC?

Hi, Yes I prepared .mat file but I have problem on training !!!

i also try... please let me know if you success . thanks in advance @MinaRe

% converts a png ground trith to .map
function GTinst=cnvt2gt(fname)
% fname='C:\Users\ogaes\Documents\MATLAB\Mina\GT.png';
seg=imread(fname);
imshow(rgb2gray(seg),[]);
GTinst.Segmentation=rgb2gray(seg);
GTinst.Boundaries=cell(0);
GTinst.Categories=[];
ObjNumber=0;
categoriesList=sort(unique(GTinst.Segmentation),'ascend');
for it=1:size(categoriesList,1)
ctg=categoriesList(it);
if(ctg~=0)
CC = bwconncomp(GTinst.Segmentation==ctg);% connected components analysis
for obj=1:CC.NumObjects
imgb=zeros(CC.ImageSize);
pixelsIndex=CC.PixelIdxList{obj};
imgb(pixelsIndex)=ctg;
bnd = bwboundaries(imgb);
imgb2=zeros(CC.ImageSize);
imgb2(sub2ind(CC.ImageSize,bnd{1}(:,1),bnd{1}(:,2)))=ctg;
ObjNumber=ObjNumber+1;
GTinst.Boundaries{ObjNumber,1}=sparse(imgb2);
GTinst.Categories=[GTinst.Categories;ctg];
end
end
end
end
function GTcls=cnvt2-gt(fname)
% fname='C:\Users\ogaes\Documents\MATLAB\Mina\GT.png';
seg=imread(fname);
imshow(rgb2gray(seg),[]);
GTcls.Segmentation=rgb2gray(seg);
GTcls.Boundaries=cell(0);
GTcls.Categories=[];
ObjNumber=0;
categoriesList=sort(unique(GTcls.Segmentation),'ascend');
for it=1:size(categoriesList,1)
ctg=categoriesList(it);
if(ctg~=0)
CC = bwconncomp(GTcls.Segmentation==ctg);% connected components analysis
for obj=1:CC.NumObjects
imgb=zeros(CC.ImageSize);
pixelsIndex=CC.PixelIdxList{obj};
imgb(pixelsIndex)=ctg;
bnd = bwboundaries(imgb);
imgb2=zeros(CC.ImageSize);
imgb2(sub2ind(CC.ImageSize,bnd{1}(:,1),bnd{1}(:,2)))=ctg;
ObjNumber=ObjNumber+1;
GTcls.Boundaries{ObjNumber,1}=sparse(imgb2);
GTcls.Categories=[GTcls.Categories;ctg];
end
end
end
end

Hey guys!
Did anyone succeded in implementing Pyramid-lstms in Keras?

I am also very interested in PyraMiD-LSTM. Maybe someone has implemented it?

+1

Hi all, anyone is the success with pre-processing of Pyramid-lstms? Could we discuss this step?


fix(article-categories): Apply toLower for item categories

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

24 of 24 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 80.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
493

Relevant Lines:
610

💛  - Coveralls


Internal BYK services

AS AN End Client
I WANT TO get information about Bürokratt
SO THAT I could be more informed
Acceptance Criteria

[ ] Common Service to get information about Bürokratt's Participants (service providers)
[ ] Common Service to get information about all the e-services provided via Bürokratt
[ ] Common Service to get information about Bürokratt's both technical and business level updates

Blocked as CentOps Admin is still being developed with an ETA of 22.06.2023. Still, this needs pentesting, etc., so its output about Bürokratt Participants and services may also be provided as fixed content as input for Common Services.


Rule: Check if there is data before first section

Any data in a file that is located before the first section is ignored in RF. I think it may be useful to catch such cases and report that it is not contained by any section thus ignored by RF.

Your comments in #234:
This is fine:
# robocop: disable=some-specific-rule-that-I-want-to-ignore-in-this-whole-file
*** Test Cases ***
stuff

This is also fine:
*** Comments ***
Someone clearly used Comments section so we don't need to tell him/her that this section is ignored

*** Test Cases ***
stuff

And this is not fine:
${var}  10  # ups, this is comment not effective code!
*** Keywords ***
Keyword

Based on these examples I suppose it should be enough to check whether the first line of the file is a data section header or not (using RawFileChecker).
It can be done like:
def visit_File(self, node):
    tokens = list(get_tokens(node.source))
    if not 'HEADER' in tokens[0].type and not tokens[0].value.startswith('# robocop:'):
        self.report(...)

Or like this:
def parse_file(self):
    self.lines = []
    super().parse_file()
    if not self.lines[0].startswith('***') and not self.lines[0].startswith('# robocop:'):
        self.report(...)

Should we put this to the comments.py checker category?

The second option will be probably faster. But what if someone have only empty lines before first section? :

*** Settings ***

should we report 'data before first section is ignored' or rather something along of 'invalid number of empty lines before section 4/0'?

Good question, it depends on the point of view.
From the logical perspective (and I suppose from Robot Framework's point of view), it is considered as data, even if they are empty lines. And if you merge my pull request about 0509, Robocop will throw a warning with [W] 0509 Section is empty, since those empty lines before the *** Settings *** are considered as part of the *** Comments ***.
I would throw a warning with data before first section is ignored instead of invalid number of empty lines before section.
What is your opinion?

Yes I agree with you 👍

Thanks! :)
Since this data is considered as Comments, should I put the new rule inside comments.py? Or is length.py even better?
Something like:
class IgnoredDataChecker(RawFileChecker):
    """ Checker for ignored data. It checks whether there is ignored data defined before the first section header or not."""
    rules = {
        "0527": (
            "ignored-data",
            "Found data in file which is ignored",
            RuleSeverity.WARNING
        )
    }

It's not really checking for length, so comments.py would be more suitable. Although I would argue about half of the rules grouping in robocop - it's not important to end user and it's only for splitting up a code a bit and helping to find given rule faster. And if I were to look for "comment section related rules" I would hit comments.py first.

There is another situation to handle (beside the three example above), it is not enough to check the first line, as I assumed earlier:
# robocop: disable=1001
${var}    10    # This should throw a warning.
${var}    20    # This is not good but one warning is enough.
*** Settings ***

Based on all the scenarios, what about this?
class IgnoredDataChecker(RawFileChecker):
    """ Checker for ignored data. """
    rules = {
        "7004": (
            "ignored-data",
            "Ignored data found in file",
            RuleSeverity.WARNING
        )
    }

    def __init__(self, *args):
        self.section_header = False
        self.ignored_data = False
        super().__init__(*args)

    def check_line(self, line, lineno):
        if self.section_header or self.ignored_data:
            return
        if line.startswith('***'):
            self.section_header = True
            return
        if not line.startswith('***') and not line.startswith('# robocop:'):
            self.report("ignored-data", lineno=lineno, col=0)
            self.ignored_data = True

I can also do the checks in the def parse_file(...), but it would mean we will go through the first lines twice (once while reading the lines, once during the for loop).
    def parse_file(self):
        self.lines = []
        super().parse_file()
        for line in self.lines:
            if line.startswith('***'):
                break
            if not line.startswith('***') and not line.startswith('# robocop:'):
                self.report("ignored-data", lineno=1, col=0)
                break

    def check_line(self, line, lineno):
        self.lines.append(line)

If you go with second approach you don't need to call suepr().parse_file() if you're iterating over lines anyway. You can do something like:
    def parse_file(self):
        """ Read file line by line and for each call check_line method. """
        with open(self.source) as file:
            for lineno, line in enumerate(file, 1):
                # run your check here, break early if needed

You will iterate over same line only once that way.
From robocop point of view, it just call scan_file() and later accumulate found issues from self.issues, so we don't need to keep same logic in every rule


Reps and weight are 0 when entering plan page

When entering the page where the exercises are listed and sets can be input, the reps and weight are initially set to 0. Tapping on the exercise will update reps and weight to the correct numbers.
Steps to reproduce the behavior:

Go to "Plans" Tab
Click on any plan
In the newly opened page, reps and weight are 0, as described above

Expected behavior:
reps and weight should be set to their proper values when first entering the page.
My guess: Has something to do with this commit

Not sure how that commit could cause this, if you could please upload more details to try and reproduce this bug.
Perhaps the readTable method in drift isn't reliable on all devices?
ADB logs or flexify app db dump would be appreciated.

One important piece of information that I forgot to write yesterday: This bug only occurs in 1.1.87 and later. 1.1.86 works fine. That's why I am suspecting that particular commit in the first place.
I have dug a little deeper into this. To pinpoint the problem I did the following in a test environment:

In Branch https://github.com/dmrowietz/Flexify/tree/issue_123_debugging I removed all but one item from defaultExercises and defaultPlans to make the DB as simple as possible. I then built up the db-query step by step:
a: join
b: orderBy
c: groupBy
d: addColumns

Delete existing flexify.sqlite file <-- make sure this is the db of the test environment, not your actual database

Build flexify on the branch issue_123_debugging. I am building on Linux native, building for Android is broken for me at the moment.

Start app and add one set of "Arnold press" (1rep@1kg), restart the app

The DB is now very simple. It contains only one exercise with exactly one set with 1rep@1kg

Using a debugger take a look at the variables a,b,c,d in updateDefaults()

=> Curious, groupBy reduces the number of items. In my understanding it should not do that.
More details:

b._parsedData[1] is the set I created with 1rep@1kg
Only _parsedData[0] gets past groupBy so i think this is where the problem lies.


cannot disable autopairs inside treesitter comment nodes, but all other treesitter-based autopair rules work

First of all, thank you so much for creating an autopair plugin that connects to treesitter! I love the added intelligence I can get for my autopairs with treesitter.
But there is one thing that I haven't been able to sort out regarding nvim-autopairs and nvim-treesitter. I generally want to turn of autopairs inside strings of text and inside comments. I have managed to turn autopairs off inside strings in c, c++ and python but I'm not able to turn off autopair inside comments in any of the three languages. I'm using the playground plugin to find the treesitter names for the nodes.
I have been able to add other autopair rules based on treesitter nodes and that works just fine. I've tried a few weird rules to create pairs in various treesitter c++ nodes and it worked just fine. So nvim-autopairs and nvim-treesitter seems to work together nicely for everything I've tried except for disabling all autopairs inside treesitter comment nodes.
Any ideas for what I might have done wrong? Or have I stumbled upon a bug?
I'm not sure what's considered the best way to add a minimal init.vim to a github issue, so I'll add it as a quote:
call plug#begin('~/.config/nvim/plugged')
Plug 'nvim-treesitter/nvim-treesitter'
Plug 'nvim-treesitter/playground'
Plug 'windwp/nvim-autopairs'
call plug#end()
lua << EOF
ts_config = require('nvim-treesitter.configs')
ts_config.setup{
	ensure_installed = "maintained",
	autopairs = {enable = true}
}
ap_config = require('nvim-autopairs')
ap_config.setup({
	check_ts = true,
	ts_config = {
		cpp = {'string_literal', 'comment'},
		c = {'string_literal', 'comment'},
		python = {'string', 'comment'}
	}
})
EOF

EDIT: put the init.vim code in a code block instead of quote. I'm new to github so didn't know how to create code blocks.
EDIT2: Now I learned how to put highlighting in the codeblock so I added that.

call plug#begin('~/.config/nvim/plugged')
Plug 'nvim-treesitter/nvim-treesitter'
Plug 'nvim-treesitter/playground'
Plug 'windwp/nvim-autopairs'
call plug#end()
lua << EOF
ts_config = require('nvim-treesitter.configs')
ts_config.setup{
	ensure_installed = "maintained",
	autopairs = {enable = true}
}
ap_config = require('nvim-autopairs')
ap_config.setup({
	check_ts = true,
	ts_config = {
		cpp = {'string_literal', 'comment'},
		c = {'string_literal', 'comment'},
		python = {'string', 'comment'}
	}
})
EOF

can you give a sample of c or python code

In the below piece of c code, I can create autopairs everywhere except inside the string and I use the init.vim from above. I again verified with playground that treesitter has the nodes with the names from the init.vim.
/* Auto generation of pairs still work here */
int main(){
	char x[] = "Autogeneration of pairs doesn't work here";
	return 0;
}

    c = {'string_literal', 'comment', 'source'},

you need to add source  that playground don't display inject language  in c comment it inject another parser of document language.

Thank you very much! That seems to solve the issue perfectly. Now it works just as expected! Thanks a lot!
Feel free to close this issue, unless you want it to be visible for others who might stumble upon the same situation.


Multi-stage intersect ignores all modifier

In SQL intersect may be modified with the all modifier. For example:
if table A contains a column a with values [1,1,2,3,4] and B contains a column b with values [1, 1, 2]:
select *
from (select a from A)
intersect (select b from B)

Returns [1, 2] while
select *
from (select a from A)
intersect ALL (select b from B)

returns [1,1,2].
Currently Pinot accepts the ALL modifier and it is shown in the explain plan, but the semantics are always the same. Specifically, Pinot semantics are the ones of intersect without all modifier.
You can verify that by running ColocatedJoinEngineQuickStart and executing:
select userUUID
from (select userUUID from userGroups)
intersect all
(select userUUID from userGroups)

with and without all.
intersect all should return the same number of rows than count() (which is 2494) while intersect should return the same number of rows than count(distinct(userUUID)) (which is 2470).
But the returned number of rows is 2470 with and without all modifier
As a short term solution we can fail if all modifier is supplied, as it would be better than returning incorrect results.

Hi @gortiz, could you please assign this issue and https://github.com/apache/pinot/issues/13127 to me? I'd like to take a look.


docs(tabs): link to tab pattern

What I did

add a pattern page for tabs
stub a pattern image for tabs (cc @coreyvickery)
write up a link-to-tab pattern

Testing Instructions

view the pattern page
check that hash navigation to tabs or tab contents works

Notes to Reviewers
cc @markcaron this pattern was requested by Lindsay Mitchel

Should we provide the explicitly used as a codeblock on the pattern page itself?

Should we provide the explicitly used html / js code as a codeblock on the pattern page itself? Do patterns pages ultimately get a code tab as well long term?

yes, but maybe not in this pr

OK @zeroedin PTAL
@adamjohnson I noticed an unrelated issue: I wasn't able to tab to the "Best" link in the "West" tab panel on firefox, fedora 40, with orca screenreader on (or off). Instead, I tabbed to the tab panel itself, which I think should not be in the tab order. Can you confirm? If so, let's open a new issue, or maybe this is already addressed elsewhere?

wasn't able to tab to the "Best" link in the "West" tab panel on firefox

the link doesn't have a href on it.

I tabbed to the tab panel itself, which I think should not be in the tab order. Can you confirm?

From ARIA Authoring Practices Guide Tabs docs (Note #4):

When the tabpanel does not contain any focusable elements or the first element with content is not focusable, the tabpanel should set tabindex="0" to include it in the tab sequence of the page.

So, in this case, this tab is behaving as expected.


Missing Users and Groups option

the users and groups option is not available on the current UI after the redesign of app registrations. How can access that option or whats the current process?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ada0b95-37b4-22d1-152f-fc29a52f5706
Version Independent ID: 9424e3bb-d141-f74f-c6c5-114410253e2d
Content: How to assign users and groups to an application
Content Source: articles/active-directory/manage-apps/methods-for-assigning-users-and-groups.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @msmimart
Microsoft Alias: mimart

@burstingninja Thanks for your feedback! We will investigate and update as appropriate.

@burstingninja Glad to hear that.  We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Authentication for HTTP Server

Initial implementation of authentication for HTTP Server. The authentication code is copied from https://github.com/bluesky/tiled
and modified to suite specific needs. This is not the final version of the authentication code. The authentication API may change in the future.
Description

The code was tested by sending requests from command line using httpie. Following is the list of requests that were proven to work.
Start HTTP server with ’toy’ provider
QSERVER_HTTP_SERVER_CONFIG=config_toy.yml uvicorn --host localhost --port 60610 bluesky_httpserver.server:app
Request token using ‘toy’ provider
http --form POST http://localhost:60610/api/auth/provider/toy/token username=bob password=bob_password
Request API key using token
http POST http://localhost:60610/api/auth/apikey expires_in:=900 scopes:='["read:status", "apikeys"]' 'Authorization: Bearer ’
Request API key using API key (with ‘apikeys’ scope)
http POST http://localhost:60610/api/auth/apikey expires_in:=900 scopes:='["read:status", "apikeys"]' 'Authorization: ApiKey ’
‘whoami’ using API key
http GET http://localhost:60610/api/auth/whoami 'Authorization: ApiKey '
Refresh session (get new token) using ‘refesh token’
http POST http://localhost:60610/api/auth/session/refresh refresh_token=
Revoke session (based on session UID from ‘whoami’) - makes refresh token expire, tokens and API keys will still run until they expire
http DELETE http://localhost:60610/api/auth/session/revoke/  'Authorization: Bearer '  (alternatively an API key could be used for authorization)
Get information on an API key (used to authorize the request)
http GET http://localhost:60610/api/auth/apikey 'Authorization: ApiKey '
Delete API key that belongs to the authenticated user
http DELETE http://localhost:60610/api/auth/apikey first_eight== 'Authorization: Bearer ' (alternatively API key may be used for authorization, including the one that is being deleted)
Log out (expected to delete cookies with the token or API key stored locally (does not work with httpie) No authentication is required.
http POST http://localhost:60610/api/auth/logout
Admin access. Get information on all principals.
http GET http://localhost:60610/api/auth/principal 'Authorization: Bearer ' (or API key)
Admin access. Get information on a principal by principal UUID.
http GET http://localhost:60610/api/auth/principal/ 'Authorization: Bearer ' (or API key)
Admin access. Get API key for a principal.
http POST http://localhost:60610/api/auth/principal//apikey expires_in:=900 scopes:='["read:status", "apikeys"]' 'Authorization: Bearer ' (or API key)
Motivation and Context

Summary of Changes for Release Notes

Fixed
Added

Initial implementation of basic authentication. The authentication API may change in future releases.

Changed
Removed
How Has This Been Tested?

The PR contains working code and provide functionality sufficient to add basic security features to other system components. The authentication code will be improved and extended in future PRs.


executor/fuchsia: close vmo handle in syz_mmap.

This commit fixes a handle leak in syz_mmap. The bug was pointed out by
mdempsky during a code review.
The syz_mmap function creates a VMO and maps it to a VMAR in the address
specified by the syz_mmap parameters. Once a VMO is mapped to a vmar,
the handle to the vmo can be closed without problems.
The new code makes sure that zx_handle_close(vmo_handle) gets called before
the syz_mmap function returns.

LGTM

The failure does not look relevant to this change:
+ wget -O seed https://storage.googleapis.com/fuzzit-b5fbf.appspot.com/orgs%2Fsyzkaller%2Ftargets%2Fsyzkaller-prog-deserialize%2Fseed?GoogleAccessId=fuzzit-b5fbf%40appspot.gserviceaccount.com&Expires=1599867783&Signature=CMM%2BOdzPp7CmMyAc4Tyfqr8P%2B5%2F5uVX78mnLC1JXL5kogl4uBVCb47eJM9nlB4MMMSXH1hvFz4HEw3gKDcAx6y3SlOdAp86zQ6MLIbI%2F29IU7tU3l0xRQeAEUF%2FiNlWy2WoescoCN33iFVgcWcYntAcnN9rHNwa42%2BSuCF1UnMi5NVYUG%2FwksGufSmu7u5uuVNiuZzcBPFiMce5qbRYNci3rBPwCThDDZ%2FuqnAGZa6wmJnljDZnEfcZx7CTaGSjzfn4feF9qbuG%2BfMUsqu6%2FRQ47UZX2WsFPSR4GfmIE5CDaOnrc1arh5STxZe3gPpqeURKDFIm1n7e%2B%2B1K1OCJRXw%3D%3D
--2019-09-11 23:43:48--  https://storage.googleapis.com/fuzzit-b5fbf.appspot.com/orgs%2Fsyzkaller%2Ftargets%2Fsyzkaller-prog-deserialize%2Fseed?GoogleAccessId=fuzzit-b5fbf%40appspot.gserviceaccount.com&Expires=1599867783&Signature=CMM%2BOdzPp7CmMyAc4Tyfqr8P%2B5%2F5uVX78mnLC1JXL5kogl4uBVCb47eJM9nlB4MMMSXH1hvFz4HEw3gKDcAx6y3SlOdAp86zQ6MLIbI%2F29IU7tU3l0xRQeAEUF%2FiNlWy2WoescoCN33iFVgcWcYntAcnN9rHNwa42%2BSuCF1UnMi5NVYUG%2FwksGufSmu7u5uuVNiuZzcBPFiMce5qbRYNci3rBPwCThDDZ%2FuqnAGZa6wmJnljDZnEfcZx7CTaGSjzfn4feF9qbuG%2BfMUsqu6%2FRQ47UZX2WsFPSR4GfmIE5CDaOnrc1arh5STxZe3gPpqeURKDFIm1n7e%2B%2B1K1OCJRXw%3D%3D
Resolving storage.googleapis.com (storage.googleapis.com)... <IP_ADDRESS>, 2607:f8b0:4001:c05::80
Connecting to storage.googleapis.com (storage.googleapis.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-09-11 23:43:48 ERROR 404: Not Found.

@yevgenypats FYI

LGTM

@dvyukov thanks for letting me know. yeah, we had some bug recently. opening a PR with an updated version of the CLI.


Calling c++ code from python using pybind11 creates an error when creating Spacy::Spacy object on stack but not as a pointer

Here's a minimal example to reproduce this error:
cmake-add-subdirectory-hdr.zip
To reproduce this
cd build
cmake .. && make
cd ../src/
python pyTest.py

Why does the following code (creating Spacy::Spacy object on stack) creates an error:
  Spacy::Spacy spacy;
  auto nlp = spacy.load("en_core_web_sm");

Fatal Python error: PyThreadState_Get: the function must be called with the GIL held, but the GIL is released (the current Python thread state is NULL)
Python runtime state: finalizing (tstate=0x00000001029b63c8)

Abort trap: 6

But this one works?
  Spacy::Spacy* spacy = new Spacy::Spacy();
  auto nlp = spacy->load("en_core_web_sm");

Hi! Spacy-cpp is a C++ wrapper library for the (Python) spacy library, so internally it sets up a Python interpreter instance which is used to perform the various spacy calls. Spacy-cpp is not intended to be called from Python, and googling above error message shows some other people encountering similar problem when calling Python -> C++ -> Python due to the GIL (Python's global interpreter lock).
Having that said, I suspect the reason it works with the heap object is that the code does new Spacy.. without corresponding delete, thus the object is not cleaned up. With the stack object it's guaranteed to be cleaned up at the end of it's scope.
Supporting usage from Python/pybind11 is probably outside the scope of spacy-cpp, but I'm curious what is the use-case, why not call spacy directly from Python (and not use C++ / spacy-cpp)?

Edit: A potential work-around/hack could be to comment out the call to Py_Finalize() from Python::~Python() in src/spacy/python.cpp - I've not tested this, it's just a guess.

Your guess was right. I'm unsure if I should keep it as a pointer as before with src/spacy/python.cpp unchanged or with this change. At the end of the day, I'm passing Python the flag to take ownership of the lifetime of the variables.

but I'm curious what is the use-case, why not call spacy directly from Python (and not use C++ / spacy-cpp)?

Haha good question. I'm developing an app that given two words, finds related words that rhyme (spacy is used to identify pos tags). The server is very slow with pure Python, so I had to create a C++ binding using pybind11. But it resulted in a large overhead in transferring large data sets from C++ to Python. My solution is to score the rhyme couples in C++ and only return the top N rather than returning all the rhyme couples and scoring them in Python (just the data transfer will take a few seconds).

I'm unsure if I should keep it as a pointer as before with src/spacy/python.cpp unchanged or with this change.

Generally, I would leave the third-party library (spacy-cpp) untouched to facilitate future potential updates of the library.
Thanks for sharing the background 🙂
I will proceed to close this issue, as I believe a fix for this would be out of scope for spacy-cpp. Feel free to re-open if you have concerns. Thanks!


Charting Cleanup and Additions

Description

Refactor ChartingInsightManagerExtension.cs

Stop Alpha framework from adding charts to algorithm until insight occurs (Fixes useless charts for non-framework based algos)
Cleanup, nit fixes, and simplify charting and series handling

Add drawdown to default charts in BaseSetupHandler
Add capacity to default charts in Backtesting
Add some comments for future clarity

Related Issue

Closes #5612
Motivation and Context

To make the default charts more useful and reduce clutter by stopping unneeded charts.
Requires Documentation Change

N/A
How Has This Been Tested?

All regressions passing
Tested in the cloud, see examples in comments below.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

For all algorithms referenced below I pushed the end date out 1 year so we could have a nice picture of charting behavior.
BasicTemplateFuturesFrameworkAlgorithm

BasicTemplateOptionsAlgorithm

BasicTemplateOptionsFilterUniverseAlgorithm

G10CurrencySelectionModelFrameworkAlgorithm

Push all the end dates out one year for these tests
Tested on Lean v12040
BasicTemplateCryptoAlgorithm

BasicTemplateFuturesFrameworkAlgorithm

BasicTemplateOptionsAlgorithm

BasicTemplateOptionsFilterUniverseAlgorithm

DropboxUniverseSelectionAlgorithm

FuturesMomentumAlgorithm

G10CurrencySelectionModelFrameworkAlgorithm

MACDTrendAlgorithm