Runtime type matching is buggy.

I was trying to accomplish something similar to Scaffold.of(context), where the closest ScaffoldState ancestor is obtained using the method ancestorStateOfType.
Source code from StackOverflow for demonstrating this error,
class IApp extends StatefulWidget {
  @override
  IAppState createState() => new IAppState();

  static IAppState of(BuildContext context) =>
    context.ancestorStateOfType(const TypeMatcher<IAppState>());
}

  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      // ommitted: some localization and theming details
      home: new HomePage(),
    );
  }

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
      // ommited: some Scaffold properties such as AppBar
      // runtimeType not actual goal, but just for demonstration purposes
      body: new Text(IApp.of(context).runtimeType.toString()),
    );
  }

Here IApp.of() returns null.
The StackOverflow answer explains this is particularly because of Dart's addressing policy. Opposing to the answer in my case, the absolute addressed and relative addressed class are treated alike but somehow different from the one within the widget tree. After I spent an hour debugging, I obtained the runtimeType of the state in the widgettree as IAppState but it's comparing to inequal.

This error message may add clarity to what I'm trying to explain.
I/flutter (12520): type 'IAppState' is not a subtype of type 'IAppState' where
I/flutter (12520):   IAppState is from file:///.../istore/lib/main.dart
I/flutter (12520):   IApp is from file:///.../istore/lib/main.dart
I/flutter (12520):   IAppState is from package:istore/main.dart
I/flutter (12520):   IApp is from package:istore/main.dart

This is unfortunately surprising behavior but currently working as expected. For more context see https://github.com/dart-lang/sdk/issues/32601.

Just ensure all imports paths in lib/main.dart start with 'dart:...' or 'package:...'

I made sure all imports are made with 'package:..'. Once I did that, call to context.ancestorStateOfType returns null.
Then I added a small routine which forcefully visits every ancestor to find the one with same type name (using the comparision element.state.runtimeType.toString()=="IAppState") and attempted to store it in IAppState (declared within the same file), now I get an error:
I/flutter (12520): type 'IAppState' is not a subtype of type 'IAppState' where
I/flutter (12520):   IAppState is from file:///.../istore/lib/main.dart
I/flutter (12520):   IApp is from file:///.../istore/lib/main.dart
I/flutter (12520):   IAppState is from package:istore/main.dart
I/flutter (12520):   IApp is from package:istore/main.dart

I/flutter (12520):   IApp is from file:///.../istore/lib/main.dart
I/flutter (12520):   IApp is from package:istore/main.dart

Still 2 different paths to the same file.
Do you import lib/main.dart anywhere?

It's hard to tell with the available information, but from above output I think there is something fishy with your file structure or imports. Perhaps you can make the code available in a public GitHub project?

I wrote a workaround.
// main.dart
import 'package:istore/main.dart' as main2;

// changed all uses of IApp to main2.IApp. This fixed the issue.

I will write a minimal app to demonstrate this error as soon as I find some free time. I am worried about why Dart distinguishes between different addressing schemes and wasting a day for every Dart developer.

Nope, I have no such import within the project.

import 'package:istore/main.dart' as main2;

I'd say importing main.dart is a very bad idea. Just move the code to another file and import the code from there.

This is a Dart issue.

cc @leafpetersen

@leafpetersen we have heard of this from multiple people.

I've filed this on the Dart team, I'm going to close this bug on our side.


状态机模式是否有必要强依赖es

servicecombo应该只是一个协调器，依赖es做历史记录查询是否有些太重了？
db查询的性能瓶颈在哪呢？把es做成一个可选项是一个更好的选择？

Currently, only the state machine model uses ES to store archived messages and front-end queries. You can implement the TransactionRepository interface according to your favorite storage. Just like ElasticsearchTransactionRepository.java

I want to know why use ES in FSM? Is it just a temporary solution? Or what other considerations?

ES is designed to provide an Improve query performance way to find and manage information on large transaction data


Add og images to talks

This PR builds upon #36 and adds images to all the talks to be shown on embed.
This PR also fixes quite a few other details:

It uses the correct links for og tags
It supports deploy domains in image links (you can test the og tags on the temporary netlify domain)
It fixes the  tag on the pages
It extracts some of the duplicate logic in templates

Note: The images are generated based using Sketch, the Data Populator plugin and the generated /content/_data/2020/talks_simple.json with the attached 20200722_dat-event-2020-banner.sketch and later optimized using ImageAlpha to produce 128bit color pngs (roughly 1/5th of the size).

Merging early, so we have it ready for the next meeting. Please revert if its a problem.


Skip pyside6 version 6.4.3 for tests

Description
This skips version 6.4.3 of pyside6 when testing to avoid the problems described in #5657. It does not close that issue, but at least reduces noise on the PR tests.
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

References
Related to #5657
How has this been tested?

[ ] all tests pass with my change

I'm unsure why the PR tests are skipped and also don't know how to manually force them. Given the simplicity of the change, I think it's probably fine to merge this anyway, but if anyone knows that would be useful info!

Thanks to the GitHub action for starting those as they caught my mistake of skipping 6.3.4 instead of 6.4.3 as desired.

I'm going to skip the usual 24 hours here to help PRs start passing again. Feel free to revert if you disagree with that.


NearDistance Breaks ENB Water Reflections

When passing the NearDistancePitchThreshold, ENB water reflections suddenly become very opaque. Increasing the NearDistance setting to compensate causes body clipping, so that isn't a solution.
Interestingly, Immersive First Person View doesn't really have this issue. Even with its NearClipExteriorDown setting at 1 (default is 3 but I usually use 8), the most disturbance is minor reflection flickering.
I am currently using ENBSeries v0.483 with Skyrim SE 1.5.97.

It is a known limitation for now unfortunately. I don't know enough about the engine how the NearDistance works as interiors it seems fine but exterior depending on graphical mods installed the opaqueness of water and shadows flickering can be very annoying!!!
IFPV works differently as it mimicks First Person by using the Third Person camera. IC only mimicks First Person where it has too, horse riding, werewolf, vampirelord etc. Why the mods are different.

I don't know what I did, but the issue is gone at the moment.
Things that changed with my game recently:

Uninstalled Water for ENB. (I use RW2 and wanted to try the Water for ENB textures. The issue could have been that I had forgotten to disable the Water for ENB meshes when I was still using the mod and they were causing the issue?)
Gerating LODs with DynDOLOD 3. (No clue how that could fix it.)
Updated a few mods that I can't remember.
The game weather changed over time. (The weather may have been part of the cause I guess.)

Is this what you mean. As you can see from my screenshots it doesn't look too bad due to my mod setup, if it was bog standard vanilla the water would look opaque. Both screenshots are taken with Water for ENB and using Rudy ENB Obsidian Weathers preset.
No Adjustment is Improved Camera's values at default. The other I adjusted NearDistancePitchThreshold until it kicked in.


Error while sending multiple files at the same time

Error: FileSystemException: Cannot retrieve length of file, path = '/private/var/mobile/Containers/Data/Application/.../tmp/....pvt'(OS Error: Is a directory, errno = 21)

The same problem happens when I try to transfer live photos to another device from my iPhone.  Ordinary images in JPEG can be transferred without problems.

The same problem occurs to me. Is there any method to ignore? I accept sending photos without live motion, how can I send the still versions without this error?

The same problem happens when I try to transfer live photos to another device from my iPhone. Ordinary images in JPEG can be transferred without problems. It seems like a live photo is not considered as a single file but as a folder containing a series of photos by LANDrop.

The same problem occurs to me.
And I found that if I share pics from the album and click the "Landrop", it won't show the error. But if choosing pics inside the Landrop app, the problem is always pop out.
Hope this way helps.

The same problem happens when I try to transfer live photos to another device from my iPhone. Ordinary images in JPEG can be transferred without problems. It seems like a live photo is not considered as a single file but as a folder containing a series of photos by LANDrop.

The same problem occurs to me.
And I found that if I share pics from the album and click the "Landrop", it won't show the error. But if choosing pics inside the Landrop app, the problem is always pop out.
Hope this way helps.

 Thanks a lot!


Further build improvements

I want to get to a point where someone who wants to work with the source code (eg debug it or enhance it) can clone the repo, then build it using the scripts in the Build folder without having to mess around to much, and end up with the same type library ids, interface ids, and class ids as the latest version committed here (for example so that the included sample apps can be run without having to rebuild everything).
For this to happen, the developer needs to be able to get the current versions of the binaries into his Bin folder, so that binary compatibility (or at least project compatibility) can be preserved when building his versions.
However it would not be good to include the binaries directly in the repo, because that would cause problems when a developer submits a pull request, since they'd have to deliberately exclude the binaries in their commits - which would be error prone. Much better to exclude all binaries using .gitignore (which is the current state of affairs).
So to achieve what we want, I will build the 'official' binaries, which will determine the 'official' type library, interface, and class ids. After each such build, I will create a new release that contains a .zip file and a Windows Installer (.msi) file:

the .zip file will be aimed at our intrepid developer, and will contain all the binaries. The developer will simply extract the binaries into the Bin folder, and then run the registerTradeWrightCommon.bat script to get the dll's and ocx's properly registered.

the .msi will be an end user installer, which will install and register all the executables and provide shortcuts for launching the sample programs.

the release will also include a merge module (.msm) file that may be useful for those who want to use it in their own projects and provide a .msi installer for them.

If the developer subsequently modifies any of the components in a way that potentially affects compatibility,  they may end up with class ids that don't match the 'official' ones. Provided this development is private (ie not promulgated outside the developer's system), this is fine. If the developer submits their enhancements for inclusion in the main repo, and they are pulled in (resulting in a new release), this will result in different ids from what they already had from their own build, so they will need to once more download the released binaries and rebuild their local version to ensure they have all the correct ids.
I currently intend to include the Visual Studio 2008 project for building the .msi and .msm files, but I may change my mind...

I need to rethink the above. The problem with it is that because the binaries are not pushed to the repository, it's not possible to recreate the full environment for an earlier build. For example, if it's necessary to fix a bug in or add a feature to a version that is not binary compatible with the current version, it's not simple to ensure all the correct binaries are in the right places to guarantee the right type library ids and class ids are carried forward in the fixed version.
Therefore we will now push dll's, ocx's and exe's.
To address the scenario above, suppose the current release is v4.1.124, and the previous release is v4.0.107. The developer must create a branch starting at version 4.0.107 to reconstruct the full file structure at that version for proper rebuilding: this new branch could be called v4.0 . Once the necessary changes have been made to this branch, it will not be sensible to merge it back into Master (which has moved way on), and the branch will have to remain permanently. A new release can then be created on that branch, which could be tagged v4.0.107a. Ssimilarly another round of fixes could be released a v4.0.107b, and so on..

Merged.


Combining appengine tests into coverage

Adds appengine tests to coverage tox env. The output from tox -e coverage is misleading:
 ~  workspace  oauth2client  master  $  tox -e cover
GLOB sdist-make: /Users/jonwayne/workspace/oauth2client/setup.py
cover inst-nodeps: /Users/jonwayne/workspace/oauth2client/.tox/dist/oauth2client-1.4.12.zip
cover installed: beautifulsoup4==4.4.0,cffi==1.2.1,coverage==3.7.1,cryptography==1.0,Django==1.8.4,enum34==1.0.4,Flask==0.10.1,funcsigs==0.4,httplib2==0.9.1,idna==2.0,ipaddress==1.0.14,itsdangerous==0.24,Jinja2==2.8,keyring==5.4,MarkupSafe==0.23,mock==1.3.0,nose==1.3.7,NoseGAE==0.5.7,oauth2client==1.4.12,pbr==1.6.0,pyasn1==0.1.8,pyasn1-modules==0.0.7,pycparser==2.14,pycrypto==2.6.1,pyOpenSSL==0.15.1,rsa==3.2,six==1.9.0,waitress==0.8.9,WebOb==1.4.1,WebTest==2.0.18,Werkzeug==0.10.4,wheel==0.24.0
cover runtests: PYTHONHASHSEED='4171150552'
cover runtests: commands[0] | nosetests --with-coverage --cover-package=oauth2client --cover-erase --cover-tests --cover-branches --ignore-files=test_appengine\.py
.............................................................................................................................................................................................................................................................................
Name                           Stmts   Miss Branch BrMiss  Cover   Missing
--------------------------------------------------------------------------
oauth2client                       7      0      0      0   100%
oauth2client._helpers             27      0      6      0   100%
oauth2client._openssl_crypt       41      0      4      0   100%
oauth2client._pycrypto_crypt      40      0      4      0   100%
oauth2client.client              725     83    207     44    86%   57-58, 164, 206, 215, 224, 232, 292-296, 355, 365, 372, 724, 741, 776, 889, 892-894, 931-932, 1221, 1237, 1258, 1345, 1418-1422, 1489-1491, 1495-1497, 1551, 1572, 1701, 1875-1896, 1999-2004, 2007, 2017, 2029-2067, 2093, 2095, 2098, 2113, 2222, 2227-2233
oauth2client.clientsecrets        49      0     18      0   100%
oauth2client.crypt                87     14     28      6    83%   44-49, 54-56, 62-66, 153, 167
oauth2client.devshell             53      0      8      0   100%
oauth2client.django_orm           68     26     22     14    56%   46, 48, 53, 71, 73, 78, 101-104, 112-120, 131-140, 145-146
oauth2client.file                 47      0      4      0   100%
oauth2client.flask_util          167      0     40      0   100%
oauth2client.gce                  39      0      4      0   100%
oauth2client.keyring_storage      29      0      2      0   100%
oauth2client.locked_file         183    101     64     47    40%   91, 100, 104, 124-158, 162-169, 173, 196, 216-230, 239-240, 245-329, 351, 356
oauth2client.multistore_file     165     17     24      7    87%   287-294, 360-363, 368-369, 372, 379-380, 386-388, 466-467
oauth2client.service_account      54      0      0      0   100%
oauth2client.tools               109     65     18     16    36%   54-55, 165-239, 244, 249, 252
oauth2client.util                 55     12     18      7    74%   138-141, 148-149, 219-226
oauth2client.xsrfutil             43      0     10      0   100%
--------------------------------------------------------------------------
TOTAL                           1988    318    481    141    81%
----------------------------------------------------------------------
Ran 269 tests in 8.911s

OK
cover runtests: commands[1] | nosetests --with-coverage --cover-package=oauth2client --with-gae --cover-tests --cover-branches --gae-application=tests/data --gae-lib-root=/Users/jonwayne/Downloads/google_appengine --logging-level=INFO tests/test_appengine.py
...................................
Name                           Stmts   Miss Branch BrMiss  Cover   Missing
--------------------------------------------------------------------------
oauth2client                       7      0      0      0   100%
oauth2client._helpers             27      0      6      0   100%
oauth2client._openssl_crypt       41      0      4      0   100%
oauth2client._pycrypto_crypt      40      0      4      0   100%
oauth2client.appengine           337     29     87     20    88%   53-54, 233, 238, 271, 301, 303, 306-307, 314, 347, 362, 378, 382-383, 413, 437, 716-718, 733-734, 758, 800-801, 866, 929, 977, 1016
oauth2client.client              725     82    207     43    87%   57-58, 164, 206, 215, 224, 232, 292-296, 355, 365, 372, 724, 776, 889, 892-894, 931-932, 1221, 1237, 1258, 1345, 1418-1422, 1489-1491, 1495-1497, 1551, 1572, 1701, 1875-1896, 1999-2004, 2007, 2017, 2029-2067, 2093, 2095, 2098, 2113, 2222, 2227-2233
oauth2client.clientsecrets        49      0     18      0   100%
oauth2client.crypt                87     14     28      6    83%   44-49, 54-56, 62-66, 153, 167
oauth2client.util                 55      6     18      6    84%   138-141, 148-149, 220
oauth2client.xsrfutil             43      0     10      0   100%
--------------------------------------------------------------------------
TOTAL                           1411    131    382     75    89%
----------------------------------------------------------------------
Ran 35 tests in 0.373s

OK
__________________________________________________________________________ summary ___________________________________________________________________________
  cover: commands succeeded
  congratulations :)

Running coverage report shows that the coverage is actually combined between the two runs:
Name                           Stmts   Miss Branch BrMiss  Cover
----------------------------------------------------------------
oauth2client/__init__              7      0      0      0   100%
oauth2client/_helpers             27      0      6      0   100%
oauth2client/_openssl_crypt       41      0      4      0   100%
oauth2client/_pycrypto_crypt      40      0      4      0   100%
oauth2client/appengine           337     29     87     20    88%
oauth2client/client              725     82    207     43    87%
oauth2client/clientsecrets        49      0     18      0   100%
oauth2client/crypt                87     14     28      6    83%
oauth2client/devshell             53      0      8      0   100%
oauth2client/django_orm           68     26     22     14    56%
oauth2client/file                 47      0      4      0   100%
oauth2client/flask_util          167      0     40      0   100%
oauth2client/gce                  39      0      4      0   100%
oauth2client/keyring_storage      29      0      2      0   100%
oauth2client/locked_file         183    101     64     47    40%
oauth2client/multistore_file     165     17     24      7    87%
oauth2client/old_run              77     70     16     16     8%
oauth2client/service_account      54      0      0      0   100%
oauth2client/tools               109     65     18     16    36%
oauth2client/util                 55      6     18      6    84%
oauth2client/xsrfutil             43      0     10      0   100%
----------------------------------------------------------------
TOTAL                           2402    410    584    175    80%

Coveralls should pick up the combined coverage.
This removes nosexcover as well.

@jonparrott Can we surprise the twice run output and just use coverage report? Is there a way to get missing line numbers in coverage report?

I want to hold off on removing xcover until we understand it better (e.g. maybe Tres will have something to say on the issue).

There doesn't seem to be a way to suppress the immediate report on each run. As mentioned, I can add coverage report at the end.

Yes, coverage report -m will show missing numbers:
Name                           Stmts   Miss Branch BrMiss  Cover   Missing
--------------------------------------------------------------------------
oauth2client/__init__              7      0      0      0   100%
oauth2client/_helpers             27      0      6      0   100%
oauth2client/_openssl_crypt       41      0      4      0   100%
oauth2client/_pycrypto_crypt      40      0      4      0   100%
oauth2client/appengine           337     29     87     20    88%   53-54, 233, 238, 271, 301, 303, 306-307, 314, 347, 362, 378, 382-383, 413, 437, 716-718, 733-734, 758, 800-801, 866, 929, 977, 1016
oauth2client/client              725     82    207     43    87%   57-58, 164, 206, 215, 224, 232, 292-296, 355, 365, 372, 724, 776, 889, 892-894, 931-932, 1221, 1237, 1258, 1345, 1418-1422, 1489-1491, 1495-1497, 1551, 1572, 1701, 1875-1896, 1999-2004, 2007, 2017, 2029-2067, 2093, 2095, 2098, 2113, 2222, 2227-2233
oauth2client/clientsecrets        49      0     18      0   100%
oauth2client/crypt                87     14     28      6    83%   44-49, 54-56, 62-66, 153, 167
oauth2client/devshell             53      0      8      0   100%
oauth2client/django_orm           68     26     22     14    56%   46, 48, 53, 71, 73, 78, 101-104, 112-120, 131-140, 145-146
oauth2client/file                 47      0      4      0   100%
oauth2client/flask_util          167      0     40      0   100%
oauth2client/gce                  39      0      4      0   100%
oauth2client/keyring_storage      29      0      2      0   100%
oauth2client/locked_file         183    101     64     47    40%   91, 100, 104, 124-158, 162-169, 173, 196, 216-230, 239-240, 245-329, 351, 356
oauth2client/multistore_file     165     17     24      7    87%   287-294, 360-363, 368-369, 372, 379-380, 386-388, 466-467
oauth2client/old_run              77     70     16     16     8%   26-164
oauth2client/service_account      54      0      0      0   100%
oauth2client/tools               109     65     18     16    36%   54-55, 165-239, 244, 249, 252
oauth2client/util                 55      6     18      6    84%   138-141, 148-149, 220
oauth2client/xsrfutil             43      0     10      0   100%
--------------------------------------------------------------------------
TOTAL                           2402    410    584    175    80%

Yay for coverage report -m.
As for suppressing output, we could do it the old-fashioned way: nosetests ... > /dev/null 2>&1.

lol... uh. Yes, I suppose we could do that, but I'd really rather not. :P

Another option is to redirect the report to HTML:
http://stackoverflow.com/questions/5065455/how-to-disable-nose-tests-coverage-report
http://stackoverflow.com/questions/11725193/disabling-nose-coverage-report-to-stdout-when-html-report-is-enabled
Though I'm not sure that will leave around the bits in .coverage which coverage report picks up.

Meh, that also feels really hacky.

Pushed a new commit. This adds a base cover environment in tox, and modifies cover and coverall to use that, plus now cover will run coverage report -m --fail-under 80.

Meh, that also feels really hacky.

We have a trade-off here between what feels hacky and what looks like. I'm valuing the output over the stuff we have to do.
Something else we haven't mentioned: Why is --ignore-files=test_appengine\.py even necessary?
When I removed it (and had the google_appengine SDK in the PYTHONPATH) the issue was caused by
tests/test_django_orm.py:32:    use_library('django', '1.5')

I'll look into suppressing the output.

Something else we haven't mentioned: Why is --ignore-files=test_appengine.py even necessary?

If we add an import check for dev_appserver or google.appengine and raise skiptest we no longer have to explicitly exclude it. However, we do still need to run the test itself separately.

We don't want to skip the tests. We want to check the coverage. I don't think the conflict needs to occur,  but it may take a little work to get them to all run together.

I'm not sure what you mean?

If we add an import check for dev_appserver or google.appengine and raise skiptest

We don't want raise SkipTest because we want to get a complete picture of coverage.

I'm still not following. Are you wanting to move to one run of nosetests instead of two?

Yes that was the point of

Why is --ignore-files=test_appengine\.py even necessary?

I've been down that path, and it's not a fun one. dev_appsever / nosegae does a lot of horrible, horrible things to python. It's almost impossible to undo what it does enough to be certain that your other tests aren't tainted by GAE.

OK I trust you. Then let's focus on the output suppression?
Also, any idea why
oauth2client
oauth2client._helpers
oauth2client._openssl_crypt
oauth2client._pycrypto_crypt
oauth2client.appengine
oauth2client.client
oauth2client.clientsecrets
oauth2client.crypt
oauth2client.util
oauth2client.xsrfutil

all show up when just oauth2client.appengine is tested?

all show up when just oauth2client.appengine is tested?

Probably because those modules are used by the appengine module.

I think having to run --gae-lib-root={env:GAE_PYTHONPATH} could be problematic. Do we have Travis set-up for this? (I just did an wget https://patch-diff.githubusercontent.com/raw/google/oauth2client/pull/287.patch, then git am 287.patch so I could play around with this.)
I feel like the commands are so long, they belong in a bash script anyhow. (How does that impact Windows users? Or even zsh users?)

Travis will work for GAE_PYTHONPATH, as it's set for the app engine tests.

I feel like the commands are so long, they belong in a bash script anyhow. (How does that impact Windows users? Or even zsh users?)

That is not fun. :P It's not unheard of for your nose commands to be a bit long for coverage.

FYI I figured out how to limit the output of just the appengine coverage report:
diff --git a/tox.ini b/tox.ini
index 0cfbac7..5e05741 100644
--- a/tox.ini
+++ b/tox.ini
@@ -28,7 +28,7 @@ commands =
       --ignore-files=test_appengine\.py
     nosetests \
       --with-coverage \
-      --cover-package=oauth2client \
+      --cover-package=oauth2client.appengine \
       --with-gae \
       --cover-tests \
       --cover-branches \

I had forgotten that you set
.travis.yml:16:  - GAE_PYTHONPATH=${HOME}/.cache/google_appengine

before.

That can keep it from blocking this PR, but I still plan on making it smarter.

Alright, I pushed that diff you sent over, so the output it now just the appengine module.
Do you still want to silence the output?

Let's just leave it as-is for now and deal with it if it becomes annoying.

I still want to hold off until we hear from Tres about nosexcover.

SGTM.


Cannot process AsyncAPI YAML document

You cannot give the generator a stringified JSON input or a YAML document, as it does not currently know how to process it.

Solved in https://github.com/asyncapi/modelina/pull/2023


Root Component prefix and other Component prefixes should be consistent and pass ng lint

We need to think how this should work. Consistency is key, IMO
When I generate a new app and create components, the prefixes are not consistent and therefore ng lint barks that we have inconsistent prefixes.
ng new force
cd force
ng g c foo
ng g c bar

We now have

ForceAppComponent with a selector of force-app
FooComponent with a selector of app-foo
BarComponent with a selector of app-bar

Then we add an ng lint rule in tslint.json like this (so we can follow the guide)
    "component-selector-prefix": [
      true,
      "app"
    ],

If we run ng lint we hear
$ ng lint
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.

><EMAIL_ADDRESS>lint /Users/john/_play/tmp/force
> tslint "src/**/*.ts"

src/app/bar/bar.component.spec.ts[38, 13]: The selector of the component "BarComponentTestController" should have prefix "app", however its value is "test".
src/app/foo/foo.component.spec.ts[38, 13]: The selector of the component "FooComponentTestController" should have prefix "app", however its value is "test".
src/app/force.component.ts[5, 13]: The selector of the component "ForceAppComponent" should have prefix "app", however its value is "force-app".

cc @mgechev @Brocco  @wardbell

cc @cburgdorf

This conversation has already been started and the current solutions being proposed are:

Change the app component's selector to use a prefix of app instead of a suffix. So the root/app component would end up being app-force in based upon the above example

Slight variation of prefixing a discrete value of app would be to use the optional --prefix argument's value to prepend to the root component's selector

Leave the suffix of app as is and also prefix with the configured --prefix value (app by default). The resulting app component's selector could end up being app-force-app.

Modify codelyzer to ignore/not check the root component's selector. In this case the selector for the app component could remain force-app

Obsolete issue, implemented as of now.

FYI codelyzer now supports multiple prefixes https://github.com/mgechev/codelyzer/commit/91c952225c496e0ec3c6a0d4043be1fc99dd203a.

@mgechev sweet! Could you make a PR adding the prefix rule?

@filipesilva I'll do that as soon as I get a chance.


events search is case sensitive

this might be an issue for all searches!

issue in production only

fixed by @vigliag : d3ab7848ae93330391a2dad9893149997eb30674


Fixes SQS Queues shutting down gracefully

Allow queueStopTimeout can be configurable via SimpleMessageListenerContainerFactory #gh-504
Increase queueStopTimeout default value in milliseconds to be equal to waitTimeOut #gh-507

@mkatircioglu thanks for the PR! looks good to me but wondering if we can add a configuration property for queueStopTimeout which will offer more flexibility. WDYT?

What kind of configuration property do you mean? Since there are some other properties in SimpleMessageListenerContainerFactory which might need to be configured too if we think to give some flexibility. @eddumelendez

Hi @eddumelendez According to my comments, what is your latest opinion? Would you like me to update the PR?

Since configuring custom SimpleMessageListenerContainerFactory is currently THE way to configure SQS listeners - we do not have configuration properties for SQS (yet) - this PR looks good to me. If you agree @eddumelendez I would be happy to merge it to 2.3.x branch.

Thanks for the input. Please go ahead! 👍🏽


Add a function to list all the allowlisted crates with their respective versions, features

Since we have created introduced the mechanism to support allow-listing certain crates, it'd be useful to have a function that lists what are the allow-listed crates with their respective versions, and features etc.
One idea is to make a function returning a table like,
postgres=# select plrust.allowed_dependencies();
 allowed_dependencies
----------------------
 (serde,1.0,{derive})
(1 row)

postgres=#

$ > cat ~/allow.toml
serde = { version = "=1.0", feature = ["derive"] }

This is a fine idea. Are you planning on submitting a PR or would you prefer we do it?

I would be happy to work on it!


Is there a way to remove item attached to app menu header when drawer is small?

As shown below snipped, we attach a logo to HEADER Section, and we don't want to display that logo when drawer is small (Display only when drawer is normal size).
AppLayout layout = AppLayoutBuilder
            .get(variant)
            .withTitle("Project")
            .withAppBar(appBar)
            .withDesign(AppLayoutDesign.MATERIAL)
            .withAppMenu(LeftAppMenuBuilder
                    .get()
                    .addToSection(Logo, HEADER)
                    .add(new LeftNavigationComponent("Menu1", VaadinIcon.COGS.create(), View.class))
                    .add(new LeftNavigationComponent("Menu2", VaadinIcon.AUTOMATION.create(), View2.class))
...

Thank you in advance.

Which behavior are you using?

variant = Behaviour.LEFT_HYBRID;

Some css as app-layout-left-hybrid[narrow] { ... } should do the job.

I couldn't make it work. Is it possible for you to give an example?
Logo element is defined like below. Where should I that css and how?

Where should I that css and how?

In the style section?
<dom-module id="logo-element">
  <template>
    <style>
    <!-- Here -->
    </style>
    ...
</dom-module>


Add parameters to the fakeintake component on Azure

What does this PR do?
Add parameters to the fakeintake component on Azure
Which scenarios this will impact?
Azure ones only
Motivation

The imageUrl is a parameter on the AWS side too
We might add more in the future
We use it to avoid deploying the fakeintake in AWS tests and I'd like to do the same for consistency

Additional Notes

/merge

/merge


Appium 2.0 Press KeyCode event doesn't work

When I use the Press KeyCode event, the driver trow following error on Appium 2.0.
WebDriverException: Message: Method has not yet been implemented
Stacktrace:
NotYetImplementedError: Method has not yet been implemented
at FlutterDriver.executeCommand (/Users/yahya.kara/.appium/node_modules/@appium/base-driver/lib/basedriver/driver.js:67:13)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at FlutterDriver.executeCommand (/Users/yahya.kara/.appium/node_modules/appium-flutter-driver/lib/driver.ts:139:16)
at defaultBehavior (/usr/local/lib/node_modules/appium/lib/appium.js:673:14)
at AppiumDriver.executeWrappedCommand (/usr/local/lib/node_modules/appium/lib/appium.js:763:16)
at AppiumDriver.executeCommand (/usr/local/lib/node_modules/appium/lib/appium.js:685:17)
at asyncHandler (/usr/local/lib/node_modules/appium/node_modules/@appium/base-driver/lib/protocol/protocol.js:346:19)
Could you help me  about  How can I use the press key code keyword

Hey @yahyakara
This error is occurring cause this method was not implemented yet.
We are working in the new version with this method implemented.


More descriptive error outputs

$e passes useful information that currently is not being taken advantage of. With this change

would become

Cheers


[EDIT] Nelson Mandela paintings from 2002, not from when he was incarcerated

Entry
Nelson Mandela's paintings from prison to be sold as NFTs
Changes
The watercolours where created long after Mandela was released from prison and after he stood down as president in 1999.
From the theguardian:

My Robben Island consists of five vivid watercolours painted by Mandela after he stood down as president in 1999, plus The Motivation, a handwritten text that explains his visualisation of the harsh island prison. All six works bear his signature.

The watercolours, painted in 2002 as a therapeutic activity under the guidance of the art teacher Varenka Paschke.

Therefore I recommend these changes:
Title:

Nelson Mandela's paintings of prison life to be sold as NFTs

First sentence:

The Guardian reported that five watercolor paintings of prison life  created by former South African president Nelson Mandela will be sold as NFTs next month, as well as a handwritten description of why he created the artwork.

Agreement
By submitting this issue, I irrevocably agree to release my contribution under the CC-BY 3.0 License. I agree that a hyperlink or URL is sufficient attribution under the Creative Commons license.
Please attribute this contribution to:
Joseph

Thank you! Fixed.


Allow ECDHE and DHE as forward-compatible aliases for EECDH and EDH

see PR #3203
Future versions of OpenSSL use the canonical terms "ECDHE" and "DHE"
as configuration strings and compilation constants.  This patch
introduces aliases so that the stable 1.0.2 branch can be
forward-compatible with code and configuration scripts that use the
normalized terms, while avoiding changing any library output for
stable users.

This has been applied to the 1.0.2 branch some time ago.


Create style variables to customize component

Create style variables to allow developers to modify key styles such as colors, fonts, spacing, and other design elements. These variables should provide an easy way to customize the component’s look without altering its core structure.
Examples:

any updates on this ?
im struggling to customize the styling

Check this: https://github.com/juanjotorres90/ngx-material-intl-tel-input/issues/19#issuecomment-2332390908
This library uses Angular Material components, so styling them should be similar.
This is an open-source project, feel free to request a PR to add any variables you might need.
Thank you 😉


Add issue tracking to checkcomments analyzer

Description
Implemented github issue tracking for checkcomments analyzer, uses lockedfile to limit number of requests.

Closes #2733
Readiness checklist

[x] I added/updated unit tests (and they pass).
[ ] I added/updated integration/compatibility tests (and they pass).
[ ] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[ ] I ensured that PR title is good enough for the changelog.
[ ] (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
[ ] I marked all done items in this checklist.

Oh, sorry, we missed that. Will review shortly

Thank you!


Pnt 270 pnt rename

PNT -> PEG rename
The code will always handle PEG, and the json marshaling will do the switch
Issue #270

Rebased https://github.com/pegnet/pegnet/pull/281


(WIP) Apply moduleId to @Component annotation

Hey again guys, sorry, i had to open a new PR since my local rebase failed.
This commit sets the moduleId property of the @Component annotation to enable
templateUrl and styleUrls to be only the file name without the
surrounding path.
$ npm start and using the app in the browser runs fine so far, however $ npm test fails:
[22:27:52] Plumber found unhandled error:
 Error in plugin 'gulp-inline-ng2-template'
Message:
    ENOENT: no such file or directory, open '/Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/about.component.html'
Details:
    errno: -2
    code: ENOENT
    syscall: open
    path: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/about.component.html
    fileName: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/app/+about/about.component.ts
[22:27:52] Plumber found unhandled error:
 Error in plugin 'gulp-inline-ng2-template'
Message:
    ENOENT: no such file or directory, open '/Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/home.component.html'
Details:
    errno: -2
    code: ENOENT
    syscall: open
    path: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/home.component.html
    fileName: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/app/+home/home.component.ts
[22:27:52] Plumber found unhandled error:
 Error in plugin 'gulp-inline-ng2-template'
Message:
    ENOENT: no such file or directory, open '/Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/navbar.component.html'
Details:
    errno: -2
    code: ENOENT
    syscall: open
    path: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/navbar.component.html
    fileName: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/app/shared/navbar/navbar.component.ts
[22:27:52] Plumber found unhandled error:
 Error in plugin 'gulp-inline-ng2-template'
Message:
    ENOENT: no such file or directory, open '/Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/toolbar.component.html'
Details:
    errno: -2
    code: ENOENT
    syscall: open
    path: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/toolbar.component.html
    fileName: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/app/shared/toolbar/toolbar.component.ts
[22:27:52] Plumber found unhandled error:
 Error in plugin 'gulp-inline-ng2-template'
Message:
    ENOENT: no such file or directory, open '/Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/app.component.html'
Details:
    errno: -2
    code: ENOENT
    syscall: open
    path: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/app.component.html
    fileName: /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed/src/client/app/app.component.ts
[22:27:54] Finished 'build.js.test' after 3.17 s

Is there a further update to some configuration (SystemJS, CommonJS, the builder?) neccessary to make it work?
$ npm run e2e runs fine though:
# DonDope @ DonDope-MacBook in ~/Development/GitHub/TheDonDope/angular2-seed on git:master o [15:42:38]
$ npm run e2e

><EMAIL_ADDRESS>e2e /Users/DonDope/Development/GitHub/TheDonDope/angular2-seed
> protractor

[22:33:27] I/direct - Using ChromeDriver directly...
[22:33:27] I/launcher - Running 1 instances of WebDriver
Spec started
Started

  About
    ✓ should have correct feature heading
.
  Home
    ✓ should have an input
.    ✓ should have a list of computer scientists
.    ✓ should add a name to the list using the form
.
  App
    ✓ should have a title
.    ✓ should have <nav>
.    ✓ should have correct nav text for Home
.    ✓ should have correct nav text for About
.
Executed 8 of 8 specs SUCCESS in 16 secs.

8 specs, 0 failures
Finished in 16.263 seconds
[22:33:45] I/launcher - 0 instance(s) of WebDriver still running
[22:33:45] I/launcher - chrome #01 passed

@TheDonDope gulp-inline-ng2-template config needs to be updated. Set that one (https://github.com/mgechev/angular2-seed/blob/master/tools/tasks/seed/build.js.test.ts#L28) to ture

@ludohenin Thank you for the solution :)))
I'll update and push another commit :)

Weird, my local $ npm test now runs fine, but the CI builds still fail with the same error.

🎉  It works now :) :shipit:


AWS Gamelift sdk for Unity

Hi, I am trying to write client side code using AWSGameLift API for my Unity project. Is GameLift service available for .NET 3.5 ?
I am using Unity 2017.4.3f1 version. I have changed my project settings to support .NET 4.6 Experimental and restarted unity. I was able to install Amazon game lift for my project using nuget package manager in visual studio. Then, I was able to access Amazon GameLift API in my vs code. But API was still inaccessible in Unity editor (there were errors at using Amazon code) . And after sometime they became inaccessible in vs too. Does anyone know why, and how to solve this issue?

Dup: #973

Closing as a duplicate.  Please also review our AWS SDK for .NET v3.5 preview if you haven't already.  Switching to targeting our .NET Standard code will allow Unity developers to access all of our AWS services.


Filter images by open issues

My actions before raising this issue

[ x] Read/searched the docs
[ x] Searched past issues

In our use case we would like to filter images by issues. After the reviewer adds the issues to a job, the annotator would like to navigate quickly through only the images that have open issues.
From playing around with the UI and reading the documentation that currently does not seem to be possible.
Possible Solution
Possibly adding "issue" option to the rules in the filter modal or an arrow like button that cycles only through images with open issues.

Hi @mlenarsic
There is ability to navigate between frames with issues (but it navigates even through closed issues, nevertheless might be helpful for you):

https://openvinotoolkit.github.io/cvat/docs/manual/advanced/review/

Oh great I was focusing on getting it work with the filters and completely missed this part of the documentation somehow. This covers our requirements nicely. Thank you!


Added default setting for conversion, and currency directive now respects default currency

I'm working on a project that would really benefit from setting a default value for currency conversion, as well as from the @currency directive also respecting the default currency setting.
We currently store values as decimals already, and we only support one global currency. It's a lot less work to just be able to mindlessly use @currency and @money and not worry about anything else.
As such I would like you to consider these changes and pull them into the repository.

Setting the default value to null while the type-hinting is set to bool or string doesn't work.


erlang_nif-sys is not up to date

I received the following error:
error: failed to run custom build command for erlang_nif-sys v0.6.4
Unsupported Erland version.
Is the erlang_nif-sys version up to date in the Cargo.toml?
Does 'cargo update' fix it?
If not please report at https://github.com/goertzenator/erlang_nif-sys.
cargo update does not fix this.

See https://github.com/rusterlium/erlang_nif-sys/pull/39#issuecomment-582134181, can you migrate to rustler_sys?


Simplify conditional expression

Problem
The conditional expression is not easy to read.
Solution:
Simplify conditional expression
Result:
made it easier to read
This commitment supports to open source community for Hacktoberfest.

I think the way it was written had a clearer intent.

I think the way it was written had a clearer intent.

The important thing is that anyone who does maintenance can easily read the code. Nobody can read intent.

Hi @joschi , @arteam what do you think about this pull request.

@elifnurcevik Thanks for your contribution.
I would agree with @jplock here that the original version was more straight forward to read.


change lambda lesson_8

This is a PR for @grosu to review kore transition changes made in lambda.k
It is easier and more efficient for me to make a PR on lesson 8 as lesson 9 is already merged.
I checked that the difference is lesson 9 added comments and div by zero.
Please do NOT merge this.

Looks good, thanks @laurayuwen.  One thing that I'm not sure about, in all our definitions, is the terminology -COMMON and -SYNTAX.  I'd like to think a bit more about it, but in the meanwhile, if you guys have any suggestions I'd be glad to hear them.

@grosu, regarding module naming, please have a look at this issue: #1933

@grosu In order to pass Jenkins test, I also updated lesson_9, you can just review lesson_8
@cos Could you also have a look?

lgtm.  I guess we can merge, but please let's not do other languages until we get rid of this --COMMON thing.

got it. And the reviewer does the merge.


bug: range_reader(offset..) with larger seek could produce inconsist behavior

o.range_reader(offset..) to open an ObjectReader
Seek to a very large pos like u32::MAX
Read to end

Some services will return Ok(0), but some services could return errors.
I'm not sure if this behavior should be treated as a bug.
Docs from std::io::Seek:

A seek beyond the end of a stream is allowed, but behavior is defined by the implementation.

Docs from std::io::Read:

This reader has reached its “end of file” and will likely no longer be able to produce bytes. Note that this does not mean that the reader will always no longer be able to produce bytes. As an example, on Linux, this method will call the recv syscall for a TcpStream, where returning zero indicates the connection was shut down correctly. While for File, it is possible to reach the end of file and get zero as result, but if more data is appended to the file, future calls to read will return more data.

Seems not a big issue.


Add support for search

Hi.
It doesn't seem like hubcaps supports the search API.
It would be useful to be able to search repositories, users, issues, etc.
For more information, see https://developer.github.com/v3/search/

That's a good point @mkroman. I can look into this

@mkroman I published a new version of hubcaps initial support for searching issues. im going to open up separate specific issues for support for searching code and repos


fix(getComponentInfo): subcomponents from js files

Currently, we consider any file in a component directory to be a subcomponent.  However, there was a stray markdown file in /src/modules/Dropdown/TODO.md that resulted in a "subcomponent" called "TODO" on the Dropdown.
This PR strictly limits subcomponent identification to JS files in component directories.

Codecov Report

Merging #2862 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2862   +/-   ##
=======================================
  Coverage   99.66%   99.66%
=======================================
  Files         161      161
  Lines        2722     2722
=======================================
  Hits         2713     2713
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a30105...95d38af. Read the comment docs.

Released in<EMAIL_ADDRESS>


[Implement] : FAB

Description
[implement] : FAB

Implemented the basic functions of the FAB
* Can use IconButton that is a default button component of FAB by passing the icon types and callbacks.
* Can replace the default button component of FAB by passing renderButton function
* Can set absolute position of FAB
* Can replace buttons by active Props

Rendering conditions:
if(active===false)render DefaultFAB
if(active===true)render ActiveFAB and ActionButtons
please comment about the structure of Component.
**Animation is not implemented**
**Need more implementation**

Related Issues
[FloatingActionButton] implementing floatingActionButton component
Tests
I did not add the test yet.
This PR needs more implementation.
Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] Run yarn test or yarn test -u if you need to update snapshot.
[X] Run yarn lint
[X] I am willing to follow-up on review comments in a timely manner.

I slightly look into it. I think maybe it will be easier for me to understand if you provide some example code and output.
But It was totally fine.
Ok. As I understand,  FABList is rendered only when Active. And DefaultFAB/ActiveFAB is chosen by Active state.
Also, ActiveFAB, DefaultFAB, and FABItem can have render function or it is rendered as default form.
I think overall structure is fine, but naming can be better.

I think DefaultFAB is the most confusing part.  Default <--> Active should be replaced with Inactive <--> Active or Expanded <--> Collapsed. And the word Default should be used for without render function situation.
ActiveFAB and  FABItem has Parent-Children relation, but it is not revealed with name.

BTW,  this might be silly mistake of mine, but I'm seeing icon never changes.
I'm always seeing same icon whenever I change iconName string.
I'm using like this.
<FAB
  active={true}
  ActiveFAB={{icon: 'cross-light', onPress: () => null}}
  DefaultFAB={{icon: 'cross-light', onPress: () => null}}
  FABList={[
    {icon: 'chevron-down-light', onPress: () => null},
    {icon: 'chevron-down-light', onPress: () => null},
    {icon: 'chevron-down-light', onPress: () => null},
  ]}
/>

It's hard to communicate many changes at once with review(and codecov warning is annoying 😄 ), so I pasted code below.
This is just a suggestion. Feel free to point out anything. :)

I can't be sure this refactor guarantee same functionality as before because there's no test code. But I think It is sufficient for suggestion.
theme is not provided to defaultSubRenderer in code below. It should be changed. maybe useTheme is needed?

const defaultRootRenderer = ({icon, onPress}: FABItem): React.ReactElement => (
  <IconButton icon={<StyledIcon size={24} name={icon} />} onPress={onPress} />
);

const defaultSubRenderer = (
  {icon, onPress}: FABItem,
  _index: number,
): React.ReactElement => (
  <IconButton
    icon={<StyledIcon theme={theme} size={24} name={icon} />}
    onPress={onPress}
  />
);

const FloatingActionButtons: FC<
  FloatingActionButtonsWrapperProps & {theme: DoobooTheme}
> = ({
  theme,
  active,
  inactiveRootItem,
  activeRootItem,
  subItems,
  renderInactiveRootItem = defaultRootRenderer,
  renderActiveRootItem = defaultRootRenderer,
  renderSubItem = defaultSubRenderer,
  zIndex = 0,
  top = 'auto',
  bottom = 'auto',
  left = 'auto',
  right = 'auto',
}) => {
  return (
    <FABContainer
      style={{
        top,
        bottom,
        left,
        right,
        zIndex,
      }}>
      <Animated.View>
        {active &&
          subItems.map((item, idx) => (
            <ItemContainer key={item.icon + idx}>
              {renderSubItem(item, idx)}
            </ItemContainer>
          ))}
      </Animated.View>
      <ItemContainer>
        {active
          ? renderInactiveRootItem(inactiveRootItem)
          : renderActiveRootItem(activeRootItem)}
      </ItemContainer>
    </FABContainer>
  );
};

export const FAB = withTheme(FloatingActionButtons);

Also the generic can be extended like below
interface FABItemProp {
  icon: string;
  name: string;
}

type Props<T extends FABItemProp> = {

@hyochan  thanks
It is very good idea to use generic extended the FABItem.
It will give more flexibility to  FAB component

but I think we should support default components such as with conditionals.
Because it makes it much easier to use components. It will improve developers' experience in use.

@wndudqus  For sure. My code above support default components, but I remove conditional using default value feature which language provides.
// code from props destructing above
renderInactiveRootItem = defaultRootRenderer,
renderActiveRootItem = defaultRootRenderer,
renderSubItem = defaultSubRenderer,

Note that I set default render function that I defined above. User can provide render function, or omit it.
Is there's anything I misunderstood, please let me know.

@yujong-lee
Oh, I see... I think this approach seems to simplify the code.
How do you think? @hyochan

the

Yes for the default component~ You can try @yujong-lee 's proposal 👍

@yujong-lee
Oh, I see... I think this approach seems to simplify the code.
How do you think? @hyochan

Yes for the default component~ You can try @yujong-lee 's proposal 👍

When FAB first renders, it doesn't hide the children. It should not run the animation when it shouldn't and also should follow isActive prop.
When looking in your code I see that you are showing children with opacity animation.

I have some issues with the above design.

The FABItem should appear from the main FAB button but they are just appearing from their target positions. I think we need to change that.
As told previously, it should behave with actual prop value.

Additionally, the custom render function would not want to receive the callback for the press event. It'd only want to provide a different UI element.
{FABList.map((item, idx) => {
  return (
    <TouchableOpacity onPress={onPressFABItem?.(item)}>
      {renderFABListItem ? (
        renderFABListItem(item, idx)
      ) : (
        <StyledIcon theme={theme} size={24} name={item.icon} />
      )}
    </TouchableOpacity>
  );
})}

@hyochan @yujong-lee
I think I covered most of your reviews

change Props naming
changed behavior
Previously, only the transparency of the button was adjusted depending on the state but now the actual position is adjusted.
3. Change state management.
Previously, the active was managed as a "state", modified to manage it as a "props".
4.  path name changed
FloatingActionButtonWrapper> FAB
Bug that state was not synced with UI has fixed

https://user-images.githubusercontent.com/35381940/133622429-09a1282c-e65c-4006-84d8-91daa1f9c508.mp4

There's still some parts that is not reflected in code review. For example, renderProp, or styles.(buttonWrapperStyle is better replaced with styles.)
If some reviews are not acceptable, feel free to tell me and have a discussion. It should not be one-sided.
But since this pull request is old and big, let's take care of this in later PR.
Thank you for great work on this!

@yujong-lee   oh I left some comment about your review like renderProp, but I forgot to submit the review so.. my mistake sorry


Try fix spurious C++ compilation failures on nightly build

What
We currently get spurious failures on Nightly
https://github.com/rerun-io/rerun/actions/runs/9856973608/job/27216926987
due to missing opencv headers. Common wisdom online ranges from "install that package" to "create a symlink from python packages to that system dir".
Attempting to tackle this with a slightly different package setup.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check


GH-39712: [Java] Enable code review and formatting code through Spotless Maven plugin

Rationale for this change
To enable code review and formatting code by using Spotless Maven plugin.
What changes are included in this PR?

[X] Maven configuration to enable Spotless Maven plugin.
[x] Documentation how to use ´mvn spotless:apply´

Are these changes tested?
By ´mvn spotless:apply´
Are there any user-facing changes?
No

Closes: #39712

Please consider: Initial formatting implementations will require a large number of file changes.
Among the main changes that need to be reviewed are:

pom.xml
maven/pom.xml
bom/pom.xml

@davisusanibar shall we hold this merge until we merge the errorprone fixes?
Then it will help a lot to clean up everything at once?

@davisusanibar shall we hold this merge until we merge the errorprone fixes? Then it will help a lot to clean up everything at once?

Hi @vibhatha, this sounds like a good idea to me.

The documentation has been added, please review if more details need to be added.
CC: @vibhatha @lidavidm @danepitkin

The documentation has been added, please review if more details need to be added.
CC: @vibhatha @lidavidm @danepitkin

File at: https://github.com/apache/arrow/blob/b6d012523c3d1627851bde20944401114259d9c6/docs/source/developers/java/development.rst#code-style

(1) did you mean to leave this in draft
(2) is it perhaps possible to enable this one module at a time?

(1) did you mean to leave this in draft (

Our plan was to merge first https://github.com/apache/arrow/pull/39777 https://github.com/apache/arrow/pull/39713#issuecomment-1903108403

is it perhaps possible to enable this one module at a time?

Let me break this down into modules.

In order to define a better alternative solution, the current pull request has been closed

In order to define a better alternative solution, the current pull request has been closed

Created an issue: https://github.com/apache/arrow/issues/40757


Assign a custom domain should not ignore regions field.

Hi there!
It's reproducible following some steps. I have used now.json to config my deployment process. I have filled the region field to make the deploy just on sfo1 and the alias field to have the latest deployment on a readable URL.
// now.json
{
 "name": "no-name-project",
 "alias": ["fake-alias"],
 "regions": ["sfo1"]
}

Then, just type:

now
now alias
now scale fake-alias.now.sh sfo1 1

Until here, I have my scaled deployment on sfo1 and everything work fine.
The issue appears when I try to have a custom domain. For instance: my-fake-custom-domain.com.

now alias fake-alias.now.sh my-fake-custom-domain.com

My deployment is scaled on sfo1 and bru1.

When you assign an alias to a domain, the scaling rules of the deployment that was previously located behind that alias are assigned.
What do you need to do is now scale my-fake-custom-domain.com instead of now scale fake-alias.now.sh in order to prevent it.


Add the Total fields to the SearchResp struct

Description
The opensearch Search reference documentation give some information on the track_total_hits parameter but doesn't include the full response body when it's used. track_total_hits is useful when you're trying to get a count of all hits in a given index for a given query without using the scroll api or some other traching mechinism.
This PR adds the return values structure for the track_total_hits parameter into the SearchResp structure.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I did mean to close it. I was incorrect and I believe the SDK already handles this case.


Update the storage sub-schema validation to restrict duplicate fields from being set.

This allows us to control what fields are set, and error when a user provides multiple spec.storage.hive items, i.e.:
apiVersion: metering.openshift.io/v1
kind: MeteringConfig
metadata:
  name: "operator-metering"
spec:
  unsupportedFeatures:
    enableHDFS: true

  storage:
    type: "hive"
    hive:
      type: "azure"
      hdfs:
        namenode: "hdfs-namenode-0.hdfs-namenode:9820"
      s3:
        bucket: stub
        region: stubstub
        secretName: stubstubstub

Before this change, this configuration would pass validation, but now this would produce the error message:
"spec.storage.hive" must validate one and only one schema (oneOf). Found none valid
"spec.storage.hive" must not validate the schema (not)
"spec.storage.hive" must validate all the schemas (allOf)

This still needs to be updated to restrict duplicate spec.storage.hive.type: ... fields from being set, i.e.:
apiVersion: metering.openshift.io/v1
kind: MeteringConfig
metadata:
  name: "operator-metering"
spec:
  unsupportedFeatures:
    enableHDFS: true

  storage:
    type: "hive"
    hive:
      type: "azure"
      type: "hdfs"
      hdfs:
        namenode: "hdfs-namenode-0.hdfs-namenode:9820"

The configuration above would pass validation, but I haven't found a way to enforce this behavior yet.

@timflannagan1 The above is more of a yaml parsing thing. Specifying type twice, the yaml parser simply overwrites the values of the first with "hdfs", so the validation only ever sees type: "hdfs"

@chancez okay that makes sense, and this would imply that the inverse (type: hdfs, type: azure) would be invalid, which would be the intended behavior.

Yeah, that would basically be setting: type: azure, the hdfs: {} section  which would be an invalid combo

/retest

/lgtm
/approve


Ranking on EvalAI leaderboard

Hi!
It seems that the ranking on the leaderboard for Task 1 is based on the logic "the lower nDCG@5 and nDCG@10 scores, the better". Should not it be the opposite? Could you please elaborate a bit on the evaluation strategy?
Thanks in advance!

Hi, thanks a lot for raising this! Looks like evalAI's default way to produce a leaderboard ranking is to sort by ascending order of metric value, which is incorrect in this case since higher nDCG scores are better. We've fixed this to show the correct leaderboard ranking now! Submissions with higher nDCG@10 scores are ranked higher.
Please let us know if you find any other issues!


Coconet: Remove conv weights initializer when not training...

(was causing TPU errors and isn't needed for inference) and remove tf.nn.moments from batchnorm when not training (was a bug, shouldn't have been in inference graph).

thanks!


Provide a way to pass options to cargo-audit

Motivation
cargo-audit has some useful options, and it would be nice to be able to use them via audit-check. For example:

--deny-warnings: Fail if a warning exists -- warnings may be missed by reviewers until the PR has been merged and the issue submitted.
--ignore: Ignore specified advisory -- if fix requires breaking change, the fix may be postponed as it cannot be fixed immediately (especially if that advisory is warning).

Workflow example
      - uses: actions-rs/audit-check@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          options: --deny-warnings --ignore RUSTSEC-2020-0016

or
      - uses: actions-rs/audit-check@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          deny-warnings: true
          ignore: [RUSTSEC-2020-0016]

I think it'd be great to have the arguments parameterized as in the second example, e.g.  ignore: ["RUSTSEC-2020-0016"]

FYI, we just landed a PR to cargo-audit to autodetect a project-local .cargo/audit.toml file, which can be used to pass most configuration options and also means running it locally will match CI:
https://github.com/RustSec/cargo-audit/pull/252
That should hopefully also address this issue.

I created an audit.toml:
[output]
deny = ["unmaintained", "unsound", "yanked"]
quiet = false

Which worked locally in promoting the warnings to errors, however I saw no difference in the audit-check task, it still passed with warnings. Is there a trick I'm missing?

You placed it in .cargo/audit.toml?

@tarcieri yes I did, and like I said it does have an effect locally.
I'm in a private repo ATM, but if this is a surprise that it's not working, I can make a MVCE repo?

Is it possible CI is caching an older version of cargo-audit?

I suppose it is, do you know how to check the version used?
Here is my MCVE repo: https://github.com/alan-signal/cargo-audit-action/pull/1

@tarcieri Looking at this I can see this runs $ cargo audit --json.
Locally, removing my .cargo/audit.toml file, it mearly has this effect:

So, it would seem that the issue is that the json output does not reflect the output options and it is reported as a warning:
"warnings": {
    "unmaintained": [
      {
        "kind": "unmaintained",
        "package": {
          "name": "cpuid-bool",
          "version": "0.2.0",
          "source": "registry+https://github.com/rust-lang/crates.io-index",
          "checksum": "dcb25d077389e53838a8158c8e99174c5a9d902dee4904320db714f3c653ffba",
          "replace": null
        },
        "advisory": {
          "id": "RUSTSEC-2021-0064",
          "package": "cpuid-bool",
          "title": "`cpuid-bool` has been renamed to `cpufeatures`",
          "description": "Please use the `cpufeatures`` crate going forward:\n\n<https://github.com/RustCrypto/utils/tree/master/cpufeatures>\n\nThere will be no further releases of `cpuid-bool`.",
          "date": "2021-05-06",
          "aliases": [],
          "related": [],
          "collection": "crates",
          "categories": [],
          "keywords": [],
          "cvss": null,
          "informational": "unmaintained",
          "url": "https://github.com/RustCrypto/utils/pull/381",
          "references": [],
          "yanked": false
        },
        "versions": {
          "patched": [],
          "unaffected": []
        }
      }
    ]
  }

Huh, could be a bug. Can you open an issue on https://github.com/rustsec/rustsec?

I will, thankyou!

@tarcieri https://github.com/RustSec/rustsec/issues/376 thanks again!


Fix Unwraps, Add Flexi Logger for Log Rotation, and Update Examples

This pull request addresses several issues within the code base, focusing on fixing unwraps, adding log rotation with Flexi logger, and updating examples to ensure they work correctly in the designated directory.
Changes Made:

Fixed all occurrences of unwraps in the code base, replacing them with appropriate error handling to improve code robustness and prevent potential panics.
Implemented Flexi logger for log rotation. Log files will now be retained for 7 days, and compressed zip files will be stored for 2 days, allowing for efficient log management.
Updated examples to work seamlessly in the specified working directory, ensuring that they reflect accurate usage patterns and provide a better understanding of the code.

Marked this as draft to prevent accidental merges while the log comments are addressed.


Generate linux based image with Edge 79 beta

https://www.microsoftedgeinsider.com/en-us/welcome/update?channel=beta&version=79.0.309.12
Above Edge browser should be portable to the Linux container. let's try to create an image even for "79.0 beta" version.

@vdelendik any Linux distribution download URL would accelerate building such image.


refactor(consensus): move code from select to handle_proposal

minimize the code inside of macros

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2620  👈 (View in Graphite)
#2499
#2498
#2497
#2496
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 15, 3:44 AM EST: A user started a stack merge that includes this pull request via Graphite.


⚠ Bofrost.de has degraded performance

In 8e9b469, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 990 ms

Resolved: Bofrost.de performance has improved in 0c2c139.


Deploy the API of the model

Search for the best way to deploy the API.
See if we can use python to connect to the firebase and store the output of the API directly without needing to call out to the API from the App.

Deployed the API using Azure and Docker hub.

Deployed the API using Azure and Docker hub.


Feature/mtsdk 340 create automation tests on i os

-Create iOS automation tests

I see node_modules showing up in this PR. However I'm not sure what node is used for in this feature.


os: TestMkdirAll is broken on plan9

@0intro
I just submitted CL 86295, and that has broken plan9 builder
https://build.golang.org/log/2611e1b7cb762567c5360fd1029c0a0e414921b0
with
--- FAIL: TestMkdirAll (0.01s)
	path_test.go:67: MkdirAll "/tmp/_TestMkdirAll_/dir/./dir2/file/subdir" returned wrong error path: "/tmp/_TestMkdirAll_/dir/dir2/file/subdir" not "/tmp/_TestMkdirAll_/dir/dir2/file"
FAIL
FAIL	os	1.799s

sorry about that. I looked at plan9 code, but I do not know enough to understand why it is broken. Feel free to revert CL 86295 if it is wrong on plan9.
Thank you
Alex

Closing this as a dup of #23918.
Alex


sco usb and uart differences

There are significant differences between the behaviour of UART and USB hci adapters. I think these differences require bluealsa to implement specific code for each. The main underlying distinction is that UART imposes no "packet" boundaries of its own - the size of a single transfer is limited only by the size of the buffers on each side; whereas USB imposes both size and timing constraints that are in addition to buffer size limits.
Consider USB first:
For SCO data (not A2DP) bluez uses the USB "isochronous" interface configured with a transaction interval of 1ms, and performs transfers at 3ms intervals. It is this 3ms interval that determines the size and timing of reads and writes to a SCO socket.
For CVSD voice, bluealsa writes raw mono 16bit 8kHz linear PCM. Doing the math gives a data rate of 16000 bytes per second, or 48 bytes per 3ms interval. Magic number 48 explained!
For mSBC, bluealsa writes encoded, compressed, mono 16bit 16kHz PCM. The raw linear PCM stream works out at 32000 bytes per second, and mSBC encoding compresses this at 60 bytes of output for every 240 bytes of input. So we end up with 3 * 32 / 4 = 24 bytes per 3ms interval. Magic number 24 explained :smile:
These magic numbers should not be interpreted as "maximums" (as in "mtu"). They are fixed requirements and if bluealsa fails to deliver exacly that number on time then the data rate will fall below that required to maintain the audio stream.
Note that the 3ms interval is measured by the USB clock, so trying to apply finer-grained timing adjustments using nanosleep() in the bluealsa SCO thread loop is counter-productive. Instead, bluealsa must concentrate on always being ready to read/write the correct chunk of data whenever the socket is ready.
@Arkq: As an aside, you are aware of a patch submitted on the kernel bluetooth mailing list that is proposing to modify bluez' implementation of mSBC streams on usb - latest update here:
https://www.spinics.net/lists/linux-bluetooth/msg82230.html . If that proposal is ever adopted, then the chunk size for mSBC will change from 24 to 60. Bluealsa will then have to determine which version of the btusb driver is loaded to know which value to use - I can't find any API that allows user space to query for the value.
Now consider UART:
The UART bus does not constrain the size or timing of individual transfers in any way. Thus the HCI can optimize data flow according to its own buffer capacity and latency requirements.
For CVSD, the most efficient strategy is to transfer as much data as the controller buffer can hold with each write. The only other constraint is that audio frames must not be fragmented, which means that the chunk size must be an even number. The buffer size is obtained by
getsockopt(sco_fd, SOL_SCO, SCO_OPTIONS, &options, &len)
For many UART adapters with smallish SCO buffers (eg broadcom typically uses 64 bytes) it is possible to maintain a sufficient data rate with smaller transfers (eg 48 bytes). However, for adapters designed with larger buffers (apparently some Texas Instruments ones have a 150 byte buffer) using 48 byte chunks results in dropped frames and very poor sound quality. Therefore bluealsa should always transfer chunks of size sco_mtu for CVSD streams on UART adapters.
For mSBC, (and any other codec using "transparent" voice) the most efficient strategy is to transfer one full codec frame at a time. So that is a chunk size of 60 bytes, always containing one complete mSBC frame.
I haven't tested the need for nanosleep() with UART yet. It is possible that using poll() is sufficient to achieve the correct data rate for SCO, but I haven't been able to confirm this just by reading the BT core spec and bluez code.
I am hoping to be able to implement some of this analysis experimentally, and will submit a PR if it goes well. However, that will not be before the new year now, so I wanted to raise this as an issue so that any other interested parties can comment and point out any mistakes or omissions; maybe others could even try some code to see if bluealsa would benefit from this approach.

Many thanks for such extensive research! Magic numbers explanation is most entertaining :)

Note that the 3ms interval is measured by the USB clock, so trying to apply finer-grained timing adjustments using nanosleep() in the bluealsa SCO thread loop is counter-productive.

I'm not sure for USB bluetooth, but for UART bluetooth, incorrect timing has caused mSBC issues (missing packets). Before the 9eb717f commit, the delay was not working, so the write was triggered by data availability or SCO socket writeability. With such setup data flow was not linear (in the function of time) - there were linear parts and stalling parts. After fixing the delay, the data flow becomes linear and the mSBC "quality" was improved. But maybe these two events are not related....
For USB bluetooth, I'm not able to force mSBC playback, so I'm not sure whether correct delay accounting is important. I will try to investigate it though. I might try to remove delay logic and see whether CVSD will still work.

If that proposal is ever adopted, then the chunk size for mSBC will change from 24 to 60.

It would be best to avoid that.... I'm experimenting with various options for detecting MTU from reading, or FIONREAD ioctl. But the result are not consistent. And of course it is not general solution, so it will not be merged into the master, but maybe it will lead me somewhere...

for UART bluetooth, incorrect timing has caused mSBC issues (missing packets)

Ok, the bluetooth core spec is not as clear on timing requirements for UART as it is on USB.  So I think you have demonstrated here that bluealsa is responsible for correct timing on a UART HCI bus.
This table summarizes the results of my analysis. sco_mtu stands for the value obtained from getsockopt().

Bus Type
CVSD
mSBC

UART
chunk size: sco_mtutiming delay: yes
chunk size: 60 bytestiming delay: yes

USB
chunk size: 48 bytestiming delay: no
chunk size: 24 bytestiming delay: no

Of course, other bus types exist, and this analysis needs to be extended to cover them also. I am unable to test any other types, but may do some more reading on them next year.

It turns out that, for  bluez SCO sockets, the POLLOUT event is always ready, so it cannot be used to control the timing of outgoing packets.
Next I will look at using the method adopted by pulseaudio which is to use the POLLIN event as the trigger for both read() and write() on a SCO socket. If that worls then the timing delay becomes unncessary for both USB and UART. I'll report back when I have some test results.

I might already say, that it will not work, because pollin does not trigger
if there is no incoming data (case where bluealsa talks to bluealsa in only
one direction). For headsets it will most likely work, because headsets
will send mic audio.

pollin does not trigger if there is no incoming data (case where bluealsa talks to bluealsa in only
one direction)

Yes, absolutely. That was why I originally doubted the possibility of using a read() to establish the HCI SCO packet size. But if bluealsa to bluealsa is the only problem case (a big if that's yet to be proven) then it can be fixed by sending silence when no pcm input is present.
A bigger issue for me now is what to do when the sco socket is ready for output but there is not a full packet of data available. For CVSD I can easily pad with silence, but for mSBC I think that may not be possible. Similar issue when SCO input arrives but the buffer does not have space for it - perhaps simply drop the overflow for CVSD but no such easy answer for mSBC. I intend to think over that for a while.

After trialling all the ideas above, I have to concede that none have produced any measurable improvement over the existing bluealsa SCO code.
One addition that does at least remove the underruns that I see with msbc is the "Packet Loss Concelment" code from the bluetooth HFP spec. I needed to replace their "short" type declarations with "uint8_t" or "int16_t" in various places, but other than that it works well with bluealsa msbc to replace any missing audio frames and so keep the bit rate correct.
The licencing conditions of the example code in the HFP spec is unclear to me, so I don't know if I am permitted to post it here as a PR.
@Arkq I am happy to post my modifications to src/mcbc.[ch] to use the PLC code if you are interested, but you would have to satisfy yourself that it is OK to copy the spec example code, and obtain that directly.


mWeb - Emoji - Empty space in emoji category "Smiles&People"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Log in with your credentials
Go to any conversation
Click emoji
Scroll down to category "Smiles&People"

Expected Result:
User can see all emoji without any spaces.
Actual Result:
The user sees a gap in the emoji category "Smiles&People".
Workaround:
Unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/190008435-d7a4ae2a-fe9c-4a87-b48e-af65e09932eb.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

oh, initially I thought it's not reproducible. Yes, I can reproduce this one. I reproduced it in Chrome on iOS.

Monthly, I think our product is rarely used in mobile browsers.

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)

Issue not reproducible during KI retests. (Third week) Closing

Issue is reproduced during QA Regression on build <IP_ADDRESS>

@kbecciv, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.


Add map_name to the sequence-error.tsv

Since the sequence-error.tsv file has the errors for all of the alignments, knowing the map_name is helpful to filter this file.

Relates to #29

Addressed in #53 -- nonmatch.tsv.gz contains a column "read_id" that can be used to join or filter on the corresponding "read_id" in per_read.tsv.gz or alignments.tsv.gz. This approach is demonstrated in report.Rmd to extract only vector-mapped reads.


Tests for RST-3088

JIRA:
https://tools.hmcts.net/jira/browse/RST-3088
Description:

Adds a test that touches the hardship questions.
Some of the feature code is simplified.

LGTM will approve once conflicts are resolved

LGTM will approve once conflicts are resolved


Bug when opening contributors page in Firefox on Ubuntu

See #75

As of 02/20/2020, I'm unable to replicate the bug.
Firefox Version: 73.0
Operating System: Ubuntu 18.04.4 LTS, x64
git Version: 2.17.1
@Ishan1742 , are you still getting errors with trying to open git gud contributors when Firefox isn't open yet?

I am currently on Manjaro 19.0.0
I don't have the bug here.


Can't get reg ID - from register callback returns "OK" (DUPLICATED)

I'm working on a cordova 3.5 application and I'm using this plugin for push notification.
Here is my code:
push_init: function(){
var SENDER_ID = "my GCM project number";
var pushNotification;
var txt;
var successHandler = function( result ) {
     navigator.notification.alert('Push: win -> ' + result);
};
var errorHandler = function( error ) {
     navigator.notification.alert('Push: error -> ' + error );
};

var push_android = function(e) {

     navigator.notification.alert('push_android() - connection established...');

      switch( e.event ) {
        case 'registered':
            if ( e.regid.length > 0 )
            {
               navigator.notification.alert("Regid " + e.regid);
               navigator.notification.alert('registration id = '+e.regid);
            }
            break;

       case 'message':
         navigator.notification.alert('message = '+e.message+' msgcnt = '+e.msgcnt);
            break;

       case 'error':
         navigator.notification.alert('GCM error = '+e.msg);
         break;

         default:
         navigator.notification.alert('An unknown GCM event has occurred');
         break;
       }
 };

 var onNotificationAPN = function( e ) {
        navigator.notification.alert('onNotificationAPN()');
 };

        try {

            pushNotification = window.plugins.pushNotification;

            if ( device.platform == 'android' || device.platform == 'Android' || device.platform == "amazon-fireos" ) {

                pushNotification.register(
                    successHandler,
                    errorHandler,
                    {
                        "senderID": SENDER_ID,
                        "ecb": "push_android"
                    }
                );

            } else {
                pushNotification.register(
                    successHandler,
                    errorHandler,
                    {
                        "badge": "true",
                        "sound": "true",
                        "alert": "true",
                        "ecb": "onNotificationAPN"
                    }
                );
            }

        } catch (error) {
            txt = "There was an error on this page.\n\n";
            navigator.notification.alert(txt);
        }

    },

My problem is that when I run my app on my android phone (HTC one with kitkat 4.4.2) it just alerts Push: win -> OK instead it should alert the registration ID I will use later to send notifications.
I have already created a new project on Android Developers Console site and activeted GCM and I got a Project ID and a Project Number (the one I used above), I also created a API Key for server applications and I got an API key string. My google account is the same I use on my android phone (I don't know if it's required).
So what do you think? Am I missing something?

@Krysisx have you found any solution?


[Update Request]: REAPER Arm64EC builds

What type of update are you requesting?
A new locale, architecture, or installer type of an existing version
Current Package Identifier
Cockos.REAPER
Package Version
7.27
Please describe the changes you would like to see
An Arm64EC version of REAPER exists, and should be offered to those who are running Windows on Arm.
https://www.reaper.fm/files/7.x/reaper727_win11_arm64ec_beta-install.exe

Hi @snickler 👋🏼 ,

[!TIP]
Modify the very first comment of the pull request as follows. This can associate the pull request to this issue. When the pull request is successfully merged, this issue can also be closed automatically.

  Checklist for Pull Requests

  * [x]  Have you signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs)?
- * [x]  Is there a linked Issue? [[Update Request]: REAPER Arm64EC builds #190304](https://github.com/microsoft/winget-pkgs/issues/190304)
+ * [x]  Is there a linked Issue? Resolve #190304


[BUG] [BUG] Request to update Twitter icon to X on social share

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?
https://www.biodrop.io/krushnarout
Version of BioDrop (for example "v1.2.3")
v2.97.1
Description
The twitter icon has been updated to X on footer but it's still same on social share link.
Steps to Reproduce
Go to https://www.biodrop.io/eddiejaoude and click on social share.
Screenshots

Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this
I will update the BsTwitter to latest X logo from the react-icons library.

Good spot @krushnarout
I will assign this to you.

@SaraJaoude Thank you

I wish this didn't have to happen :(

hi guys! has this been fixed yet?


Move back to official mkcert packages and update mkcert

https://github.com/FiloSottile/mkcert/pull/284 has been merged, so mkcert is also officially available for arm64 now. That means we don't need the fork drud/mkcert anymore. This issue is just as a notification that we should switch back at some point; I don't have the bandwidth to do so at the moment, but when I do, I'll report here before I start working on it.
If anyone has time to work on this that'd be great 🚀

Thanks. I agree that we don't have to move fast on this. In fact... we don't know how good the new official release is yet. It got a lot of sudden commits.

DDEV will be available for Apple Silicon before too terribly long; mostly as soon as Docker Desktop has a tech preview.
Since the maintainer of mkcert is leading the charge for golang support on Apple Silicon, I imagine he'll add a package there, but if he doesn't, we'll want to stay on our fork (and put a darwin/arm64 build on it).

mkcert is built for apple silicon in homebrew, but the repo doesn't build releases for it. I opened https://github.com/FiloSottile/mkcert/issues/329 requesting the build for Apple Silicon.

mkcert is built for apple silicon in homebrew, but the repo doesn't build releases for it. I opened https://github.com/FiloSottile/mkcert/issues/329 requesting the build for Apple Silicon.

This is blocked by https://github.com/FiloSottile/mkcert/pull/359 for Apple Silicon.

Note that mkcert is available via apt-get in Ubuntu 22.04, and also that DDEV includes mkcert in the ddev apt package.

I'm pretty sure that this issue is obsolete. The two usages I see are
https://github.com/ddev/ddev/blob/e0c89d6e952ebb90872d8390e2cca2faa5bd27e2/containers/ddev-webserver/Dockerfile#L92
and https://github.com/ddev/ddev/blob/e0c89d6e952ebb90872d8390e2cca2faa5bd27e2/containers/ddev-webserver/Dockerfile#L216
I guess it's done for the normal build and the prod build separately?
Anyway, I'm pretty sure the ddev/mkcert is obsolete already.
Closing, and I'll archive ddev/mkcert


[bevy_ui/layout] Add tests, missing asserts, missing debug field, and widen children param in update_children for UiSurface

This is 3 of 5 iterative PR's that affect bevy_ui/layout

[x] Blocked by https://github.com/bevyengine/bevy/pull/12801
[x] Blocked by https://github.com/bevyengine/bevy/pull/12802

Objective

Add tests to UiSurface
Add missing asserts in _assert_send_sync_ui_surface_impl_safe
Add missing Debug field print for camera_entity_to_taffy

Solution

Adds tests to UiSurface
Adds missing asserts in _assert_send_sync_ui_surface_impl_safe
Adds missing impl Debug field print for camera_entity_to_taffy

Well, I attempted to clear up the merge conflicts, but after pulling in changes from main (not rebasing to maintain history for current reviewers), it seems like bevy_text is requiring some extra params for compute_camera_layout. Satisfying this would require initializing a Bevy app to get a reference to the Query and Font system. It would be nice to extract that kind of test out to its own mod instead of bloating the set of tests in this PR. I'll see about making those changes over the next few days when I get time.

For now, I've excluded the one test, test_compute_camera_layout, when bevy_text is active inside layout/ui_surface::tests.
For coverage of those new bevy_text params, I went with the path of least resistance by adding the test inside layout/mod::tests since it already has a Bevy app being created.
But I'm not sure I like layout/mod owning responsibility for layout/ui_surface. Since that was the whole point of extracting ui_surface to its own file; Any suggestions? The one thing that comes to mind would be moving setup_ui_test_world to a pub mod tests {} and exposing it as pub for ui_surface to call

I removed the change described as "Widen children param in update_children (required for tests)" because the new GhostNode changes rely on it continuing to be an iterator, and my previous reasoning is likely flawed.

Previously I was using
const TEST_LAYOUT_CONTEXT: LayoutContext = LayoutContext {
    scale_factor: 1.0, // default 1.0
    physical_size: bevy_math::Vec2::ONE, // default Vec2(0,0)
    min_size: 0.0, // default 0.0
    max_size: 1.0, // default 0.0
};

but changed to using LayoutContext::default(). Does anyone know if the default values nullify the usefulness of the tests? They still seem to pass, but it's been several months since I initially worked on this, so I'm not acutely aware of any side effects.

Otherwise, the only outstanding item is this discussion: https://github.com/bevyengine/bevy/pull/12803#discussion_r1779347976

Does anyone know if the default values nullify the usefulness of the tests?
I have not looked at the tests in detail, but the default LayoutContext has zero size, so presumably there is a lot of short-circuiting inside the layout algorithm which probably invalidates the test results. I'd revert back to using TEST_LAYOUT_CONTEXT but use a larger max_size, more like 1000.0.

I'd revert back to using TEST_LAYOUT_CONTEXT but use a larger max_size, more like 1000.0.

Good idea, restored in https://github.com/bevyengine/bevy/pull/12803/commits/03c2f343b2fa9312f429d811db2e0884e4b327f0

Thanks for your patience <3 Really nice stuff.

@StrikeForceZero this needs to be manually updated to reflect the changes on main. Sorry :( I really like this work and would love to get it in though, so please let us know if you're interested in completing this.

@StrikeForceZero this needs to be manually updated to reflect the changes on main.

Ok, should be good now @alice-i-cecile


Test failure with creates_new_id_implicitly

There's a failing test starting with 0.20.0 on Arch Linux:
% RUST_BACKTRACE=1 cargo test
[...]
---- creates_new_id_implicitly stdout ----
thread 'creates_new_id_implicitly' panicked at 'assertion failed: c.run(&[\"id\", \"trust\", \"--level=medium\",\n        \"FYlr8YoYGVvDwHQxqEIs89reKKDy-oWisoO0qXXEfHE\"], \"\").status.success()', cargo-crev/tests/clitest.rs:11:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/std/src/panicking.rs:493:5
   1: core::panicking::panic_fmt
             at /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/core/src/panicking.rs:92:14
   2: core::panicking::panic
             at /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/core/src/panicking.rs:50:5
   3: clitest::creates_new_id_implicitly
             at ./tests/clitest.rs:11:5
   4: clitest::creates_new_id_implicitly::{{closure}}
             at ./tests/clitest.rs:7:1
   5: core::ops::function::FnOnce::call_once
             at /home/user/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
   6: core::ops::function::FnOnce::call_once
             at /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Can't reproduce. Was this a one time thing or it happens every time? It might be some local problem or some assumption somewhere that doesn't work on your system. :thinking:

If you want to help me debug this (if it persistent), find the line like this:
Running tests/clitest.rs (target/debug/deps/clitest-7b973c51747d6f21)

Then run that test standalone like this:
 strace -fff target/debug/deps/clitest-7b973c51747d6f21

If you can provide me with this strace output, I might be able to figure out what is going wrong and where.


Investigation on sphinxcontrib-typer instead of sphinx-click.

Ref: https://github.com/sphinx-contrib/typer

sphinx-click work fine right now, will follow up this latter.

Close as we use click instead of typer now.