Ship rails-bin upstream

The goal is to be able to install this project as and run the tests locally as well.
For example, when developing on Rails and making changes to the configuring guide, breaking changes will fail the build in CI.
This is great to be able to prevent shipping incorrect documentation, and also providing developers feedback on their work.
However, it would be nice if a developer could execute those same tests locally without having to run a build.

If we make this project a gem, and add it to the rails/rails Gemfile we could have a rake task to run the same tests for us.
cd ~/oss/rails
bundle exec rake check-changelogs

This would require the following work:

We ship this project as a gem
Add that gem to rails/rails Gemfile
Update rails/rails Rakefile to include any tasks we want to make available

The first part is simple, the second part requires getting buy-in from other Rails committers. :pray:

Done in rails/rails#48216 🎉


AccountInfo -> TokenClaim missing custom claim

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.16.1
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.0.1
Description
We are migrating from the old https://github.com/syncweek-react-aad/react-aad MSAL 1.0 to 2.0 library to this library and we have most of our code working.  However one major difference in the old library and new library is with the old library allowed "custom" claims to come through.  For example,  we currently pass immutable_id through to get the users onPremisesImmutableId in our token claims.
The old library had idTokenClaims defined as a StringDict so custom claims like immutable_id came through:
idTokenClaims: StringDict;

Payload:

The new library is bound to an object that does not seem to allow for any unbound custom claims properties to come through:
 idTokenClaims?: object;

Object is of course missing the immutable_id:

Defined as:
/**
 * Type which describes Id Token claims known by MSAL.
 */
export type TokenClaims = {
    iss?: string,
    iat?: number,
    oid?: string,
    sub?: string,
    tid?: string,
    ver?: string,
    upn?: string,
    preferred_username?: string,
    emails?: string[],
    name?: string,
    nonce?: string,
    exp?: number,
    home_oid?: string,
    sid?: string,
    cloud_instance_host_name?: string,
    cnf?: {
        kid: string;
    };
    x5c_ca?: string
};

So the question is how to do we go about getting our custom claim such as "immutable_id" in the new MSAL 2.0 library?
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

@melloware Thanks for bringing this to our attention. We do strive to send all claims and the idToken type is mostly for internal reference. Let me try reproducing this and reach out.

OK thank you!

@sameerag I am closing this ticket.  The issue was on our end where the custom claim was not added to our account. Our admins adjusted our profile and now we get our immutable id.  I thought the above TS object was the issue but it was not!   Closing ticket.

Thank you @melloware


Testing issue when trying to add to conda-forge

I'm attempting to add this to conda-forge and in the recipe have the command awslocal -h to simply check for functionality, which runs fine on linux & mac osx but when testing in azure on windows I get "awslocal is not recognized as an internal or external command"
Is there a different command I can use to test that installation was successful?

Thanks for reporting @mwilson8 . Looks like a duplicate of #11 - we'll push a fix shortly.

This should be fixed in 8878701 . Can you please give it a try with the latest version 0.5 of the pip package? Please report here if the problem persists. Thanks

Successful build in https://github.com/conda-forge/awscli-local-feedstock/pull/2. Thanks!


Windows version appends character to start of each file

After building a powershell script to use your tool and convert all the files over from BIND to TerraForm we discovered a weird bug where it was appending some special character to the start of the file, making Terraform fail to validate.
brendand@~/Documents/repos/ecosystem/terraform/aws-dns (prod)(master) $ head prod/allcloudcontent.com.au.resources.tf
��
resource

As you can see that was at the start of every file.
This character wasn't visible in Notepad, Notepad++, VSCode, Sublime, Vi or anything else I tried.
We ended up discovering it by doing a hexdump -c on the file and saw the first character was some sort of blank one.
0000000         r  \0   e  \0   s  \0   o  \0   u  \0   r  \0   c  \0

After using dos2unix to convert from UTF-16LE to UTF-8 Unix:
0000000   r   e   s   o   u   r   c   e       "   a   w   s   _   r   o
This allowed the TerraForm validate to successfully complete.
I'm not 100 sure it was your program at fault, but something I thought you and others should be aware of incase it happens to them.
Again thanks for the program, it's saved me so much time and work.

Hey @Havoc302,
This is a Powershell peculiarity. It defaults to writing files with UTF-16 encoding, and the first two bytes there are the "byte order mark", or BOM. The overwhelming majority of tools use UTF-8, without a BOM, so then UTF-16 files get misinterpreted.
When writing files from Powershell, override the encoding like this:  Out-File -Encoding utf8 ...

Ah PS did it. Apologies. And thanks I'll fix up my script.


rkt: fix enter when running without overlay fs

When not using overlay fs, the tree cache was not getting populated.
Since we now take the enter binary from the tree cache, this was
breaking rkt enter.
We now populate stage1's tree cache in every case. We don't do it for
the app images because it can add a significant amount of time in the
first run if the image is big and it's not needed unless you use overlay
fs.
Fixes #683

We should decide what to do with the tree cache when overlay fs is not used. The rendering can take a long time because if fsyncs every file before returning
Right now we always extract the files from the ACI even if we have a tree cache. Should we render in any case and then copy the files instead of extracting?

Right now we always extract the files from the ACI even if we have a tree cache. Should we render in any case and then copy the files instead of extracting?

yes, seems reasonable to me

LGTM for now, @iaguis could you please file a follow-up to address the extraction redundancy?

#693


Change default for saveUninitialized to false

https://github.com/digitalbazaar/bedrock-express/blob/master/lib/config.js#L18
See: https://github.com/expressjs/session#saveuninitialized
I suspect these defaults are very old and not correct for most work flows. Most of the time sessions are used for login/authN in bedrock applications. We should therefore default to false for saving a session when we don't need to. There's no reason to save a new session to the backing session store for every request that comes from a new client that doesn't transmit a cookie identifying it.

@dlongley @aljones15 can you report on the status of this?  I was thinking that maybe other express flags that were found that provided a better overall solution?

Have tested this in another project and we could safely set this to false before the mongo upgrade. However, the behavior of bedrock-session-mongodb will have to be retested in order to verify that the behaviors stay the same with the latest version of MongoDB. The upgrade to bedrock-session-mongodb was a real breaking change i.e. connect-mongo had to be upgraded and that might have changed how this flag works with that library.
These were the observed behaviors before the upgrade:
https://gist.github.com/aljones15/3defa74231551e5b9934d79609661ae1

The default should change to false.

Addressed by #21.


new architecture for releases

kinectron.bundle.js should be kinectron_client.js or kinectron-client.js
for every release there should be a zip file with the client and a zip file with the server.

I've changed the file name to kinectron-client.js and it the client file is now hosted on jsdelivr with a matching tag to the current release. For example:
The new release is available at https://github.com/kinectron/kinectron/releases/tag/0.2.0 and the client is at<EMAIL_ADDRESS>


Set process environment in Benchmark hook member methods

Set environment in pre_execute and post_execute member methods
according to environment and modules execution settings.

Coverage increased (+0.05%) to 86.05% when pulling c52c49fed853db887e923986cec4bdef09583918 on modules-in-python-hooks into 02dfab3f94124c0c15d185ad844502942b811eb4 on master.

At last, tests pass. Can you please review @ohm314 ?

Awesome! Will review first thing when I get to the office


wget: command not found, when i used mac ip:public command

Closing since it has been resolved by @Matrixbirds here: https://github.com/guarinogabriel/mac-cli/pull/44


Added Calculator readme

There are some conflicts arising, please compare with the latest repository and pull accordingly.


Brand new Windows 11 machine has winget installed but all commands don't return anything

Brief description of your issue
I recently started a new Windows 11 VM and wanted to use WinGet to install my packages but it does not seem to work at all for any installs searches and lists. I can however type winget and see the help so its installed?
Steps to reproduce
Fresh install Windows 11 machine in parallels on an M1 Mac
Try to run any subcommand that does not just return text (i.e not winget, or winget --info)
Expected behavior
I am able to install packages from winget
Actual behavior
Whichever shell I am using gets hung and returns to the prompt but now is blue:

Happens on cmd.exe and powershell.exe with or without Windows Terminal:

Happens with loads of winget subcommands:

Environment
Windows Package Manager v1.2.10691
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.2861
Package: Microsoft.DesktopAppInstaller v1.17.10691.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

This is all in a Parallels VM on a M1 ARM64 Mac.

installing app installer from MSFT store seems to work


Emit WithdrawnRewards event for LiquidUnfarm and LiquidUnfarmAndWithdraw

Summary

As the title says, emit WithdrawnRewards event for LiquidUnfarm and LiquidUnfarmAndWithdraw.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

After having an internal discussion, the event is not a necessary information for farmers as well as client developers. Instead, it is decided to remove the currently emitting event in LiquidFarm msg.


Update swig files

Swig files need to be updated in master. Current swig check doesn't pass.

This should also be fixed in the cosmicemu branch, when that is merged.

Given the delays in cosmicemu following conflicts with master, I would appreciate it we could merge this today to have swig checks up to date un master while we work on merging cosmicemu. @damonge, could you approve?

Actually - these checks are passing in master now, apparently following a recent merge of another branch. So I'm closing this PR.


Enhancement - UUID/GUID Data Type

Expected behavior and actual behavior
Expected:  During Class property creation, able to select UUID/GUID option
Actual:  UUID/GUID is not an available option
Steps to reproduce the problem
Attempt to create a new property on a class
Important Questions
A trend in database software is to natively support UUID/GUID properties such as SQL Server and Oracle.  Though it is possible to store a UUID as a string, it would be better as a supported type.  This would improve readability and also operation.  For example, 32 char vs. 36 char UUID should perform correct equals comparison.  String comparison will not work.  A new supported data type should be able to handle either case.
Runninng Mode

[ ] Embedded, using PLOCAL access mode
[ ] Embedded, using MEMORY access mode
[X] Remote

Misc

[ ] I have a distributed setup with multiple servers. How many?
[X] I'm using the Enterprise Edition

OrientDB Version

[ ] v2.0.x - Please specify last number:
[ ] v2.1.x - Please specify last number:
[X] v2.2.x - Please specify last number: 4

Operating System

[ ] Linux
[X] MacOSX
[ ] Windows
[ ] Other Unix
[ ] Other, name?

Java Version

[ ] 6
[ ] 7
[X] 8

Is this enhancement on any milestone roadmap?  If so, which one.  Thanks.


consolidate the create workflow logic into one place

there are at least 4 places where the create workflow execution is used.

https://github.com/uber/cadence/blob/0e81b8eadce844893db5dc3b198b2c5961a4c47e/service/history/historyReplicator.go#L264
https://github.com/uber/cadence/blob/dbe4abb6f8bf3b5387ec7bfea296ba2d9bfa1918/service/history/historyEngine.go#L324
https://github.com/uber/cadence/blob/dbe4abb6f8bf3b5387ec7bfea296ba2d9bfa1918/service/history/historyEngine.go#L1871
https://github.com/uber/cadence/blob/0e81b8eadce844893db5dc3b198b2c5961a4c47e/service/history/mutableStateBuilder.go#L2137

we should merge the logic into one place

consolidation is finished as part of business layer refactor


If available, use temp file create followed by link to PUT an object.

Signed-off-by: Marc Eshel<EMAIL_ADDRESS>Explain the changes

use temp files to create object for PUT

Issues: Fixed #xxx / Gap #xxx

small file create are slow

Testing Instructions:

set env variable that points to libgpfs
GPFS_DL_PATH={PATH}libgpfs.so

[ ] Doc added/updated
[ ] Tests added

@guymguym @jackyalbo what is holding this patch?

Hey @eshelmarc I think the Cpp code is looking good, but I am a bit more concerned that the js side is duplicating too much code... I would like to propose a concrete direction on how to merge these paths by small refactoring, but haven't had the time yet. We can talk about it next week.

@guymguym as you know my js knowledge is limited, so I was trying to keep the changes simple, I don't mind if someone else will make those changes or if you have patience to show me exactly how to improve it that is fine too.

@guymguym as you know my js knowledge is limited, so I was trying to keep the changes simple, I don't mind if someone else will make those changes or if you have patience to show me exactly how to improve it that is fine too.

not sure what to do with DeepScan failure, it is not my code that is flaged.

@eshelmarc if you haven't then try rebasing from upstream -
git fetch --all
git rebase upstream/main
git push -f origin

I am not sure if I did the merge with the main tree correctly, I see another patch in in this PR, so let me know when the patch is ready how to merge it in.

not sure what is failing, it was working for my tests

I made most of the change the to change exports_fs["temp_file"] did not work got the error ../src/native/fs/fs_napi.cpp:1440:14: error: ‘class Napi::Object’ has no member named ‘Freeze’

still failing, any ideas why?

@guymguym let me know if there is anything else that I need to change

@guymguym which Update branch should I use, Update with merge commit or  update with rebase ?

fetch and rebase from upstream:
git fetch --all
git rebase upstream/main
git push -f origin

</nas/eshel2-core/noobaa-core/src> git fetch --all
Fetching origin
</nas/eshel2-core/noobaa-core/src> git rebase upstream/main
fatal: Needed a single revision
invalid upstream 'upstream/main'

oops, sorry mixed up master/main, this repo still uses master:
git fetch --all
git rebase upstream/master
git push -f origin

@guymguym why is it failing, why can we merge it already?

@eshelmarc @guymguym
I re-ran the workflow and now it passes


how do train the models of pytorch

Just use the office training codes with this network model.
Please check the official training codes: https://github.com/pytorch/examples/tree/master/imagenet


Added USE_SIGNAL_HANDLER to other Linux builds which didn't had it

Description
see title
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy Thanks for the contribution!
@mxnet-label-bot [pr-awaiting-review, build]

@larroy Thanks for the contribution!
@mxnet-label-bot add [pr-awaiting-review, build]

@larroy rebase?


Add Star Button to Meshery

Description
This PR fixes #1183
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

Maybe use #00B39F, instead of yellow because the text is not visible in light mode.
Can you check the hover effect in dark mode? It is not working correctly in dark mode.

Hey @Gautam-666 ! Thanks for the suggestions
I was thinking that maybe we can make the drop shadow color as #00B39F or change the color of button on hover just like in the case of other buttons on the page. I have changed the background color of the button from yellow to #00B39F though.

I got your point @Saksham294 but issue with yellow colour was that it wasn't really attracting the attention of the viewer in Light mode especially.

Use the github social-icon image for this, adding another svg would be unnecessary
To keep the consistency of the styles, use the existing ones

You mean to remove the current CSS styles I added and make them using existing ones right?

@Saksham294, yes

@Saksham294
If you could incorporate the suggested changes, we can discuss this in websites call tomorrow. Be sure to add this as an agenda item in the meeting minutes

Looks good on mobile.

@Saksham294 Can you just check the following  hovering issue between the buttons?
https://github.com/meshery/meshery.io/assets/91362589/effaec1e-3bfe-4410-b0f1-9f1a60ca6b81

@Savio629 the issue is while hovering the anchor tag. If we want to fix this we have to change the a: hover. However this will change the effect for other elements as well. Another way is to add another class to this anchor tag


Getting string indices must be integers error when calling mint.get_budgets in Python?

Greetings all, so I finally got past all the issues with the email only login prompt, but now I'm trying to do a simple call to mint.get_budgets() and getting the 'string indices must be integers' error.   Do we know of any issues going on with the budgets area of code by chance?  Please be advised, I am novice Python developer. : )
Thanks!
Python:
budgets = mint.get_budgets()
TypeError                                 Traceback (most recent call last)
 in
1 #Get this months budget data
----> 2 budgets = mint.get_budgets()
3
~.conda\envs\mintEnv\lib\site-packages\mintapi\api.py in get_budgets(self, hist)
1015                     category = self.get_category_object_from_id(budget['cat'], categories)
1016                     budget['cat'] = category['name']
-> 1017                     budget['parent'] = category['parent']['name']
1018
1019         return budgets
TypeError: string indices must be integers

@mrooney this can probably be closed with #261 being already merged.

Thanks, I'll mark as a duplicate, and Jon I hope you are able to resolve with the latest version.

Duplicate of #261

@mrooney  Thanks, unfortunately I'm now getting that error when trying to pull budget history, any advice?
mint.get_budgets(hist=2)

@jcsacto thanks for the update! Are you getting that with the latest mintapi, 1.53? If so, feel free to open a new report with our beautiful new bug template :D


Stackstrings loaded into global variables

See function in 53bcda3e3fa629163328911e6ca13445 at VA 0x100013B0.

see https://github.com/fireeye/flare-floss/tree/fix/get_stackstrings_on_move for potential solution
performance changes:
Finished execution after 2.001157 seconds | Finished execution after 0.889498 seconds
Finished execution after 1.535905 seconds | Finished execution after 0.534664 seconds
Finished execution after 7.279704 seconds | Finished execution after 3.540252 seconds
Finished execution after 1.210376 seconds | Finished execution after 0.876422 seconds
Finished execution after 1.059937 seconds | Finished execution after 1.560157 seconds
Finished execution after 48.164911 seconds | Finished execution after 32.614481 seconds
Finished execution after 13.890418 seconds | Finished execution after 9.625995 seconds
Finished execution after 12.354010 seconds | Finished execution after 16.892529 seconds
Finished execution after 30.181431 seconds | Finished execution after 31.138448 seconds
Finished execution after 29.413580 seconds | Finished execution after 26.919828 seconds
Finished execution after 9.784146 seconds | Finished execution after 10.114317 seconds
Finished execution after 2.675725 seconds | Finished execution after 1.191114 seconds
Finished execution after 3.308836 seconds | Finished execution after 1.253435 seconds
Finished execution after 1.394621 seconds | Finished execution after 0.298292 seconds
Finished execution after 1.644238 seconds | Finished execution after 0.301401 seconds
Finished execution after 1.421414 seconds | Finished execution after 1.160257 seconds
Finished execution after 15.485367 seconds | Finished execution after 18.499221 seconds
Finished execution after 8.429687 seconds | Finished execution after 9.152752 seconds
Finished execution after 5.956419 seconds | Finished execution after 9.267610 seconds
Finished execution after 0.107332 seconds | Finished execution after 0.120155 seconds
Finished execution after 0.310461 seconds | Finished execution after 0.401672 seconds

performance decrease by a factor of 2x is not very good. we should research heuristics to detect when to apply this technique.

potential heuristics:
detecting a sequence of four "move single byte constant into contiguous buffer" seems like it should be doable. then trigger a collection at the end of the current basic block?

Getting much worse https://github.com/fireeye/flare-floss/commit/9f2ceb2a24066f58131a9628c95ac80467544331 :)
Finished execution after 1.763606 seconds		      |	Finished execution after 1.050786 seconds
Finished execution after 1.706242 seconds		      |	Finished execution after 0.629037 seconds
Finished execution after 12.561846 seconds		      |	Finished execution after 1.522367 seconds
Finished execution after 2.636911 seconds		      |	Finished execution after 0.990657 seconds
Finished execution after 2.355830 seconds		      |	Finished execution after 1.464837 seconds
Finished execution after 108.653779 seconds		      |	Finished execution after 32.578955 seconds
Finished execution after 30.139329 seconds		      |	Finished execution after 5.361783 seconds
Finished execution after 31.426122 seconds		      |	Finished execution after 4.235152 seconds
Finished execution after 58.432218 seconds		      |	Finished execution after 28.328247 seconds
Finished execution after 60.083270 seconds		      |	Finished execution after 23.393540 seconds
Finished execution after 23.200419 seconds		      |	Finished execution after 8.643929 seconds
Finished execution after 5.616619 seconds		      |	Finished execution after 3.125362 seconds
Finished execution after 12.671287 seconds		      |	Finished execution after 4.440304 seconds
Finished execution after 2.808645 seconds		      |	Finished execution after 1.345349 seconds
Finished execution after 2.712589 seconds		      |	Finished execution after 1.272226 seconds
Finished execution after 10.651504 seconds		      |	Finished execution after 0.928227 seconds
Finished execution after 32.426640 seconds		      |	Finished execution after 11.923773 seconds
Finished execution after 18.479772 seconds		      |	Finished execution after 6.459448 seconds
Finished execution after 17.081412 seconds		      |	Finished execution after 9.025540 seconds
Finished execution after 0.674579 seconds		      |	Finished execution after 0.120631 seconds
Finished execution after 1.554304 seconds		      |	Finished execution after 0.892557 seconds

Another approach could be to use vivisect's writelog.

For 4ae6fc176e4ce97b360246328012c97106e3e02e
Don't ask me why it's sometimes faster with the update. I suspect it might be failing although the extracted stack strings are almost identical...
Before                                                                              After
FLOSS extracted 68 stackstrings				      |	FLOSS extracted 70 stackstrings
Finished execution after 21.395251 seconds		      |	Finished execution after 11.779689 seconds
FLOSS extracted 68 stackstrings				      |	FLOSS extracted 70 stackstrings
Finished execution after 12.086730 seconds		      |	Finished execution after 5.766737 seconds
FLOSS extracted 33 stackstrings					FLOSS extracted 33 stackstrings
Finished execution after 2.909764 seconds		      |	Finished execution after 2.250041 seconds
FLOSS extracted 33 stackstrings					FLOSS extracted 33 stackstrings
Finished execution after 7.052175 seconds		      |	Finished execution after 2.185107 seconds
FLOSS extracted 34 stackstrings					FLOSS extracted 34 stackstrings
Finished execution after 2.014953 seconds		      |	Finished execution after 2.196353 seconds
FLOSS extracted 7 stackstrings					FLOSS extracted 7 stackstrings
Finished execution after 0.541726 seconds		      |	Finished execution after 0.534595 seconds
FLOSS extracted 58 stackstrings					FLOSS extracted 58 stackstrings
Finished execution after 2.123646 seconds		      |	Finished execution after 2.852025 seconds
FLOSS extracted 33 stackstrings					FLOSS extracted 33 stackstrings
Finished execution after 1.869085 seconds		      |	Finished execution after 2.126633 seconds
FLOSS extracted 6 stackstrings					FLOSS extracted 6 stackstrings
Finished execution after 0.276731 seconds		      |	Finished execution after 0.273309 seconds
FLOSS extracted 4 stackstrings					FLOSS extracted 4 stackstrings
Finished execution after 0.079342 seconds		      |	Finished execution after 0.093086 seconds
FLOSS extracted 0 stackstrings					FLOSS extracted 0 stackstrings
Finished execution after 0.321545 seconds		      |	Finished execution after 0.298798 seconds
FLOSS extracted 5 stackstrings					FLOSS extracted 5 stackstrings
Finished execution after 0.964567 seconds		      |	Finished execution after 1.415666 seconds
FLOSS extracted 2 stackstrings					FLOSS extracted 2 stackstrings
Finished execution after 0.125332 seconds		      |	Finished execution after 0.119400 seconds
FLOSS extracted 0 stackstrings					FLOSS extracted 0 stackstrings
Finished execution after 0.310682 seconds		      |	Finished execution after 0.376916 seconds
FLOSS extracted 12 stackstrings					FLOSS extracted 12 stackstrings
Finished execution after 6.055719 seconds		      |	Finished execution after 1.704970 seconds
FLOSS extracted 0 stackstrings					FLOSS extracted 0 stackstrings
Finished execution after 0.627058 seconds		      |	Finished execution after 0.262685 seconds
FLOSS extracted 0 stackstrings					FLOSS extracted 0 stackstrings
Finished execution after 0.199009 seconds		      |	Finished execution after 0.110610 seconds
FLOSS extracted 4 stackstrings					FLOSS extracted 4 stackstrings
Finished execution after 0.300824 seconds		      |	Finished execution after 0.172792 seconds
FLOSS extracted 30 stackstrings					FLOSS extracted 30 stackstrings
Finished execution after 9.836497 seconds		      |	Finished execution after 4.135498 seconds
FLOSS extracted 26 stackstrings					FLOSS extracted 26 stackstrings
Finished execution after 6.628611 seconds		      |	Finished execution after 2.229550 seconds
FLOSS extracted 12 stackstrings					FLOSS extracted 12 stackstrings
Finished execution after 2.260597 seconds		      |	Finished execution after 3.112243 seconds
FLOSS extracted 23 stackstrings					FLOSS extracted 23 stackstrings
Finished execution after 1.667418 seconds		      |	Finished execution after 2.097401 seconds

follow #269 for PR implementing these changes.

Closed via #269.


fix: bundled wasm assets not found during build

This PR does the following:

Introduces some support for the filePathMap option in a function config file.
Symlinks assets to the function's folder, so that they can be found during the build process.

fixes #676
fixes #672
Example of this in a function's .vc-config.json:

I've given this a test on my system, and it works! 🙌

Thanks, wasm imports work as expected now.

the other is that I am not sure if changing any file outside .vercel/static/output is appropriate...
I might be wrong but I think we don't do this anywhere else and try to keep things in memory instead whenever possible (to avoid issues like the one I mentioned in which using the skip build option can make the build no longer idempotent)
what do you think?

this is true. i dont think we do this anywhere else in the .vercel/output/functions. on the one hand, this make the fix a lot simpler, instead of changing how some of the deeper logic works, as it allows all the logic we have for the assets in a function's dir to continue doing their thing instead.
would you prefer i make the change to the deeper parts where it's processed instead of symlinking them?

would you prefer i make the change to the deeper parts where it's processed instead of symlinking them?

yeah I think I'd much rather prefer that if it's not too much of a thing to ask 😓
I feel like if we start to "cheat" things can go out of hand and spiral out of control, saying "we never touch files that don't belong to us" feels like a much cleaner/clearer mental model that can prevent pain in the long run (and again, I think that adding exceptions to this can lead to unpredicability and pain 😓)
I don't think that not using symlinks is going to be problematic... it might a bit cumbersome as the paths need to be passed around though 😓
Would you be willing to give that a shot? 🙏
(if you prefer you can also do it in a separate branch and PR and we can compare that solution to this one)

Would you be willing to give that a shot? 🙏

There ya go. You were right, should have done it like this originally, good shout :)

Thank you all for the fix! 🙂


Add scripts for running go vet and go fmt

4 scripts are added:

verify-govet
verify-gofmt
update-gofmt
verify-all

/lgtm


add private key for account

Hey Albert! Thanks for the PR. I'd prefer to keep using the mnemonic. There are many scenarios in which it helps having multiple accounts, for instance when writing tests.


Fixed sending the password recovery email

Thanks, the first one went somehow lost in my stash. skeleton.py is also fixed.


Docker container for project

Hi there,
I was thinking, it would be a good thing to containerize the app with Docker or at least Podman. What do you think?

I think it's a great addition! :)


Vue single file components

Is it possible to create single file components using the vue template and typescript?
like: https://vuejs.org/v2/guide/single-file-components.html
Currently what i see is the html code out of the typescript files.
Thanks in advice.

The template in the SpaTemplates package doesn't use single-file components. I'm sure it's possible to amend the Webpack config to make it build single-file components, but you'd have to check Vue and Webpack docs to find out how.
Also we're no longer making changes to the Vue template in this repo, so closing. Hope that's OK!


Update gogo/protobuf to 1.3.2

Update dependency gogo/protobuf from 1.3.1 to 1.3.2
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
a1f54853362fb90beb90dae783c95bce7da20def
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
a1f54853362fb90beb90dae783c95bce7da20def
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Feature: Stats has co-composition analysis

Running the stats management command now produces a further co-composition specific analysis.

Co-composition analysis

Refining the folkrnn.org session data above, we can analyze only those tunes which are in some way a tweak of the one that came before. This iterative process of human-directed tweaks of the machine-generated tunes, demonstrates co-composition using the folkrnn.org system. In numbers –
Of the 24657 tunes generated on folkrnn.org, 14088 keep the generation parameters from the previous tune, while changing one or more (57%).
This happened in 4007 'iterative' sequences, each averaging 6 generated tunes (mean: 5.9, stddev: 8.7)
The frequency of the generate parameters used now becomes:
key: 0.28, meter: 0.24, model: 0.093, seed locked: 0.34, start_abc is excerpt: 0.02, start_abc: 0.2, temp: 0.39

One feature now possible to expose is whether the user has identified a salient phrase in the prior tune, and has primed the generation of the new tune with this phrase. This is the strongest metric of co-composition available. This is reported above as 'start_abc is excerpt', tested for phrases comprising five characters or more (e.g. five notes, or fewer with phrasing), and as per other generation metrics reported here, not counting subsequent generations with that metric unchanged. This happened 283 times; 2%

Further evidence of human-machine co-composition can be seen on themachinefolksession.org, where 239 of the 'iterative' folkrnn.org tunes were archived. Using the tune saliency metric used by the machinefolksession.org homepage, the most noteworthy of these tunes is Green Electrodes. This was generated (//folkrnn.org/tune/5139) in the key C Dorian, and as archived (https://machinefolksession.org//tune/294) the user has manually added a variation set in the key E Dorian. This shows a limitation of folkrnn.org, that all tunes are generated in a variant of C (a consequence of an optimisation made while training the RNN on the corpus of existing tunes), and shows that the human editing features of themachinefolksession.org have been used by users to work around such a limitation. Also, while not co-composition per-se, that the machine generated tune has some value to the user is also shown by the act of them naming it.
Direct evidence of the user's intent can be seen in Rounding Derry (https://themachinefolksession.org/tune/587. The user generated tune FOLK RNN TUNE №24807 on a fresh load of folkrnn.org, i.e. default parameters, randomised seed. The user played this tune twice, and then selected the musical phrase 'C2EG ACEG|CGEG FDB,G,' and set this for the start_abc generation parameter. The user generated the next iteration, played it back, and this is what is seen archived on themachinefolksession.org. There, the user writes –
Generated from a pleasant 2 measure section of a random sequence, I liked this particularly because of the first 4 bars and then the jump to the 10th interval key center(?) in the second section. Also my first contribution!

Co-composition analysis

Refining the folkrnn.org session data above, we can analyze only those tunes which are in some way a tweak of the one that came before. This iterative process of human-directed tweaks of the machine-generated tunes demonstrates co-composition using the folkrnn.org system. In numbers –
Of the 24657 tunes generated on folkrnn.org, 14088 keep the generation parameters from the previous tune while changing one or more (57%).
This happened within 4007 'iterative' sequences of, on average 6 tune generations (mean: 5.9, stddev: 8.7).
The frequency of the generate parameters used now becomes:
key: 0.28, meter: 0.24, model: 0.093, seed locked: 0.34, start_abc is excerpt: 0.02, start_abc: 0.2, temp: 0.39

One feature now possible to expose is whether the user has identified a salient phrase in the prior tune, and has primed the generation of the new tune with this phrase. This is the strongest metric of co-composition available on folkrnn.org. This is reported above as 'start_abc is excerpt', tested for phrases comprising five characters or more (e.g. five notes, or fewer with phrasing), and as per other generation metrics reported here, not counting subsequent generations with that metric unchanged. This happened 283 times (2%)

Further evidence of human-machine co-composition can be seen on themachinefolksession.org, where 239 of the 'iterative' folkrnn.org tunes were archived. Using the tune saliency metric used by the machinefolksession.org homepage, the most noteworthy of these tunes is 'Green Electrodes'. This was generated in the key C Dorian (//folkrnn.org/tune/5139), and as archived (https://machinefolksession.org/tune/294) the user has manually added a variation set in the key E Dorian. This shows a limitation of folkrnn.org, that all tunes are generated in a variant of C (a consequence of an optimisation made while training the RNN on the corpus of existing tunes), and shows that the human editing features of themachinefolksession.org have been used by users to work around such a limitation. Also, while not co-composition per-se, the act of the user naming the machine generated tune shows it has some value to them.

Direct evidence of the user's intent can be seen in 'Rounding Derry' (https://themachinefolksession.org/tune/587). The user generated tune 'FolkRNN Tune №24807' on a fresh load of folkrnn.org, i.e. default parameters, randomised seed. The user played this tune twice, and then selected the musical phrase 'C2EG ACEG|CGEG FDB,G,' and set this for the start_abc generation parameter. The user generated the next iteration, played it back, and archived on themachinefolksession.org with a title of their creation. There, the user writes –
'Generated from a pleasant 2 measure section of a random sequence, I liked this particularly because of the first 4 bars and then the jump to the 10th interval key center(?) in the second section. Also my first contribution!'


wip: Bump k8s 1.11 test version and dependencies to 1.11.3

depends on https://github.com/cilium/cilium/pull/5520

This change is

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-upstream-k8s

test-me-please

depends on https://github.com/kubernetes/release/issues/624

test-me-please

test-upstream-k8s


Adds missing closing parenthesis to README.md

Just a tiny typo: adds a closing parenthesis to README.md.

:+1:


Validate customer belongs to org when retrieveing encrypted account number

Codecov Report

Merging #217 into master will decrease coverage by 2.64%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   61.31%   58.66%   -2.65%
==========================================
  Files          49       49
  Lines        2629     2729     +100
==========================================
- Hits         1612     1601      -11
- Misses        710      822     +112
+ Partials      307      306       -1

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f86b774). Click here to learn what that means.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master     #217   +/-   ##
=========================================
  Coverage          ?   58.60%
=========================================
  Files             ?       49
  Lines             ?     2732
  Branches          ?        0
=========================================
  Hits              ?     1601
  Misses            ?      825
  Partials          ?      306


Dashboard shows currency in € when I have it in $ in Firefly

Dashboard shows currency in euros when I have it in dollars in Firefly. I cannot seem to change the currency in Waterfly either. Extra strange part is that the Transactions show properly in dollars.

No euros used in app. I have usd set as default.
On Sat, Jun 10, 2023, 01:44 dreautall @.***> wrote:

Do you have any euro asset accounts in Firefly? In the Firefly
Webinterface, which currency is labelled as default (under Settings ->
Currencies)?
—
Reply to this email directly, view it on GitHub
https://github.com/dreautall/waterfly-iii/issues/58#issuecomment-1585500990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALJFQYJM5FI6PKSEVYNXTJTXKQCTJANCNFSM6AAAAAAZAW4AMI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I just logged into the app to check. It was the Daily Summary but looking
at it now it shows the currency in dollars. I guess it just took a few
hours for the Daily Summary to update to the proper currency. Strange.
Thank you for your help.
On Sat, Jun 10, 2023, 09:11 dreautall @.***> wrote:

Which chart(s) in the dashboard are showing euros?
—
Reply to this email directly, view it on GitHub
https://github.com/dreautall/waterfly-iii/issues/58#issuecomment-1585659776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALJFQYOKXDKNK3DZNWUOEK3XKRXBTANCNFSM6AAAAAAZAW4AMI
.
You are receiving this because you authored the thread.Message ID:
@.***>


[AMENDMENT] ProtonMail

Title
ProtonMail (source: Communication ➜ Encrypted Email ➜ ProtonMail)
Amendments
ProtonMail's description starts with "An open-source..." but is flagged as "Not Open Source" which is quite ambiguous.  I suggest here to remove the open-source part of the introduction.
Amendment Data
name: ProtonMail
url: https://protonmail.com
icon: https://proton.me/favicons/android-chrome-192x192.png
openSource: false
github: ProtonMail/WebClients
tosdrId: 491
androidApp: ch.protonmail.android
iosApp: https://apps.apple.com/us/app/proton-mail-encrypted-email/id979659905
subreddit: ProtonMail
description: >
  An end-to-end encrypted anonymous email service. ProtonMail has a

  modern easy-to-use and customizable UI, as well as fast, secure native mobile

  apps. ProtonMail has all the features that you'd expect from a modern email

  service and is based on simplicity without sacrificing security. It has a free

  plan or a premium option for using custom domains (starting at $5/month).

  ProtonMail requires no personally identifiable information for signup, they
  have

  a [.onion](https://protonirockerxow.onion) server, for access via Tor, and
  they

  accept anonymous payment: BTC and cash (as well as the normal credit card and
  PayPal).

Affiliation Disclosure
None
Would you like to submit a PR?
Yes!
Please tick the boxes

[X] You have filled out this form accurately, and to the best of your knowledge
[X] You have indicated whether or not you are associated with the project the amendment refers to
[X] A similar submission has not already been opened for this software / service
[X] You agree to our Code of Conduct
[X] You have read and followed the Contributing Guide

Fixed in https://github.com/Lissy93/awesome-privacy/pull/285. Thanks for the issue!


Scale up QueryService

Is there a possibility to scale up the QueryService by increasing the replicaCount value?
Since the QueryService uses a local SqliteDB to store metadata such as users, I do not see the possibility for scaling. Can you use an external PostgresDB in such cases? As stated in this issue, this does not seem supported: https://github.com/SigNoz/signoz/issues/941.
Is there any other way? Otherwise, I don't see the reason for the replicaCount value if the cluster breaks when it is higher than 1.
(I have tried it for testing purposes and accounts do not propagate to other QueryService Nodes. Therefore it is random if you can log in or not.)

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Hi @m-riedel,
Yes, horizontal scaling of query-service is not supported right now.


Icebox support for ice40 LM

This is Icebox support for the ice40 LM. It's successfully generated a chipdb and abitstream with arachne-pnr. Hardware verification is in work.

Awesome! However, a minor nitpick, the chipdb should not be included in the repo, but gitignored like the other chipdbs to avoid the repo ballooning in size (changes to routing may also cause large changes to the chipdb.)
Thanks for your work!

However, a minor nitpick, the chipdb should not be included in the repo

+1
@awygle can you please rebase this PR so that  chipdb-lm4k.txt is not even part of the git history? Thanks.

Fixed! Sorry - saw the other DBs not in git status and read that as "committed" not "gitignored" :)


Design Committee

Description
Currently there are inconsistencies in the designs of different objects and UI elements in the game so it would be beneficial to all teams' designers to have a list of consistent guidelines. The purpose of the UI/UX design committee is to communicate results from team 15’s user testing, in which users will provide feedback on the design consistency and overall aesthetics of the entire game.
Dependencies
The communication of updated design guidelines and high priority design amendments will depend on the user testing and analysis completed by team 15: Improving UI elements and adding animations
Milestones

[x] Confirm updated design guidelines with committee members (i.e. designers from all teams) (Oct. 12)
[x] Communicate findings from user testing and consequent design guidelines to all teams (Oct. 13)
[x] Create an improved version of the Style Guide to maintain consistent standards across design (Oct. 18)

Completion Deadline: Oct. 18
Documentation

Main description of feature
User documentation
...

Members

Suhas Udupa (@suhasudupaa) (Suhas Udupa)
Emma Schmidley (@schmidem) (Emma Schmidley)
Rohan Teotia (@RohanTeo) (Rohan Teotia)
Aleks (@a-siroki) (Aleks Siroki)
Annabel (@Annabel-Kennedy, Annabel Kennedy)

Hi UX Committee! Just confirming that all changes required from the document have now been implemented into the shop & inventory features. Thanks!

Hi UX Committee! Just confirming that all changes required from the document have now been implemented into the shop & inventory features. Thanks!

That's amazing! We saw the improvements! Thank you for an excellent cooperation!

Discussion between design committee members on the 13/10 about how designers will check that their designs align with the revised style guidelines. It was concluded that this would be a self checking process and hence no submission folder was needed where decisions would submit there work for approval.

Decision relayed to all designers in the uiux committee:


App force close with DND

Android 9
Not rooted
Ver 0.9.5
Pixel 3
App works great, when do not disturb is active the quick settings will cause the program to force close. This is reproducible and stops when dnd is deactivated.

Have you tried disabling the behavior toggles on the app settings? Also let me know if this last update fixed it for you.

This should've been fixed.
Closing after deploying the first stable release. Enjoy 1.0.1 :-)
Please reopen if you find this issue again. Thank you!


[dvsim] Fix remaining comments  from #5876

Signed-off-by: Srikrishna Iyer<EMAIL_ADDRESS>

Calling other tools is a key functionality of dvsim, and as such, we need to get this functionality right and fully understand our own code.
This PR is clearly a workaround for a problem that is not understood. I can see the desire to paper over a problem during time pressure, and as such am approving this PR.
But even in such a case (and even more so!) be explicit and clear about it in the pull request and commit message.
Before merging, please rewrite the commit message to clearly indicate that this is a temporary workaround for a yet undiagnosed issue. Link to the follow-up issue you filed. In the follow-up issue (https://github.com/lowRISC/opentitan/issues/5945), explain how to reproduce the issue that led to the workaround you're applying in this PR, the behavior you see, etc.


Improve Initialization Time

Hello,
Thanks for developing such an awesome library! I had one question around the initialization time, specifically the time it takes from calling start on a micro service to getting the onStart callback and then getting my "READY" callback after my js file has loaded. On average from the time I call start on the micro service to the time I get the onStart callback I see about a 500 ms overhead. Then from onStart to the time I get my "READY" callback at the end of my js file (which is fairly large at about 3mb) its about another 2 seconds. I was wondering if anyone else has experienced anything like this and found a way to reduce this overhead.
Thanks,
Tyler

I haven't done any work around profiling, so I haven't attempted to optimize speed.
At 3mb, it is going to be difficult to get it to be much more efficient, I think.  Are you triggering a micro service in multiple places?  The best I can recommend at this point is to launch a single micro service once, and then use the emitter interface to send multiple requests to it.  That way you only endure the startup pain once per launch.
Are you using liquidserver to serve the js or are you embedding it as a resource in your app?  If you are using liquidserver, may I recommend that you copy the js from the .lib directory and put it in your app as a resource?  Let me know if that improves the speed (basically removing the network calls) -- if it does, then it may be that caching isn't working right.  If it doesn't, then it means that it just takes a long time for node to chew on your giant file.
I will put this into my backlog of things to investigate.

Thanks for the reply,
I am currently using the liquidserver to serve the js file from raw resources, not the network. I haven't tested what kind of delay the network calls would add, but I'm currently only planning to use the local resource. It's a pretty big file though, it was 3mb minified and about 7 mb before that (around 200,000 lines). Its a fairly large project which I compiled together with webpack.
I am also currently only triggering the microservice once, so it's just the initial 2.5 second added delay. I was actually able to reduce the dependencies and get the file size down to 500kb minified. This reduced the delay to about 1.2 seconds total until the READY event. I also noticed that minified vs non minified didn't make a huge different in the delay (~100 ms or so), even though the size was about half.
I was wondering if there was a way to remove the sqllite dependency and all the file system code the runs in the begging and just setup the node environment bare (not sure if this is technically possible)? That could help to reduce the initial 500 ms delay I see before the onStart of the microservice.
Thanks so much again for an amazing library. It works fantastically for my use case! I'm just trying to see how much I can minimize this initialization time overhead as its really the only drawback I currently have as opposed to re-writing the code in java.
Thanks again,
Tyler

You can remove these things, but it would require rebuilding the library.  How much do really require node?  If it is raw javascript (and you don't need networking and other node built-ins), then you can just use the javascript engine directly.

I could probably get around using node if I polyfill some of the API's. With the java scrip engine, I wouldn't be able to use the event based API though correct? Ill look into how much time it would save using the engine directly.
One this I was wondering if there way a way to prevent having to go through the setup every time the user opened the app. Would it be possible to persist the filesystem and avoid having to do this setup every time the user opens then app, but instead just the first time? It would be great to be able to persist the id and just look up if its already initialized. Not sure if that is possible?
Specifically talking about these steps:
07-20 12:12:14.253 Create dir /files/org.liquidplayer.node/node_modules
07-20 12:12:14.255 Create dir /files/org.liquidplayer.node/node_modules/sqlite3
07-20 12:12:14.256 Create dir /files/org.liquidplayer.node/node_modules/sqlite3/lib
07-20 12:12:14.257 Copying node_modules/sqlite3/lib/index.js to /files/org.liquidplayer.node/node_modules/sqlite3/lib/index.js
07-20 12:12:14.257 Copying node_modules/sqlite3/lib/sqlite3.js to /files/org.liquidplayer.node/node_modules/sqlite3/lib/sqlite3.js
07-20 12:12:14.258 Copying node_modules/sqlite3/lib/trace.js to /files/org.liquidplayer.node/node_modules/sqlite3/lib/trace.js
07-20 12:12:14.259 Copying node_modules/sqlite3/package.json to /files/org.liquidplayer.node/node_modules/sqlite3/package.json
07-20 12:12:14.260 Copying node_modules/sqlite3/sqlite3.js to /files/org.liquidplayer.node/node_modules/sqlite3/sqlite3.js
07-20 12:12:14.524 deleting session /cache/org.liquidplayer.node/sessions/7b26d77c-17cc-47c4-9a3d-3d0a719027d2
07-20 12:12:14.531 Created directory /cache/org.liquidplayer.node/sessions/cf9da525-fa90-432b-a430-d262eedde5a3/home
07-20 12:12:14.545 Created directory /cache/org.liquidplayer.node/sessions/cf9da525-fa90-432b-a430-d262eedde5a3/temp

FYI, I was able to get the code running using the javascript engine directly. This brought the initialization time down to ~800 ms. Much better than ~1300 with a microservice. Here is a breakdown of the ~800 ms.
Creating JSContext: 202 ms
Evaluating JS file: 602 ms
Total time: 804 ms

Another update,
I decided to try our AndroidJSCore, the library you deprecated for this one and found some interesting results. It is much faster than LiquidCore in terms of initialization. Here are the same times for AndroidJSCore on the same device, with the same code.
Creating JSContext: 46 ms
Evaluating JS file: 329 ms
Total time: 375 ms
I guess JavascriptCore can initialize and process the javascript code faster than V8?

@ericwlange Looks like the main way to reduce the context creation time would be to use the V8 snapshots feature. Have you looked into this at all?
Some information: https://v8project.blogspot.com/2015/09/custom-startup-snapshots.html

I haven't look at the snapshots feature yet.  Thanks for sending.  But I did watch the Chrome Dev Summit livestream and the v8 team mentioned that the newest version is 22% faster, and that the node community has been integrating it.  I will let it settle a bit and then upgrade the version of node.  In the meantime, I will look into snapshots.


Add action to publish RC to PyPi

Untested since its pretty hard to test manual workflows on branches, after merge I'll try it and make any fixes as needed.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @Abacn

R: @jrmccluskey


Remember window position & size

At the moment the Mod Manager doesn't save its window state (maximized or not), window size and position upon exiting, so restarting the program resets to default position and size. This becomes an issue when the default position and size are difficult to use, for example with the current design the Mod Manager's controls don't fit the screen at 1920x1080 with 150% scaling so it needs manual adjustments on every startup.

The last update should now save the size when you click on save and load it on startup. I haven't added position yet, since I remember an issue with it from the old Manager where on a rare case, the window could become unavailable, as if it  was offscreen. I do not know if that issue would be on WPF, this would require more tests first, but either way, I figured out size should be the most important part for now.


Internal comment 16

Issue description
Describe your issue in detail here
Internal comment 16
Definition Of Ready (DoR)
This issue can be worked on if

[x] a developer is assigned
[x] the issue is labeled
[x] the issue is assigned to the current sprint
[x] the issue is estimated
[x] a meaningful title has been set
[x] the issue is described in detail

https://fibo952390745.wordpress.com/2023/05/18/week-15-design-patterns/comment-page-1/#comment-60


what is instant and override

what is instant and override in ca settings

Instant was known as Predict before. It attacks the crystal in the moment the SpawnPacket for it arrives, which can save up to 50ms per crystal.
Override ignores the MaxSelfPlace and MaxSelfBreak Damage that the crystal will deal to you (still checks that that crystal doesn't kill you), if it can deal lethal damage to the target with it.


Text color

The text color used in the paragraph with class=content-body-font just under the navbar is getting mixed up with the background  which doesn't looks so good.
Would like to improve upon it as a part of GSSOC' 21.

Can I work on this?

can you please assign this issue to me?

Can I work on this issue ?

Can l work on this issue?

Can you assign this issue to me?

Can l work on this issue?

Please assign this issue to me, i would like to work on this and show my creativity @Pranav016

Closing this issue as PR is merged.


Native mobile clients

Is swarm going to support mobile clients natively (via swift/java languages)? If yes, do you need help with adapting code for these platforms?

That is the plan.
My personal plan is to put things in order till early January. Make sure all implementations match the latest spec, can talk to each other, etc.
You may focus on making the Java version up-to-date or you may start a Swift version, it is up to you.
Feel free to ask me any questions.


Change one access to barrier queue from dispatch_sync to dispatch_bar…

…rier_sync to solve potential multi-thread problem.
New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
The barrierQueue in SDWebImageDownloadOperation is a concurrent queue. Any other write acess such as [self.callbackBlocks addObject:callbacks] and [self.callbackBlocks removeObjectIdenticalTo:token] is all placed during a dispatch_barrier_sync block. Therefore the read acess should also use dispatch_barrier_sync instead of dispatch_sync to avoid multi-thread problem.
This commit is from #1684.

@dreampiggy I don't think I agree. Here's how I see it.
For synchronization of a resource using queues you can go with 2 options: serial queue (easier to implement, just one operation allowed at a time) and option 2 is a concurrent queue.
A concurrent queue allows the multi-reader single-writer pattern, this is the case here. So all writes to the resource (callbackBlocks array) are using dispatch_barrier_sync which makes sure no other block is executed on that resource. But for the reads, using dispatch_sync will allow multiple read operations going on at once.
If we make everything a dispatch_barrier_sync, it's the same as using a serial queue - which we should do to avoid the extra-not-justified-complexity.
Now, I'm not sure I got what the crash from #1684 is all about, can someone give me some insights?

@bpoplauschi Well. I don't mean any crash. And I think this will not cause a crash because it's looks safe with only one writer and multiple reader. I mean this may cause some issue in logic. For example, when the writer submit a block, this should be delay but currently all the readers may get the wrong result. It's not really safe to use one writer and multiple readers in multi-thread environment, in practice... Especially it's really performance-sensitive.
And I suggest, for one writer and multiple readers, it's not recommended to use dispatch_barrier_async for writter and dispatch_sync for reader. This will cause a dead-lock in some cases(This is because of GCD Thread Pool limit of 64 threads, I can tell more detail information later since it's midnight in my local timezone 😴 ). We should use pthread_rwlock.  You can try this demo project about reader-writer thread safe. Try set that reader: writer greater than 3:1 and you will trigger dead-lock for GCD.
Demo : https://github.com/dreampiggy/ThreadSafeTest

Oh...maybe this is related to that #803 ? A dead-lock ? Maybe I can try to investigate later.

@dreampiggy man don't stay up late :) we need you fresh :) let's look at this in more detail after merging the decoding refactoring.

@dreampiggy 兄弟你是真的稳。不过注意身体啊老哥，身体是革命的本钱 😃 ("Sleep early" in our native tongue)

@bpoplauschi https://stackoverflow.com/questions/15150308/workaround-on-the-threads-limit-in-grand-central-dispatch
GCD use a thread pool to manage the threads to manager your block submits to the queue. But it has a max threads limits for each queue. For some cases like this approach to read-write-lock. It will trigger the max limits of threads and no more thread can be created. So that GCD will notice that system resouce is exhausted. And write all that threads to end and dispatch the newly block. But the all threads can not release the resource. Then a dead-lock will occur.
So how to trigger this case ? Currently I found that if you can use dispatch_sync with more than 64 times (This will simulate a situation that alll 64 threads is locked and wait for resource). meanwhile there is a barrier used dispatch_async(This will simulate a situation that a new GCD resource may be available) . Then this will cause a dead lock.
- (void)testAll {
    int loop = 30; // if loop * read > 64, the dead lock may occur. Higher loop will have a high rate
    int write = 1;
    int read = 3;
    dispatch_queue_t barrierQueue = dispatch_queue_create("barrier", DISPATCH_QUEUE_CONCURRENT);
    dispatch_queue_t concurrentQueue = dispatch_queue_create("concurrent", DISPATCH_QUEUE_CONCURRENT);
    for (int i = 0; i < loop; i++) { // why to place in a loop is to simulate a random add read/write block because GCD will execute the block immediately
        for (int j = 0; j < write; j++) {
            dispatch_async(barrierQueue, ^{
                dispatch_barrier_async(concurrentQueue, ^{
                    NSLog(@"%@", @"write");
                });
            });
        }
        for (int k = 0; k < read; k++) {
            dispatch_async(barrierQueue, ^{
                dispatch_sync(concurrentQueue, ^{
                    NSLog(@"%@", @"read");
                });
            });
        }
    }
}

So, it's not recommend to use GCD to approach that read-write-lock synchronization algorithm. A better solution is to use pthread_rwlock. This is a more safe way to do this.

Now, look at our code:
-[SDWebImageDownloaderOperation cancel:] is that reader. It can be called from -[SDWebImageDownloader cancel:]. This is also a concurrent enviroment.
-[SDWebImageDownloaderOperation reset] is that writer. It can also be called from SDWebImageDownloader. And this is also a concurrent enviroment.
This situation is normally OK. But in a really rare case（for example, user call cancel manually concurrently; user use prefetcher and manager concurrently with same URL at the same time) . This can cause a dead-lock. I personally not face this situation, but #803 may be a case that match this dead-lock. I advice to switch from that barrier queue in SDWebIamgeDownloadOperation  to pthread_rwlock. This can keep the read-write-lock performance and may solve this problem.

@dreampiggy why did you remove this PR from 4.2.0? I missed it :)

@bpoplauschi Need more investigation about this one. I prefer to use pthread_rwlock instead of barrier_queue. But since the case is really rare(hit the 64 threads limit), we can keep the current solution.


Massive slowdown in v 4.8

Describe the bug
Has anyone else experienced a massive slowdown in solution load time starting in v. 4.8?  In 4.7 my solution of 16 .fsproj files and 2 .csproj files can load in about 30 sec to a minute (as in all fsproj files are loaded in the solution explorer and Intellisense is working).  In v4.8 and v4.8.1 loading the same solution can take 15-30 min.
Environment (please complete the following information):

OS: Windows
Ionide version: 4.8.0 & 4.8.1
VSCode version: 1.43.2
dotnet SDK version: 3.1.101
mono / .Net Framework version: 4.7.2 is installed, but my solution is using 4.7.1

Additional context
Could this be related to the presence of the 2 C# projects in my solution?

Unfortunately I can't share my repo.  I'm happy using 4.7 for now, or if others are experiencing the problem and there's an interest in diagnosing this further, I can try to make an open repo that reproduces the issue.  (I don't want to do that if no one else is experiencing the problem though).

Should be fixed in 4.11


Cube: Corrupted Ashbringer

This item cannot be cubed in-game yet appears in the cube for every class on the planner.

Fixed.


Cloning behavior inconsistent with the extension

Hi there!
I'm implementing a middleware pipeline third-party library using this extension with the polyfill. The implementation exhausts the Queue class of this library recursively by cloning itself. You can take a look at the implementation here.
When I run the tests with the extension, everything works perfectly well and as expected. However, when I run the tests with the polyfill, everything breaks.
Looking at the polyfill code, I realized that there was not a Ds\Queue::__clone method implemented, so when I called clone on the queue, the internal Ds\Deque containing the array was not being cloned.
I implemented the clone method in my vendor folder just for testing purposes, and this fixed it.
I can submit a PR with the fix if you are busy to fix it yourself. Just let me know.
Thanks for this awesome extension!

Thanks for this bug report, I'll make some time to fix this asap. 👍

Thanks a lot! Switched to Deque in the meantime so no hurry! :)


feat: add distrobuilder to -dx

Adds distrobuilder to -dx for building custom incus and lxd images.

Note: distrobuilder can't be run in a container for technical reasons, that would have been preferred.


Cloned hyperline repo fails to load

While installing the plugin using hpm-cli I have no issues and works perfectly. It fails to load when I clone the repo for development. Here is a screenshot of the issue.

The cloned repo is at

My .hyperterm.js

Is there something else I must do in order to make it work, besides cloning the repo at the hyperterm_plugins/local folder?

@Or3stis try the following steps and let me know if they work out for you. I'm submitting a PR for this.
To set up the project for development:

Clone this repository into ~/.hyperterm_plugins/local/
Run npm install within the project directory
Run npm run build to build the plugin OR npm run dev to build the plugin and watch for file changes.
Add the name of the directory to localPlugins in ~/.hyperterm.js.
Reload terminal window

It works great 👍 !!
Thank you @JerryLopez


turn-layout-manager/v1.1 build

Hi Collin, it seems the build for 1.1 has failed in jitpack, do you mind having a look into whenever you can please? Thanks!
Log https://jitpack.io/com/github/cdflynn/turn-layout-manager/v1.1/build.log

It seems that it's missing the following imports:
import android.view.ViewGroup;
import android.os.Build;

Thanks! should be resolved now with v1.2


Sort hosts in RollingUpdateService

@rohansingh @gimaker

:+1:

:cat: sorting cat sez plz implement natural ordering kthxbye :trollface:

:+1:


switching monitor is only effective when there are windows in the monitor

switching monitor is only effective when there are windows in the monitor
I have the following binding in my ~/.skhdrc
cmd - 1 : chunkc tiling::monitor -f 1
cmd - 2 : chunkc tiling::monitor -f 2

if you can not reproduce this problem,
I will supply my full config files.

This has been discussed a lot in previous issues regarding multi-monitor behaviour. There is no way we know to focus the desktop on a given monitor programmatically.

thanks @dominiklohmann
sad to know
closing it


[R-package] lgb.prepare_rules() and lgb.prepare_rules2() should validate rules

Summary
lgb.prepare_rules() should validate that rulesis a list of named numeric vectors.lgb.prepare_rules2()should validate thatrules` is a list of named integer vectors.
"validate" = throw an informative error
Motivation
Currently, lgb.prepare_rules() and lgb.prepare_rules2()  accept rules and apply them without validating the contents. This could silently cause undesirable effects.
The following code should result in an error because the values in rules are numeric, not integer
testDF <- data.frame(
    character_col = c("a", NA_character_, "c", "a", "a", "c")
    , na_col = rep(NA, 6L)
    , na_real_col = rep(NA_real_, 6L)
    , na_int_col = rep(NA_integer_, 6L)
    , na_character_col = rep(NA_character_, 6L)
    , numeric_col = c(1.0, 9.0, NA_real_, 10.0, 11.0, 12.0)
    , factor_col = as.factor(c("n", "n", "y", "y", "n", "n"))
    , integer_col = c(1L, 9L, NA_integer_, 1L, 1L, 1L)
    , stringsAsFactors = FALSE
)
custom_rules <- list(
    "character_col" = c(
        "a" = 5.5
        , "c" = -10.2
    )
    , "factor_col" = c(
        "n" = 65.4
        , "y" = 65.01
    )
)
result <- lgb.prepare_rules2(
    data = input_data
    , rules = custom_rules
)

Closed in favor of being in #2302. We decided to keep all feature requests in one place.
Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

I've updated the title and description here now that #3095 has been merged


The type initializer for 'SQLite.SQLiteConnection' threw an exception. ---> System.DllNotFoundException: e_sqlite3

On our Xamarin Android project we are trying to switch from sqlite-net to official sqlite-net-pcl package.

However after this switch when creating a new SQLiteConnection I am getting following exception:

The type initializer for 'SQLite.SQLiteConnection' threw an exception.
---> System.DllNotFoundException: e_sqlite3

Full exception:

Xamarin caused by: android.runtime.JavaProxyThrowable:
System.TypeInitializationException: The type initializer for
'SQLite.SQLiteConnection' threw an exception. --->
System.DllNotFoundException: e_sqlite3   at (wrapper
managed-to-native)
SQLitePCL.SQLite3Provider_e_sqlite3+NativeMethods:sqlite3_libversion_number
()   at
SQLitePCL.SQLite3Provider_e_sqlite3.SQLitePCL.ISQLite3Provider.sqlite3_libversion_number
() [0x00000] in :0    at
SQLitePCL.raw.SetProvider (SQLitePCL.ISQLite3Provider imp) [0x00000]
in <4472a4c16754425197d915f39ebd937e>:0    at
SQLitePCL.Batteries_V2.Init () [0x0000d] in
<1125db7e18f0475797b2764ec6653cf1>:0    at
SQLite.SQLiteConnection..cctor () [0x00000] in
/Users/fak/Dropbox/Projects/sqlite-net/src/SQLite.cs:171     --- End
of inner exception stack trace --- 	at
mono.android.view.View_OnClickListenerImplementor.n_onClick(Native
Method) 	at
mono.android.view.View_OnClickListenerImplementor.onClick(View_OnClickListenerImplementor.java:30)
at android.view.View.performClick(View.java:4780) 	at
android.view.View$PerformClick.run(View.java:19866) 	at
android.os.Handler.handleCallback(Handler.java:739) 	at
android.os.Handler.dispatchMessage(Handler.java:95) 	at
android.os.Looper.loop(Looper.java:135) 	at
android.app.ActivityThread.main(ActivityThread.java:5254) 	at
java.lang.reflect.Method.invoke(Native Method) 	at
java.lang.reflect.Method.invoke(Method.java:372) 	at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

In the log I can see following info:

12-01 10:43:05.356 D/Mono    (11194): DllImport attempting to load:
'e_sqlite3'. 12-01 10:43:05.358 D/Mono    (11194): DllImport error
loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3"
not found'. 12-01 10:43:05.360 D/Mono    (11194): DllImport error
loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so"
not found'. 12-01 10:43:05.360 D/Mono    (11194): DllImport error
loading library '/system/lib/libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3" not
found'. 12-01 10:43:05.360 D/Mono    (11194): DllImport error loading
library '/system/lib/libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3.so"
not found'. 12-01 10:43:05.360 D/Mono    (11194): DllImport error
loading library 'libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.
12-01 10:43:05.361 D/Mono    (11194): DllImport error loading library
'libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3.so" not found'.
12-01 10:43:05.361 D/Mono    (11194): DllImport error loading library
'e_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/e_sqlite3" not found'. 12-01
10:43:05.362 D/Mono    (11194): DllImport error loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3"
not found'. 12-01 10:43:05.364 D/Mono    (11194): DllImport error
loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so"
not found'. 12-01 10:43:05.364 D/Mono    (11194): DllImport error
loading library '/system/lib/libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3" not
found'. 12-01 10:43:05.364 D/Mono    (11194): DllImport error loading
library '/system/lib/libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3.so"
not found'. 12-01 10:43:05.364 D/Mono    (11194): DllImport error
loading library 'libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.
12-01 10:43:05.364 D/Mono    (11194): DllImport error loading library
'libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3.so" not found'.
12-01 10:43:05.365 D/Mono    (11194): DllImport error loading library
'libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.
12-01 10:43:05.365 W/Mono    (11194): DllImport unable to load library
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.
12-01 10:43:05.365 D/Mono    (11194): DllImport attempting to load:
'e_sqlite3'. 12-01 10:43:05.366 D/Mono    (11194): DllImport error
loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3"
not found'. 12-01 10:43:05.368 D/Mono    (11194): DllImport error
loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so"
not found'. 12-01 10:43:05.368 D/Mono    (11194): DllImport error
loading library '/system/lib/libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3" not
found'. 12-01 10:43:05.368 D/Mono    (11194): DllImport error loading
library '/system/lib/libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3.so"
not found'. 12-01 10:43:05.368 D/Mono    (11194): DllImport error
loading library 'libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.
12-01 10:43:05.368 D/Mono    (11194): DllImport error loading library
'libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3.so" not found'.
12-01 10:43:05.369 D/Mono    (11194): DllImport error loading library
'e_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/e_sqlite3" not found'. 12-01
10:43:05.370 D/Mono    (11194): DllImport error loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3"
not found'. 12-01 10:43:05.371 D/Mono    (11194): DllImport error
loading library
'/storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so':
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//storage/emulated/0/Android/data/com.psonar.android/files/.override/libe_sqlite3.so"
not found'. 12-01 10:43:05.372 D/Mono    (11194): DllImport error
loading library '/system/lib/libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3" not
found'. 12-01 10:43:05.372 D/Mono    (11194): DllImport error loading
library '/system/lib/libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86//system/lib/libe_sqlite3.so"
not found'. 12-01 10:43:05.372 D/Mono    (11194): DllImport error
loading library 'libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.
12-01 10:43:05.372 D/Mono    (11194): DllImport error loading library
'libe_sqlite3.so': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3.so" not found'.
12-01 10:43:05.373 D/Mono    (11194): DllImport error loading library
'libe_sqlite3': 'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.
12-01 10:43:05.373 W/Mono    (11194): DllImport unable to load library
'dlopen failed: library
"/data/app/com.psonar.android-1/lib/x86/libe_sqlite3" not found'.

It's obvious what's wrong: System.DllNotFoundException: e_sqlite3 however I can't find any relevant info that would lead to solving this problem.
I checked my nuget packages and they all seem to be correctly installed.

I checked the package location and it is all correct. Very unsure where the cause might be.

I can't reproduce this.  I just did a quick sample project and things seem to work fine.  So we need to figure out what's different about your situation.
The references do look right.
Are you building debug or release?
Is this happening in an emulator or on a device?
Are the nuget packages installed into a PCL project, or a Droid app project, or both?
The first thing I would do is go into the build output directory, find the APK file, and use "unzip -l" to examine its contents, and see if lib/x86/libe_sqlite3.so made it there.

Hello Eric,
Is this happening in an emulator or on a device?
I tried both - emulator and a device (one running API 22 the other one running api 23).
Are you building debug or release?
Build in debug (didn't think of trying release).
Are the nuget packages installed into a PCL project, or a Droid app project, or both?
Installed in Droid App project
The first thing I would do is go into the build output directory, find the APK file, and use "unzip -l" to examine its contents, and see if lib/x86/libe_sqlite3.so made it there.
Good tip, I will try that tomorrow.

As you were suspecting -  lib/x86/libe_sqlite3.so didn't make it there:
http://i26.photobucket.com/albums/c148/Kubatko/sqlite-net-pcl.png
Any suspicion of why that might be happening?

At the moment, I have no idea.  So I'll make some wild guesses of things to check.
Xamarin Android linker settings?
Target Android version?
Force a full rebuild?
Older versions of nuget or Visual Studio or Xamarin Studio?

Do you have the linker enabled? Perhaps the linker is removing the library.

OK, solved it. Even though I am a little bit confused. If I add the sqlite-pcl packages to my starting project then the libe_sqlite3 appears there correctly. If I have it in my droid project which is referenced by the starting project then it gets stripped away.
To answer the previous questions:
Xamarin Android linker settings?
Linker is set to "none".
Target Android version?
The latest one.
Force a full rebuild?

Older versions of nuget or Visual Studio or Xamarin Studio?
All to the latest versions. (using VS 2015)

Oh, yeah.  That would do it.
Not adding the pkg to the app project is a common problem.  But when I saw that you were adding it to a non-PCL Droid-specific project, I assumed that project was the app, not a library.

All good then, thanks for your help. Closing :)

This error is still occurring with Xamarin PCL.
Environment:  VS2015 Xamarin.Forms.Portable targeting Android
Build : Compile using Android 6.0.
Nugets : In Droid Project
sqlite-net-pcl  v1.3.1
SQLitePCLRaw.bundle_green v.1.1,2
-net-pcl  v1.3.1sqlite-net-pcl  v1.3.1


DeepSpeed ZeRO 3 issue

I followed all the instructions for training, ran the pre-training script on 1 image for debugging and was getting a lot of GPU memory usage and the following error:
"[rank0]: Traceback (most recent call last):
[rank0]:   File "videollama2/train_flash_attn.py", line 12, in
[rank0]:     train(attn_implementation="flash_attention_2")
[rank0]:   File "/home/ayaan/VideoLLaMA2/./videollama2/train.py", line 964, in train
[rank0]:     safe_save_model_for_hf_trainer(trainer=trainer, output_dir=training_args.output_dir)
[rank0]:   File "/home/ayaan/VideoLLaMA2/./videollama2/train.py", line 226, in safe_save_model_for_hf_trainer
[rank0]:     weight_to_save = get_mm_adapter_state_maybe_zero_3(trainer.model.named_parameters(), keys_to_match)
[rank0]:   File "/home/ayaan/VideoLLaMA2/./videollama2/train.py", line 196, in get_mm_adapter_state_maybe_zero_3
[rank0]:     to_return = {k: maybe_zero_3(v, ignore_status=True).cpu() for k, v in to_return.items()}
[rank0]:   File "/home/ayaan/VideoLLaMA2/./videollama2/train.py", line 196, in
[rank0]:     to_return = {k: maybe_zero_3(v, ignore_status=True).cpu() for k, v in to_return.items()}
[rank0]:   File "/home/ayaan/VideoLLaMA2/./videollama2/train.py", line 154, in maybe_zero_3
[rank0]:     param = param.data.detach().cpu().clone()
[rank0]:   File "/home/ayaan/miniconda3/envs/myenv/lib/python3.8/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 2230, in exit
[rank0]:     self.params[0].partition(param_list=self.params, has_been_updated=False)
[rank0]:   File "/home/ayaan/miniconda3/envs/myenv/lib/python3.8/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1375, in partition
[rank0]:     self._partition(param_list, has_been_updated=has_been_updated)
[rank0]:   File "/home/ayaan/miniconda3/envs/myenv/lib/python3.8/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1524, in _partition
[rank0]:     self._partition_param(param, has_been_updated=has_been_updated)
[rank0]:   File "/home/ayaan/miniconda3/envs/myenv/lib/python3.8/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
[rank0]:     ret_val = func(*args, **kwargs)
[rank0]:   File "/home/ayaan/miniconda3/envs/myenv/lib/python3.8/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1557, in _partition_param
[rank0]:     free_param(param)
[rank0]:   File "/home/ayaan/miniconda3/envs/myenv/lib/python3.8/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
[rank0]:     ret_val = func(*args, **kwargs)
[rank0]:   File "/home/ayaan/miniconda3/envs/myenv/lib/python3.8/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 281, in free_param
[rank0]:     assert not param.ds_active_sub_modules, param.ds_summary()
[rank0]: AssertionError: {'id': 682, 'status': 'AVAILABLE', 'numel': 4194304, 'ds_numel': 4194304, 'shape': (4096, 1024, 1, 1), 'ds_shape': (4096, 1024, 1, 1), 'requires_grad': True, 'grad_shape': None, 'persist': False, 'active_sub_modules': {755}, 'ds_tensor.shape': torch.Size([524288])}"
Did you guys encounter this and how can I fix this? I only get this error in DeepSpeed ZeRO 3 and not DeepSpeed ZeRO 2.

Hi, I am having the same issue as well. Have you figured out yet?


Repair incorrect fix for double increment of literal regex count.

On redeferral of an enclosing function, where nested functions are still in a compiled state, we do not want to re-increment the literal regex count for the nested functions. But we do still want to count the regexes and allocate new regex storage for the function we're recompiling. A new simple fix handles both cases.

@dilijev This is the one you were interested in.

@pleath Fix looks reasonable to me. Thanks!


Setting step to 1 makes slider integer

Then you can't set step back to 0.2

This also seems to be fixed.
I can set to min(0), max(100), step(1), and then to min(0), max(100), step(0.1), without issues.


[docs] Broken links in introduction.md

Description
The links as they appear on docs.opentitan.org are currently broken for the Hardware and Software links. Looks like these are pointing at paths like https://opentitan.org/hw/index.html when they should point to https://opentitan.org/book/hw/index.html. In the markdown doc the link looks the same as it does for the [OpenTitan Earl Grey Chip Datasheet](https://opentitan.org/book/hw/top_earlgrey/doc/specification.html), which generates the correct link, so I'm not sure exactly what is going on here.
It looks like this may be fix by https://github.com/lowRISC/opentitan/pull/17924, but still filling this since these are high visibility links.

Thanks for creating this issue. I should really have created it a little while ago, sorry.
This is a mdBook bug. I've created a bug report (https://github.com/rust-lang/mdBook/issues/2060) with a minimal reproduction and fix. TLDR; links work fine at  https://opentitan.org/book/doc/introduction.html but the same page is used for https://opentitan.org/book/ with broken links.
To fix this without having to wait for upstream we could:

move doc/introduction.md to README.md
use a patched version of mdbook.
use a redirect from /book/ to /book/doc/introduction.md in the site's deployment.

Some parts copied from https://github.com/lowRISC/opentitan/pull/17847#pullrequestreview-1378968940

Thanks @HU90m! It is my opinion that fixing these links should be a priority, and if we're blocked on upstream we should implement one of your fixes to temporarily resolve the issue, and then revert the change once the bug in mdBook is fixed upstream. My instinct is to use the patched version of mdbook that you linked, since that will be easy to revert.

That all sounds good, thanks for your input.
I'll get to work moving OT onto the patched version of mdbook first thing tomorrow.

On this note, it looks like the individual links to the IP specs (IP names in the table) are also broken: https://opentitan.org/book/hw/index.html#top

On this note, it looks like the individual links to the design specs (design names in the table) are also broken: https://opentitan.org/book/hw/index.html#top

Thanks for the heads up. This is captured in https://github.com/lowRISC/opentitan/issues/17591 and is next in priority after this issue.


141 serializable metrics

Let's discuss moving all the extension functions and their files into the tools.aqua.stars.core.metric.serialization package, or some subpackage. Maybe some of these files can also be merged.

We should also rename DataSaver.kt as this might be confusing. PlottingDataSaver.kt might be a valid option.

Still to do:

[ ] Add Serializable interface to more metrics
[ ] Add some more SerializationResults while implementing Serializable for metrics
[ ] Some more tests
[ ] A final comparison of all results (creation of final results file for pipeline)
[ ] Create ground-truth data for experiments
[ ] Update pipeline to check for changed evaluations

#164 should be merged first.

Currently missing interface implementations:

InvalidTSCInstances
MissingTSCInstances
PostEvaluationMetrics


Dependabot alerts on GHA

Type of question

General operator-related help

Question
What did you do?
In my project: https://github.com/lsst/qserv-operator:

I use latest version of operator-sdk (1.15.0)
I have enabled GHA's "Dependabot alerts"

What did you expect to see?
I do not want to have "Dependabot alerts"
What did you see instead? Under which circumstances?
I have two "Dependabot alerts" related to  dependencies provided by "operator-sdk":
https://github.com/lsst/qserv-operator/security/dependabot
Environment
Operator type:

/language go

Kubernetes cluster type:
kind
$ operator-sdk version
operator-sdk version: "v1.15.0", commit: "f6326e832a8a5e5453d0ad25e86714a0de2c0fc8", kubernetes version: "1.21", go version: "go1.16.10", GOOS: "linux", GOARCH: "amd64"

$ go version (if language is Go)
go version go1.16.3 linux/amd64

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.0", GitCommit:"c2b5237ccd9c0f1d600d3072634ca66cefdf272f", GitTreeState:"clean", BuildDate:"2021-08-04T18:03:20Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

Additional context

I forked so i could see the dependabot warnings.

Hi @fjammes, I just made a fresh repo with a new operator SDK project, and am not seeing any dependabot alerts. The versions locked in the go.sum files match. Can we get confirmation that you are still seeing these alerts?

Thanks @ryantking , yes I am still seeing the two alerts. Could you please provide me your go.sum? Here is two extract of mine:
$ cat go.sum| grep jwt-go
github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ=
github.com/form3tech-oss/jwt-go v3.2.2+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k=
github.com/form3tech-oss/jwt-go v3.2.3+incompatible h1:7ZaBxOI7TMoYBfyA3cQHErNNyAWIKUMIwqxEtgHOs5c=
github.com/form3tech-oss/jwt-go v3.2.3+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k=

$ cat go.sum| grep miekg
github.com/miekg/dns v1.0.14/go.mod h1:W1PPwlIAgtquWBMBEV9nkV9Cazfe8ScdGz/Lj7v3Nrg=

The vulnerabilities are on github.com/miekg/dns <= 1.1.25 and dgrijalva/jwt-go <= 3.2.0

@fjammes here are the same commands you executed:
$ cat go.sum| grep jwt-go
github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ=
github.com/form3tech-oss/jwt-go v3.2.2+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k=
github.com/form3tech-oss/jwt-go v3.2.3+incompatible h1:7ZaBxOI7TMoYBfyA3cQHErNNyAWIKUMIwqxEtgHOs5c=
github.com/form3tech-oss/jwt-go v3.2.3+incompatible/go.mod h1:pbq4aXjuKjdthFRnoDwaVPLA+WlJuPGy+QneDUgJi2k=

$ cat go.sum| grep miekg
github.com/miekg/dns v1.0.14/go.mod h1:W1PPwlIAgtquWBMBEV9nkV9Cazfe8ScdGz/Lj7v3Nrg=

The versions look the same to me.
Here is my test repo

@ryantking thanks so much! On my side the Dependabot alert have disappeared from Github webpage of my project for an unknown reason... So I will close this one.

@fjammes Great! Feel free to reopen if something else crops up.