[Web] In release mode, list indexing doesn't throw RangeError, returns null instead

Hey, this is quite a serious bug that we caught while shipping a new build of Dara.
Very hard to debug too, since it only manifests in the release mode for web, which doesn't have a sane way to get a stack trace (https://github.com/getsentry/sentry-dart/issues/417)
Code sample
// lib/main.dart

void main() {
  List<int> items = [1, 2, 3];
  print(items[3]);
}

Steps to Reproduce

Expected results:

Execute flutter run -d chrome on the code sample
See the following error -

Error: RangeError (index): Index out of range: index should be less than 3: 3
    at Object.throw_ [as throw] (http://localhost:51727/dart_sdk.js:5067:11)
    at Array.[dartx._get] (http://localhost:51727/dart_sdk.js:17485:21)
    at main$ (http://localhost:51727/packages/dara/main.dart.lib.js:18:28)
    at main (http://localhost:51727/web_entrypoint.dart.lib.js:36:29)
    at main.next (<anonymous>)
    at http://localhost:51727/dart_sdk.js:40571:33
    at _RootZone.runUnary (http://localhost:51727/dart_sdk.js:40441:59)
    at _FutureListener.thenAwait.handleValue (http://localhost:51727/dart_sdk.js:35363:29)
    at handleValueCallback (http://localhost:51727/dart_sdk.js:35931:49)
    at Function._propagateToListeners (http://localhost:51727/dart_sdk.js:35969:17)
    at _Future.new.[_completeWithValue] (http://localhost:51727/dart_sdk.js:35817:23)
    at http://localhost:51727/dart_sdk.js:34998:46
    at _RootZone.runUnary (http://localhost:51727/dart_sdk.js:40441:59)
    at _FutureListener.then.handleValue (http://localhost:51727/dart_sdk.js:35363:29)
    at handleValueCallback (http://localhost:51727/dart_sdk.js:35931:49)
    at Function._propagateToListeners (http://localhost:51727/dart_sdk.js:35969:17)
    at _Future.new.[_completeWithValue] (http://localhost:51727/dart_sdk.js:35817:23)
    at async._AsyncCallbackEntry.new.callback (http://localhost:51727/dart_sdk.js:35838:35)
    at Object._microtaskLoop (http://localhost:51727/dart_sdk.js:40708:13)
    at _startMicrotaskLoop (http://localhost:51727/dart_sdk.js:40714:13)
    at http://localhost:51727/dart_sdk.js:36191:9

Actual results:

Run flutter run -d chrome --release
Range error is not thrown. Instead, the console spits out a null.

Flutter doctor
[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3 21E230 darwin-arm, locale en-IN)
    • Flutter version 2.10.4 at /Users/dev/Tools/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (13 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc3)
    • Android SDK at /Users/dev/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0-rc3
    • Java binary at: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_275-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[☠] IntelliJ IDEA Ultimate Edition (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues.
    ✗ FormatException: Unexpected extension byte (at offset 5)
    • #0      _Utf8Decoder.convertSingle (dart:convert-patch/convert_patch.dart:1789:7)
      #1      Utf8Decoder.convert (dart:convert/utf.dart:351:42)
      #2      InputStream.readString (package:archive/src/util/input_stream.dart:207:30)
      #3      new ZipDirectory.read (package:archive/src/zip/zip_directory.dart:40:30)
      #4      ZipDecoder.decodeBuffer (package:archive/src/zip_decoder.dart:19:30)
      #5      ZipDecoder.decodeBytes (package:archive/src/zip_decoder.dart:14:12)
      #6      IntelliJPlugins._findPluginXml (package:flutter_tools/src/intellij/intellij.dart:130:44)
      #7      IntelliJPlugins._readPackageVersion (package:flutter_tools/src/intellij/intellij.dart:141:40)
      #8      IntelliJPlugins.validatePackage (package:flutter_tools/src/intellij/intellij.dart:63:35)
      #9      IntelliJValidator.validate (package:flutter_tools/src/intellij/intellij_validator.dart:103:15)
      #10     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
      #11     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:109:18)
      #12     _rootRun (dart:async/zone.dart:1426:13)
      #13     _CustomZone.run (dart:async/zone.dart:1328:19)
      #14     _runZoned (dart:async/zone.dart:1861:10)
      #15     runZonedGuarded (dart:async/zone.dart:1849:12)
      #16     runZoned (dart:async/zone.dart:1780:12)
      #17     asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
      #18     Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:205:9)
      #19     Doctor.diagnose (package:flutter_tools/src/doctor.dart:309:47)
      #20     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:50:48)
      #21     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1320:12)
      <asynchronous suspension>
      #22     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1161:27)
      <asynchronous suspension>
      #23     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #24     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
      <asynchronous suspension>
      #25     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
      <asynchronous suspension>
      #26     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #27     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
      <asynchronous suspension>
      #28     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
      <asynchronous suspension>
      #29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #30     main (package:flutter_tools/executable.dart:94:3)
      <asynchronous suspension>

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Users/dev/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/213.6777.52/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.56.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.22.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.3 21E230 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 100.0.4896.75
    ! Error: iPad is not connected. Xcode will continue when iPad is connected. (code -13)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

If possible, could you try the latest dev build? Just to see if we've fixed it!
This could happen if you have turned on too many compilation optimizations...

This is still happening on the current tip of tree.  The Flutter tools enable the dart2js -O4 optimization level in release builds, which is potentially unsafe for cases like this.
I noticed that flutter_tools at one point had a way to set the optimization level but it looks like that is not currently exposed.

I'm going to close this as fixed by https://github.com/flutter/flutter/pull/101945.


platform ci: Add tests with java, cpp, web, and other downstream consumers

These non-go libraries are implemented in other repositories to make it easier to build and separate work streams. However, this means they often discover regressions before we see them here.

We support cross-testing of TDF files where they are created with SDK A and tested with head and most recent release of all other clients (C++/python, javascript/web, and java) v. go
We support service operations where possible

this work is being tracked by an issue int he tests repo: https://github.com/opentdf/tests/issues/151
Closing this issue as duplicate.


fix: Error log on a widget property not clearing out when the widget property is deleted

Description
fix: Error log on a widget property not clearing out when the widget property is deleted
Fixes #12894
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=212b8dd

/ok-to-test sha=c9133a0

/ok-to-test sha=54b6323

LGTM cc: @Druthi

/ok-to-test sha=a056993

/ok-to-test sha=c43ac36

/ok-to-test sha=f2830b6


ISPN-13586 Upgrade JGroups to 4.2.18.Final

https://issues.redhat.com/browse/ISPN-13586

Merged, thanks


Choose development environment

Since Node.js is used, the first choice is to to work on Linux environment and in particular through WSL when on Windows system. For the installation I follow the guide supplied by Microsoft.
In case I work on Windows, I install Node.js from the provided binaries. Further installation are specified at https://github.com/nodejs/node-gyp#on-windows.

Completed with commit 8ccab4e80a58a875d19e08143638b6e744fe019c.


Updating text after selecting item fails to show in text input after keyboard is closed

After selecting an item, if I update the text field, the text will seem to be correctly updated in the text input. But after dismissing the keyboard, the text input will reset to the previously selected item, even though my onChangeText and onSelectItem functions capture the updated state. Purely updating the text input or selecting the item works fine.
Initially opening list:

Selecting item "AA":

Updating text input (text input field seems to have correctly updated text):

After dismissing keyboard (text input field resets to last selected item "AA", even though my state has correctly captured the updated text of "AAbbb"):

Thank you.

I had a similar problem, which I solved by doing this:
const dropdownController = useRef(null)

<AutocompleteDropdown
  [...]
  controller={(controller) => {
    dropdownController.current = controller
  }}
  onBlur={() => {dropdownController.current.setItem({ id: 'selectedIdHere', title: 'selectedTitleHere' })}}
  />

Thanks @Joelis57 , although that didn't fully work for me as my use case was to set the text in the input to an item that does not yet exist in the dataset. However taking note from your code I modified my code to the below which seems to have worked for my use case:
<AutocompleteDropdown
  [...]
  controller={(controller) => {
    dropdownController.current = controller
  }}
  onBlur={() => {dropdownController.current.setInputText(activity)}}
  textInputProps={{
    onSubmitEditing: () => {dropdownController.current.toggle()}
  }}
  />

Appreciate the help!


//flutter/example_service needs license

@Hixie I was going to add https://gist.github.com/chinmaygarde/5beb295df469acf0967e. But that has a section about retaining copyright notices and stuff.
http://choosealicense.com/ maybe?

Please start from a pre-blessed template: https://github.com/flutter/oss_project_template


Suggestion in case login fails with 404

Hi and thanks for this super useful tool - I used to export all my bookmarks via the bookmarks panel and then parse the XML with R to keep a tabulated backup.
This would simplify the process massively and the csv output is amazing - so thank you 🙇
I am not sure if this would be helpful - but I found out that you need to be logged in to your Firefox account in the browser in order for the login to work. I kept getting this error until i realised that I am not logged in:
API request failed, cause: Request failed, cause: ffsync.http_404: call to https://sync-1-us-west1-g.sync.services.mozilla.com/1.5/207392506/storage/crypto/keys returned statuscode 404

I just wanted to mention this - perhaps useful for some other people. Happy to add a comment to the README if you think this is useful (but maybe it's a rookie mistake, not sure so thought to ask)
In any case, thanks again.

Hmm this is weird, I definitely did not need to be logged in in my browser.
Sometimes mozilla will send you a confirmation mail, which you need to accept before the login works - but that's all.
Perhaps this is a similar case, and once you log in via your browser the sync service server recognizes your ip and no longer needs an additional (mail) confirmation...
I'm currently a bit busy, but I will look into it when I have more time.
PS: if you want you can send me a PR with an updated README (perhaps add a FAQ section), I'm currently not at a computer, but can accept it from my phone :D


chore: publish node 22.7.0 to use for cypress system binary test

builds node 22.7.0 base image for use in the cypress repo as a system test needed to make sure experimental node flags added to the version are removed. These images are published manually but creating this pull request as an artifact that can be referenced for posterity if needed. See https://github.com/cypress-io/cypress/issues/30084 for more details

closing as images are published manually

@AtofStryker
cypress/included:13.13.3 is now cypress-13.13.3-node-22.7.0-chrome-127.0.6533.119-1-ff-129.0.1-edge-127.0.2651.98-1
That will surprise anybody using the short-form of the tag, expecting to get Cypress cypress-13.13.3-node-20.16.0-chrome-127.0.6533.119-1-ff-129.0.1-edge-127.0.2651.98-1 with the LTS Node.js version and not the "bleeding edge" Node.js version!

@AtofStryker
cypress/included:13.13.3 is now cypress-13.13.3-node-22.7.0-chrome-127.0.6533.119-1-ff-129.0.1-edge-127.0.2651.98-1
That will surprise anybody using the short-form of the tag, expecting to get Cypress cypress-13.13.3-node-20.16.0-chrome-127.0.6533.119-1-ff-129.0.1-edge-127.0.2651.98-1 with the LTS Node.js version and not the "bleeding edge" Node.js version!

looks like I missed commenting out the short tag. Ill rerun the publish with the factory default

@AtofStryker

looks like I missed commenting out the short tag. Ill rerun the publish with the factory default

I don't think that will work because the publish process only checks for the long tag and if that is present then it won't republish.
I'd suggest bumping FACTORY_DEFAULT_NODE_VERSION to 20.17.0 which would publish a new set of images.

@AtofStryker

looks like I missed commenting out the short tag. Ill rerun the publish with the factory default

I don't think that will work because the publish process only checks for the long tag and if that is present then it won't republish.
I'd suggest bumping FACTORY_DEFAULT_NODE_VERSION to 20.17.0 which would publish a new set of images.
(Unless that is you are able to manipulate tags manually. I don't have that experience, so I can't advise.)

honestly just seems easiest to bump the factory node version. PR open https://github.com/cypress-io/cypress-docker-images/pull/1201. Sorry about this I thought I got all the tags on this publish. One day I'll get it 😬 .

@AtofStryker

honestly just seems easiest to bump the factory node version. PR open https://github.com/cypress-io/cypress-docker-images/pull/1201. Sorry about this I thought I got all the tags on this publish. One day I'll get it 😬 .

No problem! The bad tag was not up for very long and I only noticed because I was running cypress/included:13.13.3 and I typed in the short-tag manually. When I got a run-time punycode deprecation warning, I realized that something was amiss!
I checked that it is fixed now. 👍🏻

@AtofStryker
Since the documentation didn't properly cover the case of publishing the latest Node.js I submitted changes to make it more general. That should hopefully help anybody else who needs to tackle anything similar in future.


Unify BDI QA data with regular QA data (new)

Replaces WorkOrder with CustomOrder 2.
Supercedes  #4587

@davidmreed : David Glick says that the failing tests here are Chrome 77 and should not block merging.

@skristem @deepmalamehta
Can one of you check this branch out and validate whether I've broken your tests?

my current bdi tests still work fine. Thanks for checking

Approving based on confirmation that BDI tests are good to go.


Incompatible with 4.0.0

When trying to migrate this plugin in redmine 4.0.0, I'm getting the following stack trace:
Migrating plugins. Please be patient, this could take a while...
/home/redmine/redmine/vendor/bundle/ruby/2.3.0/gems/activemodel-5.2.2/lib/active_model/validations/clusivity.rb:8: warning: already initialized constant ActiveModel::Validations::Clusivity::ERROR_MESSAGE
/home/redmine/data/tmp/bundle/ruby/2.3.0/gems/activemodel-5.2.2/lib/active_model/validations/clusivity.rb:8: warning: previous definition of ERROR_MESSAGE was here
rake aborted!
NoMethodError: undefined method `to_prepare' for ActionDispatch::Callbacks:Class
/home/redmine/redmine/plugins/redmine_remote_revision_url/init.rb:4:in `<top (required)>'
/home/redmine/redmine/vendor/bundle/ruby/2.3.0/gems/activesupport-5.2.2/lib/active_support/dependencies.rb:291:in `require'

ps. thanks for this plugin btw, very useful

I no longer use Redmine and cannot effectively update and maintain this repo.  Let me know if interested in taking it over?


Determine parameters for PAD

In the implementation of PAD (issue #4 ) the config can be set up to accept a limited number of hyperparameters for SVC. This issue would consider whether more hyperparameters are required, and the range of values to search when calculating the metric.

I think this issue would benefit from some experimentation with the full dataset a selection of transforms and a range of kernels and other hyperparameters.


Angular with CLI attach instead of launch

Is there a way to get the recipe to work via attach instead of launch?

Yeah! I've done this before, but you still need to launch a new Chrome.

well launching a new chrome instance with attach is sort of defeating the purpose right? i guess i'll just settle for launching or browser debugging until it's sorted out.

We can't put Chrome into debug mode when it's already running. This is a limitation of Chrome.

After 3 hours I wrote this comment, I'm finally sending it:

The reason for that is that Chrome starts without --remote-debugging-port enabled, so no one can listen to it. To just attach vscode's debugger to Chrome, it would have to be started everytime with --remote-debugging-port enabled, otherwise there's nothing for vscode's debugger to connect to.


installation: fix API app entrypoint

Signed-off-by: Jiri Kuncar<EMAIL_ADDRESS>--
needed for zenodo/zenodo#544

Coverage remained the same at 60.03% when pulling d1792899d15abd3a4434a555a199f48a2937403e on jirikuncar:installation into 1b9ef5b9d8cce685d4e0399a56830b45a7d5e70b on inveniosoftware:master.


Images via API

Dear community. Is it possible to add an image to a site or device via API?
Thank you

There's /api/extras/image-attachments/ but I'm not sure if it's possible, maybe ask over on the NetBox mailing list. Either way, pynetbox doesn't support it currently. Would be open to a PR that implemented it assuming it's possible from the api.


S2U-37 <IP_ADDRESS> Announcements: Ability to highlight announcements - Master

It looks like that:
When creating an announcement:

In announcement page:

In the homepage:

In content page (lessons) > when embedding the announcements:

This looks solid to me, great job @JuanDavid102 !


Sign in with Apple doesn't throw .MissingOrInvalidNonce

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.4 (11E146)
Firebase SDK version: 6.24.0
Firebase Component: Auth
Component version: 6.24.0
Installation method: Carthage

[REQUIRED] Step 2: Describe the problem
I implemented sign in with Apple according to "Authenticate Using Apple on iOS" firebase tutorial. I decide to test wrong nonce but account was successfully created.
I tried several times, tried deleting account in Firebase Auth console, removing Apple Sign In in iPhone settings, reinstalling app and checked that I am not already logged in and test clear run from scratch.
Steps to reproduce:

Implement "Authenticate Using Apple on iOS" according tutorial
Change 'nonce' to any wrong String when creating:
OAuthProvider.credential(withProviderID: "apple.com", IDToken: idTokenString, rawNonce: nonce)

Relevant Code:
let credential = OAuthProvider.credential(withProviderID: "apple.com", idToken: idTokenString, rawNonce: "AnyStringThatNotTheRightNonce")

Auth.auth().signIn(with: credential) { (authResult, error) in
    if let error = error {
        // Error. If error.code == .MissingOrInvalidNonce, make sure
        // you're sending the SHA256-hashed nonce as a hex string with
        // your request to Apple.
        print(error.localizedDescription) // NEVER GET HERE DESPITE WRONG NONCE
        return
    }
    // User is signed in to Firebase with Apple.
    // ...
}

Thanks @savelii, this looks like a bug.

For internal tracking: b/156932868

Is there an actual nonce in the Apple ID token? Please inspect your Apple ID token claims (you can use jwt.io). If there is no nonce in the ID token, then we ignore the check.

This part specifically:
let request = appleIDProvider.createRequest()
request.requestedScopes = [.fullName, .email]
// Nonce needs to be set.
request.nonce = sha256(nonce)

We tried to reproduce it and it failed when we passed an incorrect rawNonce:
"ERROR_MISSING_OR_INVALID_NONCE" received.
I speculate, you are not setting it correctly in the Apple ID token to begin with.

I was thinking check always take place, independly nil or not nonce in jwt.
Yes I inspecting token and nonce is missing, error was with custom sha256 function that return nil, my fault.
Thanks for help, I close issue.


Exoscale Root Size numbers are all in twice

Version - master 3/24
Steps to Reproduce:

Add Host
Select Exoscale
Fill out account access & security group
Click on the Root Size drop-down

Results: all the numbers are in there twice

Expected: Numbers should only be there once.

Version - master 4/1
Verified fixed


Is there a way to convert query to a promise (browser client)?

I'm using angular js and would want to broadcast an event once I have a updated 2 different databases(browser client end).
ie.
db1.insert(doc1) and db2.insert(doc2) and use $q.all() to figure out if both the db operations are completed. Is there a way to do it ?

Hello, this is not possible at the moment no and not planned. I suggest you use the async module to achieve that result: https://github.com/caolan/async

Current usecase is not very complicated. So I'm not sure if I have to use async on client end. Angular already provides sufficient support for promises. Let me check tho. Thank you for the quick reply.


TimeoutException

I get  TimeoutExceptions on my servers.
redis version : 2.8.2103
mconnectionTimeoutInMilliseconds = "5000"
operationTimeoutInMilliseconds = "1000"
retryTimeoutInMilliseconds="3000"
here's the exception
[TimeoutException: Timeout performing EVAL, inst: 14, mgr: ProcessReadQueue, err: never, queue: 10, qu: 0, qs: 10, qc: 0, wr: 0, wq: 0, in: 65536, ar: 1, IOCP: (Busy=0,Free=1000,Min=32,Max=1000), WORKER: (Busy=14,Free=8177,Min=32,Max=8191), clientName: xxx]
StackExchange.Redis.ConnectionMultiplexer.ExecuteSyncImpl[T](Message message, ResultProcessor`1 processor, ServerEndPoint server):949
StackExchange.Redis.RedisBase.ExecuteSync[T](Message message, ResultProcessor`1 processor, ServerEndPoint server):25
StackExchange.Redis.RedisDatabase.ScriptEvaluate(String script, RedisKey[] keys, RedisValue[] values, CommandFlags flags):17
Microsoft.Web.Redis.StackExchangeClientConnection+<>c__DisplayClass4.b__3():0
Microsoft.Web.Redis.StackExchangeClientConnection.RetryForScriptNotFound(Func`1 redisOperation):37
Microsoft.Web.Redis.StackExchangeClientConnection.RetryLogic(Func`1 redisOperation):52
Microsoft.Web.Redis.StackExchangeClientConnection.Eval(String script, String[] keyArgs, Object[] valueArgs):233
Microsoft.Web.Redis.RedisConnectionWrapper.TryTakeWriteLockAndGetData(DateTime lockTime, Int32 lockTimeout, Object& lockId, ISessionStateItemCollection& data, Int32& sessionTimeout):101
Microsoft.Web.Redis.RedisSessionStateProvider.GetItemFromSessionStore(Boolean isWriteLockRequired, HttpContext context, String id, Boolean& locked, TimeSpan& lockAge, Object& lockId, SessionStateActions& actions):434
Microsoft.Web.Redis.RedisSessionStateProvider.GetItemExclusive(HttpContext context, String id, Boolean& locked, TimeSpan& lockAge, Object& lockId, SessionStateActions& actions):36
System.Web.SessionState.SessionStateModule.GetSessionStateItem():60
System.Web.SessionState.SessionStateModule.PollLockedSessionCallback(Object state):78

Hi @mehdymohajery
when you get the timeout what happens if you connect using redis-cli? Does it fail as well?
Can you provide the server log at the time of the timeout?
Thank you.

the issue happens randomly so I can't test it with redis-cli when it happens.
the sample exception happened on 11:07 , no errors in redis log (loglevel=notice)
[2924] 16 Sep 11:03:51.868 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:03:51.884 * Background saving started by pid 7660
[2924] 16 Sep 11:03:57.344 # fork operation complete
[2924] 16 Sep 11:03:57.640 * Background saving terminated with success
[2924] 16 Sep 11:05:10.102 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:05:10.118 * Background saving started by pid 9712
[2924] 16 Sep 11:05:15.359 # fork operation complete
[2924] 16 Sep 11:05:15.687 * Background saving terminated with success
[2924] 16 Sep 11:06:18.477 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:06:18.493 * Background saving started by pid 4980
[2924] 16 Sep 11:06:23.734 # fork operation complete
[2924] 16 Sep 11:06:24.031 * Background saving terminated with success
[2924] 16 Sep 11:07:25.042 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:07:25.074 * Background saving started by pid 8884
[2924] 16 Sep 11:07:30.612 # fork operation complete
[2924] 16 Sep 11:07:30.955 * Background saving terminated with success
[2924] 16 Sep 11:08:31.062 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:08:31.077 * Background saving started by pid 7188
[2924] 16 Sep 11:08:36.241 # fork operation complete
[2924] 16 Sep 11:08:36.647 * Background saving terminated with success
[2924] 16 Sep 11:09:37.034 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:09:37.050 * Background saving started by pid 8512
[2924] 16 Sep 11:09:42.510 # fork operation complete
[2924] 16 Sep 11:09:42.806 * Background saving terminated with success
[2924] 16 Sep 11:10:43.100 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:10:43.116 * Background saving started by pid 7656
[2924] 16 Sep 11:10:48.358 # fork operation complete
[2924] 16 Sep 11:10:48.763 * Background saving terminated with success
[2924] 16 Sep 11:11:49.089 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:11:49.104 * Background saving started by pid 8408
[2924] 16 Sep 11:11:54.268 # fork operation complete
[2924] 16 Sep 11:11:54.533 * Background saving terminated with success
[2924] 16 Sep 11:12:55.030 * 10000 changes in 60 seconds. Saving...
[2924] 16 Sep 11:12:55.045 * Background saving started by pid 8512
[2924] 16 Sep 11:13:00.287 # fork operation complete
[2924] 16 Sep 11:13:00.568 * Background saving terminated with success
[2924] 16 Sep 11:14:01.080 * 10000 changes in 60 seconds. Saving...

@mehdymohajery
so the server kept accepting connections, maybe it's just a client issue, it wouldn't be the first time that the problem is in the StackExchange client.

@mehdymohajery
closing the issues after two months of inactivity given the problem seems client related and not caused by the server.
Please feel free to reopen the issue if needed.


verbose --count as well as -c for consistency.

Not essential at all, but kind of irritating.

Fixed in #10. Thanks!


[SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in …

…alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion #416
student 151220121. designated task complete.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4031/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4032/
Test FAILed.

can you sign the CLA https://cla.alluxio.org/ ? @Oscilloputer0627

Close due to lack of activities after 30 days


apply prettier and eslint --fix

These are the fixes that are purely automatic. I'm going to branch from this and get started on the ones that need to be be done by hand.
(If something in here isn't really what you want, I suggest that we merge this for now (since I'm building on top of it), but make an issue to change the rule that's not right.)

I don’t see anything - in general I don’t have a strong preference for what the code looks like as long as it is uniform, hence my desire for prettier.

@ilan-gold : If this is good, give it a checkmark? Not sure if you had other reservations...

Can you run it one more time for the new code?  I am approving pre-emptively so that once it;s done, you can merge.

pulled latest changes, and npm start still works.


Builds won't run

I've looked through issues #1 and #2 in order to resolve my build issues.
Now that it does build, using Microsoft Visual Studio 2015 Community,launching the build's .exe file does nothing.
Even when done as an administrator.
So I'm wondering if there's a workaround, or if a build could please be posted for ease of use. I looked on your site, but the box link wasn't working.

I don't know why you want to build deprecated software.


Add Microsoft.Bot.Builder.Classic package for V3 Dialog support on V4 SDK

@tomlm: The build fails. Please don't merge until we figure out why.


NullPointerException returned

NullPointerException is returned if any of the configuration environment variables are not provided.
We should return an informative exception with what environment variables are missing.

Resolved in: https://github.com/cyberark/conjur-api-java/pull/43


Error in public client

Too many bugs in the frontend anyways. CBA to fix since this repo is focused on the server. Unless PR ofc.


Javascript error: TypeError in no skipurl defined

If you do not define a skipurl, the uploadform will throw a javascript error:
TypeError: url.indexOf is not a function. (In 'url.indexOf(skipUrl)', 'url.indexOf' is undefined)

Hello @JurekRaben
How i can reproduce this error?
Thanks.-

Hi,
I did not define routing or skipurls simply, and used the file upload form using ajax.

Hey @JurekRaben
I don't see the word "skipUrl" on the whole code.
Are you sure is the plugin the cause of the error?

Ah, no, not really. It’s an anonymous function, maybe it was caused by debugbar then. Will check that later.

Am 26.03.2018 um 15:27 schrieb Martin M<EMAIL_ADDRESS>Hey @JurekRaben https://github.com/JurekRaben
I don't see the word "skipUrl" on the whole code.
Are you sure is the plugin the cause of the error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/skydiver/october-plugin-forms/issues/95#issuecomment-376165120, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOoPyr0S2xXaot8c1CKy4dVASbxSSTIks5tiOyvgaJpZM4S3C8l.

Yes, it’s a problem of debugbar. Sorry then :)

Am 26.03.2018 um 15:27 schrieb Martin M<EMAIL_ADDRESS>Hey @JurekRaben https://github.com/JurekRaben
I don't see the word "skipUrl" on the whole code.
Are you sure is the plugin the cause of the error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/skydiver/october-plugin-forms/issues/95#issuecomment-376165120, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOoPyr0S2xXaot8c1CKy4dVASbxSSTIks5tiOyvgaJpZM4S3C8l.


can't open vim

error:
dyld: Library not loaded: /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/libruby.2.0.0.dylib
Referenced from: /usr/local/bin/vim
Reason: image not found

Can you provide a bit more detail? I cannot replicate this error.
You may want to try this.


Added bi-directional language functionality for quiz

Solving #89 for the most part. No option for "both", since its a bit more complicated to implement.

LGTM!
In the future i think the feature could be improved by using not very similar words, and maybe eliminating the chance of duplicates.

Thanks! The issue with the similar words has to do with how they are entered (in English) in the database. I checked it for "Expensive", and the options were "Cheap,Costly,High-priced". I will look into it, but I think we'd have to reload the data or manually edit.


[BugFix] fixed_hash_map'find() return opposite result

Fixes #issue
SmallFixedSizeHashMap' find() return opposite result.
I encounter this bug when select count(*) from xx group by month(date time) limit 0,1;
when the first chunk is all the same month, the aggregator will generate a map that
contains the month->aggData. when the second chunk comes, the map.size() > limit,
so there is no need generator new month->aggData, but they will get wrong _streaming_selection,
and wrong aggData(nullptr) and that raise be crash.

Should add some test cases

ok, I'll add test case in out test repo.

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5

https://github.com/Mergifyio backport branch-2.4

@Merigifyio backport branch-2.3


chore: drop python 3.6 support

This is my contribution for #292
As I've already seen that 3.6 jobs are failing for #316, I thought maybe that should be done first.

Thank you for the PR, @hakandilek.
The process of removing py36 support should be implemented in the TARGET BRANCH: dev/3.0.0
Therefore, i will close this PR, as it has the wrong target branch.
Feel free to open a new one for TARGET BRANCH: dev/3.0.0


Allow loop prop to take a number

Thoughts on allowing the loop prop to take a number as an option (instead of only boolean)?
For cases where you want the animation to loop some amount of times less than infinity.

This feature should be implemented in the native modules first. @mjsisley if you are still interested in having it you can request it there: https://github.com/airbnb/lottie-android and https://github.com/airbnb/lottie-ios


The getter for FirstVisibleLine treats wrapped line as multiple lines

Let's say, for example, Line 0 is very long, and gets wrapped two times.
I scroll down so that Line 5 is at the top of the control. If I then call FirstVisibleLine, it will claim the first visible line is Line 7. (due to Line 0 being wrapped twice)
The setter for FirstVisibleLine is not affected by wrapped lines (as far as I can tell), and works as expected.
It looks like this might be a upstream bug in Scintilla's function, but I don't know for sure.

The remarks for FirstVisibleLine indicate that it will return the "visible line, not a document line" -- which means the wrapped line index. To get the actual document line, you need to pass the value returned from FirstVisibleLine to DocLineFromVisible.

Oh, that explains it. That certainly works. Thank you.


Cannot Open URL

Is your feature request related to a problem? Please describe.
I cannot render a C4 Model diagram that works with Intellij plugin.
Here is the code
!pragma layout smetana
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Context.puml

LAYOUT_WITH_LEGEND()

Person(utilisateur, "Utilisateur")

Here is what I get :

Describe the solution you'd like
Here is what I get with IntelliJ PlantUML plugin :

Describe alternatives you've considered
I guess I could manage my C4 model outside of Obsidian…

I don't have experience with obsididan-plantuml, however generally speaking, if your instance of plantuml includes the Standard Library for PlantUML, C4 and other utilities are available without an internet fetch and can be included with:
!include <C4/C4_Container.puml>


Revert PR #947 - merge to 7.1.x

This reverts PRs #1559, #1522 and #947
PR #947 made the HTTP state machine unstable and lead to crashes in production like #1930 #1559 #1522 #1531 #1629
This reverts commit c1ac5f8bf87fd4bc3a8e06507219970d83965acd.

[approve ci autest]


Adding Contributors page

Description
I can add the option to navigate contributor page.
I will show the github profile of all the contributors worked for the project.
I will ensure to make the page UI similar to the theme and also responsive for all screens.
It will directly fetch the data from the repository.
Motivation
It will show,
Transparency: It shows transparency in the project's development and highlights the collaborative effort behind it.
Engagement: It helps build a community by encouraging more people to contribute and get involved.
Networking: It provides an opportunity for users to connect with contributors, potentially leading to more collaboration and support.
Screenshots
No response
Additional Context
No response
Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct.
[X] The changes don't break the code.
[X] I will attach screenshots and videos of the development work once it is done.

Priority
High

Hey,
I can do this task, can you assign this to me.
Thankyou!


look at point utility function

Need an affine matrix transform generator that takes two points, an origin and target point, and generates a transform matrix.

This should go in the raysect.math.transform library.

Experimented with this, but it doesn't seem to do anything useful that user can't already do through other means. Doesn't save on code verbosity.


ffdec: Add version 15.0.0

Closes #7682

[x] I have read the Contributing Guide.

/verify

/verify


[Snackbar] - fix button position with long texts

[ ] PR has tests / docs demo, and is linted.
[ x Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Fix for #4676

@oliviertassinari Can you review this PR?

@mpontikes it has problems in ff, need to replace with flex maybe

I only had a quick view at time PR.
Do we really want to display ...  when the text is too long?
From the specification, I think that we should increase the height of the Snackbar.
Hence, looks like the root issue is the same as https://github.com/callemall/material-ui/pull/4294.
Regarding a proper fix, I think that we should stop forcing the height of the element, take advantage of the browser layout CSS engine and use a height: 100% transform for the open / close stuff.

@oliviertassinari big 👍 For this,
I didn't wanted about multiple lines in this PR because there is another issue about multi line snack bar, so I just add '...' At the end


Draft:Feature/various adjustement

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 5 committers have signed the CLA.:white_check_mark: capf4bbo:white_check_mark: lpinon:white_check_mark: Jorge-Dacal:white_check_mark: ultymatom:x: github-actions[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Fix #690, enter and leave field with tab

Should fix the issue that you cannot enter and leave a selection field with "tab". Tested with the demo page as well as in a custom project.

Thank you for taking on this issue @jasoeight !

@shentao please merge


Expand Zone access

With the addition of shared zones, some users are getting confused about what they should expect to see in the Zones section of VinylDNS. They also aren't sure how to know if a shared zone they want to work with exists in VinylDNS. Currently the "zones" API endpoint and Zones page in the portal only return zones a user is in the owner group for or has an ACL rule for. We return all zones to super and support users. We should make clear to users what zones they own but also allow them to see what zones exist in VinylDNS. This PR does not change their ability to access the specific zones though.
Changes in this pull request:
API:

add listAll boolean parameter to the listZones API endpoint. Default is false.
update canSeeZone method in AccessValidations.scala to include shared zones
add accessLevel to ZoneInfo and ZoneSummaryInfo, used canSeeZone and canChangeZone methods to determine a user's access level.
users can see all zones in the listZones response but can only access shared zones, and private zones they own or have access to through ACL rules.

Portal:

in the portal add tabs in the Zones page, one for "My Zones" (existing "zones" API call) and one for "All Zones" ("zones" API call with "listAll" set to true)
change the ""No zones found." message in the portal to "No zones found. You do not own any zones in VinylDNS. You can manage records in shared zones through Batch Changes."
Use "accessLevel" to determine what zones in the All Zones tab have a "View" button. Must have accessLevel Delete or Read.
Use "accessLevel" to determine which zones show the "Manage Zone" tab. Only accessLevel Delete.
Use "accessLevel" to determine if "Sync Zone" button shows
Use "accessLevel" and zone shared status to determine if "Create Recordset" button shows.

note: This does not change logic around super and support users, although i propose we do stop returning all zones by default for those users so they can distinguish what they manage personally vs what they manage in a system administrator capacity.

with what I've got currently there would be issues with checking zone access in the "all zones" tab in the portal if the user has access to more than 100 zones. It's only checking the zones in "All Zones" against the ID's of the first page of results in "My Zones". have to chew on this.

Is the plan to make Groups read only as well, so users can link to the admin group for the zone to contact them?

yes, there's a separate issue for that https://github.com/vinyldns/vinyldns/issues/642.

We should probably show the Connect Zone button on All Zones as it contains both mine and everything else.

I don't think we want to hide everything in Manage Zone.  Perhaps we should rename the tabs and just make that one read only.
There is some useful information in there (admin group, status, id, last sync time, created).  Perhaps show that info as read only and hide the connection info and acl rules.

pulled this back a bit. Originally added shared zones to the the canSeeZone method, removed that at this time. So users will still see the shared zones in the listZones response, but as it is currently they still will not have access to shared zones directly via the getZone or getZoneByName API calls. We'll discuss in the future what users should and shouldn't have access to in a zone before opening that up more.

I'd prefer to leave the changing the way we handle ACL rules for a separate issue/PR @mitruly since that's existing behavior. I'll take a look at your other comments.

🍻


Inconsistent library versions notice.

Hi. I have implemented a tool to detect library version inconsistencies. Your project have 2 inconsistent libraries.
Take org.apache.hadoop:hadoop-common for example, this library is declared as version <IP_ADDRESS>.6.1.0-129 in underfs/wasb, 2.7.3 in integration/yarn and etc... Such version inconsistencies may cause unnecessary maintenance effort in the long run. For example, if two modules become inter-dependent, library version conflict may happen. It has already become a common issue and hinders development progress. Thus a version harmonization is necessary.
Provided we applied a version harmonization, I calculated the cost it may have to harmonize to all upper versions including an up-to-date one. The cost refers to POM config changes and API invocation changes. Take org.apache.hadoop:hadoop-common for example, if we harmonize all the library versions into 3.1.3. The concern is, how much should the project code adapt to the newer library version. We list an effort table to quantify the harmonization cost.
The effort table is listed below. It shows the overall harmonization effort by modules. The columns represents the number of library APIs and API calls(NA,NAC), deleted APIs and API calls(NDA,NDAC) as well as modified API and API calls(NMA,NMAC). Modified APIs refers to those APIs whose call graph is not the same as previous version. Take the first row for example, if upgrading the library into version 3.1.3. Given that 24 APIs is used in module integration/yarn, 0 of them is deleted in a recommended version(which will throw a NoMethodFoundError unless re-compiling the project),  15 of them is regarded as modified which could break the former API contract.

Index
Module
NA(NAC)
NDA(NDAC)
NMA(NMAC)

1
integration/yarn
24(34)
0(0)
15(25)

2
underfs/wasb
0(0)
0(0)
0(0)

The file table listed below shows the potential files that may be affected due to library API change, which could help to spot the concerned API usage and rerun the test cases.

Module
File
Type
API

integration/yarn
integration/yarn/src/main/java/alluxio/yarn/Client.java
modify
org.apache.hadoop.security.Credentials.writeTokenStorageToStream(java.io.DataOutputStream)

integration/yarn
integration/yarn/src/main/java/alluxio/yarn/Client.java
modify
org.apache.hadoop.security.UserGroupInformation.getCurrentUser()

integration/yarn
integration/yarn/src/main/java/alluxio/yarn/Client.java
modify
org.apache.hadoop.security.Credentials.addToken(org.apache.hadoop.io.Text,org.apache.hadoop.security.token.Token)

4
..
..
..

If you are interested, you can have a more complete and detailed report in the attached PDF file.
Alluxio alluxio.pdf

thanks @kaifeng-h  ,
dependencies in underfs/wasb shall be shaded and class-loaded by different classloader to avoid class conflict.
And we are removing integration/yarn module now.
Thanks for the report! It is quite useful


Layout issue while adding linked products

Bug report
Title
Layout issue while adding linked products
Preconditions
1. framework Version. Master

Steps to reproduce
1. step1: add linked products in any product

Actual result
https://prnt.sc/u28pd0

fixed in master


Add default translation, rotation, scale to node targeted for animation

Cesium PR: https://github.com/AnalyticalGraphicsInc/cesium/pull/6351
Also fixed in the 2.0 branch: https://github.com/AnalyticalGraphicsInc/gltf-pipeline/commit/2050870964347e9c2ef7f470151da3b074ebdef8

Coverage increased (+0.04%) to 86.295% when pulling 6eb0f85591e0d2c647a4f268eb5628b955936324 on node-trs-default into 23f008295c541cbc977c5b856adcdc41880ad037 on 2.0-cesium.

@emackey Updated.

Looks great.  Please merge, thanks!


Make print-version-info a local test

Description
This test runs properly in docker container but not in travis, as the Git command used to retrieve the version (git describe) for the build is not working there.
Type of change

Configuration update

Testing steps
None
Checklist

[ ] Pylint passes for Python sources
[ ] sources has been pre-processed by Black
[ ] updated documentation wherever necessary
[ ] new tests can be executed both locally and within docker container
[ ] new tests have been included in scenario list (make update-scenarios)

Found a way to fix the issue in affected CIs


Missing WC mean

Example: PPN668289767/00000001.xml
👀 @kba It is a bug, I think. Will look into it.

@kba Unfortunately, it's a problem with the ALTO files - There are no word confidences in this example and I suspected this is the case for all of them :\

Probably not a bug here but I'll keep it open to review/re-check when the underlying issue is resolved.


fix https bug (release 2.2.x)

Change Description

Fixes issue #10695 where passing incorrect HTTPS configuration to nodeos will prevent HTTP server from functioning properly. Move variable initialization in http_plugin::plugin_initialize to the beginning of the function.
Change Type
Select ONE:

[ ] Documentation

[x] Stability bug fix

[ ] Other

[ ] Other - special case

Testing Changes
Select ANY that apply:

[x] New Tests

[ ] Existing Tests

[ ] Test Framework

[x] CI System

[ ] Other

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Mistakenly attmpted to merged into master which messed up the CI system, and chaging branch and rebuilding does not appear to help, so creating a new PR.


docs/building-operators/golang: fix context.Context usage, imports, general formatting

Description of the change:

docs/building-operators/golang: fix context.Context usage, imports, and general formatting

Motivation for the change: docs weren't using the correct context.Context value (see #4474), imports weren't formatted correctly, and different GVKs were used which is confusing.
/kind documentation
Signed-off-by: Eric Stroczynski<EMAIL_ADDRESS>Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

/retest


V2.4.x/dev issue#1883

PR
CheckList（PR Assigners）
确认已完成以下操作：

[ ] 已将分支与当前合入分支同步
[ ] 已在关联 Issue 中补充「功能自测」部分内容
[ ] 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested（需通过测试同学测试） -> done
[ ] 将 PR 添加上 pr/reviewable

CheckList（PR Reviewers）
确认已完成以下操作：

[ ] 检查关联 Issue 「功能自测」部分内容
[ ] 必要时打回 pr/reviewable，要求重新修改
[ ] 及时 Approve

Codecov Report

Merging #1889 (d48c725) into v2.4.3-dev (176f530) will decrease coverage by 0.15%.
The diff coverage is 77.77%.

@@              Coverage Diff               @@
##           v2.4.3-dev    #1889      +/-   ##
==============================================
- Coverage       74.42%   74.27%   -0.15%
==============================================
  Files             403      403
  Lines           27673    27683      +10
==============================================
- Hits            20595    20561      -34
- Misses           7078     7122      +44

Files
Coverage Δ

...s/backend/components/collections/agent_new/base.py
91.02% <ø> (ø)

...nents/collections/agent_new/upgrade_to_agent_id.py
95.23% <100.00%> (+0.50%)
:arrow_up:

apps/backend/components/collections/base.py
91.76% <100.00%> (+0.51%)
:arrow_up:

apps/backend/components/collections/plugin.py
82.25% <ø> (ø)

...mponents/collections/agent_new/get_agent_status.py
38.66% <42.85%> (-54.20%)
:arrow_down:

... and 2 files with indirect coverage changes


Update CONTRIBUTING.md

What ❔

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via zk spellcheck.
[ ] Linkcheck has been run via zk linkcheck.

thanks for the contribution - we con't accept stylistic/one-line changes, please see here.


Upgrade promptflow to 1.16.2

Package Name:  azure-ai-evaluation
Package Version: 1.1.0
Operating System: Win11
Python Version: 3.11

Describe the bug
azure-ai-evaluation has a dependency on prompflow which released 1.16.2  https://pypi.org/project/promptflow/ to address security vulnerabilities. Since we are using azure-ai-evaluation, we would like to make our project compliant.
To Reproduce
Steps to reproduce the behavior:
1.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hi @yuqizhou77 thanks for the feedback, we will get back to you asap.


Feat date display

Attempting to add details to the date displayed in smalltime.
Implemented with SimpleCalendar, tested with the default configuration for others calendar (except PF2),
From there, it's easy to implement the other calendars using the same data (yearPostfix, etc.)

Adding French translation

translate the "of month..." string

TBD: handle SimpleCalendar seasons

Sorry for the delay, I've been mostly out of commission for the past few days with vaccine side-effects. Gonna take a look through this and possibly make some tweaks, but at a first glance it seems solid. Thanks!


RuntimeError: Internal: Non-root tuple types are not handled.

I'm currently having an issue with jax (jaxlib 0.1.61), when using GPU with cuda 10.1 (I don't get this error when using only CPU).
I can't produce an MWA at the moment. I can't find any info on this error.. Can anyone give me some pointers on which type of behaviour might generate this error?
Traceback (most recent call last):
  File "/project/clebschnet/Examples/hparams.py", line 549, in <module>
    run_opt(args)
  File "/project/clebschnet/Examples/hparams.py", line 348, in run_opt
    ma = JaxClebschTreeTrax(hi, D, 1/2, depth,
  File "../clebschnet/machine.py", line 234, in JaxClebschTreeTrax
    return Trax(
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 628, in __init__
    self.jax_init_parameters(rescale=self.rescale)
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 657, in jax_init_parameters
    self.rescale_weights()
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 682, in rescale_weights
    self.eval_in_batches(tree_unflatten(flat_ptree, flat_params), self._state, states)
  File "/opt/conda/lib/python3.8/site-packages/jax/_src/profiler.py", line 115, in wrapper
    return func(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 839, in eval_in_batches
    ch_out, new_state = self._forward_fn_with_state(params, state, ch, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 528, in <lambda>
    self._forward_fn_with_state = jax.jit(lambda pars, state, x: self._forward_fn_t(pars, state, x))
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 517, in <lambda>
    self._forward_fn_t = lambda pars, state, x: net.pure_fn(x, pars, state, None) # returns (Tensor, state)
  File "/opt/conda/lib/python3.8/site-packages/trax/layers/base.py", line 548, in pure_fn
    raise LayerError(name, 'pure_fn',
jax._src.traceback_util.FilteredStackTrace: trax.layers.base.LayerError: Exception passing through layer Serial (in pure_fn):
  layer created in file [...]/../clebschnet/layers_trax_tree.py, line 193
  layer input shapes: ShapeDtype{shape:(64, 64), dtype:float64}

  File [...]/trax/layers/combinators.py, line 88, in forward
    outputs, s = layer.pure_fn(inputs, w, s, rng, use_cache=True)

LayerError: Exception passing through layer InputTransform (in pure_fn):
  layer created in file [...]/../clebschnet/layers_trax_tree.py, line 406
  layer input shapes: ShapeDtype{shape:(64, 64), dtype:float64}

  File [...]/../clebschnet/layers_trax_tree.py, line 433, in forward
    x = self.vsmallest_lexicographically(tempx, n_sites).reshape((-1,1) + self.og_lattice)

  File [...]/jax/_src/traceback_util.py, line 139, in reraise_with_filtered_traceback
    return fun(*args, **kwargs)

  File [...]/site-packages/jax/api.py, line 1222, in batched_fun
    out_flat = batching.batch(

  File [...]/site-packages/jax/linear_util.py, line 166, in call_wrapped
    ans = self.f(*args, **dict(self.params, **kwargs))

  File [...]/../clebschnet/layers_trax_tree.py, line 461, in smallest_lexicographically
    return x[jnp.lexsort(sorted_x)[0]]

  File [...]/_src/numpy/lax_numpy.py, line 3932, in lexsort
    return lax.sort((*keys[::-1], iota), dimension=axis, num_keys=len(keys))[-1]

  File [...]/_src/lax/lax.py, line 1414, in sort
    return tuple(sort_p.bind(*operand, dimension=dimension,

  File [...]/site-packages/jax/core.py, line 282, in bind
    out = top_trace.process_primitive(self, tracers, params)

  File [...]/jax/interpreters/batching.py, line 151, in process_primitive
    val_out, dim_out = batched_primitive(vals_in, dims_in, **params)

  File [...]/_src/lax/lax.py, line 5782, in _sort_batch_rule
    return (sort_p.bind(*new_args, dimension=new_dimension, is_stable=is_stable, num_keys=num_keys),

  File [...]/site-packages/jax/core.py, line 282, in bind
    out = top_trace.process_primitive(self, tracers, params)

  File [...]/site-packages/jax/core.py, line 628, in process_primitive
    return primitive.impl(*tracers, **params)

  File [...]/jax/interpreters/xla.py, line 238, in apply_primitive
    compiled_fun = xla_primitive_callable(prim, *unsafe_map(arg_spec, args), **params)

  File [...]/jax/_src/util.py, line 198, in wrapper
    return cached(bool(FLAGS.jax_enable_x64), *args, **kwargs)

  File [...]/jax/_src/util.py, line 191, in cached
    return f(*args, **kwargs)

  File [...]/jax/interpreters/xla.py, line 288, in xla_primitive_callable
    compiled = backend_compile(backend, built_c, options)

  File [...]/jax/interpreters/xla.py, line 352, in backend_compile
    return backend.compile(built_c, compile_options=options)

RuntimeError: Internal: Non-root tuple types are not handled.

The stack trace above excludes JAX-internal frames.
The following is the original exception that occurred, unmodified.

--------------------

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/project/clebschnet/Examples/hparams.py", line 549, in <module>
    run_opt(args)
  File "/project/clebschnet/Examples/hparams.py", line 348, in run_opt
    ma = JaxClebschTreeTrax(hi, D, 1/2, depth,
  File "../clebschnet/machine.py", line 234, in JaxClebschTreeTrax
    return Trax(
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 628, in __init__
    self.jax_init_parameters(rescale=self.rescale)
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 657, in jax_init_parameters
    self.rescale_weights()
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 682, in rescale_weights
    self.eval_in_batches(tree_unflatten(flat_ptree, flat_params), self._state, states)
  File "/opt/conda/lib/python3.8/site-packages/jax/_src/profiler.py", line 115, in wrapper
    return func(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 839, in eval_in_batches
    ch_out, new_state = self._forward_fn_with_state(params, state, ch, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/jax/_src/traceback_util.py", line 139, in reraise_with_filtered_traceback
    return fun(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/jax/api.py", line 396, in f_jitted
    return cpp_jitted_f(*args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 528, in <lambda>
    self._forward_fn_with_state = jax.jit(lambda pars, state, x: self._forward_fn_t(pars, state, x))
  File "/opt/conda/lib/python3.8/site-packages/netket/machine/jax.py", line 517, in <lambda>
    self._forward_fn_t = lambda pars, state, x: net.pure_fn(x, pars, state, None) # returns (Tensor, state)
  File "/opt/conda/lib/python3.8/site-packages/trax/layers/base.py", line 548, in pure_fn
    raise LayerError(name, 'pure_fn',
trax.layers.base.LayerError: Exception passing through layer Serial (in pure_fn):
  layer created in file [...]/../clebschnet/layers_trax_tree.py, line 193
  layer input shapes: ShapeDtype{shape:(64, 64), dtype:float64}

  File [...]/trax/layers/combinators.py, line 88, in forward
    outputs, s = layer.pure_fn(inputs, w, s, rng, use_cache=True)

LayerError: Exception passing through layer InputTransform (in pure_fn):
  layer created in file [...]/../clebschnet/layers_trax_tree.py, line 406
  layer input shapes: ShapeDtype{shape:(64, 64), dtype:float64}

  File [...]/../clebschnet/layers_trax_tree.py, line 433, in forward
    x = self.vsmallest_lexicographically(tempx, n_sites).reshape((-1,1) + self.og_lattice)

  File [...]/jax/_src/traceback_util.py, line 139, in reraise_with_filtered_traceback
    return fun(*args, **kwargs)

  File [...]/site-packages/jax/api.py, line 1222, in batched_fun
    out_flat = batching.batch(

  File [...]/site-packages/jax/linear_util.py, line 166, in call_wrapped
    ans = self.f(*args, **dict(self.params, **kwargs))

  File [...]/../clebschnet/layers_trax_tree.py, line 461, in smallest_lexicographically
    return x[jnp.lexsort(sorted_x)[0]]

  File [...]/_src/numpy/lax_numpy.py, line 3932, in lexsort
    return lax.sort((*keys[::-1], iota), dimension=axis, num_keys=len(keys))[-1]

  File [...]/_src/lax/lax.py, line 1414, in sort
    return tuple(sort_p.bind(*operand, dimension=dimension,

  File [...]/site-packages/jax/core.py, line 282, in bind
    out = top_trace.process_primitive(self, tracers, params)

  File [...]/jax/interpreters/batching.py, line 151, in process_primitive
    val_out, dim_out = batched_primitive(vals_in, dims_in, **params)

  File [...]/_src/lax/lax.py, line 5782, in _sort_batch_rule
    return (sort_p.bind(*new_args, dimension=new_dimension, is_stable=is_stable, num_keys=num_keys),

  File [...]/site-packages/jax/core.py, line 282, in bind
    out = top_trace.process_primitive(self, tracers, params)

  File [...]/site-packages/jax/core.py, line 628, in process_primitive
    return primitive.impl(*tracers, **params)

  File [...]/jax/interpreters/xla.py, line 238, in apply_primitive
    compiled_fun = xla_primitive_callable(prim, *unsafe_map(arg_spec, args), **params)

  File [...]/jax/_src/util.py, line 198, in wrapper
    return cached(bool(FLAGS.jax_enable_x64), *args, **kwargs)

  File [...]/jax/_src/util.py, line 191, in cached
    return f(*args, **kwargs)

  File [...]/jax/interpreters/xla.py, line 288, in xla_primitive_callable
    compiled = backend_compile(backend, built_c, options)

  File [...]/jax/interpreters/xla.py, line 352, in backend_compile
    return backend.compile(built_c, compile_options=options)

RuntimeError: Internal: Non-root tuple types are not handled.

This error originates inside XLA, but I'm actually unsure how to produce it. Can you share either a reproduction or an HLO dump?
You can get an HLO dump by running JAX with the environment variable XLA_FLAGS=--xla_dump_to=/tmp/somewhere and zipping up the files you get out. (Note this does essentially share your model's code on Github, if that matters.)

Any updates? Is there a way for me to reproduce this?

Closing. I suspect the bug has already been fixed in newer jaxlibs, and without a way to reproduce it there's nothing we can do. Please reopen if there's a way for us to reproduce the issue at head!


refactor/mv3 contentScript HMR is not work

Describe the bug
code

page

if refresh the ext

page is ok.

Reproduction
vitesse-webext/src/contentScripts/index.ts
System Info
System:
    OS: macOS 11.7.1
    CPU: (8) arm64 Apple M1
    Memory: 96.77 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 8.3.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Edge: 103.0.1264.71
    Firefox: 106.0
    Safari: 14.1.2

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

SAME, and my solution was to install the Extensions Reloader. After making changes to the extension files, I would on click the Extensions Reloader  button and refresh the page to ensure the changes would be applied.

@xlzy520 Has the problem been resolved now? I also encountered the same problem.

refactor/mv3 is deprecated, please use main branch

@tmkx But plasmo did it.

@tmkx as far as I can tell, HMR ins't working for content script on the main branch :-/

It is still not work for now.


Consumer option 'autoCommitMsgCount' not documented?

I've been trying to find out what this option does but i've failed to find any documentation.
Could anyone give more information on this? Thanks!

It's actually missing in document, but you can set autoCommitMsgCount in options

Looks like it's just defined in the default options? I don't see other references to that attribute anywhere else.

Any idea how or why it got there in the first place?

No idea @rtorrero. I haven't been in the code base that long. Maybe it was a feature that was planned but never implemented. We should remove it to prevent confusion. PR's welcome! :)


experimental[minor]: Adds experimental custom format prompt templates and handlebars

@davidfant this would be the more isolated way of adding custom formats - we've had a lot of issues with jinja2 on Python and want to keep dependencies light anyway.
Let me know what you think and if this fits your use-case - we'd need to add chat prompt template variants as well but could start with something like this.
Feel free to merge into your branch if it looks ok to you and we can merge that PR.
We will also want tests

Requires a new @langchain/core release and version bump.

Thank you for your patience @davidfant!


[New Port Request] DotNetSdk

Library name: .NET SDK
Source repository URL: https://github.com/dotnet/runtime
Anything else that is useful to know when adding (such as optional features the library may have that should be included):
Many ports (i.e. chakracore) are relying on .NET SDK so it will be reasonable to add it as a port.

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Fixes an issue with the printout of ->balance

Thought I'd fix the issue I reported earlier while I had this open
If you'd prefer to fix it in a different way, feel free to skip this

That's fine, I guess you can fix it like that lol
Anyway, adding on '\n' could be enough, but this also works, so its fine

I just wasn't sure what discord would do if you sent it a message that ended in \n.  If it added extra blank space below the message, that would be weird.

No, it shouldn't.
But I will make sure to test this


added basic auth support

Firstly, thank you for your pull request!
I have commented my thoughts on your code. Just need a bit adjustment.

I'd love to see this get merged, it would be useful!

Unfortunately I switched to goreq, but you're welcome to take these changes and make a PR of your own

@dickeyxxx thanks for the followup!  I'd never seen goreq, it looks interesting.
@parnurzeal Can we still get this improvement merged?

@jaytaylor  Yeah, sure. I will move forward with the remaining to fix :)
@dickeyxxx  Thanks for helping this, anyway.

This has been done in develop branch. It will be merged to master for a new release version in following week.


from_deluge is missing deluge_label key for Deluge 2.x

Expected behaviour:
After updating Deluge from 1.3.15 to 2.0.3, my task fails to run because the key deluge-label is no longer being populated by from_deluge.
Actual behaviour:
This key should still be available in Deluge 2.x
Steps to reproduce:

Step 1: Add a random torrent to Deluge 2.x, add label test to it.
Step 2: Run flexget --test execute --task sample_task --dump
Step 3: Notice that deluge_label does not exist. It used to exist for Deluge 1.3.15.

Config:
--- config from task: sample_task
accept_all: true
disable:
  - seen
  - seen_info_hash
from_deluge:
  filter:
    label: test
    state: Seeding
  host: deluge-host
  password: password
  port: 58846
  username: username
no_entries_ok: true

---

Log:

(click to expand)
2020-02-04 17:41:36 INFO     manager                       Test mode, creating a copy from database ...
2020-02-04 17:41:37 INFO     manager                       Test database created
2020-02-04 17:41:40 VERBOSE  task_queue                    There are 1 tasks to execute. Shutdown will commence when they have completed.
2020-02-04 17:42:04 INFO     deluge_client.client sample_task     Connecting to deluge-manual:58846
2020-02-04 17:42:04 VERBOSE  details       sample_task     Produced 1 entries.
2020-02-04 17:42:04 VERBOSE  task          sample_task     ACCEPTED: `debian-10.2.0-amd64-netinst.iso` by accept_all plugin
2020-02-04 17:42:04 VERBOSE  details       sample_task     Summary - Accepted: 1 (Rejected: 0 Undecided: 0 Failed: 0)
2020-02-04 17:42:04 WARNING  task          sample_task     Task doesn't have any output plugins, you should add (at least) one!
-- Accepted: ---------------------------
title            : debian-10.2.0-amd64-netinst.iso
url              :
original_url     :
accepted_by      : accept_all
content_files    : [debian-10.2.0-amd64-netinst.iso]
content_size     : 335.0
deluge_active_time: 62
deluge_all_time_download: 363873728
deluge_auto_managed: True
deluge_comment   : "Debian CD from cdimage.debian.org"
deluge_completed_time:<PHONE_NUMBER>
deluge_creator   :
deluge_distributed_copies: 0.0
deluge_download_location: /ssd
deluge_download_payload_rate: 2848
deluge_eta       : 0
deluge_file_priorities: (4,)
deluge_file_progress: (1.0,)
deluge_files     : ({'index': 0, 'path': 'debian-10.2.0-amd64-netinst.iso', 'size': 351272960, 'offset': 0},)
deluge_finished_time: 40
deluge_hash      : 86d4c80024a469be4c50bc5a102cf71780310074
deluge_id        : 86d4c80024a469be4c50bc5a102cf71780310074
deluge_is_auto_managed: True
deluge_is_finished: True
deluge_is_seed   : True
deluge_last_seen_complete:<PHONE_NUMBER>
deluge_max_connections: -1
deluge_max_download_speed: -1.0
deluge_max_upload_slots: -1
deluge_max_upload_speed: -1.0
deluge_message   : OK
deluge_move_completed: False
deluge_move_completed_path: /root/Downloads
deluge_move_on_completed: False
deluge_move_on_completed_path: /root/Downloads
deluge_name      : debian-10.2.0-amd64-netinst.iso
deluge_next_announce: 0
deluge_num_files : 1
deluge_num_peers : 0
deluge_num_pieces: 1340
deluge_num_seeds : 0
deluge_orig_files: ({'index': 0, 'path': 'debian-10.2.0-amd64-netinst.iso', 'size': 351272960, 'offset': 0},)
deluge_owner     : dangmai
deluge_paused    : False
deluge_peers     : ()
deluge_piece_length: 262144
deluge_pieces    : None
deluge_prioritize_first_last: False
deluge_prioritize_first_last_pieces: False
deluge_private   : False
deluge_progress  : 100.0
deluge_queue     : -1
deluge_ratio     : 0.0
deluge_remove_at_ratio: False
deluge_save_path : /ssd
deluge_seed_mode : False
deluge_seed_rank :<PHONE_NUMBER>
deluge_seeding_time: 40
deluge_seeds_peers_ratio: 56.66666793823242
deluge_sequential_download: False
deluge_shared    : False
deluge_state     : Seeding
deluge_stop_at_ratio: False
deluge_stop_ratio: 2.0
deluge_storage_mode: sparse
deluge_super_seeding: False
deluge_time_added:<PHONE_NUMBER>
deluge_time_since_download: 40
deluge_time_since_transfer: 40
deluge_time_since_upload: -1
deluge_total_done: 351272960
deluge_total_payload_download: 363873728
deluge_total_payload_upload: 0
deluge_total_peers: 15
deluge_total_remaining: 0
deluge_total_seeds: 850
deluge_total_size: 351272960
deluge_total_uploaded: 0
deluge_total_wanted: 351272960
deluge_tracker   : http://bttracker.debian.org:6969/announce
deluge_tracker_host: debian.org
deluge_tracker_status: Announce OK
deluge_trackers  : ({'url': 'http://bttracker.debian.org:6969/announce', 'trackerid': '', 'message': '', 'last_error': {'value': 0, 'category': 'system'}, 'next_announce': None, 'min_announce': None, 'scrape_incomplete': -1, 'scrape_complete': -1, 'scrape_downloaded': -1, 'tier': 0, 'fail_limit': 0, 'fails': 0, 'source': 1, 'verified': False, 'updating': False, 'start_sent': False, 'complete_sent': False, 'send_stats': True},)
deluge_upload_payload_rate: 0
media_id         : <LazyField - value will be determined when it is accessed>
original_title   : debian-10.2.0-amd64-netinst.iso
quality          : <LazyField - value will be determined when it is accessed>
task             : sample_task
torrent_info_hash: 86d4c80024a469be4c50bc5a102cf71780310074
torrent_peers    : 0
torrent_seeds    : 0

2020-02-04 17:42:06 INFO     manager                       Removed test database

Additional information:

FlexGet version: 3.1.6
Python version: 3.7
Installation method: Docker container
Using daemon (yes/no): no
OS and version: Ubuntu 18.04 for host, Alpine for Docker container
Link to crash log: N/A

We add all keys available from deluge, so it's likely gone now for good. If your from_deluge uses specific filter label you could just add it manually via set plugin though.
@gazpachoking final verdict as our deluge overlord?

The funny thing is that the label filter does work, and so does setting the label when using deluge output plugin - so Flexget does have a way to get that information from Deluge somehow.

There is certainly a way we can get that field still. I'm currently trying to determine whether it's a bug in deluge, or we need to change our call to get it.

This is a bug in deluge at the moment. I've opened up a ticket on their tracker. I think probably we should open a PR over there in order to actually get some traction though.

Still an issue

Made a PR, hopefully it actually works and makes it to the next deluge version https://github.com/deluge-torrent/deluge/pull/344

PR got merged. Next release of deluge won't have this problem anymore. 2.0.6 or 2.1.0, whatever comes out next.

Still patiently waiting for deluge2.0 for windows

There's been quite a bit of action on that front now. I'm expecting official Windows builds to come for all future 2.0 releases. There's also some unofficial ones available. https://forum.deluge-torrent.org/viewforum.php?f=12


New/edit alert form: select all + unselect all buttons

For a more user-friendly experience.
This was mentioned by Stijn (VMM).

This was implemented in the new alert form a couple months ago.


Bootstrap validation errors

Description
Use custom bootstrap errors.
Fixes #272
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have added tests to cover my changes.
[x] All new code is fully covered by tests (see coverage report)

Alternative fix in PR #296


feat: Istiod helm chart volume mount support

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
There is a use case to use cert-manager with istio to generate mTLS certificates. This requires us to add 2 mounts to the istiod deployment. Currently, tutorials online suggest using IstioOperator, which is now discouraged. We'd like have a parameter on the helm chart to pass the required volumes.
Usage:
spec:
  template:
    spec:
      containers:
      - name: discovery
        args:
        - --tlsCertFile=/etc/cert-manager/tls/tls.crt
        - --tlsKeyFile=/etc/cert-manager/tls/tls.key
        - --caCertFile=/etc/cert-manager/ca/root-cert.pem
        env:
        - name: ENABLE_CA_SERVER
          value: "false"
        volumeMounts:
        - mountPath: "/etc/cert-manager/tls"
          name: cert-manager
          readOnly: true
        - mountPath: "/etc/cert-manager/ca"
          name: ca-root-cert
          readOnly: true
      volumes:
      - name: cert-manager
        secret:
          secretName: istiod-tls
      - name: ca-root-cert
        configMap:
          defaultMode: 420
          name: istio-ca-root-cert

Describe alternatives you've considered
Currently I'm using kubectl patch to add the above configuration. This is sketchy and not recommended for production environments.
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context
https://github.com/istio/istio/tree/1.15.0/manifests/charts/istio-control/istio-discovery

This PR does the same thing a different way. https://github.com/istio/istio/pull/39375


Label error: can't render any mutiline texts

version: 20220322 latest
Python info and System info by DR crash report maker
Python info

Version: 3.8.10
Implementation: CPython
Compiler: MSC v.1928 64 bit (AMD64)

System info

System: Windows-10-10.0.19044-SP0
Computer name: shenjack-5600X
machine: AMD64
processor: AMD64 Family 25 Model 33 Stepping 0, AuthenticAMD
release: 10
version: 10.0.19044

Not sure what branch you are using, but this is fixed in the latest 1.5 branch.
Next time master is updated, it should be resolved.

Not sure what branch you are using, but this is fixed in the latest 1.5 branch.
Next time master is updated, it should be resolved. As a workaround for now you can use pyglet.options["win32_gdi_font"] = True
EDIT: As to why this is happening. The default font renderer for Windows has been changed to DirectWrite, which had an issue with glyphs that have 0 width and 0 height (line breaks, and other 0 space characters). The option lets you force the old font renderer.

got it， i am using the master branch


Ensure password lock/unlock works again

Description:
Ensure password is stored in the keychain as hex encoded sha256 digest,.
Motivation and Context:
Ref https://twitter.com/cryptonobo/status/1282019127876558848
It seems that as part of this commit https://github.com/LN-Zap/zap-desktop/commit/dc9c73611ba415dce0d4dde9b8f34f810a9c4f51 our sha256digest utility was updated to support multiple encoding mechanisms however as part of this the default encoding changed from a hex string to a buffer.
This was done in preparation for keysend support however in the process it broke the password encoding/decoding which expects passwords to be encoded as a hex string for storage in the keychain.
How Has This Been Tested?
Manually - enable password, change password, disable password. Also, install 0.6.2, enable the password, then upgrade to 0.7.0 and verify that the password still works.
Types of changes:
Bug fix
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 22.033% when pulling 78e808e51cba60d34fd47418ef74bd9665c46f9e on fix/password-hex-string into 5d2ad32857f059acdf439a436ce26dc9257702ec on master.


[Feature]: Create internal frameworks templates for the CLI

Describe the feature
After https://github.com/radix-vue/shadcn-vue/pull/528, the CLI should check in a Nuxt project If shadcn-nuxt injects the file or not and act accordingly. This requires modifying the following code.
https://github.com/radix-vue/shadcn-vue/blob/bd0a8206efa0c0f1fee735f17ab94c63b408e106/packages/cli/src/commands/init.ts#L301-L306
Similarly after https://github.com/radix-vue/shadcn-vue/pull/531.We need to check if we should install all deps or only a set of them here
https://github.com/radix-vue/shadcn-vue/blob/bd0a8206efa0c0f1fee735f17ab94c63b408e106/packages/cli/src/commands/init.ts#L313-L316
This checking can get messy too quick, and that's for Nuxt-specifics alone. Adding features specific to astro for example would require adding checks for that too.
I propose refactoring the runInit command to the following
cli/src/commands/init.ts
import { runNuxtInitTemplate, runNuxtInitTemplate, runNuxtInitTemplate} from './initTempaltes'

export async function runInit(cwd: string, config: Config) {
  const spinner = ora('Initializing project...')?.start()

  const context = await getProjectInfo() // `context` has `framework` option among other useful keys
  const { framework } = context

  // Shared Inline Code

  // Running the appropriate init template based on framework
  let success, error;
  if (context.framework === 'nuxt')
    { success, error} = runNuxtInitTemplate(context)
  elseif (context.framework === 'vite')
    { success, error} = runVueInitTemplate(context)
  elseif (context.framework === 'astro')
    { success, error} = runAstroInitTemplate(context) // Just for example. For now I think `Nuxt` and `Vue` templates would be sufficent

  if (error) return consola.error('Error while initializing.', error)
  spinner?.succeed()
}

cli/src/commands/initTempaltes.ts
export function runNuxtInitTemplate(context: ProjectContext) {
  // Specific Nuxt Things
  sharedFunction()
  // Other Specific Nuxt Things
  return { success, error }
}

export function runViteInitTemplate(context: ProjectContext) {
  // Specific Vite Setup
  sharedFunction()
  // Other Specific Vite Things
  return { success, error }
}

export function runAstroInitTemplate(context: ProjectContext) {
  // Specific Astro Setup
  sharedFunction()
  // Other Specific Astro Things
  return { success, error }
}

function sharedFunction(){
  // Stuff
}

This way is more organized and easier to understand & maintain. Also if anyone want to contribute to specific framework he won't need to understand how the other frameworks work and avoids changing unrelated code which can cause mistakes.
I opened the issue for discussion. I'm up to raise a PR once a final structure is agreed 🙏
Additional information

[X] I intend to submit a PR for this feature.
[ ] I have already implemented and/or tested this feature.

CC @zernonia


Sgdemux

Opening a draft PR for increased readability of changes to nf-core-modules/modules/nf-core/sgdemux/ & nf-core-modules/tests/modules/nf-core/sgdemux

Here is the latest version of sgdemux, including the checks shown below. Most importantly test.yml has been updated to exclude md5sums for fastq's fue to sorting errors.
PR checklist

[x] This comment contains a description of changes (with reason).

[x] If you've added a new tool - have you followed the module conventions in the contribution docs

[x] If necessary, include test data in your PR.

[x] Remove all TODO statements.

[x] Emit the versions.yml file.

[x] Follow the naming conventions.

[x] Follow the parameters requirements.

[x] Follow the input/output options guidelines.

[x] Add a resource label

[x] Use BioConda and BioContainers if possible to fulfil software requirements.

Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:

[x] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
[x] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
[x] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware


[WIP] Add an extra function for people wanting to talk to a real person

Extends #1175

"In addition, parallel function calls is supported on the following models:
gpt-4-1106-preview
gpt-3.5-turbo-1106"


Update documentation with API changes

See #115 for the new API.

Fixed by #120. Was also a duplicate issue. (whoops!)


Set a default Greeting/Help message in bot - bot banner

Hey Team..can anyone suggest me how to setup a greeting/help message in a WebEx bot..I am using webexteamssdk 1.6 to send and retrieve messages from the chat. I could not find option to provide greeting. Any help would be greatly appreciated.
Thanks in advance

Closing this issue; it is a troubleshooting/assistance request that is almost three years old.


decode: prometheus: fix to avoid freeing non-malloced data

The fuzzer in https://github.com/fluent/fluent-bit/pull/7745 found a bug that shows the prometheus decoder is sometimes freeing data that is not malloced. This is an attempt to fix that.
Please do verify this -- the fuzzer no longer finds the issue here and the bug is obvious, however, for coming up with a fix I found the code a bit tricky to validate as I'm not deeply familiar with this decoder.

ping @DavidKorczynski on changes requested

I think the issue highlighted by this PR may need a more substantial fix. There is mixing of dynamically allocated memory and non-dynamically allocated memory, and in order to achieve consistency there is some rewriting needed (not just fixing). I think the owner/maintainer of the code should address the issues -- @tarruda can you assist here?

@tarruda it seems this needs a more elaborated solution. would you please take a look at it ? (cc: @niedbalski for visibility)


Problems testing with Jest and invariant

Hello Ken, I had some tests following this technique http://facebook.github.io/react/blog/2014/09/24/testing-flux-applications.html
However, I am having some troubles using McFly. I tried to write a test using your library example.
jest.dontMock('../CounterStore');
jest.dontMock('../../flux/mcFly');

describe('CounterStore', function()
{
   it('expects store to be defined', function() {
     CounterStore = require('../CounterStore');
     expect(CounterStore).toBeDefined();
   });
});

This test fails.
What I do is add this to the package.json:
"jest": {
   "rootDir": ".",
    "scriptPreprocessor": "../jest-preprocessor.js",
    "unmockedModulePathPatterns": [
      "./node_modules/react",
      "./node_modules/mcfly"
    ]
 },

Then the test passes ok. However, in my project I also use react-tools. It's giving me a very weird error:
MyStore.js: __DEV__ ist not defined
.../node_modules/react-tools/src/vendor/core/invariant.js:26:7
.../node_modules/mcfly/lib/Store.js:21:5
.../node_modules/mcfly/lib/McFly.js:32:17

I saw in line 21 of mcfly Store there is:
invariant(!methods.callback, '"callback" is a reserved name and cannot be used as a method name.');

But it is using the invariant library from react-tools instead of the one from mcfly! Is this a library problem? Or am I using the packages very wrong? Not sure if this is mcfly related o a Jest problem.
This is not happening with the example of this library (still using 0.0.2) but if you change the package.json to:
 "dependencies": {
   "mcfly": "0.0.8",
   "react": "^0.12.0",
   "underscore": "^1.7.0"
 },

Then:
 - ReferenceError: /Users/xxx/Desktop/mcfly-master/example/js/stores/CounterStore.js: __DEV__ is not defined
    at invariant (/Users/xxx/Desktop/mcfly-master/example/node_modules/react-tools/src/vendor/core/invariant.js:26:7)
    at new Store (/Users/xxx/Desktop/mcfly-master/example/node_modules/mcfly/lib/Store.js:21:5)
    at McFly.createStore (/Users/xxx/Desktop/mcfly-master/example/node_modules/mcfly/lib/McFly.js:32:17)
    at /Users/xxx/Desktop/mcfly-master/example/js/stores/CounterStore.js:9:26

EDIT:
If in Jest configuration I do:
"globals": {"__DEV__": true}

Then all tests are ok but I feel like cheating? But actually if I try:
var mockStore.mcFly.createStore({
  mixin: function(){
    return null
  }
    ...
})

Then it tells me:
Invariant violation: "mixin" is a reserver name and cannot be used as a method name

(which is from McFly invariant so... maybe I am not doing anything wrong at the end).

I am having the same issue when testing some react component ... What do you mean by namespacing it? Should I namespace the component? How would you do that and how would you reference the component?
Why doesn't this occur when running the code in the browser?

@davidreher I think my invariant and Facebooks invariant are colliding. Therefore I would name invariant like iv or something.

Hello again,
Using mcfly 0.0.10 and Jest 0.4.0, I am still seeing this error:
__DEV__ is not defined
  at invariant (.../node_modules/react-tools/src/vendor/core/invariant.js:26:7)
  at new Store (.../node_modules/mcfly/lib/Store.js:23:5)
  at McFly.createStore (.../node_modules/mcfly/lib/McFly.js:34:17)

I wonder if the reason is coming from doing this:
"unmockedModulePathPatterns": [
  "<rootDir>/node_modules/react",
  "<rootDir>/node_modules/mcfly"
]

But without mcfly there I had other problems...

often I need to use this in my tests around McFly stores
jest.mock('mcfly/node_modules/flux');

As well as not mocking my mcFly instance.
also you can add globals to the package.json
  "jest": {
    "globals": {
      "__DEV__": true,
    },

Hi! Yea maybe I would have to try removing   "<rootDir>/node_modules/mcfly" and check the tests...
Adding the global DEV variable does the trick but it seems very hacky to me.

I think you'll still need to keep the unmockedModulePathPatterns for mcfly so that stores and actions can be created and tested. I just make sure that the flux dependency of McFly still does get mocked (which contains invariant)
In my build, we use a DEV flag in our source anyway as it's a common practice so the global flags in the test runner make logical sense.
I think you could also add this to your test file to achieve the same goal (not sure how jest plays with this):
GLOBAL.__DEV__ = true

I tried to add the globals to my package.json, but it didn't work I still see the error DEV is not defined

How would one go about modifying the globals within the tests? So for instance if I wanted DEV to be true for one test, and then false for another.

How would one go about modifying the globals within the tests? So for instance if I wanted DEV to be true for one test, and then false for another.

just do window.DEV to change it


Complete position redesign (NEEDS CHECK!)

Redesigned the system of poses for easily adding new ones. Added one. Still needs a more professional look-through into the scaling.

I appreciate the effort, however, you put your changes in a single huge commit which you somehow got git to treat as a file creation. Which ultimately means, that even if you had based your changes off the newest version from my repository (rebasing yours), I can't compare versions through git. This makes merging a very challenging task.
Aside from that, what exactly does your pull request actually change? The only thing I noticed different (having not looked at the code too much but I just compiled and ran your version) was the broken scaling you mentioned.
If you rebase your changes off the current upstream master I'll take another look, maybe git will allow me to see diffs then - in it's current state merging your changes would be a pretty big effort on my end :/


Error finding provider when using selinux_port

I would like to use aelinux_port and other types/and providers provided by this module but not use the whole module to control selinux.
This requires that the packages for selinux be installed.  This module already has the logic for that in selinux::packages and all the hiera data that is set up but I can't use it without the whole module because it it private.
I have a fix that makes the package module public so it can be included in other modules when the type or providers are used  but does not require them to include the whole module.  It also will not conflict with the module if they do choose to include the module to control selinux.

Closing per https://github.com/voxpupuli/puppet-selinux/pull/338#issuecomment-788522608


request for placeholder field inside of textfield class?

request for placeholder field inside of textfield class?

http://stackoverflow.com/questions/9749742/python-wtforms-can-i-add-a-placeholder-attribute-when-i-init-a-field/9783777#9783777