Offline option

Hi! 👋🏾
Thanks for writing pipdeptree I'm loving it 😍
I'm integrating it in https://github.com/plone repositories together with z3c.dependencychecker to understand and update the requirements of all distributions that make up Plone.
It would be cool if pipdeptree could have an --offline option where it would not require internet connection to resolve the dependencies.
My use case is that we have a requirements.txt/constraints.txt files with all the dependencies and their exact version that need to be used, we are missing the visualization of how they are tangled together (which is what pipdeptree covers ✨ ).
So the idea would be that when the --offline option is given to pipdeptree it resolves the dependencies within what's available within the virtual environment where it is run on.
If a dependency is missing/can't be resolved, pipdeptree needs to bail out and ask users to either remove the --offline option or install the packages that are needed.
Would this functionality something that make sense to have in pipdeptree? 🤔 🍀

Indeed, pipdeptree can be used without network connection originally. It can also be used in virtual environment with --local-only.

Could you post more outputs or steps to reporduce if you still have questions. Thanks!

I closed this issue now.
If you still have problems, please reopen it anytime.


SC-6975: improve re-authentication feature

Scope of changes
SC-6975: improve re-authentication feature
Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[x] refactoring

Acceptance criteria
To have this experience, the user session must expire for now. In this case, the easiest thing to do is to connect and then reconnect after two or three hours
Author checklist

[ ] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #655 (df41fbf) into main (ec1585c) will decrease coverage by 8.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   46.15%   38.10%   -8.06%
==========================================
  Files         551      155     -396
  Lines       16454     2433   -14021
  Branches     1194      617     -577
==========================================
- Hits         7595      927    -6668
+ Misses       7704     1330    -6374
+ Partials     1155      176     -979

Impacted Files
Coverage Δ

...s-user-ui/src/application/routes/LandingOutlet.tsx

...s-user-ui/src/application/routes/PrivateOutlet.tsx

...ds-user-ui/src/components/NeedsAttention/index.tsx

...b/gds-user-ui/src/components/Sidebar/MobileNav.tsx

...omponents/TestnetProgress/CertificateStepLabel.tsx

web/gds-user-ui/src/hooks/useAuth.ts

web/gds-user-ui/src/hooks/useCertificateStepper.ts

web/gds-user-ui/src/hooks/useCustomAuth0.ts

web/gds-user-ui/src/layouts/DashboardLayout.tsx

.../gds-user-ui/src/layouts/SimpleDashboardLayout.tsx

... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1585c...df41fbf. Read the comment docs.


Pod not building on Xcode 13 Beta & iOS 15 Beta

Information
I tried building this pod for a flutter plugin with the Xcode 13 Beta, however it gives a lot of errors. Seems to be something with unwrapping the service from the characteristic object. See the logs for more information.
DFU Bootloader version:

Library version: 4.10.3

Device information:

Device: iPad Air 2
OS: iOS 15 Beta

Logs
(Image because full stack trace is too long for Github)

Thank you for creating the issue. I really like Apple for caring about backwards compatibility.

This seems to be because of this kind of API changes

At least its not like Android where everything gets deprecated after a new api release.. 😅

Fixed: https://github.com/NordicSemiconductor/IOS-Pods-DFU-Library/pull/433


sinkmanager(ticdc): init

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/5928
What is changed and how it works?
init sink manager implement.
Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

Codecov Report

Merging #7388 (cb83338) into master (11dbe58) will decrease coverage by 0.1006%.
The diff coverage is 46.7966%.

Additional details and impacted files

Flag
Coverage Δ

dm
51.9611% <52.0000%> (+0.0176%)
:arrow_up:

engine
60.7717% <ø> (-0.1144%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7388        +/-   ##
================================================
- Coverage   59.8873%   59.7867%   -0.1007%
================================================
  Files           799        800         +1
  Lines         91637      91629         -8
================================================
- Hits          54879      54782        -97
- Misses        31982      32072        +90
+ Partials       4776       4775         -1

Rest LGTM.

/hold
This PR will be split into multi PRs.


Import topics during migration

Partially fix #5490

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7ffa3fc). Click here to learn what that means.
The diff coverage is 43.75%.

@@            Coverage Diff            @@
##             master    #7851   +/-   ##
=========================================
  Coverage          ?   41.39%
=========================================
  Files             ?      474
  Lines             ?    63796
  Branches          ?        0
=========================================
  Hits              ?    26408
  Misses            ?    33946
  Partials          ?     3442

Impacted Files
Coverage Δ

modules/migrations/gitea.go
8.65% <0%> (ø)

modules/migrations/github.go
84.35% <100%> (ø)

modules/migrations/git.go
55.55% <100%> (ø)

modules/migrations/migrate.go
21.17% <22.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffa3fc...a2c5551. Read the comment docs.


Towards scala 2.13 compatibility

Changed ⇒ with => because the single unicode character is deprecated.
Change scala.Seq to scala.collections.immutable.Seq throughout the project.

Special attention has been given to the com.ing.baker.il.EventDescriptor, where the toString method has been overridden to try to keep its output the same as before the Seq change. This is required to keep the recipe hash the same, to keep recipes backwards compatible between baker versions.
Although many recipe variants are tested to be backwards compatible within the unit tests throughout the different baker modules, there could be edge cases where backwards compatibility is lost.
Another thing of note is that when using scaladsl as a consumer, you will have to supply immutable sequences now, instead of mutable ones in the previous version.
When using scala 2.12 this usually means adding import scala.collection.immutable.Seq and/or using .toIndexedSeq instead of .toSeq.
In scala 2.13 the current scala.Seq and .toSeq already point to the immutable Seqs, so no changes would be required.

Codecov Report

Merging #1175 (9b85525) into master (75dd285) will increase coverage by 0.10%.
The diff coverage is 88.12%.

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
+ Coverage   81.31%   81.41%   +0.10%
==========================================
  Files         122      123       +1
  Lines        3960     3961       +1
  Branches      117      125       +8
==========================================
+ Hits         3220     3225       +5
+ Misses        740      736       -4

Impacted Files
Coverage Δ

...n/scala/com/ing/baker/runtime/akka/AkkaBaker.scala
79.02% <ø> (ø)

...tor/process_instance/ProcessInstanceProtocol.scala
27.77% <0.00%> (ø)

...kka/actor/process_instance/internal/Instance.scala
100.00% <ø> (ø)

...ain/scala/com/ing/baker/runtime/model/BakerF.scala
37.39% <ø> (ø)

...m/ing/baker/runtime/model/InteractionManager.scala
68.62% <ø> (ø)

...ng/baker/runtime/model/RecipeInstanceManager.scala
75.00% <ø> (ø)

.../runtime/model/recipeinstance/RecipeInstance.scala
87.27% <ø> (ø)

...recipeinstance/RecipeInstanceEventValidation.scala
91.11% <ø> (ø)

...r/runtime/serialization/InteractionExecution.scala
100.00% <ø> (ø)

...c/main/scala/com/ing/baker/il/CompiledRecipe.scala
86.36% <ø> (ø)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75dd285...9b85525. Read the comment docs.


Support

https://www.w3.org/TR/SVG11/filters.html#feComponentTransferElement

Fixed by https://github.com/RazrFalcon/resvg/commit/f8e9f87fe2a41594c5c8897d189ea029839ddf4c


Scaling Dispike to Large, Organized Projects - Questions and Concerns

I'd like to preface this discussion with thanks, Dispike is an impressive project and I look forward to seeing its continued growth.
As Dispike nears its first stable release, I've begun to scaffold my first project that will be based upon it. It's here that I've run into concerns regarding how a "large-scale" Dispike project should be organized; however, I'm unsure whether this is a matter of library design or lack of understanding on my end.
As it stands, an ideal Dispike bot (as provided by the example) is structured as follows:
bot.py
bot = Dispike(...)

@bot.interaction.on("...")
async def CommandA(...):
    return DiscordResponse(...)

@bot.interaction.on("...")
async def CommandB(...):
    return DiscordResponse(...)

@bot.interaction.on("...")
async def CommandC(...):
    return DiscordResponse(...)

This is a clean and simple approach to interfacing with the library, but it quickly becomes problematic at scale and I'm unsure how to resolve it. Because the bot instance is used in the decorator, using classes (and accessing self for global variables) is not an option(?) As you could imagine, this is less than ideal when you have several commands or commands with large amounts of logic.
Discord.py provides a solution to this as follows:
.../commandGroupA.py
from discord.ext.commands import command

class ExampleBot:
    @command(name="commandA")
    async def CommandA(...):
        await ctx.send(...)

    @command(name="commandB")
    async def CommandB(...):
        await ctx.send(...)

    @command(name="commandC")
    async def CommandC(...):
        await ctx.send(...)

By importing command and using it in the decorator, we do not need to access the bot object. This allows for commands (interaction) to be defined in various files across the project without having to avoid circular imports and classes.
An example of what this could look like for Dispike is as follows:
bot.py
bot = Dispike(...)

bot.run(...)

.../commandGroupA.py
from dispike import interaction

class CommandGroupA:
    @interaction.on("commandA", eventType=EventTypes.COMMAND)
    async def CommandA(...):
        return DiscordResponse(...)

    @interaction.on("commandB", eventType=EventTypes.COMMAND)
    async def CommandB(...):
        return DiscordResponse(...)

    @interaction.on("commandC", eventType=EventTypes.COMMAND)
    async def CommandC(...):
        return DiscordResponse(...)

.../.../commandGroupB.py
from dispike import interaction

class CommandGroupB:
    @interaction.on("commandD", eventType=EventTypes.COMMAND)
    async def CommandD(...):
        return DiscordResponse(...)

    @interaction.on("commandE", eventType=EventTypes.COMMAND)
    async def CommandE(...):
        return DiscordResponse(...)

    @interaction.on("commandF", eventType=EventTypes.COMMAND)
    async def CommandF(...):
        return DiscordResponse(...)

I'd appreciate any input you may have on this @ms7m! It's not a groundbreaking issue by any means, but I'm hopeful that you'll have a solution that I'm overlooking that may not even require changes to the library.
Perhaps the example bot could be updated to demonstrate the best practices?
Thanks!

I agree 100% with the concern on scaling this out -- I first noticed it when trying to develop the sample bot.
This will definitely lead to a little bit of a rewrite, and I'll try to develop some ideas over the weekend.

Edit: I'm gonna push a couple of ideas on the dev branch to get this rolling, this is what it'll probably look like
from dispike import interactions
from dispike import interactions, Dispike
from dispike.response import DiscordResponse
from dispike.register.models import DiscordCommand
import typing

*testing_commands.py*
class SampleCommandCollection(interactions.EventCollection):
    def __init__(self, *args, **kwargs):
        # if needed
        pass

    @staticmethod
    def command_schemas() -> typing.List[
        typing.Union[interactions.PerCommandRegistrationSettings, DiscordCommand]
    ]:
        return [
            DiscordCommand(
                name="testcommands",
                description="return simple command",
                options=[],
            )
        ]

    def registered_commands(self) -> typing.List[typing.Callable]:
        return [self.sample_interactions]

    # COMMANDS

    @interactions.on("testcommand")
    async def sample_command(*args, **kwargs) -> DiscordResponse:
        ...

    @interactions.on("testcommand2")
    async def sample_command_2(*args, **kwargs) -> DiscordResponse:
        ...

main.py
bot = Dispike(
    client_public_key=...,
    application_id=...,
    bot_token=...,
)

bot.register_collection(collection=SampleCommandCollection, initialze_on_load=True)

When writing the components, i played around with the idea of having more advanced commands having their own full class, with both the main handler and interaction handlers. But that is actually something that a dev could do themselves

@ms7m I had some time to try out the changes from #47, very happy with the progress and looking forward to the release. I believe all of my concerns have been resolved, though there's just one thing left that I'm unsure of and would like your input.
First, a minimal example for context...
./bot.py
from commands import ExampleCollection

class ExampleBot:
    def Run(self):
        bot = Dispike(...)

        bot.register_collection(collection=ExampleCollection)

        bot.run(5000)

if __name__ == "__main__":
    ExampleBot.Run(ExampleBot)

./commands/__init__.py
from .example import ExampleCollection

./commands/example.py
class ExampleCollection(EventCollection):
    def command_schemas():
        return [
            PerCommandRegistrationSettings(
                schema=DiscordCommand(name="example", description="Example Command.", options=[]),
                guild_id=...,
            )
        ]

    @interactions.on("example")
    async def ExampleCommand(ctx: IncomingDiscordInteraction) -> DiscordResponse:
        return DiscordResponse(content=f"Hello, World!")

This example allows for the exact kind of structure that I described in the initial Issue. The only caveat I've found is that in the command handler (ExampleCommand()), self cannot be accessed. Am I missing something or is this currently not possible?
Ideally, variables could be defined in the ExampleBot class and then later accessed in the ExampleCommand() handler.

Unrelated to the problem described in the above comment.
I do not believe that it's currently possible to send a DeferredResponse in an EventCollection as the bot object no longer exists. Correct me if I'm wrong, but perhaps a way of solving this would be as follows...?
@interactions.on("example")
async def ExampleCommand(ctx: IncomingDiscordInteraction) -> DeferredResponse:
    return DeferredResponse(original_context=ctx, new_message=DiscordResponse(...))

.register_event_collection function has an argument to help you initialize with arguments.. So in theory you should be able to do
 bot.register_collection(collection=ExampleCollection, initalization_arguments={"bot": bot}, initialze_on_load=True)

You can also do

_collection = ExampleCollection(bot=bot)
bot.register_collection=(_collection)

All of these methods assume that you have added __init__ to your collection.

Actually I've just tried it my self, and there was a bug that dispike couldn't find any methods inside the collection that have a interactions.on decorator.
I've just pushed a change to the dev branch, so go ahead and pull/install and try everything above again.

Perfect, I think that's all of my scale concerns resolved! I'll get to building with the dev branch and report any further issues or concerns that I run into.

The initalization_arguments argument for register_collection is misspelled, it should be initialization_arguments.


TypeScript type definitions

I am wondering if there is already someone who started with the type definitions for this project. I think it would open the project for an even bigger audience.
What is your opinion on that?

I added type definitions. @types/react-simple-maps

@thepocp Thanks! I'm running into an issue, though, where trying to add an onClick handler to <Geography> is resulting in a compiler error:
Type '{ key: number; geography: any; projection: (point: [number, number]) => void; onClick: (e: SyntheticEvent<Element, Event>) => void; style: { default: any; hover: { fill: string; stroke: string; strokeWidth: number; outline: string; }; pressed: { ...; }; }; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Geography> & Readonly<{ children?: ReactNode; }> & Readonly<GeographyProps>'.
  Property 'onClick' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Geography> & Readonly<{ children?: ReactNode; }> & Readonly<GeographyProps>'.

For the code that's being used, it's based on this example.

As of Jan. 2, 2020, it looks like the published types are for for 0.12.2 but the current version is 1.0.0-beta.0 which causes mismatches.

I created a pull request: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/41370

I'm having some trouble with the projection prop on ComposableMap. It's type is string | ProjectionFunction but as far as I can tell from the code it should be string | GeoProjection. Is that correct? Should I create a PR?

It seems that the types for react-simple-maps have fallen significantly behind the current version.


Bugfix/include pending channels in max channel

When committing funds, we check if there is already a channel open for that currency. We were having an issue where we were allowing multiple channels of the same currency to open if you committed balances very quickly in a row. This was because the committed balance of the first channel was still pending.
This PR also takes pending channels into consideration when attempting to open new channels.

 When committing a balance, behavior should be the same regardless of amount in channel


Tags aren't rendered in Paragraphs section of tag summary page

Given the following page content:
#test

This is a #test tag.

The "📌 test" page looks like this:

Note that the tag itself is missing from the quoted paragraph.  If a paragraph includes multiple tags, they're all missing (i.e. it affects both the tag of the summary page you're looking at, as well as other nearby tags).

Yeah, this is a good point that requires some type of decision.
In general you may use a hashtag "in the flow" of some text, like you're doing now. In others you may use it to tag something more as meta data. Likely in those scenarios you'd put the hash tag either at the very beginning or very end, so we could make the behavior of whether to leave the tag inside or not depend on that. That may lead to unexpected edge cases, though. For instance if your paragraph (in this case, but we should the same rules apply to pages, items, tasks etc.) starts with a hashtag it would disappear, whereas if it's the second word it is not. An alternative would be to keep two versions in the database, one with all tags in tact and one without.
Opinions?

I'd try to not introduce special behaviour with surprising edge cases in the default application. Also keeping the same information twice seems like it will need to be maintained twice, cause surprises for Plugs etc.
In that case of choosing just one, I'd show the tags, mostly because it supports the IMO simpler and "mainstream" use case of using them in text. In the other situation of having them as metadata, there will probably be some processing through query, template or sth else. So if for that user seeing the tags is an eyesore, they will know the tools to hide them. Also conceptually this is simpler to me - the text is there, but sometimes it's special meaning
Counterargument:

optimize for people with a hacker mindset

😉

(I should say I'm new to SilverBullet, so still discovering the layers of hackability... 🙂)

In general you may use a hashtag "in the flow" of some text, like you're doing now. In others you may use it to tag something more as meta data.

My understanding from https://silverbullet.md/Objects#Tags is that tags on their own are what actually tag the page, whereas ones mixed with non-tag text are just linking to it (and indeed the Pages vs. Paragraphs distinction seems to match this, with the latter more like the Linked Mentions section for page links).
I'm not sure what's involved in indexing, but I think in general I'd also expect the whole thing to be captured and shown when presented elsewhere, including any elements with special meanings.
I've also just spotted the table on https://silverbullet.md/Objects#paragraph where #paragraph-tag is similarly omitted from the table showing what I'm assuming is the raw indexed data about tags in paragraphs.

I like what @Maarrk is suggesting, which is to keep the tags in the indexed text, because there's means to remove it later for those who want it.
As to @Terrance your understanding of how it works. Indeed, tags by themselves on an empty line tag the whole page. If they're used in a (top level) paragraph, they'd tag that paragraph. If they're used in a task, or list item, they tag that task or list item. I think I've been inconsistent with in what cases I pull the tags out of the text and in what we don't, so would be good to standardize that. Probably keeping them in makes most sense.

Adding this to the 1.0 roadmap as we need consistent behavior across all object types. Either tags are removed or kept, or there is an attribute with the original text and one with the cleaned one.


Fix Twitter link

Fixes duplicate : in Twitter profile link that was causing Twitter profile links to not work.
Have a couple more PRs incoming for other minor quality of life fixes.

Follows #1172.

Thank you, @iansltx!


Feature request: input-changed should accept function call rather then function reference

When I have following code, I'd like to have a way to call the callback along with it's value. On regular input I use the ng-change for it. It would be really neat if input-changed worked the same way. Currently I don't see a way to do it, so please let me know if I'm missing something.
<div ng-repeat="user in users">
  <angucomplete-alt input-changed="changedInputForUser(user)" />
</div>

Thanks

Try this:
$scope.changedInputForUser = function(str) {
  var user = $scope.users[this.$parent.$index]
  // do something with user and str
}

This should definitely be documented. I'll do it.

Thank you @antony


Update project.js

just added a project

thank you - how do I know when a new version of the software is ready to download?

On 19 Oct 2020, at 4:28 PM, Oktawia Kata<EMAIL_ADDRESS>wrote:
Merged #195 https://github.com/BMMRO-tech/BMMRO/pull/195 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/BMMRO-tech/BMMRO/pull/195#event-3895385161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJPO5WVT6VQYVMVRT5H5FDSLSON3ANCNFSM4STZ4LJA.

@CharlotteBahamas2017 this is a manual process for now, whoever merges the PR and deploys the new version should let you know that a new version is available.
For debugging purposes, there is a version number in the footer.

thanks - and where is the dashboard I can add a ‘wishlist’ item

On 21 Oct 2020, at 7:33 AM, Oktawia Kata<EMAIL_ADDRESS>wrote:
@CharlotteBahamas2017 https://github.com/CharlotteBahamas2017 this is a manual process for now, whoever merges the PR and deploys the new version should let you know that a new version is available.
For debugging purposes, there is a version number in the footer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/BMMRO-tech/BMMRO/pull/195#issuecomment-713504541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJPO5RUGZKCBM2KSZJYY5LSL3BJRANCNFSM4STZ4LJA.


update V2MintModal to latest changes

What does this PR do and why?
update v2 mint modal to new formatted number input
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1850

PR #1851

PR #1852

PR #1853

PR #1854

PR #1855

PR #1856

PR #1857   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: Bz06LeDtEbubKjTKJ7Uz

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: K6aspz5JPAni9wHcwaz8


angular with universal getting error

Hi,
I am trying to angular with universal.
I refer this  https://github.com/angular/angular-cli/wiki/stories-universal-rendering.
I build my app
using this command
npm run build:ssr
I trying to serve using this command
npm run serve:ssr
I am getting this error.
> Unhandled Promise rejection: renderModule[Factory]() requires the use of BrowserModule.withServerTransition() to ensure
> the server-rendered app can be properly bootstrapped into a client app.

How can i fix this issue.
Kindly pls advice me,
Thanks.

Ok, first question, do you have the line BrowserModule.withServerTransition() in your AppModule? Also, can you post the repo you're dealing with so we can take a closer look at it?

Have the same issue and dont have BrowserModule.withServerTransition() in my AppModule

@TomasKatz Do you have it somewhere? It needs to be somewhere in your application.

Resolved it by adding:
import { BrowserModule } from '@angular/platform-browser';
...
imports: [
      BrowserModule.withServerTransition({
          appId: 'ng-universal-demystified'
      })...
  ]

However the problem we are facing here is f**ing uploading an express-universal app to IIS, which proves  to be non-trivial at all.

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


Message to all contributors

This project is awesome !!!!!
Thank for that.
I like the samples with all the comments, it make all the code very understandable👍🏻
Great job.

Hey thanks!


feat: add walletconnect default setup.

add walletconnect setup with wagmi+react-query stack

Notes

need production WC project id, will follow up with @web3-nomad
using ETH mainnet for now, Hedera config will be added next

will reopen to see new preview urls


Allow control of Circe formatting

Restores the ability to use a custom Printer if the user wants,
by specifying it in implicit scope.
Keeps the current default behavior of using Printer.nospaces.

Solves #138

Nice. Yet I think I will set up benchmarks to see the impact on performance before merging. Just out of curiosity...

@nicolasdalsass could you please rebase your PR?

Yup !

Thanks for merging :-) Out of curiosity, could you spin benchmarks ? Your comment got me thinking too !


Add space after commas and add an option to get css colors in color module level 4 format

Hi! In this PR I'm modifying primarily two things:

Standard legacy color format (added spaces after the commas)
Standard current CSS Color Module Level 4 (replaces commas with just spaces, removes the "a" appended to color formats, e.g. rgba(...) is now just rgb(...), and the alpha value separator is the "/" character)

Documentation about the CSS Color Module Level 4 is here: https://www.w3.org/TR/css-color-4/#color-syntax
The way it would work is as follows:
const legacyColor = new ColorTranslator("#004080c0");
console.log(legacyColor.RGB);       // rgb(0, 64, 128)
console.log(legacyColor.RGBA);      // rgba(0, 64, 128, 0.752941)
console.log(legacyColor.HEX);       // #004080
console.log(legacyColor.HEXA);      // #004080C0
console.log(legacyColor.HSL);       // hsl(210, 100%, 25.098039%)
console.log(legacyColor.HSLA);      // hsla(210, 100%, 25.098039%, 0.752941)
console.log(legacyColor.CMYK);      // cmyk(100%, 50%, 0%, 49.803922%)
console.log(legacyColor.CMYKA);     // cmyk(100%, 50%, 0%, 49.803922%, 0.752941)

const level4Color = new ColorTranslator("#004080c0", undefined, true);
console.log(level4Color.RGB);       // rgb(0 64 128)
console.log(level4Color.RGBA);      // rgb(0 64 128 / 0.752941)
console.log(level4Color.HEX);       // #004080
console.log(level4Color.HEXA);      // #004080C0
console.log(level4Color.HSL);       // hsl(210 100% 25.098039%)
console.log(level4Color.HSLA);      // hsl(210 100% 25.098039% / 0.752941)
console.log(level4Color.CMYK);      // cmyk(100% 50% 0% 49.803922%)
console.log(level4Color.CMYKA);     // cmyk(100% 50% 0% 49.803922% / 0.752941)

⚠This PR is still missing tests, documentation updates, and more, but I wanted to make sure that you agree with these changes before continuing⚠

Would it be possible to have the deg suffix on the angles? This is required by stylelint-config-standard…

@unikitty37 It indeed is possible,  but as far as I can tell, using the "deg" suffix or not is equally as valid (neither of those is legacy according to W3C), so I leave it up to @elchininet to decide

@unikitty37 It indeed is possible, but as far as I can tell, using the "deg" suffix or not is equally as valid (neither of those is legacy according to W3C), so I leave it up to @elchininet to decide

As the main reason for my raising the parent issue is to get the colours generated to satisfy stylelint-config-standard, I'd obviously like it to be either always included or an option. At the very least, editing a colour that already has "deg" in place shouldn't cause it to be removed, so I only have to add it the first time…

@unikitty37 I think that the deg problem might be an issue of stylelint-config-standard since they state in their README:

It extends stylelint-config-recommended and turns on additional rules to enforce modern conventions found in the CSS specifications.

Where CSS specifications refers to the W3C web, and as I read through the W3C documentation, I didn't see a single instance where the unitless hue value is legacy.
This is the rule that throws that error
https://stylelint.io/user-guide/rules/hue-degree-notation

@jeronimoek I don't think anybody's saying unitless is legacy, as such — but stylelint can be used to enforce consistent usage one way or the other, and it would be better if the decision as to which to use came from the stylelint user, and wasn't being forced by ColorTranslator only supporting one way :)
In particular, if a project decides to use stylelint-config-standard to avoid bikeshedding, not supporting the deg unit means developers have to put it back in every time they edit a colour.

@unikitty37 I agree, but maybe we should look into that in another issue since the changes presented here are required to allow non-legacy color formats (CSS Colors Module Level 4), meanwhile, the deg problem is related to users of stylelint-config-recommended library.
Depending on what @elchininet decides, we either could add the deg suffix by default or otherwise, we might need to add another option to tackle that problem, which would require another issue in my opinion

Hi @jeronimoek,
Pull requests are always welcome and you already have contributed to the project :)
CSS Level 4 is something that I have on my list since a long time.
Some comments about this pull request in particular:

Avoid refactorings of the code when you want to implement a new feature, this only makes the pull request harder to review. Ship only the minimum required changes to implement the new feature, the rest of the changes could be made in separate pull requests.
Avoid making changes that are not fully justified in the pull request description. Adding spaces after the commas is not something necessary by the CSS specification and it is not related to the CSS Level 4 either, so it seems that it is something that you need, want or prefer, but for that you need to provide reasons of the change and preferably make them in a separate pull request.
I agree with @unikitty37, it should not be up to the library to decide the format of the final CSS, the user should be able to select it. Now that the intention is to bring CSS Level 4, this is a good oportunity to avoid forcing the final format of the CSS. The library already accepts CSS Level 4 inputs, it should be able to generate all these formats as the output in the same way.

So, these are my thoughts about how should be the proper way to implement this:
This change can be shipped as a breaking change (a major version of the library), so I think that it should be safe to remove legacy support by default from the output, obtainig the output in the legacy format should be optional (the opposite to what you are trying to achieve). If someone wants the legacy format by default, they can stick to an old version.
At the moment, the static methods require many parameters, this will became a big problem in the future because new options will be requested, so more parameters will be added. If one wants to add a parameter that is at the end of the method one should send undefined or set a value in the previous ones, this will become problematic when more parameters are added. This is a good opportunity to introduce a configuration object. Only one parameter could be sent at the end of the static methods or sent to the class instance. All the options of this configuration object should be optional so it is easy to add more and more options in the future and the options should be intended just to override the default ones. This configuration object could have a shape like this one (I didn‘t thought deeply about it, so this is just to give an idea):
// config optional parameter
{
    decimals: 2,
    legacy: true,
    anglesUnit: 'deg',
    spacesAfterCommas: true
}

Now, the library could detect these parameters in the input, so if someone is using a format for the input, the library should return the same format without the necessity of providing a configuration. If one wants different types of input but a consistent output, then a configuration is needed, if a configuration is sent it rules over the input format. This solves what you want to achieve with the commas after the values, what @unikitty37 is searching for his use case and I think that it should be flexible enough for any use case.

If one sends #FF00FF55 => Defaults options
If one sends rgb(100,40,12) => legacy: true / spacesAfterCommas: false
If one sends hsl(300deg 100% 50% / 50%) => legacy: false / anglesUnit: deg

I would like to hear your opinon and also @unikitty37‘s opinion. For this changes we should create a branch prepared for the next big release and ship the changes in small commits intended for specific things as it is easier to review (migrate to a configuration object, detect the options from the input, apply different templates depending on the configuration, etc). I can help to work on it.
Let me both know your thoughts, regards.

@elchininet Thanks for your attention! I agree with you. This would make a big improvement to the library. I'll wait for the new branch.
Regarding the library setting the options based on the input value, we should decide how it will work when there is more than one color input involved, for example, when using a color blend or color mix static method.
Also, I'm not so used to this workflow. Should we create a new issue and track the progress there?
Maybe we could use a task list for this purpose. https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists

@elchininet I like this — it looks like it should be flexible enough to handle all the use cases I can think of. Thanks!

Ok @jeronimoek,
I‘ll create the issue and the task list soon, but we can sync and change things there once it is done.
Regards

Hi @jeronimoek,
Here you go: https://github.com/elchininet/ColorTranslator/issues/114
We can split the tasks between us, so just let me know if you prefer tp cover only certain tasks and I‘ll take care of the rest.
Regards


added my name

I have added my name to the list
Related issue

What changes does this PR do?
Screenshots (If any)
Questions

Closing due to inactivity feel free to reopen.


gitter channel

A gitter channel might be useful.
www.gitter.im

I don't think this is necessary at the moment


chore(deps): :arrow_up: update all non-major dev dependencies

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@storybook/addon-essentials (source)
7.5.3 -> 7.6.0

@storybook/addon-mdx-gfm (source)
7.5.3 -> 7.6.0

@storybook/test-runner
0.15.2 -> 0.16.0

@typescript-eslint/eslint-plugin
6.12.0 -> 6.13.1

@typescript-eslint/parser
6.12.0 -> 6.13.1

aws-cdk-lib
^2.110.1 -> ^2.111.0

aws-sdk
2.1502.0 -> 2.1505.0

esbuild
^0.19.7 -> ^0.19.8

fs-extra
^11.1.1 -> ^11.2.0

Release Notes

storybookjs/storybook (@storybook/addon-essentials)
v7.6.0
Compare Source

storybookjs/storybook (@storybook/addon-mdx-gfm)
v7.6.0
Compare Source

storybookjs/test-runner (@storybook/test-runner)
v0.16.0
Compare Source
🚀 Enhancement

Introduce logLevel configuration #406 (@yannbf)

🐛 Bug Fix

Filter duplicated error messages in browser logs #405 (@yannbf)
Fix sync issues between tests #404 (@yannbf)
Refactor: Extract the setup page scripts into a separate file #403 (@yannbf)
Docs: Adds feedback form to migration documentation #402 (@jonniebigodes)
Bump jest-playwright-preset from v3.0.1 to v4.0.0 #400 (@kemuridama)
Improve type safety and code quality #383 (@bryanjtc @yannbf)
Refactor: Improve internal code #378 (@bryanjtc @yannbf)

Authors: 4

@jonniebigodes
Bryan Thomas (@bryanjtc)
Ryo Ochiai (@kemuridama)
Yann Braga (@yannbf)

typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)
v6.13.1
Compare Source
Note: Version bump only for package @typescript-eslint/eslint-plugin
You can read about our versioning strategy and releases on our website.
v6.13.0
Compare Source
Note: Version bump only for package @typescript-eslint/eslint-plugin
You can read about our versioning strategy and releases on our website.

typescript-eslint/typescript-eslint (@typescript-eslint/parser)
v6.13.1
Compare Source
Note: Version bump only for package @typescript-eslint/parser
You can read about our versioning strategy and releases on our website.
v6.13.0
Compare Source
Note: Version bump only for package @typescript-eslint/parser
You can read about our versioning strategy and releases on our website.

aws/aws-sdk-js (aws-sdk)
v2.1505.0
Compare Source

feature: ElastiCache: Launching Amazon ElastiCache Serverless that enables you to create a cache in under a minute without any capacity management. ElastiCache Serverless monitors the cache's memory, CPU, and network usage and scales both vertically and horizontally to support your application's requirements.

v2.1504.0
Compare Source

feature: AppSync: This update enables introspection of Aurora cluster databases using the RDS Data API
feature: B2bi: This is the initial SDK release for AWS B2B Data Interchange.
feature: Backup: AWS Backup now supports restore testing, a new feature that allows customers to automate restore testing and validating their backups. Additionally, this release adds support for EBS Snapshots Archive tier.
feature: ControlTower: This release adds the following support: 1. The EnableControl API can configure controls that are configurable.  2. The GetEnabledControl API shows the configured parameters on an enabled control. 3. The new UpdateEnabledControl API can change parameters on an enabled control.
feature: EFS: Adding support for EFS Replication to existing file system.
feature: Fis: AWS FIS adds support for multi-account experiments & empty target resolution. This release also introduces the CreateTargetAccountConfiguration API that allows experiments across multiple AWS accounts, and the ListExperimentResolvedTargets API to list target details.
feature: Glue: add observations support to DQ CodeGen config model + update document for connectiontypes supported by ConnectorData entities
feature: SecurityHub: Adds and updates APIs to support central configuration. This feature allows the Security Hub delegated administrator to configure Security Hub for their entire AWS Org across multiple regions from a home Region. With this release, findings also include account name and application metadata.
feature: TranscribeService: This release adds support for AWS HealthScribe APIs within Amazon Transcribe

v2.1503.0
Compare Source

feature: AccessAnalyzer: IAM Access Analyzer now continuously monitors IAM roles and users in your AWS account or organization to generate findings for unused access. Additionally, IAM Access Analyzer now provides custom policy checks to validate that IAM policies adhere to your security standards ahead of deployments.
feature: Amp: This release adds support for the Amazon Managed Service for Prometheus collector, a fully managed, agentless Prometheus metrics scraping capability.
feature: BCMDataExports: Users can create, read, update, delete Exports of billing and cost management data.  Users can get details of Export Executions and details of Tables for exporting.  Tagging support is provided for Exports
feature: CloudTrail: CloudTrail Lake now supports federating event data stores. giving users the ability to run queries against their event data using Amazon Athena.
feature: CloudWatchLogs: Added APIs to Create, Update, Get, List and Delete LogAnomalyDetectors and List and Update Anomalies in Detector. Added LogGroupClass attribute for LogGroups to classify loggroup as Standard loggroup with all capabilities or InfrequentAccess loggroup with limited capabilities.
feature: CodeStarconnections: This release adds support for the CloudFormation Git sync feature. Git sync enables updating a CloudFormation stack from a template stored in a Git repository.
feature: ComputeOptimizer: This release enables AWS Compute Optimizer to analyze and generate recommendations with customization and discounts preferences.
feature: ConfigService: Support Periodic Recording for Configuration Recorder
feature: ControlTower: Add APIs to create and manage a landing zone.
feature: CostOptimizationHub: This release launches Cost Optimization Hub, a new AWS Billing and Cost Management feature that helps you consolidate and prioritize cost optimization recommendations across your AWS Organizations member accounts and AWS Regions, so that you can get the most out of your AWS spend.
feature: Detective: Added new APIs in Detective to support resource investigations
feature: ECS: Adds a new 'type' property to the Setting structure. Adds a new AccountSetting - guardDutyActivate for ECS.
feature: EFS: Adding support for EFS Archive lifecycle configuration.
feature: EKS: This release adds support for EKS Pod Identity feature. EKS Pod Identity makes it easy for customers to obtain IAM permissions for the applications running in their EKS clusters.
feature: EKSAuth: This release adds support for EKS Pod Identity feature. EKS Pod Identity makes it easy for customers to obtain IAM permissions for their applications running in the EKS clusters.
feature: ELBv2: This release enables both mutual authentication (mTLS), and Automatic Target Weights (ATW) for Application Load Balancers.
feature: FSx: Added support for FSx for ONTAP scale-out file systems and FlexGroup volumes. Added the HAPairs field and ThroughputCapacityPerHAPair for filesystem. Added AggregateConfiguration (containing Aggregates and ConstituentsPerAggregate) and SizeInBytes for volume.
feature: FreeTier: This is the initial SDK release for the AWS Free Tier GetFreeTierUsage API
feature: GuardDuty: Add support for Runtime Monitoring for ECS and ECS-EC2.
feature: IoTFleetWise: AWS IoT FleetWise introduces new APIs for vision system data, such as data collected from cameras, radars, and lidars. You can now model and decode complex data types.
feature: LakeFormation: This release adds four new APIs "DescribeLakeFormationIdentityCenterConfiguration", "CreateLakeFormationIdentityCenterConfiguration", "DescribeLakeFormationIdentityCenterConfiguration", and "DeleteLakeFormationIdentityCenterConfiguration", and also updates the corresponding documentation.
feature: LexModelsV2: This release introduces new generative AI features in AWS Lex: Assisted Slot Resolution, Descriptive Bot Building, and Sample Utterance Generation. These features leverage large language models available through Amazon Bedrock to improve the bot builder and customer experiences.
feature: LexRuntimeV2: Updates API to latest version.
feature: ManagedBlockchain: Add optional NetworkType property to Accessor APIs
feature: Personalize: Enables metadata in recommendations, recommendations with themes, and next best action recommendations
feature: PersonalizeEvents: This release enables PutActions and PutActionInteractions
feature: PersonalizeRuntime: Enables metadata in recommendations and next best action recommendations
feature: QuickSight: This release launches new APIs for trusted identity propagation setup and supports creating datasources using trusted identity propagation as authentication method for QuickSight accounts configured with IAM Identity Center.
feature: Redshift: This release adds support for multi-data warehouse writes through data sharing.
feature: Repostspace: Initial release of AWS re:Post Private
feature: S3: Adding new params - Key and Prefix, to S3 API operations for supporting S3 Access Grants. Note - These updates will not change any of the existing S3 API functionality.
feature: S3Control: Introduce Amazon S3 Access Grants, a new S3 access control feature that maps identities in directories such as Active Directory, or AWS Identity and Access Management (IAM) Principals, to datasets in S3.
feature: SecretsManager: AWS Secrets Manager has released the BatchGetSecretValue API, which allows customers to fetch up to 20 Secrets with a single request using a list of secret names or filters.
feature: SecurityHub: Adds and updates APIs to support customizable security controls. This feature allows Security Hub customers to provide custom parameters for security controls. With this release, findings for controls that support custom parameters will include the parameters used to generate the findings.
feature: StepFunctions: Adds new TestState operation which accepts the definition of a single state and executes it. You can test a state without creating a state machine or updating an existing state machine.
feature: TranscribeService: This release adds support for transcriptions from audio sources in 64 new languages and introduces generative call summarization in Transcribe Call Analytics (Post call)
feature: WorkSpaces: The release introduces Multi-Region Resilience one-way data replication that allows you to replicate data from your primary WorkSpace to a standby WorkSpace in another AWS Region. DescribeWorkspaces now returns the status of data replication.
feature: WorkSpacesThinClient: Initial release of Amazon WorkSpaces Thin Client

jprichardson/node-fs-extra (fs-extra)
v11.2.0
Compare Source

Copy directory contents in parallel for better performance (#1026)
Refactor internal code to use async/await (#1020)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR!


Do not run libvcx publishing from fork PRs

Thank you so much :D

Codecov Report

Merging #827 (30f194d) into main (07c35cb) will decrease coverage by 40.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #827       +/-   ##
==========================================
- Coverage   49.00%   8.73%   -40.27%
==========================================
  Files         410     405        -5
  Lines       33495   32663      -832
  Branches     7436    7194      -242
==========================================
- Hits        16413    2854    -13559
- Misses      11968   29003    +17035
+ Partials     5114     806     -4308

Flag
Coverage Δ

unittests-aries-vcx
8.73% <ø> (-40.24%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 302 files with indirect coverage changes


any plans to support SD3?

Any plans to experiment with SD3 DiT blocks?

yeah, same question!

What's with the thumbs down? If we can get this to work could possibly bypass any bad blocks that my be doing some sort of abliteration to the model when certain terms used, so it's not so overly censored. As it is now you have to use negative prompting of nsfw words to get better images, but there is some potential with this node here that I see.
I could modify this, I just didn't know how to translate this weight map (which was oddly deleted by stability AI) https://huggingface.co/stabilityai/stable-diffusion-3-medium-diffusers/commit/b1148b4028b9ec56ebd36444c193d56aeff7ab56

for SD3 support I was experimenting here, would greatly appreciate some help or direction 🙏🏻

yeah guys it's in my to-do :smile:


Installation error

Get this error while installing on a mac:
In file included from /Users/atulbansal/base/projects/cpp/asyncio/include/asyncio/event_loop.h:9:
/Users/atulbansal/base/projects/cpp/asyncio/include/asyncio/handle.h:9:10: fatal error: 'source_location' file not found
#include <source_location>
^~~~~~~~~~~~~~~~~
1 error generated.

Get this error while installing on a mac:
In file included from /Users/atulbansal/base/projects/cpp/asyncio/include/asyncio/event_loop.h:9: /Users/atulbansal/base/projects/cpp/asyncio/include/asyncio/handle.h:9:10: fatal error: 'source_location' file not found #include <source_location> ^~~~~~~~~~~~~~~~~ 1 error generated.

using gcc & libstdc++ instead

Same problem.
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.6 LTS
Release:	20.04
Codename:	focal
$ gcc --version
gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Other projects with coroutines and different C++20 features compile without problem.

Same problem. $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.6 LTS Release: 20.04 Codename: focal
$ gcc --version gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 Copyright (C) 2020 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Other projects with coroutines and different C++20 features compile without problem.

only support gcc-11/12


Fix a file type detection bug in the Upload library

There were actually 2 bugs that could be triggered in different scenarios (both, introduced with the _file_mime_type() method by me, sorry):

if the UNIX 'file' command was used, an empty argument was passed to it, due to an incorrect variable name (thanks to whoever fixed that in the 2.1-stable branch)
if the mime_content_type() function was used, it turns out that it's possible for it to return FALSE or an empty string and thus resulting in the file being rejected

Is this different to #733?
Should I close that one?
Is this meant to go to develop or 2.1-stable?
Can you add a change-log please.
you do not need to update 2.1-stable AND develop, just the lowest common denominator. We'll update 3.0 with 2.1 changes periodically.

Ok, updated the change log here as well.
Yes - it's a different patch, as one of the lines is already fixed in the 2.1-stable branch - just made the same changes where needed, so there's no conflict.

Please don't manually copy changes from one branch to another. You say
you did it to avoid conflicts but this makes the uneccessairily. We
aren't maintaining two copies here, we're just making a change to the
lowest version that needs to be changed. Everything is merged upwards,
so by fixing these two issues separately in 2.1 you have already fixed
3.0, it has just not been updated yet. This is done manually now and
then, and not by new pull requests.
Thank you for your fixes, but you didn't have to do it twice! :)

Andrey Andreev
<EMAIL_ADDRESS>2 December 2011 13:34
Ok, updated the change log here as well.
Yes - it's a different patch, as one of the lines is already fixed in
the 2.1-stable branch - just made the same changes where needed, so
there's no conflict.

Reply to this email directly or view it on GitHub:
https://github.com/EllisLab/CodeIgniter/pull/734#issuecomment-2989981


Backport #22104 to 1.28

Original PR

@ericgribkoff Thanks for catching that! I'd rather just do this backport in one. I'll get it in on master first.

Passing manually triggered run.

Unrelated failures: 1, 2


Publish app and update

Once a basic app is shippable, get it published and auto-updating.
Acceptance criteria

[ ] App can check for updates and update itself upon user input
[ ] (maybe) github automatically creates a full release when main is tagged
[ ] (maybe) github automatically creates a draft release when main receives commits

Closed by https://github.com/BoboRett/totally-not-curse/pull/9


ssh execute command in path

I guess my post is more a question than a real issue, but here it is (worst case is, you get to see how a user of your lib for a few hours try to do) :
I am trying to define a task to get the git branch of a repository.
Here is what I have so far :
(deftask :git-branch []
  (ssh (run
         (cd (:path @config))
         (run "pwd") ;; this println nicely /var/dev/my-repo => ok
         (run "ls -a") ;; this lists the right content                => ok
         (run "git rev-parse --abbrev-ref HEAD") ;; master => ok

         ;; strangely this is listed before
         ;; and it fails with :
         ;; stderr  fatal: Not a git repository (or any of the parent directories): .git
         (let [rt (ssh "git rev-parse --abbrev-ref HEAD")]
           (println "status " (:status rt))
           (println "stdout " (:stdout rt))
           (println "stderr " (:stderr rt)))

         ;; I am in my home repository
         ;; how can use `ssh` to get a result
         ;; while being in a repository ?
         (let [rt (ssh "pwd")]
             (println "status " (:status rt))
             (println "stdout " (:stdout rt))
             (println "stderr " (:stderr rt))))))

I am confused by the rules of the paths. I expected all calls inside cd to have the same path. Also, how can I get the result of "git rev-parse --abbrev-ref HEAD" in the right folder ?

Alright I got it working, but I'm not sure why I had to nest those ssh and run macros. Also, I expected the tasks to be able to return values like normal functions, and that's not what I get.
(deftask :git-status []
  (ssh (run
         (let [st (ssh (cd (:path @config)
                           (run "git status")))]
           (println "status " (:status st))
           (println "stdout " (:stdout st))
           (println "stderr " (:stderr st))
           st  ;; this doesn't work
           ))))

The last line, was to return a value (in this case : {:stdout "master\n", :stderr "", :status 0}).
The result I get instead :
  (println "RETURNS " (call :git-branch))
  ;; RETURNS  {:stdout , :stderr zsh:1: command not found: :branch
  ;; , :status 127}

For now I am using an atom to store the results, but this is less than ideal.


Crash when using someviewinsidestack.hidden = true

I'm getting a crash when I'm trying to hide some of my views from the stack. I tried to remove two different views from my stack, one that doesn't have constraints inside, and another that does. The first one hides normally, the second one causes my application to crash. I'm using SnapKit to set contraints and I'm still using Swift 1.2.
I don't have time to provide more details now. Later today I'm going to try to reproduce this error in the demo app, then I post an update.
Thanks.

What version of TZStackView are you using? And can you send me a report of the crash?

I'm using the 1.0.0 version.
I created a repository with the code that reproduces the issue: https://github.com/GlaucoNeves/TZStackViewIssue
I also tried the same code in Xcode 7 using the UIStackView and worked fine.

@GlaucoNeves I was seeing a similar issue due to AutoLayout constraint errors/conflicts when hiding an auto-height view with top and bottom constraints relative its subviews. I worked around this issue by storing a reference to the bottom layout constraint, then removing or adding it based on the view's hidden value:
override var hidden: Bool {
	didSet {
		// need to remove bottom constraint for auto-height layout else we'll get AutoLayout errors
		if let constraint = bottomLayoutConstraint {
			if hidden {
				removeConstraint(constraint)
			} else {
				addConstraint(constraint)
			}
		}
	}
}


Generated code doesn't use fully qualified syntax leading to unexpected behaviour of derived trait impls

Describe the bug
For the Clone trait (I haven't tried other traits), derivative will impl Clone on a type even if one of its members doesn't and instead just has a function called clone() that matches the interface.
This also means if the members where to impl Clone and have a separate clone function, then the derivative impl would not call, Clone::clone but the Members::clone.
To Reproduce
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e357412d7e9b32c3aef52fb4b4b8a7a4
use derivative; // 2.2.0

struct DoesNotImplClone {}
impl DoesNotImplClone {
    fn clone(&self) -> Self {
        Self {}
    }
}

// Works, but I would expect it to fail
#[derive(derivative::Derivative)]
#[derivative(Clone)]
struct Derivative {x: DoesNotImplClone}

// Fails as expected
//
// #[derive(Clone)]
// struct Derive {x: DoesNotImplClone}

fn main() {}

Expected behavior
I would expect the derived trait's impl to always use the struct/enum member's impls of that derived trait (and if they don't impl the trait fail to compile). And to importantly never call functions that just happen to have the same interface, as the trait.
Version (please complete the following information):
stable 1.69.0 (See Playground), derivative 2.2.0
I've also tried this locally:
rustup --version: rustup 1.25.2 (fae52a197 2023-02-01)
cargo --version: cargo 1.65.0-nightly (4fd148c47 2022-08-03)
rustc --version: rustc 1.65.0-nightly (d394408fb 2022-08-07)

Version of derivative: 2.2.0

This (using arg.clone() instead of UFCS core::Clone::clone(arg)) is also the cause of issues like #90
A workaround is to make the expansion use UFCS via clone_with. In OP's case this means struct Derivative { #[derivative(Clone(clone_with = "Clone::clone"))] x: DoesNotImplClone }


esp_intr_free(): core could change after call to esp_cpu_get_core_id() (IDFGH-11480)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
The function esp_intr_free() in components/esp_hw_support/intr_alloc.c on line 703 does this:
//Assign this routine to the core where this interrupt is allocated on.
if (handle->vector_desc->cpu != esp_cpu_get_core_id()) {
    esp_err_t ret = esp_ipc_call_blocking(handle->vector_desc->cpu, &esp_intr_free_cb, (void *)handle);
    return ret == ESP_OK ? ESP_OK : ESP_FAIL;
}

If this routine is run on a task that has no core affinity, the scheduler could move it to the other core after esp_cpu_get_core_id() got called. The call to esp_ipc_call_blocking() should therefore be made unconditionally, but at least in all cases in which the current task has no affinity.

Thanks for reporting this, this indeed seems like a potential issue.
We'll investigate it.

Hi @gralpli!
Thanks for reporting it. I created a fix for it. I am wondering how this issue affects the system. Did you get an error message?
This would be useful to share an error log (or incorrect behavior that you observed) for people who encounter the same problem.

I did not get an error message, I spotted it by reading the source code.


Please check the json its all correct

{
"symbol": "CAN",
"address": "0x917FD2f7378FF479419dCB56C5cbB445fBbF902A",
"overview": {
"en": "Coinwaycoin(CAN) is an ERC20 Crypto for the marketing industrial purpose with well known ideas & business development management teams IEO coming on p2pb2b exchange.",
"zh": "Coinwaycoin（CAN）是一种ERC20加密货币，用于工业营销目的，拥有知名的想法和业务开发管理团队，IEO即将在p2pb2b交易平台上进行交易"
},
"email"<EMAIL_ADDRESS>"website": "https://coinwaycan.com/",
"whitepaper": "https://coinwaycan.com/wp-content/uploads/2020/09/coinwaycan.pdf",
"state": "NORMAL",
"published_on": "2020-09-11",
"initial_price": {
"ETH": "0.0001 ETH",
"USD": "0.03 USD",
"BTC": "0.0000037 BTC"
},
"links": {
"blog": "https://www.altcoinstalks.com/index.php?topic=172017.0",
"twitter": "https://twitter.com/COINWAYCAN",
"telegram": "https://t.me/joinchat/CANOFFICIALGROUP",
"github": "https://github.com/coinwaycan",
"facebook": "https://www.facebook.com/coinwaygroups",
"reddit": "https://www.reddit.com/r/Coinway-official/"
}
}

https://github.com/consenlabs/token-profile/pull/6374 submitted a new on plese add the logo & details


Expose CheckDependentModules as configurable flag / Destroy in big repos takes a very long time

Describe the enhancement
CheckDependentModules should be configurable.
Additional context
Destroy in some cases, like in big repositories, takes a very long time, even an hour or more, where it previously ran in a minute. Often there is no reason to check for dependent modules so this should be at least configurable, if it's true by default.
I don't think there would be any negative implications with this change, as if not explicitly set, the behavior would remain the same as it is now.
It started with version #299, v0.33.0 and introduction of CheckDependentModules.
Workaroud since then was to run terragrunt apply -destroy instead of terragrunt destroy.
Since #3011, v0.56.5, the only remaining workaround, afaik is terragrunt plan -destroy -out outfile.
Regarding level of effort, it's probably low.

[x] Changes required.
[x] Implications of the feature.
[x] Alternatives considered.
[x] Level of effort.

RFC Not Needed

[x] I have evaluated the complexity of this enhancement, and I believe it does not require an RFC.

Released in v0.68.8


Fill in existing stubbed  implementations

Related to the ActionHandler for component::dex

@zbuc Is this ticket still useful? Can you expand in the OP what the goal here is?

Folding into #1724


Confusing variable names in unit test assertions

I am spending time debugging the unit tests for #2582 and I have found that the way the variables are named is confusing...
For example in Overlays size in pixels we have the following:
Util.assessNumericValue(assert, actPosition.left, expPosition.x, epsilon,
                "X position mismatch " + contextMessage);

If you follow the test back to it's declaration the args for act and exp are reversed...
assessNumericValue: function ( assert, value1, value2, variance, message ) {
            assert.ok( Util.equalsWithVariance( value1, value2, variance ), message + " Expected:" + value1 + " Found: " + value2 + " Variance: " + variance );
        }

I suggest this be refactored and these brought in line to make it less confusing to work with unit tests...
E.g. Found renamed to Actual and swapped with Expected

Oh man... Good catch! Definitely would be good to clean up.

This is a one line change I think.
Something like:
     assert.ok( Util.equalsWithVariance( value1, value2, variance ), message + " Actual:" + value1+ " Expected: " + value2+ " Variance: " + variance );

Sounds right. Just need to also check every place that calls it to make sure it's lined up properly.

hey friends i opened a PR for this. checked all references of that test too. hope this helps.

@ATH42 is work on this issue complete?


append() method using dynamically resized arrays

This has come up a few times recently, e.g., on StackOverflow.
We could implement efficient append()/extend() methods with something like the following strategy:

Write a ResizableArray duck array class, that stores its data in a continuous numpy array, which allows for appending along its first (outer-most) dimension and is resized every time an exponentially growing size threshold is exceeded using standard methods for dynamically resized arrays. TensorFlow's streaming_concat is a good example of the right logic.  This class would expose a duck array interface suitable for use in xarray (e.g., similar to xarray.core.indexing.CopyOnWriteArray), along with .append and extend methods that handle numpy arrays.

Write a ResizableVariable subclass of Variable that stores its data in a ResizableArray. It works like a Variable but adds append and extend methods.

Write a ResizableDataset subclass of Dataset that uses ResizableVariable instead of Variable objects and has an additional argument for specifying the "resizable" dimension. All variables put in a ResizableDataset that use the resizable dimension must have it as their first dimension, and you cannot make an index along this dimension, because pandas.Index cannot be efficiently resized. Operations other than append/extend on a ResizableDataset return a normal Dataset.

The end user API could look something like this:
ds = xarray.ResizableDataset(dim='example')
for example_ds in ...:
   ds.append(example_ds)

One consideration for whether this is actually worth doing is if there are common workflows that make use of intermediate accumulated datasets (maybe trailing window operations?).

Would this also somehow be related to unlimited dims and appending to an existing netCDF file?
Something like:
ds = xarray.ResizableDataset(dim='example')
ds.to_file('file.nc')
for example_ds in ...:
   ds.append(example_ds)
   ds.flush()  # the data exists on disk but not on memory any more

Writing up this proposal was actually enough for me to realize that this is probably not a good idea. There just aren't many use cases for this:

Either you don't care about the speed, and you happily write xarray.concat in a loop.
 The only operations that really make sense are trailing window operations, which you might as well do calling something like xarray.concat(list_of_datasets[-10:], dim='example') to construct the trailing window dataset from scratch.

Would this also somehow be related to unlimited dims and appending to an existing netCDF file?

Yes, it's sort of a similar idea. But honestly, I think this use case would be better served by a keyword argument on to_netcdf, e.g., ds.to_netcdf('file.nc', extend='example') extends file.nc along the "example" dimension, or creates a new file with "example" as an unlimited dimension.


Allow koji-client to access docker socket

This is required to run integration tests in container

What operations exactly require this?

Some integration tests require pulling built images. It would be nice to make it optional, but I can't come up with nice way of doing that


Configure Azure Properties

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: KrishnaMukhirala sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Unable to switch kernel from iTorch to iPython

Hi,
I have iTorch installed and, for some reason, this is the default kernel when I open a notebook in jupyter lab. When I try to switch over to iPython using Notebook > Switch kernel > Python, the kernel stays in iTorch. I hope I don't have to uninstall iTorch.

It does seem to work in the console, however.

Hi @Feynman27, I have several kernels installed, and I am able to switch between them in the notebook, so it should work.  Can you please try saving a notebook with the Python kernel using the "classic" notebook jupyter notebook, and then opening that file in JupyterLab and see if it opens with the Python kernel?

Hi @blink1073 Yes, opening a notebook saved from the classic notebook works just fine when I open it in jupyter lab.

Hmm, this is a tough one to debug ;).  Can you please try jupyter lab --debug, open a new notebook, and look for Kernel args: {'kernel_name': '<name>', 'cwd': '<cwd>'}, and also for Received kernel info: ... (to see which kernels these are).  You may end up with two of these statements depending on what is going on.

I can't seem to find Kernel args or kernel info in the output. I do see that two kernels are detected though. I've pasted it below:
thomas@thomas-ThinkPad-W540:~$ jupyter lab --debug

[D 07:39:56.394 LabApp] Searching [u'/home/thomas', '/home/thomas/.jupyter', '/home/thomas/anaconda2/etc/jupyter', '/usr/local/etc/jupyter', '/etc/jupyter'] for config files
[D 07:39:56.394 LabApp] Looking for jupyter_config in /etc/jupyter
[D 07:39:56.395 LabApp] Looking for jupyter_config in /usr/local/etc/jupyter
[D 07:39:56.410 LabApp] Looking for jupyter_config in /home/thomas/anaconda2/etc/jupyter
[D 07:39:56.426 LabApp] Looking for jupyter_config in /home/thomas/.jupyter
[D 07:39:56.426 LabApp] Looking for jupyter_config in /home/thomas
[D 07:39:56.427 LabApp] Looking for jupyter_notebook_config in /etc/jupyter
[D 07:39:56.427 LabApp] Looking for jupyter_notebook_config in /usr/local/etc/jupyter
[D 07:39:56.427 LabApp] Looking for jupyter_notebook_config in /home/thomas/anaconda2/etc/jupyter
[W 07:39:56.440 LabApp] Unrecognized JSON config file version, assuming version 1
[D 07:39:56.440 LabApp] Loaded config file: /home/thomas/anaconda2/etc/jupyter/jupyter_notebook_config.json
[D 07:39:56.475 LabApp] Looking for jupyter_notebook_config in /home/thomas/.jupyter
[W 07:39:56.501 LabApp] Unrecognized JSON config file version, assuming version 1
[D 07:39:56.501 LabApp] Loaded config file: /home/thomas/.jupyter/jupyter_notebook_config.json
[D 07:39:56.502 LabApp] Looking for jupyter_notebook_config in /home/thomas
[D 07:39:57.130 LabApp] Found kernel itorch in /home/thomas/.local/share/jupyter/kernels
[D 07:39:57.661 LabApp] Native kernel (python2) available from /home/thomas/anaconda2/lib/python2.7/site-packages/ipykernel/resources
[I 07:39:58.513 LabApp] [nb_conda_kernels] enabled, 2 kernels found
[D 07:39:58.513 LabApp]
    - itorch: /home/thomas/.local/share/jupyter/kernels/itorch
        - Python [Root]: /home/thomas/anaconda2/bin/python
        [I 07:39:58.554 LabApp] Writing notebook server cookie secret to /run/user/1000/jupyter/notebook_cookie_secret
        [I 07:39:58.708 LabApp] Pre-alpha version of JupyterLab extension loaded from /home/thomas/jupyterlab/jupyterlab
        [I 07:39:58.734 LabApp] Serving notebooks from local directory: /home/thomas
        [I 07:39:58.734 LabApp] 0 active kernels
        [I 07:39:58.734 LabApp] The Jupyter Notebook is running at: http://localhost:8888/
        [I 07:39:58.734 LabApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
        [D 07:40:00.020 LabApp] Using contents: services/contents
        Created new window in existing browser session.

There is a conda issue about this: https://github.com/conda/conda/issues/3094
The Conda folks are aware of it and working on a fix.

@blink1073 Ah, my apologies. Here is the output you requested:
[D 13:52:09.665 LabApp] Kernel args: {'kernel_name': u'Python [Root]', 'cwd': u'/home/thomas/Sandbox/h2o-tutorials/h2o-open-tour-2016/chicago'}
[D 13:52:10.431 LabApp] Received kernel info: {u'language_info': {u'mimetype': u'text/x-python', u'nbconvert_exporter': u'python', u'name': u'python', u'pygments_lexer':            u'ipython2', u'version': u'2.7.12', u'file_extension': u'.py', u'codemirror_mode': {u'version': 2, u'name': u'ipython'}}, u'implementation': u'ipython', u'implementation_version': u'4.2.   0', u'protocol_version': u'5.0', u'banner': u'Python 2.7.12 |Anaconda 4.1.1 (64-bit)| (default, Jul
        2 2016, 17:42:40) \nType "copyright", "credits" or "license" for more information.\n\nIPython 4.2.0 -- An enhanced Interactive Python.\n?         -> Introduction and overview of    IPython\'s features.\n%quickref -> Quick reference.\nhelp      -> Python\'s own help system.\nobject?   -> Details about \'object\', use \'object??\' for extra details.\n', u'help_links':  [{u'url': u'http://docs.python.org/2.7', u'text': u'Python'}, {u'url':
        u'http://ipython.org/documentation.html', u'text': u'IPython'}, {u'url': u'http://docs.scipy.org/doc/numpy/reference/', u'text': u'NumPy'}, {u'url': u'http://docs.scipy.org/doc/    scipy/reference/', u'text': u'SciPy'}, {u'url': u'http://matplotlib.org/contents.html', u'text': u'Matplotlib'}, {u'url': u'http://docs.sympy.org/latest/index.html', u'text': u'SymPy'},    {u'url': u'http://pandas.pydata.org/pandas-docs/stable/', u'text': u'pandas'}]}

@Feynman27  We've released versions of nb_conda, nb_conda_kernels and nb_anacondacloud through the official Anaconda conda repos that should resolve the issues you are seeing!
conda update nb_conda nb_conda_kernels nb_anacondacloud

As-installed kernel names that are eligible for being default (e.g. python2, python3, ir, etc.) will be maintained unmodified, so they should always appear there.
The downside is as many as three options for the current env, i.e. if you are in root, you will see Python 2 and Python [root] and Python [default], you can now reproducibly capture which environment your kernel should run against.
meta: https://github.com/Anaconda-Platform/anaconda-nb-extensions/issues/166

Great. It seems to be working!

Awesome, @blink1073 or @afshin, can you close this one? Thanks!


Bundler silently fails to install gems when gemspec and lock file versions differ

If I update the version in my gems gemspec file but forget to run bundle update to update Gemfile.lock, when I run bundle install it fails to install gems without notice. For example:
$ bundle install
Fetching gem metadata from https://rubygems.org/
Fetching version metadata from https://rubygems.org/
Fetching dependency metadata from https://rubygems.org/
Resolving dependencies.....
Installing rake 11.1.2
Installing CFPropertyList 2.2.8
Installing i18n 0.7.0
Installing json 1.8.3 with native extensions
Installing minitest 5.9.0
Installing thread_safe 0.3.5
Installing addressable 2.3.8
Installing archive-tar-minitar 0.5.2
Installing cabin 0.8.1
Installing ffi 1.9.10 with native extensions
Installing contracts 0.14.0
Installing builder 3.2.2
Installing gherkin 3.2.0
Installing cucumber-wire 0.0.1
Installing diff-lcs 1.2.5
Installing multi_json 1.12.1
Installing multi_test 0.1.2
Installing rspec-support 3.4.1
Installing thor 0.19.1
Installing ast 2.3.0
Installing encryptor 3.0.0
Installing mini_portile2 2.1.0
Installing pkg-config 1.1.7
Installing lru_redux 0.8.4
Installing jmespath 1.3.0
Installing ice_nine 0.11.2
Installing backports 3.6.8
Using bundler 1.12.5
Installing clamp 1.0.0
Installing colorize 0.7.7
Installing excon 0.51.0
Installing multipart-post 2.0.0
Installing little-plugger 1.1.4
Installing retriable 2.1.0
Installing hashie 3.4.4
Installing multi_xml 0.5.5
Installing rack 2.0.1
Installing equalizer 0.0.11
Installing mysql2 0.4.4 with native extensions
Installing puma 3.6.0 with native extensions
Installing iso8601 0.9.1
Installing statsd-ruby 1.3.0
Using systemd-daemon 0.1.0 from https://github.com/pdrakeweb/systemd-daemon.git (at wip@4462346)
Installing highline 1.7.8
Installing rotp 2.1.2
Installing semantic 1.4.1
Installing github-markup 1.4.0
Installing redcarpet 3.3.4 with native extensions
Installing coderay 1.1.1
Installing thrift <IP_ADDRESS> with native extensions
Installing docile 1.1.5
Installing facter 2.4.6
Installing insist 1.0.0
Installing mustache 0.99.8
Installing stud 0.0.22
Installing io-like 0.3.0
Installing net-http-persistent 2.9.4
Installing net-http-pipeline 1.0.1
Installing git 1.3.0
Installing json_pure 2.0.1
Installing minitar 0.5.4
Installing semantic_puppet 0.1.1
Installing rsync 1.0.9
Installing method_source 0.8.2
Installing parallel 1.9.0
Installing powerpack 0.1.1
Installing slop 3.6.0
Installing websocket 1.2.3
Installing rainbow 2.1.0
Installing ruby-progressbar 1.8.1
Installing unicode-display_width 1.0.5
Using sequel 4.35.0 from git@github.com:jeremyevans/sequel.git (at d2f6b69@d2f6b69)
Installing simplecov-html 0.10.0
Installing sqlite3 1.3.11 with native extensions
Installing yard <IP_ADDRESS>
Installing bugsnag 2.8.13
Installing tzinfo 1.2.2
Installing descendants_tracker 0.0.4
Installing json-schema 2.5.2
Installing launchy 2.4.3
Installing arr-pm 0.0.10
Installing childprocess 0.5.9
Installing ethon 0.9.0
Installing cucumber-core 1.4.0
Installing rspec-expectations 3.4.0
Installing rspec-core 3.4.4
Installing rspec-mocks 3.4.1
Installing librarianp 0.6.3
Installing parser <IP_ADDRESS>
Installing attr_encrypted 3.0.1
Installing nokogiri 1.6.8 with native extensions
Installing aws-sdk-core 2.2.37
Installing faraday 0.9.2
Installing logging 2.1.0

$ bundle exec rake -T
Could not find activesupport-4.2.7 in any of the sources
Run `bundle install` to install missing gems.

I would expect bundler to error when encountering a version mismatch, rather than continuing to install some gems.

Thanks for reporting this! It sounds like a bug. Could you please provide a list of commands we can run (or a repo we can check out) that will allow us to reproduce this bug so that we can fix it?

ping @jamesiarmes

Thanks for reporting this! It sounds like a bug. Could you please provide a list of commands we can run (or a repo we can check out) that will allow us to reproduce this bug so that we can fix it?

The project that I've encountered this in is private. I'll try to create a Gemfile without private repos that I can post.

Its possible this is related to https://github.com/bundler/bundler/issues/5264 ?

ping @jamesiarmes

Closing, presuming fixed by https://github.com/bundler/bundler/issues/5266


Fails when Yubikey NEO has all modes enabled

Hi,
New Yubikey NEO with all modes enabled (-m86 (OTP/U2F/CCID composite device))

'''
python yubicoauthenticator/yubico_authenticator.py
'NoneType' object has no attribute '_cmd_ok'
No smartcard reader found with YubiOath applet
'''
-=david=-

I'm getting this too. When does it work? What mode do you have to disable?

Hi,
I haven't revisited this since I created the initial report. Perhaps it's still broken? I've moved on from it worrying about it :-)
-=david=-

I'm running LinuxMint 17.1 xfce 64-bit and I'm getting this error.  Was there a solution to this error?

I think the U2F module is the problem. It still works on Windows. See #22 for a more detailed description of the issue.

Same issue happening on OSX (Mavericks) with a new NEO I just got. U2F is enabled by default in it.

@dainnilsson
Any advice here? Seems like the project is far for abandoned despite being unusable for a number of people...

I was able to get this working (LinuxMint 17.1 and Xubuntu 15.04) by doing the following:

YubiKey Setup and Configuration:

Yubikey Authenticator:

Clone the git repository on Github:

git clone https://github.com/Yubico/yubioath-desktop.git

Open Software Manager, search for 'libccid' and install it.
Patch the info.plist:

sudo sh -c 'wget -q -O - https://raw.githubusercontent.com/Yubico/yubikey-neo-manager/master/resources/linux-fix-ccid-udev | python'

Install all dependency packages:

sudo apt-get install pcscd python-pyscard python-pbkdf2 python-pyside.qtgui

Yubikey Desktop applications:

Add Yubico PPA to PPA sources:

Reference: https://launchpad.net/~yubico/+archive/ubuntu/stable?field.series_filter=trusty
In Update Manager
Edit...Software sources
Select PPAs button
Add 'ppa:yubico/stable'

Alternative way: sudo add-apt-repository ppa:yubico/stable

sudo apt-get update
sudo apt-get install ykneomgr
sudo apt-get install yubikey-neo-manager
sudo apt-get install yubikey-personalization
sudo apt-get install yubikey-personalization-gui

Google U2F (Chrome, etc...) [This isn't needed after patching info.plist from above]

References:

https://www.youtube.com/watch?v=nz6sYGQtP4I
https://www.yubico.com/faq/enable-u2f-linux/
https://github.com/Yubico/libu2f-host/blob/master/70-u2f.rules

Create file: /etc/udev/rules.d/70-u2f.rules

sudo nano /etc/udev/rules.d/70-u2f.rules
Paste in the content from 3rd link above and save.

This was all gathered from my post in the Yubico forums: http://forum.yubico.com/viewtopic.php?f=26&t=1727
Hope that helps.

@ViViDboarder Advice? Sure. I suggest you sit tight for a few more days. As I assume you were referring to, there's been a lot of activity with this project over the past month or so: I've taken over ownership of the project and have been re-writing it from scratch with the goal of improving the user experience as well as adding support for TOTP using the YubiKey standards slot based challenge response mode. This has yet to result in a new release, but is very close now. The latest release for this project, 0.1.1, is more than a year old, and all open issues are targetting that version. I'll be closing all open issues once the new release is out (2.0.0).
For this particular issue, it does sound like the problem is with your libccid configuration, and the instructions provided in this thread (or in the README or this project) should help you get past it. This will be required for the new version as well.

Great! Thanks for the status update. I hope can understand my uncertainty
when I see commit activity with no communication after quite a while. I'm
glad that you're working towards a 2.0.
Does the package installer not automatically patch this? I figured it would
be one of the install steps. I'll run the script and see if that fixes it
and wait until the next release before opening new tickets.

The new version is out. @ViViDboarder what OS are you using? The installer for OS X should run the patch for you. You can verify by looking at the file: /usr/libexec/SmartCardServices/drivers/ifd-ccid.bundle/Contents/Info.plist
If correctly patched it should contain entries for all combinations of modes for the YubiKey NEO, such as U2F+CCID, OTP+U2F+CCID, etc.

@dainnilsson To install the newest version on linux (ubuntu), simply use the ppa?  Does it take a bit to get populated or something because I added the ppa but when I go to install yubioath-desktop its saying "Unable to locate package yubioath-desktop".
I added: ppa:yubico/stable

@drohm The PPA release juuuuuuust finished building, and will take a few minutes before it becomes available. It should be enough to just wait for a while. You can check on the status here: https://launchpad.net/~yubico/+archive/ubuntu/stable/+packages?batch=75&memo=75&start=75
Once the package has a green checkbox you should be good to go, just do an apt-get update first!

@dainnilsson Excellent, just got it.  Well done on the new release, looks great and works very well.

@dainnilsson awesome! Thanks! Just ran the installer on my Mac (10.10.3) and it still won't recognize my key.
I checked and I can find the following in /usr/libexec/SmartCardServices/drivers/ifd-ccid.bundle/Contents/Info.plist.
<string>Yubico Yubikey 4 OTP+U2F+CCID</string>
<string>Yubico Yubikey 4 U2F+CCID</string>
<string>Yubico Yubikey 4 OTP+CCID</string>
<string>Yubico Yubikey 4 CCID</string>
<string>Yubico Yubikey NEO OTP+U2F+CCID</string>
<string>Yubico Yubikey NEO U2F+CCID</string>

Thoughts?

Decided to reboot my computer and that solved it! Looks great!
:+1: @dainnilsson

Per default only those entries are in /etc/libccid_Info.plist:
<string>Yubico Yubikey NEO OTP+CCID</string>
<string>Yubico Yubikey NEO CCID</string>

Well this should be the reason why it stopped working after activating U2F.
yubioath (the gui) still show that I have to insert the yubikey NEO. But yubioath-cliand the old v0.1.1 gui are now working. Therefore this seems to be another not related bug  ....

@ViViDboarder Great, I'll make a note of that in the README!
@raabf Strange that it's working with yubioath-cli but not the GUI. Perhaps this is related to #26? As you say, since it's working with the CLI tool it doesn't sound like an issue with the libccid configuration.

@raabf Ok, so not related to #26. It seems very strange that it's working for the CLI tool but not the GUI. Does it work in any of the modes (pure CCID for example)?

I do the following:

delete both slots (they was password protected)
Only enable CCID -> yubioath gui works afterwards
enable all modes again -> yubioath gui works afterwards
set static password and challange respond to the slots (no password protection) -> yubioath gui works afterwards
set static password and challange respond to the slots (password protection). My yubikey neo is now in the same state as is was before step1 (my original configuration)  -> yubioath gui works afterwards

Actually it works. strange ... :confused:

Strange... But seeing that it works now I'll close this issue. Please open a new one if you have further issues.

Yea do that :-) . Maybe I have more information, if it ever happens again.


DependencyCheck uses deprecated commons-lang3 classes

I spotted in a mvn clean install
[WARNING] /Users/aikebah/NetBeansProjects/DependencyCheck/core/src/main/java/org/owasp/dependencycheck/reporting/ReportGenerator.java:[38,37] org.apache.commons.lang3.text.WordUtils in org.apache.commons.lang3.text has been deprecated
Looking up the commons-lang text package APIdocs I found that the classes involved have moved to a new Apache commons project: Commons Text.
https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/text/package-summary.html
For the sake of forward stability we should adapt the code to this new project.
I'll work on a PR for this

Thanks for the PR!


how to define target modules in the Qlora script

How do you use all linear layers with LoRA adapters? like q_proj, k_proj, v_proj, o_proj, w1, w2, w3, and lm_head. and what are the layers that are finetuned with the current QLoRA script?

ok understood. thanks


Weird behavior using tf.Variable in a tf.data.experimental.map_and_batch callback function

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): 1.13.1 from conda
TensorFlow version (use command below): 1.13.1
Python version: 3.7.3
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Code to reproduce the issue
import tensorflow as tf

def foo(x):
    array = tf.Variable(lambda: tf.zeros(20, dtype=tf.float32),
            trainable=False, use_resource=True)
    ind = tf.reshape(x, [-1, 1])
    val = tf.reshape(tf.cast(x, tf.float32), [-1])

    array_assign = array.assign(tf.zeros_like(array))
    with tf.control_dependencies([array_assign]):
        array = array.scatter_nd_update(ind, tf.cast(val, dtype=tf.float32))

    return array

dataset = tf.data.Dataset.range(20)
# dataset = dataset.map(foo)
# dataset = dataset.batch(5)
dataset = dataset.apply(
        tf.data.experimental.map_and_batch(foo, 5, num_parallel_batches=1))

iterator = dataset.make_initializable_iterator()

with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())
    sess.run(iterator.initializer)
    next_element = iterator.get_next()
    fetches = sess.run(next_element)
    print(fetches)

Describe the current behavior
If using normal map and batch, one get
[[0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 2. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 3. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]]

Describe the expected behavior
If using map_and_batch, one get changing results like:
[[0. 1. 2. 3. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 1. 0. 0. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 1. 2. 3. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 1. 2. 3. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 1. 0. 0. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]]

There should be always only one and non-duplicate non-zeros per-line.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Not sure if this is related to #27507 . On a Colab with tf-nightly, #27507 seems fixed but this issue still reproduces.

@prclibo I got the following result
WARNING:tensorflow:From /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/resource_variable_ops.py:435: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version.
Instructions for updating:
Colocations handled automatically by placer.
[[0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 2. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 0. 3. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 0. 0. 4. 5. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]]
Could you try to run it in Google colab or upgrade your TF1.13.1 and run it. Please let me know how it progresses. Thanks!

@jvishnuvardhan No, on the above colab (https://colab.research.google.com/drive/1DzTvOJRXYUk0CSjvGa11ewmjTP7VJ1kF) the issue still reproduces, with updated tf-nightly version:

Successfully installed google-pasta-0.1.5 tb-nightly-1.14.0a20190423 tf-estimator-nightly-1.14.0.dev2019042301 tf-nightly-1.14.1.dev20190423 wrapt-1.11.1

Which version are you using?

@prclibo I had used TF1.13.1 as you mentioned TF1.13.1 in your issue template.
I just tried TF-nightly and the output is as follows
W0424 01:48:58.248569<PHONE_NUMBER>98592 deprecation.py:323] From :19: map_and_batch (from tensorflow.python.data.experimental.ops.batching) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.data.Dataset.map(map_func, num_parallel_calls) followed by tf.data.Dataset.batch(batch_size, drop_remainder). Static tf.data optimizations will take care of using the fused implementation.
[[0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 2. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 0. 3. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 2. 0. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]]
The result is not what is expected but the map_and_batch is going to be deprecated (check the warning above). The suggested op is map followed by batch which is working well in tf-nightly.  What is the point in using deprecated op when you have better working ops that replaced the deprecated op. Please let me know what you think. Thanks!

@jvishnuvardhan Thanks for the tests. However I still reproduce it with separate map and batch in 1.14.1-dev20190423 (!pip install tf-nightly). See the last cell in https://colab.research.google.com/drive/1DzTvOJRXYUk0CSjvGa11ewmjTP7VJ1kF
Maybe you can share a successful Colab?

@prclibo I have changed one line in your code
dataset = dataset.map(foo, num_parallel_calls=1)
This is the output I get
[[0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 2. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 0. 3. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
[0. 0. 0. 0. 4. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]]
Here is the gist. Thanks!

@jvishnuvardhan thanks, but setting num_parallel_calls=1 does not really solve the issue, right?
I would expect that when num_parallel_calls > 1 each line in its output has only one element scattered and the element is different from each other lines. The order of line can be permuted or not depending on the threading implementation. But the issue is not solved for num_parallel_calls > 1 right now.

The behavior you see if expected because your foo function is using shared state -- the array variable will be shared by all invocations of the foo function because that's how resource variables in TensorFlow work. Furthermore, map_and_batch with num_parallel_batches with perform concurrent invocations of foo. That means that you will have multiple instances of foo all accessing (reading / writing) array at the same time, which explains the behavior you are seeing.
If you would like to achieve the "expected" behavior, use a constant instead of variable. As far as I can tell there is no good reason for you to need to be using a variable.

@jsimsa Thanks. The reason of using a variable is that I failed to use a constant tensor in a Dataset.map callback operated by scatter_nd_update. See the second cell in https://github.com/tensorflow/tensorflow/issues/11239#issuecomment-313784148
Doing scattering onto a constant tf.zeros(20) causes AttributeError: 'Tensor' object has no attribute '_lazy_read'. Is there any workaround to solve this?

You can achieve the desired the behavior using the following simpler program:
import tensorflow as tf

def foo(x):
  array = tf.one_hot(x, 20) * tf.cast(x, dtype=tf.float32)
  return array

dataset = tf.data.Dataset.range(20)
dataset = dataset.map(foo)
dataset = dataset.batch(5)

iterator = dataset.make_initializable_iterator()

with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())
    sess.run(iterator.initializer)
    next_element = iterator.get_next()
    fetches = sess.run(next_element)
    print(fetches)


Wrong alert on submit button in editor screen

Submit button in the editor screen doesn't work correctly.
When we register an editor screen without a parent browser screen after the form has been submitted alert wrong messages.
Submitting the form results in:

The same problem with #509.
Both depend on the callback goToParentScreen() without parentScreen, which have been fixed in #509.


Suggestion Add multi-language support

Not all of my Chinese players can speak English, I hope to add multi-language support, I am willing to contribute Chinese file
thank

I would love to support other languages, but the plugin is very poorly setup for translations and will be a big lift to get there


about the training time cost

First thank you for your excellent work. I have the question that how long did it take to train the model. I used the same GPU (Titan XP) as mentioned in the paper, and  it took me more than one day to train the model on the single subset "leather" on the MVTec dataset.
Can I do changes to accelerate my training?

I try to change the batch size since I find there's still a lot of memory room on GPU but facing some code error. It seems something in simplex noise code only support batchsize=1
I want to reduce the epoch which is now 3000 to 500 to reduce the training time, but I have no idea whether it will do harm to the final performance

Hi Henry
Due to time constraints when originally working on the project I wasn't able to fix those.
If you're able to increase the batch size, it should speed the model up; further 500 epochs should give good outputs but not necessarily perfect if memory serves.