AJAX multipart/form-data submission (possible bug?)

Hi all,
First, as this is my very first communication -- a massive thank you to Team Slim.  Your work is fantastic.
Anyway, I've been experiencing problems with making multipart/form-data submissions.
On my application, I have a "save" button.  Using AJAX, this submits multiple forms simultaneously to the server.  Anyway, these forms themselves contain a huge number of inputs (hundreds if not thousands), some of which are files.  Using the standard POST method this works fine, but as soon as I submit it with a simple bit of Javascript, it ceases to work:
    // hook up submit button
        document.getElementById('submit').addEventListener(
            'click',   // add a click event
            function (event) {
                var form = document.getElementById('mainForm');

                $.ajax({
                    url:            getAction(form), // returns "action" of form element = URI of page
                    type:           getMethod(form),  // returns "method" of form element = POST
                    data:           new FormData(form),
                    processData:    false,
                    contentType:    false,
                    success:    function (data) {
                        // do some more stuff here
                    }
                });
            }
        );

From this, I get the slim error
Argument 6 passed to {myFunction}() must be of the type array, null given, called in {file} on line {N}

Where that line is $request->getUploadedFiles().
If I do this:
var_dump($request->getUploadedFiles());
var_dump($request->getParsedBody()); exit;

It displays:
array(0) {
}
NULL

However, the request headers look fine to me:
Content-Type:multipart/form-data; boundary=----WebKitFormBoundaryToDWK3EjS5R9OV2T
.....

------WebKitFormBoundaryToDWK3EjS5R9OV2T
Content-Disposition: form-data; name="labNumber"

1234567489
------WebKitFormBoundaryToDWK3EjS5R9OV2T
Content-Disposition: form-data; name="hpo[HP_0000478][term]"

Individual has no ocular abnormality

[....]

------WebKitFormBoundaryToDWK3EjS5R9OV2T
Content-Disposition: form-data; name="labreport[files][1]"; filename="LF160 001 - Cellbank Referral Form.pdf"
Content-Type: application/pdf

Any ideas on how I can fix this in my application, OR if it's a bug in Slim3.  As before, the same form submitted without AJAX works fine.

Just noticed, this is only an issue when the form method is "PUT" - I changed it over to "POST" and it works fine with that!


Get rid of double deploy entry in Travis config file

http://stackoverflow.com/questions/36539398/deploying-different-files-based-on-build-os/ could work.

Worked with a test release.


Remove built-in notification system

This comes from before plugins like https://github.com/rcarriga/nvim-notify were popular. Instead of re-implementing their work, we can just use vim.notify().
@ten3roberts Any objection to dropping the home-made notifications?

My only question regarding this is how it behaves when the user does not use nvim-notify or noice. From what I recall, it will print in the command area, and testing now causes the dreaded Press ENTER or type command to continue if you do :lua vim.notify("Foo") vim.notify("Bar")

So, agreed, that would suck. But... that doesn't seem to happen? I disabled nvim-notify in my config, and the messages indeed do now print to the command area, but I'm not faced with a "hit-enter" prompt :shrug: The messages just print nicely. Maybe it's only an issue if the vim.notify() calls are very close together, which we're not really doing.

Hmm, it happens for me if I do vim.notify() twics in the same :lua command
From what I've read in the docs it happens if there are more than one messages in one redraw

Ah, ok, I think that won't be an issue then.

Oops, yeah, good looking out 😅


build: add turborepo

Closes #264

todo: fix graphql resoultions and add wait-on for dev scripts

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix(sec): upgrade github.com/containerd/containerd to 1.6.18

What happened？
There are 1 security vulnerabilities found in github.com/containerd/containerd v1.4.1

CVE-2023-25173

What did I do？
Upgrade github.com/containerd/containerd from v1.4.1 to 1.6.18 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
How can we automate the detection of these types of issues?
By using the GitHub Actions configurations provided by murphysec, we can conduct automatic code security checks in our CI pipeline.
The specification of the pull request
PR Specification from OSCS

Does this project need a maintainer?


CIF-1608 - Category Carousel Component

created generic carousel component
created category carousel component
adjusted product carousel and related products component to extend the generic carousel component
added unit tests

Related PRs:

https://github.com/adobe/aem-cif-guides-venia/pull/72
https://github.com/adobe/aem-project-archetype/pull/524

Related Issue
CIF-1608
How Has This Been Tested?
Unit tests, manual testing.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

@herzog31 , I've created follow-up issue for adding the new component to the component library examples and also to add IT which is based on the examples package.

I agree here with @herzog31 lets add ITs here. Yes the PR is already large but there is no need for a follow-up issue. We already have an issue ticket and tests should simply be part of it.

I've updated the examples project and added integration test for category carousel.


Refactoring: replace plan phases strings with const enums

Reference: https://github.com/kubev2v/forklift-console-plugin/pull/1395#discussion_r1861292874
Replace the PlanPhase strings with consts.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.21%. Comparing base (13484d0) to head (fe6bb35).
Report is 152 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   36.81%   36.21%   -0.60%
==========================================
  Files         158      159       +1
  Lines        2548     2579      +31
  Branches      599      600       +1
==========================================
- Hits          938      934       -4
- Misses       1428     1630     +202
+ Partials      182       15     -167

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: double margin

Description
order of the QMargins class differed from the old custom Margins class
Fixes #4838


feat: GCS Based Templates Should Support All SparkSQL CSV Options

This request changes all Python templates that read from or write to Cloud Storage to support all CSV options supported by Spark. Listed here: https://spark.apache.org/docs/latest/sql-data-sources-csv.html#data-source-option
Because I didn't want to add the same code in multiple places I've refactored all templates to use central functions for adding CSV options to dataframes.
Example change for reading from Cloud Storage
Previous code:
        input_data: DataFrame

        if input_file_format == constants.FORMAT_PRQT:
            input_data = spark.read \
                .parquet(input_file_location)
        elif input_file_format == constants.FORMAT_AVRO:
            input_data = spark.read \
                .format(constants.FORMAT_AVRO_EXTD) \
                .load(input_file_location)
        elif input_file_format == constants.FORMAT_CSV:
            input_data = spark.read \
                .format(constants.FORMAT_CSV) \
                .option(constants.HEADER, True) \
                .option(constants.INFER_SCHEMA, True) \
                .load(input_file_location)
        elif input_file_format == constants.FORMAT_JSON:
            input_data = spark.read \
                .json(input_file_location)

New code:
        spark_read_options = spark_options_from_template_args(args, constants.GCS_BT_INPUT_SPARK_OPTIONS)
        input_data = ingest_dataframe_from_cloud_storage(
            spark, input_file_format, input_file_location, spark_read_options
        )

And same technique for writing to Cloud Storage.
Previous code:

        if gcs_output_format == constants.FORMAT_PRQT:
            writer \
                .parquet(gcs_output_location)
        elif gcs_output_format == constants.FORMAT_AVRO:
            writer \
                .format(constants.FORMAT_AVRO) \
                .save(gcs_output_location)
        elif gcs_output_format == constants.FORMAT_CSV:
            writer \
                .option(constants.HEADER, True) \
                .csv(gcs_output_location)
        elif gcs_output_format == constants.FORMAT_JSON:
            writer \
                .json(gcs_output_location)

New code:
        spark_write_options = spark_options_from_template_args(args, constants.GCS_TO_GCS_OUTPUT_SPARK_OPTIONS)
        persist_dataframe_to_cloud_storage(writer, gcs_output_format, gcs_output_location, spark_write_options)

This removes a lot of duplication.
The Spark options themselves are driven by constants, see SPARK_OPTIONS.
The tmeplate options are also driven by constants mapping them back to Spark options, e.g: GCS_BQ_INPUT_SPARK_OPTIONS
After merging this I need to raise an equivalent issue for the Java templates.

please review optional parameters in readmes

@shashank-google , I've modified several READMEs to highlight new attributes as optional as requested.
Unit and integration tests have run cleanly.

@NiloFreitas I have created a new PR based on your suggested modifications on branch issue-532-csv-options-refactor.
When we are done with the other PR I'll delete this one.


Master

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-candidate@9dd8d45). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release-candidate     #231   +/-   ##
====================================================
  Coverage                     ?   99.95%
====================================================
  Files                        ?      116
  Lines                        ?     8117
  Branches                     ?        0
====================================================
  Hits                         ?     8113
  Misses                       ?        4
  Partials                     ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd8d45...b1855cf. Read the comment docs.


The logo is now clickable and takes you back to the home page.

Awesome, thanks Mohan for spotting this and @erose for making it happen!


There is a Bug in libcanard dsdl,Please check –BeginFirmwareUpdateRequest

There‘s a Bug in uavcan_protocol_file_BeginFirmwareUpdateRequest_decode_internal(…)
This Bug lead to a wrong decode struct.
line 89
// Compound
offset = uavcan_protocol_file_Path_decode_internal(transfer, 0, &dest->image_file_remote_path, dyn_arr_buf, offset);
The second actual parameter should not be ‘0’, It should be ‘payload_len’;
fix:
// Compound
offset = uavcan_protocol_file_Path_decode_internal(transfer, payload_len, &dest->image_file_remote_path, dyn_arr_buf, offset);

@aasmune how does it look to you?

After looking briefly at this, it looks to me that this bug affects decoding of all types (both messages and services) which contain at least one compound type. If this is the case, then the zero in this line should be changed to 'payload_len' https://github.com/UAVCAN/libcanard/blob/master/dsdl_compiler/libcanard_dsdl_compiler/code_type_template.tmpl#L320. Are you able to verify that this is the case @Cherish-Gww?


feat: Product card not found: ensure the content fits the screen

What

On small devices, the Product not found card may overflow the screen

Changes in this PR:

Include a FittedBox
Move the 3 Texts into a single RichText

Screenshot
(On an iPod Touch)

Will fix #2946

Oops you're right 🙈 it's now fixed.
Please let me a few minutes because the invalid barcode card also has problems.

I prefer to create a new PR, as this one is limited to one card


analytics

Type
Enhancement

Description

Integrated Google Tag Manager (noscript) in the main documentation layout.
Added Google Tag Manager script for enhanced analytics tracking.

Changes walkthrough
Relevant filesEnhancement

main.htmlIntegration of Google Tag Manager (noscript)

docs/overrides/main.html
Extends base.html for the main documentation layout.  Adds Google Tag Manager (noscript) integration.

+10/-0

custom.htmlImplementation of Google Tag Manager Script

docs/overrides/partials/integrations/analytics/custom.html

Implements Google Tag Manager script for analytics.

+7/-0

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/review auto_approve

Release Notes:

analytics
docs: Add "Improve Component" tool documentation and update related g…
refine help
docs: Refine project description and reorganize documentation links i…
Update github.md

Release Notes:

Replace checkmark emojis with tick emojis in documentation

Added docs for pr-agent-pro

Added ignore_bot_pr option

Update describe.md: Improve image formatting, restructure content, an…

Refactor review.md: Improve image formatting, restructure content, an…


RDP related crash

At home I have a PC with 3RVX installed. Every day I login to that PC thru RDP from work. 3RVX crashes when I login to that PC back at home.
The crash details from event log:
Faulting application name: 3RVX.exe, version: <IP_ADDRESS>, time stamp: 0x55fcf80a
Faulting module name: unknown, version: <IP_ADDRESS>, time stamp: 0x00000000
Exception code: 0xc0000005
Fault offset: 0x6220746f
Faulting process id: 0x2ec0
Faulting application start time: 0x01d153bd57fca884
Faulting application path: C:\Program Files (x86)\3RVX\3RVX.exe
Faulting module path: unknown
Report Id: b34df92d-c062-11e5-803b-005056c00008

Interesting, thanks for letting me know. I'll get RDP going on my test machine and see if I can reproduce the bug.

I believe this is related to #42, and I should have a fix ready fairly soon.

I've noticed that audio device changes from my Xonar DG to Remote Audio while RDP is active. Seems the crash somewhat related to that.


Changing splash screen and removing unused activity

Fixes issue https://github.com/fossasia/open-event-android/issues/1101

@heysadboy
The splash_logo.png that you have added can be compressed using a pngcrusher or some other tool.
Uncompressed images unnecessarily bloats the apk leading to huge apks (size wise).
Just a suggestion.

@free4murad Thanks for the suggestion. I already compressed it using https://kraken.io/ . But I'll see if it doesn't decreases the quality of the image.


Added a search bar

Fixes Issue🛠

Closes #174
Description👨💻
Added a search bar to search compnents.

Type of change📄

[X] New feature (non-breaking change which adds functionality)

How this has been tested✅
tested locally on my machine.

Checklist✅

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I am an Open Source Contributor

Screenshots/GIF📷

Pls add your search bar to the top of the components section page and not in the home page @pranjal12-web

Not done, you have to place this search bar at the top in the components section. When we click on Get Components button, then components section comes but search bar should come and below that the componentss!! @pranjal12-web

https://github.com/Rakesh9100/Beautiify/assets/67697534/6acf8419-fa8e-4885-9c13-c4ebff4ce7d5

@Rakesh9100 kindly check once as  when i am testing locally , i can see those required changes

Beautiify.-.Google.Chrome.2024-01-22.18-53-59.mp4

As you can see, search bar is coming in the home page which we don't want. It should come on the second page only when clicked on Get Components @pranjal12-web


Protocol osmand

Change the protocol to OsmAnd Live Tracking web address format

I have implemented OsmAnd protocol in the Traccar Client.


BUG: mktemp: too few X's in template 'gh-montage'

Haven't begun to debug yet, just opening the issue first
$ ./gh-montage -d hyperledger

+ getopts a:dfhm:p-: OPT
+ shift 1
+ '[' -z hyperledger ']'
+ [[ hyperledger == *\/* ]]
+ ORGANIZATION=hyperledger
+ '[' -z '' ']'
+ MONTAGEFILE=hyperledger-48.jpg
+ test -f hyperledger-48.jpg
++ mktemp -d -t gh-montage
mktemp: too few X's in template ‘gh-montage’
+ TMPDIR=

✨ thank you for the first issue and PR, @shmup !!!

For those curious, https://www.gnu.org/software/autogen/mktemp.html:

Usage: mktemp [OPTION]... [TEMPLATE]
Create a temporary file or directory, safely, and print its name.
TEMPLATE must contain at least 3 consecutive `X's in last component.
If TEMPLATE is not specified, use tmp.XXXXXXXXXX, and --tmpdir is implied.
Files are created u+rw, and directories u+rwx, minus umask restrictions.


Fix Use two-factor authentication code and Use recovery codes text blinks

Details

When pressing the text button to switch, the text blinks.
Fixed Issues

$ https://github.com/Expensify/App/issues/48712
PROPOSAL: https://github.com/Expensify/App/issues/48712#issuecomment-2336534467
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: 2FA is enabled

Log out
Enter your login and magic code
Press the Use two-factor authentication code/Use recovery codes multiple times to switch between those two text
Verify the text is not blinking

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/bdb5568e-d427-4cc6-b50f-6693848195a6

Android: mWeb Chrome

https://github.com/user-attachments/assets/c8b588c1-b06c-4e4d-a666-4dbdebbbb9af

iOS: Native

https://github.com/user-attachments/assets/39bebb30-0592-4ac6-8f65-e0bba2966f3d

iOS: mWeb Safari

https://github.com/user-attachments/assets/8bd222a5-9737-476a-998e-214628b83ffa

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/41978061-37c6-4f70-9d13-b85555c4503c

MacOS: Desktop

https://github.com/user-attachments/assets/0ca9f9b5-0fed-4914-86f1-5fce9d86b096

I got max request when trying to test on iOS mWeb.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/3fdbbb26-4bd9-48e8-b1b3-01742a57329c

Android: mWeb Chrome

https://github.com/user-attachments/assets/f1d120ce-9d05-42e9-82b7-5de6ed88e780

iOS: Native

https://github.com/user-attachments/assets/e39260d8-32ec-437e-a372-6f69a69954f4

iOS: mWeb Safari

https://github.com/user-attachments/assets/75a11e87-b743-45e6-bb20-4ffa8825f70f

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/039e1543-2ec9-42cc-aa70-2c774998db49

MacOS: Desktop

https://github.com/user-attachments/assets/d76caa7d-616a-407b-9db0-f08a9e8f7ea0

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Incident: OpenAI

The service "OpenAI" has been down since 2024-11-17T16:05:36.740Z (Downtime: 60.128 seconds).

This is a test


Cannot server StarCoder 2 with vllm/vllm-openai:v0.3.3 image?

Hi all,
When I was trying to test the newly released StarCoder2 model with 0.3.3, I noticed the following error being thrown:
ValueError: The checkpoint you are trying to load has model type `starcoder2` but Transformers does not recognize this architecture. This could be because of an issue with the checkpoint, or because your version of Transformers is out of date.
From my understanding this is due to transformers not releasing support for SC2 in the current released version but only in the master branch? Lmk if I am understanding correctly, and if so, is there anyway to fix the image? Thanks!

Maybe transformers >= 4.38.0  # Required for Gemma. from the requirements.txt is not enough?

@andyl98 Make sure your model name or path contain bigcode and starcoder2 string. And We will remove this temporary check after transformers support startcoder2.

Modify model_type in config.json to gpt_bigcode, and then it is ok.

local starcoder2 path is "/home/models/bigcode/startcoder2-15b/", the error occured:【ValueError: The checkpoint you are trying to load has model type starcoder2 but Transformers does not recognize this architecture. This could be because of an issue with the checkpoint, or because your version of Transformers is out of date.】

Actually this issue seems to happen in our CI right now

any updates?


Reaching out - Flexx

Hi,
Interesting project! I wanted to reach out because I am working on a similar approach to realize a "web-tech-based" GUI for Python. The project is called Flexx. It differs from htmlPy in that it hides almost all CSS/JS/HTML for the user. Users can write client-code in Python, which is transpiled to JavaScript. Also it targets multiple web runtimes (including Qt Webkit). I am not sure if/how your goals overlap with mine, but if they do maybe we can consider some colaboration?

Hi
Lets continue the discussion off the repository. My contact details are on my website. Please contact me on the means preferable to you.


Removing $ sign in code examples, so that copy/paste can be used. Add…

…ing missing datacenter argument
fixes bug https://github.com/scylladb/care-pet/issues/118#event-8148145361

@omrivardi can you review?


[QUESTION] - How to set different Read Timeout for http handlers and websocket handler

Describe the Question
By default hertz has 3 minutes of Read timeout which is fine. But I wanted to disable ReadTimeout for Websocket handler. Currently the websocket connection auto close with error Error connection read timeout.
Is it possible to disable or increase the Read Timeout for websocket handler.

https://www.cloudwego.io/zh/docs/hertz/tutorials/basic-feature/protocol/websocket/#setreadtimeoutsetwritetimeout


Add support for 'optional' keyword

Hello!
I added support for the 'optional' keyword in the proto3 syntax. While it works on my proto example, I am not used to programming in Go and didn't add relevant tests. Would you still be able to consider this PR? Really appreciated!

Awesome! Thank you for the contribution.


[BUG] bug with has multiple tags in path

Demo code:
goapidoc.NewPath("GET", "/v1/policy", "查询所有策略").
	WithTags("Policy").
	// WithTags("Administration").
	WithSecurities("Jwt").
	WithResponses(goapidoc.NewResponse(200).WithType("_Result<_Page<PolicyDto>>")),

The first tags (policy) will be ignore and only the last tag will be shown in spec.json.

This is a fake bug, the correct usage is following:
goapidoc.NewPath("GET", "/v1/policy", "查询所有策略").
	WithTags("Policy", "Administration").
	WithSecurities("Jwt").
	WithResponses(goapidoc.NewResponse(200).WithType("_Result<_Page<PolicyDto>>")),


Fix bug for isothermal EB on GPU

Closes #237
@taaresh1 can you verify that this solves your problem?

@baperry2  This resolved the issue! Thanks a lot for the prompt response.


Memory leak on Sciex data ?

There seem to be a memory leak somewhere in the peakpicking algorithms.
So far, it has only been seen when converting AB Sciex data, but it may be caused by something else.
It does not happen every time, it seems like it happens most often when computer resources are used by another process, but I can't reproduce it for the moment.
But I managed to reproduce the leak on a specific spectrum in the file '20130206_BG_ID_01.wiff' (it does not happen every time, but it does it's always on that spectrum)

bug is fixed, it was related to the fitting algorithm of AB Sciex data


cirq.contrib.quimb fails with quimb 1.2.0

Description of the issue
Quimb fails with version 1.2.0.  We should either require 1.3 or (ideally) fix whatever was broken in 1.2
How to reproduce the issue
pip install quimb==1.2.0
pytest cirq/contrib/quimb/

test_tensor_expectation_value
...
 AttributeError: 'numpy.complex128' object has no attribute 'add_owner'

Cirq version
cirq from HEAD and quimb == 1.2.0

It fails in rank_simplify. I think the fix is this line: https://github.com/jcmgray/quimb/commit/492201519157355b751d64af73e297a318f0adff#diff-382c633ca92381427ca0bc74c1ac3081R3361
One option is to comment out state_vector.py:150 which calls rank_simplify. It's possible EITHER that (1) this will cause performance to deteriorate in a major way for gridlike circuits because lots of things can be fused ahead of any true contraction OR (2) contract already finds a path that does this so it's fine.
Instead of truly investigating this, I say we set the requirements to >=1.3.0 and if someone is desperate to use 1.2.0 they can patch out that specific line. What do you think?

So, it looks like this doesn't quite work in our favorite environment, since it looks like the version number is not super well specified.  Maybe it got pulled from master or something:
This is the error:
"invalid literal for int() with base 10: '0+unknown'"
I think it is fine for it to assume unknown versions are not compatible, but it should not error out.


Automatic Dispatch Table Detection Sometimes Missing Last Entry

The automatic detection of dispatch tables is sometimes short by one element.
This problem occurs when the 'heuristic range clamp' is utilized to automatically infer the end of a dispatch table, and the stride of the range is larger than the load size.

Fixed in 3.1.3574-dev.


 It has the effect of shutting down our ability to replay a video we just watched.
So, if you had the time and found a way to disable Up Next, that would be great.
Basically, Up Next is  a new feature that jumps to some other video suggested by Youtube when your video's done, and there's no way to stop it. Which means now the only way to replay what you watched is to use the browser Back button and reload the entire page.
Furthermore it means if you wanted to view some videos that showed up in the right-hand column, those will all be different now so for this too you need to browser-Back and hope they're still listed.
Thanks again for the amazing YTC. My head explodes every time I have to watch youtube without it.

You can disable Up Next entirely by flipping the toggle in the upper-right corner (the color will also change from blue to grey). This works on both Firefox and Chrome; I haven't tested other browsers.
Screenshot for reference: http://i.imgur.com/Krz4pvV.png

And the next time you visit YouTube without stored cookies it will be activated again.
I would be very grateful if you could add a toggle somewhere in YTC.

You can disable autoplay on Up Next by flipping the toggle in the upper-right corner

That's incorrect. On my computer flipping the toggle makes no difference. I already tried that and it jumps to the Up Next anyway. It does not start playing that next video (because I have YTC set to block autoplay) but you do get sent to the page of that video and the video loads. So AFAIK when you have YTC set up the way I do, the toggle has no effect of any kind.

@ackern does the setting get reset when you have YTC disabled? If not, it is not a YTC problem. Would be a nice feature though for all the people who are cookie paranoid.

I don't understand your question. There's too many "not"s.  When YTC is disabled, the toggle functions correctly for a limited period of time. I have noticed  unpredictable variations in how long it 'sticks'. Sometimes when I switch it off,  Youtube switches it back on after a video or two and sometimes it seems to stay off the whole day, or anything in between. But I don't precisely test because I can't stand to watch that much with YTC turned off.

Duplicate of #1581 , I agree that it is very annoying and I have the same experience with the "disable autoplay" thing not helping at all.

Disable autoplay is not supposed to, if I recall, to stop the up next video switch from happening.
Anyway, I don't believe it is YTC that messes with the up next toggle getting reset. It would, however, be beneficial for having a option to always check the status of the toggle and then switch it on or off as preferred.

The state of the Up Next Autoplay switch is stored by a YouTube site cookie. If you are deleting cookies set by YouTube and are not using an account, then you should expect settings to reset to their default state the next time you load the site.

I had this problem.  The switch was in the "Off" state, yet Up Next was still triggering.  Flipping it on and back off didn't help.  Recently however, I tried once again flipping it on and back off, and it appears to have finally stopped.  The problem may have been partially fixed.  Has anyone else tried toggling it recently?

The feature stores the user setting in a cookie so if anyone has cookies disabled/blocked then the autoplay off will never work (unless on the first time) because it tries to find the user choice and defaults to on when it doesn't find it.
It is also possible that some times the cookie bugs out and stores an incorrect setting that is incompatible with the feature and so it again defaults to on.
I will try later to create a small script to remove that autoplay feature for anyone that wants it until YePpHa decides wether or not he will include this in YTC.

I have a suggestion..... Up Next is generally a good feature, only annoying fact is, YT gets to chose the video for u. What would be nice, is a function in YTC where i can click on related videos while the current video is playing, which are then stored in kind of an extra-list. As soon as the current video ends, the next video of all I have chosen would lo0ad. Alternatively, I could load the next one with lets say CTRL+right arrow or whatever. (Not the watch-later list on YT, where u need to go to that list and then play it.) That would be pretty epic, caus I often see many interesting related vids when watching, but being at the next one, I forgot the others i wanted to check. Then again, I need to go back, and forget the related ones on the new vid which i was interested in.... well yeah..... that would be epic..... ^^

@WhyTheFuckAreAllNamesAlreadyTaken Please open a new ticket for your suggestion instead of posting it to a irrelevant existing issue report so it can actually be found later on.

Alright, here it is the autoplay up next remover userscript, all you have to do is have a userscript addon/extensio manager installed (like Greasemonkey or Tampermonkey) and click on the "Raw" button, it should ask you if you want to install it and that's it, autoplay up next is gone.
https://gist.github.com/Yonezpt/51adf278a24488f75ff0
Works for Firefox and Chrome, let me know if it worked ok.

Marry me! That rocks!
Also it has the effect of making the thing that happens at the end of the video much quicker. The grid of suggested video thumbnails in the player window - it appears instantly now. Before (before Up Next existed), it loaded a lot slower which was hugely irritating. I think the thumbnails would load one by one, one after the other. Or they would fade in gradually.  Now, your video ends and bam the thumbnails are there immediately.

@Yonezpt
Works like a charm. Thank you very much!

Thanks very much Yonezpt for your script, works fine on Pale Moon. I really wish it'll be included in YTC, Up Next is extremely annoying.

@Yonezpt Thanks !!!!

Yonezpt's script not working anymore?

@Gittyperson The script is still working for me on both Firefox and Chrome. Could you please discuss this in the script page instead of here? Otherwise we are abusing an issue page that is related to YTC, not to my userscript.

You are right, I'm deleting both comments.

I have this issue as well. Will be using @Yonezpt 's script for now
Using Firefox 38 Beta, Developer Version #501 with Greasemonkey.

:+1: for @Yonezpt's script being put into YTC.

I agree !!

Very cool that there is a script for this. Will definitely appreciate if it is implemented directly with YouTube Center.
@Zarggg's comment about "default state" is incredibly fallacious when YouTube Center already has numerous options beyond extending YouTube by changing its default state (center, language, comment/description/share expansion, player, player resolution and size, and so on) that works with or without cookies. If it can be feasibly done, then "live with it" isn't a valid response given the nature of this extension.


icub-firmware-shared version catching up with iCub version?

As I had to revert to a previous version of YARP/iCub yesterday, I chose to checkout the tags for the latest package releases (YARP v2.3.63, iCub 1.1.15). Looking for the tags in icub-firmware-shared, the latest one was 1.1.13, which was not working with iCub v1.1.15. I ended up checking out icub-firmware commits from around the date of the iCub v1.1.15 release.
Wouldn't be easier in the future, at the date of each iCub v1.x.y release, to tag the icub-firmware head of the same date as icub-firmware v1.x.y?

This looks like a good suggestion to me.

@mbrunettini: can you update the tagging instructions so we do not forget next time?

Fine, tagging instructions updated.


fix: github action

purposefully making a test fail to test github actions pipeline

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (da21e66) to head (ce84a43).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #179    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files            1         1
  Lines          335       209   -126
  Branches       116        66    -50
==========================================
- Hits           335       209   -126

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add setdefault method

we need a setdefault method to change default tag of the asset
it should prompt on override: you currently have "...."

if we change tag X to default do we remove X from the config?

Hmm, good question.
also do we need a way to move a default into a tagged slot?
if we forced all assets to have tags, then default could just be a pointer to an existing tag. That would answer this question, but would require all assets to have a tag.


Autocomplete with custom promises Highlight vs Used

I tried Autocomplete with custom promises on your demo page. I chosen "Autocomplete with custom promises" mode and typed Tag9. The Tag9 was highlighted properly in the selection, BUT in case of [ENTER] the first option was used from the selection, not the highlighted one. I just wondering if it is an easy fix.

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Make Reused Page Content Searchable

Describe the feature you'd like
Make "shared content" searchable in the pages they are shared in.
Let's say I have a page titled "washing dishes". This will be the content I want to share, or reuse, in other pages such as "making breakfast" and "making dinner". Currently if I search for "washing dishes", only the "washing dishes" page shows up. Would like to have it also find the other pages as well....and better still if that is an "option/filter" setting in the searches if you want to include it or not.
Describe the benefits this feature would bring to BookStack users
If I am searching "how to run a cafe efficiently" book for washing dishes, it will not return the making breakfast or making dinner pages in that book. My example is poor for actual usage/need but we have content shared between multiple books but the user search in the book becomes no results and in the global search becomes insufficient result (only the shared content page, but it is missing the page we actually want them to find).
Additional context
Regarding Reusing Page Content:
https://www.bookstackapp.com/docs/user/reusing-page-content/

Thanks for the suggestion @nvnvnvnvn.
This actually used to be a feature but I removed it since it allowed the included content to be visible to those without permission to view the included item.
This will be difficult to do while full conforming to the permission system. Maybe a halfway-solution if make the included content indexed if visible to the guest user? Not ideal though as we'll have to re-index or having warnings to re-index when changes are made to guest user permissions.

Thanks @ssddanbrown , that does seem like a challenge. I was thinking if it is in a page that someone has permissions to view they should be able to view everything. But, I can see where someone may want to have content in a page that only certain people can view that particular section/content of the page.
Interesting situation.  Could it be a global setting so we could choose to show it and others could choose to not?

Hi @ssddanbrown. First and foremost. Thank you for building such a wonderful and powerful tool over the years.
I'm trying to enable this feature in this custom fork (https://github.com/Shreemeera-Foundation/bookstack-smf-replica) of the project. Can you please share how can I enable the said feature?
Thank you in advance.

@pankaz Might be more that one boolean change looking at this now, but not diven too deep into it. The page content terms are generated here. It's be a case of altering that line to run the provided HTML through this function first.
Note, this can have side affects when permissions/visibility-control is at play in an instance.

Hi @ssddanbrown, thank you so much for pointing us in the right direction. I appreciate your quick reply and guidance. We achieved the expected result by tweaking the parsePageIncludes method and reindexing the search terms.


cannot upload profile

Describe the Bug i am been trying to upload video from last 1 hr but cannot
To Reproduce
Expected Behavior
Screenshots
Device and Browser Information

i wanted to create my profile in proof of humanity but cannot upload video is c keeps on saying error

Hello! I want to upload my video again since when I did it there was a problem with the camera and everything came out black, how do I upload it again? my address is 0x6ff2506bf4de50dfee0f73ba5caaad3f1f352382
Because of this mistake they did not approve my profile, and I paid almost 300 USD!! PLEASE HELP ME, THANK YOU!


Cop idea: Style/BitPredicates

Is your feature request related to a problem? Please describe.
Ruby 2.5 (!) introduced Integer#anybits?/#allbits?/#nobits? predicates. Accordingly, it would be cool if Rubocop suggested those corrections:
# 1. anybits?
# bad
(variable & MY_FLAGS).positive?
# good
variable.anybits?(MY_FLAGS)

# 2. allbits?
# bad
(variable & MY_FLAGS) == MY_FLAGS
# good
variable.allbits?(MY_FLAGS)

# 3. nobits?
# bad
(variable & MY_FLAGS).zero?
# good
variable.nobits?(MY_FLAGS)

I’ve seen a lot of codebases that use the bit-math version, and in many cases, predicates version seems to be clearer. It also has an educational value: I constantly see people writing bit-math to check flags seven years after methods introduction (because they simply don’t remember methods exist).
Haven’t yet time enough to work on the cop myself (well, I happen to have a draft branch, and I feel guilty for never finishing it, maybe I’ll do... but it is what it is) :cry:

One can also access individual bits via [], perhaps it could be part of such a cop as well.
Bit extraction:
# bad
(x >> bit) & 1

# good
x[bit]

Bit checking:
# bad
x & (1 << bit) > 0

# good
x[bit] == 1

# bad
x & (1 << bit) == 0

# good
x[bit] == 0

Bit checking against constant powers of 2:
# bad
(x & 8).positive?
(x & 0b01000).positive?
(x & (1 << 3)).positive?
(x & 8) == 8

# good
x[3] == 1


[os-telegraf] Please add CPU temperature monitoring

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[x] When the request is meant for an existing plugin, I've added its name to the title.

Is your feature request related to a problem? Please describe.
The problem I'm having is not being able to monitor CPU temperatures with the Telegraf plugin.
Describe the solution you'd like
Add CPU (and possibly other sensors) to the Telegraf plugin. Perhaps like this https://github.com/influxdata/telegraf/blob/master/plugins/inputs/sensors/README.md
Describe alternatives you've considered
Using a custom Telegraf config but that is not a very elegant solution.
Additional context
No other context.

currently the workaround is to edit the telegraf.conf according to this https://forum.opnsense.org/index.php?topic=17938.0
however, the additional line that is added into the telegraf.conf will be removed whenever telegraf service is restarted


Chrisda to Main

Learn Build status updates of commit c2ff67c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-Place.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Bulk validation fixes h1 title

Docs Build status updates of commit d441c39:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/WebSDK/samples/ThirdPartyNotices.md
:warning:Warning

Details

Skype/WebSDK/samples/ThirdPartyNotices.md

Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@lindalu-MSFT
The warnings will be addressed in another PR! My apologies for such a tiny PR!
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!


gparyani: Watch devart.com/dbforge

gparyani requests the watch of the watch_keyword devart\.com/dbforge. See the MS search here and the Stack Exchange search here.

devart\.com/dbforge has been seen in 1 true positive, 0 false positives, and 1 NAA.

Please close; already blacklisted.

Coverage remained the same at 63.106% when pulling 044c25888e857ef2a9f4bb0d615f811f88b1d1e4 on auto-blacklist-1536640018 into 439c505ae31aa145159f9c7c33b6d5acbddc656f on master.

Coverage remained the same at 63.106% when pulling 044c25888e857ef2a9f4bb0d615f811f88b1d1e4 on auto-blacklist-1536640018 into 439c505ae31aa145159f9c7c33b6d5acbddc656f on master.

The entire domain is already blacklisted, though we might want to fall back and do this if the site-wide blacklisting turns out to generate FPs.


[Bug] Compilation Error

Describe the Bug
Version : current Master .
After fixing the green screen bug which i had to add this in google.js config file
        acceptHeader: [ 'multipart/related; type=application/octet-stream; transfer-syntax=*'],
Compilation with errors and compilation doesn't contain the fix above and the result is that the green screen appears in compiled version and in dev mode it doesn't appear
Steps to Reproduce
version master , work with google.js , and add the acceptHeader: [ 'multipart/related; type=application/octet-stream; transfer-syntax=*'] to fix the green screen issue ..
yarn run dev -
everything works as expected after compilation , it appears that it wont take the google.js new fields , even when i set showStudyList to false and ignore crossOrigin message warning to false .
The current behavior
after compilation green screen still appears,
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  app.bundle.fd9c7b9b4b5554cbe9bf.js (4.27 MiB)
  dicom-microscopy-viewer.bundle.891b86d0c0df9ca3fe6b.js (2.18 MiB)
  26.bundle.121399fde7abcf84fd93.js (1.09 MiB)
  220.bundle.d0b0df6e3678c751fa3c.js (592 KiB)
  cornerstoneDICOMImageLoader.min.js.map (390 KiB)
  index.worker.64c896c4316fcd506666.worker.js.map (500 KiB)
  dicomMicroscopyViewer.min.js (2.18 MiB)
  index.worker.min.worker.js.map (726 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  app (4.35 MiB)
      app.bundle.css
      app.bundle.fd9c7b9b4b5554cbe9bf.js

webpack 5.88.2 compiled with 2 warnings in 59900 ms (5e5fbb83434425d247a0)

 >  Lerna (powered by Nx)   Successfully ran target build:viewer for project @ohif/app

   Nx read the output from the cache instead of running the command for 1 out of 1 tasks.

Done in 1.89s.

Compilation output warning .
looks like the issue is about compilation
The expected behavior
after compilation , it will work exactly like it run perfectly fine in DEV mode (yarn run dev with google.js conf)
OS
window 11
Node version
v20.9.0
Browser
Version 118.0.5993.118 (Official Build) (64-bit)

Checkout the latest master branch, I think it is fixed, re-open if not

@sedghi Thanks for answering! unfortunately i tried - pulled the latest master, used yarn run build and this is the result :
`@ohif/app: assets by path *.js 12.4 MiB 48 assets
@ohif/app: assets by path assets/ 318 KiB 48 assets
@ohif/app: assets by path *.wasm 1.42 MiB 8 assets
@ohif/app: assets by path *.css 97.3 KiB 7 assets
@ohif/app: assets by path *.map 1.73 MiB 5 assets
@ohif/app: assets by path *.svg 32.3 KiB 2 assets
@ohif/app: assets by path *.html 5.36 KiB
@ohif/app:   asset index.html 4.71 KiB [emitted]
@ohif/app:   asset silent-refresh.html 665 bytes [emitted] [from: ../public/silent-refresh.html] [copied]
@ohif/app: assets by path *.json 1.64 KiB
@ohif/app:   asset manifest.json 1.34 KiB [emitted] [from: ../public/manifest.json] [copied]
@ohif/app:   asset serve.json 310 bytes [emitted] [from: ../public/serve.json] [copied]
@ohif/app: asset _headers 264 bytes [emitted] [from: ../public/_headers] [copied]
@ohif/app: asset _redirects 156 bytes [emitted] [from: ../public/_redirects] [copied]
@ohif/app: Entrypoint app [big] 5.5 MiB (19.1 MiB) = app.bundle.css 83.8 KiB app.bundle.20e2fc14b98128ebe05d.js 5.41 MiB 2 auxiliary assets
@ohif/app: LOG from InjectManifest
@ohif/app:  The service worker at sw.js will precache
@ohif/app:          176 URLs, totaling 53.5 MB.
@ohif/app: WARNING in ../../../extensions/tmtv/src/utils/calculateSUVPeak.ts 94:2-44
@ohif/app: export 'utilities'.'pointInSurroundingSphereCallback' (imported as 'utilities') was not found in '@cornerstonejs/tools' (possible exports: annotationFrameRange, boundingBox, calibrateImageSpacing, cine, clip, contours, debounce, drawing, dynamicVolume, getAnnotationNearPoint, getAnnotationNearPointOnEnabledElement, getCalibratedAreaUnits, getCalibratedLengthUnits, getCalibratedScale, getSphereBoundsInfo, isObject, jumpToSlice, math, orientation, planar, planarFreehandROITool, pointInShapeCallback, pointToString, polyDataUtils, rectangleROITool, roundNumber, scroll, segmentation, stackContextPrefetch, stackPrefetch, throttle, touch, triggerAnnotationRender, triggerAnnotationRenderForViewportIds, triggerEvent, viewport, viewportFilters, voi)
@ohif/app:  @ ../../../extensions/tmtv/src/commandsModule.js 7:0-56 211:22-38
@ohif/app:  @ ../../../extensions/tmtv/src/index.tsx 5:0-46 35:11-25
@ohif/app:  @ ./pluginImports.js
@ohif/app:  @ ./index.js 19:0-89 33:4-21 34:4-16
@ohif/app: WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
@ohif/app: This can impact web performance.
@ohif/app: Assets:
@ohif/app:   app.bundle.20e2fc14b98128ebe05d.js (5.41 MiB)
@ohif/app:   dicom-microscopy-viewer.bundle.649323f830e61afc3dbf.js (2.18 MiB)
@ohif/app:   223.bundle.473c30ab997e3a001639.js (597 KiB)
@ohif/app:   cornerstoneDICOMImageLoader.min.js.map (397 KiB)
@ohif/app:   index.worker.64c896c4316fcd506666.worker.js.map (500 KiB)
@ohif/app:   dicomMicroscopyViewer.min.js (2.18 MiB)
@ohif/app:   index.worker.min.worker.js.map (726 KiB)
@ohif/app: WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
@ohif/app: Entrypoints:
@ohif/app:   app (5.5 MiB)
@ohif/app:       app.bundle.css
@ohif/app:       app.bundle.20e2fc14b98128ebe05d.js
@ohif/app:
@ohif/app: webpack 5.89.0 compiled with 3 warnings in 53939 ms (cb97047c198bdedfe5b0)
`

@niirdan I don't see any error here, do you see the dist folder getting generated in the platform/app?

Unfortunately no, stays empty
On Tue, 9 Jan 2024 at 22:59 Alireza @.***> wrote:

@niirdan https://github.com/niirdan I don't see any error here, do you
see the dist folder getting generated in the platform/app?
—
Reply to this email directly, view it on GitHub
https://github.com/OHIF/Viewers/issues/3868#issuecomment-1883782573, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5B2UZWJTQWNECFIYB2MR3LYNWVRVAVCNFSM6AAAAABBFJ7HICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTG44DENJXGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

what is your node version? you should use 18.x

@sedghi i am using node version 20.9.0

Can you try 18?

Of course, I will try it and let you know
Thanks
On Wed, 10 Jan 2024 at 15:25 Alireza @.***> wrote:

Can you try 18?
—
Reply to this email directly, view it on GitHub
https://github.com/OHIF/Viewers/issues/3868#issuecomment-1884847407, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5B2UZVEE3I54FEVE7ZTJTLYN2JFPAVCNFSM6AAAAABBFJ7HICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBUHA2DONBQG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sedghi
v18.17.1 should work?

It should


Player configure drm advanced settings change other key systems

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
v2.4.2
Can you reproduce the issue with our latest release version?:
Yes
Can you reproduce the issue with the latest code from master?:
Yes
Are you using the demo app or your own custom app?:
Demo app
If custom app, can you reproduce the issue using our demo app?:
N/A
What browser and OS are you using?:
Chrome Linux and Window (and probably others)
What are the manifest and license server URIs?:
Any demo asset.
What did you do?

Load any asset.
Open DevTools.
shakaDemo.localPlayer_.getConfiguration().drm.advanced
shakaDemo.localPlayer_.configure({drm: {advanced:{'com.widevine.alpha': {distinctiveIdentifierRequired: true}}}})
shakaDemo.localPlayer_.getConfiguration().drm.advanced

What did you expect to happen?
Should only update the com.widevine.alpha settings.
What actually happened?
The other key systems are updated to the new settings too.

Fix cherry-picked to v2.4.5.


Windows: files directory contents must be writable by nginx user in container

What happened (or feature request):
I note that the files directory for my (windows ddev) drupal site is mounted as root, but the nginx process is running as nginx, as we'd expect. But with this mounting, nginx is not necessarily able to write into the files directory as it needs to do.  This is on windows.
Possible solutions include:

Recursively Chowning the files dir to nginx owner and/or nginx group
chmod directories and files carefully to add permissions.

The normal approach on a server would be to grant nginx group write perms on everything in the directory.
All changes here have important implications for linux users, as changing the ownership must be done "right" or it results in very significant host-side permission problems.
What you expected to happen:
Version: Please include the output of ddev version and the project's .ddev/config.yaml.
How to reproduce this:
Anything else do we need to know:
Related source links or issues:

@rfay Given that this is specified as an issue affecting Windows only, what is the reason for the discrepancy? That is, I'm assuming Linux/Windows mount the files directory as the nginx user. Is this a deficiency in Docker for Windows?

I haven't studied it on other platforms, am not sure I know it's windows only. This may be related to the same problems we have on linux, which we've solved by changing the 'nginx' user/group after starting the container.

Ownership on Windows is fine, at least since #745 - I just tested it.


Infra25725 add codecov token to workflow

Description
This PR...

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[x] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
is the codecov token needed for simulator CI ?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.57%. Comparing base (6502dde) to head (8d6e3ac).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8960      +/-   ##
============================================
- Coverage     19.99%   16.57%   -3.43%
+ Complexity    18766    15787    -2979
============================================
  Files          4867     4778      -89
  Lines        326215   333586    +7371
  Branches      45858    48105    +2247
============================================
- Hits          65228    55286    -9942
- Misses       251539   271807   +20268
+ Partials       9448     6493    -2955

Flag
Coverage Δ

simulator-marvin-tests
?

unittests
16.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

great, it works

good job @DaanHoogland  !

@DaanHoogland is the codecov token needed for simulator CI and UI build ?
$ git grep codecov-action
.github/workflows/ci.yml:      - uses: codecov/codecov-action@v3
.github/workflows/codecov.yml:      - uses: codecov/codecov-action@v3
.github/workflows/ui.yml:      - uses: codecov/codecov-action@v3

they probably are, thanks


Popover doesn't work in Fullscreen Mode

Hello folks,
First of all thanks for the super UI Framework - we really love using it. I just wanted to ask here if someone has a clue on how to make popovers and other functionality work seamlessly with the modern full screen mode?
The popover I am trying to show works good in regular mode but doesn't show up when the full screen move is toggled.
I am using this http://tutorialzine.com/2012/02/enhance-your-website-fullscreen-api/ to go fullscreen.
Thanks in advance!

guys, why the issue is closed, I still facing it three years after its post!

I have the same problem, although this issue exist since 2012. In the meantime you may overcome the issue by appending your popover inside a container element and not just the body of your document. This can be done using container option.
e.g
(<any>element).popover({                     animation    : true,                       html            : true,                      content        : htmlMsg,                      container     : '#elementid'                 }).popover('show');

Same problem and no solution find... :/

The solution is to add in the popover boundary: 'viewport' in option


As a noobie I would appreciate link to the project its somewhere on the main page

Could there be a link to the main page to Silta itself?
Also, could the Silta project be also pinned on our Github main page?

:heavy_check_mark: wunderio/silta it's pinned for org


install under git msys require move 'ftl java plsql resources' to scripts folder

user@host /c/user/lib/ftldb/tags/v1.2.1/src/main/scripts
$ usr_install.sh tns user pwd
------------ INSTALLING FTLDB -------------
Log file: setup/!usr_install_nrs_dev_prod_upd.log
Run SQL*Plus installation script.
SQL*Plus: Release <IP_ADDRESS>.0 Production on Вт Мар 31 17:11:06 2015
Copyright (c) 1982, 2010, Oracle.  All rights reserved.
Присоединен к:
Oracle Database 11g Enterprise Edition Release <IP_ADDRESS>.0 - 64bit Production
With the Partitioning option
SQL*Plus script started.
Switch to USER schema.
Сеанс изменен.
Create NUMBER_NT type.
Не удается найти указанный файл.
Отсоединено

If you're a Windows user, don't use shell scripts under Cygwin or other shell-emulators. Loadjava in Oracle Client for Win is a batch script and won't work!
Use only usr_install.bat.

Moreover, according to this:

SQL*Plus: Release <IP_ADDRESS>.0 Production on Вт Мар 31 17:11:06 2015

it seems you have Oracle Client <IP_ADDRESS>.0 for Windows installed. It has a buggy loadjava utility. Update your client, if you have problems with loading jars into DB.


Update egoscale driver version

Update the version of Exoscale driver to fix an API parsing error.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "update-exoscale-driver" git@github.com:exoscale/docker-machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle done!

Thanks!


Removes unused redisson CommandExecutor import

Hi Vladimir,
There is an unused import on line 32 (org.redisson.command.CommandExecutor).
I suspect this to be a typo because:

the import org.redisson.command.CommandExecutor is not referenced anywhere inside the class definition
the class definition (SpringDataRedisBasedProxyManager) is a spring-data implementation of the ProxyManager. I would not suspect to see references to vendor-specific implementations here because you're already using the vendor-agnostic facilities provided by spring-data-redis.

My builds still run but my IDE is complaining because I don't have redisson on my classpath (this is surely the case for others as well, spring-boot-data-starter-redis only supplies jedis and lettuce).

Thank you


The editor uro button fails to interact

Issue description
The editor uro button fails to interact to launch editor plugin.
Steps to reproduce

Open v-sekai editor
Click on the editor uro button
Nothing changes

Minimal reproduction project (For SDK or engine issues)
No response
Using a released version?
Yes https://github.com/V-Sekai/v-sekai-game/commit/b8a2a02fc2031d3451318ae3902122814b3d284d
What OS? Any other relevant information? (V-Sekai version, Godot revision, System information)
Windows 11, 535.98 Nvidia

Works fine?


Update Proper Comment i Docker file

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

Added proper comment in docker file for better understanding

Hey @devhabib429
Thank you for opening this pull request.
This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Add yRange option

https://user-images.githubusercontent.com/13172299/139166299-319a29b4-2b39-4a2e-b24d-8fd4cad07880.MP4
Closes #20

@jxom thanks for reviewing! I missed the latest comment, but I pushed changes to resolve all outstanding requests.

Legendary work.


Put writing 0 byte file.

Hello again,
Could you please explain what i am doing wrong when doing a Get from one FTP Server  and trying to Put to another FTP Server.
My bad code is below.
var Client = require('ftp'),
connects = 0;
var srcparams = { // Windows FTP Server
host: "ftptest1.com",
port: 21,
user: "ftp",
password: "password",
debug: console.log
};
var destparams = {
host: "ftptest2.com",
port: 21,
user: "ftp",
password: "password",
debug: console.log
};
var src = new Client();
var dest = new Client();
src.connect(srcparams);
dest.connect(destparams);
src.on('ready', function() {
console.log('source ready');
connects++;
copy();
});
dest.on('ready', function() {
console.log('destination ready');
connects++;
copy();
});
function copy() {
if (connects === 2) {
copyfile();
}
}
function copyfile(source, destination, callback) {
src.get('www/index.html', function(err, stream) {
if (err) {
throw err;
}
stream.once('close', function() {
src.end();
});
//stream.pipe(fs.createWriteStream('foo.local-copy.txt'));
dest.put(stream, 'www/index.html', function(err) {
if (err) {
throw err;
}
dest.close();
});
});
}
the debug output is
[connection] < '230 User logged in.\r\n'
[parser] < '230 User logged in.\r\n'
[parser] Response: code=230, buffer='User logged in.'
[connection] > 'FEAT'
[connection] < '211-Extended features supported:\r\n LANG EN*\r\n UTF8\r\n AUTH TLS;TLS-C;SSL;TLS-P;\r\n PBSZ\r\n PROT C;P;\r\n CCC\r\n HOST\r\n SIZE\r\n MDTM\r\n REST STREAM\r\n211 END\r\n'
[parser] < '211-Extended features supported:\r\n LANG EN*\r\n UTF8\r\n AUTH TLS;TLS-C;SSL;TLS-P;\r\n PBSZ\r\n PROT C;P;\r\n CCC\r\n HOST\r\n SIZE\r\n MDTM\r\n REST STREAM\r\n211 END\r\n'
[parser] Response: code=211, buffer='Extended features supported:\r\n LANG EN*\r\n UTF8\r\n AUTH TLS;TLS-C;SSL;TLS-P;\r\n PBSZ\r\n PROT C;P;\r\n CCC\r\n HOST\r\n SIZE\r\n MDTM\r\n REST STREAM\r\nEND'
[connection] > 'TYPE I'
[connection] < '200 Type set to I.\r\n'
[parser] < '200 Type set to I.\r\n'
[parser] Response: code=200, buffer='Type set to I.'
source ready
[connection] > 'PASV'
[connection] < '227 Entering Passive Mode (192,96,210,12,7,222).\r\n'
[parser] < '227 Entering Passive Mode (192,96,210,12,7,222).\r\n'
[parser] Response: code=227, buffer='Entering Passive Mode (192,96,210,12,7,222).'
[connection] PASV socket connected
[connection] > 'RETR www/index.html'
[connection] < '125 Data connection already open; Transfer starting.\r\n'
[parser] < '125 Data connection already open; Transfer starting.\r\n'
[parser] Response: code=125, buffer='Data connection already open; Transfer starting.'
[connection] > 'PASV'
[connection] < '226 Transfer complete.\r\n'
[parser] < '226 Transfer complete.\r\n'
[parser] Response: code=226, buffer='Transfer complete.'
[connection] > 'MODE S'
[connection] < '227 Entering Passive Mode (192,96,210,17,7,231).\r\n'
[parser] < '227 Entering Passive Mode (192,96,210,17,7,231).\r\n'
[parser] Response: code=227, buffer='Entering Passive Mode (192,96,210,17,7,231).'
[connection] PASV socket connected
[connection] > 'STOR www/index.html'
[connection] < '200 Mode S ok.\r\n'
[parser] < '200 Mode S ok.\r\n'
[parser] Response: code=200, buffer='Mode S ok.'
[connection] < '125 Data connection already open; Transfer starting.\r\n'
[parser] < '125 Data connection already open; Transfer starting.\r\n'
[parser] Response: code=125, buffer='Data connection already open; Transfer starting.'

Looks like this is still an issue?

Same issue as @ugate. The workaround gets the files transferring the full file at least...


Fix #2169, Update CI_LAB entry point in cfe_es_startup.scr

Checklist

[x] I reviewed the Contributing Guide.
[x] I signed and emailed the appropriate Contributor License Agreement to<EMAIL_ADDRESS>and copied<EMAIL_ADDRESS>
Describe the contribution

Fixes #2169

Updates CI_LAB entry point in cfe_es_startup.scr

Part of changes to the ci-lab app and GroundSystem
Aim is to standardize naming of CI_LAB functions to match the predominant cFS style.
Testing performed
Only the GitHub CI workflow actions.
Expected behavior changes
No impact on behavior.
Contributor Info
Avi Weiss @thnkslprpt

@dmknutsen This one should go in now as well I think, given that https://github.com/nasa/ci_lab/pull/126 was merged in


Adjusted advertiseOSDF namespaceAd generation

-- Now uses basepaths and issuers if a token is required

Also, in the advertise_test unit testing code, I switched the actual vs expected values since they were reversed and it was annoying me.

@jhiemstrawisc That's a good point. I suppose it should really attempt a match on the basepath first and then the path. I think at least. This will be a larger fix, so I may have to punt this off to 7.4

My $0.02:

We should match on most specific path first then base path.  This is because there are some oddball cases where base path (for issuing / verification) don't line up with the path itself.

For a given prefix, there should only be one CredentialGeneration block (see https://github.com/opensciencegrid/topology/blob/master/virtual-organizations/GLOW.yaml#L109 versus https://github.com/opensciencegrid/topology/blob/master/virtual-organizations/LIGO.yaml).  There may be multiple permitted issuers that can sign tokens but only one that we can redirect people to create new tokens.

In terms of headers, we should have the x-pelican-authorization be multi-valued.  How about x-pelican-authorization: issuer=https://issuer1.example.com, issuer=https://issuer2.example.com?  Would that be backward-compatible with existing clients?

We shouldn't be using the name scitokens in the wire format.  SciTokens is a token profile and, in many cases, these issuers use other token formats like the WLCG profile.  How about something more generic like token_authorization?

@bbockelm  - I'm somewhat confused by your specific comments about CredentialGeneration and scitokens. OSDF I think only has one CredentialGeneration per origin already and the scitokens that is currently being passed is because scitokens in the json field from OSDFTopology. I can adjust the name of the struct that is mirroring the topology so that it has a different name, but that json:scitokens bit has to stay.

The below is our NamespaceAd struct - which is not serving our purposes.
NamespaceAd struct {
		RequireToken   bool         `json:"requireToken"`
		Path           string       `json:"path"`
		Issuer         url.URL      `json:"url"`
		MaxScopeDepth  uint         `json:"maxScopeDepth"`
		Strategy       StrategyType `json:"strategy"`
		BasePath       string       `json:"basePath"`
		VaultServer    string       `json:"vaultServer"`
		DirlistHost    string       `json:"dirlisthost"`
		RestrictedPath []string     `json:"restrictedPath"`
}

The issue now is what we want to determine a single NamespaceAd. It should be one ad per namespace. We've determined that topology has multiple issuers and base paths per namespace. So we will need to adjust this NamespaceAd significantly to account for the multiple Issuers and BasePath combinations and will almost certainly have backwards compatibility concerns.

Ok - I got around to reviewing the Google document that @turetske had created based on the discussion.  I think a lot of the "bones" of this PR can stay in place but I did some minor reworking of field names and other parts of the structure.
We'll still need to update the clients and the response headers from the director.  Those aren't covered in length in the document, just as an aside in the implementation notes.


feat: implement WebRTC warning badge

add options guide to whats new (#826)

fix bug in c2d detect hyperlink incorrectly && dial pad title incorrect && meeting discription is  not right && white screen when update contact source filter (#831)

Fix c2d detect hyperlink incorrectly && app name error && dial pad title incorrect && meeting content not right && white screen when update contact source filter && lose source icon when contact name is null

fix  meeting discription is not right

check value this.listelem not null before use

await hangup func in answerAndEnd and update googleclientid in bt brand (#838)

fix bug in login panel that currentlocale is sync after initialize proxy (#836)

fix bug in login panel that currentlocale is sync after initialize proxy

update currentLocale

remove unuserd code

chore: add sample rate to sentry in prod env (#841)

add sample rate to sentry in prod env

fix syntax error

update sentry configuration

[RCINIT-6839]Remove failed fax message in call history list (#827)

fix bug Presence icon is not displayed correctly when changing status (#837)

fix bug Presence icon is not displayed correctly when changing status in SW

update presencestatus in headerview

Revert "update presencestatus in headerview"

This reverts commit fe37a21baa44222657f5270186eecc66b1dbd0e4.

Revert "fix bug Presence icon is not displayed correctly when changing status in SW"

This reverts commit 285cbef463b3c1d6316c323d27961f8baec87e7d.

when dndstatus is do not disturb status should be do not disturb

update presence status

bugfix answer call then direct to blank page & prod build hash (#843)

should not open conversation page when click actionmenulist (#842)

feat: add extra webrtc warning (#835)

add extra webrtc warning

add rebranding to webphone alert

add calling mode condition to disable check in non-webphone mode

update webphone to support reconnect from webphone badge

update i18n

add tests for webphone badge

update locale for audio settings alert

remove errcode -1 to make error msg more generic

support audio auto prompted

in meeting description replace /r/n with  (#847)

Bugfix: do not launch sign in flow when unauthorized & lock authorize process (#828)

Bugfix: do not launch sign in flow when unauthorized & lock authorize process

fix google signin flow

chore: implement localStorage migration process (#846)

empty localStorage when upgrading from lower version

enable migration in all env

extract migrationLocalStorage & add tests

update unit tests

minor: update navigation UI (#850)

update navigation UI

update styles

update user guide to support locales (#844)

update user guide to support locales

remove unnecessary comments

update user guide module

Fix user guide & update webphone error handling & hide area code check for non-rc app (#853)

fix user guide add error handling for 403 in webphone & update call button color

hide area code check for non-rc app & add webphone error msg

fix dependencies name

change the order of code

workaround: fixed width and height of options page

should hide what's new when c2d or c2sms (#854)

hide feedback in other brands (#852)

fix bug show blank page when answer fail (#851)

Import user guides for RC (#859)

import what's new guides images

replace image 2

Coverage decreased (-0.004%) to 4.816% when pulling 8446edcf0734ad8a4f02d66f42c7e19bea7dcf10 on ele828:sync-3-27 into 8446edcf0734ad8a4f02d66f42c7e19bea7dcf10 on ringcentral:master.

Coverage decreased (-0.004%) to 4.816% when pulling 8446edcf0734ad8a4f02d66f42c7e19bea7dcf10 on ele828:sync-3-27 into 8446edcf0734ad8a4f02d66f42c7e19bea7dcf10 on ringcentral:master.


Encourage the model to produce valid markdown

VS Code Version:
OS Version:
Logs:

Steps to Reproduce:

question - 3m48s+32s+7m16s+19m45s =
answers-

To add up the time, you first need to convert everything to the same unit. In this case, let's use seconds.

3m48s = 360 + 48 = 228 seconds 32s = 32 seconds 7m16s = 760 + 16 = 436 seconds 19m45s = 19*60 + 45 = 1185 seconds

Now, add all the seconds together:

228s + 32s + 436s + 1185s = 1881 seconds

To convert this back to minutes and seconds, divide by 60 and take the remainder:

1881 ÷ 60 = 31 minutes and 21 seconds

So, 3m48s + 32s + 7m16s + 19m45s = 31m21s.

it answers correctly, but the multiplication signs are interpreted as markdown formatting and the answer looks wrong
expecting -
3m48s = 3*60 + 48 = 228 seconds 32s = 32 seconds 7m16s = 7*60 + 16 = 436 seconds 19m45s = 19*60 + 45 = 1185 seconds

Yes, we need to try to encourage the model to produce valid markdown with some more examples...

This makes it nearly impossible to get it to write a README.md file for you. Should be something it would be good at, explaining and documenting usually work well. But since it can't do nested code blocks correctly, the content can be good but isn't very useful.
Invoking inline doesn't appear to be able to read the rest of the workspace, so while it can write into the editor it can't see enough context. It would be nice if chat could write directly to files.

Workaround:
Write your answer in markdown format enclosed between "```". 😄

This makes it nearly impossible to get it to write a README.md file for you. Should be something it would be good at, explaining and documenting usually work well. But since it can't do nested code blocks correctly, the content can be good but isn't very useful.
Invoking inline doesn't appear to be able to read the rest of the workspace, so while it can write into the editor it can't see enough context. It would be nice if chat could write directly to files.

@zeel01 Have you tried Copilot Edits?

used this prompt to generate the README.md content in a JSON format and then utilized it.
Here’s an example of the prompt and its use in Node.js or a browser developer console:
// Prompt
// Can you provide the README.md content in JSON format, such as:
// { "readme": "## Installation\n ..." }

// Response
const response = { "readme": "## Installation\n ..." };

// Usage
console.log(response.readme); // Outputs: ## Installation\n ...

The Result:
# URL Checker

This project is designed to fetch URLs from sitemaps, check their availability, and log any errors encountered during the process.

## Project Structure


Author id for posts & test suite update

The test suit now contains a test for an upcoming video. The video will be premiering in 2024. So that should keep the test running for some time.

If it fails at some point, just update the video to a new one.

I added the authorid to all community posts and to the video and playlist elements, as they were missing and one could not open channel links to youtube then.

All tested, except the playlist author id as I could not find one channel which has a playlist posted recently. To be tested, otherwise I would keep it in the wild until someone stumbles upon one and it fails (or it might work even, as I inferred that it would work like the other elements).

Good point to add the comment

@absidue is it possible for u to review this. Im afk for a few days


[6.0] embedded: fix a crash when specializing a generic class method with an indirect return value

Explanation: This fixes a compiler crash which can only happen in embedded swift: when specializing generic class methods, there is no callee function available. The fix is to use the ReabstractionInfo::mapTypeIntoContext utility function which checks for a null callee function pointer.
Scope: Only affects embedded swift
Risk: very low. The change is trivial and only affects the case where it was crashing without the fix
Testing: Tested by a test case
Issue: rdar://126762162
Reviewer:  @kubamracek
Main branch PR: https://github.com/apple/swift/pull/73172 (and https://github.com/apple/swift/pull/73194 for a fix in the test)

@swift-ci test

This will probably need to include https://github.com/apple/swift/pull/73194

@swift-ci test


[BugFix] Use plan's row_desc instead of empty row_desc

Signed-off-by: Kevin Li<EMAIL_ADDRESS>What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Problem Summary(Required) ：

MemoryScratchSink uses _row_desc to generate _id_to_col_name, if _row_desc is empty, the arrow filed converted by convert_to_arrow_schema will not contain col_name.
col_name in arrow field is used in starrocks-flink-connector.

void MemoryScratchSinkOperatorFactory::_prepare_id_to_col_name_map() {
    for (auto* tuple_desc : _row_desc.tuple_descriptors()) {
        auto& slots = tuple_desc->slots();
        int64_t tuple_id = tuple_desc->id();
        for (auto slot : slots) {
            int64_t slot_id = slot->id();
            int64_t id = tuple_id << 32 | slot_id;
            _id_to_col_name.emplace(id, slot->col_name());
        }
    }
}

Status convert_to_arrow_schema(const RowDescriptor& row_desc,
                               const std::unordered_map<int64_t, std::string>& id_to_col_name,
                               std::shared_ptr<arrow::Schema>* result,
                               const std::vector<ExprContext*>& output_expr_ctxs) {
    std::vector<std::shared_ptr<arrow::Field>> fields;
    for (const auto& expr_context : output_expr_ctxs) {
        Expr* expr = expr_context->root();
        std::shared_ptr<arrow::Field> field;
        string col_name;
        ColumnRef* col_ref = expr->get_column_ref();
        DCHECK(col_ref != nullptr);
        int64_t slot_id = col_ref->slot_id();
        int64_t tuple_id = col_ref->tuple_id();
        int64_t id = tuple_id << 32 | slot_id;
        auto it = id_to_col_name.find(id);
        if (it == id_to_col_name.end()) {
            LOG(WARNING) << "Can't find the RefSlot in the row_desc.";
        } else {
            col_name = it->second;
        }

        RETURN_IF_ERROR(convert_to_arrow_field(expr->type(), col_name, expr->is_nullable(), &field));
        fields.push_back(field);
    }
    *result = arrow::schema(std::move(fields));
    return Status::OK();
}

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.5


IGNITE-17951 Sql. Enlist partitions in transaction when preparing the execution plan.

What is done in the PR:

Added a new InternalTable#scan method that requires a transaction id and a RAFT leader term to scan a local partition.
(it seems that this procedure can be improved by introducing a "completely local" scan).
The "RAFT leader term" can be different for each partition group, so during the SQL mapping we collect not only the RAFT "leader", but also the "term" for each partition.
(see InternalTable#leaderAssignmentsWithTerm())
Partitions are enlisted in the transaction before plan fragments are sent, right after the fragment mapping step.
(see ExecutionServiceImpl.DistributedQueryManager#enlistPartitions)
All tests that used the old explicit transaction method have been reworked to use the new method.

I don't think we can operate with RAFT terminology in SQL execution layer. Let's think how to avoid using the terms in API methods.
Leader and term should be a part of some transactional context, which can be passed through execution layer and indices right down to the tables layer.

I don't think we can operate with RAFT terminology in SQL execution layer. Let's think how to avoid using the terms in API methods. Leader and term should be a part of some transactional context, which can be passed through execution layer and indices right down to the tables layer.

Agreed, but from my point of view, we are currently blocked by [1] and/or [2] (see TODO in javadoc for ReadWriteReplicaRequest#term).
Because when we process the ReadWriteReplicaRequest, the "term" from the request is currently checked (see PartitionReplicaListener#ensureReplicaIsPrimary). It operates with request 'term', but it seems that it should check term from enlisted partitions.
So currently we can't do a RW-scan passing only the transaction id (we also need to pass the "term" somehow).
@AMashenkov Do you have any idea how to get around this?
[1] https://issues.apache.org/jira/browse/IGNITE-17256
[2] https://issues.apache.org/jira/browse/IGNITE-15083


Multi-reference extension not syncing referenced entry changes

Background
I'm attempting to create an enhanced multi-reference editor, styled and operating as per the default Contentful (Forma 36) functionality, but from which I can have entry fields be directly editable on the sortable card.
This is to cut down on the multiple steps it currently takes a content author to open a referenced entry, check a field value, change the field value, publish and then return.
By leveraging the renderCustomCard property on the MultipleEntryReferenceEditor to return a reimplemented WrappedEntryCard and having that import a custom EntryCard based on the source, I have almost gotten this to work.
Unfortunately, changes that I make to the referenced entries using sdk.space.updateEntry are not syncing back into the MultipleEntryReferenceEditor.
Issue
It appears that field extensions are not provided access to sdk.space.onEntityChanged, so the EntityStore used by the ReferenceEditor does not observe changes made to the referenced entries.
The default Entry links list appearance provided by Contentful does not experience this.
I have not been able to find a viable workaround to having the referenced entries update after either my own or external changes.
Replication
The lack of syncing changes from referenced entries into the multi-reference extension can be seen in the extensions/multiple-references-extension example provided in this repository.

Install the example as per the instructions
Apply it to an appropriate field in your Content model
Create demo content if necessary
Open two browser windows
Access and edit a referenced entry in the second window

The status and values shown on the card in the first window will quickly become out of sync.

As there has been no activity on this issue for several weeks, I will attempt to clarify.
When the MultipleEntryReferenceEditor is used as an extension, any changes made to the referenced entries are not kept in sync regardless of how those changes are made:

By any of the sdk.space methods like updateEntry or publishEntry
By another tab, window, or browser
By another content author

This is not caused by our extension, code or edits.
It can be seen directly in the multiple-references-extension example provided by Contentful.
Under the most basic usage where an entry is edited in the same tab, the changes sync once the edit pane is closed because the EntityStore has a fallback to listen to the slide in navigation. This isn't useful when the changes could be originating from any number of places as outlined above.
This issue is a roadblock for the following extension created to address client complaints that the default Contentful UI isn't streamlined enough.

Hi @knupska, thanks a lot for the detailed report, I appreciate the time you spent on investigation. And sorry for the delayed answer.
You're right, sdk.space.onEntityChanged is only accessible within the web app and can not be accessed from the public widget SDK. As you correctly said, exposing this method would allow reference cards to be updated whenever an entry is changed elsewhere.
I will ask the team managing https://github.com/contentful/ui-extensions-sdk if we can expose it.

Thanks for chasing it up @djagya.
Apologies for reporting it here too, I hadn't noticed those methods were actually being exposed by the ui-extensions-sdk package.

It's been some time (almost 3 years), can anyone at Contentful advise if this was ever added to the public widget SDK, or if it has otherwise changed in a way where it is now possible to achieve via an extension?

We encounter this behaviour in the latest app framework as well.
Using the renderCustomCard-prop will lead to not updated List if you add or edited an entry.


Polybar configs are missing the wireless network icons

Checking through the polybar configs the wireless network stus icons are missing from themes/[THEME ie Sky]/.config/polybar/config
Would you be able to add them to the config scripts please?

Hello, the network status icon in this theme is the standard NetWorkManager icon, this theme uses the system tray instead of a Polybar module. Just right click on your NetWorkManager and change the icon manually.