User in full control over comments

We would like to give the user more control over the comments:
Currently, before and after trivia are supported but this can lead to duplication of comments.
E.g. with find pattern
$S_A; $S_B;

and replace pattern
$S_B; $S_A;

with
before and after equal to All_Trivia.
The find pattern matches the following instance
a;
-- comment
b;

results in the replacement

-- comment
b;
a;
-- comment

However, we also want to enable tools to add marks to the code,
such that consequent changes are limited to the marked sections.
These comments should NOT be accessible by other users.

Problem
The following real world example shows why comment handling is needed.
-      return not
-        (R1 (1).X > R2 (2).X           --  R1 on the right of R2
-         or else R2 (1).X > R1 (2).X   --  R2 on the right of R1
-         or else R1 (1).Y > R2 (2).Y   --  R1 below R2
-         or else R2 (1).Y > R1 (2).Y); --  R1 above R2
+      return
+        (((R1 (1).X <= R2 (2).X) and then (R2 (1).X <= R1 (2).X))
+         and then (R1 (1).Y <= R2 (2).Y))
+        and then (R2 (1).Y <= R1 (2).Y); --  R1 above R2

Although one might wonder whether the comment is still correct after the transformation.
A Solution
Comments within place holders are part of that place holder.
In find and replace, these comments are thus just copied as part of the place holder.
Yet how to handle comments surrounding the place holders?
Users typically associate these surrounding comments in a particular way with the place holder,
e.g. comments before a function describe that function, comment after a statement describe that statement.
Example:
Suppose, the user wants to swap f and g.
  -- C0
  f;
  -- C1
  g;
  -- C2

What does he wants as end result?
  -- C0
  g;
  -- C1
  f;
  -- C2

  -- C1
  g;
  -- C2
  -- C0
  f;

  g;
  -- C2
  -- C0
  f;
  -- C1

or even
  -- C1
  g;
  -- C2
  -- C0
  f;
  -- C1

Proposed solution:

Introduce placeholders for comments to specify which are relevant and how they should be manipulated

Questions:

Should we match comments (only) or trivia (comments + white spaces)?
Proposal: comments only
Should we differentiate between single and multi-line / multiple comments?
Proposal: Only support list of comments (enforce usage of $M_ names)
Only add that a match can fail due to the absence of comment when there is a real pull!
Should we (still) allow our users to add regular comments to a replacement pattern?
e.g., z := max (x,y); -- PvdL: 2022-05-02 if statement replaced by max function
Proposal: Yes, just like we still allow identifiers as well!
Does a user want to specify that he only wants the last part of a comment?

So has
-- $M_X
-- $M_Y

a clear interpretation?
Ada Examples
Pattern
-- $S_comment_before
function $S_function

will match
instance
-- Describing comment of my_function
function my_function

Pattern
-- $M_comment_before
function $S_function

will match
instance
-- Describing multiline
-- comment of my_function
function my_function

The following design is proposed (for now):
In find patterns

[x] Either only comments with placeholders allowed
[ ] Or both comments with and without placeholders allowed: comments without placeholders must be exactly matched.

Note: using a check function, a comment can still be matched to a particular text.
In replace patterns

[ ] Either only comments with placeholders allowed
[x] Or both comments with and without placeholders allowed, comments without placeholders are just inserted as is.


Deprecate Schedule instructions for Timed instructions

Summary
This PR deprecates Schedule.instructions for Schedule.timed_Instructions(flatten=True), which will enable us to move towards a Schedule tree with Call instructions.
Details and comments

I'm a little confused about what this is accomplishing. instructions is a good and useful attribute.
Why accept flatten as an argument? The behavior is separate, isn't it? Rather than sched.timed_instructions(flatten=True), the user should write sched.flatten().timed_instructions if they want it "flattened". (Although I had thought that instructions were always returned flat)

The goal is to not return the time of every instruction. This will allow us to move to a representation that does not have absolute timing and Schedule instructions will be able to return the top-level instructions. This will enable code re-usue by only returning the top-level elements in the schedule tree.
I added flatten to maintain the current behavior. I don't want to return the inlined schedule tree but want to allow referencing of other schedules from within a schedule, these references should be made through a Call instruction which will be enabled once we go through this deprecation period.

Closing in favour of addressing this in the future IR.


Can you set ConfigValidationUtils.MAX_LEGTH longer

Exception in thread "thread-finconfig-firstLoad-pool-0" java.lang.IllegalStateException: Invalid file="-authorityFilter,-catconsumerfilter,-catproviderfilter,-dashboardFilter,-fintech_monitor,-fqtracerconsumer,-fqtracerprovider,-frameworkAttachmentCleConfigValidationUtilsanFilter,-ft_monitor,-ft_tracer_consumer,-ft_tracer_provider,-grpcFilter,-healthcheckfilter,-hystrixconsumerfilter,-ratelimiterfilter,-serviceinfofilter,-strace_log_monitor,-tr_monitor,-tracecontextfilter,-ucsProviderFilter" is longer than 200
at org.apache.dubbo.config.utils.ConfigValidationUtils.checkProperty(ConfigValidationUtils.java:583)
at org.apache.dubbo.config.utils.ConfigValidationUtils.checkMultiName(ConfigValidationUtils.java:558)
at org.apache.dubbo.config.utils.ConfigValidationUtils.checkMultiExtension(ConfigValidationUtils.java:520)
at org.apache.dubbo.config.utils.ConfigValidationUtils.validateAbstractInterfaceConfig(ConfigValidationUtils.java:298)
at org.apache.dubbo.config.utils.ConfigValidationUtils.validateReferenceConfig(ConfigValidationUtils.java:344)
at org.apache.dubbo.config.ReferenceConfig.checkAndUpdateSubConfigs(ReferenceConfig.java:420)
at org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:193)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:158)

case :  The custom filter will be called circularly. The referer parameter can be used to destroy the closed loop, for example, to exclude some filters, but it may exceed the parameter length limit（ConfigValidationUtils.MAX_LEGTH）

it is not easy to determine the proper length

Is it more reasonable for filter SPI strength exclusion to provide a prefix matching parameter, for example, according to the package name, other scenarios are similar

Is it more reasonable for filter SPI strength exclusion to provide a prefix matching parameter, for example, according to the package name, other scenarios are similar

Sounds good. But can we figure out all the cases?

Is it more reasonable for filter SPI strength exclusion to provide a prefix matching parameter, for example, according to the package name, other scenarios are similar

Sounds good. But can we figure out all the cases?

Well, yes, I feel that we can't take all the scenarios into consideration. However, it seems that there may be a large demand for customization of cluster and filter layer. Can we start with these two?

Is it more reasonable for filter SPI strength exclusion to provide a prefix matching parameter, for example, according to the package name, other scenarios are similar

Sounds good. But can we figure out all the cases?

Well, yes, I feel that we can't take all the scenarios into consideration. However, it seems that there may be a large demand for customization of cluster and filter layer. Can we start with these two?

Sure


[Feedback] This appears to be targeting the wrong API.

This appears to be targeting the wrong API.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4ad9f167-7d29-f933-7b47-60bd744899b1
Version Independent ID: 8097fcbd-adcc-ce49-a378-426c65af9296
Content: Send proactive messages - Teams
Content Source: msteams-platform/bots/how-to/conversations/send-proactive-messages.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: surbhigupta

@v-npaladugu - Thanks for reporting your issue.
Could you please elaborate more on your requirement?

@v-npaladugu -We have checked the API in this document but did not find any wrong API.
Looks like document is already updated.
We are closing this issue for now, please feel free to reopen it, if required.


Parser Error: Cannot infer the type of "next_location" variable because the value doesn't have a set type.

This error occurs on the latest download from the package on MacOS.
Anyone know how do you fix this type error?
Line 39:Cannot infer the type of "next_location" variable because the value doesn't have a set type.
Line 42:Cannot infer the type of "direction" variable because the value doesn't have a set type.
39		var next_location := _navigation_agent.get_next_location() // *** RED

		if not _navigation_agent.is_target_reached():
42			var direction := (next_location - global_position) // *** RED
			direction.y = 0
			direction = direction.normalized()

Duplicate of #23

location -> position


TODO: Add a test for mouse leaving browser window during table selection

A bug with the page not scrolling is fixed in https://github.com/facebook/lexical/pull/5919

Add a test to prevent regression
Steps to reproduce the bug before the fix:

Add a table with many rows so that it goes beyond the visible window
Mouse down on one of the cells close to the bottom of the window
Quickly move the mouse beyond the bottom window border

Result: The window is not scrolled
Expected result: The window is scrolled allowing selection of the table

Possible solution here: https://github.com/microsoft/playwright/issues/19203

I think this has since regressed because there wasn't any tests for it


save misses dependencies under build constraints

If a dependency is under build constraints that are not locally satisfied (for example, a foo_windows.go file on a unix machine), then godep save won't pick it up.

I believe that I created a duplicate issue at #161. However, some new information has come to light: if a library is using the ! operator in a build line (i.e. // +build !linux),  even the -tags parameter on go list won't help.

Closing in favor of #271.


Non-root Docker in Docker README changes

I walked through this tutorial and found that this sample code did not work for me.
*.socket should have been *.sock
and
Line 83 is actually ensuring that the docker-host.sock file exists before creating a symbolic link.
and
Line 90 is actually removing the symbolic link created above if that script gets executed. sudo socat will fail if docker.sock already exist.s
Let me know if this is incorrect.
I did not test out the other scenarios (docker compose + kubernetes).

Thanks!  I must have had autocomplete adding "et" when typing this up.  Appreciate it!


Error when building with ceres on ubuntu 22.04

My ceres-solver version is 2.2.0.
Part of the output in building process is as follows:

[ 73%] Building CXX object map/CMakeFiles/map.dir/src/rig.cc.o
[ 73%] Building CXX object map/CMakeFiles/map.dir/src/landmark.cc.o
[ 74%] Building CXX object map/CMakeFiles/map.dir/src/dataviews.cc.o
[ 74%] Building CXX object map/CMakeFiles/map.dir/src/observation.cc.o
[ 75%] Building CXX object map/CMakeFiles/map.dir/src/shot.cc.o
[ 76%] Building CXX object map/CMakeFiles/map.dir/src/map.cc.o
[ 77%] Building CXX object map/CMakeFiles/map.dir/src/tracks_manager.cc.o
In file included from /usr/local/include/ceres/rotation.h:52,
from /tmp/pip-req-build-6r3malib/opensfm/src/geometry/test/camera_functions_test.cc:2:
/usr/local/include/ceres/internal/euler_angles.h:84:45: error: ‘is_same_v’ is not a member of ‘std’; did you mean ‘is_same’?
84 |   static constexpr bool kIsParityOdd = std::is_same_v<ParityType, Odd>;
|                                             ^~~~~~~~~
|                                             is_same
/usr/local/include/ceres/internal/euler_angles.h:84:65: error: expected primary-expression before ‘,’ token
84 |   static constexpr bool kIsParityOdd = std::is_same_v<ParityType, Odd>;
|                                                                 ^
/usr/local/include/ceres/internal/euler_angles.h:84:67: error: ‘constexpr’ static data member ‘Odd’ must have an initializer
84 |   static constexpr bool kIsParityOdd = std::is_same_v<ParityType, Odd>;
|                                                                   ^~~
/usr/local/include/ceres/internal/euler_angles.h:84:67: error: expected ‘;’ at end of member declaration
84 |   static constexpr bool kIsParityOdd = std::is_same_v<ParityType, Odd>;
|                                                                   ^~~
|                                                                      ;
/usr/local/include/ceres/internal/euler_angles.h:84:70: error: expected unqualified-id before ‘>’ token
84 |   static constexpr bool kIsParityOdd = std::is_same_v<ParityType, Odd>;
|                                                                      ^
/usr/local/include/ceres/internal/euler_angles.h:86:12: error: ‘is_same_v’ is not a member of ‘std’; did you mean ‘is_same’?
86 |       std::is_same_v<AngleConventionType, ProperEuler>;
|            ^~~~~~~~~
|            is_same
/usr/local/include/ceres/internal/euler_angles.h:86:41: error: expected primary-expression before ‘,’ token
86 |       std::is_same_v<AngleConventionType, ProperEuler>;
|                                         ^
/usr/local/include/ceres/internal/euler_angles.h:86:43: error: ‘constexpr’ static data member ‘ProperEuler’ must have an initializer
86 |       std::is_same_v<AngleConventionType, ProperEuler>;
|                                           ^~~~~~~~~~~
/usr/local/include/ceres/internal/euler_angles.h:86:43: error: expected ‘;’ at end of member declaration
86 |       std::is_same_v<AngleConventionType, ProperEuler>;
|                                           ^~~~~~~~~~~
|                                                      ;
/usr/local/include/ceres/internal/euler_angles.h:86:54: error: expected unqualified-id before ‘>’ token
86 |       std::is_same_v<AngleConventionType, ProperEuler>;
|                                                      ^

...

make[2]: *** [geometry/CMakeFiles/geometry_test.dir/build.make:90: geometry/CMakeFiles/geometry_test.dir/test/camera_functions_test.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:822: geometry/CMakeFiles/geometry_test.dir/all] Error 2
[ 81%] Linking CXX executable map_test
/usr/bin/ld: CMakeFiles/map_test.dir/test/tracks_manager_test.cc.o: in function testing::internal::TestFactoryImpl<(anonymous namespace)::TracksManagerTest_ReturnsAllCommonObservations_Test>::CreateTest()':       tracks_manager_test.cc:(.text+0xe90): warning: the use of tmpnam' is dangerous, better use `mkstemp'
[ 81%] Built target map_test
make[2]: *** [robust/CMakeFiles/robust.dir/build.make:146: robust/CMakeFiles/robust.dir/src/instanciations.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:876: robust/CMakeFiles/robust.dir/all] Error 2
[ 82%] Linking CXX static library libbundle.a
[ 82%] Built target bundle
make: *** [Makefile:101: all] Error 2
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/tmp/pip-req-build-6r3malib/setup.py", line 60, in
build_c_extension()
File "/tmp/pip-req-build-6r3malib/setup.py", line 54, in build_c_extension
subprocess.check_call(
File "/home/xianjing/anaconda3/envs/2Dmap/lib/python3.9/subprocess.py", line 373, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '-j72']' returned non-zero exit status 2.

Do you have any idea about the problem?

I tackled this problem by installing ceres-solver 2.0.0.

I tackled this problem by installing ceres-solver 2.0.0.

thanks very much! This problem has stuck me for ten days!


Returns same comment form for different model when requesting from same template.

This error occurs when we  request for comments for more than one models from same template.
Use case :
Let's initially we request for comment for model Question in the same context again request for comment for Answer model then it returns same form since try catch statement bypasses update of form.
Code from  /mezzanine/generic/templatetags/comment_tags.py
def comments_for(context, obj):
...
26    try:
27        context["posted_comment_form"]
28    except KeyError:
29        context["posted_comment_form"] = form
30    context["unposted_comment_form"] = form
31    ...

Error at line number 26.
Small fixed for this.
Replace try catch block with below code.
if context.get("posted_comment_form") is None or \
                    context.get("posted_comment_form") != form:
        context["posted_comment_form"] = form
        context["unposted_comment_form"] = form

Can you provide a minimal sample project that reproduces this issue?

I am having too many files in project so it will take some time to create project so , I am providing template here which will produce this error.
       ...

       ...
            {% comments_for object %}
       ...

       ...

        {% if answers %}

Answer{{ len|pluralize }}

            {% for answer in answers %}
                     ...
                    {% comments_for answer %}
                     ...
            {% endfor %}
        {% endif %}

       ...

In this template  comments_for is requested twice with different objects. According to the code given in comments_tags it will treat both as same object since context would be having posted_comment_form.
I hope this would be sufficient if not let me know, I will create a project for this error.

That makes more sense, thanks.

Hi!
I  think I've got  a really pleasant surprise for you, you'll like it I swear  http://bysygene.fostersfrostings.com/e7oesyv
Kind regards, daro822


Should have a way to bring across changes

After a source project has been migrated, if there are some changes (like new test suites/plans, new work items, updates on some migrated work items), the tool should be able to sync this change to target project.

Agreed and some of that is possible, if you have:

added Plans, Suits, or Test Cases then you can just re-run the migrator.

Added Work Items then you can re-run and it will migrate those left.

What I would like to be able to have is to Update already existing Work Items if they have changed since the last time they were migrated. This is however more complicated and can result in way more edge cases. Its on the backlog...

No one has stepped up to implement..

Is the "WorkItemUpdateConfig" meant for this? I haven't found much documentation about this yet.

No, WorkItemUpdate is used for in place editing of a single TFS or Azure DevOps instance.


encounters

Current dependencies on/for this PR:

master

PR #9

PR #10   👈

This comment was auto-generated by Graphite.

Merge activity

Oct 12, 6:12 PM: @mazylol started a stack merge that includes this pull request via Graphite.


Move com.canoo.platform.remoting.server.spi to com.canoo.platform.remoting.server.event.spi

🆕🐥:dog: First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
:space_invader: Description of the issue
Since the content of the SPI package is only related to the event bus it should be a sub package of the event bus.
📋 Step by Step

🙋 Claim this issue: Comment below.
🔄 replace the up for grabs label with in progress.
:fork_and_knife: fork the repository in github by simply clicking the 'fork' button.
:arrow_heading_down: check out the forked repository
:twisted_rightwards_arrows: create a feature branch for the issue. We do not have any naming definition for branches.
💾 Commit your changes.
🔀 Start a Pull Request.
🏁 Done 👍 Ask in comments for a review :)
🔬 If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
:boom: you did it! We will merge the fix in the master of the Dolphin Platform project.
:bouquet: Thanks, thanks, thanks for being part as an open source contributor for Dolphin Platform

🤔❓ Questions
You can join our community chat at Slack

Hey, can I give this a go?

@Jarota sure :)

see https://github.com/canoo/dolphin-platform/pull/666

This is already done...hence closing.


Mention commit method in README?

There's a mention about autoCommit flag that refers to commit method but no discussion of commit method itself. It could be a good idea to cover that.

It would be a good idea indeed.

+1

I added a note about tree.commit in the update section. Is that sufficient?

Yeah, at least now you know it's there. :+1:
Maybe it would be a good idea to split up the docs at some point and just leave an overview at README.


Subtask of MDC-Migratation: Mat-Cards

https://material.angular.io/components/card/api
No style changes to note about these components, they should look the same as before.

QA: Passed


Can I use antigen for installation?

Can I use antigen (https://github.com/zsh-users/antigen) to apply this theme, so that users simply apply like antigen theme hohmannr/bubblified? I think then more people can enjoy this awesome theme. Please consider this.
For example, currently I'm using spaceship-prompt (denysdovhan/spaceship-prompt) using antigen.

This is a good idea, I have not thought about this, but will consider this in a future update.

Antigen is awesome and already compatible with this theme. For me it worked without changing anything. I will update the README.


[Draft] Support spot-to-spot consolidation.

Description
This PR is a feature for enabling spot-to-spot "replace" consolidation for AWS Karpenter. It provides an option for the customers to enable/disable the spot-to-spot consolidation through a feature flag named as SpotConsolidation. By default the feature is turned off. The spot consolidation would kick-in only when there are a minimum of 15 instanceTypes for the new NodeClaim to replace the current spot candidate. This condition is valid for both single and multi-node spot-to-spot consolidation. The value (15) for minimum number of InstanceTypes is currently hard coded based on the analysis performed on the flexibility of AWS customer requests.
Issue#: https://github.com/kubernetes-sigs/karpenter/issues/763
How was this change tested?
Added functional tests and end-to-end tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nikmohan123 Just passing over this, but looks like you need to sign the CLA as noted here: https://github.com/kubernetes-sigs/karpenter/pull/897#issuecomment-1863478799

/ok-to-test

@nikmohan123 Just passing over this, but looks like you need to sign the CLA as noted here: #897 (comment)

I added the missing CLA Authorization for EasyCLA in the link attached in the description but it still shows it as missing for some reason.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

35 of 40 (87.5%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 80.13%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/disruption/consolidation.go
29
34
85.29%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
7662

Relevant Lines:
9562

💛  - Coveralls

/hold Wait for @njtran review prior to merge

/unhold Let's go!

/unhold
Let's go!


ggez?

I'm struggling to find enough free time, but work is sloooowly goes on.

^ I had a few hours off this evening and here's the first screenshot of an almost playable port of Zemeroth to ggez :tada:

Almost there... Only correct sprite offsets, colors and a few UI tweaks left.


Add regression test for #231 - via an element that modify its children.

A misbehaved element that modifies its children should not disturb the part finding on instances. This was originally reported in #231 as a problem with ShadyDOM.

not sure if it's the same but also related to ShadyDom.
A dom node with shadow dom will prevent lit-html from setting properties of any light-dom element in polyfilled browsers like FireFox
something like this should work right?
class FooOne extends HTMLElement {
  constructor() {
    super();
    this.attachShadow({ mode: 'open'});
    this.fooOne = 'fooOne';
  }
  connectedCallback() {
    this.shadowRoot.innerHTML = 'shadow-dom
<slot></slot>';
  }
}
customElements.define('foo-one', FooOne);

render(html`
  <foo-one>
    light-dom
  </foo-one>
`, document.querySelector('#target'));

if not it would be a pretty HUGE deal right? I mean you could use it for only one level deep? even though you are only light-dom elements... => however could also be a "bug" in shadyDom? (maybe not moving properties along?)
So here is the full example which runs fine in Chrome but fails in Firefox.
https://codepen.io/daKmoR/pen/jKPReb
I sure hope this can be "fixed" - and it may need a higher priority then "low" :see_no_evil:

@bgotink oh yeah that did the trick :)
@justinfagnani any chance for a bugfix release?

This isn't going to be very practical to test, since elements are barred from modifying their light children or attributes in the constructor. Going to close this now.


Non-deletable stores.

I just realized that the zipStore does not allow deletion (and thus does not allow rename).
Is that something that should be addressed in the spec, of should it maybe be fixed in the ZipStore with TombStones ?

Hi @Carreau, I think it is reasonable if a store does not support deletion. If you agree, then yes I'd suggest we clarify that supporting deletion is optional somehow. E.g., maybe stores can be readable, writable, deletable, listable, these are the basic capabilities. A store that is only readable can still be useful. Similarly a store that is only readable and writable can still be useful.

That's fine with me, but that's push more complexity on the Zarr Protocol implementation, while you could try to push the deletion implementation details to the store. That seem also to be there only to accommodate the zip store.

Think what Matthias was referring to is ZipStore allows writing, but not deletion. So the erase* functions don't work. Similarly writing behaves more like write-once (since deletion is not supported).
That said, think in practice ZipStore behaves better as a "readable store" (ignoring the initial creation step). This is already a common case like a read-only filesystem or HTTP stores is a common use case that we would want to support, which is covered under "readable store".
Side note: We may prefer to fix the ZipStore oddity ( https://github.com/zarr-developers/zarr-python/issues/828 ) either by making it more feature complete ( https://github.com/zarr-developers/zarr-python/pull/1184 ) or moving it to read-only.

Thanks for the clarification @jakirkham! Do you think there's a TODO for the current v3 core spec from this issue? I'm re-opening it, but I'm not quite sure if this belongs into the zarr-specs repo or rather zarr-python? Sorry for the confusion, seems like I'm missing some context here. @joshmoore, can you help?

Seems like there's enough confusion around this that we should minimally try to add our expectations in the V3 spec and possibly V2. @Caviere will soon be investigating the ZipStore and we can try to dig into these questions which may then lead to wanting to address delete-ability more broadly in the spec.

Since the zip store is currently not yet specified in v3 I assume this does not block ZEP 1, which is mostly about the core spec. Further clarifications can also be added to the core spec after ZEP 1 is accepted.


Mismatch of the format specifier and variable type

When compiling circllhist_print.c, Clang emits the following warning due to mismatch of the format specifier and variable type.  This does not happen on 64-bit machines, because size_t is 64-bit long there and matches uint64_t, but on 32-bit it is not.
circllhist_print.c:28:49: warning: format specifies type 'size_t'
      (aka 'unsigned int') but the argument has type 'uint64_t' (aka
      'unsigned long long') [-Wformat]
        printf("%s\"%g\":%zu", i ? "," : "", v, vc);
                         ~~~                    ^~
                         %llu
1 warning generated.

Thanks for sending this in. I have a opened a PR with a fix here:
https://github.com/circonus-labs/libcircllhist/pull/55
Do you want to check if this works on your machine?


728 - Question page preview

What is the context of this PR?
Implement preview for the question page including all answer types. This is a lift and tidy from the prototype #487
There are no cypress tests for this as I'm not sure what it could do.
How to review

Ensure it matches (where appropriate) the netlify preview in #487

 UI - Question page preview

 UI - Question page preview

Bug resolved but that should have been covered by the unit tests which were also causing the null snapshots. I think cypress feels like a hammer to crack a nut as we are not managing external state or making network calls.
@SamGodwin2 and @samiwel what do you think?

I appreciate as there are no user interactions on the preview page Cypress might be overkill in this scenerio. I feel it would definately be useful to build an entire page, then validate it is previewed as expected.
An alternative solution could be: https://github.com/americanexpress/jest-image-snapshot.
It is also worth adding Cypress tests to ensure you can switch between Builder / Preview tabs.

I appreciate as there are no user interactions on the preview page Cypress might be overkill in this scenerio. I feel it would definately be useful to build an entire page, then validate it is previewed as expected.
An alternative solution could be: https://github.com/americanexpress/jest-image-snapshot.
It is also worth adding Cypress tests to ensure you can switch between Builder / Preview tabs.

I think unit-testing the display logic around missing content is enough?

 UI - Question page preview


Does SK6812MINI-E work in Corne 2.1 Choc?

Well, i realised i had bought the wrong version of SMD LEDs.  Before trying to solder them i wanted to ask if it is compatible.
Would it work at all?
Or must i buy the SK6812MINI also?

SK6812MINI-E is not compatible with SK6812MINI.

I am ordering SK6812MINI 3535 (3.5 mm) Correct?

yes


ENG-6277-update kotlin

Advanced device signal React Native Android sdk is compiled on Kotlin 1.8 version.

We will add an exclude group: 'org.jetbrains.kotlin', module: 'kotlin-stdlib' in the sandbox to avoid this issue.


allow to skip the TOC on fabric and device documentation

Enhancement summary
Make the rendering of the TOC optional
Which component of AVD is impacted
eos_designs, eos_cli_config_gen
Use case example
In my project I use one repo to generate configs and documentation for multiple sites and fabrics. I am using mkdocs to consolidate the generated documents and build the aggregated docs nicely in one interface. mkdocs with material theme automatically generates navigation lings with TOC on the right panel.
Therefore if I build documentation like this, I would like to leverage the AVD generated markdown documents but would like to skip the TOC on each of them since this is already handled for me with mkdocs.
Describe the solution you would like
TOC rendering with the option to disable it on input vars
Describe alternatives you have considered
Forking the documentation templates or building a custom template for device and fabric documentation.
Additional context
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

As a note, the rendering seemed correct on this demo for fabric:
https://github.com/arista-netdevops-community/ansible-avd-cloudvision-demo/blob/master/inventory/documentation/DC1_FABRIC/DC1_FABRIC.md?plain=1
But not for devices:
https://github.com/arista-netdevops-community/ansible-avd-cloudvision-demo/blob/master/inventory/documentation/devices/DC1-L2LEAF1A.md?plain=1

Partially duplicate of #1748

I suggest to change this request to only the optional TOC, and then add your input on headers to #1748.

Sounds good. I have edited the issue description accordingly and added my comment to the other issue.

For skipping TOC on device docs, we just need to adjust this to "{{ device_documentation_toc | arista.avd.default(true) }}" (or whatever key we decide on)

This issue is still relevant.

Sure. We have removed the auto-close, so it will stay open.


GEN-31: Meeting Notes: Week #5 Meeting #5

To Do

Take notes during the meeting.
Create the wiki page.
Add links to Sidebar and Homepage.

Deadline
04.11.2022 @23.55
Additional Information
Reviewer: @BElifb

Added week 5 meeting 5 to the sidebar and homepage. Can be found here.

We have talked about two additional tasks:

Our label format should be fixed. We have labels like Priority: High, Effort: Low and labels like documentation, backend etc. I think we have to convert all labels to the former format. (like Type: Documentation, Team: Backend, Status: Postponed)
We have to design several logos for our project and pick one of them.

I though we could assign those to @dundarmete if it's ok with him as well. What are your opinions on that?

First point seems totally reasonable, we can easily do that. Logo design was mentioned but we haven't assigned it to anyone yet. There are two options: we can either assign it to one or a few people, or we can follow a voluntary system and choose the most liked logo.

Assigning to a few people seems like a luxury while there are lots of other things to do. I guess we are waiting for the response of @dundarmete at this point.

You can assign me to both of these tasks, no problem.

Added mentioned tasks.


Unifi device_tracker - crashes HA

For some reason Home-assistant crashes with device tracking for Unifi enabled. Logs says nothing..
With the following enabled, it wont start.
'
device_tracker:

platform: unifi
host: <IP_ADDRESS>
username: !secret unifi_username
password: !secret unifi_password
verify_ssl: false
detection_time: 15
site_id: 0wpdeg12
'

If you've never had it running it is probably something wrong with your configuration

I also experienced this issue. Up until 2 days ago the device tracker had been working fine for months. Then Hassio appeared to die with nothing I could find in the logs. Removing the tracker from the configuration fixed the issue.

Allright, I know nothing about that.

Maybe it is related to the device tracker change?

I fixed it. For me the issue was that the actual Unifi Controller had run out of disk space, locking it up. I gave it more space and updated all my software and everything works again.

Great to hear. Closing this issue then.


Create DelegatingInsertOperation. #48

Rebased on master.

Codecov Report

Merging #49 into master will increase coverage by 0.32%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   31.99%   32.31%   +0.32%
==========================================
  Files         126      127       +1
  Lines        1047     1052       +5
  Branches       40       40
==========================================
+ Hits          335      340       +5
  Misses        711      711
  Partials        1        1

Impacted Files
Coverage Δ

...ntentpal/operations/DelegatingInsertOperation.java
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e70cb...1a8137d. Read the comment docs.


added county text_field to _patient_information

I rule and have completed some work on Case Manager that's ready for review!
(brief, plain english overview of your changes here)
After examining, patient.rb, I found that field :county, type: String was already there.  So I only needed to add a text field to the _patient_information form.
This pull request makes the following changes:
It adds a text input into the __patient_information form.  Corrects issue "Add optional county field #1016"
(If there are changes to the views, please include a screenshot so we know what to look for!)
Added county text input under City and State

It relates to the following issue #s:

Fixes #1016

looks good @electricflannel ! We'll get this in after the patient/pregnancy PR gets merged. Thanks a ton!

Codecov Report

Merging #1034 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   95.54%   95.54%
=======================================
  Files          48       48
  Lines         898      898
=======================================
  Hits          858      858
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f79400...0980e6d. Read the comment docs.

Deep dug into the patient params atm - I think we need to add this to the strong params as well?

@lomky is right on here -- this'll get swallowed by the controller if we don't bump it. My mistake, sorry all!
@electricflannel could you pop into patients_controller and add  :county to the PATIENT_INFORMATION_PARAMS constant when you get a sec?

Hey @colinxfleming and @lomky, I just added the :county to strong params, so I think we are good to go!

This looks great, thanks @electricflannel ! I'm going to spin up a test in a separate PR to give you an example of that, so you know what you're looking for and next time you can learn some unit testing. Hang tight.


Users schema and controllers.

User Schema to add what data is to be added in the user profile like username, email, social links, about user.
User controllers to perform CRUD operations for users.
If these are required to be stored in MongDB,.

Not required at the moment still working on its workflow design


plotLoadings, absolute scale

Now loadings can be visualized with barplot also in absolute scale. That is the default choice.
The reason is that original scale takes too much space since values can be negative and positive. Moreover, the effect size cannot be easily compared between positive and negative values (that is the most important info)

In absolute scale, there the comparison is easier. +/- shows whether the value is positive or negative

How about distinguishing the positive vs. negative with a color instead?

With colors, it seems to be easier to see +/-

Yes. You also sometimes see this done so in literatures.
Just thinking if the default should be lines instead of bars ("lolliplot plot")?


New item should submit when losing focus

First... this is very nice. I love what you've done here.  I tried the app and noticed something, so I thought I'd post.
When I click outside of the entry, it still shows as 'pending' and will even allow me to start another item. I recommend that it submit after it loses focus in addition to the , which is the only way I can see to submit it currently.
Again, great job. I look forward to seeing the finished product.

Great thank you for your feedback, I will look into it as soon as I can.
I'm going to be working of this for a while yet. The version that you are viewing is a prototype/mock-up/proof of concept.
The is a problem with that model and tkinter treeview for that matter. The problem is viewing large trees, Treeview starts to bog down when the tree gets to large.
To get around this you need to use paging and only load the tree with 3 or 4 times what the display can show and page in the data as needed.
To manage this, I have written a module call mem_tree, mem_tree can hold large trees (as many as you want) in memory which can be paged into Treeview as needed.
So, what I'm trying to say is use the demo as a learning tool, the final product will be when I meagre the two.
Here is a link to mem_tree, mem_tree can be used as an app cache, it's really a dictionary on steroids but has many uses.
https://github.com/unodan/Mem_Tree
[https://avatars0.githubusercontent.com/u/6221775?s=400&v=4]https://github.com/unodan/Mem_Tree
unodan/Mem_Treehttps://github.com/unodan/Mem_Tree
In memory tree structure. Contribute to unodan/Mem_Tree development by creating an account on GitHub.
github.com

From: Israel Dryer<EMAIL_ADDRESS>Sent: June 29, 2020 2:03 PM
To: unodan/TkInter-Treeview-Example-Demo<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [unodan/TkInter-Treeview-Example-Demo] New item should submit when losing focus (#1)
First... this is very nice. I love what you've done here. I tried the app and noticed something, so I thought I'd post.
When I click outside of the entry, it still shows as 'pending' and will even allow me to start another item. I recommend that it submit after it loses focus in addition to the , which is the only way I can see to submit it currently.
Again, great job. I look forward to seeing the finished product.
[image]https://user-images.githubusercontent.com/42584742/86039819-ffad1e00-ba10-11ea-8faf-5656c17d3f13.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/unodan/TkInter-Treeview-Example-Demo/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPO7T4S2F3SNAZUEFD3OZLRZDJQ3ANCNFSM4OLOUJHA.


Add support for context manager dependencies

There is currently support for dependency-generators, with yield syntax. It is also worth adding support for context managers (__enter__, __exit__, __aenter__ and __aexit__), as they implement the same functionality, but are more convenient to use outside DI.

Agree, actually. Should not be hard to implement, though.


Update target profile page description section

In the new target ETL and API schema, the description displayed at the top of the target profile page is now returned in the target.functionDescriptions field.
Can we please update the query to use this new field?
query targetInfo {
  target(ensemblId: "ENSG00000232810") {
    approvedSymbol
    approvedName
    functionDescriptions
  }
}

Example query: TNF

Ticket closed as work complete and merged into main! 👍


[BUG] RKE Kubernetes upgrades with Oracle 7.9 nodes break replicas until rebooted

Describe the bug
The Longhorn docs indicate that Kubernetes don't require any special steps for Longhorn nodes. While this is the case with Ubuntu nodes, this is not the case with Oracle  Linux 7.9 nodes.
After a Kubernetes upgrade, volumes seem to get stuck in a detaching state, and replicas eventually move to a failed state in a few minutes. I've had one even disappear. They never rebuild and come back as they do on Ubuntu nodes. Rebooting the workers fixes this.
In the Rancher UI, pods that use the volume show these messages:
Warning	FailedMount	Unable to attach or mount volumes: unmounted volumes=[prometheus-rancher-monitoring-prometheus-db], unattached volumes=[prometheus-nginx nginx-home config-out tls-assets prometheus-rancher-monitoring-prometheus-db prometheus-rancher-monitoring-prometheus-rulefiles-0 rancher-monitoring-prometheus-token-hq7jf config]: timed out waiting for the condition	a few seconds ago

Warning	FailedMount	MountVolume.WaitForAttach failed for volume "pvc-beda61b6-e7cb-4407-acdd-8fefb15ec186" : volume pvc-beda61b6-e7cb-4407-acdd-8fefb15ec186 has GET error for volume attachment csi-1f7b15e40fde84f27d6f398a75b3f0a941dcb2d033a09a4c7288ae52a35a4187: volumeattachments.storage.k8s.io "csi-1f7b15e40fde84f27d6f398a75b3f0a941dcb2d033a09a4c7288ae52a35a4187" not found	a minute ago

Warning	FailedMount	Unable to attach or mount volumes: unmounted volumes=[prometheus-rancher-monitoring-prometheus-db], unattached volumes=[prometheus-rancher-monitoring-prometheus-rulefiles-0 rancher-monitoring-prometheus-token-hq7jf config prometheus-nginx nginx-home config-out tls-assets prometheus-rancher-monitoring-prometheus-db]: timed out waiting for the condition	2 minutes ago

Warning	FailedMount	Unable to attach or mount volumes: unmounted volumes=[prometheus-rancher-monitoring-prometheus-db], unattached volumes=[config-out tls-assets prometheus-rancher-monitoring-prometheus-db prometheus-rancher-monitoring-prometheus-rulefiles-0 rancher-monitoring-prometheus-token-hq7jf config prometheus-nginx nginx-home]: timed out waiting for the condition

I also found these errors in the Longhorn support bundle:
longhorn-manager-nkz2n/longhorn-manager.log:2021-04-29T19:05:17.168313544Z time="2021-04-29T19:05:17Z" level=warning msg="Instance pvc-beda61b6-e7cb-4407-acdd-8fefb15ec186-r-de5079dd is state error, error message: Instance Manager errored"

longhorn-manager-nkz2n/longhorn-manager.log:2021-04-29T19:05:17.168318870Z time="2021-04-29T19:05:17Z" level=debug msg="Instance handler updated instance pvc-beda61b6-e7cb-4407-acdd-8fefb15ec186-r-de5079dd state, old state running, new state error"

longhorn-manager-nkz2n/longhorn-manager.log:2021-04-29T19:06:27.172522896Z time="2021-04-29T19:06:27Z" level=warning msg="cannot get crash log for instance pvc-beda61b6-e7cb-4407-acdd-8fefb15ec186-r-de5079dd on Instance Manager instance-manager-r-8f88c18f at ip-172-31-30-1, error rpc error: code = NotFound desc = cannot find process pvc-beda61b6-e7cb-4407-acdd-8fefb15ec186-r-de5079dd"

To Reproduce
Steps to reproduce the behavior:

Spin up 3 EC2 nodes using an Oracle 7.9 image (marketplace for the one I used). Each should have two extra EBS volumes (important for setup steps). One for /var/lib/docker and another for /var/lib/longhorn. Run these commands to set them up to be used as the Kubernetes nodes.
Set up a Rancher 2.5.x. Use the EC2 nodes as downstream custom cluster nodes with all roles.
Install Longhorn 1.1.0
I installed Rancher Monitoring with Longhorn for the Prometheus volume (to ensure I had some data)
Upgrade Kubernetes. Eventually, the volume for Prometheus will degrade and never return.

Expected behavior
Eventually, the replicas/volume should reconcile.
Log
longhorn-support-bundle_b5fbb11f-2341-4bba-940d-35c1eba5f06e_2021-04-29T19-23-45Z.zip
Environment:

Longhorn version: 1.1.0
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Rancher Apps & Marketplace
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: RKE / Rancher custom cluster
Node config

OS type and version: Oracle Linux 7.9
CPU per node: 4
Memory per node: 16
Disk type(e.g. SSD/NVMe): Two extra EBS, one at /var/lib/docker (btrfs) and another at /var/lib/longhorn (xfs)
Network bandwidth between the nodes: n/a

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): AWS EC2
Number of Longhorn volumes in the cluster: 1

Additional context
The extra EBS volumes are there to match the customer's infrastructure as much as possible, but I do not suspect that they make a difference here. /var/lib/longhorn is xfs which is supported and /var/lib/docker is btrfs which is supported by docker as well.

@bentastic27 Looks good! Definitely what I experienced.

Thanks for the reporting, we knew this issue already and create a task.

In future we might want to test this with wordpress app deployed in Rancher too as one customer has reported the problem with wordpress app too.

The volume should be finally returned to healthy status, but it seems in this case, it didn't get back.
@jenting curious of anyone already checked this support bundle?

Kubernetes upgrade will lead to pod restart. This is fatal for Longhorn system. Since Longhorn uses instance manager pods to manage replicas and engines of volumes. Once the instance manager pod is down, the related replica/engine will crash then the volume will become degraded or faulted. This is why you saw volume pvc-beda61b6-e7cb-4407-acdd-8fefb15ec186 crash during the upgrade.
I am not sure which worker you reboot. But some nodes in your cluster loop in Ready and NotReady. This means the instance manager pods cannot be restarted then the replicas on the nodes cannot be rebuilt.
2021-04-29T19:05:16.840233911Z time="2021-04-29T19:05:16Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"ip-172-31-30-1\", UID:\"e7863bd4-1090-4181-b428-54c0159dfae0\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"13129\", FieldPath:\"\"}): type: 'Normal' reason: 'Ready' Node ip-172-31-30-1 is ready"
2021-04-29T19:05:16.840267974Z time="2021-04-29T19:05:16Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"ip-172-31-30-1\", UID:\"e7863bd4-1090-4181-b428-54c0159dfae0\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"13129\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node ip-172-31-30-1 not ready: KubeletNotReady"

2021-04-29T19:04:47.253785034Z time="2021-04-29T19:04:47Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"ip-172-31-30-83\", UID:\"4677b063-510a-4079-8357-cc9d6b05457f\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"12839\", FieldPath:\"\"}): type: 'Warning' reason: 'Ready' Kubernetes node ip-172-31-30-83 not ready: KubeletNotReady"
2021-04-29T19:04:47.271894469Z time="2021-04-29T19:04:47Z" level=info msg="Event(v1.ObjectReference{Kind:\"Node\", Namespace:\"longhorn-system\", Name:\"ip-172-31-30-83\", UID:\"4677b063-510a-4079-8357-cc9d6b05457f\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"12839\", FieldPath:\"\"}): type: 'Normal' reason: 'Ready' Node ip-172-31-30-83 is ready"

We will check if there is a better way to handle the Kubernetes upgrade. For now we would recommend to detach all volumes before the Kubernetes upgrade only.


NEXT-00000: disable indexing in PaymentMethodIndexer to prevent infinite loop

1. Why is this change necessary?
PaymentMethodIndexer triggers new PaymentMethodIndexingMessage after indexing.
2. What does this change do, exactly?
Disable indexing to prevent infinite loop
3. Describe each step to reproduce the issue or behaviour.
see #3430
4. Please link to the relevant issues (if any).
closes #3430
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

🤖[deprecated] Generated by Copilot at df0accf
Fixed a bug that caused infinite recursion when indexing payment methods. Introduced a new context flag to skip indexing during updates in PaymentMethodIndexer.php.

🤖[deprecated] Generated by Copilot at df0accf

Create a new context with disabled indexing to avoid triggering the indexer again when upserting payment methods (link,link)
Pass the new context to the generateDistinguishablePaymentNames method, which updates the payment method names to avoid duplicates (link)
Dispatch the PaymentMethodIndexerEvent with the original context to notify other listeners of the changes (link)
Import the Context and EntityIndexerRegistry classes from the Shopware\Core\Framework namespace (link)

Hi @niklaswolf,
would you mind adding a unit test in /tests/unit/ and also a changelog file in /changelog/_unreleased? You can find a template for that changelog file in the changelog directory.
Thanks!

@mstegmeyer done :)

Your PR has been merged. Thank you for your contribution 🎉 💙


Travis integration allowed to fail on latest build.

Travis integration fails on the nightly build. I guess the failure is because of normalize! being included in the base(the fix however lies in QuBase). As everything works fine on release version, build constraints are changed such that a failure is allowed to fail on nightly build.

@acroy thoughts on this would be helpful. Thanks !

Nice feature! Looks good.

Merging this !


Add the option of enabling TLS for sending traces

Is your feature request related to a problem? Please describe
We would like to enforce TLS for sending our traces. But we are not able to do it for nginx traces as nginx-otel does not have any config option to enable it.
Describe the solution you'd like
Beeing able to specify:

that we want to send our traces over TLS
toggle an insecure mode in order to disable certificate verification

Describe alternatives you've considered
None.
Additional context
None.

We have this feature (and few other features) in our roadmap:
otel_exporter {
ssl on | off;   # “off” by default
trusted_certificate “path/to/ca/bundle“;
}
Trying to understand priorities for those. So, thank you for your interest in this module and for submitting a feature request.

I`m also interesting to use https for collector endpoint with tls option insecure_skip_verify
its very important for our stack,
How long needs to wait about this feature?

We are going to implement TLS export, but I'm not sure about 'insecure_skip_verify'. If you need such option, perhaps, you don't really need TLS. As a workaround for now you can try to use otelcol, which can accept HTTP and reexport via HTTPS.

If I understand the problem correct, the way we've gotten around this is by doing the following:

Create a new server block in nginx for the otel upstream
Set up grpc_pass, grpc_ssl_certificate, and grpc_ssl_certificate_key in the block
Point the otel_exporter block to localhost: for the server block created in step 1.
We also set otel_trace off for this server block so we don't create spans for nginx sending a trace to the otel upstream.

Would that solve this use case?

I`m also interesting to use https for collector endpoint with tls option insecure_skip_verify its very important for our stack, How long needs to wait about this feature?

I mean, need to skip certificate verification. Because, using self signed ssl and some time there are problems, with adding these everytime.

Any update of this issue?

Any update of this issue? We need to have this option too.

@dplotnikov-f5

@vladimirkokshenev

Now TLS can be enabled by specifying "https" scheme in the endpoint. By default, system CA bundle is used to verify endpoint's certificate, but this can be overridden with "trusted_certificate" directive.
otel_exporter {
    endpoint "https://otel.labt.fp.f5net.com:4433";

    trusted_certificate “path/to/custom/ca/bundle“; # optional
}


Move cleric doctrine data to enable homebrew

Migration number is 831 to allow for #6640 to be merged prior to this one more painlessly.

How does this and the barbarian changes relate?

Just anticipating that one getting merged first so the conflict with this one is smaller.


Projection matrix for depth images?

Where can I find the k matrix for projecting the depth to points? I am working with the raw dataset for now and if I recall correctly the Matterport exports individual k matrices for each viewpoint.

it's 0.5, 0.5, 0.5, 0.5.


Replace stdlib phase 1

This incldues the std lib interface and implementation in each respective bs-containers module, removing them from and simplifying containers.ml to now just be simple aliases. Next step will be to rename and clean up the std lib interfaces, aliasing each function individually. Phase 3 will be to replace them with our own implementations.
PS: note that the hashtbl include was just removed instead of moved into bhashtbl, since it proved to be rather difficult to untangle all the module interdependencies cleanly. It will probably be easier to just rebuild it manually instead of going through the intermediary alias step.

Exactly what I wanted to do, will review today.

Looks good


File not uploading to the SFTP server

I have a question not an issue--big thanks up front:
I'm trying to use your "put" method, but the file is not being sent to the server.  I'm not getting any error messages.  Would this code work below?  By the way, the sftp.list method is working!

Nevermind!  I got it to work using the zlib compression below--thank you for your code:
sftp.put("/home/user/sftp/file.txt", "/upload/file.txt", "zlib");

@talbotlawrence thanks for your advice

For anyone got the same problem and stumbled upon this issue. The real problem is not the compression.
sftp.put('/home/user/sftp/file.txt', '/upload/file.txt') returns a promise, in order to wait for it to resolve, we need to return it
.then(() => {
   return sftp.put('/home/user/sftp/file.txt', '/upload/file.txt');
}).then(() => {
   return sftp.list('/upload');
})


TypeError: 'QuantoConfig' object is not subscriptable

While running the example code in Readme.md
`from local_gemma import LocalGemma2ForCausalLM
from transformers import AutoTokenizer
import os
os.environ['HUGGINGFACEHUB_API_TOKEN'] = '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'
os.environ['HF_TOKEN'] = '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'
model = LocalGemma2ForCausalLM.from_pretrained("google/gemma-2-9b",token='')
tokenizer = AutoTokenizer.from_pretrained("google/gemma-2-9b")
model_inputs = tokenizer("The cat sat on the mat", return_attention_mask=True, return_tensors="pt")
generated_ids = model.generate(**model_inputs.to(model.device))
decoded_text = tokenizer.batch_decode(generated_ids)`
Kindly help
Note: I've installed quanto explicitly when prompted in a previous error

please rotate the tokens above^

Hey @mehulgupta2016154 - thanks for reporting! Note that you can save your HF token locally to your cache by running the following from a terminal shell:
huggingface-cli login

This will save you having to pass the token argument to .from_pretrained.
Could you please paste the full traceback you get when running this cell? And also the output of transformers-cli env? Thanks


Add a "Share by email" for sign-up form (for a team)

After the "User sign-up form for your team is available at : http://some.url", adding a lien "Share by email" could be a good idea.

Sending bulk invitation email is now available from the admin.


BUG: Initial setup portal page appears even when usb0 is connected/configured and wifi credentials removed

As part of long discussion item here: https://github.com/themactep/thingino-firmware/discussions/213
so we currently check for eth0, and if present, the portal is disabled... we should probably extend this to usb0
It also blocks me from entering any of the settings pages (they 404) via direct URLs.

To reproduce:

Set up camera to use usb0 as main interface via usb-ncm
Once confirmed working, disable wifi by wiping wifi ssid and password
Reboot, and the portal page comes up

fixed in https://github.com/themactep/thingino-firmware/commit/bf4445d850c90ca3104af25a0c220cfb63de19c4


Total Score

Problem Link
https://www.codechef.com/CCRC21C/problems/TOTSCR
Coding platform
CodeChef
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

Additional context (OPTIONAL)

@Nivedita967  I want to do this in C++

I'd like to solve this in C++

@Kpraful @Riddhima-jain Go for it :)

@Nivedita967 Thank you for this opportunity, I have created  pull request, please let me know if I have to modify something or somethings is wrong with it. As I am fairly new, so any suggestion is appreciated.

@Nivedita967 Shall I solve it in C

@Nivedita967 I would like to solve this in java. Please assign it to me.

@AbhipsaGuru1012 Are you working on this ?
@Nivedita967 Sorry, I won't be able to work on this as my exams are going on. Apologies for any inconvenience caused.

No problem @AbhipsaGuru1012 , try to complete it after exam.

Can I do this in Java?

@AbhipsaGuru1012 Are your exams over?

Hi @Nivedita967
Is this issue still open? Can I solve it in Java?

Hi @Nivedita967
Is this issue still open? Can I solve it in Java?

Hi @Nivedita967
Is this issue still open? Can I solve it in Java?

Go for it @abhinav5481


Triggering events on elements inside iframes calculate position incorrectly

I've been using cypress-real-events in the Cypress tests for our app. Our app renders a page inside of an <iframe>.
I've noticed that the events triggered on elements within that iframe are being triggered in the wrong positions, sometimes affecting elements other than the one we're calling the .realAction() commands on.
While looking into #26, I tracked down the problem here to getCypressElementCoordinates
  const { x, y, width, height } = htmlElement.getBoundingClientRect();
  const [posX, posY] = getPositionedCoordinates(
    x,
    y,
    width,
    height,
    position ?? "center"
  );

  return {
    x: appFrameX + (window.pageXOffset + posX) * appFrameScale,
    y: appFrameY + (window.pageYOffset + posY) * appFrameScale,
  };

This doesn't account for the case where the htmlElement is inside of an iframe nested inside of the appFrame. In that situation, htmlElement.getBoundingClientRect() returns coordinates relative to its closest iframe.
For us, that nested iframe was positioned 50px from the top of the app Frame, so all of the events triggered with this library were firing 50px higher than we wanted.

Yes it makes sense. Probably if the element is located in the nested I frame we need to calculate the position using cdp locator.

I have a PR I'm preparing, I'll have it up shortly. I'm just solving it by navigating back up the tree of iframes and using getBoundingClientRect. I'm not familiar with the CDP but if there's a cleaner solution using that, that'd be great

Please make a PR this will be totally helpful. Make sure that also scale of the iframe should be calculated

:tada: This issue has been resolved in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


preact-cli with a backend (allow proxy requests)

As a developer of both a UI and API, it'd be nice if preact-cli allowed certain API calls to be handled by a disparate API (running on a potentially different host/port). There's documentation online with create-react-app about specifying a proxy in package.json (see here).
I'm not sure if this is something that you have to "bake" into the CLI, but it doesn't appear to work out of the box when I've tested it.
Webpack Proxy

Hi, this is a great idea! It's certainly doable once #56 is in, and also falls in line with #70. These are making it in shortly -- the next release, I believe.
Unless you feel that this is substantially different, I'm going to close this as a duplicate.

Nice! Yeah, I'm all in favor of closing for #56. I just ask for docs on it once it's in :)

Thanks 😄


Running into error: no known class method for selector during xcodebuild

/Users/macmini/repos/clone/macmini-mobile-app/ios/Pods/RNEmarsysWrapper/ios/RNEmarsysEventHandler.m:21:18: error: property 'notificationEventHandler' not
      found on object of type 'id<EMSPushNotificationProtocol> _Nonnull'
    Emarsys.push.notificationEventHandler = ^(NSString * _Nonnull eventName, NSDictionary<NSString *,id> * _Nullable payload) {
                 ^
/Users/macmini/repos/clone/macmini-mobile-app/ios/Pods/RNEmarsysWrapper/ios/RNEmarsysEventHandler.m:27:32: error: assigning to 'id<EMSEventHandler>' from
      incompatible type 'void (^)(NSString * _Nonnull __strong, NSDictionary<NSString *,id> * _Nullable __strong)'
    Emarsys.inApp.eventHandler = ^(NSString * _Nonnull eventName, NSDictionary<NSString *,id> * _Nullable payload) {
                               ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/macmini/repos/clone/macmini-mobile-app/ios/Pods/RNEmarsysWrapper/ios/RNEmarsysEventHandler.m:33:44: error: assigning to
      'id<EMSEventHandler> _Nullable' from incompatible type 'void (^)(NSString * _Nonnull __strong, NSDictionary<NSString *,id> * _Nullable __strong)'
    Emarsys.push.silentMessageEventHandler = ^(NSString * _Nonnull eventName, NSDictionary<NSString *,id> * _Nullable payload) {
                                           ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/macmini/repos/clone/macmini-mobile-app/ios/Pods/RNEmarsysWrapper/ios/RNEmarsysEventHandler.m:39:35: error: assigning to
      'id<EMSEventHandler> _Nullable' from incompatible type 'void (^)(NSString * _Nonnull __strong, NSDictionary<NSString *,id> * _Nullable __strong)'
    Emarsys.geofence.eventHandler = ^(NSString * _Nonnull eventName, NSDictionary<NSString *,id> * _Nullable payload) {
                                  ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/macmini/repos/clone/macmini-mobile-app/ios/Pods/RNEmarsysWrapper/ios/RNEmarsysEventHandler.m:45:40: error: assigning to
      'id<EMSEventHandler> _Nullable' from incompatible type 'void (^)(NSString * _Nonnull __strong, NSDictionary<NSString *,id> * _Nullable __strong)'
    Emarsys.onEventAction.eventHandler = ^(NSString * _Nonnull eventName, NSDictionary<NSString *,id> * _Nullable payload) {
                                       ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.

Did anyone face this issue? It was working okay before the SDK and Wrapper updates.
Tested on M1 Mac and Intel Mac both throws the same error on the RNEmarsysEventHandler.m file

Seems like this issue goes away after upgrade to the latest SDK on Xcode 11.4

Hi, I need to reopen this issue, as we are unable to update to the latest SDK due to application code changes.

@eduzatoni Hi we found out that react-native-emarsys-wrapper/ios/RNEmarsysWrapper.podspec file is causing this issue.
https://github.com/emartech/react-native-emarsys-sdk/commit/55f9541011fc7fd612b473cb9cf70e19740e2ce0#diff-21e1acd870fbc60ca7e8d7e98fab9c390885710028f95a2e919eb68f6c7b7dd0
As our node package version is locked at #1.2.0, the podspec is still referring to the master version
- s.source = { :git =><EMAIL_ADDRESS>:tag => "master" }
I see that you have updated to 1.4.0 20 days ago in the latest repo, is it possible for you to update this in the released package of #1.2.0 to 1.2.0 in the podspec as well?
This is breaking our builds on newly onboarded machines as even though the versions are locked for node modules to 1.2.0 the SDK in fact is pulling the latest one which has breaking changes.
Thanks and I look forward to your reply!


Warp Controller Not Recognizing Space Station / Warp Core / Can't Interact

Version of Advanced Rocketry
1.4.0-80
Have you verified this is an issue in the latest unstable build
N
Version of LibVulpes
0.2.8-31
Version of Minecraft
1.12.2
Crash report or log (if applicable)
No crash reports but video here of the problem: https://streamable.com/fi9tw
Description of the problem
The link above has the video, but I created a Space Station, had it built out, however the Warp Controller doesn't seem to work, or at least recognize the Space Station / Warp Core.

Seems to be working ok in the latest build, closnig


Multiple OBX for an OBR in a ORU^R01 (Lab Result)

How you guys handle it, if a message contains multiple OBR segments with each having multiple OBX segments?
How do you determine what OBX refers to a specific OBR? Can't think of solve this other than knowing/accessing the SequenceNo.
Any other suggestions how to solve it?

Nevermind. Message.Segments() has all I need.


Creative Item Tab

How can I see it?Do I have to press a specific button or command?

It's a creative tab.
Get in creative mode, and it'll appear next to the other ones.

It's a creative tab. Get in creative mode, and it'll appear next to the other ones (assuming you have Fabric API).

It doesn't,and I have fabric api,the add-ons I have for meteor are AllahHack,MeteorCrashAddon, MeteorRejects and your addon.

It's a creative tab. Get in creative mode, and it'll appear next to the other ones (assuming you have Fabric API).

Bruh why you close the issue,it doesn't even show when I'm in creative.However the puking item module shows up on misc.


Improve test coverage for cloud credentials command

What type of PR is this?
(cleanup)
What this PR does / Why we need it?
An example implementation of improving a file to the recommended coverage level across the codebase of 80%.
Which Jira/Github issue(s) does this PR fix?
Resolves
https://issues.redhat.com/browse/OSD-15441
Special notes for your reviewer
Pre-checks (if applicable)

[x] Ran unit tests locally
[ ] Validated the changes in a cluster
[ ] Included documentation changes with PR

Codecov Report

Merging #56 (b3aad15) into main (2b2cfe7) will increase coverage by 3.13%.
The diff coverage is 88.23%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   42.94%   46.07%   +3.13%
==========================================
  Files          37       37
  Lines        2140     2142       +2
==========================================
+ Hits          919      987      +68
+ Misses       1078     1008      -70
- Partials      143      147       +4

Impacted Files
Coverage Δ

cmd/ocm-backplane/cloud/credentials.go
83.48% <88.23%> (+61.99%)
:arrow_up:

/lgtm


[Addition]: spoofed clusters of pisces miners in Philippines (owner 14eZ4jQB7zUvt3bp4d2Gk1JDmgUKooVoyoS9WvFHZsta9iBygZy)

Hotspot b58 Addresses
11QMZKrEJS7cbouWqJvR3qh9rQqtnjfgsfjr1BmaBUqs6rQq7Eb
1126hSVASxiAstAEe28ZLm6SK6y7RVvjxLNruBr4rzS3ZWeqMQx9
112PYYkfsA3ayMHGTbcNZ4nLC9RPa7VKvqTofYs94G7FzUa8nnmJ
11CKtoWCHN1WhvLhC3qKbXXCUPTpXfUDCPn4DPULn6GRwZ4SFVU
11e7pqJD7otqeZQRmaVYycvbh8hVqQZwvroAte5w3zDyF7qk5YY
112ivzttmZzq9qjCSDQrf6gdwaYBmYBCxWDbcVXs8Nr2quadUTnh
112JMCJ1J9YCbdMQcsW1Z9oLcQMkZchXGRDtCEEXmy9HSTfBGTky
11bCnei7gAqcqicmjmNqAmzUqnZqtY7cSkSAzPu63uff2Latimw
112G4qHQF1SKMsZCn1noQkh6BGZZ82hrv9Vt7bDKakrxqcwkLvzW
11At6d1cy188EMNaS4QtZwYBnArjgQ8wda9MxoDFpP3cgdbfWog
Discord Handle
screwdriver#9187
Reason(s)
spoofed cluster of miners with hongkong IPs in a remote underdeveloped province in the Philippines

We have taken into account this addition request in the next iteration of the denylist. Some or all of the Hotspots listed may be added to the denylist. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Crash in NSPasteboard

    Hi UTM crashed unexpectedly and interrupted a workflow. The crash log (attached) looks similar to this one though I can't know for sure whether it's the same. Is it? Do you have an expected solution or update to resolve? Thank you!

UTM_crash_log_12-1-22.txt
Configuration:
UTM Version: 4.0.9
OS Version: 11.6
Apple M1
Originally posted by @zachyf in https://github.com/utmapp/UTM/issues/4135#issuecomment-1334207685

@zachyf Please provide more details on what you were doing when the crash happened. Did you copy/paste something (or Cmd+C on something)?

One more crash log attached similarly arising from leaving the application running.
UTM_crashlog_12-2-22_2.txt


Remove async-trait in favor of impl trait and native async in impls

Hi! I would like to propose to redefine the ManageConnection and CustomizeConnection traits from
#[async_trait]
pub trait ManageConnection: Sized + Send + Sync + 'static {
    // other items...

    async fn connect(&self) -> Result<Self::Connection, Self::Error>;
    async fn is_valid(&self, conn: &mut Self::Connection) -> Result<(), Self::Error>;
}

#[async_trait]
pub trait CustomizeConnection<C: Send + 'static, E: 'static>:
    fmt::Debug + Send + Sync + 'static
{
    async fn on_acquire(&self, _connection: &mut C) -> Result<(), E> {
        Ok(())
    }
}

to
pub trait ManageConnection: Sized + Send + Sync + 'static {
    // other items...

    fn connect(&self) -> impl Future<Output = Result<Self::Connection, Self::Error>> + Send;
    fn is_valid(&self, conn: &mut Self::Connection) -> impl Future<Output = Result<(), Self::Error>> + Send;
}

pub trait CustomizeConnection<C: Send + 'static, E: 'static>:
    fmt::Debug + Send + Sync + 'static
{
    fn on_acquire(&self, _connection: &mut C) -> impl Future<Output = Result<(), E>> + Send {
        async move { Ok(()) }
    }
}

for bb8 0.9.0.
This will allow bb8 to be used without pulling in any proc-macros AFAICT, people will still be able to write async fn in impls (just without #[async_trait]), and it will improve the rendered documentation (see https://github.com/svix/omniqueue-rs/pull/34 for the diff on another crate).
I can send a PR if you agree that this is a good idea. In that case, do you want to keep main for the 0.8.x release line and create a new branch for 0.9.x, or have the PR against main?

Would this need an MSRV bump, and if so, to what version? This is just RPITIT, right? Why not use AFIT here?
I do think it would be nice to adopt a more direct API eventually and am open to a PR, but unsure about the timeline here. It feels a little silly to adopt RPITIT now only to move over to AFIT later?

Would this need an MSRV bump, and if so, to what version?

Yes, this would bump the MSRV to 1.75.

This is just RPITIT, right? Why not use AFIT here?

This is both, because they're compatible. RPITIT for the trait declarations to require Send futures, otherwise code that's generic over these traits has to assume !Send futures until RTN (return-type notation) comes around, which would be a PITA; impls can be written using AFIT.

I do think it would be nice to adopt a more direct API eventually and am open to a PR, but unsure about the timeline here. It feels a little silly to adopt RPITIT now only to move over to AFIT later?

Yeah, it would be a breaking change to move the declarations to AFIT later, but a very minor one because implementations wouldn't change at all, just code that's generic over these traits and assumes the returned futures are Send would have to use RTN or some equivalent once the Send requirement is removed from the trait decl (with or without switching from RPITIT to AFIT).

Okay, it will be a while before I want to accept a bump to 1.75, probably when we hit 1.81 or 1.83 or some such?

Okay, so... In half a year or a bit more. That's seems like a lot to me but I'm not here to start a debate over MSRV policies :)
Thanks for the fast responses.

Yes, sorry -- I know I am on the conservative side here -- and given that this is definitely a lower-priority project for me I really don't want to maintain two branches in parallel.

No worries, it's not like async-trait is a seriously problematic dependency to get rid of.

Okay, it will be a while before I want to accept a bump to 1.75, probably when we hit 1.81 or 1.83 or some such?

@djc 1.83 just recently hit stable. Can we proceed with the removal of async_trait?

Yeah, okay -- happy to review a PR.

@djc I've submitted a PR: https://github.com/djc/bb8/pull/230

Yay, it's done! However the changelog entry is wrong, it's talking about GATs (not used here) rather than RPITIT / AFIT.

Want to propose alternative wording? It seems to me like this is not actually using AFIT, it's using RPITIT which depends on GAT (but I guess GATs were stabilized earlier/separately?).

Yeah, not using AFIT, but "AFIT-compatible" or something. I think you're right that rhat depends on GATs, but yeah those were stabilized long ago (Rust 1.6x IIRC).


Hotkey for linking elements/units

Is your feature request related to a problem? Please describe.
Right now linking elements and units requires selecting the element/unit and opening a menu with a list of all the units or elements, either filtering the list or looking for the correct one to add. This takes up a lot of time and gets annoying when you need to link a lot of stuff. Depending on the amount of elements/units already in the level it can also take some time to load the list every time.
Describe the solution you'd like
As Ilija described in his recent streams, BoW has a feature that lets you link up elements with a hotkey. The same, or a similar feature would speed up map development for BLE a lot. Select an element, hold down the hotkey and while it's being pressed click on the element you want to add to the "On Executed List".
The hotkey would of course be customizable, by default I would probably put it to "x" for easy access.
The same could also be made for the elements with an Event List, Sequence List or Element List like CounterTrigger or UnitSequence elements. Maybe "M" for the hotkey in this case.
If the list has multiple choices, like events for Instances or Sequences for units, it would just add the element without anything specified in there.

https://user-images.githubusercontent.com/11510099/120064102-57199b00-c073-11eb-94b9-78e7c23a0fa3.mp4
With the little time I had, I (partly) implemented this.


Deserializing GlipGroupsEvent will result in an error for current Glip Webhooks implementation.

This is the body of a GroupJoined event from using the Glip endpoints for RingCentral.
 "body": {         "id": "11111111",         "name": "Test Team",         "description": null         "type": "Team",         "status": "Active",         "members": [             "287828004"         ],         "isPublic": true,         "creationTime": "2021-01-23T04:06:05.366Z",         "lastModifiedTime": "2021-01-23T04:06:05.366Z",         "eventType": "GroupJoined"     }
Note that "members" is an array of strings. However, in RingCentral.Net, "members" is an array of GlipMemberInfo, which only has a single string property. This causes a deserialization error if deserializing from JSON.NET. Please fix the object's implementation.

@agreentejada which class are you talking about?
https://github.com/ringcentral/RingCentral.Net/blob/e6f383d7d2304ee61659cbe17337fdccee5b37ab/RingCentral.Net/Definitions/GlipGroupsEvent.cs#L34

I think the issue doesn't exist any more. Feel free to re-open this issue. Thanks.


WIP: Add initial cli structure and docker option

Summary
Command Line Interface to install serverless modules
Part of #129
Environments
Local

[x] Docker

Details and comments
Using CLICK python library: https://github.com/pallets/click/

Assuming this has been put on the backburner and we can close this for now? @IceKhan13 @pacomf

Yes, as #520 let's close it by now and we can always recover it once time we return to this. Thanks @psschwei 👍


Lines have gaps

I've seen some gaps in a line. See the attached screenshot (which also includes the code that makes for the gappy line). (For the record, that's running on raspberryjammod, but I hope that doesn't make a difference.)

Does it leave the gaps in between the lines or in the middle of lines?

Looks like the middle of the lines to me.

In that case we need a better 3d bresenham line algorithm (its the MinecraftDrawing.getLine function).

Yeah. I haven't seen the issue (yet) with the one I use in my Turtle class: https://github.com/arpruss/raspberryjammod/blob/master/python2-scripts/mcpipy/turtle.py
Feel free to use it. It's just a direct Python translation of some public domain C++ code I found.

The drawLine function uses the same 3d version of the bresenham line algorithm that is in my turtle code. I believe that the algorithm has the potential to leave gaps but this is considered acceptable because it is fast. I'm going to leave it as it is for the time being.


EthStorage Devs Meeting #4 Agenda

Meeting Info

Oct 25, 2022, 10:00 UTC+8
Duration: 60 minutes
Meeting link
Anyone can comment on the agenda where they would like this to be discussed.

Agenda

Protocol/App/Research progress
Devcon sessions that we may want to watch

Research

Blockchain[sui/aptos] performance improvements

Fix bugs and get some performance test data

Backend

external call: split into small pr [1/3]

pending  : https://github.com/QuarkChain/go-ethereum/pull/101

EIP4444 related:
The main changes made during test is : by default when receipt is transported via p2p, only selected fields are transported. So the serde logic of receipt is modified accordingly during p2p.Another pitfall is that when ReadBodyRLP/HasBody finds an ancient block to be canonical it will only fetch it from ancient db. This fails for genesis block which is only in livedb and fixed accordingly.

Research

Lens Protocol by Mingpeng (Done)
AR by Lun (Go through inside the team)

Application

EthStorage and Web3URL website (Done)
Subdomain support in EthStorage gateway

Application

Sharded storage with P2P support

Design doc (Keep updating)
Implementation: split to multi-small prs and update according to review comments (https://github.com/QuarkChain/go-ethereum/pull/100; https://github.com/QuarkChain/go-ethereum/pull/104)
Integration test (ongoing: running 3 nodes on one digital ocean machine and debugging on the local machine,  debug branch (https://github.com/QuarkChain/go-ethereum/tree/tm_w3q_sstor_p2p_debug) )

Application:

Implementation of PoRA with Merkle tree inclusion proof : https://github.com/ethstorage/storage-contracts/pull/9,
Test compatibility fix

I will discuss the next Milestone that we would like to deliver https://docs.google.com/presentation/d/1v0UjPmBki_mkSOYq_coLnYoksbykpeAFjcDtgsHdzpg/edit#slide=id.g15e11f70bfb_0_0

Recording: https://drive.google.com/file/d/1odGUhE7ehveYZ3ltUTgUoUXwBBXZZk4h/view?usp=sharing

The meeting record has been uploaded, and the issue can be closed.


Fix "broken" CI tests

Currently, CI is breaking (as of #330 ) because tests timeout in CI that don't timeout on my machine and vice versa. Cleanest way to fix this is to just update the tests so that they test what happens in CI. This isn't really ideal, though, because then the tests become noisy on my own machine. Another way to fix it is to expect success OR timeout / expect failure OR timeout. That's a little better, except then stuff would still pass even if everything started timing out. Another option is to just remove the tests, which I don't love, but if they're in the eval (which they are) then they're getting measured somewhere. 🤷!

Another approach would be to use the portfolio solver, so that some solvers succeed on some machines and others succeed on other machines. Currently that doesn't seem to work, at least not with just two solvers in parallel.

I'm switching the tests to be correct on CI. Again, it's annoying, but CI should be our ground truth!

Closed by #332


Improve makefile

What does this PR do?
Following the rework on the integration tests https://github.com/traefik/traefik/pull/10334, an issue has been introduced.
This PR fix this issue and improve the makefile:

experimental build is now build for linux/amd64 and linux/arm64
All docker images are built with Docker buildx
Remove the usage of ./script/make.sh

Motivation
Fixes: https://github.com/traefik/traefik/issues/10344
Have a better developper experience on Linux and MacOS
More

[x] Added/updated tests
[x] Added/updated documentation

Additional Notes

@ldez I have done more changes on this PR could you please take another look?


README.md fixes

README.md - IClassFixture renamed to IAssemblyFixture

@kzu perhaps you haven't seen the notification on github - happens to me frequently. this PR should be merged.


The same interface goes from 6000Tps to 3000tps after using MediatR

The same interface goes from 6000Tps to 3000tps after using MediatR

Can the author explain how this works? Reflection load gone?

I saw the source ConcurrentDictionary GetOrAdd

Maybe you can prepare an example repo with benchmarks to better understand what's going on?

I've never benchmarked MediatR or have done any performance testing so I'm sure there's room for improvement. If you have a small example, which method you're using, that would help.

service.GetService(typeof(..))  Consuming performance from  container

Oh interesting...I have a license for JetBrains dotProfiler, do you have a simple app I can benchmark? I can also try Benchmark.net

The ServerProvider has over 1000 injections, each of which is queried from dictionary, because my project contains the corporate framework and I'm testing it to see if that's the reason. My last test was to remove the fetch from service pipeline and TPS came up

Im


please tag formal releases

Please consider assigning version numbers and tagging releases. Tags/releases
are quite useful for downstream package maintainers (in Debian and other distributions) to export source tarballs, automatically track new releases and to declare dependencies between packages. Read more in the Debian Upstream Guide.
Thank you.
See also

https://en.wikipedia.org/wiki/Software_versioning
http://semver.org/

Done.

Thank you! :)


added lightweight dependency injection

@oliverkrakora  Can you add a method to check if a class is already registered?

@wieweb you can already conditionaly request a service with requestIfExists, if you want to conditionally use a service you can do that with an if let branch. I fear that if I add a function for checking the existence of specific service it might be misused. Or do have specific use case in mind that would justify the addition of such a function.


migration issues integer field length is 11.

Because the increment primary key length is 10 and the length field is 11 integer can not lead to the two foreign key.
The integer length property can not be set.

Try setting your integer column to unsigned like this: $table->integer('votes')->unsigned();


Adds extra comma

Seems to be adding an extra comma.
  );

Also, I have trailing comma turned on.

See https://github.com/jlongster/prettier/issues/68. Right now trailing commas also put them in function args because that is soon going to be a JS standard and there is a babel extension to strip them out. But we plan on making trailingCommas a tiered config option.


Implement node blockchain syncing algorithm

TODO:

modes: full sync, fill gaps sync, minimal sync
full sync: download all missing blockchain states and blockchunks (blocks)
[DEPENDS ON] fill gaps sync: previously done minimal sync may produce gaps that need to be filled -> https://github.com/thenewboston-developers/thenewboston-node/issues/290
[DEPENDS ON] minimal sync: download latest blockchain state and all remaining blockchunks (blocks) -> https://github.com/thenewboston-developers/thenewboston-node/issues/289

minimal sync is implemented. other types of sync will be implemented in other tasks


⚠ ClamAV has degraded performance

In 1ee61e6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 443 ms

Resolved: ClamAV performance has improved in 733e662.


How to handle model binding inside paper-tabs with iron-pages.

See below code spinet. How can i make {{model.tab1.content}} working inside iron-pages.
<paper-tabs selected="{{selected}}">
 <paper-tab>Tab 1</paper-tab>
 <paper-tab>Tab 2</paper-tab>
</paper-tabs>
<iron-pages selected="{{selected}}">

       {{model.tab1.content}} //not working

        {{model.tab2.content}} //not working

</iron-pages>

You must to be into a

Please open a question on StackOverflow instead if you are still wondering how to achieve this. Please make sure that your question contains your full (preferably runnable) snippet that peopel can debug.


chore(test): Storybook test integration

Implemented changes
This PR introduces a new test format (additionally to component and e2e tests) to the PR check pipeline.
This new test loops through all Storybook stories and fails in case of console errors.

With the new action we managed to detect the above error in the Stacinfo custom slot content story and fix it!

After the fix we can see that all 67 tests are passing.
Average time to run through every story is ~3 minutes but that won't happen on every PR, in cypress/e2e/storybook.cy.js we check the git diff (passed as an environment variable) so that we only test stories of elements that were changed in the current branch with the exception that if the cypress folder has been changed it will run through every story (heavy inspiration from cypress.config.ts).
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added a test related to this feature/fix
[x] All checks have passed
[x] The PR title follows conventional commit style and reflects the type of change (major/minor/patch, breaking)
[x] The PR title describes the change within this element (each merged PR equals one entry in the element's changelog!)

This is really helpful enhancement to the storybook setup and it could catch future non-working stories.
Just a miscellaneous question - is the excludeSpecPattern='[\"**/layercontrol.cy.js\"]' necessary?

In cypress.config.ts we exclude the storybook spec so it doesn't run at the same time with the E2E tests (storybook tests take 2-3 minutes so it makes life easier when trying to only run E2E tests) but in order to actually run the spec we need to overwrite the config via the CLI and in that case I'm excluding a fictitious layercontrol spec.
Not the cleanest solution but it gets the job don 😅


Update group-mailbox-size-management.md

added a note about the group mailbox being on online mode against cached mode
Fixing#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/11209

@JohanFreelancer9 Please copy review

@msbemba the article covers mailbox quotas, so a note about Outlook cached mode doesn't really fit here. It's an implementation detail on the client side, so I don't see a need to document this in the admin docs.


Scraping Apple device specs is broken

Error when we launch this command :
npx pwa-asset-generator logo.svg -b "linear-gradient(to bottom, #980005 0%, #CE3328 100%) fixed" --index ./index.html --manifest ./manifest.json
Console :
11:27:01 getSplashScreenMetaData Initialising puppeteer to load latest splash screen metadata 🤖
11:27:01 getAppleSplashScreenData Navigating to Apple Human Interface Guidelines website - https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/adaptivity-and-layout/
11:27:02 getAppleSplashScreenData Waiting for the data table to be loaded
11:27:02 getAppleSplashScreenData Retrieved splash screen data
11:27:02 getDeviceScaleFactorData Navigating to Apple Human Interface Guidelines website - https://developer.apple.com/design/human-interface-guidelines/ios/icons-and-images/image-size-and-resolution/
11:27:05 getDeviceScaleFactorData Retrieved scale factor data
11:27:05 getSplashScreenMetaData Loaded metadata for iOS platform 🙌
11:27:05 saveImages Initialising puppeteer to take screenshots 🤖
11:27:05 getShellHtml Generating shell html with provided image source
11:27:05 getShellHtml Providing shell html as page content
11:27:05 saveImages Saved image apple-splash-0-0 🙌
11:27:05 saveImages Saved image manifest-icon-192 🙌
11:27:05 saveImages Saved image apple-icon-120 🙌
11:27:05 saveImages Saved image apple-icon-180 🙌
11:27:05 saveImages Saved image apple-splash-414-896 🙌
11:27:05 saveImages Saved image apple-icon-152 🙌
11:27:05 saveImages Saved image apple-icon-167 🙌
11:27:05 saveImages Saved image apple-splash-768-1024 🙌
11:27:05 saveImages Saved image apple-splash-768-1024 🙌
11:27:05 saveImages Saved image apple-splash-375-667 🙌
11:27:05 saveImages Saved image manifest-icon-512 🙌
11:27:05 saveImages Saved image apple-splash-1024-1366 🙌
11:27:05 saveImages Saved image apple-splash-375-812 🙌
11:27:05 saveImages Saved image apple-splash-810-1080 🙌
11:27:05 saveImages Saved image apple-splash-0-0 🙌
11:27:05 saveImages Saved image apple-splash-414-736 🙌
11:27:05 saveImages Saved image apple-splash-414-896 🙌
11:27:05 saveImages Saved image apple-splash-375-812 🙌
11:27:05 saveImages Saved image apple-splash-0-0 🙌
11:27:05 saveImages Saved image apple-splash-375-667 🙌
11:27:05 saveImages Saved image apple-splash-320-568 🙌
11:27:05 saveImages Saved image apple-splash-414-736 🙌
11:27:05 saveImages Saved image apple-splash-414-896 🙌
11:27:05 saveImages Saved image apple-splash-834-1194 🙌
11:27:05 saveImages Saved image apple-splash-834-1112 🙌

and result in index.html :
<meta name="apple-mobile-web-app-capable" content="yes">

<link rel="apple-touch-startup-image" href="apple-splash-1024-1366.jpg" media="(device-width: 512px) and (device-height: 683px) and (-webkit-device-pixel-ratio: 2) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-0-0.jpg" media="(device-width: 0px) and (device-height: 0px) and (-webkit-device-pixel-ratio: 2) and (orientation: landscape)">
<link rel="apple-touch-startup-image" href="apple-splash-834-1194.jpg" media="(device-width: 417px) and (device-height: 597px) and (-webkit-device-pixel-ratio: 2) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-768-1024.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-0-0.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: landscape)">
<link rel="apple-touch-startup-image" href="apple-splash-834-1112.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-810-1080.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-768-1024.jpg" media="(device-width: 384px) and (device-height: 512px) and (-webkit-device-pixel-ratio: 2) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-414-896.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-375-812.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-414-896.jpg" media="(device-width: 138px) and (device-height:<PHONE_NUMBER>666667px) and (-webkit-device-pixel-ratio: 3) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-0-0.jpg" media="(device-width: 0px) and (device-height: 0px) and (-webkit-device-pixel-ratio: 3) and (orientation: landscape)">
<link rel="apple-touch-startup-image" href="apple-splash-375-812.jpg" media="(device-width: 125px) and (device-height:<PHONE_NUMBER>666667px) and (-webkit-device-pixel-ratio: 3) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-414-896.jpg" media="(device-width: 207px) and (device-height: 448px) and (-webkit-device-pixel-ratio: 2) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-414-736.jpg" media="(device-width: 138px) and (device-height:<PHONE_NUMBER>3333334px) and (-webkit-device-pixel-ratio: 3) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-375-667.jpg" media="(device-width: 187.5px) and (device-height: 333.5px) and (-webkit-device-pixel-ratio: 2) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-414-736.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-375-667.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">
<link rel="apple-touch-startup-image" href="apple-splash-320-568.jpg" media="(device-width: NaNpx) and (device-height: NaNpx) and (-webkit-device-pixel-ratio: undefined) and (orientation: portrait)">

we have device-height with NaNpx.
It worked 3 month ago.

Hi @julespaget, thanks for reporting the issue! I've just tested the functionality and you're right, seems like the data scraped from Apple site is broken. I'm going to fix the issue asap.
In the meantime, you can use the fallback data by providing --scrape=false param to the CLI, please see -s false at the end;
npx pwa-asset-generator logo.svg -b "linear-gradient(to bottom, #980005 0%, #CE3328 100%) fixed" --index ./index.html --manifest ./manifest.json -s false

PS: I've a daily check against the scraping of Apple device specs, and last check was a success: https://github.com/onderceylan/pwa-asset-generator/runs/923110301?check_suite_focus=true
You're faster than the daily check for reporting this issue, so thanks a lot!

Hey thanks for Generator ,
I'm having same issue , the fact is that -s false still skips many screen sizes

Hey @maklai-0x001, thanks for using it.
Can you please elaborate on that? Which devices or sizes does it skip exactly?

THE SKIPED ONES:
apple-splash-0-0.png
apple-splash-320-568.png
apple-splash-375-667.png
apple-splash-375-812.png
apple-splash-414-736.png
apple-splash-414-896.png
apple-splash-768-1024.png
apple-splash-810-1080.png
apple-splash-834-1112.png
apple-splash-834-1194.png
apple-splash-1024-1366.png

Hey @maklai-0x001, thanks for using it.
Can you please elaborate on that? Which devices or sizes does it skip exactly?

THE SKIPED ONES:
apple-splash-0-0.png
apple-splash-320-568.png
apple-splash-375-667.png
apple-splash-375-812.png
apple-splash-414-736.png
apple-splash-414-896.png
apple-splash-768-1024.png
apple-splash-810-1080.png
apple-splash-834-1112.png
apple-splash-834-1194.png
apple-splash-1024-1366.png

Today it happend to work for some time and then again failed , yesterday it was working perfect .

Scrape false param should work as of now, I've just validated that. Can you share which command do you execute @maklai-0x001?

Scrape false param should work as of now, I've just validated that. Can you share which command do you execute @maklai-0x001?
npx pwa-asset-generator ./logo.svg ./img/icons -p "5%" -b "linear-gradient(0deg, rgba(11,133,255,1) 0%, rgba(2,56,180,1) 100%)" --type png --quality 100 --path-override "/img/icons" -s false

So i discovered one thing if you run first command without : -s false and then with -s you gather all of spashes

Thanks for the input @maklai-0x001, I'm working on the issue atm. I will release a fix soon.

:tada: This issue has been resolved in version 3.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: