_prepResources fails if Object has been extended

Added a hasOwnProperty check so only values in the resources object are iterated over.

@wbaaron
Can you add more details for this pull request?

If Object's prototype is extended, _prepResources is likely to fail because it will treat any extended property as a class that can be instantiated with new.
Example:
Object is extended to have a 'length' function:
Object.prototype.length = function length() {     return Object.entries(this).length;   };
Since resources is an object, iterating over it with a for loop without checking hasOwnProperty will also iterate over extended properties. Using the example, new resources[name](this) will try to call new length(this) which will result in an error.

Added another commit. When something failed in the _request call, an extended Error object was returned in all cases except two. Those two cases returned regular javascript objects. The new commit corrects these two instances to also return extended Error objects.


docs: translate Responding to Events Page

Closes #445
Description
Translate the Responding to Events page.
Page: https://id.react.dev/learn/responding-to-events

hii, are you still working on this? If not, let me take over and continue your work. Thanks!!

Superseded by #596.


dynamic watermark positioning

would it be possible to add dynamic watermark positioning like if the video file is 4:3 it be placed  in 4:3 base spacing then add the Horizontal 5 and vertical 5 margins it would be placed 10 pixels in plus 5 over and 5 down but 16:9 would be placed just 5 pixels in and 5 down

Aspect ratio's used info
https://en.wikipedia.org/wiki/Aspect_ratio_(image)

This will be implemented with upcoming scaling fixes.

Note that this was made optional in #986 and will need to be re-enabled in each watermark's settings.


How to group actions in a context menu?

This describes how to add an action to a context menu.  I've added four actions, now I want to group them in a parent fly-out menu, like the out-of-box "Templates" or "Add to Dashboard" menu groups.  How can I accomplish that?  What contribution type do I use?

I found an example that shows how to do it when the menu values are dynamically assigned.  My values are static.  Is there a way to add the sub-menu actions via configuration, or is the above javascript solution currently the only way?


text to slider

https://github.com/twosigma/beakerx/blob/master/demoFiles/interactive.ipynb
the plot demo should have a slider and draw a line with the slope of a float slider 1-10 in the plot.

Did 2 examples:
There is picture of one of it, but our widgets do not support "update", so it is blinking while recreating.


Uncaught Error: use "new" to construct a Mongo.Collection (if collection-hooks are installed)

Hi,
i try to use a clientside-only GroundDB.
meteor Version <IP_ADDRESS>
ground:db Version 0.3.12
if (Meteor.isClient) {
  Territories = new Ground.Collection('Territories', {
    connection: null
  });
}

Error in client console (Chrome):

Uncaught Error: use "new" to construct a Mongo.Collection
```

Please help.

oh no!
found the problem: package matb33:collection-hooks breaks ground:db

Would be nice to get the the two packages work together.

Could you give the beta a spin to see if its an issue there too? (Wip)

Hi @Jehu ,
Try this: remove both packages and install in this order:

matb33:collection-hooks
ground:db

then it'll work fine (at the time I wrote this, I was using ground:db 0.3.12 and matb33:collection-hooks 0.7.14)

@joaopiopedreira, thanks! that worked
@raix, is the version that joaopiopedreira mentioned (0.3.12) the beta you were referring to?

Brian, the beta version @raix mentioned is the new ES2015 compliant version of
ground:db. I believe it’s meant for Meteor 1.2.
Link here: https://github.com/GroundMeteor/db/tree/es2015-localforage
It has still some work-in-progress, so let it chill for a while ;-)
On 28 August 2015 at 21:28, Brian Rayburn <<EMAIL_ADDRESS>> wrote:
@joaopiopedreira , thanks! that worked
@raix , is the version that joaopiopedreira mentioned (0.3.12) the beta you were
referring to?
—
Reply to this email directly or view it on GitHub .

@joaopiopedreira thanks for the hint with installation order.


Cli.run overrides with no validation block

http.post for example has overrides which don't require a Validator, I think it would be useful for there to be cli.run overrides that don't require it also (if all ones care about is that status code is 0).

Yes.


Implements issue #137 and #153.

@lelekaz in the future (if we even get that far since we finished mostly everything), just include "Closes #137, Closes #153" so someone else can hover over the number to see what you're referring to. I'm a little busy so I'm probably gonna look at this tomorrow night.

Looks great @lelekaz ! I added one small commit that removes the warning if the user tries submitting a form, since that was technically taking them to another page, it also popped the warning. Approving now...

I think we can merge this one and #149 before Monday. I think they're good changes that are small but good for the quality of life aspect of the app.

LGTM, I had to push a commit because I encountered this error again

Ah, this is what you were talking about in #151!


Added "Resolution" section

Added "Resolution" section with the first, basic analysis step.

@LuigiBruno - Looks good, thanks for the PR.

@tedhudek - This PR is ready to head up to Master/Live when you have a moment.

@LuigiBruno - Looks good, thanks for the PR.

Thanks @DOMARS.


Classic WoD preview/logo wrong(?)

I was trying to setup a Classic World of Darkness campaign, but the image preview looks wonky. I can't figure out of the preview/logo is wrong, or if the underlying HTML is also off.
I'm looking at CWorldofDarkness/CWoD.png and it looks like it's the sheet for Vampire. Is that intentional?

If you read the Instruction text next to the preview image, its says:

Classic World of Darkness Sheet:Includes Revised Vampire Warewolf Demon Mummy Mage Hunter + some Homebrew Gargoyles and Diclonius

Yeah, not the best formatting on the instruction, but contains the information necessary to realize it's what you're after. And if you open the sheet in a game, it defaults to show  the "World of Darkness" sheet.
Could update the "instructions" text to be more clear and switch out the preview image for on that shows WoD to reduce future confusion.

I'm new to roll20, so I couldn't figure out what one of my incoming players would see. Just wanted to confirm that the HTML itself is right, and it sounds like it is. Thanks @Anduh


Crash fix38

This should solve problem #38. Also should solve the issue with the cake wallet.
BufferedReader.lines() is not supported on some old  Android devices. (works fine on android >= 7).

@DeRain @JohnnyJumper fixing this probably will solve the issue, but there's no warranty that nothing else fails in a runtime. A more reliable solution will be to upgrade to the 8th version to match the library or pack a different version of the library build on java 7 if that is not possible.

@DeRain @JohnnyJumper fixing this probably will solve the issue, but there's no warranty that nothing else fails in a runtime. A more reliable solution will be to upgrade to the 8th version to match the library or pack a different version of the library build on java 7 if that is not possible.

Do you mean require Java 8+?

@DeRain  We never supported Java version less than 7. This issue happens with cake-wallet who can't upgrade to java 8 at this time and gnosis android managed to caught this only once. It is not a hard fix and I don't see why we shouldn't update this.
This time it is beneficial to us because we are getting rid of an extra dependency that we haven't used anywhere else except here.

@DeRain @JohnnyJumper fixing this probably will solve the issue, but there's no warranty that nothing else fails in a runtime. A more reliable solution will be to upgrade to the 8th version to match the library or pack a different version of the library build on java 7 if that is not possible.

Do you mean require Java 8+?

@DeRain I think we can deploy the fix this time and reject future changes if they are much more complicated than this


Accessibility-Causing Missing labels issue

This input does not have id attribute.Causing missing label issue for Accessibility.
Ex: Form..has mobile,home and work telephone input fields...on a page:
This can cause missing labels as there is no corresponding input(not complaint with WCAG 2.0 Accessibility)
Please fix it..Thank you!

@SA21 I think a better idea would to allow a style prop.
Also, the files under lib folder are generated files. The source files are in src folder.

I see there is style={this.getFlagStyle()} on div element,not style tag on input element.
Adding id to getFlagStyle(),would not help Accessibility issue..Better would be to add a property as id.
If you can edit this change ,would help on dealing with Accessibility issue.

@SA21 Then maybe the prop can be inputStyle

What i understand, we need to add a property as
<input   style={this.inputStyle} ...........   />
inputStyle(){
return {
id: {this.props.id}
};
}
Something like this...?

Nope. Allow inputStyle as a prop.
var inputStyle = {
  id: 'specialInputId',
  background: 'peach',
  border: '1px solid green'
};

<ReactTelephoneInput
    inputStyle={inputStyle}
    {...otherProps}
    />

Have a defaultProp for `inputStyle` as `{}`

And then pass it to the input element.


Error downloading

Provide a description of requested docs changes
# It has a solution?

Hello,
https://github.com/heliomarpm/udemy-downloader-gui#warning
unless you have the encryption keys to use with udemy-downloader, there are no solutions.

Thanks @rickeymandraque

The Skip option is just to continue downloading the available files and videos.


Log files rotation

Hi,
Would it be possible to have a log rotate option (it's generally done with a signal who also reload the configuration) ? I would like to rotate the log files every days at midnight, without restarting the service.
From what I've read, the log file is actually rotated whis this code from glog project:
// MaxSize is the maximum size of a log file in bytes.
var MaxSize uint64 = 1024 * 1024 * 1800

func (sb *syncBuffer) Write(p []byte) (n int, err error) {
  if sb.nbytes+uint64(len(p)) >= MaxSize {
    if err := sb.rotateFile(time.Now()); err != nil {
      sb.logger.exit(err)
    }
}
...

Would be nice too to change the MaxSize value ...

I've done the job here: https://github.com/Toubib/imageproxy/commit/65be9595a2758470d168376814f8c23e1620427b
Need some tests before pull request.

I wonder if a better approach would just be to switch to github.com/Sirupsen/logrus or something similar?  Do you know if it does log rotation like you're looking for?

I'm going to go ahead and close this in favor of #105.  While I haven't implemented it yet, my intent is to move to the standard log package which writes only to stderr, at which point imageproxy is no longer in the business of caring about log files at all.  There are numerous tools available that could then read imageproxy's stderr and store them in files however the user likes.

Ok.


Changing Stack Overflow Poller to 180 minutes

👎 I like those :(

We'll still have them, just at larger intervals.  The current one does lead to some excessive flood sometimes.

Not frequent enough!


Move specs for arithmetic primitives to primitives_spec

Alternative to #11233. This moves all primitives specs to a new test suite. The actual tests are the same as that PR except that spec/std/overflow_spec.cr is also combined here.
The primitives_spec target has a Makefile dependency on the local Crystal compiler, so any primitive method introductions or fixes in a PR should be immediately available whenever make primitives_spec is run, including on CI. (Those introductions or fixes are not guaranteed to be there if the specs are run directly via bin/crystal spec spec/primitives_spec.cr.)

By the way, I tried to gather the run times of all the test_linux* jobs in the past 2 weeks. The results are:

test_linux: average = 46m26s, standard deviation = 291s
test_linux (1.0.0): average = 46m05s, standard deviation = 332s
test_linux (1.1.1): average = 45m19s, standard deviation = 327s

The raw data is here. Right here the same jobs are already giving run times down to around 35 minutes so I'd say that's a rather significant improvement.

Wow, that's really a lot. I had expected to shave of quite a bunch, but 10 minutes is really a significant step.


Detect sha256sum or shasum and error if neither is present.

Changes prefer sha256sum over shasum.  A new variable SHACMD holds the command as being sha256sum or 'shasum -a 256'.
NOTE!! Unable to test fully as none of my systems have shasum.

What is your environment?

This is common to BSD/unix style systems ... i.e. Darwin (Mac) uses shasum vs sha256sum.  there are a number of changes, including differences in the date binary as well... I am thinking of adding a PR to address these issues however I cannot get this to work on MAC yet.

Sorry for the late action, it looks good thanks!


362 remove backend folder

Decision with Minye, Paul and me:

Rename tool back to MetaConfigurator because its more catchy/stays more in the mind
Move frontend/config-assistant to /frontend

Will do moving of all files later, to avoid merge conflicts during the current phase.


Change console.log to new Error

@all-contributors please add @AkiaCode for code

@all-contributors please add @AkiaCode for code

LGTM! Thanks a lot 👍

LGTM! Thanks a lot 👍


Add Ruby config in .editorconfig

This issue is about Enhancements.

[ ] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[ ] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

The contributors most likely able to help are:
@aashutoshrathi
Possible duplicate or related issues are:

#428: Add badges to README.md
#459: Adding C# section in .editorconfig

Please add it in #514.

If this issue is open then @iiitv/project-maintainers I would like to work on it.

Yeah, I guess you can take it.


MWPW-121861 - Text block updates to support SEO Long form content

Updated the Text block to support Inset and Long Form variants
Added a block typography config for variant mapping and optional overrides
Extended the block content container style options to target token widths per viewport

Resolves: MWPW-121861
Test URLs:

Before
After

Long form content lets go!


BAU: Add msa-version as a task output

If we went to propagate the update version, it needs to be an output.

@risicle Quite right


Some Playlists Cannot be Fully Downloaded

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Most of the time yt-dlp woks well, but I figure out that in some playlists it download None or Only One playlist, examples:
$ \yt-dlp --yes-playlist https://www.youtube.com/@kathryndobrow205/playlists
$ \yt-dlp --yes-playlist https://www.youtube.com/@BriTheMathGuy/playlists
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
$ \yt-dlp -vU https://www.youtube.com/@kathryndobrow205/playlists
[debug] Command-line config: ['-vU', 'https://www.youtube.com/@kathryndobrow205/playlists']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [197d0b03b]
[debug] Python 3.12.7 (CPython x86_64 64bit) - Linux-6.6.58-1-lts-x86_64-with-glibc2.40 (OpenSSL 3.4.0 22 Oct 2024, glibc 2.40)
[debug] exe versions: ffmpeg 7.0.2 (setts), ffprobe 7.0.2, phantomjs broken, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.20.0, brotlicffi-<IP_ADDRESS>, certifi-2024.08.30, mutagen-1.47.0, requests-2.32.3, secretstorage-3.3.3, sqlite3-3.46.1, urllib3-1.26.20, websockets-12.0, xattr-0.10.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests
[debug] Loaded 1838 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[youtube:tab] Extracting URL: https://www.youtube.com/@kathryndobrow205/playlists
[youtube:tab] @kathryndobrow205/playlists: Downloading webpage
[debug] [youtube:tab] Selected tab: 'playlists' (playlists), Requested tab: 'playlists'
[download] Downloading playlist: Kathryn Dobrow - Playlists
[youtube:tab] Playlist Kathryn Dobrow - Playlists: Downloading 0 items
[download] Finished downloading playlist: Kathryn Dobrow - Playlists

Duplicate of #11524


Bug: Unhandled errors in websockets can lead to panics

Describe the bug
https://github.com/surrealdb/surrealdb.go/pull/118/files
Not much detail, but there is a code line. Apparently, when the error isnt handled correctly, the websocket connections can panic.
The TODO is going to be added to the codebase
Steps to reproduce
Unknown, may need to review code
Expected behaviour
No panics, errors handled correctly
SurrealDB version
1.0.0+20231130.a420c821.dirty for macos on aarch64
Contact Details
<EMAIL_ADDRESS>Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @phughk , I could take this.
Also for you, some of gorilla ws's errors cannot be recovered such as connection errors in that case I believe we should try reconnecting and also implement them in PR or separate them into two.
reconnect also fix: https://github.com/surrealdb/surrealdb.go/issues/110

With the NewTestSurrealDB function in the PR #118, I can easily reproduce this error, by simply shutting down SurrealDB server and sleep for a second.
func TestSurrealDBPanic(t *testing.T) {
	t.Parallel()

	_, db, close := NewTestSurrealDB(t)
	_ = db // db implicitly holds websocket connection, and can panic when SurrealDB is not accessible
	close()

	time.Sleep(1 * time.Second)
}

I agree with @ElecTwix --  when the connection is lost, it would be the best if the server can go into reconnection loop. I'd imagine there would be some adjustment needed for the read path as well, but we should first focus on server to automatically recover (in that sense panic needs to be addressed).

Hi everyone,
I have created a diagram for implementing reconnection and reauthentication.
What are your thoughts?

full view

Thanks so much for this!
I agree that implicit retries are favourable. We need to be careful how we go about it though - we don't want indefinite loops, and we do want to fail-fast in many cases (such as deploying to a cluster where SurrealDB hasnt yet started or isn't reachable).
The pattern for this is called a circuit breaker. We should explore how circuit breakers are implemented in golang (I haven't used them myself, only in-house solutions). There could be frameworks that help with this.
The number of retries and timeout durations must be configurable. Some people may want to have no retries and short timeouts, for example.
Additionally, if the retries have failed, there cannot be a panic, and instead must be a checkable error code. Then users can handle logic on their side - reconnect, reconnect with new address, or terminate the client.
Regarding the diagram for the approach - I think this is great @ElecTwix thank you! It looks sensible. I would advise having the circuit breaker pattern in the db.go file. Configuration should be outside db.go, though. Db.go should use the configuration provided.


Link Broken

The link under "Use mail flow rules to set the SCL in messages." pointing to https://docs.microsoft.com/en-us/exchange/security-and-compliance/mail-flow-rules/use-rules-to-set-scl.md is a 404 page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b17ce75e-79ba-0acd-066c-a0120a29d65d
Version Independent ID: 14673b1c-8489-0abc-90a0-42f35d516424
Content: Configure the delivery of third-party phishing simulations to users and unfiltered messages to SecOps mailboxes - Office 365
Content Source: microsoft-365/security/office-365-security/configure-advanced-delivery.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@mattdreher, it was that extra '.md' at the end. I removed it.
Thanks for the feedback.
Closing


add cloudfoundry/healthchecker to ARP WG

This is for my WG and I approve 🎉

@emalm could you approve this for us?

@ameowlia @dsboulder What's the new repo for?  /cc @cloudfoundry/toc

It is a healthchecker that restarts bosh jobs when HTTP endpoints stop responding. The monit including in CF is so old that it can't do HTTP checks, so this is an alternative for that. This code currently exists in cf-networking-helpers, but we want it to graduate into its own repo. It is currently used for gorouter, silk-controller, garden, and others.

Thanks, @ameowlia! Sounds good to me. If this proves useful outside of its current ARP usage, maybe it's a utility that the Foundational Infrastructure WG should own in the long term.


CSS line-height error ??

My IDE (Aptana) says that there is an error in one of the CSS files. I don't know if it is just a thing of my IDE or it is really an error. I also don't know what value I should put so I attach here a screen shot so you can act accordingly.

Yeah, it looks like the default is normal, not auto.

done!


add --verbose to manpages and fix links for reporting bugs

Can one of the admins verify this patch?


Migrate Database

Use something like firebase, the issue with realm is that it doesn't work nicely with the ephemeral filesystem of heroku, everytime the bot restarts, the data gets wiped out. Firebase sounds like a nice alternative.

Done in #7.


Support Bosque language

Description

Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?q=bosque

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://github.com/joelibaceta/linguist/blob/bosque-language/samples/Bosque/max.bsq
https://github.com/joelibaceta/linguist/blob/bosque-language/samples/Bosque/hello-world.bsq

[x] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

Overall usage on GitHub.com appears to be too low for inclusion of the .bsq extension at a mere 297 files - https://github.com/search?q=extension%3Absq+NOT+nothack&type=code


how to use data bind?

like v-model?
how can i get the editor's current new content?

ok, i got the answer:
@code-change="callback"


onNotificationOpen is not called on Android

I’m doing tests with this plugin and I 'm getting an unexpected result:
On Android when the app is absolutely closed and I tap on the notification, the app is opened but onNotificationOpen is not fired, but when the app is in foreground or in background this method is called correctly. I tested it on Android 4.4.4, 5.1, 6.0.1 and I got the same result.
Nevertheless on iOS it works correctly. When the app is closed and the notification is tapped, the app is opened and onNotificationOpen is called.
Any suggestion? Thanks

Same issue as #108

issue #108 not solve this problem

I face the same problem here, issue #108 doesn't fix anything. The function is never called: the app opens, but then nothing is done.

I found a turn around, not really elegant but it works :
var intervalId = setInterval(function(){
    window.FirebasePlugin.onNotificationOpen(function(notification) {
      console.log(notification);
      clearInterval(intervalId);
    }, function(error) {
      console.error(error);
    });

  }, 1000);

Will try to bind onNotificationOpen and stop at first received notification.
Why i need to do this :
When i start the application with this code just in onDeviceReady it's like the FMC service not yet connected to firebase server.
window.FirebasePlugin.onNotificationOpen(function(notification) {
      console.log(notification);
    }, function(error) {
      console.error(error);
    });

But if i evaluate this same code in the chrome console after app start, it works.
Except when the application is not started and i receive a notification, i touch the notification, the application start, but plugin look like not yet ready, and onNotificationOpen is not called.
I hope this debug session could help.

I use this plugin in a very slow device, perhaps an asynchronous issue ?

@etherny did you have problem even when the app is in background (launched, not completely killed)?
If so, you should call onNotificationOpen on both device ready and resume.
I thought your workaround was to fix the problem when the app is not even launched. I've tested it on Android and it did not work on my end.

@davidgamarra I just read your post again. Did you say on your end tapping the notification when the app is not launched did fire onNotificationOpen on iOS? It did not work on my end.

document.addEventListener("deviceready", function() {
    window.FirebasePlugin.grantPermission();

    var saveToken = function(token) {
        var myToken = localStorage.getItem("onevent.firebase.token");
        if(myToken != token) {
                localStorage.setItem("onevent.firebase.token", token);
                console.log(token);
            }
        }
    }

    var errorToken = function(error) {
        console.error(error);
    }

    window.FirebasePlugin.getToken(saveToken, errorToken);

    window.FirebasePlugin.onTokenRefresh(saveToken, errorToken);

    window.FirebasePlugin.onNotificationOpen(function(notification) {
        console.log(notification);
        alert(notification.text);
    }, function(error) {
        console.error(error);
    });

}, false);

This is my code, as you can see, its on "deviceready" so the expected behaviour is when I tap on the notification when te app is closed it must open the app and call onNotificationOpen but it dont work. On iOS yes. When te app is open onNotificationOpen works perfectly so I dont need "resume" event.
I emphasize that on Android I mean app closed when the app is completely killed. If the app is closed but on background it works as well.

@chanphillip hello, yes i tried to add the onNotificationOpen in ready and resume methods. I put traces in both methods to be sure to pass through, and i m certain to pass in the two methods but onNotificationOpen never called.
Same issue on background app and on not open app.
I looked at your code but all looks good, i forked your job, and investigate in few days.

Same here: onNotificationOpen method is never triggered. I tried to place it on both resume and onDeviceReady without success.

I put traces in :
FirebasePlugin : onNotificationOpen
FirebasePlugin: sendNotification
FirebasePluginMessagingService : onMessageReceived
OnNotificationOpenReceiver : onReceive
Case app in front

Send notification
log and all working

01-16 21:10:31.567 4722-6742/##project## D/ETHERNY: onMessageReceived com.google.firebase.messaging.RemoteMessage@5b8029a
01-16 21:10:31.567 4722-6742/##project## D/FirebasePlugin: From:<PHONE_NUMBER>52
01-16 21:10:31.568 4722-6742/##project## D/FirebasePlugin: Notification Message id: 0:1484619032357658%a9549c76a9549c76
01-16 21:10:31.568 4722-6742/##project## D/FirebasePlugin: Notification Message Title: null
01-16 21:10:31.568 4722-6742/##project## D/FirebasePlugin: Notification Message Body/Text: test
01-16 21:10:31.568 4722-6742/##project## D/ETHERNY: sendNotification Bundle[{tap=false}]

Case app in back

Send notification
Click on notification icon
App come back in front
Only this trace and not call of onNotificationOpen
log

01-16 21:09:49.178 4722-4722/##project## D/ETHERNY: sendNotification Bundle[mParcelledData.dataSize=308]

Case app closed

Send notification
Click on notification icon
App come back in front
No trace and not call of onNotificationOpen

I have this log for all notifications even if the application is in front and active
01-16 21:21:10.850 13745-16353/##project## D/FA: Logging event (FE): _nr, Bundle[{_o=fcm, _ndt=0, _nmn=test, _nmt=1484619671, _nmid=4324614190085375568}]
01-16 21:21:11.069 13745-16353/##project## V/FA: Using measurement service
01-16 21:21:11.069 13745-16353/##project## V/FA: Connecting to remote service
01-16 21:21:11.118 13745-13745/##project## W/FA: Service connection failed: ConnectionResult{statusCode=SERVICE_VERSION_UPDATE_REQUIRED, resolution=null, message=null}

Use case :
Send notification, tray icon, click on notification while application in background.
Application immediately opened after notification click.

01-16 21:46:16.560 2850-3839/##project## D/FA: Logging event (FE): _no, Bundle[{_o=fcm, _ndt=0, _nmn=test, _nmt=1484621164, _nmid=7882742816762035924}]
01-16 21:46:16.586 2850-2850/##project## D/ETHERNY: sendNotification Bundle[mParcelledData.dataSize=308]
01-16 21:46:16.608 2850-2850/##project## D/CordovaActivity: Started the activity.
01-16 21:46:16.617 2850-2850/##project## D/CordovaActivity: Resumed the activity.
01-16 21:46:16.639 2850-2850/##project## D/SystemWebChromeClient: file:///android_asset/www/js/firebase-message-cloud.js: Line 18 : [object Object]
01-16 21:46:16.639 2850-2850/##project## I/chromium: [INFO:CONSOLE(18)] "[object Object]", source: file:///android_asset/www/js/firebase-message-cloud.js (18)
01-16 21:46:16.739 2850-3839/##project## V/FA: Using measurement service
01-16 21:46:16.739 2850-3839/##project## V/FA: Connecting to remote service
01-16 21:46:16.746 2850-3839/##project## W/GooglePlayServicesUtil: Google Play services out of date.  Requires 10084000 but found 9879480
01-16 21:46:16.746 2850-3839/##project## V/FA: Using measurement service
01-16 21:46:16.747 2850-3839/##project## V/FA: Connection attempt already in progress
01-16 21:46:16.747 2850-3839/##project## V/FA: Activity resumed, time: 142150
01-16 21:46:16.766 2850-2894/##project## E/EGL_emulation: tid 2894: eglSurfaceAttrib(1174): error 0x3009 (EGL_BAD_MATCH)
01-16 21:46:16.766 2850-2894/##project## W/OpenGLRenderer: Failed to set EGL_SWAP_BEHAVIOR on surface 0x79bcf48bcc40, error=EGL_BAD_MATCH
01-16 21:46:16.799 2850-2857/##project## W/art: Suspending all threads took: 20.837ms
01-16 21:46:16.869 2850-2850/##project## W/art: Attempt to remove non-JNI local reference, dumping thread
01-16 21:46:16.898 2850-2861/##project## I/art: Background sticky concurrent mark sweep GC freed 1730(132KB) AllocSpace objects, 1(20KB) LOS objects, 0% free, 12MB/12MB, paused 63.221ms total 120.237ms
01-16 21:46:17.231 2850-2850/##project## W/FA: Service connection failed: ConnectionResult{statusCode=SERVICE_VERSION_UPDATE_REQUIRED, resolution=null, message=null}
01-16 21:46:17.265 2850-2850/##project## W/art: Attempt to remove non-JNI local reference, dumping thread
01-16 21:46:17.386 2850-2861/##project## I/art: Background partial concurrent mark sweep GC freed 882(72KB) AllocSpace objects, 1(20KB) LOS objects, 16% free, 19MB/23MB, paused 19.678ms total 161.802ms
01-16 21:46:18.255 2850-2850/##project## W/art: Attempt to remove non-JNI local reference, dumping thread
01-16 21:46:18.416 2850-2850/##project## W/art: Attempt to remove non-JNI local reference, dumping thread
01-16 21:46:18.557 2850-2850/##project## W/art: Attempt to remove non-JNI local reference, dumping thread
01-16 21:46:18.699 2850-2850/##project## W/art: Attempt to remove non-JNI local reference, dumping thread
01-16 21:46:18.720 2850-2861/##project## I/art: Background sticky concurrent mark sweep GC freed 3(72B) AllocSpace objects, 0(0B) LOS objects, 0% free, 26MB/26MB, paused 7.596ms total 22.828ms
01-16 21:47:16.782 2850-5047/##project## W/FA: Tasks have been queued for a long time

Use case :
Application not started, send notification, receive notification in tray, click on it and application start.
https://gist.github.com/etherny/81eab0b991dca2cdfc345350c379abe8

Hi there,
I'am facing the same issue, so i'am trying to understand what's going on in the code.
For the cold start usecase the doc says to use


why the memory usage always increased, do we have recommended device configure?

from 2G increased to 7G after only did a few tasks

Are you using the latest code?
There was a memory leak bug in previous versions, but it has been fixed in the latest code.

got it, I'll try it, thanks bro


Always remove AWS-SNAT-CHAIN rules when running in ENI mode.

Please see each individual commit for details.
Always remove `AWS-SNAT-CHAIN` rules when running in ENI mode.

@brb @jibi ☝

/test

/test-runtime

GKE failure is unrelated, marking as ready


W2022 image cannot be Generalized and used as Azure virtual machine scale set agent

Description
Goal is to use W2022 image for Azure VM ScaleSet as agents.
To reproduce issue :

Create W2022 image according to instructions : https://github.com/actions/runner-images/blob/main/docs/create-image-and-azure-resources.md
Follow instructions here : https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/scale-set-agents?view=azure-devops
execute step 6 (from section "Create a scale set with custom image") from above instructions : C:\Windows\System32\sysprep\sysprep.exe /generalize /oobe /shutdown

Result :
2023-01-06 16:32:24, Error                 SYSPRP MRTGeneralize:98 - ERROR: Failed ConnectServer
2023-02-09 16:28:24, Error                 SYSPRP MRTGeneralize:98 - ERROR: Failed ConnectServer
2023-02-14 09:39:44, Error                 SYSPRP MRTGeneralize:98 - ERROR: Failed ConnectServer
2023-02-14 09:39:59, Error                 SYSPRP ActionPlatform::DeleteValue: Error from RegDeleteValueW for value senseGuid under key HKEY_LOCAL_MACHINE\Software\Microsoft\Windows Advanced Threat Protection; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP SysprepSession::ExecuteAction: Failed during deleteValue operation; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP SysprepSession::ExecuteInternal: Error in executing action for Windows-SenseClient-Service; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP SysprepSession::Execute: Error in executing actions from C:\Windows\System32\Sysprep\ActionFiles\Generalize.xml; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP RunPlatformActions:Failed while executing Sysprep session actions; dwRet = 0x5
2023-02-14 09:39:59, Error      [0x0f0070] SYSPRP RunDlls:An error occurred while running registry sysprep DLLs, halting sysprep execution. dwRet = 0x5
2023-02-14 09:39:59, Error      [0x0f00a8] SYSPRP WinMain:Hit failure while processing sysprep generalize internal providers; hr = 0x80070005
Expected Result : Generalization succeeds.
Note : Several months ago this issue did not existed.
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Image Version: 20230206.1
Is it regression?
No
Expected behavior
I can complete instructions here : https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/scale-set-agents?view=azure-devops and successfully execute step 6 (from section "Create a scale set with custom image") from above instructions : C:\Windows\System32\sysprep\sysprep.exe /generalize /oobe /shutdown
Actual behavior
step 6 fails (from section "Create a scale set with custom image") from above instructions : C:\Windows\System32\sysprep\sysprep.exe /generalize /oobe /shutdown
Result :
2023-01-06 16:32:24, Error                 SYSPRP MRTGeneralize:98 - ERROR: Failed ConnectServer
2023-02-09 16:28:24, Error                 SYSPRP MRTGeneralize:98 - ERROR: Failed ConnectServer
2023-02-14 09:39:44, Error                 SYSPRP MRTGeneralize:98 - ERROR: Failed ConnectServer
2023-02-14 09:39:59, Error                 SYSPRP ActionPlatform::DeleteValue: Error from RegDeleteValueW for value senseGuid under key HKEY_LOCAL_MACHINE\Software\Microsoft\Windows Advanced Threat Protection; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP SysprepSession::ExecuteAction: Failed during deleteValue operation; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP SysprepSession::ExecuteInternal: Error in executing action for Windows-SenseClient-Service; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP SysprepSession::Execute: Error in executing actions from C:\Windows\System32\Sysprep\ActionFiles\Generalize.xml; dwRet = 0x5
2023-02-14 09:39:59, Error                 SYSPRP RunPlatformActions:Failed while executing Sysprep session actions; dwRet = 0x5
2023-02-14 09:39:59, Error      [0x0f0070] SYSPRP RunDlls:An error occurred while running registry sysprep DLLs, halting sysprep execution. dwRet = 0x5
2023-02-14 09:39:59, Error      [0x0f00a8] SYSPRP WinMain:Hit failure while processing sysprep generalize internal providers; hr = 0x80070005
Repro steps

Create W2022 image according to instructions : https://github.com/actions/runner-images/blob/main/docs/create-image-and-azure-resources.md
Follow instructions here : https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/scale-set-agents?view=azure-devops
execute step 6 (from section "Create a scale set with custom image") from above instructions : C:\Windows\System32\sysprep\sysprep.exe /generalize /oobe /shutdown

@MareksIf  Do you have Microsoft Defender for Endpoint running in your environment ?

@erik-de-bont
I checked VM in Azure, and it has extension : MDE.Windows
Type : Microsoft.Azure.AzureDefenderForServers.MDE.Windows
Probably installed by company policy, not sure.
I will try to run script that you have provided.

Hello @MareksIf!
Hmm. It doesn't look like a bug for our images because we did the same system prepare process every time with image build. You can take a look here: ~/images/win/windows2022.json.
And I cannot recommend you disable anti-virus protection - users always perform such actions at their own risk.
But it would be really great if you can report that protection bug to Microsoft Defender developers. That way you may help another users to avoid the same issue. And there we have discussion about the same issues: https://github.com/actions/runner-images/discussions/6251


allow appending deployment key to username (#2062)

This PR allows appending deployment keys to usernames as used by gitlab.
Furthermore a new property is_unsafe is introduced for ParsedUrl, which can be used for cli command like poetry add to easily return whether the git dependency contains a password.
According to gitlab's docs a + is allowed in usernames. This is fixed as well.
Fixes: https://github.com/python-poetry/poetry/issues/2062
(This was initially submitted to the poetry repository: https://github.com/python-poetry/poetry/pull/2169)
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!

[x] Added tests for changed code.
[ ] Updated documentation for changed code.

Thanks for this, @finswimmer!
I noticed one thing that it doesn't explicitly tests for / address is using Personal Access Tokens (https://github.com/python-poetry/poetry/issues/2348). It might work, but would be nice to add a test for it to avoid issues.
GitHub docs about it.
Also, is there anything that I can contribute on this that could help speed things up? Thanks!

Bumping this up again, @finswimmer to ask if there's any specific areas I can help building / supporting that can help speed this up?
Thanks for all your work!

@finswimmer : I took a stab at the remainder items here that'd help in resolving https://github.com/python-poetry/poetry/issues/2062 and https://github.com/python-poetry/poetry/issues/2348, and based it off of the branch for this PR. https://github.com/finswimmer/core/pull/1

Any news here?!?


WHATWG URL parsing API

Ecmascript built-ins provide some URI encoding/decoding support but it's not enough to actually work with URIs. The WHATWG URL parsing API might be a useful counterpart to make URIs easy to work with directly: https://url.spec.whatwg.org/.
URIs are commonly required in networking code so it might be nice to support them out of the box, and there's some internal shared code with the URL encoding/decoding support (though the rule tables might be different because the referenced URL standards have different versions).
If there isn't enough internal synergy, providing this as an extra would be equally viable.

This might be nice to have as a built-in even outside of networking code, for general path parsing.  The specification makes direct references to concepts like Windows drive letters, etc. so it seems like it would be useful for that.


Fixed a bug on 4K screens where environment variable has a decimal …

…value, I wrapped it with Math.round() to ensure an integer result

As an example the bug produces<EMAIL_ADDRESS><EMAIL_ADDRESS>

Great pull request, confirmed to fix the bug.

I'm already using this change in production since I suggested it in the bug report. It seems to work ok with no ill effects.

@xorcery Can merge this too.


How to download the obj dataset of PB_T50_RS？

I downloaded the .bin file. How do I convert it to .ply or .object?

You may have already solved the problem, but I will write down the solution.
You can use the load_pc_file function of data_utils.py to properly transform the bin file.


Include WebRTC data channel stuff

Please see Microsoft/TypeScript#23245 for context. This needs to update src\lib\dom.generated.d.ts so I'm opening a PR here instead of in the TypeScript repository. I will be working on this, but can't guarantee any deadlines/estimates, so anyone else is welcome to race me to PRing this.

@TomasHubelbauer I've created PR. @mhegazy could you review it?

@a-tarasyuk can you please link it here?

Looks like a duplicate of https://github.com/Microsoft/TypeScript/issues/23245 and should be fixed by https://github.com/Microsoft/TSJS-lib-generator/pull/424

I'm such a goof... I thought I opened this in the TSJS-lib-generator repo :-(


Far focus on load

I built an application starting from the QR code scanner example. It works well, but there's something that bothers me. Maybe I'm doing something wrong, but when I run the camera its focus start at infinite, then it takes about 3 seconds to auto-focus adjust so it's possible to scan a QR code. Is there some way to start the camera with focus set to a closer distance?

Tap for focus (assuming the hardware supports it) is the only focus control.
You can access the api for that https://github.com/Android-for-Python/Camera4Kivy#focus after the camera is connected.
Or you could try increasing the analyze_pixels_resolution


Optimize the authentication server for production using  a non-blocking framework:  (Spring Webflux).

@jhonToni We are strictly focusing on a Servlet implementation for the initial set of features that would qualify for a MVP version. We haven't decided whether we'll provide a WebFlux version at this point.
Quite honestly, I'm not convinced it's needed. The client and resource server(s) are the most active, whereas, the authorization server is not as active as it simply issues a token and may validate a token, which is limited activity between the many interactions that follow between a client and resource server after a token is issued.
Either way, I'm going to close this issue as WebFlux is not on the roadmap as of now.

@jgrandja can u help a little bit with the idea of how to convert all of this project to reactive?
In particular the filter part. Any initial pointers will help a lot

@jgrandja Also, it's incompatible with embedding it in a webflux application.

support for that would be helpful especially when we consider modular monolith architecture

Would be great to add support!

I'm a stubborn guy, I hope to join, I'm willing to complete this part

What a stubborn guy, I hope to join, I am willing to complete this part


launchd: add launch_events property

Description
Adding support for the LaunchEvents key in launchd. From man launchd.plist:
LaunchEvents <dictionary of dictionaries of dictionaries>
Specifies higher-level event types to be used as launch-on-demand event sources.  Each sub-dictionary defines events for a particular event subsystem, such as "com.apple.iokit.match-ing", which can be used to launch jobs based on the appearance of nodes in the IORegistry. Each dictionary within the sub-dictionary specifies an event descriptor that is specified to each event subsystem. With this key, the job promises to use the xpc_set_event_stream_handler(3) API to consume events. See xpc_events(3) for more details on event sources.

Allows for having a LaunchDaemon with something like the following
	<key>LaunchEvents</key>
	<dict>
		<key>com.apple.iokit.matching</key>
		<dict>
			<key>com.example.iOS-device-attached</key>
			<dict>
				<key>IOMatchLaunchStream</key>
				<true/>
				<key>IOProviderClass</key>
				<string>IOUSBDevice</string>
			</dict>
		</dict>
	</dict>

Related Issue
n/a
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Looks good to me! @tas50 Thoughts?

Thanks @chilcote. Congrats on the first commit


Routing is not working - Spring cloud gateway + Eureka Server

@SpringBootApplication
@EnableEurekaClient
@Configuration
public class GatewayApplication {

    @Bean
    public RouteLocator customRouteLocator(RouteLocatorBuilder builder) {
        return builder.routes()
                .route("um_route", r -> r
                        .path("/um/**")
                        .uri("lb://user-management")
                )
                .build();
    }
}

discovery.locator is enabled as:
spring.application.name=gateway
server.port=10002

spring.cloud.gateway.discovery.locator.enabled=true
spring.cloud.gateway.discovery.locator.lower-case-service-id=true

application is registed:

but when I http://localhost:10002/um/hello I got 404 as response
ps:
it seems spring cloud gateway have a default config for the routing as /application-name/
so I got response by url http://localhost:10002/user-management/hello
But still don't know how to customize the routing url

You might try adding  setPath("/hello")  in routing

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

@ryanjbaxter
I am facing a similar problem, the loadbalancer is not able to retrieve the server list.
Error message:
2018-09-05 23:20:17.751  INFO 47037 --- [ctor-http-nio-2] c.netflix.loadbalancer.BaseLoadBalancer  : Client: localhost instantiated a LoadBalancer: DynamicServerListLoadBalancer:{NFLoadBalancer:name=localhost,current list of Servers=[],Load balancer stats=Zone stats: {},Server stats: []}ServerList:null
2018-09-05 23:20:17.756  INFO 47037 --- [ctor-http-nio-2] c.n.l.DynamicServerListLoadBalancer      : Using serverListUpdater PollingServerListUpdater
2018-09-05 23:20:17.760  INFO 47037 --- [ctor-http-nio-2] c.n.l.DynamicServerListLoadBalancer      : DynamicServerListLoadBalancer for client localhost initialized: DynamicServerListLoadBalancer:{NFLoadBalancer:name=localhost,current list of Servers=[],Load balancer stats=Zone stats: {},Server stats: []}ServerList:org.springframework.cloud.netflix.ribbon.eureka.DomainExtractingServerList@107dc063
2018-09-05 23:20:17.822 ERROR 47037 --- [ctor-http-nio-2] .a.w.r.e.DefaultErrorWebExceptionHandler : Failed to handle request [GET http://localhost:8080/rest-service/hello]

org.springframework.cloud.gateway.support.NotFoundException: Unable to find instance for localhost
	at org.springframework.cloud.gateway.filter.LoadBalancerClientFilter.filter(LoadBalancerClientFilter.java:72) ~[spring-cloud-gateway-core-2.0.1.RELEASE.jar:2.0.1.RELEASE]
	at org.springframework.cloud.gateway.handler.FilteringWebHandler$GatewayFilterAdapter.filter(FilteringWebHandler.java:133) ~[spring-cloud-gateway-core-2.0.1.RELEASE.jar:2.0.1.RELEASE]
	at org.springframework.cloud.gateway.filter.OrderedGatewayFilter.filter(OrderedGatewayFilter.java:44) ~[spring-cloud-gateway-core-2.0.1.RELEASE.jar:2.0.1.RELEASE]
	at org.springframework.cloud.gateway.handler.FilteringWebHandler$DefaultGatewayFilterChain.lambda$filter$0(FilteringWebHandler.java:115) ~[spring-cloud-gateway-core-2.0.1.RELEASE.jar:2.0.1.RELEASE]
	at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:45) ~[reactor-core-3.1.8.RELEASE.jar:3.1.8.RELEASE]

Code:

Eureka Server
Spring Cloud Gateway
Rest service

PS: Works fine when the actual endpoint is provided instead of the service id.

Closing this issue due to lack of requested feedback.

Closing this issue due to lack of requested feedback.

sorry feedback late:
here is my demo projects reproduce the problem:
https://github.com/poppinlr/client.git
https://github.com/poppinlr/gateway.git
https://github.com/poppinlr/serviceManagement.git
I can get response from http://localhost:8082/client/hello
as I said use the default service id
but the java config doesn't work : as
    @Bean
    public RouteLocator customRouteLocator(RouteLocatorBuilder builder) {
        return builder.routes()
                .route("um_route", r -> r
                        .path("/clinetc/**")
                        .uri("lb://clinet/")
                )
                .build();
    }

your route has spelling errors clinet vs client and clinetc vs clientc.
    @Bean
    public RouteLocator customRouteLocator(RouteLocatorBuilder builder) {
        return builder.routes()
                .route("um_route", r -> r
                        .path("/clientc/**")
                        .filters(f -> f.stripPrefix(1))
                        .uri("lb://client/")
                )
                .build();
    }

.filters(f -> f.stripPrefix(1))

Sorry for spelling mistake,
I think  .filters(f -> f.stripPrefix(1)) help to solve the problem, thanks!

Hi @spencergibb
I am integrating spring cloud gateway with consul to discover services.
My bootstrap.properties is as below
spring:    application:       name: fci-ccm-gateway    cloud:       consul:          enabled: true          host: localhost          port: 8500          discovery:             register: false             enabled: true       gateway:          discovery:             locator:                enabled: true
My application.properties is as below
server:    port: 4321
My RoutingConfig class is below-
`@Configuration
public class RoutingConfig {
@Bean
public RouteLocator gatewayRoutes(RouteLocatorBuilder builder) {
	return builder.routes()
			.route(r -> r.path("/productConfig/**").filters(f -> f.stripPrefix(1)).uri("lb://demo/").id("demo"))
			.build();

}

}
`
In the consul service is registered with name as demo.
Also while starting it showing logs as below with no errors-
2019-11-22 19:42:24.508  INFO 4242 --- [           main] b.c.PropertySourceBootstrapConfiguration : Located property source: CompositePropertySource {name='consul', propertySources=[ConsulPropertySource {name='config/fci-ccm-gateway/'}, ConsulPropertySource {name='config/application/'}]} 2019-11-22 19:42:24.513  INFO 4242 --- [           main] com.fci.ccm.FciCcmGateway                : No active profile set, falling back to default profiles: default 2019-11-22 19:42:25.143  WARN 4242 --- [           main] o.s.boot.actuate.endpoint.EndpointId     : Endpoint ID 'bus-env' contains invalid characters, please migrate to a valid format. 2019-11-22 19:42:25.379  WARN 4242 --- [           main] o.s.boot.actuate.endpoint.EndpointId     : Endpoint ID 'bus-refresh' contains invalid characters, please migrate to a valid format. 2019-11-22 19:42:25.415  WARN 4242 --- [           main] o.s.boot.actuate.endpoint.EndpointId     : Endpoint ID 'service-registry' contains invalid characters, please migrate to a valid format. 2019-11-22 19:42:25.795  INFO 4242 --- [           main] o.s.cloud.context.scope.GenericScope     : BeanFactory id=affa8031-8929-3537-8b85-16b8abcc7638 2019-11-22 19:42:25.805  INFO 4242 --- [           main] faultConfiguringBeanFactoryPostProcessor : No bean named 'errorChannel' has been explicitly defined. Therefore, a default PublishSubscribeChannel will be created. 2019-11-22 19:42:25.810  INFO 4242 --- [           main] faultConfiguringBeanFactoryPostProcessor : No bean named 'taskScheduler' has been explicitly defined. Therefore, a default ThreadPoolTaskScheduler will be created. 2019-11-22 19:42:25.815  INFO 4242 --- [           main] faultConfiguringBeanFactoryPostProcessor : No bean named 'integrationHeaderChannelRegistry' has been explicitly defined. Therefore, a default DefaultHeaderChannelRegistry will be created. 2019-11-22 19:42:25.868  INFO 4242 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.retry.annotation.RetryConfiguration' of type [org.springframework.retry.annotation.RetryConfiguration$$EnhancerBySpringCGLIB$$24aab0bf] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying) 2019-11-22 19:42:25.923  INFO 4242 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'integrationDisposableAutoCreatedBeans' of type [org.springframework.integration.config.annotation.Disposables] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying) 2019-11-22 19:42:25.956  INFO 4242 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.integration.config.IntegrationManagementConfiguration' of type [org.springframework.integration.config.IntegrationManagementConfiguration$$EnhancerBySpringCGLIB$$99d8d3c9] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying) 2019-11-22 19:42:25.978  INFO 4242 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.integration.IntegrationAutoConfiguration$IntegrationJmxConfiguration' of type [org.springframework.boot.autoconfigure.integration.IntegrationAutoConfiguration$IntegrationJmxConfiguration$$EnhancerBySpringCGLIB$$756adee9] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying) 2019-11-22 19:42:26.001  INFO 4242 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.jmx.JmxAutoConfiguration' of type [org.springframework.boot.autoconfigure.jmx.JmxAutoConfiguration$$EnhancerBySpringCGLIB$$ae5287b6] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying) 2019-11-22 19:42:26.195  INFO 4242 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'mbeanServer' of type [com.sun.jmx.mbeanserver.JmxMBeanServer] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying) 2019-11-22 19:42:26.208  INFO 4242 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration' of type [org.springframework.cloud.autoconfigure.ConfigurationPropertiesRebinderAutoConfiguration$$EnhancerBySpringCGLIB$$4b011b97] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying) 2019-11-22 19:42:26.505  WARN 4242 --- [           main] c.n.c.sources.URLConfigurationSource     : No URLs will be polled as dynamic configuration sources. 2019-11-22 19:42:26.507  INFO 4242 --- [           main] c.n.c.sources.URLConfigurationSource     : To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. 2019-11-22 19:42:26.514  WARN 4242 --- [           main] c.n.c.sources.URLConfigurationSource     : No URLs will be polled as dynamic configuration sources. 2019-11-22 19:42:26.514  INFO 4242 --- [           main] c.n.c.sources.URLConfigurationSource     : To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. 2019-11-22 19:42:27.302  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [After] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Before] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Between] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Cookie] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Header] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Host] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Method] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Path] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Query] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [ReadBodyPredicateFactory] 2019-11-22 19:42:27.303  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [RemoteAddr] 2019-11-22 19:42:27.304  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [Weight] 2019-11-22 19:42:27.304  INFO 4242 --- [           main] o.s.c.g.r.RouteDefinitionRouteLocator    : Loaded RoutePredicateFactory [CloudFoundryRouteService] 2019-11-22 19:42:27.855  INFO 4242 --- [           main] o.s.s.c.ThreadPoolTaskScheduler          : Initializing ExecutorService 'taskScheduler' 2019-11-22 19:42:28.029  INFO 4242 --- [           main] o.s.b.a.e.web.EndpointLinksResolver      : Exposing 2 endpoint(s) beneath base path '/actuator' 2019-11-22 19:42:28.582  INFO 4242 --- [           main] o.s.s.c.ThreadPoolTaskScheduler          : Initializing ExecutorService 'catalogWatchTaskScheduler' 2019-11-22 19:42:28.660  INFO 4242 --- [           main] o.s.s.c.ThreadPoolTaskScheduler          : Initializing ExecutorService 'configWatchTaskScheduler' 2019-11-22 19:42:28.740  INFO 4242 --- [           main] o.s.c.s.m.DirectWithAttributesChannel    : Channel 'fci-ccm-gateway-1.springCloudBusInput' has 1 subscriber(s). 2019-11-22 19:42:28.831  INFO 4242 --- [           main] o.s.i.monitor.IntegrationMBeanExporter   : Registering MessageChannel springCloudBusOutput 2019-11-22 19:42:28.879  INFO 4242 --- [           main] o.s.i.monitor.IntegrationMBeanExporter   : Registering MessageChannel nullChannel 2019-11-22 19:42:28.892  INFO 4242 --- [           main] o.s.i.monitor.IntegrationMBeanExporter   : Registering MessageChannel errorChannel 2019-11-22 19:42:28.919  INFO 4242 --- [           main] o.s.i.monitor.IntegrationMBeanExporter   : Registering MessageChannel springCloudBusInput 2019-11-22 19:42:28.930  INFO 4242 --- [           main] o.s.i.monitor.IntegrationMBeanExporter   : Registering MessageHandler errorLogger 2019-11-22 19:42:28.946  INFO 4242 --- [           main] o.s.i.monitor.IntegrationMBeanExporter   : Registering MessageHandler org.springframework.cloud.stream.binding.StreamListenerMessageHandler@67b560fe 2019-11-22 19:42:29.030  INFO 4242 --- [           main] o.s.i.endpoint.EventDrivenConsumer       : Adding {logging-channel-adapter:_org.springframework.integration.errorLogger} as a subscriber to the 'errorChannel' channel 2019-11-22 19:42:29.030  INFO 4242 --- [           main] o.s.i.channel.PublishSubscribeChannel    : Channel 'fci-ccm-gateway-1.errorChannel' has 1 subscriber(s). 2019-11-22 19:42:29.030  INFO 4242 --- [           main] o.s.i.endpoint.EventDrivenConsumer       : started _org.springframework.integration.errorLogger 2019-11-22 19:42:29.069  INFO 4242 --- [           main] b.c.PropertySourceBootstrapConfiguration : Located property source: CompositePropertySource {name='consul', propertySources=[ConsulPropertySource {name='config/fci-ccm-gateway/'}, ConsulPropertySource {name='config/application/'}]} 2019-11-22 19:42:29.335  INFO 4242 --- [           main] o.s.i.endpoint.EventDrivenConsumer       : Adding {message-handler:outbound.springCloudBus} as a subscriber to the 'springCloudBusOutput' channel 2019-11-22 19:42:29.335  INFO 4242 --- [           main] o.s.c.s.m.DirectWithAttributesChannel    : Channel 'fci-ccm-gateway-1.springCloudBusOutput' has 1 subscriber(s). 2019-11-22 19:42:29.335  INFO 4242 --- [           main] o.s.i.endpoint.EventDrivenConsumer       : started outbound.springCloudBus 2019-11-22 19:42:29.359  INFO 4242 --- [           main] o.s.c.c.b.ConsulInboundMessageProducer   : started org.springframework.cloud.consul.binder.ConsulInboundMessageProducer@2ad2b274 2019-11-22 19:42:29.629  INFO 4242 --- [           main] o.s.b.web.embedded.netty.NettyWebServer  : Netty started on port(s): 4321
Problem is   when I accessing this url http://localhost:4321/productConfig
It gives me
There was an unexpected error (type=Service Unavailable, status=503). Unable to find instance for demo
Can you please help ?
Thanks

.filters(f -> f.stripPrefix(1))

Sorry for spelling mistake,
I think .filters(f -> f.stripPrefix(1)) help to solve the problem, thanks!

Thanks it worked for me

.filters(f -> f.stripPrefix(1))

I don't know what reason is, but it worked for me. Omg, it took me 3 hours. Thank you so much.

your route has spelling errors clinet vs client and clinetc vs clientc.
    @Bean
    public RouteLocator customRouteLocator(RouteLocatorBuilder builder) {
        return builder.routes()
                .route("um_route", r -> r
                        .path("/clientc/**")
                        .filters(f -> f.stripPrefix(1))
                        .uri("lb://client/")
                )
                .build();
    }

Man i tried several different configuration but this was the only that worked for me, thanks a lot!

.filters(f -> f.stripPrefix(1))

I don't know what reason is, but it worked for me. Omg, it took me 3 hours. Thank you so much.

for me took 1 day hahaha

adding this code : .filters(f -> f.stripPrefix(1)), resolved the problem I was facing (404 not found response)

Can someone please check on this issue as well..

Can some please check on this issue as well  : https://github.com/Narenderflora/spring-cloud-gateway/issues/1

OMG. It literally makes no senses but this help me escape from 404 response !!!

                    .filters(f -> f.stripPrefix(1))


BigQuery wrapper: JSON not supported

Trying to query a table with JSON data type in BigQuery.
Foreign table, with json column type, gets created fine but upon querying, the wrapper returns:
Failed to run sql query: get table metadata failed: Request error (error: error decoding response body: unknown variant `JSON`, expected one of `STRING`, `BYTES`, `INTEGER`, `INT64`, `FLOAT`, `FLOAT64`, `NUMERIC`, `BIGNUMERIC`, `BOOLEAN`, `BOOL`, `TIMESTAMP`, `DATE`, `TIME`, `DATETIME`, `RECORD`, `STRUCT` at line 15 column 22)

The workaround I used till supported:

use json_to_string() in bigquery
in the foreign table ddl, define that column as text and add a generated column to convert back to json (jsonStringColumn::json)

Yes, JSON is not support yet in BigQuery FDW. A workaround is using TO_JSON_STRING to convert JSON to STRING in BigQuery and store that string as source table column. Then use subquery or view on top of PG foreign table and convert that string back to JSON.

We're currently working on improving BigQuery fdw, the JSON support should be ready on the next release. And thanks for the subquery in table option, it is quite useful, we will evaluate and hopefully include it in the future release.

EDIT: I have edited the title and added Numeric:
Failed to run sql query: field type Numeric not supported
which is a valid type in PG: https://www.postgresql.org/docs/current/datatype-numeric.html
Would be good to add all supported ones or document the limited support.
Thanks.

@burmecia I believe this should be reopened. #78 added numeric support, but not JSON, which was the main issue raised originally.


authorization code grant request does not set "state"

The API documentation at https://developer.vimeo.com/api/authentication#generate-redirect says that the "state" param is required and should be validated by the client, but I don't see where the Python library is setting it or validating it.

Sorry, I suppose validation would be left up to the user, but I don't see the option to set it.

@justinruggles You could set it here

We should add it as a parameter to auth_url


fix fix streams for node memory leak in sink v2

Proposed changes
We shouldn't clear _streams_for_node until we release it,
otherwise there will be a memory leak.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


App Framework - Now with build for Apple App Store

Hey folks, after two month of development, I am happy to present you now: App Framework

App Framework
Does all the tricky stuff for you to develop, test, build and deploy iOS and Android like web applications.
Features

The power is under the hood - but for sure, we have a Demo App.

Beautiful

All well known iOS and Material user interface components as well as native transitions
Comprehensive icon fonts like FontAwesome, Framework7, Ion and Material Icons
Phone frame around your application on big screens

Powerful

Easy realization of state based, reactive user interfaces with the power of Vue.js
State kept for history, tabs, scroll positions, panels, modals, form and page component data
User registration, password reset and login processes with Firebase Authentication
Realtime database and file storage services with Firebase
Application hosting with Firebase Hosting
Offline capabilty, flexible routing and multi-language support

Timesaving

Creation of a lightweight and well-organized project folder, prepared to push to GitHub
Development server with live reload, perfectly to use together with Chrome DevTools
Your application is splitted up in easy to maintain single file components with ES2015 support
Generation of favicons, touch icons and splash screens out of a single image file
Integrated code checks for correctness and standard conformity
Build process with version bump and compression of all HTML, CSS, JavaScript and image files
Deployment to Firebase Hosting or your own server without downtime and with easy rollback solution

Scope extended - Deployment will be realized for Apple App Store and Google Play Store as well.
@nolimits4web - Vladimir, would it be okay for you to add App Framework to your starter kit list?

Version 1.1 released - now with Apple App Store build :-)
https://github.com/scriptPilot/app-framework

Version 1.2 released - now with Google Play Store deployment!
https://github.com/scriptPilot/app-framework
@nolimits4web - Vladimir, I pushed PR to your documentation, in order to promote App Framework at the right place. If you prefer, you could close this issue then.
Dennis


Fix some tests : make coverage -> test

make coverage use mysql database in paralell than test-mysql. That introduce test fails for test like GPG that insert key at runtime.
And some quick fix of missed error during PRs.

@JonasFranzDEV Yes, I haven't look in detail for the part still failling. I have mostly look for the what happen aroung the GPG part since I have worked on it. ^^

But why so many files changed?

@lunny I just moved integrations/gitea-repositories-meta/gitea-repositories to integrations/gitea-repositories-meta so that for each (mysql/pgsql/sqlite) sepearate gitea-repositories-* directory could be used and there is no hardcoded value but app.ini configuration value is reused

LGTM

LGTM

thx @lafriks


Article on Using Azure Private Link Service to access Azure Kubernetes Service/App  across another VNET/network

There is not much information available on how to access a Kubernetes Service on Private AKS Cluster from a different VNET or network.
So, for example, let's say we created a serviceA that is accessible inside the VNET of the Private AKS Cluster.  The article could talk about on

How can this service be accessed in another VNET
How can Azure PaaS services like Azure Data Factory, Databricks etc access the Kubernetes service? The Paas services have managed VNET so VNET peering is not possible in this case.

This can be achieved through PLS and Linked Service Integration and we did it for a customer of ours. Can document and write the article for the same.
This will help in many cases of PaaS services using Managed VNETs.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fb4b8145-27ae-8817-6d85-969aa85e601d
Version Independent ID: 00f897cd-5c20-cb3b-9c17-5f75eddd1715
Content: What is Azure Private Link service?
Content Source: articles/private-link/private-link-service-overview.md
Service: private-link
GitHub Login: @asudbring
Microsoft Alias: allensu

@kshitijcode
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!

@Naveenommi-MSFT The documentation doesn't exist for this anywhere. We want to add the documentation to Azure Private Link Service.
https://learn.microsoft.com/en-us/azure/private-link/private-link-service-overview

@kshitijcode , these details are available in the below doc:
https://learn.microsoft.com/en-gb/azure/aks/private-clusters#virtual-network-peering
The above doc talks about both "Vnet peering" and "Hub and spoke with custom DNS" scenarios.
Could you please check this doc and let us know if there is any other specific scenario that you are looking for?

@kshitijcode , We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Yes, So the doc doesn't talk about anything for "managed VNETs". These VNETS(https://learn.microsoft.com/en-us/azure/data-factory/managed-virtual-network-private-endpoint)  are used by different PaaS Services like Azure DataFactory, DataBricks, and many other Azure PaaS services.  The "managed VNETs" are maintained by azure and cannot be paired. Hence in such scenarios, it's challenging to access Private Endpoints across a different VNET and there is therefore no documentation about the same.
Also, not much context or information is available on how to expose services on a private AKS cluster on a different VNET without making it public. So let's say I am using a managed VNET through ADF and I have an app exposed as a service in a private AKS cluster in a different VNET. How can we access the Kubernetes service(app) privately without going public in ADF?

@kshitijcode , this document where you have raised the feedback only talks about Private link and Private endpoint in general such as private dns integration, rbac permissions, creating private endpoints, managing private endpoints etc. and do not talk about any specific azure services. For specific azure service integration with private endpoint, you need to refer the respective azure service doc.
Now, coming back to your below point:
How can Azure PaaS services like Azure Data Factory, Databricks etc access the Kubernetes service? The Paas services have managed VNET so VNET peering is not possible in this case. ---> This can be achieved through PLS and Linked Service Integration and we did it for a customer of ours. Can document and write the article for the same.
This type of setup is documented in the ADF docs.
Refer : https://learn.microsoft.com/en-us/azure/data-factory/tutorial-managed-virtual-network-sql-managed-instance
If you are looking for a specific doc with tutorial to access AKS from ADF, I would request you to raise a doc feedback from the ADF docs.

@GitaraniSharma-MSFT  i am looking for some way to connect my private AKS cluster to from outside network(not using VPN either) as i have terraform cloud creating infra and AKS and post that not able to apply any resource (via terraform) as API is private.
is there any way private link or anything else will help here?


Fullscreen issue with InternetExplorer

Describe the bug
There are three issues with fullscreen:

The f keyboard control does not work in Internet Explorer.
You can not go fullscreen even if you click on fullscreen button in bottom right. The screen just goes black. (Internet Explorer)
If you go fullscreen and hit Escape on keyboard, the fullscreen icon does not change back.

To Reproduce
Follow steps listed in the description.
Expected behavior

The fullscreen feature and the f keyboard control should work properly in Internet Explorer.
Hitting escape on keyboard when in fullscreen mode should exit fullscreen and change back the fullscreen icon properly

Screenshots or Links

Affected version
v3.0.0
UPDATE:
Issue 1 & 2 exist in Internet explorer 11, Issue 3 exists in all browsers(Internet Explorer 11, Chrome, Edge). The issues can be experienced with the video on the fluidplayer website:
https://www.fluidplayer.com/#demo
Internet Explorer version : 11.900.18362.0

Please provide version. Anything but IE 11 or latest Edge is not supported.

Issue 1 & 2 exist in Internet explorer 11, Issue 3 exists in all browsers(Internet Explorer 11, Chrome, Edge).
Internet Explorer version : 11.900.18362.0

@amritsingh22 - Can you please confirm if the issue is persisting or is resolved

@amritsingh22 - Can you please confirm if the issue is persisting or is resolved

I was able to figure out a solution. Thank you
On Fri, Dec 24, 2021, 2:31 AM HariPriyaKuberSingh @.***>
wrote:

@amritsingh22 https://github.com/amritsingh22 - Can you please confirm
if the issue is persisting or is resolved
—
Reply to this email directly, view it on GitHub
https://github.com/fluid-player/fluid-player/issues/493#issuecomment-1000777784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQHOGFBWKTEGEXB6PXA4Y6DUSRDX5ANCNFSM4OV7ZCEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Based on the reporters comment, the issue is fixed and hence closing the ticket


Merge develop branch to v2 branch

Codecov Report

Merging #2239 (af11cb0) into v2 (024557e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v2    #2239   +/-   ##
=======================================
  Coverage   97.65%   97.65%
=======================================
  Files          56       56
  Lines       10477    10477
=======================================
  Hits        10231    10231
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 024557e...af11cb0. Read the comment docs.


Covenant API

Add support for the Covenant API, which is a new addition to the Game Data APIs for the Shadowlands expansion.

I'll take a swing at this. Seems like a small and easy enough API set.

@danjagnow wanted to check and see if you'd be cool with some tweaks I was interested in introducing while unit testing this method. Specifically I was looking at doing the following:

Including Fluent Assertions for some validation of model deserializations
Tests for different region+locale combos to better exercise some of the other code paths beyond the Region.US and Locale.en_US

Not planning to do all combos, but at least get a little more coverage.

Change up the test case layout for the Covenant API methods, similar to the DI tests

Basically looking at trying to bring a little SRP to the unit tests so that 1 class focuses on testing one method (or in this case pair of methods for the region+locale overload).

Let me know your thoughts, don't want to add too much or create fragmentation if you're not on-board.

Adding Fluent Assertions would be good.  I use it in my professional work, and I like it.  I have just been too lazy to add validations beyond the not-null check.  This is particularly important after the PR that migrated from Newtonsoft.Json to System.Text.Json.  Previously it was possible to set MissingMemberHandling = MissingMemberHandling.Error for debug builds, which made it much easier to discover cases where the C# models lacked a property that was needed for full deserialization of the JSON.  See the note about MissingMemberHandling in the migration guidance for details.  Hopefully https://github.com/dotnet/runtime/issues/37483 will get addressed in the future.
Tests for different combinations of region and locale would be very welcome; again, I've just been too lazy to add these.
Changing the test case layout is fine with me.  I find that the existing layout is fine for the level of testing that is currently being performed, but having a single test class per API may be too coarse-grained when adding the variants you're proposing.  Feel free to change it up.


Enhancement of ConverterRevit: Extracting material quantities and properties (incl. multi-material elements)

Problem: The current Revit converter does not allow for retrieving quantities from an element consisting of multiple materials.
Example: A multi-layered wall does only have 1 Volume. However, for analysing quantities for cost-estimation or LCA we need exact quantities of each material.
Enhancement: I propose adding an object to the Base-object generated in ConvertToSpeckle in the ConverterRevit. It needs to be discussed how this quantity should be structured. It could either have a set of the materials with all their parameters and the quantities (volumes, area). Or - to begin with - just the material-id and quantities.
Please let me know what you think. I would be happy to contribute.
Thanks,
Kilian

Hi Kilian, I'm fully in favor of this!
Ideally, we'd find a way to define the quantities and materials in a way that is not Revit specific so it can be applied also to elements coming from other BIM software.
We'll discuss how to best implement it internally, in the meantime feel free to start looking at what the Revit logic to get this information out would look like :)
@izzylys this could be a valid addition to our object cleanup.
@JR-Morgan would it make any sense to leverage the material properties we are already using for rendering?


Rename some xml_rpc_server methods

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.43%. Comparing base (ec5d62b) to head (4d3859b).
Report is 74 commits behind head on devel.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1548      +/-   ##
==========================================
- Coverage   90.42%   88.43%   -1.99%
==========================================
  Files          49       52       +3
  Lines        6037     6400     +363
==========================================
+ Hits         5459     5660     +201
- Misses        578      740     +162

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add behavior on predefined keyword (E.X. oneOf)

What version of Ajv you are you using?
6.9.2
What problem do you want to solve?
I would like implement discriminator feature on AJV by addKeyword feature
But i get stuck for AJV always report it has error under oneOf statement.
I has try call before validate
ajv.removeKeyword("oneOf")
ajv.addKeyword("oneOf", {.....})

it work for disable oneOf checking, but i would like keep the original implementation if discriminator not available, so what should i do ?
What do you think is the correct solution to problem?
Here is my attempt code.
const ajv = new Ajv(opts)
  ajv.removeKeyword("oneOf")
  ajv.addKeyword("oneOf", {
    inline: function(it, keyword, schema, parentSchema) {
      if (parentSchema.discriminator) {
        return "true" // disable the checking if discriminator available
      }
      const inlineCode = doT.compile(require("ajv/lib/dotjs/oneOf"))(
        it,
        keyword,
        schema,
        parentSchema
      )
      return inlineCode
    },
    errors: true,
    statements: true
  })

But it not working.
When i used to validate the schema
Schema
{
  $id: "fuck-off",
  oneOf: [
    {
      $ref: "#/definitions/A"
    },
    {
      $ref: "#/definitions/B"
    },
    {
      $ref: "#/definitions/C"
    }
  ],
  definitions: {
    A: {
      type: "object",
      properties: {
        objType: {
          type: "string",
          enum: ["A"]
        },
        bProp: {
          type: "string"
        }
      },
      required: ["objType", "aProp"]
    },
    B: {
      type: "object",
      properties: {
        objType: {
          type: "string",
          enum: ["B"]
        },
        bProp: {
          type: "string"
        }
      },
      required: ["objType", "bProp"]
    },
    C: {
      type: "object",
      properties: {
        objType: {
          type: "string",
          enum: ["C"]
        },
        cProp: {
          type: "string"
        }
      },
      required: ["objType", "cProp"]
    }
  }

code:
    validate({
      objType: "C"
    })

it expect should throw error because missing cProp.
But in fact i can't get all error ....
Will you be able to implement it?

Finally, i got that working code
  const orgOneOfImplementation = ajv.RULES.all.oneOf.code
  ajv.RULES.all.oneOf.code = (it, keyword, schema) => {
    if (it.schema.discriminator) {
      return undefined // disable the checking if discriminator available
    }
    return orgOneOfImplementation(it, keyword, schema)
  }

But it is possible expose official API to do that ? That look odd

I believe discriminator is no-op in the new version of swagger and should only be used to optimise oneOf behaviour (to avoid validating the branches that would fail), but it doesn't change the validation result. Discriminator doesn't really replace oneOf validation, but it shortcuts the branch selection by excluding all branches that are guaranteed to fail (so the implementation above is not correct).
You could simply add it as no-op to allow it in strictKeywords mode:
ajv.addKeyword('discriminator');

Or you could submit an enhancement PR that introduces option "discriminator" to enable discriminator keyword to optimise the validation of oneOf keyword (to only validate against one branch). Or maybe openAPI option to enable both "nullable" and "discriminator", and then "nullable" option can be deprecated and removed from the next major version.
If you go this route, I would probably like to see some extra schema validation step (possibly optional) that would guarantee that only one branch can pass for each allowed discriminator value.
And, obviously, tests both to test new behaviour and also to ensure "discriminator" is ignored without the option and all branches are still validated even if it is present.
Or it indeed can be a plug-in introducing discriminator by replacing oneOf implementation - but it feels wrong though to replace oneOf - there likely to be some edge cases...

@epoberezkin My current solution is transpiler discriminator to select keyword which introduced in
ajv-keyword
For reference , my implementation here:
createAJVInstance

@davidnghk01 I'm not sure, that we have the same use case, but it seems to be very similar. I want to validate request body with OpenAPI-Schema. Validating object has something like state. Different states has different requirements for the same object. For example, in hidden object is everything optional, but in active not. The example with discriminator doesn't worked for me with ajv, because ajv ignores discriminator and just assume hidden state. This is fatal for validation.
The OpenApi doesn't support constants, but proposed solution from the author to add an enum seems to work:
openapi: 3.0.0
info:
  title: About MyObjects
  version: 0.0.1
paths: {}

components:
  schemas:
    MyObject:
      oneOf:
        - $ref: "#/components/schemas/MyObjectHidden"
        - $ref: "#/components/schemas/MyObjectActive"
      discriminator:
        propertyName: state
        mapping:
          HIDDEN: "#/components/schemas/MyObjectHidden"
          ACTIVE: "#/components/schemas/MyObjectActive"

    MyObjectBase:
      properties:
        phoneNumber:
          type: string

    MyObjectHidden:
      allOf:
        - $ref: "#/components/schemas/MyObjectBase"
        - type: object
          required:
            - state
          properties:
            state:
              type: string
              enum:
                - HIDDEN

    MyObjectActive:
      allOf:
        - $ref: "#/components/schemas/MyObjectBase"
        - type: object
          required:
            - state
            - phoneNumber
          properties:
            state:
              type: string
              enum:
                - ACTIVE

const valid = ajv.validate({$ref: 'openapi.yml#/components/schemas/MyObject'}, body)

The generation of typescript-fetch is broken for this example, but I hope it is fixed in 4.2.1.

see https://github.com/epoberezkin/ajv/issues/1119 for discriminator keyword


Add "Try Again" button

Hi, I have a suggestion.
A file is in use:

Please add "Try Again" button,
Like Windows Explorer:

Thanks

Version 2.3 added retry button. If you don't see the update on the Store you can get it from files.community/download/stable.