Add unsafeSsl parameter on influxdb

Signed-off-by: Dimitrios Tsioumas<EMAIL_ADDRESS>Adds unsafeSsL parameter in the InfluxDB scaler, usnafeSsl disables SSL certificate verification. Use when connecting over HTTPS with a self-signed certificate.
Checklist

[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[ ] Tests have been added
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[ ] A PR is opened to update the documentation on (repo) (if applicable)
[ ] Changelog has been updated

Fixes #2124

Could you sign your latest commit?
https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what
There are another 2 errors related with the linting. Could you take a look at them?
https://github.com/kedacore/keda/runs/3805290932
Thanks :)


improve notices

square blocks with less shadow
turn whole block into clickable link
use dark background + accent color

That looks very jarring on my screen at least.

https://dlang.dawg.eu/

That looks very jarring on my screen at least.

It just looks about right on mine and it's also supposed to be noticed.

Also the first time, that the website has a clear center of focus.

Two alternatives.
white

Red A700 (#D50000)

White is much nicer.
Also, I just remembered that red-on-black is almost unreadable for people with protanopia, so we should avoid that.

#950


How to measure draw calls?

Version
3.60 beta 12
Description
I'm trying to implement basic counter with draw calls number. I was hoping to do so with the AFTER_FLUSH pipeline event but I always get 1 draw call between PRE_RENDER and POST_RENDER webgl renderer events.
Example Test Code
https://codesandbox.io/s/draw-calls-nyjkdc?file=/src/index.ts
Additional notes
SpectorJS shows 7 draws when I make capture for the provided example with 100 texts.

Spector is what I would use. I don't use it for performance testing, but for debugging, it's second to none really.

I was looking for a quick way to check draw calls on mobile devices where SpectorJS is not available.
I have double-checked the code in the provided example and think that either docs for AFTER_FLUSH event are misleading or something wrong with the way I count draw calls. I see 7 draws call in Spector capture but only 1 AFTER_FLUSH event is emitted during the render.

This event is dispatched by a WebGLPipeline right after it has issued a drawArrays command and cleared its vertex count.

You can try this, but don't call it repeatedly.
   protected countDrawCall() {
      let
         drawCallCount = 0,
         renderer = this.sys.renderer;
      if (renderer instanceof Phaser.Renderer.WebGL.WebGLRenderer) {
         this.game.events.on(Phaser.Core.Events.POST_STEP, () => {
            console.log(drawCallCount);
            drawCallCount = 0;
         });

         let gl = WebGLRenderingContext.prototype;
         //@ts-ignore
         gl.realDrawArrays = WebGLRenderingContext.prototype.drawArrays;
         gl.drawArrays = function (mode: GLenum, first: GLint, count: GLsizei) {
            drawCallCount += 1;
            //@ts-ignore
            this.realDrawArrays(mode, first, count);
         };
      }
   }

@x-wk it is nice to see my own code that I have posted some time ago on Phaser forums :)
I was hoping to do it in a "phaser way". Like before 3.60 there was a 'texturesFlush' property which I used.

SpectorJS can be used Standalone on mobile, it doesn't need to be run as a browser extension.

https://twitter.com/phaser_/status/1586050938929815552
You can now test this on https://labs.phaser.io by changing the Phaser version to 'dev' and then clicking 'WebGL Debug' on any example. The renderer has the new methods available.

Closing as this feature is now built into Phaser 3.60.

https://twitter.com/phaser_/status/1586050938929815552
You can now test this on https://labs.phaser.io by changing the Phaser version to 'dev' and then clicking 'WebGL Debug' on any example. The renderer has the new methods available.

Twitter/X compression made this unable to watch properly, it's pixelated, can't see. Any chance to upload it elswhere?

@alamboley there's no need - just do what the instructions in my message said and you can see it for yourself (only you don't have to switch to 'dev' any more, as it's built into 3.60 versions)


Return self in the "new" method

Return self in the "new" method because method return last variable "@trade_for" by default

Thanks:)


feat: Text display orientation and rendering fixes

This adds more features of text displays and fixes some issues with the current implementation

Adds support for fixed text displays
Adds support for rotation and transformation
Fixes background color issues (they are encoded in 2s complements, not direct integers)
Fixes size of text and alignment

Great but does fixed text render fine when it's behind transparent object like stained glass?


Feature request: Add org-save-link in elfeed entry

When I read some great articles, I really want to save them into my org files.
And since we already have a database, so can we add this feature into elfeed? Or is there already a package can do this?

No package but you can use code from here and modify it to your needs:
http://heikkil.github.io/blog/2015/05/09/notes-from-elfeed-entries/

@heikkil Thanks for your tips! It works for me.
Based on your code, I made some improvement to provide a org-store-link-function for elfeed entry.
(defun private/org-elfeed-entry-store-link ()
  (when elfeed-show-entry
    (let* ((link (elfeed-entry-link elfeed-show-entry))
           (title (elfeed-entry-title elfeed-show-entry)))
      (org-store-link-props
       :link link
       :description title)
      )))

(add-hook 'org-store-link-functions 'private/org-elfeed-entry-store-link)

See also #34

Done, close please.


fix(ssr): resolve interlocking circular dependency issues

Description
fixes #11468
Updated logic around managing interlocking circular dependencies in ssrModuleLoader (introduced in #3950), which still has been problematic in certain type of scenarios, e.g., when using dynamic imports. This essentially refactors the way Vite keeps track of pending module dependencies using a graph, which helps identify and tolerate circular dependencies more accurately:

pendingModuleDependencyGraph: Map<string, Set<string>> contains edges, where key is a module url, and the value is a set of URLs of the module's dependencies
addPendingModuleDependency(originUrl, depUrl) updates the dependency graph, adding an edge representing the interdependency between two modules
checkModuleDependencyExists(originUrl, targetUrl) checks for the existence of a transitive (or direct) dependency between two modules

All in all this helps detect circular dependencies between modules, allowing modules to be returned partially executed to circumvent initialization deadlocks when two modules are indirectly waiting on one another (according to the ESM spec). Note that this is only applicable to static imports, as dynamic imports are resolved at runtime and do not contribute to the static dependency graph in the same way.
Added a missing test case capturing a problematic "deadlock" scenario when using dynamic imports (apparently current implementation only solved circular dependencies for static imports), which is currently failing on main: https://github.com/vitejs/vite/actions/runs/7271136773/job/19811284557?pr=15395#step:13:114

Additional context

#11468 became a bespoke umbrella for all sorts of issues when Vite server becomes irresponsive, and while this PR fixes a very particular bug involving circular dependencies, it may not address all of the issues reported there.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Update the corresponding documentation if needed.
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Not sure if I should be worried by these two transient test failures, are these known flaky tests perhaps? (they are passing for me locally, and in CI from time to time):

playground/ssr/__tests__/ssr.spec.ts > html proxy is encoded (failed on first run, 🔴 build; passed on next run, 🟢 build)
playground/lib/__tests__/lib.spec.ts [ playground/lib/__tests__/lib.spec.ts ]  (passed on first run, 🟢 build; failed on next run, 🔴 build)

Seems like generally this changes from a stack to a graph approach for checking circular imports. Can you explain why the stack approach before didn't work before?
I agree that we should probably skip the circular check for dynamic imports. But for static imports the logic seems to be fine before.

Correct. I believe the original approach using the stack certainly worked just fine for regular (static) imports, where the execution of modules follows sequential and linear order based on current implementation in Vite. But in reality the process may start from multiple distant points in the module graph, e.g., in the dynamic imports case, and it lacks accuracy in this type of scenario so circular references go undetected.
/2c I dunno what future direction is for Vite, but it seems that current approach to handling ES modules in SSR context has diverged from the "native" implementation in both Node.js and browsers (it mimics the CJS more than it does ESM). Which can certainly lead to some inconsistent / unexpected behavior, and may present some challenges in the future. So perhaps it could be one area to focus on in the near-term to ensure the implementations is closely aligned w/ the standard, e.g., maybe it could run natively w/ help of experimental module loaders in Node.js.

I tested this branch with my project that's currently impacted by this bug, and it works like a charm :tada:
This'll save countless projects like mine out there.
Can't thank you enough for your work @shYkiSto

Is there anything I can do to help expedite reviewing of this PR? Would be great to patch this long-standing issue in the next minor 🤞
cc @bluwy @patak-dev

+1 I believe this is the cause of a hang when we npm run dev.
Disabling SSR for our layout, as suggested in https://github.com/vitejs/vite/issues/11468#issuecomment-1946677466 works.

Hey @bluwy, @patak-dev,
Any chance this can be prioritized for the upcoming releases? We've been running this revision internally for 3+ months, and there're no reports of circular dependencies causing issues (also, other folks reported that it indeed resolved the issue in their project)
Thanks!

Thanks for your patience here @shYkiSto. I added it to the 5.3 milestone so we force us to push us to decide if we'll move forward with this PR.


Introduced Safer SMTP Alternative: Added SMTP_SSL

Details
While triaging your project, our bug fixing tool generated the following message(s)-

In file: elastalert.py, method: send_notification_email, a clear-text protocol such as FTP, Telnet or SMTP is used. These protocols transfer data without any encryption, which expose applications to a large range of risks. iCR suggested that data should be transferred over only secure transport channels.

Changes

Added SMTP_SSL option with authentication
Updated documentation for SMTP_SSL

Checklist

[x] I have reviewed the contributing guidelines.
[x] I have included unit tests for my changes or additions.
[x] I have successfully run make test-docker with my changes.
[x] I have manually tested all relevant modes of the change in this PR.
[x] I have updated the documentation.
[x] I have updated the changelog.

Questions or Comments

Unit Test: It wasn't needed since SMTP is mocked.
Relevant modes of change in PR: No idea what it means
Documentation: I have updated one rst file.
Changelog: No idea what to add. If you help me, I can add one.

Previously Found & Fixed

https://www.github.com/google/timesketch/pull/2940
https://www.github.com/nasa-gibs/onearth/pull/177
https://www.github.com/geopython/pycsw/pull/917

CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.
The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

Hello and thanks for your interest in ElastAlert2!
There are two new if blocks that will need unit test coverage. While smtp may be mocked already, the use of that mock does not exempt the newly added logic. The unit test should cover the scenarios:

when SSL is not used (already covered by test_notify_email())
when SSL is used but without credentials
when SSL is used with credentials
(optionally) SSL is not used, but credentials are used (your code currently doesn't handle this situation).

Regarding the documentation, the new parameters should clarify that username/password both must be supplied in order to use authentication. Also, it needs to clarify that the credentials will only be provided if SSL is enabled, unless you choose to add support for insecure authentication (test scenario four above)
That said, the alerters in ElastAlert2 already support secure email and authentication. Yet they do so by using credentials stored in a separate file. This is done to avoid storing email secrets in a common configuration file that also contains non-secrets. So adding your changes will introduce a bit of confusion to the project since one email path (ElastAlert2 error notifications) will use email credentials stored in the config file/env, while the other email path (Trigger Alerts) will read credentials from a file dedicated to storing SMTP secrets. I suspect the reason no one has added SSL or authentication support to the former path is because it's rarely used. Given all that, I'm not opposed to adding this PR as-is, since it does add some additional security, even if it doesn't get used very often. But it is something to consider if you were interested in changing the behavior to make it more consistent with the existing secure email path.
You can view the CHANGELOG.md file and observe the pattern we've been using for adding new changelog entries. Other contributors have been successfully able to discern the pattern and add their changes.

Hello, Is there a plan to continue this PR?

Yes, of course. Sorry for my inactiveness. I've thought of changes to this PR and would soon push them.

I updated the documentation of the new fields to match your latest changes.
The unit tests should be verifying that the user/pass is provided to the login function, and should validate that the host/port is provided as configured.

I updated the documentation of the new fields to match your latest changes.
The unit tests should be verifying that the user/pass is provided to the login function, and should validate that the host/port is provided as configured.

Looks like there was a merge conflict. I have resolved it.

Looks like there was a merge conflict. I have resolved it.

Thanks for doing that. The unit tests will need some additional assertions to verify user/pass/host/port are passed as expected. After those assertions are implemented this should be ready to merge.

Closing due to inactivity. Feel free to re-open if the remaining work is ready to push.


GH-3806 improve performance of clear() in NativeStore

GitHub issue resolved: #3806
Briefly describe the changes proposed in this PR:

PR Author Checklist (see the contributor guidelines for more details):

[ ] my pull request is self-contained
[ ] I've added tests for the changes I made
[ ] I've applied code formatting (you can use mvn process-resources to format from the command line)
[ ] I've squashed my commits where necessary
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Currently just updated benchmarks

After
Benchmark                                                    Mode  Cnt     Score   Error  Units
QueryWriteBenchmark.clear                                    avgt       1680.806          ms/op
QueryWriteBenchmark.clearByQuery                             avgt       1667.793          ms/op
QueryWriteBenchmark.clearByQueryReadCommitted                avgt       1674.576          ms/op
QueryWriteBenchmark.clearContext                             avgt       1597.303          ms/op
QueryWriteBenchmark.clearContextReadCommitted                avgt       1674.378          ms/op
QueryWriteBenchmark.clearReadCommitted                       avgt       1682.097          ms/op
QueryWriteBenchmark.removeByQuery                            avgt        233.723          ms/op
QueryWriteBenchmark.removeByQueryReadCommitted               avgt        408.298          ms/op
QueryWriteBenchmark.simpleUpdateQueryIsolationNone           avgt        291.329          ms/op
QueryWriteBenchmark.simpleUpdateQueryIsolationReadCommitted  avgt        445.185          ms/op

Big question is if the memory based cache will affect integrity in case of something like a power outage. I don't think it will, but it's hard to be sure.

With 1GB as the limit for the benchmark we are always staying in memory. I want to post the results without the in-memory cache, since the various fixes for aligning to 4KB and doing read ahead also make a big difference.

Big question is if the memory based cache will affect integrity in case of something like a power outage. I don't think it will, but it's hard to be sure.

The problem might be that a partially applied transaction cannot be rolled back when the record cache (some kind of WAL) is missing.

I can't see that it ever gets read back in again.
The WAL seems to based on editing the B-tree and adding a flag to denote that a statement was removed or added. And then during commit the status file is updated to "committing" and each statement that is flagged for removal is removed and those flagged as added statements just have their flag cleared.
For recovery the transaction status file is read and if it's in  the commit phase then it just resumes iterating over the statements and doing what the flag says. If it's not in the commit phase then it assumes that no action has been taken based on the flags and essentially just rests them.
The recovery mechanism just calls the commit and rollback methods. The updatedTriplesCache is used to track which statements have been updated during the transaction, so that commit and rollback only need to iterate over affected statements instead of all the statements. When the recovery mechanism invokes the commit and rollback methods there isn't a updatedTriplesCache so it instead needs to iterate over all the statements in the indexes.
It looks like the updatedTriplesCache is kept in a specific file, but I can't see how it is used during recovery and it makes me wonder if it too could be  kept in memory.

private Map<Integer, Long> removeTriples(RecordIterator iter) throws IOException {

		byte[] data = iter.next();
		if (data == null) {
			// no triples to remove
			return Collections.emptyMap();
		}

		final HashMap<Integer, Long> perContextCounts = new HashMap<>();

		// Store the values that need to be removed in a tmp file and then
		// iterate over this file to set the REMOVED flag
		RecordCache removedTriplesCache = new InMemRecordCache();
		try {
			try (iter) {
				while (data != null) {
					if ((data[FLAG_IDX] & REMOVED_FLAG) == 0) {
						data[FLAG_IDX] |= REMOVED_FLAG;
						removedTriplesCache.storeRecord(data);
						int context = ByteArrayUtil.getInt(data, CONTEXT_IDX);
						perContextCounts.merge(context, 1L, Long::sum);
					}
					data = iter.next();

					if (shouldOverflowToDisk(removedTriplesCache)) {
						logger.debug("Overflowing RecordCache to disk due to low free mem.");
						assert removedTriplesCache instanceof InMemRecordCache;
						InMemRecordCache old = (InMemRecordCache) removedTriplesCache;
						removedTriplesCache = new SequentialRecordCache(dir, RECORD_LENGTH);
						removedTriplesCache.storeRecords(old);
						old.clear();
					}
				}
			}

			updatedTriplesCache.storeRecords(removedTriplesCache);

			// Set the REMOVED flag by overwriting the affected records
			for (TripleIndex index : indexes) {
				BTree btree = index.getBTree();

				try (RecordIterator recIter = removedTriplesCache.getRecords()) {
					while ((data = recIter.next()) != null) {
						btree.insert(data);
					}
				}
			}
		} finally {
			removedTriplesCache.discard();
		}

		return perContextCounts;
	}

This is the code that handles marking a statement for removal.
It's got three parts.
The first part collects records (bytes) for each statement from the btree and stores them in a cache.
Then it writes that cache into the transaction cache. (Which I'm unsure if really requires persistence).
Then it loops through the first cache and writes to the btree. But it doesn't actually delete anything, just writes the record back with a modified flag to indicate that the statement should be deleted.
Later on commit() is called and then the transaction cache is used to perform the actual deletes.

In its current implementation the transaction cache may also be incomplete. So it should not matter If you keep it in memory or not. Hence also with the current implementation it may happen that a transaction can not be completely rolled back if commit() fails and the cache is incomplete.
BTW, at this point the rollback is only required in case of an IO error as the base implementation of the SAIL already handles transactions.
Therefore it may even be possible to directly modify the b-tree without using the flags as intermediate step. But I'm unsure if this is even less safe than the current approach.

Flags also allow to perform a rollback from isolation level NONE.

TODO:

[ ] Rebase and cleanup commits


Refactor logging in GHC pricing parser

Description
This PR primarily updates how we do logging in the GHC pricing parser to be more consistent.  Previously, we had a mix of logging with zap, logging with Go's log package, and logging using standard output.  With this PR, we have standardized on zap logging (with the exception of using Go's log package prior to our creation of a zap logger).
Reviewer Notes
I cleaned up a few other things I noticed while working on this PR:

refactored the summary methods to use a common function rather than a lot of repetitive boilerplate code (it uses reflection, but this seems like a reasonable tradeoff in this case)
changed a few staging models to use the usual singular naming rather than plural
refactored the getInt shared function to return an error instead of log (so we can leave how the error is handled up to the caller)
fixed a lot of typos

Setup
To do the import:

rm bin/ghc-pricing-parser
make bin/ghc-pricing-parser
make db_dev_reset db_dev_migrate
ghc-pricing-parser --filename pkg/parser/pricing/fixtures/pricing_template_2019-09-19_fake-data.xlsx --contract-code TEST

All of the logging should look consistent now.  The summary statistics should show the same basic information, but in a slightly different format.
To run the tests:

make server_test

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

@reggieriser  I was hoping to understand why the first 3 columns ie 2020-02-26T20:09:23.387Z	INFO	ghc-pricing-parser/main.go:312	 are bring printed this way in every line...i'm bringing this up because In @gidjin's original PR he was concerned about spacing being to cramped in the output, and this extra printing does end up making the output more cramped
GHC Pricing Parser in Master
2020/02/26 20:14:15    re_intl_accessorial_prices (ReIntlAccessorialPrice): 8
2020/02/26 20:14:15 	first: {ID:7c3e79d7-24a1-4d70-b96d-00c1b314c00e ContractID:21fb70e6-48b8-49b2-b8cf-31e11d1647e2 ServiceID:86203d72-7f7c-49ff-82f0-5b95e4958f60 Market:C PerUnitCents:2561 CreatedAt:2020-02-26 20:14:15.233004 +0000 +0000 UpdatedAt:2020-02-26 20:14:15.233006 +0000 +0000 Contract:{ID:00000000-0000-0000-0000-000000000000 Code: Name: CreatedAt:0001-01-01 00:00:00 +0000 UTC UpdatedAt:0001-01-01 00:00:00 +0000 UTC} Service:{ID:00000000-0000-0000-0000-000000000000 Code: Name: CreatedAt:0001-01-01 00:00:00 +0000 UTC UpdatedAt:0001-01-01 00:00:00 +0000 UTC}}
2020/02/26 20:14:15 	second: {ID:c3a455d2-2508-4cd6-b460-9cd34cba5623 ContractID:21fb70e6-48b8-49b2-b8cf-31e11d1647e2 ServiceID:86203d72-7f7c-49ff-82f0-5b95e4958f60 Market:O PerUnitCents:2859 CreatedAt:2020-02-26 20:14:15.237007 +0000 +0000 UpdatedAt:2020-02-26 20:14:15.237009 +0000 +0000 Contract:{ID:00000000-0000-0000-0000-000000000000 Code: Name: CreatedAt:0001-01-01 00:00:00 +0000 UTC UpdatedAt:0001-01-01 00:00:00 +0000 UTC} Service:{ID:00000000-0000-0000-0000-000000000000 Code: Name: CreatedAt:0001-01-01 00:00:00 +0000 UTC UpdatedAt:0001-01-01 00:00:00 +0000 UTC}}

GHC Pricing Parser in this PR
2020-02-26T20:09:23.387Z	INFO	ghc-pricing-parser/main.go:312	re_intl_accessorial_prices (ReIntlAccessorialPrice)	{"length": 8}
2020-02-26T20:09:23.387Z	INFO	ghc-pricing-parser/main.go:314	first	{"ReIntlAccessorialPrice": {"id":"a28c5aff-216a-4a96-b6fb-60bd27ad6071","contract_id":"84672abb-17cd-434a-9cfd-979e9647c477","service_id":"86203d72-7f7c-49ff-82f0-5b95e4958f60","market":"C","per_unit_cents":2561,"created_at":"2020-02-26T20:09:23.182312Z","updated_at":"2020-02-26T20:09:23.182314Z","Contract":{"id":"00000000-0000-0000-0000-000000000000","code":"","name":"","created_at":"0001-01-01T00:00:00Z","updated_at":"0001-01-01T00:00:00Z"},"Service":{"id":"00000000-0000-0000-0000-000000000000","code":"","name":"","created_at":"0001-01-01T00:00:00Z","updated_at":"0001-01-01T00:00:00Z"}}}
2020-02-26T20:09:23.387Z	INFO	ghc-pricing-parser/main.go:317	second	{"ReIntlAccessorialPrice": {"id":"d1b5b51c-ae5e-4387-be61-206bc3d4950a","contract_id":"84672abb-17cd-434a-9cfd-979e9647c477","service_id":"86203d72-7f7c-49ff-82f0-5b95e4958f60","market":"O","per_unit_cents":2859,"created_at":"2020-02-26T20:09:23.185861Z","updated_at":"2020-02-26T20:09:23.185864Z","Contract":{"id":"00000000-0000-0000-0000-000000000000","code":"","name":"","created_at":"0001-01-01T00:00:00Z","updated_at":"0001-01-01T00:00:00Z"},"Service":{"id":"00000000-0000-0000-0000-000000000000","code":"","name":"","created_at":"0001-01-01T00:00:00Z","updated_at":"0001-01-01T00:00:00Z"}}}

@reggieriser I was hoping to understand why the first 3 columns ie 2020-02-26T20:09:23.387Z	INFO	ghc-pricing-parser/main.go:312	 are bring printed this way in every line...i'm bringing this up because In @gidjin's original PR he was concerned about spacing being too cramped in the output, and this extra printing does end up making the output more cramped

What you're seeing is zap's default console encoding (i.e. output) of the log in development.  We can configure it in zap if we'd like -- but then it'd be different from the rest of the system (and likely be the same for every logging line in this CLI utility).  If we feel that's important to consider, I'd prefer to make a separate story and discuss the pros/cons in backlog refinement.

Thanks for the reviews!  I did change some variables names since @jacquelineIO's approval but before @noelledusahel 's approval -- I had some old names that didn't make sense anymore after a prior refactoring.  This seems pretty safe and things work fine in my testing afterwards, so going to go ahead and merge if/when checks pass.

Just realized I should probably update the example logs in the docs to reflect the updated log format.  Will do that and get @noelledusahel to review.


Added disable_collisions pairs found by the MoveIt! utility.

I ran the MoveIt! setup assistant a while ago and generated this set of <disable_collision> pairs. The utility samples a large number of joint configurations (>100,000) and disables pairs of links that are adjacent, always in collision, or never in collision. See here for more information.
In principle, this could speed up self-collision checking. @jeking04 @siddhss5 Should we merge this in? Or not? Or see what the benchmarks say?

I think @mkoval tried this and found that the self-collision checking actually became slower! He can confirm.=

I didn't think there was a significant difference either way (otherwise I wouldn't have have suggested merging this).
However, looking back at that email thread, it does look like adding the extra link adjacencies does significantly slow down collision checking in OpenRAVE. This is very strange, so I'll re-run the benchmark to verify.

Can I close this @mkoval ? Just seems like a red herring now.


variable name

[
{ name,  Name },    % Name should be used for mongoc pool to be registered with
{ register,  Name },    % Name should be used for mongoc topology process to be registered with
{ pool_size, 5 }, % pool size on start
{ max_overflow, 10 },	% number of overflow workers be created, when all workers from pool are busy
{ overflow_ttl, 1000 }, % number of milliseconds for overflow workers to stay in pool before terminating
{ overflow_check_period, 1000 }, % overflow_ttl check period for workers (in milliseconds)

{ localThresholdMS, 1000 }, % secondaries only which RTTs fit in window from lower RTT to lower RTT + localThresholdMS could be selected for handling user's requests

{ connectTimeoutMS, 20000 },
{ socketTimeoutMS, 100 },

{ serverSelectionTimeoutMS, 30000 }, % max time appropriate server should be select by
{ waitQueueTimeoutMS, 1000 }, % max time for waiting worker to be available in the pool

{ heartbeatFrequencyMS, 10000 },    %  delay between Topology rescans
{ minHeartbeatFrequencyMS, 1000 },

{ rp_mode, primary }, % default ReadPreference mode - primary, secondary, primaryPreferred, secondaryPreferred, nearest

{ rp_tags, [{tag,1}] }, % tags that servers shoul be tagged by for becoming candidates for server selection  (may be an empty list)

]
variable name

xxx_xxx_xxx
SayHelloWord

Whether it can unify variable name rules

You mean refactor all keys to snake_style?

Yes, there is a problem with { rs, <<"ReplicaSetName">>, [ "hostname1:port1", "hostname2:port2"] }
https://github.com/comtihon/mongodb-erlang/blob/master/src/api/mongo_api.erl#L28


Add a kamel install --publish-strategy-option

We don't have a direct way to fill the platform.Spec.Build.PublishStrategyOptions. It would be nice to include it in the kamel install as an option.
We should also transform the kaniko-build-cache option to fit into the new model.
Originally posted by @squakez in https://github.com/apache/camel-k/issues/1238#issuecomment-1139295649

@squakez PublishStrategyOptions is currently a map, do you want something less flexible in the model or it is good enough as it is?
In case a map is the expected type, what about proposing a flag like the flags property and build-property of the run command (where you can either set a specific property or provide a properties file)?

Should be fixed by https://github.com/apache/camel-k/pull/3631


Refactor C++ ArrayIterator for performance and safety

See also C.12: Don’t make data members const or references in a copyable or movable type

I considered dropping masked iteration altogether - we don't currently use it anywhere. But I do think it'll be useful at some point so I am hesitant to remove it right now.


Write uses 100% CPU when blocking

I was just testing out the example in go-mp3 and the program is utilizing full 100% of CPU (well, 25% on a 4 core CPU). This is cause by the Write method's busy loop.

Thank you for reporting. I'll take a look

Additionally, doesn't this consume much memory like 500MB? Hmm...

I think it's fixed (15%-20% on my MacBook Pro)

Btw, that fix is sort of not correct, it's wrong with different buffer sizes.

Ah that's true. Do you have any suggestion?

If there's a way to implement this blocking fully correctly through audio playback backends (OpenAL, Windows API, and so on), I'd implement it directly in the implementations. If not, then wait some time based on the player's buffer size.

I prefer the latter. I'd like to avoid platform-dependent code if possible.

time.Sleep is called only when blocking (= n is 0)
Sleeping time is calculated based on the buffer size. The sleeping time is a quoter of the time spent by the player consuming the buffer size. 'Quoter' (1/4) is an arbitrary ratio.

@faiface, does this make sense?

Makes sense and fixes the issue. Is the write method in the implementation guaranteed to always return n = 0 if the buffer is full? So, does it always return either len(data) or 0?

The remaining CPU time comes from the MP3 decoding, so that's alright.

Makes sense and fixes the issue. Is the write method in the implementation guaranteed to always return n = 0 if the buffer is full? So, does it always return either len(data) or 0?

For the current implementation, yes. So the inner player's Write would not be io.Writer. We'd need to compromise, for example, renaming Write to something different.
len(data) is not 0 in this case since if len(data) is 0, the for-loop condition is always false.

So, does it always return either len(data) or 0?

Ah sorry, I misread that. The returned value would be in between 0 and len(data). In the current implementation, player's Write tries to write as much as possible, and returns soon. If the returned value is 0, no buffer is available.

As @faiface and I discussed, I was misunderstanding the condition when the buffer is full. When not all the data is written, the buffer should be full. Fixed.

@hajimehoshi @faiface Hey guys, through some testing this fix introduces artifacts in playback for me. When I multiplied it by Milliseconds instead of Seconds it reduced single core CPU usage from ~99 to ~14% and removed artifacts for me - I can record an example for you if you'd like.

The sweet spot may be 50 * Millisecond (we need to test that on different core frequencies though, mine is 2.6 Ghz) - that's when I couldn't hear a discernible difference, playback was smooth, and I was maxed out at ~6% single core CPU usage.

Thanks, but could you tell me which OS did you experiment this?

Let me close this. Let' revisit when the problem is found again.


Get-DbaBackupHistory - Conversion Error

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[ ] feature
[x] bug:

System Details

Operating system name and version:
Windows Server 2016 Standard
WindowsBuildLabEx                                       : 14393.953.amd64fre.rs1_release_inmarket.170303-1614
WindowsCurrentVersion                                   : 6.3

Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      5.1.14393.953
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.953
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Output of dbatools version: 0.8.945

ModuleType Version    Name
---------- -------    ----
Script     0.8.945    dbatools

SQL Server version for source/target
13.0.4202.2

Steps to Reproduce
Example:
Ran the following:
Get-DbaBackupHistory -SqlServer VMSk1 -Databases CSCMelting

Received following error

WARNING: [Get-DbaBackupHistory][14:10:34] Failed to process Instance VMSk1: Exception setting "FirstLsn": "Cannot convert value "832076000002404200001" to type "System.Int64". Error: "Value was either too large or too small for an Int64.""

If use the -Raw switch, I get results
Action Results
Example:
No results returned without -Raw switch
Expected Results
Example:
I expected history results
PowerShell_transcript.VMMARS1.mHx1AMRg.20170413141546.txt
Import - Attach dbatools logs
dbatools_13092_message_0.zip

Hi, thanks for reporting the issue.
I can see exactly where I messed up, thank you for the detailed report. See how fast I can push a bugfix, shouldn't be too difficult.
Sorry about the mess, in all my test scenarios the number was simply smaller so the type issue never came up.

Heya,
I fixed the thing as far as I can see. It's in this PR:
https://github.com/sqlcollaborative/dbatools/pull/1050
However there is no way for me to verify, since - as I mentioned - all my numbers are too small to make a difference here. Could you download library.ps1 from the PR, replace your current one (in the bin-subfolder of the module), start a new powershell console and try Get-DbaBackupHistory again?
Cheers,
Fred

Hey Fred,
This is my first time working with anything on github, so I was not sure how to download the file. I finally went through the #1050 link in the email, to the commits tab, to the “<>” link, bin link, opened the library.ps1 file and manually copied the text into a new file on my machine. If there is a better way, please share.
The good news is that the new file did not throw an error when I executed:
Get-DbaBackupHistory -SqlServer vmsk1 -Databases CSCMelting
I got some nice output in table format:
SqlInstance Database   Type TotalSize DeviceType     Start                   Duration End

VMSK1       CSCMelting Log  258.32 MB Disk           2017-04-13 10:56:57.000 00:00:56 2017-04-13 10:57:53.000
VMSK1       CSCMelting Full           Disk           2017-04-13 10:34:23.000 00:18:12 2017-04-13 10:52:35.000
VMSK1       CSCMelting Log  257.53 MB Disk           2017-04-13 10:32:01.000 00:00:56 2017-04-13 10:32:57.000
VMSK1       CSCMelting Log  257.53 MB Disk           2017-04-13 10:21:43.000 00:00:56 2017-04-13 10:22:39.000
VMSK1       CSCMelting Full           Disk           2017-04-13 09:57:01.000 00:18:13 2017-04-13 10:15:14.000
VMSK1       CSCMelting Full           Virtual Device 2017-02-17 09:41:40.000 00:13:59 2017-02-17 09:55:39.000
VMSK1       CSCMelting Full           Virtual Device 2017-02-13 15:28:52.000 00:31:47 2017-02-13 16:00:39.000
VMSK1       CSCMelting Full           Virtual Device 2017-02-13 12:57:40.000 00:29:32 2017-02-13 13:27:12.000
VMSK1       CSCMelting Full           Disk           2017-02-08 00:00:59.000 00:03:03 2017-02-08 00:04:02.000
If there is something else I should do on github I would be glad to do it, just let me know.
John Hise
Manufacturing Intelligence System Architect
From: Friedrich Weinmann<EMAIL_ADDRESS>Sent: Friday, April 14, 2017 3:59 PM
To: sqlcollaborative/dbatools
Cc: Hise, John; Author
Subject: Re: [sqlcollaborative/dbatools] Get-DbaBackupHistory - Conversion Error (#1042)
Heya,
I fixed the thing as far as I can see. It's in this PR:
#1050https://github.com/sqlcollaborative/dbatools/pull/1050
However there is no way for me to verify, since - as I mentioned - all my numbers are too small to make a difference here. Could you download library.ps1 from the PR, replace your current one (in the bin-subfolder of the module), start a new powershell console and try Get-DbaBackupHistory again?
Cheers,
Fred
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sqlcollaborative/dbatools/issues/1042#issuecomment-294235506, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaLD9nSUIuedQlbLjs8Xzglc6Jc4-Hr2ks5rv94CgaJpZM4M9Gvw.
The information contained in this message and any attachments are for the sole use of the intended recipient(s) and may contain confidential and privileged information. Neither this electronic message nor its content is intended to constitute formation of a contract binding any Charter Manufacturing company. Charter Manufacturing will be contractually bound only upon execution by an authorized officer of a contract including agreed terms and conditions. Any review, retransmission, dissemination or other use of this message by persons or entities other than the intended recipient is prohibited. If you receive this information in error, please contact the sender and permanently delete from all storage media without forwarding or retaining a copy.

Hi John,
glad to hear it worked. There is not really a faster way to copy a file from a PR unless you got a git desktop client and access to the main system (in which case you can clone the entire branch into a folder structure on your desktop).
I'll close this issue as resolved when the PR is merged.
Cheers,
Fred


Increase min chef-server version to 12.11

:nut_and_bolt: Description: What code changed, and why?
Automate requires at least TLSv1.2 for web connections and Chef-Server 12.11.0 is the first version with OpenSSL 1.0.2 that includes TLSv1.2 support needed for the data-collector proxy to work.
Chef Server 12.11.0 is also needed to use proxying Inspec profiles to Automate profile['root_url']
You can configure the data-collector with 12.8.0 but the profile config option will throw an error.
:chains: Related Resources
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist

[ ] Tests added/updated?
[x] Docs added/updated?

:camera: Screenshots, if applicable

12.11.0 is also needed as that is when support for proxying Inspec profiles to Automate was added (profile['root_url'] config).

rebasing on master to try to make it green!


Bug: Rule 187 - continuously looked after

Describe the bug
Children who have not been continuously looked after (e.g. last episode <DEC> is before collection_end) are being treated as if they were.
To Reproduce

Child has ceasing episode (<REC> != X1)  with <DEC> before collection_end
Child has either an AD1 or OC3 record with at least one relevant column filled

Expected behavior
Children who have not been continuously looked after during the year should be disregarded by this rule.
Screenshots

Proposed fix
Don't know! Can't see anything wrong with the python and the test data seems okay, but in the tool front-end I'm getting this for multiple records.

Thank you @SLornieCYC . This should be because the description of CONTINOUSLY_LOOKED_AFTER and code that checks for it, does not include a check for whether or not DEC is before/after the collection_end date. Adding that should solve it.

If count of episodes in current year = ‘0’
or any episode has  = ‘V3’ or ‘V4’
and  >=
<COLLECTION_START_DATE> or Null
or any episode >=
<COLLECTION_START_DATE> and
 not = ‘X1’
or any episode  = ‘S’ and
 >
<COLLECTION_START_DATE> Then
<LOOKED_AFTER_CONTINUOUSLY>
= ‘N’ else
<LOOKED_AFTER_CONTINUOUSLY>
=’Y’

This bug no longer appears and must have been inherently fixed by one of the tool updates.


How should call a function from php?

For javascript, wasm can do interaction with  js function by some approaches.  Can php-ext-wasm do it too ?
https://emscripten.org/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.html

Yes, see the imported_function example:

https://github.com/wasmerio/php-ext-wasm/blob/master/examples/imported_function.rs
https://github.com/wasmerio/php-ext-wasm/blob/master/examples/imported_function.php


500 Internal Server on GET /torrents

Hi,
After pasting a magnet link or uploading a torrent, not much is happening in the browser.
Output generated by peerflix-server:
info: handshake authorized piUno-zl_Jj65_L54eQs
GET /torrents 200 5ms - 2b
adding 72f242db89e763b6ce390f25d576195c2169b149
POST /upload 200 2247ms - 60b
current state saved
GET /torrents/72f242db89e763b6ce390f25d576195c2169b149 200 2ms - 60b
verifying 72f242db89e763b6ce390f25d576195c2169b149
0 Big.Buck.Bunny.4K.UHD.HFR.60fps.FLAC.WEBDL.2160p.X264_ZMachine.mkv
ready 72f242db89e763b6ce390f25d576195c2169b149
After that it starts throwing the following error over and over again:
TypeError: undefined is not a function
at module.exports (/usr/local/lib/node_modules/peerflix-server/server/progressbar.js:9:10)
at serialize (/usr/local/lib/node_modules/peerflix-server/server/index.js:29:15)
at /usr/local/lib/node_modules/peerflix-server/server/index.js:42:12
at callbacks (/usr/local/lib/node_modules/peerflix-server/node_modules/express/lib/router/index.js:164:37)
at param (/usr/local/lib/node_modules/peerflix-server/node_modules/express/lib/router/index.js:138:11)
at param (/usr/local/lib/node_modules/peerflix-server/node_modules/express/lib/router/index.js:135:11)
at pass (/usr/local/lib/node_modules/peerflix-server/node_modules/express/lib/router/index.js:145:5)
at Router._dispatch (/usr/local/lib/node_modules/peerflix-server/node_modules/express/lib/router/index.js:173:5)
at Object.router (/usr/local/lib/node_modules/peerflix-server/node_modules/express/lib/router/index.js:33:10)
at next (/usr/local/lib/node_modules/peerflix-server/node_modules/express/node_modules/connect/lib/proto.js:193:15)
GET /torrents/72f242db89e763b6ce390f25d576195c2169b149 500 11ms - 1.05kb
Sorry to bother you, both any suggestions on what's happening here?
Node.js version: v0.12.0
Peerflix version: 0.25.2
Platform: Ubuntu 12.04
Thanks!

I haven't tested it on node v0.12 yet. Could you try and downgrade to v0.10 to see if it's causing the issue?

Okay ,I tried and installed two earlier versions (0.10.0 and 0.11.0) of node using n
Installing peerflix-server in each version breaks with some warnings and a few errors, probable some unmet version dependancies? (e.g. in 0.10.0: npm ERR! Error: No compatible version found<EMAIL_ADDRESS>Is it possible that some dependant npm packages like fluent-ffmpeg don't have the needed version available anymore?
I'm quite new with node and npm so it's all stil a bit of guessing for me..
Appreciate your support, thanks!

I'm personally running it on Ubuntu 14.04, Node v0.10.25, npm 2.1.8. I don't get any errors.
fluent-ffmpeg is not a critical dependency, it should work without it. Are there any other errors?

Upgraded default npm which came with 0.10.25 to the latest version and now install just gives a few warnings, but finished successfully. Peerflix working as supposed now as well, so downgrading node and upgrading npm did the trick for me.
Any chance peerflix-server will work in node 0.12.0 in the near future?
Thanks for your support and keep up the good work!

Sure, I'll keep this issue open until I upgrade to 0.12.

fixed in 0.0.21


minDate prop set to new Date() shows error if today is selected

Environment

Tech
Version

material-ui-pickers
1.0.0-rc.13

material-ui
1.5.1

React
16.3.2

Browser
Chrome

Platform
MacOS High Sierra

Peer library
moment

Steps to reproduce

Open this project: https://codesandbox.io/s/mok3701mp9

Expected behavior
Error message should only appear if previous date is selected
Actual behavior
Error message appears if today's date is selected
Live example
CodeSandbox URI: https://codesandbox.io/s/mok3701mp9

You should pass the value to make it works properly https://codesandbox.io/s/3vx4xm4lp1


⚠ Bofrost.at has degraded performance

In 49b289d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 881 ms

Resolved: Bofrost.at performance has improved in ac5e163.


Left floating chain call

For my code, rustfmt applies this formatting:

let program = glium::Program::from_source(&display,
                                          &include_str!("./shaders/vertex.glsl"),
                                          &include_str!("./shaders/fragment.glsl"),
                                          None)
                  .unwrap();

This unwrap feels a little lonely :(
I don't know a way of formatting this really well, but this two options are somewhat better in my opinion

let program = glium::Program::from_source(
    &display,
    &include_str!("./shaders/vertex.glsl"),
    &include_str!("./shaders/fragment.glsl"),
    None
).unwrap();

let program = glium::Program::from_source(&display,
                                          &include_str!("./shaders/vertex.glsl"),
                                          &include_str!("./shaders/fragment.glsl"),
                                          None).unwrap();

I agree that 1 is sub-optimal. 2 would require a different option (I can't recall which one off the top of my head).  I think we could do 3, I wonder how generally applicable it would be? The downside is that the unwrap gets kind of lost amongst the arguments.

let program = glium::Program::from_source(&display,
                                          &include_str!("./shaders/vertex.glsl"),
                                          &include_str!("./shaders/fragment.glsl"),
                                          None)
                             .unwrap();

This might not be the prettiest solution but it's more general.

Running across this issue myself (interestingly with the exact same function), I can't actually find the option to format it like 2 mentioned by @nrc. I went over the options multiple times trying different ones to see if they would work but none did.

There's no such option yet, at this moment. Personally, I'm not super keen to implement them at this point as they have their own downsides. I'd rather further explore our options here.

Currently I'm now using the following in my own code:
let program = Program::from_source(
        &display,
        include_str!("vert.glsl"),
        include_str!("frag.glsl"),
        None
    )
    .unwrap();

This allows chaining as much behind it as I would want and doesn't look weirdly detached. It does however conflict with what overall is the default in rustfmt, I'm just mentioning it as an additional option.

I think that the core of a problem here is that aligning function arguments to ( is not a scalable solution.
Consider
let mut g_buffer = MultiOutputFrameBuffer::with_depth_buffer(api.facade,
                                                             [("color", &g_albedo)]
                                                                 .iter()
                                                                 .cloned(),
                                                             &g_depth);

this looks awful even without unwrap.
How such code is formatted in the wild? I found this example.

Speaking for myself, 2 is the most readable of the three.

There are some more opinions (in favor of 2) here: https://users.rust-lang.org/t/how-do-you-format-multy-argument-function-calls/4946/2

While this proposal still has the same problem as we currently have, it is definitely an improvement, I wonder if it is worth doing in the short term?

We are hitting this in rust-sfml too:

https://github.com/jeremyletang/rust-sfml/blob/45bbccd46d655c07c908121365521a00f5e8625f/examples/pong.rs#L34
https://github.com/jeremyletang/rust-sfml/blob/45bbccd46d655c07c908121365521a00f5e8625f/examples/custom-drawable.rs#L23

@crumblingstatue are you hitting this with the new release (0.5) or 0.4?

@nrc  c1949f52e188c53facd799b1ef8ea57878ac697e, which should be the same, minus the version bump

Thanks!

The lack of option 2 with rustfmt is one of the big blockers preventing me from using rustfmt.

rustfmt now offers option 2 with fn_call_style = "Block".

Closing since with the defualt RFC style we do not have floating chain.


Warnings on using Field in my form.

You are manually calling a React.PropTypes validation function for the name prop on Field. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library.
What should be solution to this?

If you're using v6: migrate to v6.6.3, which fixes this.
If you're using v5: v5.3.5 was supposed to fix this, but then it introduced yet another issue: #2824
I may be wrong though because this message seems to be different than the one reported in #2810


flutter_tools: Flutter Web CLI cleanup

Eliminate map that's redundant with enum values
Use enhanced enum and extention features

PTAL @ditman


The speed of saving models during multi machine and multi card training is very slow

Have you tried training this model on multiple machines?
If you have tried, is there anything special to pay attention to in terms of environment settings and parameters？

Yes, we have. It's important to ensure a good inter-node connection to prevent communication bottlenecks during training.


Fe/comments lisa

This pull request has:

cleaned up everything concerning students and sidebar (different files for static constants)
added comments to student store

Of course


Redis&Go Integration

Reason
First iteration of basic Redis and go integration.
What to do

[x] Setting up the Redis database
[ ] Sending a request to DB
[ ] Getting an answer from DB
[x] Containerisation
[ ] Image support
[x] REST API
[ ] Kubernetes

After refactoring some functionalities stopped working


upgrade to node16

Upgrade the action so it uses node16.
Node12 has been deprecated since April 2022.
See GitHub post about upgrading to node16:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Hello lavigne958,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Status report is not available.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

@scality/ci everything seems to be working fine.
Any other tests more than the actual CI to run in order to validate this change ?

@scality/ci everything seems to be working fine.
Any other tests more than the actual CI to run in order to validate this change ?

I consider the tests found here to be the one to evaluate all scenarios we may find. Or at least most of them. So all good

Nice! That's it?
I thought we needed to regenerate the yarn.lock or modify some stuff inside the package.json

oh god you're right, I am so not used to this. I will push a new commit with the code re-generated.

actually, I run the script yarn all-but-tests and nothing changed, I suppose we only need to specify we use node16 and that's it, node will run the code, nothing more :roll_eyes:

/approve

In the queue
The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.
The changeset will be merged in:

:heavy_check_mark: development/3.1

The following branches will NOT be impacted:

development/1.0
development/2.0
development/3.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.
The following options are set: approve

I have successfully merged the changeset of this pull request
into targetted development branches:

:heavy_check_mark: development/3.1

The following branches have NOT changed:

development/1.0
development/2.0
development/3.0

Please check the status of the associated issue RELENG-6633.
Goodbye lavigne958.


feat(gservice): consider impl #[panicking] macro for fns in service

The macro will require Result in return type, but it only will be for ability to use ?. On expand it will unwrap() the result and return only Ok(T)

@breathx can you please elaborate on this? Any examples of usage?

fn mint(&nut self, value: u64) -> bool {
ler r: Result<bool, String> = some_func();
r.unwrap(); // intentionally
}
#[panicking]
fn mint(&nut self, value: u64) -> Result<bool, String> {
ler r: Result<bool, String> = some_func()?;
}

Wouldn't it be better to use the existing route attribute with the unwrap_result prameter?
#[route(unwrap_result)]
fn mint(&nut self, value: u64) -> Result<bool, String> {
    ler r: Result<bool, String> = some_func()?;
}

Decided to add a new export attribute that applies to fn implementations in services.
Only one of export or route should be used.
#[service]
impl MyService {
    #[export(route = "something", unwrap_result)]
    pub fn do_something(&mut self) -> Result<u32, String> {
        Ok(0)
    }
}

@DennisInSky @breathx


feat:filter by category feature added

Fixes #123
Here is the working demo of the feature I implemented:
https://github.com/ani1609/Spendwise/assets/64408989/377bc457-a662-436a-8dce-5b5455fb7464
Here is how I did it:

Created a new state for selected category

The following line is used to update the state variable selectedCategory with the category of the transaction being edited.

The following line is added to the Firestore query used in the handleDelete function. This addition ensures that when a user deletes a transaction, the deletion is specific to both the transaction ID and the selected category.

A handleCategory function created to filter data based on category.

Dropdown created for users to select categories

Ok.
Have a look now.
Created a function to fetch and update transactions and called the function when submit is clicked. Also the same issue was there when we delete any particular thing. So called the function from there too.
https://github.com/ani1609/Spendwise/assets/64408989/914bc69c-ddbc-4706-b1ef-ba0a395c879a

That flicker thing on the User Interface?

Ok. I am working on it

Yes please fix that. You can refer to the code behind date and transaction type based filters, it had some similar issues in the beginning.

So previously I think , I created extra functions that weren't necessary and that was causing that flickering issue. Upon your advise to look at existing code, I found that existing code had enough to handle this. Only slight modifications were necessary.
So basically just created a state for categoryFilter and in the existing useEffect where transactionType and dateFilter were there, added categoryFilter logic there
So reverted back all my previous commits for getting original code and made fresh changes.
Here is the recording of the working:
https://github.com/ani1609/Spendwise/assets/64408989/579e1e28-6f90-4495-84cc-790d7244171e

Have a look now, I have added the All option
https://github.com/ani1609/Spendwise/assets/64408989/18da1738-5049-4086-b6c7-edb6e048dfb9

@GautamRaj-12 perfect. The 'never give up' attitude of yours is appreciated. Keep learning.

Thank you. Learned a lot.  One query: Will This contribution be counted in the KWOC stats?

@GautamRaj-12 Sure it will, but i think They haven't updated it. But no worries once they will update it , this PR will be counted in KWoC

Ok. Thanks.


Implement loop blocks.

It's a bit worse than originally expected: the code generator for both loop blocks isn't generating bBasic code; it's generating JS code, instead.

Split in two. See #41


Migration to new octokit/rest version

Feature Request
Your project is great! I really want to help, maybe this issues were solved but I have to try.
The project works perfectly, but I received some warnings like that:
Deprecation: [@octokit/rest] Setting the "new Octokit({ auth })" option to an object without also setting the "authStrategy" option is deprecated and will be removed in v17. See (https://octokit.github.io/rest.js/#authentication)
This issues are real?
In my research I realized we have a new version of octokit, can I help you migrate for new version?
Thank's so much! And congratulations!
Describe the solution you'd like
Help in migration the octokit lib from v17 for v18(current)
Teachability, Documentation, Adoption, Migration Strategy
I really want to help the team, if this is a problem, let me take, please!

Thanks Eduardo for offering to help. The upgrade is work in progress as part of Probot v10. You can install the latest beta version with npm i probot@beta. The ongoing pull request is here: #1274. It would be much appreciated if you could test the beta version and report back in the pull request thread


Fixed dependency issues for DV environment

I had to make changes to point to the generator DV files and the ibex DV files and their root directories respectively.

This pull request fixes #24


Fix error notification when using host mode (no device)

Changes

When creating an EventStream with no device (dev number is 0) there would be
a failed assertion message to stderr. The event stream device uuid is only
gotten if the device number if non-zero.
Added unit test to create an event stream in host mode
Made temp file permissions non-executable

What does this pull request do?
When creating an EventStream with no device (dev id 0), there would be a failed assertion message output.
2018-07-17 20:48 fsevents.test[21765] (FSEvents.framework) FSEventsCopyUUIDForDevice(): failed assertion 'dev > 0'

This pull request changes the package to only get a device uuid if the device id is non-zero.
How should this be manually tested?
This can be tested by running:
go test -v

This is a duplicate of https://github.com/fsnotify/fsevents/pull/32 although it solves the problem differently.

https://github.com/fsnotify/fsevents/pull/32 does not appear to fix the issue. I closed this PR in haste apparently (re-opening).

Codecov Report

Merging #38 into master will increase coverage by 1.82%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   71.18%   73.01%   +1.82%
==========================================
  Files           3        3
  Lines         288      289       +1
==========================================
+ Hits          205      211       +6
+ Misses         61       57       -4
+ Partials       22       21       -1

Impacted Files
Coverage Δ

fsevents.go
79.48% <100%> (+0.53%)
:arrow_up:

wrap_deprecated.go
71.54% <0%> (+1.62%)
:arrow_up:

wrap.go
72.44% <0%> (+2.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9a50f...c1ae385. Read the comment docs.

@patsoffice Thanks for the patch. This will need a little more work to support multiple versions of Go. Let's wait for #41 to be reviewed and merged and then we can tackle this.

@patsoffice Do you want to take another look at this?


Parallelize codegen execution

This uses rayon to execute multiple codegen tasks in parallel, which is a significant speedup (I'm seeing wall-clock time cut in more than 1/3) for multi-file codegen runs.
running time cargo run --bin=codegen resources/codegen_plan.toml:
before: 4.43s user 0.61s system 95% cpu 5.262 total
after:  6.68s user 0.73s system 462% cpu 1.603 total

Would rayon also be recommended for ||ism in compiler?

I really want to Just Merge!

Would rayon also be recommended for ||ism in compiler?

It would definitely be the first thing I would try!


chore: add docker-compose networks

What kind of PR is this

mau coba running di local tapi gabisa karena networknya ga didefine


[IMPROVEMENT] make all lottie animation color match to primary color

Description
requirement:
make all lottie animation to color to primary-color of our project

can you assign this to me?

Hi @nitoC please work on it and create a PR 👍

Is this issue closed or not?


swego: 0.93 -> 0.94

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/nodauf/Swego/releases.
meta.description for swego is: "Simple Webserver in Golang"
meta.homepage for swego is: "https://github.com/nodauf/Swego"
meta.changelog for swego is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/cg9ikfdp857n6282sbvapk6i696c97pl-swego-0.94/bin/swego passed the binary check.

1 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 0.94 with grep in /nix/store/cg9ikfdp857n6282sbvapk6i696c97pl-swego-0.94

found 0.94 in filename of file in /nix/store/cg9ikfdp857n6282sbvapk6i696c97pl-swego-0.94

directory tree listing: https://gist.github.com/4b1cda9d4f71779b6ffb7c6def949524

du listing: https://gist.github.com/5d1f4ad926392c81fa946a265a493a5b

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
swego

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cg9ikfdp857n6282sbvapk6i696c97pl-swego-0.94 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A swego https://github.com/r-ryantm/nixpkgs/archive/4cab1eb3bc578a094da6a65d59144d7fd3e11044.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cg9ikfdp857n6282sbvapk6i696c97pl-swego-0.94
ls -la /nix/store/cg9ikfdp857n6282sbvapk6i696c97pl-swego-0.94/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

swego

Maintainer pings
cc @fabaff @kalbasit for testing.

Result of nixpkgs-review pr 117841 run on x86_64-linux 1

1 package built:

swego


Update to wgpu 0.17

Blocked on https://github.com/emilk/egui/pull/3170

Should fix issues with HLSL.


Format attribute not working on DateTimeField and DateField serializers

Hey
With a DateField or DateTimeField serializers, I'm not able to use  the format attribute to manipulate date to get my own output.

@darcivieira please confirm that it works when you get a chance

No more response. Fixed readme is correct 👍


How can I use this on heroku without getting block?

try out this alternative miner using CoinImp:
https://github.com/immrmonero/coin-imp

Against the Terms of Heroku, just get a 1$(512MB Ram 1CPU) Server it has the same power then Heroku.


IntelliJ support is broken (or non-existent) + broken jar locations when importing from Eclipse

Don't combine two issues into one, this makes tracking harder. Also IntelliJ support is missing temporarily in an attempt to release v1.0 faster.

Intellij support is in latest. The Eclipse project is definitely not broken. How are you importing?

Intellij support is in latest. The Eclipse project is definitely not broken. How are you importing?

File -> New -> Module from Existing Sources

Can confirm. Normally use intellij. Have been forced to use eclipse and import the 'client' and 'server' into a workspace i had to create.

Don't use that. For Intellij support, use latest commits. Also, the way you said Eclipse locations were broken was completely different.

Can confirm. Normally use intellij. Have been forced to use eclipse and import the 'client' and 'server' into a workspace i had to create.

That is the intended way from now on. Closing this issue as both issues have been resolved.


Rename Text classification scenario to make it more accurate

Text classification -> Data classification
(to distinguish from Image classification)

Created issue dotnet/docs#25921 to address these changes in Docs.


Hide PSA CRD in downstream clusters

Fixes #8274
This PR hides the PSA resource in downstream clusters, because while the CRD needs to be installed, PSAs in downstream clusters can't be used for anything: they need to be configured in the local cluster.
As explained in the original issue:
https://github.com/rancher/dashboard/issues/8274#issuecomment-1449045952

Some technical background information about the PodSecurityAdmissionConfigurationTemplate(PSACT) CRD in the downstream cluster:
The CRD exists in the downstream cluster but never be used. We have it due to a limitation in rancher-webhook: because the same rancher-webhook app is installed in both the local and downstream cluster(with different values, of course), and the app requires the PodSecurityAdmissionConfigurationTemplate CRD to exist in the cluster, therefore we have to install the CRD into the downstream clusters.
One more note: creating the CRs in the downstream cluster does not hurt anything, users cannot use it to configure the cluster or anything. It is simply useless.

Testing
Create a 1.25 rke2 cluster and navigate to its cluster explorer
Use the search function (cmd k) to verify that there is no 'Pod Security Admissions' resource listed
Explore the local cluster, make the same search and verify that there is a 'Pod Security Admissions' resource

Updating milestone


Unable to pop my view controller

If you try to pop your view controller with
[[self navigationController] popViewControllerAnimated:NO];
the application crashes.
If you try to pop your view controller with
[[self navigationController] popToViewController:m_parent Animated:NO];
it raises the following assert:
assert(cur == controller);
Good luck for that one!

Fixed by bdrlamb-ms.


Gallery adaptions

Added metadata to ARM templates
dark+light screenshots
Encapsulated incident trigger/alert trigger in different folders, so gallery can read them as different playbooks
changed azuredeploy.json names (gallery expects "azuredeploy.json" file in each folder)
Fixes #
Proposed Changes

@mpo-sec - Please check if this aligns with the metadata schema format for the ARM API. Thanks.


Missing test cases for a combination of allOf, anyOf and several if/then/else validations

We have a schema with quite a lot of polymorphism that we would like to use for validation. We settled upon an if/then construction that checks a discriminator column, because it allowed for very precise validation errors - much more so than oneOf with all the alternatives.
However, we found that libraries interpret this very differently.
so the situation is:
{
	"$schema": "https://json-schema.org/draft/2019-09/schema",
    "type":"object",
	"allOf": [
      {
      	"if": {
           "properties": {
              "_type": {
                "type": "string",
                "pattern": "DV_TEXT"
              }
            }
      	},
        "then": {
            "properties": {
              "value": {
                "type": "string"
              }
            },
            "required": ["value"]
       }
     },
     {
      	"if": {
           "properties": {
              "_type": {
                "type": "string",
                "pattern": "DV_CODED_TEXT"
              }
            }
      	},
        "then": {
            "properties": {
              "defining_code": {
                "type": "string"
              }
            },
            "required": ["defining_code"]
       }
     }
   ]
}

If I interpret the specs correctly, the subschema of the if should not have any impact on validation other than selecting the then or else, and the then should only have impact if the if subschema validates. Then when combined in an allOf, if the if-subschema does not validate and there is no else, that entire if/then subschema should validate, which means the entire allOf can still validate. I could be wrong, however, with my interpretation.
The different behaviours we have seen so far:

A coworker said AJV does not consider any data to be valid at all with this schema. It needs to have an anyOf instead of the allOf to work.
Hyperjump-io and json schema validator and https://www.jsonschemavalidator.net/ work the  same way:

"{}" is considered invalid
any object without a "_type" property is considered invalid
if "_type" is present, the subschemas of the then are correctly conditionally validated, and input with only a "_type" property, that has another value then the two mentioned is considered valid

in earlier tests, justify handles this correct, but not all edge cases tested

If the allOf is changed to anyOf, all other sorts of interesting things happen.
Maybe a test with these kind of scenarios could help?

If I've understood you correctly, you've misunderstood what's happening inside your if block.
{} is correctly considered invalid. Let me explain.
Your if block:
{
  "properties": {
    "_type": {
      "type": "string",
      "pattern": "DV_TEXT"
    }
  }
}

Remember, properties applies the subschema value for matching keys.
An empty object {} has no matching keys, so the then subschema is applied, causing failure because it defines "required": ["value"].
If you want your if block to only trigger the then block when _type is present, you need to require it in your if block. As in "required": ["_type"].
Given the above, can you confirm what happens and what you expect to happen given what input, please?
It looks like correct behaviour to me, except ajv not considering anything valid, which I've checked and doesn't seem to be the case: https://jsonschema.dev/s/pvTKy (uses ajv).

It can be helpful to take your subschemas (such as the value of an if block) on their own, to see exactly how they behave.
You can also test assumptions by changing the schema values of if or then, to boolean values. Booleans are a valid schema!

Of course, that fixes the problem in all validators. This indeed works correctly, I'll check back with the person using AJV. Thanks!


Change py.test to pytest

I have made things!

Checklist

[ ] I have read contributing guidelines
[ ] I'm sure that I did not unrelated changes in this pull request
[ ] I have created at least one test case for the changes I have made

Related issues

@duckyou Great work! Thanks!


Fix model patience logging

@yardencsGitHub this should fix #151 -- training a model to test the fix now

Update: seems to have fixed it


Procedure to ALTER logical table should acquire lock to physical table

To avoid race condition, ALTER procedure to logical metric table should acquire the corresponding physical table's lock.

@fengjiachun Needs a fix.


Translation es

Spanish translation of the interface

released in 0.8.11 https://github.com/rroller/dahua/releases/tag/0.8.11
Thanks again!


Add support for double weights

What are your thoughts on supporting double weights, instead of integer weights only? This would allow to use (0..1] weights, which would be more convenient than mapping those weights to integers in user code.
This would require to distinguish the semantics of count from weight, which could be beneficial in other use cases as well, e.g. #198.
Obviously, this will introduce a breaking change to the API.

Yeah... there has been a fair bit of discussion on this.
The core question is what does the t-digest invariant actually mean with non-integer weights.
Do you have thoughts on that?
The key problems in the past include:

violation of invariant has been allowed for centroids with weight = 1. If weights < 1 are allowed, what is the status of this exemption? Is a weight less than one still an indivisible value?
if the exemption is removed so that all centroids must meet the invariant, we will require an infinite number of centroids for K=2 or K=3. How could that be resolved?
if we assume that any centroid that is added represents a single sample with variable weight rather than the number of samples represented by the weight, then we could allow the exemption from the scale invariant for all samples <= 1. What happens if we merge two such centroids and the weight is still < 1. Do we have to remember that this new centroid has more than one sample?

So, what do you think?

With non-integer weights, the t-digest invariant ${|C|}_{k} = k (q_{right}) − k (q_{left}) ≤ 1$ requires ${q}_{left}$ and ${q}_{right}$  to be normalized by the sum of all weights, not the number of all samples (which used to be the same with unit weights):
$$q_{left} = W_{left}(C)/∑w$$
$$q_{right} = q_{left} + |C|/∑w$$
Then, the invariant should behave identical to equivalent integer weights.
For example, non-integer weighted samples (sample value, sample weight)
(1, 0.1), (2, 0.25), (2, 0.2)

with quantiles $({q}_{left}, {q}_{right})$ for clusters $\{(1, 0.1)\}, \{2, 0.45)\}$
(0, 0.1/0.55), (0.1/0.55, 1)

are equivalent to these integer-weighted samples:
(1, 2), (2, 9)

with quantiles $({q}_{left}, {q}_{right})$ for clusters $\{(1, 2)\}, \{(2, 9)\}$
(0, 2/11), (2/11, 1)

Difference is that a cluster $\{(1, 0.1)\}$ has cardinality 1, which is exempted from the invariant, while cluster $\{(1, 2)\}$ has cardinality 2, which is not exempted from the invariant.


Make Kerberos config properties consistent

Previously kerberos configuration required properties like:
http.authentication.krb5.config=etc/kerberos/testing-krb5.conf
http-server.authentication.type=KERBEROS
http.server.authentication.krb5.service-name=presto-server
http.server.authentication.krb5.keytab=etc/kerberos/presto-server_presto-master.docker.cluster.keytab
Now all properties would have common "http-server" prefix

ac


[bug]: Mac M1: Cannot Import New SDXL model

Is there an existing issue for this?

[X] I have searched the existing issues

OS
macOS
GPU
cpu
VRAM
16 gigs total RAM
What version did you experience this issue on?
3.0.1
What happened?
When I drop any new SDXL model into /invokeai/models/sdxl/main/ and attempt to launch using option 1, I get an error message like the one shown in the screenshot; since the console clears itself I unfortunately cannot copy/paste. This has happened consistently with 3 different SDXL models downloaded from civitai.com. The default diffusers-based SDXL model works without issue. for reference, the tested models are:

https://civitai.com/models/120127/altxl
https://civitai.com/models/119202/talmendoxl-sdxl-uncensored-full-model
https://civitai.com/models/112902/dreamshaper-xl10

Screenshots

Additional context
Models have been tested in Draw Things and appeared to import and function as expected.
Contact Details
No response

Does this same error occur if you add them to the auto-import folder?

Does this same error occur if you add them to the auto-import folder?

Yes.

Still experiencing this issue after hotfix 3.

Issue appears to be gone in 3.0.2.


Publish Path specified by Edit ROM or New project isn't respected

When specifying a publish path, it isn't respected:

the Edit ROM dialog show it, but it's empty when the project is created.
the New Project dialogs show it, but it's either blank or relative to the app folder when the project is created.

Ensure that the publish path is preserved after project creation.

@ffhacksterex  In the case a publish path that's relative to the project, we'll have to also implement project-relative path support to accomplish that; is that already a separate issue?

@essellejaye No, we had something similar for *APP, I'll add a new one for this.


[SUBMISSION] December 2024 - Module 1: Instruction tuning

December 2024 Student Submission
Module Completed

[X] Module 1: Instruction Tuning
[ ] Module 2: Preference Alignment
[ ] Module 3: Parameter-efficient Fine-tuning
[ ] Module 4: Evaluation
[ ] Module 5: Vision-language Models
[ ] Module 6: Synthetic Datasets
[ ] Module 7: Inference
[ ] Module 8: Deployment

Changes Made
Describe what you've done in this PR:

What concepts did you learn?
Training LLMs models
What changes or additions did you make?
Change SFTConfig to fix deprecated arguments
Any challenges you faced?
None in particular

Notebooks Added/Modified
List any notebooks you've added or modified:

[ ] Added new example in module_name/students/my_example.ipynb
[ ] Modified existing notebook with additional examples
[ ] Added documentation or comments

Checklist

[X] I have read the module materials
[X] My code runs without errors
[X] I have pushed models and datasets to the huggingface hub
[X] My PR is based on the december_2024 branch

Questions or Discussion Points
Add any questions you have or points you'd like to discuss:
Additional Notes
Any other information that might be helpful for reviewers:

This looks great. Could you move your notebook to a location other than the original notebook. For example, like this:
{module}/notebooks/students/{student_name}/{notebook}


exposing additional signing and encryption algorithms in the KeyVault .net SDK

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[ ] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dragav,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Updated media folder name and media paths.

@sethmanheim

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

If this PR needs approval, or if the commits need to be pulled into the private repo, contact @ManikaDhiman. Thanks.

#sign-off

@LouisBerner @ManikaDhiman - make sure to check the images after these changes are live, including the lightbox fuctionality. thanks.


[Encoder decoder] Add cuda graph support during decoding for encoder-decoder models

In this PR we are adding support for CUDA Graph capture & replay during the decoding phase for encoder-decoder models. Currently this support is missing for encoder-decoder models. To that end this PR makes the following changes

Updates the CUDA capture process in model_runner.py and CUDAGraphRunner to capture the additional inputs/attention metadata needed for encoder-decoder models. We also had to make changes to CommonAttentionState in vllm/attention/backends/utils.py to account for the additional attention metadata that needs to be captured for encoder decoder models.

Updated the CUDA graph replay process to add the additional encoder decoder tensors needed. This required changes to CUDAGraphRunner in model_runner.py and enc_dec_model_runner.py.

Updated the model signature for encoder decoder models (bart.py) to pass the encoder specific arguments at the end as keyword arguments. This enables us to reuse the existing Model replay/warmup logic in CUDAGraphRunner.

Updated the description of the max_seq_len_to_capture to indicate that if the sequence length of the encoder input exceeds this then we will fallback to eager mode.

Added e2e cuda graph correctness test for encoder-decoder models using bart in test_bart.py and also added an additional test in test_encoder_decoder_model_runner.py to test that the tensors are being padded appropriately during CUDA Graph capture and replay.

#7447
Measurements based on e2e test
For the test test_model_with_cuda_graph[DecoderPromptType.CUSTOM-5-2048-bfloat16-facebook/bart-large-cnn] with the cuda graph enabled we see an increase in token throughput
With CUDA Graph Processed prompts: 100%|█████████████████████████████████████████████████████████| 8/8 [00:00<00:00, 44.62it/s, est. speed input: 1026.55 toks/s, output: 764.27 toks/s]
Without CUDA Graph Processed prompts: 100%|██████████████████████████████████████████████████████████| 8/8 [00:00<00:00, 15.12it/s, est. speed input: 347.97 toks/s, output: 259.08 toks/s]
.

/ready

Thanks for the review. Addressed comments and synced.


Version for android

Don't you plan to add support for android native look and feel?

Closing it for now, as i am going to implement materials theme/plugin/fork in different repo


Invalid page description

[Enter feedback here]
This isn't showing how to convert.  This page is saying "I know you need to convert your project, so I'll tell you that you should look at a sample repo and then do it."  This isn't a how-to-convert page, this is a sample-cmake-project.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bbcb7c84-bd49-1b2a-ae81-a2a2cc0e1fa4
Version Independent ID: f70e4f72-6868-095f-9183-1a46409b1d48
Content: Convert a Visual Studio project to CMake - Azure Sphere
Content Source: AzureSphere/articles/resources/convert-vcxproj-cmake.md
Service: azure-sphere
GitHub Login: @richcalaway
Microsoft Alias: azurespheredocs

Hi Matthew,
I wrote this up in 2020. It may help you.
https://community.element14.com/products/devtools/avnetboardscommunity/azure-sphere-starter-kits/b/blog/posts/porting-azure-sphere-visual-studio-projects-to-cmake
Brian

From: Matthew McCann @.>
Sent: Friday, July 21, 2023 11:23:32 AM
To: MicrosoftDocs/azure-sphere-issues @.>
Cc: Subscribed @.***>
Subject: [External][MicrosoftDocs/azure-sphere-issues] Invalid page description (Issue #305)
[Enter feedback here]
This isn't showing how to convert. This page is saying "I know you need to convert your project, so I'll tell you that you should look at a sample repo and then do it." This isn't a how-to-convert page, this is a sample-cmake-project.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bbcb7c84-bd49-1b2a-ae81-a2a2cc0e1fa4
Version Independent ID: f70e4f72-6868-095f-9183-1a46409b1d48
Content: Convert a Visual Studio project to CMake - Azure Spherehttps://learn.microsoft.com/en-us/azure-sphere/resources/convert-vcxproj-cmake
Content Source: AzureSphere/articles/resources/convert-vcxproj-cmake.mdhttps://github.com/MicrosoftDocs/Azure-Sphere-Docs-pr/blob/live/AzureSphere/articles/resources/convert-vcxproj-cmake.md
Service: azure-sphere
GitHub Login: @richcalawayhttps://github.com/richcalaway
Microsoft Alias: azurespheredocs

—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-sphere-issues/issues/305, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ5SQWZEOQA7RFPAYFWEKVDXRKNHJANCNFSM6AAAAAA2S7QLQI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@SuperElectron
Thanks for your feedback! We will investigate and update as appropriate.

@SaibabaBalapur-MSFT Sorry, I am not the author of this topic. My only contribution to this topic was a bulk metadata update to remove one metadata attribute done as part of a Quality & Maintenance vendor pass. It looks like the author richcalaway doesn't exist anymore in GitHub or Microsoft so I suggest assigning this to @prabhushyja as owner of this content set.

@prabhushyja
please review it.

@SuperElectron - Can you provide specific feedback about the information you are looking for on this page?
We do not automatically convert Visual Studio projects. If you have Visual Studio project files, you have to manually follow the steps listed in Convert a Visual Studio project to CMake.

Can close, it was a while ago and I don't have the code on me. Have a great day 😊


Mocha tests - mocha.json options file not found. Using default values...

Low priority I think but...
From what I've researched, mocha usually uses a mocha.opts file, not a .json file.
As we're expecting a json file instead, the format and location of this needs to be documented for users/devs along with what options are/aren't supported.
At a minimum if there's no expectation that an end user will modify the defaults set by this plugin it's possibly worth suppressing this message in TestFrameworks/Mocha/mocha.js

Agreed, we should make it clearer what that's for.
Fwiw the best documentation is currently available in our 1.1 RC release notes - we haven't moved it over to our wiki just yet, but feel free to jump in and help (our wiki is public) :smiley:
And you can view some of the discussion around why mocha.json at https://github.com/Microsoft/nodejstools/pull/168

Cool - thanks. Reading now...
... ok - understand the reasoning behind using a different file from .opts and the location.
And in the release notes too :) - is the test config part new in there?
I'll fathom out a starter on the wiki for this - probably something about "Configuring Test Output"

Wiki done - "Configuring Mocha Options" (as it's more than just test output).
Thanks for the help on this.

Any plans to support more options (like the --require flag)?  Also, it might be good to document which flags don't currently work.  I'm tempted to hack around in the mocha.js file to get things working but I don't want to break my upgrade path.


Cluster State Logs take up 2/3s of the total log volume

Description
What problem are you trying to solve?
There is a large amount of the log volume dedicated to a single log cluster sync logs. I see two ways to solve the volume.

As we move to the new controller runtime logging with verbosity levels, I suggest we add it at lower verbosity.
Log after a longer period similar to the abnormal amount of time between consolidation like seen here. We can log if there has been an abnormal amount of time for cluster sync.

How important is this feature to you?

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

/assign Bryce-Soghigian