LTR Retriever crashes when input assembly does not contain LTRs

Description of the bug
LTR Retriever crashes when input assembly does not contain LTRs
Command used and terminal output
No response
Relevant files
No response
System information
No response

Tasks

[ ] Add unit tests to FASTA_LTRRETRIEVER_LAI relevant modules to verify that they can exit gracefully when no LTRs are found

https://github.com/nf-core/modules/pull/5979
https://github.com/nf-core/modules/pull/5978


Add textDocument/inlineCompletion to 3.18

This is an initial pass per the discussion in https://github.com/microsoft/language-server-protocol/issues/1529 I primarily modeled it after the existing VSCode API. I'm opening a PR for vscode-languageserver-node in parallel.

Sorry for any spam on the review requesting here. I think it's ready for @dbaeumer and @rchl to both look at.

Needs to wait until next week. We have endgame week.

Hey Dirk, with https://github.com/microsoft/vscode-languageserver-node/pull/1190 approved, is there anything in particular you'd like in this PR?

Conceptually there is a difference between them. Code completions should usually only suggest things that are correct (e.g. complete an existing method, ...) were as inline completions can be way more fuzzy. That is why they complement each other.

How about adding a fuzzy score or confidence score to the completion results then? The inline in the new proposal implies how clients should present it, and so far the policy was that presentation is mostly left up to the clients. It also doesn't communicate this semantic difference you mentioned.

I see the point that the spec should talk about how a client presents inline completions (e.g. for example as grayed text in the editor itself). I will think about how to rephrase this.
However there is a conceptual different that we would like to keep separate mostly because adding additional flags or context information always turned out to be more complicated.

With only one item being displayed at a time, the server may use this
feature for visible edits where it is relatively confident the user would like
this edit in particular.

Isn't this contradicting that inline completions can be way more fuzzy?

No, completion items should for example not complete incorrect code (e.g. propose a method that doesn't exist). Inline completions are allowed to generate code that is both syntactically and semantically incorrect.

(sorry about the churn)


NTR: metadata for "Lee Gambian" RNASeq in plasmo and host.

Hi Jie,
there is an RNASeq dataset where i'd like to load some associated metadata.  It is the "Lee Gambian" dataset in plasmo and host.
The meta data is here:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6326353/bin/NIHMS81012-supplement-Supplementary_Dataset_1.xlsx
Most of the headers require ontology terms. We don't have definitions, all we have is the headers in that file. Could you take a look and we can discuss later.
Thank you.

@weili-apidb Could you please list the terms you need?

Parasite density  (/µl)

I found the term 'parasite density by PCR' http://purl.obolibrary.org/obo/EUPATH_0000536
Can I know what method is used to get the Parasite density? If it is PCR, we can use existing EUPATH term. Otherwise, we need to add a new term.

I submitted two new term requests:
https://github.com/VEuPathDB-ontology/VEuPathDB-ontology/issues/416 Percentage parasitemia
https://github.com/VEuPathDB-ontology/VEuPathDB-ontology/issues/417 Sickle cell screen
@weili-apidb Could you please review the terms? If they are correct, we will add in the ontology and provide the IDs to you.

@weili-apidb We need more information of following 3 terms.
PfHRP2 (ng/mL) - is it blood Plasmodium falciparum histidine-rich proteins 2 density
Parasite clones - Can we have more information of it?
First Blantyre coma score - How is it different from Blantyre coma score?

-The two new terms look good to me.
-PfHRP2 (ng/mL)
P. falciparum histidine rich protein 2
-Parasite density (/µl)
Peripheral blood parasite quantification by RNA-sequencing of blood from infected patients.
-Parasite clones ?
-First Blantyre coma score ?

Yes, in blood

Asked JohnB, Kathryn and Susanne. They have no idea about the two terms:
-Parasite clones
-First Blantyre coma score

Thanks @weili-apidb

For "ethnicity", http://purl.obolibrary.org/obo/OMRSE_00000100 is obsolete. Replaced with http://purl.obolibrary.org/obo/OMRSE_00000205
For "Red blood cell count (x1012/L" it should be CMO_0000025 not CMO_0000029


Question: regarding bookmarks?

Does brackets have bookmarking capability? Like I remember in visual studio (ugh) there was a way to place a bookmark then use a shortcut to jump to the line you place a bookmark on. Does it do this? if not, it would be cool to add that

Hey @carinlynchin,
there's at least this extension https://github.com/JeffryBooher/brackets-bookmarks-extension by a Adobe member (and one other older one that doesn't seem to be supported anymore). Does that work for you? 👍

So awesome!!! thank you so much :)

Trello card: https://trello.com/c/ziZfd6Rl/548-bookmark-line-location-within-text


fix: styling project management

This PR...
Changes

[x] Highlighted the active project in the table
[x] Separated cluster management from project management
[x] project item hover color
[x] display confirm message when delete

Fixes

How to test it

Screenshots

https://user-images.githubusercontent.com/20525304/150767308-7e7259d7-f312-4878-804d-2d3eea9badc2.mp4
Checklist

[ ] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

@tommywhitehead  we have inconsistent colors between project dropdown and cluster dropdown!
more context https://kubeshop.slack.com/archives/C023JNPUSP8/p1643011938397600


Reveal.js for presentations

Reveal seems a bit more straightforward for making a presentation engine versus impress, which takes much more css skillz.
https://github.com/hakimel/reveal.js

Hacked this shiz together, not proud but it's definitely better than impress with less effort (since it comes with themes). Need to improve editing and make feature more evident.


Possible to distinguish between clickStage and stage drag?

Is it possible to distinguish between a clickStage and "dragStage' event?
The "2. BIND CALLBACKS TO EVENTS" example on http://sigmajs.org/ can be used to recreate my issue.
When a node is clicked the non-neighboring nodes are grey'd out. Cool, good so far. Now if you move the graph by dragging the stage then when the mouse is released the clickStage event is fired and the entire graph is recolored. I would like to prevent this from happening.
What would be really great is if the clickStage event were not fired at all when the mouse is moved while down (by some appropriate amount). However, I can understand if this behavior is not so great for everyone else.
Thanks!
Bob B

Hi @jacomyal,
I really appreciate you fixed this issue, it's great helpful. However, I cannot find the isDragging property both in "clickStage" and "clickNode" event captor property in release 1.0.3. I also dig into the source code  for the latest release, namely, "captor.mouse.js" file, but cannot find the property as well.
Could you please help me out with it? Thanks!

Thanks, I found isDragging really useful

@jacomyal thank you for adding this functionality I was running into the same problem with the drag plugin and the clickNode event.

@telam  the isDragging property seems to stay false for me too in the clickNode event while dragging one node .

For anyone who is having trouble with the clickNode event and the isDragging property, I found a temporary solution, although it is a little hacky. @Kuroky360 I hope this helps you!
// let the user drag nodes around
var listener = new sigma.plugins.dragNodes(network, network.renderers[0]);

listener.bind("drag", function (e) {
    network.unbind('clickNode');
});

listener.bind("dragend", function (e) {
    setTimeout(function () {
        network.bind('clickNode', node_click_function);
    }, 250);
});

@telam well, I will try it.Thanks for your suggestion!


refactor: migrate to signal-based inputs & queries + output fns

Signals are stable, let's migrate!

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#865  👈 (View in Graphite)
#864
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Moving up and down via shortcuts does not work in Firefox

When attempting to move task up or down via Shift + Up/Down/j/k, task will just blink in place, but will not move.
This is with Firefox  87.0 and todoist shortcuts 128.

Hmm, have you removed sorting from the project?  When sorting is enabled,
task movement doesn't work.
For me task movement works in firefox
On Fri, Apr 2, 2021 at 11:20 PM Matej Drobnič @.***>
wrote:

When attempting to move task up or down via Shift + Up/Down/j/k, task will
just blink in place, but will not move.
This is with Firefox 87.0 and todoist shortcuts 128.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/176, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKTNKCQNSNTSSKJJSHDTG2QTPANCNFSM42J3NKYA
.

I can move tasks with mouse with no problems, so it's not the sorting.

Are there any logs or anything else I can give you to help sort out the issue?

If you download the extension code, and then set DEBUG to true here -
https://github.com/mgsloan/todoist-shortcuts/blob/master/src/todoist-shortcuts.js#L5

then load the modified extension you will get a lot more logs.  Not sure
if they will help diagnose, but they might!

It might not be necessary to enable the DEBUG logging.  By default it will
still log errors, so the normal logs in developer tools might also be
useful.
On Thu, Apr 8, 2021 at 3:25 AM Matej Drobnič @.***>
wrote:

Are there any logs or anything else I can give you to help sort out the
issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/176#issuecomment-815605108,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKWIWXTLCZ26OMHUWMTTHVZBFANCNFSM42J3NKYA
.

Huh it seems to work now. Maybe it was an update from Todoist that messed up something before. Thanks for your help.

This is still happening, but only in one project (can't find anything different in that project). Here is the debug log of me trying to move a task up with Shift + K:
todoist-shortcuts: keydownHandler
keydown Shift { target: body.with_new_emoji_sizing
, key: "K", charCode: 0, keyCode: 75 }
vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.242 todoist-shortcuts: ignoring scroll vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.242 todoist-shortcuts: moveUp target is
<li id="task-4751098710" class="task_list_item task_list_item--project_hidden" data-selection-id="4751098710" aria-selected="false" data-item-id="4751098710" data-item-indent="1" style="">
vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.261 todoist-shortcuts: viewMode =  project vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.262 todoist-shortcuts: ignoring mutations since drag is in progress:
Array [ MutationRecord ]
vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.267 todoist-shortcuts: handleMouseMove ignoring synthetic mouse move event. 11 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.332 todoist-shortcuts: restoring scroll vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.332 todoist-shortcuts: Checking if cursor still exists:<PHONE_NUMBER> indent_1 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.333 todoist-shortcuts: Cursor hasn't changed task: currentSection =  <empty string> lastCursorSection =  <empty string> id =<PHONE_NUMBER> indent = indent_1 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.333 todoist-shortcuts: Found normal cursor, so storing its context vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.333 todoist-shortcuts: wrote down cursor context: id =<PHONE_NUMBER> indent = indent_1 section = <empty string> idx = 31 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.350 todoist-shortcuts: viewMode =  project vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.351 todoist-shortcuts: ensuring cursor due to mutations:
Array [ MutationRecord ]
vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.351 todoist-shortcuts: Checking if cursor still exists:<PHONE_NUMBER> indent_1 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.351 todoist-shortcuts: Cursor hasn't changed task: currentSection =  <empty string> lastCursorSection =  <empty string> id =<PHONE_NUMBER> indent = indent_1 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.352 todoist-shortcuts: Found normal cursor, so storing its context vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.352 todoist-shortcuts: wrote down cursor context: id =<PHONE_NUMBER> indent = indent_1 section = <empty string> idx = 31 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.400 todoist-shortcuts: Checking if cursor still exists:<PHONE_NUMBER> indent_1 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.401 todoist-shortcuts: Cursor hasn't changed task: currentSection =  <empty string> lastCursorSection =  <empty string> id =<PHONE_NUMBER> indent = indent_1 vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.401 todoist-shortcuts: Found normal cursor, so storing its context vendor.f3cab33e857221b9f96a.js:1:366360
07:56:42.401 todoist-shortcuts: wrote down cursor context: id =<PHONE_NUMBER> indent = indent_1 section = <empty string> idx = 31 vendor.f3cab33e857221b9f96a.js:1:366360

Same issue - in Inbox w/ no sort enabled in chrome. none of the move lines work. Works with edge for some reason.

Curious!  The only browsers available to me are chrome and firefox, so I
can't straightforwardly work on this.  Would accept patches fixing it
though, naturally!
On Sat, Jul 10, 2021 at 8:11 AM GaryFurash @.***> wrote:

Same issue - in Inbox w/ no sort enabled in chrome. none of the move lines
work. Works with edge for some reason.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/176#issuecomment-877644218,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKX5655O4EKZNCDMUPTTXBIIJANCNFSM42J3NKYA
.

The only browsers available to me are chrome and firefox, so I can't straightforwardly work on this.

Well, I'm having issue in Firefox and @GaryFurash has an issue in Chrome, so I don't think this is an issue ;)
Any chance you could make a branch with more logging enabled? That way I can install this and give you more logs on what is going on.

True!
To get more logs you can change line 5 from const DEBUG = false; to
const DEBUG = true;
-Michael
On Sun, Jul 25, 2021 at 12:31 AM Matej Drobnič @.***>
wrote:

The only browsers available to me are chrome and firefox, so I can't
straightforwardly work on this.
Well, I'm having issue in Firefox and @GaryFurash
https://github.com/GaryFurash has an issue in Chrome, so I don't think
this is an issue ;)
Any chance you could make a branch with more logging enabled? That way I
can install this and give you more logs on what is going on.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/176#issuecomment-886154358,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKVB3XG4JZE76RXEG7TTZOVUDANCNFSM42J3NKYA
.

I've given you debug logs above. Or do you want me to retry this with newer builds (maybe you added more logging statements?)?

Sorry, since I have no idea how to reproduce the bug, I can't really work on fixing it.

Right, but we can reproduce it for you and give you all the necessary data to fix it.

I, too, have trouble using j/k to move around. I suppose this is mostly due to the new Todoist shortcut thing. I just wrote to their tech support, asking if they have an option to undo all their own shortcuts like what Gmail has been offering for almost 10 years.

@mgsloan I've been trying to debug it and the issue appears to be in the  offset method. Sometimes, offset methods does not appear to provide proper Y for the emulated mouse cursor (it is hundreds off) and it thus attempts to move it to a different position.
Changing offset method to the following code fixes the shifting issue:
  function offset(el) {
    let bounds = el.getBoundingClientRect();
    return {x: bounds.x, y: bounds.y};
  }

however, it causes different issues (just moving up or down with j and k causes page to randomly scroll around).
Do you have any idea what could cause the offset method to break? I can try inserting extra debug statements.

Fix will be in version 142!  Thanks matejdro!
I can now reproduce this issue.  The problem happens when there are enough tasks in a project to allow scrolling, and the window is scrolled down.
I've kept the "put task in view" code using the old implementation of offset, and used matejdro's offset code for task movement.

That's amazing, thanks a lot.


Proposal: optimize size and request count

JSON-to-Go use highlight.js and load all languages
JSON-to-Proto (copy-paste of JSON-to-Go) also use highlight.js but load one language
If you agree ➡ i will rewrite with Webpack and one build file ➡ this reduce loaded size

Sure, submit a PR and I'll take a look.

Great, this is first ready step ➡ #75
If you agree ➡ i will use https://webpack.js.org/guides/lazy-loading/ to extract 700 KB of gofmt.js to lazy loading, and some clear code


Docs issue related to migration and distributed

Description:

For a user who is migration to 3.1.0 distributed setup, there were a couple of points missed in the documentation.

In APIM 3.1.0 distributed setup, the key manager's public certificate should be included in the GW,s client trustore with the alias "gateway_certificate_alias".
Since we are using thrift to communicate with TM we don't use LB. But for store/publisher to communicate with TM HA setup, we might need a LB, (This is not mandatory but better to have it) They wanted to reason out these.
For store/publisher to communicate with GW in HA mode, you need if there's only a single external LB fronting GWs, should they use another internal LB or can they use external LB.
Distributed deployment best practices documentation.
Distributed deployment troubleshoot guide.

If you see specific error, what kind of checks you can do to narrow down the issue or to solve the issue etc.

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Since distributed deployment best practices and the troubleshooting needs new content, I moved that to another issue https://github.com/wso2/docs-apim/issues/2705


"Corrupted" save

Attempting to load a .12 save file after updating to .13/.14 returns a message informing that the save is corrupted and can't be loaded (save can be safely loaded in .12 by using the rollback feature). The game must then be crashed to exit.
Please provide documentation on what to do in these situations and how to correctly update, or notify if we should not update at all.

All changes are documented on change log which you can access from mod UI. Unfortunately there are some game breaking changes and we point them out with “RESPEC required on …” as very first entry on changelog.
You need to rollback to 12, can do that from mod UI as well but will need to rollback twice if at 14.
On 12 Respec off any subclasses that got highlighted as “need RESPEC”.
once so upgrade and RESPEC back to them.

Understandable. Can we hope to see some improvements to the respec feature in the future, or to additive changes to avoid class-swapping shenanigans?


This class should not be package private but should be possible to ex…

…tend JedisFactory adnd JedisPool. Further, jedispool should create factory through a method to allow for overriding, alternatively be added as a constructor parameter. Current impl is bogged by constructors which  should really be taking a ConfigParam instead.

Why did the tests fail?

@sazzad16 any objections?

@gkorland without any test, I'm a bit concerned. but you can go ahead if want.


error: ‘stoi’ is not a member of ‘std’

My enviroment is win11, wsl2, g++,gcc 4.4.7
I met the problem :
deviceQuery.cpp: In function ‘int main(int, char**)’:
deviceQuery.cpp:176: error: ‘stoi’ is not a member of ‘std’
deviceQuery.cpp:180: error: no matching function for call to ‘std::basic_fstream<char, std::char_traits >::open(std::string&, std::_Ios_Openmode)’
/usr/include/c++/4.4/fstream:865: note: candidates are: void std::basic_fstream<_CharT, _Traits>::open(const char*, std::_Ios_Openmode) [with _CharT = char, _Traits = std::char_traits]
make: *** [Makefile:326: deviceQuery.o] Error 1
Failed to compile deviceQuery
I try the solution on stackoverflow but don't work
https://stackoverflow.com/questions/38034197/compile-error-stoi-is-not-a-member-of-std

sorry, I solve the problem. My version of  gcc and g++ are too old. the version should be over 4.8 to support the c++11


Where CompiledExpression.php ?

$ zephir generate
PHP Warning:  require(/opt/zephir/Library/Optimizers/FunctionCall/CompiledExpression.php): failed to open stream: No such file or directory in /opt/zephir/Library/Loader.php on line 48
PHP Fatal error:  require(): Failed opening required '/opt/zephir/Library/Optimizers/FunctionCall/CompiledExpression.php' (include_path='.:/usr/share/php:/usr/share/pear') in /opt/zephir/Library/Loader.php on line 48

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10612199-where-compiledexpression-php?utm_campaign=plugin&utm_content=tracker%2F280146&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F280146&utm_medium=issues&utm_source=github).

Did you install the dependencies?
composer install

Recently installed. But still get error
PHP Fatal error:  Class 'Zephir\Optimizers\FunctionCall\CompiledExpression' not found in /home/wskdf/coba/optimizers/TahedeTesOptimizer.php on line 32
return new CompiledExpression("double", "my_tahede_tes(" . $resolvedParams[0] . ")", $expression);

The code from zephir manual, I only replace function name.

You have to add at the beginning of the file /home/wskdf/coba/optimizers/TahedeTesOptimizer.php:
use Zephir\CompiledExpression;

Generate and compile success, but extension not work
/usr/sbin/apache2: symbol lookup error: /usr/lib/php5/20090626/coba.so: undefined symbol: my_tahede_tes
I'm not must use "my_calculate_pi" right?

You have to add the C source file where my_tahede_tes is implemented to your project, like this: https://github.com/phalcon/cphalcon/blob/2.0.0/config.json#L23-L34

I did.
But solved now. Run  zephir fullclean and generate again,,,,
Thank's


community[minor]: Add graph store extractors

This adds an extractor interface and an implementation for HTML pages.
Extractors are used to create GraphVectorStore Links on loaded content.
Twitter handle: cbornet_

@cbornet if you're confident with the abstractions we can also commit it to langchain which is meant for provider agnostic implementations.


reader: fix the invisible write record flashback bug

Signed-off-by: JmPotato<EMAIL_ADDRESS>What is changed and how it works?
Issue Number: Close #13844.
What's Changed:

Fix the bug that when a key's last write record is `WriteType::Lock` or `WriteType::Rollback`,
the `scan_writes` will return the invisible write record as the result, which will affect the flashback correctness.

Check List
Tests

Unit test
Integration test

Release note
None.

/run-check-issue-triage-complete

/check-issue-triage-complete

/merge

/merge

/merge


NFT withdrawal stuck in processing

Users IOTA L1 Address: iota1qqrt3msgkgqtnwutuxq78ywnnxnaww2x769nz9yzcwgfv7w7gzppg0yh603

@whatmicha It sounds like your query would be best dealt with by the support team.
Please see the link below to our dedicated support line:
Support :Help Center
Note: Click on the live chat icon at the bottom corner of the page to start a conversation

So now we have scammers here too. @Demistumod67 scammer get out of here!

related to https://github.com/soonaverse/app/issues/182


More node operation updates. (No Merge)

Corrections to Access API docs.

Closing because these changes were addressed in #201


Pincode input gets stuck if re-entry is canceled after initial entry

Bug Found
Steps to reproduce bug :

Go to the home page.
Enter a valid pincode and wait for the confirmation.
Try to edit the pincode by selecting the field again.
Click the "Cancel" button or outside the field without re-entering a new pincode.
Observe that the pincode field prompts for input again instead of using the last entered pincode.

Expected Behaviour :
When canceling the pincode re-entry, the field should retain the previously entered pincode instead of requesting input again.
Actual Behavior :
The field prompts for the pincode again, disregarding the previously entered pincode, and prevents the user from proceeding without re-entering it.
Screenshot :

Hi @namansinghrana! Thanks for opening this issue on Ratna Supermarket. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

Hello @namansinghrana! Your issue #189 has been closed. Thank you for your contribution!🚀


white-space safe 'thefuck' with the history line passed as a single arg?

In some shells' thefuck alias, e.g. for bash, the core part falls to:
# https://github.com/nvbn/thefuck/blob/master/thefuck/shells/bash.py#L13
eval $(BUNCH_OF_VARIABLES=something thefuck $(fc -ln -1)))

But $(fc -ln -1) is not a safe thing to try. In python terminology, $(fc -ln -1) is something like:
reduce(op.add, (glob.glob(i) for i in shell_stdout(['fc', '-ln', '-1']).split()))

which is almost certainly not the thing you are looking for. Similarly, $TF_CMD gets split and globbed and list-joined (and ' '.join()'ed by eval) in eval $TF_CMD.
For POSIX shells like bash and zsh (well, POSIX-ish) this can be solved by passing in the whole history string and actually interpreting the results of shlex.split(thestring). For other shells.. perhaps a custom lexer?
tcsh seems to suffer from the same problem, but I am not a tcsh expert so I may be wrong:
A2:~# sh -xvc ': "$@"' -- `echo 'foo bar /*'`
: "$@"
+ : foo bar /bin /boot /dev /etc /home /initrd.img /initrd.img.old /lib /lib32 /lib64 /libx32 /lost+found /media /mnt /opt /proc /pub /root /run /sbin /srv /sys /tmp /usr /var /vmlinuz /vmlinuz.old

(using sh for some arg dump that makes sense)

thefuck actually has a long way to go regarding whitespace/metachar-safety. Take 237f43e as an example (I found the cd issue when searching for 'whitespace' in issues to make sure that I didn't get a dup):
return 'cd "{0}"'.format(cwd)

This is unfortunately not the safe thing to do, e.g.:
cd "$(mktemp -d)"
mkdir aaaa\"
thefuck cd aaa

You will get some output like:
cd "/tmp/tmp.R71CQrZT1O/aaaa""

Unbalanced quotes.
The Right Thing :tm: to do is to actually use lists as the data structure for internal representation of single commands, i.e.
return ['cd', cwd]

And finally do some quoting based on shell-dependent rules before outputting:
# e.g. POSIX-ish shells:
def quote(self, list):
    return ' '.join("'{0}'".format(arg.replace("'", "'\\''")) for arg in list) # shlex.quote(arg)

Yep, you're right. I'll think about how it can be made.


Soundcloud Optimization

Due to recent events with the bots that depend on Youtube to play your music, many of us developers have moved to "Soundcloud", it is true that Erela can play from "Soundcloud", but there is a problem, some songs only play 30s, as they are within the "PREMIUM" plan of Soundcloud, I do not know if in the future, there will be a solution for this.

There wont be a solution for this for erela.js since lavaplayer, the library used by lavalink would probably have to be changed heavily.

And have you not considered using other types of players like iTunes?

And have you not considered using other types of players like iTunes?

What? You can't stream audio from iTunes using lavaplayer.


Cassandra Error after restart

Hi there,
After restarting Kong, (container based, started over marathon) I have got the cryptic:
[INFO] Connecting to the database...
[ERR] Cassandra error: Cassandra returned error (Invalid): "Invalid column name path because it conflicts with an existing column"

I would not really enjoy having reconfuigure the entire proxy. An idea where this might come from?
Thanks in advance.

Short edit, version might help
[INFO] Using configuration: /etc/kong/kong.yml
[INFO] Kong version.......0.3.2
       Proxy HTTP port....8000
       Proxy HTTPS port...8443
       Admin API port.....8001
       dnsmasq port.......8053
       Database...........cassandra keepalive=60000 hosts=services.mycompany.io port=9042 timeout=1000 keyspace=kong
[INFO] Connecting to the database...
[ERR] Cassandra error: Cassandra returned error (Invalid): "Invalid column name path because it conflicts with an existing column"

And bumping up to 0.4.1 did not help
[INFO] Using configuration: /etc/kong/kong.yml
[INFO] Kong version.......0.4.1
       Proxy HTTP port....8000
       Proxy HTTPS port...8443
       Admin API port.....8001
       dnsmasq port.......8053
       Database...........cassandra keepalive=60000 hosts=services.mobilecity.io port=9042 timeout=1000 keyspace=kong
[INFO] Connecting to the database...
[ERR] Cassandra error: Cassandra returned error (Invalid): "Invalid column name path because it conflicts with an existing column"

Hi,
Can you connect to your Cassandra cluster with cqlsh and execute:
USE <your_keyspace>;
DESCRIBE TABLES;

Especially look for a table named schema_migrations. In case it is here, please also share the output of:
SELECT * FROM schema_migrations;

That would be really helpful and that way I could give you instructions on how to fix your cluster without re-configuring everything.
Could you also tell us how many Cassandra nodes are you running ? Thank you.

Hi,
I have saved every configuration request, so I could rebuild everything with not too much pain.
I've saved the broken Cassandra state though, so if you expect to find some interesting bug that would improve Kong itself I would search were it went wrong but if not I would let this one go if I'm the first one to experience it.
As we are still in staging I'have only one instance running.
Let me know if this might be of general interess and thanks for the response.

Closing this since the root of the problem is found in #491.


Intellisense doesn't work on installed Python libraries

It seems that Intellisense does recognize pip-installed libraries itself and if you do the following:
import matplotlib.[press ctrl-space to trigger Intellisense]
it loads a moment and then provides correct subpackages.
But if I try to use the lib in my code like this:
matplotlib.[press ctrl-space to trigger Intellisense]
it doesn't show anything except for the usual stuff it generates from the file's content
Weirdly, if I hover above matplotlib, it does show me information about the module...
Note that I use vscode insider:

VSCode Version:
1.22.0-insider
6c22e21cdcd6811770ddcc0d8ac3174aaad03678 (<- not sure if this is the version commit, it show up in vscode-insider --version)
x64
OS Version: Windows 10 x64

Steps to Reproduce:

Create py file
import matplotlib/numpy/scipy
no Intellisense shows up when trying to access methods

Does this issue occur when all extensions are disabled?: No (ofc, it needs at least the Python extension)
Glad about any help/information about how to fix this issue!

Intellisense is not actually working in general after the latest update on my end

Okay so it doesn't seem to be a problem of misconfiguration, that's nice to hear! Do you know when this will be fixed?

Can you please file this issue against the python extension


apipanic: Log stack at debug level

Previously, it was difficult to debug issues when the API panicked
because only a single line like the following was printed:
level=warning msg="Cilium API handler panicked" client=@ method=GET
panic_message="write unix /var/run/cilium/cilium.sock->@: write: broken
pipe"
This patch logs the stack at this point at debug level so that it can at
least be determined in developer environments.
Fixes: #4191

This change is

test-me-please

Hit #4514 .

test-me-please


React native webview shared instance

Hello, I'm planning on rewriting webview to be able to have instances separate from the rendering of the webview. This PR will probably not make it as is, but this idea behind it is good

Hi @Titozzz , what's missing in this PR? What can I improve in it?

Hi @Titozzz , I am using this implementation in one of our production app. Is anything wrong with it or anything that I can improve?

I don't think it's necessarily broken, it just has many other features that would use this. Pre loading, messaging with the instance even when not shown. Stuff like that but the API will be quite different


Making the Navbar Sticky

[YES ] Have you followed the contributing guidelines?
Yes, I have read and followed all the contributing guidelines.

[ YES] Have you explained what your changes do, and why they add value?
Yes, I have commented on the changes made and what exactly the code does.
This contribution aimed to make the navbar of the website sticky.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

👋 Thank you for the contribution, but we're not planning to change the navbar style at this time.


error: cannot add moonbitlang/core as dependency

Tried to add the core library, but I receive a generic error. Not sure what to try. This is with the latest stable release of moon CLI.

$ moon add moonbitlang/core

error: cannot add `moonbitlang/core` as dependency

Using a blank project created by moon new

The current moonbitlang/core and the compiler are released together and will be automatically linked during compilation. This means you do not need to install them from mooncakes.io. The moonbitlang/core on mooncakes.io currently serves only as documentation. We will fix the confusing installation information.
In the future, once the compiler reaches a stable state, it may allow for the addition of different versions of moonbitlang/core.

Can you clarify how to make it work? I tried to "just use" it but the compiler complains it can't find it. Latest version.

Below is my full installation log:
$ rm -rf ~/.moon
$ /bin/bash -c "$(curl -fsSL https://cli.moonbitlang.com/mac_m1_moon_setup.sh)"
Downloading https://cli.moonbitlang.com/macos_m1/moon to /Users/li/.moon/bin/moon
Downloading https://cli.moonbitlang.com/macos_m1/moonc to /Users/li/.moon/bin/moonc
Downloading https://cli.moonbitlang.com/macos_m1/moonfmt to /Users/li/.moon/bin/moonfmt
Downloading https://cli.moonbitlang.com/macos_m1/moonrun to /Users/li/.moon/bin/moonrun
Downloading https://cli.moonbitlang.com/macos_m1/moondoc to /Users/li/.moon/bin/moondoc
/Users/li/.moon/bin/moon downloaded
/Users/li/.moon/bin/moonc downloaded
/Users/li/.moon/bin/moonfmt downloaded
/Users/li/.moon/bin/moonrun downloaded
/Users/li/.moon/bin/moondoc downloaded
Update successfully!
Downloading moonbit core...
Install successfully
$ moon version --all
moon 0.1.0 (90245da 2024-03-22) ~/.moon/bin/moon
moonc 3592922 2024-03-22 ~/.moon/bin/moonc
$ moon new hello
Created hello
$ cd hello
$ moon run main
Hello, world!

What is your output?

@jayphelps note you don't need add core, you can use it directly


Add basic html to the tutorial

What
Add basic HTML to the tutorial
Why
The tutorial covers some html, but doesnt explain the basics of tags opening and closing, attributes.
Who needs to work on this

content design

Who needs to review this

interaction design

Done when

[ ] We have covered the basics of html in the tutorial

PR: https://github.com/alphagov/govuk-prototype-kit-docs/pull/260


makeBucketRequest code confused

Hi:
I am just learning yours project
I am confused with api-put-bucket.go  MakeBucket() call isValidBucketName() to validate the input arguments and call makeBucketRequest() to make a httprequest
but come into makeBucketRequest()  again call isValidBucketName()  here is repeat ??
and in makeBucketRequest()
targetURL, err := url.Parse(c.endpointURL)   the client is init from the New  here to parse it why ??

but come into makeBucketRequest() again call isValidBucketName() here is repeat ??

This is because each function its own function validation independently. To avoid this we need to keep a validated form of a BucketType. Any changes here are welcome.

targetURL, err := url.Parse(c.endpointURL) the client is init from the New here to parse it why ??

This needs to be changed to store parsed URL directly.   This is a trivial change.


Feature/video codec phonebook clear

Modified the SelectDirectoryEntry method in VideoCodecBase to accept a 0 index and set the private _selectedDirectoryItem to a null value, and modifed the rest of the method to clear all appropriate trilist signals.
Added a digital join to explicitly pass a zero index to SelectDirectoryEntry and set the DirectorySetRow join to a ToFromSimpl so we could report the index passed into the method.

Closing as changes are implemented in #993


Update doc comments and mark additional Driver APIs as @_spi(Testing)

Nothing exciting, just some minor cleanups I noticed.

@swift-ci test

yeah, I'm sure there's more we could do to clean up the API surface, I really only looked through Driver.swift for now.


made the header FitFlex (under 350px ) image and and footer responsive .

Title and Issue number

Title : the about us page is not responsive
Issue No. : #24
Code Stack :
Close #24
Video (mandatory)

NAVBAR
before :
the image was making the page un responsive

after:
i have fixed the placement of the image to maintain responsiveness

FOOTER
before:
the footer was not responsive

i made the footer responsive:

video
the video size is too big i don't think video is required for this enhancement images are enough still if you require it let me know i will try to add it too 🫡.
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md if its a new page/tech stack
[x] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?
yes

[x] I'm a GSSOC-EXT contributor
[x] I'm a HACKTOBERFEST contributor

I can see that you only changed 4 lines of code for responsive. other changed code just changed single quote to double. also their is no spacing between logo and title.

okay i will add space in logos and image

@AyushSharma72 Why did you close your pull request?


Tag editing

Add, remove, and create new tags manually.

Though I know you are working on this as a milestone, this one feature is something a lot of people need to have. For those who buy and sell prints it would be best to be able to look up via special tags. For example if someone is looking for a half blood orc all they have to do is search the tag and all those files show up through different creators.
This one thing would get a lot of people to download and use this

Thanks! Good to know what people need first :)

🎉 The ability to add/remove/edit tags is now a released feature 🎉


Remove 'Vo' from model names

To keep model names more self-explanatory, we must remove 'Vo' in the names. The model names must be renamed as follows

[ ] PolicyVo -> Policy
[ ] ServiceDetailVo -> DeployedServiceDetails
[ ] ServiceVo -> DeployedService
[ ] VendorHostedServiceDetailsVo -> VendorHostedDeployedServiceDetails

let me do it


Rf/extract conditional header validation

Dependent on https://github.com/scality/Arsenal/pull/295

end to end here: http://ci.ironmann.io/gh/scality/Integration/13996

end-to-end passed


feat(sqlite): SQLite Module for Hermes

Description
Add integration test for Hermes SQLite module for running on WASM runner.
Related Issue(s)
Closes #246
Description of Changes

Added integration test for the SQLite module in both functional tests and benchmarks
Added internal state for SQLite module. Without this, will cause error during WASM runtime

Please confirm the following checks

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream module

Seems it's time add a generalised object which will maintain wasmtime::Resources. So this abstraction will be used in both crypto and sqllite runtime extensions. It could be something like:
trait ResourceAllocation {
   fn allocate<T>(params: T) -> Self {
    }
}

trait ResourceDeallocation {
   fn deallocate<T>(params: T) -> Self {
    }
}

struct ResourceManager<T> {
  apps_state: DashMap<HermesAppName, DashMap<u32, wasmtime::Resources<T>>>,
}

Generalizing this is a great idea, but it might be a bit out of scope at the moment. Once the module is stable, we can revisit the idea of creating traits and structs for internal generalization with a dedicated ticket.


fast place + legit scaffold = crash

it happens on badlion and lunar as well. only fast place works great but when you conbine them, minecraft crashes

its because of legit scaffold!


Add OpenAI starter sample

Purpose
Add OpenAI starter sample
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@saragluna , please help take a look, thanks.

@Netyyyy FYI this link to you if needed.


Plugins planned

plugins planned (new or migrate from Ivory):

[x] Authentication (replaces BasicAuth by @sagikazarmark)
[x] Cookie (#35, migrate)
[x] History (migrate)
[x] Logger (migrate)
[x] Redirect (migrate)
[x] Retry (migrate)
[ ] Tape Recorder (PHP-VCR like by @jeromegamez, see #4)
[x] Stopwatch (migrate)
[x] Convert error responses to exceptions (throw exception when status is 4xx / 5xx)
[ ] Base URI (to complete incomplete requests, see also #37)
[ ] Validator (validate http request based on protocol (1.0 / 1.1)
[ ] Sanitizer (add http request headers based on available informations, like Host header, Content-Length header, ...)
[x] Encoding : Deflate, Chunk, ... (Add header to request to say that we support compression, and decorate stream for deflate / chunk if needed)
[x] Cache (integration with doctrine / cache, psr 6 ? )

Are you okay with me implementing the Tape Recorder part :)? Unless someone else is already at it, of course!

No problem go ahead :)

@jeromegamez it's good to see you here. :smile:
No problem at all, it is your baby anyway.
I was looking at VCR. Do you think there is a possibility to join forces with them? Honestly, I never used these tools too much, just played with them. However, if they are the same, why couldn't we team up with them?
I don't insist on it, I leave this to you, but it would be good to investigate what the possibilities are.

What's the difference between history and logger?

@jeromegamez awesome! i created #4 to discuss this in its own thread.

What's the difference between history and logger?

Logger log request / response / exception to a psr/log implementation
History keep trace of http calls (request response couple) in a journal
The real distinction comes from the "couple" thing, in logger plugin there a just some events which may or may be not related, in history the trace is always with the couple

I see. Where is history data kept?

The default implementation from ivory http adapter kept data in memory (with a variable), see https://github.com/egeloen/ivory-http-adapter/blob/master/src/Event/History/Journal.php

so the history one would be a meta plugin for other tools (like a symfony toolbar integration) to extract what happened during this request?

so the history one would be a meta plugin for other tools (like a symfony toolbar integration) to extract what happened during this request?

Like a data collector thing yes

That sounds good. @dbu can it somehow be added to the HttplugBundle?

yes, HttplugBundle would be the right place for integrating the history
plugin with the symfony toolbar

Updated the list :
Compression and Chunk should be in one plugin (Encoding)
Add Cache Plugin (i have see many libraries using cache system to avoid doing to many calls to an api endpoint)

Cache is something that is experimental even in guzzle, would be nice to have. Not sure though whether we need cache if we have VCR or not.

I think they all depend on a mutual dependancy like the Formatter / Normalizer thing (which can also be used in the Log plugin), so we can serialize a http request in another format. But despite from that workflow and usage is not the same.

cache sounds like a great idea. and while vcr is similar, its not the
same. cache should likely respect the cache header instructions. vcr
should unconditionally cache.

VCR even doesn't cache. In VCR's domain, I'm asking you: what is a cache? Has this something to do with those hipster people strolling through the woods searching for treasures? I just know cassettes, racks and my recorder :innocent:

But seriously, I also think that the VCR shouldn't be more than that: the notion pf a TTL would already be oit of scope.

absolutely. however, the mechanics of restoring a response matching some
request from a file is the same as a cache. there might be potential to
share code.

@jeromegamez you probably spent more time with this than me, so I guess you know better, it was just an idea.
However this raises a question: VCR has a storage layer, doesn't it?
I agree, that caching is something else.

Plugins repo is probably on the right way. I think we should not finish all the plugins prior to the stable release. Partly because some components (like caching and formatter) require more planning/duscussion, partly because I don't want to hurry just because stable release, partly because we have other work to do: polishing discovery, message factory, documentation, not to mention the packages used by plugins (authentication, cookie).
We probably have enough plugins implemented for the stable release. There are a few "would be nice to have"s, like Base URI, Sanitizer, Encoding, but I think none of them is requirement.
This repo should also be reviewed. I've already found minor CS errors, I will provide a PR for those.
@joelwurtz @dbu what's the situation with plugin docs? Have anybody written any docs?

agree that we should not wait for having lots of plugins implemented for
a 1.0. but we need to see the architectural approach works.
regarding docs: there is only the reminder issue
https://github.com/php-http/documentation/issues/15 . joel, can you
write some documentation for that and i review that? once we have the
general stuff and the already existing plugins documented, it should
also be easier to add doc about each plugin as we add it to the system.

Will try to begin some documentation on this tomorrow will do that directly on a branch so you can edit yourself

Ok to remove the Timer / Formatter Plugin, they were not plugin in ivory http adapter, just class to add information on the Logger / Journal Plugin

sounds right.

I think with the two plugins already in PR, next work will be on the BaseUri plugin and History plugin, after that we can safely release a first / alpha version of plugin-client (BaseUri is the most needed one i think)

Agree. I would concentrate on BaseURI and cleaning up/proofreading existing code. History plugin can wait I think.

does a base uri plugin make sense? i thought we discussed that its not
possible to create messages without a valid uri? or was this plugin
about synchronizing domain in uri and HOST header?

Hm, I remember something about this discussion, but I can't recall where we discussed it.
Also, host is only required for 1.1

BaseUri can also be used when you want to add a Prefix for a client,
Like an API which may be accesible under the /api path or not

okay. not a blocker for 1.0 then but makes sense.

Hello, guys. Is there any chance to get such plugins?

OAuth v2 authentication. I think its purpose is obvious.
Page iterator. Sometimes we need to iterate through several pages, returned by API, to get full collection. So, if we call some API returning the objects collection with pagination (using X-Pagination-* headers), with this plugin we could collect all the pages and return the whole response array to the application.

OAuth v2 authentication

Absolutely, but shouldn't it be an authentication component instead?
https://github.com/php-http/authentication

Page iterator

I would turn it upside down. Since you actually need the iterator, not the client itself, I would use Pagerfanta with a custom adapter. Although I don't think such a plugin/adapter is easy: you need insights about the content, it's format, etc which doesn't seem to be a responsibility of the HTTP part of your code.

Absolutely, but shouldn't it be an authentication component instead?

Yes, I think, it's better to make it inside Authentication. So, you are planning to implement this soon? It is worth to be included in plugins TODO list then.

which doesn't seem to be a responsibility of the HTTP part of your code

You're right, will think about additional utility for this.

@RomeroMsk There’s now Bearer support in php-http/message. Is that sufficient for your needs?

@ddeboer, not it's not enough. Adding the bearer header to request is not a big problem. We need to fetch the token from auth endpoint first and refetch it in case of 401 HTTP Status.

@ddeboer, not it's not enough. Adding the bearer header to request is not a big problem. We need to fetch the token from auth endpoint first and refetch it in case of 401 HTTP Status.

How you fetch and refresh a token is very specific to the API. I think it is hard to try to standardize in a http client/plugin.

How you fetch and refresh a token is very specific to the API. I think it is hard to try to standardize in a http client/plugin.

No, OAuth v2 - is standard. Token is fetching by HTTP request with strictly defined parameters. So it can be standardized in plugin.

You’re right, @RomeroMsk. Do you have time to work on an OAuth2 plugin?

Yes, OAuth v2 is standard. But the implementation of it differ.
Example with a few I've worked with.

Vendor
Description

LinkedIn
They have no refresh functionality, you simply have to reauthenticate. Uses POST request to get token. Uses a grant_type parameter.

Facebook
Does not have a refresh, Uses GET request to get token.

HH.ru
Using a POST request to get and refresh the token. Uses a grant_type parameter.

Superjob.ru
Using a GET request to get and refresh the token

Refresh token is optional.
grant_type is standard.

We could have a look at https://github.com/commerceguys/guzzle-oauth2-plugin for inspiration.

Do you have time to work on an OAuth2 plugin?

Sorry, have no time to work on it now.

We could have a look at https://github.com/commerceguys/guzzle-oauth2-plugin for inspiration.

Or at this: https://github.com/thephpleague/oauth2-client

Agreed on integration with the phpleague component, as that’s the direction commerceguys seems to take as well.
@sagikazarmark Do we need a separate plugin or only a php-http/message Authentication component?

Hard question, which I am trying to answer for some time. I think the problem is that we can't authenticate and send the original request in one request, which means we need to start at least one new request, which means we need a separate plugin for this.
Another solution would be some kind of Authentication interface which allows doing some extra logic apart from authenticating the request itself.
About league oauth: it looks promising. It would allow us to implement an Authentication method in a nice way. However it uses guzzle 6 internally, which itself is not a problem, but then (at least for now) Guzzle 6 would be a requirement to use our OAuth authentication method. We could probably ask them if they want to use httplug in the future.

I think the problem is that we can't authenticate and send the original request in one request, which means we need to start at least one new request, which means we need a separate plugin for this.

True, but the request would be sent by thephpleague/oauth2-client, so either through Guzzle 6 (currently) or later through HTTPlug. As long as our plugin acts on the correct headers (so doesn’t act on OAuth  authentication requests), we’re good.

OK, let's do this. Having it as an authentication method is nicer than having a separate plugin for it.

Ok, so add it to message and see how far we get?

Yup.
Do we need at least an authorization code? In most cases we can't confirm access on an authorization page, can we?

I think oauth2 will be better integrated with an Oauth2Client implementing HttpClient / HttpAsyncClient and decorating an HttpClient / HttpAsyncClient with the PluginClient for the AuthenticationPlugin
WDYT ?

Why? I think with the plugin system we wanted to avoid such decorations whenever possible.
Also, if we plan to use league oauth, a client wrapper seems to be an overkill.

Because Oauth2 is not something which change the request / workflow behavior and is more a standard around http.

Because Oauth2 is not something which change the request

This is not true, it changes the requests (adds the token).

It will do multiple calls

That's true, but this is why there is a $first callback, isn't it?

Also, if we plan to use league oauth, a client wrapper seems to be an overkill.

What about this one?

Closing this, as i think Sanitizer plugin is not useful (separated into other plugins, with the ContentLengthPlugin as an example)
and validator plugin not really a indispensable one, as it does not make sens to have this a runtime IMO

Regarding the TapeRecorder plugin (PHP-VCR alike), I did an implementation some time ago. The public API is a big wacky and it need some documentation, but, here you go : https://github.com/eleven-labs/http-replay-plugin


Option to remove basics from card pool

In some game mode (e.g. Housman, Solomon...), keeping basics when drafting from standard sets doesn't make a lot of sense and feels bad when drafting. They are automatically omitted when possible, but not when the set has some other possible lands in its land slot.
Add an option (enabled by default?) in their respective dialog to remove basics from the card pool after it has been generated. Generate more packs (by reducing their expected size by one) to make sure we generate enough cards.

@Senryoku are you taking contributions? I think I could work on this. Thanks for all the great work!

@Senryoku are you taking contributions? I think I could work on this. Thanks for all the great work!

I do, thanks for asking!
In this case I merely opened this issue as a note to myself because I couldn't tackle it immediately. It shouldn't take me too long to implement once I have time to work on it, but feel free to look around if you're interested :)

Sounds good, I'll poke around

I think I've got it working locally for Solomon draft. For which draft modes did you want this option? I expect at least these:

Solomon
Winston
Winchester
Housman
Grid

I don't have a list, but yours looks good!


Modal: size="fullscreen" sticks to left

Bug Report
Steps

Go to https://react.semantic-ui.com/modules/modal/#variations-size
Click on "Fullscreen"

Expected Result
Expected popup to be centered

Actual Result
Popup sticks to left border

Version
v0.84.0
Testcase
Please see https://react.semantic-ui.com/modules/modal/#variations-size

WebInspector shows left: 0!important; property for .ui.fullscreen.modal which seems to cause the issue

https://github.com/Semantic-Org/Semantic-UI-React/issues/3289#issuecomment-440224606
We should temporary switch our docs to semantic-ui package.

@layershifter I think this one is fixed in https://github.com/Semantic-Org/Semantic-UI/commit/36d5857eaba7e6a51ca522521f8505f5c343405c

has this issue been fixed? i'm new to open source and i will like to take this as my first issue

Just a reminder. The issue is still present in semantic-ui-react 0.86.0, because it uses semantic-ui-css 2.4.1
Thought it was fixed as the issue is closed and PR merged.

This is still an issue in semantic-ui-react 0.88. @layershifter should this issue be re-opened?


Drop language lookups

vscode already provides language identification. this pr removes internal language lookup to rely on vscode instead.

Sorry I missed this PR when it was first opened
Not sure I follow the proposal. We need to re-implement syntax highlighting using shiki as this isn't provided by VS Code. I don't think shiki can call into VS Code's language mappings either
Can you explain the issue this is trying to solve?


[ViacomCBS] [XBOX] Clear preroll period to first encrypted content period failure.

Have you read the FAQ and checked for duplicate open issues?
Yes completely.
What version of Shaka Player are you using?
Tested Master branch,  2.5.14, 2.5.10, 2.4.7, 2.3.10 and 2.2.10 All of which had the exact same result. Could not get out of clear pre roll to content protected period.
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Demo raw simple setup. Page urls included in support email with content and la urls.
If custom app, can you reproduce the issue using our demo app?
yes
What browser and OS are you using?
XBOX Win/10 Spartan (2014–2019 Edge) non chromium build of edge which is what XBOX dev offers at this time.
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Sandbox ID: XDKS.1
OS version: 10.0.19041.3068 (rs_xbox_release_2006.200610-0000)
OS edition: June 2020
Xbox Live device ID: FD00A956242E1869
Console ID: 74f233ae.f9265a03.c4fee763.851eb008.01
Serial number:<PHONE_NUMBER>16
Console type: Xbox One S
Model: 1681
Devkit type: Universal Windows App Devkit

Sandbox ID: XDKS.1
OS version: 10.0.19041.3068 (rs_xbox_release_2006.200610-0000)
OS edition: June 2020
Console ID: A7DCC4D8.6B218CCF.694B68FC.0D3DB308.01
Model: 1681
Console type: Xbox One S
Devkit type: Universal Windows App Devkit

Sandbox ID: XDKS.1
OS version: 10.0.19041.3068 (rs_xbox_release_2006.200610-0000)
OS edition: June 2020
Xbox Live device ID: FD00812AA7534FE0
Console ID: 4c279407.7e461c98.d56bb52f.dfb64007.01
Serial number:<PHONE_NUMBER>17
Console type: Xbox One X
Devkit type: Universal Windows App Devkit

What are the manifest and license server URIs?
Same as this ticket https://github.com/google/shaka-player/issues/2620
Sent over on<EMAIL_ADDRESS>What did you do?
Play from 0 start time and let preroll finish, on the first transition to a content period player stalls.
Non zero test are interesting.
If you skip the pre-roll with a non zero start time, all mid-roll DAI period transition thereafter works as expected.
What did you expect to happen?
The first content period initializes and plays out.
What actually happened?
The content period fails to init and play properly.

XBOX it is failing 100% on all boxes. We tested many versions and all fail exactly the same way.
I tried to apply some of your Tizen fixs I saw in master for Edge as well to just test on XBOX. For instance this block
// on one of these platforms.  Instead, default stallSkip to 0 to force the
// stall detector to pause and play instead.
if (shaka.util.Platform.isWebOS() ||
shaka.util.Platform.isTizen() ||
shaka.util.Platform.isEdge() ||
shaka.util.Platform.isChromecast()) {
streaming.stallSkip = 0;
}
and the Endianness changes I did for comcast just to test..... All of which made no difference for XBOX.

Here is an image from xbox, much like the other samsung issue

We had to devs test on two of the mentioned XB1 above and here are the logs.
xbox_shaka_2514.txt
2.5.14-xbox.txt

If the ad periods are inserted at a segment boundary without modifying/splitting any of the segments
Confirmed with our All Access team DAI does not modify any encrypted content segments at all.

I am seeing the same issue with our streams, when there is unencrypted preroll before encrypted content. This only happens on Edge with PlayReady and Xbox One.
Anything I can try or provide to help with this issue?

Hi everyone,
Sorry for the long delay with no updates.
We still don't have any bright ideas for how to debug this or what might be causing it.  Our best guess is that something specific to DAI triggers a bug in the XBox or its browser or its PlayReady implementation, but we have no way to test that idea or dig deeper at the moment.
It would be ideal if Microsoft could debug this somehow, since they would have access to information from the browser and OS that we could never see.

Thanks @joeyparrish. I am talking to Microsoft about it, so will let you know if anything useful comes out of that.

Microsoft are saying that this is a limitation on their side. They determinate the decoding pipeline method by first appended fragment to each source buffer. So if a stream starts with an unencrypted fragments (pre-roll advert for example) all encrypted content after after the unencrypted part won't be decoded correctly. But no errors throw, just green screen and no audio...
The way we are fixing this in our fork is that we find an init fragment of an encrypted period and when the stream starts from an unencrypted period, we append the encrypted init fragment first, then the straight after that the correct unencrypted init fragment and as usual. This fixes the problem, but obviously it is a bit unusual solution.
@joeyparrish  Please let me know if you are interested in a PR with this or if you'd rather stay away from this :)

Yes, please send a PR!  With appropriate comments, I'm sure there's a relatively clean way to make it work.

@davidbohunek David great info and news! We can test our content as well once PR is up.  Thanks for sharing.

@davidbohunek Hi, hope you are well? Wondering if there was ever a PR for this or just a fix in your fork.  Wondering If I could scope the change and try to test it with our content.

Looks like I duplicated this issue here https://github.com/google/shaka-player/issues/2974
Sorry. I was searching for hours and didn't find anything.
In our case though, it's working fine on Tizens but we have something similar in roughly 50% playbacks on LG webOS.
@davidbohunek if you don't have the time to PR this fix, do you mind if someone else does? We're not using our own fork of shaka-player and would prefer not to have to start now 🙂

Am seeing the same issue with Tizen 3.0/2017/Widevine. When there is an ad before drm content, decoding is bad. Tizen 2018 and up looks ok.
Looking into shaka player code, seems like streaming_engine.js goes like this:
start
	initStreams_
		scheduleUpdate_
			onUpdate_
				update_
					fetchAndAppend_
						initSourceBuffer_
                                                       mediaSourceEngine.appendBuffer

So it seems fetchAndAppend_ or initSourceBuffer_
is where the fix can be applied.
@joeyparrish any idea how to check if a segment is encrypted?
Also when I load a stream that has a pre-roll ad, and don't play it at all,  I can see that all variants in this.manifest_ have drmInfo meaning they are encrypted. Are these variants somehow normalized across the entire stream? because if it loaded just variants from the first unencrypted/ad period, drmInfos should be empty?

One other solution that comes to mind for VOD without the need to alter shaka-player is that if CuePoint start/end times are known, setup a listener for the encrypted event on the video element and pick a random time where the stream in encrypted as the start time when loading the stream player.load(contentUrl, timestampWhereStreamEncrypted)
and when the encrypted event is raised meaning that the decoding pipeline is correctly set, just revert back to the regular start time with
videoElement.currentTime = realStartupTime
This should all happen reasonably fast so the user would not notice.

This workaround works, but listener for returning to the proper position needs to be set-up on the first timeupdate event.

Happy New Year! Just checking in if there any ideas here?  I could do some dev and testing but a bit lost where to start and was hoping on having @davidbohunek PR for reference or use.
We are starting to see this being escalated on Samsung as well as Xbox

@dsparacio, I'm consulting with an expert internally on how we could work around this in the player.  In short, I would guess that it should be feasible to modify a clear init segment in memory to indicate encryption.  If the player is configured for encrypted content, and the init segment doesn't indicate encryption, and it's a platform that we know has this issue, we would modify it before appending it.
We're going to work out what whether this is feasible and what it would take to implement.  If it's feasible, and not too complicated, we could manually test the change on Tizen and XBox, and if we're successful, ship the fix in our next release.
Your next question is probably "when's you next release?"  We're not on a fixed schedule at this time, but this is a big enough issue that I would start the release process right away, even if there's nothing else to cherry-pick for that release.

@joeyparrish Great info as always! Thanks for the update. We can test this in any branch and help out where needed. We have a failing Samsung model and XB on hand. Let me know I'll stay tuned.

@joeyparrish Great info as always! Thanks for the update. We can test this in any branch and help out where needed. We have a failing Samsung model and XB on hand. Let me know I'll stay tuned.

Good news and bad news.  The good news is that there is a workaround in review right now.  The bad news is that our Xbox One has died, so we have no way to confirm it there.
We will confirm the workaround on Tizen 3.0 using the content provided by @dsparacio, though, and then hopefully someone else can confirm on Xbox before we cherry-pick the workaround into a release.

Your content appears to play on our Tizen device both with and without the fix, so our device must not be one of the ones affected.  I tried in both a PlayReady-only config and a Widevine-only config.

Your content appears to play on our Tizen device both with and without the fix, so our device must not be one of the ones affected.  I tried in both a PlayReady-only config and a Widevine-only config.

@dsparacio, the workaround is now on the master branch.  Please take a look when you have time!

@dsparacio, the workaround is now on the master branch.  Please take a look when you have time!

@joeyparrish We schedule this testing for monday.  Get back to you soon with results

@joeyparrish We schedule this testing for monday.  Get back to you soon with results

Excellent.  Thanks!

Excellent.  Thanks!

I'm cherry-picking this to v3.0.x and doing another test pass, in preparation for v3.0.8.  If everything looks good here, I'll push to v3.0.x.  If your tests are not successful, I can still revert the commit before we push the release.  Thanks!

I'm cherry-picking this to v3.0.x and doing another test pass, in preparation for v3.0.8.  If everything looks good here, I'll push to v3.0.x.  If your tests are not successful, I can still revert the commit before we push the release.  Thanks!

@joeyparrish pulling now and building sending to our QA.  get back to you with any question/ results asap.  If this works and goes into 3.0.8 we may just pick that up instead of 3.0.7 which we just picked for this sprint.  All depends on outcome and timelines.   Talk to you soon

@joeyparrish pulling now and building sending to our QA.  get back to you with any question/ results asap.  If this works and goes into 3.0.8 we may just pick that up instead of 3.0.7 which we just picked for this sprint.  All depends on outcome and timelines.   Talk to you soon

@joeyparrish on change on the one Samsung we have that has this issue.  Still gets to Enc periods and green screen.
XB1,  we are getting dash manifest parse errors now and cannot get to to log lines for Fake Encryption steps.  I will have our lead QA jump on here and add logs.  I am hoping the XB1, the main focus here, is just a XML issue and the DRM part will work once we clear that up.

@joeyparrish on change on the one Samsung we have that has this issue.  Still gets to Enc periods and green screen.
XB1,  we are getting dash manifest parse errors now and cannot get to to log lines for Fake Encryption steps.  I will have our lead QA jump on here and add logs.  I am hoping the XB1, the main focus here, is just a XML issue and the DRM part will work once we clear that up.

3.0.7 Logs from Xbox:
shaka_xbox.txt

3.0.7 Logs from Xbox:
shaka_xbox.txt

As Dan mentioned I am getting Invalid XML issue regardless of if I try drm protected or drm-less .mpd.
"Fatal media error, no option for recovery : DASH_INVALID_XML / 4001",

As Dan mentioned I am getting Invalid XML issue regardless of if I try drm protected or drm-less .mpd.
"Fatal media error, no option for recovery : DASH_INVALID_XML / 4001",

getting the same error on our app, dash_parser, parseManifest_  , shaka.util.XmlUtils.parseXml fails,
try {
      const string = shaka.util.StringUtils.fromUTF8(data);
      return shaka.util.XmlUtils.parseXmlString(string, expectedRootElemName);
    } catch (exception) {
      return null;
    }
    ```
'Text Decoder' is not defined exception

getting the same error on our app, dash_parser, parseManifest_  , shaka.util.XmlUtils.parseXml fails,
try {
      const string = shaka.util.StringUtils.fromUTF8(data);
      return shaka.util.XmlUtils.parseXmlString(string, expectedRootElemName);
    } catch (exception) {
      return null;
    }
    ```
'Text Decoder' is not defined exception

With the URL in the log, playing in ChromeOS, I don't see an XML parsing error.
@bcupac, thank you for mentioning this!  If you are using the master branch, you will need a TextDecoder polyfill for Xbox.  We suggest https://www.npmjs.com/package/fastestsmallesttextencoderdecoder  This is not needed for the v3.0.x branch or v3.0 releases, but will be needed in v3.1+.
Now that I look again at the logs from @agajassi, I see that the version number is reported as v3.0.7-master-22-g49d611f6, so y'all must have made the same mistake.
You can try again with a polyfill added for TextDecoder, or you can try building from the v3.0.x branch instead.

With the URL in the log, playing in ChromeOS, I don't see an XML parsing error.
@bcupac, thank you for mentioning this!  If you are using the master branch, you will need a TextDecoder polyfill for Xbox.  We suggest https://www.npmjs.com/package/fastestsmallesttextencoderdecoder  This is not needed for the v3.0.x branch or v3.0 releases, but will be needed in v3.1+.
Now that I look again at the logs from @agajassi, I see that the version number is reported as v3.0.7-master-22-g49d611f6, so y'all must have made the same mistake.
You can try again with a polyfill added for TextDecoder, or you can try building from the v3.0.x branch instead.

@joeyparrish we are loading the polyfill in page now and testing again.  Standby

@joeyparrish we are loading the polyfill in page now and testing again.  Standby

@joeyparrish
Getting same 4001 XML Error even with TextDecoder polyfill added to the page.

@joeyparrish
Getting same 4001 XML Error even with TextDecoder polyfill added to the page.

@joeyparrish
We tried Shaka version: v3.0.7-20-g66cdd44e-debug on Xbox. The one that does not require polyfill.
Got this error:
MEDIA_SOURCE_OPERATION_FAILED 3014 number. A MediaSource operation failed. error.data[0] is a MediaError code from the video element.
Full logs:
shaka_logs_new.txt

@joeyparrish
We tried Shaka version: v3.0.7-20-g66cdd44e-debug on Xbox. The one that does not require polyfill.
Got this error:
MEDIA_SOURCE_OPERATION_FAILED 3014 number. A MediaSource operation failed. error.data[0] is a MediaError code from the video element.
Full logs:
shaka_logs_new.txt

I built 3.0.x that resulted in v3.0.7-20-g66cdd44e-debug in logs.  @joeyparrish Does all this look correct from your perspective?  Does this log help at all. Let us know if you need us to collect or debug anything specifically.

I built 3.0.x that resulted in v3.0.7-20-g66cdd44e-debug in logs.  @joeyparrish Does all this look correct from your perspective?  Does this log help at all. Let us know if you need us to collect or debug anything specifically.

Thank you for the logs.  I wish I could see what the MediaSource error was in error.data[0], but it doesn't appear to get logged.  Is that something you can log for us?
I'm not sure what to do next.  I think it's best if I revert the change in v3.0.x until we have this sorted out, and go ahead with the v3.0.8 release without this change.
I've started trying to replace our Xbox so we can deal with this in a more hands-on way, but apparently the original XB1 consoles are not being made or serviced, and the new ones are out of stock almost everywhere because of supply chain issues and import quarantines.

Thank you for the logs.  I wish I could see what the MediaSource error was in error.data[0], but it doesn't appear to get logged.  Is that something you can log for us?
I'm not sure what to do next.  I think it's best if I revert the change in v3.0.x until we have this sorted out, and go ahead with the v3.0.8 release without this change.
I've started trying to replace our Xbox so we can deal with this in a more hands-on way, but apparently the original XB1 consoles are not being made or serviced, and the new ones are out of stock almost everywhere because of supply chain issues and import quarantines.

@joeyparrish if I can arrange an xbox to loan you for a few weeks would that help?

@joeyparrish if I can arrange an xbox to loan you for a few weeks would that help?

I managed to find a used one that could be shipped to me by the end of the week.  But thank you for the offer!
It will take some time to get set up for anything more useful than opening the browser, but I'll try to set up Visual Studio and dev mode soon.

I managed to find a used one that could be shipped to me by the end of the week.  But thank you for the offer!
It will take some time to get set up for anything more useful than opening the browser, but I'll try to set up Visual Studio and dev mode soon.

I have a hacky way to manually connect the Xbox to the Shaka automated tests.  I found, to my disappointment, that the built-in browser doesn't seem to have PlayReady enabled.  But I was able to build a UWP app with WebView and add a capability to the manifest to enable PlayReady there.  Through that, I can run our automated tests and get console logs.  But it's painful.  I don't have time to build this all the way into our test lab with https://github.com/google/generic-webdriver-server yet, but I've got most of the pieces in place and it's good enough to allow me to do some basic debugging on the device.
I'm about out of time for today, but I may be able to get some useful info tomorrow.
That said, I think I still need to revert the workaround in the v3.0.x branch and get v3.0.8 out the door.  I meant to have it done sooner.  There are other fixes that need to be in an official release ASAP.

My dev mode Xbox One refuses to play your content with my workaround, and the MS error code attached to the failure is 0x80004005, which seems to translate simply to E_FAIL.  Not too helpful.  :-)
But with the workaround disabled, it at least begins playback.  So that means if I can figure out what is wrong with the manipulated init segments, I should get immediate feedback.

Hey @joeyparrish , sorry if you already took this into account.  You mentioned your Xbox1 is in DevMode.  For DevMode you need to set you PR license to SL150.

@riksagar, I'm not in control of the PR licenses coming from CBS's license service, but they seem to be fine in that regard.
Flipping the order of "encv"/"enca" and "avc1"/"mp4a" boxes seems to make my Xbox happy, although Chrome doesn't like it.  Since this is a platform-specific workaround, that might not matter in the long run.  However, I found that even with the workarounds disabled, the sample content sent to me by @dsparacio seems to play anyway.
So, it's possible that my Xbox simply doesn't exhibit the problem to begin with.  @dsparacio, @agajassi, please try this small edit to the master branch in lib/media/content_workarounds.js to see if it helps:
-    const sourceBoxEnd = sourceBox.start + sourceBox.size;
+    const sourceBoxEnd = sourceBox.start;

For me, it at least fixes the E_FAIL error I saw before, but since I can't seem to reproduce the blocky-green artifacts of a failed decrypt either way, you'll have to let me know what that small change does for your devices.

Thanks @joeyparrish  Will try in AM

@joeyparrish @dsparacio
This issue is also reproducible for our streams when using Chromium Edge or old Edge with PlayReady or Windows 10 UWP which is basically old Edge.

Tested windows 10 uwp, Xbox and chromium edge With this change.
-    const sourceBoxEnd = sourceBox.start + sourceBox.size;
+    const sourceBoxEnd = sourceBox.start;```

Stream works OK in windows10 UWP and Xbox, but throws 3014 error on chromium edge.

with using old
const sourceBoxEnd = sourceBox.start + sourceBox.size on chromium edge, no 3014 error but still has decoding green artifacts

Stream works OK in windows10 UWP and Xbox, but throws 3014 error on chromium edge.

This workaround won't be applied on Chromium Edge, only on Xbox One and Tizen.
I'm glad to hear this fixes it for you on Xbox.  I'll get this rolled into the next release.

The existing workaround works on Tizen, but not Xbox One, and the modified workaround works on Xbox One, but not Tizen.  So the next change to the code will have to be to make it platform-specific which order these boxes go in.
I've verified that with the new forthcoming workaround and the current platform rules for applying it (Xbox One & Tizen only), the content from CBS plays through at least 90s (preroll, one content period, midroll) for me on:

Chrome 88 on Windows 10 (workaround skipped)
Chromium-based Edge 88 on Windows 10 (workaround skipped)
Xbox One firmware 19041.5496 (November 2020) in UWP WebView (Legacy Edge 18) (workaround applied, encv box first)

In earlier test, these were also working:

Tizen 3 w/ PlayReady config (init segment workaround applied, avc1 box first)
Tizen 3 w/ Widevine config (init segment workaround applied, avc1 box first)

However, I can't reconfirm those, as our Tizen test infra seems to be broken at the moment.  I can't load any external assets for some reason, and it complains about cross-origin access in spite of everything having explicit CORS headers allowing access.  Not sure if it was broken by a TV firmware update or what, but the test infra itself hasn't changed.

@joeyparrish
This is Agajan. I work with @dsparacio. I just tried your recent changes in v3.0.8-master and wanted to confirm that the underlying issue works on Xbox. Thank you for your help addressing this.

We're very happy that we could address it at all.  The change went out in the official v3.0.8 release, in case you want to stay on the release branch.  Thanks for your feedback and for helping verify the work!

@joeyparrish much appreciated.  Thanks for sticking with this one!

Xbox One will soon become an officially-supported platform.  If anyone is interested to see how, check out this PR for our new test infrastructure tools for Xbox: https://github.com/google/generic-webdriver-server/pull/12

@dsparacio Do you know if this problem is exclusive to Xbox One or also happens in the Xbox Series S|X? I see that @joeyparrish 's code only applies to Xbox One.

@av

@avelad not that far with new Xbox so not sure. It does happen on a certain Samsung versions.

The workaround is applied based on the UA string, so it's possible that it's too narrowly-targeted.
For what it's worth, I developed the workaround on a refurbished Xbox One X model.  There, the workaround appeared to be unnecessary, but not harmful.  I expect that excluding it from Series X and Series S models will be okay.  If I'm wrong, it's a ~1-line fix.


jax.random.randint() fails when minval/maxval are traced, but aren't arrays.

Description
When using jax.random.randint() under nested vmaps and scans, the (non-array) minval and maxval can become traced.
Unfortunately, this causes a failure when np.shape() attempts to convert the value to an array to get a shape.
...
File "/home/michael/.local/lib/python3.10/site-packages/jax/_src/random.py", line 458, in _randint
    _check_shape("randint", shape, np.shape(minval), np.shape(maxval))
  File "/home/michael/.local/lib/python3.10/site-packages/numpy/core/fromnumeric.py", line 2024, in shape
    result = asarray(a).shape
  File "/home/michael/.local/lib/python3.10/site-packages/jax/_src/core.py", line 705, in __array__
    raise TracerArrayConversionError(self)
jax.errors.TracerArrayConversionError: The numpy.ndarray conversion method __array__() was called on traced array with shape int32[]
The error occurred while tracing the function _randint at /home/michael/.local/lib/python3.10/site-packages/jax/_src/random.py:456 for jit.

This originates from the check in _randint.
@partial(jit, static_argnums=(1, 4))
def _randint(key, shape, minval, maxval, dtype) -> Array:
  _check_shape("randint", shape, np.shape(minval), np.shape(maxval))
  if not jnp.issubdtype(dtype, np.integer):
    raise TypeError(f"randint only accepts integer dtypes, got {dtype}")

  check_arraylike("randint", minval, maxval)
  minval = jnp.asarray(minval)
  maxval = jnp.asarray(maxval)

I suspect the fix is to re-order this so that the _check_shape() happens after the jnp.array() calls?
System info (python version, jaxlib version, accelerator, etc.)
jax:    0.4.24
jaxlib: 0.4.24
numpy:  1.26.4

List inputs are invalid for these parameters, whether the elements are traced or not. We could put the _check_shape call after check_arraylike, and then check_arraylike would give a better error. What do you think?

Hmm. My bad, I didn't notice that I was somehow passing a list in, instead of a scalar.
The better error message might be useful, but it's marginal. Closing this!


Reproducer for issue with New prefix in Go

fixes #3920

The IT test failure is expected as it reproduces the bug:
https://github.com/microsoft/kiota/actions/runs/7221853048/job/19680844961

Superseded by #3940


How to use feed_dict in MonitoredTrainingSession

Click to expand!
Issue Type
Performance
Source
source
Tensorflow Version
tf 1.15
Custom Code
Yes
OS Platform and Distribution
Ubuntu 18
Mobile device
No response
Python version
3.7
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I saw this link:https://github.com/tensorflow/tensorflow/issues/19657#issuecomment-396385448
Because tf.data.Dataset.from_tensor_slices stores the entire dataset in the TF graph, it is recommended to use placeholder and feed_dict. But I use MonitoredTrainingSession not Session, and no initialization operations can be performed after MonitoredTrainingSession , So I used scaffold to initialize the data. But an error is reported: 'GetNext() failed because the iterator has not been initialized. Ensure that you have run the initializer operation for this iterator before getting the next element.'

How to use feed_dict in MonitoredTrainingSession and initialize the data correctly?

Standalone code to reproduce the issue
from cProfile import label
from pyexpat import features
import tensorflow as tf
import numpy as np
import pandas as pd
import time
import collections
import random
datas = np.random.rand(16000000)
features = tf.placeholder(tf.float32)
feed_dict = {features:datas}
dataset = tf.data.Dataset.from_tensor_slices(features)
dataset = dataset.batch(100)
dataset = dataset.prefetch(2)
iterator = dataset.make_initializable_iterator()
next_element = iterator.get_next()
global_step = tf.train.get_or_create_global_step()
sess_config = tf.ConfigProto()
scaffold = tf.train.Scaffold(
        init_op=iterator.initializer,
        local_init_op=tf.local_variables_initializer(),
        init_feed_dict=feed_dict,
       )
stop_hook = tf.train.StopAtStepHook(last_step=1000)
hooks = []
hooks.append(stop_hook)
tm = time.time()
with tf.train.MonitoredTrainingSession(
            scaffold=scaffold,
            hooks=hooks,
            checkpoint_dir = './result/ddd',
            save_checkpoint_steps=1000,
            summary_dir= None,
            save_summaries_steps=1000,
            config=sess_config) as sess:
    print(f'cost session create:{time.time() - tm:.8f}s')
    t2 = time.time()
    # sess.run(iterator.initializer,feed_dict={data: tuple([datas]*40)})
    for i in range(1,100):
        sess.run(next_element)
    print(f'cost run time:{time.time() - t2:.8f}s')
    print('done')

Relevant log output
tensorflow.python.framework.errors_impl.FailedPreconditionError: GetNext() failed because the iterator has not been initialized. Ensure that you have run the initializer operation for this iterator before getting the next element.
         [[node IteratorGetNext (defined at /usr/local/lib/python3.6/dist-packages/tensorflow_core/python/framework/ops.py:1748) ]]

@zhanglirong1999 TF v1.x is not actively supported, please upgrade to latest TF version and refer this migration doc. Could you refer this gist in latest version and see the similar thread?
Thank you!


Spanner Auditing

fixes #1283
adds user and date auditing annotation support.
We are not supporting the CreatedBy and CreatedDate columns because Spring Data's support for those assumes the existence of hidden-from-the-user versioning columns which we do not support in this module.

Codecov Report

Merging #1454 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1454      +/-   ##
============================================
+ Coverage     69.15%   69.25%   +0.09%
- Complexity     1520     1529       +9
============================================
  Files           215      217       +2
  Lines          5898     5917      +19
  Branches        600      600
============================================
+ Hits           4079     4098      +19
  Misses         1567     1567
  Partials        252      252

Flag
Coverage Δ
Complexity Δ

#integration
?
?

#unittests
69.25% <100%> (+0.09%)
1529 <19> (+9)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...er/repository/config/SpannerAuditingRegistrar.java
100% <100%> (ø)
5 <5> (?)

...pository/support/SpannerAuditingEventListener.java
100% <100%> (ø)
2 <2> (?)

...k/cloud/gcp/data/spanner/core/SpannerTemplate.java
73.68% <100%> (+0.35%)
71 <11> (+2)
:arrow_up:

...ta/spanner/core/mapping/event/BeforeSaveEvent.java
100% <100%> (ø)
1 <1> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07529ad...c1af8ab. Read the comment docs.

@meltsufin I took a closer look how spring-data-jdbc determines if the entity was just-created.
It goes like this:

does if the entity has a @version annotated property then use that. if not, then use its ID value.
if the value is NULL then the entity was just-created
if the value is a number-like value and its value is 0 then it was just-created (so you can't use 0-value keys even if they're from existing rows in Spanner).
otherwise it's not just-created.

@meltsufin does that sound OK to you? I think we can support the created-events but it's large enough to be a little project by itself.

@ChengyuanZhao Yes, let's keep it separate.


Graph provider relationships

Context
We're working on implementing provider-to-provider permissions. We don't have a way to see what permissions exist between providers at the moment. I'm playing around with the code and data to get a better understanding of the domain.
Changes proposed in this pull request
This generates a diagram that shows the relationships and permissions that exist. It may be useful to get an idea about the relationship between providers. It's very MVP and doesn't have any tests - I'd like to see this in qa/prod first.

Guidance to review
https://apply-for-te-graph-prov-rycd5a.herokuapp.com/support/providers/relationships
Link to Trello card
https://trello.com/c/sCTl8idK/2333-review-access-controls-in-preparation-for-launch
Things to check

[X] This code doesn't rely on migrations in the same Pull Request
[X] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[X] API release notes have been updated if necessary
[X] New environment variables have been added to the Azure config

Haven't feature flagged it because it's not even linked form somewhere :)


(Uprating) Minimum wage calculator 2022

National Living Wage for those aged 23 and over will increase
from £8.91 per hour to £9.50 per hour.
National Minimum Wage will also increase:

for 21 to 22 year olds – from £8.36 per hour to £9.18
for 18 to 20 year olds – from £6.56 per hour to £6.83
for those under 18 – from £4.62 per hour to £4.81
for apprentices – from £4.30 per hour to £4.81

Accommodation offset rates will also change:

daily – from £8.36 to £8.70

https://trello.com/c/eoazcTDo/868-deploy-on-1-april-national-minimum-wage-and-living-wage-calculators

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

This has been content reviewed and fact checked. Changes were addressed in separate PRs that can be deployed before the 1 April.


unable to resolve dependency tree version 2.2.12

Description of the bug:

When following https://cdk8s.io/docs/latest/getting-started there is a error when running cdk8s init typescript-app
Reproduction Steps:

$ npm -g list | grep npm@
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
$ node -v
18.13.0

$ cdk8s --version
2.2.12

$ cdk8s init typescript-app
Initializing a project from the typescript-app template

Error Log:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/constructs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer constructs@"^10" from<EMAIL_ADDRESS>npm ERR!   node_modules/cdk8s
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/cdk8s-plus-25
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/cdk8s-plus-25
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! C:\Users\enoconan\AppData\Local\npm-cache\_logs\2023-04-09T12_08_51_408Z-eresolve-report.txt
npm ERR!     C:\Users\enoconan\AppData\Local\npm-cache\_logs\2023-04-09T12_08_51_408Z-debug-0.log

Environment:

Framework Version: 2.2.12
OS:windows 11

Other:

This is :bug: Bug Report

This looks related to #827. Another user posted a comment on how to fix this issue - can you try this suggestion and see if it solves your problem?

It looks like as a result of this the package.json is generated without any packages installed. No node_modules directory is present.
{
  "name": "cdk_test",
  "version": "1.0.0",
  "main": "main.js",
  "types": "main.ts",
  "license": "Apache-2.0",
  "private": true,
  "scripts": {
    "import": "cdk8s import",
    "synth": "cdk8s synth",
    "compile": "tsc --build",
    "watch": "tsc --build -w",
    "test": "jest",
    "build": "npm run compile && npm run test && npm run synth",
    "upgrade": "npm i cdk8s@latest cdk8s-cli@latest",
    "upgrade:next": "npm i cdk8s@next cdk8s-cli@next"
  }
}

Running npm i cdk8s@latest --save works without issue.

Closing as duplicate of https://github.com/cdk8s-team/cdk8s-cli/issues/827


Communication between OB38S003 and ESP8285

Hi,
I have an idea about handling the protocol encoding and decoding on ESP8285 chip and just transferrind the raw data of pulse lengths using uart between those two chips. I'm using esphome and there is already really good libraries for doing the encoding and decoding, but of course it would also need changes to work also with raw data coming from uart. What do you think about that? Is there something that I haven't been thinking and this is just bad idea? I can try to make some kind of pull request if you don't mind, but it may take some time as my C skills aren't very good.
By the way, thanks a lot for your hard work on this!
-Otto

Hi Otto,
I have updated the OnbrightFlasher to allow connecting to wifi so that a larger hex file can be uploaded through web browser.
So it should work to flash either the pass through mode or serial mode file in this repository.
I plan to reorganize the source code and learn more about makefiles so that all the firmware modes can be built at the same time.
I have also made progress on porting the original portisch firmware to SDCC compiler:
https://github.com/mightymos/SonOfPortisch
It should hopefully be the next step to allow this to work on the OB38S003.
I hope to have all the options built here so that people can choose.
Have you tried the OnbrightFlasher web upload option recently?
What else do you think?

Otto

I haven't tried the wifi uploader, but I have been using the python script for uploading and it works well for me.
I was thinking to add third mode that is something between pass through and serial modes. So that we don't need to use ESP8285 resources for simple operations like handling the transmission and receiving rf signals. But we could use ESP8285 resources for more demanding operations like encoding and decoding the signals as OB38S003 is somewhat limited for that. And at least for esphome there is already really good encoding and decoding options for rf signals and we could use those and transfer the raw signal data by serial. At least for transmission should work, but I don't know if it would work for receiving in noicy environment.
The idea here is that people could flash the OB38S003 just once and even if they get new devices that need new protocols they don't need to flash the OB38S003 as they are handling the signal encoding and decoding on ESP8285 chip. And I'm not sure if Portisch has support for the devices that I'm using (Nexa), but esphome has. Of course this would need changes to esphome side too.

The most straightforward thing is to use the pass through firmware and the remote receiver component in ESPHome:
https://esphome.io/components/remote_receiver.html
The project has an example YAML file for ESPHome now.
Other users here might be able to help to see if your Nexa device is supported:
https://github.com/mightymos/RF-Bridge-OB38S003/issues/8
You can also attempt to decode an unknown protocol using ESPHome dump feature.


Remove the support for profile optimization for the deprecated publisher and devportal profiles

Description
Need to remove the support for profile optimization for the deprecated publisher and devportal profiles.
Also needs to remove some config related to these profiles in registry.xml indexers and infer.json configs which will be used when starting pack with these profiles.
Affected Component
APIM
Version
4.2.0-alpha
Related Issues
No response
Suggested Labels
No response

Fixed with https://github.com/wso2/product-apim/pull/13158