Timex 3

Building upon @rmosolgo's branch, this makes Verk work with Timex v3.x. See #78.
Current objections to consider before merging:

Tests are not fully passing—test/schedule_manager_test.ex needs some work. Either the mocks need to be updated or that test should be refactored to not use mocking.
As currently constituted, this branch breaks support for Timex <3.x. I'm unsure if everyone is comfortable with that. Timex makes some significant API changes that would require some significant structural changes to be able to support both versions

Coverage decreased (-0.9%) to 81.616% when pulling 0625aa323395ce04a651fe5b067a8954d44b0b22 on karmajunkie:timex-3 into bb863812647f204a752ec7b7d097e0f470f7ec5f on edgurgel:master.

Coverage decreased (-0.9%) to 81.616% when pulling 0655fbd49c4d23229e42ca2a88a4709cf10a8ad1 on karmajunkie:timex-3 into bb863812647f204a752ec7b7d097e0f470f7ec5f on edgurgel:master.

Also I'm happy to change the tests to use less mocks! Feel free to suggest them :)

Coverage decreased (-0.9%) to 81.616% when pulling f4d3a3e03f7e52848da40197e2828d586123cf46 on karmajunkie:timex-3 into bb863812647f204a752ec7b7d097e0f470f7ec5f on edgurgel:master.

@edgurgel regarding the mocks, I would probably recommend testing against an actual Redis server. Redis is set up as a dependency in CI already, and there are other tests that depend on it so its not saving a whole lot by mocking it out.
If that's not kosher, then a config setting that specifies an alternate module can be set up, so that in test its using the alternative instead of Redix.
Something I noticed in trying to debug the failures in meck were that the docs seemed to indicate that meck's common usage pattern is to create a mock process/module (not totally clear which, though the gen_server.call failures make it seem like its a process) and set expectations against that rather than against a normal predefined module. Not sure if that has anything to do with the failures I'm seeing though.

Coverage increased (+0.2%) to 82.682% when pulling 30239e0d3ba89d0393659719a7ce87494fd2d36f on karmajunkie:timex-3 into bb863812647f204a752ec7b7d097e0f470f7ec5f on edgurgel:master.

Coverage increased (+0.2%) to 82.682% when pulling 9e342fd3899feba2cecc7aad187327ebc18b9d52 on karmajunkie:timex-3 into bb863812647f204a752ec7b7d097e0f470f7ec5f on edgurgel:master.

@edgurgel regarding the mocks, I would probably recommend testing against an actual Redis server. Redis is set up as a dependency in CI already, and there are other tests that depend on it so its not saving a whole lot by mocking it out.

The problem is that the Redis commands were tested standalone and here we would test it again against Redis :/

If that's not kosher, then a config setting that specifies an alternate module can be set up, so that in test its using the alternative instead of Redix.

That's an option but they way to configure is to use Application env right? Then you need to have 1 "Fake" module that can't be changed for specific specs (say you want them simulate a failure for same test you wrote before?).

Something I noticed in trying to debug the failures in meck were that the docs seemed to indicate that meck's common usage pattern is to create a mock process/module (not totally clear which, though the gen_server.call failures make it seem like its a process) and set expectations against that rather than against a normal predefined module. Not sure if that has anything to do with the failures I'm seeing though.

Yeah meck will have a process to catch all the calls made and compare with the expectations etc. I really want to send a PR to make it easier and how what was expected and what it was returned. I understand that it's not the best feedback right now :(
I'm checking the PR again! Hopefully we can get this through soon!
Again, thanks for sending the PR :)

The problem is that the Redis commands were tested standalone and here we would test it again against Redis :/

Maybe I'm not understanding what you're driving at, but that's what I think one would want. Redis itself is the reference implementation, and ultimately the only one that matters. If you're objecting to the notion of testing against Redis twice, then I'd suggest that its possible these tests are not wholly necessary. Testing to ensure an API was called with the arguments one thinks it should be called with is often a bit of a code smell to me, because it is very possible that an API interface changes or something else happens to make that verification incorrect, which creates brittle tests. Were I to rewrite this particular set of tests, I would go as far as verifying that the Redis sorted set contains the expected key with about the score I expect (within a 1 second delta or so) but I would probably prefer to use a client interface within Verk to test against, which remains internally consistent.

That's an option but they way to configure is to use Application env right? Then you need to have 1 "Fake" module that can't be changed for specific specs (say you want them simulate a failure for same test you wrote before?).

As I understand the usage of meck that's what it is intended to do—create a flexible substitution for a real (hardcoded) implementation. An implementation with a custom fake can also be made to be as flexible or strict as one feels appropriate. The point is not the flexibility of the fake, but breaking the coupling in the code to a specific module (dependency injection, in other words) which in this case is the reference to Redix rather than a module. I should point out though that the coupling to Application environment is arguably an antipattern itself—a better path might be to inject the dependency when the schedule manager process is started, which the test can control. So if you're going to use something like meck, inject the mock process into the ScheduleManager process for that test.  Something like this:
setup do
  fake = :meck.new(:my_redis, [:strict])
  {:ok, pid} = GenServer.start(ScheduleManager, [redis: fake], name: Verk.Redis)
  {:ok, schedule_manager: pid, redis: fake}
end

test "something", %{redis: fakeredis} do
  expect(fakeredis, :command, [Verk.Redis, [...]], {:ok, _})
  do_something(...)
end

The code above I'm sure would need some tweaks but that's the gist of what I'm talking about.

Yeah meck will have a process to catch all the calls made and compare with the expectations etc.

Yeah, I missed the detail of the parameters supplied to meck in working with the tests—just a hazard of working with a new-to-me API. I appreciate the catch and the review!
Regardless of the discussion about mocks, I think the PR as currently constituted takes into account your requested modifications, and the mocking question is probably outside the scope of this PR. Maybe worth opening another issue on it but mostly I was just looking to get a build that didn't object to the use of Timex > 3.0 in my app :) Looking forward to more feedback!

I'm really enjoying this whole discussion :)
So if I understood well the ScheduleManager would have both the "redis module" and the redis pid:
  defmodule State do
    @moduledoc false
    defstruct [:redis, :redis_pid]
  end

then inside the ScheduleManager we would call:
....(%State{ redis: redis, redis_pid: redis_pid } = state
redis.command!(redis_pid, ...)

Tell me if I didn't understand properly, please.
So my only issue with this is that we have a variable on the state that would not exist if we were writing tests right? This is what really bugs me when adding "dependency injection" for the sake of testing :/

Thank you 🎉

@edgurgel not sure where to continue the discussion re: mocking so I'm just going to put this here :)
There's probably any number of ways to structure it. My personal practice is to wrap 3rd party lib access behind a module I control, as was done with Verk.Time, so that you have a stable interface for the rest of your application to code against, and a configurable backend that you can replace not only in tests but (for example) to use an alternative such as Postgres or AWS SQS. There's a valid argument about doing too much to support possibilities in the future (YAGNI) but this is one that I have found time and again to be a very cheap hedge against the future.  Imagine that we maintain the original dependency to Timex but need to preserve compatibility with all major versions. The stable interface of Verk.Time allows us to do that across all of the application, deferring the implementation to something configured by the client—and if that client is a test, we can also configure a backing process that allows us to freeze time (which I believe was part of the purpose of setting expectations on Timex in the original code, but correct me if I'm wrong.)
I don't think it would be altogether necessary to supply a pid in State—I think you can just as easily use the :name of the server, in this case Verk.Redis.  Or simply send messages to the pid in ScheduleManager. In the above code the idea was that the module to make calls against was a dependency supplied by the supervisor, which in the case of a test would be the test itself. The mechanics of it can be fairly flexible.
I'd push back on the notion that this is only for testing purposes though. Testing elucidates good design—and that design lets you do things like replace a concrete implementation with another technology while preserving the application interface. Consider that the "best" way to go about it would probably be an API interface that is a black box, and outside that box you should not need to care about the implementation (beyond obvious issues like bad performance). Is it backed by poolboy and a bunch of processes to avoid bottlenecks? Is it backed by Redix, or a new-and-improved BEAM application with 10x throughput? Unless you're in the box, it doesn't matter. l
Hopefully that clarifies what I was getting at!


Not throwing exception (unable to retry) when configuration not found in cloud config server

Is there a possibility to throw an exception when configuration is not found in the cloud config server? Our project microservices architecture allows the situation when cloud config client is starting, but the configuration is not already passed to the cloud config server.
The problem is it actually locates some configuration (default?) so no exceptions are thrown and retry is not executed:
org.springframework.cloud.config.client.ConfigServicePropertySourceLocator.locate | Fetching config from server at: http://localhost:8089/config
org.springframework.cloud.bootstrap.config.PropertySourceBootstrapConfiguration.initialize | Located property source: CompositePropertySource [name='configService', propertySources=[MapPropertySource {name='configClient'}]]

But then the missleading error occured:
java.lang.IllegalArgumentException: Could not resolve placeholder 'key.value' in value "${key.value}"

Because config was not found in cloud config service. I want to enable retrying when configuration is not found, but the locate function from ConfigServicePropertySourceLocator.class does not throw any exceptions when config could not be found, only when connection to the server could not be established.
I had to make a workaround for this specific case and override ConfigServicePropertySourceLocator's locate function by adding check if propertySources list from Environment's result object is empty. (when using common application.properties in cloud config server it actually won't work as needed).

So do you have an application.properties file in your config repo?

Yeah, I don't think this is something we want to do. There's never been a guarantee that there is available properties for a given app. IIRC there's an open issue about validating before applying.

I understand, but isn't missing config the case which should throw an exception or at least log warning that propertySources are empty, nothing was located? In my opinion an application should fail here, not when starting other beans which refer to the missing properties. Another thing is that it doesn't allow to set retries on failure. It is only possible to set retry when a client cannot connect to the config server.

Yes, the failure of not finding a property is orthoganal to connecting to config server.
How do we know when empty of a failure? We can't

I didn't mean missing keys in .properties file, but missing .properties file. It is impossible to handle first case in generic way as You've mentioned.
Maybe response status should not be 200 on GET /{name}/{profile}/{label} but 404 when looked specific .properties file is not found (getRemoteEnvironment function).
My custom semi-hardcoded workaround, after the getRemoteEnvironment function call in locate function:
 if (!result.getPropertySources()
                            .stream()
                            .filter(ps -> Paths.get(ps.getName()).getFileName().toString().equals(propertiesName))
                            .findAny()
                            .isPresent()) {
                        String errorMessage = "Configuration not found for: " + result.getName();
                        logger.error(errorMessage);
                        throw new IllegalStateException(errorMessage);
                    }

which is caught later and thrown again in properties.isFailFast condition check (retry enabled).

I know, that will break many existing users

Closing as wontfix


Symfony debugbar problem

In version 2 , the  debugbar data don't update on Ajax navigation

Hi @jneto81,
Thanks for reporting the issue! We will do our best to fix it as soon as possible!

Any news about this ?

I'm closing this issue because it seems fixed with ORO 3.1.9.


Add diff to artifacts

This should be ready now. I tried having it make a comment on this pr, but i think with githubs permissions that will be a lot harder.

After some not too long investigation, it can be done by running a new action when a CI event has completed, which is debatable in my opinion.

Added javadocs to this


Is there any Conda or Pip package for MKL-DNN

Description
Is there any available Conda or PIP package for MKL-DNN like how we have for MKL.

There's a conda package available. I'm not aware of a pip package.

@vpirogov - Now with the release of v0.14 we could benefit from an update to that package, since it's easier for developers to install. Could this be pushed at this point?

Thanks for pointing out that the package got stale! Let me see what I can do there.

Conda package for v0.14 is published.


[MDEPLOY-255] altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c…

MDEPLOY-255 altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/cygwin on windows
Following this checklist to help us incorporate your
contribution quickly and easily:

[x ] Make sure there is a JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without
pulling in other changes.
[x ] Each commit in the pull request should have a meaningful subject line and body.
[ x] Format the pull request title like [MPH-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MPH-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
[ x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ x] Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
[ ] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[x ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[ ] In any other case, please file an Apache Individual Contributor License Agreement.

I consider this to be a workaround rather than a solution because the root caues has not been found.

@michael-o, @eolivelli,
For me it is indeed w/a, which lets me modify, compile and deploy some stuff from github to internal repo to debug the project I'm working on.
I consider it as a draft because I'm not sure it's me who have to decide if deploy plugin should get a couple (or three couples) of new parameters or there is another w/a.
I suppose the problem might be related to org.apache.maven.shared.transfer.project.deploy.ProjectDeployerRequest from maven-artifact-transfer, but I considered as overkill for me to debug this project.
he problem itself might be in incorrect storing/parsing colons and URL part of altDeploymentRepository parameter in mingw environment, because cygwin/mings might make attempts to convert unix/windows path separators:

':'<->';'
'/'<->'\'
When I pass repo id as text and url as URL plugin works fine.
I'm not sure I'm ready for writing tests right now.


Test Liveness of Touchscreen

[x] What happens when the lcd is powered on?
[x] Get example file from library running

(1 hour)

When the display is powered on, with no instructions, it simply shows a blank white screen:

Attempted to use the Adafruit CircuitPython RGB Display module. However, when I try to run the example file I get the error
OSError: /dev/spidev0.0 does not exist
I also cannot find the spidev module when I run the lsmod | grep spi even after enabling SPI using raspi-config and rebooting.
To solve this issue, I attempted to download spidev using sudo apt install python3-spidev which returns python3-spidev is already the newest version (20200602~200721-1).
I also used pip3 install spidev which returns Requirement already satisfied: spidev in /usr/lib/python3/dist-packages (3.5)
Neither resolved the issue.
I attempted to get spidev from github using the following commands:
git clone https://github.com/doceme/py-spidev.git
cd py-spidev
make
sudo make install
(which also required me to use sudo apt-get install python3-setuptools to be able to make)
This also did not resolve the issue.
I will be going into office hours on Wednesday, Thursday, and Friday to try to get SPI and the Adafruit CircuitPython RGB Display module working so that I can confirm the functionality of the display.

Attempted to use the Adafruit CircuitPython RGB Display module. However, when I try to run the example file I get the error OSError: /dev/spidev0.0 does not exist
I also cannot find the spidev module when I run the lsmod | grep spi even after enabling SPI using raspi-config and rebooting.

Since the error message indicates that the OS cannot find the SPI device, it's possible that the SPI peripheral on your Pi is broken. (For example, if you accidentally connected it to a 5V SPI bus, or if there is a soldering problem on the display header that causes a short.)
My recommendation is to first validate if this is the case:

borrow a Pi from another member of your team
put your SD card in that Pi (the activation of the SPI driver by raspi-config is on the SD card, not on the Pi, so if you have done that on your SD card then the SPI peripheral should be active when you put your SD card into a different Pi.)
try running that example code (which again, is on your SD card!). Don't even connect the display - just see if it gets past the "finding and opening the SPI device at 0,0" step, or if it raises the same error.

If it raises the same error: it's probably an OS/driver/configuration problem..
If it does not raise the error about finding the SPI 0,0 device: it's probably your Pi.
If it turns out that SPI0 on your Pi is broken, you can put your SD card back into your own Pi, and try SPI1 to see if it works.  You can enable SPI1 by adding a line to the boot config file, then rebooting the Pi, as described here.
After rebooting, check in /dev and check the output of lsmod to see if the SPI device is recognized.
If SPI1 is also not recognized, there might be more damage to the Pi than we can overcome by working around it - then we'd probably have to swap out the Pi.
Regardless: before trying to connect the display again, you should make sure you are not connecting it in a way that can damage the SPI bus it is connected to.

To solve this issue, I attempted to download spidev using sudo apt install python3-spidev which returns python3-spidev is already the newest version (20200602~200721-1). I also used pip3 install spidev which returns Requirement already satisfied: spidev in /usr/lib/python3/dist-packages (3.5) Neither resolved the issue.
I attempted to get spidev from github using the following commands: git clone https://github.com/doceme/py-spidev.git cd py-spidev make sudo make install (which also required me to use sudo apt-get install python3-setuptools to be able to make) This also did not resolve the issue.

There is no indication that the Python library is the problem - if the driver is not even loaded and the SPI0 device does not appear in /dev, that's several steps below the Python library.

After placing my sd card into Fatiha's Pi, the same error still occurred.

Using the Adafruit CircuitPython RGB Display module now I get the error
pi@raspberrypi23:~/touchscreen $ python3 display_image.py
Traceback (most recent call last):
  File "/home/pi/touchscreen/display_image.py", line 89, in <module>
    image = image.resize((scaled_width, scaled_height), Image.Resampling.BICUBIC)
  File "/usr/lib/python3/dist-packages/PIL/Image.py", line 62, in __getattr__
    raise AttributeError(f"module '{__name__}' has no attribute '{name}'")
AttributeError: module 'PIL.Image' has no attribute 'Resampling'

The output on the display looks like this:

I was successfully able to test the liveness of the touchscreen by running two example files. The output of the first example file:

The output of the second example file:

@creechelseaa please review


Add reservations to admin control subnet allocs

This adds ability to add and remove reservations
for subnet allocations. A subnet is reserved with
the host IP (PublicIP). flannel will then use this
subnet for a host requesting a subnet.
Reservations are denoted in etcd as subnets with no
expiration (TTL is zero). When a reserved subnet is
allocated, it's TTL continues to be not set. If a
reservation is removed, the TTL is set to the usual
24 hours.
Also adds corresponding client/server APIs for
reservation management.
Fixes #280

Feel good about the overall approach.

Do we have an e2e test or integration test yet?
The code LGTM.

We don't have e2e tests. That's on a todo list and it's non-trivial task as it requires setting up etcd and multiple containers or VMs for flannel daemons.


Update dependabot.yml

Update github actions using the dependabot machinery

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.382%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
316

Relevant Lines:
615

💛  - Coveralls


Make code PEP8 compliant

Code is not passing flake8, need to update so that PEP8 tests will pass.

Was applied to "develop" branch


[UPGRADE] Upgrade JMX exporter to the newest version

Describe the solution you'd like
JMX exporter needs to be upgraded to the newest version: 0.16.1

DoD checklist

[ ] Changelog updated
[ ] COMPONENTS.md updated / doesn't need to be updated
[ ] Schema updated / doesn't need to be updated
[ ] Feature has automated tests
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade

[ ] Idempotency tested
[ ] Documentation added / updated / doesn't need to be updated
[ ] All conversations in PR resolved
[ ] Solution meets requirements and is done according to design doc
[ ] Usage compliant with license
[ ] Backport tasks created / doesn't need to be backported

Spike about versions was in #2719.

:heavy_check_mark: Tested apply and upgrade from v1.0 (x86_64) and from v1.1 (aarch64).


Explore Refactor of RxObject

This ticket follows some of the recommendations that @KrisJordan thought about in #180, including refactoring RxObject to be a subclass of ReplaySubject.

@KrisJordan I am closing this issue - Angular Signals in v16+ will likely remove the need for the RxObject abstraction!


Help measure onchain usage data for Zodiac

Problem
We have no idea how to measure usage of our zodiac module
Impact
Zodiac team is seeking to goal around this
Proposed Solution
Measure using this info. Can you help point me to how?

Skeletor Spaceman, [Jul 11, 2023 at 1:38:30 PM]:
GitHub - defi-wonderland/zodiac-connext-module-factory
Contribute to defi-wonderland/zodiac-connext-module-factory development by creating an account on GitHub.
Skeletor Spaceman, [Jul 11, 2023 at 1:38:30 PM]:
address of deployed factories: https://github.com/defi-wonderland/zodiac-connext-module-factory#deployments
Alex White, [Jul 11, 2023 at 1:39:50 PM]:
ty!
Skeletor Spaceman, [Jul 11, 2023 at 1:41:35 PM]:
hmm but we don't save it on an internal mapping and we do not emit any event on the factory.
the connext module does tho: emit ModuleSetUp(owner(), avatar, target, originSender, origin, connext);
but since the owner and a few other parameters are the actual factory, you can easily filter them too :)
_connextModule = new ConnextModule{salt: _moduleSalt}(
// Hardcoded values are replaced with the correct values
// after creating the safe (owner, avatar, target, connext)
_FACTORY_ADDRESS, // Hardcoded for ownership control (owner)
_FACTORY_ADDRESS, // Hardcoded for ownership control (avatar)
_FACTORY_ADDRESS, // Hardcoded for ownership control (target)
_moduleData.originSender,
_moduleData.origin,
_FACTORY_ADDRESS // Hardcoded, factory is connext (connext)
);

stale, closing


[617] Merge Two Binary Trees

Codecov Report

Merging #48 (4ae584a) into master (7866d8a) will increase coverage by 0.8%.
The diff coverage is 100.0%.

:exclamation: Current head 4ae584a differs from pull request most recent head b17d7a7. Consider uploading reports for the commit b17d7a7 to get more accurate results

Impacted Files
Coverage Δ

src/problem/p0617_merge_two_binary_trees.rs
100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


feat: Added doc for SAML authentication.

Details:
Added steps to be followed for SAML authentication.

@ritsingh thank you for starting this.


fix(api): fixed IsImageDigest validator for non-strings

:tada: This PR is included in version 6.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added basic support for any work item field for work item cmdlets

PS Summary
Added the possibility to set any work item fields with Add-VSTeamWorkItem and Update-VSTeamWorkItem. This is solved by using a hash table parameter and adding them dynamically to the JSON body.
PR Checklist

[X] Write Help
[X] Write Unit Test
[X] Update VSTeam.psd1
[X] Update CHANGELOG.md

related to #188

Can you update the help to explain what will happen if they add description to the hashtable? I would like that in the help instead of the user having to hit the error to find out.

Yes, I will do that ASAP.

Added the comments in the "Notes" section. Tell me if that is the appropriate place or if that should be written directly attached to the parameter description.

@DarqueWarrior is the documentation you requested fine for you?


add raw data

@restrellado I made a raw and processed folder in data - would it make sense to add the CSV for tt_tweets into the processed (or the raw) data folder?

going to stop here with this one - this was to add @emilybovee's sci_mo_data in exactly the same way she did, except (per this issue) the data is synthesized via synthpop. The purpose of the package is to make it so the relationships in the data are the same, though the specific values for an individual case should be different (synthetic). My big (only) concern is that any values that we interpret may be slightly different (and, I hope not very different). @emilybovee perhaps we can look together to make sure it's right.

added the raw data and the code to process it - going to merge this


Game over camera off animation

Describe your problem here.

The camera keeps going down here and is not moving up i've been trying to figure it out using multiple methods but nothing is working :'(
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Nothing edited

Should be fixable (when 0.7.2 is out) by changing the camera offset

Thank :)


Ensure the logo text can be customised

From slack:

Hey there folks… Is it an oversight that the upper-left “STRATOS” text isn’t customizable? Here’s the line in GitHub:
https://github.com/cloudfoundry-incubator/stratos/blob/67158d9230d946783c9bf7415f697580d2eae398/src/frontend/app/features/dashboard/side-nav/side-nav.component.html#L5
…where clearly there’s precedent for theming other stuff right near there…
https://github.com/cloudfoundry-incubator/stratos/blob/67158d9230d946783c9bf7415f697580d2eae398/src/frontend/app/features/dashboard/side-nav/side-nav.component.html#L17
I don’t like the idea that I have to fork Stratos just to make a string change there…!

@nwmac can this be closed?

@KlapTrap Yes - looks like this is fixed: https://github.com/cloudfoundry-incubator/stratos/blob/v2-master/src/frontend/packages/core/src/features/dashboard/side-nav/side-nav.component.html


Method not found: Splat.IDependencyResolver Splat.Locator.get_Current() on Xamarin Forms after upgrading to version 7.2.1 from version 6.1.7

Describe the bug
After upgrading my project to use reactiveui verson 9.15.1 (from 9.9.1) splat throws this missing method exception.
Environment(please complete the following information):

Splat 7.2.1
ReactiveUI 9.15.1
Xamarin forms <IP_ADDRESS>4457
Device: Android

Hmm. Seems you have something that has a dependency on a old version of splat.

You are right, i hadn't noticed that my Bll project used splat for IOC. After updating my Bll project dependency, the missing method exception went away. Thanks for your insanely quick response.

No problem. The AOT compiler in xamarin Android is a bit finiky about that stuff


fix(CallPopUp): Enable call pop up when user is out of active call chat

What this PR does 📖
This pull request includes significant updates to the VideoPreview component in the calling module. The changes involve enhancing the video preview functionality, improving the user interface, and fixing the visibility toggle for the call screen.
Enhancements to VideoPreview functionality:

src/lib/components/calling/VideoPreview.svelte: Replaced the show variable with showVideoPreview to control the visibility of the video preview, and added logic to sort and filter users based on their audio status.
src/lib/components/calling/VideoPreview.svelte: Implemented a new attachStream function to handle the attachment of video streams to video elements.

User interface improvements:

src/lib/components/calling/VideoPreview.svelte: Updated the video preview container to use a grid layout for displaying multiple video streams, and added styles to improve the appearance and layout of video elements. [1] [2]

Visibility toggle fix:

src/lib/media/Voice.ts: Moved the callScreenVisible.set(false) statement to ensure the call screen visibility is correctly toggled when leaving a call. [1] [2]

Re-enabling the VideoPreview component:

src/routes/+layout.svelte: Re-enabled the VideoPreview component in the layout by removing the comment that was disabling it.

Special notes for QAs 🧪

It will just show 3 users in Video Preview, even if call has 10 users on it. But, if last user in call, start to speak, he will be changed to the first place in the list, and will appear on Video Preview.
Video

https://github.com/user-attachments/assets/c4e70ce1-2d9e-4fc5-8c5b-ab082baf3219

When user leave a call, should update video preview immediately.
Video

https://github.com/user-attachments/assets/1766cf51-644f-4371-9def-b596f3e3dfba

It works with video enabled too.
Image

Which issue(s) this PR fixes 🔨

Resolve #854

Special notes for reviewers 🗒
Additional comments 🎤

@stavares843 and @phillsatellite I think it has a problem yet, when we test with user that didn't do the call.

so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug
Gravacao.do.ecra.2024-11-19.as.22.15.52.mov
then both @phillsatellite and i had the following bug
290390209.mov
also no image when i activate video but worked for @phillsatellite - works on dev

browser - chrome

Very interesting, I will do more tests and try to improve this code.

so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug
Gravacao.do.ecra.2024-11-19.as.22.15.52.mov
then both @phillsatellite and i had the following bug
290390209.mov
also no image when i activate video but worked for @phillsatellite - works on dev

browser - chrome

I did a commit for it.


support filtering with node status list

Is your feature request related to a problem? Please describe
support filtering with list when possible. it is now available for nodes?farm_ids and contracts?state=
Describe the solution you'd like
other filters can take a list too like nodes?status= and others

Verified:
I queried nodes with status list [up, down] https://gridproxy.dev.grid.tf/nodes?status=up,down


Update travis, address some keyPath issues

Codecov Report

Merging #2 into master will increase coverage by 1.39%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master       #2      +/-   ##
============================================
+ Coverage     70.85%   72.24%   +1.39%
+ Complexity      113      112       -1
============================================
  Files             6        6
  Lines           247      245       -2
============================================
+ Hits            175      177       +2
+ Misses           72       68       -4

Impacted Files
Coverage Δ
Complexity Δ

src/Crypt.php
72.94% <33.33%> (+3.97%)
41 <6> (-1)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee042d1...7d85a02. Read the comment docs.


replacing the https://cronos.org/explorer/testnet3 explorer address t…

Cronoscan have just extended to Cronos testnet cronostestnet_338-3
https://testnet.cronoscan.com/

/staging


[FEATURE] Manual transfer approval

Is your feature request related to a problem? Please describe.

Currently, transfer approval is processed automatically by a batch processing, but we would like to be able to do this manually.

Describe the solution you'd like

We would like to add an API for manual transfer approval.
Refer to the list of transfer approval -> Refer to the details of transfer approval -> Approve transfer (manually)

GET: /share/transfer_approvals/{token_address}/{id}
Show Details
POST: /share/transfer_approvals/{token_address}/{id}
Approve transfer


Check helper pod status is failing because of multiple same chaos experiments running in the k8s namespace

Version
1.10.0
Bug description
We're using 1.10.0 to run multiple pod-network-loss chaos experiments at the same time, it's using pumba to create helper pod. Also, we setup one namespace as the chaos namespace, so the helper pods will be running in the same namespace at that time. Some chaos experiments showed verdict: Fail after some time, the litmus job's pod logs showed
time="2021-01-19T15:58:16Z" level=info msg="[Status]: Checking the status of the helper pod"
time="2021-01-19T15:58:16Z" level=info msg="[Status]: Checking whether application containers are in ready state"
time="2021-01-19T16:02:12Z" level=error msg="Chaos injection failed, err: helper pod is not in running state, err: container is in terminated state"

User Experience
The helper pods are still running, the chaos effect is still effective. The helper pod will not be cleaned after that which makes the following chaos experiments verdict marked as Fail.
Expected behavior
The chaos experiment can be finished as expected with Verdict: Success and the helper pods will be cleaned.

After I checked the code, it seems it's using a generic appLabel app=app=pod-network-loss-helper to filter the helper pods, which will be mixed by different application's chaos experiment pods. Do I understand correctly?

After I checked the code, it seems it's using a generic appLabel app=app=pod-network-loss-helper to filter the helper pods, which will be mixed by different application's chaos experiment pods. Do I understand correctly?

Thank you @songrgg for reporting this. We will get back on this soon.

Thank you @songrgg for reporting this. We will get back on this soon.

@songrgg you are right. We are in fact using a RunID in order to add a dynamic element to the helper pods to differentiate it from the different instances of the helper belonging to other experiments, but filtering by a common label leading to this problem.
This will be addressed by changing the choice of label used in filtering the right helpers to get their statuses.

@songrgg you are right. We are in fact using a RunID in order to add a dynamic element to the helper pods to differentiate it from the different instances of the helper belonging to other experiments, but filtering by a common label leading to this problem.
This will be addressed by changing the choice of label used in filtering the right helpers to get their statuses.

Sounds great, thank you :)

Sounds great, thank you :)

I think ChaosUID might be a good option.

I think ChaosUID might be a good option.

This is fixed via PR https://github.com/litmuschaos/litmus-go/pull/276 & available since 1.12.3


Sync with master

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

:exclamation: No coverage uploaded for pull request base (bstring-migration@c73ee69). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             bstring-migration   #23425   +/-   ##
====================================================
  Coverage                     ?   14.59%
====================================================
  Files                        ?       51
  Lines                        ?     1411
  Branches                     ?      219
====================================================
  Hits                         ?      206
  Misses                       ?     1189
  Partials                     ?       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73ee69...c73ee69. Read the comment docs.


Set Vive Tracker as default input controller

Hello,
Is it possible to set vive tracker as default input controller for all sessions of steamvr app to not change controller at each new launch of steamvr?
It would be nice to do this from code, so I won't need to do setup after PC reboot.
Also, what are the proper settings for vive tracker, to use is as input controller, such as hyperblaster gun and how to bind haptic action to trigger vibro in hyperblaster gun for example?
Using Unity as engine for development.
Thanks in advance!

Hi 0x00x0 I think this is a similar question to mine, I don't have an answer for you but I'm subscribed to this thread in case you get a reply. you can check my question here and watch that for an answer too.
Set controller default state appearance #549


Calling clipper.deleteAll() breaks plans view (outlines/edges)

Describe the bug 📝
When calling clipper.deleteAll() any time before entering the plans view (like in the plans component tutorial), the outlines of the elements are broken. Something in deleteAll destroys the edges/outlines. What do I need to call to update them again?
The plans are still there, just the color of the meshes, and the edges thickness is not considered.
Reproduction ▶
No response
Steps to reproduce 🔢

follow the tutorial for plans component
follow the tutorial for clipper
call clipper.deleteAll()
enter the plans view

No response
System Info 💻
System:
    OS: macOS 14.5
    CPU: (11) arm64 Apple M3 Pro
    Memory: 100.80 MB / 18.00 GB
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
  Browsers:
    Chrome: 126.0.6478.56

Used Package Manager 📦
npm
Error Trace/Logs 📃
No response
Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
[X] Check that this is a concrete bug. For Q&A join our Community.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hey @maidi29 right now the plans use the clipper for cutting the model. We could skip the floorplan planes, but that feels a bit rigid. What if instead we allow to define a type property for planes? By default, the type would be default, but for plans it would be plan. Then, we could add a filter optional argument to deleteAll(), so it would look like this:
clipper.deleteAll({type: "default"});

Would this solve your issue? I'm trying to find a way that also support future use cases for clipping planes (sections, specific views of model details, etc).

@agviegas thanks for the fast reply! Yes, I think this would solve my issue :) I only want to remove user-made clipping planes before entering the plans view but without having the styles of edges and meshes "destroyed"

Solved from version<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Now all planes have a type string property that can be customized. The default value is default, and the planes created by the plan component are floorplan. Adding the following code to the plans tutorial:
const clipper = components.get(OBC.Clipper);
clipper.createFromNormalAndCoplanarPoint(
  world,
  new THREE.Vector3(1, 0, 0),
  new THREE.Vector3(),
);

window.onkeydown = () => {
  clipper.deleteAll(new Set(["default"]));
};

I get this:
https://github.com/user-attachments/assets/a2e12e77-9239-4343-aafb-c0e6880100cf
This would also allow you to define your own custom plane types, and delete them all or skip their deletion selectively. I'll publish later today. Let me know if it doesn't work!


Benchmark Proposal: many small arrays VS few large spen-ed arrays

I topic that I have seen asked regarding C# is whether it is better to perform large allocations and segment them or just do lots of smaller allocations.
Might make a useful benchmark.

I had an idea for this but I honestly can't remember now... I'm just gonna close this...

Btw fwiw it's definitely better to perform a large allocation if it's a long-term one


[Utils] Change test to negative test

This commit changes a test to negative test.
ONE-vscode-DCO-1.0-Signed-off-by: yunjay-hong<EMAIL_ADDRESS>

@llFreetimell I'm not 100% sure this change is following your convention in https://github.com/Samsung/ONE-vscode/pull/1154/files#r938485139. Please let me know :smile:


Headers not added with configured middleware?

Hello! I am using gulp-webserver's middleware option to set a header (Access-Control-Allow-Origin). I have also configured livereload. When I load my livereload.js script, however, that header is not served.
Simplified version of my code:
const livereload = {
  enable: true,
  port: 18000,
  filter: function (filename) {
    // ...
  }
};

gulp.src('.')
  .pipe(webserver({
    livereload,
    directoryListing: true,
    https: false,
    middleware: [
      (req, res, next) => {
        res.setHeader('Access-Control-Allow-Origin', '*'); // eg.
        next();
      }
    ]
  }));

Example response headers:
HTTP/1.1 200 OK
content-type: application/json
date: Tue, 01 Aug 2017 19:37:26 GMT
connection: close
transfer-encoding: chunked

Having the same issue, where I want JSON files to have a json header and continue to next() but yeah the header is coming out as text/html. I worked around this by manually reading the json file from disk and res.end(content) just after adding the header. Definitely would prefer not to have to do this though.


Possible Security Problems

Hey there! I noticed some possible problems in some code in this repo. A quick summary of a few of them is below, but let me know if you're interested in seeing a full report or talking about cloud security in general.

severity: serious
filename: ./JumpHost/template.json
line number(s): [241]
resource(s):
Missing egress rule means all traffic is allowed outbound.  Make this explicit if it is desired configuration

severity: warning
filename: ./VPC/aws-scca-vdss-stack-singleAZ.json
line number(s): [140]
resource(s):
EC2 Subnet should not have MapPublicIpOnLaunch set to true

severity: warning
filename: ./VPC/aws-scca-vdss-stack-singleAZ.template.json
line number(s): [122]
resource(s):
EC2 Subnet should not have MapPublicIpOnLaunch set to true

severity: warning
filename: ./VPC/route-table-update-post-EC2-builds.json
line number(s): [163]
resource(s):
IAM role should not allow * resource on its permissions policy

severity: warning
filename: ./JumpHost/template.json
line number(s): [241]
resource(s):
Security Groups found with ingress cidr that is not /32

severity: warning
filename: ./JumpHost/template.json
line number(s): [241]
resource(s):
Security Groups found with cidr open to world on ingress.  This should never be true on instance.  Permissible on ELB

severity: warning
filename: ./JumpHost/template.json
line number(s): [241]
resource(s):
Security Groups found ingress with port range instead of just a single port

Thanks for these items. We will review and add this to our backlog and address. Updates to come.

Thanks for submitting. Some updates:

I've submitted PR #84 to address many of these issues.
I've created issue #83 to track the progress of removing inbound access from the public internet.
The IAM role is unchanged, for now. Long term, we would like to perform post-deployment config in a different tool.
I'll close out this issue now, please reach out if you have more to submit.


Fix pofiles discovering logic in '--modified' option when files are renamed.

I'm getting this error when I've renamed a file running powrap --modified:
Traceback (most recent call last):
  File "/.../python-docs-es/venv/bin/powrap", line 33, in <module>
    sys.exit(load_entry_point('powrap', 'console_scripts', 'powrap')())
  File "/.../python-docs-es/venv/src/powrap/powrap/powrap.py", line 111, in main
    args.po_files.extend(
  File "/.../python-docs-es/venv/src/powrap/powrap/powrap.py", line 113, in <genexpr>
    for status, filename in git_status_lines
ValueError: too many values to unpack (expected 2)

It seems that the error is coming from the extension of args.pofiles when are renamed files, because the output of git status --porcelain when there are renamed files is like:
M  .pre-commit-config.yaml
 M cpython
R  dictionaries/library_http_cookies.txt -> dictionaries/library_http.cookies.txt
M  library/http.cookies.po
M  requirements.txt

And the split in git_status_lines takes the value:
[['M', '.pre-commit-config.yaml'], ['M', 'cpython'], ['R', 'dictionaries/library_http_cookies.txt', '-> dictionaries/library_http.cookies.txt'], ['M', 'library/http.cookies.po'], ['M', 'requirements.txt']]

and here is the error.

The workaround which I opted to is to add --no-renames option to git command. The output in the example above is:
M  .pre-commit-config.yaml
 M cpython
A  dictionaries/library_http.cookies.txt
D  dictionaries/library_http_cookies.txt
M  library/http.cookies.po
M  requirements.txt

and ignore all files with status D.

LGTM, thanks for the PR!


Double Click in Karate Robot framework for windows app

Double click doesnt work in Karate Robot framework for windows app
locate('abc').doubleClick()

Error - PolyglotException: TypeError: invokemember (doubleclick) on com.intuit.karate.robot.win.WinElement failed due to: Arity error - expected:2 actual:0

@spd42 from the error message it looks like a spelling mistake. since I can't replicate this, please follow this process: https://github.com/karatelabs/karate/wiki/How-to-Submit-an-Issue

@spd42 actually I think the documentation is incomplete and you need to do this:
locate('abc').doubleClick(0, 0) - because I checked the code and the method gives you option to click at an offset from the current element: https://github.com/karatelabs/karate/blob/master/karate-robot/src/main/java/com/intuit/karate/robot/Element.java#L86


[Demo] Create speech-to-text-ws demo

Intent
WIP

gonna fix this one up after a midterm real quick

Added a minimalistic frontend app with almost no dependencies to subscribe to the websocket and output the results with some basic styling
decided not to pull in tailwind, typescript, linters, etc. to reduce unnecessary complexity


client.users.all returns in 1 of 15 cases not all entries

I have an issue when fetching all Users via client.users.all. My tests showed that in ~1 of 15 cases there are less Users returned than existing. For example you have 137 Users in your Zendesk system and when fetching them via client.users.all only 37 get returned. This is very strange and not consist reproducible. I couldn't track it down in the code yet. So I can't say if it's caused by the Gem or the API endpoint.
Is there any known issue?
Feedback would be great! It's kinda urgent.

I managed to debug my way through the Gem and found the following response genereated here:
https://github.com/zendesk/zendesk_api_client_rb/blob/master/lib/zendesk_api/collection.rb#L400
Response:
...
\"next_page\"=>nil, \"previous_page\"=>\"https://xxx.zendesk.com/api/v2/users.json?page=1\", \"count\"=>137} @url=#<URI::HTTPS https://xxx.zendesk.com/api/v2/users?page=2>
...

From my understanding the API (requests) work as they should. But since only 37 of the 137 Users are processed in the block and the API returns 100 records each request it seems to me the block is not executed for the first 100 entities. I veified this and my logs showed that the block is not executed for the first 100 entities. If my schedule allows it I will dig deeper and try to understand what could have prevented the block execution and not throwing an error.

@thorsteneckel could you share a code snippet that demonstrates this behaviour?

You may also consider the bang method: client.users.all! this way you're more likely to see an error in the logs.

Hi @sandlerr - thanks for your feedback. It was possible to reproduce this with the following simple lines:
zendesk_users = []
client.users.all { |zendesk_user|
  zendesk_users.push(zendesk_user)
}

if zendesk_users.size != 137
  p zendek_users.size
  p zendesk_users
end

I replaced .all by .all! but wasn't able to reproduce it back then. I'll try to look into this later this day again.

Gonna close this since it's a very long issue and all! seemed to work just fine 🤷♂


[BUG] Missing proper alt attributes on img tags

Description
Many people just write one or two words explaining about the image in alt attributes which is not the correct way to describe the image.
Benefits of enhancing the alt attributes include:
Accessibility: Alt attributes provide essential information to individuals who cannot see the images directly, allowing them to understand the visual content through alternative text descriptions.
Compliance: By following best practices and guidelines, such as those outlined in the Web Content Accessibility Guidelines (WCAG), we can ensure our project meets accessibility standards, which is important for inclusivity and legal compliance.
SEO (Search Engine Optimization): Meaningful alt attributes can improve search engine rankings by providing search engines with more context about the images. This can result in increased visibility and organic traffic to our project.
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I have read the discussion tab thoroughly and got the project idea
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Please assign me this issue so that I can work on this issue under GSSOC'23.


add a parent above wicked-forms-model and wicked-forms-wicketX

Add a parent module above the two, so you can check out the repo and directly have the showcase AND the library open in the IDE. This way you can directly see if changes in the library have effects on the showcase.

done together with issue #5 (gradle migration)


Updated README for syntax highlighting

Description of change
Just some small changes to the readme. Moved indented code to js codeblocks, to allow for proper syntax highlighting.

Thanks!


Add support for fully-unauthenticated Firechat ("public-mode" out-of-the-box)

Any updates on this ? Is it possible to do this ?


Workaround race contition in drawer.redrawMetrics()

This is my current workaround I am using for the issue #111 (fatal error: concurrent map iteration and map write) to guard against concurrent access to the shared map StatusCodes accross ali and its library tsenart/vegeta

@fedorlitau Thank you for your discovery. The cause is definitely the data race on the StatusCode 👍
Your workaround solution is correct. It should perform correctly. But I have an idea that is simpler and goroutines don't block each other.
How about copying the StatusCode map when making a new Metrics (ali/attacker/metrics.go#L71) like:
 }

 func newMetrics(m *vegeta.Metrics) *Metrics {
+       codes := make(map[string]int, len(m.StatusCodes))
+       for k, v := range m.StatusCodes {
+               codes[k] = v
+       }
        return &Metrics{
                Latencies: LatencyMetrics{
                        Total: m.Latencies.Total,
@@ -98,7 +102,7 @@ func newMetrics(m *vegeta.Metrics) *Metrics {
                Rate:        m.Rate,
                Throughput:  m.Throughput,
                Success:     m.Success,
-               StatusCodes: m.StatusCodes,
+               StatusCodes: codes,
                Errors:      m.Errors,
        }
 }

@nakabonne I'm glad I could point into the right direction =) I like the copy idea, because it also decouples ali's type Metrics from vegeta's more 👍

@fedorlitau Thank you. If you don't mind, could you work on that solution? Possibly, the above change will work well.

Hey @nakabonne, sorry for the delay - I have created a new PR #115. Haven't tested it for hours, but first tests look good - no crashes.


Sort addons by Enabled

Implements #1037.
Notice it sorts the addons by name if two share the same enabled/disabled status. I found this to be more intuitive.
This is my first pull request, so I'm sorry if I missed something or did it in a way that goes against BD's JavaScript Style guide.

Can you fix the change to the string file? Your current change affects every line

Can you fix the change to the string file? Your current change affects every line

Yeah, that was an issue with my formatter, should be fixed now though. Sorry about that.

Hello,
When will this be released ?
Thanks


feature: loginSilent

This resolves #275 and #563.
This is an alternative to PR #541.  Rather than adding a new config value that changes the acquireToken behavior, this adds a new function.
This adds loginSilent, following the same patterns as the existing loginRedirect and loginPopup.  Like the other login processes, loginSilent is for attempting to get an id token from the authority without any locally available user data or tokens.  It first uses acquireTokenSilent to try to get an id token from cache or with cached data.  Failing that, it makes a new silent request to the authority for an id token.  If the authority has an active session, then an id token is provided.  If the authority does not have an active session, then the promise is rejected.

@DarylThayil @navyasric Assuming there is continued concern with PR #541, please consider this one instead.  I hope this can be more keeping with the desired behavior of the library.

BTW I had to specify highlight.js version to fix the build.  They are tracking the issue here:
https://github.com/highlightjs/highlight.js/issues/1984

@DarylThayil It has been some time since I received any feedback, and I've never gotten feedback from @navyasric @sameerag @pkamalamsft on this or #541 themselves.  I can see you guys are going through some significant refactorings / reorganizing, but I hope including a login_silent can be worked into that.  It does nicely match the login and acquireToken listings.
I didn't know it at the time, but https://github.com/IdentityModel/oidc-client-js/wiki has a signInSilent, seemingly to achieve a similar purpose to what I'm going for here.  It looks like it doesn't have separate acquireToken methods - it gets the id_token and the access token both at once, rather than in separate requests.  That means the scopes are set in the configuration, rather than being able to get different tokens for different scopes.

Dean thanks so much for the suggestion. I can definitely understand the request and need.  Like you called out we are in the midst of a major refactor.  I think we will be at a good place to evaluate the feature request when that has landed.  We are working on publishing a roadmap, and understanding how people are using it and the current shortfalls are really helpful.  I am sorry I don't have a concrete answer right now! cc: @navyasric

Instead of loginSilent, we have opted for ssoSilent, which will be added via #1166. Thanks again for the suggestion! Closing.


Istio not generating standard prometheus metrics

Hi,
I have httpbin and sleep services, printing access logs to stdout but am not Able to get any standard metrics starting with istio_requests_* on checking localhost:15000/stats/prometheus inside Istio-proxy container of httpbin pod.
@zirain Hope here we can continue.
Also, stats filter is present in config_dump

How can I check which filter out of
stats-filter-1.10
stats-filter-1.13
stats-filter-1.9

is being used for my sidecars ?
As am able to see access logs on sidecar, but no standard metrics.

Do you have a 1.13 sidecar ?  IIRC, you were building/installing from master, which will give you 1.14.X sidecars. There shouldn't be much difference between the filters, so you can copy and paste and update the version regex in the filter themselves.
Alternatively, you can delete all of the EnvoyFilters and make sure that MeshConfig.defaultProviders.metrics includes prometheus.

Thank you very much @douglas-reid  @zirain , Metrics are now coming, stats filter version was missing.
Thanks for handling my annoying messages here.

Do you have a 1.13 sidecar ? IIRC, you were building/installing from master, which will give you 1.14.X sidecars. There shouldn't be much difference between the filters, so you can copy and paste and update the version regex in the filter themselves.
Alternatively, you can delete all of the EnvoyFilters and make sure that MeshConfig.defaultProviders.metrics includes prometheus.

maybe it's time to move to code, just like the mx filter

@zirain Can you help to find out if there is any such setting/label through which we can enable automatic sidecar injection for a particular deployment inspite of enabling it at namespace level.
Am aware that manually it can be done using istioctl Kube-inject deployment.yaml but it will be a challenge do it for all existing and upcoming deployments.

@doverk96  could you please share your istio configmap for ref ?
i tried same: MeshConfig.defaultProviders.metrics and deleted filters but the ingress and egress pod started crashing due to configmap issue.

Thank you very much @douglas-reid @zirain , Metrics are now coming, stats filter version was missing.
Hi @doverk96, can you tell what did you do to fix stats filter version missing?


[#109031802] spruce container

What
Build a container with spruce to be able to merge manifests on Concourse.
It uses a go alpine linux image as base to be able to compile go code while keeping a small image size.
How to review
Requirements:

Run docker locally
Set docker environment variables if necessary. Example with docker-machine run:

eval "$(docker-machine env <machine>)"`

Run

bundle install
rake build:spruce
rake spec:spruce will run the spruce test
rake will run all the tests
check the README for usage instructions

Who can review
Anyone but @saliceti or @jimconner

Nice PR! :+1:


Add support for transactions and basic session management

Yeah, I’ll fix these. Please also review the session management code if you have not done it yet…

I'll review the session code but can't promise it will be today. In the mean time, could you please make a separate PR for sessions (unless there is a dependency between session code and transactions that I've overlooked).

There’s no dependency, but the way the sessions were created in the tests does not work with Consul v1.5.0 (on my machine, at least).

Fixed, please review now.

Btw, do you have plane to make dedicated Tx endpoint or not?

As for now, no. We only need KV transactions for our job, and it’s quite unlikely we are going to need the other ones, but — who knows :)


Feature: Deferred Data

Problem?
The idea of having an async wrapper, tracking status of data fetching, and the subsequent structure of the portfolio (generic static page component in the future) is a bit dated and doesn't leverage offerings of the new react router data API's.
Solution!
Extracting the contact links into a footer component to be used with the site layout. Refactoring the portfolio store and component to make use of a loader and other helpers relating to deferred data fetching with react router updates.

The AsyncWrapper component can likely be deleted.


Made height of video dynamic, changed styling of autocomplete dropdown

Height of the video now dynamically changes in order to fit the entire height of the displayed content (see attached pictures for example)

Changed the styling of the autocomplete dropdown to increase visibility and have better contrast.

Video spanning entire height - Example 1

Video spanning entire height - Example 2

Autocomplete dropdown styling changes

LGTM!


[ISSUE-48][FEATURE] Add Uniffle Dockerfile

What changes were proposed in this pull request?
To solve issue #48 ，I add the Dockerfile for Uniffle.
Why are the changes needed?
Support K8S Operator
Does this PR introduce any user-facing change?
Yes, we will add the document later
How was this patch tested?
Manual test

/assign @jerqi

#48

cc @zuston @czy006 Could you help me review this patch?

Could you remove the file https://github.com/apache/incubator-uniffle/blob/master/deploy/kubernetes/docker/.gitkeep? Because the directory docker has files, don't need a keep file.

@zuston @kaijchen @frankliee @czy006 Thanks for your review, if you have any other suggestion, you can raise a follow-up pr. Merged.


Exception when using property key with square bracket and array value

Describe the bug
Spring Cloud Config 2.2.5.RELEASE
I have an issue with the following configuration. The use of "[ is due to the > in the property name:
dms:
  standardization:
    rules:
      "[XXX>yyy]":
        - XXX>www

An exception is thrown:
java.lang.ClassCastException: class java.util.LinkedHashMap cannot be cast to class java.util.List (java.util.LinkedHashMap and java.util.List are in module java.base of loader 'bootstrap')
        at org.springframework.cloud.config.server.environment.EnvironmentController$PropertyNavigator.setMapValue(EnvironmentController.java:375)
        at org.springframework.cloud.config.server.environment.EnvironmentController$PropertyNavigator.setMapValue(EnvironmentController.java:372)
        at org.springframework.cloud.config.server.environment.EnvironmentController$PropertyNavigator.setMapValue(EnvironmentController.java:372)
        at org.springframework.cloud.config.server.environment.EnvironmentController$PropertyNavigator.access$100(EnvironmentController.java:349)
        at org.springframework.cloud.config.server.environment.EnvironmentController.convertToMap(EnvironmentController.java:240)
        at org.springframework.cloud.config.server.environment.EnvironmentController.labelledYaml(EnvironmentController.java:204)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

By debugging the code, I see that the propertyKey is converted to dms.standardization.rules[XXX>yyy][0] which results in an IllegalArgumentException because the character after a square bracket is supposed to be a digit
https://github.com/spring-cloud/spring-cloud-config/blob/cec480ea2dfdf819dde95479d07e186b6ecc5f7d/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/EnvironmentController.java#L463

Yes. It's not meant to be exhaustive because of incompatibilities between yaml and properties. If you can think of a fix that would be great, otherwise we'll see if there are others suffering from this issue.

same issue here when try to define some cors configs for spring cloud gateway, the config I try to use is:
spring:
cloud:
gateway:
enabled: true
globalcors:
cors-configurations:
'[/**]':
allowedOrigins: ""
allowedHeaders: ""
allowedMethods: "*"
allowCredentials: true


fix: remove hardcoded default storageClassName

Fixes https://github.com/wiremind/wiremind-helm-charts/issues/529

Closing this since i have merged your changes here:

https://github.com/wiremind/wiremind-helm-charts/pull/528

Thanks for your contribution!


TEST-#2728: add reset_index benchmark

Signed-off-by: Anatoly Myachev<EMAIL_ADDRESS>
What do these changes do?

[ ] commit message follows format outlined here
[ ] passes flake8 modin
[ ] passes black --check modin
[ ] signed commit with git commit -s
[x] Resolves #2728
[ ] tests added and passing

It seems to me that work with MultiIndex is purely pandas, so parameters such as level, col_fill, col_level doesn't include to benchmark.

This benchmark is for single level index. Do we have plans for MultiIndex reset_index benchmark?

@gshimansky case with multiindex was be added


SingleThreadedExecutor: Consider removing pointer/int conversions

See https://github.com/OpenCyphal-Garage/libcyphal/pull/371#discussion_r1704756790_
One posisble way to approach this is to move the custom executor extension point into Callback::Any. This change affects only the SingleThreadedExecutor and everything below it, not the main codebase.

This is not a high-priority issue because it affects only the specific implementation of one Executor policy. The core library is not affected. It is already possible to create an execution policy that does not need this.

Closing as fixed by PR #376


Plunker template is broken

Plunker template is broken:

Link to Plunker: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd?p=preview

Until it's fixed, the following should work
http://plnkr.co/edit/tNFOkVcXvN1FtL9elPlq?p=preview

Fixed. Thanks @willshowell


small memory leak

in src/unix/loop.c at line 66
err = uv_signal_init(loop, &loop->child_watcher);

this one is not freed when loop closed.

Are you seeing an actual memory leak with e.g. valgrind?  It's true that the handle is never closed but that doesn't matter in this case because it's internal and embedded in the uv_loop_t structure itself.

I see it in valgrind.

Can you post the valgrind output?  I'd like to understand what's happening here.

I found the cause of the problem. I must call uv_close() in uv_run() if I call it after uv_run() memory leak.
But in my case, I write a uv binding with a language with gc and I can't call close in uv_run().
#include <stdlib.h>
#include <uv.h>

void timer_cb(uv_timer_t *handle)
{
//uv_close((uv_handle_t *)handle, NULL); // move uv_close() to here and no memory leak
}

int main()
{
  uv_loop_t *loop = (uv_loop_t *)malloc(sizeof(uv_loop_t));
  uv_loop_init(loop);

  uv_timer_t timer;
  uv_timer_init(loop, &timer);
  uv_timer_start(&timer, timer_cb, 1000, 0);

  uv_run(loop, UV_RUN_DEFAULT);

  uv_close((uv_handle_t *)&timer, NULL);

  uv_loop_close(loop);
  free(loop);

  return 0;
}

$ valgrind --leak-check=full ./hello
==14943== Memcheck, a memory error detector
==14943== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==14943== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info
==14943== Command: ./bin-dbg/hello
==14943==
==14943==
==14943== HEAP SUMMARY:
==14943==     in use at exit: 128 bytes in 1 blocks
==14943==   total heap usage: 2 allocs, 1 frees, 976 bytes allocated
==14943==
==14943== 128 bytes in 1 blocks are definitely lost in loss record 1 of 1
==14943==    at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==14943==    by 0x4C2CF1F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==14943==    by 0x414F77: uv__realloc (uv-common.c:86)
==14943==    by 0x40469F: maybe_resize (core.c:771)
==14943==    by 0x4048C7: uv__io_start (core.c:810)
==14943==    by 0x40DAED: uv__signal_loop_once_init (signal.c:225)
==14943==    by 0x40DBC5: uv_signal_init (signal.c:260)
==14943==    by 0x409E0C: uv_loop_init (loop.c:66)
==14943==    by 0x403541: main (hello.cpp:12)
==14943==
==14943== LEAK SUMMARY:
==14943==    definitely lost: 128 bytes in 1 blocks
==14943==    indirectly lost: 0 bytes in 0 blocks
==14943==      possibly lost: 0 bytes in 0 blocks
==14943==    still reachable: 0 bytes in 0 blocks
==14943==         suppressed: 0 bytes in 0 blocks
==14943==
==14943== For counts of detected and suppressed errors, rerun with: -v
==14943== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

That's eerily similar to https://github.com/libuv/libuv/issues/560.

Thanks.


Change code examples in tf.strings.format to use TF 2.x

The code examples in tf.strings.format still uses 1.x (tf.compat.v1)
which is not appropriate now.
This PR changes code examples in tf.strings.format to use TF 2.x.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

@yongtang Can you please address Ubuntu Sanity errors? Thanks!

Thanks @mihaimaruseac @gbaned for the help. I have updated the PR. The previous failure was caused by the fact that doctest does not use "" to locate the code block anymore (use ">>>" and "...") instead. I have removed the redundant "" that was causing the test failure in the PR.
Please take a look and let me know if there are any other issues.

Thanks @mihaimaruseac, the PR has been updated with a shorter example and the pylint disable has been removed as well.


2.5 models, views, templates and ancillary files

Overview
This PR makes changes to the models, views, templates, urls and ancillary files for the councilmatic 2.5 upgrade. This PR does not include the map view for the board members page, which will come in a separate PR.
Notes
This PR depends on changes to the scrapers and django-councilmatic. I believe they can be reviewed separately

https://github.com/opencivicdata/scrapers-us-municipal/pull/299
https://github.com/datamade/django-councilmatic/pull/260

Also, we are bit out of synch with LA metro master, we should discuss how we want to handle that.
Testing Instructions
Move councilmatic/settings_deployment.py.example to councilmatic/settings_deployment.py.
docker-compose up scrapers
docker-compose run --rm -e DJANGO_MANAGEPY_MIGRATE=off app python manage.py migrate
convert_attachment_text
docker-compose run --rm -e DJANGO_MANAGEPY_MIGRATE=off app python manage.py update_index --batch-size=100
docker-compose up

@hancush thank you for the review! I've addressed some of your very good suggestions. Others, at your approval, I would like to defer to other PRs.
I do think that we should resolve the infelicities around pre-fetching in this PR, but I require your more detailed guidance.


web: Added a Yocto monitor

This commit is to append a monitor display for a Yocto build (devtool).
The web page show information of running PRs to build Yocto binaries.
(e.g., PR number, PR time, and commit number)
*Changes

Added a function to monitor Yocto build status
Resized sleep.png file with 'convert' command

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: Version: 1.20190225. Thank you for submitting PR #513. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

This PR is verified by the aging test in the real CI server.


front end translation changes - using i18next library

NOT ready to be merged yet  pending Ivan's review
Ivan, I enclosed the following files just to detail the steps I took to extract JSON from the js files and then translate json into POT file:
convert.js (this contains code that translates JSON into POT)
gulpfile.js (see this one for the tasks I ran to extract text from JS files into JSON)
package.json is just that for my local nodeJS projects that details the dependencies needed to run my gulp tasks
NOTE, I will delete the above files after you have reviewed since they are just sample files, and I have since make some changes in the js (I haven't re-run the tasks to re-generate).  The paths referenced in those files only referenced those on my mac
translation.json file contains JSON that resulted from running i18next scanning tool to extract text from main.js and gil.js (NOTE the location of this JSON file can be changed, I just need to make the necessary adjustment in the code to look for where it is)

Hello @achen2401! Thanks for submitting the PR.

In the file portal/views/portal.py, following are the PEP8 issues :

Line 841:1: E302 expected 2 blank lines, found 1

will resolve conflict and re-create this PR


HTML preview

Can i preview my HTML code with Atom without any other plugin?
Because of building on Electrion,
I think Atom has the ability of rendering html.
Just support by itself, not only Live Preview Markdown.

And i know there is a three-part package:  atom-html-preview

#3088


output.resourcesDir should be in the application server classpath

for vaadinRun, along with output.classesDir.
Otherwise, classpath resources are never found by the application server, except if one uses a (I think) non-standard configuration, where resources are also written to classesDir.
I tried this, and it works for me (with Jetty):
https://github.com/michaz/gradle-vaadin-plugin/commit/6481b93c1637c18698717e781a1d0d0c9044186f
This seems to conflict with the special case for Eclipse, though, see comment, and I'm not sure what to do about that.

Setting vaadinRun.classesDir does not alter you build in any way, it will just point the server to that directory for everything needed to run the webapp. It is up to the developer to get all the necessary compiled classes and resources into that directory if needed. Consider that directory as a expanded WAR archive.
There are two use-cases for this:
1) I want to compile my Gradle project into a War but I wan to also test it in Eclipse with vaadinRun. I don't want to mix classes compiled by Eclipse with classes compiled by Gradle.
In this case you want to set vaadinRun.classesDir to bin as that is where Eclipse puts both class and resource files, but you still want Gradle to put the classes and resources into build/classes as that is what gets added to the WAR.
2) I want to compile all my classes into another directory than the standard one and run it with vaadinRun
In this case you want to point both eclipse and Gradle to the same directory, you can do that by
   sourceSets {
                main.output.classesDir = 'bin'
                main.output.resourcesDir = 'bin'
            }
    vaadinRun {
            classesDir 'bin'
    }

3) I want to compile all my classes to the standard Gradle classes dir, even from Eclipse
In this case you want to set project.eclipse.classpath.defaultOutputDir = project.sourceSets.main.output.classesDir so eclipse configures the project to compile the classes to the standard Gradle classes location.
--
I am guessing you want 2) but haven't pointed the resource dir to the custom classes dir?
I added a warning about when you no classes can be found in the custom classesDir which most likely indicate that you haven't pointed either Gradle or Eclipse to the right location.

Thanks! My remark about Eclipse was confusing, I think (I don't use it). It's rather:
4.) I want to compile all my classes to the standard Gradle classes dir, and I want to have Gradle copy all my resources to the standard Gradle resources dir, and I want vaadinRun to pick up both classes and resources from these dirs.
Currently, only classes are picked up, not resources, becuase only the classes dir is passed to the app server.

Hi, thanks for clarifying the issue.
The resource directory should now be by default added if you haven't set the vaadinRun.classesDir. If you do set it, then you have to manually add both classes and resources to that directory by yourself.


[Issue #289.7] TextQL: Implementation of bean builder method in Predicates

Implementation of bean builder method in Predicates

Implemented bean builder method (getOperatorBean) in Predicates.
The algorithm used to convert the parsed statements into a logical plan is described in this doc.
P.S. This PR require PR #342 and #343  to be finished first

LGTM.


Question: Are you open for me to contribute dialect: SAP Hana database

Hello,
Before I put the effort to prepare a Pull requestm I'd like to know if you would welcome a new dialect for SAP Hana.
Many thanks,
Ariel

Absolutely @arial-bentu!
Go for it. I'm totally welcome with contributions, dialects is were I need it most since I don't know all of them.
Please, go ahead and let me know if you need any help/guidance on it!
Welcome aboard!
On May 6 2019, at 2:29 pm, ariel-bentu<EMAIL_ADDRESS>wrote:

Hello,
Before I put the effort to prepare a Pull requestm I'd like to know if you would welcome a new dialect for SAP Hana.
Many thanks,
Ariel
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (https://github.com/mtxr/vscode-sqltools/issues/212), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAFMX2IQHD2C5EHTLIRTNLDPUBTHZANCNFSM4HLB5GNQ).

Related to #20.

One more important question: Would you consider changing the license to something less viral? preferablly Apache, Eclipse ot similar?
Thanks

I need to check the differences first, but I don't see why not to change.
What do you want to achieve with this new licensing?

As far as I know GPL, if I use it in our products, it requires that my product becomes open source.
I would like to prepackage your extension in our bundle.

Ok. Will need some time to check it, because I believe we are using some GPL libs too.
I can't check it right now, is it ok if I answer it tomorrow? I'll be checking the licenses here https://choosealicense.com/licenses/, also I'll take a look at Eclipse license that I don't know

Sure. Thanks
בתאריך יום ג׳, 7 במאי 2019, 14:53, מאת Matheus Teixeira <
<EMAIL_ADDRESS>
Ok. Will need some time to check it, because I believe we are using some
GPL libs too.
I can't check it right now, is it ok if I answer it tomorrow? I'll be
checking the licenses here https://choosealicense.com/licenses/, also
I'll take a look at Eclipse license that I don't know
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mtxr/vscode-sqltools/issues/212#issuecomment-490047556,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE3ZMN5OP5PMYHVUZR5ZYLTPUFUR3ANCNFSM4HLB5GNQ
.


where to find the '"Lin-Chen/ShareGPT4V-7B_Pretrained_vit-large336-l12'

hi @steven640pixel , i wonder where to find the pretrained clip model ("Lin-Chen/ShareGPT4V-7B_Pretrained_vit-large336-l12) in the config.json

i find you have put it in the huggingface, see https://huggingface.co/Lin-Chen/ShareGPT4V-7B_Pretrained_vit-large336-l12.


Buffer not polyfied for local development

We cannot polyfill Buffer for local development due to WalletConnect issue https://github.com/WalletConnect/walletconnect-monorepo/issues/4064

Module "buffer" has been externalized for browser compatibility. Cannot access "buffer.Buffer" in client code. See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

expired

Still valid.


Dark mode

It would be fun to have a toggle to switch the editor to dark mode, using the syntax highlighting colors used in the rest of the Ceylon website.

Done.


Enable shared serialization in Torch

This allows passing tensors between threads by
reference. This speeds up training for all models,
particulary when data are comparatively large
v.s. compute time.
Alexnet on CIFAR10 (2 epochs): 10m35s -> 9m28s
GoogleNet on CIFAR10 (1 epoch): 45m5s -> 44m52s
LeNet on MNIST (30 epochs): 2m17s -> 2m15s

Chipping away at https://github.com/NVIDIA/DIGITS/issues/339

LGTM


Receives meta monitoring queries do not deduplicate data

Thanos version used:
v0.30.2

What happened:
I configured head_series_limit as documented in https://thanos.io/tip/components/receive.md/#understanding-the-configuration-file, however the meta_monitoring_limit_query was not deduplicating the data, despite the --query.replica-label configured in the querier. This dropped metrics becaused the number or series reported by the querier was a multiple (replication factor) of the real value.
What you expected to happen:
I expected duplication to be in place, since the queriers used for metamonitoring were configured accordingly.
How to reproduce it (as minimally and precisely as possible):
Any metamonitoring query provided that the replication factor is larger than 1.

Solved in https://github.com/thanos-io/thanos/pull/6121 :bow:


bump to v1.0.0rc5

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:

[ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
[ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
[ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.14 out of 15 committers have signed the CLA.:white_check_mark: plyfager:white_check_mark: LeoXing1996:white_check_mark: zengyh1900:white_check_mark: VongolaWu:white_check_mark: AlexZou14:white_check_mark: austin273:white_check_mark: ldr426:white_check_mark: Z-Fran:white_check_mark: curiosity654:white_check_mark: liuwenran:white_check_mark: lvhan028:white_check_mark: willaty:white_check_mark: whu-lee:white_check_mark: Zdafeng:x: xiaomileYou have signed the CLA already but the status is still pending? Let us recheck it.


Complete the documentation

Hi @azhsetiawan, please take a look of my PR for resolves issue #1

Awesome!
Thank you @alfathony


Alternative emoji table

Hello, I am working on a PR to allow having a different emoji table, in specific the one from https://unicodey.com/emoji-data/table.htm which json data can be found here: https://github.com/iamcal/emoji-data/blob/master/emoji_pretty.json
The idea would be to allow overriding which emoji table to use via a java property, so it is done during startup. This will change which json file the EmojiManager will load.
I have two implementation options and wanted to get your opinion:
Option 1
Allow overriding the default json file to any file by using a java property called com.vdurmont.emoji.EmojiManager.PATH. This will allow the developer to use whatever emoji json mapping he wants.
EmojiManager would then look for that property and if it is defined will use that file as the default.
Option 2
Allows overriding the emoji set by using a java property called com.vdurmont.emoji.EmojiManager.SET, and would have two values default or unicodey. The first will be the default and will use the current emoji set. The second, will be the unicodey set that would ship with emoji-java as an alternate set.
EmojiManager would then look for that property and pick the corresponding json file
Let me know what do you prefer or if you have a better idea, thanks!

Closing since I did the pr #94


Misc fixes

Format conventionally, particularly the header
Remove use of "declare-function" (which should have been "require"), and then use simpler built-in functions to avoid library deps
Fix interactive arg behaviour so that function also works non-interactively

In connection with https://github.com/melpa/melpa/pull/7189

@purcell there are many improvements here.  I will apply what I have learned from this feedback when I am writing other packages.
Thank you


Disconnection and reconnection

Describe the bug
I will be using chatterino and I will get randomly disconnected for about 1-2 minutes no messages will show at all then says reconnected and starts to work in about another 10 seconds. My internet isn't going out either because the stream that I am watching continues.
Screenshots
https://imgur.com/a/dHuQ5Zt
Chatterino [version]
Chatterino 2.2.2 (commit 07fc0c3ad)
Operating system
Windows 10
Additional information
I've tried reinstalling 2 different times I have also seen something where it says to not have more than 100 tabs I currently only have 4 so im not really sure what to try from here and have also added and removed my account several times which seems to work for about 5 min then the same problem occurs

All know issues.
Twitch drops connection randomly
You can't have more than 100 rooms open, twitch limit.
Close some tabs.


Better privacy with hashing machine-uid ids

https://www.freedesktop.org/software/systemd/man/latest/machine-id.html

#54 should be considered as replacement for this issue


Requirements for the input data

Thanks for the good tools. My issue is as follow. If I'd like to get the cell proportion in each spot based on Spatial Transcriptomics data and Sc-RNA reference what should I do to satisfy the model input. E.g. can I just use the raw count data in ST and ScRNA dataset or I need to do normalization and log() operation before mapping cause I noticed you have mentioned in your paper "we do not assume that G and S measure gene expression using the same unit of measures" in Methods part. Does it mean the raw count data is OK? Thanks!

Hi @Epoch1128 . It will still be better if you normalize the data before mapping. But no need to take log operation because Tangram linearly combines the gene expression between different cells.


sink (ticdc): fix kafka metrics

What problem does this PR solve?

Issue Number: close #10777
What is changed and how it works?

Use the Rate1() method instead of the Mean() method from metrics.Meter to get the most recent rate, which is more accurate.
For the histogram metrics, display both the 99th percentile and the average in the Grafana dashboard.

Check List
Tests

Manual test (add detailed scripts or steps below)

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Fix a inaccurate kafka metrics.

/retest

/retest


Saved appeals save return

Pivotal
dummy page for list of saved appeals after logging in
looky likey:

Vielen dank


Release Version 4

Look into open issues and close all that can be closed until release.

[ ] version 4.0 release performed
[ ] update release description
[ ] perform release for maven central

[ ] version 4.0 release performed
[ ] update release description
[ ] perform release for maven central


Fix php docs and comments

That's the last one waiting for review. Thank you @MathiasReker for all these pull-requests.


[TYPING] Use ReactNode instead of JSX.Element to match official react typings

I was getting an incompatibility type error and noticed this.
Also, ReactNode already includes these null | undefined | false conditions

Sweet @brunolemos, we've had a discussion with @krzysztofciombor about this because neither of us is a typescript expert. Glad that you have found this and pointed the right solution


[tool_crash] FileSystemException: Cannot open file, OS Error: El sistema no puede encontrar el archivo especificado., errno = 2

Command
flutter doctor

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot open file, OS Error: El sistema no puede encontrar el archivo especificado.
, errno = 2
#0      _File.throwIfError (dart:io/file_impl.dart:675:7)
#1      _File.openSync (dart:io/file_impl.dart:490:5)
#2      _File.writeAsBytesSync (dart:io/file_impl.dart:644:31)
#3      _File.writeAsStringSync (dart:io/file_impl.dart:668:5)
#4      ForwardingFile.writeAsStringSync (package:file/src/forwarding/forwarding_file.dart:150:16)
#5      ErrorHandlingFile.writeAsStringSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:267:22)
#6      _runSync (package:flutter_tools/src/base/error_handling_io.dart:590:14)
#7      ErrorHandlingFile.writeAsStringSync (package:flutter_tools/src/base/error_handling_io.dart:266:5)
#8      Cache.setStampFor (package:flutter_tools/src/cache.dart:639:35)
#9      VersionCheckStamp.store (package:flutter_tools/src/version.dart:781:30)
#10     FlutterVersion._getLatestAvailableFlutterDate (package:flutter_tools/src/version.dart:336:31)
<asynchronous suspension>
#11     FlutterVersion.checkFlutterVersionFreshness (package:flutter_tools/src/version.dart:283:47)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:311:11)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:285:5)
<asynchronous suspension>
#15     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:115:9)
<asynchronous suspension>
#16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#17     main (package:flutter_tools/executable.dart:90:3)

[✓] Flutter (Channel stable, 3.13.4, on Microsoft Windows [Versi¢n 10.0.22621.2283], locale es-ES)
    • Flutter version 3.13.4 on channel stable at C:\Users\david\OneDrive\Documentos\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 367f9ea16b (7 days ago), 2023-09-12 23:27:53 -0500
    • Engine revision 9064459a8b
    • Dart version 3.1.2
    • DevTools version 2.25.0

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Android\android-sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✗] Visual Studio - develop Windows apps
    ✗ Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[✓] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[!] Android Studio (version unknown)
    • Android Studio at D:\src\flutter\bin
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    ✗ android-studio-dir = D:\src\flutter\bin
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.
    • Consider removing your android-studio-dir setting by running:
      flutter config --android-studio-dir=

[✓] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.2.3
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.81.1)
    • VS Code at C:\Users\david\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Versi¢n 10.0.22621.2283]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 116.0.5845.188
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 117.0.2045.31

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 3 categories.

Flutter Application Metadata
No pubspec in working directory.

Closing this as a duplicate of https://github.com/flutter/flutter/issues/76479


Webpack resolver: possible compatibility issue with atom/linter-eslint

Dear,
I've been having a compatibility issue with the webpack resolver and atom/linter-eslint. When running eslint from the command line all my imports gets resolved correctly. Through atom/linter-eslint it could not resolve those that relied on resolve.root or resolve.alias.
I'm not sure if this is a bug in either this plugin, linter-eslint, or a different depending package.
A work-around is simple enough so I just wanted to highlight how to fix it for the benefit of others. Perhaps this could be included in the documentation as well.
My webpack config before: not working for linter-eslint
{
  alias: {
    'app': path.resolve('./client/app'),
  }
}

My webpack config after: working for linter-eslint.
{
  alias: {
    'app': path.resolve(__dirname, './client/app'),
  }
}

Same goes for the resolve.root setting.
Cheers.

You're in good company: #260
TL;DR: your described workaround is the preferred solution at this time. See the linked issue for possible alternatives, but I'm not sure what can be done in the resolver to solve this issue.


make blob tests faster by not stopping emulator between each invoke.

I happened to notice that test started and stopped the emulator between each test which was slow.

hmm..this doesn't seem to work on the server.


[Bug][Helm][Operator] Verify that setting resources in initArgs works

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ray-operator
What happened + What you expected to happen
There are reports that setting num-cpus and num-gpus in initArgs does not work.
Check if that's the case. If so, fix.
Reproduction script
https://github.com/ray-project/ray/issues/13270#issuecomment-1310439746
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

I was not able to reproduce the issue.