BackdropFilter doesn't cover fullscreen on simulator only

Image.asset(
                'assets/images/my_music_cover.png',
                width: getScreenWidth(context),
                height: getScreenHeight(context),
                fit: BoxFit.cover,
              ),
        BackdropFilter(
          filter: ImageFilter.blur(sigmaX: 50, sigmaY: 50),
          child: Container(
            color: Colors.white.withOpacity(0.5),
            width: getScreenWidth(context),
            height: getScreenHeight(context),
          ),
        )

it was not what I wanted.
do me a favor please,thanks anyway

iOS

Android

Code Sample
import 'dart:ui';

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Stack(
          children: <Widget>[
            Image.network(
              'https://i.imgur.com/QCNbOAo.png',
              width: MediaQuery.of(context).size.width,
              height: MediaQuery.of(context).size.height,
              fit: BoxFit.cover,
            ),
            BackdropFilter(
              filter: ImageFilter.blur(sigmaX: 50, sigmaY: 50),
              child: Container(
                color: Colors.white.withOpacity(0.5),
                width: MediaQuery.of(context).size.width,
                height: MediaQuery.of(context).size.height,
              ),
            ),
          ],
        ),
      ),
      floatingActionButton:
          FloatingActionButton(child: Icon(Icons.add), onPressed: () {}),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.6 19G73, locale en-GB)
    • Flutter version 1.17.5 at /Users/taha/Code/flutter_stable
    • Framework revision 8af6b2f038 (2 weeks ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (2 available)
    • SM M305F  • 32003c30dc19668f                     • android-arm64 • Android
      10 (API 29)
    • iPhone 11 • AAB605C7-0569-43D6-9D8D-2AC1A9C36264 • ios           •
      com.apple.CoreSimulator.SimRuntime.iOS-13-6 (simulator)

• No issues found!

flutter doctor -v
[✓] Flutter (Channel dev, 1.21.0-1.0.pre, on Mac OS X 10.15.6 19G73, locale
    en-GB)
    • Flutter version 1.21.0-1.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision f25bd9c55c (2 days ago), 2020-07-14 20:26:01 -0400
    • Engine revision 99c2b3a245
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 20bf2fcf56)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (5 available)
    • SM M305F (mobile)  • 32003c30dc19668f                     • android-arm64  • Android 10 (API 29)
    • iPhone 11 (mobile) • AAB605C7-0569-43D6-9D8D-2AC1A9C36264 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-6 (simulator)
    • macOS (desktop)    • macos                                • darwin-x64     • Mac OS X 10.15.6
      19G73
    • Web Server (web)   • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Have you tried your code on a physical device? Seems like the Simulator uses a different renderer than the actual devices

Yes, it  doesn't reproduce on physical device but it does happen on simulator so changing title until somebody confirms we can close this issue

If the simulator is using the software Skia renderer then this is a known issue in Skia where they don't support edge clamp mode for the software versions of the blur filter: https://bugs.chromium.org/p/skia/issues/detail?id=10911

Verified this using latest versions and running the code sample on iOS simulator. Confirmed that the blur now covers entire screen as below:

Closing this as fixed.

 stable, master flutter doctor -v
[✓] Flutter (Channel stable, 3.3.8, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.3.8 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (25 hours ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.6.0-3.0.pre.18, on macOS 12.2.1 21D62 darwin-x64,
    locale en-GB)
    • Flutter version 3.6.0-3.0.pre.18 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1aeb1721ca (2 hours ago), 2022-11-14 21:12:25 -0500
    • Engine revision 78ae241400
    • Dart version 2.19.0 (build 2.19.0-398.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


Logger events

This adds error- and warning-level messages from selected loggers to the output events.

This looks good to me. I had a look to see if there were any explicit calls to add_event  that could be dropped now, but they all seem to be next to calls to the log_error function rather than the logging.error, so seems good.


Add support for quillpad lists and handle edge cases

Went to use this for myself, and added the things I needed, including:

add a pyproject.toml to make installing dependencies simpler
add support for quillpad checklists ->markdown checklist conversion
fix error when importing note not in a notebook
fix error when note has no title (replace with timestamp)
fix sanitization of titles to prevent issues saving file

Sorry I'm not being more granular with the PR, but most of the changes are small.

Hi, thank you so much! I'll take a proper look later but from a glance this looks good to me. Is this ready for review?

Alright, changes have been merged!


Update automatic-testing.md

fixing typo since its really at test.integrationtests.skills.runner and not test.integrationtest.skills.runner

Nice catch, thanks!


Odd behavior when taking a square root

I'm playing around with this library, and I found some odd behavior
This is to calculate the average speed of a particle in a Maxwellian distribution.
I wrote something simple to do this
#include <type_traits>
#include <mp-units/systems/international/international.h>
#include <mp-units/systems/isq/space_and_time.h>
#include <mp-units/systems/si/unit_symbols.h>
#include <iostream>
#include "mp-units/math.h"

using namespace mp_units;

auto AverageSpeed(const QuantityOf<isq::thermodynamic_temperature> auto &Temperature, const QuantityOf<isq::mass> auto &Mass)
{
        const auto boltz =  mp_units::si::si2019::boltzmann_constant;
        constexpr double pi = std::numbers::pi;
        const auto Internal = 8.0 * boltz * Temperature / (pi * Mass);

        using namespace mp_units::si::unit_symbols;
        const QuantityOf< pow<2>(isq::velocity)> auto Internal_converted = value_cast<(m * m / (s*s))>( Internal);
        return mp_units::pow<1,2>(Internal); //Change Internal to Internal_converted in order to compile
}

int main()
{
  using namespace mp_units::si::unit_symbols;
  using namespace mp_units::international::unit_symbols;

  const auto Temp = 1000 * K;
  const auto Mass = 10 * Da;

  const auto particleSpeed = AverageSpeed(Temp, Mass);

  std::cout << particleSpeed[m / s].number() << std::endl;
}

This currently fails to compile with at magnitude.h line 310
  if (exp.den != 1) {
    std::terminate();  // Rational powers not yet supported
  }

I think its trying to take a square root of a boltzmann constant which is not allowed.  The type of Internal seem measured in K * k_b / Da.
However, if I replace the return statement of my AverageSpeed function with
return mp_units::pow<1,2>(Internal_converted);

then everything compiles.   Is there a good argument for why the value_cast in necessary here?

I would expect to see this if you're doing a unit conversion between two units whose ratio has a rational power.
The reason is that we always compute unit conversion factors at compile time, but we can't currently compute rational powers at compile time. What we'd need is a constexpr version of powl(). I'm pretty sure this could be done; for example, the gcem library has one. I'm just not sure we'd want to take on the extra dependency of using it directly, so maybe we could roll our own at some point.
In any case, the code you've written is perfectly valid for the future version of this library which includes this feature. 🙂 In the meantime, I thought it would be better to produce a hard error rather than return an approximate (i.e., incorrect) result.
The reason you're able to get it to work is that when you do the conversion in squared speed, rather than speed, the conversion factor doesn't have any rational powers.

Nearly all <cmath> functions will be constexpr in either C++23 (https://wg21.link/P0533R9) or C++26 (https://wg21.link/P1383R2), and I think that a few compilers already implement it this way. We just need a PR with a proper magnitudes implementation 😉
I also refactored your example a bit here: https://godbolt.org/z/v6Tf8o3hT.

Can we take advantage of that yet, though, and still maintain the C++20 compatibliity?   WDYT --- will we need to detect constexpr compatibility, and provide a "hand rolled" alternative for those who don't have it?

and provide a "hand rolled" alternative for those who don't have it

or do std::terminate like we are doing right now.

The reason you're able to get it to work is that when you do the conversion in squared speed, rather than speed, the conversion factor doesn't have any rational powers.

In theory you should still have to take a square root of one to get another conversion factor.  I take it there is some constexpr check for that.

I'm pretty sure this could be done; for example, the gcem library has one.  I'm just not sure we'd want to take on the extra dependency of using it directly, so maybe we could roll our own at some point.

I get the feeling, but taking a sqrt of something is too common to leave as "just wait until you have a C++23 compiler."  That laves any volume/area conversion to a length as impossible let alone my energy to velocity conversions.
I'll try to put together an option dependency to gcem.   Is it safe to say that only that place in compute_base_power needs to be changed?

The reason you're able to get it to work is that when you do the conversion in squared speed, rather than speed, the conversion factor doesn't have any rational powers.

In theory you should still have to take a square root of one to get another conversion factor. I take it there is some constexpr check for that.

There are two things going on here: a unit conversion, and a runtime square root computation.  The reason it works when you do the unit conversion between the squared quantities is that you're essentially pushing all of the square-root-ness into the runtime computation.

I'm pretty sure this could be done; for example, the gcem library has one.  I'm just not sure we'd want to take on the extra dependency of using it directly, so maybe we could roll our own at some point.

I get the feeling, but taking a sqrt of something is too common to leave as "just wait until you have a C++23 compiler." That laves any volume/area conversion to a length as impossible let alone my energy to velocity conversions.
I'll try to put together an option dependency to gcem. Is it safe to say that only that place in compute_base_power needs to be changed?

Yes, I expect that is the only place that would need to be changed.

I'm not expecting to be able to work on this before March at the earliest, because any spare bandwidth I might have would go towards the standard units library papers instead.  That said, I do have some good news: Au has now implemented this feature!  See aurora-opensource/au#213.
The strategy I used was to write a root(x, n) function which does a binary search to find the value r such that int_pow(r, n) is as close as possible to x.  This is probably slow, but I don't think that matters because we'll only ever call it at compile time.  And, it's guaranteed to produce the closest representable result, by definition!  (Up to any floating point inaccuracies in our int_pow function, that is.)
Even though I don't have time to work on this for mp-units for the next several months, I'm still posting this here so that folks can discuss the implementation strategy if they want.  Then it'll be just a matter of finding time to implement this.

@khansson, your original example is now enshrined as a test case that helps make sure this feature works.


Refresh Render Task List only once every frame

Closes #2610. Shaves off a minimum of 1 ms from time taken for task list refreshes according to the logs before and after the change.
How to test
In debug mode (F3), enable and disable wireframe mode (F9) to trigger task list refreshes (I don't know of any other method). The speedup isn't noticeable, but on comparison between the logs before and after the change, in the worst case a minimum of 1 ms is shaved off the task list refresh time.
Details

Nodes now request refreshes (RenderTaskListGenerator.requestRefresh()). If requested, the task list will be refreshed in the next preRenderUpdate.
WorldRendererImpl stores a reference to RenderTaskListGenerator as a field. This has no performance implications since all nodes store the  same reference anyway.

Can one of the admins please verify this patch?

@GooeyHub: ok to test

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Just approved 879ee7ef and subsequently made one tiny change about a line that slipped through the cracks. @rzats, if Jenkins doesn't complain from my perspective this can be merged.
Good work @eviltak, much appreciated. I hope you'll stick around and take the chance to get your hands dirty with the rendering engine again. :wink:

Merged and added @eviltak to the credits - thanks for your contribution!

@emanuele3d Fortunately, I do. #2601 is in my sights!


🐛 open -> private, users can see updates if they don't refresh the page

Bug Report
Problematic behavior
User who opened a doc when it was public and don't refresh can see updates even if the document was made private.
Expected behavior/code
If the doc visibility changes from public to private it should affect users consulting the doc in real time.
So maybe we should force a refresh or find some kind of viable solution.
Additional context/Screenshots
https://www.loom.com/share/43d66acf412641e5893402e99445fcd0?sid=08ccd38d-4a82-48d4-8eef-dc0e998fa5f8

Lot of "IF":

if someone has a doc in public
if the owner switch to private
if at the same moment someone that was invited thanks to the public link is connected on the doc
if you decide to add some super secrets

To solve that, basically the backend should send the information to the frontend, so to address this potential bug, you must add websocket, or a webhook system, or pulling but we don't want that. We could try to use the y.js server to send this information, but it is a bit like a trick.

If we want this level of security, another case:

I invite userA
userA connect to the doc
I revoke userA
userA can still see the doc until he refreshed the page


Multiple updates for usability, error handling, and better data presentation

Various updates described below:

Update where json files are saved

Rather than just dump all the json files we create into a single directory and ensure that navigating the directory is imposible, create a hierarchy of directories that starts with a directory of the region number, then a directory of the callsign prefix before the region number and then place all the json files for that region number and prefix into that directory. This ensures that the files are still easy to find but that we can navigate their directory hierachy easily. So for instance given the callsign K1ABC, the json file will now be in _build/callsigns/1/K/K1ABC.json

Turn off quoting in the python csv library

Recently I found an error in the FCC EN.dat file.  This record:
EN|3473987|||W2JJW|L|L01773257|West, James "|JAMES|"|WEST|||||602 PROVINCE LINE RD|ALLENTOWN|NJ|08501|||000|0022526404|I||||||
caused the csv parser to throw all kinds of errors due to the quotes inside the fields. To avoid these errors and because quoting is not used in the FCC dat files anyway, the solution is to simply tell the python csv library to turn quoting off.
For reference, the quotes in that line used to be the letter J. I'm not sure why they changed.

Pretty format license status and operator class codes

Rather than return the single letter codes for license status and operator class, return the full text taken from the FCC ULS Code definitions file.

Add FCC ULS and QRZ links for each license record when outputting as a dict.

That's awesome. So strange about that messed up record!
Thank you for these contributions. I've been wanting to get back around to working on this project again and this helps motivate me to do so :-)


Update README.md

surge URL added to README for initial submission to gLearn

merging branches with updated README.md file with sure URL for  initial submission to gLearn


Sync the value when selected with the input field

Hi there, Thanks for the awesome library ❤
I have a question here. How can I sync the value when selected with the input field?
( The value of input will change when I press the apply button. You can see the example below )
https://github.com/Vuepic/vue-datepicker/assets/12345613/a460edc2-c294-41ff-ad3d-250514ea99a4

Hello, you can use the auto-apply prop.

Hmm. with auto-apply props. We just hide the apply button here.
I just want to when select a day. The value of input will change. But the apply button still shows here.

You need to provide config.keepActionRow prop in that case

The apply button shows, but the value of the input field doesn't change. You can take a look at my record.
Like when I select day 6. the input will change to day six, too.
https://github.com/Vuepic/vue-datepicker/assets/12345613/f31b8a2a-a4e0-4b2e-b144-69926543a825


TCMalloc built with mingw-w64 deadlocks during startup when pthread-based TLS is enabled

Here's the call stack

The ??s from libwinpthread-1.dll are calls to pthread_setspecific().
Here's the line we are stuck on (it's a spinlock) https://github.com/mingw-w64/mingw-w64/blob/86a5e0f41683d8e60b3756712e7a417055d291dc/mingw-w64-libraries/winpthreads/src/thread.c#L913
The spinlock implementation in question
https://github.com/mingw-w64/mingw-w64/blob/86a5e0f41683d8e60b3756712e7a417055d291dc/mingw-w64-libraries/winpthreads/src/spinlock.c#L50
Looks like the MinGW port of pthread_setspecific() is not reentrant.
Identified with this flavour of MinGW
https://github.com/brechtsanders/winlibs_mingw/releases/tag/13.2.0posix-17.0.5-11.0.1-ucrt-r3
The build flag in question is HAVE_PTHREAD.
I'm currently working on a changelist to disable it by default in the CMake build

https://github.com/gperftools/gperftools/pull/1485

First of all, thanks a lot for looking at this and reporting the issue.
So I am able to reproduce the deadlock and indeed the issue is they're calling realloc while holding their internal lock.
Deadlock is only reproducible on "posix" variant of mingw that debian ships with mingw cross compiler, not their default "win32" variant. (And this is all mega-stale msvcrt, sadly no ucrt option there yet)
Here is what I think we should be doing:
a) general philosophy is now to embrace threading rather than trying to avoid it. So all this "don't include pthreads" logic should go. It only adds complications and multiples configurations that require additional testing. (It made sense for us in past, but not anymore; see #1110 for some more background).
b) since mingw-pthreads config has "incompatible" pthreads implementation we should try using windows native API (make it same for MSVC compiler&runtime as well). I.e. we only use threading API for pthread_atfork (doesn't apply to windows & mingw), and for per-thread storage (including deallocation when thread dies). The code currently builds all that around pthreads, "simulating" it on win32. Perhaps we should consider generalizing this. I'd like us to consider native C++ API, but that same mingw+posix config is likely to be borked there. Worth checking what competition does (jemalloc likely does pthreads, mimalloc being more windows centric and newer might have interesting ideas in this area)
c) NOMINMAX stuff should be fixed separately (with or without config.h matter consolidation; likely without)
If you have time to work on this let me know. If not, I'll eventually find time to do it myself. We cannot afford doing adventurous unique ptr hacks like you suggest in pull request.

Give me a few days to put something together.
I think we can split the work discussed here into a couple of PRs

Consolidate MSVC & MinGW TLS/threading implementations around WinAPI.

I expect this to be more of a cleanup/refactoring task, probably no new code needs to be introduced
This should already unblock Autotools-MinGW builds, and will fix this issue #1483

Fix CMake MinGW & MSVC builds

Also ensure implicit TLS is disabled for #1484
Also ensure config.h isolation between CMake & Autotools/VSProj to avoid configuration conflicts as described in #1482

With both of those PRs, #1485 will be resolved.

#1487

Resolved with #1487 by moving MinGW builds to always use WinAPI TLS


.Net: exception on using AssistantBuilder to create IAssistant

I have the latest packages.
With this code:
var assistant = await new AssistantBuilder()
.WithOpenAIChatCompletion(openAIModel, openAI_Key)
.FromTemplate(assistant_definition)
.BuildAsync();
I am seeing the following exception:
Could not load file or assembly 'Microsoft.SemanticKernel.Connectors.OpenAI, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f300afd708cefcd3'. The system cannot find the file specified.
I get the exception only if creating an Assistant is the first thing I do in my solution.
If I first run some other non-Assistants workflow, like chat/function-calling etc. and then choose to use Assistants then no exception is thrown. Maybe at this time the assembly is already loaded so creating an assistant works??
Possibly some assembly mismatch between the Experimental.Assistants and other v1 packages?

@deepinderdeol Can you switch to using this package https://www.nuget.org/packages/Microsoft.SemanticKernel.Experimental.Agents/1.0.1-alpha
We re-renamed the assistants package to agents.
See: https://github.com/microsoft/semantic-kernel/blob/main/dotnet/src/Experimental/Agents/AgentBuilder.cs

@alliscode Can we remove the old assistants code now?

Issue is fixed after switching to Agents package. Thanks @markwallace-microsoft
Unrelated to this issue - maybe this is already possible or is being considered, I think it would be good if chat-history could be passed in when invoking the agent thread, something like this so the manager can consider past interactions when invoking workers:
var agentMessages = thread.InvokeAsync(manager_agent, userQuery, chatHistory);


clean & clear code

clean and clear code

How to restart the teamcity build check when "git early eof" issues was encountered?


platform_views_scroll_perf__timeline_summary:99th_percentile_frame_build_time_millis 250% regression

introduction https://github.com/flutter/flutter/pull/144208
skia-perf

This is probably a result of https://github.com/flutter/engine/pull/50976

We looked into this more and the cause was the multiview PR that landed and was reverted changed how the work was scheduled in a way that reduce the measured workload of the framework.


Minor: Use upstream concat_batches from arrow-rs

Which issue does this PR close?
N/A
Rationale for this change
While working on https://github.com/apache/datafusion/pull/11610 I found that there is a wrapper over concat_batches
The concat batches function is now available in arrow-rs so let's use that
What changes are included in this PR?
Use arrow concat_batches directly rather than via a wrapper
Are these changes tested?
By existing CI
Are there any user-facing changes?
No

@ozankabak  mentioned https://github.com/apache/datafusion/pull/11610#issuecomment-2244524858 there was work in progress for CoalesceBatches so we might want to make this PR a draft until that work has landed


Add status sort button

Resolves #48

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (f226ecd) 99.08% compared to head (d14edf1) 99.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   99.08%   99.10%   +0.01%
==========================================
  Files          33       33
  Lines         547      559      +12
  Branches       90       99       +9
==========================================
+ Hits          542      554      +12
  Misses          3        3
  Partials        2        2

Impacted Files
Coverage Δ

src/components/Table/Filter.tsx
100.00% <ø> (ø)

src/components/Table/styles.ts
100.00% <ø> (ø)

src/constants/tests.ts
100.00% <ø> (ø)

src/styles.ts
100.00% <ø> (ø)

src/components/Table/Table.tsx
100.00% <100.00%> (ø)

src/hooks/useTable.tsx
100.00% <100.00%> (ø)

src/utils/table.ts
96.22% <100.00%> (+0.26%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


⚠ Cioos Pacific CKAN has degraded performance

In 0196c83, Cioos Pacific CKAN (https://catalogue.cioospacific.ca) experienced degraded performance:

HTTP code: 200
Response time: 15448 ms

Resolved: Cioos Pacific CKAN performance has improved in 17b207e after 26 minutes.


When the return value of Spring RestController is Mono, the request occasionally returns null

RestController method as below, use Mono<ResponseEntity> as return body
public Mono<ResponseEntity<OAuth2AccessToken>> scanTicket(@PathVariable("ticket") String ticket, @RequestParam Map<String, String> parameters)

when i use IDEA to start up my project, use below JVM param, occasionally the response is null
-Darex.service.name=auth-server
-Darex.storage.service.host=<IP_ADDRESS>:8093
-javaagent:/Users/marco/Downloads/workspace/arex-agent-java/arex-agent-jar/arex-agent-0.1.0.jar

Expected Behavior

Get valid response like this

Current Behavior

Get null response

Your Environment

Spring boot version: 2.2.6.RELEASE
Java Version: 1.8
Arex Version: latest

The problems mentioned above have not been reproduced so far, add more dependency configuration information。
<dependency>
    <groupId>org.apache.tomcat.embed</groupId>
    <artifactId>tomcat-embed-core</artifactId>
    <version>9.0.37</version>
</dependency>

<dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-tomcat</artifactId>
    <version>2.2.6.RELEASE</version>
</dependency>

If possible, please provide [GitHub address] to reproduce this issue.

This issue will be closed. If you have more infomations, please reopen and add it.


Migrate from secrets to credentials

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

What are we trying to do?

Right now we use the (quite old) style secrets file. Let's move over to using the new-style configs/credentials/ files

What feature or behavior is this required for?

Keeping up with Rails Norms

How could we solve this issue? (Not knowing is okay!)

After a bit of research, let's follow the per-env key migration route. That best matches our current setup.
This article has a good step by step.
Development & Test

create a development.key & test.key
run the rails commands to set up each of their credential files
remove the secrets file & update the .gitignore
replace any reference to Rails.application.secrets with Rails.application.credentials
commit these keys, creds, and code changes to the repo
confirm the app still runs successfully locally

via docker
via bare-metal install
in test runs

Production
Either @colinxfleming or @lomky should handle this.

generate the production.key
run the rails commands to set up its corresponding credential file
commit only the credential file to the repo
in Heroku, set RAILS_MASTER_KEY to the production key
confirm functionality in Sandbox
release to production

Final cleanup

delete the old secrets file

Anything else?

S/o to the work done in #3128 & #3220 for kicking this off!

I think there's a second strategic point here, which is to make a new environment for sandbox that duplicates production, so we can have a different key file. I'll commit to dealing with this shortly.

I'm shocked this is the first time I've done this on this project, but I accidentally pushed straight to main instead of a branch, ha. The commit setting up the ability to use a staging environment is in https://github.com/DARIAEngineering/dcaf_case_management/commit/f70d63400a291f2f9bbb8349021a1e6178063243 and I'll move our actual staging environment to use that later. Should be a noop more generally.


Create test suite across pinot releases and services

We should write a test suite that verifies that pinot releases are compatible with each other in terms of segment format, zookeeper data formats, protocols between components, etc.  Something like this may help decide if we have a strict deployment order for a release or an y random deployment order will work.
We will need to start zk and kafka, and keep it running throughout the test, while starting and stopping other components in old and new releases. With four components, each one being in old or new release, we have 16 possible release pairs to test. If we want to test things in a set upgrade order, then we have only 4.
We can choose to add downgrade tests as well.
For each combination, we could:

refresh an offline segment
push a new offline segment
(push to kafka and) consume enough rows to create at lease one new segment
execute some simple queries with expected results at each stage.

The goal of this test is not to test any individual component (e.g. does retention manager work right), but to test that operations done in one release works consistently when another release is started on any component.
We can grow the suite by adding more tests as we see fit

Related issue https://github.com/apache/incubator-pinot/issues/5490

Sailesh Nankani https://www.linkedin.com/in/sailesh-nankani/ is currently working on this

Looks like this is a duplicate of #4854 so we can track discussions there. Closing this one

PR #7149, PR #7108, PR #7105, PR #7103, PR #7074, PR #7024, PR# 7020, PR #7011, PR #6959, PR #6550, PR #6160, PR #6129


[feat] tauri migrate shoud migrate main bin name to product name

Describe the problem
#9375 removed renaming binary to product name specified in Tauri.toml.
However, this is not migrated with tauri migrate and unexpectedly broke user installed shortcuts
Describe the solution you'd like
I think it's much better to migrate main bin name to product name in tauri migrate command.
I'm going to create issue for documentation.
Alternatives considered
No response
Additional context
No response

Can you explain how #9375 broke your user shortcut? did you update from a version that was using tauri@beta?

Hey @anatawa12, we are running into the same issue, I'm gonna try adding an option to get the compatible v1 behavior here https://github.com/gitbutlerapp/tauri/pull/1

fixed in https://github.com/tauri-apps/tauri/pull/10977


Can't patch youtube

Using latest revx version and patching supported YouTube version. Any ideas?

Project has been discontinued for now. Remove RevX and use the original Revancify as it has been recontinued.


Fix Kube version for e2e test

Issue #, if available:
Description of changes:
Fix Kube version for e2e test and update it to 126.
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.15


Outline-Client does not install on windows 10

hello i have a promlem

Outline-Client does not install on windows 10 give me  Messages

OS: windows 10
chrome
1.3.3

You can do two things here:

Uninstall just everything regarding Outline. Whether it be it's files, cache, and also if it has a folder in the system registry. After that, clean install the Outline Client/Manager and see if the issue persist.
If it does, you can check out your antivirus settings or your firewall settings. Many times it happens that applications are not allowed to be installed on some devices due to it's antivirus system. So, that can be a considerable point.

It worked . I cleaned everything, closed the anti-virus and firewall and installed it . Thank you very much .

Glad this worked for you @ahmed9560. Thanks @iamsid47 for the workaround.


Bug reports

Please add a prominent link to cncf.ci saying:
"Please report any bugs by reporting an issue on https://github.com/crosscloudci/cross-cloud" like on https://k8s.devstats.cncf.io/dashboard/db/dashboards?refresh=15m&orgId=1

This issue was moved to crosscloudci/crosscloudci#2


Shift+Right-Click?

Love this mod! But there's one tiiiny little issue. It still shows the animations on shift+right click, which causes placement of Placeable Items to not work anymore. If you could make the animations only play when used normally it would be perfect. Thanks for making such an awesome addition to minecraft, it really adds so much to immersion~.

There is the "Skip Animation" key bound to X by default you can hold when right clicking.

Ok that's helpful! I didn't see that option. I changed it to shift, which is the same as Placeable Items, so I don't have to contort (shift+x+right-click) to get it to work.

Glad it worked out.


Flushing interval not configurable

While migrating from signalfx-nodejs-tracing (npm: signalfx-tracing) users might be unable to set the flushing interval to a desired value, if they needed to customize that setting previously.

It's configurable via OTEL_BSP_SCHEDULE_DELAY, however the BSP itself does not work properly at the moment (https://github.com/open-telemetry/opentelemetry-js/issues/3094)


Allow Python 3.8

Some projects are stuck with older versions of python.  This PR brings in support for python 3.8 and 3.9 instead of just 3.10.

That was easy!  :]


Locations can be created but not destroyed?

FireHole can be created via:
hammer_location FireHole
However, there seems to be no way to delete the object? Remove Anything doesn't work as it doesn't seem to have a target point to aim at.

You might need ESP mod to enable visual rays for locations.

Just tried it out, esp_enable * unfortunately doesn't show any data for FireHole


Add /health endpoint

Currently does nothing but return an empty 200 page. We need something
for the ALB to use in the upcoming http -> https work.

@ntwyman Updated.


2017 is out.

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Tracking 2017 versions now that RTM is out.
As soon as MS cares to publish LifeCycle updates I'll take care of the provisional "2027-10-02" supporteduntil.

PARRRRRTY!


Input is stateless, using a namespace (similar to a logger) could be better than a singleton class.

          `Input` is stateless, using a namespace (similar to a logger) could be better than a singleton class.

Originally posted by @ntut-rick in https://github.com/ntut-open-source-club/practical-tools-for-simple-design/pull/30#discussion_r1292301658

This is done with #34 so I'm closing this issue.


[RESTEASY-2042] Fix resteasy-jaxrs module dependencies

https://issues.jboss.org/browse/RESTEASY-2042

Is this optional?
Reading the JIRA I don't understand why this is needed at all. Looking at the code in the description I don't see any MP config API involvement directly or transitively. Is there something about our mp-config subsystem integration with CDI that causes the need for it?
@jmesnil @jfdenise FYI.

@bstansberry , the way the MicroprofileClientBuilder currently is implies that the dependency has to be there is the MP REST client is used. See https://github.com/resteasy/Resteasy/blob/3.6.1.Final/resteasy-client-microprofile/src/main/java/org/jboss/resteasy/client/microprofile/MicroprofileClientBuilder.java#L53 .

@asoldano we should probably use WFLY commit ids rather than RESTEASY


MAC (osx) not working

Hi,
Why the mac version is released without a simple test before. The app does not start at all.
After little research, I found that the Symbolic links in the Framework folder are invalid.
Instead, a link to real files located in each framework are just plain files, it must be a link for Versions/A/.
Examples:
ls -l WebchainWallet.app/Contents/Frameworks/Electron\ Framework.framework
total 24

-rw-rw-r--@ 1 garrylachman  staff   35 Jul 12 03:13 Electron Framework
-rw-rw-r--@ 1 garrylachman  staff   26 Jul 12 03:13 Libraries
-rw-rw-r--@ 1 garrylachman  staff   26 Jul 12 03:13 Resources
drwxrwxr-x@ 4 garrylachman  staff  128 Jul 12 03:13 Versions

in this case the Electron Framework must be a symbolic link to
WebchainWallet.app/Contents/Frameworks/Electron\ Framework.framework/Versions/A/Electron\ Framework
Now it's just a plain text file contains:
`Versions/Current/Electron Framework
All symbolic links are invalid.
Garry Lachman
`

Hi, please can you give more details about the version of MacOS that you use? Because the wallet is working fine on Mac OS 10.13 High Sierra

I can confirm aswell, doesn't work on mac OS 10.15
Will it be fixed ?

I am currently on Mojave and it doesn't work either


Accecibility notes on navs

Navs have a section for accessibility notes.
Since most users will just copy and paste the code snippets and hardly anyone will actually read the docs I wonder if we should bake accessibility into every code snippet.
I know it will be way more verbose and it might not show the point of the example, but the dent Bootstrap can make just be changing this would be huge!
@patrickhlauke What do you think? If you like this idea I can work on a PR

The examples provided in the docs mostly aim to provide twbs users the visual output of a given class/component; hence accessibility is out of the scope for this kind of usage; isn't it?

@Fouzyyyy you are right, the examples on navs are to provide class information. But I couldn't disagree more with it. We have accessibility roles and aria tags all over the place on other parts of the docs and @patrickhlauke is doing an amazing job trying to make things accessible.
Accessibility should be one of the main concerns of any front end implementation, if we can get baked in accessible snippets we will be sure that the "copy and paste" users of the docs will end up with an accessible website.
That is a HUGE impact due to the amount of bootstrap users.
An accessible web is a better web, and we can make a difference just by making snippets accessible.

Feel free to submit a PR (which I guess for the <ul> based examples will simply mean having a <nav> or <div role="navigation"> wrapper...)

@andresgalante I understand, ideally the accessibility must be taken into account in any piece of code, whether it's an example code or production one.
Are you submitting a PR? did you identify all the docs examples that must be altered? I can help with this if needed.

Hi @Fouzyyyy thanks a lot for the offer 😄  I did submit a PR yesterday but it was wrongly linked to the issue, I just fixed the reference.

In general, always happy to see PRs that improve things where they may be lacking :)
I would suggest splitting any effort up into small chunks, though (rather than working on a massive single pull request). Makes it easier to review/discuss on a case by case basis if there's any doubt, or if it comes down to opinion/taste rather than being a clear error/omission. And means that smaller good additions can be merged more quickly without being held up by those other ones.

Should this be closed for more specific issues?

yes i think it would be best to have case-specific issues/PRs here - makes it a bit clearer.

(and yes, if the main concern was that primary navigations should be given a role="navigation" or be wrapped with a <nav>, it's perhaps dangerous to include that in the various examples, as then you may end up with the opposite effect - people adding those everywhere, even when what they're using them for is NOT primary navigation. which is not a major problem per se, but if a page has more than one navigation landmark, it immediately reduces the usefulness of such a landmark to assistive tech users, as it makes it MORE difficult for them to work out which one exactly is the primary navigation)


Undefined is not a function - with-conditionals.js

Describe the bug
'Undefined is not a function', happens somewhere inside Nativewind's code. It comes out of the node_modules/nativewind/dist/runtime/native/styled/with-conditionals.js" file.
To Reproduce
Cannot show due to being a private application. I've used 2.0.0 before and everything seems to be working, but when I upgraded to 3.0.0, this happened.
Expected behavior
Should work after compilation and loading the application.
Expo Snack
It's a React Native app
Screenshots

Additional context
For some reason, my Login page styling works but other wont. I have tried changing the 'content' in tailwind.config.js to different directories but it does not seem to help or dissolve the issue.
The issue even persists when I don't set a path at all in my tailwind.config.js.
NativeWind: warn - No utility classes were detected in your source files. If this is unexpected, double-check the 'content' option in your Tailwind CSS configuration.

Update: I also have these weird warnings:
WARN  'new NativeEventEmitter()' was called with a non-null argument without the required 'addListener' method.  WARN  'new NativeEventEmitter()' was called with a non-null argument without the required 'removeListeners' method.  WARN  'new NativeEventEmitter()' was called with a non-null argument without the required 'addListener' method.  WARN  'new NativeEventEmitter()' was called with a non-null argument without the required 'removeListeners' method.  WARN  Require cycle: src/config/store.tsx -> src/models/index.ts -> src/models/measurementArchive.ts -> src/config/api.ts -> src/config/apiConfig.ts -> src/config/store.tsx

This should be fixed in the v4 release


Allow media picker to yank relative image links

Proposed change

For daily/weekly entries, the media picker was just chopping the home directory off the media file's path, yielding broken image links. This uses the existing make_relative_path function to get the same behavior we see in the image pasting feature already.
Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (thank you!)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation update

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:

Checklist

[x] I am running the latest version of the plugin.
[x] The code change is tested and works locally.
[x] There is no commented out code in this PR.
[x] The code has been formatted using Stylua (a .stylua.toml file is provided)
[ ] The code has been checked with luacheck (a .luacheckrc file is provided)
[ ] The README.md has been updated according to this change.
[ ] The doc/telekasten.txt helpfile has been updated according to this change.

Thank you for this PR!


Update usecases.rst

Correct the link | the target page link has been removed.

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


Update windows-update-troubleshooting.md

issue #4151
remove the broken link

Thank you @MaratMussabekov .
@nenonix and @JohanFreelancer9 for copy review please. Thank you.

Dear @JohanFreelancer9,
your recommendations were applied,
Thank you!

Hello @greg-lindsay this pull request has been copy edited and is ready for your final review and approval. Please let us know if there are outstanding issues to be resolved prior to merge. Thank you. See: commits and changes.

Hi again @greg-lindsay if time permits, kindly review and approve this PR that contains removal of the broken link. Right now, users clicking the link are getting redirected to a 404 page. We appreciate the help, thank you.
CC: @AndreaBarr

Hi again @greg-lindsay and @AndreaBarr I'd like to follow-up on the status of this pull request. Can you please review and merge if there are no issues? Thank you so much.

Hi @greg-lindsay and @AndreaBarr just following up again. Kindly review this PR when time permits. We appreciate the help, thank you.

Hi @greg-lindsay following up again on this open PR. We hope you can review this soon. @AndreaBarr can you please check as well? Please let us know if there are issues. Thank you again.

Hi again @AndreaBarr would you be able to assist? This PR has been opened for 2 weeks and it contains a fix to a broken link (the target page of the outgoing link doesn't exist anymore). Thank you so much.

Thank you once again @AndreaBarr!


[proposal] General ID vs name usage at CLI

Description
Many resources can be identified by a unique ID or by a name (within a workspace or organization scope). This proposal wants to define a long term solution to how to use them at the CLI. Some resources have the problem that the current API do not have any endpoint to query them by name, to use them currently we need to request the full list and search them locally.
The workspace
Can be identified using a long id or with unique workspace name + organization name.
Proposal:

At workspaces subcommands use -n/--name for the workspace name, -o/--organization for organization name and -i/--id for ID. Do not use the TOWER_WORKSPACE_ID env variable here.

If there is only one organization the option -o/--organization will be optional.

At other subcommands use always -w/--workspace optional option to pass the id or to pass the name organization_name/workspace_name. We can use the / to detect that is a name.
The TOWER_WORKSPACE_ID will be used if available. Issue: https://github.com/seqeralabs/tower-cli/issues/63

Examples:
tw workspaces delete -i <WORKSPACE_ID>
tw workspaces view --id <WORKSPACE_ID>
tw workspaces add -n <WORKSPACE_NAME>           (only name is available on insertion)
tw workspaces update --name <WORKSPACE_NAME>

tw compute-envs ... -w <WORKSPACE_NAME_OR_ID>
tw actions ... -w <WORKSPACE_NAME_OR_ID>
tw credentials ... -w <WORKSPACE_NAME_OR_ID>
tw participants ... -w <WORKSPACE_NAME_OR_ID>
tw pipelines ... -w <WORKSPACE_NAME_OR_ID>
tw runs ... -w <WORKSPACE_NAME_OR_ID>

Organization
Can be identified using a long id or with unique name. Notice that an organization name with only digits is not valid.
Proposal:

At organizations subcommands use -n/--name for the name and -i/--id for ID. Do not use the TOWER_WORKSPACE_ID env variable here.

At other subcomands use always optional option -o/--organization that accepts both things. We can use the fact that the id is only digits to detect id vs name.

Examples:
tw organizations view -i <ORG_ID>
tw organizations delete --name <ORG_NAME>
tw organizations add -n <ORG_NAME>           (only name is available on insertion)
tw organizations update --id <ORG_ID>

tw members ... -o <ORG_NAME_OR_ID>
tw teams ... -o <ORG_NAME_OR_ID>
tw collaborators ... -o <ORG_NAME_OR_ID>

Pipelines
Can be identified using a long or a unique name at the organization level. Notice that a pipeline name with only digits is not valid.
Proposal:

At pipelines subcommands use -n/--name for the name and -i/--id for ID.

Only the tw launch uses the pipeline and it's a special command. Here we'll keep using the positional parameter that accepts the name of the pipeline or a Nextflow URL repo.

Examples:
tw pipelines delete -i <PIPE_ID>
tw pipelines export --id <PIPE_ID>
tw pipelines import -n <PIPE_NAME>        (only name is available on insertion)
tw pipelines add --name <PIPE_NAME>        (only name is available on insertion)
tw pipelines update -n <PIPE_NAME>
tw pipelines view -i <PIPE_ID>

tw launch <PIPELINE_NAME>
tw launch <PIPELINE_ID>         (do we want to accept this? theorically is possible to automatically detect this case)

Runs
Can be identified using a random string ID. It is only used at runs subcommands.
Proposal:

At runs subcommands use -i/--id for ID

Examples:
tw runs view -i <RUN_ID>
tw runs relaunch --id <RUN_ID>

Actions
Can be identified using a random string ID and a unique name (at workspace scope). It is only used at actions subcommands.
Proposal:

At actions subcommands use -n/--name for the name and -i/--id for ID.

Compute Environments
Can be identified using a random string ID and a unique name (at workspace scope).
Proposal:

At compute-envs subcommands use -n/--name for the name and -i/--id for ID.

At other commands use -c/--compute-env that accepts both things. First check if the name exists, if not use it as an ID.

Examples:
tw compute-envs view -i <CE_ID>
tw compute-envs import -n <CE_NAME> ...

tw runs relaunch --compute-env <CE_ID> ...
tw launch -c <CE_NAME> ...

Credentials
Can be identified using a random string ID and a unique name (at workspace scope).
Proposal:

At credentials subcommands use -n/--name for the name and -i/--id for ID.

At other commands use -c/--credentials that accept both things. First check if the name exists, if not use it as an ID.

Examples:
tw credentials add aws -n <CREDS_NAME>

tw credentials delete -i <CREDS_ID>

tw compute-envs add gke -c <CREDS_ID>
tw compute-envs add gke --credentials=<CREDS_NAME>

Related issues:
https://github.com/seqeralabs/tower-cli/issues/88
https://github.com/seqeralabs/tower-cli/issues/63

Thanks @jordeu (@swampie ) and sorry, I did not read until now. Will follow the instructions when I retake the issue.

Just to have it clear, and as a general rule, we will be using a name or ID convention for resource referencing here; meaning I can reference a CE by name or ID.

When name and id are both strings, search first by ID (credentials and CE)


[filer.backup] avoid backup truncated files

Describe the bug
failed backup if new_entry contains delete_chunks:true
System Setup
weed filer.backup -filerPath "/"
3.57
replication.toml:
[sink.s3]
enabled = true
aws_access_key_id = "xxxx"
aws_secret_access_key = "yyyy"
region = "us-east-2"
bucket = "backups"
directory = "/docs"
endpoint = "https://storage"
is_incremental = true

Expected behavior
Skip backup there is a delete_chunks:true flag
Additional context
E1110 20:37:02.241428 filer_pb_tail.go:89 process directory:"/documents/8/7/2"  event_notification:{
new_entry:{name:"87279e8754b8d728c696c47445ebaf10-thumb-bak"  chunks:{file_id:"8,679a6278ced870"  size:14490  modified_ts_ns:1692373608704630899  e_tag:"zT9IpGyOtAT5/jgfmOD+eg=="  fid:{volume_id:8  file_key:6789730  cookie:2026821744}}  attributes:{file_size:14490  mtime:1678822702  file_mode:4
20  uid:990  gid:990  crtime:1692373608  mime:"image/jpeg"  inode:9740092430445530816}}  delete_chunks:true  new_parent_path:"/documents/8/7/2"  signatures:1520837357  signatures:-1416986718}  ts_ns:169237360870954990
1: create entry1 : RequestError: send request failed
caused by: Put "https://storage/backups/docs/2023-03-14/documents/8/7/2/87279e8754b8d728c696c47445ebaf10-thumb-bak": http://<IP_ADDRESS>:8080/8,679a6278ced870?readDeleted=true: 404 Not Found

it seems the https://storage/backups/docs/2023-03-14/documents/8/7/2/87279e8754b8d728c696c47445ebaf10-thumb-bak file was updated later. So it should be fine to skip current error.

Here is the full response:
E1110 20:37:29.028503 filer_pb_tail.go:89 process directory:"/documents/8/7/2"
event_notification: {
 old_entry: {
 	name:".872809481ab4c04988b491bd70b73fc4-thumb-bak.vVA5U6"
 	chunks: {
 		file_id:"12,679aa70782687a"  size:4949  modified_ts_ns:1692373609852264590  e_tag:"263CbIf79wu/MdKN5RP6sw=="
 		fid: {
 			volume_id:12  file_key:6789799  cookie:125986938
 		}
 	}
 	attributes: {
 		file_size:4949  mtime:1679121311  file_mode:384  uid:990  gid:990  crtime:1692373609  mime:"image/jpeg"  inode:10511126301643284507
 	}
 }
 new_entry: {
 	name:".872809481ab4c04988b491bd70b73fc4-thumb-bak.vVA5U6"
 	chunks: {
 		file_id:"12,679aa70782687a"  size:4949  modified_ts_ns:1692373609852264590  e_tag:"263CbIf79wu/MdKN5RP6sw=="
 		fid: {
 			volume_id:12  file_key:6789799  cookie:125986938
 		}
 	}
 	attributes: {
 		file_size:4949  mtime:1679121311  file_mode:420  uid:990  gid:990  crtime:1692373609  mime:"image/jpeg"  inode:10511126301643284507
 	}
}
delete_chunks:true new_parent_path:"/documents/8/7/2" signatures:1520837357 signatures:-1416986718
}  ts_ns:1692373609855693995: create entry2 : RequestError: send request failed
caused by: Put "https://storage/backups/docs/2023-03-18/documents/8/7/2/.872809481ab4c04988b491bd70b73fc4-thumb-bak.vVA5U6": http://<IP_ADDRESS>:8080/12,679aa70782687a?readDeleted=true: 404 Not Found

Perhaps the fact is that the temporary file was deleted before the backup event was processed


Release 1.2 WIP

Any hope on 1.2? There are so many PR's and issues. You reply almost all of them but 1.2 branch is on hiatus for a long time now.

@Cediddi 1.2 will be coming.  It's not dead..you'll see some new commits today in fact :)

renamed the branch, which closed this PR.  active PR: https://github.com/amoffat/sh/pull/332


Slack bot in/out nodes do not have default label names

The slack bot in/out nodes do not have default label names as the general slack node does.
The labels are set to either the node name or the empty string using the below code in slackpost.html.
label: function() {
    return this.name||"";
},

This means that when the node is dragged onto the node-red workspace it is unnamed and it's hard to know what node it is unless you recognise the slack logo.
I'm happy to create a PR for this change.

Thanks for raising @annaet
If you could create a PR that would be awesome.
Otherwise I'll try to take a look into this soon.

Resolved by 2.0.0.


JIRA Closed issue status is not updated in DefectDojo

Dear Team,
We have successfully push finding into jira but when we close the issue in jira, the status is not updated in DefectDojo
Thanks,
Kondal

@tkr6743  Could you help me with pushing defect dojo issues to Jira.  How did you do that

Hey @tkr6743 Check out #1419 It sounds like it might work for you.


The feature email address listed on the website is down

From @dfsp-spirit on October 5, 2018 14:49
Nature of issue?

[x] Found a bug
[ ] Existing feature enhancement
[ ] New feature request

Most appropriate sub-area of p5.js?

[ ] Color
[ ] Core/Environment/Rendering
[ ] Data
[ ] Events
[ ] Image
[ ] IO
[ ] Math
[ ] Typography
[ ] Utilities
[ ] WebGL
[x] Other: Website

Details about the bug:

The website lists the email address<EMAIL_ADDRESS>where people should can send their work to be featured. but the address is rejected by the mail server at p5js.org.

See https://p5js.org/community/, section 'Create' or search the page content for<EMAIL_ADDRESS>using the search function of your browser (usually CTRL+f) to find the address on the page. Send a test email to the address to see that it's broken.
NOTE: I know the bug template text here asks you to post stuff like this on the forums, but they are closed for registration, so there is no way to do that.
Copied from original issue: processing/p5.js#3253

aha thank you. I will update this

thanks @dfsp-spirit I will update this.
btw the forum should be open for registration.. can you tell me the error you're seeing? or is there a leftover link to the old archived forum somewhere?

From @dfsp-spirit on October 6, 2018 9:11
Hi @lmccart,
yes, the link to the old forum is displayed when you click on the New Issue link here at github. It says:

PLEASE NOTE: The github issues are for bugs and feature requests for the p5.js library itself. If you have a general question or bug programming with p5.js please post it in the p5.js forum: https://forum.processing.org/two/.

And there it says:

We are about to switch to a new forum software. Until then we have removed the registration on this forum.

The text on the "New Issue" for the repo processing/p5.js was fixed,
and also the feature email address was updated to<EMAIL_ADDRESS>with Pull Request #276


Transform the biosample metadata about mCAFE samples into NMDC objects

From NMDC Data Schema / Data Management Team Rolling Notes
SQLite database of NCBI biosample metadata (aka NCBI relational biosample database) has everything but the GOLD paths, which Mark will add a look up

done


org-chef-marmiton-fetch miss some words

I tried
(org-chef-insert-recipe "https://www.marmiton.org/recettes/recette_couscous-aux-calamars_29712.aspx")
Some words are missing ("oignon", "poivron" etc.)

That's no good! I'll try to take a look soon, but if anybody wants internet points (and this to get fixed faster), please feel free to submit a pull request :).

Should be fixed now.


Create offline mode for editing

Enable tile downloading and storage of edits in cache when in offline mode.
Provide update function to update database.
Leaflet Offline
https://github.com/robertomlsoares/leaflet-offline
https://github.com/allartk/leaflet.offline

This is on hold after a PWA test. PWA are now supported on desktop platforms as well as in IOS.


Wrong typing for object

The typing for "object" is wrong in latest release.
The key could be string | number or anything.
This has been changed in latest release.

@meabed can you be more specific?
Is this related to the openapi-client-axios-typegen package?

Thanks @anttiviljami, yes it's the typegen package.

Can you clarify?
What exactly changed? What is the desired/expected behaviour?

Sure,
The previous behavior is swagger with property "object", for example:
"properties": {
  "metadata": {
    "description": "",
    "type": "object"
  }
}

it generate typing
metadata?: {}

After the last update, it generates types as:
  metadata?: {
      [key: string]: any;
  };

Which is wrong because key could be number / undefined / null / string. I think it might be an issue with dtsgenerator?
Thanks!

Hey there,
you should report this error on https://github.com/horiuchi/dtsgenerator (used by : https://github.com/anttiviljami/dtsgenerator)

This is an upstream issue with dtsgenerator but I’ll leave this open for the time being to track

did someone report this already? / any updates?
in my case this happens, when defining: oneOf: [{ type: 'string' }, { type: 'number' }]


ExCL workflow hangs looking for running until an ssh connection is made

A workaround: open a tmux session on milan0 and leave it running after exit

Resolved: https://docs.excl.ornl.gov/quick-start-guides/github-ci#enable-linger-for-your-user

Resolved: https://docs.excl.ornl.gov/quick-start-guides/github-ci#enable-linger-for-your-user


Fixed incorrect preposition usage

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

The preposition "to" is not needed here.

Not incorrect.


ngModel Non Standard Date Formats

Hi there, wanted to start up a new thread than #973, since it may not be exactly the same problem.  The solution that was provided in that issue for using a parser to store the value on the model doesn't work for non standard string formats like "yyyyMMdd" for a date.  I took the solution plunk and created a new one:
http://plnkr.co/edit/yb7AlE?p=preview
This issue is that the injection of a parser into the pipeline doesn't look like its in the $parsers chain of the calendar control with this myformat and errors will come up as such:
Datepicker directive: "ng-model" value must be a Date object, a number of milliseconds since 01.01.1970 or a string representing an RFC2822 or ISO 8601 date.
I believe that in the example from #973 it is able to interpret the model as a standard date format.
Regards

Closing due to inactivity. Please feel free to re-open once you've tested with the latest UI Bootstrap 0.13 and Angular JS 1.3 and can confirm this is still an issue.


name vs title

Currently, the alternate asset extension defines title and description. I think this is not ideal, due to the reasone below:
Here's an example that I've seen in the wild:
{
      "href": "https://example.com/example.tif",
      "type": "image/jp2",
      "file:size": 100015921,
      "file:checksum": "1620a7e5018b93dd4c9b99b379215b6fe924466829154c821c0044ceb6a304dedc61",
      "title": "Green (band 3) - 10m",
      "alternate": {
        "s3": {
          "href": "s3://example.com/example.tif",
          "storage:platform": "OTHER",
          "storage:region": "waw",
          "storage:requester_pays": false,
          "storage:tier": "hot"
        }
      }
    }

The title in the overall asset is a generic title for the file and looks fine. Providing the title again in the sub-asset doesn't make a lot of sense though, it would be the same, just hosted on S3.
STAC Browser implements this extension as a Tab interface. Showing the titles for the tabs doesn't make sense. I've implemented it as such, that it supports a name field to provide short labels for the tab headers.
I'd actually propose to add a name field for such cases to the Alternate Asset Object.
title and description I'd remove and refer back to common metadata, saying that extensions and common metadata fields such as title and description can be used to further define the alternative asset.
The updates example would look like this:
{
      "href": "https://example.com/example.tif",
      "type": "image/jp2",
       "name": "HTTP",
      "file:size": 100015921,
      "file:checksum": "1620a7e5018b93dd4c9b99b379215b6fe924466829154c821c0044ceb6a304dedc61",
      "title": "Green (band 3) - 10m",
      "alternate": {
        "s3": {
          "href": "s3://example.com/example.tif",
          "name": "S3",
          "storage:platform": "OTHER",
          "storage:region": "waw",
          "storage:requester_pays": false,
          "storage:tier": "hot"
        }
      }
    }

and render as such:

See also: https://github.com/radiantearth/stac-browser/commit/47dea4f23968c2bfdb7c3642725c4879b227af35

I'm +1 on all this - dropping title and description and just using 'name' from common metadata.

Reconsidering this - there is already a key used in the alternate dictionary, in this case "s3".   Having a name is a bit redundant, but if there is a name then Best Practices should state that the key and name should be the same.

Hmm, I don't think I agree. Name for me is human readable with spaces, special characters, localization option. A key should be stable and machine-optimized.


workaround new autocomplete crasher

Building against the latest swift-apis reveals a new autocomplete crasher: the autocompleter cannot deal with the "sequenced" method introduced in https://github.com/tensorflow/swift-apis/pull/20.
I tried to investigate a bit, but it's something non-obvious happening deep within substitution map stuff. So I think the safest way to make the autocompleter not crash in v0.2 release is to suppress "sequenced" as an autocomplete result.
https://bugs.swift.org/browse/TF-315 has details about the crash.

@swift-ci please test tensorflow


Add the blob2list() and list2blob() functions

Related e-mail threads on the vim-dev mailing list:
https://groups.google.com/g/vim_dev/c/c82X7U4MD9Y/m/x_Gd9ylRBQAJ
https://groups.google.com/g/vim_dev/c/4CDTjFu-P9A/m/OtS5qTsUCAAJ

check_for_blob_arg() is only used for Vim9 script, but is then followed by another check for VAR_BLOB.
Looks like when using check_for_blob_arg() always the second check can be dropped.
Similarly for check_for_list_arg() in f_list2blob().

list2blob() fails if one of the numbers is negative.  As it is now, a value over 255 ends up overflowing, taking the lower 8 bits.
I think we should also fail if the number is above 255.
This is a bit strict, I suppose if someone wants to do avoids errors filtering the list first would be the solution.

Sorry for the confusion, since it was a small change I already added the check for the number value.  And give an error message mentioning the invalid number, otherwise there is no clue, other than getting an empty result.
I hope this works OK, otherwise we can still change it.

Hi Bram,
On Tue, Sep 14, 2021 at 1:39 PM Bram Moolenaar @.***>
wrote:

Sorry for the confusion, since it was a small change I already added the
check for the number value. And give an error message mentioning the
invalid number, otherwise there is no clue, other than getting an empty
result.
I hope this works OK, otherwise we can still change it.

Your changes look good to me.
Regards,
Yegappan


Game does not resume if paused between waves

Game does not resume properly if paused between waves. The already spawend numbers continue moving, but no new numbers appear.
I assume this issue is caused by the stage delay-time. If the game is paused within this time, GamePhase changes to PAUSED and nextWave()-funtion will refuse to start by returing null.
I recommend to change the position of delay(3000L) before the first attaker of a wave spawns.
Game.kt line 333...
fun onEndOfWave()
    {
        currentWave = null
        GlobalScope.launch { delay(3000L); startNextWave() }
    }

and Stage.tk line 192...
fun nextWave(): Wave?
    {
        if (theGame.state.phase != Game.GamePhase.RUNNING)
            return null
        else if (waves.size == 0)

Okay, I found out that after leaving the stage wich back the  "continueGameButton" on the main menu continues the game properly.

You're right. This may be the cause of several bug reports "no more attackers appear after level xy" which I was never able to reproduce.
Another problem is that the 3 seconds delay does not change when the game is accelerated.

Changed the whole mechanism of how delays are calculated.


Tv anhanguera and Tv Goiania Band - BR  channels

The channels are correct, but why did it fails?
https://mi.tv/br/async/channel/band-tv-goiania/2022-05-23/0
https://mi.tv/br/async/channel/tv-anhanguera-hd/2022-05-23/0

Thank you for your contribution!


Change “enabled” slot on the subgraph to be on/off icon instead

@fthr I'm not sure about this...

is this a button?
would we still connect eg. booleans to the slot?
how does this improve things?

right now all slot names are UTF8 text, personally I don't believe changing english names to icons makes it simpler, on the contrary. thoughts?

This is one of those @mattatgit /redesign-area things that probably shouldn't be an issue yet.


Winston exception handler doesn't handle UnhandledPromiseRejectionWarning

Please tell us about your environment:
"devDependencies": {
"@types/chai": "^4.1.7",
"@types/chai-as-promised": "^7.1.0",
"@types/mocha": "^5.2.6",
"@types/mock-fs": "^3.6.30",
"@types/node": "^11.11.0",
"@types/sinon": "^7.0.9",
"@typescript-eslint/eslint-plugin": "^1.4.2",
"@typescript-eslint/parser": "^1.4.2",
"chai": "^4.2.0",
"chai-as-promised": "^7.1.1",
"eslint": "^5.15.1",
"jest": "^24.4.0",
"mocha": "^6.0.2",
"mock-fs": "^4.8.0",
"sinon": "^7.2.7",
"ts-mockito": "^2.3.1",
"ts-node": "^8.0.3",
"typemoq": "^2.1.0",
"typescript": "^3.3.3333"
},
"dependencies": {
"@types/argparse": "^1.0.36",
"@types/fs-extra": "^5.0.5",
"@types/request-promise": "^4.1.42",
"argparse": "^1.0.10",
"fs-extra": "^7.0.1",
"moment": "^2.24.0",
"queue": "^6.0.0",
"request": "^2.88.0",
"request-promise": "^4.2.4",
"slack": "^11.0.2",
"winston": "^3.2.1"
}
What is the problem?
Throwing Error inside the async function is not handled by Winston exception handler, an error is not being logged so information is lost.
Other information
const _format = winston.format.printf((info) => `[${moment().format('YYYY/MM/DD hh:mm:ss')}] ${info.level}: ${info.message}`);
winston.createLogger({
        transports: [
          new winston.transports.File({
            filename: path.join(<string>EnvVars.get('ROOT_DIR'), 'logs', 'exceptions.log'), // valid path
            format: winston.format.combine(this._format),
            handleExceptions: true
          })
        ]
      })

(async function(){
    throw new Error('test') // not working, exceptions.log is empty
})()

(function(){
    throw new Error('test') // works
})()

test.ts
import {createLogger, transports} from 'winston';

createLogger({
  transports: [
    new transports.File({
      filename: 'exception.log',
      handleExceptions: true
    })
   ]
});

async function main(): Promise<any>{
  throw new Error('test') // not working, exceptions.log is empty
}

function main1(): any{
  throw new Error('test') // works
}

main(); // doesn't work
main1(); // works

After compiling to js and running via cmd - only exception in non-promise type function is handled by winston

I guess a workaround would be to use ->
process.on('unhandledRejection', (reason, promise) => {
        throw reason;
})

And from there Winston would pick up an exception and log it

We added a RejectionHandler https://github.com/winstonjs/winston/blob/master/lib/winston/rejection-handler.js a few releases back -- I think using that will help with your issue!  Might need both exception handler and rejection handler, depending on what kinds of issues you want to catch.  Feel free to follow-up if that doesn't solve your issues.

It seems RejectionHandler class doesn't work as expected... I wasn't able to catch rejections with<EMAIL_ADDRESS>I guess private helper method _addHandler for handler addition was copied from exception handler without any modification.
You use the same flag handleExceptions here instead of handleRejections
`/**

Helper method to add a transport as an exception handler.
@param {Transport} handler - The transport to add as an exception handler.
@returns {void}
/
_addHandler(handler) {
if (!this.handlers.has(handler)) {
handler.handleExceptions = true;
const wrapper = new ExceptionStream(handler);
this.handlers.set(handler, wrapper);
this.logger.pipe(wrapper);
}
}And after that proivate method_getRejectionHandlersfilters assigned transports withhandleRejectionsflag = true  see below:  /*
Returns the list of transports and exceptionHandlers for this instance.
@returns {Array} - List of transports and exceptionHandlers for this
instance.
@private
*/
_getRejectionHandlers() {
// Remark (indexzero): since logger.transports returns all of the pipes
// from the _readableState of the stream we actually get the join of the
// explicit handlers and the implicit transports with
// handleRejections: true
return this.logger.transports.filter(wrap => {
const transport = wrap.transport || wrap;
return transport.handleRejections;
});
}`

yes, the same issue happen on my project, should be a bug anyway


Join the Prowler Slack Community!

Join our Slack workspace using this invite https://join.slack.com/t/prowler-workspace/shared_invite/zt-2luugg3ld-_MlE692tRwAZoMMrZ1sV7w where we provide support and guidance and we have a great community about Prowler.

Hello @jfagoagas,
I have tried to join the Slack channel, but it only allows domains ending with prowler.com. Is it meant only for pro users, or can anyone join?

Hello @JOSHUAJEBARAJ! I've just updated the previous link with a new version since something changed, please let us know if the new invite link works as expected.
Thanks for using Prowler 🚀

Thank you @jfagoagas  , The link worked , Joined the community :)

15d246c6181d72e91123bca89c032db9b50df754

15d246c6181d72e91123bca89c032db9b50df754

Hi
I am new to using Prowler, i am getting the below error
No module named 'alive_progress'
i have created virtual environment  and installed  alive_progress
Thanks

Hey! @amitchandela if you join Prowler slack community  and explain your issue there, we'll help you in a better way!
Thanks for using Prowler! 🚀


gnome3.webkitgtk: 2.20.1 -> 2.20.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/webkitgtk/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/h4aballc6wsb4kj32kcjcx5x4vbax6fj-webkitgtk-2.20.2/bin/WebKitWebDriver -h’ got 0 exit code
ran ‘/nix/store/h4aballc6wsb4kj32kcjcx5x4vbax6fj-webkitgtk-2.20.2/bin/WebKitWebDriver --help’ got 0 exit code
found 2.20.2 with grep in /nix/store/h4aballc6wsb4kj32kcjcx5x4vbax6fj-webkitgtk-2.20.2
directory tree listing: https://gist.github.com/e3496e2d8a6b933a107141f5caecb92d

This contains a CVE fix: https://webkitgtk.org/2018/05/07/webkitgtk2.20.2-released.html, so maybe this should go directly to master after all (and backported to 18.03 if there are no problems).
cc @bendlas

Merged to staging by accident. Also cherry-picked in master: 058e10f2417

Thanks. I switched this to staging before I noticed the CVE fix, and forgot to switch it back...
@vcunat should this be picked to 18.03 (or staging-18.03 maybe) ?

Right, directly (< 500 Linux rebuilds).  Testing the build locally atop 18.03, will push later.

Thanks for watching stuff suitable for 18.03 :heart:


[types/mempool] Update roles so that they are ranked in mempool

Right now we classify all transactions as either "governance" or "non-governance" where governance transactions are prioritized over all non-governance transactions. However, within governance there is no prioritization but we should, in particular LibraRoot and TC transactions should be prioritized over all other transactions including other governance-related transactions.
This PR introduces this ranking for governance transactions.
This should not break client behavior when interacting with the system.

@bors-libra r=christinacelee

:pushpin: Commit a8b2ff0 has been approved by christinacelee

:hourglass: Testing commit a8b2ff098cee68b6fdef96adbafd8e275fa2f3d7 with merge 84d1bbcb6e193ae560830e8c219303a0440af89d...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: christinacelee
Pushing 84d1bbcb6e193ae560830e8c219303a0440af89d to master...


Fix issue 12227 - Allow matching multiple patterns in one go with std.regex

A long awaited feature is in. The helpers for matchFirst/matchAll etc. are not provided but regex can now be constructed with a array of patterns more or less following the API outlined.

Fix and extended matchFirst/matchAll to support multiple strings in one go.

Auto-merge toggled on


PAPP-22739: Mark Github as FIPS Compliant

Update license year
Run pre-commit hook
Mark as fips_compliant

Static test failures

Min Platform Version


fix: readOnly objects in arrays are handled correctly

Addresses #2336
Summary
Currently, given an object with a readOnly required field, Prism does not handle it properly as soon as the object is embedded into an array. Specifically, the user will get an error saying they must manually specify the readOnly property. This PR fixes this issue for all possibilities of arrays: single-typed arrays specified by a single item schema, and tuple-typed arrays specified by a list of item schemas, both with and without the additionalItems schema for tuple-typed arrays.
See: https://json-schema.org/understanding-json-schema/reference/array
And also see: https://tools.ietf.org/html/draft-zyp-json-schema-03 for items type signature (sections 5.5, 6.4, and 6.9) and additionalItems type signature (sections 5.6, 6.4, and 6.10) in the code
Checklist

The basics

[X] I tested these changes manually in my local or dev environment

Tests

[X] Added or updated
[ ] N/A

Event Tracking

[ ] I added event tracking and followed the event tracking guidelines
[X] N/A

Error Reporting

[ ] I reported errors and followed the error reporting guidelines
[X] N/A

Screenshots
--------------------------------------------------READONLY TESTS--------------------------------------------------
Given the following schema (which includes a non-tuple-typed array):
openapi: 3.1.0

paths:
  /pets:
    post:
      requestBody:
        content:
          application/json:
            schema:
                $ref: '#/components/schemas/Pets'
      responses:
        '200':
          description: A pet id
          "content":
            application/json:
              schema:
                type: object
                properties:
                  id:
                    type: integer
                    format: int64
                required:
                  - "id"
                additionalProperties: false

components:
  schemas:
    Pets:
      type: object
      properties:
        objectsArray:
          type: array
          items:
            type: object
            required:
              - id
              - name
            properties:
              id:
                readOnly: true
                type: string
              name:
                type: string
        title:
          type: string
          readOnly: true
        address:
          type: integer
      required:
        - title
        - address

I send the following POST request successfully:

With Prism before this fix, we get an error:

If I change the schema to include a tuple-typed array, with additionalItems specified for demonstration like so:
openapi: 3.1.0

paths:
  /pets:
    post:
      requestBody:
        content:
          application/json:
            schema:
                $ref: '#/components/schemas/Pets'
      responses:
        '200':
          description: A pet id
          "content":
            application/json:
              schema:
                type: object
                properties:
                  id:
                    type: integer
                    format: int64
                required:
                  - "id"
                additionalProperties: false

components:
  schemas:
    Pets:
      type: object
      properties:
        objectsArrayWithAdditionalItems:
          type: array
          items:
            - type: object
              required:
                - id
                - name
              properties:
                id:
                  readOnly: true
                  type: string
                name:
                  type: string
            - type: object
              required:
                - address
                - title
              properties:
                address:
                  readOnly: true
                  type: string
                title:
                  type: string
          additionalItems:
            type: object
            required:
              - status
              - ticket
            properties:
              status:
                readOnly: true
                type: string
              ticket:
                type: string

we see that the fix  works for readonly properties in both the tuple-typed items list, and the additionalItems schema object.

With Prism before this fix, we get an error:

--------------------------------------------------WRITEONLY TESTS--------------------------------------------------
Given the following schema (which includes a non-tuple-typed array):
openapi: 3.1.0

paths:
  /pets:
    get:
      requestBody: {}
      responses:
        '200':
          description: Detailed pet information
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Pets'

components:
  schemas:
    Pets:
      type: object
      properties:
        objectsArray:
          type: array
          items:
            type: object
            required:
              - id
              - name
            properties:
              id:
                writeOnly: true
                type: string
              name:
                type: string
              additionalItems: false
        title:
          type: string
          writeOnly: true
        address:
          type: integer
        additionalItems: false
      required:
        - title
        - address

I send the following POST request and get a response with the writeOnly properties (including the "id" property in the array) excluded as they're supposed to be:

With Prism before this fix, we get the writeOnly property "id" from the array inappropriately included in the response:

If I change the schema to include a tuple-typed array:
openapi: 3.1.0

paths:
  /pets:
    get:
      requestBody: {}
      responses:
        '200':
          description: Detailed pet information
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Pets'

components:
  schemas:
    Pets:
      type: object
      properties:
        objectsArrayWithAdditionalItems:
          type: array
          items:
            - type: object
              required:
                - id
                - name
              properties:
                id:
                  writeOnly: true
                  type: string
                name:
                  type: string
                additionalProperties: false
            - type: object
              required:
                - address
                - title
              properties:
                address:
                  writeOnly: true
                  type: string
                title:
                  type: string
                additionalProperties: false
        additionalProperties: false

we see that the fix works for writeOnly properties in the tuple-typed array -- they're appropriately excluded from the response:

With Prism before this fix, however, the writeOnly properties in the array are inappropriately returned in the response:

@rattrayalex

Thank you for opening this PR! Everything here looks great. After reviewing, we are wondering if these array changes need to be added for writeOnly as well. Is that something you would be willing to add as part of this PR?

Hi Brenda, thanks for the feedback! I thought about this for a moment and realized that the existing PR actually does handle arrays with writeOnly as well (it's independent of the predicate used). I am working on adding some test cases for this and will update shortly!

I've added tests (unit and end-end) showing this works for writeonly. However, I didn't include additionalItems in the tuple typed array for the end-end tests. additionalItems are indeed being filtered correctly for both readOnly and writeOnly based on the unit tests, but there is apparently an unrelated bug in Prism where additionalItems are never returned in the response. See the following repro using the master branch of Prism:
openapi: 3.1.0

paths:
  /pets:
    get:
      requestBody: {}
      responses:
        '200':
          description: Detailed pet information
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Pets'

components:
  schemas:
    Pets:
      type: object
      properties:
        objectsArrayWithAdditionalItems:
          type: array
          items:
            - type: object
              required:
                - id
                - name
              properties:
                id:
                  type: string
                name:
                  type: string
                additionalProperties: false
            - type: object
              required:
                - address
                - title
              properties:
                address:
                  type: string
                title:
                  type: string
                additionalProperties: false
          additionalItems:
            type: object
            required:
              - status
              - ticket
            properties:
              status:
                type: string
              ticket:
                type: string
              additionalProperties: false
        additionalProperties: false

Note how status and ticket aren't included in a third array item.

@brendarearden Hi! Would it be possible to get a follow up review? Thank you!

https://github.com/stoplightio/prism/issues/2519 I opened an issue to track the additionalitems bug you discovered as well!


rule: add verification for labels provided via --label

Fixes #800

Changes
Uses prometheus' LabelName verification to check if labels provided via --label fit the guidelines

Verification
make test and tested various unsupported label names like -.

Added unit tests for parseFlagLabels. Did you have something like this in mind?

Thanks for pointing that out. Adjusted according to your suggestions. Looks a lot cleaner this way :).

Probably :) First time writing Go code, first time contributing to a Github Project so I thought these are the entry level tasks that I need to get up to speed. :)

What? I couldn't see that (: How you found about proper table test template then? (:

I didn't know that it has a name. Also the first time writing a unit test and I figured if we are testing a function we should provide multiple test cases and doing that in an array and looping through it looked like the best way to do this :).


Custom languages in markdown highlight syntax do not generate

What version of Hugo are you using (hugo version)?

$ hugo version
0.74.3

Does this issue reproduce with the latest release?
yes
Setup
We use prism.js as syntax highlighter and we added programmatically support for new languages.
Problem
``` test
nice source code
```

does not generate the enclosing

.
As a result the css styling is partially broken.

Can't reproduce.
i'm on
Hugo Static Site Generator v0.75.0-DEV-E5591E89/extended linux/amd64 BuildDate: 2020-07-29T01:53:59+0700

please close this issue and move to https://discourse.gohugo.io

I do not why but this seems to be an intended behavior as a test case says.
An easy workaround is using html in markdown

``' test
nice source code
``'

Note: Please make markup's unsafe setting true in your config.toml like
[markup]
[markup.goldmark.renderer]
unsafe = true

See config section in docs


feat(moduletemplate): Wrap function module template wrappers with parens

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
No, just updated existing expected output.

If relevant, link to documentation update:

Summary
This back-ports c7b06ad617e7a3ea1d554214509d368c456996bb to webpack-1 based on the Twitter thread for the original PR (#3658).

Does this PR introduce a breaking change?
No

Other information
This is my first webpack PR, so please let me know if there's anything I need to fix!

Current coverage is 11.76% (diff: 100%)

Merging #3661 into webpack-1 will not change coverage

@@           webpack-1      #3661   diff @@
===========================================
  Files              1          1
  Lines             34         34
  Methods            5          5
  Messages           0          0
  Branches           6          6
===========================================
  Hits               4          4
  Misses            30         30
  Partials           0          0

Powered by Codecov. Last update e666686...2def8b4

I should note that npm test made changes to bin/webpack.js, which I did not include in the commit. Is that correct?

@sokra would you mind reviewing this one. Since I haven't been involved with the v1 code I just want to ensure another pair of eyes on it before merging into stable v1.


'About Us' page needs new hero image

The image includes an employee who's head gets cut off on larger screens.

Closed via 552e721226514c29e8ab050f5bdf963e5d03ee41


support casper JS features

based on this idea it will be great to have wrapper for all the casperjs features using JS.
Thanks

Thank you for this feature


Sprite3D zIndex is not applied to internal ProjectionSprite zIndex

The standard pipeline sorts its ProjectionSprites by zIndex, but as far as I can tell, there is no way to set this internal ProjectionSprite zIndex value through Sprite3D.
As a workaround I had to extend Sprite3D like so:
export class Sprite3DWorkaround extends Sprite3D {
  get sprite(): { zIndex: number } {
    return (this as unknown as { _sprite: { zIndex: number } })._sprite;
  }

  override get zIndex(): number {
    return this.sprite.zIndex;
  }
  override set zIndex(value: number) {
    this.sprite.zIndex = value;
  }
}

I believe Sprite3D should redirect getting and setting zIndex to its internal ProjectionSprite, just as it does for other sprite properties (like anchor, tint, texture, and blendMode)
So I've created a simple pull request for that here: https://github.com/jnsmalm/pixi3d/pull/156

Thanks! It's correct, it should have the zIndex property exposed.
But, for this to have any effect right now you also need to set depthTest = false on the sprite renderer (which is available on the standard pipeline, but only as a private property). So right now something like:
app.renderer.plugins.pipeline._spriteRenderer.state.depthTest = false
Just curious, did you do this as well for your zIndex fix to function correctly or did you do anything else?

@jnsmalm I didn't have to change depthTest or anything else to fix my specific layering issue, but to be fair, I just started the process of implementing our sprite system using pixi3d yesterday, so I haven't tested things too deeply yet!
The layering issue I was encountering can be replicated like so:

Spawn a large Sprite3D with a texture and rotate it to be the "floor" plane.
Set the zIndex of the floor to be very low like -1000.
Spawn a few billboarded Sprite3D's at various positions on top of the floor plane (like the bunnies example)

Result: Any Bunnies rendered at the top half of the screen render with their boundary box incorrectly "obscuring" the floor plane texture.
Simply redirecting the zIndex property fixed that issue foe me without needing to change any other code.

@jnsmalm (Just as an overall note, I find it easier to work with typescript libraries that default to using protected backing fields in their classes instead of private ones. That way you can still keep the public facing interface clean, but us end-users can easily implement temporary workarounds, while we wait for a fixes/version updates from the library author. Just a suggestion, of course!)


Fixed tests and compatibility with bourbon. See issue #27

Thanks! I've been swamped with work, so this helps immensely.


Syntax support in Webstorm

Hi!
I'd like to thank you for this awesome e2e solution. Keep up with the great work!
I'm wondering if there is a way to have the API be recognizable in Webstorm IDE?
I've had it installed both globally and then locally, but the syntax is not recognized.
I've added the screenshot of the problematic behavior in question.
Also, I have tried searching through the Webstorm's Javascript libraries > TypeScript community stubs, but with no success.

system: Windows 10:
testcafe: 0.16.2:
node: 6.10.0:

TestCafe bundles the TypeScript declaration file with the npm package, so you do not need to install it separately. As I now WebStorm should load TestCafe declaration file automatically if you have installed testcafe package locally.
We've tested it on the WebStorm v2017.1.3 (see the screencast). What WebStorm version do you use?

I'm using the 2017.1.4 version of the Webstorm.
I have no code quality tools enabled at the moment of testing.
I wonder about the list of Webstorm's Javascript Libraries in that Webstorm? In mine, I've disabled everything except HTML and it looks like this:

And here is the list of libraries in my IDE:

Please, export your WebStorm settings and send them to us.

Sure thing, Here it is!
settings.zip

I've imported your settings and my WebStorm still indexes typescript definitions from TestCafe.
Please, hover the cursor over the hightlighted word with an error and provide the displayed error message (as in video).
I've reproduced your issue when I turned off the Use TypeScript Service option.

Make sure that typescript is installed and WebStorm finds it.
Then check that Use TypeScript Service option is turned on.

I've, actually, never used typescript before.
Is it necessary to use it with Testcafe?

TestCafe does not require TypeScript for creating tests. TypeScript is used for IDE code completion. So, the TypeScript Service should be enabled if you wish to use code completion for your IDE.

Hi Marina,
I've installed TypeScript 2.4.1 globally and have configured it, as shown in the image bellow, but the highlighting did not change.

I was able to get basic autocomplete in JS tests by adding node_modules/testcafe/ts-defs/index.d.ts as a JS library in PhpStorm settings:

Result:

Thanks, @Leksat.
Your suggested solution worked for me as well.