Sphix not in setup.py

make dist which depends on make update-docs fails saying
build/virtualenv/bin/sphinx-apidoc --no-toc -d 5 -H WellcomeML -o ./docs -f wellcomeml
make: build/virtualenv/bin/sphinx-apidoc: No such file or directory

possible fix pip install sphinx

After installing sphinx with pip install sphinx i got
Could not import extension sphinx_rtd_theme (exception: No module named 'sphinx_rtd_theme')

Ah damn, this was probably caused by removing the requirements.txt!

Oh no, there is a docs requirements. The make dist command was developed before the docs. We need to pip install -r docs/requirements.txt

Fixes by 4f0d495d5393d9686afd2551067b32c096bbab46 but we can also go with your suggested fix which probably makes more sense

Hmm, on second though this problem should not have occured due to https://github.com/wellcometrust/WellcomeML/blob/3a8097b8c4c27ce4e4abfb62f488ce9041a8fbb3/Makefile#L11
So maybe it happened because i had not recreated the environment. Let me try this.


Optimise XmlNodeConverter

Short-circuit SerializeGroupedNodes on no child nodes: Avoids creating unused Dictionary.
Don't create Dictionary in ReadAttributeElements if it'll be empty.
Reduce calls to JsonReader.TokenType virtual property.

I thought about it some more after the review and I wrote this - https://github.com/JamesNK/Newtonsoft.Json/commit/96fc838858096a7be4167b8d0deeaf8803ffc0d3
It keeps all the tests for HasChildNodes and HasAttributes internal to the wrappers. XmlNodeConverter will happily use the collections.
If you remove the last commit then I'll squash the others then add mine.

That's out. I added two comments on your commit (one minor but does have an impact, one trivial).


Use LspProgressUpdate event to handle progress

Use LspProgressUpdate event instead of hooking vim.lsp.handlers["$/progress"] directly, as discussed in #51.
I'm not using vim.lsp.util.get_progress_messages(), because it doesn't return token, and it's actually private for now, maybe not ready for users. I don't want to change current code structure too much, so in handle_progress() I just iterate client.messages like what get_progress_messages() did.
By the way, I found that is_installed() doesn't work due to commit e87666ce9420da887eff4e56430317a0acd8ad5e, and did a little tweak. But I wonder if this function is really necessary.

Hi, @ZenLian , have you tested this PR with null-ls?
I have tried to use LspProgressUpdate and API vim.lsp.util.get_progress_messages to implement my progress in lualine.
But internal neovim runtime, there is error when listening LspProgressUpdate event for null-ls.
I am looking for solutions to solve this.

@linrongbin16 What's the error message?
I dont know if I can help :( It's been quite a long time, maybe this PR is outdated, I should close it.

Superseded by #143. But thanks for putting in the effort! I really do appreciate it.


Controlnet

I updated to the latest release 1.2.0 but I cant find the Controlnet options...
More over, I activated it in settings under stable diffusion but still cant find it ;-(
What am I missing?

ControlNet is not an independent model, so it does not appear in the settings. You can use the following options to start the service:
--model sd1.5 --sd-controlnet --sd-controlnet-method control_v11p_sd15_canny

Thanks for the reply @Sanster
I really dont know where to add this argument, I am using the one click installer, is that why?

One more question please, when I am using the latest update I am not geting alphachannel from remove background.
so it is saving .png but with bkacj background not transparant any idea why?
Please help me on fixing this for alpha channel in remove BG and where to use --model sd1.5 --sd-controlnet --sd-controlnet-method control_v11p_sd15_canny

ControlNet

Set Stable Diffusion model(Currently there is a bug where if the initial model launched is not an SD model, ControlNet will not take effect.) as the initial launched model: sd1.5/anything4/realisticVision1.4

Enable ControlNet in the Diffusion Model tab

Remove background issue
I did not reproduce this issue. My PNG images have transparent background layers after being saved.
my test image:

remove bg resule:

@Sanster Thanks a lot, once I set sd1.5 it work as expected.
Regarding removeBG I test your image and below is the output:

rembg alpha channel issue fixed in 1.2.1

Yes I can confirm it is working now... thank you!


View uploaded files without needing to be logged in to the realm in the browser.

Closes #3303.

@chrisbobbe @gnprice this PR is ready for a review.

@chrisbobbe @gnprice this PR is ready for a review.

Great, glad to have this so quickly! Looking now.

@chrisbobbe I force pushed some non-trivial changes after you commented.

@chrisbobbe I force pushed some non-trivial changes after you commented.

Yep, thanks! I saw the update and I'm looking at the series up to 9c0b4bc now.

@chrisbobbe there were some errors in the code. I've pushed some changes. Apologies for the inconvenience. I've thoroughly tested now.

@chrisbobbe there were some errors in the code. I've pushed some changes. Apologies for the inconvenience. I've thoroughly tested now.

No problem! 🙂 I actually hadn't gotten very deep in my review when I took a break to eat lunch; back now.

@chrisbobbe Thanks for the review!

Also, if the browser decides it can't display it, it triggers what seems like the platform's preferred way to download a file.

 Even on Android, if the browser can't handle a file, but some other app can, a dialog is shown to choose the app to open it with, apart from the browser.
For example -

For video files, I get a choice to open in VLC media player, the system video app, or in Firefox.
For music files, I get a choice to open in a music app, in VLC, or in Firefox.
For pdf files, I get a choice to open in GDrive PDF Viewer, or in Firefox.

So, I think it's best to let the browser handle all files, for an overall better experience. I've changed the PR to reflect this.

@chrisbobbe @gnprice Thanks for the review. I've pushed some changes, and the PR is ready for another review.

@chrisbobbe thanks for the review!
I've made the suggested changes, and the PR is ready for a re-review.

@chrisbobbe I've updated the PR with a fix for lightbox included.

Thanks for the review, @gnprice. I've pushed some changes.

OK, tried this end-to-end, in an emulator running Android 8.

Tried downloading an image, for #2115. Steps: Message list > tap an image to get to lightbox > overflow menu > Download image.
Result: got this error message:

That is a different message from the status quo! So something changed.
And, notably, it seems like the download actually worked. There was a notification from Download Manager:

And opening that notification, I get to choose between HTML Viewer and Chrome; and either way, it successfully shows the image. Here's Chrome:

Also the download shows up in my Downloads folder, in the Files app:

(there's two of them there because I tried the download twice.)
Anyway, that's totally progress, so worth merging, but there are still some things to fix. :slightly_smiling_face:

#3303 coming up...

(Oh, and I was curious where that error message comes from, with its garbled syntax:

Download manager download failed, the file does not downloaded to destination.

Found it with grep -r 'downloaded to d' -- it's in the file node_modules/rn-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobReq.java, so from rn-fetch-blob.)

Again in an emulator running Android 8, testing this end to end:

#3303. Went to message list, found a message with an upload that wasn't an image. (To do that: in the webapp searched for has:attachment, and scrolled through history to find one that wasn't an image.) Specifically the file happened to be a PDF, with a .pdf extension on its name.
Hit the link. Got a prompt (a bottom sheet) asking if I wanted to use Chrome or WebView Browser Tester; I chose Chrome.
That opened a new screen with a browser view. That in turn gave me a permission prompt, for Chrome -- asking for file/storage permissions for Chrome. I approved.
Then a toast "Downloading..." appeared, and the browser view closed and I got the message list again. The download succeeded; I got a Chrome notification for it. Tapping the notification, the file opened up successfully in a PDF viewer.
So, I think that is a success!
The UX seems a bit suboptimal, in that I'd rather go straight to showing the PDF rather than have a few more taps and have to go through a notification. But I'm pretty used to seeing that flow, as an Android user, so I'm not sure there's an easy way for us to cause something nicer to happen.

OK, and this time on iOS, in a simulated iPhone 8 running iOS 13.3.

#3303. Same steps as on Android, up to tapping on the link in the message list.
Got a browser view. But this time, after a few seconds of loading, the result was an error:

That appears to be from S3 directly, because that's in the location bar at the top. The error message begins:

SignatureDoesNotMatch The request signature we calculated does not match the signature you provided. Check your key and signing method. [... then a bunch of details ...]

Ditto on a second try. I watched the timing closely this time, and it was only about a second between me tapping the link and the error message appearing. So it's not an expiration issue -- there's something else wrong.
Still worth merging because it fixes the issue for Android and this is no worse than the status quo on iOS -- but there remains something to fix and I think it doesn't resolve the issue #3303.

Same iOS environment, now testing #2115.

#2115. Same initial steps, up to hitting "Download image" in the overflow menu.
The permissions prompt has a confusing message, in this context:

We should fix that, as a followup.
Then the first time, the download failed. I think I spent over a minute at the permissions prompt, mostly because I was describing it here. Can we request permission before we get the temporary URL, rather than after? That'd avoid this issue.
Then the second time, it succeeded! At least, the toast said it did.
Going to the Files app, it's not there -- in particular it's not in the "Downloads" folder.
But going to the Photos app, it's there. Cool. I'm not sure which place I would expect it to land in, but either way, having it work at all is a major improvement 🙂

Aha, and I may have spotted what's going wrong in the #3033 case on iOS!
From that error page, I hit the "share" icon and chose "Copy", to get the URL onto the clipboard. Then went and pasted it elsewhere (the compose box, as the handiest place.) Here it is:
https://zulip-uploads.s3.amazonaws.com/1230/-Opc2L055IYelpraPb1oRDeU/sagas.pdf?Signature=2mpNGb0ysKFpVN8bkkMVsulQSVE%253D&Expires=1591317724&AWSAccessKeyId=AKIAIEVMBCAT2WD3M5KQ
I went and pulled up the same upload in the webapp, to compare. (It works fine there.) Here's the URL I find in the location bar there:
https://zulip-uploads.s3.amazonaws.com/1230/-Opc2L055IYelpraPb1oRDeU/sagas.pdf?Signature=xipp%2FD69nk89xmkKha3cx6K%2FSSg%3D&Expires=1591317779&AWSAccessKeyId=AKIAIEVMBCAT2WD3M5KQ
I think the problem is that %253D. That's the percent-encoding of %3D, which is itself the percent-encoding of =. Note there's a %3D at the end of the Signature query-parameter in the successful URL. Both signatures look like base64, which very often ends with a = as padding.
So it seems like we're double-encoding the URL, and as a result the decoding of it has a signature ending in %3D instead of in = and the signature doesn't validate.
Anyway, about to merge, and then I'll file issues for the various followups.

Then the first time, the download failed. I think I spent over a minute at the permissions prompt, mostly because I was describing it here. Can we request permission before we get the temporary URL, rather than after?

I think the short answer to this question may be "no", sadly -- the API we're using, and similarly its latest version, doesn't have a way to request the permission before committing to a specific URL to try to save. That I think is in turn probably ultimately a consequence of Apple's (reasonable!) desire to push apps to show permissions prompts only right at the moment where there's a clear thing the app wants to use the permission to do.
Ah well. These temporary URLs last 60 seconds, and it probably won't be common for a user to hesitate at a permission prompt for that long, or close to it. And if they do, it's a one-time occurrence anyway.

OK, and done filing those followups! See #4136, #4137, #4138, #4139.


Remove Endpoint from Client.request

What is not easy to do right now?
The zhttp.endpoint.Endpoint and zhttp.service.Client.Endpoint are two separate and confusing types.
Describe the solution you'd like
Delete zhttp.service.Client.Endpoint and just simply use Method and Path where ever required eg:

// Current
def request(endpoint: Endpoint, headers: Headers, content: HttpData[Any, Nothing]): ZIO[EventLoopGroup with ChannelFactory, Throwable, ClientResponse]

// Proposed
def request(method: Method, url: URL, headers: Headers, content: HttpData[Any, Nothing]): ZIO[EventLoopGroup with ChannelFactory, Throwable, ClientResponse]

Why is it important?
General cleanliness and hygiene.
Additional context
None

Happy to take this one

Thanks @brendo-m


Improve tests feedback, linked to #104

This is related to #104, and an attempt to improve the RuleTester's feedback. By default, it uses Mocha's describe and it to create rules, but it they are not defined, it uses the functions here.
I've managed to override the RuleTester test creation a bit to use AVA's test rather than Mocha's it, and here are the results:
When run with Mocha

When run with AVA (with --verbose)

When run with AVA and tap-mocha-reporter

The odd test.xxx(t => {}) kind of everywhere are the second part of the title (since it takes as title the code, and the code has a \n in the middle). If we remove the \n, it gets much clearer

Please check out eslint-ava-rule-tester, which exports a modified RuleTester. I'm up for modifying the name, but it's already published (could not make it all work with npm link), which contains the same code that you can see in test/helpers/ava-rule-tester.js (I kept it ll so that you guys could easily see what I did here).
Let me know what you guys think.
PS: Obviously this is just a draft, I haven't migrated all the tests and have even left an error so that you can see the error feedback more easily.

Nice! Looks so much better now :)

Maybe we should do a PR to ESLint adding a hook to their rule checker so any test framework could easily hook into it?

Nice! Looks so much better now :)

Yeah!

Maybe we should do a PR to ESLint adding a hook to their rule checker so any test framework could easily hook into it?

Sure. By their contribution guidelines, we should first create an issue though. Not sure I see what the hook should look like though?

By the way: Found this comment https://github.com/eslint/eslint/issues/5040#issuecomment-182693246, where they talk about eventually using AVA under the hood for RuleTester.

Created an issue in ESLint about this https://github.com/eslint/eslint/issues/6227

Now that we know that ESLint considers this okay and describe and it as part of their API (meaning it will be enforced by semver), shall I go ahead with finishing this? If so, I'll go ahead and do eslint-plugin-xo too (and my own plugins).

Before

After

Biggest number of test additions you'll ever see in one commit :D

Hmm, looking into the tests a bit later today. Stay tuned.

shall I go ahead with finishing this?

Let's do it! :D

There you go :)

Yay! So much better output :)

:)
Will do a PR for xo soon-ish.

PS: https://github.com/eslint/eslint/pull/6331, if you have comments to improve this ;)


python312Packages.cloudsmith-api: 2.0.13 -> 2.0.16

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.cloudsmith-api is: Cloudsmith API Client
meta.homepage for python312Packages.cloudsmith-api is: https://github.com/cloudsmith-io/cloudsmith-api
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.16 with grep in /nix/store/b2lm07nbvwzcxiw0p62q3ymqn0ibmcnd-python3.12-cloudsmith-api-2.0.16
found 2.0.16 in filename of file in /nix/store/b2lm07nbvwzcxiw0p62q3ymqn0ibmcnd-python3.12-cloudsmith-api-2.0.16

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

cloudsmith-cli
python311Packages.cloudsmith-api
python312Packages.cloudsmith-api

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b2lm07nbvwzcxiw0p62q3ymqn0ibmcnd-python3.12-cloudsmith-api-2.0.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.cloudsmith-api https://github.com/r-ryantm/nixpkgs/archive/6a0ab30743364adc5cb66c0e286acd1d6f38cb68.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6a0ab30743364adc5cb66c0e286acd1d6f38cb68#python312Packages.cloudsmith-api

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b2lm07nbvwzcxiw0p62q3ymqn0ibmcnd-python3.12-cloudsmith-api-2.0.16
ls -la /nix/store/b2lm07nbvwzcxiw0p62q3ymqn0ibmcnd-python3.12-cloudsmith-api-2.0.16/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 6 packages built:

cloudsmith-cli
cloudsmith-cli.dist
python311Packages.cloudsmith-api
python311Packages.cloudsmith-api.dist
python312Packages.cloudsmith-api
python312Packages.cloudsmith-api.dist

Maintainer pings

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361009

aarch64-darwin

:white_check_mark: 6 packages built:

cloudsmith-cli
cloudsmith-cli.dist
python311Packages.cloudsmith-api
python311Packages.cloudsmith-api.dist
python312Packages.cloudsmith-api
python312Packages.cloudsmith-api.dist


Fix wrong error info in RepoRefForAPI (#24344)

Backport #24344 by @yp05327

I was able to directly merge.


propagate invalidated (masked) transform entries to bins

Simply masking the transform causes bug since the input map's contents simply get propagated to the output (like multiplying by one). need to figure out a way to propagate masked entries in a transform to the appropriate location(s) in the output map.
Note that this arose in connection with the PID stage, though it could be an issue elsewhere, so a fix of some form within BinnedTensorTransform might make more sense than just in the PID stage itself.

I don't think this is an issue anymore, closing it.


Form reset doesn't get same value as initial mask

Hi
I ran into a problem when doing a form reset on an input using the "integer" mask, where the initial input value had decimals.  What would happen is I set the input to some value (12.34), and when I use the integer mask, it strips off the decimals (12), and that's working fine.
But when you trigger the reset, I think that it takes the original value and enters every character with the keypress event.  This doesn't work, because the mask only blocks the radix from being entered, and doesn't strip the decimals (1234).
Here's a fiddle with a simple example.
http://jsfiddle.net/tctosr91/
I'm still trying to figure out what's going on exactly, but I think the problem is that the onBeforeMask event isn't called when the value is set through the reset event.
Thanks.

@bdmay96 ,
Fixed ;-)


[Skype] There was a problem synchronizing your bot to Skype.

Bot Info

SDK Platform: Node.js
SDK Version: 6.0.0
Active Channels: Skype
Deployment Environment: local development with Emulator

Issue Description
On sending message to bot no request is send to my server. When reload dev.botframework.com/bots/channels?id= then I recieve an error of 500: Internal server error.
When I am sending message through emulator it works totally fine.

Actual Results
On sending message to bot no request is send to my server.

i have same errors, all tests bot <->myservice is ok, but bot <-> skype i see errors - There was a problem synchronizing your bot to Skype.

Can anyone help me regarding this please?

Cross-linking similar issues #4401, #4388, #4394.
@sudeep-cedcoss,  @PulseDiver @agpalma59, @Ananya-96, please follow this issue for now as it appears you're all running into the same problem.
The dev team is currently investigating this problem and we will be posting updates on the situation here.
If there are any changes in your bot's status or if you have any new/different information please share it here.

@sudeep-cedcoss, @PulseDiver, @agpalma59, @Ananya-96 the issue has been mitigated, can you verify that the problem has been fixed for you?

@stevengum97 old bot not work in skype, but new created bot  works fine! thanx

@stevengum97  Yes errors got fixed. Thanks

Closing issue due to a released fix and inactivity. If anyone is still having problems please file a new issue.


[Bug]:  docker image: server crashes before starting bug in run-java.sh

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Im having an issue starting the latest build of appsmith
This is the  stdout
backend stdout | 2024-09-28T06:18:41.328Z Running with mongo.
2024-09-28 06:18:41,329 INFO exited: backend (exit status 1; not expected)
backend stdout | /opt/appsmith/run-java.sh: line 14: cd: /opt/appsmith/server/mongo: No such file or directory
mongodb-fixer: false
mongodb-fixer: 2024-09-28T06:18:42.190Z MongoDB version set to 5.0
mongodb-fixer: 2024-09-28T06:18:42.192Z Done
2024-09-28 06:18:42,330 INFO reaped unknown pid 89
2024-09-28 06:18:43,332 INFO spawned: 'backend' with pid 1725
backend stdout | 2024-09-28T06:18:43.339Z Load environment configuration
backend stdout | 2024-09-28T06:18:43.346Z Running with mongo.
2024-09-28 06:18:43,346 INFO exited: backend (exit status 1; not expected)
backend stdout | /opt/appsmith/run-java.sh: line 14: cd: /opt/appsmith/server/mongo: No such file or directory
2024-09-28 06:18:46,350 INFO spawned: 'backend' with pid 1731
backend stdout | 2024-09-28T06:18:46.357Z Load environment configuration
backend stdout | 2024-09-28T06:18:46.364Z Running with mongo.
2024-09-28 06:18:46,365 INFO exited: backend (exit status 1; not expected)
backend stdout | /opt/appsmith/run-java.sh: line 14: cd: /opt/appsmith/server/mongo: No such file or directory
2024-09-28 06:18:46,365 INFO gave up: backend entered FATAL state, too many start retries too quickly

dir
# in the container ls
$ /opt/appsmith# ls -l

total 140
-rwxr-xr-x 1 root root  1549 Sep 27 09:22 JFR-recording-24-hours.sh
-rwxr-xr-x 1 root root  1017 Sep 27 09:22 auto_heal.sh
drwxr-xr-x 2 root root  4096 Sep 27 09:22 baseline-ce
-rw-r--r-- 1 root root  6219 Sep 27 09:22 caddy-reconfigure.mjs
-rwxr-xr-x 1 root root  3594 Sep 27 09:22 diagnostics.sh
drwxr-xr-x 1 root root  4096 Sep 28 05:52 editor
-rwxr-xr-x 1 root root 18426 Sep 27 09:22 entrypoint.sh
-rwxr-xr-x 1 root root  1853 Sep 27 09:22 generate-infra-details.sh
-rwxr-xr-x 1 root root  1252 Sep 27 09:22 healthcheck.sh
-rw-rw-r-- 1 root root   299 Sep 28 06:03 info.json
-rwxr-xr-x 1 root root  8276 Oct 30  2023 install_docker.sh
-rwxr-xr-x 1 root root   618 Sep 27 09:22 mongodb-fixer.sh
-rwxr-xr-x 1 root root  3645 Sep 27 09:22 pg-upgrade.sh
-rwxr-xr-x 1 root root   617 Oct 30  2023 pull_resource.sh
-rwxr-xr-x 1 root root   444 Sep 27 09:22 record-heap-dump.sh
-rwxr-xr-x 1 root root   433 Sep 27 09:22 record-thread-dump.sh
drwxr-xr-x 1 root root  4096 Sep 28 05:37 rts
-rwxr-xr-x 1 root root   592 Sep 27 09:22 run-caddy.sh
-rwxr-xr-x 1 root root  2382 Sep 27 09:22 run-java.sh
-rwxr-xr-x 1 root root   147 Sep 27 09:22 run-postgres.sh
-rwxr-xr-x 1 root root    88 Sep 27 09:22 run-starting-page-init.sh
-rwxr-xr-x 1 root root  1680 Sep 27 09:22 run-with-env.sh
-rwxr-xr-x 1 root root   763 Oct 30  2023 start_app.sh
-rw-r--r-- 1 root root  2094 Sep 27 09:22 starting-page-init.py
drwxr-xr-x 1 root root  4096 Sep 27 09:22 templates
-rwxr-xr-x 1 root root   285 Sep 27 09:22 thread-profile-start.sh
-rwxr-xr-x 1 root root   134 Sep 27 09:22 thread-profile-stop.sh
drwxr-xr-x 1 root root  4096 Sep 28 06:03 utils

Steps To Reproduce
steps to reproduce bug
/app/client/packages/rts
$ yarn install --immutable
$ yarn build

/app/client
$ yarn install --immutable
$ yarn build

/app/server
$ ./build.sh -DskipTests

/
$ docker images
appsmith/base-ce                                            release             650e518218aa   5 days ago       1.7GB

$ docker buildx build --build-arg BASE=appsmith/base-ce:release --platform linux/amd64 -t my_appsmith:latest_merge . -o type=docker

Public Sample App
No response
Environment
Release
Severity
Critical (Broken Production apps)
Issue video log
No response
Version
release

had to run this before buildx
$ ./scripts/prepare_server_artifacts.sh


⚠ Bofrost.es has degraded performance

In c2e928c, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1541 ms

Resolved: Bofrost.es performance has improved in 5b75955 after 7 minutes.


✨ post update collision detection

closes #5599
If two users edit the same post, it can happen that they override each others content or post settings. With this PR this won't happen anymore.
This PR can detect post changes and tag changes and if a collision is detected, the user will receive an error back. Each commit should be clear and has enough context to understand the required changes.

[x] test on postgres
[x] test on node 6
[x] more comments?
[x] go over code pieces where we use find and edit together
[x] add more context to the commits
[x] ensure client receives error code
[x] tested with 1.0 - have a branch for it as well
[x] tested with Ghost Desktop
[x] add more tests?
[x] Ghost-Admin: don't auto save if user isn't actively changing anything, see #8331

This is ready for review 🙀


Unify build directories.

This unifies the deps, build, incremental, and .fingerprint directories, pulling them out of the debug/release directories. This lays the groundwork so that #6577 can more easily share build artifacts across debug/release. Final artifacts remain linked into debug/release.
For backwards compatibility, tests and benchmarks are still stored in target/{debug,release}/deps. This is because it is not uncommon for tests to use current_exe to find executable binaries.
Misc details:

Removed the native directory, I'm fairly certain it is not used.
Removed the naming restriction for build, incremental, and native.  examples and deps are still restricted.
Added doc to Layout now that Layout owns the top-level structure. Other things like package and .metabuild could be added later, just to keep everything in one place.

r? @Eh2406
(rust_highfive has picked a reviewer for you, use r? to override)

This may be a disruptive change, so I'd like to make sure this is a good layout for the future, or if a different strategy would be better. There is some flexibility to change things around (for example, we could make it .deps to be hidden, or use some other, more descriptive name). The directories could also be nested together.
As I mentioned earlier, this slightly breaks rustbuild, but the fix is simple.
I feel like the backwards compatibility for tests is a little inelegant. Not sure if there's a better approach.
Continuing discussion from #6577:

directory junctions are supported much further back on Windows, right?

Directory junctions are supported back to Windows 2000. However, they are absolute-paths only, and only work on NTFS. std does not have a way to create them (it has one for internal tests, though). symlink_dir creates symlinks, hard_link creates file-only hardlinks, and directory junctions are a 3rd concept. It would be possible to try directory junctions, but I fear that would cause issues.

I feel like this is a good next step on eventually moving to a separate global cache, if that is the direction the team decides to go.
I see two concerns:

How much breakage is this going to make? How much shim code to we need for backwards compatibility? How backwards compatible to we want to be? Can we test this somehow? Opt in for testing? A crater run?
Are we going to have to add shims for this behavior when we make changes in the future? Witch is hard as the team has not clearly defined what we want to go.

I wonder if this is a good moment to define what is "stable" about the file structure and what is "implementation details"?

Difficult questions to answer.  I think it will definitely break a few projects.  I just did some searching, and I'm unfortunately finding a large number of projects digging in the deps dir (over 40), which is making me reconsider this strategy.  ☹
I'm not sure how to proceed.  It would be depressing to have undocumented behavior be perma-stable because people are using it, and it would also be frustrating to break a bunch of projects.
I could change it to hard-link everything into the old deps dir.  I worry about filesystems that don't support hard-links, in which case you'd have two copies of everything.  I could go with the symlink/directory-junction approach, but that means Windows wouldn't support non-NTFS filesystems.
Another approach would be to segregate build-dependencies, and hard-link the shared ones.  That will be more difficult to implement, but might be a good outcome.
Could also just give up on trying to share, and just say build scripts need to be compiled separately. That will make some projects very unhappy, though.
Hmm... 🤔   Anyone with ideas?

Since we're wondering about possible breakage here, I think it'd be most actionable to go from concrete breakage to develop a plan to roll this out. @ehuss you mentioned that you saw some projects digging around in deps, and would it be possible to categorize those accesses into how the folder is currently being used?
I think with that we might be able to develop a strategy to roll this out (for example do we roll it out with warnings on internals? do we have an unstable flag and opt-in for awhile before switching defaults? do we switch immediately, use hard links where possible, and warn on internals? etc/etc).

:umbrella: The latest upstream changes (presumably #6687) made this pull request unmergeable. Please resolve the merge conflicts.

I did a survey of projects that appear to be accessing inside deps: https://gist.github.com/ehuss/7e3de6b732d276bb9639de11bf911af3
This is not a complete survey, but maybe gives an idea of what is being used.  It might be interesting to consider these will also likely break with a global, shared cache.  How disruptive does that survey look?
I don't see flags as being a good way to transition.  An unstable flag would only be usable on nightly, and I feel it would be unlikely that projects would support both modes simultaneously.
I'm considering a different approach of keeping build dependencies separate, but with a fallback mechanism so that it would use the deps in debug or release if they are available and compatible.  That might be less disruptive. I could also implement it in such a way to naturally support a global shared cache.  One concern is that it would not play nicely if custom profiles are ever added.  Can anyone think of other drawbacks or considerations?

I don't have time to dig in at the moment, but I want to make it clear that With some transition plan I like the general goule.

Thanks for collecting that info @ehuss!
I continue to pretty strongly feel that we should continue to find a way forward with this change or something pretty similar. I don't want us to get into a situation where we feel shackled to make changes because you're definitely right that doing something like a global cache is going to cause problems regardless, but I feel like those problems are worth the tradeoff of the benefits we'd otherwise get.
Along those lines I see this as a "game" of figuring out how to make the impact as reasonable as possible. A good number of those crates, for example, are largely just interested in the "final artifact", but something that isn't handled well. For example the "final artifact" may include something via RUSTFLAGS or cargo rustc which is currently just defacto buried away somewhere.
Another category seems to be about executing rustc to do things like more doctests or compiletest. Thankfully though there's a small handful of foundational crates we can fix in one way or another to get them working again.

I wonder if we could take a plan of attack like so?

Prepare the change in target directory layout, but make it internally conditional on a boolean switch.
Send a post to internals, detailing:

A description of the change, as well as motivation
Expected fallout we expect to see, and how to fix it
Initial ideas of how to fix the fallout

On nightly default the boolean switch to "use the new scheme", but provide a very easy (env var, cargo config, etc) way to turn it back to the old scheme.

From there we'd have some clear messaging saying that a change is coming as well as a way to force experimentation with the new scheme (but a way to locally fix builds if necessary). Depending on the fallout and schemes we have for fixing things we could then continue to evaluate. If it breaks everything and everyone's unhappy then we revert the boolean switch and figure out a different strategy. If it breaks lots and there's enthusiasm to fix, then it'll fix itself in time. Or maybe we have very little breakage in practice!
How's that sound?

for example, we could make it .deps to be hidden, or use some other, more descriptive name

I think we should do this. The main problem with the current situation is that we don't actually say which things inside target are public API and  which are private impl details. So a name like .cache or .cargo-private or .internal would be useful: it won't prevent users from poking into internals, if they have two, but they hopefully will see that this is not covered by stability guarantees.

What needs to be done regarding this? One thing that would be nice to see is the deps having their own folder. That way, I can easily delete everything under target on CI except for the target/deps and then cache it based on Cargo.toml. This will reduce a lot of CI cache problems rust projects have.
Currently clap does this.

I'm not sure how to proceed. It would be depressing to have undocumented behavior be perma-stable because people are using it, and it would also be frustrating to break a bunch of projects.
With some transition plan I like the general goal

Could cargo set a DEPS or TARGET_DEPS variable in the build script that shows where the artifacts will be output to? That can be rolled out on nightly for a while before the change, allowing cargo projects to transition without breaking any crates. Then once most crates have transitioned, cargo could switch the directory to the new format.

I'm going to close this PR for now.  I'm still interested in pursuing this, but it will take more work than I have time for now.

I'm going to close this PR for now.  I'm still interested in pursuing this, but it will take more work than I have time for now.


Not able to compile on mac OS Mojave

Even though g++ is installed and updated, cmake cannot recognise it as a legitimate gnu compiler and I am getting the error message saying that my compiler environment is unsupported

Hi @shreyasdhole ,
I have never compiled it on mac OS, but I have a few colleagues and collaborators who successfully did.
I will ask them to help you with the issue, if you were not able to solve it by now.
Sorry for the late reply!
Gian

@shreyasdhole Have you tried with flags -DCMAKE_CXX_COMPILER=<PATH_TO_G++> -DCMAKE_C_COMPILER=<PATH_TO_GCC>?
I'm compiling it correctly in macOS Catalina.


Not possible to add [APM Request Latency] via DistributionWidgetDefinition class widget

Describe the bug
No possibility to add apm_stats_query to the DistributionWidgetDefinition widget class.
apm_query=LogQueryDefinition does not make it possible to reproduce APM Request Latency distribution chart for the service.
Label the issue properly.
severity/medium
To Reproduce
Steps to reproduce the behavior:

Add DistributionWidgetDefinition widget to the Dashboard class as follows:

            Widget(
                definition=DistributionWidgetDefinition(
                    title="Latency distribution",
                    title_size="16",
                    show_legend=False,
                    title_align=WidgetTextAlign("left"),
                    type=DistributionWidgetDefinitionType("distribution"),
                    xaxis=DistributionWidgetXAxis(max="p95"),
                    yaxis=DistributionWidgetYAxis(scale="linear"),
                    requests=[
                        DistributionWidgetRequest(
                            apm_stats_query=ApmStatsQueryDefinition(
                                env="env",
                                name="service_request",
                                primary_tag="",
                                row_type=ApmStatsQueryRowType("service"),
                                service="service",
                            ),
                        ),
                    ],
                ),
            ),

Expected behavior
Possibility to add apm_stats_query parameter and ApmStatsQueryDefinition class to the DistributionWidgetDefinition class is added.
Screenshots

I Would like to have this option via Python API for the distribution widget which is not possible now.
Environment and Versions (please complete the following information):
OS: Ubuntu 20.04 LTS
Python: 3.8.10
datadog-api-client: 1.3.0
Additional context
Add any other context about the problem here.

Hi, I believe it has been fixed with #628 . Thanks.

@therve Cool, I managed to test and push to my repo, works as desired. Thanks!


How much VRAM required for Share Captioner?

Hi

How much VRAM is required for Share Captioner?

Is there a way to use Multiple GPUs for loading Share Captioner?

Are there Quantization methods (4bit, 8bit) available for Share Captioner?

I have tried to run Share Captioner but I have got CUDA Out of Memory error on a Rtx 3090:
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 172.00 MiB. GPU 0 has a total capacty of 24.00 GiB of which 0 bytes is free. Including non-PyTorch memory, this process has<PHONE_NUMBER>4.00 GiB memory in use. Of the allocated memory 23.10 GiB is allocated by PyTorch, and 3.24 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

I am also having this question. Does anybody have a answer ?

So how much VRAM is being used in your A6000?


XML Sitemap from All in One Seo Pack not working - Redirection issue

My blog is http://www.99blogger.com/
So my sitemap file must be in http://www.99blogger.com/sitemap.xml
But http://www.99blogger.com/sitemap.xml redirect to http://www.99blogger.com/sitemap_index.xml
And shows this page

I removed the yoast configuration lines in wpcommon.conf still no use
This is my current wpcommon.conf
<-----Start----->
WordPress COMMON SETTINGS
DO NOT MODIFY, ALL CHNAGES LOST AFTER UPDATE EasyEngine (ee)
Limit access to avoid brute force attack
location = /wp-login.php {
limit_req zone=one burst=1 nodelay;
include fastcgi_params;
fastcgi_pass php;
}
Disable wp-config.txt
location = /wp-config.txt {
deny  all;
access_log off;
log_not_found off;
}
Disallow php in upload folder
location /wp-content/uploads/ {
location ~ .php$ {
#Prevent Direct Access Of PHP Files From Web Browsers
deny all;
}
}
<-----End----->
Help me solve this issue

@felixcoolb I see you have shifted to yoast SEO plugin - http://www.99blogger.com/sitemap_index.xml so I am closing this issue.
For future technical support, please use free community support - http://community.rtcamp.com/c/easyengine
We are also offering premium support at https://rtcamp.com/products/easyengine-premium-support/
Please check more details at - https://github.com/rtCamp/easyengine/blob/master/CONTRIBUTING.md


Azure Gov API not available

As of today, the API version 2022-09-09 for Microsoft.DesktopVirtualization is not available in Azure Government. I reverted all of the code back to API version "2022-04-04-preview" and the AVD Accelerator code still worked.

I don't see "2022-04-04-preview" in my Azure US Government subscription:

Oops, that was a typo on my part. The API version that I used instead of 2022-04-01-preview. I didn't bother testing with 2022-07-05-preview or 2022-08-09-privatepreview because I was only comparing the API versions with what the public Microsoft documentation showed for API version.
But the version 2022-09-09 definitely does not exist and the AVD Accelerator will not deploy using that API version in Azure Gov.

Oops, that was a typo on my part. The API version that I used instead of 2022-04-01-preview. I didn't bother testing with 2022-07-05-preview or 2022-08-09-privatepreview because I was only comparing the API versions with what the public Microsoft documentation showed for API version.
But the version 2022-09-09 definitely does not exist and the AVD Accelerator will not deploy using that API version in Azure Gov.

@chbragg new code was merged to use API 2022-07-05-preview when deploying to gov and API 2022-09-09 when deploying to commercial.
Please test your deployment and let us know if you have any feedback.
cc: @swathibhat1 please help us out creating the tracking item.

I can't get the new version to work at all. When using the UI to "Deploy to Azure Gov" without a custom image, the deployment never creates any resources in the "HostPool-AppGroups" step. It doesn't error out, it just doesn't create the host pool or any other resource. It fails when it tries to provision the session hosts but a host pool doesn't exist.
When trying to deploy with code using Bicep, I get many errors that say "@2022-07-01" does not have types available."
Can you please revert the changes? I can see in the portal now on several different Azure Gov tenants that the API 2022-09-09 for Microsoft.DesktopVirtualization is now available.

Thanks for the feedback, reverted the changes


Add PID motor controls to the arm

Need to look at using the encoder on the motor to stabilize it.

[x] PID Controller class #23.
[ ] Constant tuning for the arm.

Closed in #38.


keep_dims => keepdims

In order to avoid the deprecation warning

Hello edumucelli, thank you very much for your pull request.
The deprecation warning is raised when tensorflow>=1.5.0. On tensorflow 1.4.X there are no deprecation warnings. Travis CI is failing because Tensorflow 1.4.1 is being used for launching the tests and keepdims does not exist as a parameter of the tf.reduce_sum and tf.reduce_max functions on this version.
If you add a check for solving this version problem then I will accept your pull request.
>>> import tensorflow as tf
>>> tf.__version__
'1.5.1'

Hi @ipazc, yep, you are right, I have realised that just after the build got broken but I was taken by other tasks in the meantime and was not able to get back here to fix it. I will do it right away. Cheers!


Reduce minimum NPM version to match web app

Summary
Just what it says in the title. I was able to build and run the iOS app in the simulator with this version of NPM, so I figured it would be fine to have it match that while still recommending the newer version of NPM
These are the versions of Node and NPM that we use for web
harrison-mm:mattermost-mobile harrison $ npm --version
7.24.0
harrison-mm:mattermost-mobile harrison $ node --version
v16.10.0

Release Note
NONE

Also, another thing to note is that npm 9 is out and we should look into it


Make themes dir when making config dir

Users who already have a config directory will need to manually create the 'themes' directory, but this will create it for new installs.

This will make it?

Ah I'd missed that, thanks @virattara!


Going back in the path doesn't work with oclazyload?

Hi everyone,
while implementing oclazyload to the component router tutorial https://docs.angularjs.org/guide/component-router, I came across the following problem:
this.gotoHeroes = function () { var heroId = this.hero && this.hero.id;  this.$router.navigate(['HeroList', {id: heroId}]);};
(this is a function for a Button that simply goes back in the path)
produces the Error: angular.js:13236 TypeError: Cannot read property 'navigate' of undefined
Debugging showed that the router is the same router as in the app.js / hero.component, but it seems like it can't fall back to the path it knew before. What is interesting, since it worked perfectly without implementing lazy loading.
Is there any coherence?
Best regards
liasrose

@liasrose it is hard to know with this information because there are no comment about how lazy load has been implemented on your code. Could you show us more detail?

I implemented lazy loading like this in the app.js:
`(function () {
var app = angular.module('app', ['oc.lazyLoad', 'ngComponentRouter']);
app.config(function ($locationProvider) {
    $locationProvider.html5Mode(true);
});

app.value('$routerRootComponent', 'app');

app.component('app', {
    template: [
        'Home |',
        'Heroes |',
        'Crisis Center',
        '
',
        '<ng-outlet></ng-outlet>'
    ].join('\n'),
    controller: ['$router', '$ocLazyLoad', function ($router, $ocLazyLoad) {
        $router.config([
            {path: '/', name: 'Home', component: 'home', usaAsDefault: true},

            //Heroes Route
            {
                path: '/heroes/...',
                name: 'Heroes',
                loader: function () {
                    // lazy load Heroes
                    return $ocLazyLoad.load('/heroes/heroes.js')
                        .then(function () {
                            return 'heroes';
                        });
                }
            },`

Lazy loading functions perfect, also loading to the "subroute", the heroList and heroDetail (both components of heroes, in this example everything is in one file)
$routeConfig: [         {path: '/', name: 'HeroList', component: 'heroList', useAsDefault: true},         {path: '/:id', name: 'HeroDetail', component: 'heroDetail'}     ]
the only thing that isn't working, is going back from HeroDetail to HeroList via the router (see code in my first comment above). I can also go back just using window.history.back(), so there is no urgent help needed, I was just curious why its not working anymore after implementing lazyloading.
Best regards
liasrose

@liasrose I am implementing this based on ui-router. It also does not load again when it moves to parent path because it is already loaded. Is your router correctly setup 'HeroList' and 'HeroDetail' as parent-children relation?
I will try on ngComponentRouter too to see this goes well.


MAINT: openblas_support added sha256 hash

What does this implement/fix?
Added sha256 hash for AArch64 architecture specific OpenBlas which is a prerequisite to close gh-11170

Thanks @odidev--I'm not sure if you meant to auto-close the linked issue just yet, but I'll leave that up to you.


Installing atom without sudo privilidges

When atempting to compile atom from source on a university machine without user privilidges tons of access errors occur (1. the npm version is not 1.4 and compiling a local  node + running from that does not work). Is there a way to just obtain a compiled form to run ? for example sublime is easy to install without user prvilidges. Can this be added ?

@franciscovargas
Could you solve this issue? I am facing the same problem with the dependencies ..older gcc version, no electron, node, npm etc and no Sudo :(


Create a dummy git repo in case we need to build wheels later

This does not sound right. I'll need to dig out the root cause of the problem.


Refactor build script

This PR regactors the wasmedge-sys build script to remove the dependency on the external commands wget, tar and bash.
It also reduces the amount of duplicated code in the build script.

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


soft deprecation for jsx-space-before-closing

The introduction of jsx-tag-spacing makes jsx-space-before-closing obsolete.
https://github.com/yannickcr/eslint-plugin-react/pull/1070
https://github.com/yannickcr/eslint-plugin-react/issues/693#issuecomment-234842809
since the plan is to deprecate jsx-space-before-closing, I think it would be already helpful and less confusing - as it was for me - if this would be already mentioned in the docs.
something like:
Note: This rule will be deprecated in the next major release. Consider using jsx-tag-spacing instead.

Mind if I do a PR?

Sounds great!
You can also mark the rule itself as deprecated in its metadata.

I believe this is a must have. Because if a project has both configuration, with different settings, eslint will keep complaining that there's an error.

Looks like this is already in the docs via https://github.com/yannickcr/eslint-plugin-react/pull/1070/files#diff-682c810c832cf33406eede243921fd42

Closed with #1070.


Issue with Timezone

r at 5:20pm get things from fridge
Creates a reminder for 11:20pm called things from fridge. I'm in AEDT, could this be a timezone issue?

I had the same problem.
GET is a timezone.


Resolve #6412

Resolve #6412

🙏

Humm sorry, can we change that to ar-DZ since contribution is comming from Algeria and not from Arabia Saudi or add ar-DZ so that I continue translating in ar-DZ and not ar-SA.
Political and technical reasons.
Thankd you.

Humm sorry, can we change that to ar-DZ since contribution is comming from Algeria and not from Arabia Saudi or add ar-DZ so that I continue translating in ar-DZ and not ar-SA.

It depends on Crowdin. currently we have only ar-SA for arabic locale.
If you need to rename ar-SA to ar-DZ, it should be done on Crowdin first.
https://github.com/syuilo/misskey/blob/develop/locales/ar-SA.yml


Problem loading other variables than u/v wind components

I'm not managing to get temperature, relative humidity (for example) to be correctly loaded and shown. I've downloaded the latest GFS grib file and converted using grib2json. Everything works fine if I download only u and v momentum components. However, if I include other variables, the wind is not read correctly (all globe is filled with a constant direction strong wind).
Do I have to modify anything in the data files such as variable names, data order, to include these scalar variables?

@tpdp Do you able to find the temperature folder for finding the temperature based on the location. I am executing this github project on window 10 localhost and it has limited functionality of wind and its speed only.


Setup failed

I tried to follow the INSTALL.md for the installation. However, the script for "python setup.py build develop" failed. I have already upgraded the GCC to 5 or higher.
I got a warning error saying
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Your compiler (c++) is not compatible with the compiler Pytorch was
built with for this platform, which is g++ on linux. Please
use g++ to to compile your extension. Alternatively, you may
compile PyTorch from source using c++, and then you can also use
c++ to compile your extension.
See https://github.com/pytorch/pytorch/blob/master/CONTRIBUTING.md for help
with compiling PyTorch from source.

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Can anyone help me with it? Thanks in advance!

您好，您解决了吗

没有解决
在 2022年5月23日，23:20，Lara-lyx @.***> 写道：

您好，您解决了吗
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fscene_graph_benchmark%2Fissues%2F56%23issuecomment-1135457185&data=05|01|meiqi.guo%40pitt.edu|882a6310edf7472207b608da3d4d7d78|9ef9f489e0a04eeb87cc3a526112fd0d|1|0|637889700282167891|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ecE0O4yh%2BiSAcy40I3V8OqQUSZniJmNoyzqL50hKo7g%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKGW7SKCS3BGBW52Q3Q7JZTVLRYKRANCNFSM5ILMAM2Q&data=05|01|meiqi.guo%40pitt.edu|882a6310edf7472207b608da3d4d7d78|9ef9f489e0a04eeb87cc3a526112fd0d|1|0|637889700282167891|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=bxi2pbAgwUR8B4QT7D0sZp7%2BXqDok8CuSfZA%2BQQFqm0%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


will this project be updated with latest code or there is some similar project like this?

I cloned the code and try to install in local, but it seems the packages it depends on are mostly out of dated.
Not sure if there is someone there have already fork and update the project, or is there some similar projects like cmx.js that is built recently?

@hileon you can get the site working by bypassing the old grunt dependency hell and using an older version of Node that still conforms to the tis changes. I'm using https://nodejs.org/en/blog/release/v0.12.18
nom install --save-dev<EMAIL_ADDRESS>./node_modules/.bin/coffee -c **/*.coffee
cd app && python3 -m http.server 8080

It'll get you the trans-pilled comic editor and you can host it wherever.

@Promaethius Thanks for this, however, the visual editor isn't working. The visual editor area is just blank. Do you have an idea?

@Promaethius may be you have this trans-piled version somewhere? Or even container?

I managed to build a working version and put it into docker container, you can check it here.

@jehy Greatly appreciate you brushing this up.
I am interested in using, extending and maintaining this.
New to coffeescript, but am willing to learn!..

@jehy Greatly appreciate you brushing this up.
I am interested in using, extending and maintaining this.
New to coffeescript, but am willing to learn!..

Hi! You can contact me via telegram, I can provide some details. We can also make a zoom call.
BTW, you should not learn coffescript. It's dead already. It's better to start with migrating to typescript. May be there are some automated migrators, or you can try chatgpt.

Yes, wanted to suggest it myself, but did not think it was right to do so before we could have a discussion. I am a bit busy through this weekend, but we take it up next week!


Select correct xcode version in activate on MacOS

@sambhav7890 There's no way to find out the xcode versions installed on the system. The xcode select command expects path of the xcode installs from the user. I am not sure if it would be easier to add it into the activate script or ask the user to switch to the correct version of xcode himself. About xcode select: http://iosdevelopertips.com/xcode/xcode-select-managing-multiple-versions-of-xcode.html Let me know if you know of a workaround for this.


Updated GitHub workflow Node version to LTS

@jeanettephung, I've identified the issue causing the GitHub action failure in #48.
This small fix should resolve it. Let's get this merged! 👍

Thanks @Bramikke, will do.


Automatically open the authorization window without clicking context menu in tray icon

Please add a possibility to automatically open the authorization window without clicking context menu in tray icon.

This is not possible I'm afraid – GUI operations must be run from the main thread (see pywebview's documentation)


Config broken after Micro SD card change

Issue Type
[ ] Question
[x] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation
Description and/or steps/code to reproduce the problem

have a micro SD card in your device that has more free memory than the main storage.
use OsmDroid
exchange or remove the micro SD card
use OsmDroid again

-> Configuration will still try to use the previous path.
Suggested fix
In DefaultConfigurationProvider, exchange line 328
        if (!prefs.contains("osmdroid.basePath")) {

with these two lines:
        String basePathStr= prefs.getString("osmdroid.basePath", null);
        if (basePathStr==null || !new File(basePathStr).exists()) {

Environment
If it's a bug, version(s) of android this affects:
All
Version of osmdroid the issue relates to:
6.1.2

Can you do a pr for this?


Fixed deserializing generic autovalue classes.

Copy over the type paramaters passed into the TypeApdapterFactory
from the source type to the autovalue type if necessary. You lose
this information when just doing Class.forName().
Fixes #8

LGTM


Tooltip: reactive toggling doesn’t work if the tooltip icon is in focus

Unfortunately, I didn’t cover one possibility in https://github.com/carbon-design-system/carbon-components-svelte/pull/885. In the reactive tooltip example, toggling doesn’t work as intended if the icon is in focus.
https://user-images.githubusercontent.com/47485431/140752758-3306bdf4-d50a-4122-ae28-2401d46ce4dc.mov

Patched in v0.47.6


Should I set authentication mode to forms or None?

Should I set authentication mode to forms or None? If I set to none  then it doesn't get redirected to my login page. what is the best approach to this?

Are you using WIF or Katana for your cookie management?

I'm using WIF

Well, you can set it to None, but then no redirects happen to your login page (as you saw). IIRC, you can still the forms auth redirect and it will kick in and redirect your users (even though you're not using forms auth for actually logging in the users). The other option is to build a module to redirect on a 401 response.

ok. I have the auth mode set to forms in-which it redirects to the correct page.
I'm trying to set sliding expiration. I tried using the forms auth method (which I know wouldn't work) and now I saw some resources online, but with the implementation I have, user is automatically logged out after set time, in other words, absolute expiration is what I have working and I want a sliding expiration. Please point me in the right direction.
Below is my web.config setting:

 <system.identityModel.services>
    <federationConfiguration>
      <cookieHandler requireSsl="false" persistentSessionLifetime="00:20:00" />
    </federationConfiguration>
  </system.identityModel.services>
  <system.identityModel>
    <identityConfiguration>
      <securityTokenHandlers>
          <remove type="System.IdentityModel.Tokens.SessionSecurityTokenHandler, System.IdentityModel, Version=<IP_ADDRESS>, Culture=neutral,                     PublicKeyToken=B77A5C561934E089" />

        <add type="System.IdentityModel.Tokens.SessionSecurityTokenHandler, System.IdentityModel, Version=<IP_ADDRESS>, Culture=neutral,                  PublicKeyToken=B77A5C561934E089">
          <sessionTokenRequirement lifetime="00:20:00"></sessionTokenRequirement>
        </add>
      </securityTokenHandlers>
    </identityConfiguration>
  </system.identityModel>

Ok thanks


Add --older-than support to VPC

Fixes #244

I re-triggered the test suite, to double-check the two failing tests. They seem to be flaky tests...


Replace murmur32 with XXH3

Performance testing suggests that the XXH3 hash algorithm outperforms the murmur32 algorithm while still maintaining relatively good randomness.

LSF/MM/BPF 2022 talked about this, and Linux switched from murmur32 to xxh64 in the kernel.
My note from a discussion we had around that time said we currently use murmur3, xxh3 seems much better but can't use SSE2 in kernel because of floating pt arithmetic.

No measurable improvement for switching to XXH3 for small key sizes.


FR: option to "short-circuit" the observer callback

I have elements that reveal-in along the Y axis on scroll:
CustomEase.create("ease3", "M0,0 C0.35,0.028 0.338,1 1,1");

[].forEach.call(document.querySelectorAll('[data-reveal]'), el => {
    new ScrollObserver({
        whenVisible: '10%',
        triggerElement: el,
        gsap: {
            timeline: gsap.timeline({paused: true}).fromTo(el, {
                autoAlpha: 0,
                y: 50
            }, {
                autoAlpha: 1,
                duration: duration,
                ease: 'ease3',
                y: 0,
            }),
        },
    });
});

I cannot use this transition however with the ScrollObserver. It works great when scrolling the page up the Y axis, but scrolling down will cause jitters as when the bottom of the element reaches the top of the window the animation starts to move the element down again, essentially fighting against the direction of the scrolling.
The fix would be fairly simple:
var observerCallback = function observerCallback(entries) {
    entries.forEach(function (_ref2) {

        // check the y axis before proceeding
        if (_ref2.boundingClientRect.y < 0) {
            return; // do not animate when element is being scrolled past the top of the window
        }

        // ...
    });
}

Unfortunately, there is no option to short-circuit the observer callback so this cannot be done.

I highly recommend against animating the trigger element. Your triggerElement should not be your animated element. Make them be 2 different elements.
I recommend setting up a scrollTrigger element that it's soul purpose is to trigger the event, and not animation.
Follow this comment to find my recommendation: https://github.com/jonkwheeler/ScrollScene/issues/5#issuecomment-576702673
It's very easy to setup something like

I'm a bit slammed with work right now, but when I get time I'll update the README more to explain. I had to deal with this jumpiness years ago on scrollmagic. Once I changed the way in which I setup my triggers, I never had an issue again.

Thanks for the tip about the trigger.
While this solves the jitter, it does not solve the use case where I only want the animation to run when the trigger scrolls in and out of view from the bottom of the window, but not from the top of the window.
This is why a short-circuit callback option (with the observer entry as an available parameter)  would be useful.

Ah I see. Yeah I'll consider adding this in the future. Nice shout. In the meantime you should use ScrollScene to achieve that.


[Kernel][Standalone] Consolidate testing infrastructure that uses the GoldenTables project and other related clean-up

Description

Updates the goldenTables project to include utils that exposes the resource file path. Updates other projects to depend on it and use that for getting the golden table file paths.
Updates goldenTables to use the latest delta-spark version (just fixes a couple compile errors)
Update the kernelDefault DeletionVectorSuite

Update "end-to-end usage: reading partitioned dv table with checkpoint" to use a golden table since that's how the resource table was originally generated. Adds this table to GoldenTables and removes the no longer used test resource table.
Update the test resource "dv-with-columnmapping" to actually have DV enabled (previously it mistakenly wasn't).

How was this patch tested?
Testing change.
Does this PR introduce any user-facing changes?
No.

@vkorukanti
(1) Removed the .crc files from the "dv-with-columnmapping" tables, but not from the golden table generated tables since those would just be regenerated
(2) I did that here https://github.com/delta-io/delta/pull/1887/files#diff-7f4dd956fba89d1268005d7dad5de577e341e43b14875e400ddc21723ae6d9c3R836. The table added to the golden table module was generated using that code (not copied over from the kernelDefault resources).
(3) I agree about a separate PR if we do it. I think it doesn't really matter and I thought we might consider moving all the modules in connectors/ out of the inner nesting eventually anyways?


Failing to build Narwhals docker image

Hi everyone, I am following the steps in [1], however, the image fails to build. When running :
docker build -f Dockerfile ../ --tag narwhal-node:latest
at first it failed at:
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref f3ad6567-724e-4f│
ed-b479-3581ea79c75b::vvze4tc0sgfx4ik23qot9n8p8: "/narwhal/Docker/entry.sh": not found

I changed  "../" to "../../" and this time it fails at:
 > [planner 3/3] RUN sed -i '/crates\/workspace-hack/b; /crates/d; /narwhal/d' Cargo.toml     && cargo me│
tadata -q >/dev/null:                                                                                │
0.220 error: failed to load manifest for workspace member `/sui/crates/workspace-hack`                   │
0.220                                                                                │
0.220 Caused by:                                                                                │
0.220   failed to load manifest for dependency `bytecode-interpreter-crypto`                             │
0.220                                                                                │
0.220 Caused by:                                                                                │
0.220   failed to read `/sui/external-crates/move/move-prover/interpreter/crypto/Cargo.toml`             │
0.220                                                                                │
0.220 Caused by:                                                                                │
0.220   No such file or directory (os error 2)

Finally I tried to add "COPY . . " at line 32 of the dockerfile, and got:
14.41 error: failed to load manifest for workspace member `/sui/sui-execution`                           │
14.41                                                                                │
14.41 Caused by:                                                                                │
14.41   failed to parse manifest at `/sui/sui-execution/Cargo.toml`                                      │
14.41                                                                                │
14.41 Caused by:                                                                                │
14.41   error inheriting `move-binary-format` from workspace root manifest's `workspace.dependencies.move│
-binary-format`                                                                                │
14.41                                                                                │
14.41 Caused by:                                                                                │
14.41   `dependency.move-binary-format` was not found in `workspace.dependencies`

I tried a quick fix by changing "move-binary-format.workspace = true" in /sui/sui-execution/Cargo.toml to move-binary-format.workspace = path{...}, however, this seems to be necessary for every workspace dependency.
[1]https://github.com/MystenLabs/sui/tree/main/narwhal/Docker
Thanks in advance!

Hi @sebastiaoamaro, it seems caching steps in the Dockerfile is out-of-date. After https://github.com/MystenLabs/sui/issues/13034, I can build the image with
sui $ sudo narwhal/Docker/build.sh

on a mac. The docs will be updated later.
Just curious, what leads you to build Docker images for Narwhal?

I was able to build the images now thanks for the help!, however, I now have a panic on the containers. Should I create a new issue or continue here?
I want to replicate found bugs in docker deployments.
Thank you again!

@sebastiaoamaro great to hear that the image build now. Feel free to create a new issue for the panic and assign it to me. We have stopped running the docker build in CI for awhile, so parts of the docker support may have broken. This works on my machine too:
sudo docker build -f narwhal/Docker/Dockerfile  . --tag narwhal-node:latest

Ok, will create a new issue then.


[C#] Fix repeated group buffer overflow

This actually broke code I was working on in a very nasty way when the buffer size was too small - I was trying to use the DirectBuffer's bufferOverflow delegate and some bytes were getting eaten when expanding the buffer.
Explanation in the commit msg:
On a repeated group in the WrapForEncode, the parentMessage.Limit has two purposes:

It is used as a buffer offset for the _dimensions helper Wrap method
The assignment to it has a side effect of checking that we do not exceed the underlying DirectBuffer's capacity

However notice that currently this assignment happens after writing to the _dimensions helper properties BlockLength and NumInGroup,
i.e. the writes are done before we check for buffer overflow.
Underneath these are direct writes to the byte* managed by the DirectBuffer, resulting in an unchecked, unsafe buffer overflow.
To fix this the Limit has to be increased right after the call to the _dimensions.Wrap, before writes to BlockLength and NumInGroup
The same occurs in the Decode method, only reading unsafe, invalid memory instead of writing to it.
Also fixed _actingVersion was being used before it's assigned in the Encode

Thanks


feate: add SevenZCompressor

What would you like to be added:
Why is this needed:

assign to me

Golang does not implement the bzip compression scheme, so let’s not do this first


Moving logic from create_links() in pagination

I am thinking that create_links() method shouldn't do all the work, it should just create links in html form.
What if we add a protected method that runs at the end of initialize which generates the data like 'next_url', 'prev_url', 'page_numbers' ...etc;
then these data are available to access via getters which create_links() will use, this would make it easier to provide json response of pagination for APIs

Perhaps a refactorisation of this lib will be a good point in future 3.1 version ?
I am volunteer to do it when there is an accepted idea for its next version :)

I don't imagine anyone still actively looking at this, or anything related to the shitty Pagination library for that matter, but ... pull requests are good and issues just sitting open like this one are useless.


bug: Noice won't highlight functions documentation if they're too big (clangd LSP at least)

Did you check docs and existing issues?

[ ] I have read all the noice.nvim docs
[X] I have searched the existing issues of noice.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.0
Operating system/version
Arch Linux
Describe the bug
After commit https://github.com/folke/noice.nvim/commit/520a73760030f1293bbee41b0dcd041f47d1ecae, when using clangd as LSP (other LSPs or sources of Markdown docs still need to be checked), when the documentation window needs to be shown, Noice struggles to highlight the code, and some error messages pop up.
I hadn't updated in a while, but I figured this commit caused the problem using git bisect.
When using the Hover shortcut (capital K) over a function, this error occurs:
...lo/.local/share/nvim/lazy/nui.nvim/lua/nui/text/init.lua:67: Invalid 'col': out of range

And when cycling through nvim-cmp completion options, this message is shown:
Error executing vim.schedule lua callback: ...lo/.local/share/nvim/lazy/nui.nvim/lua/nui/text/init.lua:67: Invalid 'col': out of range
stack traceback:
	[C]: in function 'nvim_buf_set_extmark'
	...lo/.local/share/nvim/lazy/nui.nvim/lua/nui/text/init.lua:67: in function 'highlight'
	...local/share/nvim/lazy/noice.nvim/lua/noice/text/init.lua:114: in function 'highlight'
	...lo/.local/share/nvim/lazy/nui.nvim/lua/nui/line/init.lua:55: in function 'highlight'
	...lo/.local/share/nvim/lazy/nui.nvim/lua/nui/line/init.lua:70: in function 'render'
	...ocal/share/nvim/lazy/noice.nvim/lua/noice/text/block.lua:97: in function 'render'
	...al/share/nvim/lazy/noice.nvim/lua/noice/lsp/override.lua:48: in function 'stylize_markdown'
	...ocal/share/nvim/lazy/nvim-cmp/lua/cmp/view/docs_view.lua:55: in function 'open'
	...e/paulo/.local/share/nvim/lazy/nvim-cmp/lua/cmp/view.lua:242: in function 'callback'
	.../.local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/async.lua:131: in function ''
	vim/_editor.lua: in function <vim/_editor.lua:0>

Steps To Reproduce
My setup is basic LazyVim, none of the mentioned plugins configs were changed. Clangd was installed via Mason.
1 - Have noice.nvim, nvim-cmp and Clangd setup
2 - Crate a .cpp file with a function with a big block of documentation and some inner markdown (example provided)
3.1 - hit K over the function's name for the first error message
3.2 - hit Ctrl + space when referencing the function to trigger completion for the second error message
Here's the example of a function with a doc comment with markdown. Try calling the test() function inside main.
/*! @brief Creates a Vulkan surface for the specified window.
 *
 *  This function creates a Vulkan surface for the specified window.
 *
 *  If the Vulkan loader or at least one minimally functional ICD were not
 * found, this function returns `VK_ERROR_INITIALIZATION_FAILED` and generates a
 * @ref GLFW_API_UNAVAILABLE error.  Call @ref glfwVulkanSupported to check
 * whether Vulkan is at least minimally available.
 *
 *  If the required window surface creation instance extensions are not
 *  available or if the specified instance was not created with these extensions
 *  enabled, this function returns `VK_ERROR_EXTENSION_NOT_PRESENT` and
 *  generates a @ref GLFW_API_UNAVAILABLE error.  Call @ref
 *  glfwGetRequiredInstanceExtensions to check what instance extensions are
 *  required.
 *
 *  The window surface cannot be shared with another API so the window must
 *  have been created with the [client api hint](@ref GLFW_CLIENT_API_attrib)
 *  set to `GLFW_NO_API` otherwise it generates a @ref GLFW_INVALID_VALUE error
 *  and returns `VK_ERROR_NATIVE_WINDOW_IN_USE_KHR`.
 *
 *  The window surface must be destroyed before the specified Vulkan instance.
 *  It is the responsibility of the caller to destroy the window surface.  GLFW
 *  does not destroy it for you.  Call `vkDestroySurfaceKHR` to destroy the
 *  surface.
 *
 *  @param[in] instance The Vulkan instance to create the surface in.
 *  @param[in] window The window to create the surface for.
 *  @param[in] allocator The allocator to use, or `NULL` to use the default
 *  allocator.
 *  @param[out] surface Where to store the handle of the surface.  This is set
 *  to `VK_NULL_HANDLE` if an error occurred.
 *  @return `VK_SUCCESS` if successful, or a Vulkan error code if an
 *  [error](@ref error_handling) occurred.
 *
 *  @errors Possible errors include @ref GLFW_NOT_INITIALIZED, @ref
 *  GLFW_API_UNAVAILABLE, @ref GLFW_PLATFORM_ERROR and @ref GLFW_INVALID_VALUE
 *
 *  @remark If an error occurs before the creation call is made, GLFW returns
 *  the Vulkan error code most appropriate for the error.  Appropriate use of
 *  @ref glfwVulkanSupported and @ref glfwGetRequiredInstanceExtensions should
 *  eliminate almost all occurrences of these errors.
 *
 *  @remark @macos GLFW prefers the `VK_EXT_metal_surface` extension, with the
 *  `VK_MVK_macos_surface` extension as a fallback.  The name of the selected
 *  extension, if any, is included in the array returned by @ref
 *  glfwGetRequiredInstanceExtensions.
 *
 *  @remark @macos This function creates and sets a `CAMetalLayer` instance for
 *  the window content view, which is required for MoltenVK to function.
 *
 *  @thread_safety This function may be called from any thread.  For
 *  synchronization details of Vulkan objects, see the Vulkan specification.
 *
 *  @sa @ref vulkan_surface
 *  @sa @ref glfwGetRequiredInstanceExtensions
 *
 *  @since Added in version 3.2.
 *
 *  @ingroup vulkan
 */

int test() { return 42; }

int main() {

}

Expected Behavior
It should be working just as it was before the change. The broke highlighting isn't even the problem, it's the notifications that appear on the corner every time I'm typing.
Repro
I'll figure out the minimal setup for this, the config is quite annoying. But honestly it's just simpler to get your LazyVim setup and install clangd through Mason.

ok, thanks. Will look into it

I just reverted that change. Can you confirm it now works again?
Don't close this issue yet, since I still need to properly fix the \r code.

Yup, the problem went away

I think I just properly fixed it.


When enabled, module breaks all enriched links in journal entries in pf2e

when i add rich links it adds the link type before the ., maybe this is something with a pathfinder update? or which other modules are you using?


Custom collector page: link to tagged releases

Followup to / inspired by the link-checking failure of #5114
Clarifies the details of how to get an ocb binary (i.e., to look for releases having a tag that starts with cmd/builder), and links to the tags page instead of the specific version. This will make the link checking less brittle.

/cc @theletterf @svrnm

Given that this PR is mainly an editorial change, and that it fixes the broken build checks (for context see https://github.com/open-telemetry/opentelemetry.io/pull/5119#issuecomment-2318012101) that are affecting all subsequent PRs, I'm going to merge this now.
/cc @cartermp
@open-telemetry/collector-approvers - feedback is still welcome and will be addressed, if any, in a followup PR.


Mapping of java.time.LocalDate ... not working

Using dozer and Java 1.8 in combination with the new Date-API causes a problem in case of LocalDate (oder LocalDateTime) properties. There are no out-of-the-box converters for these new Objects.
In case you want to map these objects, dozer throws the following exception:

caused by: java.lang.NoSuchMethodException: java.time.LocalDate.()
    at java.lang.Class.getConstructor0(Class.java:2971) ~[na:1.8.0_05]
    at java.lang.Class.getDeclaredConstructor(Class.java:2165) ~[na:1.8.0_05]
    at org.dozer.factory.ConstructionStrategies$ByConstructor.newInstance(ConstructionStrategies.java:272) ~[dozer-5.5.1.jar:na]

Yeah, I met the same problem.
Wrapped by: org.dozer.MappingException: java.lang.NoSuchMethodException: java.time.LocalDateTime.()
I 'd like to know how to solve it except change it to Date again

I am running in the same issue. So I have written a straightforward so called "dozer-jdk8-support" dependency which is also available on the maven Central Repository.
see https://github.com/GeBeater/dozer-jdk8-support

@GeBeater , it this issue present in Dozer 5.4.0 and later? I wasn't even aware of the issue, but I just checked our code and ZonedDateTime conversion works like a charm on 5.4.0.

@GeBeater ; would you be interested in raising a PR with your convertors?

@garethahealy Wow! It is great to see that dozer was rekindled. As time of converter library creation I decided against a PR because at that time I assumed that nobody would accept the request. I will have a look at the coming weekend and give you feedback whether I am able to raise a PR or not. ;-)

@GeBeater ; cool!

@garethahealy Please let me know, whether the way I implemented LocalDate Converter (see commit ae9b60beead ... is ok. If so, I will implement the remaining converters and create a PR.

@GeBeater ; The code looks fine, but why didn't you add it to the current date convertor? that seems like more logical place than creating another convertor.

https://github.com/garethahealy/dozer/blob/master/core/src/main/java/org/dozer/converters/DateConverter.java

@garethahealy Thanks for your feedback. The reason is, that the DateConverter you are mentioned handles types which contains a date and a time. So I am going to rename the converter to DateTimeConverter and extend the converter with the handling of LocalDateTime and ZonedDateTime types. The handling of types that are contains only a date as well as the handling of types that are only support a time should be placed in a separate converter (my opinion). Please let me know whether this is ok.

@GeBeater ; just to understand fully.

Rename DateConverter to DateTimeConverter
Move any Date only from DateTimeConverter to DateConverter
Move any Time only from DateTimeConverter to TimeConverter

Looking at the current convertor, i can only see Timestamp that is only Time related, and no Date only. All others are DateTime.
https://github.com/garethahealy/dozer/blob/master/core/src/main/java/org/dozer/converters/DateConverter.java#L61

Sorry, guys. It only worked on 5.4.0 because we used copy-by-reference

FYI still not solved with current latest dozer version: 5.5.1.
I'm using LocaleDate withjdk 1.8.0_91, hibernate-core 5.0.11.Final & hibernate-jpa: 2.1-api-1.0.0.Final.
I'll go with the workaround: https://github.com/GeBeater/dozer-jdk8-support

I have added the dozer-jdk8-support to my project, and configured it via the xml file as directed.  But my LocalDateTime objects are still being mapped with the current datetime instead of the datetime in the original object.    Any ideas?

@gudstrand surely a configuration/use problem: check http://stackoverflow.com/a/41081180/3824457 or  or https://github.com/DozerMapper/dozer#simple-example

I did everything suggested and finally just moved on. Replaced dozer with ModelMapper and it worked right out of the box.

Hi.
Any plans to add support for Instant?

@GeBeater ; hows the PR for java 8 datetime objects? Need any help?

I can help with that.

Hi , I got convert issue for offsetdatatime .
org.dozer.MappingException: java.lang.NoSuchMethodException: java.time.OffsetDateTime

@FuchengLi: Had same issue. Update to dozer-core 6.2.0 and dozer-jdk8-support 1.0.4 and it works.

Java8 datetime is supported on master. Can someone check it covers their requirements please

It's work fine. When a release with this important fix?

hi @Jijonty, am using Dozer v5.5.1. Where can I get latest version 6.4.0 of Dozer. CHecked here  but it's showing 5.4.0 as latest version.
THanks.

@kmmahesh here is the latest version https://mvnrepository.com/artifact/com.github.dozermapper/dozer-core/6.4.1

@kmmahesh Not sure without playing with exact code, but you can try some of the examples from documentation, like excluding fields or annotations

@Jijonty got it as how to map selected fields, you can use Context based mapping by specifying a map-id. Documentation has e.g.
Thanks.

Hi I'm still getting this error.
Is a way to fix without using the dozer-jdk8-support
I updated the new dependencies
<dependency>
    <groupId>com.github.dozermapper</groupId>
    <artifactId>dozer-core</artifactId>
    <version>6.4.1</version>
</dependency>

but when I call
dozer.map(eventNtt, EventDto.class);
I get this:

c.g.dozermapper.core.MappingProcessor    : Field mapping error -->
MapId: null
Type: null
Source parent class: com.event.ntt.Event
Source field name: eventTimestamp
Source field type: class java.time.Instant
Source field value: 2019-02-08T16:09:07.062Z
Dest parent class: com.event.dto.EventDto
Dest field name: eventTimestamp
Dest field type: java.time.Instant
com.github.dozermapper.core.MappingException: java.lang.NoSuchMethodException: java.time.Instant.()

I'm doing something wrong?
I must add the support libary dozer-jdk8-support?

@ad3luc What I'm seeing is converter for java.time.Instant is added 2 weeks ago and probably will be pushed in next release. You can use the latest version, package and use the jar

@Jijonty I think that should be the only way until the pushed a new release...
Thanks


Explain the example of usage for arguments in ShapFeatureSelector

In README and all the notebooks, it assigned a value to cv
https://github.com/TorkamaniLab/zoish/blob/537d1e403e6c0cfc85bbfa1e7cb1aa7336bb15de/README.md?plain=1#L231

However, in the function, it indicated to take object:
https://github.com/TorkamaniLab/zoish/blob/537d1e403e6c0cfc85bbfa1e7cb1aa7336bb15de/zoish/feature_selectors/shap_selectors.py#L439

What does it mean for n_iter (default set to 10) as we assumed the input estimator was optimized already?
https://github.com/TorkamaniLab/zoish/blob/537d1e403e6c0cfc85bbfa1e7cb1aa7336bb15de/zoish/feature_selectors/shap_selectors.py#L440
(as it's time-consuming - any benefit from it?)

The default algorithm is "permutation" but why not "auto” as the default SHAP TreeExplainer?
https://github.com/TorkamaniLab/zoish/blob/537d1e403e6c0cfc85bbfa1e7cb1aa7336bb15de/zoish/feature_selectors/shap_selectors.py#L437

Also, what does it mean for n_iter (default set to 10) as we assumed the input estimator was optimized already?

example added


[Feature Request] I need to skew my image

is this possible? I think this is a basic transform feature?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

or please provide raw operation on GameObject's matrix, thank you very much.

@photonstorm thanks for replying, actually I'm integrating DragonBones into Phaser3, and all things done except skew. an object to attach to a slot will be a GameObjects.Image or GameObjects.Container, so which is the best way to implement this? to use mesh I think (although currently mesh does not have indices but still ok for the basic display - DragonBones advanced functionality uses vertex grid which needs indices to do disortion etc).

a high advantage that I use GameObjects.Image to attach to a slot is that it's very easy to get animation work, just set new frame for it that's enough, If use Mesh I need to figure out how to implemenet this, let me have a review in the source code.

Thank you for opening this feature request (all those months ago!). As the development of Phaser 4 has now started I am tidying-up the repo and closing off old issues that won't be directly fixed or implemented in Phaser 3 by me. I would still consider community PRs that address this issue, however, and have left the GitHub tags intact so others can track them if they wish to get involved. However, I'm afraid this is no longer a feature that will be added to v3.


Add test for virtualservice status config

Changes

Add test for VirtualService status config.

Codecov Report

Merging #472 (c2f0ad3) into master (2565e78) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   81.96%   81.77%   -0.20%
==========================================
  Files          15       15
  Lines        1048     1048
==========================================
- Hits          859      857       -2
- Misses        110      111       +1
- Partials       79       80       +1

Impacted Files	Coverage Δ
pkg/reconciler/ingress/ingress.go 69.87% <0.00%> (-1.68%)	⬇
pkg/reconciler/ingress/config/istio.go 100.00% <0.00%> (+3.33%)	⬆
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2565e78...c2f0ad3. Read the comment docs.

how does this decrease coverage... i'm only adding tests 🥺

/lgtm
I'll let Kenjiro approve since he had a request.

/lgtm
I'll let Kenjiro approve since he had a request.