[2.0.1] 'No PostCSS Config found' (options.config)

After todays upgrade to postcss-loader 2.0.0 I'm getting No PostCSS Config found everywhere.
I'm using weback.config.js from https://github.com/JeffreyWay/laravel-mix repository
My actual postCss options are:
    postCss: [
        require('autoprefixer')({
            browsers: ['Chrome >= 35',
                'Firefox >= 38',
                'Edge >= 12',
                'Explorer >= 10',
                'iOS >= 8',
                'Safari >= 8',
                'Android 2.3',
                'Android >= 4',
                'Opera >= 12'],
            cascade: true,
            add: true,
            remove: true
        })
    ]

Fixed in https://github.com/postcss/postcss-loader/commit/c4f006472a85d3bc36ae3f2f0e750291fd732b7b
Released in v2.0.1
😛

Now I'm getting other type of error messages:
Module build failed: TypeError: Cannot create property 'prev' on boolean 'false'
    at Promise.resolve.then.then (C:\Users\Uriziel\ponteus\wp-content\themes\ponteus\node_modules\postcss-loader\lib\index.js:125:47)

Did you update to v2.0.1? This should also be fixed also in v2.0.1 😛

You make me sweat here :D, mom I will investigate

I am getting the same error using the font-awesome-webpack2 package:
ERROR in ./~/css-loader?sourceMap&-minimize!./~/postcss-loader/lib!./~/sass-loader/lib/loader.js?sourceMap!./~/bootstrap-sass/assets/stylesheets/_bootstrap.scss
Module build failed: TypeError: Cannot create property 'prev' on boolean 'false'
    at Promise.resolve.then.then (/Users/gtw/clearwater-public-web/node_modules/postcss-loader/lib/index.js:125:47)
 @ ./~/bootstrap-sass/assets/stylesheets/_bootstrap.scss 4:14-175 18:2-22:4 19:20-181
 @ ./src/layouts/CoreLayout/CoreLayout.js
 @ ./src/main.js
 @ multi font-awesome-webpack2 ./src/main.js webpack-hot-middleware/client?path=http://<IP_ADDRESS>:3000/__webpack_hmr

Don't use starter kit, and tried to update to postcss-loader 2.0.1, still have No PostCSS Config found message. Have pretty big postcss config in few separate postcss.config.js files. What should I upload to help you find problem cause?

Had the same issue after installing the latest postcss-loader, so I reverted back to:
"postcss-loader": "^1.3.3",

I'm also getting the original error (2.0.1).
Now, I'm not sure... am I allowed to NOT have a separate postcss.config.js? I don't have much to config; would rather keep it in my webpack.config.js.

To clarify I do have postcss.config.js files, but not in the root category, they are in separate subfolders fro different entry points.

Please try the fix branch and provide feedback 😛 npm i -D postcss/postcss-loader#fix
@iAdramelk I'm especially interested in your setup :D

Same error here since I've upgrade:
Module build failed: Error: No PostCSS Config found in: /websites/webpack
Basicaly I was doing this:

// ===========================
// LOADERS
// ===========================

module: {
    rules: [
      {
        test: /\.scss$/,
        use: ExtractCSSPlugin.extract({
          fallback: 'style-loader',
          use: ['css-loader', 'postcss-loader', 'sass-loader']
        })
      },
      {
        test: /\.css$/,
        use: ExtractCSSPlugin.extract({
          fallback: 'style-loader',
          use: ['css-loader', 'postcss-loader']
        })
      }
    ]
  },

// ===========================
// PLUGINS
// ===========================

  plugins: [

    // LOADER OPTIONS PLUGIN
    new webpack.LoaderOptionsPlugin({
      options: {
        postcss: [
          autoprefixer()
        ]
      }
    }),

    // EXTRACT CSS PLUGIN
    new ExtractCSSPlugin({
      filename: '[name].[contenthash:8].css',
      disable: config.debug
    })
  ]

}

If you want to see the complete config I just made a gist:
webpack config gist

I just try with the fix branch, that doesn't fix the bug. Got the same error message:
Module build failed: Error: No PostCSS Config found

@jmbelloteau With the fix branch npm i -D postcss/postcss-loader#fix && please don't use the LoaderOptionsPlugin anymore, it was only meant for webpack 2 beta to support loaders incompatible with webpack 2 config syntax, which isn't the case for postcss-loader > 1.0.0

@michael-ciniawsky sure I can make an other trial with your advice. If I don't use LoaderOptionsPlugin what is the recommended method to pass autoprefixer option to postcss?

 {
    test: /\.css$/,
    use: ExtractCSSPlugin.extract({
          fallback: 'style-loader',
          use: [
             'css-loader',
             {
                loader: 'postcss-loader',
                options: {
                  plugins: [ require('autoprefixer')(...options) ]
                }
             }
           ]
        })
}

-    // LOADER OPTIONS PLUGIN
-    new webpack.LoaderOptionsPlugin({
-      options: {
-       postcss: [
-          autoprefixer()
-        ]
-      }
-    }),

@michael-ciniawsky still failing with #fix.
My file structure:
/
    webpack/
        admin/
            postcss.config.js
        application/
            postcss.config.js
        config/
            postcss/
                index.js
                media.js
                vars.js

postcss.config.js in webpack/application/
const config = require('../config/postcss');

module.exports = ctx => config(ctx, 'application');

webpack/config/postcss/index.js
/* eslint import/no-extraneous-dependencies: 0 */

const assets = require('postcss-assets');
const nested = require('postcss-nested');
const autoprefixer = require('autoprefixer');
const colorAlpha = require('postcss-color-alpha');
const flexbugs = require('postcss-flexbugs-fixes');
const simpleVars = require('postcss-simple-vars');
const customMedia = require('postcss-custom-media');
const inlineSVG = require('postcss-inline-svg');
const csso = require('postcss-csso');

const applicationMediaConfig = require('./media');
const {
  application: applicationVarsConfig,
  admin: adminVarsConfig,
  homepage: homepageVarsConfig,
} = require('./vars');

module.exports = function postcssConfig(ctx, pack) {
  const mediaPlugin = customMedia({ extensions: applicationMediaConfig });

  const applicationPlugins = [
    simpleVars({ variables: applicationVarsConfig }),
    mediaPlugin, flexbugs, autoprefixer, colorAlpha, nested, inlineSVG, assets,
  ];

  const landingPlugins = [
    simpleVars({ variables: applicationVarsConfig }),
    mediaPlugin, flexbugs, autoprefixer, colorAlpha, nested, inlineSVG, assets,
  ];

  const homepagePlugins = [
    simpleVars({ variables: homepageVarsConfig }),
    mediaPlugin, flexbugs, autoprefixer, colorAlpha, nested, inlineSVG, assets,
  ];

  const adminPlugins = [
    simpleVars({ variables: adminVarsConfig }), flexbugs,
    autoprefixer, colorAlpha, nested, assets,
  ];

  if (ctx.env === 'production') {
    adminPlugins.push(csso({ restructure: false }));
    applicationPlugins.push(csso({ restructure: false }));
    landingPlugins.push(csso({ restructure: false }));
    homepagePlugins.push(csso({ restructure: false }));
  }

  const packs = {
    admin: adminPlugins,
    application: applicationPlugins,
    landing: landingPlugins,
    homepage: homepagePlugins,
  };

  return {
    plugins: packs[pack],
  };
};

Config lookup starts from 'path.dirname(file)and then walks the file tree upwards, if the config is in a separate folder, you need to setoptions: { config: { path: 'path/to/postcss.config.js' }}inwebpack.config.js` See the README

You config setup is insanely complex tbh 😛

@michael-ciniawsky thank you so much It's working 😄

@michael-ciniawsky not sure how to change it. Basically I have some css files in: webpack/admin/**.pcss  and webpack/application/**.pcss.
If I understand readme correctly, files in webpack/admin/**.pcss should see and use webpack/admin/postcss.config.js and files in webpack/application/**.pcss should see and use config from webpack/application/postcss.config.js. It worked this way in 1.3.3, but now it doesn't work for some reason.
What should I change?

@iAdramelk
|– src
| |– admin
| | |– style.css
| | |– postcss.config.js
| |– application
| | |– style.css
| | |– postcss.config.js
|
|– webpack.config.js
|– package.json

Doesn't work ?

With npm i -D postcss/postcss-loader#fix in case you're currently on v2.0.1 😛

In my case structure was:
|– webpack
| |– admin
| | |– components
| | | |– button
| | | | |– style.css
| | |– postcss.config.js
| |– application
| | |– components
| | | |– button
| | | | |– style.css
| | |– postcss.config.js
|– webpack.config.js
|– package.json

And in wasn't working with #fix branch.

@iAdramelk kk please post the relevant part of your webpack.config.js

Here comes another insane config piece :)
const pcssLoader = {
  test: /.*\.pcss$/,
};

const pcssLoaders = [
  {
    loader: 'css-loader',
    query: {
      sourceMap: !isProduction,
      modules: true,
      localIdentName: isProduction ? '[hash:base64:4]' : '[name]__[local]___[hash:base64:3]',
      camelCase: true,
      minimize: false,
      importLoaders: 1,
    },
  },
  {
    loader: 'postcss-loader',
    query: {
      sourceMap: !isProduction
    }
  },
];

if (isProduction) {
  pcssLoader.loader = ExtractTextPlugin.extract({
    fallback: 'style-loader',
    use: pcssLoaders,
  });
} else {
  pcssLoader.use = ['style-loader', ...pcssLoaders];
}

config.module.rules.push(pcssLoader);

Which webpack version are you on atm?

postcss.config.js
module.exports = ({ file, options, env }) => ({
  parser: file.extname === '.sss' ? 'sugarss' : false,
  plugins: {
    'postcss-nested': {},
    'cssnano': env === 'production' ? { safe: true } : false
  }
})

webpack.config.js
{
  test: /\.(sss|css)$/,
  use: env === 'development'
    ? [
      'style-loader',
      { loader: 'css-loader', options: { importLoaders: 1 } },
      {
        loader: 'postcss-loader',
        options: {
          sourceMap: true
        }
      }
    ]
    : ExtractTextPlugin.extract({
      fallback: 'style-loader',
      use: [
        { loader: 'css-loader', options: { importLoaders: 1 } },
        {
          loader: 'postcss-loader',
          options: {
            sourceMap: true
          }
        }
      ]
    })
},

NODE_ENV=production webpack
NODE_ENV=development webpack-dev-server

Works on the fix branch 😊

[Hopefully 😛] fixed by https://github.com/postcss/postcss-loader/commit/e764761
Released in v2.0.2
Reopen if still regressions
@iAdramelk Please share link to a small repo I can debug, out of the gut I guess there is an error somewhere else aswell e.g postcss-assets + webpack didn't work well for me a while ago 😛

if there is no options passed to the postcss-loader I still get the error with 2.0.2
        {
          test: /\.scss$/,
          use: [{
              loader: 'style-loader'
            }, {
              loader: 'css-loader?modules&localIdentName=[hash:base64:4]&importLoaders=1&sourceMap&camelCase=true'
            }, {
              loader: 'postcss-loader'
            }, {
...

adding
            }, {
              loader: 'postcss-loader',
              options: {
                sourceMap: true
              }
            }, {

solved the issue with 2.0.2

Same behavior as @rolele, v2.0.2 is still generates this error even when I have:
new webpack.LoaderOptionsPlugin({
    options: {
        postcss: [
            require('precss'),
            require('autoprefixer')
        ]
    }
}),

This works though:
    loader: ExtractTextPlugin.extract({
        fallback: 'raw-loader',
        use: [
            'css-loader' + (isProd ? '?minimize' : ''),
            {loader: 'postcss-loader', options: { plugins: () => [ require('precss'), require('autoprefixer') ] }},
            'sass-loader'
        ]
    })

I'm also using LoaderOptionsPlugin and it does not work with 2.0.2.

LoaderOptionsPlugin is deprecated/unnecessary, it was just for the webpack 2 beta phase to support loaders which didn't support the new webpack config format during that time, please don't use it anymore 😛
postcss-loader =< v1.0.0
const query = loaderUtils.parseQuery(this.query) || this.options.postcss // <= the old webpack v1 config.postcss prop

postcss-loader > v1.0.0 (2.0.0)
const options = loaderUtils.getOptions(this) // no config.postcss support since it's not needed anymore

What's the best way to maintain config in webpack.config so we can avoid polluting our projects with a more config files?
This works when you only need to define it for one rule:
        {loader: 'postcss-loader', options: { plugins: () => [ require('precss'), require('autoprefixer') ] }},

But it gets unwieldy when you have to apply it on multiple rules, what's the best way to define it once in a central location in webpack.config and have it applies to all postcss-loader rules?

If you need a dynamic config, 'polluting' your project would be the wisest descision
{
   loader: 'postcss-loader'
   options: {
     config: {
       ctx: { plugin2: {...options} } // ctx.options in postcss.config.js
    }
  }
}

postcss.config.js
module.exports = ({ file, options, env }) => {
  parser: file.extname === '.sss' ? 'sugarss' : false
  plugins: {
    'plugin1': { root: file.dirname }
    'plugin2':  env === 'development' ? options.plugin2 : false
    'cssnano': env == 'production' { safe: true } : false
  }
}

and so on....
webpack.config.js
const env = process.env.NODE_ENV

function plugins (loader) {
   return [
      require('plugin')({ root: loader.resourcePath }),
      env === 'production' ? require('cssnano')({ safe: true }) : false
   ].filter(Boolean)
}

const config = {
  ...
  {
     loader: 'postcss-loader',
     options: { plugins: plugins(loader) }
   }
  ...
}

That's all steps I resolved via postcss-load-config in a nutshell, sry but I won't give any futher support upon this use postcss.config.js or find your way 😛

@michael-ciniawsky here, I created simplified repo without insane configs and inheritance. :) Just postcss.config.js with autoprefixer in folder and webpack.config.js in root directory.
Still failing in 2.0.2:
https://github.com/iAdramelk/postcss-loader-bug

Removing postcss config from LoaderOptionsPlugin fixed the problem for me.

@iAdramelk Thx I will take a look as soon as possible :)

@iAdramelk Fixed && Released in v2.0.4
I was sloppy... 😛

Is postcss.config.js actually required, can't I just specify the options directly in my webpack.config?

@JPortegijs Both are supported && loading hierarchy iswebpack.config.js > postcss.config.js

@michael-ciniawsky yep, no more error! Thank you very much.

Everything good here, too! Thanks!

still getting the mentioned error on<EMAIL_ADDRESS>using
new webpack.LoaderOptionsPlugin({
      minimize: false,
      debug: true,
      options: {
        postcss: [autoprefixer({ browsers: ['last 2 versions'] })],
      },
    }),

I need to add this to the README... :stuck_out_tongue:
@th3fallen LoaderOptionsPlugin doesn't work with postcss-loader >= v2.0.0 anymore since it's deprecated to use for loader options, when the loader supports webpack 2 config syntax
**webpack.config.js
{
   test: /\.css$/,
   use: [
     ...,
     ...,
    { loader: 'postcss-loader', options: { plugins: [ require('autoprefixer')(options)) ] } }
  ]
}

new webpack.LoaderOptionsPlugin({
      minimize: false,
      debug: true,
-      options: {
-        postcss: [autoprefixer({ browsers: ['last 2 versions'] })],
-      },
    }),

@michael-ciniawsky thanks for the input but how would i manage that in this syntax?
 {
        test: /\.(scss|css)$/,
        loader: ['style-loader', 'css-loader', 'postcss-loader', 'sass-loader'],
      },

@th3fallen
**webpack.config.js
// webpack 2 module.loaders => module.rules
{
   test: /\.(scss|css)$/,
   use: [ // webpack 2 loader => use
     'style-loader'
    { loader: 'css-loader', options: { importLoaders: 2 }, // needed for webpack @import handling
    { loader: 'postcss-loader', options: { plugins: [ require('autoprefixer')(options)) ] } },
    { loader: 'sass-loader', options: { includePaths: [ /* path/to/@imports */ ]}
  ]
}

thanks @michael-ciniawsky that works for my dev env. but in my productions build that's formatted like this...
const webpack = require('webpack');
const ExtractTextPlugin = require('extract-text-webpack-plugin');
import getConfig from '../config';
const path = require('path');
const config = getConfig(process.env.NODE_ENV).config;

const publicPath = (config.PREFIX || '').replace(/\/$/, '') + path.join(process.env.PUBLIC_PATH || '/').replace(/^\./, '');

module.exports =  {
  plugins: [
    new webpack.LoaderOptionsPlugin({
      minimize: true,
      debug: false,
    }),
    new ExtractTextPlugin({
      filename: 'assets/css/[name]-[hash].css',
      allChunks: true,
    }),
  ],
  module: {
    rules: [
      {
        test: /\.(scss|css)$/,
        loader: ExtractTextPlugin.extract({
          fallback: 'style-loader',
          use: [
            'style-loader',
            'css-loader',
            {
              loader: 'postcss-loader',
              options: { plugins: [require('autoprefixer')({ browsers: ['last 2 versions'] })] },
            },
            'sass-loader',
          ],
          publicPath,
        }),
      },
    ],
  },
};

im getting...
ERROR in ./~/css-loader!./~/postcss-loader/lib?{"plugins":[null]}!./~/sass-loader/lib/loader.js!./app/styles/app.scss
    Module build failed: TypeError: Cannot read property 'postcss' of null
        at Processor.normalize (/Users/clarktomlinson/Sites/When-I-Work/wheniwork-js/node_modules/postcss-loader/node_modules/postcss/lib/processor.es6:101:18)
        at new Processor (/Users/clarktomlinson/Sites/When-I-Work/wheniwork-js/node_modules/postcss-loader/node_modules/postcss/lib/processor.es6:35:29)
        at postcss (/Users/clarktomlinson/Sites/When-I-Work/wheniwork-js/node_modules/postcss-loader/node_modules/postcss/lib/postcss.es6:34:12)
        at Promise.resolve.then.then (/Users/clarktomlinson/Sites/When-I-Work/wheniwork-js/node_modules/postcss-loader/lib/index.js:137:12)
     @ ./~/style-loader!./~/css-loader!./~/postcss-loader/lib?{"plugins":[null]}!./~/sass-loader/lib/loader.js!./app/styles/app.scss 4:14-189

any ideas?

@th3fallen {"plugins":[null]} in error line, seems require('autoprefixer')({ browsers: ['last 2 versions'] }) return null

so why would that exact same config work for my dev enviroment?

apparently adding ident: 'postcss', fixed it....

@th3fallen latest postcss-loader ? (v2.0.5)
and please remove style-loader from ExtractTextPlugin.extract().use you it should only get triggered via fallback
{
        test: /\.(scss|css)$/,
-       loader: ExtractTextPlugin.extract({
+       loader: ExtractTextPlugin.extract({
          fallback: 'style-loader',
          use: [
-           'style-loader',
            'css-loader',
            {
              loader: 'postcss-loader',
              options: { plugins: [require('autoprefixer')({ browsers: ['last 2 versions'] })] },
            },
            'sass-loader',
          ],
          publicPath,
        }),
      },

@michael-ciniawsky yep, what you suggested works, not sure why not it does...

style-loader 'pitches'  code for <style></style> into your files, loading this madness can break ETWP and then the automatically generated ident might be missing, bc of a former error and your plugins don't get stringified etc etc... 😛 It works now and you get a separate 'autoprefixed' CSS file ?

no, i get 1 css file but that's what's expected from my build

Kept getting
ERROR in ./~/css-loader?{"modules":true,"importLoaders":3,"localIdentName":"[name]__[local]__[hash:base64:5]"}!./~/postcss-loader/lib!./~/resolve-url-loader!./~/sass-loader/lib/loader.js?{"outputStyle":"expanded","sourceMap":true}!./main/src/accountPages/MyPolicies/Policy/policy.scss
Module build failed: Error: No PostCSS Config found in:
...

until I added:
      {
        test: /\.scss$/,
        use: [{
          loader: 'style-loader'
        }, {
          loader: 'css-loader', options: {
            modules: true,
            importLoaders: 3,
            localIdentName: '[name]__[local]__[hash:base64:5]'
          }
        }, {
          loader: 'postcss-loader', options: {
+            plugins: [require('autoprefixer')]
          }
        }, {
          loader: 'resolve-url-loader'
        }, {
          loader: 'sass-loader', options: {
            outputStyle: 'expanded',
            sourceMap: true
          }
        }]
      },

@heisian That's the intended behaviour, either the setup (plugins && options) is specified in webpack.config.js or otherwise look for postcss.config.js and finally throw none are present, because without any setup, you parse the CSS to an AST for no reason and don't need postcss-loader (perf regression)

that config was in my webpack.config.js - not in to having a postcss.config.js file in 20+ folders, so webpack.config.js is preferred..
what is an AST? I apologize but this is about my 6th day of using Webpack in this manner.
Random tweaking has gotten me successful configs for both dev and production, however I could very well stand to learn more about what's actually going on here.
So.. why does adding the autoprefixer plugin get rid of the error? Isn't autoprefixer just a plugin for expanding out all the various permutations of CSS properties across browsers? Does postcss-loader by default require autoprefixer to function?

that config was in my webpack.config.js - not a fan of having a postcss.config.js file in 20+ folders, so webpack.config.js is preferred..

You need one postcss.config.js in the root (./), but it's enterily personal choice where to specified options :). More postcss.configs.js is only needed if you need different transforms (plugins) for certain files (Config Cascade)
CSS File {String}
=> CSS Parser (e.g PostCSS)
=> [Post]CSS AST {Object (JSON)}
=> plugin1(plugin2(pluginN(ast)))
=> PostCSS Stringifier
=> CSS File {String}

What is an AST?

AST => Abstract Syntax Tree
File (Source)
.class {
   width: 25%;
}

Interface (Syntax)
<Selector> {
  <Declaration>: <Value>;
}

AST (PostCSS)
Root {
  raws: { semicolon: false, after: '\n' },
  type: 'root',
  nodes:
   [
    Rule {
       raws: [Object],
       type: 'rule',
       nodes: [Object],
       parent: [Circular],
       source: [Object],
       selector: '.class',
       lastEach: 2,
       indexes: {}
    }
  ],
  source:
   {
     input:
     Input {
        css: '.class {\n  width: 25%;\n}\n',
        file: './src/index.css'
     },
     start: { line: 1, column: 1 }
  },
  lastEach: 2,
  indexes: {}
}

So.. why does adding the autoprefixer plugin get rid of the error?

In theory you could of course parse the CSS and stringify it back without any plugins (transforms), but this computation is unnecessary/useless then 😛

@michael-ciniawsky can we close conversation here? If someone want to write about bug or other stuff, let create new issue.

Yep, you can lock the thread anytime if you want 😛

If someone has problems, please create a new issue. Thanks!


TcpProxy: properly handle upstream LocalClose events.

Signed-off-by: Greg Greenway<EMAIL_ADDRESS>LocalClose events can happen if the ClientConnection fails to bind or set socket options. Prior to this change, the TcpProxy would ignore the error.
Risk Level: Medium
Testing: Unit tests added
Release Notes: None

@alyssawilk do you mind taking this one?

I think it is high risk for TcpProxy, medium for envoy overall because the change doesn't reach outside of TcpProxy at all.


add ngrok.connect(map) and ngrok.disconnect(url)

Current dependencies on/for this PR:

bob/connect

PR #43   👈

PR #44

This comment was auto-generated by Graphite.


feat: add Terraform deployment option

[ ] Tests written and linted ℹ
[ ] Documentation written in Wiki/README
[ ] Commit history is tidy & follows Contributing guidelines ℹ

What this does
Adds a Terraform deployment option. Deploys the same resources as the CloudFormation template.

💯 Looks good to me! Though, I can't merge :


Nebra indoor gen1

Hii
My sd card is full
Can i have the flash image to upgrade the sd card with 64gb because my miner has 32gb only
And if you can send me the way to do it

This is not a support channel.
Please email<EMAIL_ADDRESS>


radv/amdgpu: Failed to allocate a buffer

I have a RX 7900 XTX, and it looks like not all of my memory is being tested.  Passed  0.0310 seconds  written:   11.2GB 864.3GB/sec        checked:   15.0GB 832.2GB/sec

I have resizable BAR turned on in my bios.
I will attach the output I see running with the file renamed to memtest_vulkan_verbose.
It also appears that the tool crashes if I write to a log file with tee using a pipe. (i.e. ./memtest_vulkan_verbose | tee memtest_vulkan_verbose.txt will crash when ctrl+c is pressed)
memtest_vulkan_verbose.txt

In short: thanks for reporting. This is known behavior and is mostly harmless.
(I've noted the crash on Ctrl+C while piped as a separate issue #17).
Detailed:
The reason of a problem is a some incompatibility between RADV driver and memtest_vulkan. memtest_vulkan insists on allocating contiguous buffer (this is a technical design choice), but RADV is failing to allocate such buffer contiguously.
However, the good news: being able to test only 15.0GB out of 24.0 GB is not a problem for nearly all usages, since

if you are using memtest_vulkan to check the GPU for errors or overclocking stability - in practice, 99% of VRAM errors actually found by memtest_vulkan are not bound to a specific memory location, but to a data transmission mechanisms. So, they are equally found while testing ~24GB and 16GB (and even 3-4GB).
if you are using memtest_vulkan for cooling/performance check - 16GB and 24GB are the same too.

So the for 99% cases - this is just fine. The Failed to allocate a buffer messages above are generated by a driver, and from the memtest_vualkn usage scenario can be just ignored.
I can't make the driver less verbose since it is driver's unconditional stderr output
Actually some other drivers sometimes fails allocations of large contiguous buffers too, memtest_vulkan silently auto-selects a bit smaller, it's just ok.
As a half fix - I plan to detect RADV driver and apply some minor tunes:

add a notice the to the memtest_vulkan that the errors from driver are harmless
tune the memory size auto selection coefficient to faster decreasing memory size - so the count of errors won't be so huge.

Also, there is a chance that the 16GB limit is specified in some limits exposed by the driver, but I'm  not sure.
Can you please install the package containing the vulkaninfo utility (something like vulkan-tools) and attach the output of VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/radeon_icd.x86_64.json vulkaninfo ?
A side note: AMD GPUs on Linux has 2 different opensource vulkan drivers that can be installed simultaneously without severe conflicts. So you can additionally install the AMDVLK driver, and specify the driver to use by a VK_ICD_FILENAMES environment variable
(for your vulkan loader's libvulkan1 version. Newer libvulkan1 loader version renamed that var to VK_DRIVER_FILES).
So, with AMDVLK driver additionally installed you can run
[user@host]$ VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/amd_icd64.json ./memtest_vulkan
[user@host]$ VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/radeon_icd.x86_64.json ./memtest_vulkan

I have no 16+GB AMD GPU, but from my experience with 12 GB RX6700 - AMDVLK allows testing 10.5GB (1.5GB is auto-skipped by memtest_vulkan to avoid desktop lockup), while RADV limits it to 4GB. So I hope that for RX 7900 the AMDVLK can allow going above 16GB.
The same environment var applies to all other vulkan apps, including vulkaninfo

Thanks for the detailed reply!
I had thought I had both drivers installed but upon further inspection, discovered that I only had the RADV driver installed. I had to do a lot of package jumbling in order to get versions of MESA and a kernel that would support this GPU, so I guess I lost the AMDVLK driver in the process. Once I installed the AMD driver again, memtest_vulkan prompted me to select which driver to use. The issue did not appear with the AMDVLK driver, and I was able to stress test my system for an hour or so without any issues.
Thanks again for your help!
Also, thanks for letting me know about the VK_ICD_FILENAMES and VK_DRIVER_FILES environment variables. I previously only knew that I could specify to use the RADV driver via AMD_VULKAN_ICD=RADV, back when I wasn't using a bleeding-edge MESA and kernel, and had both drivers installed. ;-)


Adds RGroupDecomposition attempt

What does this implement/fix? Explain your changes.
This implements RGroup Decomposition for inclusion into the RDKit core.
There a lot of exposed twiddles to the API, I expect that a bunch of these could get removed at a later date.
Example usage
core = Chem.MolFromSmiles('O=C1C([*])C2N1C(C(O)=O)=C([*])CS2')
rg = RGroupDecomposition(core)

mols = []
count = 0
for line in open("compounds.txt"):
    sm = line.split()[-1]
    m = Chem.MolFromSmiles(sm)
    if m:
        count += 1
        idx = rg.Add(m)
rg.Process()

And to view in  a pandas table:
frame = pd.DataFrame(rg.GetRGroupsAsColumns())
PandasTools.ChangeMoleculeRendering(frame)

Any other comments?

There is no real reason to expose the class directly, these could be placed into a functional interface.

Along with the above, the pimpl design pattern is used mainly to prevent exposing a lot of implementation details into the main namespace.

There is a known missing feature, that generic smarts cores could/should be replaced with the actual matching core found for reporting purposes.  This could "easily" be done, but adds some more internal logic.

It would be awesome to align the depictions to the cores, this might be useful in the future as well.

A new AdjustQuery option was added when we only want to match the HeavyDegree, SMARTS isn't so nice for this, but we could manage it if desired, currently the HeavyDegree option is not capable of being output as a smarts pattern which is sub-optimal.

I'm still in the middle of the review (can you see comments before the review is done?), but I've got a question: How are you handling chirality?
As a "simple" example (not that anything here is simple), if I have the core C1NCO1 and decompose the molecules C1N[C@](CC)(OC)O1 and C1N[C@@](CC)(OC)O1, what do you think I should get?

There is a notebook that covers this.  Basically unless specified it treats it as you don't care but reports the stereo in the r-groups.
The system was designed to add new cores when appropriate, but this isn't fleshed out.  I.e. If we detect stereo at an rgroup, we could add a new core with stereo.  I want to do this for dummy atoms in rings btw.

Ok, found the notebook now.
What do you mean by "unless specified it treats it as you don't care but reports the stereo in the r-groups"?
I see nice behavior if stereochem is specified in the core, but when it's not specified I don't see anything special about the R groups.

I'm trying to understand the results in the stereochem notebook where stereochem is specified.
Take a look at output 19 in this notebook: https://gist.github.com/greglandrum/0fa6c1c15f05695f5e8bd4ab75dba1fc
For this input (note: the trick to get reasonable renderings of SMARTS query molecules is to specify as much of the bonds as possible):
core = Chem.MolFromSmarts("C-1-C-C-O-[C@@](-*)(-*)1")

I get as a core output:
Out[19]:
'C1-C-C-O-[C&*]-1(-[*:2])-[*:1]'

I don't really understand that.

Regarding the stereochem:
Out[19]:
'C1-C-C-O-[C&*]-1(-[*:2])-[*:1]'

The code is processing the core for visualization (adding RGroup designations and such), perhaps I'm accidentally removing stereo info when doing this.  I'll investigate.

@greglandrum  The notebook output you don't understand is probably because I'm hacking the results to show RGroups in the depiction.  I'm using the dummyLabel to set the R1 .. R2 etc.  I didn't realize this affected the smarts output.
from rdkit import Chem
m = Chem.MolFromSmiles("C1COC([*:1])C1")
dummy_atom = [atom for atom in m.GetAtoms() if atom.GetAtomicNum()==0 ][0]
dummy_atom.SetProp("dummyLabel", "R1")
Chem.MolToSmarts(m)
# '[#6]1-[#6]-[#8]-[#6](-[R1:1])-[#6]-1'

There are a couple of small changes in the most recent PR I made against your branch. When those are made, I think this is ready to merge.

@greglandrum I'm going to merge this with the master branch to get the tests running again and do another once-over.

Sounds reasonable.

Closed by 62150f7


Tag Editor hover state updates when popups or other windows are on screen

This is because I'm checking against get_global_rect(). Ideally, I'd be using mouse_entered and mouse_exited, but for some reason this doesn't seem to work.

Already fixed in a WIP pull request that will take a while longer to finish.


I have tried 2 packages now and they do not account for multiple databases for models

I have tried 2 packages now and they do not account for multiple databases for models. I have not tried this one yet do you guys have a solution for this?

Hey @krognome can you further explain it? What do you mean by multiple database? Are you referring to tenancy?

I was able to get one of the packages to work by simple changing the protected member variable of $connection on the class that extends the model with the morphTo


"Lighther" build only with plain html5 plugins

In our product we are using a fork where we do something like this in order to get a lighter build :)
We don't always need Hlsjs, and we don't need all the Flash stuff.
We are lowering the Clappr non-minified build from > 1Mb to ~400 Kbytes.
Minified goes down to from ~500 to ~200Kbytes.
We already load a lot of stuff on the frontend, and people are really unhappy about such a big library full of stuff that we don't necessarilly use.
So it would be great if such a build option could be integrated into our build system.
It's a proposal on how to do it, all open for discussion, as long as we hit the goal of being able to produce easily a build without all "non-essential" playback plugins :)
BTW my personal opinion is that all these plugins:

Yes can be shipped in the main Clappr git repo, it has a lot of advantages of having the core and the plugins in one repo (for example CI / testing)

but should not be shipped as individually built modules, that one can include or not into the page, or load on demand

Coverage decreased (-0.2%) to 73.644% when pulling dad4aee8753daf7e6385b2202700d04fe95eed05 on tchakabam:feature/build-only-with-plain-html5-plugins into a7a1d923891ec84151ae30c4349f20f72e404f3a on clappr:master.

Cool @tchakabam we discussed that a long time ago and now we're doing it again, @towerz was looking into how to make it modular (breaking the playbacks into their own github plugin and changing how we build, with two versions full and light) and @thiagopnts was working individually to shrink clappr size too.

as i said, i think it's good to have one repository, instead of having to deal with different repos.
so i would strongly favor for keeping the one big repo, but allowing the build system for one core, and many plugin binaries. in that way, you can distribute one version of everything that will actually work together, instead of always having to match the versions here and there, that's hell for anyone who wants to use it. with the mono-repo, if core breaks a plugin API, we see in CI tests on the one repo :)
It's just that you need to set up the build system to spit out several binaries :)
that's pretty easy with webpack in fact, with the chunks mode.
also, what we did in the playback middleware in my current project is that we load dependencies on-demand, using loadjs and dynamic import.
because sometimes we use Shaka and sometimes a proprietary SDK on top of Clappr, and depending on the platform we load either of the two dependent libs (and eventually the ShakaPlayback plugin).
one could make the Loader here an actual loader by allowing to get the plugins on-demand, and resolving promises to their constructors once they are loaded.
Btw there are a few other projects out there who do it so, for example GStreamer: https://cgit.freedesktop.org/gstreamer/
And Google also has a mono-repo, even if we re not there yet :speak_no_evil:

But anyway, I guess the broader discussion is one thing, this is just a small step in order to allow people having a lighter build, and we could distribute it as a seperate webpack output bundle (different than code-splitting/chunks), just by running these two configs and having a file clappr.plainhtml5only[.min].js

Coverage increased (+0.2%) to 74.027% when pulling 5675ce8720fbf27b8a03b1e153c85887671f90b2 on tchakabam:feature/build-only-with-plain-html5-plugins into a7a1d923891ec84151ae30c4349f20f72e404f3a on clappr:master.

@towerz OK, this should be what we want? :)
Also, should we commit the source-map for release builds? I guess it makes sense to distribute it along with the package (since we are distro'ing src along with the package), so that one can actually debug even when using minified build.
And for the future roadmap, it would be good to:

Have a more generic solution for build-option flags via env vars as discussed above
Have only one single call to webpack, and differentiate release/debug/other cases via the build options flags

@tchakabam it makes sense to add source maps to releases. I thought we were generating it, but we're not.

Source-maps were enabled only in the UglifyJS config, but it also needs to be set as devtool in main webpack config.

Coverage decreased (-0.03%) to 73.816% when pulling c85a4d8942bc77de1248489322ecbe6ca682757b on tchakabam:feature/build-only-with-plain-html5-plugins into a7a1d923891ec84151ae30c4349f20f72e404f3a on clappr:master.

@towerz Source-maps were generated but only when doing uglification, and by uglify-js. The devtool option on the main webpack config makes sure that generally you get a mapping from webpack bundle to original module sources, no matter if it has been uglified or not.
so there is a .min.map that maps from the uglified code, and one that maps from the unminified code, both towards the original source modules now.

Coverage decreased (-0.09%) to 73.759% when pulling 0701ff0a88064e175e3c550b7fe9cfdc25f8dae2 on tchakabam:feature/build-only-with-plain-html5-plugins into a7a1d923891ec84151ae30c4349f20f72e404f3a on clappr:master.

Coverage decreased (-0.03%) to 73.816% when pulling f5d2338496d348065c2b5b1e2016fb5c15c523dc on tchakabam:feature/build-only-with-plain-html5-plugins into a7a1d923891ec84151ae30c4349f20f72e404f3a on clappr:master.

Coverage increased (+0.3%) to 74.123% when pulling cc12aff714f3f786620821065320691d8321ba18 on tchakabam:feature/build-only-with-plain-html5-plugins into a7a1d923891ec84151ae30c4349f20f72e404f3a on clappr:master.

Coverage increased (+0.01%) to 73.855% when pulling f537067043315dca8f26f1448ff3826da71a0712 on tchakabam:feature/build-only-with-plain-html5-plugins into a7a1d923891ec84151ae30c4349f20f72e404f3a on clappr:master.

@towerz After adding the source-maps for non-min build, I need to increase test coverage, so I fixed/added some tests in HLS and media-control specs.

@towerz Sure, that makes sense! I removed all of it now. But what about the source-map for non-minified builds? :)

@towerz I just thought: Wouldn't it be good to also distro the smaller build right away in the repo? for example with a naming patterns like clappr.plainhtml5only{.min}.js ?

@tchakabam that's a good idea, can you add this?

Coverage increased (+0.1%) to 75.725% when pulling 87511a5de884af144bf81b94bb07adc9e1546464 on tchakabam:feature/build-only-with-plain-html5-plugins into c38b66f195de85d92b6910c9e88c826605f0aafd on clappr:master.

@towerz it's done :beers: merry xmas!


Psych Engine doesn't run on x64 Windows 11.

Describe your bug here.
I downloaded Psych Engine 0.6.3 on my x64 Windows 11 laptop because i need old version for a mod. When i try to launch the .exe file, it runs the proccess but doesnt launch the program itself. What can i do?
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
nothing

nvm i just needed to install a newer version

try redownloading the game

0.6.3 is not supported anymore


Fix/#565 create person disable empty address addition selection

fixes #565

 Create Person use case: disable empty address addition selection #565


fix only openyurt crd conversion should be handled for upgrading cert

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug
What this PR does / why we need it:
yurt-manager component only handle CRD resource of OpenYurt project, because certificates of other components will be effected.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm
/approve

/backport release-v1.4


Calibrated exposure quality monitoring

Codecov Report

Merging #70 (8e32fe2) into develop (90e069f) will increase coverage by 4.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
+ Coverage    84.80%   88.87%   +4.07%
===========================================
  Files           13       17       +4
  Lines          704      944     +240
===========================================
+ Hits           597      839     +242
+ Misses         107      105       -2

Impacted Files
Coverage Δ

huntsman-drp/src/huntsman/drp/fitsutil.py
83.56% <0.00%> (-14.78%)
:arrow_down:

huntsman-drp/src/huntsman/drp/butler.py
87.75% <0.00%> (-5.75%)
:arrow_down:

huntsman-drp/src/huntsman/drp/datatable.py
84.02% <0.00%> (-2.78%)
:arrow_down:

huntsman-drp/src/huntsman/drp/refcat.py
76.47% <0.00%> (-0.13%)
:arrow_down:

huntsman-drp/src/huntsman/drp/quality.py

huntsman-drp/src/huntsman/drp/lsst_tasks.py

huntsman-drp/src/huntsman/drp/utils/butler.py

...an-drp/src/huntsman/drp/lsst/ingest_refcat_task.py
95.16% <0.00%> (ø)

huntsman-drp/src/huntsman/drp/utils/testing.py
95.45% <0.00%> (ø)

huntsman-drp/src/huntsman/drp/lsst/tasks.py
82.10% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46369b0...8e32fe2. Read the comment docs.


Added smtpd_sender_login_maps

Added smtpd_sender_login_maps for reject_sender_login_mismatch postfix option.

This file does not needs to be only set when using ldap?

Totally forgot about it - yes, this modification is for ldap. Not sure where to find file with those contents without ldap:
"The controlled_envelope_senders table specifies the binding between a sender envelope address and the SASL login names that own that address:
/etc/postfix/controlled_envelope_senders
# envelope sender           owners (SASL login names)
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>postmaster<EMAIL_ADDRESS>@example.net                barney, fred<EMAIL_ADDRESS><EMAIL_ADDRESS>"

So this can be merged or are changes still needed?

Now it works in my ldap setup. Waiting for tests.

Can you please check if this would work with ldap as well. Otherwise we would have to differentiate between ldap and non ldap builds.
Please see the comments.

A am a beet confused. You would like me to check your solution from comment in another pull request? I will test it when I will be near PC.

A am a beet confused. You would like me to check your solution from comment in another pull request? I will test it when I will be near PC.

Sorry for the confusion..
Yes, exactly! That would be great.
Your PR is only working for ldap users. So in case we would implement smtpd_sender_login_maps for everyone else as well, we would have to distinguish upon server start, which mapping file we need to use.
(Depending if that's a ldap or a "standard" setup)
So, if the regex suggestion works for you/ldap as well, than we just need this one mapping file for everyone.
I hope this was less confusing!

@TechnicLab could you fix the conflict?

Actually there was no confusion anymore, it was too late in my time zone. Unfortunately stilll no near PC(

Unfortunately it is not working with my ldap setup. I guess we need to separate ldap and simple configurations.

I personally use ldap but I don't encounter any issues at the moment with master. Does this mean the restriction is not working?
ps. I have extracted the ldap service in this project in it own docker: https://hub.docker.com/r/jsmitsnl/docker-openldap-postfix-book

I manually added changes from 17Halbe and they lead to inability to send any mail. In current master you can still send messages from any email.

Ok, why do the tests for this PR fail do you know why?

Actually I have no idea.

Ok thanks for trying.. Shouldn't this be the default(not letting every signed in user spoof its address)?

No, this is not the default behavior.

I know, but IMHO it should be!
\So it has to be implemented for everyone else as well!

I absolutely agree with you, but maybe there is a reason for such default configuration?

I'll provide a PR on this in a few days. Should be easy enough.

warning: pcre map /etc/postfix/sender.cf, line 1: no closing regexp delimiter "+": ignoring this rule. It looks like there is an error with your regexp.

You copied the + from the comment as well.. Which is actually great, since this leaves a silverlining, that it will still probably work.
Just remove the leading + from the expression! Does it work?

Great! It working now.

Well, this pull request can be merged when we will determine why it is causing tests failitures.

Can you add a testcase for a user spoofing it's address?

I am making changes mainly online on GitHub without cloning repo, so I can’t check whatever test work locally or not. I will look into projects’s tests closer and will try to create spoofing test.

Did you check, if you could still receive mail from a foreign address? I think this is actually be blocking anyone sending mails to the server.
If that's the case(which I am pretty sure of), try replacing reject_sender_login_mismatch  with reject_authenticated_sender_login_mismatch

Looks like you are right, my test container rejects mail from foreign addresses.

and reject_authenticated_sender_login_mismatch? Does that work as expected?

Yes

/etc/postfix/senders.cf: No such file or directory
Modify the Dockerfile to copy that file over to the container

Thats's strange: ldap tests failed but it works locally.

@TechnicLab Could you fix the conflict and update the branch for a retest?

Well, it should work now. I will add tests today.

@TechnicLab love to merge the PR, could you inform me about the state of adding tests?

I’m sorry, I am currently ill and was not in great working condition.

@TechnicLab hope you get well soon

@TechnicLab  I hope you don't consider this being rude, I just needed some distraction from work and for a change wanted to contribute to something useful! :wink:
So I continued your work and provided a PR here: #872

Since #872 has been merged, this can be closed, right?

Closing due to no response, probably fixed by #872.


Links to "The Smartest Contract" podcast go to an unrelated website.

Maybe they let the domain name lapse? In any case these links no longer point to anything related to Ethereum

I want to work on this issue ?


Update title class name

Hyper 1.4.0 was released today and a lot of the class names changed in the UI, including the one that governs the title. This PR updates the class name so the package works as it previously did.

Thanks :)


More CSS3 specifications.

More CSS3 specifications.

This issue was imported from Google Moderator
Moderator votes: +16
Issue added by Binyamin Laukstein on 2011-08-22
To vote this issue up or down, simply include +1 or -1 in your comment.

This seems too vague.

Agreed.


Optional function parameter declared before required parameter

"Optional parameter $prefix declared before required parameter $code is implicitly treated as a required parameter"
In Languages.php:
static function getFileName( $prefix = 'Language', $code, $suffix = '.php' ) {

I'm not sure how to update the files in intuition/language/mw-classes/ should be updated, given that they're copied from MediaWiki. Is it okay to just pull in the new versions? I sort of imagine that doing so might break things!

@samwilson There's a limited amount of automation in /scripts/getLangData.php in this repo. Afaik the classes were just copied by-hand once or twice. I don't recall if they required modification beyond an indicator in the file header and possibly removal of methods we can't/don't use due to dependencies.

Okay cool, I'll have a go at updating them! Or maybe just fix the issue at hand.


Java.Lang.IllegalArgumentException: View=DecorView@842599d[AppleSignInCallbackActivity] not attached to window manager

I am getting this error after completing the Callback Flow and back in the main app. Any idea?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: baaa38ab-77e3-83b2-492c-86e1051862c3
Version Independent ID: 4194e7df-a3fc-fc87-9d7c-c008d1aa6eb2
Content: Sign In with Apple in Xamarin.Forms - Xamarin
Content Source: docs/xamarin-forms/platform/sign-in-with-apple/index.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidortinau
Microsoft Alias: daortin

Hi @microwales
This is normally caused by trying to dismiss a dialog/activity that has already been dismissed, or trying to do so off the UI thread.


Modal: Focus lock is failing with total content repaints

Describe the bug
In the modal the focus is trapped on initial render.
In scenarios where content is dynamic, for example a button changes the content within the modal entireley, the focus become unstable. Tabbing forward will get to the close button and stop. Tabbing backward will escape the modal.
To Reproduce
Steps to reproduce the behavior:

Go to 'this codesandbox.'
Click on  'show modal'
press tab repeatedly and see focus remain within the modal
Click "this is a button"
press tab repeatedly and see focus remain within the modal
observe focus stop at the 'x'
click shift + tab several times and see focus escape.

Expected behavior
focus works as does on the initial render
Desktop (please complete the following information):

OS: mac
Browser chrome

Additional context
https://jam.dev/c/b501b537-fdcb-423d-9bea-a9bdec8d9268

We should add some sort of prop so adopters can alert when the content of a modal has changed, so we can re-call the focus lock.
Another simple example of the focus lock not "refreshing":
export const FocusLock = () => {
  const [showModal, setShowModal] = React.useState(false);
  const [currentStep, setCurrentStep] = React.useState(0);
  const buttonRef = React.useRef();
  const steps = 6;

  function handleOnClose() {
    setShowModal(false);
    setCurrentStep(0);
  }

  function handleNextClick() {
    setCurrentStep(currentStep + 1);
  }
  function handleBackClick() {
    setCurrentStep(currentStep - 1);
  }

  return (
    <>
      <Modal header="Modal Title" onClose={handleOnClose} isOpen={showModal}>
        <Flex
          behavior={FlexBehavior.container}
          justify={FlexJustify.spaceBetween}
        >
          <Flex behavior={FlexBehavior.item}>
            {currentStep !== 0 ? (
              <Button
                size="small"
                color="primary"
                onClick={handleBackClick}
              >
                BACK
              </Button>
            ) : (
              <></>
            )}
          </Flex>
          <Flex behavior={FlexBehavior.item}>
            {currentStep}
          </Flex>
          <Flex behavior={FlexBehavior.item}>
            {currentStep < steps ? (
              <Button
                size="small"
                color="primary"
                onClick={handleNextClick}
              >
                NEXT
              </Button>
            ) : (
              <Button
                size="small"
                color="success"
                onClick={handleOnClose}
              >
                ENDTOUR
              </Button>
            )}
          </Flex>
        </Flex>
      </Modal>
      <Button onClick={() => setShowModal(true)} ref={buttonRef}>
        Show Modal
      </Button>
    </>
  )
}

I confirmed that in this example https://codesandbox.io/p/sandbox/modal-content-changes-3pt32d?file=%2Fexample.tsx%3A7%2C13, the focus behaves as expected
However, in the example provided above where the content is conditional, the focus still does not behave as expected: https://codesandbox.io/p/sandbox/modal-conditional-content-focus-nwnth5

This is behaving as expected-- I was using the wrong RM version in the second CodeSandbox link ✅

From Verification:


Smarter detection for image naturalWidth and naturalHeight

Smarter detection for image naturalWidth and naturalHeight so we don't try to zoom anything when it's already at its maximum dimensions. This would also re-enable the ability to not zoom beyond a source image's natural dimensions once zoomed.
In v3, there was a flag, shouldRespectMaxDimension, but I think that should be the default for image-based children.
Also, just like v3, if it's already the full-width of the page (or container?), don't zoom it.

Will get :eyes: on this this week

FYI I'm almost done completely rewriting this library into:

a vanilla JS package that is ~3kb (minified & gzipped)
a react hook that uses 👆  and is maybe 100-150 bytes

This and all the other issues should be closed out by it. I'm almost there (working out some API stuff).
Thanks for your patience

I'm stuck back on v3 until this lands, is it worth PRing something for v4 or does the ongoing rewrite make it a waste of time? :)

I wouldn't bother with trying anything like that with v4, for the fundamental concept of v4, "zoom anything", was flawed.
v5 is going to pull that back to images.
You can read more about the plight here: https://github.com/rpearce/image-zoom/discussions/274

Ahhh, thanks for the link, I hadn't looked in discussions. One thing that I did like about the idea behind v4 was that it would potentially allow us to put information such as a caption underneath the image, or potentially < >  buttons to navigate a set – just something to think about as you design the v5 API.
Many thanks

@tommoor Nothing is set for v5 apart from some core things that need to happen (fixing pixelation on iOS and accessibility, for example).
I'm not yet saying I will support what you're asking about, but I would love to know what your use case is so that I can identify how that might fit in. For example, I love what the New York Times has done.

Use case is a [https://github.com/outline/rich-markdown-editor](rich text editor) with user-editable captions. The NYT design is great you're right, would certainly be nice to have something with that much panaché

I'll also echo @tommoor, not being able to include non-image things in the zoom would be a dealbreaker for me, and it's the whole reason I used this library over others. My particular use-case is showing a title under the image when it's zoomed, like a more traditional lightbox might. I'm also using the controlled mode to only show the title when it's zoomed. The problem of course is that the zoom also blows the title up with the scale transform, not sure how to solve that one...

@madeleineostoja I'll make sure to bake a caption option in.
Could you further explain what you mean by this?

Could we perhaps get access to the zoom factor when in controlled mode, so we can account for it in anything that shouldn't be scaled up?

I've got this covered in the next major version I'm working on. Update here: https://github.com/rpearce/image-zoom/discussions/274#discussioncomment-1616865

Here's the latest update on the work that will include this! https://github.com/rpearce/react-medium-image-zoom/discussions/274#discussioncomment-2946565

Hi! Here's a screencast of the max dimension being respected in the v5-dev branch:
https://user-images.githubusercontent.com/592876/178144497-df089cd7-1591-455a-8e1c-84f5157c12d0.mp4
Once v5.0 is released (hopefully not too much longer), I'll see about adding in proper captions and maybe do so by looking for a <figcaption> or [data-rmiz-caption] (plan for a v5.1 release)

Your hard work is appreciated 🙏

If anyeone finds some spare time and wants to give the latest build a whirl to try this out:
npm i --save<EMAIL_ADDRESS>
And, if you aren't already,
import Zoom from 'react-medium-image-zoom'
import 'react-medium-image-zoom/dist/styles.css'

// ... your other code

<Zoom>
  <MyImage />
</Zoom>

The updated v5-dev README is here, and there are some breaking changes to the extra options passed to be aware of, if you're using the options.
Thanks for your time!

Should be closed now with the release of 5.0.0

@tommoor @madeleineostoja
Hi! I'm working on adding a feature that includes captioning (adding whatever you want to the zoom state). Do you have any thoughts on this approach? https://github.com/rpearce/react-medium-image-zoom/issues/332#issuecomment-1207252231

Example looks good and would certainly work for our usecase. I would consider just passing an unZoom/onClose button as prop to custom component rather than a rendered button.

@tommoor Good call on that line of thinking! I'll ponder it and see where that goes.


Creates SummaryFooterView and refactors "Summary" packages hierarchy

Adds SummeryFooterView
Refactors package hierarchy to have all the Summary blocks in the same package.

add a margin decorator on the Grapes Samples list fragment in order to have clearer and prettier item list :)
I'm not sure to understand what do you ask here. The SimpleListView already has an item decoration (see here). I'm gonna add a screenshot to this PR so you can see the result.
If this is still not what you mean, let me know :)

add a margin decorator on the Grapes Samples list fragment in order to have clearer and prettier item list :)

I'm not sure to understand what do you ask here. The SimpleListView already has an item decoration (see here). I'm gonna add a screenshot to this PR so you can see the result. If this is still not what you mean, let me know :)

Ok yes perfect, I was testing an outdated example, the issue I was raising is fixed, 👌


Reduce rviz_default_plugins memory usage

Opening issue because I need to ask for help. The ros2 linux packaging job is failing to build rviz_defaullt_plugins with an error that looks a bit like the agent ran out of memory.
07:37:10 [ 22%] Building CXX object CMakeFiles/rviz_default_plugins.dir/src/rviz_default_plugins/displays/map/swatch.cpp.o
07:37:10 [ 23%] Building CXX object CMakeFiles/rviz_default_plugins.dir/src/rviz_default_plugins/displays/marker/markers/arrow_marker.cpp.o
07:37:10 [ 24%] Building CXX object CMakeFiles/rviz_default_plugins.dir/src/rviz_default_plugins/displays/marker/markers/line_list_marker.cpp.o
07:37:10 c++: fatal error: Killed signal terminated program cc1plus
07:37:10 compilation terminated.
07:37:10 make[2]: *** [CMakeFiles/rviz_default_plugins.dir/build.make:63: CMakeFiles/rviz_default_plugins.dir/rviz_default_plugins_autogen/mocs_compilation.cpp.o] Error 1
07:37:10 make[2]: *** Waiting for unfinished jobs....
07:37:10 make[1]: *** [CMakeFiles/Makefile2:79: CMakeFiles/rviz_default_plugins.dir/all] Error 2
07:37:10 make: *** [Makefile:141: all] Error 2

This PR tried compiling separate object libraries and then linking them into the big rviz_default_plugins library would reduce the peak memory usage. It didn't.
Here's a script I wrote to watch the CPU and memory usage. It outputs csv to stdout that can be graphed.
import re
import sys
import time

import psutil

def get_cumulative_usage(regex):
    sum_cpu = 0.0
    sum_mem = 0.0
    for proc in psutil.process_iter(['name', 'cpu_percent', 'memory_percent']):
        try:
            if re.match(regex, proc.info['name']):
                sum_cpu += proc.info['cpu_percent']
                sum_mem += proc.info['memory_percent']
        except (psutil.NoSuchProcess, psutil.AccessDenied, psutil.ZombieProcess):
            pass
    return sum_cpu, sum_mem

if __name__ == '__main__':
    if 2 != len(sys.argv):
        sys.stderr.write(f'Usage: {sys.argv[0]} <regular_expression>\n')
        sys.exit(1)

    regex = re.compile(sys.argv[1])
    start = time.monotonic()
    now = start

    prev_cpu = None
    prev_mem = None

    while True:
        cum_mem, cum_cpu = get_cumulative_usage(regex)
        if cum_mem != prev_mem or cum_cpu != prev_cpu:
            print(f'{now - start}, {cum_mem}, {cum_cpu}')

        prev_mem = cum_mem
        prev_cpu = cum_cpu
        time.sleep(0.1)
        now = time.monotonic()

I used it to watch the cumulative CPU and memory usage of all ld or cc1plus processes on my machine while doing a clean build rviz_default_plugins.
python3 proc_usage.py "ld|cc1plus" > ~/rviz_mem_usage.csv

Here's the memory usage of building just rviz_default_plugins on the ros2 branch. (vertical axis % of system memory used, horizontal axis seconds)

Here's the memory usage using this branch

It does not appear to have reduced the peak.  The only other idea I have is to break up the rviz_default_plugins library into smaller shared libraries.

Another option proposed by @clalancette is to build rviz_default_plugins with -j1. Not sure how to specify that so it happens automatically and only for that package.

Differences in repos used by Packaging 1841 and 1842
https://ci.ros2.org/view/packaging/job/packaging_linux/1841/
  micro-ROS/ros_tracing/ros2_tracing:
    type: git
    url: https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing.git
    version: c3ea84b4b98a99d0a7ba3ed94846e1aaec8a8d13
  ros2/rclcpp:
    type: git
    url: https://github.com/ros2/rclcpp.git
    version: 04f3c33de5f35b6aec38da71777bf39f47e7c7a0
  ros2/rmw:
    type: git
    url: https://github.com/ros2/rmw.git
    version: 2d020b993a983849748ededec95a5a5d45905898
  ros2/system_tests:
    type: git
    url: https://github.com/ros2/system_tests.git
    version: f9dd335393b32ee9985037cd37cd80cb084bf79a

https://ci.ros2.org/view/packaging/job/packaging_linux/1842/
  micro-ROS/ros_tracing/ros2_tracing:
    type: git
    url: https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing.git
    version: 17573951dd5976e365fb93311507752746364d10
  ros2/rclcpp:
    type: git
    url: https://github.com/ros2/rclcpp.git
    version: e0bf4a9c206753cfee067d265c12f47c4eb471fc
  ros2/rmw:
    type: git
    url: https://github.com/ros2/rmw.git
    version: 8ecc9531226d23b3bd24652306887256e26394d6
  ros2/system_tests:
    type: git
    url: https://github.com/ros2/system_tests.git
    version: 2f86e4239cb07c2be5b166fc781bec7a35e727d3

Of that, only rclcpp seems like a likely candidate for having increased the memory usage here

Looking at the changes from those repos I only see one PR that might have increased memory usage.
Candidate PRs

https://github.com/ros2/rclcpp/pull/1095 @brawner FYI

adds header to header that gets included by rviz_default_plugins

Unlikely PRs

https://github.com/ros2/rmw/pull/203
https://github.com/ros2/system_tests/pull/419
https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/165
https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/166
https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/167
https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/168
https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/169
https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing/-/merge_requests/169

This package has to build a ton of object files, so it's running a lot of cc1plus processes in parallel. I've also heard anecdotally (from @nuclearsandwich) that this package hogs a lot of memory when compiling. Are there other processes running on the host that It might be taking up too much memory? The Jenkins java agent might be holding on to a lot of memory.
It looks like the last two failures occurred on the same host. Is there possibly something happening with the host? https://ci.ros2.org/computer/linux-d98d367e/
The PR you linked to (https://github.com/ros2/rclcpp/pull/1095) just adds a header that doesn't depend on any new headers. rcl/types.h, rcl/allocator.h, rclcpp/visibility_control.h are already included in some form. I also don't advocate for removing it since it's a required header for the file it's being added to. It's possible it was the straw that broke the camel's back, but reverting that PR is not going to free up much if any memory.

Did not fix issue. Closing and continuing discussion in #539


Initial default feedback prompt handler

https://github.com/bucketco/bucket-tracking-sdk/assets/331790/a59456ac-1a3e-46a3-8613-8eb185cc918f

Based on a call with @pavkam we're doing another iteration of this to ensure prompt state handling is kept intact and at the same time improve the ergonomics for customers who just want to override UI defaults of the widget UI while handling a prompt

This PR has been integrated into #41


Add a combined downloads for each of the three heat networks

The download of the heat network curves should be combined into one large one for HT, MT and LT. Sorted by network.

As discussed I would propose one large download. The download should have a clear structure though: each temperature level should clearly separated e.g. LT demand and supply, then MT demand and supply and then HT demand and supply.

Done on branch heat-2023, will be merged on completion of full project


fix(expansion-panel): Adjust vertical spacing of expansion panel headers

Completes fix for #6192

I have a feeling that this depends on the header being an exact size, which may not work with @crisbeto's PR to add height inputs; @crisbeto thoughts?

Yeah this won't work with a different height. Perhaps it should be refactored to use position: absolute and a transform for centering, instead of flexbox?

The issue I found with using position: absolute and transform: translate(..) is that we are also using transform to perform the rotation.
I have now instead moved from using ::after to using a span and performing all of the rotation on the icon itself rather than rotating the container of the icon.  I then put a margin-bottom on the container to offset the borders thickness.


[Bug] it just doesn't work as intended

Since change from 2.2.0 to 3.x things stopped worked properly, like

value conversion from JSON ValueKind to simple types
case insensitive field lookups in filter
broken Enum support
broken String filtering (getting message like No applicable method 'Contains' exists in type 'String' (at index 24))
overall failing to compile the expressions if any filter is specified

I've tried to fix it by myself but due to my lack of knowledge for dynamic expression generator I think devs should be notified too.

Please reference the prerequisites section of the readme file that may help you solve your issues, except point 2.

Thank you for quick response!
Number 5 is actually this sadly https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-3.x/breaking-changes#linq-queries-are-no-longer-evaluated-on-the-client
And I got a fix for point 2, if you need:
// Filter.cs, GetLastPropertyType
PropertyInfo property = currentType.GetProperty(propertyName, BindingFlags.IgnoreCase | BindingFlags.Public | BindingFlags.Instance);```

In point 2, I recommend using the attribute [JsonPropertyName("Your Property Name")] to the class's property.  Like below code :point_down:
public class Member
{
    [JsonPropertyName("email")]
    public string Email { get; set; }

    [JsonPropertyName("name")]
    public string Name { get; set; }
}

Number 5 is actually this sadly https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-3.x/breaking-changes#linq-queries-are-no-longer-evaluated-on-the-client

Could you provide a sample expression that you use to occur this issue?

Thanks! Although I don't use JsonPropertyName (and others might do), it would be good to have that information on the repo readme too.

Number 5 is actually this sadly https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-3.x/breaking-changes#linq-queries-are-no-longer-evaluated-on-the-client

Could you provide a sample expression that you use to occur this issue?

It's all fine, resolved. Was my mistake to use non-db functions in Select operator before ToDataSourceResult

It's all fine, resolved. Was my mistake to use non-db functions in Select operator before ToDataSourceResult

Ya, that's the point that I thought, cause I had encountered it before :joy:


add pg_repack to v14-16

This PR adds pg_repack as an available extension for Postgres 14-16.

Extension installed properly in 16


Fix architecture diagram

https://github.com/linkedin/datahub/blob/master/docs/architecture/architecture.md
The architecture diagram misses the connection between ES, N4j & GMS which can lead to confusion.

Updated the architecture diagram to reflect all connections.


[Bug]: Eufy Door Lock not working even after assigning the station manually

Version
1.5.2-1
Node version
?
Operating System type
Linux
Operating system version
Proxmox 7.4-3
Describe the bug
I recently migrated from the old Eufy addon to this one after the last update made it stop working. Everything was working except for my T8520 lock, I found the other bug reports for this issue and set a static IP and added the following code:
stations:

serial_number: T8520Q##########
ip_address: 192.168.1.##
Yet my lock is still not responding to lock/unlock commands, nor is it even showing an accurate state. It is all but dead.
The logs aren't even showing any errors... I'm at a dead end and getting desperate!

To reproduce
It just doesn't work at all
Screenshots & Logfiles
No response
Additional context
No response

@bropat there is no error, so I'm not sure how to get debug logs

Try latest version.


Reduce UDP server memory usage

This pull request reduces the memory usage of the UDP server by using a sync.Pool.
This is the result of the server benchmarks (with #734):
name              old time/op    new time/op    delta
Serve-12            48.7µs ± 3%    50.3µs ± 2%   +3.36%  (p=0.000 n=10+9)
Serve6-12           49.4µs ± 2%    50.8µs ± 3%   +2.80%  (p=0.000 n=10+10)
ServeCompress-12    50.9µs ± 2%    52.9µs ± 3%   +3.87%  (p=0.000 n=10+10)

name              old alloc/op   new alloc/op   delta
Serve-12            3.86kB ± 0%    3.39kB ± 0%  -12.36%  (p=0.000 n=10+10)
Serve6-12           3.70kB ± 0%    3.23kB ± 0%  -12.90%  (p=0.000 n=10+10)
ServeCompress-12    4.12kB ± 0%    3.64kB ± 0%  -11.58%  (p=0.000 n=10+10)

name              old allocs/op  new allocs/op  delta
Serve-12              56.0 ± 0%      56.0 ± 0%     ~     (all equal)
Serve6-12             53.0 ± 0%      53.0 ± 0%     ~     (all equal)
ServeCompress-12      58.0 ± 0%      58.0 ± 0%     ~     (all equal)

The reduced memory usage in those benchmarks would be even more pronounced with a larger UDPSize value.
A more complete benchmark, using dnstrace, is here: https://gist.github.com/tmthrgd/cfcc4b245267cd8d2571eaeeda0f83ad. Those benchmarks are quite interesting: with the minimum UDP message size, there is no meaningful performance change (182972.7 q/s -> 185201.5 q/s). While on the other hand, when using the maximum message size, there is a huge performance increase (74972.8 q/s -> 172692.6 q/s).
This partially address #732.
/cc @larytet @haosdent

Codecov Report

Merging #735 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   55.74%   55.75%   +0.01%
==========================================
  Files          39       39
  Lines       10722    10730       +8
==========================================
+ Hits         5977     5983       +6
- Misses       3665     3667       +2
  Partials     1080     1080

Impacted Files
Coverage Δ

server.go
62.27% <87.5%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a34f54...c327bf6. Read the comment docs.

many thx!

Wow. nice!


[AYS API] Get repository API does not work with all repositories

When using the cockpit exposed end points to list repositories, the API will list all repositories it will find on the system regardless if they are created via the cockpit create repo API or not.
If the client code tries to use the get repo API to retrieve a repo that is not created via the cockpit API, the call will fail
def get_repo(name):
    """
    try to get a repo by his name.
    name is prepend with AYS_REPO_DIR to create the full path to the repo
    raise j.exceptions.NotFound if repo doesn't exists
    """
    path = j.sal.fs.pathClean(j.sal.fs.joinPaths(AYS_REPO_DIR, name))
    res = j.atyourservice._repos.find(path=path)
    if len(res) <= 0:
        raise j.exceptions.NotFound(
            "Repository {} doesn't exists".format(name))
    if len(res) > 1:
        raise j.exceptions.BUG(
            "More then one repository find with this name ({}). this should not happen.".format(name))
    return res[0].objectGet()

This is not consistent, we need either to only show the repos that are created using the cockpit API as a response to the list repos API (not good) or allow the user to get a repo that is not created by the cockpit API.

This is already solved in 8.2.0, with one server serving all interfaces.
I'll put this to be validated on 8.2.0, as an extra check.


So long, Detroit.

Why?
Due to my increased focus on contributing to the codebase and creating new features, maintaining and actively working on my map has no longer become my priority. I quite unfortunately have let it fall a bit to the wayside, and as such the quality of it has suffered. While i did enjoy working on and maintaining Barratry, in recent weeks, it's felt more like a chore than something i really enjoy.
Because of that, i'd like to formally remove the map from the game. The ideas i've had for it have run their course and it's about time someone else had the opportunity to showcase their own creations.
From the very first design, named Shitstation, it's been my pleasure to map for this game. I hope everyone enjoyed Barratry.
Changelog

:cl:

remove: Barratry has been removed.

RIP Barratry, ‘twas my favorite map too

Fixes #8038 and #9429

Fixes #8038 and #9429

lol both of these have been fixed for a while

rest in peace detroit
we hated you

now i definitely wont play the game

o7

that said it should probably just get derotated and not deleted

i need a new favorite map now.......


When calculate cmac with iv value using openssl.

Hi,
Now ,I have a requirement。
That is calculate cmac value with iv.
But I have no idea,and  have methods with mbedtls.
polarssl:
size_t mactlen;
CMAC_CTX *ctx = CMAC_CTX_new();
CMAC_Init(ctx, key, keysize/8, EVP_aes_128_ecb(), NULL);
CMAC_Update(ctx, input, length);
CMAC_Final(ctx, output, &mactlen);

CMAC_CTX_free(ctx);

mbedtls:
mbedtls_cipher_init( &ctx );
if( ( ret = mbedtls_cipher_setup( &ctx, cipher_info ) ) != 0 )
goto exit;
ret = mbedtls_cipher_cmac_starts( &ctx, key, keylen );
//add iv,state
memcpy(ctx.cmac_ctx->state, iv, 16);    // this is important.
Any one have ideas?
Thanks.

Have you read the EVP_MAC man-page?

i have readed it .But i have no idea for replcace iv method

Go back and look at the man page.  Understand it.  The example is for a CMAC/AES-128-CBC which is exactly what you are wanting.
As for your question, I suggest you look at this.
The second from top result is relevant.

Hi,
thanks you for suggest ,And i have compiled openssl 3.0 and tested it .
But it seems wrong.
size_t mactlen = 0;
EVP_MAC *mac = EVP_MAC_fetch(NULL, "CMAC", NULL);
if(mac == NULL)
{
return -1;
}
OSSL_PARAM params[2] = {0};
params[0] = OSSL_PARAM_construct_utf8_string("cipher","aes-128-ecb", 0);
params[1] = OSSL_PARAM_construct_end();

EVP_MAC_CTX *ctx = EVP_MAC_CTX_new(mac);
if(ctx == NULL)
{
    return -1;
}
EVP_MAC_init(ctx, (const unsigned char *)key, keysize/8,params);
EVP_MAC_update(ctx, input,length);
EVP_MAC_final(ctx, output, &mactlen, 4096);
EVP_MAC_CTX_free(ctx);
EVP_MAC_free(mac);

input:
00 00 00 00 00 00 00 00 00 00 00 04 00 00 80 01 bf c3 29 11 c7 18 c3 40 bc a2 84 d8 a9 45 a4 9d
or
00 00 00 00 00 00 00 00 00 00 00 06 00 00 80 01 bf c3 29 11 c7 18 c3 40 bc a2 84 d8 a9 45 a4 9d
others argument is same. but result is same.
04 cf ff 1b 09 74 a5 82 31 b2 d6 60 27 f5 b2 db

Why do you use ECB? It should ignore IV totally. CMAC implies CBC mode

Because it refer to the code implemented with mbedtls .

refered mbedtls code:
cipher_info = mbedtls_cipher_info_from_type( MBEDTLS_CIPHER_AES_128_ECB );
mbedtls_cipher_init( &ctx );
if( ( ret = mbedtls_cipher_setup( &ctx, cipher_info ) ) != 0 )
goto exit;
ret = mbedtls_cipher_cmac_starts( &ctx, key, keylen );
//add iv,state
memcpy(ctx.cmac_ctx->state, iv, 16); // this is important.

Why do you use ECB? It should ignore IV totally. CMAC implies CBC mode

thanks ,i replace ecb  with cbc.now ,it successfully.
But ,now i have another problem.
When set iv parameter with cbc ,the value of  calculate is wrong.
EVP_MAC *mac = EVP_MAC_fetch(NULL, "CMAC", NULL);
OSSL_PARAM params[3] = {0};
params[0] = OSSL_PARAM_construct_utf8_string(OSSL_MAC_PARAM_CIPHER,"aes-128-cbc", 0);
params[1] = OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SEED,iv,16);
params[2] = OSSL_PARAM_construct_end();
EVP_MAC_CTX *ctx = EVP_MAC_CTX_new(mac);
EVP_MAC_init(ctx, key,keysize/8,params);
EVP_MAC_update(ctx, input,length);
EVP_MAC_final(ctx, output, &mactlen, 16);

When set iv parameter with cbc ,the value of calculate is wrong.

What is the key, what is the IV and what is the expected and computed MACed data value?

I have implemented it  in other ways.


dns-operator-aws clean all DNS records

Task
dns-operator-aws needs to clean all leftover DNS records from the managed Route53 hosted zone created by other components (e.g. external-dns).
Background
external-dns creates DNS records which lead to the cluster deletion to be stuck. Manual intervention is required in order to unblock the deletion process.

done


Can i run it 7/24

İts stopping when do the search and thing can i runt it everyday automatically

yea, if ure running linux use cron, if windows, use scheduled tasks


resolvconf: Detect dinit

I talked with @davmac314 and he added the required functionality in https://github.com/davmac314/dinit/commit/bc23b8ee7654b252a71fab5e2b494926f46b8b4b. I can now upstream my local patch.

Even if it’s definitely not required, done.

Even if it’s definitely not required, done.

POSIX states that command may use STDERR for diagnostic messages, so any requirement depends on the command implementation. A quick look through the NetBSD shell source code indicates it can indeed log diagnostics to STDERR using command.

Oh, sorry then ! I tried the two situations: command -v sh, which prints the path, and command -v nonexistant which prints nothing. I thought, wrongly, that this would be the POSIX behavior.


Getting started resoruces?

Hello, im interested in this repo. Can you provide some getting started scene or script where everything is setup for us newbros to just see setup. I need to crate octree that will dynamically update as objects are going through zones. I see this is possible with this but I'm unable to wrap my head around it. Thank you.

Sorry ASoldo, I'm not able to provide any extra support for this repo at the moment.


fix duplicate randomPayload

This change is

Thanks! Missed this one completely. 👏🏻

Thanks! Missed this one completely. 👏🏻

You're welcome, I wrote you a dm on FB


DirectXTK draw transparent text

How can I draw a transparent text?

What have you tried?
See Drawing Text, SpriteBatch, and SpriteFont

Thanks.
Solution: DirectXTK draw transparent text.
Code:
CommonStates states(device);
spriteBatch->Begin(SpriteSortMode_Deferred, states.NonPremultiplied() );

MakeSpriteFont defaults to using premultipled alpha, and so SpriteBatch does as well. if you create your SpriteBatch using NonPremultiplied, then you either need to submit your SpriteFont drawing in a different Begin / End block with out it, or you need to generate your spritefont with /NoPremultiply.


Update site pages with copy-edited and reviewed content

This PR is rather large, but solely focuses on updating content that has been edited by our copy editor contractor and reviewed by M-Lab staff. In some cases a template file or include file was edited to update content drawn in from those sources, such as the footer or grid of tests on the tests page.
This PR can be previewed on my fork and should fulfill the requirements to close issues #162 #163 #129 #130 and #131

This change is

_data/header-footer-content.yml, line 94 [r2] (raw file):
Why do we reference New America here at all? Do we have to? Seems strange.

Comments from Reviewable

_pages/08-about.md, line 10 [r2] (raw file):
I would remove the M-Lab from here, and just leave "Open Internet Measurement"

Comments from Reviewable

_pages/08-about.md, line 17 [r2] (raw file):
This is the only bullet ending in a period. Either end each of them with it, or remove the period at the end of the sentence.

Comments from Reviewable

_includes/grid.html, line 32 [r2] (raw file):
Does this change belong in this PR? Seems like it's not a content change.

Comments from Reviewable

_layouts/page.html, line 14 [r2] (raw file):
similarly, this page is showing as edited, even though it wasn't. Can we discard changes on this file? so that it's not included in the PR?

Comments from Reviewable

_pages/contact.md, line 14 [r2] (raw file):
I don't think the %21 change should be in here. @mtlynch can you double check me here? Both links work, but I'd think we'd want '#!forum' and not using %21 in the link.

Comments from Reviewable

_pages/faq.md, line 64 [r2] (raw file):
This change got reverted, and should be discarded. I think this is a rebase/version issue.

Comments from Reviewable

Left some comments to address, which should be small. PTAL?

Comments from Reviewable

Reviewed 4 of 30 files at r1.
Review status: 4 of 31 files reviewed at latest revision, 11 unresolved discussions.

_pages/bigquery_examples.md, line 38 [r2] (raw file):
Why are we taking out the backticks for code?

_pages/contact.md, line 14 [r2] (raw file):
Yeah, I'd prefer the unencoded exclamation point. I don't think any browsers will choke on it.

_pages/gcs.md, line 91 [r2] (raw file):
The trailing b was correct.
If it makes it seem less accidental, we can do

You can access M-Lab files programmatically by replacing:

storage.cloud.google.com/m/cloudstorage/b/

with

storage.googleapis.com/

_pages/gcs.md, line 111 [r2] (raw file):
This looks like a mistake

_pages/tools/glasnost.md, line 10 [r2] (raw file):
Can we cut the mention of eMule and Gnutella? I don't think anyone has used those in like 10 years.

Comments from Reviewable

_data/header-footer-content.yml, line 94 [r2] (raw file):
This is just what was on the old site. New America reference could be removed.

Comments from Reviewable

_data/header-footer-content.yml, line 94 [r2] (raw file):
I'll remove this in my next commit.

Comments from Reviewable

_includes/grid.html, line 32 [r2] (raw file):
This change is for the /tests/ page, moving the descriptions of test categories from the top of the page to below the heading for that category. The content for the grid of tests on the tests page is in the YAML front matter and grid.html puts the page together on build. I added an additional value to the YAML called group-description, and this template pulls that in when it creates the page.

Comments from Reviewable

_pages/bigquery_examples.md, line 38 [r2] (raw file):
I didn't catch those. Our copy editor went a bit overboard on this page and removed them, so I had to add them back in. I missed these. Will add back in my next commit.

Comments from Reviewable

It seems that there are a number of style conventions we've begun to follow, regarding capitalization of headers, "data sets" instead of "datasets". Can we add a section to the readme.md or maybe a file called style_guide.md that documents these patterns? Maybe we can even add automated tests to enforce these style choices. It seems doable to make a check that flags instances of the word "dataset" if someone accidentally introduces it in the future.

Reviewed 13 of 30 files at r1, 1 of 3 files at r2, 6 of 8 files at r3.
Review status: 21 of 30 files reviewed at latest revision, 13 unresolved discussions.

_pages/02-visualizations.md, line 3 [r3] (raw file):
Suggest cutting the visualizations page (and all subpages) entirely at this point. Or at least taking it out of main navigation. Everything is so out of date and we keep burning cycles dragging it forward.

_pages/03-tests.md, line 81 [r3] (raw file):
Did the -- (in "run them--") come from the copy editor? That seems unusual style and I don't see it anywhere else on the page.

_pages/05-contribute.md, line 34 [r3] (raw file):
Why aren't the headings on this page capitalized like the others? Is it a matter of header level?

_pages/state.md, line 79 [r3] (raw file):
If we're capitalizing headings, shouldn't "Tests" be capitalized?

_pages/tools/neubot.md, line 10 [r3] (raw file):
Looks like we're missing the trailing double quote on "bittorrent

Comments from Reviewable

_pages/02-visualizations.md, line 3 [r3] (raw file):
Let's add an issue to address this page at the moment, but I'd prefer to not remove the page.

Comments from Reviewable

_pages/03-tests.md, line 81 [r3] (raw file):
True -- @critzo can you check this?

Comments from Reviewable

_pages/05-contribute.md, line 34 [r3] (raw file):
@critzo did you check these?

Comments from Reviewable

_pages/contact.md, line 14 [r2] (raw file):
@critzo it needs the '#!forum' -- the link is broken at the moment.

Comments from Reviewable

_pages/state.md, line 79 [r3] (raw file):
@critzo another quick one

Comments from Reviewable

_pages/tools/neubot.md, line 10 [r3] (raw file):
@critzo another quick edit.

Comments from Reviewable

_layouts/page.html, line 14 [r2] (raw file):
This is still showing some weird edits. Were you able to discard the changes here?

Comments from Reviewable

_data/header-footer-content.yml, line 94 [r2] (raw file):
Done.

Comments from Reviewable

_data/header-footer-content.yml, line 94 [r2] (raw file):
Done.

Comments from Reviewable

_pages/03-tests.md, line 81 [r3] (raw file):
@georgiamoon @mtlynch I reviewed the Google doc revision history and it looks like this was mistakenly added during our review after the copy editor's pass. Suggested revision:
This means that tests only run when people decide to run them. They do not passively monitor your connection.

Comments from Reviewable

_pages/05-contribute.md, line 34 [r3] (raw file):
@georgiamoon I will check them again. To @mtlynch 's comments elsewhere about style guide, our copy editor provided a mix of capitalizing words in headings and not. What is our preference for capitalization in headings? Based on your reply I will review all the pages again for consistency.

Comments from Reviewable

_pages/02-visualizations.md, line 3 [r3] (raw file):
Logged as an issue in https://github.com/m-lab/m-lab.github.io/issues/189

Comments from Reviewable

_pages/08-about.md, line 10 [r2] (raw file):
Done.

Comments from Reviewable

_pages/08-about.md, line 17 [r2] (raw file):
Done.

Comments from Reviewable

_pages/bigquery_examples.md, line 38 [r2] (raw file):
Done.

Comments from Reviewable

_pages/contact.md, line 14 [r2] (raw file):
Done.

Comments from Reviewable

_pages/faq.md, line 64 [r2] (raw file):
Done.

Comments from Reviewable

_pages/gcs.md, line 111 [r2] (raw file):
Done.

Comments from Reviewable

_pages/state.md, line 79 [r3] (raw file):
@georgiamoon @mtlynch looks like our preference is for capitalizing. I'll review all pages for this and capitalizing words in headings.

Comments from Reviewable

_pages/tools/neubot.md, line 10 [r3] (raw file):
Done.

Comments from Reviewable

_layouts/page.html, line 14 [r2] (raw file):
Done.

Comments from Reviewable

_pages/03-tests.md, line 81 [r3] (raw file):
Done.

Comments from Reviewable

_pages/05-contribute.md, line 34 [r3] (raw file):
Done.

Comments from Reviewable

_pages/state.md, line 79 [r3] (raw file):
Done.

Comments from Reviewable

Comments from Reviewable

Reviewed 18 of 30 files at r1, 1 of 3 files at r2, 6 of 8 files at r3, 12 of 12 files at r4.
Review status: all files reviewed at latest revision, 9 unresolved discussions.

Comments from Reviewable


Using GlueSQL with Axum

I'm trying to find a way to execute sql queries on SharedMemoryStorage inside axum handlers, but .execute_async future isn't Send, I suppose due to [async_trait(?Send)] but it's required by handler bounds, so it doesn't compile. At the same time, regular sync .execute function panics with cannot execute 'LocalPool' executor from within another executor: EnterError, which I suppose can be worked around using using tokio's block_in_place but might significantly hurt the performance. Any suggestions on how can I get around these problems? I really like the ideas behind GlueSQL but I'm having hard time figuring out how it is supposed to be used in multithreaded concurrent applications

That's right. Since we are using #[async_trait(?Send)], we are asking for Pin<Box<dyn Future<..> + "Send">> and not doing it.
I think we decided on this interface to support WebStorage in the past.

Storage in web_sys does not implement Send

I've tried a few things to work around this, but the current solution I can think of is to distinguish between traits that return Future, which always require Send, and traits that do not.

@ever0de do I understand correctly that there is no pretty solution to this right now, but it's something that should be addressed in the future?

@edezhic
I'm one of the people who thinks this needs to be fixed. I'm thinking of solving it by separating traits, as I wrote above.
Example.
#[cfg(feature = "send")]
store_trait!(async_trait)
#[cfg(not(feature = "send")))]
store_trait!(async_trait(?Send))

// macro expand...
// #[async_trait]
// trait Store {}

// #[async_trait(?Send)]
// trait Store {}

If I come up with a better way to do it, I'll probably do something else. Any other ideas?

@ever0de  Tbh no idea right now, but I want to point out that I'm considering using axum with webstorage as well (inside a service worker, you can find an example of such usage here - https://github.com/edezhic/pwrsapp). Basically running instances of GlueSQL on both server and client but with different storages. I wonder how that might work

Yes, the server and client would have to use different storage.
WebStorage, like Axum, requires a Send condition in the handler, so you can't use it for the following reasons.

The WebStorage we support is being used through web_sys, so it fulfills the !Send condition.

I'll try to implement the above comment first, so why don't you use a storage that implements Send on the server?

@ever0de I won't use webstorage on the server for sure, most likely it would be sharedmemory or maybe even paired with sled. But I wonder whether it would be possible to use Axum+Glue at all. In theory it would be a single-threaded environment so Send should be safe to implement, but I'm probably missing smth. These things don't look conceptually incompatible, but type signatures are definitely problematic here

Just to add a bit of context, I think if these problems will be resolved it would open amazing capabilities for fullstack rust apps which might reuse client/server code, eg it would be relatively trivial to implement data synchronization like in meteor.js framework and others. With a service worker such app will also be able to support mobile platforms in almost-native cross-platform fashion. I think the potential of such a stack is even greater than Flutter and alike since it would be based on open web standards

Migrate to the issue #1265


Support ADO.NET cluster configuration in the Client

With version 8.0.0 having its own mechanism for connecting to the Kernel, we haven't implemented ADO.NET support for looking up the silos.

Orleans cluster config is going away in v10


Shim+awkward

This tests #23 and #32 in unison, awkward tests are expected to pass. If successful, DO NOT MERGE, instead merge #23 to master first and then rebase #32 onto master.

So, judging from the fact that the error is the same with and without shim, this PR will probably be alright.

#23 was merged

This was transient and is no longer needed.


[Feature]: Apply for Use of Dongtai logo in GitLab

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description
During the process of contributing Dongtai project to GitLab's template projects, we want to confirm the usage of Dongtai logo in GitLab product as addressed in Use of third-party trademark in GitLab.
Here are our questions:

Do you have any legal license information of Dongtai logo? or any link for the source of this logo?
Do you agree that GitLab can use Dongtai logo in the product?

Proposed Solution
Hope you answer our questions and agree our usage.
Alternatives Considered
No response
Additional Information
No response

Thanks. Yes, we definitely agree to contribute our project to GitLab as templates, and GitLab can use our logo.
For the legal license of logo, you can find that the logo is under patent application here. Sorry that the website is in Chinese, but it is a credible institution web to search China’s company info.
Also, you can find the logo is on our official website


SAKIII-4993 safeOutput group title in entity widget and in the mylibrary widget

https://jira.sakaiproject.org/browse/SAKIII-4993

Closing. New pull request at https://github.com/sakaiproject/3akai-ux/pull/1692 targeting 1.2.0


Return Message With Status

This is message not showing in postman
AuthenticateResult.Fail("Invalid Authorization Header");

Same with Swagger.
The only message that is returned is Error: Unauthorizes.

Same with Swagger.
The only message that is returned is Error: Unauthorizes.

Ahha, it's because the current implementation does not support this kind of response.
I just wonder is there possibility to return custom response?


I see only top and bottom toolbar and white screen

After turning on CarStream in car, i see only the top and bottom toolbar, the remaining screen is white. no Buttons in the toolbar not work.  Is there any solution to this problem?

Try to uninstall and reinstall AA (2.9 Versione , 3.0 is not compatible) and CarStream


Create: 0665-non-decreasing-array.java

File(s) Modified: 0665-non-decreasing-array.java
Language(s) Used: java...
Submission URL: _https://leetcode.com/problems/non-decreasing-array/submissions/867311207/_

Thanks, @tanerijun!


Fortran no longer working

This
http://gcc.godbolt.org/#{"version"%3A3%2C"filterAsm"%3A{"labels"%3Atrue%2C"directives"%3Atrue%2C"commentOnly"%3Atrue%2C"intel"%3Atrue}%2C"compilers"%3A[{"sourcez"%3A"ATBOFMEMBNgKgDTAEoHUBQI3ALwnwJxEB0AHACwBMArAecANTABsxA7AQMwHWUCiAWkpwAKsAHACxAAw9KBaYM6i4cSkwCMM6Rualqg8iridxwLRsrTppToObH6TVtU7NOnfgILHqmYAAOoACWAHYALvBIaP7godBAA%3D"%2C"compiler"%3A"%2Fopt%2Fgcc-4.9.0%2Fbin%2Fg%2B%2B"%2C"options"%3A"-x f95 -O3 -march%3Dnative"}]}
used to correctly compile Fortran code. Why is none of the GCC compiled with Fortran support now? It should be extremely easy to compile it as well.

Thanks: I had honestly never known fortran would "just work" - I certainly never intended for it to do so!
All the GCCs are built with a script that only enables C and C++.  I can rebuild all the GCCs (at some expense of time), with fortran enabled. I guess a separate "fortran.godbolt.org" could be made too, which then uses the flags to build fortran, limits the compilers to those supporting it, and also then uses Fortran syntax highlighting.
Thanks for reporting!

It would awesome to have fortran.godbolt.org and use it to compare assembly from Fortran with the assembly from C/C++. Would help to dispell (or confirm!) lots of myths.

Well, this seems to work again. The rest of this issue seems like a duplicate of #549

Hi, Fortran is now added as a separate language thanks to @dbroemmel 's efforts! let us know if you have any trouble with it


git hub widget not showing data.. git hub collector runs fine inserted data in mongo db

Hi,
I am able to run git hub collector properly and data is inserted in mongo db..
but I can not see commit details in github widget.. its not reflecting.

Can you paste any bowser console log?

Thanks @tabladrum for your response.
you need browser log ?
I am not sure of this

application.properties file contain git hub related details..

the same details used for loading data from github to mongo db and showing data from mongo db to dashboard ?

@rabarisanjay Use latest codebase. Reopen if still an issue.


properly set int64 format for long in discovery

We accidentally convert long types to strings in discovery without the
int64 format. This change fixes that.

Current coverage is 79.29% (diff: 100%)

Merging #39 into master will not change coverage

@@             master        #39   diff @@
==========================================
  Files           159        159
  Lines          5631       5631
  Methods           0          0
  Messages          0          0
  Branches        949        949
==========================================
  Hits           4465       4465
  Misses          884        884
  Partials        282        282

Powered by Codecov. Last update acafdf4...c5f5fde