Fix big number pad re-renders

Details
Big number pad was not memoized and was re-rendered on any click of the button, which cause issue - when keyboard hangs and nothing typed or typed in the wrong place
Fixed Issues
$ https://github.com/Expensify/App/issues/15630
$ https://github.com/Expensify/App/issues/15630#issuecomment-1456426604
Tests

Open the app
Go the the send money screen
Type numbers

[ ] Verify that no errors appear in the JS console

Offline tests
This feature doesn't change or is impacted by offline mode.
QA Steps
Same as above.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/28352309/223460650-e8a3e94f-2c54-4827-ab1c-96ac4b907fcb.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/28352309/223460762-890894b7-935c-42d5-9eee-a18b6227e19b.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/28352309/223460800-bf6790e5-1d0a-4a5b-bb3c-cd90717923d0.mov

Desktop
https://user-images.githubusercontent.com/28352309/223460831-25a5e250-ed83-43cf-9ba3-504fb977839b.mov

iOS
https://user-images.githubusercontent.com/28352309/223460854-9f5c63b7-ffb2-4203-919a-f5caacdb87ae.mov

Android
https://user-images.githubusercontent.com/28352309/223460885-5591a967-5fac-4f4b-ad6b-300794a46ad9.mov

@mountiny @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

I will also be testing this in an hour or so

Thanks @mananjadhav

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/3069065/223927763-0934c598-ffd7-4993-b625-af9a0c6ad916.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/3069065/223927782-1eacfb11-1a57-4465-90d7-7c6b983b7ef0.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/3069065/223927805-363427ce-f30f-425b-9906-73621de0e0fa.mov

Desktop
https://user-images.githubusercontent.com/3069065/223927832-44d489ce-d59d-4ba1-a30b-278e75c8f1aa.mov

iOS
https://user-images.githubusercontent.com/3069065/223927864-cbcbf3a9-f555-4d2f-b6ba-d72e615483f9.mov

Android
https://user-images.githubusercontent.com/3069065/223927891-d62402f7-f4c3-4330-a8f9-e0330e0a602e.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.82-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.2.82-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I think this has caused a regression, you can't move cursor on the amount page
https://user-images.githubusercontent.com/9059945/226601129-09c81b77-0f3c-47fc-84c9-2ba318b32b3a.mp4
At first glance it looks like this change is a fault, we should invert the state

This might be the fix (but I haven't tested it heavily)
updateLongPressHandlerState(value) {
    this.setState({shouldUpdateSelection: !value});
}

Thanks @eVoloshchak raised this in Slack with @narefyev91

Unable to Remove Request/Send Money Instantly by Holding the Remove Button
his issue was caused by a series of changes of IOU Money Keypad files.
https://github.com/Expensify/App/pull/15710
https://github.com/Expensify/App/pull/16394
https://github.com/Expensify/App/pull/16673


XPUBS param no longer accepts "rescan" option in BWT 0.2.0

Adding XPUBs and rescanning the Bitcoin blockchain is the one big drawback of lightweight Electrum middleware like BWT and EPS. This should be as easy as possible for the user, or even 3rd-party software to add XPUBs automatically.
The bwt.env config file seems like a good place to manage the keys that are monitored. I was happy to see that the following works in BWT 0.1.5:

adding multiple XPUBS= lines, not needing to concatenate the very long xpub strings into one, which would be a maintenance nightmare
adding the rescan arguemnt to the xpub, like on the command line: XPUBS='zpub12345....XYZ:2020-10-01'

While the first point still seems to work with BWT 0.2-RC1, the second usage gives now an error:
error: Invalid value for '--xpub <xpubs>...': invalid base58 character 0x3a

I think the option to easily add a new XPUB and specify the "rescan since" option just for that XPUB is very important. Adding it directly to the xpub string seems the easiest way to manage the keys.
Is this an unintended change? Or, if now, would it be feasible to make that work again?

Seems like I was mistaken. BWT accepts multiple XPUBS lines in the config without error, but seems to scan only the first one.
I'd love to see the option to have one xpub per line, with the rescan date, in the bwt.env config file:

much easier to add new xpubs over time with copy/paste
better to maintain and keep an overview
more feasible for 3rd-party-apps to add keys automatically

Seems like I was mistaken. BWT accepts multiple XPUBS lines in the config without error, but seems to scan only the first one.

That is correct. The config file uses the dotenv format, which is a simple flat list of key-value environment variables that can't conveniently represent options with multiple values.
I can definitely see how this is not ideal though... the reason I implemented it like that was the the cli arguments parser library I'm using (structopt) does not support any form of config files, but does support configuration via environment variables, so it was easiest to inject the options via that.
I could quite easily support JSON config files (or YAML, at the cost of introducing another dependency) that are used in place of the structopt cli options, such that you'll have to configure everything in the JSON file. Do you think this would be useful?
Supporting using both a config file and cli options together would either require replacing structopt or getting a config file PR merged to it (or adding a bunch of hairy code to bwt that uses structopt in a way it was not intended to -- at which point its probably better to just replace it).

adding the rescan arguemnt to the xpub, like on the command line: XPUBS='zpub12345....XYZ:2020-10-01'

This is something that was changed recently, because Bitcoin Core only really cares about the earliest timestamp within the importmulti batch, and to simplify the CLI/FFI interfaces. But I'm open to changing that back, is there a reason that you think I should now that you know the rational behind it?
Also note that you really only have to specify --rescan-since when adding new xpubs. When starting up with xpubs that are all already imported, it won't issue any rescans so the rescan timestamp doesn't matter.

Looking at the documentation of the library I'm using to load the dotenv file, it looks like its possible to do something like this:
XPUBS=xpub1234
XPUBS=$XPUBS;ypub5678
XPUBS=$XPUBS;zpub9999

(Note that the separator was changed from , to ;. This is because of the newly added support for descriptors, which can contain ,s in them. I added a mention of this to the CHANGELOG.)

Another possible hack is to create a file with a list of cli arguments. This might be nicer because it also supports short options and doesn't SCREAM AT YOU. For example:
-n regtest
--xpub xpub1234
-x ypub5678
--descriptor wpkh(xpub4321/0/*)
-d wpkh(zpub9999/0/*) -d wpkh(zpub9999/1/*)

Then start with bwt `cat /path/to/args` . This could also be combined with additional options, i.e. bwt `cat /path/to/args` --poll-interval 2 ...

Maybe I need to take a step back and quickly explain why I think BWT is an awesome small program from a regular user's perspective:

Running a dedicated node (e.g. on a Raspberry Pi) is not for everyone
The option to just have Bitcoin Core on your machine and connect any wallet that supports that to it using BWT is really helpful to gain privacy with hardware wallets
BWT is great in that regard because it's a simple binary almost everyone can run (as opposed to EPS that needs a Python runtime environment)
As a regular user, I'd like to have an installer, a config directory with a simple file to edit and a start menu entry and as little exposure to the command line as possible (but that's of course about five steps ahead... :grin:)

In regard of the configuration file, both options work already really well:

using XPUBS is a bit screamy, but simple enough. If it's just the bwt.env file (maybe call it bwt.conf or something more self-explanatory?) that I need to edit, and I can add XPUBs over time, that would simplyfy xpub key management already a lot.

the file with CLI arguments works equally well, although the format is a bit uncommon for config files. The one thing I think should be avoided is the need to call it with other cli arguments like cat and the like. That's not very noob-friendly. Maybe there could be an option like --config /path/to/bwt.conf?

The reason why I would like to see the "rescan since" option directly with the xpub is that it's fire and forget. If you add a new wallet, you add one line. BWT could safely ignore it after that (even if it maybe implies that changing the rescan date on an existing xpub would trigger a rescan).  Having the RESCAN_SINCE argument is a bit strange, because it's not really a configuration parameter, but more a one-time command. And that would also trigger a rescan only for newly added xpubs, IIUC.
If I could take all your options from above and define the config file format I personally would like the best, it would probably be this:

~/bwt.conf
XPUBS=xpub1234
XPUBS=xpub5678:2020-11-01
XPUBS=ypub4444:2020-10-01;zpub5555:2020-10-01

or ./bwt --config ~/bwt.conf
--xpub xpub1234
--xpub xpub5678:2020-11-01
--xpub ypub4444:2020-10-01;zpub5555:2020-10-01

IIUC, the first suggestion wouldn't work, but needs XPUBS=$XPUBS;... which again is more shell-script than config file. In that case, I'd probably opt for the section option.
Thanks for being open to my suggestions. I know they are not really coming from the current possibilities, but maybe it helps to get an outside user's perspective.
BWT is a great tool already in any case, and thanks so much for that!


macOS (OSX) share extension possible?

Is it possible to run this on macOS as well? I haven't found any node share extensions yet for macOS.

@mweichert I don't think so. This is tightly couple to ios and android platform.  You are more than welcome to fork the project and make it work for macOS.
I'm still doesn't know what you are trying to do.
closing this as this is not related to this project. But you are welcome to continue the discussion here.


nixd: 1.2.0 -> 1.2.1

Diff: https://github.com/nix-community/nixd/compare/1.2.0...1.2.1
Changelog: https://github.com/nix-community/nixd/releases/tag/1.2.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

We have fixed darwin builds for apple silicon, maybe also cherry-pick that here?
https://github.com/nix-community/nixd/pull/238

maybe also cherry-pick that here?

I think nixd 1.2.1 already includes that fix https://github.com/nix-community/nixd/commit/c4f71ee237124c41313e9c13a1b2c033ed26f70c

maybe also cherry-pick that here?

I think nixd 1.2.1 already includes that fix nix-community/nixd@c4f71ee

Yes, but only for meson.build files, the packaging script here (nixpkgs) is not updated.
https://github.com/nix-community/nixd/blob/2be338120c103794d5e62c50b55a0b86f12a1578/default.nix#L48

See https://github.com/NixOS/nixpkgs/pull/247344/checks?check_run_id=15647659390

packaging script here (nixpkgs) is not updated.

Oh, I see. Updated, thanks!


[ENTESB-20837] Remove references to org.slfj4:slf4j-log4j12

Fixes: #

ubuntu-latest/java11 failed with:
Error:  NullPointerException
Error:
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error: Process completed with exit code 1.

no idea...

anyway, I think it can be merged. What should I do?

Hmm NPE when generating javadoc, strange... I'll take a look

thanks @igarashitm !


Cap harvested rewards

Upgrade the Harvest contract to allow the rewards that are to be sold to be capped.
For example, cap the amount of USDT that is purchased from selling CRV or CVX rewards.

Closing as this feature already exists. The cap is on the token being sold, eg CRV.
It is set with the _liquidationLimit param on the setRewardTokenConfig function on the Harvester.
https://etherscan.io/address/0x0D017aFA83EAce9F10A8EC5B6E13941664A6785C#writeProxyContract


let some rules not cause an error exit code

ruff has many rules and i would like to let most of the rules be checked.
we have a repository wide configuration and a pre-commit hook.
As the code base is grown over the years we have many style violation for specific rules (e.g. RET50{5,6,7,8} or SIM, which are currently also not autofixable) and we don't have them time to do it manually currently.
but the rules would make sense for our code base.
So I would like to have them visible for the developers, so that they see that there is an issue (which they might fix then as well) but ruff should not exit with an exit code =! 0 for them, as this would e.g. block the pre-commit hook.
→ A new config option could provide a list of rules which still get reported but don't cause an error.

I like this idea. This is essentially requesting to treat certain rules as a warning rather than an error, right?
A few thoughts then:

What should the configuration option be? Maybe warn-only = ["…", …]?
The summary should show Found … errors and … warnings.
Colored output should have codes highlighted in yellow for warnings
What about --format=grouped output? Would be nice for errors to be grouped together, then warnings...

But then maybe we want --format=grouped,severity?

👍 We plan to support severity levels for rules (see also #1256), which should solve this.
Once that's done, you should be able to mark rules as warnings or errors (presumedly everything will be an error by default, but TBD). And then you should be able to use "warning" and "error" to select rules (e.g., ruff --select warnings, API TBD). And they'd show up similarly to how @ngnpope has described in the CLI output.

Just gonna close as a duplicate of #1256.


Add validation around null tag strings and drop the measurements with a

warning when such tags are present.
Update the reporter docs.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

In general, what is the reasoning why tag values of null are not allowed. I understand why tag keys as null should not be allowed, but not so sure about tag values not null. I would argue it is better for metrics library API to allow such string arrays with null tag values, as it allows easy and fast generation of such tag arrays without conditional building.

Even if you would filter out the tag arrays with tag value as NULL, you should report the metric with all the other tags, not just drop the full measurement on the ground. I don’t understand this PR.

or convert null to ”null” in reporters that don’t understand nulls.

The impetus for this was that when I was testing some code I found the reporter was throwing these NPEs and I didn't know what was going on. Most time series stores do not allow null tag values. Some do allow for a stand-alone label but that is a separate data set than a key/value tags set. I had an array value that wasn't set on accident so now I'll be able to figure out where that's coming from and fix it.
Dropping the tag key isn't a good option as we don't know the user's intent. Maybe they intended to have a value there or they wanted to write "null" on purpose.
For our in-house stuff where we started seeing missing values and users were curious, we did decide to substitute a string for missing values depending on the library. We can put in "null" here if you want or make it an option in the reporter builder.

I would personally convert it in the reporter to string value ”null” or similar to keep the interface clean and fast on reporting metrics. I.e. I would not have to in my filter or code that sends the metrics filter out variables that are null from string array and can just do
 metric.inc([ TAG_KEY1, tagValue1, TAG_KEY2, tagValue2 ]);

Instead of using dozens of lines of code to grow array, re-allocate objects in case the tagValue1 or tagValue2 or both are null.

Updated @mmannerm


COSMO tag missing

The cosmo tag information is missing when installing with spack.
Seems to only be an issue when using "spack install" , version is correctly set when using "spack devbuild"

@elsagermann I may need you help here

this happen when spack use a cached tar ball which is then not a git repo (typically when re-building)


librewolf: drop upstreamed patch

This partially reverts commit 61598203a41345042d1ed0d68fbe3466be83c6be.
After update to 107 the patch is already in the src.
Things done

Built on platform(s)

[ ] no rebuild x86_64-linux
[ ] aarch64-linux

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Related to: #197849 and #201358


feat: support option allow env to load config from env

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 17 (76.47%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+15.1%) to 27.273%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

config.go
8
12
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
15.1%

Covered Lines:
33

Relevant Lines:
121

💛  - Coveralls


may i know what this project is about??

it seems intresting//   may i know what this project is about??

Yeah it was basically aiming to be a parody game of Instagram. So it had some basic Instagram features like ability to post photos and then other users could see your post in their feed. And there is a Tinder-like system for rating images which gave points to you if people liked your photo. The parody part was going to lean into the concept of people wanting to be influencers and giving up their entire physical lives to live this fantasy social media life.

wow! is all that real posting, or the posting is all a game??
On Sun, Nov 20, 2022 at 7:22 PM Keith Thomas @.***>
wrote:

Yeah it was basically aiming to be a parody game of Instagram. So it had
some basic Instagram features like ability to post photos and then other
users could see your post in their feed. And there is a Tinder-like system
for rating images which gave points to you if people liked your photo. The
parody part was going to lean into the concept of people wanting to be
influencers and giving up their entire physical lives to live this fantasy
social media life.
—
Reply to this email directly, view it on GitHub
https://github.com/kryzodoze/Delaygram/issues/1#issuecomment-1321220249,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANO5MDSXDPI6TCNZXJXQBE3WJJ267ANCNFSM6AAAAAAR7Z4VLU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Real posting. Servers aren't up anymore, but you can see the entire server in the 'server' folder. Used Mongo DB as storage, and just provided a simple API for getting/posting "social media posts".

sir, im a student and dont know server mongo DB...  can you help me setup
the app if i give you 10$ from my savings??
I know its not much, but i really want to learn during this vacation
On Mon, Nov 21, 2022 at 12:28 AM Keith Thomas @.***>
wrote:

Real posting. Servers aren't up anymore, but you can see the entire server
in the 'server' folder. Used Mongo DB as storage, and just provided a
simple API for getting/posting "social media posts".
—
Reply to this email directly, view it on GitHub
https://github.com/kryzodoze/Delaygram/issues/1#issuecomment-1321292665,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANO5MDTPYSCUQ3IY2G7BSFTWJK62FANCNFSM6AAAAAAR7Z4VLU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sorry can't help you there! It's been a few years since I've set this up so I would have to google it myself. If it helps, I just used the free service at https://www.mongodb.com/atlas/database and followed some guide and it was pretty straight-forward.


Adding PF Rule Number to UI Firewall Rules tables for external log analysis/correlation

Problem:
Today exporting firewall logs with OPNsense and anything pf in general produces as one of the export fields as "rulenum" or "rule-number" to identify what actual rule took action to generate the log.  Attempting to cross-reference what the rule was and why an action was took, there was no UI way to correlate that syslog rulenum field to an actual configured rule.
Context:
Today for any investigation from log events (pass, block) externally through a central syslog collector or siem to determine which Rule generated said event requires ssh access via an admin/root shell to see the rule numbers using "pfctl -s rules -vv" and finding the rule within those what was actually configured.
As a SOC or Network Analyst doing routine firewall log analysis, that's far from ideal as most never log into the shell as admin or root user, which then generates a ticket to the firewall guy to find out, and he'd even be hard pressed unless they know freebsd and pf reasonably well to even search for a solution as it did me.
Within OPNsense UI, your filter log view enriches this with the description as "Label" there making easier to find in Rules per issue #2034, but external log systems are not privy to the firewall rules directly, and only receive an ambiguous rule number to match against the firewall to investigate with.  This rule number not found in the main UI anywhere hampers this.
As the only method of correlation from the log event to a given Rule, the rule numbers should be visible even optionally to display in the UI as part of the Rules list per interface.
Feature Request:
The most basic solution and a quick win would be to expose the rule number pf uses to index the rules, and display these in OPNsense Firewall Rules list along side the existing protocol, source, port, etc columns. This would allow at least any user to see the configured rule by number that performed the action from the log/siem perspective in the basic UI without needing shell access.
Alternatives Considered:
Ideally pf could log something more descriptive of the rule vs. just a number would be helpful, such as including the description string would help correlate at a log level externally, but doesn't seem an option with pflogd after having looking at the man pages.  This could be to avoid string parsing or length issue, or not ideal anyways, but not done today or likely to be added there if not already
There also should be always made available that pf-based rulenum index value to Rules correlation for potential upstream enterprise log systems (splunk, wazuh, etc) or even humans to enrich their data directly, exposing them both UI and API means in this respect for association.
Thank you for the consideration!

Reformatting, closing.


WP-CLI & MAMP 3

I just upgraded to MAMP v3 and I'm unable to get WP-CLI working. I'm getting this error
Warning: mysql_connect(): No such file or directory in .../web/wp/wp-includes/wp-db.php on line 1372

Took a look at the file and couldn't figure out what went wrong. Thanks again for helping!

I found that you can fix this issue by defining unix socket on .env file.
DB_HOST='localhost:/Applications/MAMP/tmp/mysql/mysql.sock'


substrate-contracts-node does not produce blocks

When running substrate-contracts-node --dev no block is produced.
Only log line produced is:
2022-04-22 11:26:45 💻 Operating system: macos
2022-04-22 11:26:45 💻 CPU architecture: aarch64
2022-04-22 11:26:45 📦 Highest known block at #0
2022-04-22 11:26:45 〽 Prometheus exporter started at <IP_ADDRESS>:9615
2022-04-22 11:26:45 Listening for new connections on <IP_ADDRESS>:9944.
2022-04-22 11:26:46 Accepted a new tcp connection from <IP_ADDRESS>:59063.
2022-04-22 11:26:50 💤 Idle (0 peers), best: #0 (0x02ba…032a), finalized #0 (0x02ba…032a), ⬇ 0 ⬆ 0
2022-04-22 11:26:55 💤 Idle (0 peers), best: #0 (0x02ba…032a), finalized #0 (0x02ba…032a), ⬇ 0 ⬆ 0
2022-04-22 11:27:00 💤 Idle (0 peers), best: #0 (0x02ba…032a), finalized #0 (0x02ba…032a), ⬇ 0 ⬆ 0
2022-04-22 11:27:05 💤 Idle (0 peers), best: #0 (0x02ba…032a), finalized #0 (0x02ba…032a), ⬇ 0 ⬆ 0
2022-04-22 11:27:10 💤 Idle (0 peers), best: #0 (0x02ba…032a), finalized #0 (0x02ba…032a), ⬇ 0 ⬆ 0
Am I missing something?

@ceikit We switched to a consensus mechanism "menual seal" a while ago (in https://github.com/paritytech/substrate-contracts-node/pull/42). This was done so that there is no block time, but instead transactions are processed alsmost instantly. This is very handy for development and testing, but unsuitable for production.
It should still be possible to deploy and interact with contracts as normal, just faster. Did you run into any problems?

@cmichi thank you! my problem is that https://paritytech.github.io/contracts-ui/ shows Connection Error and cannot connect to Local Node, preventing contract deployment.
(I would assume then that I should not see any block produced in polkadot.js)

@cmichi it looks like it's an issue with the websocket:
2022-04-22 14:50:15 Blocked connection to WebSockets server from untrusted origin: Some("https://paritytech.github.io")

do you know how to allow the connection?

@ceikit this error happens when the local node is not ran in development mode. you need to run substrate-contracts-node --dev

@statictype you are right, I guess the executable that we download from here https://github.com/paritytech/substrate-contracts-node/releases starts the node not in dev
version 0.12.0-98a6757

@smu160 I opened an issue about it https://github.com/paritytech/substrate-contracts-node/issues/79
In the meantime you can just execute ./substrate-contracts-node --dev

@statictype Thank you for getting back to me.
I am running into this issue with the --dev flag as well.
This is what I run:
$ ./substrate-contracts-node-linux/substrate-contracts-node --dev
2022-05-18 14:18:10 Substrate Contracts Node
2022-05-18 14:18:10 ✌  version 0.15.0-254342f
2022-05-18 14:18:10 ❤  by Parity Technologies<EMAIL_ADDRESS>2021-2022
2022-05-18 14:18:10 📋 Chain specification: Development
2022-05-18 14:18:10 🏷  Node name: absent-cattle-4287
2022-05-18 14:18:10 👤 Role: AUTHORITY
2022-05-18 14:18:10 💾 Database: RocksDb at /tmp/substrateje4vY7/chains/dev/db/full
2022-05-18 14:18:10 ⛓  Native runtime: substrate-contracts-node-100 (substrate-contracts-node-1.tx1.au1)
2022-05-18 14:18:10 🔨 Initializing Genesis block/state (state: 0xa6aa…5ba0, header-hash: 0xf02e…c251)
2022-05-18 14:18:10 🏷  Local node identity is: 12D3KooWBJUUqu9zBriM9uBVf1xhAiwAbpm9utH112SjGbTP7uab
2022-05-18 14:18:10 💻 Operating system: linux
2022-05-18 14:18:10 💻 CPU architecture: x86_64
2022-05-18 14:18:10 💻 Target environment: gnu
2022-05-18 14:18:10 💻 CPU: AMD Ryzen 9 3900X 12-Core Processor
2022-05-18 14:18:10 💻 CPU cores: 12
2022-05-18 14:18:10 💻 Memory: 128729MB
2022-05-18 14:18:10 💻 Kernel: 5.15.0-30-generic
2022-05-18 14:18:10 💻 Linux distribution: Ubuntu 22.04 LTS
2022-05-18 14:18:10 💻 Virtual machine: no
2022-05-18 14:18:10 📦 Highest known block at #0
2022-05-18 14:18:10 〽 Prometheus exporter started at <IP_ADDRESS>:9615
2022-05-18 14:18:10 Running JSON-RPC HTTP server: addr=<IP_ADDRESS>:9933, allowed origins=None
2022-05-18 14:18:10 Running JSON-RPC WS server: addr=<IP_ADDRESS>:9944, allowed origins=None
2022-05-18 14:18:15 💤 Idle (0 peers), best: #0 (0xf02e…c251), finalized #0 (0xf02e…c251), ⬇ 0 ⬆ 0
2022-05-18 14:18:20 💤 Idle (0 peers), best: #0 (0xf02e…c251), finalized #0 (0xf02e…c251), ⬇ 0 ⬆ 0
2022-05-18 14:18:21 Accepting new connection, 1/100

Note the Accepting new connection, 1/100 in the log only occurs when I connect via websocat ws://<IP_ADDRESS>:9944

It would be useful being able to configure this, as having blocks produced is useful for testing with indexers etc.

No idea why, but when I execute cargo run the node do not want to start at all. All I got:
tomek@rhei-box:~/ssd/workspaces/substrate-contracts-node$ cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.64s
     Running `target/debug/substrate-contracts-node`
2022-10-09 19:42:37.698  INFO main sc_cli::runner: Substrate Contracts Node
2022-10-09 19:42:37.699  INFO main sc_cli::runner: ✌  version 0.20.0-8d76d04faca
2022-10-09 19:42:37.699  INFO main sc_cli::runner: ❤  by Parity Technologies<EMAIL_ADDRESS>2021-2022
2022-10-09 19:42:37.699  INFO main sc_cli::runner: 📋 Chain specification: Development
2022-10-09 19:42:37.699  INFO main sc_cli::runner: 🏷  Node name: physical-glove-3120
2022-10-09 19:42:37.699  INFO main sc_cli::runner: 👤 Role: AUTHORITY
2022-10-09 19:42:37.699  INFO main sc_cli::runner: 💾 Database: RocksDb at /tmp/substrate1UmNVs/chains/dev/db/full
2022-10-09 19:42:37.699  INFO main sc_cli::runner: ⛓  Native runtime: substrate-contracts-node-100 (substrate-contracts-node-1.tx1.au1)
2022-10-09 19:43:16.139  INFO main sc_rpc_server: Running JSON-RPC HTTP server: addr=<IP_ADDRESS>:9933, allowed origins=None
2022-10-09 19:43:16.139  INFO main sc_rpc_server: Running JSON-RPC WS server: addr=<IP_ADDRESS>:9944, allowed origins=None

It is started. Read above. Blocks are produced on demand.


docs: added nextjs app dir example

What kind of change does this pull request introduce?
As the NextJS app dir gets closer to a stable product I think it's relevant to add examples on how to use Sandpack with the NextJS App directory. That's what I've added in this PR.
At least one discussion mentions the wish for examples; #906.
What is the current behavior?
There's only a NextJS pages directory example.
What is the new behavior?
We now have 2 NextJS examples; one with the app directory and one with the pages directory.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
No tests required as it's an example.
Checklist

[x] Documentation;
[ ] Storybook (if applicable); N/A
[ ] Tests; N/A
[x] Ready to be merged;

Wow, thank you so much!


Maximum Update Depth Exceeded bug

Going to the facilities list and clicking on a facility causes a Maximum update depth exceeded error in the developer tools, and the page freezes. It doesn't occur when going to the facility directly. This error is present on Staging but not Production.

It doesn't happen every time, but I've run into this when visiting a facility page directly.


The output contains white spaces for each line of code

hello, basically as the title says, the output contains blank spaces for each line of code even with semicolons:

Scilab kernel v0.9.10
Metakernel v0.24.2
Python v3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 21:26:53) [MSC v.1916 32 bit (Intel)]
Python path: C:\Program Files (x86)\Python37-32\python.exe
Connecting to Scilab...
Scilab connection established
Scilab version "<IP_ADDRESS>0134035"
scilab-6.0.2

Hi @ezalorpro, this is a known issue but I'm not sure how to solve it.

@blink1073 Well in that case , i took a look to the code of the kernel, and since i dont know anything about it, i took the naive approach of pre process the execute code and clean it from '\n'  and comments lines. I dont think thist approach is robust enought in the long term, more testing is requiered, but so far it is not bad. Maybe making use of regular expression whould be a beter choice, but i dont know literaly nothing about regex so . . .
def do_execute_direct(self, code, silent=False):

        # Extra code for better output
        temp = ''
        code = code.lstrip().rstrip('\n')
        NumLines = code.count('\n')

        for i, line in enumerate(code.split('\n')):
            line = line.lstrip().rstrip().split('//')
            if line[0] is not '':
                if line[0].rstrip()[-1] is not ';' and i != NumLines:
                    temp += line[0].lstrip().rstrip() + '\n'
                elif line[0].rstrip()[-1] is ';' or i == NumLines:
                    temp += line[0].lstrip().rstrip()

        code = temp
        .
        .
        .

cheers.

the extra white lines could be suppressed by setting the display mode to 0, means you could add mode(0) at the beginning of the worksheet.
thanks.
rgds,
Chin Luh

@ezalorpro: Works fine. Thanks for sharing.
Except if you have an URL in mprintf() or disp() commands. The "//" makes trouble. But not a big deal.


Move session params show_log and log_level as a global configuration.

What do these changes do?

Print the process information when launching session
Dump session status when launch failed even show_log is False
Move show_log and log_level as a global configuration.
Add graphscope.set_option and graphscope.get_option API

Related issue number
Fixes #7
Fixes #27

Codecov Report

Merging #42 (df5d0b3) into main (46ab90a) will decrease coverage by 22.26%.
The diff coverage is 87.62%.

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
- Coverage   77.36%   55.10%   -22.27%
===========================================
  Files          48       49        +1
  Lines        4356     4450       +94
===========================================
- Hits         3370     2452      -918
- Misses        986     1998     +1012

Impacted Files
Coverage Δ

python/graphscope/deploy/kubernetes/cluster.py
75.09% <73.33%> (+3.71%)
:arrow_up:

python/graphscope/client/session.py
60.66% <80.00%> (-12.42%)
:arrow_down:

python/graphscope/deploy/kubernetes/utils.py
73.68% <88.23%> (+12.93%)
:arrow_up:

python/graphscope/client/utils.py
92.85% <92.85%> (ø)

python/graphscope/client/rpc.py
80.00% <100.00%> (-3.71%)
:arrow_down:

python/graphscope/config.py
100.00% <100.00%> (ø)

...n/graphscope/deploy/kubernetes/resource_builder.py
61.58% <100.00%> (ø)

python/graphscope/deploy/tests/test_demo_script.py
99.00% <100.00%> (+<0.01%)
:arrow_up:

python/graphscope/analytical/udf/patch.py
3.47% <0.00%> (-96.53%)
:arrow_down:

python/graphscope/analytical/udf/wrapper.py
25.80% <0.00%> (-74.20%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ab90a...df5d0b3. Read the comment docs.

Thanks, @sighingnow, I have improved the coding following your advice.

There are still many show_logs=True/False in test_xxxxx.py.


Clarify role of ts_config_rule in documentation

I have been trying to make the intellij plugin work with my typescript build. I think it would be great if the documentation for ts_config_rule (http://ij.bazel.build/docs/project-views.html#ts_config_rule) was expanded to explain what the rule needs to do in order to make IDEA pick up typescript files.

Ah, wait. I think I completely missread what the plugin was doing. I will remove the second half of that of this issue.

The bazel plugin has only very rudimentary support for typescript -- the ts_config_rule is purely there as a convenience after you've already set up typescript support in IntelliJ (via custom BUILD rules, etc.).
During sync, we'll run whatever Bazel target it points to (which presumably will update typescript libraries).
We're looking at adding additional javascript / typescript support in the future, but for now it's very limited.

Oh, ok cool. I guess all I was looking for is getting it to pick up my type files from npm. It struck me after posting this that if I stick them in a srcjar rather than a tarball they will probably get picked up, right?

A example of such a rule would be miost helpful. If you enable ts support in intellij and run into this the project sync will fail and you either must fix it on the spot or disable typescript support again.


Issue with k8s.io/docs/tasks/debug-application-cluster/audit/

This is a...

[ ] Feature Request
[ x ] Bug Report

Problem:
Missing content about the Stage of events in auditing. It used to exist in the 1.7 documentation, but seems to have vanished from more recent documentation, even though the concepts are still used.
Proposed Solution:
Add back documentation about the different stages of events for auditing.
Page to Update:
https://kubernetes.io/docs/tasks/debug-application-cluster/audit/

/assign soltysh, sttts, ericchiang

/assign @soltysh
/assign @sttts
/assign @ericchiang

/assign


feat: product instances for OrderedSub

Surely these instances could go in Mathlib.Algebra.Order.Sub.Basic?
I'm generally in favour of smaller files but in this case the granularity seems a bit too fine. I note that though you import Sub.Canonical, in fact Sub.Basic suffices.
In any case, I'll let you decide.
bors d+

Unfortunately in Sub.Basic we fail with: error: failed to synthesize instance Add (α × β)

bors merge


Migrate cache to Apollo v3

Is your feature request related to a problem? Please describe.
We need to update Apollo client cache system to v3. The problem is that there is a breaking change, there is no fragment matcher anymore: https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/#breaking-cache-changes
End user must be able to provide "possibleTypes" instead.
Also, updating the cache directly lead to writeData is not defined for hooks optimistic update.
Describe the solution you'd like

should we compute possible types automatically? As long as we don't generate unions I think not
however we certainly need the user to be able to setup the possibleTypes for their app

So:

Adding a new method to register some possible types? Pass them at client creation?
(note that in Next we avoid such issues by letting the user create its own client ; creating it in Vulcan core is convenient but makes tweaking diffficult).
remove apollo-cache-* deps when done
replace cache "writeData" by writeQuery (as it is already done in Vulcan NPM: https://github.com/VulcanJS/vulcan-npm/blob/devel/packages/react-hooks/multiQueryUpdater.ts), this part will be easy

Additional context
https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/#breaking-cache-changes

I am seeing a lot of "Invariant Violation" errors from Apollo 3 in the browser console. They are not causing breaking errors, but they are an indication that the Apollo client cache is probably not operating efficiently.
So the point is that we need to move on this sooner rather than later.
In addition, there are other vestiges of Apollo 2 like apollo-link-state that we should probably deprecate from the Vulcan code (see https://github.com/apollographql/apollo-client/pull/5982). In this case it's possible that nobody in Vulcan land is using link state - but how do we find that out? Is it safe to just remove this feature?
I could probably make these changes, but I can't commit to starting right away because of other deadlines I have. But if I do start on this, how do I make sure that no-one else is doing the same work? To discuss that question further, I will open another issue.

I am seeing a lot of "Invariant Violation" errors from Apollo 3 in the browser console. They are not causing breaking errors, but they are an indication that the Apollo client cache is probably not operating efficiently.
So the point is that we need to move on this sooner rather than later.
In addition, there are other vestiges of Apollo 2 like apollo-link-state that we should probably deprecate from the Vulcan code (see https://github.com/apollographql/apollo-client/pull/5982). In this case it's possible that nobody in Vulcan land is using link state - but how do we find that out? Is it safe to just remove this feature?
I could probably make these changes, but I can't commit to starting right away because of other deadlines I have. But if I do start on this, how do I make sure that no-one else is doing the same work? To discuss that question further, I will open another issue.

Contribution would be muuuch appreciated. If you start something, I would simply suggest releasing a patch version of Vulcan current code before we merge the work, and then release a minor.
It's ok to have breaking change, as long as we rely on semantic versioning. There is also a MIGRATING.md where you can explain breaking changes manually + the automated changelog.

Contribution would be muuuch appreciated. If you start something, I would simply suggest releasing a patch version of Vulcan current code before we merge the work, and then release a minor.
It's ok to have breaking change, as long as we rely on semantic versioning. There is also a MIGRATING.md where you can explain breaking changes manually + the automated changelog.


rdkit.Chem.GetSubstructMatch called in dm.scaffold.fuzzy_scaffolding takes rdkit mol as input, not str

According to the datamol documentation and code, the enforce_subs parameter of dm.scaffold.fuzzy_scaffolding should be a list of str (presumably SMILES or SMARTS). However, passing in a list of str gives the following rdkit argument error:

This is because the dm.scaffold.fuzyy_scaffolding function passes the enfocre_subs parameter to rdkit.Chem.GetSubstructMatch, which should take as input an rdkit molecule object, not a string.
Additionally, upon loading the pattern SMILES as molecule object and passing that into the enforce_subs parameter, the function runs without error but dm.scaffold.fuzyy_scaffolding will miss the loaded pattern:
Edit: Image removed. This was a bad example I falsely thought wasn't capturing an enforce_subs r-group. Will find a better example.

Thanks for reporting the bug @colinrsmall.
Indeed this is misleading, and we should probably only accept mol or SMARTS objects here (or propose to do the conversion within the function itself).
Would you like to contribute and propose a fix in a PR?
Note that we are also considering revisiting how this function works at https://github.com/datamol-org/datamol/issues/114.

Sure, the documentation would be an easy fix. Looking at the source code, I'm concerned that some specified fragments in enforce_subs may be missed. If I understand the code correctly, after doing r-group decomposition, you check each r-group to see if they contain any specific fragments:
rgroups = [
    rgp
    for rgp in rgroups
    if not any([len(rgp.GetSubstructMatch(frag)) > 0 for frag in enforce_subs])
]

If they don't, then they get trimmed from the final scaffold (leaving any r-groups that contain a specified fragment remaining):
scaff = trim_side_chain(mol, AdjustQueryProperties(core, core_query_param), rgroups)

This will necessarily miss substructures that are part of both the core and an r-group, such as the atoms highlighted below:

Maybe this is desired behavior? If so, you might also want to update the documentation to specify that the fragments passed in to enforce_subs are true r-groups that would otherwise get wholly stripped away by regular Murcko scaffolding.

Hello @colinrsmall,
You are right about this being the original desired behaviour. The enforce_subs should be interpreted as enforce substitutions (keep vectors attached to the core when they match any fragment in the list).
Since the core here is defined by the Murcko scaffold, then as you said, the behavior can not allow overlapping between the Rgroups and the Murcko core.
Was your expectation that the core itself would contain the queries passed as input by enforce_subs ? This would indeed be a valid use case for this function and in that case we would need to loosely defined the scaffold, based on the ring systems, while including atom matching the query of interest.


noise/image pairs

The noise image here is sampled from the Gaussian noise., or the real image after adding noise by T step?

Hi @zhangyh33 ,
Thanks for your interest! That is a very good question! The noise-image pairs were sampled from the Gaussian noise rather than perturbed from the real images.
Feel free to ask if you have further questions.
Zhengyang

BTW, the FID scores shown in this repo were the distances to the test set, where popular distillation methods compute the FID to the train set.
GET+Offline Distillation even rivals consistency distillation, if we take FID_train as the metric.  (For GET, usually FID_train ≈ FID_test - 2 on CIFAR10.) Offline Distillation is somewhat largely underestimated...
We'll update it later on. Please feel free to try GET!


DeleteForRoot is not right

DeleteForRoot is not right, after DeleteForRoot, the value still can be retrieved. In fact, Delete method in MapStore is not called in DeleteForRoot

The test pass because Delete method in SparseMerkleTree will set defaultValue to root, thus value cannot get from this empty root. This is not correct, root should not set when delete

@yydfjt was this closed because there is no underlying issue?


pep8speaks reports both W503 and W504

Apparently there has been a recent change in pycodestyle that favors line breaks before binary operators over breaks after them:
# Old style
x =<PHONE_NUMBER>40502 +
     74979743 *
     8383)
# New style
x =<PHONE_NUMBER>40502
     + 74979743
     * 8383)

Currently, pep8speaks complains about both variants: the first one triggers W504, the second one W503.
In principle, W504 should be ignored by default in pycodestyle, but that doesn't seem to be the case.
Should one of the two go into the list of default ignores?

Hi @kohr-h!
Can you let me know about the version of pycodestyle with this change? As soon as it gets published on pypi, I can deploy the latest version.
pep8speaks does not have any default pycodestyle configuration. I recommend using .pep8speaks.yml to configure pycodestyle according to your needs.

Oh! Sure, it makes sense to me.
I will add W504 in the README.


Definition of Maps [IG}

Maps are used in two places within the model.  We need to specify exactly what these are. This could be achieved by using a complex data type (as per Range, Quantity)

ScheduledDecisionInstance
SyntaxTemplateDictionary

See master ticket #261

@dih-cdisc: for conditionAssignment class. I only had to make slight modifications. See below altered text:
Descriptions of the decision and pointer are defined using the conditionAssignment class. This class includes 2 attributes: a description of a condition and the reference to the target instance of the scheduledActivityInstance class that it points to once this condition is met, for example: "not reached cycle 12 and fulfilling eligibility to enter next cycle","ScheduledActivityInstance_2".

@dih-cdisc : also updated syntax template IG accordingly: https://wiki.cdisc.org/display/USDMIGv3/Syntax+Templates

This class includes 2 attributes: a description of a condition and the reference to the target instance of the scheduledActivityInstance class that it points to once this condition is met, for example: "not reached cycle 12 and fulfilling eligibility to enter next cycle","ScheduledActivityInstance_2".

@BSnoeijerCD @dih-cdisc : Based on Berber's comments above, consider whether the 'target' relationship should be renamed to one of the following:
conditionalTarget
conditionalInstance
conditionalinstanceTarget
conditionaltargetInstance

This class includes 2 attributes: a description of a condition and the reference to the target instance of the scheduledActivityInstance class that it points to once this condition is met, for example: "not reached cycle 12 and fulfilling eligibility to enter next cycle","ScheduledActivityInstance_2".

@BSnoeijerCD @dih-cdisc : Based on Berber's comments above, consider whether the 'target' relationship should be renamed to one of the following: conditionalTarget conditionalInstance conditionalinstanceTarget conditionaltargetInstance

Lets not over think this, see https://github.com/cdisc-org/DDF-RA/issues/261#issuecomment-2002966743


Interior left nav open state

Closes carbon-design-system/carbon-components-react#715
Adding a new props initialOpenState to interiorLeftNav to control it's initial state of open.
It is required when we have smaller screen and the left Navigation is open by default it should be close by default for better UX.
Changelog
New

Added new props initialOpenState to interiorLeftNav Component

Changed
interiorLeftNav Component
Removed
Removed Nothing

@asudoh Thanks for the review comment. I am now updating props in cWRP.

@asudoh changed the prop name from initialOpenState to simply open. Thanks

Thanks @pfarkya! Please introduce this.props.open !== nextProps.open check, too.

@asudoh Changed as requested. Thanks!

@asudoh When I will expect it to be merged?

@marijohannessen changed as reviewed. Thanks!


test-rdf4h: rdf-tests/turtle/manifest.ttl: openFile: does not exist (No such file or directory)

When building for Stackage LTS 8:
/tmp/stackage-build13/rdf4h-3.0.1$ dist/build/test-rdf4h/test-rdf4h
test-rdf4h: rdf-tests/turtle/manifest.ttl: openFile: does not exist (No such file or directory)

@juhp the instructions for running the tests for this library are in the README.md file:
$ git submodule update --init --recursive
$ git submodule foreach git pull origin gh-pages
$ stack test

I could I suppose integrate this into my Test.hs (main) file for the test suite, I thought it cleaner to do the way above.
Do you know of a way to integrate the above git commands into a script for stackage to pick up before running stack test ? Either in the stack.yaml file, or somewhere else?

AFAIK stack test requires the tests to be integrated.

Is there a workaround for this? I can't seem to build rdf4h on nixos because of this bug.

@JonathanReeve I'm not a nixos user.
Can nixos not run:
$ git submodule update --init --recursive
$ git submodule foreach git pull origin gh-pages

Before
$ stack test

?

Nix runs tests for whatever package (Haskell or otherwise) has tests, and installation will fail if the tests fail. So any package that depends on rdf4h will fail to install if rdf4h runs tests that fail. Is there a way to put those git commands in the test suite somehow? Or put the test suite in the submodule?
Another option is to add rdf4h to the list of packages that Nix skips checks for, but ideally it could still run the tests, and the tests would pass.
BTW you can reproduce this, even if you're not on nixos, by installing Nix and running nix-shell -p haskellPackages.rdf4h.

@juhp @JonathanReeve  can there be any workaround for this? This rdf4h library now passes all W3C RDF parser unit tests for NTriples, Turtle and XML, and it'd be good to have rdf4h on stackage.
The TravisCI automated testing works out-of-the-box, because when it spots the rdf-tests submodule in this repo, it runs git submodule update --init --recursive to obtain the W3C data files needed for testing, which seems like an elegant solution to obtain all the files:
https://travis-ci.org/robstewart57/rdf4h/jobs/631996835#L182
Do similar mechanisms not exist in stackage/nix?


After some steps, all the NNs always output same action

I'm training a A3C these days, but the NN always take the same action, after some steps.
The game I train for is similar to playing Go. There will be few reward in the short term. So it hard to learn something useful for the NN form the game. Maybe that is where the problem is. I tried '    torch.nn.utils.clip_grad_norm(lnet.parameters(), 50) ', and used relu as activate function. But it doesn't work.

I meet same problem, it looks like stuck in a local optimal. Do you solve it?


Add Layer5 newcomer Welcome workflows

This repo (containers-101-workshop) has recently been relocated. It is in need of having GitHub issue templates added to it.
The Layer5 newcomer Welcome workflows can be found here:

https://github.com/layer5io/meshery/tree/master/.github/welcome
https://github.com/layer5io/meshery/blob/master/.github/config.yml

The files/folder above need copied over to this repo.

Hi @shwegyi198361, thank you for jumping into the other Meshery issue regarding updating it's Releases table.
Would you like to try your hand at this issue?

I think we're good to go on this issue given the updates in #5 from @morrme.


support for absolute imports

currently any absolute imports (resolved relative to the baseDir) - e.g.
import { NestedNavLevel } from 'modules/clean/react/maestro_nav/maestro_nav_src/nested-nav';

are not followed by dts-bundle; instead, they seem to always be ignored - copied to the output as is, with no declare module ... {...} generated in the output for them.  AFAICT dts-bundle only understands relative imports (used mainly in commonjs).
I was looking for a config-only workaround to this and discovered that if I use externals: true and try to exclude: /^react$/ I get fairly close to what I want, but it still ends up crashing here: https://github.com/TypeStrong/dts-bundle/blob/master/lib/index.ts#L270
/srv/server/metaserver/build_static/js_tools/node_modules/dts-bundle/lib/index.js:173
                if (isExclude(path.relative(baseDir, p.file), true)) {
                                                      ^
TypeError: Cannot read property 'file' of undefined
    at /srv/server/metaserver/build_static/js_tools/node_modules/dts-bundle/lib/index.js:173:55
    at Array.forEach (native)
    at Object.bundle (/srv/server/metaserver/build_static/js_tools/node_modules/dts-bundle/lib/index.js:166:35)
    at Object.<anonymous> (/srv/server/metaserver/build_static/js_tools/declaration_bundler.js:12:15)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)

A few console.log's later and I've learned that exportMap is empty, but I don't really understand what it is expected to represent.  I've attempted to change baseDir to make things work but from reading the code it doesn't seem like it'll help at all.  My best guess is that it doesn't understand that these are actually local files - it thinks they are node_modules - and is somehow hoping I've given some instructions as to how to handle them.
At the moment it seems like my best option is to attempt to fork this project (and maybe send a patch?) as I can't tell that any possible configuration values will solve my conundrum.  If there's some configuration options I could use to accomplish this that I've missed, please let me know.

btw I've decided to hack on dts-generator instead of dts-bundle, so doesn't matter a ton to me if this gets fixed, but will leave this here as a record of the deficiency.

Pull requests are welcome.


unit test removal of all DMA regions

In #413 we fixed a bad bug in the path that removed all DMA regions. We should unit test this path.

The test should also verify the ->unregister callback is called.


add ability to use scenario file in brute.py

I just stumbled upon this script and I noticed that there is no way to use a specified scenario. My impression is that this was intended to be there, but was forgotten.

Good catch!  I just never used the scenario feature


AsyncClientFactory getThreadLocalCluster failure under validation_server

We're seeing an issue validating our grpc access logging config
[external/envoy/source/server/config_validation/server.cc:60] error initializing configuration 'generated/config/envoy_canary.yaml': Unknown gRPC client cluster 'grpceventsink'

I think these lines should be using the helper ClusterInfoMaps.getCluster() instead of iterating the map manually.
https://github.com/envoyproxy/envoy/blob/e20957c011b11a4f9f935ec7556ed89d1d8c22d7/source/common/grpc/async_client_manager_impl.cc#L41-L42

This is a regression from https://github.com/envoyproxy/envoy/pull/15227/files.
@wozz can you take a look? I think the issue is related to: https://github.com/envoyproxy/envoy/pull/15227/files#diff-e4857a8d978c47fcbd3f06c256cffad8e65c573cb77fe7fb5e3cc3c6f510f323R290-R291
I think that should be using the bootstrap option (I think probably). And now that I think about it should this really actually read ValidateStaticOnMainThread?
Additionally, I'm not sure if the bootstrap option should also be checking for warming cluster or not per @kb000 comment.

will look into this

@wozz in looking a bit more I think we may need to fix the validation cluster manager to return clusters when getThreadLocalCluster() is called? I still think what @kb000 points out is also probably a bug (though preexisting), but I don't think it's the issue he is facing, which I think would impact other callsites also.

I had changed the grpc access log validation to not use main thread because I hit the ASSERT in tests:
[ RUN      ] IpVersionsCientType/TcpGrpcAccessLogIntegrationTest.BasicAccessLogFlow/IPv4_EnvoyGrpc_V3
[2021-03-11 21:45:51.881][6297591][critical][assert] [source/common/grpc/async_client_manager_impl.cc:39] assert failure: Thread::MainThread::isMainThread().
[2021-03-11 21:45:51.881][6297591][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] Caught Abort trap: 6, suspect faulting address 0x7fff203c9462
[2021-03-11 21:45:51.882][6297591][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers):
[2021-03-11 21:45:51.882][6297591][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:92] Envoy version: 0/1.18.0-dev/test/DEBUG/BoringSSL
[2021-03-11 21:45:51.900][6297591][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #0: Envoy::SignalAction::sigHandler() [0x1146b4eac]
[2021-03-11 21:45:51.909][6297591][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #1: _sigtramp [0x7fff2043bd7d]
[2021-03-11 21:45:51.918][6297591][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #2: _dyld_private [0x11730c5e0]
[2021-03-11 21:45:51.920][6297591][critical][backtrace] [bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:96] #3: abort [0x7fff2034a720]

This implies it was one of the cases broken previously because it used methods meant for the main thread on worker threads.

@wozz OK, if that's the case then I think we have to fix the validation server to return clusters from getThreadLocalCluster()? https://github.com/envoyproxy/envoy/blob/e20957c011b11a4f9f935ec7556ed89d1d8c22d7/source/server/config_validation/cluster_manager.h#L58-L63
I'm not really sure the best way to fix this without digging in a bunch more. :(

(I guess in general I don't understand how we can be throwing exceptions at all on the workers so I'm not sure this change is right in general, should we revert while we sort this out?)

Since there doesn't seem like a fix is immediately clear I think we should revert for now and redo this change (with appropriate regression testing added) once we understand the problem better.

Ok, we can revert. The workaround is to disable the static cluster validation.

this issue can be closed. I've opened a new issue to track the original concern: https://github.com/envoyproxy/envoy/issues/15458


Fix minor typo

Just saw a minor error. Thanks for making this, looks great!

Thanks for the fix!


add support for post processing with --post-hook

Thank you so much for bumpversion. It's the link in the release process chain that I have been missing and wanting for so long
I have two use cases that I started to solve with sed and multiple bumpversion invocations before deciding there had to be a better way.
[1] replacement text with leading '#' character
This came up managing a changelog using the same pattern that bumpversion uses: insert a line for the new version when bumping. Works great with rST, but with Markdown things get interesting. I wanted to write:
[bumpversion:file:CHANGELOG.md]
search = ## [Unreleased][unreleased]
replace = ## [Unreleased][unreleased]
	## [{new_version}] - [{now:%Y-%m-%d}]

but of course configparser treats that last line as a comment. Could add a marker and use sed or figure out another way to write the Markdown (dash underlines for level 2 instead of ## could work here). Both felt bad to me.
[2] removal of line
I ran into this copying the flow that bumpversion releases themselves use for the CHANGELOG. After bumpversion release the CHANGELOG is in good shape. After the bumpversion patch to start the unreleased dev section there is this pesky extra line. I was wondering how bumpversion dealt with it and then I saw the "grooming changelog" commits...
What I wanted was a chance to do extra stuff to the replaced text of each file so I added a --post-hook argument. With it the above use cases are solved with a config snippet like:
[bumpversion:file:CHANGELOG.md]
search = ## [Unreleased][unreleased]
replace = ## [Unreleased][unreleased]
	<<>>## [{new_version}] - [{now:%Y-%m-%d}]

and this hook:
import re

def hook(s, current_version, new_version):
    s = s.replace('<<>>', '')

    if (new_version.endswith('-dev')):
        pat = re.compile('## \[({})\]'.format(new_version))

        def dev_line(line):
            m = re.match(pat, line)
            if m:
                return m.group(1) == new_version

        lines = [line for line in s.splitlines() if not dev_line(line)]
        s = '\n'.join(lines)

    return s

I'd appreciate any feedback or suggestions, whether or not this PR is a good fit for the project.

Yes, I like the general direction of this very much (make bumpversion pluggable, create a public API in addition to the command line interface), #98 goes in that direction as well and that is the way forward.
I'd have to think about this whether we can make it more general. Exposing such an API like the one you proposed in the PR is somewhat permanent once introduced so better make this something solid.

cc/ @lgiordani

@peritus cool, yes it is as much about proposing the idea than the specific implementation.
Ideally one should be able to define per file hooks, just as search and replace can be defined per file. I looked at this, but was deterred by the multiple argument parsing passes and didn't want to break anything.
One might also want to hook different points in the cycle, perhaps having pre and post file hooks and pre and post hooks for the entire run.

Thanks! I like those use cases. Introducing hooks is a good idea and I agree with @peritus that it deserves a good design phase. I'll dig into it. @mgk if you have a more complete view of the whole thing feel free to post here a longer description. As Filip said we are trying to make a good step forward, and good ideas or code are always welcome.


Which SIDD data do you use exactly?

Hi, you use SIDD-Medium sRGB data, right? but there are mirror 1 and mirror 2, so which mirror do you use? and what's the difference of mirror 1 and 2?

they are the same

solved by about answer.

hi。the mirror one can't be down,can you help me?


Add CI workflow

Fixes #7

:tada: This issue has been resolved in version 0.7.0 :tada:
The release is available on GitHub release


find matched section range on text input?

In callback onTextInput,
I'm trying to figure out a way to convert matched text into a range, but seems it's not easy to do so.
editor.onTextInput({
  match: /\*(.*)\* /,
  run(editor, matches) {
    // if there's any matched text, find the range in section.
}
});

This is a feature if we want to automatically replace a text pattern into another one (e.g. auto convert *mobile*  to mobile. And it's a must for WYSIWYG markdown editor.

Probably the best way to do this is to find it relative to the editor's current range.
The editor's range is where the cursor currently is. When this onTextInput hook gets called, the cursor range will be collapsed (i.e., no text is selected, the range's head position === its tail position) directly after the " " (space) character that the user just typed.
  editor.onTextInput({
    match: /\*(.*)\* /,
    run(editor, matches) {
      let text = matches[1]; // the text in the capture group;
      let range = editor.range;
      range = range.extend(-1 * (text.length + 2 + 1)); // extend the range backward to cover the text + the 2 "*" + 1 " "

      // make the text bold
      editor.run(postEditor => {
        let position = postEditor.deleteRange(range);
        let bold = postEditor.builder.createMarkup('strong');
        let nextPosition = postEditor.insertTextWithMarkup(position, text, [bold]);
        postEditor.insertTextWithMarkup(nextPosition, ' ', []); // insert the un-marked-up space
      });
    }
  });

some relevant docs:

postEditor#insertTextWithMarkup
postEditor#deleteRange
Range#extend

I think this addresses your question so I will close it now, but please feel free to reopen if you have a follow-up.


Documentation for the tagset used by the POS tagger of Sudachi

Hi, I'm wondering that if there are any documentation for the tagset used by the POS tagger of Sudachi?

See the following thread on Slack.
https://sudachi-dev.slack.com/archives/CBCF278AC/p1617584539086100

Thanks, but neither the pdf link nor the Python code snippet works now.

If you are using 0.6.2, the following snippet should work
import sudachipy
sudachi_dic = sudachipy.Dictionary()
matcher = sudachi_dic.pos_matcher([()])
for pos_id, pos in enumerate(matcher):
  print(pos_id, ",".join(pos), sep="\t")

It seems that the BCCWJ manual has been moved here.
https://ccd.ninjal.ac.jp/bccwj/doc/manual/BCCWJ_Manual_05.pdf

Thanks!


android (portrait) can't scan EAN

Expected Behaviour
Scanning in landscape and in portrait mods
Actual Behaviour
Working only in landscape mode:
In portrait mode I have stretched preview image

Reproduce Scenario (including but not limited to)
orientation: "portrait"
Steps to Reproduce
just set orientation to "portrait"
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 7.1
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Mi 4c
Cordova CLI version and cordova platform version
cordova --version 6.5.0
cordova platforms

android 6.1.2 (on 5.1.1 the same issue)
browser 4.1.0
Plugin version
3.0.0
cordova plugin version | grep phonegap-plugin-barcodescanner
Sample Code that illustrates the problem
Logs taken while reproducing problem
[console.log] Received Event: deviceready
[console.log] Plugin available
[console.log] We got a barcode
Result:
Format:

I too can confirm we are having this issue reading the barcode format EAN128 in portrait mode. We are now forcing the scanner into the landscape mode.


Add more non-ASCII text in automated tests

I grepped for non-ASCII characters in backend tests. Some test files have many of them but most don't. I also manually checked zerver/tests/tests.py. I could only find one non-ASCII character being used (which is ☃).
It is important that we use non-ASCII characters in our tests so that we can be sure that we are handling strings correctly.
Maybe we should also add some non-ASCII streams, users, etc in our test database.

Yeah, this is a good idea; since the tests share users with the development server default data, this is also an opportunity to improve that as well.  I think it'd be reasonable to:

change the name of some of our default streams to include non-ascii characters
add or replace one or two of our default users with a character with a non-ascii name (I'm not sure non-ascii are actually allowed in email addresses, but we could consider testing with one anyway).
Modify the default message content used by populate_db to include non-ascii text.

Ideally we'd use names where there are some latin characters in the name, so it's easy to autocomplete the names when doing manual testing without knowing how to type non-latin characters.  I'd also try to continue the theme of picking characters from literature.
Probably top make this easy we'll want to stop hardcoding e.g<EMAIL_ADDRESS>in every test and instead at least be accessing something like self.email, so it's easier to make changes to these things.

A related thing I should mention while we're thinking about this is that I'd like to move the default test domain from zulip.com to example.com at some point, since I think it being zulip.com can be confusing.

Opened the example.com thing as: https://github.com/zulip/zulip/issues/1118

We've covered most of this in the years since it was opened, and have newer issues covering the remaining pieces, so this is at best a duplicate. Closing.


0 hosts are up

when executing the script as user it don't detect the default gateway
also when tryin with root it return 0 hosts are up ..
i wich that you fix this issue as soon as possible

Are you running it in a virtual machine? If yes, do you have your network card in bridge mode?
Also which error are you getting?
The one with the "something went wrong" or the "you can't kick anyone off"?

@hexocrypt Please let us know if you've managed to resolve this issue.

hello i don't work on virtual machine
i recived as a return : 0 hosts something went wrong
then it back to terminal
2017-01-21 12:31 GMT+01:00 Nikolaos Kamarinakis<EMAIL_ADDRESS>
@hexocrypt https://github.com/hexocrypt Please let us know if you've
managed to resolve this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-274256114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdjwqNtepiHKUuz2VJX5y6-sn7YFrzhks5rUeyFgaJpZM4LmJFZ
.

Oh so you recive someting went wrong... let me look at it.

Try running nmap outside of it but like this...
nmap -Pn <IP_ADDRESS>(Or your gateway)/24
{P.S.}Don't type Or your gateway...

@hexocrypt Please provide more information about your network, and the IP of your attacker machine/gateway/victim.

hello sorry for the delay !
tomorrow i will provide to you all informations
best regards
2017-01-26 20:08 GMT+01:00 David Schütz<EMAIL_ADDRESS>
@hexocrypt https://github.com/hexocrypt Please provide more information
about your network, and the IP of your attacker machine/gateway/victim.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-275481400,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdjwhtYFzumU1aeO5M2U6a3vaUSWW3Nks5rWO9FgaJpZM4LmJFZ
.

All good...
Running Kali 2016.2
Network Normal Router
Victim all devices
Gateway <IP_ADDRESS>
Cant install double tables, or terminal tables
Thanks, Ian
On Thu, Jan 26, 2017 at 4:49 PM, hexocrypt<EMAIL_ADDRESS>wrote:

hello sorry for the delay !
tomorrow i will provide to you all informations
best regards
2017-01-26 20:08 GMT+01:00 David Schütz<EMAIL_ADDRESS>
@hexocrypt https://github.com/hexocrypt Please provide more
information
about your network, and the IP of your attacker machine/gateway/victim.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-275481400,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ATdjwhtYFzumU1aeO5M2U6a3vaUSWW3Nks5rWO9FgaJpZM4LmJFZ>

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-275524813,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX5icSAaXgtV02fdbKdWuxasjGUj-AtOks5rWRTmgaJpZM4LmJFZ
.

2017-01-29 2:06 GMT+01:00 iamianthomas<EMAIL_ADDRESS>
All good...
Running Kali 2016.2
Network Normal Router
Victim all devices
Gateway <IP_ADDRESS>
Cant install double tables, or terminal tables
Thanks, Ian
On Thu, Jan 26, 2017 at 4:49 PM, hexocrypt<EMAIL_ADDRESS>wrote:

hello sorry for the delay !
tomorrow i will provide to you all informations
best regards
2017-01-26 20:08 GMT+01:00 David Schütz<EMAIL_ADDRESS>
@hexocrypt https://github.com/hexocrypt Please provide more
information
about your network, and the IP of your attacker machine/gateway/victim.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/k4m4/kickthemout/issues/20#issuecomment-275481400
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ATdjwhtYFzumU1aeO5M2U6a3vaUSWW3Nks5rWO9FgaJpZM4LmJFZ>

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-275524813,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AX5icSAaXgtV02fdbKdWuxasjGUj-AtOks5rWRTmgaJpZM4LmJFZ>

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-275886588,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdjwuDdwoqta4H74rsCUjBE2r_mvA_Gks5rW-YHgaJpZM4LmJFZ
.

@hexocrypt Could you provide us the info? Thanks.

How are u folks? Im working on a bridge VM my whole family are on the same network i want to kick them all out but somehow im only seeing my host machine and the getaway, What am i missing here? Some network configuration? Im sure they are all on the same router. Do this man a favor. Thank you mates.

Why don't you just use aireplay-ng? You can use the -k option for an ip.
For ex: aireplay-ng -0 0 -a (NETWORK BSSID) -k (THERE IP) (THE MONITOR MODE
INTERFACE)
so in my house it could be aireplay-ng -0 0 -a 00:19:3b:99:e2:80 -k
<IP_ADDRESS> wlan0mon.
First you would have to put device in monitor mode
airmon-ng
airmon-ng start (interface) boom. The new monitor mode interface will be
(interface +mon at end)
mine is wlan0mon
Hope this helps...
you can do this with as many terminals as you would like.
On Sun, Feb 5, 2017 at 8:25 PM, luisaleperozo<EMAIL_ADDRESS>wrote:

How are u folks? Im working on a bridge VM my whole family are on the same
network i want to kick them all out but somehow im only seeing my host
machine and the getaway, What am i missing here? Some network
configuration? Im sure they are all on the same router. Do this man a
favor. Thank you mates.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-277566816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX5iccyynWjx_0j7DIBwRizyl73Os-W7ks5rZnaEgaJpZM4LmJFZ
.

hey
oh i think that the script make a monitor mode it self no need to run them
by my self
thanx anyway i will try it and get back to you
2017-02-06 16:31 GMT+01:00 iamianthomas<EMAIL_ADDRESS>
Why don't you just use aireplay-ng? You can use the -k option for an ip.
For ex: aireplay-ng -0 0 -a (NETWORK BSSID) -k (THERE IP) (THE MONITOR MODE
INTERFACE)
so in my house it could be aireplay-ng -0 0 -a 00:19:3b:99:e2:80 -k
<IP_ADDRESS> wlan0mon.
First you would have to put device in monitor mode
airmon-ng
airmon-ng start (interface) boom. The new monitor mode interface will be
(interface +mon at end)
mine is wlan0mon
Hope this helps...
you can do this with as many terminals as you would like.
On Sun, Feb 5, 2017 at 8:25 PM, luisaleperozo<EMAIL_ADDRESS>wrote:

How are u folks? Im working on a bridge VM my whole family are on the
same
network i want to kick them all out but somehow im only seeing my host
machine and the getaway, What am i missing here? Some network
configuration? Im sure they are all on the same router. Do this man a
favor. Thank you mates.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-277566816,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX5iccyynWjx_
0j7DIBwRizyl73Os-W7ks5rZnaEgaJpZM4LmJFZ>

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-277717549,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdjwgQhz9Fy5PD3UJIAgIZ10MzbIFf8ks5rZzzvgaJpZM4LmJFZ
.

No problem
On Mon, Feb 6, 2017 at 12:51 PM, hexocrypt<EMAIL_ADDRESS>wrote:

hey
oh i think that the script make a monitor mode it self no need to run them
by my self
thanx anyway i will try it and get back to you
2017-02-06 16:31 GMT+01:00 iamianthomas<EMAIL_ADDRESS>
Why don't you just use aireplay-ng? You can use the -k option for an ip.
For ex: aireplay-ng -0 0 -a (NETWORK BSSID) -k (THERE IP) (THE MONITOR
MODE
INTERFACE)
so in my house it could be aireplay-ng -0 0 -a 00:19:3b:99:e2:80 -k
<IP_ADDRESS> wlan0mon.
First you would have to put device in monitor mode
airmon-ng
airmon-ng start (interface) boom. The new monitor mode interface will be
(interface +mon at end)
mine is wlan0mon
Hope this helps...
you can do this with as many terminals as you would like.
On Sun, Feb 5, 2017 at 8:25 PM, luisaleperozo<EMAIL_ADDRESS>wrote:

How are u folks? Im working on a bridge VM my whole family are on the
same
network i want to kick them all out but somehow im only seeing my host
machine and the getaway, What am i missing here? Some network
configuration? Im sure they are all on the same router. Do this man a
favor. Thank you mates.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/k4m4/kickthemout/issues/20#issuecomment-277566816
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX5iccyynWjx_
0j7DIBwRizyl73Os-W7ks5rZnaEgaJpZM4LmJFZ>

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-277717549,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ATdjwgQhz9Fy5PD3UJIAgIZ10MzbIFf8ks5rZzzvgaJpZM4LmJFZ>

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/k4m4/kickthemout/issues/20#issuecomment-277759037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX5icfZDBcSnQ7hn7Exwb2BUWapMulXlks5rZ121gaJpZM4LmJFZ
.

Closing this due to inactivity. If anyone is still experiencing this problem, please create a new issue. Thanks!

Hello i've got the same error
Using interface 'eth0' with MAC address 'f4:8e:38:73:cc:5a'.
Gateway IP: '<IP_ADDRESS>' --> 0 hosts are up.

It looks like something went wrong :/
If you are experiencing this error multiple times, please submit an issue here:
https://github.com/k4m4/kickthemout/issues

hello i've got the same error on ubuntu app on windows 10

WARNING: There are 0 hosts up on you network except your gateway.
You can't kick anyone off


Don't use boost::thread_specific_ptr in LogAcceptCategory

Using valgrind memcheck shows that this causes invalid "free" calls on exit.
I'm not sure what the reason is and it might actually be a false positive.
However, this stops us from using valgrind memcheck and valgrind massif,
so we should fix this issue by using the C++11 thread_local storage
specifier.
This is not necessarily a v14 targeted PR, as the error reported by memcheck
does not lead to any crashes.

I think this issue should go away when we backport https://github.com/bitcoin/bitcoin/pull/9424


Add UniteTest Data Generation Class, Add HashField UnitTest and Pass it.

Add TestTable class, which can load table data from csv for unitTest.
Add TestTableTest, which is a unitTest for TestTable class. Print the loaded table and compare with truth data manually.
Add HashFieldTest class, which involves 4 class, HashMetaFieldRS, HashMetaFieldWS, HashFieldWS, CoolFieldRS. In Unittest, generate data and write it into buffer with writestore part; then read data from this buffer with readstore part. Compare the expected value and actual value

Fix the untracked file.
Clean commit log and rebase it.
plz, review and merge
@hugy718

works at my side. Maybe we shall place the TestData into the corresponding src/test/resources

fix it


EntityCommands should have methods to fail gracefully

What problem does this solve or what need does it fill?
Commands failing due to an entity being despawned is one of the most common and frustrating sources of panics in Bevy at the moment.
What solution would you like?

Enable better backtrace behavior to enable debugging. In particular, we need to know the list of other commands that operated on this entity, and which systems they were issued in.
A tool to enable entity commands to fail gracefully (silently ignore / log / warn) rather than panicking.

What alternative(s) have you considered?
Try
For each of the existing methods on EntityCommands, unwrap this option. Create a try_X variant for each method.
This creates significant API bloat and doesn't capture the way that entity commands are chained: after the first operation has succeeded, the rest of the operations in the chain are infallible.
Verified entity flag
Store a verified_entity_exists Option flag on EntityCommands.  Each of the existing methods on EntityCommands should attempt to set this flag by unwrapping it to Some(true) if it is None`, and be skipped if it is false.
Then, create a few methods on EntityCommands that set the value of the verification flag with varying behavior:

commands.entity(entity).silently_fail_if_missing().insert(Foo)
commands.entity(entity).log_if_missing().insert(Foo)
commands.entity(entity).warn_if_missing().insert(Foo)

This doesn't work though, because the check is occuring at command-issuing time.
Additional context
#2241 proposes a much more general approach to this, but has significant complexity and overhead.
#3757 aims for a similar goal, but doesn't actually create a reliable API: entities can be despawned after we check for their existence, resulting in the same panic.
@emiongit expressed interest in this problem in #3840.

The critical challenge here is that we need to check evaluation at the time of Command evaluation, not command issuing.

Enable better backtrace behavior to enable debugging. In particular, we need to know the list of other commands that operated on this entity, and which systems they were issued in.

I tried to solve this with:

#3848, which will give the source system of a command when it panics
#3851, which will log in which system an entity was despawned

I want to respectfully push back against this idea, or at least my perception of this idea, that those of us experiencing this just need to reorder our systems already. :)
There really aren't any good tools for doing this at scale, without introducing all sorts of brittle cross-plugin dependencies. So say I have a damage/health system that despawns any entities with < 0 damage. That means I...run every single system before this destroy system? Unless I'm misunderstanding, that's a lot of .before(DESTROY_LABEL).before(DESTROY_LABEL).before(...) all over my game, and now every plugin in my game has to know about this one very specific point in an unrelated plugin. That, when I as the game designer know that 90% of these current panics can fail without consequence, and the 10% that can't aren't worth adding lots of extra overhead to the other 90% because it's more academically correct. :) I'm sure someone's going to suggest how I can fix this by using events, tagging entities about to despawn, etc. but why? If I as the game designer know these systems can fail to do their thing, then please don't make me have to care about one more thing that doesn't seem strictly necessary. Writing a game is complicated enough without having to fight the engine, says the guy used to fighting engines. :)
To be clear, I'm fine with methods like .silently_fail_if_missing() and similar. Opting in is fine. But right now there's no opt either way, and these crashes are outpacing others for me by a long shot. I just tend to see a lot more understanding for the "your commands don't make sense!" perspective than I do the "Building a game out of emergent complexity is hard enough already!" perspective.

Some other solutions that might help reduce these problems:

(optional) entity refcounting (if you have a strong reference, the entity is guaranteed to still be alive)
"hard system dependencies":  force SystemA commands to be applied before running dependent SystemB (this is the biggest feature I want from the "stageless" scheduler we're designing now). This would make it possible for SystemB to directly respond to the effects from SystemA, rather than needing a second data channel to "anticipate" changes. Note that this is already possible by converting your systems to exclusive systems.

(optional) entity refcounting (if you have a strong reference, the entity is guaranteed to still be alive)

in the cases that panics now, there are two commands to apply on the same entity: a despawn, then a component insert. How would it work with refcounting? would it be the despawn that would panic?

One graceful method (try_insert) was added in https://github.com/bevyengine/bevy/pull/9844


Unify VM

The state read and constraint VM's can be unified now. I think this is basically as simple as pulling the constraint vm code into the state read vm crate and dedupping a few things.

Closed via #229, landing in #212.