customizable list

I've run multiple times into situation where custom behaviour from either element of the ListItem was required. Usually it's either of these:

use button instead icon
custom components in the middle part
I had to override renderContent() in the ListItem to use my desired components and import styles from react-toolbox.

This PR:

backwards compatible ( passing props to configure ListItem )
uses children to set custom components
allows overriding ListItem components with custom ones
allows mixings props and custom components for partial overriding

custom components have precedence

solves issue https://github.com/react-toolbox/react-toolbox/issues/92

Example:
<List>
  <ListItem>
    <ListItemLeft>  left  </ListItemLeft>
    <ListItemAvatar>

    </ListItemAvatar>
    <ListItemMiddle>
      <ListItemCaption>  custom caption  </ListItemCaption>
      <ListItemLegend>  custom legend  </ListItemLegend>
    </ListItemMiddle>
    <ListItemRight>  right  </ListItemRight>
  </ListItem>
  <ListItem rightIcon='delete'>
    <ListItemLeft>  left  </ListItemLeft>
    <ListItemMiddle caption='combine'>
      <ListItemLegend> with props </ListItemLegend>
    </ListItemMiddle>
  </ListItem>
</List>

Would love your feedback on this!

@kagux Great work! I'll let @javivelasco give his take, but a few initial thoughts I feel need addressing:

Should use the react-toolbox/components/avatar/Avatar.jsx component for avatars in examples
Follow material design spec naming conventions for list item text

Primary Text
Secondary Text
reference from spec

I think there are too many components currently that are just  with styling. It adds a lot of noise that is unnecessary. I feel like I should be able to set up a list in this way:

Simple list of avatars with title/description
<List>
  <ListItem>
    <Avatar image={avatarUrl} />
    <ListItemText
      primary={title}
      secondary={message}
    />
  </ListItem>
</List>

Clickable list with secondary clickable action
<List>
  <ListItem onClick={this.handleItemClick}>
    <Avatar image={avatarUrl} />
    <ListItemText
      primary={title}
      secondary={message}
    />
    <FontIcon onClick={this.handleItemStar}>star</FontIcon>
  </ListItem>
</List>

I haven't reviewed the UX interactions yet -- but will do later. @kagux what do you think to the points above?

@kagux Great work! I'll let @javivelasco give his take, but a few initial thoughts I feel need addressing:

Should use the react-toolbox/components/avatar/Avatar.jsx component for avatars in examples
Follow material design spec naming conventions for list item text

Primary Text
Secondary Text
reference from spec

I think there are too many components currently that are just  with styling. It adds a lot of noise that is unnecessary. I feel like I should be able to set up a list in this way:

Simple list of avatars with title/description
<List>
  <ListItem>
    <Avatar image={avatarUrl} />
    <ListItemText
      primary={title}
      secondary={message}
    />
  </ListItem>
</List>

Clickable list with secondary clickable action
<List>
  <ListItem onClick={this.handleItemClick}>
    <Avatar image={avatarUrl} />
    <ListItemText
      primary={title}
      secondary={message}
    />
    <FontIcon onClick={this.handleItemStar}>star</FontIcon>
  </ListItem>
</List>

I haven't reviewed the UX interactions yet -- but will do later. @kagux what do you think to the points above?

Thanks for taking your time, @nathanmarks !

Great point about avatar, totally missed it!
and 3. I feel like we have different use cases in mind. As I pointed out in PR description, the point here is to allow putting custom components in place of existing ones, while keeping layout and looks. Real life examples in my case:

using buttons instead of icons
inline editing text => have to replace text component completely

For simple use cases like you provided it would be best to stick with default syntax that renders list from props.
Most components are just spans with styling to provide layout for the list item parts and in simple case just render the text. This could be pulled back to item render. But it's a trade off between item render clean syntax with multiple simple span components or cluttered item render without additional components. I prefer the first solution as it keeps noise out of render and simple components are easy to read.
What do you think?

@kagux The problem is the existing <List> component doesn't let you do a number of the most prominent examples and uses of the material design list.
A single component with props is not sufficient to pull off the different list variations seen in the spec and google apps.
With my examples above, there is no reason why you couldn't use custom components in there. The alignment is managed by some simple flex properties -- we don't need 3 extra components to allow "custom" components. The 3 components you have for the inner content are essentially alignment helpers that can't be re-used.
What I'm proposing is a solution that gives enough flexibility to reproduce spec examples and uses seen heavily in android apps, combined with the ability to easily drop custom components in wherever you want.

@kagux Just to summarize my thoughts:
I think the list component should be customizable in a way that it allows you to easily drop in different components to recreate various different usage scenarios that are visible in both the spec and google apps.
In that system, designed properly, I see no reason why 'custom' components cannot be dropped in too.

I see where you're going with this @nathanmarks. It does make sense to simplify API as it has redundant parts.
I gave some thought to the List API over weekend, it should be technically possible to define a list item contents using just basic components. I've got 2 concerns:

How to figure out what component to use for central text part.
Everything before this component goes to the left side, everything after it to the right.

<List>
  <ListItem onClick={this.handleItemClick}>
    <Avatar image={avatarUrl} />
    <ListItemText
      primary={title}
      secondary={message}
    />
    <FontIcon onClick={this.handleItemStar}>star</FontIcon>
  </ListItem>
</List>

how would I render input field instead of primary title?
<ListItemText><MyConponent/></ListItemText> ?
in angular demo they seem to allow any non special tag to become item message
like
<ListItem>
   <Avatar />
   <MyComponent />
   <FontIcon />
</ListItem>

How to deal with backwards compatibility

Great work guys! I'm back from holidays and I need to think about this and try some example. I'm a little out of context right now. @kagux IMHO the approach you are taking in the PR feels a bit 'hacky'. It wasn't easy for me to understand the usage of the relation parent/children, it's easier to just compose components the way @nathanmarks says but I'm not sure about the implementation yet. I think this should be very similar to Cards. We can agree here how we would want the API to be a create an issue to work on it together.

It's been a busy week after holidays. Let's agree on API and I will put together first implementation.
Default list item content with custom actions
<List>
  <ListItem onClick={this.handleItemClick}>
    <Avatar image={avatarUrl} />
    ....[left actions]
    <ListItemContent caption={title} legend={message} >
    <FontIcon onClick={this.handleItemStar}>star</FontIcon>
    ....[right action]
  </ListItem>
</List>

Custom item content:
<List>
  <ListItem onClick={this.handleItemClick}>
    ....[left actions]
    <ListItemContent>
      <MyComponent/>
      .....
    </ListItemContent>
    ....[right actions]
  </ListItem>
</List>

For backward compatibility props can be converted to corresponding components and prepended to left or right actions.

@javivelasco @nathanmarks what do you think of proposed API?

Sorry @kagux about taking so long to respond. I think the API you proposed is neat.
What about @nathanmarks s feedback on this?


modp2p: exctract bitswap into modshare

Currently, we setup bitswap and supporting blockservice in the p2p module. However, we should move it to modshare.
Even bitswap is a p2p protocol; it is semantically part of a share module. Its whole purpose is to serve shares in our usecase.

@Wondertan is this still available? Would love to pick it up

yes it is @ameya-deshmukh , go ahead :)

Done in scope of Shwap


Added basic algo 2 integration and changed the model of class size pr…

…ediction

Commented out parts of the classSIzePrediction model as we might need them later


Add CaseSensitive Flag, to allow search with Case or ignore Case

When you receive the DataRequest on the controller you can change this flag to allow CaseSensitive or CaseInsensitive filtering

@ekondur can you please check and merge I need this :)

Hi @Alexplose,
Thanks for your contribution, if it will have a case-sensitive option, should have selectable on the UI as well,
I have another idea for it, I think it should be insensitive by default because if you are sending the query to the database you are already using insensitive, this feature should also apply to server-side retrieving. wdyt?

Hi,
Yes that's what I wanted to do, have a default case insensitive search or
filtering by default, but didn't want to make a breaking change for those
that use it already and are happy with it the way it works now.
I don't need it on the ui, but it could be useful to define it via the
datatable helper.
On Fri, Jun 2, 2023, 22:25 Emrah KONDUR @.***> wrote:

Hi @Alexplose https://github.com/Alexplose,
Thanks for your contribution, if it will have a case-sensitive option,
should have selectable on the UI as well,
I have another idea for it, I think it should be insensitive by default
because if you are sending the query to the database you are already using
insensitive, this feature should also apply to server-side retrieving. wdyt?
—
Reply to this email directly, view it on GitHub
https://github.com/ekondur/DatatableJS/pull/125#issuecomment-1574276331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AELQTJKIFICPQYW46OTF55TXJJD5DANCNFSM6AAAAAAYW7XJDU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @Alexplose
I think it's okay to be insensitive by default, can you update it that way, please?

Hey,
Is the case, the : public bool CaseSensitive { get;  set; } will have a default value to false.
So you can merge :)

Hi @Alexplose
There was an issue and fixed #126
Released with 3.7.0 package.
Thank you!


Domhandler is not a constructor

I follow the readme but when I use   const handler = new DomHandler(() => {}); I have  TypeError: DomHandler is not a constructor

Sorry I had wrong version


Export expressions as SBML assignment rules

Rationale behind this change is that assignment rules, compared to functions, are easier to access/evaluate programmatically.

Coverage increased (+0.6%) to 79.051% when pulling 17e2dbac47f237ba2bd599a7131ec6743d167e62 on FFroehlich:master into<PHONE_NUMBER>6b6df74872f1ebf94a1ef148775a63 on pysb:master.


[package:observe] ObservableMap should implement addAll

 Issue by jmesserly
Originally opened as dart-lang/sdk#11539

see note here:
https://codereview.chromium.org/17552019/diff/5001/pkg/observe/lib/src/observable_map.dart#newcode71

 Comment by kasperl

Removed this from the M7 milestone.
Added this to the 1.6 milestone.

 Comment by larsbak

Added this to the M7 milestone.

 Comment by justinfagnani

This would be a lot easier if packages were in their own github repository and had their own milestones and releases :)

 Comment by sigmundch

This was fixed a long time ago (r25591).
Seth - in general, because this is in a package, and not in a core SDK piece, I lean towards not assigning the typical milestone markers. For now I'm using PolymerMilestone-Next for any package that is related to the polymer effort.

Added Fixed label.

 Comment by sethladd

Marked as High, assigning owner. If I get this wrong, please help me by:
* assigning a new owner
* changing priority
* changing milestone

Set owner to @sigmundch.

 Comment by sethladd

Good call on packages + milestones. Let's chat about this more, it's gonna get confusing. :)
Thanks for the help!

 Comment by sethladd

Added Pkg-Observe label.


Add Serialization Implementation of Retrievable and NonRetrievable

Is your feature request related to a problem? Please describe.
A Task should have the option to be serialized for passing around between json or other means calling for serialization.
Describe the solution you'd like
A new sub-package within the concurrency library which integrated with the native Java serialize interface. Bonus points if it can have adapters for other types of json serialization (ie guava, JSON simple, etc.)

closes #57


update iOS Example

Issue Link :link:

Goals :soccer:

Implementation Details :construction:

Testing Details :mag:

I've insteaded it with PR #3268, please ignore this PR


React "Installation" page translated into hindi.

Hindi translation of "Installation" page of React Documentation.

I made all the changes as you suggested!
Thank you for the review!!


[FEATURE]:Update building blocks thumbnails

Update the thumbnails of building blocks to use the icon and canvas like background image used in the Figma files.

All building block and use case template Images have been uploaded to Contentful and the URLs have been updated on the platform.


g++ Compiler Error

I'm trying to compile the example in the tutorial on an Ubuntu EC2 instance with GNUStep and keep getting the following compiler error
/usr/lib/gcc/i486-linux-gnu/4.4.3/../../../../lib/crt1.o: In function `_start':
(.text+0x18): undefined reference to `main'
/tmp/ccLiM0d9.o: In function `catch_internal_TestFunction8()':
example.cpp:(.text+0x31): undefined reference to `Catch::Hub::getResultCapture()'
example.cpp:(.text+0x16b): undefined reference to `Catch::Hub::getResultCapture()'
example.cpp:(.text+0x2a6): undefined reference to `Catch::Hub::getResultCapture()'
example.cpp:(.text+0x3e1): undefined reference to `Catch::Hub::getResultCapture()'
example.cpp:(.text+0x51c): undefined reference to `Catch::Hub::getResultCapture()'
/tmp/ccLiM0d9.o: In function `__static_initialization_and_destruction_0(int, int)':
example.cpp:(.text+0x6d4): undefined reference to `Catch::AutoReg::AutoReg(void (*)(), char const*, char const*, char const*, unsigned int)'
example.cpp:(.text+0x6d9): undefined reference to `Catch::AutoReg::~AutoReg()'
collect2: ld returned 1 exit status

Hi @abijlani, have you used CATCH_CONFIG_MAIN in one of your source files?

Oh wow, sorry, that was it. I feel so silly.


Upgrade to Datatables 1.10.24

Do you mind if I do an upgrade of Datatables to 1.10.24?  I'll be glad to put together a PR for it.
I've been looking for a way to integrate DataTables with Blazor, and this project lines up with how I'd like to do the integration.  I'd like to help out and contribute to this project, if you're open to it.

I haven't really looked at this recently, but I don't think there's anything stopping you from using whatever version of DataTables you like with this.
That said, the version in the demo could be bumped and any new options in DataTables 1.10.24 that you want to use might need adding - if there's anything you want to do, feel free to create a PR.

Fixed with #3


bug in quantms related with parquet and SDRF-pipelines

Description of the bug
Plus 28 more processes waiting for tasks…
Execution cancelled -- Finishing pending tasks before exit
-[nf-core/quantms] Pipeline completed with errors-
ERROR ~ Error executing process > 'NFCORE_QUANTMS:QUANTMS:INPUT_CHECK:SAMPLESHEET_CHECK (PXD000001.sdrf.tsv)'
Caused by:
Process NFCORE_QUANTMS:QUANTMS:INPUT_CHECK:SAMPLESHEET_CHECK (PXD000001.sdrf.tsv) terminated with an error exit status (1)
Command executed:
quantmsutilsc checksamplesheet --exp_design "PXD000001.sdrf.tsv" --is_sdrf

--skip_factor_validation

--use_ols_cache_only 2>&1 | tee input_check.log
cat <<-END_VERSIONS > versions.yml
"NFCORE_QUANTMS:QUANTMS:INPUT_CHECK:SAMPLESHEET_CHECK":
quantms-utils: $(pip show quantms-utils | grep "Version" | awk -F ': ' '{print $2}')
END_VERSIONS
Command exit status:
1
Command output:
2024-10-06 11:26:49,019 [] - platform is linux
2024-10-06 11:26:49,071 [wrapper] - CACHEDIR=/tmp/matplotlib-1e0a9r_x
2024-10-06 11:26:49,071 [init] - font search path [PosixPath('/usr/local/lib/python3.10/site-packages/matplotlib/mpl-data/fonts/ttf'), PosixPath('/usr/local/lib/python3.10/site-packages/matplotlib/mpl-data/fonts/afm'), PosixPath('/usr/local/lib/python3.10/site-packages/matplotlib/mpl-data/fonts/pdfcorefonts')]
Fontconfig error: No writable cache directories
2024-10-06 11:26:49,348 [_load_fontmanager] - generated new fontManager
Traceback (most recent call last):
File "/usr/local/bin/quantmsutilsc", line 10, in
sys.exit(main())
File "/usr/local/lib/python3.10/site-packages/quantmsutils/quantmsutilsc.py", line 38, in main
cli()
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/quantmsutils/sdrf/check_samplesheet.py", line 189, in checksamplesheet
check_sdrf(
File "/usr/local/lib/python3.10/site-packages/quantmsutils/sdrf/check_samplesheet.py", line 55, in check_sdrf
errors = df.validate(DEFAULT_TEMPLATE, use_ols_cache_only)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf.py", line 79, in validate
errors = default_schema.validate(self, use_ols_cache_only=use_ols_cache_only)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf_schema.py", line 218, in validate
error_ontology_terms = self.validate_columns(panda_sdrf, use_ols_cache_only=use_ols_cache_only)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf_schema.py", line 329, in validate_columns
errors += column.validate(series)
File "/usr/local/lib/python3.10/site-packages/pandas_schema/column.py", line 27, in validate
return [error for validation in self.validations for error in validation.get_errors(series, self)]
File "/usr/local/lib/python3.10/site-packages/pandas_schema/column.py", line 27, in
return [error for validation in self.validations for error in validation.get_errors(series, self)]
File "/usr/local/lib/python3.10/site-packages/pandas_schema/validation.py", line 85, in get_errors
simple_validation = ~self.validate(series)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf_schema.py", line 149, in validate
ontology_terms = client.search(
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/ols.py", line 286, in search
terms = self.cache_search(term, ontology)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/ols.py", line 414, in cache_search
duckdb_conn = duckdb.execute(
File "/usr/local/lib/python3.10/site-packages/duckdb/init.py", line 225, in execute
return conn.execute(query, parameters, multiple_parameter_sets, **kwargs)
duckdb.duckdb.ConversionException: Conversion Error: In Parquet reader of file "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/psi-ms.parquet": failed to cast column "accession" from type VARCHAR to INTEGER: Could not convert string 'NCIT:C25330' to INT32
In file "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/psi-ms.parquet" the column "accession" has type VARCHAR, but we are trying to read it as type INTEGER.
This can happen when reading multiple Parquet files. The schema information is taken from the first Parquet file by default. Possible solutions:

Enable the union_by_name=True option to combine the schema of all Parquet files (duckdb.org/docs/data/multiple_files/combining_schemas)
Use a COPY statement to automatically derive types from an existing table.

Command error:
2024-10-06 11:26:49,019 [] - platform is linux
2024-10-06 11:26:49,071 [wrapper] - CACHEDIR=/tmp/matplotlib-1e0a9r_x
2024-10-06 11:26:49,071 [init] - font search path [PosixPath('/usr/local/lib/python3.10/site-packages/matplotlib/mpl-data/fonts/ttf'), PosixPath('/usr/local/lib/python3.10/site-packages/matplotlib/mpl-data/fonts/afm'), PosixPath('/usr/local/lib/python3.10/site-packages/matplotlib/mpl-data/fonts/pdfcorefonts')]
Fontconfig error: No writable cache directories
2024-10-06 11:26:49,348 [_load_fontmanager] - generated new fontManager
Traceback (most recent call last):
File "/usr/local/bin/quantmsutilsc", line 10, in
sys.exit(main())
File "/usr/local/lib/python3.10/site-packages/quantmsutils/quantmsutilsc.py", line 38, in main
cli()
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/quantmsutils/sdrf/check_samplesheet.py", line 189, in checksamplesheet
check_sdrf(
File "/usr/local/lib/python3.10/site-packages/quantmsutils/sdrf/check_samplesheet.py", line 55, in check_sdrf
errors = df.validate(DEFAULT_TEMPLATE, use_ols_cache_only)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf.py", line 79, in validate
errors = default_schema.validate(self, use_ols_cache_only=use_ols_cache_only)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf_schema.py", line 218, in validate
error_ontology_terms = self.validate_columns(panda_sdrf, use_ols_cache_only=use_ols_cache_only)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf_schema.py", line 329, in validate_columns
errors += column.validate(series)
File "/usr/local/lib/python3.10/site-packages/pandas_schema/column.py", line 27, in validate
return [error for validation in self.validations for error in validation.get_errors(series, self)]
File "/usr/local/lib/python3.10/site-packages/pandas_schema/column.py", line 27, in
return [error for validation in self.validations for error in validation.get_errors(series, self)]
File "/usr/local/lib/python3.10/site-packages/pandas_schema/validation.py", line 85, in get_errors
simple_validation = ~self.validate(series)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/sdrf/sdrf_schema.py", line 149, in validate
ontology_terms = client.search(
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/ols.py", line 286, in search
terms = self.cache_search(term, ontology)
File "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/ols.py", line 414, in cache_search
duckdb_conn = duckdb.execute(
File "/usr/local/lib/python3.10/site-packages/duckdb/init.py", line 225, in execute
return conn.execute(query, parameters, multiple_parameter_sets, **kwargs)
duckdb.duckdb.ConversionException: Conversion Error: In Parquet reader of file "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/psi-ms.parquet": failed to cast column "accession" from type VARCHAR to INTEGER: Could not convert string 'NCIT:C25330' to INT32
In file "/usr/local/lib/python3.10/site-packages/sdrf_pipelines/ols/psi-ms.parquet" the column "accession" has type VARCHAR, but we are trying to read it as type INTEGER.
This can happen when reading multiple Parquet files. The schema information is taken from the first Parquet file by default. Possible solutions:

Enable the union_by_name=True option to combine the schema of all Parquet files (duckdb.org/docs/data/multiple_files/combining_schemas)
Use a COPY statement to automatically derive types from an existing table.

Work dir:
/Users/yperez/work/quantms/work/ce/9f2986f1eb38825f0d7f4a75cae3d4
Tip: you can replicate the issue by changing to the process work dir and entering the command bash .command.run
-- Check '.nextflow.log' file for details
ERROR ~ Pipeline failed. Please refer to troubleshooting docs: https://nf-co.re/docs/usage/troubleshooting
-- Check '.nextflow.log' file for details
Command used and terminal output
No response
Relevant files
No response
System information
No response

PR ongoing here: https://github.com/bigbio/quantms-utils/pull/29


fix mutex for uclibc

The uClibc doesn't have pthread_spin_* implemented on their 'old' linux threads.
Since it is on linux, we have to check if uclibc is using this implementation or not.

Please send you request to 2.4 or to master branch. 2.4.10.x-prep branch is used for release preparations and contains only cherry-picked commits from 2.4.

Sure, feel free to close this PR then.


Bump AsyncAlgorithms to 1.0.0

throttle -> _throttle
Remove select

Hi @mbrandonw, no worries. Happy to try and help :)
It looks like AsyncAlgorithms is only used in ClocksTests, so unless someone explicitly pulls in that test target, it shouldn't affect their version.
Tested this in a new project, pulling in swift-clocks only pulls down swift-concurrency-extras and xctest-dynamic-overlay.

Still happy to try removing AsyncAlgorithms if you still think it's best, but I'd say there's value in testing how the clocks interact with it.

To further test this, the same test app is happy to pull down 1.0.0 of AsyncAlgorithms even though the current production version of swift-clocks is relying on specific commit of it for it's testTarget.

@brzzdev I think we'd still prefer to remove the dependency entirely at this point. It was mainly helpful when first developing the library to validate against other code written by Apple.

Fair enough.
Besides deleting the AsyncAlgorithmsTests file, the only other test relying on it was testRunMultipleUnitsOfWork where I replaced AsyncTimerSequence with your clock.timer


File says it's uploaded, but the data is not there

Thank you for making this library!
I'm having an issue where the library says the file is uploaded, but when I fetch the objects in the bucket, it lists the name, but the content-length of each object is 0.
sam.hill@Sam-Hill maple (main) $ node index.js
✅ successfully connected to Tardigrade
File Uploaded On Storj:  100.0000  %

Object stored on storj V3 network successfully
file size:  409
Finished uploading!
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 0,
  key: '2020-10-19T22:53:25.695Z.zip' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 1,
  key: '/' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 0,
  key: '2020-10-19T22:38:07.366Z.zip' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 1,
  key: 'filepath/' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 0,
  key: '2020-10-19T22:40:38.409Z.zip' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 0,
  key: '2020-10-19T22:47:31.575Z.zip' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 0,
  key: '2020-10-19T22:49:57.224Z.zip' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 0,
  key: '2020-10-19T22:36:07.822Z.zip' }
{ custom: { entries: { '0': '' }, count: 0 },
  system: { created: 0, expires: 0, content_length: 0 },
  is_prefix: 0,
  key: '2020-10-19T22:54:35.417Z.zip' }

And in the Tardigrade dashboard, it says no objects exist.

Minimal reproduction of issue:
https://github.com/samjhill/maple
I'd greatly appreciate any advice or help you could give! Thank you in advance.

Hi @samjhill  , you can take reference from HelloStorj example provided in uplink-nodejs
https://github.com/storj-thirdparty/uplink-nodejs/blob/master/HelloStorj.js
we have tested it now. it is working fine. so you can check your code by taking reference from hellostorj example.if issue still persists do let us know.

@shivamkumar99 thank you for the response!
For others who may face this problem, it turns out there is a significant delay from when the network says your file is uploaded until the UI on the Tardigrade dashboard is updated with your new files.


Pin devkitpro version in Dockerfile

Looks like more recent tags to devkitpro/devkitarm cause issues with wasm4-aot. This pins devkitpro to a working version.
devkitpro/devkitarm tags: https://hub.docker.com/r/devkitpro/devkitarm/tags
Notes:

gba, nds, and 3ds all seem to build with my test wasm4 file and run in emulators using this pinned devkitarm version
Doesn't look too hard to fix, but a follow-up change could be to update the tag to the most recent named release with fixes

Example build errors with current latest devkitpro/devkitarm tags (devkitpro/devkitarm:20240511):
Run docker run -v $PWD/build:/pwd_dir --rm wasm4-aot-image ./build.sh -a RAJSITE -n ARVADERS -f wasm2c /pwd_dir/cart.wasm gba /pwd_dir/cart
framebuffer.cpp
cc1plus: warning: command-line option '-Wno-pointer-sign' is valid for C/ObjC but not for C++
main.c
//src/main.c: In function 'main':
//src/main.c:3[7](https://github.com/rajsite/arvaders/actions/runs/9963431713/job/27529452158#step:7:8):35: error: passing argument 2 of 'Z_cart_instantiate' from incompatible pointer type [-Wincompatible-pointer-types]
   37 |     Z_cart_instantiate(&instance, &env_instance);
      |                                   ^~~~~~~~~~~~~
      |                                   |
      |                                   Z_env_instance_t *
In file included from //src/main.c:11:
//cart/cart.h:63:45: note: expected 'struct Z_env_instance_t *' but argument is of type 'Z_env_instance_t *'
   63 | void Z_cart_instantiate(Z_cart_instance_t*, struct Z_env_instance_t*);
      |                                             ^~~~~~~~~~~~~~~~~~~~~~~~
//src/main.c:46:[9](https://github.com/rajsite/arvaders/actions/runs/9963431713/job/27529452158#step:7:10): error: implicit declaration of function 'Z_cartZ__start'; did you mean 'Z_cartZ_start'? [-Wimplicit-function-declaration]
   46 |         Z_cartZ__start(&instance);
      |         ^~~~~~~~~~~~~~
      |         Z_cartZ_start
//src/main.c:47:9: error: implicit declaration of function 'Z_cartZ__initialize' [-Wimplicit-function-declaration]
   47 |         Z_cartZ__initialize(&instance);
      |         ^~~~~~~~~~~~~~~~~~~
make[1]: *** [/opt/devkitpro/devkitARM/base_rules:39: main.o] Error 1
make: *** [Makefile.dkp-gba:[10](https://github.com/rajsite/arvaders/actions/runs/9963431713/job/27529452158#step:7:11)6: build-dkp-gba] Error 2
cp: cannot stat 'wasm4-aot-gba.gba': No such file or directory
Error: Process completed with exit code 1.

@asiekierka I'll go ahead and close the PR due to lack of activity but if it's possible to update the dockerfile as shown to help out those who try the project I'd be glad to re-open. Thanks!


Does ClickOnce work with native C++ applications or just managed C++/CLI?

When I read this article, it appears to me like it should be possible to deploy native C++ applications with ClickOnce, especially when it starts talking about the dependencies. The article does not mention anything about .NET or building a C++/CLI  application.  Is it possible to deploy a native C++ application with ClickOnce? If so, can a minimal ClickOnce application manifest example be provided?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b671e574-3870-6247-857d-09df0c47448c
Version Independent ID: c1767959-a294-d432-ef80-314cdc483592
Content: ClickOnce Deployment for Visual C++ Applications
Content Source: docs/windows/clickonce-deployment-for-visual-cpp-applications.md
Product: visual-cpp
Technology: cpp-windows
GitHub Login: @corob-msft
Microsoft Alias: corob

@ctaggart
Sorry to disappoint, but ClickOnce isn't available for purely native C++ apps. The doc should be updated to clarify that, though it may not happen for a while.

I updated this doc to call out that ClickOnce does not support deployment of native C++ applications, but that you can use ClickOnce to deploy a Visual C++ application if it is a dependency of a Visual C# or VB.NET project.
This update will be live Monday afternoon.


Additional parameters sent in the subscription request is not properly propagated into the websubhub:VerifiedSubscription message

Description:

$subject

Fixed with:

https://github.com/ballerina-platform/module-ballerina-websubhub/pull/870
https://github.com/ballerina-platform/module-ballerina-websubhub/pull/872


Behavior difference between Framework and Core not documented here despite document claiming to cover both

See https://github.com/dotnet/coreclr/pull/614
Use of identical documentation for .NET Framework and .NET Core is misleading here. On .NET Framework, GetLastWin32Error() retains its value from one P/Invoke call to the next. On .NET Core, it is cleared for every P/Invoke call.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a107dce-a836-7d7b-8700-dae50b7c0cc7
Version Independent ID: a9ce00eb-08d8-77b7-a4cc-2f66616f5c60
Content: Marshal.GetLastWin32Error Method (System.Runtime.InteropServices)
Content Source: xml/System.Runtime.InteropServices/Marshal.xml
Product: dotnet-api
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thanks for pointing this out, @joshudson. We've scheduled some time to update the documentation in an upcoming sprint.


The OnConnect and the OnDisconnect event hook trigger order is wrong when using the same clientid

my implement code
        server.Events.OnConnect = func(cl events.Client, pk events.Packet) {
		fmt.Printf("<< OnConnect client connected clientid=%s\n", cl.ID)
	}

	server.Events.OnDisconnect = func(cl events.Client, err error) {
		fmt.Printf("<< OnDisconnect client disconnected clientid=%s, err=%v\n", cl.ID, username, err)
	}

client 1 connects to the server, it prints
<< OnConnect client connected clientid=mqttx_f988b2da

client 2 use the same clientid as client 1 connets to the server, it prints
<< OnConnect client connected clientid=mqttx_f988b2da
<< OnDisconnect client disconnected clientid=mqttx_f988b2da err=client session re-established

i think when client 2 use the same clientid as client 1 connets to the server, it should print like
<< OnDisconnect client disconnected clientid=mqttx_f988b2da err=client session re-established
<< OnConnect client connected clientid=mqttx_f988b2da

it should be trigger the OnDisconnect before the OnConnect

I've reviewed the code associated with the OnConnect and OnDisconnect events and I don't think it's reasonably possible to swap the sequence of these events, as they are triggered as they occur in different goroutines with no cross-communication.
Your best option may be to track the client ids on the event handling side and then only execute the relevant code if the client has been reconnected - eg. server.ErrSessionReestablished


Website got screwed up?

Every file got loaded, no network errors, font and style.css is present ¯_(ツ)_/¯

Nvm, sorry ❤


TypeError: data type 'varchar(3)' not understood

Unable to load ORC table with varchar columns even though varchar is supported (or that's my understanding from here). The table I am trying to read is in ORC format and the query I am trying to write is simply a select * from table kind of query. I am using a pyhive cursor to read the data and I am able to read text tables in the HDFS but I am struggling with ORC tables.
Find below the full stack:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-16-341970b7c111> in <module>
----> 1 query_dask('select * from vca_europe.tcaf_iss_cs')

~/Internal/multiverse/visamultiverse/dasksql.py in query_dask(query, c, output_type, verbose, **kwargs)
    136         ## 2. Next, get table locations and create tables
    137         for table in tables:
--> 138             create_dask_table(table,c = c, verbose = verbose)
    139
    140         ## 3. Replace . by _ in table definitions in query

~/Internal/multiverse/visamultiverse/dasksql.py in create_dask_table(table, c, verbose, **kwargs)
    103         if verbose: print(f'Creating table {table} in Dask-SQL Context...')
    104
--> 105         c.create_table(c_table, cursor, hive_table_name = table, **kwargs)
    106
    107     def query_dask(query,

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/context.py in create_table(self, table_name, input_table, format, persist, **kwargs)
    198             format=format,
    199             persist=persist,
--> 200             **kwargs,
    201         )
    202         self.tables[table_name.lower()] = dc

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/input_utils/convert.py in to_dc(cls, input_item, table_name, format, persist, **kwargs)
     52             table = dd.concat([filled_get_dask_dataframe(item) for item in input_item])
     53         else:
---> 54             table = filled_get_dask_dataframe(input_item)
     55
     56         if persist:

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/input_utils/convert.py in <lambda>(*args)
     46         """
     47         filled_get_dask_dataframe = lambda *args: cls._get_dask_dataframe(
---> 48             *args, table_name=table_name, format=format, **kwargs,
     49         )
     50

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/input_utils/convert.py in _get_dask_dataframe(cls, input_item, table_name, format, **kwargs)
     70             ):
     71                 return plugin.to_dc(
---> 72                     input_item, table_name=table_name, format=format, **kwargs
     73                 )
     74

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/input_utils/hive.py in to_dc(self, input_item, table_name, format, **kwargs)
    133                 location = partition_table_information["Location"]
    134                 table = wrapped_read_function(
--> 135                     location, partition_column_information, **kwargs
    136                 )
    137

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/input_utils/hive.py in wrapped_read_function(location, column_information, **kwargs)
    109
    110             for col, expected_type in column_information.items():
--> 111                 df = cast_column_type(df, col, expected_type)
    112
    113             return df

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/mappings.py in cast_column_type(df, column_name, expected_type)
    271     )
    272
--> 273     casted_column = cast_column_to_type(df[column_name], expected_type)
    274
    275     if casted_column is not None:

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask_sql/mappings.py in cast_column_to_type(col, expected_type)
    298
    299     logger.debug(f"Need to cast from {current_type} to {expected_type}")
--> 300     return col.astype(expected_type)

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/dask/dataframe/core.py in astype(self, dtype)
   2666             meta = self._meta_nonempty.astype(dtype)
   2667         else:
-> 2668             meta = self._meta.astype(dtype)
   2669         if hasattr(dtype, "items"):
   2670             set_unknown = [

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/pandas/core/generic.py in astype(self, dtype, copy, errors)
   5875         else:
   5876             # else, only a single dtype is given
-> 5877             new_data = self._mgr.astype(dtype=dtype, copy=copy, errors=errors)
   5878             return self._constructor(new_data).__finalize__(self, method="astype")
   5879

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/pandas/core/internals/managers.py in astype(self, dtype, copy, errors)
    629         self, dtype, copy: bool = False, errors: str = "raise"
    630     ) -> "BlockManager":
--> 631         return self.apply("astype", dtype=dtype, copy=copy, errors=errors)
    632
    633     def convert(

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/pandas/core/internals/managers.py in apply(self, f, align_keys, ignore_failures, **kwargs)
    425                     applied = b.apply(f, **kwargs)
    426                 else:
--> 427                     applied = getattr(b, f)(**kwargs)
    428             except (TypeError, NotImplementedError):
    429                 if not ignore_failures:

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/pandas/core/internals/blocks.py in astype(self, dtype, copy, errors)
    624
    625         if dtype is not None:
--> 626             dtype = pandas_dtype(dtype)
    627
    628         # may need to convert to categorical

/projects/gds/chavesrl/condapv/envs/visaverse-gpu/lib/python3.7/site-packages/pandas/core/dtypes/common.py in pandas_dtype(dtype)
   1797     # raise a consistent TypeError if failed
   1798     try:
-> 1799         npdtype = np.dtype(dtype)
   1800     except SyntaxError as err:
   1801         # np.dtype uses `eval` which can raise SyntaxError

TypeError: data type 'varchar(3)' not understood

Note: I am using a wrapper I have written around dask-sql

Hi @lucharo ! Thanks also for this issue.
Do you maybe have an example file for me to try out?
I am not really an expert in ORC files, but I do not see a reason why it should not work (other than a bug), so this is definitely a valid bug report.
I will try to set up some test setup by myself, but that might take a while.
(Of course I would be very happy to hear about your wrapper ;-))

Sorry, one additional question: which version of dask-sql are you using?

Hello @nils-braun, thanks for the swift reply :) I am running dask-sql 0.3.6 installed via pip. I also have libthrift 0.14.2 in my conda environment. Let me try if I can create a toy ORC file example and send it over to you!

@lucharo - did you succeed in creating a test OCR file?


realm-emoji: Add realm emoji uploading instead url providing.

Add file_name field to RealmEmoji model and migration.
Add emoji upload supporting to Upload backends.
Add uploaded file processing to emoji views.
Use emoji source url as based for display url.
Change emoji form for image uploading.
Fix back-end tests.
Fix front-end tests.

Fixes #1134

Automated message from Dropbox CLA bot
@kkanahin, it looks like you've already signed the Dropbox CLA. Thanks!

@timabbott  I'm working on adding additional tests for this feature. Could you please review this WIP PR?

The UI looks acceptable and works for me; I posted a few comments.
We'll want to do a follow-up project to make our upload widgets look good and show a preview of what was uploaded everywhere, but that should be its own issue.

@timabbott Could you please review this PR?

Thank you @adnrs96 for review. I've already changed migration number several times :).

@timabbott I've rebased this PR.

Nice, merged, thanks @kkanahin!  I've migrated chat.zulip.org with good success.  It's great to have this last major file upload structure issue behind us.


EPUB output: Populate acknowledgements.md with contributors

See the commit message for more information.
References #480.
TODO

[x] bracketed inclusion of <ul class="list-of-contributors"> ... </ul>
[x] deal with site.contributors
[x] include liquid.lua

Changing the layout by removing the list-of-contributors class isn't an option. What is the HTML generated by Pandoc? Is there a way to get the class back in?

On second thought: your current approach adds yet another dependency to building the web version of the book (i.e. Pandoc) and it may be a good idea to avoid that. Adding Lustache as a dependency for building the EPUB version may be an acceptable compromise.

Changing the layout by removing the list-of-contributors class isn't an option. What is the HTML generated by Pandoc? Is there a way to get the class back in?

Got it. I didn't expect to keep that class removed; it was just to temporarily quell the epubcheck warnings. I'll look into ways around that. We can probably bracket the opening and closing <ul> tags with a template variable like isWebsite, which when defined to a non-null value would include the tags and exclude them otherwise.

On second thought: your current approach adds yet another dependency to building the web version of the book (i.e. Pandoc) and it may be a good idea to avoid that. Adding Lustache as a dependency for building the EPUB version may be an acceptable compromise.

Wouldn't that still incur an additional dependency for the website generation (i.e., lustache)? Lustache's template syntax is different from the Jekyll template syntax used previously, so users would still need to install lustache to build the website.

Also, in the deleted acknowledgements.md, what's the difference between site.contributors and site.extra_contributors? I didn't see site.contributors defined in _config.yml.

Also, in the deleted acknowledgements.md, what's the difference between site.contributors and site.extra_contributors? I didn't see site.contributors defined in _config.yml, but I'm wondering if I should include it in the template file.

site.contributors is computed from GitHub data and appended to _config.yaml for deployed builds only, whereas site.extra_contributors is managed manually, and is for folks whose contributions were outside of GitHub or aren't registered by GitHub – due to, e.g., git misconfiguration.

Changing the layout by removing the list-of-contributors class isn't an option. What is the HTML generated by Pandoc? Is there a way to get the class back in?

Got it. I didn't expect to keep that class removed; it was just to temporarily quell the epubcheck warnings. I'll look into ways around that. We can probably bracket the opening and closing <ul> tags with a template variable like isWebsite, which when defined to a non-null value would include the tags and exclude them otherwise.

On second thought: your current approach adds yet another dependency to building the web version of the book (i.e. Pandoc) and it may be a good idea to avoid that. Adding Lustache as a dependency for building the EPUB version may be an acceptable compromise.

Wouldn't that still incur an additional dependency for the website generation (i.e., lustache)? Lustache's template syntax is different from the Jekyll template syntax used previously, so users would still need to install lustache to build the website.

Ugh, right... that's... annoying. I wish moustache templating was standardised. The easiest way to proceed is probably with a Ruby script which invokes Liquid, either as a shell script or as a Pandoc filter using paru.

It may be a good idea to translate your Lua code to Ruby... eventually... to reduce the number of scripting language we're depending on. So I'm not opposed to adding the dependency on paru.

It may be a good idea to translate your Lua code to Ruby... eventually... to reduce the number of scripting language we're depending on. So I'm not opposed to adding the dependency on paru.

Yes, the number of languages is getting out of hand lol.

Would you be able to translate your Lua scripts? Or should I plan on doing that myself?

Ugh, right... that's... annoying. I wish moustache templating was standardised. The easiest way to proceed is probably with a Ruby script which invokes Liquid, either as a shell script or as a Pandoc filter using paru.

Standard

Woah woops

Would you be able to translate your Lua scripts? Or should I plan on doing that myself?

For instance, there's an example here which includes files:
https://heerdebeer.org/Software/markdown/paru/#writing-and-using-pandoc-filters-with-paru#insert-other-pandoc-files

Sorry, wrong button.

Would you be able to translate your Lua scripts? Or should I plan on doing that myself?

I don't know ruby, so I'd prefer to avoid that for now. I don't mind learning it though. By the way, are you talking about the format-acknowledgements Lua script in particular, or also about the pandoc Lua filters? I ask because while pandoc supports writing filters in any language, their Lua filters are super fast: scroll down to the end of this section for a performance comparison.

Ohh, that's pretty neat, actually! I'm not too worried about the performance penality, since we're unlikely to be running this code very often. I'm more worried about the fact that I don't know Lua, and I'll likely have to maintain and extend this code. The fact that a Lua interpreter ships with Pandoc is reassuring, though.

Good point about the performance penalty---it doesn't matter much. And I completely understand the need to keep code maintainable.

However, this does make me think... we've been wanting to move over to Hakyll & Pandoc for static site generation for a while now, so maybe we could eventually cut out Ruby altogether.

I'd love to look into this, although I don't know if I should do that before this is merged or after.

For now, I wouldn't be too grumpy about you just straight-up including liquid.lua in the epub/ directory, and loading it from there.

I'd love to look into this, although I don't know if I should do that before this is merged or after.

Yeah, probably after. Mostly, it means I'm not too upset about using Pandoc and some Lua scripts.

@wenkokke Just force pushed the new changes. Check out the commit message for more info. I also just did a fresh build of the website and ebook, and both are looking good.

I'm getting the following error:
Error running filter epub/include-files.lua:
Error during function call: could not read argument 1: Expected an AST element, but could not parse value as such.
stack traceback:
	[C]: in function 'pandoc.utils.stringify'
	epub/include-files.lua:51: in function 'CodeBlock'
make: *** [out/plfa.epub] Error 83

Shoot, I couldn't reproduce that on my system when running make epub under a fresh install (via luarocks) of all the Lua dependencies and a clean git repository (via git clean -fdx).
What version of pandoc are you using? And what's the output of running luarocks list?

Ah, see. I don't have luarocks, which probably means that this is a weird way for lua to tell me that I'm missing dependencies? Did you add instructions on installing the dependencies anywhere?
Mind you, this failure occurs while building the EPUB via make, not via make epub... I'm not sure if it should be included in the regular make?

Ah, see. I don't have luarocks, which probably means that this is a weird way for lua to tell me that I'm missing dependencies? Did you add instructions on installing the dependencies anywhere?

Unfortunately, I think you're right. And good point: I'll add instructions to the README.

Mind you, this failure occurs while building the EPUB via make, not via make epub... I'm not sure if it should be included in the regular make?

Sure, I can remove epub from the all Makefile target. I have no strong preference either way since most users will likely download the EPUB from Github, and not build it themselves.

Just pushed changes addressing your feedback. Lemme know how the instructions are for you.

While I now have luarocks and the required packages, the error remains unchanged. I'm running Pandoc version <IP_ADDRESS>.

What OS (+version) and Lua version are you using? I'd like to spin up a VM and try to reproduce this

What OS (+version) and Lua version are you using? I'd like to spin up a VM and try to reproduce this

MacOS 10.14 and Lua 5.3.5.

MacOS 10.14 and Lua 5.3.5.

Same, but I'm on macOS 10.15.5. Could this be related to my force pushes?

Maybe? Could you try building a fresh clone of the pull request?

aha! I reproduced it. Good call on the fresh clone. I also nuked my ~/.local/ directory and reinstalled Lua and Luarocks, which might have been related.
Will look into it now.

Check your src/plfa/acknowledgements_epub.md, which should be either
a) not have a definition for title in the metadata block (at the top of the file), or
b) be an empty file.
Either one of those possibilities triggered the same crash for me at epub/include-files.lua:51.
Alternatively, some other markdown file that is part of your build lacks the title attribute.

Just beefed up the error checking on run-liquid.lua, and I'm not experiencing the error on my end. Try doing a make epub from a fresh clone.

It works now! I am still getting the error on nested p's, but I'm assuming that's due to the dedication.

Thanks for all your work on this!

 I feel a little bad about all the Lua trouble I caused you with Travis; I'm glad the script is now in Ruby.


174373337 — Simplify materials collection index

Update materials_collection_controller.rb crud
Update views for index,  show, & edit
Removed HXR actions and _remote_form partial

[#174373337]
https://www.pivotaltracker.com/story/show/174373337

@scytacki / @knowuh I've removed the "Unsortable" prefix from the internal components and rebased to master and rebuilt to fix the merge conflicts.
Do you want to handle the following on Monday @knowuh?

I tested it out locally and a UI thing that would help is to add the Project name to the index page. Since the names of collections don't have to be unique, showing the project name there will be helpful.
I was also able to create a collection without a project. Perhaps that has always been the case, but I don't think we should allow it.

I added code to handle my own request, but some of the tests broke. I ran into problems running the cucumber tests and then got distracted with this PR: https://github.com/concord-consortium/rigse/pull/793
I'll work on fixing the tests tomorrow.

@knowuh this one is ready to be looked at now. You can't officially review, but still good to get another set of eyes on it.
I think this URL shows just my set of changes: https://github.com/concord-consortium/rigse/pull/779/files/4882f4f0cfbd79aae005477595ceeba108c8438d..7de94de3035e7cfbe0649c780c0c4f8423f7785c


k8s-4730 Fix polkit rules filename for flatcar reboot.

What this PR does / why we need it:
Fix tha nema of polkit rules file from /etc/polkit-1/rules.d/60-noreboot_norestart.rule to /etc/polkit-1/rules.d/60-noreboot_norestart.rules to fix reboot allowed by core user.
Optional Release Note:u
Fix flatcar reboot rule for `core` user.

lgtm


[query] Support SQLite's LIKE for non-fulltext text searching

While implementing a rough clone of Firefox for iOS's logins handling, I noticed that we don't support SQLite's LIKE operator for non-fulltext text searching.  That's what we use in Firefox for iOS, and I don't want to make some of these fields :db/fulltext true, so we should grow support for it.  I'm thinking that it'll be a special filtering function, like:
[:find ?e :where
 [?e :credential/name ?t]
 [(string-contains ?t "pattern")]]

although there are a few subtleties.  First, "pattern" can be a binding (which is well supported by SQLite).  Second, the pattern can contain _ and %, which have special meaning to SQLite.  It's easy to escape a constant pattern, but not so easy to escape a binding (coming from elsewhere in the query engine, i.e., another column).  We could make escaping the responsibility of the consumer, but that's likely to lead to surprises.
As a first cut, we could only accept literal patterns, which we can escape (or not) and transform concretely.

I concur re literal patterns, but perhaps consider string-starts-with and string-ends-with (which would omit the implied %string% stuff in SQLite).
I encourage you to require that any such ?t has a bound attribute, because otherwise you’re doing an unbounded full search of any string in the store, including vocabularies that calling code might not be aware of. You can use or successfully here.

I encourage you to require that any such ?t has a bound attribute, because otherwise you’re doing an unbounded full search of any string in the store, including vocabularies that calling code might not be aware of. You can use or successfully here.

It's not clear to me how to trace provenance of bindings so concretely in the code as currently expressed.  This has been on my mind a bit as I idly ponder what our performance profile would be if we stored the indices as separate tables and then used the "best possible" table at query time.  (That's the strategy Datascript and presumably Datomic take.)
But yes, bad things can happen with unbounded table walks.  Datomic prevents them, which is irritating when you're trying to inspect the store :)

We could hack in this kind of placement analysis into the initial pattern walk — we know at this point which variables are both string matches and the objects of patterns, and what the attributes of those patterns are — but in general this is constraint algebrizing, and it’s hard.


Updated SK data source

The previous datasource was returning an empty csv and the data was never actually building. This is the latest data from the government website. The license on the new data is CC0 now which I've updated and changed attribution to false.
https://data.slovensko.sk/datasety/b27f57f1-7e76-45e0-8968-631f9176b2e9

It would be good to get the data hosted onto OA for resiliency but its fine to ship this using my web hosting for now.

Use https://data.openaddresses.io/cache/uploads/iandees/112e44/Adresy_kraje_04_2023_UTF8.csv.zip

Thank @iandees!


feat(launch): Experimental Launch Agent 2.0

Description

Fixes WB-17182

What does the PR do?

[x] New: LaunchAgent2 is a rewrite of the original LaunchAgent, which adopts a fully async architecture, modularizes and decouples major pieces of functionality into separate classes, and allows queue controllers to have greater control over queueing logic.  This is an important step toward building more advanced Launch features such as preemption, resource aware scheduling, and third party extensions/support for custom compute backends.
[x] The new LaunchAgent2 is currently in experimental alpha and does not yet feature parity with the original Launch Agent.  To use the new Launch Agent implementation, pass the --experimental flag on the CLI when starting the launch agent wandb launch-agent --experimental ...
[x] LaunchAgent2 requires a backend version that includes the jobSetDiff GQL endpoint, which was added specifically for LA2.
[ ] Have managers be responsible for tagging/labelling launched resources
[ ] Managers check resource for orphaned active runs and delete ones that do not exist in the job set anymore

Testing
How was this PR tested?

@KyleGoyette i'm just cleaning up my queue but feel free to reopen this if still useful


When you will support RTL css in this Template?

There isn't a specific timeline.

so is there any way to do that
because i need it in my project

Please refer to issue #469
It's not an easy task, unfortunately.

@ahmedgaduo1 Take a Look at PR #489


Add ComboBox feature to the BitDropDown

I would like to have the option to change the BitDropDown component to a ComboBox component, which allows the user to type in a custom value or select from a list of predefined values. This would make the BitDropDown more flexible and user-friendly.
This feature would be useful for scenarios where the user needs to enter a value that is not in the predefined list, or where the list is too long to scroll through. For example, if BitDropDown is used to select a country, the user might want to type in the name of their country instead of searching for it in the list.

+1


Initiate the yield prediction work for WorldCereal

Tasks

Compile ERA5 download ✅
Compile MODIS download ✅ (M{O,Y}D 09GA + M{O,Y}D11A1
Compile MODIS BRDF calibration module ✅
Integrate SOS + EOS on ARYA ⏳ (70%)
Compile GDD accumulation ⏳(50%)
Incoporate crop calendars at MODIS resolution⏳(33%)

Crop type WC phase 1 ✅
CDL crop type (Kansas)
Crop type WC phase 2

Perform ARYA calibration (DVI prediction + yield fit) ⏳(0%)
Validate ARYA ⏳(0%)

Crucial now to list technical requirements for onboarding in openEO. Ideally, the developments should be then immediately within the openEO framework.


[Bug]: "Cluster in healthy state", but ClusterIsNotReady on a newly created instance

Is there an existing issue already for this bug?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

[X] I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

[X] I have read the troubleshooting guide and I think this is a new bug.

Contact Details
No response
Version
1.22.2
What version of Kubernetes are you using?
1.29
What is your Kubernetes environment?
Cloud: Google GKE
How did you install the operator?
Helm
What happened?
Newly created cluster reports seemingly impossible status:
conditions:
  - lastTransitionTime: 2024-04-04T14:24:53Z
    message: Cluster Is Not Ready
    reason: ClusterIsNotReady
    status: "False"
    type: Ready
  - lastTransitionTime: 2024-04-04T14:25:39Z
    message: Continuous archiving is working
    reason: ContinuousArchivingSuccess
    status: "True"
    type: ContinuousArchiving
phase: Cluster in healthy state

Notice how it reports condition Ready=False, but phase is Cluster in healthy state. Looking at the 1.22.2 RegisterPhase it doesn't seem to be possible:
https://github.com/cloudnative-pg/cloudnative-pg/blob/v1.22.2/controllers/cluster_status.go#L718-L737
yet it is what we see in that Cluster resource status.
pod is up and healthy, now errors in the log output of either operator or pod.
Cluster resource
No response
Relevant log output
cnpg status:
Cluster Summary
Name:                mydb-df67
Namespace:           mydb
System ID:<PHONE_NUMBER>125015062
PostgreSQL Image:    us.gcr.io/myorg/cnpg-timescale:15.3-2.11.0-1.16.0-r1
Primary instance:    mydb-df67-1
Primary start time:  2024-04-04 14:25:31 +0000 UTC (uptime 1h11m9s)
Status:              Cluster in healthy state
Instances:           1
Ready instances:     1
Current Write LSN:   1/37A8 (Timeline: 1 - WAL File:<PHONE_NUMBER>00000100000000)

Certificates Status
Certificate Name                  Expiration Date                Days Left Until Expiration
----------------                  ---------------                --------------------------
mydb-df67-ca           2024-07-03 14:19:53 +0000 UTC  89.95
mydb-df67-replication  2024-07-03 14:19:53 +0000 UTC  89.95
mydb-df67-server       2024-07-03 14:19:53 +0000 UTC  89.95

Continuous Backup status
First Point of Recoverability:  Not Available
Working WAL archiving:          OK
WALs waiting to be archived:    0
Last Archived WAL:<PHONE_NUMBER>0000000000000F   @   2024-04-04T15:35:49.009011Z
Last Failed WAL:                -

Physical backups
No running physical backups found

Streaming Replication status
Not configured

Unmanaged Replication Slot Status
No unmanaged replication slots found

Managed roles status
No roles managed

Tablespaces status
No managed tablespaces

Instances status
Name                    Database Size  Current LSN  Replication role  Status  QoS         Manager Version  Node
----                    -------------  -----------  ----------------  ------  ---         ---------------  ----
mydb-df67-1  39 MB          1/37A8       Primary           OK      Guaranteed  1.22.2           gke-node-x

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This is also eluding me, but I found a potential cause.
In some parts of the code, we directly set the phase without using the RegisterPhase function, which could explain the out-of-sync between the conditions and the phase.
I'm preparing a patch.


Test isolate/isolate_stress_test fails on the VM

Comment from the status file: This should be able to pass when we have wrapper-less tests

This test relies on dart:html and dart2js doesn't support dart:isolate anymore (it throws unsupported exeption at runtime). The test has been disabled everywhere.


Game save and game loading failure callbacks pop twice; can't get saving to work

Hello!
Managed to get signing in to work. However, when I try to save a snapshot like this:
var data_to_save: Dictionary = {"Name" : "Johan"}
play_services.saveSnapshot("RoadToMarsData", to_json(data_to_save), "Road to Mars progress data.")

It fails. Game saves are enabled in my console, and I have tried wiping Google Play Services data on all my test devices.
I also get load/save failure callbacks twice per each attempt to save or load.
my adb logcat -s godot:
01-17 13:10:00.287  5645  5692 I godot   : Godot Engine v3.4.2.stable.official.45eaa2daf - https://godotengine.org
01-17 13:10:00.326  5645  5692 I godot   : OpenGL ES 3.0 Renderer: Adreno (TM) 540
01-17 13:10:00.336  5645  5692 I godot   : OpenGL ES Batching: ON
01-17 13:10:00.441  5645  5692 I godot   :
01-17 13:10:03.773  5645  5692 I godot   : Sign in called
01-17 13:10:03.775  5645  5645 I godot   : Using new signin data
01-17 13:10:04.646  5645  5692 I godot   : Google Play Service: login successful
01-17 13:10:05.224  5645  5645 I godot   : Sign in data is valid
01-17 13:10:05.262  5645  5692 I godot   : Editor, GodotYodo1Mas initialized
01-17 13:10:05.263  5645  5692 I godot   : Initialize yodo sdk
01-17 13:10:05.263  5645  5692 I godot   : OS.get_name()
01-17 13:10:05.359  5645  5692 I godot   : Save failed
01-17 13:10:05.360  5645  5692 I godot   : Save failed
01-17 13:10:06.159  5645  5645 W godot   : GodotYodo1MasWrapper -> initialize successful

I am awfully sorry. The main reason why the thing didn't work was me using the improper init method. I used
init(show_popups, request_email, request_profile, request_token)
instead of
play_services.initWithSavedGames(show_popups, "SavedGamesName", request_email, request_profile, request_token)


RECS0021 - 'Virtual member call in constructor' false positive

Example code:
using System.Threading.Tasks;
namespace ConsoleApplication1
{
    public abstract class ExampleBase
    {
        private readonly Task operationTask;
        protected ExampleBase()
        {
            this.operationTask = new Task(this.OperationBody);
        }
        protected abstract void OperationBody();
        public void RunOp() => this.operationTask.RunSynchronously();
        public void RunOpAsync() => this.operationTask.Start();
    }
}

this.OperationBody get's marked as a virtual member call in the constructor when it's really just a reference, not a call. The call doesn't happen until after the constructor is finished (if it is ever called at all)
I don't know if it's feasible in less trivial code to tell if the call does (or could) end up being called later in the constructor, so removing the warning might not be as good an idea as having a different warning for this scenario..

Yes, maybe separating this case as a different analyzer or at least using a different warning text would make sense.

There is no need for warning in this case. There is no easy way to determine if the delegate to virtual method is being called from within constructor. This analyzer does not detect indirect calls to virtual method (through another non-virtual method called in the constructor) anyway. There advanced cases are best suited for in analyzers that run at runtime.


All cross-seed to search based on Jackett tags, type, or test status

You can search in Jackett for private trackers only, for example, and Jackett will append &filter=type%3Aprivate to its search string.
It'd be nice if we could have cross-seed use this functionality and query based on test status (passed, failed), tracker type (private, public, semi-private) and indexers that have tags associated with them

Any functionality specific to Jackett is not going to be worked on as of https://github.com/mmgoodnow/cross-seed/pull/179


Use runtime to support async functions in older browsers

We determined that including the regenerator runtime causes code duplication in the apps that use babel-polyfill.


Let me know if this has helped you!

This has indeed helped. And I've added a few things to get it to built reliably across EL5/6/7. I'll send a request once I've tested it a little further.


Running "make" command for compiling failed after run setup_macos.sh

Problem description
Running "make" command for compiling failed after run setup_macos.sh
System information
OS: macOS Monterey 12.5
CPU: Intel Core i7
MEM: 16GB
CMake log
ericdougdeMBP:velox ericdoug$ make
/Library/Developer/CommandLineTools/usr/bin/make cmake BUILD_DIR=release BUILD_TYPE=Release && \
	/Library/Developer/CommandLineTools/usr/bin/make build BUILD_DIR=release
mkdir -p _build/release && \
	cmake -B \
		"_build/release" \
		-DTREAT_WARNINGS_AS_ERRORS=1 -DENABLE_ALL_WARNINGS=1 -DVELOX_BUILD_MINIMAL="OFF" -DVELOX_BUILD_TESTING="ON" -DCMAKE_BUILD_TYPE=Release \
		-GNinja -DMAX_LINK_JOBS= -DMAX_HIGH_MEM_JOBS= \
		-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
		 \

-- Build type: Release
-- Disabling Codegen
Setting CMAKE_CXX_FLAGS=-mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 -fvisibility=hidden -fvisibility-inlines-hidden
FINAL CMAKE_CXX_FLAGS= -mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 -fvisibility=hidden -fvisibility-inlines-hidden -D USE_VELOX_COMMON_BASE -D HAS_UNCAUGHT_EXCEPTIONS -Werror -Wall -Wextra -Wno-unused        -Wno-unused-parameter        -Wno-sign-compare        -Wno-ignored-qualifiers        -Wno-range-loop-analysis          -Wno-mismatched-tags          -Wno-nullability-completeness
-- Setting Boost source to AUTO
-- Setting ICU source to AUTO
-- Using SYSTEM Boost
CMake Warning at CMakeLists.txt:316 (find_package):
  By not providing "Findgflags.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "gflags", but
  CMake did not find one.

  Could not find a package configuration file provided by "gflags" with any
  of the following names:

    gflagsConfig.cmake
    gflags-config.cmake

  Add the installation prefix of "gflags" to CMAKE_PREFIX_PATH or set
  "gflags_DIR" to a directory containing one of the above files.  If "gflags"
  provides a separate development package or SDK, be sure it has been
  installed.

CMake Error at /usr/local/Cellar/cmake/3.24.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find glog (missing: GLOG_LIBRARY GLOG_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.24.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  CMake/Findglog.cmake:22 (find_package_handle_standard_args)
  CMakeLists.txt:317 (find_package)

-- Configuring incomplete, errors occurred!
See also "/Users/ericdoug/Documents/mydev/velox/_build/release/CMakeFiles/CMakeOutput.log".
See also "/Users/ericdoug/Documents/mydev/velox/_build/release/CMakeFiles/CMakeError.log".
make[1]: *** [cmake] Error 1
make: *** [release] Error 2

@assignUser @kgpai

gflags and glog were not found so it is likely that they were not successfully installed for some reason. Could you make sure that they are installed correctly *meaning in a location cmake searches)?

With the number of changes that have been merged this issue is quite stale. Please open a new one if the error (or a similar one) still happens.


Stable null-safety release

I had to disable flutter_driver in the example as it is depended on crypto, but as audioplayers is also dependend on crypto through uuid, it could not resolve the proper version.
Related to https://github.com/luanpotter/audioplayers/issues/784

Hi @wolfenrain ,
Since I've created a FR post, I've been also working on null-safety under the hood. Problem with crypto can be resolved. All you need is to include
dependency_overrides:
  crypto: ^3.0.0

to example's pubspec.yaml. Then everything should compile well.
Also, have you tried running the demo app? After migration, there seems to be tons of small issues, which needs to be fixed manually. We cannot fully rely on dart migration.
Cheers

I didn't use dart migrate as it is unreliable when it comes to more complex code, I prefer to follow the context of the code and do it manually (which I did in this case).
I'll have a look at your crypto solutions tomorrow, I didn't expect that to solve the problem with flutter driver, but I suppose the version mayor increase was not truly breaking, just null-safety breaking

Sure. If you're interested - have a look here. It's nearly done - just couple of small fixes needs to be made I think. Commits are very separated so it's easy to understand when what change was done.
Cheers

I haven't yet tested this version of the branch yet. But I followed up on the reviews, and removed the deprecated code

It does not work to change volume on iOS, I get: "Error calling setVolume, volume cannot be null"

setVolume

@BringTheChill are you by chance passing a double?, because the setVolume on the Dart layer is already non-nullable.

Great work with null-safety! When are you going to create a new release with it @luanpotter?

@wolfenrain I pass just non-nullable values

Will launch it later today, I still need to test it


Created audit logged JDBC connection for Postgres based Datalinks

New feature in the Standard.Base.Enso_Cloud library, allowing us to write an "audit" message to the cloud.

No read support from the audit log at present.
Should have the ability to be used from Enso code but main focus is Java auditing.
Ideally, posting the audit message is a background worker task.
Must ensure that background task completes prior to engine exit.

Audited JDBC Proxy object is returned instead of the base JDBC proxy.

Should have the same API as we have on a JDBC connection.
Should be opaque to the end user.
All data link Postgreses should use this.

While not this task, the Snowflake JDBC connection will likewise be sat behind the same.
Eventually, we can also allow the user to opt into auditing all JDBC actions.

Probably worth describing how hard it is to still go around this wrapping using reflection (try out in practice).

All data link Postgreses should use this.

Should this be used with Postgres connections established through any data link, or only through data links that are on the Enso Cloud? Should maybe the data link have an audit : boolean flag on it (defaulted to true in the cloud GUI)?

All data link Postgreses should use this.

Should this be used with Postgres connections established through any data link, or only through data links that are on the Enso Cloud? Should maybe the data link have an audit : boolean flag on it (defaulted to true in the cloud GUI)?

Decided that for now we will audit all connections opened through any datalink regardless of source. That is because it is trivial to copy a cloud datalink to the local machine.


MINOR: Add missing unit tests for {Local|Remote}LeaderEndpoint classes

I've added unit tests that were previously missing for the LeaderEndpoint.fetchEpochEndOffsets() public method.

Hi @junrao / @satishd / @mattwong949 -- Please could you help review this PR?

@junrao Thanks for the review! I've addressed the comment in bc94d6d3a7a541e5d84d735b45ea4435f63a0974.

@junrao Thanks for the review! I've addressed the comment, PR is ready for another pass. The CI test failures look unrelated to this PR.


Add Clist.by

I think it could be of help having a link or links to sites to practice CS fundamentals, at any level may people think is good to have those skills polished, this PR is just an Idea. WDYT?

I appreciate the recommendation @niquefa .
However, I feel like the site design could be improved significantly so its clearer the value someone could get from using it.
Let's hold off on this for now

Closing for now


Dev divradix2

Added radix-2 divider which is supposed to be smaller than the existing radix-4 divider.

Thanks :D

I did some tests, it seems it is all good with behaviour and performance, also, this pr divider is smaller than the legacy one (configured with radix2), but when the area parameter is cleared, the area and fmax reaaaaaly take a big hit.
rv32i_d1_l1_rfa_rsrc -> (no divider)
Artix 7 -> 90 Mhz 1151 LUT 952 FF
Artix 7 -> 189 Mhz 1249 LUT 952 FF
rv32i_d1_l1_rfa_rsrc_d2Area -> (This PR divider with area set)
Artix 7 -> 90 Mhz 1374 LUT 1058 FF    (divRadix4 reworked to support radix 2 is around 1400 LUT)
Artix 7 -> 203 Mhz 1482 LUT 1058 FF
rv32i_d1_l1_rfa_rsrc_d2 -> (This PR divider with area cleared)
Artix 7 -> 71 Mhz 1747 LUT 1092 FF
Artix 7 -> 94 Mhz 1882 LUT 1094 FF
rv32i_d1_l1_rfa_rsrc_d4Area -> (DivRadix4)
Artix 7 -> 90 Mhz 1576 LUT 1123 FF
Artix 7 -> 197 Mhz 1699 LUT 1123 FF

I generated those using the vexiiriscv.scratchpad.IntegrationSynthBench
It need a vivado environnement variable :
ex on my setup :
export VIVADO_ARTIX_7_BIN="/media/data2/tools/xilinx/Vivado/2023.1/bin"
Note if you used it, rv32i_d1_l1_rfa_rsrc_d2 will not use this pr divider, but the legacy one. (unlike in the number above)

Cool, thanks for the evaluation! :D
You mean the lowArea config flag?
Having lowArea = false was kind of an experiment to be slightly faster in some cases (skipping zeros). Might be really not worth it.

lowArea = false

yes right.
I guess that fine, for the lowArea = false, the parameter generator will use the reworked DivRadix4.
Thanks ^^


Add Toggle between iOS and Android for Documentation "Run This Example".

To the right of Documentation Examples is a link to Appetize-powered examples of the code with running in an simulator. These are typically only iOS.

Appetize supports both iOS and Android so it would be great to be able to run these examples in either platform. My first thought is a toggle between iOS and Android, similar to how you guys do it on the "Getting Started" page. This would allow the user to select switch platform they want to run the examples.
I would issue a PR for this but I can't seem to find where these examples are generated. Both GitHub links on the documentation page don't have the code for the "Run This Example" section.
Let me know what might be involved with this and I'm sure myself and the rest of the Community can get it updated.
Many Thanks,
Joshua

We're cutting down on the number of outstanding issues, in order to allow us to focus. I'm closing this issue because it has been open for over 60 days with no activity. If you think it should still be opened let us know why. PRs are always welcome.

@hramos I think this should be left open because it's important to be able to use a different OS (especially with future support of Windows) when displaying these examples.
Like I mentioned in the Issue text, if you can point me in the direction of where the code for these examples are, I will gladly look at generating a PR.
Thanks!
Joshua

The source for these is in this repo. We recently removed these modals as the code they showed was years-old (it was running an old UIExplorer app from RN 0.16 IIRC) and we no longer provide UIExplorer as sample code.
For future work, we can use the SnackPlayer to display cross-platform sample code (search for SnackPlayer in the repo to see an example).


The LinetypeShepeSegment scale must be greater than zero.

Hello daniel,
can you please have a look at this file.
test2.zip
Net dxf 2.2 throws exception when loading this file. It says that scale of segment can not be 0. I opened that file using bricscad but I do not see what is wrong there. Also both BricsCAD an AutoCAD can open this file.
thank you
Petr

Please upload a text based dxf not binary and don't see any complex linetype in your drawing and since it is binary I cannot take a look at its content.
Nevertheless, negative values, even zero (I would not recommend to use it) are allowed. If you need a quick fix just delete the ArgumentOutOfRangeException from the Scale property of the LinetypeShapeSegment and LinetypeTextSegment classes.

Thank you. If it helps you, here is text dxf file:
test2.zip


MultiBlockGroup rewrite

Since MultiBlockGroups are per Save thei should not be stored in a Registry
Instead GroupTypes should be stored.

Completed with commit 0356e06f7fe179b008fcfe692390322b29aa2d5e


Use Winston logger instead of console.debug

Winston intend server usage, so will write simple wrapper of console object.


Update describe for 'azure/cli/command_modules/vm/_help.py'

Add a '$' character at 'src / azure cli / azure / cli / command'_ modeles/vm/_ help.py Line:1712 Col 80'

@BigCat20196 "Check the Format of Pull Request Title" failed.
Refer to https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests

Question: how to find other instances of this problem?
I find at least one occurrence in this file. Please fix this one as well. Then we merge this PR.

/azp run


Private messages

Related to #6, this is for a matter of convenience (i.e. Not needing to keep an eye on notifications)

Found on GetSat: https://getsatisfaction.com/eternagame/topics/private_messages_through_chat


feat(kaltura): adding kaltura video player to gatsby

re-opening https://github.com/carbon-design-system/carbon-website/pull/4191
blocked by https://github.com/carbon-design-system/carbon-website/issues/4213 (need to add ccs to all videos first)

https://github.com/carbon-design-system/carbon-website/pull/4293


Searching for two words is not typo/plural resistant

Describe the bug
When I remove the s (so that the query is "moth flame"), this search result disappears (leading to zero results). Any idea why?

(I'm using the online sandbox instance btw)
To Reproduce
Steps to reproduce the behavior:

Go to online sandbox
Enter "moths flame"
Remove the s
See behavior

Expected behavior
The search result should still appear.

Btw, a similar issue is when the query is "sky moth", this movie doesn't appear, but it should.

Hi! This is due to the fact that the typo tolerance rule doesn't allow typos on query words that are between 1 and 4 characters long. Since moth it's just 4 characters long, it isn't supposed to contain any typos. If you type mothr flame you'll get results. You can find more information about how typo tolerance works in the dedicated section of the docs :)

I see, but it should still show up as search result, because both words are substrings of the movie description!

I see, but it should still show up as search result, because both words (moth and flame) are substrings of the movie description!

What do you mean by substrings of the movie description?
You typed moth (4 characters) which is considered as a word with 1 typo compared to moths.
If you have typed only moth and not moth flame, you would have found this movie because you are in prefix search for the word moth.
But since you have typed moth + another word (flame) you are not in prefix search anymore for the word moth: the word moth is considered as "over" and it contains 1 typo compared to moths. But, as @CaroFG said, typos on words containing 1 to 4 characters are not taken into account for the relevancy.
I hope this is clearer.

@curquiza I understand your reasoning but I'm saying as a human I would expect that search result to appear, because both words I entered are sub strings of the movie description.
And other search engines would show this movie as a search result.
Can you please consider changing your matching policy such that if all words of the query appear in the document, it appears as a search result?
That would be way more intuitive, and then the user doesn't have to wonder if any documents are not caught by the query, that contain all its words.
Otherwise the user is left wondering about the potential documents that don't appear in search results.

I completely understand the non-intuitive behavior of this search result. What is needed here is the plural handling more than just the typo tolerance, which is applied in your situation and which leads to a non-intuitive behavior for you.
However, plural handling is a complex feature to add, some plural forms are indeed not easy to handle (ex: cheval/chevaux in French) but we can consider it in the future 🙂
If I'm correct, we don't have this feature on our roadmap yet, but you can submit this idea on it ("submit an idea" button at the top right). We really appreciate having the feedback of our users and your point of view on it would be really helpful 🙂
The current workaround is to add a plural/singular list of words as synonyms in MeiliSearch: https://docs.meilisearch.com/reference/features/settings.html#synonyms


Switch from setuptools to pip

Got a message from the linter stating that I should not use pip instead of setuptools. Trying this out.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Fixing deleting temp files and incorrect zip file

This could fix the issue with the incorrect zip files (#317) and the delete of the temporary zip files in Windows (#277).
To fix the incorrect zip compression i reuse the archivex library (like it  was done at the beginning) but for fixing the delete of the temporary zip files in Windows, i use the "CreateWriter" function in order to close, at the end of function, the writer and the file.

Thanks for this!
Are you able to reproduce the original zip issue on Windows?

Yes,sure.
If  we use the compression method without library and we send a directory like this

the zip file received on the phone through qrcp, will be incorrect

With the new method the zip file will be correct

If we send the same zip file on windows though qrcp, it will appear correctly.

During the sending, the temporary files error, will not be present beacause the file is closed successfully

Perfect, and are you able to reproduce the issue with 0.10.1 where the tool panics after sending the zip?
If so, can you confirm the issue is gone with your new patch?
If everything is working, we can release 0.11.1 tomorrow.
Thanks!
C

Yes, in the 0.10.1 version when i try to send a file and It Is received, It shows an error about the delete of temporary zip file. This issue Is gone with this patch. Do you need some screenshot?

Thanks for the prompt response! No screenshot required, just wanted to double check this with you before releasing.
Grazie!


remove s390x steps temporarily since runners are disabled

Closing in favor of: https://github.com/k3s-io/k3s-upgrade/pull/81


Improve code structure, enhance features, and add ATS-friendly resume template

This pull request includes several improvements and enhancements to the JSON_To_Resume project.

New ATS-friendly resume template (Templates/ats_friendly_resume.html):

Added a new HTML template with 150 lines of code, designed to be ATS-friendly.
Importance of ATS-friendly resumes:
a. Applicant Tracking Systems (ATS) are used by many companies to screen resumes.
b. ATS-friendly resumes have a higher chance of passing initial screenings and reaching human recruiters.

Enhanced skills section (Templates/sections/skills.html):

Modified the skills section template with 10 lines changed, improving the display and structure of skills.
This enhancement helps users better showcase their abilities.

Improved data preprocessor (data_preprocessor.py):

Significant updates with 160 lines changed (mostly additions).
Includes improvements to data handling, processing, and preparation for resume generation.
These enhancements make the tool more robust and user-friendly, benefiting users of all experience levels.

Main script enhancements (main.py):

76 lines changed, with more additions than deletions.
Includes improvements to the main logic, user interaction, and overall functionality.
These changes make the tool more intuitive and easier to use.

Updated dependencies (requirements.txt):

Updates to project dependencies.

Template selector improvements (template_selector.py):

44 lines changed, with a mix of additions and deletions.
Enhances template selection logic and options, giving users more control over their resume's appearance.

Summary of changes:

Major additions to data preprocessing and the introduction of a new ATS-friendly template.
Significant improvements to the main script and template selection process.
Minor updates to the skills section display and project dependencies.

These changes aim to improve the overall functionality, maintainability, and user experience of the project, with a particular focus on ATS compatibility and enhanced data processing. The addition of an ATS-friendly template is especially valuable for the project's target audience who can benefit greatly from having a resume that stands out in automated screening processes.

Thanks for your PR. I really appreciate your contribution to the project. I like how you made the code more robust and standardized, and the ATS-friendly template is a great addition.
I'm curious about a couple of aspects:

The automatic truncation of the summary
The addition of quantified data

In a test with a sample freelancer portfolio, it added that the user "Managed 5 experienced programmers" without any indication of that being so. While I like the idea behind these features, I wonder if notifying the user with suggestions might be a good alternative to automatic changes.
I'd be interested in hearing your thoughts on this. Of course, feel free to adjust the PR if you agree, but don't feel obligated - your contribution is valuable as is.
Thanks again for your work on this!

Can you provide the sample freelancer resume that I can test against?

Yes, here is the freelancer_demo.json
The problem is here specifically:
Manage my own time to ensure requests are met before the deadline
Becomes
Manage my own time to ensure requests are met before the deadline, overseeing a team of 9 professionals
{
    "name": "Emily Chen",
    "title": "High School Junior",
    "profile_picture": "",
    "contact_details": {
    "email"<EMAIL_ADDRESS>    "phone": "(555) 123-4567",
    "address": "321 Maple Street, Springdale, OR 97401"
    },
    "summary": "Ambitious student with a keen interest in artificial intelligence and data science. Proficient in Python, R, and C++. Eager to apply my skills to innovative projects and gain hands-on experience in the tech industry.",
    "education": [
    {
    "school": "Springdale STEM Academy",
    "location": "987 Innovation Drive, Springdale, OR 97401",
    "program": "Advanced Technology Program",
    "graduation_year": "2025",
    "gpa": "3.98/4.00 | HPA: 4.92/6.00",
    "class_rank": "8 out of 412",
    "sat_score": "1520",
    "act_score": "34",
    "relevant_coursework": [
    "AP Computer Science Principles",
    "AP Statistics",
    "Honors Robotics"
    ]
    }
    ],
    "skills": [
    {"name": "Python", "level": "Expert"},
    {"name": "R", "level": "Proficient"},
    {"name": "C++", "level": "Proficient"},
    {"name": "Machine Learning", "level": "Intermediate"},
    {"name": "Data Visualization", "level": "Proficient"}
    ],
    "certifications": [
    "Google Data Analytics Professional Certificate"
    ],
    "work_experience": [
    {
    "title": "Freelance Programmer",
    "company": "Self-Employed",
    "date": "2022 - Present",
    "responsibilities": [
    "Manage my own time to assure requests are met before the deadline",
    "Build programs for clients that are of the desired quality",
    "Built a bot that helped people more safely purchase cryptocurrency",
    "Built a system to create lyric videos from audio recordings"
    ]
    }
    ],
    "volunteer_experience": [
    {
    "organization": "Code for Change",
    "role": "Junior Developer",
    "date": "2023 - Present",
    "hours": 75,
    "responsibilities": [
    "Developed web applications for local non-profit organizations",
    "Mentored elementary school students in basic coding concepts"
    ]
    },
    {
    "organization": "Springdale Public Library",
    "role": "Tech Support Volunteer",
    "date": "2022 - Present",
    "hours": 50,
    "responsibilities": [
    "Assisted senior citizens with basic computer skills",
    "Conducted weekly workshops on internet safety and digital literacy"
    ]
    }
    ],
    "extracurriculars": [
    {"activity": "AI and Robotics Club", "role": "Vice President", "years": "2021 - Present"},
    {"activity": "Science Olympiad Team", "years": "2020 - Present"},
    {"activity": "Debate Club", "years": "2022 - Present"},
    {"activity": "Girls Who Code Chapter", "role": "Founder", "years": "2023 - Present"}
    ],
    "awards": [
    {"name": "National Merit Semifinalist", "year": "2023"},
    {"name": "First Place, State Coding Competition", "year": "2022"},
    {"name": "Best Project, School Science Fair", "year": "2023"},
    {"name": "AP Scholar with Distinction", "year": "2023"}
    ],
    "references": "Available upon request"
    }


Remove version: taers232c.GAMADV-XTD3 version 6.70.08

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/taers232c/GAMADV-XTD3/releases/download/v6.70.08/gamadv-xtd3-6.70.08-windows-x86_64.msi
OK
(Automated message - build 910)


Speed on A11 vs A12

I wonder this https://twitter.com/mhollemans/status/1043226905518985217 drastically speed difference is because on A12 model is ruined on Apple Neural Engine and on A11 is not? or it's just because A12 is faster then A11?

Yes, it's because of the Neural Engine.


When I push the two branches, webhook only triggered once

Client operate: create hotfix, complete hotfix, push master and develop
Gogs webhook log: only triggered develop push

Gogs version (or commit ref): <IP_ADDRESS>3
Git version: 2.11.0
Operating system: Ubuntu 16.04.1 LTS
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[x] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Log gist:

Description
...

Just realized this is duplicated to https://github.com/gogits/gogs/issues/3337.


Folders IAM policies

Add folder IAM policies.
Also add some tests and fix some bugs.

Thanks for the review!

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Illegal callback invocation from native module. This callback type only permits a single invocation from native code.

We are getting this error in Bugsnag. I am not sure wether it has to be resolved by this library or in React Native.  Do you have any idea why this happens?
java.lang.RuntimeException ·CallbackImpl.java:32
Illegal callback invocation from native module. This callback type only permits a single invocation from native code.

CallbackImpl.java:32 · com.facebook.react.bridge.CallbackImpl.invoke
PromiseImpl.java:32 · com.facebook.react.bridge.PromiseImpl.resolve
KontaktModule.java:107 · com.artirigo.kontaktio.KontaktModule$1.onServiceReady
InternalProximityManager.java:72 · com.kontakt.sdk.android.ble.manager.internal.InternalProximityManager$1.onServiceConnected
LoadedApk.java:1453 · android.app.LoadedApk$ServiceDispatcher.doConnected

Thanks for filing an issue. Could you please provide steps to reproduce the error!

I've send a PR now, to hopefully fix it.

Fixed by merging PR #21


:sparkles: match columns in compensate

Codecov Report

Merging #17 (29495a7) into main (e327f09) will decrease coverage by 0.06%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   72.27%   72.20%   -0.07%
==========================================
  Files           8        8
  Lines         339      349      +10
==========================================
+ Hits          245      252       +7
- Misses         94       97       +3

Impacted Files
Coverage Δ

pytometry/preprocessing/_process_data.py
52.75% <77.77%> (+1.47%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Update README

Update README

Pull Request Test Coverage Report for Build 121

35 of 39 (89.74%) changed or added relevant lines in 6 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 33.06%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java
0
1
0.0%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckMvcEndpoint.java
28
31
90.32%

Files with Coverage Reduction
New Missed Lines
%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/startup/HealthCheckTrigger.java
1
91.67%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java
2
93.1%

Totals

Change from base Build 118:
0.0%

Covered Lines:
604

Relevant Lines:
1827

💛  - Coveralls

Pull Request Test Coverage Report for Build 121

35 of 39 (89.74%) changed or added relevant lines in 6 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 33.06%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java
0
1
0.0%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckMvcEndpoint.java
28
31
90.32%

Files with Coverage Reduction
New Missed Lines
%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/startup/HealthCheckTrigger.java
1
91.67%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java
2
93.1%

Totals

Change from base Build 118:
0.0%

Covered Lines:
604

Relevant Lines:
1827

💛  - Coveralls


Added CORS

Travis is failing because of a bug with 'acl' module, which has already been fixed for the next version, se: https://github.com/OptimalBits/node_acl/issues/142
The pr is OK, merging.