error: (-28:Unknown error code -28) The input arrays should have at least 4 corresponding point sets to calculate Homography in function 'findHomography'

Hi,
Would you know why I am getting this error? I see in the code here that you check for minimum 4 pairs of points before findHomography but still getting the error:
https://github.com/tryolabs/norfair/blob/009a1b171ab14336d79d7b7b02dfa5f45066c79e/norfair/camera_motion.py#L220
File "/home/aagrawal/face_detection/real_videos/open_source_face_detection.py", line 232, in main
coord_transformation = motion_estimator.update(frame) #, mask)
File "/home/aagrawal/face_detection/face_venv/lib/python3.10/site-packages/norfair/camera_motion.py", line 396, in update
update_prvs, coord_transformations = self.transformations_getter(
File "/home/aagrawal/face_detection/face_venv/lib/python3.10/site-packages/norfair/camera_motion.py", line 216, in call
homography_matrix, points_used = cv2.findHomography(
cv2.error: OpenCV(4.9.0) /io/opencv/modules/calib3d/src/fundam.cpp:385: error: (-28:Unknown error code -28) The input arrays should have at least 4 corresponding point sets to calculate Homography in function 'findHomography'

The reason might be because that bug was fixed not long ago, but the fix is still not part of the latest release. Maybe try installing Norfair from the master branch:
pip install git+https://github.com/tryolabs/norfair.git@master#egg=norfair

Tell me if this fixes the issue.

Thanks a lot, @aguscas !
Installing from master seemed to work. I do get the following warning though:

Does this mean that transformation will be skipped for the frame in case of this issue but everything else will work fine?

Everything should work fine. That means that the coord_transformation will not be updated in that frame (the MotionEstimator will return the latest transformation it could estimate). As long as that doesn't happen often it shouldn't be a problem with the coord_transformation, since typically a single frame shouldn't affect that much at the coordinate_transformation.

Makes sense! Closing this issue. Again, thanks so much for your help!

If you want not even have that warning (so that you always estimate the transformation), you can also try setting the max_points argument of the MotionEstimator to a higher value (so that it tries sampling more points), or the min_distance parameter to a smaller value (so that we allow to sample points that are closer to each other).

For now, it's not an issue for me but I'll experiment with those two parameters. Thanks a lot!


how to specify where cursor goes during a replaceRange?

We've run into this issue:

Open codemirror.net
Place cursor on the last line, las column in the document
Try to automatically insert a newline at the end of the doc, with editor.replaceRange('\n', {line: 7}, {line: 7})

Expected:
The cursor stays where it was, but the newline gets inserted after it.
Actual:
The newline gets inserted and the cursor goes down with it.
I don't see any way to effectively configure this behavior. Is there something I'm missing?

I don't see any way to effectively configure this behavior. Is there something I'm missing?

Nope, replaceRange (and more generally any kind of change) will move the selection forward when it's in or on the boundaries of the change. You could work around this by resetting the selection after the change (if it changed at all).


wrapper.emitted includes sub-component events with the same name

Description
When testing component events, we often trigger an event on an inner sub-component to mimic user input, and observe a final event get emitted from the component under test, sometimes with a different / transformed value. However the current version of vue-test-utils-next makes this difficult by returning all emitted events with the same name, even if they were not emitted directly by the component under test.
This has become more of an issue with the recommendation not to use shallow mount, and the prevalence of update:modelValue events when using v-model heavily (ie in forms).
Expected behaviour
I would expect wrapper.emitted() to only include events emitted by the top-level component provided as the first argument to mount.
Observed behaviour
wrapper.emitted() includes events emitted from sub-components, adding to events observed under the same name.
Example
import { mount } from '@vue/test-utils';

const RawInput = {
  template: '<input v-model="computedValue" />',
  emits: ['update:modelValue'],
  props: ['modelValue'],
  computed: {
    computedValue: {
      get() { return this.modelValue; },
      set(val) { this.$emit('update:modelValue', val); },
    },
  },
};
const CSVInput = {
  template: '
<RawInput v-model="computedValue" />
',
  components: { RawInput },
  emits: ['update:modelValue'],
  props: ['modelValue'],
  computed: {
    computedValue: {
      get() { return this.modelValue.join(' '); },
      set(val) { this.$emit('update:modelValue', val.split(',')); },
    },
  },
};

test('emitted events', () => {
  const wrapper = mount(CSVInput, { props: { modelValue: [] } });
  // inner component emits 'foo,bar'
  wrapper.get('input').setValue('foo,bar');

  // we want to test outer component emits ['foo', 'bar']
  expect(wrapper.emitted('update:modelValue')).toStrictEqual([[['foo', 'bar']]]);

  // instead wrapper.emitted('update:modelValue') contains events for both
  // inner and outer components
});

Error: expect(received).toStrictEqual(expected) // deep equality

- Expected
+ Received

@@ -1,7 +1,10 @@
  Array [
    Array [
+     "foo,bar",
+   ],
+   Array [
      Array [
        "foo",
        "bar",
      ],
    ],

Version
2.0.0-rc.0
This also appears to be a regression that was not present in earlier versions, as updating to 2.0.0-rc.0 broke about 12 tests in our test suite that were previously working with the expected behaviour.

Hi! This definitely looks like something that should not happen. Is it possibly due to https://github.com/vuejs/vue-test-utils-next/pull/296?

Looks like it. The devTools emit method is getting called on every emit, so all events occurring within the wrapper are being recorded.
A simple fix would be to add a key to each vm to record events for each vm separately, not sure if polluting the vm instance is considered bad form. Alternately, events could be recorded against the component uid.
I can take a look at getting a PR up tomorrow if no one else has a chance to look at it.

Had a crack at a PR, updated the tests to detect the issue but I haven't tested this fork against my actual project codebase.


Add 4 additional commands for build

Add --with-secure-properties flag in 'acr build-task show' command.
Add 'acr build-task update-build' command.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x ] I adhere to the Command Guidelines.

CI is still failing

The failing CI seems not related with the commits, should we restart the build?

yes


Falcon Primitive Operations

Feature Description
Primitive operations of Falcon Protocol:

[ ] Addition with public value
[ ] Subtraction with public value
[ ] Addition with another secret
[ ] Subtraction with public value
[ ] Multiplication with public value
[ ] Multiplication with another secret

Additional Context
Falcon Paper
This PR has a dependency on #145 and should be built on Replicated Secret Share Tensor.

I think this could also be split into multiple issues?


AttachmentList: Improve UX on new items

AttachmentList: Improve UX on new items

This update improves the AttachmentList UX when new attachments are added.
The UI now scrolls to reveal the latest attachment. The left/right
scrolling MATH has also been updated to scroll to the correct amount.

Coverage remained the same at 100.0% when pulling 5673a8102f3b932f8aaa5c09eab0c4143efaa699 on attachment-list-scroll-ux into a0f261b39fa47b807aa297df9d5649d6354dd1b6 on master.


opentok 1.0.3 conflicts with pushwoosh 3.5.0

When both plugins opentok 1.0.3 and pushwoosh 3.5.0 is included, opentok is not able to publish video.  However, if pushwoosh 3.4.16 is used, everything is ok again.
Built with Intel XDK v1912 Cordova (4.1.2) iOS, tested on iPhone 5s, iPhone 6, iPad 8.3

Turns out it was an issue on pushwoosh's side.  Fixed in 3.5.1.


Add classifiers for Odoo versions

Request to add a new Trove classifier.
The name of the classifier(s) you would like to add:

Framework :: Odoo :: 8.0
Framework :: Odoo :: 9.0
Framework :: Odoo :: 10.0
Framework :: Odoo :: 11.0
Framework :: Odoo :: 12.0
Framework :: Odoo :: 13.0
Framework :: Odoo :: 14.0
Framework :: Odoo :: 15.0

Why do you want to add this classifier?
Similar to other frameworks (Plone, Django), it is useful for Odoo to have per version classifiers, to easily locate addons that match an Odoo version.

Odoo 15.0 is going to be released next week. It would be super cool if this could be merged by then so we can use the version classifiers from the beginning for Odoo 15 compatible addons.

To elaborate a little bit, we are going to evolve the naming scheme for Odoo addons from odoo{series}-addon-{addon_name} to odoo-addon-{addon-name}, which will help reducing the number of projects we publish on PyPI and alleviate possible name conflict issues. Having a classifier for each Odoo series therefore becomes more important.
Let me know if there are any concern with this PR.

Thank you so much.


Installing CLI without apt-key

Currently the installation instructions on the download page includes:
wget -qO - https://releases.jfrog.io/artifactory/jfrog-gpg-public/jfrog_public_gpg.key | sudo apt-key add - [...]

But given that apt-key is being deprecated, with 22.04 being the last supported version, this needs to be updated. This process can normally be done manually by downloading the key to /usr/share/keyrings[^1] and adding a signed-by reference to the public key. However, doing that I end up with:
"Failed to update apt cache: GPG error: https://releases.jfrog.io/artifactory/jfrog-debs xenial InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 6B219DCCD7639232. The repository 'https://releases.jfrog.io/artifactory/jfrog-debs xenial InRelease' is not signed."

when the repo list has a signed-by part. This is solved by removing the signed-by part, but sometimes (I can't seem to reproduce when) this results in another error where apt reports something like "Updates with this method cannot be made securely" and aborts the whole update process.
Even when adding the public key via gpg --keyserver keyserver.ubuntu.com --recv-key 6B219DCCD7639232 it still gives the above error message. I'm guessing this is due to the repository actually not being signed, and that it does not make a difference whether the public key is fetched. My question is, do you have a suggested way to do this securely, without apt-key?
[^1]: curl -sS  https://releases.jfrog.io/artifactory/jfrog-gpg-public/jfrog_public_gpg.key | sudo tee /usr/share/keyrings/jfrog.asc && echo "deb [signed-by=/usr/share/keyrings/jfrog.asc] https://releases.jfrog.io/artifactory/jfrog-debs xenial contrib" > /etc/apt/source.list.d/jfrog.list

I just ran into this. For me, the issue was that https://releases.jfrog.io/artifactory/jfrog-gpg-public/jfrog_public_gpg.key uses CRLF line endings. Using:
wget -qO - https://releases.jfrog.io/artifactory/jfrog-gpg-public/jfrog_public_gpg.key | tr -d '\015' | ...

makes everything work as expected.

Thanks a lot for your response @klaegera ! That does indeed seem to be the issue, and removing all \r from the file made it work perfectly for me. Awesome!
Still, while this is good work-around, the issue remains.

The scripts used to create the debian and rpm installers of jfrog-cli are managed here, in case someone would like to attempt improving them through a pull request.

@eyalbe4 this is a problem with https://releases.jfrog.io/artifactory/jfrog-gpg-public/jfrog_public_gpg.key — dos2unix needs to be run on that file. This is not something that can be fixed in https://github.com/jfrog/jfrog-cli/tree/dev/build/deb_rpm/v2-jf because the public key is not managed there.
This is a problem for anyone running Ubuntu 22.04 or later, since they will be fetching and storing https://releases.jfrog.io/artifactory/jfrog-gpg-public/jfrog_public_gpg.key on the filesystem, as this is now the correct way to install gpg keys for APT. So the downloaded key is used directly rather than processing it by gpg first. It's very non-obvious that the problem is that the key is in the wrong format.

This fixes the problem in APT: https://salsa.debian.org/apt-team/apt/-/merge_requests/309


Warning: Unable to load font 'MaterialIcons'. (and other fonts)

Describe the bug
I'm trying to use the package on a new MAUI app. Using the package even a completely blank MAUI.
Several errors are logged, the first one being
Microsoft.Maui.FontRegistrar: Warning: Unable to load font 'MaterialIcons'.

System.InvalidOperationException: Operation is not valid due to the current state of the object.
   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at WinRT.ExceptionHelpers.ThrowExceptionForHR(Int32 hr)
   at ABI.Windows.Storage.IApplicationDataStaticsMethods.get_Current(IObjectReference _obj)
   at Windows.Storage.ApplicationData.get_Current()
   at Microsoft.Maui.EmbeddedFontLoader.LoadFont(EmbeddedFont font)
   at Microsoft.Maui.FontRegistrar.LoadEmbeddedFont(String cacheKey, String filename, String alias, Stream stream)
   at Microsoft.Maui.FontRegistrar.GetFont(String font)

When trying to render the page, errors regarding the missing font are logged:
Microsoft.Maui.FontManager: Error: Error loading font 'Assets/Fonts/MaterialIcons.ttf'.

System.InvalidOperationException: This operation is not supported for a relative URI.
   at System.Uri.get_AbsolutePath()
   at Microsoft.Maui.FontManager.FindFontFamilyName(String fontFile)
Microsoft.Maui.FontManager: Error: Error loading font 'Assets/Fonts/MaterialIcons.otf'.

System.InvalidOperationException: This operation is not supported for a relative URI.
   at System.Uri.get_AbsolutePath()
   at Microsoft.Maui.FontManager.FindFontFamilyName(String fontFile)

To Reproduce

Add <PackageReference Include="AathifMahir.Maui.MauiIcons.Material" Version="2.1.5" />, which then looks like this:

<ItemGroup>
   	<PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" />
   	<PackageReference Include="Microsoft.Maui.Controls.Compatibility" Version="$(MauiVersion)" />
   	<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="8.0.0" />
   	<PackageReference Include="AathifMahir.Maui.MauiIcons.Material" Version="2.1.5" />
</ItemGroup>

Change MauiProgram.cs

		builder
			.UseMauiApp<App>()
			.UseMaterialMauiIcons()
			.ConfigureFonts(fonts =>
			{
				fonts.AddFont("OpenSans-Regular.ttf", "OpenSansRegular");
				fonts.AddFont("OpenSans-Semibold.ttf", "OpenSansSemibold");
			});

Add Icon & change code-behind to prevent XAML error

using MauiIcons.Core;

namespace Test;

public partial class MainPage : ContentPage
{
	public MainPage()
	{
		InitializeComponent();
		_ = new MauiIcon();

	}
}

<?xml version="1.0" encoding="utf-8" ?>
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:mi="http://www.aathifmahir.com/dotnet/2022/maui/icons"
             x:Class="Test.MainPage">

    <ScrollView>
        <StackLayout>
            <mi:MauiIcon Icon="{mi:Material ABC}"/>
        </StackLayout>
    </ScrollView>

</ContentPage>

Compile and run application

Expected behavior
Icon should load
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop and Smartphone (please complete the following information):

OS: Windows
Version 22H2
.NET 8.0.204
MAUI Manifest version: 8.0.7/8.0.100

Additional context
I've tried adding the ttf into the resource folder as well, without any success

Can you try adding UseMauiMaterialIcon Extension after Configure Fonts? I assume Configure Fonts Method Causing this issue

Thanks for your fast reply @AathifMahir ! I changed the order, without any success. I also tried loading/including the font myself, without any success. It seems like quite an obscure error, an internet search has not yet resulted in any solutions for me.

Thanks for your fast reply @AathifMahir ! I changed the order, without any success. I also tried loading/including the font myself, without any success. It seems like quite an obscure error, an internet search has not yet resulted in any solutions for me.

I'll try my best to reproduce this issue as soon as possible.

I'll look into that. Currently my local debugging for android is not working, because my user directory contains a space... I'll see if I can work around that.

I'll look into that. Currently my local debugging for android is not working, because my user directory contains a space... I'll see if I can work around that.
Edit: I've got it to work on Android, where the icon is displayed without issues. So it seems to be related to Windows.

The problem here, I can't reproduce this on Windows or Android or any other platforms? As far I can see from the error logs you have submitted. I assume it has to do with Maui SDK, I think something went wrong with the installation or completely something else that we are yet to diagnose

@ChrisK91 I have closed this issue since there's no activity on this,if your still facing the same issue, feel free comment on this issue for further discussion or reopening

The problem still exists, however I'm currently working around it by embedding the relevant icons as SVGs directly. It might be related to dotnet or maui itself. I'll see if one of the framework updates fixes it in the future. Thanks for your help!

The problem still exists, however I'm currently working around it by embedding the relevant icons as SVGs directly. It might be related to dotnet or maui itself. I'll see if one of the framework updates fixes it in the future. Thanks for your help!

I'm not sure, if it is related to Maui Itself. I can't seem to reproduce this issue at all with various different Maui Version.
Did you tried reinstalling Maui Workload?

I just did a complete reinstallation of the dotnet sdk and maui, without any changes. I will report back, if anything changes with a future update.

I have same issue using new version 2.2.5. When I downgraded 2.1.5, works fine. I'm using MAUI CommunityToolkit (latest version).

Are you running Windows 10? Maybe it's an issue with the Windows version.

Are you running Windows 10? Maybe it's an issue with the Windows version.

I'm on Windows 11


Linten Fails in CI

CI is currently failing https://github.com/iguessthislldo/OpenDDS-Debian/actions/runs/11396348767/job/31710020239#step:9:610 any suggestions for fixing it?

Originally posted by @mitza-oci in https://github.com/OpenDDS/OpenDDS-Debian/issues/3#issuecomment-2427346667

I would address some of the issues like spelling upstream, but a lot of these would require significant modifications in the deb build process and/or changes in OpenDDS and ACE/TAO. A lot of them also appear to be strict things that would only really be a sticking point if we were actually trying to get OpenDDS in official repos. So once the spelling was fixed, I'd either completely disable Linten or, assuming it's configurable, turn off the checks we don't care about.


Git: Separate the commit length limit of subject line and description lines

Since VS Code 1.28 we have a new git.inputValidationLength to set the commit length limit, but I think the subject line and the description lines should have different length settings, as mentioned in #56481.
This article says the subject line is preferably limited 50 characters, and the description lines are 72 characters per line. Also, GitHub web UI displays a warning message if your commit subject line is more than 50 characters.

How about something like git.subjectValidationLength and git.descriptionValidationLength?

I'd love to take a look at this if no one's working on it yet! Could anyone tell me which files I have to look at to fully integrate these settings after adding them to extensions/git/package.json?


Implemented floating save/preview buttons for engagement editing

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-498
Description of changes:
Implemented a floating behavior for the save/preview buttons during engagement editing. This feature persists across all tabs but exclusively saves data for the Engagement Content tab.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report
Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (ca06c76) 71.27% compared to head (aaba79e) 71.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
- Coverage   71.27%   71.25%   -0.02%
==========================================
  Files         509      509
  Lines       17063    17074      +11
  Branches     1288     1289       +1
==========================================
+ Hits        12161    12166       +5
- Misses       4662     4669       +7
+ Partials      240      239       -1

Flag
Coverage Δ

metweb
59.11% <69.49%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...agement/form/EngagementFormTabs/EngagementForm.tsx
86.66% <85.71%> (+7.31%)
:arrow_up:

...ormTabs/AdditionalDetails/AdditionalTabContent.tsx
87.50% <75.00%> (-12.50%)
:arrow_down:

...gementFormTabs/Settings/EngagementSettingsForm.tsx
88.23% <75.00%> (-11.77%)
:arrow_down:

...rmTabs/UserManagement/EngagementUserManagement.tsx
86.66% <66.66%> (-13.34%)
:arrow_down:

.../form/EngagementFormTabs/EngagementTabsContext.tsx
66.92% <63.33%> (-1.40%)
:arrow_down:


Sound Expanded Volume Controls Do Not Work

The volume control blocks, change volume by, specifically does not work and instead it is zero when run.
Load the extension and click the change volume by block, turn on the volume monitor

The volume control blocks, change volume by, specifically does not work and instead it is zero when run.
Load the extension and click the change volume by block, turn on the volume monitor

should be fixed now

The change volume block now works, the set volume does not work however
On Sun, 26 May 2024, 05:28 GarboMuffin, @.***> wrote:

Closed #1355 https://github.com/TurboWarp/extensions/issues/1355 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/TurboWarp/extensions/issues/1355#event-12934973363,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVBRBM2OJ7QS7OY3K4QWLTLZEFQIFAVCNFSM6AAAAABETUH2QCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHEZTIOJXGMZTMMY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Improve document

Describe what happened (or what feature you want)
Improve document, and show more usage in the documents.
Describe what you expected to happen
A clear and concise description of what you expected to happen.
How to reproduce it (as minimally and precisely as possible)
Related code
Tell us your environment

nacos-sdk-csharp version: [e.g. 1.1.0/...]
modular : [e.g. naming/config/msconfig/....]
nacos server version: [e.g. 2.0.0/....]
how to host nacos server : [e.g. docker/k8s/mse/virtual machine/...]

Anything else we need to know?

Host the document on readthedocs now.
https://nacos-sdk-csharp.readthedocs.io/en/latest/

hope the document will be enhanced. for example, the meaning of the configuration field.


🚀 - tuiDropdownAlign support for 'center'

Which @taiga-ui/* package(s) are relevant/releated to the feature request?
core, cdk
Description
The current options for tuiDropdownAlign are right and left.
Is there an easy way to center-align a dropdown relative to the host element? I tried using negative margins, however that did not quite work out. If there is no easy way an option to center the dropdown would be a nice addition.

Duplicate of https://github.com/Tinkoff/taiga-ui/issues/3704


[Feat] Allow to choose a point on the map (instead of a newsflash)

First version could be a simple interface to input X and Y coordinates
Ultimate version would be clicking on a button somewhere near the little map that will open a bigger version of the map, allowing to choose a point and click to confirm.

@atalyaalon API spec required

Figma:
https://www.figma.com/file/AJb0s5LH7Vpo9MqciMM0rY/Anyway?node-id=0%3A1


Fix missing default types in profile configs when consumed via NuGet

https://github.com/microsoft/MixedRealityToolkit-Unity/issues/4491
The current type enumeration code uses Unity's assembly CompilationPipeline.GetAssemblies, which only captures things that are going through Unity's compilation pipeline. This doesn't work well when consuming MRTK as compiled binaries - these types are obviously not part of source files at that point.

/azp run


Nabu Casa error - Remote UI unreachable

Home Assistant release with the issue:
0.103.6
Last working Home Assistant release (if known):
0.103.5
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io on Ubuntu host
Integration:
Description of problem:
After upgrading to 0.103.6 (from .5) the GUI in unreachable from its Nabu Casa URL. It is still reachable on its DuckDNS url.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
Traceback (if applicable):
Errors in log, persising after Docker restarts:
2020-01-07 19:12:41 ERROR (MainThread) [hass_nabucasa.remote] Can't handle request-connection without backend
2020-01-07 19:12:41 ERROR (MainThread) [hass_nabucasa.iot] Error handling message
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot.py", line 90, in _async_handle_handler_message
    result = await handler(self.cloud, message["payload"])
  File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot.py", line 143, in async_handle_remote_sni
    await cloud.remote.handle_connection_requests(caller_ip)
  File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/remote.py", line 216, in handle_connection_requests
    raise RemoteNotConnected()
hass_nabucasa.remote.RemoteNotConnected

Additional information:
Edit: downgrading to 0.103.5 immediately fixed this issue. Definitely seems to be related to 0.103.6 then.
Edit2: seems it's not related to 0.103.6 after all. Now on 0.103.5, after most HA restarts the remote UI is unreachable for me. Logs are below in the comments.

103.6 only made changes to the cloud integration related to Google (https://github.com/home-assistant/home-assistant/pull/30525/files). Do you have any other errors in your logs ?

I have had issues since 103 with remote ui sometimes being unavailable. It comes back at random intervals. Google working fine though. Have started using my own domain for now to see if it solves itself, but seen a couple of people in discord and the forums reporting this

@balloob No, this is a full copy-paste of the log after the last restart. The restart before that had some standard warnings about the 'dangers' of custom components (spotcast, afvalwijzer).

Same issue on 0.103.5. Just started today.
Wed Jan 08 2020 14:36:02 GMT-0500 (Eastern Standard Time) Error handling message Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot.py", line 90, in _async_handle_handler_message     result = await handler(self.cloud, message["payload"])   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot.py", line 143, in async_handle_remote_sni     await cloud.remote.handle_connection_requests(caller_ip)   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/remote.py", line 216, in handle_connection_requests     raise RemoteNotConnected() hass_nabucasa.remote.RemoteNotConnected

I need the full log of startup with debug logging. Otherwise I can't say why the backend was not setup.

My issue has changed somewhat: I do not see the nabucasa errors I mentioned in the description. But my front end is unreachable after 50% of the restarts. So I have to restart twice to get into the front-end.
home-assistant.log
Can you check this log to see what is causing the front end not to load?

Is there anything else I can do to help this along?

What I see in your log is, that the code is never called like they will not exists. Can you remove the dept folder inside config?

As i mentioned earlier i am having the same issues. I am also running Hass.io on Ubuntu, HA 0.104.3 with Hass.io supervisor v195. My custom components are HACS (0.20.9 = latest), Amazon Rekognition 103, Krisinformation 95fe9d2, Unifi Gateway v0.2.3. Have tried uninstalling them all as well as Custom header and card tools. The remote UI problems started for me after 102. Should i provide som logs as well?

If you said after restart. Do you means after restart the core or the full device?
@fillwe yes but I need only the log (debug) from hass_nabucasa. all other is not needed.

If I perform an "hassio ha restart" on CLI - not if I'm restarting the whole device.
In the mean time I upgraded to 0.104.3 and the error did not occur until now!

I also mean a restart of core HA. I also restarted the device (Ubuntu) once, but that didn't make any difference for the issue.

Hi,
I'm experiencing the same issue: after reboot the remote connection is unreachable for quite some time. I've also contacted support about this, but thusfar we haven't been able to solve it.
In my configuration Nabu Casa starts working again when I disable Amazon Polly TTS. Are more people here using that integration?

I am indeed using Amazon Polly. Will try if disabling it works for me soon.

I'm not using Amazon Polly TTS just builtin Google TTS.

For people chiming in on this issue that they also experience this, we need logs or we can't determine the issue.

Ah of course, my apologies.
Home Assistant release with the issue::  0.103.5 & 0.104.3
Operating environment (Hass.io/Docker/Windows/etc.): Hass.io on Raspberry Pi 3
I'm in touch with the Nabu Casa support team. They recommended to match my AWS server option with the Nabu Casa one, changing it from eu-west-3 to eu-central-1. This made the connection sometimes work as normal, but more often note.
Log file when remote UI is not available
Error handling message Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot.py", line 90, in _async_handle_handler_message     result = await handler(self.cloud, message["payload"])   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot.py", line 143, in async_handle_remote_sni     await cloud.remote.handle_connection_requests(caller_ip)   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/remote.py", line 216, in handle_connection_requests     raise RemoteNotConnected() hass_nabucasa.remote.RemoteNotConnected
Can't handle request-connection without backend
Log when remote UI is available
Unexpected error Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot_base.py", line 108, in connect     await self._handle_connection()   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/iot_base.py", line 147, in _handle_connection     await self.cloud.auth.async_check_token()   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/auth.py", line 145, in async_check_token     await self.cloud.run_executor(self._check_token)   File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run     result = self.fn(*self.args, **self.kwargs)   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/auth.py", line 160, in _check_token     access_token=self.cloud.access_token, refresh_token=self.cloud.refresh_token   File "/usr/local/lib/python3.7/site-packages/hass_nabucasa/auth.py", line 217, in _cognito     **kwargs,   File "/usr/local/lib/python3.7/site-packages/warrant/__init__.py", line 172, in __init__     self.client = boto3.client('cognito-idp', **boto3_client_kwargs)   File "/usr/local/lib/python3.7/site-packages/boto3/__init__.py", line 91, in client     return _get_default_session().client(*args, **kwargs)   File "/usr/local/lib/python3.7/site-packages/boto3/session.py", line 263, in client     aws_session_token=aws_session_token, config=config)   File "/usr/local/lib/python3.7/site-packages/botocore/session.py", line 827, in create_client     credentials = self.get_credentials()   File "/usr/local/lib/python3.7/site-packages/botocore/session.py", line 426, in get_credentials     'credential_provider').load_credentials()   File "/usr/local/lib/python3.7/site-packages/botocore/session.py", line 907, in get_component     del self._deferred[name] KeyError: 'credential_provider'

@MichielvanBeers
Can you (and anyone else) change the logger: integration as shown here?
  default: info
  logs:
    hass_nabucasa: debug
    snitun: debug
    homeassistant.components.cloud: debug
    homeassistant.components.cloud.iot: debug```

@cogneato
I already had my logger set to that configuration. So the log you see above, is the info that came when I changed my settings to that. Let me know if I can do anything else.

Also experience the connection problem to Remote UI. Though that that is a limitation of trial period, but looks like there is some issue.
Yesterday and day before yesterday there were power failures in my place, and after device running HA was online again it never appeared connected via nabu.casa URL. Actually when I tried to open the remote UI from HASS application on Android it suggested me to open my profile on nabu.casa and click "Connect" for Remote UI. After this the Remote UI is back online.
From my understanding it means that nabu.casa somehow knows where my local instance is running but it is not linked to nabu.casa URL after restart and should be manually re-connected.

Moved my installation from Docker on Ubuntu to vem in proxmox, have not had any issues since moving. Starting to think this is a Ubuntu host related issue

@MichielvanBeers Amazon Polly doesn't seem to be the culprit. I did several tests where Polly was disabled and enabled. Here are two logs, in both cases Amazon Polly was enabled in configuration.yaml:
home-assistant1.log - Remote UI was unreachable after restart
home-assistant2.log - Remote UI was available after restart, straight away
@cogneato These logs are with your recommended logging options. Anything I can try to help find this issue?

I am experiencing this issue as well, working on getting logs..

Here's a log for you https://pastebin.com/DmLDuxML
Let me know what else I can provide

Traced it down to https://github.com/boto/boto3/issues/1592 . It seems like it's related to having other threads also use the AWS SDK. Looks like https://github.com/boto/boto3/issues/1592#issuecomment-540825115 might be a solution.

Thanks for the update @balloob! I'm not completely sure how I can implement this fix myself though.. Could you maybe give me a pointer on if and how I can implement this fix?

We need to implement the fix in the code.

Awesome, thank you for working on a fix!

Awesome.  This has been plaguing me.  I'm really looking forward to the fix being released.  Thanks @balloob !

That is great news! Very happy to hear that there is a fix :) thanks a lot!

hello guys
i been having the same issue after a reboot nabu kasa SSL goes down. Is there a fix for this coming soon?? ill be posting log later tonight

Please create a new issue. This issue has been resolved.


Make istio_cni.enabled explicit in chart values

Please provide a description of this PR:
This PR fixes #43632, by making the option to enable the istio-cni explict in the istiod chart. The improvement is mostly UX - rather than having to scrounge around docs, a user deploying the helm chart should be able to scan values.yaml and identify all the options which change the behavior of the installation.
Given istio-cni is important enough to have its own chart, it's important enough to have a default false (so this change is backwards-compatible) entry in values.yaml.

Hi @funkypenguin. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@funkypenguin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
8699ed628903d58db157a48b62bbe94248c73b6d
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Please also add this to https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/values.yaml
You may need to also update https://github.com/istio/istio/blob/master/operator/pkg/apis/istio/v1alpha1/values_types.proto with both istio_cni.enabled and istio_cni.chained settings as well.

(thinking aloud) A proper parent Helm chart and use of nested/component-scoped charts+variables exposed at the top level would help a lot with discoverability (dunno if that's been floated previously).
Thanks for this tho, sorry it was buried.

I think this would be a really good idea. The fact that CNI is buried as is a separate chart makes it difficult for people to adopt it since it's largely an afterthought. IMO, CNI is something most people should adopt (see https://istio.io/latest/docs/ops/best-practices/security/#cni).
But we'd need to figure out a way to help migrate users away from it as well as the updating all of the documentation around it.
@howardjohn and @ericvn any thoughts? This would need a RFE to probably do this and get it approved.

This was fixed in https://github.com/istio/istio/pull/45207


Flake8 crashed!

linter-flake8:: Flake8 threw an error related to: TypeError: unorderable types: str() > int() Please check Atom's Console for more details

I have the same problem.

This message is only shown when flake8 itself has crashed!
You can see the "most recent" message in the notification, but the full stack trace is only available in the console. You need to open Atom's Developer Tools to view that.
@ibmboy19 That's odd that it's not reading your locale correctly. What OS are you on?

main.js:201 linter-flake8:: Flake8 returned an error Traceback (most recent call last):
File "c:\python3\lib\site-packages\flake8\checker.py", line 471, in run_ast_checks
ast = self.processor.build_ast()
File "c:\python3\lib\site-packages\flake8\processor.py", line 211, in build_ast
return compile(''.join(self.lines), '', 'exec', PyCF_ONLY_AST)
UnicodeEncodeError: 'utf-8' codec can't encode character '\udcae' in position 771: surrogates not allowed
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\python3\lib\runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "c:\python3\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Python3\Scripts\flake8.exe_main.py", line 9, in
File "c:\python3\lib\site-packages\flake8\main\cli.py", line 16, in main
app.run(argv)
File "c:\python3\lib\site-packages\flake8\main\application.py", line 328, in run
self._run(argv)
File "c:\python3\lib\site-packages\flake8\main\application.py", line 316, in _run
self.run_checks()
File "c:\python3\lib\site-packages\flake8\main\application.py", line 246, in run_checks
self.file_checker_manager.run()
File "c:\python3\lib\site-packages\flake8\checker.py", line 319, in run
self.run_serial()
File "c:\python3\lib\site-packages\flake8\checker.py", line 303, in run_serial
checker.run_checks()
File "c:\python3\lib\site-packages\flake8\checker.py", line 573, in run_checks
self.run_ast_checks()
File "c:\python3\lib\site-packages\flake8\checker.py", line 474, in run_ast_checks
row, column = self._extract_syntax_information(exception)
File "c:\python3\lib\site-packages\flake8\checker.py", line 441, in _extract_syntax_information
if column > 0 and token and isinstance(exception, SyntaxError):
TypeError: unorderable types: str() > int()(anonymous function) @ main.js:201
main.js:201 linter-flake8:: Flake8 returned an error Traceback (most recent call last):
File "c:\python3\lib\site-packages\flake8\checker.py", line 471, in run_ast_checks
ast = self.processor.build_ast()
File "c:\python3\lib\site-packages\flake8\processor.py", line 211, in build_ast
return compile(''.join(self.lines), '', 'exec', PyCF_ONLY_AST)
UnicodeEncodeError: 'utf-8' codec can't encode character '\udcae' in position 771: surrogates not allowed
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\python3\lib\runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "c:\python3\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Python3\Scripts\flake8.exe_main.py", line 9, in
File "c:\python3\lib\site-packages\flake8\main\cli.py", line 16, in main
app.run(argv)
File "c:\python3\lib\site-packages\flake8\main\application.py", line 328, in run
self._run(argv)
File "c:\python3\lib\site-packages\flake8\main\application.py", line 316, in _run
self.run_checks()
File "c:\python3\lib\site-packages\flake8\main\application.py", line 246, in run_checks
self.file_checker_manager.run()
File "c:\python3\lib\site-packages\flake8\checker.py", line 319, in run
self.run_serial()
File "c:\python3\lib\site-packages\flake8\checker.py", line 303, in run_serial
checker.run_checks()
File "c:\python3\lib\site-packages\flake8\checker.py", line 573, in run_checks
self.run_ast_checks()
File "c:\python3\lib\site-packages\flake8\checker.py", line 474, in run_ast_checks
row, column = self._extract_syntax_information(exception)
File "c:\python3\lib\site-packages\flake8\checker.py", line 441, in _extract_syntax_information
if column > 0 and token and isinstance(exception, SyntaxError):
TypeError: unorderable types: str() > int()(anonymous function) @ main.js:201step @ C:\Users\S1691.atom\packages\linter-flake8\lib\main.js:9_tickCallback @ internal/process/next_tick.js:103

@Arcanemagus It's under windows.
I finally figure out the problem is the lack of some dependency.

@hover-cheng Wow! That is one crazy stack trace, it looks like you have a \udcae character in your code that is causing flake8 to crash.
Are you able to share the code in question? This needs to be reported in the flake8 repository.

@Arcanemagus thank you,because the use of Chinese,so that is causing flake8 to crash.

@hover-cheng Does flake8 work in the CLI for you?

Closing due to this being an issue with flake8 and/or system configuration.

I'm getting this same error with flake8 3.3. The above poster's "lack of some dependency" is not particularly helpful...

@guillochon Did you check the console for the detailed information...?

@Arcanemagus I'm actually not sure how to do that...the key stroke listed on the web to enable the dev tools don't seem to do anything: https://discuss.atom.io/t/how-to-make-developer-tools-appear/16232

I have similar issue:
UnicodeEncodeError: 'utf-8' codec can't encode character '\udc8d' in position 1344: surrogates not allowed
I found out that the file is encoded in UTF-8 with Byte Order Mark. When I convert it to pure UTF-8 the issue disappears.

@luboss There is a known bug with the current version of flake8 that is fixed in their master but still waiting on release.
@guillochon Ctrl+Shift+I is the Windows (and Linux?) keyboard shortcut, you can always go to View -> Developer -> Toggle Developer Tools though.

#451 has more useful information, for people like me who arrive here looking

I have the problem which look similar and it's not unreadable character, because it crashes even before I type smth.

Hi,
I had a similar problem.
In my case it seems to come from a conflict between linter-flake8 and linter-spell.
Disable linter-spell solved the problem.


Update css-logical-props.json

Hi

Hi, can you describe what's being changed in this PR and why?


.csv column reassignment UI

small simplification suggestion (need only  id ← edit field)
should look like (or even on same line):

current look:

@martinjaggi @PaulMansat  I propose to slightly change the style to either 3 line arrangement or one line, which one do you prefer?

Adding another line will integrate more smoothly into the structure, for a one liner I would also change some of the parent div's (i.e. simplify overall structure)

whichever you prefer.
arrow should point from source text field to target td

closing this because it was resolved in #93


[drop-in replacement] make MCADv2 states same as MCACv1

We need states named as https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/6fb5e32f6097f3b0ed1d1f4164dd137601939062/pkg/apis/controller/v1beta1/appwrapper.go#L149 to make testing easier for drop-in replacement

Closed by #37.


How to change the IP address in Published Ports links?

Hi,
is there a way how to change the IP address in the links in Published Ports column? I am running Portainer inside docker (with Linux containers) on Windows and the IP address is <IP_ADDRESS>. When I navigate to that link, it does not connect and I have to change it to localhost and then I am connected to the docker container.
Thanks,
Karel

Hi @kfrajtak, you can update the Public IP of your endpoint in Settings, Endpoints, click on the endpoint, update the public IP and hit save.
Closing this issue, feel free to comment or ask if you're missing something.

Edit the endpoint, and put the ip you want to use for links in “public ip”
Rgds,
Neil Cresswell
On 12/07/2018, at 10:00 PM, Karel Frajtak <notifications<EMAIL_ADDRESS>wrote:
Hi,
is there a way how to change the IP address in the links in Published Ports column? I am running Portainer inside docker (with Linux containers) on Windows and the IP address is <IP_ADDRESS>. When I navigate to that link, it does not connect and I have to change it to localhost and then I am connected to the docker container.
Thanks,
Karel
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_2037&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=JIlvJJoLxreTZmdIKgmpyVaNTGXatWMmJHMdblUyR2A&s=4BHLTBgCwr6d8bju2fXzHBopAmIxc6xe2Nyyy403yEQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrleOQKub836MidNuFWzH2pvlOo3Stks5uFx5JgaJpZM4VMjtg&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=JIlvJJoLxreTZmdIKgmpyVaNTGXatWMmJHMdblUyR2A&s=ApMdqknZE3PZdxdarYTOLzFHkVlXrETPFTtVHLdQzJc&e=.


Fixed Issue #22

Add data URI pattern to validate data URIs
Updated docs with error message keys

Codecov Report

Merging #26 (d73b12e) into master (0256320) will decrease coverage by 3.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   96.37%   92.87%   -3.50%
==========================================
  Files          13        6       -7
  Lines         883      365     -518
==========================================
- Hits          851      339     -512
+ Misses         32       26       -6

Flag
Coverage Δ

unittests
92.87% <100.00%> (-3.50%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

django_api_forms/__init__.py
100.00% <100.00%> (ø)

django_api_forms/fields.py
96.79% <100.00%> (+0.47%)
:arrow_up:

django_api_forms/forms.py
86.98% <100.00%> (+1.60%)
:arrow_up:

django_api_forms/version.py
100.00% <100.00%> (ø)

tests/settings.py

tests/test_modelchoicefield.py

django_api_forms/apps.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73b3dd...d73b12e. Read the comment docs.


Implementing the library

I can't figure out where to put the lines from your tutorial. I also followed this, but when I run the app, I get the error: Android.OS.FileUriExposedException
Can anyone help?

Can you provide a sample project to reproduce the problem?


Largest & Smallest Element

@div-bargali I am new to Open Source Contribution and Hacktober Fest.
I wanted to know, that I have made this Pull Request without opening an Issue, so will it be considered for 'HacktoberFest Accepted' label?


Enable UniDic on jdeppy

This pull request allows jdeppy to handle UniDic on MeCab.
It also adds some type hints to the code.
The code has been formatted with black.

I would like to hear the author's opinion on this proposed interface change(dic_type, a new argument in JDepp class's constructor).
Thank you in advance.

These changes seem to LGTM, so I will merge this after updating README.md.
Thanks for your contribution 👏


ctrl+F find does nothing now

On Ubuntu.
Suddently stopped working. restart fixes for a while.
can type in field but then nothing.

Can you explain the problem some more? Does anything at all happen when you type in the find field? What version of vscode?

I realize my comment is pretty useless, but what I am asking is where should I be looking (logs etc) to try to get more useful information when this is happening?
I don't think there is much hope of getting anywhere without me finding a few more clues to paste.

https://github.com/microsoft/vscode/wiki/Search-Issues#missing-search-results

So here is one clear example: ctrl+f searching for "best" IN THE FILE ONLY, it find two entries and I can toggle bettween them. It does not fine "something_best". It's like it is inserting whitespace. Slash in vim mode works and it finds all the entries.
This is a pretty new bug. Not sure if an update did it.

https://developercommunity.visualstudio.com/content/problem/316778/whole-word-find-in-files.html

I don't know what that link is supposed to show, but it sounds like you have whole-word search toggled on. Check whether that middle button in the find viewlet is turned on (with a background/border color)

I restarted and it went away but it seems plausiable this is the cause. I don't think this visual tools are helpful. You can do all of this with regex or vim etc. We should strive to make all "UI" based tricks UGLY and BOLD. So anything nonstandard (click this, check that, should be RED and look broken). Visually impaired will not notice. There is a reason evevery uses vim or the other editor which I will not name.

This is customizable if you prefer something like this:

Let me know if the problem shows up again


Buy Btc from Ramp

Announcement from Ramp: Ramp Network is now available in all 50 U.S. states!
This can be something we need to  announce too as now you can buy directly in your Vault from all these new places.

Announced.


Suggestions in BaseCrowdsale.sol

I am auditing this:
https://github.com/Onther-Tech/tokyo/blob/f7007f39d1868910f0f262163416b4492be9d98b/packages/tokyo-reusable-crowdsale/audit/full-features/contracts/base/crowdsale/BaseCrowdsale.sol
I just wonder how you(@4000D) think about these suggestions.
variable name:

cap -> softCap or hardCap like data field in input json.
https://github.com/Onther-Tech/tokyo/blob/f7007f39d1868910f0f262163416b4492be9d98b/packages/tokyo-reusable-crowdsale/audit/full-features/contracts/base/crowdsale/BaseCrowdsale.sol#L31

unused parameter:

_beneficiary field not used
https://github.com/Onther-Tech/tokyo/blob/f7007f39d1868910f0f262163416b4492be9d98b/packages/tokyo-reusable-crowdsale/audit/full-features/contracts/base/crowdsale/BaseCrowdsale.sol#L150

logic:

I would like to divide buyTokens into functions buyTokens and buyTokensAndGenerateToBeneficiary. buyTokens's beneficiary is msg.sender, buyTokensAndGenerateToBeneficiary's beneficiary is address parameter(beneficiary).
https://github.com/Onther-Tech/tokyo/blob/f7007f39d1868910f0f262163416b4492be9d98b/packages/tokyo-reusable-crowdsale/audit/full-features/contracts/base/crowdsale/BaseCrowdsale.sol#L56
To make an investment explicit, do not put logic in the fallback function, just revert it.
https://github.com/Onther-Tech/tokyo/blob/f7007f39d1868910f0f262163416b4492be9d98b/packages/tokyo-reusable-crowdsale/audit/full-features/contracts/base/crowdsale/BaseCrowdsale.sol#L52
In my opinion, would not it be better to separate unimplemented functions into different contracts or interfaces?
https://github.com/Onther-Tech/tokyo/blob/f7007f39d1868910f0f262163416b4492be9d98b/packages/tokyo-reusable-crowdsale/audit/full-features/contracts/base/crowdsale/BaseCrowdsale.sol#L166

cap is hard cap of crowdsale.
goal is soft cap.


Outdated httpx version & base_url issue

Currently an oudated httpx version is used which among other things includes this bug https://github.com/encode/httpx/issues/846
Do you mind updating the dependencies? I can do a PR if everyone is ok with that.

Many thanks!


Feature/rocket booking

These are the functionalities implemented in this branch;

Rockets that have already been reserved show a "Reserved" badge and "Cancel reservation" button instead of the default "Reserve rocket" (as per design).

STATUS: APPROVED :green_circle:
Hi @Ayokunnumi1    :wave: :wave:,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Cleanly written code :white_check_mark:
App runs well and functions as expected ✅
Nicely implemented project requirement ✅
Professional repo documentation :heavy_check_mark:

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


eframe: several windows in series

Closes https://github.com/emilk/egui/issues/1918
This attempts to allow opening several eframe windows after each other (one at the time).
So far this is unsuccessful on my mac. I open one window, then click the close button. The original window stays, and a second window opens, then closes by itself. I suspect there are several things in winit that needs fixing.
Try it out with cargo run -p serial_windows

I add the following code to the start of GlowWinitApp.on_event() func, and found the second and third window receive some events which are not belong to them.
 if window_id != self.window().id() {
    println!("{event:?}");
    println!("window_id mismatch !");
    return EventResult::Wait;
}

# Running `target\debug\serial_windows.exe`
ModifiersChanged((empty))
window_id mismatch !
Focused(false)
window_id mismatch !
Destroyed
window_id mismatch !
ModifiersChanged((empty))
window_id mismatch !
Focused(false)
window_id mismatch !

Ignoring events to the wrong window seems like a good idea, so I added that. The extra call to run_return does nothing on my Mac.
Does it now work as expected on Windows?

Does it now work as expected on Windows?

Yes, it works.
https://user-images.githubusercontent.com/42370281/184650345-16c9b79b-dd99-4363-b2ff-352f4ea35bff.mp4

Well, that's nice! On Mac I get winit::event::Event::LoopDestroyed right away, and then the event loop closes. Well, perhaps I can merge this as at least a step in the right direction.


Error when installing devel branch

Master installs and can be checked fine. Devel installs but when checking the tick box to enable it the following error is displayed:

So we changed the way that the RMANTREE setting is set in the addon preferences for the devel branch.  What do you have set there?

I think we should be using the new "PrintToInfo" operator to report setup issues btw here.

Hi Brian,
I'm attaching 2 pictures of the 2 branches in blender. 01_master shows it
installs everything by default according to the installation folder, and I
guess using the environment variables it sets in windows. 02_devel is as
far as I can get with this version, I can select the zip file but as soon
as I check the tick box to enable it I get the long error I posted, so no
way to set RMANTREE  :(
I'm using the master version for now, but I was loving the things/menus
implemented in the devel version and I truly hope it becomes master soon.
Thanks a lot for supporting blender and for the time and effort you're
putting into it.
regards,
Alvaro
On Sun, Jun 26, 2016 at 6:35 PM, bsavery<EMAIL_ADDRESS>wrote:

I think we should be using the new "PrintToInfo" operator to report setup
issues btw here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/293#issuecomment-228629986,
or mute the thread
https://github.com/notifications/unsubscribe/ADpQ2hvfHNqyWnHyuHVeOw_9u8AXVwP9ks5qPwzPgaJpZM4I-WK7
.

Didn't get the attachments.

That's weird, they show up ok in sent mail. Do you mean they must be
attached at github's bug report thread?
I'm attaching them again.
Please let me know if you receive them OK this time.  :D
regards,
Alvaro
On Tue, Jun 28, 2016 at 3:07 PM, bsavery<EMAIL_ADDRESS>wrote:

Didn't get the attachments.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/293#issuecomment-229166928,
or mute the thread
https://github.com/notifications/unsubscribe/ADpQ2pTaVkfAYwvISH7R1RxkH6hftwq3ks5qQX8ZgaJpZM4I-WK7
.

Yeah I think they have to be attached on github

ughhhh sorryyyy  I was attaching them here.
On Tue, Jun 28, 2016 at 3:29 PM, bsavery<EMAIL_ADDRESS>wrote:

Yeah I think they have to be attached on github
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/293#issuecomment-229173029,
or mute the thread
https://github.com/notifications/unsubscribe/ADpQ2hyWm2ym1-VRO0Kk_ACzIMBMSUhqks5qQYRBgaJpZM4I-WK7
.

I'm working to make the error reporting better.  In the meantime what do you get in the console window?  Which you can access through Help » Toggle System Console on windows
https://wiki.blender.org/index.php/User:Fade/Doc:2.6/Manual/Interface/Window_system/Console_window

Also I updated the devel branch to at least get you to the preferences to fix the errror!


Question about hidden state in decoder

Thank you for your nice tutorial.
I just have a few questions.
class Decoder(nn.Module):
    def __init__(self, target_vocab_size, embed_dim, hidden_dim,
                 n_layers, dropout):
        super(Decoder, self).__init__()
        self.n_layers = n_layers
        self.embed = nn.Embedding(target_vocab_size, embed_dim, padding_idx=1)
        self.attention = LuongAttention(hidden_dim)
        self.gru = nn.GRU(embed_dim + hidden_dim, hidden_dim, n_layers,
                          dropout=dropout)
        self.out = nn.Linear(hidden_dim * 2, target_vocab_size)

    def forward(self, output, encoder_out, decoder_hidden):
        """
        decodes one output frame
        """
        embedded = self.embed(output)  # (1, batch, embed_dim)
        context, mask = self.attention(decoder_hidden[:-1], encoder_out)  # 1, 1, 50 (seq, batch, hidden_dim)
        rnn_output, decoder_hidden = self.gru(torch.cat([embedded, context], dim=2),
                                              decoder_hidden)
        output = self.out(torch.cat([rnn_output, context], 2))
        return output, decoder_hidden, mask

In your decoder implementation, you set the input dimension size of self.gru as embed_dim+hidden_dim and feed embedded input and context together, but I am not so sure whether this is the Luong's method in the oroginal paper.

Why you feed decoder_hidden[:-1] into the self.attention? As I understand, decoder_hidden[:-1] indexes the output except the uppermost layer right?

decoder_hidden isn't the rnn output, it's the cell state. the indexing is to select only the last gru's state. pytorch nn.GRU has a n_layers arg which lets you initialize a stacked gru. If n_layers > 1 we want to make sure we only take the state of the last layer.

Thanks for your quick answer, but if you want to use the last layer's state then why did you index like decoder_hidden[:-1]. I think it should be decoder_hidden[-1] or decoder_hidden[-1:].

You are correct, it should be decoder_hidden[-1:]. I suppose I never caught that type since I didn't test with more than two layers in the decoder. decoder_hidden[-1] probably won't work since that will remove dimensions of size 1.

Thanks! and I want to ask you one more thing. I think the concatenation of target embedding and context (rnn_output, decoder_hidden = self.gru(torch.cat([embedded, context], dim=2), decoder_hidden)) is not mentioned in the original paper. I found out many variations of these kinds of implementation. I think this becomes a kind of convention to improve the performance of NMT. However, I can't understand the motivation behind that. Some people seem to call it 'input feeding'. Could you explain it to me?

pushed a fix for the decoder mistake and updated to 4.0. let me know if everything works out if you end up training with it.
commit


make:module endless run in Step #1

My project is running on Laravel 5.2.45 and I tried coffeinated/modules  v2.2.4 as well as v3.2.5 because of problems installing v4.0.7 (see issue #254).
Installation was no problem. But when I trie to create a new module with php artisan make:module teams it reruns Step #1 again and again until I stop the process. Here a small excerpt from the console output:
*-----------------------------------------------*
|                                                           |
|          Step #1: Configure Manifest          |
|                                               |
*-----------------------------------------------*

You have provided the following manifest information:
Name:        Teams
Slug:        teams
Namespace:   Teams
Version:     1.0
Description: This is the description for the Teams module.
Author:
License:     MIT
*-----------------------------------------------*
|                                               |
|          Step #1: Configure Manifest          |
|                                               |
*-----------------------------------------------*

You have provided the following manifest information:
Name:        Teams
Slug:        teams
Namespace:   Teams
Version:     1.0
Description: This is the description for the Teams module.
Author:
License:     MIT
*-----------------------------------------------*
|                                               |
|          Step #1: Configure Manifest          |
|                                               |
*-----------------------------------------------*

You have provided the following manifest information:
Name:        Teams
Slug:        teams
Namespace:   Teams
Version:     1.0
Description: This is the description for the Teams module.
Author:
License:     MIT
......

Is there something I am doing wrong?

same as what I posted a while back: https://github.com/caffeinated/modules/issues/250

Just tired again for giggles. Steps taken:

composer clear-cache (lets make sure get new code)
composer global require "laravel/installer" (freshen our laravel)
larval new APPy
cd APPy
composer require caffeinated/modules
5.1. add classes to config
5.2 make app/Modules directory
composer dump-autoload (cause we all know this solves all of laravel's problems)
pa make:module test (pa: short cut for php artisan)
hit enter for ['no'] to continue and still get a chance to create another module

I'll take a look at this in the morning - I'm sure its a stupid bug. Sorry for the inconvenience and time this has been open for!

Wait... are you guys (@Brotzka & @illuminate3) are hitting no to the message asking to continue? That's the confirmation message asking if you'd like to actually create the module. It's asking to confirm that the information you provided is correct. Hit Y to actually create the module and the command will then exit.
Seems the message is unclear, so I can update that to make it more coherent?

Yes, I'm hitting "no" or just enter. However, I'm not even getting a module made. I can live with a bad message but no module is a let down.

Definitely will. Sorry for the confusion!


Level 8_1 Serving 2 customers at the same time

Summary

Hi everyone Im facing an error whereby after a certain point one of my server accidentally serves 2 customers at the same time. My Implementation involves calling a PENDING class after WAIT where in PENDING it checks for what position the customer is in the queue and whether the the server is available. Im thinking the issue either occurs in pending or serving but i cant really pinpoint it?
Attached is my SERVE and PENDING
Serve EXECUTE

PENDING EXECUTE

This is probably due to the fact that you're not updating your server queues for your customers properly. I encountered the same problem because the earlier levels didn't account for the queues after a Done Event. My best guess to solve this problem would be to check all your events to make sure that they are properly updating your servers, their busy status, their queues, and subsequently, the Shop state.
Hope this helps and that you manage to solve it soon!

Since your implementation revolves around checking for what position the customer is in the queue and whether the the server is available. Maybe you could check if there is an issue with ur getAvailability. Other than that I am also not sure why you would return a new Serve Event in your else statement in pending execute because it could potentially serve a customer when the server is not available. These are just my suspicions but without fully grasping your implementation it is quite hard to advice accordingly.

Hello! i had the same issue too! i think it could possibly be because youre not updating ur shop status/server status correctly.
I managed to resolve this issue by creating a shop.getCurrentServer(this.server) function in my shop (which identifies the server w same server id as this.server), to get the most recent state of the server. U also have to update the event time of ur pending class correctly. Hope this helps!

HI GUYS ive solved the issue! It lied with my rest not updating shop properly thanks all!


Allow to configure the maximum number of reconnections.

It'd be nice if one could configure the maximum number of automatic reconnections when instantiating a socket. Something like:
var socket = io(url, {maxReconnections: 5}); //The socket will automatically reconnect up to 5 times

This is indeed already in the documentation.
We are working on making the documentation better.


added russian localization

What it Does

Adds Russian localization
Discussion in #7

How I Tested

Set system language to Russian
Start app

Thank you @mikaelacaron ! 👍


Setting a cookie helps to avoid http 429 errors on the Youtube "watch?v=" page.

Seems youtube now blocks IP's very fast when requesting there "watch?v="-page. This seems NOT the case if you add a cookie to this request.
This is not a production-ready patch. I know setting a static text for the consent-date and for the global zone is far from ideal. But it works for now.

DAMN. Sent the wrong patch


Correction for PCI bus mapping in Multi LC

Ensure PCI bus index always starts from 1 even though in multi lc mode

Hi @hellt ,
I have updated the code for PCI bus mapping to cope the multi lc issue on non sequence interface.

thanks @gusman
I will try and test it as well


An error when installing the Ballerina Integrator VSCode extension

Description:
An error when installing the .vsix file in a new environment as "command ballerinaIntegrator.projectTemplates not found" is encountered. This needs to be fixed.
Affected Product Version:
Ballerina Integrator VSCode extension

This error is seen when the Ballerina Integrator extension is not installed properly. Since the Ballerina extension is added as a dependent extension, the VS Code should be kept open until both extensions are fully installed. Hence, closing this issue, re-open if the issue persists even after a successful installation.


fix to avoid "No Package matching 'python-pip'"

In order to avoid this error on RedHat family
TASK [abaez.docker : making sure pip installed] ********************************
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "failed": true, "msg": "No Package matching 'python-pip' found available, installed or updated", "rc": 0, "results": []}
       	to retry, use: --limit @ansible/playbook.retry

Hello @matiasdecarli,
Thanks for the PR. I didn't notice I was assuming EPEL was already installed. Forgot abaez.common was removed as a prerequisite. Anyway, I'll update this momentarily. I do have a specific style in setting up a curl fetch. That and lines 16:17 are not required since the whole role should be run in privilege. I'll document this better.
Thanks again for the help!

Hi @abaez . Thanks to you for this Role!
Let me know if I can help with anything else

Alright, just did the change to src install instead:
https://github.com/abaez/ansible-role-docker/commit/15f6cbfe623f3169c0ee45fe4903dd4b5fbd937b
Really. Thanks again!


Add legal disclaimer

Chore
Add legal disclaimer bullets to the Vega Wallet browser extension.
Dependent on #370
Tasks

[ ] Think about how we handle mainnet v fairground as the disclaimer is only relevant for mainnet
[ ] Work out where to place content
[ ] Develop
[ ] Test
[ ] etc.

Sketch
Current thinking is aiming towards this on the getting started page.

On the testnet version I guess we would just change to something like@:

Notes

Lets add a tick box that you have to tick before it will let you click get started
Remove the create / import cos that changes the flow.


Reduce dependencies

To make the datasource even more useful outside of Apollo, you could probably drop the actual apollo imports and just create a few types
Datasource
export interface DataSourceConfig<TContext> {
  context: TContext;
  cache: KeyValueCache;
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
export abstract class DataSource<TContext = any> {
  initialize?(config: DataSourceConfig<TContext>): void | Promise<void>;
}

Cache
export interface KeyValueCacheSetOptions {
  /**
   * Specified in **seconds**, the time-to-live (TTL) value limits the lifespan
   * of the data being stored in the cache.
   */
  ttl?: number | null;
}

export interface KeyValueCache<V = string> {
  get(key: string): Promise<V | undefined>;
  set(key: string, value: V, options?: KeyValueCacheSetOptions): Promise<void>;
  delete(key: string): Promise<boolean | void>;
}

export class InMemoryLRUCache<V = string> implements KeyValueCache<V> {
  private store: LRUCache<string, V>;

  // TODO: Define reasonable default max size of the cache
  constructor({
    maxSize = Infinity,
    sizeCalculator = defaultLengthCalculation,
    onDispose,
  }: {
    maxSize?: number;
    sizeCalculator?: (value: V, key: string) => number;
    onDispose?: (key: string, value: V) => void;
  } = {}) {
    this.store = new LRUCache({
      max: maxSize,
      length: sizeCalculator,
      dispose: onDispose,
    });
  }

  async get(key: string) {
    return this.store.get(key);
  }
  async set(key: string, value: V, options?: { ttl?: number }) {
    const maxAge = options?.ttl && options.ttl * 1000;
    this.store.set(key, value, maxAge);
  }
  async delete(key: string) {
    this.store.del(key);
  }

  // Drops all data from the cache. This should only be used by test suites ---
  // production code should never drop all data from an end user cache.
  async flush(): Promise<void> {
    this.store.reset();
  }
  async getTotalSize() {
    return this.store.length;
  }

  // This is a size calculator based on the number of bytes in a JSON
  // encoding of the stored object. It happens to be what ApolloServer
  // uses for its default DocumentStore and may be helpful to others as well.
  static jsonBytesSizeCalculator<T>(obj: T): number {
    return Buffer.byteLength(JSON.stringify(obj), 'utf8');
  }
}

function defaultLengthCalculation(item: any) {
  if (Array.isArray(item) || typeof item === 'string') {
    return item.length;
  }

  // Go with the lru-cache default "naive" size, in lieu anything better:
  //   https://github.com/isaacs/node-lru-cache/blob/a71be6cd/index.js#L17
  return 1;
}

Then just change the error line to
      throw new Error(
        'FirestoreDataSource must be created with a Firestore collection (from @google-cloud/firestore)'
      );

Of course, I used the code from Apollo for the cache. It does make me wonder that if no cache is supplied, should one be created inside the class? Or maybe it should just be a non-functional cache?
const noCache = {
  get: (key: string) => Promise.resolve(undefined),
  set: (key: string) => Promise.resolve(undefined),
  delete: (key: string) => Promise.resolve(undefined),
};

There is a good argument for making the cache very declarative.

I can see the appeal, but it would lose a lot in terms of maintainability for me. The point of depending on those packages for types is that I can easily make sure the package is compatible with apollo-server, its intended usecase, by keeping those packages up to date and being yelled at by typescript.
The package is perfectly useful without apollo as-is, from my experience, the largest issue I suppose it that it has a sub-dependency on graphql (2.7M) that bumps up the size, that comes from apollo-server-errors which, to your point, might be worth removing

You can still import the Apollo packages and use them in testing.
That would give you any fail results in the rare instance that the interface for the Apollo Datasource actually changed.
If that happened, it would be a major breaking change anyway and probably require changes to the datasource in general.
I only mention it as I'm finding a use for dataloaders in some non-graphql cases as well. Having a nice batch/cache datasource is handy even in some more standard RESTful apis. The size savings is nice too. I didn't think of that as much as just being able to use it outside of Apollo.

I've released v5.2.0 which removes the dependency on apollo-server-errors
Yes, if the underlying datasource types change in a major way this library would need a major version, that's already happened once.
I'm getting a lot of value as a maintainer by depending on the remaining apollo packages which mainly provides typings, I get a clear indication when changes are needed, I don't have to maintain a copy of the "API" that the library has a goal to adhere to, and I can "re-export" the types for better typings for dependants.
It's orders of magnitude simpler from a maintainer point of view, and at this point in time I don't have the availability to make things less practical  to maintain, especially as I don't see what would be gained.
I don't really understand your point that inlining these type definitions/using another default cache implementation would make it easier to use the datasource in non-graphql applications - I use this in several non-graphql/non-apollo projects without any issues. Am I missing some specific usecase where it creates problems?

Datasource Types
No, it won't cause problems.
But if you are building a RESTful interface or maybe a gRPC, you'll end up pulling in the npm modules for Apollo and then GraphQL and so on. It is only based on reducing npm imports.
But again, you can still use the Apollo libs in testing. If you do typescript linting/compiling it will throw a type error if the values don't align. If the interface for Datasource was more complicated, it wouldn't be worth it for sure. As it is so crazy simple...
Also, it doesn't need to be called Datasource. It could be DatasourceRef or whatever. And, it also wouldn't really need to be exported, but it is handy if you are working in an environment that is completely devoid of Apollo.
Yet again - this is just being efficient with NPM imports. Honestly, it makes no difference operationally.

Cache
The actual cache interface is also a copy from Apollo. Just not pulling in the Apollo npm modules in a project they are not needed. This is pretty much a copy/paste from the Apollo source.
export interface KeyValueCacheSetOptions {
  /**
   * Specified in **seconds**, the time-to-live (TTL) value limits the lifespan
   * of the data being stored in the cache.
   */
  ttl?: number | null;
}

export interface KeyValueCache<V = string> {
  get(key: string): Promise<V | undefined>;
  set(key: string, value: V, options?: KeyValueCacheSetOptions): Promise<void>;
  delete(key: string): Promise<boolean | void>;
}

The other stuff I put in above was the actual code Apollo uses for InMemoryLRUCache. Which, is really a default wrapper around LRUcache - but converted to async calls. Mainly this allows easier interop between async cache sources like Redis.
When I suggested using a noCache
const noCache = {
  get: (key: string) => Promise.resolve(undefined),
  set: (key: string) => Promise.resolve(undefined),
  delete: (key: string) => Promise.resolve(undefined),
};

This would then change the line in initialize to:
cache: cache ?? noCache,
This is just a choice between being declarative or not. Should an LRUcache be auto-created if a user didn't specify one? But then, what are the settings (like max size)? Could that cause debug confusion? Should a developer have to actually do the work to specify and create their cache with settings that match their project to have caching enabled at all? Or should every datasource just automatically start something that is going to take up an unknown memory footprint?
It is similar to ending your lines in semicolons or not. In the past, I've built my datasources exactly like you have where if Apollo doesn't give a cache then I just create one myself. I ran across a project where this was done all over the place and they were killing their NodeJS ram limit with a mixture of heavy load and large data payloads. Once we specified a central cache (or at least defined them declaratively) the issue went away.

To be clear though, these are just freely given ideas and they are worth exactly that. I super appreciate your contribution to the community.
I have some ideas about sub-collections as well. I expanded on the Mongo datasource to use the dataloader on complex queries instead of only ID fetches. I ended up using a hash of the query for a cache reference. I bet something similar could be done with sub-collections. Firestore is a bit more challenging as Mongo can really combine a lot in a big $or [...] wrapper.


Update patch package for http-client library

@dmitrizagidulin Has updated and published to npm the http-client and deps; re-tested needed in wallet

Npm publish forthcoming

Npm publish and Build 81 release, but will wait on https://github.com/digitalcredentials/learner-credential-wallet/issues/638 to close.

Fixed in latest npm package, closing


Add paginated index queries to foreign key backlinks

We currently do unpaginated index queries, which is a problem.

Bikeshed: Without reading code or docstrings, it isn't clear that .backlinks.foo() returns the non-paginated keys and .backlinks.foo_keys() returns paginated keys. Shouldn't we maybe make that explicit (backlinks.foo_paged() or something)?

Bikeshed: Without reading code or docstrings, it isn't clear that .backlinks.foo() returns the non-paginated keys and .backlinks.foo_keys() returns paginated keys. Shouldn't we maybe make that explicit (backlinks.foo_paged() or something)?

I want to eventually get rid of all non-paginated index results, at which point foo_paged() won't make much sense. foo_keys() already makes more sense than foos(), which implies that you get model objects rather than keys.

I want to eventually get rid of all non-paginated index results, at which point foo_paged() won't make much sense. foo_keys() already makes more sense than foos(), which implies that you get model objects rather than keys.

+1, happy with that.

:+1:

:+1: again, when travis is happy.


Add styling

Updated styling to match FSH School. Addresses task: https://standardhealthrecord.atlassian.net/browse/INT-929

Aligned the (non-code) fonts with the font on FSH School
Aligned the button styles
Made the grey backgrounds white
Renamed the “Documentation” button to “Back to School”
Included a “Powered by SUSHI v1.0.1” on TopBar

Note: this version number is hardcoded

@ngfreiter we had looked into using the SUSHI function, but we had thought that since it relies on fs functions to read the package.json, we would have trouble using it in FSH Online even if it was exported. I don't remember if @SamCitron had explicitly confirmed that, so we can do that if you think that doesn't sound right.

@ngfreiter we had looked into using the SUSHI function, but we had thought that since it relies on fs functions to read the package.json, we would have trouble using it in FSH Online even if it was exported. I don't remember if @SamCitron had explicitly confirmed that, so we can do that if you think that doesn't sound right.

Ohh, that makes sense! Hardcoded is fine then.

The SUSHI version is known at build-time.  I think we could find a way to inject it into the code during the build - so it's not hard-coded in our source, but looks hard-coded in the output.  I'm thinking we could do that as a post-build script that does a replacement in the output file or maybe use custom environment variables --maybe setting the SUSHI number programmatically as an env variable in a pre-build step...  Anyway, I'm not sure the most elegant approach, and I don't think it has to be figured out in this PR, but I suspect we can come up with something.

The SUSHI version is known at build-time. I think we could find a way to inject it into the code during the build - so it's not hard-coded in our source, but looks hard-coded in the output. I'm thinking we could do that as a post-build script that does a replacement in the output file or maybe use custom environment variables --maybe setting the SUSHI number programmatically as an env variable in a pre-build step... Anyway, I'm not sure the most elegant approach, and I don't think it has to be figured out in this PR, but I suspect we can come up with something.
EDIT: BTW, I think we could pull the SUSHI version from the [package-lock.json] (but again, this would need to be handled during build rather than during runtime).

@cmoesel I don't think I've ever done any pre- or post-build steps before, but that's certainly something to look into. We thought about using the package-lock.json but I think it would have been at runtime and we didn't know that that was the best step so had just decided to go with hardcoding it for now. If you feel like we should look into any of these options on this PR, let us know. But it's sounding like maybe it is outside the scope of this. If so, I can make a task for the backlog. What do you think?

If you feel like we should look into any of these options on this PR, let us know. But it's sounding like maybe it is outside the scope of this. If so, I can make a task for the backlog. What do you think?

Backlog it!


docs: update ansiblels homepage url

Updating the homepage for the ansible-language-server to the latest URL, as the currently stated URL points to an archived repository (whose repo description also now points to the latest URL as introduced by this change).
This can be further verified at the package's registry page here: https://www.npmjs.com/package/@ansible/ansible-language-server

Oops, I missed reading the above section in the docs 😅 . Should I revert the change under the docs folder, or let CI overwrite it?


feat: Add agones lifecycle callbacks

Linking server lifecycle events to agones SDK callbacks.

Hi @syllabix  I've rolled back this PR to the point you've branched off. Can you please check & approve? Once this is merged, you should be able to merge #14 without any conflicts.


[MRG] Bump nteract-on-jupyter to 2.0.12 and notebook to 5.7.8

Updates the packages we provide for users.

ty, @betatim


authorize() should check if cached credentials already exist

Currently, authorize() doesn't check if the user already has cached tokens (sometime in the past) and if they do, then don't show these two questions:

I think we should check for tokens in the cache folder and if it doesn't exist, then display the above questions, but if it does exist, then grab those cached tokens.

Yes. This has been a thing I keep noticing but have yet to do anything about it. Thanks for tracking it @howardbaek


Add login_url field support to InlineButton

Issue #232.
// Login represents a parameter of the inline keyboard button
// used to automatically authorize a user. Serves as a great replacement
// for the Telegram Login Widget when the user is coming from Telegram.
type Login struct {
	URL         string `json:"url"`
	Text        string `json:"forward_text,omitempty"`
	Username    string `json:"bot_username,omitempty"`
	WriteAccess bool   `json:"request_write_access,omitempty"`
}

Also I had to implement custom MarshalJSON for InlineButton and I'll explain why. InlineQueryChat must not have omitempty tag and it's very important!
There is option in Bot API to leave switch_inline_query_current_chat empty, so opened inline-mode also will be empty, or with specified, through BotFather, placeholder. omitempty flag shows that this field will be removed when it's empty. Making inline query fields as a pointer to string will break backwards compatibility.
So, I decided that it's better to leave omitempty flag only with login_url in the same time (either it's not working together). Other fields like data and url have higher priority and switch_inline_query_current_chat just skips by API.
I hope my explanations will help a bit to understand why we need all this.

Long overdue to be merged; sorry for the wait and thank you for your work.


On error, send XML response not just HTTP code

When errors are encountered, send the XML response as described here:
https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html
Currently we are only sending the HTTP code (404, 500, etc.).  This seems to be sufficient with clients but we should be sending the full xml response with more descriptive information.

I'm thinking this is 0.3.0.
@JustinKyleJames Thoughts?

makes sense.   0.2.0 for immediate needs/functionality.


fix issue with linux build failing due to missing testing

Here's a more polished and professional version of your description that would be suitable for a pull request:

Description of the Issue
On a Linux build where I use case-paths, I encountered an issue that required me to add the swift-testing dependency explicitly. While testing on macOS, I found that this did not conflict with the existing Xcode setup, but to ensure compatibility across both platforms, it seems safest to add the dependency explicitly.
This issue arose because I use swift-testing in the project, and while it enabled me to run tests on Linux, it caused the build to fail when testing code that uses case-paths. The failure occurred because case-paths could not import Testing. I had been using Testing for running tests but had not listed it as a dependency in the target that uses it.
Solution
To resolve this, I have added swift-testing as an explicit dependency for the target using case-paths. This approach ensures the tests run correctly on Linux while maintaining compatibility with macOS. Since the dependency can only be added if it’s listed in the package, I opted to remove the #if condition to avoid build failures on macOS.

By explicitly including the swift-testing dependency, this change ensures a smoother experience for both Linux and macOS builds, eliminating issues related to missing dependencies during testing.

This more polished version will help present your change more clearly when submitting a pull request. Let me know if you need any adjustments!
The build fail on linux

Hi @doozMen, I don't think we can accept this PR as-is because people using this library for Apple platforms will suddenly incur the cost of compiling macros when it's not actually needed. Also, according to this thread, Swift Testing is coming to the various Swift toolchains very soon, and so this shouldn't be necessary. In fact, it seems that the swift:nightly snapshot already has it. Can you try using that snapshot?

I'm going to close this for now, but we are happy to reconsider if there is reason to believe this is the correct way to move forward.

Ok will have to see then how to solve it. I'm using the nightly


Implement an html page for /debug/vars

This page has to include stats for:

App stats
Garbage collector

See http://gogs.io/ for an example.

Not needed anymore


Make build-deb-packages.sh runnable on docker containers without mounting /usr/src and /lib/modules

Problem:

Issue #148.
When creating gdrcopy_*.deb, dh_auto_build also does make gdrdrv. In many docker images, an error occurs because of the lack of linux kernel source.

This PR:

fixes the above problem.

Presubmit testing:

Successfully run build-deb-packages.sh on docker image nvidia/cuda:11.0-devel.
The built gdrdrv-dkms.deb is also successfully installed on the host machine (Ubuntu 18.04).

@drossetti, @lukeyeager Would be great if you could review this PR.


make the 0,0 point transparent

we should also remove the information on hovering for this point.

Point is not plotted when this is merged #175


THERE ARE NO ASSISTANT AUDIO DATA RESPONCE?

I set up a kit like introduction of v1 with rpi3b everything is ok until i run the demo, it can recognize my voice, but it only return text, no sound audio return, i flash again and use old credential that create long time ago and it's work, but when i flash again and and use a new credential: there no answer sound respond, i check the code and found that there's no data audio return when recognize. Any body have the same issue? please help me.

@phong31151812 Can you try with the latest sdcard image ? Image can be downloaded from : https://github.com/google/aiyprojects-raspbian/releases

Tested the new 2018-08-03 image on a rpi3b with v1 voicehat. Still no response from the demos. grpc demo correctly recognises commands, everything shows up on myactivity.google.com, check_audio works fine (although my recorded voice sounds very quiet). But not getting any audio responses.

@cray That's weird, when did you setup your credentials? You are right, looks the same as  googlesamples/assistant-sdk-python#274, we'll double check everything.

@dmitriykovalev I used an existing assistant.json file from a project I created when the original v1 voicekit came out with MagPi in Australia last year. I also flashed a fresh 2018-08-03 image and created a new set of Oauth2 credentials on the same project. Results the same. I have not tried to create a whole new project from scratch.

@cray-  I'm glad it's working now, thank you for the update!


Set log level to debug for backup info and collection meta

This is not a critical issue. Tested recently and found out the log size from executing the create backup command exceeds 2MB (when number of binlog files are large).
code.1
code.2
Thanks!

@ghu613 Yes, 'copy' related logs account for a large proportion. We still keep it INFO level because it helps us locate the issues when users meet some failure. It is consuming to ask open-source users change log level and retry.  We will think about it. Thanks a lot.


Propagate OpenAPI 3 'explode' field for parameter style

This PR follows on from https://github.com/Azure/perks/pull/118 to address https://github.com/Azure/autorest.modelerfour/issues/314 which reports that we don't carry along the explode field for parameters with style of form.  This change takes the new explode field on HttpParameter and populates it with whatever is provided by the incoming OpenAPI 3 spec.

I'll go ahead and merge this since it's proven to be working based on the scenario YAML file updates.


[semver:minor] Bugfix/fix yarn version issue

This is just a follow-up of the previous one so to include the correct semver tag

The purpose of this PR is to promote the changes from #42 to the production orb


[HUDI-2688][RFC-37] A new Hudi connector for Trino

Add implementation details
Update table with new rfc
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

cc: @vinothchandar @bvaradar @caneGuy @yihua

greate @codope thanks for this. i will take a look later this week!

this high level makes sense to me. @codope should we keep this open for further comments or do you plan to add more specific details around how we integrate with hive metastore, what we give up against the hive-connector and any other implementation constraints.


docs: add build validation guidance Azure DevOps

Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes

Minor updates to the wiki page for the Accelerator in regards to the build validation guidance for Azure DevOps

Breaking Changes
None
Testing Evidence
n/a
As part of this Pull Request I have

[x] Read the Contribution Guide and ensured this PR is compliant with the guide
[x] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
[x] Checked for duplicate Pull Requests
[x] Associated it with relevant GitHub Issues
[ ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[ ] Updated one or more of the following tests (if required)

Unit
Linting
E2E (End-To-End)
ValidateAzCloud (Base validation in Azure Cloud)
ValidateMcCloud (Base validation in Azure China Cloud)

[x] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
[ ] If relevant, created or updated Code Tours here

Thanks for adding this additional clarity to the documentation, @MarcoJanse!