Data analysts should be able to use Text.contains to check for substring using various matcher techniques.

Pull Request Description

Important Notes

Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the Scala, Java, and Rust style guides.
All code has been tested:

[x] Unit tests have been written where possible.
[ ] If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

Comparison of the Normalizer+Java.contains vs StringSearch implementations (full results sheet):

Test
Java Contains
ICU StringSearch

Text.contains  exact
25.3
107.8

Text.contains  case-insensitive
64
143.1

Text.contains  exact regex
188.7
184.6

Text.contains  case-insensitive regex
344.8
343.8

Text.contains  const-width regex
419.4
497.2

Text.contains  wildcard regex
119.4
114.4

Only first two rows are relevant - Regex implementation did not change, so any differences there are only due to measurement uncertainty.
We can see that unfortunately StringSearch is 2-4x slower. I don't think we can get a better solution which will handle the edge cases correctly though - unlikely that we can get something both correct and at the same faster than the ICU implementation. Also a significant part of this cost is likely due to the additional logic needed to correctly handle the edge cases - which is just unavoidable if we want this (simply - more complex) behaviour.


Cannot read properties of undefined (reading 'toString')

The extension cannot connect to synapse fabric environment and it says the following error:
Cannot read properties of undefined (reading 'toString')

Sorry for the delay. The issue has been fixed in the latest version of extension. Please feel free to try to see if it happen again.


Fix applications.get to use query

Codecov Report

Merging #267 into beta will increase coverage by 0.54%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##             beta     #267      +/-   ##
==========================================
+ Coverage   65.92%   66.47%   +0.54%
==========================================
  Files          30       30
  Lines        1033     1035       +2
==========================================
+ Hits          681      688       +7
+ Misses        352      347       -5

Impacted Files
Coverage Δ

src/App.js
44.26% <75%> (+10.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5dd47...b70e6ef. Read the comment docs.


v7 npm package is way too big

It looks like something is incorrectly getting packaged up now, there's no way the distribution should be 500MB / ~5.6k files.
https://www.npmjs.com/package/evergreen-ui?activeTab=versions

It looks like the V7 pre-release package is also the same size:
https://www.npmjs.com/package/evergreen-ui/v/7.0.0
https://www.npmjs.com/package/evergreen-ui/v/7.0.0-0

Alright, looks like npm pack --dry-run and yarn pack --dry-run work a little differently. npm pack --dry-run was showing the correct size / file listing...
➜  evergreen git:(master) ✗ npm pack && ls -l evergreen-ui-7.0.0.tgz
npm notice === Tarball Details ===
npm notice name:          evergreen-ui
npm notice version:       7.0.0
npm notice filename:      evergreen-ui-7.0.0.tgz
npm notice package size:  1.2 MB
npm notice unpacked size: 6.6 MB
npm notice shasum:        e792bac5e2028cc61286040bcd3ba04f2172cd04
npm notice integrity:     sha512-SLUpPAixFVnqk[...]D5yHn2zBCFbPQ==
npm notice total files:   1764
npm notice
evergreen-ui-7.0.0.tgz
-rw-r--r--  1 Brandon  staff  1203132 Jan 17 20:35 evergreen-ui-7.0.0.tgz

However, yarn pack --dry-run generates a much different tarball:
➜  evergreen git:(master) yarn pack --dry-run
yarn pack v1.22.17
success Wrote tarball to "/Users/Brandon/oss/fork/evergreen/evergreen-ui-v7.0.0.tgz".
✨  Done in 10.16s.
➜  evergreen git:(master) ✗ ls -l evergreen-ui-v7.0.0.tgz
-rw-r--r--  1 Brandon  staff  81265232 Jan 17 20:32 evergreen-ui-v7.0.0.tgz

The .tgz generated by yarn is almost 81 MB, while the npm generated by npm is the expected size - 1.2 MB. I think this change is from the addition of the !**/*.test.js and !**/*.stories.js lines in package.json > files
This was certainly not the intended effect, so I'll open up a PR to remove those!

Related: probably need to look into https://github.com/ai/size-limit/ and updating our configuration to catch something like this in the future 😓


catt will break with next pychromecast release

Upstream has removed get_chromecast from pychromecast, see https://github.com/balloob/pychromecast/commit/dac71620f6faa22a2da79a2432eb9126f30292e1.
So we need to either freeze the pychromecast requirement or implement auto-discovery filtering ourselves. I can do a PR for either, if you are interrested.

Hmm, how does filtering work now? Does it return all Chromecasts and you select one? If so, that would be pretty easy to add, no? That would probably be my preference.

There is only get_chromecasts left, so no filtering.

Ah, right. Filtering should just be a one-liner though, no? I don't have multiple Chromecasts, so I'm not familiar with how filtering worked, I'm afraid.

I'll work something out

This should be resolved with #11, right?

Yep

I'm reopening this, as pychromecast 0.8.0 is out, and catt is no longer working properly. The new issue is not related to what we already discussed (get_chromecast), but rather with how play_media now works internally.
Please see https://github.com/balloob/pychromecast/issues/151.
The problem with block_until_active() is that it is implemented in such a way, that it is blocking until media_controller is actually playing something. That means we can't use it in CastController.init. And as described in the pychromecast issue, this method call is now needed to make play_media work properly.
I'll discuss this with the pychromecast people. In the meantime I can make a PR with a freeze on requirements, if you like.

We could also just hotfix it, and just add self.cast.media_controller.block_until_active() to CastController.play_media. That seems to work ok, but not super-reliably.
And besides, I never liked the time.sleep(0.2) in CastController.init. There should be a way of making shure everything is ready, without waiting an arbitrary amount of time.

Hmm, I think a freeze on the requirements will be better for now, until we can figure out how to fix the problem for good, thank you.


Find model by hash

I have downloaded a model which can no longer be found.
I know the hash is 5af5443c09e4, how can I find that again?
It's dolphin2.1-mistral:latest, but I don't know what latest actually means, it could be many versions over time.
Can I recover other tags on that build?

$ cat manifests/registry.ollama.ai/library/llama3.1/latest | jq .layers.'[]'.digest
"sha256:8eeb52dfb3bb9aefdf9d1ef24b3bdbcfbe82238798c4b918278320b6fcef18fe"
"sha256:948af2743fc78a328dcb3b0f5a31b3d75f415840fdb699e8b1235978392ecf85"
"sha256:0ba8f0e314b4264dfd19df045cde9d4c394a52474bf92ed6a3de22a4ca31a177"
"sha256:56bb8bd477a519ffa694fc449c2413c6f0e1d3b1c88fa7e3c9d88d3ae49d4dcb"

$ du -hs blobs/sha256-8eeb52dfb3bb9aefdf9d1ef24b3bdbcfbe82238798c4b918278320b6fcef18fe
4,4G    blobs/sha256-8eeb52dfb3bb9aefdf9d1ef24b3bdbcfbe82238798c4b918278320b6fcef18fe


Lane height bug rcdexta/react trello#184 sambokai

Related issue: https://github.com/rcdexta/react-trello/issues/184

The dist folder will not be checked into this repo and built in the CI and pushed to npm. So, will get rid of it. Thanks

@rcdexta Oops. I had left that in master for my own use.


Add barcode support

Thanks for the useful library! It was great to not have to reinvent the wheel in our implementation. This pull request adds support for barcode reading to the library, which was a feature we needed.
Cheers,
Theo

@theopolisme Thanks Theo! Took me a long time to get this all working. Really cool to see someone using this library :) Thanks for submitting your code. I'll merge it :)


feat: include screenshot for emails + sms notifications

Description

Includes screenshot for SMS + Email notifications

Testing

New dependencies

Awesome work! Thanks 😄


[Feature] As a release author, I want bosh create-job to create a scaffold with BPM, such that I can easily follow best pratices for my new releases

The old-style shellscript copypasta should no longer be encouraged. Documentation at https://bosh.io/docs/create-release/ could stay the same in most parts, we probably just need to remove the references to the startup scripts.
Wdyt?

cc @jfmyers9 @xoebus @aramprice - I think this and related release author UX goals may have been discussed a bit before.

Given BPM does not support Windows, this UX wouldn't make much sense for Windows releases. bosh create-job doesn't currently take an OS -- and I wouldn't want to complicate the process too much.

At one point someone suggested having a --adapter bpm flag or something to generate-job which would be a bit more opinionated in one direction or another.
The issues I see with this approach is that I'm not sure what the other values to --adapter could possibly be. I'm also not 100% how much value is added. In some ways it may just be better to have explicit documentation in the create-release docs.

@mhoran I think I'm missing some context from the discussion that @dpb587-pivotal is alluding to in his comment. Therefore, I'm looking at this from the current point-of-view:

we have documentation how to create a release for linux: https://bosh.io/docs/create-release/

this uses templating with bosh generate-job and contains shell scripts which people copy-paste into their own releases

we have delta documentation for what's different when creating a release for windows: https://bosh.io/docs/windows/#releases

Not sure if your discussion focused around getting rid of the windows delta documentation, for example, but as long as we have this: Why don't we change the linux documentation and generators to make it easier for people to do the right thing? I don't think the situation for windows release would change much or even at all.


force decompress textures when building arrays in compatibility

Fixes crashes, and removes the requirement to manually re-import textures for compatibility mode.
When the arrays are built, if in compatibility and the texture format is compressed, decompress before building the array that is sent to generated_texture.create()
Deprecated in 4.4 (hopefully)

Great, thank you!


[Bug] Wrong Discord message on start after automatic_update

The discord webhook sends two Stop messages and no start message after automatic restart due to automatic_update=1.
The second message says "Stop Successful" which  leads me to believe it is supposed to say "Start Successful".

Moving this over to discussions with the other questions/bugs (#61)


Add rule to check cmdlet compatibility

Resolves #605

This change is

:shipit:

@bmanikm Thanks!


Add Contrib dir to RDPaths

Ensure RDContribDir is still available if RDConfig falls back to RDPaths.py
#1024 originally added RDContribDir, but not if neither RDBASE or CONDA_DEFAULT_ENV are set.

Thanks!


HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

In concat RPC, it will call FSDirConcatOp::verifySrcFiles() to check the source files. In this function, it would make permission check for srcs. Whether do the permission check should be decided by dfs.permissions.enabled configuration. And the 'pc' parameter is always not null.
// permission check for srcs if (pc != null) {   fsd.checkPathAccess(pc, iip, FsAction.READ); // read the file   fsd.checkParentAccess(pc, iip, FsAction.WRITE); // for delete }

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 35s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 37s

trunk passed

+1 :green_heart:
shadedclient
26m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 23s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 30s

the patch passed

+1 :green_heart:
shadedclient
26m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
218m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

338m  6s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 62a547ee9b45 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5ff358ca067fe556aac691af44fbe1282d9bb608

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/1/testReport/

Max. process+thread count
2153 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao Ok, I have add  the NPE check. Thanks for your review.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
34m 56s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
1m 19s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
25m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
25m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
224m 21s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

348m 43s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f869479f92f9 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d0130a25759590bcc249948fa3a7bb8f00c415a0

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/2/testReport/

Max. process+thread count
2277 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao OK, I have add the unit test.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m  3s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  9s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 18s

trunk passed

+1 :green_heart:
javadoc
3m  9s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
25m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 30 unchanged - 0 fixed = 33 total (was 30)

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
25m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
229m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

343m 23s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.server.namenode.TestHDFSConcat

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5c448bc655e3 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c4acd1c0e057b6a39122ecfc7681f6c73809e1d5

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/3/testReport/

Max. process+thread count
2242 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 54s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  9s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
26m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  3s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  3s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 30 unchanged - 0 fixed = 33 total (was 30)

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
25m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
233m 49s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

343m 43s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.server.namenode.TestHDFSConcat

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5a2e8d98fbe2 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d9f10cffa7c71e3066c58c38765aa5559f2d44a7

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/4/testReport/

Max. process+thread count
2250 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
30m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 27s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 10s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
26m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
26m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
233m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

381m  1s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestHDFSConcat

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ee6885c539ec 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 97b2d4c0a06334de883941249471740afbbb155d

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/5/testReport/

Max. process+thread count
2301 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 20s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  9s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 19s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
26m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
25m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
227m 57s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

338m  8s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2cb14013a8a8 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 47dc50f549dc86139e1c34f9760fda6f2644e35a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/6/testReport/

Max. process+thread count
2448 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 26s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 19s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
25m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 16s

the patch passed

+1 :green_heart:
shadedclient
25m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
223m 11s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

333m 24s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 09b6198660b6 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0a42c2af4e2361ac9914e4e3197ffc79722b2eb8

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/7/testReport/

Max. process+thread count
2237 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
43m 34s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 18s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
25m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
25m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
230m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

347m 45s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux aa640bcd0d3b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 63ddfef1d90230add6dc3438e98788e4e4d4b1d0

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/8/testReport/

Max. process+thread count
2013 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Try to improve it as following, JFYI.
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
index ea5ac38aa86..bc6b66af446 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
@@ -121,7 +121,7 @@ private static INodeFile[] verifySrcFiles(FSDirectory fsd, String[] srcs,
     for(String src : srcs) {
       final INodesInPath iip = fsd.resolvePath(pc, src, DirOp.WRITE);
       // permission check for srcs
-      if (pc != null) {
+      if (pc != null && fsd.isPermissionEnabled()) {
         fsd.checkPathAccess(pc, iip, FsAction.READ); // read the file
         fsd.checkParentAccess(pc, iip, FsAction.WRITE); // for delete
       }
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
index 1608a84168d..c08c2adce9f 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
@@ -27,6 +27,8 @@

 import java.io.IOException;

+import org.apache.hadoop.fs.permission.FsPermission;
+import org.apache.hadoop.security.AccessControlException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.apache.hadoop.conf.Configuration;
@@ -564,4 +566,56 @@ public void testConcatOnSameFile() throws Exception {

     assertEquals(1, dfs.getContentSummary(new Path(dir)).getFileCount());
   }
-}
+
+  /**
+   * Test permission of Concat operation.
+   */
+  @Test
+  public void testConcatPermissions() throws IOException {
+    String testPathDir = "/dir";
+    Path dir = new Path(testPathDir);
+    dfs.mkdirs(dir);
+    dfs.setPermission(dir, new FsPermission((short)0777));
+
+    Path dst = new Path(testPathDir, "dst");
+    Path src = new Path(testPathDir, "src");
+    DFSTestUtil.createFile(dfs, dst, blockSize, REPL_FACTOR, 1);
+
+    // Create a user who is not the owner of the file and try concat operation.
+    final UserGroupInformation user
+        = UserGroupInformation.createUserForTesting(
+            "theDoctor", new String[]{"group"});
+    DistributedFileSystem dfs2 =
+        (DistributedFileSystem)DFSTestUtil.getFileSystemAs(user, conf);
+
+    // Test 1: User is not the owner of the file and has src & dst permission.
+    DFSTestUtil.createFile(dfs, src, blockSize, REPL_FACTOR, 1);
+    dfs.setPermission(dst, new FsPermission((short)0777));
+    dfs.setPermission(src, new FsPermission((short)0777));
+    try {
+      dfs2.concat(dst, new Path[]{src});
+    } catch (AccessControlException ace) {
+      fail("Got unexpected exception.");
+    }
+
+    // Test 2: User is not the owner of the file and has only dst permission.
+    DFSTestUtil.createFile(dfs, src, blockSize, REPL_FACTOR, 1);
+    dfs.setPermission(dst, new FsPermission((short)0777));
+    dfs.setPermission(src, new FsPermission((short)0700));
+    try {
+      dfs2.concat(dst, new Path[]{src});
+      fail("Get unexpected exception.");
+    } catch (AccessControlException ace) {
+    }
+
+    // Test 3: User is not the owner of the file and has only src permission.
+    DFSTestUtil.createFile(dfs, src, blockSize, REPL_FACTOR, 1);
+    dfs.setPermission(dst, new FsPermission((short)0700));
+    dfs.setPermission(src, new FsPermission((short)0777));
+    try {
+      dfs2.concat(dst, new Path[] {src});
+      fail("Get unexpected exception.");
+    } catch (AccessControlException ace) {
+    }
+  }
+}

@Hexiaoqiao Ok, I would follow your suggest. But I also have a problem that I think we should test the two case:

Set dfs.permissions.enabled to true, with wrong user to concat, it would throw exception.
Set dfs.permissions.enabled to false, with wrong user to concat, it would not throw exception.
I think these cases would reproduce this PR's effect. Please help clarify my question, thank you.

Set dfs.permissions.enabled to false, with the same wrong user to concat, it would not check permission and don't throw exception.

I don't think it is necessary. But it will be better if have them. Please feel free if you prefer to do that.

@Hexiaoqiao OK, I add both UT in TestHDFSConcat.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 12s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 17s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 30s

trunk passed

+1 :green_heart:
shadedclient
25m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  2s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
25m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
221m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

333m 47s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 63ce00f5e03f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 73950aefda8793c4b2a09487f2e44d13d7e244cd

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/9/testReport/

Max. process+thread count
2580 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 58s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  9s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 18s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 23s

trunk passed

+1 :green_heart:
shadedclient
25m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
25m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
221m 15s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

334m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 52d023eabc87 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dca2148c3e8deacd610962a90525147bfa112ae4

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/10/testReport/

Max. process+thread count
2148 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m  8s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 17s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
26m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
25m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
222m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

333m 11s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5561

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ee7c4330d8f8 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a9dff007b549338e1751d35f59542bf1aefda462

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/11/testReport/

Max. process+thread count
2040 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5561/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Add implicit frustration demo

Can you share a dataset that we can replay and eventually run your analysis ?
fnames = [
    "../exp_data/20220525-120400-S1-Acq2.hdf5",
    "../exp_data/20220525-125204-S2-Acq2.hdf5",
]


fix blocking Depth() call on the closed queue

Looks like a fixup for #11, thanks.

In what program did you observe this problem, btw? Was it nsqd or something else?

I'm using this package in my program to have disk backed channels.
I think the depth method would be better if it returns the real value from the metadata file when the queue is closed. Maybe the last value of the depth before the queue closing can also be used.

Yeah ... maybe something like this, in addition to your fix, would be sufficient:
--- a/diskqueue.go
+++ b/diskqueue.go
@@ -138,7 +138,12 @@ func New(name string, dataPath string, maxBytesPerFile int64,

 // Depth returns the depth of the queue
 func (d *diskQueue) Depth() int64 {
-       return <-d.depthChan
+       depth, ok := <-d.depthChan
+       if !ok {
+               // ioLoop exited
+               depth = d.depth
+       }
+       return depth
 }

That was my first attempt too. I prefer this if it's also ok for you.

Yeah that seems fine to me. You want to add that bit to this PR?


Binary doesn't works on Debian 8

Hi,
I had to clone the repo and build it on Debian to make it work. The binary given in the Readme seems to be compatible for OSX only.
Regards,
Halfman.

I've pushed a new binary for Linux and updated the readme.
I'll leave this open because the build/distribution process is not ideal at the moment.

Added new linux binary in f5a46d12cd07f86a8f9baaea0f678f71c5a73482, and added instructions for installation on linux in 581d4fadf5c470c157c4d67c624fefa0692e2f46


malloc free lob parser

For embedded micro-controllers it would be better to have a lob parser that doesn't need malloc etc.

I definitely agree, I personally haven't had to face this yet but I'll be getting there soon.
My rough plan was just to initialize a static lob-buffer to work from and enforce some max constants, if you have a more specific/restrictive environment then I'd love to accommodate that too, suggestions welcome :)

I was thinking alongside something like your js0n JSON parser.
So work with a static allocated buffer and form there just return pointers to the underlying raw string.
I'm not sure if this is to simplistic as an approach and how this would work in the real world.

I need to do an audit of all lob_* calls for memory management in general soon, so I might end up adding something like this even sooner depending on what I learn in that process.

Some embedded libraries do support malloc. It's in avr-libc and in things like newlib. I don't think it's unreasonable to have a malloc implementation.
Now, there's the advantage of determinism w/o malloc. But before you go and rip them out I would recommend thinking about whether you are anti-malloc for the right reasons.

Yep, my goal isn't to rip out malloc, but to identify what parts of the code depend on mutable vs. immutable packets.  I'm more concerned about being able to have very managed buffers for embedded, to know where to let it flex and how far, and it's all a bit murky right now w/ lob_t being used a lot.

all my experience so far is that anywhere embedded that telehash fits into has a malloc that is smarter than we would try to be...


Adjust the owners structure in the parent records' access field

From https://github.com/inveniosoftware/invenio-records-resources/pull/296
We should probably adjust the owners structure in the parent records' access field (https://github.com/inveniosoftware/invenio-rdm-records/blob/master/invenio_rdm_records/records/systemfields/access/owners.py) to use the newly created mechanisms

Closing as it's similar to #523, and will be revisited once we look into sharing a record


Added frameworks, corrected blockchains and added tools

Sorry I added many suggestions in one pull request but otherways it takes too long in this fast paced times :)

✖  12:3   ToC missing item for "Tools"                            remark-lint:awesome-toc
✖  47:29  List item description must end with proper punctuation  remark-lint:awesome-list-item
✖  48:34  List item description must end with proper punctuation  remark-lint:awesome-list-item
✖  79:50  List item description must end with proper punctuation  remark-lint:awesome-list-item
✖  83:36  List item description must end with proper punctuation  remark-lint:awesome-list-item

What does this mean? :ToC missing item for "Tools"

ToC = Table of Contents
You just need to add the section in Contents


[Backport 1.2] Upgrade to log4j 2.15.0

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Overall test timeout was reached:
org.opensearch.plugins.InstallPluginCommandTests > classMethod FAILED
    java.lang.Exception: Suite timeout exceeded (>= 1200000 msec).
        at __randomizedtesting.SeedInfo.seed([D1E872A9E86A5199]:0)

Individual failed test succeeds on retry.

start gradle check

start gradle check

@dblock looks like DCO check is not backported to 1.2

@dblock looks like DCO check is not backported to 1.2

Did something slip through?


[Q] Allow a custom block to retrieve data to render via an injected getter function

This is a general question regarding plugin architecture and the dos/don'ts. Should the content block rendered by a plugin only ever user entity meta data to render its content? It seems logical to do so, but what if we have a list of items from which a user can select and that list of items can be modified. If an entity would store that information, it would become stale. In such a case I feel that using a getter injected via props to retrieve the up-to-date data for a certain id is legit, but I'd like to hear what others think about this.

You should feel free to pass through any props you need to your custom block component -- it does not have to be restricted purely to entity data.
One point worth noting: if your custom block should re-render independently of other content changes, you may want to use internal state or a subscription on your custom block to trigger this independent re-rendering.


tweak "non-Red Hat user" language

change "non-Red Hat user" language to "non-Red Hat SRE". Clusters can be owned by Red Hatters, so sometimes it is a Red Hat user making a manual change. When a Red Hatter gets this SL, it makes them anxious they've been hacked.
/assign @csheremeta @fahlmant

/lgtm


goolge-maps always ask to share location

I don't know if it is a defect. Is there a way to configure anguar-google-maps not to ask user share his location?

Please specify center="0,0" if you don't mind. If center is not given, ngmap does not know how to set center, and ngmap try to find your location and set the center.

I am using center variable to bind it from controller.
It shows me correct positioning but also ask for location in case center = "49,31"
map ng-if="filtered" style="height: 500px;" zoom="{{ zoom }}" center="{{ center }}">

then the center is not set when the controller starts, using ajax i guess.
$scope.center="0,0"

center is set correctly, in other case map wall be not positioned.
Please take a look at my video.
https://drive.google.com/file/d/0B9p7S1WlVmbnaW1vdS1vd0hHYzA/view?usp=sharing
2015-02-12 10:54 GMT-06:00 Allen Kim<EMAIL_ADDRESS>
then the center is not set when the controller starts, using ajax i guess.
$scope.center="0,0"
—
Reply to this email directly or view it on GitHub
https://github.com/allenhwkim/angularjs-google-maps/issues/145#issuecomment-74107027
.

console.log('$scope.center', $scope.center) at the end of your controller.

[image: Встроенное изображение 1]
2015-02-12 11:04 GMT-06:00 Allen Kim<EMAIL_ADDRESS>
console.log('$scope.center', $scope.center) at the end of your controller.
—
Reply to this email directly or view it on GitHub
https://github.com/allenhwkim/angularjs-google-maps/issues/145#issuecomment-74109094
.

[image: Встроенное изображение 1] ?
I can't go on like this. Please provide me a full working example by plnkr or jsfiddle

I will make it.

Closing By Inactivity


Using the Javascript URL API, modify the API requests to use URL objects instead of URL strings as argument for the fetch method calls.

The URL object maybe defined in a special script, as urls.js.


Ensure that environment variables are not shown in the UI

Input environment variables necessary to bootstrap atlantis shouldn't be exposed in the Google Cloud UI as these values contain sensitive information.
Preferably populate an atlantis.env that contains the data passed down to var.env_vars and using envFile in the container spec persist these environment variables into the atlantis container.

As this is technically not possible* without bringing your own image, I've documented an example with very detailed reference code on how to secure your environment variables.
*we could write systemd services and bypass the kontlet-startup service but I rather not go down that route.


Update cargo lock file

Major change being updating tokio to latest version to 1.24 which has CPU performance improvements

Dependabot should take care of this I think pretty soon?

But you're faster, so let's do this!

I think it hasn't been picked up yet because of how the cargo.toml defines tokio. It's not a specific version

Huh well it should be able to upgrade freely then


Add HOMEBREW_BOOTSNAP to optionally use Bootsnap

Bootsnap is a library that plugs into Ruby, with optional support for ActiveSupport and YAML, to optimize and cache expensive computations.
https://github.com/Shopify/bootsnap

For our case that translates to "repeated calls to brew have
reductions in the time spend requireing speeding up the process
boot time".
For example:
$ hyperfine --warmup=2 "unset HOMEBREW_BOOTSNAP; brew info wget" "export HOMEBREW_BOOTSNAP=1; brew info wget"
Benchmark #1: unset HOMEBREW_BOOTSNAP; brew info wget
  Time (mean ± σ):      2.417 s ±  0.032 s    [User: 659.0 ms, System: 855.5 ms]
  Range (min … max):    2.382 s …  2.464 s    10 runs

Benchmark #2: export HOMEBREW_BOOTSNAP=1; brew info wget
  Time (mean ± σ):      1.862 s ±  0.064 s    [User: 425.3 ms, System: 566.8 ms]
  Range (min … max):    1.736 s …  1.952 s    10 runs

Summary
  'export HOMEBREW_BOOTSNAP=1; brew info wget' ran
    1.30 ± 0.05 times faster than 'unset HOMEBREW_BOOTSNAP; brew info wget'

Review period will end on 2021-01-21 at 14:02:47 UTC.

Review period will end on 2021-01-21 at 14:02:47 UTC.

Is there a plan to eventually ship this by default to maintainers (or even normal users) rather than having to know about an envvar?

@issyl0 Yes, my thinking is we ship this as-is, encourage maintainers to test out the env and eventually it becomes default.

Is there a plan to eventually ship this by default to maintainers (or even normal users) rather than having to know about an envvar?

@issyl0 Yes, my thinking is we ship this as-is, encourage maintainers to test out the env and eventually it becomes default.

Review period ended.

Review period ended.


Exercise 6.04 fails at the last command

While running your script (works well) however at the last line [12]
creating the dropdown interaction and building the plot
based on selection
@interact(Stock=stock_names)
def get_stock_for(Stock='AAPL'):
stock = dataset[dataset['symbol'] == Stock][:25]
show(get_plot(stock))
I am getting the following error
AttributeError: unexpected attribute 'legend_label' to Line, possible attributes are js_event_callbacks, js_property_callbacks, line_alpha, line_cap, line_color, line_dash, line_dash_offset, line_join, line_width, name, subscribed_events, tags, x or y
I am using MacOS Mojave and Python 3.7.4
Thank you,
CA

@cesar-acosta Sorry for the late reply and thank you for reaching out.
This seems to be a problem with the version of Bokeh you're using.
For the activities and exercises, we've used version 1.4.
Could you please upgrade your bokeh version to the latest version
You can use
pip install bokeh --upgrade

You can check the version by using
pip freeze|grep bokeh

Hope that helps 😊


[CINFRA] Handle leader resignation gracefully

Scope & Purpose
Before committing a transaction locally, all replicated log leaders involved in that transaction must replicate the CommitOperation marker. If all of them fail to do so, then there's no reason to panic. The transaction is going to be aborted and none of the servers had any chance to get out of sync. This is a special case where it is actually ok for the commit to fail.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Red test related to environment issue.


Add support for bin protocol parsing (kaitai)

It would be easy to create something that parses and let's the user visualize the binary format presented like ide.kaitai.io
The harder part would be to make it useful and editable. Binary protocols often have length and checksums all over the place, which aren't obviously editable even with kaitai.
But even if this wasn't possible to edit easily, it might be something nice to present to users for binary formats like protobuffs as well as for some media elements.
This is more useful probably for responses than for requests, unless we add a mime envelope parser, as file uploads are often encoded like that. That said, it does happen that some websites generate binary protobuff on the client.

https://github.com/kaitai-io/kaitai_struct_typescript_runtime

https://github.com/kaitai-io/kaitai_struct_typescript_runtime

https://doc.kaitai.io/lang_javascript.html might be better, although looking at the API, it seems like the offsets arent exposed in the API, only the parsed objects.. this means it might be hard to associate the offset at which a specific field is located.
https://github.com/kaitai-io/kaitai_struct_webide/tree/master/src/worker

https://doc.kaitai.io/lang_javascript.html might be better, although looking at the API, it seems like the offsets arent exposed in the API, only the parsed objects.. this means it might be hard to associate the offset at which a specific field is located.
https://github.com/kaitai-io/kaitai_struct_webide/tree/master/src/worker

hmm object offsets seem to be exposed via _byteOffset in a somewhat hacky way https://github.com/kaitai-io/kaitai_struct_javascript_runtime/blob/master/KaitaiStream.js
but even then
  function Elf(_io, _parent, _root) {
    this._io = _io;
    this._parent = _parent;
    this._root = _root || this;

    this._read();
  }
  Elf.prototype._read = function() {
    this.magic = this._io.readBytes(4);

And the primitives byte offsets are exposed via Uint8Array native byteOffset property.

hmm object offsets seem to be exposed via _byteOffset in a somewhat hacky way https://github.com/kaitai-io/kaitai_struct_javascript_runtime/blob/master/KaitaiStream.js
but even then
  function Elf(_io, _parent, _root) {
    this._io = _io;
    this._parent = _parent;
    this._root = _root || this;

    this._read();
  }
  Elf.prototype._read = function() {
    this.magic = this._io.readBytes(4);

And the primitives byte offsets are exposed via Uint8Array native byteOffset property.

so, it might be possible to just iterate over all defined properties of an object, get their byteOffset (and byteLength) if they are Array views, and get _byteOffset otherwise.

so, it might be possible to just iterate over all defined properties of an object, get their byteOffset (and byteLength) if they are Array views, and get _byteOffset otherwise.

from the example in http://doc.kaitai.io/lang_javascript.html:
> parsedElf._io.byteOffset
0
> parsedElf.magic
Uint8Array [ 127, 69, 76, 70 ]
> parsedElf.magic.byteOffset
0
> parsedElf.header.flags
Uint8Array [ 0, 0, 0, 0 ]
> parsedElf.header.flags.byteOffset
48

seems to work at least for things that are arrays, but it does not seem to work for things that are returned as primitives
> parsedElf.header.machine._io
undefined
> parsedElf.header.machine.byteOffset
undefined

it's unclear how the webide gets this information

from the example in http://doc.kaitai.io/lang_javascript.html:
> parsedElf._io.byteOffset
0
> parsedElf.magic
Uint8Array [ 127, 69, 76, 70 ]
> parsedElf.magic.byteOffset
0
> parsedElf.header.flags
Uint8Array [ 0, 0, 0, 0 ]
> parsedElf.header.flags.byteOffset
48

seems to work at least for things that are arrays, but it does not seem to work for things that are returned as primitives
> parsedElf.header.machine._io
undefined
> parsedElf.header.machine.byteOffset
undefined

it's unclear how the webide gets this information

this is exposed by the compiler it seems
            this.ksySchema = <KsySchema.IKsyFile>YAML.parse(srcYaml);
            this.ksyTypes = SchemaUtils.collectKsyTypes(this.ksySchema);

this is exposed by the compiler it seems
            this.ksySchema = <KsySchema.IKsyFile>YAML.parse(srcYaml);
            this.ksyTypes = SchemaUtils.collectKsyTypes(this.ksySchema);

so, a possibly easier solution to this would be to provide a fake implementation of KaitaiStream that stores the information of offsets for all the values it returns.

so, a possibly easier solution to this would be to provide a fake implementation of KaitaiStream that stores the information of offsets for all the values it returns.

example:
KaitaiStream.prototype.readS1 = function() {
  this.ensureBytesLeft(1);
  var v = this._dataView.getInt8(this.pos);
  this.pos += 1;
  return v;
};

would be:
KaitaiStream.prototype.readS1 = function() {
  this.ensureBytesLeft(1);
  var v = this._dataView.getInt8(this.pos);
  this.pos += 1;
  return this._addToMap(v); // <<-- this is new
};

with
KaitaiStream.prototype._map = new Map;
KaitaiStream.prototype._last = 0;
KaitaiStream.prototype._addToMap = (v) => {
  const obj = new v.constructor(v);
  this._map.set(obj, {index: this._map.size, start: this._last, end: this.pos});
  this._last = this.pos;
  return obj;
};

example:
KaitaiStream.prototype.readS1 = function() {
  this.ensureBytesLeft(1);
  var v = this._dataView.getInt8(this.pos);
  this.pos += 1;
  return v;
};

would be:
KaitaiStream.prototype.readS1 = function() {
  this.ensureBytesLeft(1);
  var v = this._dataView.getInt8(this.pos);
  this.pos += 1;
  return this._addToMap(v); // <<-- this is new
};

with
KaitaiStream.prototype._map = new Map;
KaitaiStream.prototype._last = 0;
KaitaiStream.prototype._addToMap = (v) => {
  const obj = new v.constructor(v);
  this._map.set(obj, {index: this._map.size, start: this._last, end: this.pos});
  this._last = this.pos;
  return obj;
};

@koczkatamas (hopefully this works ^.^) would https://github.com/google/tamperchrome/issues/63#issuecomment-753526073 work?

@koczkatamas (hopefully this works ^.^) would https://github.com/google/tamperchrome/issues/63#issuecomment-753526073 work?

@koczkatamas (hopefully this works ^.^) would #63 (comment) work?

KS has a somewhat hidden 'debug' mode which does exactly what you need: adds a _debug field into objects and stores the start, end and so-called ioOffset of the fields.
If you generate the parser code with the WebIDE, then use the JS code (debug) tab here:

Otherwise if you use the KS JS compiler, then you can set the debug property of the compile method to true to generate debug code instead of a non-debug one: https://github.com/kaitai-io/kaitai_struct_compiler/tree/master/js#basic-usage-of-compile-method
I hope this is what you need :)

@koczkatamas (hopefully this works ^.^) would #63 (comment) work?

KS has a somewhat hidden 'debug' mode which does exactly what you need: adds a _debug field into objects and stores the start, end and so-called ioOffset of the fields.
If you generate the parser code with the WebIDE, then use the JS code (debug) tab here:

Otherwise if you use the KS JS compiler, then you can set the debug property of the compile method to true to generate debug code instead of a non-debug one: https://github.com/kaitai-io/kaitai_struct_compiler/tree/master/js#basic-usage-of-compile-method
I hope this is what you need :)

woohoo! thanks =D

woohoo! thanks =D


MTU should be passed to the windows pods

This is a tracker issue. Partial work has been done in PR #331
/cc @alinbalutoiu

/cc @aserdean

@rajatchopra this is being addressed by @aserdean , he will submit a PR soon.


Provide a working example with using a Webhook

It is not clear how to configure it properly. I tried the following
Here is the code from main.go
package main

import (
	"fmt"
	"os"

	tele "gopkg.in/telebot.v3"
)

func main() {
	webhookEndpoint := os.Getenv("BOT_WEBHOOK_ENDPOINT")
	if webhookEndpoint == "" {
		panic("No BOT_WEBHOOK_ENDPOINT provided")
	}

	fmt.Println("Starting a bot")

	b, err := tele.NewBot(tele.Settings{
		Token: os.Getenv("BOT_TOKEN"),
		Poller: &tele.Webhook{
			Endpoint:    &tele.WebhookEndpoint{PublicURL: webhookEndpoint},
			DropUpdates: true,
		},
		Verbose: true,
	})
	if err != nil {
		panic("Cannot start the bot: " + err.Error())
	}

	fmt.Println("Configuring handlers...")

	b.Handle("/hello", func(c tele.Context) error {
		fmt.Println("Got a hello message")
		sent := c.Send("Hello to you too!")
		if sent != nil {
			panic(sent.Error())
		}
		return sent
	})

	b.Handle(tele.OnText, func(c tele.Context) error {
		fmt.Println("Got a message")
		sent := c.Send("Hello world!")
		if sent != nil {
			panic(sent.Error())
		}
		return sent
	})
        b.Start()
}

Created a lambda by using serverless
service: myBot
useDotenv: true
configValidationMode: error

provider:
  region: "us-west-1"
  name: aws
  runtime: go1.x
  logRetentionInDays: 30
  endpointType: regional
  tracing:
    apiGateway: true
    lambda: true
  iam:
    role:
      statements:
        - Effect: "Allow"
          Resource: "*"
          Action:
            - "xray:*"
package:
  patterns:
    - "bin/webhook"

functions:
  webhook:
    handler: bin/webhook
    timeout: 15
    description: My Bot
    memorySize: 128
    environment:
      BOT_TOKEN: ${env:BOT_TOKEN}
      BOT_WEBHOOK_ENDPOINT: ${env:BOT_WEBHOOK_ENDPOINT}
    events:
      - http:
          path: /webhook
          method: ANY
          cors: false

Built and deployed the project env GOOS=linux go build -o bin/webhook main.go and serverless deploy --verbose

I see Starting a bot and Configuring handlers... in the logs, but nothing from the handlers
The getWebhookInfo endpoint looks fine. Here is the response (replaced the app id and IP)
{
  "ok": true,
  "result": {
    "url": "https://[my-app-id].execute-api.us-west-1.amazonaws.com/dev/webhook",
    "has_custom_certificate": false,
    "pending_update_count": 2,
    "max_connections": 40,
    "ip_address": "IP"
  }
}

Note: After calling the webhook (https://[my-app-id].execute-api.us-west-1.amazonaws.com/dev/webhook) manually I receive this:
{
  "message": "Internal server error"
}

Basically, the issue is that the webhook endpoint always responds with 502

I suggest leaving serverless out of equation first and making sure that the bot itself works, this way it could be easier to troubleshoot. It appears one needs to call SetWebhook in order to set a web hook, and your example does not seem to be doing that

Thanks @AndrewSav for the direction. The following way works fine locally
'''
webhookEndpoint := os.Getenv("BOT_WEBHOOK_ENDPOINT")
if webhookEndpoint == "" {
panic("No BOT_WEBHOOK_ENDPOINT provided")
}
b, _ := tele.NewBot(tele.Settings{
	Token: os.Getenv("BOT_TOKEN"),
	Poller: &tele.Webhook{
		Endpoint:       &tele.WebhookEndpoint{PublicURL: webhookEndpoint},
		AllowedUpdates: []string{"callback_query", "message"},
		Listen:         ":8888",
	},
	Verbose: true,
})

'''
The issue I guess is that on lambda I can't listen for any port

Coming here for the same request.
Here is how it is done for AWS lambda using a node base client:
https://github.com/suntong/telegram-notify-bot-serverless/blob/a38cab3c0ff37b9cb9ea50860ea92a152b166995/handler.js#L11-L27
I.e.,
module.exports.hello = async event => {
  try {
    const body = JSON.parse(event.body);
    await bot.handleUpdate(body);
    return {
      statusCode: 200,
      body: JSON.stringify(
        {
          message: 'Ok',
        })
    };

what we need is to use bot.HandleUpdate to do the same internal stuff the library is doing from the webhook to handle a single update.


Refactor the local system dependencies such that they are more correct
and platform agnostic. [phab:D835]

Created by shahms at 2016-04-14 21:06:22:
This builds on and cleans up the previous kythe_pkg_config repository rules
such that a local directory can be specified via environment variable
to force {lib/,include/} style dependencies on all platforms.
It also supports pkg-config on all platforms, with the caveat that
OS X Xcode 10.11 has a broken OpenSSL installation. It includes the libraries
and .pc (pkg-config) file, but no headers.
Installing and linking with --force via homebrew works, but it's almost
as if Apple doesn't want people developing on/for their platform.

zarko commented inline (context lost during migration) at 2016-04-14 21:35:58:
nit: constraints

zarko commented inline (context lost during migration) at 2016-04-14 21:35:58:
nit: maybe move '{}' before "not"?

zarko accepted this revision at 2016-04-14 21:35:58

shahms wrote at 2016-04-14 21:41:19:

fix typos

Updating (earlier comment): Refactor the local system dependencies such that they are more correct
and platform agnostic.

shahms closed via commit 66aaba29b65d27c987502e8026e61022bd3f04ad at 2016-04-14 21:47:11


Prevent restarts of kube-controller from overshooting and correcting replicas

Rc manager waits for the pod controller to finish the first relist before polling for replicas after a kube-controller restart.
@lavalamp

just a few comments about improving legibility & clarity. LGTM when fixed

PTAL

Does this fully fix #10030?

Replied on the bug

Risk assessment: medium-low. Code only activated when rc manager starts/restarts.
Value: this PR prevents overshooting/correcting of the rc should the kube-controller restart with active replicas.
@lavalamp I think this needs a final LGTM for fixed nits
@davidopp @quinton-hoole I think this needs 2 more lgtms if we want it now

LGTM

LGTM
Since @lavalamp is fine with this, I'm fine with this. My knowledge of RC is a bit out-of-date so I can't vouch for it 100%.
It's not clear to me whether @brendandburns is planning to get his HA stuff merged before 1.0. If not, the priority of this is lower, but I think the risk is low anyway so I'm fine with merging it.

LGTM. Is this covered by an existing e2e test?  If not, please file an issue to track creating one.

Don't think we have a restart e2e for anything other than etcd. Agree that we should.

It's not clear to me whether @brendandburns is planning to get his HA stuff merged before 1.0. If not, the priority of this is lower, but I think the risk is low anyway so I'm fine with merging it.

Actually this covers the case where controller-manager restarts, so I think it's pretty important even without HA.


Develop fail - images

I'm new in Gatsby.
While running gatsby develop all images except one of them (blogs page cover "iphone-camera.jpg") are missed.
All demo pictures in images folder are there. But while generating its missing.
How can I assign images?

What is the error you are getting, I am testing the build locally and getting no issues.

There is no error in bash. Oly in Chrome Browser Dev.tools ('console' tab) says a lot errors about images processing. Here is one of them:
No data found for image "../../images/macbook-color.jpg"               undefinedCould not read image data file "D:\_host\open-server_actual\domains\daad\.cache\caches\gatsby-plugin-image\672271478.json".  This may mean that the images in "D:\_host\open-server_actual\domains\daad\src\components\BannerModule\BannerModule.js" were not processed. Please ensure that your gatsby version is at least 2.24.78.

What does the terminal return when you run gatsby -v

Gatsby CLI version: 4.3.0 Gatsby version: 2.19.38

The last part of the error refers to the version of Gatsby - Please ensure that your gatsby version is at least 2.24.78
Can you run npm install -g gatsby-cli and try it again. I am not getting the errors you are getting so I assume updating your Gatsby CLI version should do the trick

Thanks. Solved:

run npm outdated
manually upgrade all dependencies which are require upgrade (in my case npm install gatsby@latest --legacy-peer-deps)

For clarification: while trying to develop in Netlify ('new site from Git') option - again got error. Can you tell me how can I send access tokens from .env.production file to Gatsby environment? (I've already add this file by removing its name from gitingnore)
Netlify deploy output:

10:54:54 PM: error Invalid plugin options for "gatsby-source-contentful":
10:54:54 PM: - "accessToken" is required
10:54:54 PM: - "spaceId" is required
10:54:54 PM: not finished open and validate gatsby-configs, load plugins - 1.016s
10:54:54 PM: npm ERR! code ELIFECYCLE
10:54:54 PM: npm ERR! errno 1
10:54:54 PM: npm ERR<EMAIL_ADDRESS>build: gatsby build
10:54:54 PM: npm ERR! Exit status 1
10:54:54 PM: npm ERR!
10:54:54 PM: npm ERR! Failed at the<EMAIL_ADDRESS>build script.
10:54:54 PM: npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
10:54:54 PM: npm ERR!

Thanks again!
After setting up it builds correctly.


Icon Request

may i request vivaldi browser and a general game controller icon? thank you!!

Sure. I've just added them to the GoogleDrive folder. You can find Vivaldi in the browser folder and a generic controller icon in custom.
I have provided a preview image below.


substitute* should fail when --replace fails

Issue description
Currently, it only prints a warning, which can easily get hidden in the build log. A lot of the missing substitutions only fails at runtime, which can be problematic and hard to debug.
This is the logic that prints the warning, we should be able to just add a non-0 return value like --subst-var and *):
https://github.com/NixOS/nixpkgs/blob/fb5e53615b4734ca6eaeeb54b84b8000cdae0389/pkgs/stdenv/generic/setup.sh#L848
Steps to reproduce
$ nix-shell -p
$ touch foo
$ substitute foo /dev/stdout --replace a b
substituteStream(): WARNING: pattern 'a' doesn't match anything in file 'foo'
$ echo $?
0

Pinging people that touched setup.sh recently (relatively, this file doesn't get changed much)
@Artturin @roberth @sternenseemann @trofi @ncfavier @SuperSandro2000

I think it's a reasonable change, but there are a few cases where globs are used to do blanket changes, like:
pkgs/development/python-modules/remi/default.nix:    substituteInPlace test/test_*.py

I suspect those have quite a few cases when no replacement happens and migtn need some form of opt-in to restore permissive behaviour.

Those cases can be handled with || true.

|| true will only work if substituteInPlace will not stop on the first failed file and will return status after all substitutions attempted.

This would be a lot less painful if we'd introduce a new flag or a new function.
I'll note that I don't like some of its variations/behavior either:

https://github.com/NixOS/nixpkgs/issues/237216

I wouldn't be opposed to a new function, clean slate, encourage good practices.

No way.
I am using it in my codes for TDE.
Their old tqt3 code uses a custom ersatz autotools script, and it searches in hardcoded paths.
Worse, they ship configuration codes for a plethora of OSes, and many of them do not have identical hardcoded paths.
I can survive a warning, but not an error.

I think --fail and --quiet would be good flags.

Thanks for the ping, I just dusted of an old PR: #248565

I think --fail and --quiet would be good flags.

In the PR above, i opted to deprecate --replace in favor of --replace-fail --replace-warn and --replace-quiet, since a --fail  and --quiet would not affect --subst-var and --subst-var.

Fixed by https://github.com/NixOS/nixpkgs/pull/260776


Trainval_Neg.pkl file

In Trainval_Neg.pkl ,Pair all the Human and Object that has the score higher than a threshold. HO pairs that are not included in the GT, are the negative examples.
If consider (IOU(human)and IOU(object))>threshold? Indeed close to each other or not?

In Trainval_Neg.pkl ,Pair all the Human and Object that has the score higher than a threshold. HO pairs that are not included in the GT, are the negative examples.
--Yes. (score: IoU with GT box, detection confidence, all > thresholds)
If consider (IOU(human)and IOU(object))>threshold? Indeed close to each other or not?
--didn't get this point, in (IOU(human)and IOU(object)), what is "and"; "close to each other"?

I mean the minimum of human overlap IoUh and object overlap IoUo exceeds threshold, i.e  min(IoUh; IoUo) >threshold. Is such a condition considered? I mean, is the human box considered close to the object box?

H/O IoU box should all be > 0.5, yes, min() works.
No, no hand-crafted distance between human and object is explicitly defined as a constraint. But for many HOIs, h-o box distance is a useful clue.


Change #dv to #to_dv?

Array or ranges can be initialized to Daru::Vector with dv method like
[15] pry(main)> (1..3).dv
=>
#<Daru::Vector:22990900 @name = nil @metadata = {} @size = 3 >
    nil
  0   1
  1   2
  2   3

I think to_dv is better because its intuitive and easy to remember similar to to_i, to_a, etc.

+1 to this proposition.
Also, I'm not sure it is a good practice to pollute Ruby objects with such a short names.
I'd prefer having Array#to_daru_vector by default, and to_dv shortcut defined in something like daru/shortcuts (not required by default).

Ok works. to_dv is better and more suited for a Ruby class change.

Closing in favor if #424


how to change wallhack color?

im not very smart so how does one convert rgba to a float

https://doc.instantreality.org/tools/color_calculator/
Pick a color, and have a look at the "RGB Normalized decimal" for R,G,B parts. The last part is Alpha. Just use 1.0 if you have no clue about it.


qmpy dependency

Currently, CAMD depends on a custom fork of qmpy, which was used to ensure python3 compatibility.  qmpy has recently updated their github repo to be python3 compatible, but I don't think they've released yet.  When they do, we should explore reintegrating the official version.

Tried this today with a pinned commit from their repo, getting a pygraphviz installation issue on OSX.  I'm reluctant to upgrade as a result, but will continue to monitor.


Screensaver enable password not working

The function to enable the screensaver password when arriving at a location doesn't seem to be working. I'm on MacOS 10.11 and it seems to have started after I upgraded.

Check for updates, ensure you are using the latest release

Running version 1.6.1.

Same for me with 10.11 and 1.6.1. Also forcing a context does not help.. Although the message is shown that the screensaver password got (de)activated it does not work.

I can even add that the Require Password checkbox is even checked, but OS X 10.11 doesn't pick it up until you manually disable/enable it.

(1.6.1)
I've found that ControlPlane says it's enabling/disabling the screensaver password, and the box is checked/unchecked as appropriate in system preferences, but that OSX does not take any notice of this, unless I do it manually.
The apple script from SE worked for me too (reposted here for posterity):
sudo osascript -e 'tell application "System Events" to set require password to wake of security preferences to false'

I don't have the ability to test it, but I am pretty sure the action no longer works even for <10.11.
I believe this is related to fb44351, in that the deleted line was there to cause the setting to be "reloaded" (see https://web.archive.org/web/20141112135724/http://hintsforums.macworld.com/showthread.php?t=49718#13).
At minimum the delete line probably needs to be restored and a check for <10.11 be made, but unfortunately that would not fix this action for 10.11.

Still does not work on 10.11.1

Just discovered this support site. I'm also on 10.11.1, running CP 1.6.1 and can manually set the password requirement and have it work, but if CP tries, IT thinks it's doing it but it is not activating it.

Can confirm this, I have the same problem. I'm on 10.11.1, running ControlPlane 1.6.1. The checkbox is checked/unchecked in System Preferences, but OS X doesn't care, unless you do it manually.

I have the same problem... really looking forward for a fix

have this problem too, 10.11

@timothykang, 1.6.1 works on OS X 10.10.  I was using the enable/disable password until just recently when I upgraded to El Capitan, and it stopped working.

Same problem as the rest, won't work in El Capitan

I was hoping 1.6.2 solves this, but unfortunately is doesn't...

Version 1.6.2 changes the checkbox in OS X preferences but it still has no effect unfortunately.

Same with Version 1.6.2, unfortunately still does not work under 10.11.3.

Workaround: put the AppleScript referenced by @gfarrell in a shell script and then have ControlPlane fire the script using a System Action.
I didn't include the sudo in the script and it works fine.
#!/bin/sh
osascript -e 'tell application "System Events" to set require password to wake of security preferences to false'

Make a corresponding script with the last value set to true to have a script that re-enables the screensaver password:
#!/bin/sh
osascript -e 'tell application "System Events" to set require password to wake of security preferences to true'

Thanks for the tip! Adding the shell scripts worked for me. Nice workaround.

Can confirm, same with Version 1.6.2. Still does not work under 10.11.3.
I'm using the shell script workaround. Thanks @gfarrell and @richellis 👍

Thanks! Great workaround! :smile: :+1:

I incorporated the apple script into ControlPlane and it is used for 10.11.

Still not working for me! Control Plane 1.6.4 and OSX 10.11.3

Me neither, I went back to my workaround shell scripts. Those still work great.
On Tue, Mar 8, 2016 at 1:00 PM -0800, "garee76"<EMAIL_ADDRESS>wrote:
Still not working for me! Control Plane 1.6.4 and OSX 10.11.3
—
Reply to this email directly or view it on GitHub.

I'm testing this and it's working perfectly on my system.

stopped working for me again with 10.11.6.

Same with me on 10.12, and the script workaround doesn't seem to be working properly either.

Also doesn't work for me on 10.11.6 with Control Plane 1.6.5

The script workaround used to work for me on 10.11, but even the script stopped working for me after upgrading to 10.12 Sierra.  I'm using Control Plane 1.6.5.

I'll be honest and say that I haven't actually looked into this, but if history has taught me anything about this feature, Apple has slowly improved the security of the password lock with each release. It's highly likely this cannot be worked around and the feature (in ControlPlane) will need to go away.

That's sad to hear.  This one feature is the reason I sought out and found ControlPlane.  I'd be happy to help any way I can to keep this feature, but I'm not familiar with the relevant APIs and wouldn't really know where to begin.

I could imagine if we all file a bug at Apple we might have a chance of either getting it fixed or a definite answer. I mean it is a valid Apple Script to set/unset the checkmark, but then nothing happens, which is clearly a bug.