[Fix #3450] Prevent Style/TernaryParentheses from making unsafe corrections

This cop, when configured to omit parentheses, would remove them even when the condition contained an unparenthesized method call, e.g.:
foo = (bar? baz) ? 'Yes' : 'No'

which would change the semantics of the expression. This change fixes that.
I also discovered that a #defined? call is parsed as a special node type (defined?) rather than as a send.

I also discovered that a #defined? call is parsed as a special node type (defined?) rather than as a send.

defined? is a Ruby keyword.


[3.0] Improve config overrides of method and argument

What is the purpose of the change
Improve config overrides of method and argument.

Add method and argument config if found relative config props
Override argument config of service:
The match pattern is: dubbo.service.{interfaceName}.{methodName}.{arg-index}.xxx=xxx, e.g. dubbo.service.org.apache.dubbo.config.api.DemoService.sayName.0.callback=true

Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8054 (b157dc2) into 3.0 (f7cfe6e) will increase coverage by 0.03%.
The diff coverage is 74.40%.

@@             Coverage Diff              @@
##                3.0    #8054      +/-   ##
============================================
+ Coverage     60.85%   60.89%   +0.03%
+ Complexity      313      312       -1
============================================
  Files          1070     1070
  Lines         44859    44961     +102
  Branches       6699     6732      +33
============================================
+ Hits          27299    27377      +78
- Misses        14551    14558       +7
- Partials       3009     3026      +17

Impacted Files
Coverage Δ

...in/java/org/apache/dubbo/config/ServiceConfig.java
61.32% <0.00%> (-0.19%)
:arrow_down:

...g/apache/dubbo/config/AbstractInterfaceConfig.java
83.33% <64.28%> (-3.51%)
:arrow_down:

...n/java/org/apache/dubbo/config/AbstractConfig.java
75.87% <75.00%> (-0.03%)
:arrow_down:

...apache/dubbo/common/config/ConfigurationUtils.java
76.13% <75.86%> (-1.65%)
:arrow_down:

...ain/java/org/apache/dubbo/config/MethodConfig.java
88.18% <75.86%> (-3.65%)
:arrow_down:

...va/org/apache/dubbo/common/config/Environment.java
74.31% <100.00%> (+0.97%)
:arrow_up:

.../apache/dubbo/config/bootstrap/DubboBootstrap.java
69.24% <100.00%> (+0.08%)
:arrow_up:

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
:arrow_down:

...org/apache/dubbo/rpc/protocol/AbstractInvoker.java
65.76% <0.00%> (-2.71%)
:arrow_down:

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
86.66% <0.00%> (-1.91%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cfe6e...b157dc2. Read the comment docs.

Service-Callback demo test OK


Instantiate a single registry instance per URI

This refactor introduces the RegistryProvider struct which is responsible for lazily instantiating registries on a per-URI basis. This is useful to maximise usage of the connection pools, particularly when constructing the dependency graph.
This also abstracts away some of the code that was explicitly instantiating the Artifactory registry to use the Registry trait as intended.

Should be merged after #83

General note on this: This seems like over optimization as we have never created more than a handful of clients atm? The implementation looks good, but is there any reason why we need this?
I think adoption + the grpc based registry are more important in terms of priority

I strongly disagree. The optimisation aspect of it is nice, but the main goal here is actually to refactor the code to abstract away instantiating different registry implementations directly. Implementing this now is important to lay a good foundation for future changes, so that we veer away from hardcoding Artifactory everywhere.

So, the underlying axiom of my comments is that we just do not support any other registry impl for now, and we will adapt this code if we should ever break that
The planned pipeline is:
Stabilization -> Buffrs Registry Implementation -> Buffrs Registry Migration (away from artifactory)

So, the underlying axiom of my comments is that we just do not support any other registry impl for now, and we will adapt this code if we should ever break that
The planned pipeline is:
Stabilization -> Buffrs Registry Implementation -> Buffrs Registry Migration (away from artifactory)

Yeah, I know that's not on the radar for now, but my concern is that we would end up stabilising on an API that hardcodes Artifactory, and it would be a pain to migrate out of it in the future. So ultimate goal here is to get the API right.


NIFI-7307 - Add User Metadata support to the Azure Blob Processors + LookupService

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[X] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@davidvoit I am curious which scenario I use your lookup service. Can you help me understand that? Thanks

We are using this code to deduplicate files which aren't arriving in the correct order.
Old: Blob A Metadata MeasumentTime N --> New: Blob A Metadata MearumentTime N+1 (LookupKey MearumentTime New > Old => overwrite blob)
Old: Blob A Metadata MeasumentTime N+1 --> New: Blob A Metadata MearumentTime N (LookupKey MearumentTime New < Old => drop flowfile)
Thats our usecase, but I think there can be more of them. The most important thing is here we don't want to fetch the file to get metadata and route here, because the blob file could be huge and timeconsuming.
Does this makes sense?

Would you run 'mvn -Pcontrib-check clean install' and fix the warning?
src/main/java/org/apache/nifi/processors/azure/storage/ListAzureBlobStorage.java:[81] (sizes) LineLength: Line is longer than 200 characters (found 202).

This should be fixed now. The MacOS action error seems too be a problem in the pipeline itself, and not from the commit. Anything else open?

I built and test the patch. Functionally looks to me. Vote +1.

This would be a really useful feature for us, is there any possibility of this being implemented? Happy to contribute but still a fairly green java dev so would need some guidance on where to start.


Getting issue while installing visual studio 2008 on docker images

Getting issue in middle of visual studio 2008 installation on docker image.
I am using following image mcr.microsoft.com/windows/servercore:1809-KB4519338-amd64
Error: Failed to load DLL: c:\85d1d91bf8070a47c7aab4554009\visualwebdeveloper.ww\OSETUP.DLL ErrorCode: 126(0x7e).
We need to install vs2008 on docker images this requirement. I tried to crate using admin file also getting same issue, Please help to create the image.

Were you able to find a solution for this? I'm running into the same issue

hello, it's a long time, did you find a solution?

Hi,
I found solution to not install visualwebdeveloper, as i do not need it. I am installing Microsoft Visual Studio Team System 2008 Development Edition - ENU
I am using  mcr.microsoft.com/dotnet/framework/runtime:3.5 image.
First I used unattended mode, as i do not need some modules https://msfn.org/board/topic/117875-unattended-ms-visual-studio-2008-pro
Next I installed VS 2008 on the machine with windows server 2019 to get correct registry keys to disable visualwebdeveloper.
The same machine is used for docker.
I searched  in registry for string: 12.0.4518.1066, the installer was searching for it in docker container.
I found 8 keys:
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\00002109120000000000000000F01FEC\InstallProperties]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\00002109120090400000000000F01FEC\InstallProperties]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Office\12.0\Common\InstalledPackages\90120000-0021-0409-0000-0000000FF1CE]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Office\12.0\Common\ProductVersion]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Web Designer Tools\1033]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\{90120000-0021-0000-0000-0000000FF1CE}]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\{90120000-0021-0409-0000-0000000FF1CE}]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\VisualWebDeveloper]

I copied from machine to docker container C:\Program Files (x86)\Microsoft Web Designer Tools - i think it's not needed.
I added keys to registry in docker container.
I removed from VS2008_deployment.ini installation of .framework v3.5 and i run unattended installation.
Result is (i installed sp1 too):
Microsoft Document Explorer 2008
Visual Studio 2005 Tools for Office Second Edition Runtime
Microsoft Visual Studio Team System 2008 Development Edition - ENU
Visual Studio Tools for the Office system 3.0 Runtime
Microsoft SQL Server Compact 3.5 SP1 Design Tools English
Visual C++ 2008 x64 Runtime - (v9.0.30729)
Visual C++ 2008 x64 Runtime - v9.0.30729.01
Visual C++ 2008 IA64 Runtime - (v9.0.30729)
Visual C++ 2008 IA64 Runtime - v9.0.30729.01
Microsoft SQL Server Compact 3.5 for Devices ENU
Microsoft .NET Compact Framework 3.5
SQL Server System CLR Types
Microsoft Visual Studio 2005 Tools for Office Runtime
Microsoft Visual Studio 2008 Remote Debugger - ENU Service Pack 1 (KB945140)
Microsoft Document Explorer 2008
Windows Mobile 5.0 SDK R2 for Pocket PC
Visual Studio Tools for the Office system 3.0 Runtime
Visual Studio Tools for the Office system 3.0 Runtime Service Pack 1 (KB949258)
Microsoft Office Visual Web Developer 2007
Microsoft Office Visual Web Developer MUI (English) 2007
Windows Mobile 5.0 SDK R2 for Smartphone
Microsoft SQL Server Database Publishing Wizard 1.3
Microsoft SQL Server Compact 3.5 SP1 English
Microsoft .NET Compact Framework 2.0 SP2
Visual C++ 2008 x86 Runtime - (v9.0.30729)
Visual C++ 2008 x86 Runtime - v9.0.30729.01
Microsoft SQL Server 2008 Management Objects
VC Runtimes MSI

Some tools you need to install manually after installation of VS 2008. Everything is in the link above how to do it.
Image is quiet huge: 13GB
Regards

Hi,
I found solution to not install visualwebdeveloper, as i do not need it. I am installing Microsoft Visual Studio Team System 2008 Development Edition - ENU
I am using mcr.microsoft.com/dotnet/framework/runtime:3.5 image.
First I used unattended mode, as i do not need some modules https://msfn.org/board/topic/117875-unattended-ms-visual-studio-2008-pro
Next I installed VS 2008 on the machine with windows server 2019 to get correct registry keys to disable visualwebdeveloper.
The same machine is used for docker.
I searched in registry for string: 12.0.4518.1066, the installer was searching for it in docker container.
I found 8 keys:
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\00002109120000000000000000F01FEC\InstallProperties]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\00002109120090400000000000F01FEC\InstallProperties]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Office\12.0\Common\InstalledPackages\90120000-0021-0409-0000-0000000FF1CE]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Office\12.0\Common\ProductVersion]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Web Designer Tools\1033]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\{90120000-0021-0000-0000-0000000FF1CE}]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\{90120000-0021-0409-0000-0000000FF1CE}]
[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\VisualWebDeveloper]

I copied from machine to docker container C:\Program Files (x86)\Microsoft Web Designer Tools - i think it's not needed.
I added keys to registry in docker container.
I removed from VS2008_deployment.ini installation of .framework v3.5 and i run unattended installation.
Result is (i installed sp1 too):
Microsoft Document Explorer 2008
Visual Studio 2005 Tools for Office Second Edition Runtime
Microsoft Visual Studio Team System 2008 Development Edition - ENU
Visual Studio Tools for the Office system 3.0 Runtime
Microsoft SQL Server Compact 3.5 SP1 Design Tools English
Visual C++ 2008 x64 Runtime - (v9.0.30729)
Visual C++ 2008 x64 Runtime - v9.0.30729.01
Visual C++ 2008 IA64 Runtime - (v9.0.30729)
Visual C++ 2008 IA64 Runtime - v9.0.30729.01
Microsoft SQL Server Compact 3.5 for Devices ENU
Microsoft .NET Compact Framework 3.5
SQL Server System CLR Types
Microsoft Visual Studio 2005 Tools for Office Runtime
Microsoft Visual Studio 2008 Remote Debugger - ENU Service Pack 1 (KB945140)
Microsoft Document Explorer 2008
Windows Mobile 5.0 SDK R2 for Pocket PC
Visual Studio Tools for the Office system 3.0 Runtime
Visual Studio Tools for the Office system 3.0 Runtime Service Pack 1 (KB949258)
Microsoft Office Visual Web Developer 2007
Microsoft Office Visual Web Developer MUI (English) 2007
Windows Mobile 5.0 SDK R2 for Smartphone
Microsoft SQL Server Database Publishing Wizard 1.3
Microsoft SQL Server Compact 3.5 SP1 English
Microsoft .NET Compact Framework 2.0 SP2
Visual C++ 2008 x86 Runtime - (v9.0.30729)
Visual C++ 2008 x86 Runtime - v9.0.30729.01
Microsoft SQL Server 2008 Management Objects
VC Runtimes MSI

Some tools you need to install manually after installation of VS 2008. Everything is in the link above how to do it.
Image is quiet huge: 13GB
Regards

thank you, i will try this

The Dokerfile, if existing, would be welcome :)


[improve][cli] Allow pulser-client consume create a replicated subscription

Master Issue: #11371
Issue: #11371
Motivation
pulsar-client consume doesn't currently support creating replicated subscriptions.
Modifications

Added option in CmdConsume for specifying the replicated parameter for subscription creation.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

We need to add integration test between the client and broker regarding the replication.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[x] Anything that affects deployment 👉🏼 new client CLI option.

Documentation

[ ] doc
[x] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/4

The doc could be generated automatically

Yes, specifically, in this script.

/pulsarbot run-failure-checks

Already updated.

Ref - https://github.com/apache/pulsar-site/commit/2536a6e4938b0dac06d88f5b611a018afa1d7572


Add support for fromJSON in expressions

Although the linter does not actually fail my workflow run in these scenarios, I do see a handful of failure annotations for the use of fromJSON in expressions in the workflow files I'm linting, e.g.:

Notably, item # 2 in the list of expected tokens is fromJson -- with different capitalization. I would guess I can workaround this issue by using that casing? 🤔
Or should both be supported? Are our Actions expressions case-insensitive altogether? 💡
There seems to be a disagreement in casing within the blog post announcing it (shows both fromJSON and fromJson). Consequently, the Docs show only fromJSON.

I'd imagine the same is probably true for toJSON as well, though I do not have any workflow using that currently.

For now, I worked around it by using the casing fromJson. 👍🏻

Looks like you may have already updated github-actions-parser for this but those changes haven't made it into actions-linter yet: https://github.com/cschleiden/github-actions-parser/commit/25a17e365b2e6002897d50967221835bc826a46f

This has now been resolved in yesterday's latest release. Thank you! 💖


06/11/2018 02:03 : Create Pull Request for branch master -> prTesting1_2018061102

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add timeline

We could add a timeline with a section like "Important dates", e.g.:

Maintainers invited contacted: ... - ...
Labeled issues submitted by: ....
Unitary Hack coding period: ... - ...

I think this is handled now in the maintainer guide!


How to pass tiles map in Tileset class with mutiple tile layers. What should be the tiles key in that situation.

class Tileset {
  final bool preprocessed;
  final Map<String, Tile> tiles;
  late final LayerFeatureResolver _resolver;

  Tileset(this.tiles) : preprocessed = false {
    _resolver = DefaultLayerFeatureResolver(this);
  }
}

This is multiple data layer in bytes array
var tileData1 = TileFactory(theme, const Logger.noop())
                  .createTileData(VectorTileReader().read(tileBytes1));

var tileData2 = TileFactory(theme, const Logger.noop())
                  .createTileData(VectorTileReader().read(tileBytes2));

final tile1 = tileData1.toTile();
final tile2 = tileData2.toTile();

 Map<String, Tile> tiles = {};
 tiles.putIfAbsent("openmaptiles", () => tile1);
 tiles.putIfAbsent("?", () => tile2);   // what should be the value of key in this situation

final tileset = TilesetPreprocessor(theme)
                  .preprocess(Tileset(tiles), zoom: tileZXYValue[0].toDouble());

The key should correspond to a layer in your style/theme. You'll find example usage in vector_map_tiles
It's unusual to use these APIs directly. Have you considered using https://pub.dev/packages/vector_map_tiles instead? What is your use-case?


Rename pantry.extra and pantry.core to pantry

I noticed some instances of pantry.extra and pantry.core. If I understand correctly, these should all be just "pantry" now.

Coverage: 34.591%. Remained the same when pulling a07d679b09fe5fd0fd0f95193f1e682c8f08d810 on magnusviri:rm_pantry_extra_core into 012a4b1b53cfd2bd80a7d083df4ca32fd1f29584 on teaxyz:main.

k 0.26 merged and indeed this PR is now empty. Closing. But thank you.


RU locale for RecipeBook v3.0.1

Thanks, as always! I changed a few strings in v3.0.2, so I decided to wait until you can make those changes before I merge.

I'll fix this bug, but I'd recommend removing the English name from this and just keeping the Cyrillic version. Unless there's a reason to have both?

I'd recommend removing the English name from this and just keeping the Cyrillic version. Unless there's a reason to have both?

It's just for convenience. Both names useful for mod view and search in game settings. You can remove English name and leave Cyrillic if you want. Or you can use other string for GUI caption. You choose.
P.S. Link to mod portal is broken in readme ^_^

Thanks for your contributions! I'll leave the English name in and will fix the stretching bug. :)


fix: use full paths to files in workspace context prompt

Fixes https://github.com/ErikBjare/gptme/issues/328 https://github.com/ErikBjare/gptme/issues/329

[!IMPORTANT]
Updates get_workspace_prompt to use full file paths and removes unused import in gptme/prompts.py.

Behavior:

get_workspace_prompt in gptme/prompts.py now uses full file paths instead of file names in the workspace context prompt.
Logs an error and exits if a file specified in the project config does not exist.

Imports:

Removes unused glob import from gptme/prompts.py.

This description was created by  for d15d533eee2278376835fcb9e3c1dc34b6800120. It will automatically update as commits are pushed.

Codecov Report
Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (2343ab6) to head (d15d533).
Report is 1 commits behind head on master.

Files with missing lines
Patch %
Lines

gptme/prompts.py
0.00%
10 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   70.65%   69.43%   -1.22%
==========================================
  Files          67       67
  Lines        4951     4954       +3
==========================================
- Hits         3498     3440      -58
- Misses       1453     1514      +61

Flag
Coverage Δ

anthropic/claude-3-haiku-20240307
?

openai/gpt-4o-mini
69.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgrade the flink workload

Description of your changes

How has this code been tested?

Checklist

I have:

[x] Title of the PR starts with type (e.g. [Addon] or [Trait]).
[x] Updated/Added any relevant [documentation] and [examples].
[x] Unit/E2E Tests added.

close this pr for solving the DCO issue and add some new modification.


Patched fs.unlink error on windows

Replaced fs.unlinkSync() with temp.cleanupSync() solving #42
Updated readme for source map flag
Disabled Advanced mode in jsCompiler test due to warnings

Still issues with getting the actual source map to display correctly in webpack-dev-server but most likely due to invalid path mapping

Closed due to inactivity


Run more tests on both JVM/JS

fs2-io supports all APIs (including files) on JVM and JS now.

All the sources are shared now, so you can simplify your directory structure to an ordinary project (no need for shared/jvm/js split).

@satabin should I fix these modules as well?
https://github.com/satabin/fs2-data/blob/bf5a7033574d17c05cf408ef33a93b7792ec1d8a/build.sbt#L250-L251
https://github.com/satabin/fs2-data/blob/bf5a7033574d17c05cf408ef33a93b7792ec1d8a/build.sbt#L264-L265

Ok thanks I need to do a global check on my use of shared,  I thought I had more specific cases.

I let two of you figure out the sbt sources setup, it's by far not my strength 🙄
But thank you very much for the work @armanbilge! Feel free to ping me on the Typelevel Discord (same handle) if you need more workflow approvals on the way.

Looks good from my side then, but I'll let @satabin do the merge in case there's something with the source folders still to be optimised.

Nah, it’s fine, I’ll merge it. Thanks a lot @armanbilge!


Short solution needed: "Escape string with PHP PDO" (php-pdo)

Please help us write most modern and shortest code solution for this issue:
Escape string with PHP PDO (technology: php-pdo)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Escape string with PHP PDO


A strange issue that appeared after I changed the robot to GO1.

Sorry for the bother.
After I replaced the robot with GO1 following the tutorial in the Wiki, the local planner doesn't seem to be working correctly (the robot can stand normally and the global planner is fine).
I then switched the bot back to spirit and the same thing happened (as pictured). This is strange because I followed the instructions in the tutorial the entire time.
I would be grateful for an answer from your subject.

Hi @hrxsd,
Did you change anything in the code/ what branch are you currently using? I can't tell the exact issue with just the information provided.
Best,
David Ologan

Just checking in on the status of this issue, is there any additional information you could provide?
Best,
David

@ologandavid Thank you for your attention to this issue, I just added go1 to this project step by step following the guidelines in the Wiki about adding new robots and this problem occurred.
It's worth noting that when I added only the URDF file, the robot was able to run correctly in the simulation (at this point, no dynamics model had been generated using MATLAB scripts, and no source code had been modified). However, when I added the above as per the tutorial in the Wiki, the problem arose.


nix-prefetch-url --unpack needs unzip or it fails

$ nix-prefetch-url --unpack ...
downloading ...
unpacking...
error: executing 'unzip': No such file or directory

It seems this is an oversight. unzip should be installed as a dependency of nix-prefetch-url either visibly or invisibly.

Installing unzip fixes it, of course.

cc @edolstra @shlevy

This is a bug in Nix, it should claim dependency on unzip at runtime: https://github.com/NixOS/nix/blob/master/src/nix-prefetch-url/nix-prefetch-url.cc#L173

Relevant is https://github.com/NixOS/nix/issues/1234

Ran into this today, seems like a really silly issue.

Is this fixed?

Was this fixed?

Closing this since it's a Nix (not Nixpkgs) issue. It should be fixed because we're using libarchive now.

Great!


Pulls Latest Changes from upstream

There have been a ton of releases since our last pull this updates to the latest master:
https://github.com/tgstation/rust-g/releases/tag/1.2.0
https://github.com/tgstation/rust-g/releases/tag/1.1.0
https://github.com/tgstation/rust-g/releases/tag/1.0.2
https://github.com/tgstation/rust-g/releases/tag/1.0.1
https://github.com/tgstation/rust-g/releases/tag/1.0.0
https://github.com/tgstation/rust-g/releases/tag/0.8.0
https://github.com/tgstation/rust-g/releases/tag/0.7.0
https://github.com/tgstation/rust-g/releases/tag/0.6.0
https://github.com/tgstation/rust-g/releases/tag/0.5.0
https://github.com/tgstation/rust-g/releases/tag/0.4.10
https://github.com/tgstation/rust-g/releases/tag/0.4.9

god i love merge conflicts that literally aren't on local


TI-99/4A

Which gerbers are specifically for the 99/4A, only the FAT model version 1?  or will any of the others work.  Please specify so I know which one(s) to order.
Thanks

Maybe this will help
https://github.com/lfantoniosi/tn_vdp/issues/2
I still have one board V1 TI99 left. If you are interested, please let me know.


v0.12 not automerged

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
https://github.com/capellaspace/console-client/blob/main/docs/pages/changelog.rst#0120-2024-01-04
appears to be stuck https://github.com/conda-forge/capella-console-client-feedstock/pull/15
Installed packages
n/a

Environment info
n/a

hi @scottyhq
I made sure 0.13.0 is available on conda-forge: https://anaconda.org/conda-forge/capella-console-client.
When trying to get 0.12.0 up I ran into some build issues (I believe something python 3.12 support releated) and honestly decided not too dig to deep by offering 0.13.0


Corrected a typo and changed a bit of punctuation.

@paulinbar : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Syntax validator for kwmrc

Mistakes in ones kwmrc file can lead to kwm not working with out a lot of feedback as to why.
I propose a kwmc validate-config (or some other name) that checks the kwmrc file for syntax errors. At minimum for unknown commands.
Maybe this could be apart of kwmc config reload and return validation errors as apart of that command?
Having to hunt though the kwmrc file for syntax errors can be pretty tedious.

Agreed, will be done soon.

After working quite a bit on this, I really don't find this worth the time required.
I personally feel like users should just be careful when editing their config.
The config can be made readable by splitting it into multiple files and using the include option.
At 3.0.0 release, there will be a stable API that will not change for upcoming releases.

The only reason I suggested it is due to the influx of support issues for invalid config files. There is no feedback given from kwm / kwmc as to why things are not working, and it is not clear to new users if it is set up wrong, broken, or they have an invalid config file.
I figured some sort of config validation would help reduce most (all?) of those types of support requests.
If this is something that you think would be useful but just don't want to do, perhaps go though the tickets and add a help-wanted tag on issues that you don't want to / can't work on, to signal to potential contributors what issues they could tackle.

I have written a "test" parser for the kwmrc file that does report mistakes (currently only to stderr, but this is easy to redirect to a file or something) for everything except kwmc bind. The reason I feel like it is not worth doing, is parsing something like kwmc bind MyMode+cmd+shift-l exec open -na /Applications/SomeApp.app; mode activate default; space -f 2 {iTerm2, Firefox} -e using a tokenizer is just ....

Can we get Kwm to throw an error on incomplete commands then?
Try adding kwmc rule at the end of your kwmrc and then try to figure out what is happening, it's madness.

I'll finish up the one I have been working on so far. It will validate everything but kwmc bind I believe.

Ok so whenever kwmrc is loaded either on launch, or using kwmc config reload, any parsing errors will be written to stderr. The errors will often be skewed due to how parsing works, if you have a lot of syntax errors in early commands, that could potentially cause parsing of later commands to fail.
Comments are no longer prefixed as '#', but use the standard C-style block comments.
/* followed by
   some text, formatting
really            Does not matter. */

The only commands that require to be written in a single line, are these:
define ...
kwmc rule ...
kwmc bind ...

The syntax for borders have also changed to
kwmc config border focused ..
kwmc config border marked ..

instead of

kwmc config focused-border ..
etc..

Comments are no longer prefixed as '#', but use the standard C-style block comments.

Is it terribly difficult to support both? (if it is never mind, I just like using # for comment headings since I don't need to close them)

Is it terribly difficult to support both? (if it is never mind, I just like using # for comment headings since I don't need to close them)

Should be fairly easy. Do you mind if I make it // instead of # though?

Should be fairly easy. Do you mind if I make it // instead of # though?

Not at all // is fine.

Right now I'm getting a lot of parse errors, after switching to the new comment syntax. Also my p key isn't working.
binds: https://gist.github.com/ef7fc3f369b5b4c224c48fd27bc6e922

Probably due to this comment, I suspect:

/* Rotate Window-Tree By 90* (Clockwise) */

Remove the * behind 90. Probably causing some parsing issue.

Ah yeah. Doesn't like / in comments either. also some of the paths i defined are seeming to give it trouble.
 Parse error: Unknown token '/'
  Parse error: Unknown token 'Users'
  Parse error: Unknown token '/'
  Parse error: Unknown token 'Matthew'
  Parse error: Unknown token '/'
  Parse error: Unknown token '.'
  Parse error: Unknown token 'kwm'
  Parse error: Unknown token '/'
  Parse error: Unknown token 'scripts'
  Parse error: Unknown token '/'
  Parse error: Unknown token 'layouts'
  Parse error: Unknown token '*'
  Parse error: Unknown token '/'
  Parse error: Unknown token '/'
  Parse error: Unknown token 'Users'
  Parse error: Unknown token '/'
  Parse error: Unknown token 'Matthew'
  Parse error: Unknown token '/'
  Parse error: Unknown token '.'
  Parse error: Unknown token 'kwm'
  Parse error: Unknown token '/'
  Parse error: Unknown token 'scripts'
  Parse error: Unknown token '/'
  Parse error: Unknown token 'pull'
  Parse error: Unknown token '-'
  Parse error: Unknown token 'e'
  Parse error: Unknown token 'left'
  Parse error: Unknown token '*'
  Parse error: Unknown token '/'

Ah yeah. Doesn't like / in comments either.

That might be a problem, not sure why that would ruin the parsing, but will take a look at it later.

also some of the paths i defined are seeming to give it trouble.

Not sure why that would be the case, mine work just fine:
define ytc /usr/local/bin/ytc
define ~ /Users/Koe
define terminal open -na /Applications/iTerm2.app

Oh okay, it was because i used defined terms in comments. All good now, but my p key still doesn't work.

The culprit is bindsym-passthrough.

The issue regarding * and / breaking block-comments should now be fixed.

The culprit is bindsym-passthrough.

Right makes sense, - is parsed as its own token.
Syntax has changed to bindsym_passthrough.
Fixed on master.

So last thing would probably be to ignore definitions until the tokenizer gets past a comment

So last thing would probably be to ignore definitions until the tokenizer gets past a comment

This is kinda tricky as variable expansion is simply a full on find and replace.
It will expand the variable even tho it is inside a comment, however it is now properly parsed as a part of the comment and will no longer cause any issues.
Unles you do define wasd */
/* this is a comment wasd */

Oh ok, right, the slash thing solves it. 👍

Just updated to the latest commit of master and updated my configuration.
While the use of block comment sounds like an interesting addition, I don't understand why classic # comments have been removed.
I may be wrong but config files are mainly shell scripts, so, to my eyes, should support the classical shell comments. In addition, syntax highlighting doesn't work and readability of config files is now harder.
My 2cts.

I have reserved # for use as a preprocessor mark, for things that will come in the future.

I may be wrong but config files are mainly shell scripts, so, to my eyes, should support the classical shell comments. In addition, syntax highlighting doesn't work and readability of config files is now harder.

I agree. Maybe a different preprocessor mark can be chosen?


[BUG] - Can not found BSGUIKit.h iOS compile

Hello, im using Circle CI to build my app, im using xcode 12.0.0 and bugsnag for react native 7.5.2 and im getting above issue.

i did cd ios && pod install, but no luck, any thoughts ? thanks

Hey @cinder92, does your application run in Debug and Release modes as expected with Bugsnag prior to trying to archive the build? What does the output of pod install show?
The right files should be available for you following a successful install of the React Native package using npm or yarn. From the screenshot it looks like the Pods and node_modules relative to one another are ok, but they're nested in a second ios directory. so it's not clear how your project is laid out. If you're using a non-standard structure, can you please share with us what this looks like to try and reproduce this?

Hey @cinder92, does your application run in Debug and Release modes as expected with Bugsnag prior to trying to archive the build? What does the output of pod install show?
The right files should be available for you following a successful install of the React Native package using npm or yarn. From the screenshot it looks like the Pods and node_modules relative to one another are ok, but they're nested in a second ios directory. so it's not clear how your project is laid out. If you're using a non-standard structure, can you please share with us what this looks like to try and reproduce this?

Closing for now, but do let us know if you have further information to share which may help us diagnose this.


Single day query yields no output

Hello
thank you for this extension.
The following commands (for a day where there has been activity going on), output nothing:
gh furik --from 2022-10-05 --to 2022-10-06
or
gh furik --from 2022-10-05 --to 2022-10-05
Does someone reproduce it as well?

(background vision)
The business use case is:
for what projects have I worked on that (those) days?
for each commit in each project what where commit times?
This may help freelancers (or employees) remember more or less how many hours they have worked for which project on given dates...

I'm sorry for the late reply.
Please wait while I check it.

When you want to take information for one day, specify the next day in the to parameter.
gh furik --from 2022-10-05 --to 2022-10-06

But, the output was only what could be retrieved via GitHub's Event API. This includes pull request open/close, reviews, etc., but not commits.
Can you try again?Thanks for using it.


M01-LAB04: Approvals need to have "Allow approvers to approve their own runs" checked

Contact Details
<EMAIL_ADDRESS>What happened?
Lab: Configure and validate permissions
Exercise : 02
Task: 01
Step: 08
Description of issue:
The instructions don't mention and the screenshot is not showing that the checkbox "Allow approvers to approve their own runs" need to be checked. Just adding my username doesn't work, I won't be able to approve the job.
The screenshot should be updated, and the instruction should explicitly say that this checkbox needs to be checked.
I tested this with the checkbox for Test and without for Production.
Relevant screenshots

Good catch, @mkennten. Thanks! It will be fixed in the PR #51. Closing the issue.


Not an issue - question regarding code

Not an issue, hope it's okay to ask here, i'm beginner in python but can someone please explain what is the purpose of this code from core.py starting at line 40? i understand the first if statement but why the second one does the same thing (send alert)?:
if len(found) > 0 and bool(product["notifyiffound"]) == True:
    send_email = True
elif len(found) == 0 and bool(product["notifyiffound"]) == False:
    send_email = True

Hello @RichardMisencik
You are right. This statement could be refactored into a single if statement. Please do submit a pull request, and I will be more than happy to merge your change.


Fix disable https in be.conf

Proposed changes
Issue Number: none
Problem summary
disable https in be.conf.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


implement a simple condor plugin

Based on PyCondorPlugin, but with many many changes.

get rid of worker pool with multiple threads submitting in parallel
just do condor_submit serially (but bulk submitting lots of jobs together)
get rid of using agent jobid for anything here and use condor jobid instead
get rid of common schedd query function and only query for what is needed
status times come from the component, not the schedd

Basics (submit and track) tested but not sure how to test some of the utility functions that are not called by the agent but only by Ops scripts. Also, I still need to duplicate the relevant PyCondorPlugin unit tests.
@amaltaro @ticoann good enough for some code review and early feedback though.
@bbockelm , is this going along the lines of what we discussed ?
Anything else on the wishlist for this code ? I might as well address it all in one go.

You have a syntax error: RefactoringTool: Can't parse src/python/WMCore/BossAir/Plugins/SimpleCondorPlugin.py: ParseError: bad input: type=8, value=u')', context=('', (374, 92))
Most likely line 374

Thanks for noticing. Fixed it, lets see if it goes through now.

@hufnagel can you comment on what the motivation for doing this? More than what you wrote in the initial post which is mostly a list of what you want to change without much "why"? Or a pointer to somewhere this is discussed (quite likely I missed a mail or something).
Thanks!

I didn't notice the syntax error, Jenkins did. Failures in the pylint test are a good indication. I suppose I could make it notice these and post back to the issue.

That would be nice that if Jenkins can report back syntax error separate from pylint (warnings/score).

@ericvaandering , I always hated the current implementation of the Condor BossAir plugins in that it tracked by agent job id and not Condor job id. I was in the the original design meetings when we discussed BossAir and there were and still are very good reasons not to track by agent job id (basically an agent job is different from a specific instance of that job) . Commented on it a few times already during the evolution of the plugins but my comments were ignored. Getting that aspect of the plugin changed had been on my internal todo list for a couple years maybe.
Then when I was in Nebraska I talked with Brian quite a bit about the shortcomings of the current Condor BossAir plugin and we made a wish list for changes.
In addition I had the code fresh in my mind since I recently improved on the bulk submission, so I just gave it a go, took only a few days non-continuous work (had some time to kill in between working on NERSC and waiting for pilots to run) to have a first version, at which point I started asking questions in HN and kept improving the code.

As for where this was discussed before, comments in various tickets related to PyCondorPlugin and I mentioned it a few times in release planning meetings (the last one I think as well). Other than that this started exploratory and is now basically "write a somewhat clean implementation of an all python based Condor BossAir plugin and remove accumulated cruft". No push from my side to use this in operations anytime soon. Given the amount of validation such a changeover involves, I'd rather change everything at once in one go and then we can start testing slowly. If we see a clear improvement (in performance) to what we are using now we can always accelerate the schedule later.

Also the reason I implemented a new plugin instead of patching PyCondorPlugin. With a new plugin we can have it in the code and for tests (or in the Tier0) it can be selected in the resource setup and agent configuration.

Thanks @hufnagel . I'll be at CERN next week so maybe we can chat over drinks. I'm not opposed at all just trying to understand.

Ok, worked through all the comments. For some of them we are still discussing things, but due to changes around close code lines the diffs will be outdated. In that case just comment on the new commit.

Ok, pending code review and new information this is my final version. This only works with a new condor 8.5.4 package, we are still working out how to get that into COMP exactly.
Good enough for code review code. @ticoann @amaltaro @bbockelm

The latest version addresses all the concerns from the review.

Thanks, Dirk! Since it's a new file, can you please run the pep8 code reformat to get rid of all possible pylint complaints?

Where is this documented ? pep8 is not available by default on our voboxes.

If you have the wmagent unittest environment, then you have it, though I don't know the pep8 syntax for that, I just use it from the IDE (PyCharm in my case, learned from Eric :))

If you want the developers to follow some syntax convention, check for that convention in the jenkins tests. If I get suggestions from the jenkins tests I will follow them. I am not going to do anything more myself though.

Jenkins reports only a summary for that, otherwise it would be way way too much verbose and it would be impossible to browse GH PRs. E.g.
AlanWorkingBook:WMCore amaltaro$ alias pylt
alias pylt='pylint --rcfile=/Users/amaltaro/PycharmProjects/WMCore/standards/.pylintrc'
AlanWorkingBook:WMCore amaltaro$ pylt SimpleCondorPlugin.py
Warning: option comment is obsolete and it is slated for removal in Pylint 1.6.
Warning: option ignore-iface-methods is obsolete and it is slated for removal in Pylint 1.6.
************* Module SimpleCondorPlugin
W:467, 0: TODO: remove when 8.5.7 is deployed (fixme)
C:114, 0: Line too long (172/160) (line-too-long)
C:162, 0: Exactly one space required after comma
                for index,job in enumerate(jobsReady):
                         ^ (bad-whitespace)
C:221, 0: Exactly one space required after comma
                (newStatus,location) = jobInfo[job['gridid']]
                          ^ (bad-whitespace)
C:240, 0: No space allowed after bracket
            if job['globalState'] in [ 'Complete', 'Error' ]:
                                     ^ (bad-whitespace)
C:240, 0: No space allowed before bracket
            if job['globalState'] in [ 'Complete', 'Error' ]:
                                                           ^ (bad-whitespace)
C:286, 0: No space allowed after bracket
                    for condorFile in [ condorOut, condorErr, condorLog ]:
                                      ^ (bad-whitespace)
C:286, 0: No space allowed before bracket
                    for condorFile in [ condorOut, condorErr, condorLog ]:
                                                                        ^ (bad-whitespace)
C:495, 0: Line too long (167/160) (line-too-long)
C:567, 0: Exactly one space required after comma
            classAds.append((ad,1))
                               ^ (bad-whitespace)
R: 30, 0: Too many instance attributes (15/7) (too-many-instance-attributes)
C:144,12: Invalid variable name "cluster_ad" (invalid-name)
C:145,12: Invalid variable name "proc_ads" (invalid-name)
W:147,12: Specify string format arguments as logging function parameters (logging-not-lazy)
W:150,19: Catching too general exception Exception (broad-except)
W:125,27: Unused argument 'info' (unused-argument)
W:195,15: Catching too general exception Exception (broad-except)
R:250, 4: Method could be a function (no-self-use)
W:325,15: Catching too general exception Exception (broad-except)
W:347,39: Catching too general exception Exception (broad-except)
W:348,36: Specify string format arguments as logging function parameters (logging-not-lazy)
R:322, 8: Too many nested blocks (7/5) (too-many-nested-blocks)
W:359,35: Catching too general exception Exception (broad-except)
W:360,32: Specify string format arguments as logging function parameters (logging-not-lazy)
R:365, 4: Method could be a function (no-self-use)
R:383, 4: Method could be a function (no-self-use)
W:419,19: Catching too general exception Exception (broad-except)
C:468, 8: Invalid variable name "params_to_add" (invalid-name)
C:469, 8: Invalid variable name "params_to_skip" (invalid-name)

though mine complains about "invalid-name", which I don't care because we usually use camel case naming. Maybe jenkins is not using the rc file under standards(?)
If you prefer I can reformat the code and send it to you. But please, have a look at it and setup your development environment, needless to say, this improves the quality of the code and makes the code more readable.

@amaltaro You can have jenkins report it as an additional "check" that links to the output of pylint from the "details" link (instead of having jenkins update it as a comment)

+1,000,000 to the above suggestion: the Jenkins bot causes so much noise and email that I tend to  not read tickets carefully.  I'd much rather it give either a X or a checkmark and a link to where I can read more.
The Jenkins bot makes DMWM tickets hard to read.

I'm always willing to entertain suggestions, but I guarantee you that no one is going to follow a link if we don't fail the PR. Should I fail every PR that doesn't fully follow PEP-8? You will come after me with pitchforks.
We also can't actually run the pylint plugin for Jenkins. It caused some problem some time ago in the CMSSDT setup and Shahzad is loathe to re-enable it.
Personally I click the little X on PR that I am responsible for to delete out of date comments, but maybe I am the only one that can do that.

When I work with CVMFS, they absolutely reject PRs don't follow their code standards.  I suppose you could turn them into two separate checks and decide, when merging, whether you care if the second check fails.  In that case, the Github UI would say that one check failed and one succeeded.
To turn things around: why would you accept a PR that doesn't meet code standards?

+1
Accept a PR and move on or don't accept it and tell me why and what I need to fix. I don't even mind if I need to fix a lot of stuff that has nothing to do with my changes if it improves the code and makes it more adherent to standards.

I think these coding conventions are not being enforced because we cannot really isolate what comes from the new changes and what was already there. I personally would not like to add 10lines to a code and rework 1000 lines of reformatting (that sometimes cannot be completely automated).
In addition to that, we have a small enough group of WMCore contributors/developers that I was hoping we wouldn't hear "if you want me to do, then enforce it", knowing that those changes make the code better.
Just my 2c.

@amaltaro on your last comment, we either push for code convention changes or we don't. This half-way of "we want to change things but it's not supposed to be any effort or hurt" is mostly just annoying :-). Maybe we can have a campaign at some point... Only way I see to make progress on this.
I wanted to check for what pep8 tells me, but it's not even shipped with the python version we build ourselves in COMP. That should be fixed.
And yes, pep8 is in the wmagent unittest environment, but that's heavy to setup to just check code conventions. For me to use this all the time the tools need to be available in the environment I develop in, not in a separate setup. I don't use an IDE, I use shell plus emacs. Always have.


Fixing regression from #4733

Fixes regression casing behat failures on CMS.

I think this might be too simplistic - the regular expression tries to support both single and double quotes, which come out separately: https://3v4l.org/0MhfT :(
(neither this change or #4733 introduced that, the original regex suffers from the same issue)

We should be able to safely merge the two sets of matches, though: https://3v4l.org/21qve. Does this impact JS too?

The JS is not effected as it works quite differently.
Good spot, though.

Okay, tests passing, gonna merge this as it’s the simplest & safest fix for a patch release.

The regex really does need some love, trouble is there are so many variants to account for!

... and probably more

Perhaps our old friend DOMDocument might be safer (albeit probably slower).

see #4782 for improved regex on 3.x-dev


[red-knot] resolve source/stubs over namespace packages, fixes #12278

This PR tries to fix #12278. That issue doesn't have the tag help-wanted, so I'm not sure if I can contribute a fix
Summary
Expected Behaviour
In python, a module can actually be 3 things:

Regular file
Package (directory with __init__.py)
Namespace package (directory without __init__.py)

In the import logic, when resolving foo.bar.baz, we should have the following priority:
└─ foo
   └─ bar
      ├─ baz           <-- regular package over module
      │  └─ __init__.py
      └─ baz.py

works
└─ foo
   └─ bar
      ├─ baz.py        <-- module over namespace package
      └─ baz           <-- namespace package invisible (because of module)
         └─ ...

doesn't work
Current Implementation
Currently, the code properly imports regular packages over modules, but when a namespace package is here, it makes a module with the same name invisible, which is the opposite of what we want.
We want to guarantee 3 things:

Regular package has priority over module (covered in existing test)
Module has priority over namespace package (new test)
A namespace package is made invisible by a module of the same name (new test)

Fixes
We have 2 core problems in our logic:

We properly resolve a namespace package when a module of the same name exists
When a package (root, regular, namespace) is located and we try to resolve the last component foo

If foo is a directory, we consider it's a regular package

If the foo directory was a namespace package, it fails and we don't test foo as a module

If foo is not a directory, we try to resolve it as a module

This is fixed by:

Adding a check in package resolution to skip shadowed namespace packages
Changing the way we resolve modules to not rely on foo being a directory

We directly check foo/__init__
If that doesn't work, we fallback to foo

Test Plan
The issue #12278 introduces a unit test that should pass after the issue is fixed.
This test is included in the PR.

That issue doesn't have the tag help-wanted, so I'm not sure if I can contribute a fix

There's no problem working on an issue that doesn't have the help-wanted tag, it just slightly increases the risk that there are unexplored complexities or we aren't sure how we want to address it yet :) It might be a good idea to comment on the issue before you start work, to reduce the chance of wasted work because two people work on an issue at once, or because the issue is stale, or whatever.

And in this particular case, the contribution is very welcome!

Going to leave review on this one to Alex and Micha, who are more familiar with the module resolver implementation.


submitting bugfix from shubh0508

Closes #565

Codecov Report

Merging #568 (7621af6) into main (0ed597a) will decrease coverage by 4.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   90.37%   86.31%   -4.06%
==========================================
  Files          78       78
  Lines        4563     4554       -9
  Branches      946      946
==========================================
- Hits         4124     3931     -193
- Misses        250      422     +172
- Partials      189      201      +12

Flag
Coverage Δ

unittests
86.31% <0.00%> (-3.91%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

hummingbird/ml/_topology.py
68.87% <0.00%> (-16.72%)
:arrow_down:

...ummingbird/ml/containers/sklearn/tvm_containers.py
17.24% <0.00%> (-75.87%)
:arrow_down:

.../ml/operator_converters/_linear_implementations.py
75.55% <0.00%> (-22.23%)
:arrow_down:

...ird/ml/operator_converters/onnx/one_hot_encoder.py
62.50% <0.00%> (-18.75%)
:arrow_down:

...tor_converters/_one_hot_encoder_implementations.py
92.45% <0.00%> (-3.78%)
:arrow_down:

hummingbird/ml/operator_converters/sklearn/mlp.py
88.88% <0.00%> (-3.71%)
:arrow_down:

hummingbird/ml/convert.py
79.24% <0.00%> (-2.84%)
:arrow_down:

hummingbird/ml/supported.py
90.43% <0.00%> (-2.61%)
:arrow_down:

...mmingbird/ml/containers/sklearn/onnx_containers.py
87.50% <0.00%> (-2.35%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed597a...7621af6. Read the comment docs.


gcc process hangs

Trying to build a gcc cross-compiler for Haiku, gcc hangs on the following test code (taken directly from configure script):
echo '#include <math.h>' > conftest.h
gcc -Werror -Winvalid-pch -Wno-deprecated -x c++-header conftest.h -o conftest.h.gch
echo '#error "pch failed"' > conftest.h
echo '#include "conftest.h"' > conftest.cc
gcc -Werror -Winvalid-pch -Wno-deprecated -c conftest.cc

Test is 100% reproducible on my system.

Tried strace on that last gcc?

This is what I get attaching strace to the hung gcc process:
root@localhost:~# strace -p7421
strace: Test for PTRACE_O_TRACESYSGOOD failed, giving up using this feature.
Process 7421 attached

Have you by chance tried this on a more recent Windows Insider Preview build?

Yes, this part seems to be fixed.


sort systems list by display_name & score fields

@kgaikwad, works perfect with individual params, but when I combine the two eg. ?order_by=memory_score&order_how=DESC, it doesn't. Could you check if the same is happening in your local?

Tested the PR locally. LGTM :+1:
@apuntamb regarding ?order_by=memory_score&order_how=DESC make sure you surround the API in curl command with double quotes

Merged, thanks @kgaikwad !! :+1:


feat: added unit tests and migrations

Ref: CPLP-3548
Description
decline registration for an application id
Why
decline registration for an application id
Issue
Ref CPLP-3548
Checklist
Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally
[x] I have added tests that prove my changes work
[x] I have checked that new and existing tests pass locally with my changes
[x] I have commented my code, particularly in hard-to-understand areas

accedently closed pr #578 because I deleted the branch

closing to reopen a new pr as author is not the developer


test(extension): add e2e debug running

Checklist

[ ] JIRA - <link>
[ ] Proper tests implemented
[ ] Screenshots added.

coverage: 52.751%. remained the same
when pulling 208a994d2c8608c559744a3e99ac34b7e62bc2e0 on add-instruction-on-running-debug-e2e-tests
into 26ae249f3e1bc1a080ffd34325a9a0284288b5f2 on main.


[ISSUE-707] volume release label added

Purpose
Resolves #707
Add release label in addition to app
PR checklist

[x] Add link to the issue
[x] Choose Project
[x] Choose PR label
[x] New unit tests added
[x] Modified code has meaningful comments
[ ] All TODOs are linked with the issues
[ ] All comments are resolved

Testing
In progress

/ci


ScheduledTask: Unable to enter Debug Mode

Details of the scenario you tried and the problem that is occurring
Enabling DSC debug with Enable-DSCDebug -BreakAll and then running the ScheduledTask resource returns an error:

PowerShell DSC resource MSFT_ScheduledTask  failed to execute Test-TargetResource functionality with error message: Object reference not set to an instance of an object.

Verbose logs showing the problem
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = Resourcetest,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName'
 = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer REDACTED with user sid SID REDACTED.
WARNING: [REDACTED]:                            [DSCEngine] Warning LCM is in Debug 'ResourceScriptBreakAll' mode.  Resource script processing will be stopped to wait for PowerShell script debugger to attach.
VERBOSE: [REDACTED]:                            [DSCEngine] Importing the module C:\ProgramData\PuppetLabs\puppet\cache\lib\puppet_x\dsc_resources\ComputerManagementDsc\DscResources\MSFT_ScheduledTask\MSFT_ScheduledTask.psm1 in force mode.
DEBUG: [REDACTED]:                            [DSCEngine]
namespace ScheduledTask
{
    public enum DaysOfWeek
    {
        Sunday = 1,
        Monday = 2,
        Tuesday = 4,
        Wednesday = 8,
        Thursday = 16,
        Friday = 32,
        Saturday = 64
    }
}
VERBOSE: [REDACTED]: LCM:  [ Start  Test     ]  [[ScheduledTask]DirectResourceAccess]
VERBOSE: [REDACTED]:                            [[ScheduledTask]DirectResourceAccess] Importing the module MSFT_ScheduledTask in force mode.
WARNING: [REDACTED]:                            [[ScheduledTask]DirectResourceAccess] Resource is waiting for PowerShell script debugger to attach.  Use the following commands to begin debugging this resource script:
Enter-PSSession -ComputerName REDACTED -Credential <credentials>
Enter-PSHostProcess -Id 10792 -AppDomainName DscPsPluginWkr_AppDomain
Debug-Runspace -Id 2
VERBOSE: [REDACTED]: LCM:  [ End    Test     ]  [[ScheduledTask]DirectResourceAccess] False in 0.5150 seconds.PowerShell DSC resource MSFT_ScheduledTask  failed to execute Test-TargetResource functionality with error message: Object reference not set to an instance of an object.
    + CategoryInfo          : InvalidOperation: (root/Microsoft/...gurationManager:String) [], CimException
    + FullyQualifiedErrorId : ProviderOperationExecutionFailure
    + PSComputerName        : localhost

VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 1.603 seconds

Suggested solution to the issue
See the below issue for the same problem in a different DSC module:
https://github.com/PowerShell/SqlServerDsc/issues/448
The DSC configuration that is used to reproduce the issue (as detailed as possible)
No configuration to provide
The operating system the target node is running
OsName               : Microsoft Windows Server 2016 Standard
OsOperatingSystemSKU : StandardServerEdition
OsArchitecture       : 64-bit
WindowsBuildLabEx    : 14393.3053.amd64fre.rs1_release_inmarket.190612-1836
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

Version and build of PowerShell the target node is running
PSVersion                      5.1.14393.3053
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3053
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Version of the DSC module that was used ('dev' if using current dev branch)
<IP_ADDRESS>

Thanks for raising this @ShawnHardwick.
Are you able to share the DSC Config you're using (with specifics redacted)? @johlju - do you recall what the exact cause of this problem was over in SqlServerDsc?

In the SqlServerDsc case it was a parameter that set a default value from another parameter
param
(
    [Parameter(Mandatory = $true)]
    [System.String]
    $InstanceName

    [Parameter()]
    [System.String]
    $FailoverClusterGroupName = "SQL Server ($InstanceName)"`
)

Maybe it fails on this?
https://github.com/PowerShell/ComputerManagementDsc/blob/0b394479d03f2594476b123c3762b7ebee03334b/DSCResources/MSFT_ScheduledTask/MSFT_ScheduledTask.psm1#L787

@PlagueHO
I actually use Puppet to call DSC so I'll provide what Puppet calls and what I call directly to debug the code.
$invokeParams = @{
Name = 'ScheduledTask'
Method = 'test'
Property = @{
taskname = 'OneDrive Mapper'
actionexecutable = 'C:\OneDrive_Mapper\OneDrive_Mapper.exe'
scheduletype = 'AtLogOn'
enable = $true
delay = '00:00:30'
}

$result = Invoke-DscResource @invokeParams

@ShawnHardwick to just rule this out. In these locations can you remove the = [System.DateTime]::Today from all three locations.
https://github.com/PowerShell/ComputerManagementDsc/blob/0b394479d03f2594476b123c3762b7ebee03334b/DSCResources/MSFT_ScheduledTask/MSFT_ScheduledTask.psm1#L262
https://github.com/PowerShell/ComputerManagementDsc/blob/0b394479d03f2594476b123c3762b7ebee03334b/DSCResources/MSFT_ScheduledTask/MSFT_ScheduledTask.psm1#L787
https://github.com/PowerShell/ComputerManagementDsc/blob/0b394479d03f2594476b123c3762b7ebee03334b/DSCResources/MSFT_ScheduledTask/MSFT_ScheduledTask.psm1#L1637
Than in the start of each function Get-TargetResource, Test-TargetResource and Set-TargetResource please add these rows. Alternative to adding the below rows, you could add the StartTime parameter with a valid value.
if (-not $PSBoundParameters.ContainsKey('StartTime'))
{
    $StartTime = [System.DateTime]::Today
}

This is the only thing I can see that is close to the problem in SqlServerDsc, it would be nice to rule it out.

That appears to have fixed it. I can use Enable-DSCDebug -BreakAll to open a debugger in DSC now with the ScheduledTask resource.

Thanks @johlju - great info. I'll look at incorporating changes into the resource over the weekend.
@ShawnHardwick , in answer to your question, I very rarely use DSC debugging, generally relying on unit tests/integration tests. I try to use a red-green refactor (TDD) approach when writing resources. This doesn't eliminate the need for debugging, but does make it a rare enough occurrence.
I'm not completely sure why the conditions @johlju identified would have caused problems debugging DSC, but I'll look into it a bit more. Might also be something we can test for as well.


Set WaterfallStepContext.Parent correctly

Fixes https://github.com/microsoft/botbuilder-js/issues/2714

Corrects WaterfallStepContext.parent change in https://github.com/microsoft/botbuilder-js/pull/2480
JS Tracking issue for 2480: https://github.com/microsoft/botbuilder-js/issues/2162
Original .NET issue: https://github.com/microsoft/botbuilder-dotnet/issues/3854
.NET PR: https://github.com/microsoft/botbuilder-dotnet/pull/3855

Pull Request Test Coverage Report for Build 158732

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.873%

Totals

Change from base Build 158344:
0.02%

Covered Lines:
15152

Relevant Lines:
17390

💛  - Coveralls


Issues importing

I just tried to use this in a pretty minimal Vitepress project and ran into two issues:

It still ships CommonJS code, which in my setup leads to

Stefnotch@STEFNOTCH-PC MINGW64 /c/Coding/GitHub/Other/Blog (main)
$ npm run dev

> dev
> vitepress dev docs

vitepress v1.0.0-alpha.40
failed to load config from C:\Coding\GitHub\Other\Blog\docs\.vitepress\config.ts
failed to start server. error:
 ReferenceError: require is not defined in ES module scope, you can use import insteadad                                                                                r/dist/vitepress-plugin-auto-sidebar.mjs:1:11
    at file:///C:/Coding/GitHub/Other/Blog/node_modules/vitepress-plugin-auto-sidebar/dist/vitepress-plugin-auto-sidebar.mjs:1:11
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

npm i vitepress-plugin-auto-sidebar  should probably be npm i -D vitepress-plugin-auto-sidebar

Hey @stefnotch !
Thanks for your issue. Can you create a CodeSandbox so we can recreate the bug.
CommonJS can be removed. You are also welcome to create a PR for the Vite Config.
Thank you !

Of course, here you go. It's the minimal Stackblitz (hopefully close enough to CodeSandbox) project that Vitepress provides in their documentation, plus this plugin https://stackblitz.com/edit/vite-4j53c5?file=docs/.vitepress/config.ts
Typescript ends up being unhappy

Same here... 'require is not defined...'

Thank you very much for the report. I’ll take a look at it soon!

New version is released 1.0.6 with many tech improvements and bug fixes: https://github.com/JonathanSchndr/vitepress-plugin-auto-sidebar/commit/329516ebceb41aec8588aa4e52661da512ce616d


Allow reprocess invoice without duplicate

Useful guide for cancelling grpc stream from client: https://chromium.googlesource.com/external/github.com/grpc/grpc/+/HEAD/examples/python/cancellation/


re-enable yesod-auth-oauth2

It appears that the issues have been addressed.

Appears not unfortunately

My bad, I didn't realize the changes to yesod-auth-oauth2 weren't released yet. I'll ping when it's released.

I reran the travis builds. They are failing for a separate reason now, so this one should (actually) be good to go.

Yup, thanks for the ping Dan!


Dynamically chaining filters from array

Hello @YuAo and everyone using this great framework,
I have an array of different filters stored as [MTIFilter] and I'd like to loop through the array and hook the filters together.
for filter in filters {
   filter.inputImage = previousFilter.outputImage // filter.inputImage is unavailable
}

Sorry if I've overlooked something, but what is the best way to dynamically add a filter.outputImages to a previousFilter.inputImage?
Thank you for your time!
Ian
Checklist

[x] I've read the README
[x] I've searched for existing GitHub issues

Hello, @ibprojects have you find any solution Please tell me


decode call uses invalid arguments

Since this commit was merged it looks to me like Auth0Service::decodeJWT will pass an invalid argument:
return Auth0JWT::decode($encToken, $this->client_id, $this->client_secret, $this->secret_base64_encoded);
but the decode method expects
public static function decode($jwt, $valid_audiences, $client_secret, array $authorized_iss = [])
which results in:
Type error: Argument 4 passed to Auth0\\SDK\\Auth0JWT::decode() must be of the type array, boolean given

I could create a pull request for this if you'd like, changing the configuration options to accept an array of authorized_iss and removing the secret_base64_encoded

Ran into the same problem. Any news on this topic?

@jankramer  It looks like this is fixed in master since April, just needs to be tagged.
Seems the Auth0Service class could also be cleaned up a little, the $this->secret_base64_encoded is assigned in the constructor but not actually a property. Also $oauth_client is never used.

I  added a pull request which cleans up the things mentioned in my last comment.

Thx for the PR. I will check this and try to merge this today.
Sorry for the delay with this issue.

Released under 2.0.1 let me know how this goes

@glena @mickadoo Thanks, that fixed it :+1:

I'm still getting this, v3

@OscarOrSomething can you clarify what you mean by v3? The latest tag is 2.0.2

"auth0/login": "~3.0" is in my composer.json, Will try making it ~2.0

Still not working
        "auth0/login": "~2.0"

Authorization: Bearer e.....
Route::group(['middleware' => ['web']], function () {
  Route::get('/api/protected', array('middleware' => 'auth0.jwt', function() {
	return "Hello";
  }));
});

Type error: Argument 4 passed to Auth0\SDK\Auth0JWT::decode() must be of the type array, null given, called in /home/oscar/Projects/T4A/t4ashop/vendor/auth0/login/src/Auth0/Login/Auth0Service.php on line 91

Just realised this is the wrong repo, I guess I should make an issue at auth0/laravel-auth0 ?

Sorry, Wrong repository, Solved this by adding authorized_issuers to my config and not using an expired token. Soryr

So guys, can I close this issue? it is fixed for all of you right?

Probably, Yeah.

thx


Failed to run examples

See image below

Thanks for checking out zng!
breakpad-sys built ok in the Mac CI 3 days ago.
I don't have access to a Mac right now, can you try running this upstream example, see if it builds?

I cannot reproduce the issue, Google found one other instance of it happening however, fixed by updating your system maybe.
You could also try building without the "crash_handler" cargo feature, it is enabled by default, the examples/Cargo.toml defines the reps for all examples.

Added a README note for macOS (#197). If updating your system does not fix the issue leave a comment and I will reopen it.


OSError: 121

I just got a this libary installed and pluged in and when I run any thing that retruns a map it reads this error:
Traceback (most recent call last):       File "/home/pi/Desktop/IMU_MPU6050.py", line 7, in <module>        accelerometer_data = IMU.get_gyro_data()       File "/home/pi/.local/lib.python3.9/site-packages/mpu6050/mpu6050.py, line 235, in get_gyro_data          z = self.read_i2c_word(self.GYRO_ZOUT0)       File "/home/pi/.local/lib.python3.9/site-packages/mpu6050/mpu6050.py, line 87, in read_i2c_word         low = self.bus.read_byte_data(self.address, register + 1)       File "/home/pi/.local/lib/python3.9/site-packages/smbus/util.py", line 59, in validator         return fn(*args, **kwdefults)       File "/hoome/pi/.locallib/python3.9/site-packages/smbus/smbus.py", line 132, in read_byte_data
raise IOError(ffi.errno)
OSError: 121

Changed wires so thay connect straight to my pi an it works now (check sudo i2cdetect -y 1 twice).


LICENSE ISSUES

you can´t fork the code from @micha37-martins and put a license on it.

Thanks @chripo for pointing this out. But I see a duty on my side to put a license on the repo.

License added, feel free to close this issue.


Add viz as upstream dependency

Have a main and upstream-dev branch that tests for incoming changes from viz as well as other dependencies
Related to https://github.com/NCAR/geocat-viz/issues/128

Was reminded about the importance of having this in the latest bit of work on viz/examples.
I'd love to get this in place ASAP and happy to do it if that's helpful.

That'd be great thanks @kafitzgerald

We should also do something along the lines of what's mentioned in NCAR/geocat-comp#503


Support monorepos which are not workspaces

https://github.com/DarthGandalf/advent-of-code/issues/85

We implemented another way of checking the solution existence here: https://github.com/CodSpeedHQ/Advent/commit/26e3e7bebdb7adfdcd584aabd926c468c96006be


cmake: add override for CMAKE_STAGING_PREFIX in SDK

By setting this variable, all projects built against the SDK using cmake
will be installed under the SDK sysroot's "/usr" directory (unless they
override the CMAKE_INSTALL_PREFIX explicitly).
This helps when building third-party libraries: getting installed in the
standard locations under the SDK sysroot means that they can be found by
tools like pkg-config with no additional effort.
See https://github.com/Pelagicore/software-factory-blueprint/pull/17 for
the discussion which led to this choice.

Just incase you wonder: yes, I've tested this :-)
The override file is installed under /opt/pelux/2.3.1/sysroots/x86_64-pokysdk-linux/usr/share/cmake/OEToolchainConfig.cmake.d/StagingPrefix.cmake and does its job.


Crashes with  you must return a valid, non-null value from getEventData, or override dispatch and dispatchModern. Event: onFastImageLoadStart

Describe the bug
Event: you must return a valid, non-null value from getEventData, or override dispatch and dispatchModern. Event: onFastImageLoadStart
com.facebook.react.uimanager.events.d in dispatch at line 42
com.swmansion.reanimated.NodesManager in handleEvent at line 1
com.swmansion.reanimated.NodesManager in onEventDispatch at line 12
com.facebook.react.uimanager.events.f in c at line 28
com.dylanvann.fastimage.c in e at line 248
com.dylanvann.fastimage.FastImageViewManager in onAfterUpdateTransaction at line 3
To Reproduce
I switched to use this fork  from https://github.com/DylanVann/react-native-fast-image
Expected behavior
Does not crash
Screenshots
Dependency versions

React Native version: 0.73.6
React version: 18.2.0
React Native Fast Image version: release-v8.6.10

Note: if these are not the latest versions of each I recommend updating as extra effort will not be taken to be backwards compatible, and updating might resolving your issue.

@giantslogik This comes in debug mode and prod both.
and can you elaborate more with screenshots or video.

@giantslogik does this comes in debug mode and prod both.
and can you elaborate more with screenshots or video.

@giantslogik Found the issue . Will fix

@deepanshushuklad11 thanks ! Happy to find a maintained fork of this excellent library. Will try and PR anything i can fix/improve. Did you do any work on the Android Preloading? I'm trying to determine the cause of https://github.com/DylanVann/react-native-fast-image/issues/657 .

@deepanshushuklad11 thanks ! Happy to find a maintained fork of this excellent library. Will try and PR anything i can fix/improve. Did you do any work on the Android Preloading? I'm trying to determine the cause of DylanVann/react-native-fast-image#657 .

You are saying preloading doesn't work on android ?

@giantslogik I checked the issue its related to getEventData should be overridden and return empty object instead of null.
Since this is working on newer version of react-native i am not prioritising this at this moment.
I will be working on  fabric support  so i will take care of this in the same .
If you are blocked on this i can suggest you a patch if needed

@deepanshushuklad11  I'm back to using the original branch with a patch i wrote for android preloading: https://github.com/DylanVann/react-native-fast-image/issues/657#issuecomment-2312378889 . Will try this fork after i upgrade RN.


⚠ ClamAV has degraded performance

In 3bdd9a6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 201 ms

Resolved: ClamAV performance has improved in 904bc18.


Validate access key and secret key before writing into the .aws/credentials file

I don't know how or why, but I have started getting these errors while running awless:
goroutine 1 [running]:
github.com/wallix/awless/vendor/github.com/aws/aws-sdk-go/aws/session.Must(0x0, 0x2378fe0, 0xc42018ef20, 0x0)
	/private/tmp/awless-20180516-58126-6k4tue/src/github.com/wallix/awless/vendor/github.com/aws/aws-sdk-go/aws/session/session.go:276 +0x54
github.com/wallix/awless/vendor/github.com/aws/aws-sdk-go/awstesting/mock.glob..func1(0x1788f4d)
	/private/tmp/awless-20180516-58126-6k4tue/src/github.com/wallix/awless/vendor/github.com/aws/aws-sdk-go/awstesting/mock/mock.go:20 +0x128

vrnchndk:~ varun$ awless
panic: SharedConfigLoadError: failed to load config file, /Users/varun/.aws/credentials
caused by: key-value delimiter not found: (MISSING)

I then checked the /Users/varun/.aws/credentials file, and found this:
[...]
aws_access_key_id = ...
aws_secret_access_key = ...

[-i-00e692f182eef653f-disk-alarm]
aws_access_key_id = 90%!
(MISSING)aws_secret_access_key = 75%!
(MISSING)

The name -i-00e692f182eef653f-disk-alarm is a cloudwatch alarm name, which I was trying to delete like this (which used to work flawlessly before:
awless -p <PROFILE> list alarms --filter description=-i- --filter state=INSUFFICIENT_DATA --columns name,description,state --format csv | cut -d, -f1 | while read line; do awless -p <PROFILE> delete alarm name=\'"$line"\' -f --no-sync; done

I am still wondering how that profile got into the credentials file. Any insight would be really helpful.

Hi @varunchandak ,
Thanks again for reporting. That's a strange one ! AFAIK, the only place whereawless edit the .aws/credentials file is in create accesskey save=true and when no credentials are found at launch, with a credentials prompter.
The only explanation I can find is in the latter: perhaps a profile had no credentials. Thus awless prompted the credentials and if this was occurring in a script, the injected values might be wrong:
For example:
Cannot resolve AWS credentials for profile 'inexistant' (AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY)
Please enter access keys for profile 'inexistant' (stored at ~/.aws/credentials):
AWS Access Key ID? aaaaaa
AWS Secret Access Key? aaaaa
Change your profile name (or just press Enter to keep 'inexistant')? aaaa

✓ Credentials for profile 'aaaa' stored successfully in ~/.aws/credentials

$ cat ~/.aws/credentials
[aaaa]
aws_access_key_id = aaaaaa
aws_secret_access_key = aaaaa

Do you think this might be the problem ?

I think so.. sometimes I would get this prompt in the middle of a batch script execution despite have the credentials configured properly. I believe the prompt occurred and the values from the script output got entered in it.
Why do you think that the entries were done automatically ? Shouldn't there be some kind of validation for access key or secret key ?

Yes, for now there is no validation for the access key and secret key, we should add that to prevent such a bug.

I think Access Key is 20 characters and secret key is 40 characters. I have 6 profiles and the count in each of them is same.


Testing a connection after config setup

Just setting up this extension for the first time...
I have a workspace in the explorer and I have just set up a sftp.json config that has been placed in the .vscode directory.
How can I now test the connection and ensure my config is correct? Anyway to browse the remote side (to see if it connects) or do I literally have to test by performing a sync or downloading/uploading a file?

Run view: show  sftp in Command Palette.

Got it, thanks. Bit slow though :open_mouth:


Add required_kw_fieldnames

This PR adds a new function, required_kw_fieldnames, which returns a tuple of the fieldnames required (without default arguments) in the keyword constructor for the given type.
I think we can use this to trim down the aliases list in all the repos.
What's implemented is not really efficient, but this is only done once per struct and will help trim down maintaining lists of parameters. In theory this method could be added to julia Base, and @kwdef could determine this list more efficiently at macro expansion time.
I've updated the ParamBox example to use this as a demo. It's almost looking generic enough that we could make a generic constructor, but I think it's compact enough with this that users can work with the raw components and we can further abstract later if needed. This new function already stretches things as it is (i.e., requiring certain constructor types for the boxes).

I think this is trying to be a bit too fancy.


How to use "merge: false" in api.extendPackage

Version
4.0.5
Environment info
  System:
    OS: Linux 4.15 Ubuntu 18.04.3 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 12.1.0 - /usr/local/bin/node
    Yarn: 1.19.1 - /usr/bin/yarn
    npm: 6.12.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 78.0.3904.70
    Firefox: 70.0
  npmGlobalPackages:
    @vue/cli: 4.0.3

Steps to reproduce
Create a plugin and try to override a field in package.json in a generator.
What is expected?
In the documentation of api.extendPackage(), it is stated that "Nested fields are deep-merged unless { merge: false } is passed."
What is actually happening?
I don't see any part that handles this case in the code, I don't known how to override a field :slightly_frowning_face:

Building a preset and was just wondering this exact thing.

That comment was outdated documentation referring to an option that was removed long before @vue/cli 3 stable release. It will be added back in the next version.


Missing File in Phoenix Grid?

I've just completed download of the Phoenix Grid files. 162G in 1d 13h!
I tried to run through the tutorial for simulating a spectra with Phoenix instead of Sonora:
https://gollum-astro.readthedocs.io/en/latest/tutorials/gollum_demo_Sonora_and_BDSS.html
When trying to create the grid with:
grid = PHOENIXGrid(wl_lo=wl_lo, wl_hi=wl_hi)
it got to about 73% and then stopped with the following traceback:
"AssertionError: Double check that the file D:\PHOENIX\phoenix.astro.physik.uni-goettingen.de\HiResFITS\PHOENIX-ACES-AGSS-COND-2011/Z-4.0/lte07800-3.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits exists"
I checked my files and it is indeed missing. ~/Z-4.0/lte07800-2.50* and ~/Z-4.0/lte07800-3.50* are both there, but not 3.00
Looking back in my terminal log, it appears as though the download didn't even look for ~/Z-4.0/lte07800-3.00*
it just went straight from 2.5 to 3.5.
Is the file missing? Is there a way to get just that file to complete the grid? Is there a way to turn ignore that missing grid point?
I'm not sure what I should do. Please advise.

Fascinating! Thank you for opening this issue!  I think for the very low metallicities (-4 metallicity is ultra metal poor) the PHOENIX grid itself may not have computed all logg values, so indeed this is a bug: gollum should know about the underlying presence or absence of all the PHOENIX grid points, and it currently does not.  By deafult, the code snippet as you wrote it attempts to read in the entire grid:
grid = PHOENIXGrid(wl_lo=wl_lo, wl_hi=wl_hi)

I recommend delimiting the grid to a subset--- a limited range in temperature, a limited range in surface gravity, and a limited range in metallicity in the following way:
grid = PHOENIXGrid(wl_lo=wl_lo, wl_hi=wl_hi, teff_range=[2800, 3300],
                          logg_range=[3.0, 5.0],
                          metallicity_range=[-0.5, 0.5])

A side benefit is that reading in this smaller subset of the grid will take less time.
Your missing grid point makes me realize that my code may have missed the possibility of jagged grid arrays, so you thank you again for raising this friction point to my attention! 🙏

Ah! specifying the ranges of temp, logg and metallicity makes so much sense. I didn't think of that because I didn't realize those were adjustable parameters just from following the tutorial. But of course I don't need the entire grid! (it makes so much sense now that I understand better how it works, haha)
I had found several more missing files btw, though mostly confined to the extremes of the entire grid. For reference, the missing grid points are:
~/Z-4.0/lte07800-3.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08000-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08200-3.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08200-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08200-4.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08400-3.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08400-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08400-4.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08600-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08600-4.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08800-3.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte08800-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09000-3.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09000-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09000-4.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09200-3.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09200-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09200-4.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09400-3.50-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z-4.0/lte09400-4.00-4.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte09600-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte09800-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte10000-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte10200-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte10400-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte10600-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte10800-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte11000-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte11200-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte11400-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte11600-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte11600-2.50+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte11800-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte11800-2.50+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte12000-2.00+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte12000-2.50+1.0.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+0.5/lte11000-2.00+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+0.5/lte11200-2.00+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+0.5/lte11400-2.00+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+0.5/lte11600-2.00+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+0.5/lte11800-2.00+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+0.5/lte12000-2.00+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+0.5/lte12000-5.50+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
~/Z+1.0/lte12000-5.50+0.5.PHOENIX-ACES-AGSS-COND-2011-HiRes.fits
I agree that the grid should account for missing files or jagged arrays as you put it. Also, I recommend noting in the tutorial that loading in the entire grid is excessive, slow and eats up too much memory. After trying to apply a temporary patch by simply copying adjacent arrays and renaming them (in order to get a full set so it would stop complaining) my computer ran out of resources at 100% completion and couldn't render the dashboard.
Limiting the parameter ranges as suggested allowed it to load exponentially faster and reduced the overhead so I could load multiple instances in separate cells with no memory issues. It works great now! Thank you!

Closed by #59
Thank you @Tusay for raising this issue! Let us know if anything else in the same vein arises.


Implement alert schema and routes

Create an alert schema to allow users create, retrieve, edit and delete alerts. The schema should have the following properties such as title, description, image, location. Timestamps should also be set to true

Gave rise to #13


[Feature request] Specify number of significant digits for lat/lon coordinates?

Problem Description
I'm working with netCDF files that have a spatial resolution of 1.25 degrees. However, on some of these files, the coordinates have a trailing float so that -88.75 becomes -88.750008 etc. When using xr.open_mfdataset, this means that rather than having lat/lon dimensions of (145, 288) like I would see on a single file, I have lat/lon dimensions of (230, 467) and nans interspersed throughout the dataset due to misaligned grids. Therefore, it would be useful to be able to limit the number of trailing digits to 2 or 3 so that I don't run into this issue in the future!
MCVE Code Sample
d_mf=xa.open_mfdataset(flist_rean['JRA'])
v1=d_mf['ua'].isel(time=0,plev=21)
print(v1)
# which returns:
<xarray.DataArray 'ua' (lat: 230, lon: 467)>
dask.array<shape=(230, 467), dtype=float32, chunksize=(230, 467)>
Coordinates:
  * lat      (lat) float64 -90.0 -88.75 -88.75 -87.5 ... 88.75 88.75 90.0 90.0
  * lon      (lon) float64 0.0 1.25 2.5 3.75 3.75 ... 357.5 357.5 358.8 358.8
#... etc. As you can see, there are multiple values for these coordinates!

#if we look at the values:
v1.values
array([[-15.603317  , -15.665817  , -15.728317  , ..., -15.447067  ,
                 nan, -15.540817  ],...#truncated for ease of viewing

Expected Output
#This is opening a single file
x1=xa.open_dataset(flist_rean['JRA'][0]).isel(time=0,plev=21)
print(x1)
<xarray.Dataset>
Dimensions:                (lat: 145, lon: 288)
Coordinates:
  * lat                    (lat) float32 90.00001 88.75001 ... -88.75001 -90.0
  * lon                    (lon) float32 0.0 1.25 2.5 ... 357.50003 358.75003

x1['ua'].values
array([[-15.603317  , -15.665817  , -15.728317  , ..., -15.384567  ,
        -15.447067  , -15.540817  ],...#truncated for ease of viewing

Output of xr.show_versions()

INSTALLED VERSIONS
commit: None
python: 3.6.8 |Anaconda, Inc.| (default, Dec 30 2018, 01:22:34)
[GCC 7.3.0]
python-bits: 64
OS: Linux
OS-release: 4.12.14-150.27-default
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: C.UTF-8
LOCALE: en_US.UTF-8
libhdf5: 1.10.4
libnetcdf: 4.6.1
xarray: 0.11.3
pandas: 0.24.2
numpy: 1.16.2
scipy: 1.2.1
netCDF4: 1.4.2
pydap: None
h5netcdf: None
h5py: None
Nio: None
zarr: None
cftime: <IP_ADDRESS>
PseudonetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: None
cyordereddict: None
dask: 1.1.5
distributed: None
matplotlib: 3.0.3
cartopy: None
seaborn: 0.9.0
setuptools: 40.8.0
pip: 19.0.3
conda: None
pytest: None
IPython: 7.4.0
sphinx: None

Thanks for opening this issue. The underlying issue is #2217.
Until that gets solved, you can specify join='override' after updating xarray to 0.13.0. this will skip alignment and should do what you want.
Let us know if that works for you.

Hmmm. I added in the join='override' flag as suggested and it still exhibits the same behavior. However, if I do the following:
xtest=xa.open_mfdataset(flist_rean['JRA'],join='override',combine='nested',concat_dim='time')

then it seems to work!


Update slack links

Detail
Having updated in the landing page we need to review existing content to update slack link where necessary, while this issue is on the website repo it is worth also chekcign elsewhere
Actions

[ ] Search for links to previous slack
[ ] Update with invite link to new slack

Who can help
No response

done by @manics


Lapindromes

Lapindrome is defined as a string which when split in the middle, gives two halves having the same characters and same frequency of each character. If there are odd number of characters in the string, we ignore the middle character and check for lapindrome. For example gaga is a lapindrome, since the two halves ga and ga have the same characters with same frequency. Also, abccab, rotor and xyzxy are a few examples of lapindromes. Note that abbaab is NOT a lapindrome. The two halves contain the same characters but their frequencies do not match.
Your task is simple. Given a string, you need to tell if it is a lapindrome.
Input:
First line of input contains a single integer T, the number of test cases.
Each test is a single line containing a string S composed of only lowercase English alphabet.
Output:
For each test case, output on a separate line: "YES" if the string is a lapindrome and "NO" if it is not.
Constraints:
1 ≤ T ≤ 100
2 ≤ |S| ≤ 1000, where |S| denotes the length of S
Example:
Input:
6
gaga
abcde
rotor
xyzxy
abbaab
ababc
Output:
YES
NO
YES
YES
NO
NO

testCase=int(input())
while(testCase):
string=input().lower()
half=len(string)//2
if half % 2==0:
if (sorted(string[:half])==sorted(string[half:])):
print("Yes")
else: print("No")
else:
if(sorted(string[:half])==sorted(string[half+1:])):
print("Yes")
else: print("No")
testCase-=1

testCase=int(input()) while(testCase):     string=input().lower()     half=len(string)//2     if half % 2==0:         if (sorted(string[:half])==sorted(string[half:])):             print("Yes")         else: print("No")     else:         if(sorted(string[:half])==sorted(string[half+1:])):             print("Yes")         else: print("No")     testCase-=1


No option for adding trailing zeroes with numeralDecimalScale?

Great plugin! But I have some inputs that are used for entering currency values and I would like the numbers to be always formatted with 2 decimals (e.g. € 15,50).
So, in this example (https://jsfiddle.net/h7d9gn03/) I would like the input to show 12.50 instead of 12.5. There is no option for that, is there? Any plans to add this feature?

Sorry, I think this was up in a previous release 😃, but you will need to pass a string as raw value, in your case '12.50':
https://jsfiddle.net/sxeubwq1/

Close this, let me know if you still have problem.

Hi,
Same issue for me, I didn't understand how to fix this.
Desired behavior: the user types in 1234 -- as soon as "1" is keyed in ".00" is appended, as soon as "4" is typed in the comma is appended (the comma works well), end result is 1,234.00.
I don't know if the user experience will be good with the above behavior so maybe a better version would be that once they tab away from the input field (i.e., onblur() is called) either .00 is appended if the input is an integer, or "0" is appended if the input has a tenth part and not a hundredth part (e.g., 12.5)
Please let me know if cleave can achieve something like what I described above, I need this in real time or onblur. It sounded like the proposed solution mentioned above was static and didn't apply to my case.
I will probably write my own extension to conditionally add the .00 or 0 onblur(), just wanted to see if there was a built in option for this, I didn't see it in the documentation.
Thank you!
Sasha

@Shurasik Unfortunately, no built-in option is like that, the lib only handles the formatting.
Cheers.


⚠ Bofrost.fr has degraded performance

In fb7595c, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1301 ms

Resolved: Bofrost.fr performance has improved in dc599b8.


data-required is not working while using dynamically in parsley validator

Hi
I am using the parsley validate plug-in to validate my form. But when I am add the attribute ' data-required="true" ' manually through jquery based on the radio button option select by client.
please any one help me or guide me right path for this problem.
thanks
Kumar Shanmugam

I've got the same problem. I manually add required attribute only when user selected a certain option. I'm using parsley.js with Step Form Wizard http://ajoke.cz/wizard2/site/index, and i need to validate manually added required before user moves to next step.

For the scenario when there is a validation error showing and myinput is no longer required, then parsley needs to be called somehow.
The best way is probably to $myinput.trigger('input'), basically faking that the user has modified that input. If there's an error showing, validation will be redone.
Closing this, please provide CodePen if there's still an issue.

New version of parsley.js(2.3.6) did the trick. It works ok, now.