Correct way to implement RNN if looping over tensor is yet not allowed

Click to expand!
Issue Type
Support
Have you reproduced the bug with TF nightly?
No
Source
source
Tensorflow Version
2.11
Custom Code
No
OS Platform and Distribution
MaxOS 12.3.1
Mobile device

Python version
3.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
M1 Max 26 cores GPU 32 GB ram
Current Behaviour?
it throws : Iterating over a symbolic `tf.Tensor` is not allowed: AutoGraph did convert this function. This might indicate you are trying to use an unsupported feature. yet the code in my opinion can be easily converted to a graph, just conditioned on the `tf.shape(inputs)[1]`... this would allow building RNNs that accepts long and short inputs, without having to pad it, which is extremely useful if the length of the strings in the dataset is very skewed, and we have many short phrases and few long ones

Standalone code to reproduce the issue
import tensorflow as tf
class MyModel1(tf.keras.Model):
    def __init__(self, input_text_processor, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.input_text_processor = input_text_processor
    def call(self, data, training=True, max_len=50):
        inputs = self.input_text_processor(data)
        for _ in tf.range(tf.shape(inputs)[1]):
            pass
        return []

    def train_step(self, data):
        self.call(data)
        return {"loss" : 0}
dataset = [
    "hi", "what's up", "what's the weather"
]
input_text_processor = tf.keras.layers.TextVectorization()
input_text_processor.adapt(dataset)
with tf.device("/CPU:0"):
    model = MyModel1(input_text_processor)
    model.compile(tf.optimizers.Adam(), loss=tf.keras.losses.SparseCategoricalCrossentropy())
    hist = model.fit(dataset, epochs=5)

Relevant log output
Epoch 1/5
Traceback (most recent call last):
  File "/Users/username/ml/tensorflow-journey/39-rnn-enc-dec-attention/rnn-enc-dec-attention.py", line 23, in <module>
    hist = model.fit(dataset, epochs=5)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/ml-apple-metal-3-10/lib/python3.10/site-packages/keras/utils/traceback_utils.py", line 70, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/opt/homebrew/Caskroom/miniforge/base/envs/ml-apple-metal-3-10/lib/python3.10/site-packages/tensorflow/python/framework/func_graph.py", line 1269, in autograph_handler
    raise e.ag_error_metadata.to_exception(e)
tensorflow.python.framework.errors_impl.OperatorNotAllowedInGraphError: in user code:

    File "/opt/homebrew/Caskroom/miniforge/base/envs/ml-apple-metal-3-10/lib/python3.10/site-packages/keras/engine/training.py", line 1249, in train_function  *
        return step_function(self, iterator)
    File "/opt/homebrew/Caskroom/miniforge/base/envs/ml-apple-metal-3-10/lib/python3.10/site-packages/keras/engine/training.py", line 1233, in step_function  **
        outputs = model.distribute_strategy.run(run_step, args=(data,))
    File "/opt/homebrew/Caskroom/miniforge/base/envs/ml-apple-metal-3-10/lib/python3.10/site-packages/keras/engine/training.py", line 1222, in run_step  **
        outputs = model.train_step(data)
    File "/Users/username/ml/tensorflow-journey/39-rnn-enc-dec-attention/rnn-enc-dec-attention.py", line 13, in train_step
        self.call(data)
    File "/Users/username/ml/tensorflow-journey/39-rnn-enc-dec-attention/rnn-enc-dec-attention.py", line 8, in call
        for _ in tf.range(tf.shape(inputs)[1]):

    OperatorNotAllowedInGraphError: Iterating over a symbolic `tf.Tensor` is not allowed: AutoGraph did convert this function. This might indicate you are trying to use an unsupported feature.

use tf.cond to conditionally execute the loop based on the input length
In the code, the for loop is iterating over a tf.Tensor object created by tf.range(tf.shape(inputs)[1]). This tensor has a symbolic shape, which means that its size is not known until runtime. TensorFlow's AutoGraph cannot handle iterating over such symbolic tensors, as it requires knowing the size of the tensor at graph construction time.
import tensorflow as tf

class MyModel1(tf.keras.Model):
    def __init__(self, input_text_processor, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.input_text_processor = input_text_processor

    def call(self, data, training=True, max_len=50):
        inputs = self.input_text_processor(data)
        def loop_body(i):
            return i+1
        i = tf.constant(0)
        cond = lambda i: tf.less(i, tf.shape(inputs)[1])
        i = tf.cond(tf.less(tf.shape(inputs)[1], max_len), lambda: tf.shape(inputs)[1], lambda: max_len)
        tf.while_loop(cond, loop_body, [i])
        return []

    def train_step(self, data):
        self.call(data)
        return {"loss" : 0}

dataset = [
    "hi", "what's up", "what's the weather"
]
input_text_processor = tf.keras.layers.TextVectorization()
input_text_processor.adapt(dataset)

with tf.device("/CPU:0"):
    model = MyModel1(input_text_processor)
    model.compile(tf.optimizers.Adam(), loss=tf.keras.losses.SparseCategoricalCrossentropy())
    hist = model.fit(dataset, epochs=5)

OUTPUT
Epoch 1/5
1/1 [==============================] - 0s 471ms/step - loss: 0.0000e+00
Epoch 2/5
1/1 [==============================] - 0s 18ms/step - loss: 0.0000e+00
Epoch 3/5
1/1 [==============================] - 0s 49ms/step - loss: 0.0000e+00
Epoch 4/5
1/1 [==============================] - 0s 13ms/step - loss: 0.0000e+00
Epoch 5/5
1/1 [==============================] - 0s 18ms/step - loss: 0.0000e+00

thank you so much, finally I was able to do it with your hint... please consider adding more examples in the docs for tf.while_loop, in order to make it work I had to fight for a while with shape_invariants and what to do if I want more than one input for the body of the loop... Also, I would like to ask what should I use in the shape_invariants if I have a list of vector (say for example the state of a LSTM, which is [h_state, m_state])
Anyway, thank you so much

@AlbertoSinigaglia It's my pleasure to help.
If you have a list of vectors as the state of a LSTM in TensorFlow, you can use a tuple of TensorShape objects in the shape_invariants argument of the tf.function decorator to specify the shape of each vector.

@pat749  that makes total sense, thank you so much


Initial support for NATS publisher

This is a first iteration to add NATS support for publishing events.
The command line flag -nats-server was added to specify the server URL and -dump was modified to support a nats value.    Launching NATS from the command line looks like this:
./bin/gobmp -nats-server nats://localhost:4222 -dump nats

I verified the events were being generated with nats stream info:
State:

             Messages: 10,966
                Bytes: 10 MiB
             FirstSeq: 1 @ 2023-05-05T04:41:57 UTC
              LastSeq: 10,966 @ 2023-05-05T04:43:12 UTC
     Active Consumers: 0
   Number of Subjects: 6

and that the events were correct for each subject:
[10] Subject: gobmp.parsed.evpn Received: 2023-05-05T04:41:57Z

  Hash: 12de97c6ddc064947b35baadd1002bf9

{"action":"add","router_hash":"12de97c6ddc064947b35baadd1002bf9","router_ip": ... }

NATS terminology and implementation varies slightly from Kafka.  NATS uses subjects instead of topics and publishes messages to subjects.  I included the key, which equates to the router hash, in the header of the published message instead.
The acceptance criteria was a quick and simple implementation that worked and was backwards compatible, nothing more.

Related to #218

Thank you for PR, since I do not have NATS infra, it is hard for me to test nats publisher functionality. Could you please share some output frmo NATS side just to see the messages are getting in.

@sbezverk thank you for the response!  I'm carrying an image of my branch in a k8s deployment that is currently consuming BMP from our route reflectors and the events are correctly being published into their specific "topics" (NATS subjects).
From the NATS output in the previous comment, you can see over 10,000 messages received that are spread across the appropriate topics.  Here is a more recent breakdown that shows the gobmp stream receiving the messages (the RRs carry a lot of EVPN):
# nats stream subjects
? Select a Stream gobmp

            gobmp.parsed.ls_node:     13           gobmp.parsed.ls_link:     20
          gobmp.parsed.ls_prefix:     14        gobmp.parsed.statistics:    165
               gobmp.parsed.peer:     15              gobmp.parsed.evpn: 29,652

Here is a redacted gobmp.parsed.peer:
{"action":"add","router_hash":"76e94565076d98cb3ced5700f208f775","remote_bgp_id":"<IP_ADDRESS>","router_ip":"<IP_ADDRESS>","timestamp":"2023-05-05T14:17:26Z","remote_asn":64XXX,"remote_ip":"172.16.X.X","peer_type":0,"peer_rd":"0:0","remote_port":64133,"local_asn":65XXX,"local_ip":"X.X.X.X","local_port":179,"local_bgp_id":"10.81.X.X","adv_cap":{"1":[{"capability_value":"ABkARg==","capability_descr":"Multiprotocol Extensions for BGP-4 : afi=25 safi=70 BGP EVPN "}],"128":[{"capability_descr":"Prestandard Route Refresh (deprecated)"}],"2":[{"capability_descr":"Route Refresh Capability for BGP-4"}],"64":[{"capability_value":"QHg=","capability_descr":"Graceful Restart Capability"}],"65":[{"capability_value":"AAD//A==","capability_descr":"Support for 4-octet AS number capability"}],"71":[{"capability_descr":"Long-Lived Graceful Restart (LLGR) Capability"}]},"recv_cap":{"1":[{"capability_value":"ABkARg==","capability_descr":"Multiprotocol Extensions for BGP-4 : afi=25 safi=70 BGP EVPN "}],"128":[{"capability_descr":"Prestandard Route Refresh (deprecated)"}],"2":[{"capability_descr":"Route Refresh Capability for BGP-4"}],"64":[{"capability_value":"QHg=","capability_descr":"Graceful Restart Capability"}],"65":[{"capability_value":"AAD8Jg==","capability_descr":"Support for 4-octet AS number capability"}],"71":[{"capability_descr":"Long-Lived Graceful Restart (LLGR) Capability"}]},"remote_holddown":90,"adv_holddown":90,"is_l":false,"is_prepolicy":false,"is_ipv4":true,"is_adj_rib_in_post_policy":false,"is_adj_rib_out_post_policy":false,"is_loc_rib_filtered":false}

Here is an example EVPN message:
{"action":"del","router_hash":"76e94565076d98cb3ced5700f208f775","router_ip":"X.X.X.X","base_attrs":{"base_attr_hash":"0ae0a8ba138a294ead0bb379a70171ae","is_atomic_agg":false},"peer_hash":"ac7bdbec0e7eeab6a6030df9f4534b34","remote_bgp_id":"10.80.X.X","peer_ip":"172.16.X.X","peer_type":0,"peer_asn":64XXX,"timestamp":"2023-05-06T00:48:16Z","is_ipv4":true,"is_nexthop_ipv4":true,"vpn_rd":"172.16.X.X:20473","vpn_rd_type":0,"eth_tag":"AAAAAA==","ip_address":"172.16.X.X","ip_len":32,"route_type":3,"is_adj_rib_in_post_policy":true,"is_adj_rib_out_post_policy":false,"is_loc_rib_filtered":false}

I plan on improving this publisher as I continue development, but so far it's working as expected and I'm generating key/values from the events in our data warehouse.
Let me know if you want me to do something more specific.

I had some free time so I created a test as a PR on my forked repository that you can view here: https://github.com/jarrodb/gobmp/pull/1
This PR introduces a simple test of the NATS publisher.  Before running the test, the following elements are created:

in-memory NATS server
NATS connection for subscribing
NATS Publisher
BMP Server

The test sends the bytes for a PeerStateChange to the BMP Server, which tests a production flow that parses the message and publishes the event.
Finally, the test subscribes to the gobmp topic/subject and compares a couple of attributes from the body (Action and RouterHash)


Styling fix for components

this PR seems to have a lot of different fixes all rolled together - can we please split them up at least by component? otherwise it's a bit hard to review the changes


Implement RISCVInstrDecoder class for RV32I

RV32I decoding is quite similar to MIPS, well defined in https://content.riscv.org/wp-content/uploads/2017/05/riscv-spec-v2.2.pdf#page21
Your objective is to copy the MIPS decoding class
https://github.com/MIPT-ILab/mipt-mips/blob/d5952500347608ac6c625529d0ba4e343cc96663/simulator/mips/mips_instr_decode.h#L2
and use RV32I patterns instead. Additionally, you have to implement a following method:
    uint32 get_immediate(char type) const;

which would produce an immediate value based on type (encoded as a ASCII character, like 'B' or 'J')
Unfortunately, there are no compatible unit tests for RISCV so far, so you have to implement them yourself.

@agrachiv99 Looks that you can do the similar parser for three more points (I'm not able to label on the mobile version), but that time you need unit tests.

Just noticed this comment. I have already assigned to two issues, so i will take this issue later, if nobody will take it before


cmd/operator-sdk/olmcatalog/gen-csv.go: --write-config to write CSV config to disk

Description of the change:
internal/pkg/scaffold/olm-catalog: Use a CSVConfigFile in a CSV scaffold directly instead of reading from a file. CSVConfig is now a scaffold that contains a CSVConfigFile with the actual data to write.
cmd/operator-sdk/olmcatalog/gen-csv.go: Add --write-config flag so users can write a CSV config to a default path or the one passed to --csv-config.
Motivation for the change: #1259 does not directly pertain to the changes here but brought to my attention that CSV config files are not well understood. --write-config should help because it creates a default config with all fields populated.

/retest

After thinking about this further, its probably better to have a olm-catalog write-csv-config command so a user doesn't have to (re)write their CSV just to get a config.

/hold
Going to wait on this until we figure out configuration file issues.

/remove-lifecycle


Better docs for Controller::reconcile_on

The unstable method currently suggests that this method can be used to help share a store with the reconciler. This is actually nothing specific to reconcile_on, and you can do the same with the streams interface with watches_stream.
(We made the reconcile_on right before watches_stream became a thing so this makes sense.)
Have reworded the example to highlight that this has a better use-case with actually getting arbitrary third-party info, and then mapping that to kubernetes objects.
Planning on putting whatever we settle on here as the de-facto example for "external relations" on https://kube.rs/controllers/relations/#external-relations as it would be good to have something that compiled that i can refer it to.

(CI required a fixup in https://github.com/kube-rs/kube/pull/1305)

Maybe it'd be better to hide the boilerplate from the example but instead just have an external_stream and show a mapping to an ObjectRef.
Pseudo:
struct ExternalObject {
    name: String,
}

let external_stream = watch_external_objects().map_ok(|ext| ObjectRef::new(&format!("{}-cm", ext.name)).within(&ns));

That sounds a lot better to me as well. Ended up making a doc hidden function and refer to it using your name to help indicate that you are meant to write this yourself. Updated the post and image above.
Have used a very dumb signature for this hidden fn;
fn watch_external_objects() -> impl Stream<Item = ExternalObject> { stream::iter(vec![]) }

as a way to help the people who go digging, but can also show this line by default if we think it is helpful.

Note there is also a bit of an interesting quirk about this fn as it stands; it needs a kube::runtime::watcher::Error as the error type for the input stream.. This is typically not what users would have available if they are reconciling from an external resource...
Not sure what to do about that at the moment. I can change the example to highlight it with:
diff --git a/kube-runtime/src/controller/mod.rs b/kube-runtime/src/controller/mod.rs
index 69399d89..0c46fc58 100644
--- a/kube-runtime/src/controller/mod.rs
+++ b/kube-runtime/src/controller/mod.rs
@@ -1107,13 +1107,13 @@ where
     /// # let client: Client = todo!();
     /// # async fn reconcile(_: Arc<ConfigMap>, _: Arc<()>) -> Result<Action, Error> { Ok(Action::await_change()) }
     /// # fn error_policy(_: Arc<ConfigMap>, _: &kube::Error, _: Arc<()>) -> Action { Action::await_change() }
-    /// # fn watch_external_objects() -> impl Stream<Item = ExternalObject> { stream::iter(vec![]) }
+    /// # fn watch_external_objects() -> impl Stream<Item = Result<ExternalObject, kube::runtime::watcher::Error>> { stream::iter(vec![]) }
     /// # let ns = "controller-ns".to_string();
     /// struct ExternalObject {
     ///     name: String,
     /// }
-    /// let external_stream = watch_external_objects().map(|ext| {
-    ///     Ok(ObjectRef::new(&format!("{}-cm", ext.name)).within(&ns))
+    /// let external_stream = watch_external_objects().map_ok(|ext| {
+    ///     ObjectRef::new(&format!("{}-cm", ext.name)).within(&ns)
     /// });
     ///
     /// Controller::new(Api::<ConfigMap>::namespaced(client, &ns), Config::default())

but it's probably better to shift the signature of this function to not get an user error type passed in

ok, if we are to omit the Error type, we would still have to pack it into a Result<X, watcher::Error> internally in that case because it all gets packed into the trigger_selector of type stream::SelectAll<BoxStream<'static, Result<ReconcileRequest<K>, watcher::Error>>> on Controller
We could do that in the signature by doing:
diff --git a/kube-runtime/src/controller/mod.rs b/kube-runtime/src/controller/mod.rs
index 69399d89..cd85f241 100644
--- a/kube-runtime/src/controller/mod.rs
+++ b/kube-runtime/src/controller/mod.rs
@@ -1113,7 +1113,7 @@ where
     ///     name: String,
     /// }
     /// let external_stream = watch_external_objects().map(|ext| {
-    ///     Ok(ObjectRef::new(&format!("{}-cm", ext.name)).within(&ns))
+    ///     ObjectRef::new(&format!("{}-cm", ext.name)).within(&ns)
     /// });
     ///
     /// Controller::new(Api::<ConfigMap>::namespaced(client, &ns), Config::default())
@@ -1125,15 +1125,14 @@ where
     /// ```
     #[cfg(feature = "unstable-runtime-reconcile-on")]
     #[must_use]
-    pub fn reconcile_on(
-        mut self,
-        trigger: impl Stream<Item = Result<ObjectRef<K>, watcher::Error>> + Send + 'static,
-    ) -> Self {
+    pub fn reconcile_on(mut self, trigger: impl Stream<Item = ObjectRef<K>> + Send + 'static) -> Self {
         self.trigger_selector.push(
             trigger
-                .map_ok(move |obj| ReconcileRequest {
-                    obj_ref: obj,
-                    reason: ReconcileReason::Unknown,
+                .map(move |obj| {
+                    Ok(ReconcileRequest {
+                        obj_ref: obj,
+                        reason: ReconcileReason::Unknown,
+                    })
                 })
                 .boxed(),
         );

which I think is better?

Seems definitely simpler, also the watcher::Error doesn't really make sense for anything external, but is there any benefit to having the controller handle the errors?

It doesn't seem super beneficial once it's made it into the applier:
Any errors passed in there are turned into a QueueError:  https://github.com/kube-rs/kube/blob/68ae55c4337f01f71ffaa27dd4d25dc99a4b5c47/kube-runtime/src/controller/mod.rs#L277-L278
and this is the error type returned by the Controller stream meaning you can pick up on this as in the example: https://github.com/kube-rs/kube/blob/68ae55c4337f01f71ffaa27dd4d25dc99a4b5c47/examples/configmapgen_controller.rs#L114-L118
so you can get back a more nested error than the one literally saw earlier :upside_down_face:

There is a dubious benefit before it reaches the applier because we apply a global StreamBackoff on the queuestream:
https://github.com/kube-rs/kube/blob/68ae55c4337f01f71ffaa27dd4d25dc99a4b5c47/kube-runtime/src/controller/mod.rs#L1271-L1273
so if users posted Err objects into reconcile_on they would get the backoff policy attached to the combined stream which i guess would help them "not retry errors too frequently" if they didn't do any error handling on the input stream and kept spamming us with errors.
We probably don't want to encourage this though. If they are spamming us with errors they can take down the controller (because the backoff is global and continued triggering of it could starve the input stream). Plus it sends the wrong message that they don't need to handle the errors from the 3rd party / external api because they can pass it to us - and that only hurts them long term.

It's less about kube-rs handling those errors, and more about ensuring that applications can have the choice of propagating them through to wherever it makes sense to handle them.

But what can you reasonably do with these errors in the Controller? Yes you could have a common/joined error handler, but what option does that actually give you other than logging and ignoring?
I feel like you end up with a better design if you handle these errors where they occur and then you can make the decision whether to trigger the controller anyways or not.

Yeah. The example is meant to be a type-only stand-in for a typically much larger external interface module in your application that deserves to have its own error handling not interwoven with the controller side (which often is not so big).
All the use cases I have for this does not even have a stream as input, but will rather produce a synthetic stream via periodic fetching on external APIs / or listening to POST /reconcile events, and then chose to emit accepted items through some other way (put some ideas for this in a callout in this section).


[opentelemetry-exporter-azure-monitor] Rename monitor package

Per discussions amongst other languages, we are renaming to align to an OT-friendly naming convention as well as migrating this package to the broader @microsoft scope. As part of this, we're also resetting the version number to use the new beta suffix.
This change only renames the directory and updates name and version constants. No functional changes have been made.

@praveenkuttappan @KarishmaGhiya  do either of you know what's going on with the CI check for the README?

I wonder if it's choking because this package is now in @microsoft instead of @azure ?

@praveenkuttappan @KarishmaGhiya do either of you know what's going on with the CI check for the README?

I wonder if it's choking because this package is now in @microsoft instead of @azure ?

I am looking into it. I think change log check is mostly not finding package details for @ microsoft

I am looking into it. I think change log check is mostly not finding package details for @ microsoft

Can I get an ETA on when you think you'll be able to solve it? I just want to give an accurate update to the feature crew. 😄

Fix coming in from here: https://github.com/Azure/azure-sdk-tools/pull/1187
Thanks @praveenkuttappan 👍


Feat/basic settings page

Pull Request
Checklist

[x] Have you read Digital Catapult's Code of Conduct?
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.

PR Type
Please delete options that are irrelevant.

[ ] Bug Fix
[ ] Chore
[x] Feature
[ ] Documentation Update
[ ] Code style update (formatting, local variables)
[ ] Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets
https://digicatapult.atlassian.net/browse/VR-248
High level description
Allows user to view the settings page.
Detailed description
Settings page with a reset button and the only editable field being the admin email.
https://github.com/user-attachments/assets/bbda54f9-1000-402e-a77e-7ce639a897d2
If DEMO_MODE is false
https://github.com/user-attachments/assets/dc50a632-1f8a-4d3f-84f5-b2fcb228cfa8
Describe alternatives you've considered
N/A
Operational impact
Additional context

Coming to this unfamiliar with the repo so please ignore if I'm wrong. In the video, I'd expect the settings icon in the sidebar to be highlighted when you're on the settings page, it highlights the top icon instead?


Column::extend

Hi,
when I want to use Column::extend variable $value is null instead of value of column
$grid->title('Subscriber')->is_subscriber()->sortable();

Column::extend('is_subscriber', function ($value) {
	dump($value);
});

I use the version 1.4.x-dev
Do I make some mistake?
Thanks.

It works fine for me.
Are you put the extend definition in app/Admin/bootstrap.php?

Yes of course extend definition is in app/Admin/bootstrap.php
When I add variable to extend definition
Column::extend('is_subscriber', function ($value, $var) {
	dump($value);
        dump($var);
});

$grid->title('Subscriber')->is_subscriber('some content')->sortable();
$var return 'some content'
$value null
I have done Form::extend class and it work fine, but Column::extend not.
I tried also version 1.5, but result was same.

@abufalbo show us your code in app/Admin/bootstrap.php
I had same issue when I typed next:
use Encore\Admin\Grid\Column;
use app\Admin\Extensions\SelectState;
Column::extend('selectState', SelectState::class);

and in Column::$displayers I had next row:
"selectState" => "app\Admin\Extensions\SelectState"
So I fixed it in app/Admin/bootstrap.php with:
Column::extend('selectState', 'App\Admin\Extensions\SelectState');
But when i changed


OSD: Pull operator/controller images by digest

To accommodate ICSP, guarding against a quay outage, pull the operator images by digest for OSD, causing the operator to pull the (same) image for the controllers by digest as well.
OperatorHub is not affected.
HIVE-1504

/assign @jharrington22 :)
/cc @joelddiaz

:+1: from me. Just want to make sure this works for @jharrington22 and the rest of SRE


The build is broken...

I tried to build it with gcc-8.3.0 under haiku i got the following error:
/boot/home/Desktop/sff/qvterm/qvterm.cpp: In member function 'int QVTerm::settermprop(VTermProp, VTermValue*)':
/boot/home/Desktop/sff/qvterm/qvterm.cpp:739:45: error: no matching function for call to 'QVTerm::iconTextChanged(VTermStringFragment&)'
             emit iconTextChanged(val->string);
                                             ^
In file included from /boot/home/Desktop/sff/qvterm/qvterm.cpp:1:
/boot/home/Desktop/sff/qvterm/qvterm.hpp:64:10: note: candidate: 'void QVTerm::iconTextChanged(QString)'
     void iconTextChanged(QString iconText);
          ^~~~~~~~~~~~~~~
/boot/home/Desktop/sff/qvterm/qvterm.hpp:64:10: note:   no known conversion for argument 1 from 'VTermStringFragment' to 'QString'
/boot/home/Desktop/sff/qvterm/qvterm.cpp:742:42: error: no matching function for call to 'QVTerm::titleChanged(VTermStringFragment&)'
             emit titleChanged(val->string);
                                          ^
In file included from /boot/home/Desktop/sff/qvterm/qvterm.cpp:1:
/boot/home/Desktop/sff/qvterm/qvterm.hpp:65:10: note: candidate: 'void QVTerm::titleChanged(QString)'
     void titleChanged(QString title);
          ^~~~~~~~~~~~
/boot/home/Desktop/sff/qvterm/qvterm.hpp:65:10: note:   no known conversion for argument 1 from 'VTermStringFragment' to 'QString'

How can i fix this?

You're using a newer version of libvterm than the one bundled.  Make sure you update the submodule.
Note that while I am using this terminal daily, it's still pretty experimental until I at least get the features I'm looking for and can't find elsewhere (keyboard selection mode, location marking, performance on par with other terminals for instance) I'm not trying to closely track libvterm.  If I get to feature complete, I'll want to remove the bundling entirely and just use libvterm as provided by whatever distribution.

Sorry you're right, this is actually not a sff problem,  i forgot to mention that there wasn't a bundeld libvterm with your source code, and the build
system failed to download one, so i used the system one which gave me this error, then i cloned it manually from trunk, then the build went further.
I'm gonna open a new issue for the new error it's in Qt code.

@jsbronder commented on Apr 2, 2020:

You're using a newer version of libvterm than the one bundled.

Are you willing to push your patches upstream?
https://github.com/neovim/libvterm/compare/master...jsbronder:libvterm:sff
Or, in general, are you going to work with the upstream trunk anytime soon? Which would be:
http://bazaar.leonerd.org.uk/c/libvterm/
https://www.leonerd.org.uk/code/libvterm/
Thanks in advance.

Or, in general, are you going to work with the upstream trunk anytime soon? Which would be: http://bazaar.leonerd.org.uk/c/libvterm/ https://www.leonerd.org.uk/code/libvterm/

I did and never heard back, for example:
From: Justin Bronder<EMAIL_ADDRESS>Date: Mon, 11 May 2020 19:40:59 -0400
To<EMAIL_ADDRESS>Cc: Justin Bronder<EMAIL_ADDRESS>Subject: [PATCH] Use appropriate pen when reallocating screen cell buffers
X-Mailer: git-send-email 2.24.1

Feel free to see if you have better luck ;)


rsvg support

MyWikis recently had a client report to us that ImageMagick was incorrectly thumbnailing some of their SVG files. Following in the Wikimedia Foundation's footsteps, we switched to using rsvg and the results are great. It may be a good idea to add rsvg support for Canasta; this would mean setting SVG thumbnail generation to using rsvg, like so:
$wgSVGConverter = 'rsvg';

Can I work on this Issue? I am just starting out on contributing to this project.

@amalpaul54111 Thanks for your interest! Yes, absolutely.
rsvg will need to be added to the image. Installing rsvg will need to be done within the Dockerfile.
Please see this page for more info on how rsvg works in MediaWiki: https://www.mediawiki.org/wiki/Manual:$wgSVGConverters

Thanks for your help.

This seeems to have been completed back in June...


profil is missing from PVOnline results

Describe the bug
the "profile" fields results from PVOnline api is always missing from every ingredient
To Reproduce

go to ingredients inventory
switch to PVOnline search
search any ingredient
profile fields is always unknown

Expected behavior
correct profile value as with previous versione of the api
Screenshots

Additional context
PV version 8.9
"profile" fields is missing from the api response in /modules/suppliers/pvOnline.php on pvPost($pvOnlineAPI, $data),
this is a print_r of one record:
[16] => stdClass Object
              (
                  [id] => 2033
                  [cid] => 83268
                  [name] => Dimetol
                  [IUPAC] => 2,6-dimethylheptan-2-ol
                  [INCI] => 2,6-dimethylheptan-2-ol
                  [cas] => 13254-34-7
                  [einecs] => 236-244-1
                  [odor] => Fresh dihydrolinalool floral woody citrus herbal
                  [allergen] => 0
                  [physical_state] => 1
                  [structure] => iVBORw0KGgoAAAANSUhEUgA.... ..... TkSuQmCC
                  [techData] => stdClass Object
                      (
                          [XLogP] => 2.7
                          [formula] => C9H20O
                          [flash_point] => N/A
                          [molecular_weight] => 144.25
                      )

                  [ifra] => stdClass Object
                      (
                          [id] => 0
                      )

              )

Not a bug, profile field isn't available in PV Online

But it was available on previous api


Add eas env:push and env:pull commands

Why
User should be able to synchronise local environment variables with upstream.

https://linear.app/expo/issue/ENG-11920/add-eas-envpush-command
https://linear.app/expo/issue/ENG-11919/add-eas-envpull-command

How

added eas env:pull and eas env:push commands
eas env:pull handles sudo access to request values of sensitive variables

Test Plan
Tested manually

@wschurman @szdziedzic Ok, I'll work on SSO. I think the flow will be similar to that of login via SSO and I'll reuse some of its logic


Migrate ActionController::Base to ApplicationController

rails g model User name:string
will generate migration as shown below.
class CreateUsers < ActiveRecord::Migration
  def change
    create_table :users do |t|
      t.string :name
      t.timestamps null: false
    end
  end
end

In Rails 5 the same command will generate following migration.
class CreateUsers < ActiveRecord::Migration[5.0]
  def change
    create_table :users do |t|
      t.string :name
      t.timestamps
    end
  end
end

hey @bronzdoc I think you mixed the title of the issue with the description of another issue here

@arielj fixed it 👍


et2lst result "ampm" doesn't have the AM/PM add-on

The function et2lst, given an ephemeris epoch, computes the local solar time for an object on the surface of a body at a specified longitude. Here are the inputs and returned values:
    Inputs:
      float  et   = Epoch in seconds past J2000 epoch.
      int    body = ID-code of the body of interest.
      float  lon  = Longitude of surface point (radians).
      string type = Type of longitude, "PLANETOCENTRIC", etc.

    Returns:
      int    hr   = Local hour on a "24 hour" clock.
      int    mn   = Minutes past the hour.
      int    sc   = Seconds past the minute.
      string time = String giving local time on 24 hour clock.
      string ampm = String giving time on AM/PM scale.

The ampm value is missing its 'AM'/'PM'. For example, When this code runs:
import cspyce as cs
from gettestkernels import CoreKernels

cs.furnsh(CoreKernels.testMetaKernel)
et = cs.str2et("2004 may 17 16:30:00")
hr, mn, sc, time, ampm = cs.et2lst(
    et, 399,<PHONE_NUMBER>0000004 * cs.rpd(), "planetocentric")

print(ampm)

The current result is 11:19:22. The expected result is 11:19:22 A.M.. Since the result represents a 12-hour timescale, this label is necessary to correctly represent the time.

Whoever wrote this interface thought that ampm returned "A.M." or "P.M."
rather than the entire time.
There are two occurrences of 10 that need to be changed to TIMELEN in
my_et2lst() in cpsyce0.i. (Lines 2859ff). Apparently 10 characters wasn't
long enough to write out the result, so it didn't even try.
Change both occurrences of ampm[10] to ampm[TIMELEN] and the code should
work fine.
Reassigning to Emilie.
On Mon, Jun 12, 2023 at 12:00 PM esimpsons3ti @.***>
wrote:

Assigned #86 https://github.com/SETI/pds-cspyce/issues/86 to @fyellin
https://github.com/fyellin.
—
Reply to this email directly, view it on GitHub
https://github.com/SETI/pds-cspyce/issues/86#event-9506543625, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABC2LIKVPWROVFJJ3YJ5TLDXK5RNZANCNFSM6AAAAAAZDZLWJ4
.
You are receiving this because you were assigned.Message ID:
@.***>


pylepton_overlay error Raspbian Bullseye

I am trying to run ./pylepton_overlay on Raspbian Bullseye (32bit).  Python is the system default v3.9.2.  I get this error in execution:
File "/home/pi/projects/pylepton/./pylepton_overlay", line 26, in main
o = camera.add_overlay(np.getbuffer(a), size=(320,240), layer=3, alpha=int(alpha), crop=(0,0,80,60), vflip=flip_v)
File "/usr/lib/python3/dist-packages/numpy/init.py", line 214, in getattr
raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'getbuffer'
I looked around and see that Python3 "numpy" really does not have a 'getbuffer' function.  Is there a workaround for this, or an update that will run on Bullseye?
Regards,
Mike Vergara

im having the same issue. Did you ever get it resolved. thank you


Update to Kotlin 1.4.0

What does this change?

Updated to Kotlin 1.4.0
Disabled Kotlin standard libraries

What is the value of this and can you measure success?

Actually, will not affect Flutter-side.

Screenshots (Optional)

No

Codecov Report

Merging #18 into master will increase coverage by 5.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   67.90%   73.35%   +5.44%
==========================================
  Files          34       38       +4
  Lines         349      394      +45
==========================================
+ Hits          237      289      +52
+ Misses        112      105       -7

Impacted Files
Coverage Δ

lib/l10n/delegate.dart
66.66% <0.00%> (ø)

lib/ui/component/toast.dart
0.00% <0.00%> (ø)

lib/app.dart
41.66% <0.00%> (ø)

lib/ui/home/home_page.dart
86.36% <0.00%> (ø)

lib/data/model/article.dart
20.00% <0.00%> (+8.00%)
:arrow_up:

lib/ui/component/article_item.dart
95.65% <0.00%> (+8.69%)
:arrow_up:

lib/data/model/source.dart
36.36% <0.00%> (+18.18%)
:arrow_up:

lib/l10n/localized.dart
90.00% <0.00%> (+20.00%)
:arrow_up:

lib/util/ext/context.dart
100.00% <0.00%> (+60.00%)
:arrow_up:

lib/ui/detail/datail_page.dart
83.33% <0.00%> (+83.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7fb4b...750e0a4. Read the comment docs.


Docker Hub automated builds

There is still an issue with the docker hub automated builds. I triggered a new release to see if the build worked after the docker hub integration. However, I got an error:
Cloning into '.'...
Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
please ensure the correct public key is added to the list of trusted keys for this repository (128)

It seems that the docker integration in github needs to be configured, but I cannot access the repo settings. @jacobheun can you have a look?

Marking this as bug + addign to maintenance board because we  have https://hub.docker.com/r/libp2p/js-libp2p-relay-server but it is empty :)

Closing this issue because we have higher priorities, like relay v2. Also, this has been open > 2 years, and we're not confident in the impact if this gets done. If anyone feels otherwise, please feel free to re-open or create a new issue :)


forth: Add new tests from x-common

First commit is same as #412, the rest should bring us to match https://github.com/exercism/x-common/pull/394

Everything should be OK now - the only change is to rebase and also to fix the ordering of the over tests. I'll take a final look.


Make TensorFlow Reuse Buffers in WebAssembly

Quoting directly from https://github.com/hotg-ai/rune/issues/242#issuecomment-906305787

At the moment all data lives inside WebAssembly linear memory and the only copies that happen are when we do inference.
I think we should try to keep that property because trying to have some buffers living inside WebAssembly and others living in the host's memory sounds like a bad idea (hard to manage lifetimes, WebAssembly can't directly access host memory, etc.).
As I understand it, the inference copies are mainly because we haven't told TensorFlow Lite to read/write directly from WebAssembly memory instead of allocating its own buffers, and not due to a limitation in the Rune-Runtime interface. So an easy way to avoid copying into/out of TensorFlow is to just make it use the buffers we provide.

Okay so, this is slightly more complicated than i thought it would be.
There are 2 types of zero copy code paths:

TfLiteDelegate specific buffer handles:

/*
Set the delegate buffer handle to a tensor.

It can be called in the following cases:

    * Set the buffer handle to a tensor that's not being written by a delegate.
    For example, feeding an OpenGL texture as the input of the inference graph.
    * Set the buffer handle to a tensor that uses the same delegate.
    For example, set an OpenGL texture as the output of inference,
    while the node which produces output is an OpenGL delegate node.

WARNING: This is an experimental API and subject to change.
*/
TfLiteStatus SetBufferHandle(int tensor_index, TfLiteBufferHandle buffer_handle, TfLiteDelegate *delegate)

Just set the allocation type for various input/output tensors - this is probably the path for us to take:

  // Assigns (or reassigns) a custom memory allocation for the given tensor.
  // `flags` is a bitmask, see TfLiteCustomAllocationFlags.
  // The runtime does NOT take ownership of the underlying memory.
  //
  // NOTE: User needs to call AllocateTensors() after this. In case of input
  // resizing, buffers will be checked for required data size during
  // AllocateTensors().
  //
  // Parameters should satisfy the following conditions:
  // 1. tensor->allocation_type == kTfLiteArenaRw or kTfLiteArenaRwPersistent
  //    In general, this is true for I/O tensors & variable tensors.
  // 2. allocation->data has the appropriate permissions for runtime access
  //    (Read-only for inputs, Read-Write for others), and outlives Interpreter.
  // 3. allocation->bytes >= tensor->bytes.
  //    This condition is checked again if any tensors are resized.
  // 4. allocation->data should be aligned to kDefaultTensorAlignment
  //    defined in lite/util.h. (Currently 64 bytes)
  //    This check is skipped if kTfLiteCustomAllocationFlagsSkipAlignCheck is
  //    set through `flags`.
  //
  // WARNING: This is an experimental interface that is subject to change.
  TfLiteStatus SetCustomAllocationForTensor(
      int tensor_index, const TfLiteCustomAllocation& allocation,
      int64_t flags = kTfLiteCustomAllocationFlagsNone);

While 1) provides the best hardware acceleration, I think we have to go with 2) - simply because we don't support accelerated proc blocks right now, that can make use of such a handle..
This decision essentially limits our product scope. For people who want complete hardware acceleration (eg: real time video processing from multiple/high resolution cameras), They probably have to implement their custom solution as opposed to using Rune.
As for 2) - We shouldn't pass it dummy tensors anymore. We should be allocating the tensors we want to use for the rest of the inference.

As we've discussed on Slack, it sounds like the way TensorFlow Lite wants you to provide buffers goes directly against how WebAssembly likes its linear memory to be used.
In Rust terms, our rune_model_infer() host function is given access to a byte buffer that can only be used for the duration of the function call.
fn rune_model_infer(input_tensor_in_wasm_linear_memory: &[u8], ...) {
  ...
}

However in order to do zero-copy, the inference context can't be allowed to outlive the buffer because you'll get use-after-free bugs.
struct InferenceContext<'buffer> {
  input_tensor: &'buffer [u8],
}

This poses a bit of an issue because we'd really like to reuse the same InferenceContext across multiple rune_model_infer() calls because it avoids the expensive process of initializing an inference context and setting up hardware, but the borrow checker would reject that ("Error: the 'buffer lifetime cannot outlive the lifetime '_ as defined on the method body").
You also aren't really allowed to update the tensor buffers immediately before each infer() call because the pointer may have already been captured by a delegate and there is no way to let the delegate know about the change.

@saidinesh5 would this be covered by https://github.com/tensorflow/tensorflow/issues/46766?
In particular this bit:

The tensor input and output C APIs should have options to use input tensors in-place, from binary blobs, from either CPU/system memory or device (e.g. GPU) memory. This "zero-copy" API would remove any copy overhead and any overhead related to protobuf creation.


Add support for Windows Server 2019

The Windows Server Core Docker image is GA now  at mcr.microsoft.com/windows/servercore:1809. It already has .NET 4.7 installed, but an sdk image would be great to have (we already have them for .NET Core via PR 719).

Note the base OS images are currently not available.  See https://support.microsoft.com/en-us/help/4464619/windows-10-update-history.

@MichaelSimons - can you clarify regarding base OS image availability? I believe mcr.microsoft.com/windows/servercore:1809 has been available for a couple of weeks now, separate from the Windows 10 rollout.

Or I guess that image get removed after it had initially been made available? I have it locally but docker pull mcr.microsoft.com/windows/servercore:1809 is now failing with a not found error.

The base OS images were pulled and are no longer available.

@MichaelSimons can I ask if you got a working version of the 4.7.2 SDK on 1809 using the Dockerfiles in the rs5 branch? I've tried building using a cached local copy of the base image, but the VS Build Tools don't install.  Also tried with Chocolatey and I get the same result - no errors, but no VS 2017. Wondering if there's a missing Windows feature I need to enable?

@sixeyed - There is a compatibility issue between with 1809 OS images and the VS Installer.  The product teams are aware of the issue and a fix is forthcoming.

Thanks for the update @MichaelSimons - I'll stop trying for now :)

@sixeyed - There is a compatibility issue between the1809 OS images and the VS Installer. The product teams are aware of the issue and a fix is forthcoming.

Is there a separate issue reported on this to follow? we ran into this exact same problem few weeks back.
Best regards
Lars Jakobsen

There is not an external issue you can follow because VS is not open source.

why I cannot pull the image ？
PS C:\Users\Administrator> docker pull mcr.microsoft.com/windows/servercore:1809
Error response from daemon: manifest for mcr.microsoft.com/windows/servercore:1809 not found

@pacoxu Images have been removed from registry because of Windows bugs in 1809 release. Wait for re-release in a week or two.


Option to use external browser for authentication is ignored in latest release

Description
I have configured DBeaver to use an external browser to authenticate when connecting to a database. (This was the default setting until the latest release).

However, in the latest release, the option is ignored and the internal browser is always used regardless of the configuration options.

DBeaver Version
23.2.1
Operating System
Windows 10
Database and driver
Azure MSSQL
Microsoft JDBC Driver for SQL Server 11.2.3 JRE 11
Steps to reproduce

Use latest release.
Check browser settings to ensure external browser is selected.
Try authenticate with a database using Active Directory - MFA
See internal browser is used.

Additional context
No response

@KieranDevvs Hi, auth in the internal browser is configurable by the open auth links in the embedded browser checkbox in User Interface preferences

@KieranDevvs Hi, auth in the internal browser is configurable by the open auth links in the embedded browser checkbox in User Interface preferences

Ah yes my mistake, thanks for the help.

The page 'User Interface —> Web browser' doesn't work. We need to delete it from Preferences.


Task with async_forward_entry_setup not awaited

Getting this in the system log using version 1.0.9 of this integration:
Detected code that calls async_forward_entry_setup for integration garo_wallbox with title: {REDACTED_IP} and entry_id: {REDACTED_ID}, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.

Solved in version 2024.9.0


Editor Notification Background Color

Resolves #52

Before the new UI theme API was released the editor color scheme provided multiple theme keys to also style some UI elements like the editor notifications (NOTIFICATION_BACKGROUND like also defined in the default bundled Darcula editor color scheme).
The key allows to style the background color of notifications from the editor that are placed right below the tab bar at the top of the editor.
Previously nord4 was used that made the color almost unreadable because by default a low contrast foreground is used.
This has now been changed to use nord3 making the actual text content readable again.
Before

After

When can we see an update on this?

@ice1000 Since my time to spend for OSS is very limited (and not payed), I had no time to write the release notes and deploy v0.7.0 to the JetBrains Plugin registry. The problem this PR solved also annoys me during my day job and private coding so I'll try to push the artifact today. It'll take ~12-24h to be globally available since plugin updates need to run through JetBrains verification process before being set to "confirmed" status.

Nice!

Version 0.7.0 has been released and deployed to the Plugin Registry and will be available within the next 24h.


[NEW ICON]: TALLY Prime

Skill Name
Tally Prime - Accountings
Why?
its an indian based accounting software , so i need to add that in my profile and its too famous as same as sap https://tallysolutions.com/tally-prime/
Reference Image

Code of Conduct Acknowledgment

[X] I have read and agree to the Code of Conduct.

@LelouchFR I can make this icon if you agree.

@LelouchFR I can make this icon if you agree.

@LelouchFR I can make this icon if you agree.

yes sure !

Which one do you prefer guys? As light and dark or just filled one? @LelouchFR @WorldOfDex

I liked the third one

I liked the third one
So do I, I'll make the PR with the third one

I liked the third one

So do I, I'll make the PR with the third one

sounds good to me :)

all of them


Mocha timeout config for inso run config

This PR is related to #3608
I really need a configurable timeout for running tests via inso-cli.
This feature would really help me out with my super slow API endpoints I am writing tests for!
Any help, feedback is very much appreciated! I hope this helps the team!
Goal: inso run test "Sample Specification" --env "OpenAPI env" --testTimeout 120000
I am assuming documentation will need to be updated, tests, and etc.

@dimitropoulos can you please review this and share next steps?

Any update or review for this?

Closed as stale.


Add event hub starter for kafka binder

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #265   +/-   ##
=========================================
  Coverage     52.71%   52.71%
  Complexity      262      262
=========================================
  Files            96       96
  Lines          1214     1214
  Branches         62       62
=========================================
  Hits            640      640
  Misses          539      539
  Partials         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f093d...0897ab5. Read the comment docs.


chore: migrate to Owl-Bot using a staging directory

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

I discovered an issue.  Reverting to draft.


[HOLD for payment 2023-10-10] [$500] Request money flow is not proceeded to the next page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/26520
Action Performed:

Go to staging.new.expensify.com
Go to + > Request money
Change to the Distance tab.
Add waypoints.
When the submit button is enabled, Hit Enter on the keyboard.

Expected:
Pressing Enter should submit the Distance request.
Actual:
Enter key submission does not work on Distance Page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.62-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/b26859d3-d24c-41e0-818e-41720dcadddf
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0126a0498c5bbce06a
Upwork Job ID:<PHONE_NUMBER>999688704
Last Price Increase: 2023-09-22

related https://github.com/Expensify/App/issues/26588

thanks @parasharrajat, updated! @eVoloshchak let's get the proposal reviewed please!

Bump!

@parasharrajat's proposal looks good to me!
I think we should also apply the same fix to MoneyRequestConfirmationList/SettlementButton, it's the last step of request money flow and it also cannot be submitted by pressing enter

@parasharrajat's https://github.com/Expensify/App/issues/28022#issuecomment-1732990468 looks good to me!
I think we should also apply the same fix to MoneyRequestConfirmationList/SettlementButton, it's the last step of request money flow and it also cannot be submitted by pressing enter
🎀👀🎀 C+ reviewed!

Waiting for deploy!

Including this issue, https://github.com/Expensify/App/issues/29132, here since it also arises from the Enter key functionality and its role in navigation.
Could be a possible regression. Could be nothing.
Either way, I thought it good to mention it.

Bump @parasharrajat

@parasharrajat any update here? 🙇♂

Bump @parasharrajat

Not overdue, PR with the regression fix was deployed to staging today

Not overdue, PR is in production

@eVoloshchak thanks for the update!

Not overdue, PR with the fix was deployed to prod on Oct 30

Should be good now?

@eVoloshchak to confirm

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/26606. However, I don't think we can call this a regression, the PR description specifically states that Now this means you cannot use Enter to submit the Distance request, however, its a new feature and its going to be used in mobiles right now mainly so this is fine.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed here

Regression Test Proposal

Open the app.
Click on the FAB button > Request Money.
Select the Manual Tab.
Enter an amount.
Press Enter on the keyboard.
Verify that you are navigated to the next step (contact selector)

Do we agree 👍 or 👎
Also noting that this has caused a regression in https://github.com/Expensify/App/issues/29051

Payment summary:

Contributor: @parasharrajat $250
Contributor+: @eVoloshchak $250

Please apply in Upwork or create a NewDot request!

$250 payment approved for @eVoloshchak based on the comment above.

$250 approved for @parasharrajat


Mindmap functionality

It seems like a solid ground to implement mindmap functionality with advanced features eventually. Is that on the roadmap somehow?

Hi @ZiadJ,
Thank you for your comments.
Since v-network-graph is only a library for visualizing graph structures, there are no plans to develop features that will be used only for mindmap.
However, if there are specific suggestions or pull requests for features that are lacking in the mind map implementation, I would consider implementing them if they are basic features that would be useful in other types of applications.
Best Regards,


[DOC, WIP] Testpathchanging

Reference issue
closes #10813
What does this implement/fix?
Update path handling in examples/inverse/mixed_source_space_inverse.py
Additional information
deleted unwanted file 'untitled.py'

CI failures should be fixed by #10856. @ashdrew can you merge in main and mark as ready to review?

#10887 should fix the CI issue seen here, so when that one is green we can merge this one too.

@drammock this looks real and related to your changes
https://app.circleci.com/pipelines/github/mne-tools/mne-python/15025/workflows/63f162e4-9d50-45d7-b4f6-81b372d1a158/jobs/46392
Basically now there is some attribute of src that is a (Posix)Path, but it should be str. (Or we could improve object_hash to just treat Path like str, but for backward compat, whatever attribute of src is currently a Path should probably be converted to str.)

ah, oops, I didn't read your comment carefully enough @larsoner.  I've made it so objectsize can handle Path objects...  but you'd prefer that the value of mri_file be converted to string instead?  Is the backcompat issue that saving with new MNE-Python / loading with old MNE-Python won't work?

Is the backcompat issue that saving with new MNE-Python / loading with old MNE-Python won't work?

It's more that Path is not a superclass of str, so if someone used whatever value this was, e.g. fwd['src_fname'] (this is probably not the right key but you get the idea) in particular ways their code will now be broken. For example if someone did fwd['src_fname'] + ' (filename)' which works on main it will now be broken on this PR.
Thinking about it now, I'm not sure write_source_spaces will play nicely with this attribute being a Path. Even if it does for example by casting to str, then you'll have a str when you read the forward solution back from disk. We'd arguably want to keep those consistent. We could always cast to Path on read but this is a stronger backward compat break (now this attribute is always Path, not just when you pass one in to make_forward_solution or whatever)

ok I've ensured that mri_file will never be a Path object.  I've also left in the changes to objectsize because it seems a useful improvement... LMK if you think I should revert that.

Thanks @ashdrew @drammock !


Updates site theme to latest

git submodule update --remote --merge

https://deploy-preview-324--func-e.netlify.app/ renders fine
(travis should have canceled itself, but possibly this was due to mistaking a submodule update as a root change.. github worked properly and skipped tests)


How do I use Scrcpy to mirror my pc screen to my phone?

My laptop screen is broken so id like to use my phone

Scrvpy does not do that, only Android mirroring to pc.

Is there where I could modify the source code to achieve this?


Tweaks and support for latest salt version

Hey Shawn,
Here are some tweaks.  Took a while to just get the VM up and running, mostly because the latest version of salt caused some issues.
Still haven't proves any of the apps a working;)

Awesome! thanks. I plan on doing some work on this weekend.


FlutterLogoDecoration with Roboto doesn't render right on iOS

Noticed while fixing b/77980873.
There's probably some math issue.

https://github.com/xster/flutter-test/tree/master/t89_flutter_logo_canvas

Seems libtxt related.
A screen diff between blink and libtxt:

Given the same TextPainter, the text was laid out to different sizes.

Just tried this on modern flutter, seems to be fixed!


s3: increase chunk size

On certain machine specs, current configuration could mean you end up with too small chunk sizes, meaning total amount of chunks would exceed 10k+, which is the maximum amount s3 will allow.
This adjustment will generate slightly larger chunk sizes which should correct the issue

Some test runs were cancelled. I wonder if there are some known problems with tests at the moment, hard to see this change causing that.

Some test runs were cancelled. I wonder if there are some known problems with tests at the moment, hard to see this change causing that.

tried running make unittest locally on this branch and master and got the same amount of failures, so something is clearly wrong. Will see if I can find some time to figure out what is wrong


feat: improve gojudge-mid

Now, gojudge-mid can handle request successfully. But, it is verbose in code, has some issue in storage and should provide more functions.
TODO:

[ ] make sure all request can be storaged after handle
[ ] improve pkg/mq to unify the input and output
[ ] extract the repeated logic
[ ] #72
[ ] #57
[ ] special-judge support

Working on branch feat/refactor-gojudge-mid


Ability to establish known struct key order

Is your feature request related to a problem? Please describe.
Order of the fields in tooling that consumes go-oscal was mentioned as a point of confusion for the generation of artifacts. Would like to test if it is possible to define ordered structs for the top level models.
Describe the solution you'd like

Given Generation of a model
When a new model is written to a file
Then the order of the model fields is deterministic and ordered as intended

Describe alternatives you've considered
non-critical change
Additional context
Establish some error checking to ensure we capture drift when model is updated with new or different fields.

Current Discovery - establishing struct key order for fields requires additional input data or hard-coded values.
hard-coding the order is not scalable and introduces a lot of potential for drift and additional work on each release and update of OSCAL schemas.
The JSON schema - for which go-oscal uses to-date has no precedence towards the order of keys (and the order which specified in the schema is not the preferred order).
Using the XSD with the JSON schema provided an option towards fully-generated types with keys ordered - but the differences between the XML schema and the JSON schema presented issues with regards to natively supporting both.
At this time I believe integrating further complexity for generate and the inclusion of XSD to not be aligned with greater library support of XML as a first-class format. As such we should defer this for review in work done in #12 .


Upgraded issue templates to use GitHub issue forms

Issue no: #9

Hey @christyjacob4 @meldiron , Please review this PR.
Thank You

THANK YOU! All changes merged 🥳
Please reach out to eldadfux on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.
You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.
You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.
Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)


Windows pre-packaged distribution can't do inference, showing "In construction, please wait"

When can this UI feature be available? Any workaround to use generated weights to do TTS without this UI feature?

The In construction, please wait. refers to the Voice Conversion 2-GPT-SoVITS-Voice Changer,
Not the Text-to-Speech 1C-inference.

oh, you are absolutely right @SapphireLab . Thanks for pointing it out! I am going to close this issue.


DEO - Institutions CRUD

A DEO should be able to
For Primary Schools

[ ] Add a school to a boundary
[ ] View all schools for each boundary
[ ] Edit a school
[ ] Delete a school

For Preschool
For Primary Schools

[ ] Add a school to a boundary
[ ] View all schools for each boundary
[ ] Edit a school
[ ] Delete a school


ci: auto hub cd on update to elixir libraries

Proposed Changes
As discussed cc @hairyhum  @sobi3ch @mendrugory. This adds auto cd to hub on changes to our Elixir libraries

Closed as https://github.com/ockam-network/ockam/pull/1854 also adds this changes


[Bug] Ex Nihilo's Crucible Heat Source disfunctions on block-block update next to the heat source

When I use this script I sucessfully remove lava from heating my Crucible. However, when the lava gets any kind of ... block update (?) it resumes to smelt stuff in the crucible for a short period of time.
I am not sure whether this is reproduceable with a block update as it is really strange behaving.. here are a few examples.
On building:

On removal of a block the lava is next to:

On placing a barrel next to it: (rebuilt it)

On putting something in the barrel: (causes a block update)

This is rather weird because it only reacts to a block actually being broken next to it.
Or... is it the switch from lava going from still to flow?

Im suspecting it is because lava has 2 states, Flowing and Still, Blacklist both and get back to me.

Tried that. Though, I am unsure if I did it right. What are the unlocalized fluid names for each?

not sure...

If it reacts to a block update, (not changing the lava to flowing) then it must be on exnihilo side.

This is exnihilo side, I am unsure what is causing this... as all I am doing is removing the block from the registry...

Can you try this with the latest version from http://minecraft.curseforge.com/mc-mods/221696-ex-nihilo/files ?
I'm thinking it may be a server/client desync issue which has been changed in this version.

Will do, thank you.

http://gyazo.com/3d7c4b95f67ac62605ab1ac157afc4df
Nope ;(

OK, I believe I have fixed this in an upcoming ExN version. Note that this will need some backend change to ModTweaker though.
There is now a built-in method for removing ("unregister") which can be used.
For what it's worth, I believe the original issue is because meta's 0-15 were registered. Removing all of them solved the problem.

From what I can see, this issue was resolved and it was not modtweaker side anyway.


The FTP won't work properly

I can't edit or download files on the server I am connected to.
Here is an image of the error
http://prntscr.com/aryev1
http://prntscr.com/aryf9w
How do I fix this?

Can you post the developer console output?

Closing old issue ticket. Feel free to reopen @alleg0 if you still have problems and can provide some more info.


Explain the difference between log and console.log

Description
Both the docs and the jsDocs should clearly explain the difference between our internal logger log and console.log

@Weakky I don't think this was quite the issue. Its rather what's the difference between these:
import { log } from 'nexus-future'

// ...
ctx.log

Ahhhh, sorry about that. I think @schickling also mentioned he was confused whether he was supposed to use console.log or log though!

I remember the opposite 😂. Or maybe it was both. @schickling please the record straight here :)

Regardless anyway, I think disambiguating the three might be useful

Yes, I was indeed confused whether I should use console.log vs log but I think better docs would have already helped with this.
A further crazy idea (for the future) could be to scan the user code for occurrences of console.log and print a info/recommendation in the terminal to nudge the user to use log instead. 🙃

better docs would have already helped with this.

Website guide? Website API Docs? jsDoc?

A further crazy idea (for the future) could be to scan the user code for occurrences of console.log and print a info/recommendation in the terminal to nudge the user to use log instead.

Like #265 our logger component should tap into console.log and make it conform to pretty and JSON
We should create an ESLint plugin IF we can find a zero-config way to have users leverage ESLint. TS team and TSLint team have been moving away from TSLint for a long time now, toward ESLint.
With this in place, we can then add a rule checking for console.log instances and flagging them as warning (or info, blue underlines, rarely seen as far as I've experienced) that they should instead use logger component. Finally, we can leverage ESLint autofix feature to propose a replacement for them. And we can be smart enough to do things like use global logger if at module level or resolver context logger if in a resolver. Although may get blocked on fact that user might not have named the context parameter e.g. (root, args) => { ....


Status Bar does not hide in modal.

Description
The status bar is hidden. But when I open modal, the status bar appears again.
CodeSandbox/Snack link
https://snack.expo.dev/@pk936/moody-toffee
Steps to reproduce

Click on button to see modal.
The status bar appears, although it has hidden property set

NativeBase Version
3.3.10
Platform

[X] Android
[ ] CRA
[ ] Expo
[ ] iOS
[ ] Next

Other Platform
No response
Additional Information
No response

@pk936 Thanks for reporting this! We'll look into this.

Hi @pk936, This Issue is fixed in the latest version on native-base


docs(theories): list definitions related to linear algebra

As requested by @PatrickMassot, I wrote a file about the definitions related to linear algebra (at least, the ones I'm aware of).

Thank you!

I don't think I can update this PR since it's already merged, so please check out #24 which applies your suggestions.


[Fix] no-arrow-function-lifecycle: prevent crashing on ClassProperty

Fixes #3093

Codecov Report

Merging #3098 (6945995) into master (210865e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   97.55%   97.55%
=======================================
  Files         118      118
  Lines        7855     7857    +2
  Branches     2801     2802    +1
=======================================
+ Hits         7663     7665    +2
  Misses        192      192

Impacted Files
Coverage Δ

lib/rules/no-arrow-function-lifecycle.js
96.96% <100.00%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210865e...6945995. Read the comment docs.

Settings this as draft for now as some old Node + ESLint combinations were failing to parse arrow functions for some reason. Github Action seem to have some trouble running now so cannot verify whether latest commit fixed anything.

I don't believe we can use the new TS parser on older eslint versions.

Oh right the ESLint version exclusion is done by the parsers.TS() call. Now that it's used the tests are passing.


💩  NICE-127 fix Credits Grid later + shows [b]

If you want to pull SHOW data from an EVENT.SLUG --- need to pass the right database_id

This pull request has been deployed to Vercel.

Latest commit:
fbc379c

✅ Preview:
https://jeromefitzgerald-hnovv09dh-j-e-r-o-m-e.vercel.app

🔍 Inspect:
https://vercel.com/j-e-r-o-m-e/jeromefitzgerald/4gYuT7tcafopGk25fr2y33UFgkBt

View Workflow Logs


Enable debian install path for testpmd

fixup module loading for debian to account for unneeded/missing drivers
Fix ubuntu install_packages paths to use backports
add debian-specific path for dependency installation

Had to resolve a merge conflict, need a second approval after merge resolution


Setting of ”Banners folder“ is invalid

After the address is set, the image under the address cannot be queried when the local image is set to banner.

Same thing mentioned in #24


Question: instructions to add new styles

Could you please document and add the instructions needed to contribute to your project in order to ?

Add a new style
Move existing styles (https://github.com/asciidoctor/asciidoctor-stylesheet-factory)
Is it possible that we use less or sass to generate the css files
Can we release the styles for a specific version of Asciidoctor

To add a new style:

Just include include the corresponding css file to the css folder with all the other styles.
Optional: add a screenshot to the screenshots directory for inclusion in the showcase
Optional: add the new style to the list in the readme.

If you are starting from scratch on a new style you can use the template.css file as a framework. It includes most of the elements that might be interesting to tweak in asciidoctor output. Just remove anything you don't want to change.
Moving existing styles:

It might be possible to compile the stylesheet factory themes or import them directly from e.g. here or here. I imagine this would require some tweaking but it might work.

Using less/sass:

I think the idea was to avoid using CSS preprocessors to keep things as simple and transparent as possible. Given the minimalistic nature of most of the themes (mostly just a few lines), using a preprocessor seems like it might be overkill.

Releasing styles for specific versions of Asciidoctor:

Can you clarify this? Are you worried about backwards compatibility between the themes and a particular version of Asciidoctor? Have there been breaking changes in Asciidoctor that would significantly affect the way the themes work? Or are there other issues?

Can you clarify this? Are you worried about backwards compatibility between the themes and a particular version of Asciidoctor? Have there been breaking changes in Asciidoctor that would significantly affect the way the themes work? Or are there other issues?

I would like to be sure that the styles suggested here will work with by Asciidoctor v1.5.4. If this is the case, then you can release a version of your styles which are compatible to that version. That will allow third party projects to download this release to propose the styles locally

Where this asciidoc.css file is coming from ("https://github.com/darshandsoni/asciidoctor-skins/blob/gh-pages/css/asciidoctor.css"). Asciidoctor project ? Is it your own asciidoctor css file ?

Where this asciidoc.css file is coming from ("https://github.com/darshandsoni/asciidoctor-skins/blob/gh-pages/css/asciidoctor.css"). Asciidoctor project ? Is it your own asciidoctor css file ?

@darshandsoni will need to confirm this, but I believe it is the same as (or slightly modified from) the default Asciidoctor css. It should be similar to e.g. this one.

Thanks for jumping on there @dohliam!
You are correct on that last point there, it is the same as the default Asciidoctor css.
Now that you mention it @cmoulliard I realise that this may bring about very minor compatibility issues as asciidoctor gets updated. Because it is a static css file on this repo, it doesn't get the latest from the asciidoctor itself automatically.
Having said that, when asciidoctor gets updated it rarely makes major changes to the default stylesheet. The devs of asciidoctor focus more on it's functions and not the skins, so they don't mess around with the css too much. Moreover, I expect that an update to their default css would be additive and not subtractive so if anything, there'll just be a lag with features, which can be patched quickly by filing an issue or PR.
To quickly answer your concerns about v1.5.4, it seems to be working fine when I tested it. I may not have tried all the feautures so give it a go and feel free to flag any issues here!

It could be interesting that your project, like asciidoctor-stylesheet-factory, asciidoctor.js use the same asciidoctor file. If we join our efforts to achieve this goal, that should be already a great step.

Asciidoctor (Ruby Project) & asciidoctor.js both use this file : https://github.com/asciidoctor/asciidoctor/blob/master/lib/asciidoctor/stylesheets.rb#L26

Remark : Currently, I have not idea where this file (asciidoctor-default.css) has been created & is managed

The asciidoctor-stylesheets-factory project generates an asciidoctor-css file using this scss template : https://github.com/asciidoctor/asciidoctor-stylesheet-factory/blob/master/sass/asciidoctor.scss

Is the css file generated the same as packaged within your project or asciidoctor (ruby, js)?


Update docs missing referrence to windows platform on Organize our issues page.

Just built the latest version of the docs and noticed minor update would be required to Organize our issues page for missing reference to Windows platform. Jump to section ===> How Do I triage ?
kitematic/kitematic 	Kitematic is a simple application for managing Docker containers on Mac OS X.

should be replaced to
kitematic/kitematic 	Kitematic is a simple application for managing Docker containers on Mac OS X and Windows.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@askb Thanks! That page is actually in another repository; https://github.com/docker/opensource/blob/master/docs/ways/issues.md
are you interested in creating a PR there, or want us to do so?

@thaJeztah - no worries, I can do it.  can this issue be closed ? :)

@askb yes, the process is basically the same as working on docker; fork the repository, clone it to your local machine etc.
If you create a PR, you can even mention closes https://github.com/docker/docker/issues/17684 and GitHub will close this issue when the PR is merged

This was fixed


Quick navigation to 'Today' in time table

When viewing a different day than 'Today' in the timetable, add a button such that the user can navigate to 'Today' with just one click.

Solve using the calendar picker in issue #38.


Build broken in v0.14.0

no ./build in v0.14.0

Please, use make or make build instead. I've updated the docs already to reflect this change.


Add fs.watchDir

Add fs.watchDir to the extensions client.
Waiting on https://github.com/replit/repl-it-web/pull/31300 to be merged and pushed to prod first.

Nice, thank you for adding it 👍🏻


Added Align-Bottom Support.

I was looking for a align-bottom feature, then I added it.  I thought it might be useful for others. I have updated the sample project as well.

Thanks!


how to uninstall it?

it not work on my Xcode 7,so please tell me how to uninstall it.now,the iphonesimulator's SpringBoard is just a black view.

after installed it ,the iphonesimulator which version less than iPhone6s, SpringBoard is just a black view.but i need to use the iPhone 6 iphonesimulator,please tell me how to uninstall it.thanks a lot.

Looking at the Makefile it seems like make clean from the repo directory should do the trick.

Either make clean or simply deleting the downloaded folder should do the trick!


Don't preemptively convert unicode in rest-xml parser

In the rest xml parser, we were converting the input we recieve into a
str, which was causing failures on python 2 when multibyte unicode
strings were passed in. The fix is to simply use six.text_type, which
is unicode on 2 and str on 3. The string will be encoded into the
default encoding later on in the serializer.
Fixes #868
cc @kyleknap @jamesls

Looks good, please add a scripts/new-change entry for this bugfix.

I added change entry and reduced the data model to the minimum required to reproduce the bug.

:shipit: Looks good.


Fix handling of function declarations in loops with let/consts

Convert function declaration to variable declaration so that the IIFE can still be applied.
Unmark calls to captured functions like $jscomp$loop.x() as FREE_CALL.
Fixes #1124

Can you make sure the pull request description is thorough since that will end up being the CL description internally?

I assume "pull request description" is just the first comment?

Not sure but I'm seeing this now, which is much better :)

Convert function declaration to variable declaration so that the IIFE can still be applied.
Unmark calls to captured functions like $jscomp$loop.x() as FREE_CALL.
Fixes #1124

Sounds good :)

Should we merge this?


Epic: sharded pageserver ingest

Background
We currently we send all WAL to all pageserver shards, and each shard filters out the data that it needs,
in this epic we add a mechanism to filter the WAL on the safekeeper, so that each shard receives
only the data it needs.
RFC in https://github.com/neondatabase/neon/pull/8754.
### Sub-issues
- [ ] https://github.com/neondatabase/neon/issues/9328
- [ ] https://github.com/neondatabase/neon/issues/9335
- [ ] https://github.com/neondatabase/neon/issues/9336
- [ ] https://github.com/neondatabase/neon/issues/9337
- [ ] https://github.com/neondatabase/neon/issues/9338
- [ ] https://github.com/neondatabase/neon/issues/9339
- [ ] https://github.com/neondatabase/neon/issues/5543
- [ ] https://github.com/neondatabase/neon/issues/9569

### Nice to Haves
- [ ] https://github.com/neondatabase/neon/issues/7002
- [ ] https://github.com/neondatabase/neon/issues/5962

### Review follow-ups
- [ ] https://github.com/neondatabase/neon/issues/9491
- [ ] https://github.com/neondatabase/neon/issues/9823
- [ ] https://github.com/neondatabase/neon/issues/9824

Can we reconcile this with https://github.com/neondatabase/neon/issues/6345?  (I don't mind replacing that issue, just want to avoid duplication)

Short pre winter holiday update.

Sharded ingest is deployed in ap-southeast (https://github.com/neondatabase/neon/issues/9336)
Fan-out code is functionally complete (https://github.com/neondatabase/neon/issues/9337)

Once we back:

Continue deployment of sharded ingest to all other regions
Tests and tweaks to the fan-out wal reader (e.g. use futures when not sharded to minimise task spawning)
Separate roll-out of fan-out wal reader


App unable to read space when creating/updating game.

Issue
Whenever you try to update a game or create a new server the app will be unable to properly read/create a folder if it has any space in it. Examples below.
PATH
...\Steam Games\steamapps\common\VRisingDedicatedServer
When you press update, app will ignore "Steam Games" and just go with "Steam"
...\Steam\steamapps\common\VRisingDedicatedServer
This will happen in every instance when there is a space between words.
It can also cause an issue if using default override folder...
%userprofile%\AppData\LocalLow\Stunlock Studios\VRisingServer
It would be overridden with
%userprofile%\AppData\LocalLow\Stunlock\VRisingServer
And so on.
For now I'm going with _  E:\Dedicated_Servers\V-Rising
But I thinks that's a issue worth giving feedback.

2.0, however this was happening even before 1.0

I was able to replicate it, it's when SteamCMD runs. Will fix it soon. Thank you!

I believe so.


Testimonials freetest

#
Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[✓ ] Targeted PR against correct branch (master)
[ ✓] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ✓] Wrote unit tests
[✓ ] Updated relevant documentation in the code
[✓ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ✓] Re-reviewed Files changed in the Github PR explorer

Before running a system, it is necessary to test a website system to find out where the deficiencies need to be completed

Before running a system, it is necessary to test a website system to find out where the deficiencies need to be completed


Add Flutter APIs Notebook Example

Data source: https://github.com/leoafarias/flutter_flat_data
Flat data view: https://flatgithub.com/leoafarias/flutter_flat_data?filename=flutter-favorites.json

not really that enticing of a demo data for most devs. Will stick with the few sample data notebooks provided in /notebooks folder for now.


Remove scopes from messaging extension schema

Missed this one - should delete it.
https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/messaging-extensions#declare-your-messaging-extension

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eeb9dcd0-fc2e-95a0-5238-fb67b6a27ba7
Version Independent ID: 3adf9985-9a34-fbb4-161a-23beb753dd70
Content: Develop messaging extensions - Teams
Content Source: msteams-platform/concepts/messaging-extensions.md
Product: msteams
GitHub Login: @o365devx
Microsoft Alias: o365devx

Done, live.


boards/arm: Adding support for nRF9160 InnBlue21 Board.

Adding support for nRF9160 based InnBlue board V2.1. Supports both
Secure and Non-Secure configurations along with various sensors
(lis2dh12 / hts221) and devices(i2c / pwm).
Signed-off-by: Oleh Lozynskyy<EMAIL_ADDRESS>

Signed-off-by: Oleh Lozynskyy<EMAIL_ADDRESS>
Please use a valid email address

ease check if you can resize the added board ima

@ioannisg sure, let me fix that...

Besides the issues mentioned by @carlescufi , please, fix, at least, the one check-patch warning with the line exceeding 80 chars, if possible.

@ioannisg , I would've fixed this but didn't because it was a URL. The same problem exists with the nRF9160 DK board support as well. Don't think its possible to fix.

@reviewers, All requested changes are addressed in the pull request. Please review..

@olsky please squash all commits together and then force-push

@ioannisg and @mbolivar-nordic can you re-review?

@all, please re-review.. All tests are passing now..

@mbolivar-nordic thank you! COmmercially -- not yet, we have some homework todo... we will notify...
Best
Oleh

Looks good now, I had a minor comment about a possible typo
@olsky ^^

sorry for a bit late reply, but these weeks are crazy and to keep with time and schedule is a real challenge (adding the limit of movement) :-)
thank you for your time and reviews! :)

Looks good now, I had a minor comment about a possible typo
@olsky ^^

sorry for a bit late reply, but these weeks are crazy and to keep with time and schedule is a real challenge (adding the limit of movement) :-)
thank you for your time and reviews! :)

All what seems to be left is a question about a possible typo :)

@olsky the build-errors are relevant (I believe, due to recent DT changes)

Duplicate efforts: #23451

Duplicate efforts? #23451

21 != 22

Duplicate efforts? #23451

21 != 22

yes, thanks!
that's true: these are different boards, we were not creative with names :)
so the base is similar, but content (parts and sensors) and usage are different.

@carlescufi , can we merge this also ? Let me know if more updates are required..


AudioplayersPlugin.h file not found

Hello, I'm writing here after checking the following old issues & sorry for the duplicates https://github.com/luanpotter/audioplayers/issues/237 https://github.com/luanpotter/audioplayers/issues/80 https://github.com/luanpotter/audioplayers/issues/101 https://github.com/luanpotter/audioplayers/issues/92
Still can't generate an archive for iOs. When I launch Archive, it stops with the following error: ../ios/Runner/GeneratedPluginRegistrant.m:6:9: 'audioplayers/AudioplayersPlugin.h' file not found
//
//  Generated file. Do not edit.
//

#import "GeneratedPluginRegistrant.h"
#import <audioplayers/AudioplayersPlugin.h>
#import <connectivity/ConnectivityPlugin.h>
#import <flutter_webview_plugin/FlutterWebviewPlugin.h>
#import <onesignal_flutter/OneSignalPlugin.h>
#import <path_provider/PathProviderPlugin.h>
#import <share/SharePlugin.h>
#import <shared_preferences/SharedPreferencesPlugin.h>
#import <url_launcher/UrlLauncherPlugin.h>
#import <video_player/VideoPlayerPlugin.h>
#import <ytview/WebViewFlutterPlugin.h>

@implementation GeneratedPluginRegistrant

+ (void)registerWithRegistry:(NSObject<FlutterPluginRegistry>*)registry {
  [AudioplayersPlugin registerWithRegistrar:[registry registrarForPlugin:@"AudioplayersPlugin"]];
  [FLTConnectivityPlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTConnectivityPlugin"]];
  [FlutterWebviewPlugin registerWithRegistrar:[registry registrarForPlugin:@"FlutterWebviewPlugin"]];
  [OneSignalPlugin registerWithRegistrar:[registry registrarForPlugin:@"OneSignalPlugin"]];
  [FLTPathProviderPlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTPathProviderPlugin"]];
  [FLTSharePlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTSharePlugin"]];
  [FLTSharedPreferencesPlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTSharedPreferencesPlugin"]];
  [FLTUrlLauncherPlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTUrlLauncherPlugin"]];
  [FLTVideoPlayerPlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTVideoPlayerPlugin"]];
  [FLTWebViewFlutterPlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTWebViewFlutterPlugin"]];
}

@end

flutter doctor -v
[✓] Flutter (Channel master, v1.9.8-pre.108, on Mac OS X 10.14.6 18G87, locale en-LB)
    • Flutter version 1.9.8-pre.108 at /Users/macbook/flutter
    • Framework revision 95168fcc03 (17 hours ago), 2019-09-06 00:05:40 -0400
    • Engine revision f4d930581c
    • Dart version 2.5.0 (build 2.5.0-dev.4.0 be66176534)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/macbook/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.3, Build version 10G8
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

Note that I'm using the audioplayers: ^0.13.1 in pubspec.yaml. So is recommended to clone the master branch in github and then force the package to use it audioplayers: path: ../ or it doesn't matter?
Any Idea please would be appreciated.

Having the same issue, same package version.

@GaboBrandX can you share your Podfile inside ios folder

This is not a problem with audiplayers, this is something that I see happening a lot when you are using a swift plugin and your flutter projects uses objective-c, or the plugin is objective-c and your project is in swift. I am not an iOS expert, but here is some things that seems to work for:

Open your project on xcode and set the legacy build system
Open your project on xcode, creates a swift file on your project, any name will do, xcode will ask if you want to create a bridging file, hit yes, you can now delete the swift file.

Hi, the solution for me was to open the xcworkspace file with Xcode, instead of the xcodeproj. After that I've archived with no problems.
Maybe someone could enligthen us telling why did that work?
Thanks for your support!

@GaboBrandX  that is why I requested to provide the file, I want to check it if empty or missed some information, to advise you how to do.

@rabihmb I see, sorry.. I've made it work an hour after my previous post. Anyway, I've made a pod reinstallation before and didn't work. What I've made was:
pod repo remove master
pod setup
pod install
Also I've checked my iOS version and that audioplayers was present on the Podfile.

Hi..
Coukd u plz send ur podfile to check it? It want to compare it with mine
On Thu, Sep 12, 2019, 12:24 AM Gabriel Moreyra<EMAIL_ADDRESS>wrote:

@rabihmb https://github.com/rabihmb I see, sorry.. I've made it work an
hour after my previous post. Anyway, I've made a pod reinstallation before
and didn't work. What I've made was:
pod repo remove master
pod setup
pod install
Also I've checked my iOS version and that audioplayers was present on the
Podfile.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/luanpotter/audioplayers/issues/272?email_source=notifications&email_token=ADKYLL2IOZASDJ5HD27MHZ3QJFOX7A5CNFSM4IUNEMA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6P6GFY#issuecomment-530572055,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADKYLL4BBEUH7GYJOKMLTC3QJFOX7ANCNFSM4IUNEMAQ
.

@rabihmb Here you have:
pods.zip

Any of the advices here has solved your issue?

Have the same issue but the issue only occurs if I try and deploy to a physical device (iOS device). If I run in simulator there isnt any issue and the plugin functions correctly.
Using plugin version 0.13.2. Flutter version 1.9.1+HF 4

I have the same issue here. Tried everything mentioned here. My project is not swift but Objective C. Is there any workaround for this ?

Hi guys any solution for Flutter?

Can now build. I am on iOS 13.1.2 and Flutter 1.9.1.HF 5. The issue was AudioPlayers 0.13.2 Downgrading to 13.1 I was able to build and deploy to simulator and live device.
Note - I upgraded from 0.12.1 Which doesnt have ANY ISSUE whatsoever. Something must have changed with respect to 13.2. Furthermore, I found that Flutter_Twitter_Login and Audio_Players Clashed with AudioPlayers 13.2 version

anyone have idea how to solve the lost of AudioPlaysPlugin.file or other better audio pub

I faced the same problem. In my case, it seemed pub's cache was corrupted. Running pub cache repair fixed the issue

Nothing of the above worked for me

Not working at all for me - a pity as this seemed like a good plugin but I dont think there is any support for Catalina, Flutter 1.9.1 hotfix 6 and Obj C project so dont waste your time trying to fix if you have this enviroment -  I've wasted months trying to get this to work.
Is there anything better out there that is regularly supported as it seems the author of this plugin has sadly abandoned this project or not interested in fixing this particular issue.

Regenerating the Podfile for the ios project solved the issue fore me

Not working at all for me - a pity as this seemed like a good plugin but I dont think there is any support for Catalina, Flutter 1.9.1 hotfix 6 and Obj C project so dont waste your time trying to fix if you have this enviroment - I've wasted months trying to get this to work.
Is there anything better out there that is regularly supported as it seems the author of this plugin has sadly abandoned this project or not interested in fixing this particular issue.

We don’t think this problem just happens on that flutter version, or even on Catalina, we have reports from it since forever.
All the things that I tried to do to fix this, which I commented on this issue, pointed to that this is not a problem with audioplayers itself, but with the project setup using the package, but neither me or @luanpotter have strong iOS development background so we haven’t gave up on this problem, it just don’t look there is much we can do.
Of course, if an awesome member of the community with advanced iOS knowledge could help us here, we would be very grateful.

Hi, the solution for me was to open the xcworkspace file with Xcode, instead of the xcodeproj. After that I've archived with no problems.
Maybe someone could enlighten us telling why did that work?
Thanks for your support!

Thank you very much for helping me to Solve the problem，I've tried all the ways I can find.

For me work when in "Build Settings" I change the "iOS Deployment Target" to 11.0.
Looks like the audio players use tools to version >10.0

I did not abandon this project at all, we are constantly trying to merge all the PRs from the community at the same time keeping the code clean and bug free. I have lots of repos and not a lot of time, so @erickzanardo is kindly helping me to organize this repo.
I however use linux and also it's very hard to reproduce this problem as it 99% of the time works fine. This seems to be more a bug with flutter itself, and anytime I had similar issues a a clean install from flutter always solved my problem.
I would really appreciated if someone with a macos would find a cause and provide us with a PR. We will definitely take a look! Or maybe someone from the flutter team can help us out.
My only hunch would be to convert all the archaic ObjC code to swift, which might or might not fix this issue. I will try to sync with Erick to get that done at some point.

I encounterd a similar problem after increasing iOS platform from 8.0 to 11.0 in my Podfile.
I was able to fix the problem by opening the project in XCode and increasing the target version to 11.0 as well.

good news, I resolve this problem by deleting the ios file and execute 'flutter create -i objc .',if still failed,youcan use the pub: audioplayer: ^0.5.2

@JiweiMaster did you do this on your app or on the audioplayers code? is there something we can fix on the audioplayers side? could you please help our with a PR?

This solved my issue: https://github.com/flutter/flutter/issues/41033#issuecomment-534604875
For some reason, doing Open in XCode from VSCode opened Runner.xcodeproj instead of Runner.xcworkspace. I assumed it was right because it always worked properly.

I finally was able to obliterate all the obj-c code and migrate 100% to swift, so this interop stuff is no longer an issue -- check the 0.17.0 version.


On timeouts

After timeouts the batch jobs aren't all killed. The following Exception should never be raised:

INFO: Task MembersGroupsTask_2018_08_09_MX_34__home_ec2_user_n_34_c94606503b timed out after None seconds and was terminated

Some ideas to test what's going on:

Add some print statements into autobatch to check
Deliberately call this after a short period
Check TIMEOUT variable is correct

Should be fixed, but needs tidying of logging statements. Don't mark as done until we can verify that it doesn't leave zombie jobs.