abapgit.org landing page

I've switched off the redirect for abapgit.org, and now it will show https://github.com/abapGit/abapgit.org instead
Suggest making https://abapgit.org a landing page with 3 simple links:

documentation, https://docs.abapgit.org
code, https://github.com/abapGit/abapGit
eclipse plugin
projects, https://dotabap.org

I like the simplicity of the abaplint.org homepage/tiles. I would add two more tiles:

quick start, https://github.com/abapGit/abapGit/blob/master/README.md
(can this be shown without the Github stuff around it?)
demo (some youtube of the latest version)

Direct link to latest full report would also be useful.

thinking something like this, the boxes are images/icons,

Possible Scenarios:

Backup and Transparency
Code Review
Static Analysis and Testing
Moving to Steampunk
Upgrading to S/4
Safely moving changes to Production
Code Transformation
Serverless ABAP

search possibilities

i'm gonna put something together

here is a quick preview of what i got so far ;)

we already use Font Awesome in a few places, https://github.com/abapGit/abapGit#credits-and-references
So guess the placeholders can be replaced with some icons

progess can be tracked here https://github.com/schealex/abapgit.org
i've also created a data folder within src where you can find the data that will be used to generate the content of the page. We would only need to add there if we want to add further links / scenarios
let me know what you think guys :)

on the docs homepage, we have the content centered,

its 4.3MB to serve a HTML page that I guess is less than 100kb? the dist might not be shaken and minified, but still,

I'm still working on the layout but good to know that it should be centered ;)
also regarding the size, yeah if you run the dev version with debugging and source maps and all of that sure thats quite big :D
Check the actual builded version:

i find 44kb quite small for a modern frontend ;)

hmm, yea, well, is there a way to take the HTML and css and just store that?
I think its a lot of setup, with 150mb+ modules, to generate a single static HTML page?

Yeah sure the final build package is just some html, css and a small js file. Just a couple hundred kb including the images. Which can be build and deployed whereever you want via CI.
I'm a bit sick at the moment but will return to working on it soon.
About the Scenarios, should it just be a list with short descriptions and then links to the project / seperate page or would you also like to have subpages for each?

Scnearios: as a starting point just a short list with links

@schealex any news? I might have some time during this week...

Hey @larshp i've just pushed some updates. Could you please check if there is still something missing for the base page functionality? I've also added a search based upon algoliasearch which is the one we spoke of before. You will need to setup a account there and get a api key and access token. I can provide you my test-one's if you need them to try it out.

https://github.com/schealex/abapgit.org

algoliasearch: I dont think there will be any content to search, at least for now, its just one static landing page with links

see https://github.com/abapGit/abapgit.org/pull/1

merged, https://abapgit.org
follow https://github.com/abapGit/abapgit.org for progress and updates

Possible improvements, from above and slack,

Maybe another tile could point to https://docs.abapgit.org/other-articles-and-presentations.html
quick start, https://github.com/abapGit/abapGit/blob/master/README.md
(can this be shown without the Github stuff around it?)
demo (some youtube of the latest version)
use-cases/scenarios, see https://github.com/abapGit/abapGit/issues/3937#issuecomment-788627865

done for now, closing


i18next instance not available in layout component when using gatsby-plugin-layout

As stated in the title i18next seems to not be available in the layout component when using gatsby-layout.
For example using two languages it and en
export const Layout = ({ children }) => {
  const { languages } = useI18next();

  useEffect(() => {
    console.log(languages) //returns ["en"]
  }, [])

return (...)
}

I also get the warning react-i18next:: You will need to pass in an i18next instance by using initReactI18next
While on the index page everything works as expected.
export const IndexPage= () => {
  const { languages } = useI18next();

  useEffect(() => {
    console.log(languages) //returns ["it","en"]
  }, [])
return (...)
}
export const query = graphql`
  query($language: String!) {
    locales: allLocale(filter: { language: { eq: $language } }) {
      edges {
        node {
          ns
          data
          language
        }
      }
    }
  }
`

My objective is to be able to detect the current language in layout component and render my component accordingly

Did you find a solution for your problem? I have the exact same problem!


MolToSmiles then MolFromSmiles produces molecule with different chirality

Describe the bug
MolToSmiles then MolFromSmiles on a specific molecule produces a molecule with reversed chirality on certain atoms.
To Reproduce
Since I can't send the molecule as a SMILES string, I have attached a pickled version. problem_mol.zip
x = pickle.load(open('problem_mol', 'rb'))
display(x)
display(Chem.MolFromSmiles(Chem.MolToSmiles(x))) #not the same molecule

Expected behavior
Expected the molecule to remain the same.
Screenshots

Configuration (please complete the following information):

RDKit version: 2022.03.3
OS: [e.g. Ubuntu 20.04] Windows
Python version (if relevant): 3.10.4
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? conda-forge
If you are not using conda: how did you install the RDKit?

I think this issue is already answered in the discussion https://github.com/rdkit/rdkit/discussions/5376. You may want to check it ahead and close the issue. The problem here is that Interactive Python does not support multi-result output in the single kernel. Split them out and you would be fine


Implement Edit functionality for patient information

close #79

@syedowaisali90  please add unit tests for the new functionality

looking good :)

The ordering in that json enforced somehow or could someone rewrite that to change the order?
Is there a way to implement this using lookups without assuming a particular ordering?

On May 27, 2021, at 03:20, syedowaisali90 @.***> wrote:

@syedowaisali90 commented on this pull request.
In android/app/src/main/java/org/smartregister/fhircore/activity/QuestionnaireActivity.kt:

 viewModel.savePatient(patient)

 this.startActivity(Intent(this, PatientListActivity::class.java))

}

private fun getQuestionnaire(): String {
val questionnaire =

 FhirContext.forR4().newJsonParser().parseResource(viewModel.questionnaire) as Questionnaire

intent.getStringExtra(PatientDetailFragment.ARG_ITEM_ID)?.let {

 var patient: Patient? = null

 viewModel.viewModelScope.launch {

   patient = FhirApplication.fhirEngine(applicationContext).load(Patient::class.java, it)

 }

 patient?.let {

   // set first name

   questionnaire.item[0].item[0].item[0].apply {

followed the ordering of patient-registration.json form items.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


🐛 [Bug] Convert x3d model from pytorchvideo

Bug Description
I am trying to convert x3d model from pytorchvideo and got this error "ValueError: Unknown type annotation: '<class 'torch.nn.modules.module.Module'>' at".
The problem happened when I use torch_tensorrt.compile() or by "ts_model = torch.jit.script(model)"
I think the error due to the model's definition by pytorchvideo. I got error on both torch 1.11 and torch 1.12. I hope to receive some suggestion.
Thanks!!!
Environment

Build information about Torch-TensorRT can be found by turning on debug messages

Torch-TensorRT Version : 1.1.0
PyTorch Version (e.g. 1.0): 1.11 (install by conda) and 1.12 (install by Nvidia forum)
OS (e.g., Linux):Linux
Python version:aarch64linilin 3.8
CUDA version: 11.4
GPU models and configuration: 2080TI and jetson NX with Jetpack 5.0
Any other relevant information:

Could you provide more details about the model or the model itself ? This looks like a torchscripting issue. Maybe torchscript compiler is unable to understand the types  in the model.

Hi, I called x3d-m model from pytorchvideo, the model is definded in this file.

@hongsamvo so the x3d-m model fails to be scripted, even before Torch-TRT .comiple()? ie. the following fails:
# <download x3d-m_model from pytorchvideo>
...
torch.jit.script(x3d-m_model) # model directly from pytorchvideo

If so, then this is a torchscript issue. We recommend you creating an issue on pytorchvideo to get help with torchscripting.

@ncomly-nvidia yes, I haved problem when converted to torch script first, thank you for your recommend.


Cursor in debug variable hover is always a text cursor, not a pointer

Testing #64003
I can't take a screenshot of my own cursor but

Debug anything
At a breakpoint, hover a variable
Hover text in the popup
See that the cursor changes to the text cursor, not the arrow pointer. In 1.29 it is always the arrow

Also in the console

I find it really annoying, but we can see if anyone else complains.

If you find it annoying that is good enough for me to change it. But let's react in December

@roblourens do you find it annoying only in the debug hover or in all debug trees?
What would be your ideal cursor look in what case?
Note that text is always selectable.
My personal preference:

Pointer curosr in variable, watch and call stack is good as it is now
Debug console: always use selection curosr, except when hovering over elements that have children - than turn to a pointer
Debug hover: always use pointer

fyi @weinand

My preference is, if the primary way that I interact with the UI is to click on it, e.g. to expand and collapse it and so on, then it feels wrong to do that with a text cursor. If it's primarily just text, then it should be the text cursor. So I agree with what you describe.

Great, try it out in a couple of days when we release new insiders and let me know how you like it.

@isidorn The debug console in the latest insiders uses the selection cursor for everything (even the action label and background) which seems like a regression.

@nealot thank you for reporting this. I have fixed this via 7a0c826121
We will have a new insiders after the holiday break in around 10 days and that should have it fixed.


Add more examples of constructing Boolean, Primitive, String,  and Decimal Arrays, and From impl for i256

Which issue does this PR close?
N/A
Rationale for this change
While working on https://github.com/apache/arrow-datafusion/pull/6587 I realized it is still confusing to create arrays (as in it may not be clear how easy it is to do)
What changes are included in this PR?

Add more examples of constructing Boolean, PrimitiveArray, StringArray and Decimal*Array
Add From impl for i256 and i8, i16, i32 and i64 to make constructing them easier (used in the doc examples)

Are there any user-facing changes?
Easier to construct i256 and better docs

(BTW can't we do zero copy from Vec to Array now?)

Only in the case of an array of native types, i.e. Vec<i32>. Vec<Option<i32>>, Vec<&str>, Vec<Option<&str>>`, etc... are not zero-copy, thats the reason to encourage the use of the constructors

Yes, please, give me an example of how to do it / what to do and I can update the docs.

I can add some as a follow up, I think I need to make it easier to construct NullBuffers first :sweat_smile:

I can add some as a follow up, I think I need to make it easier to construct NullBuffers first 😅

👍
Again, I would be happy to help fill out the docs (if I knew what the best practice was)

(I have pushed changes to fix the CI on PR, but it seems like github may be having issues -- though https://www.githubstatus.com/ does not yet admit that)


[ISSUE #482]Support protocol adaptor plugin

Codecov Report

Merging #487 (e4af4ba) into develop (31a3825) will increase coverage by 1.20%.
The diff coverage is 13.05%.

@@              Coverage Diff              @@
##             develop     #487      +/-   ##
=============================================
+ Coverage      11.02%   12.23%   +1.20%
- Complexity       326      335       +9
=============================================
  Files            229      229
  Lines          10975    10936      -39
  Branches         924      902      -22
=============================================
+ Hits            1210     1338     +128
+ Misses          9667     9503     -164
+ Partials          98       95       -3

Impacted Files
Coverage Δ

...in/java/org/apache/eventmesh/common/Constants.java
0.00% <0.00%> (ø)

...he/eventmesh/common/EventMeshRuntimeException.java
0.00% <0.00%> (ø)

...e/eventmesh/common/config/CommonConfiguration.java
0.00% <0.00%> (-87.04%)
:arrow_down:

...ache/eventmesh/common/config/EventMeshVersion.java
0.00% <ø> (ø)

...java/org/apache/eventmesh/common/utils/IPUtil.java
46.05% <ø> (ø)

...e/eventmesh/common/utils/InnerCollectionUtils.java
0.00% <0.00%> (ø)

.../org/apache/eventmesh/common/utils/ThreadUtil.java
47.61% <0.00%> (ø)

...va/org/apache/eventmeth/protocol/http/acl/Acl.java
0.00% <0.00%> (ø)

...th/protocol/http/config/HttpProtocolConstants.java
0.00% <0.00%> (ø)

...meth/protocol/http/consumer/ConsumerGroupConf.java
0.00% <ø> (ø)

... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a3825...e4af4ba. Read the comment docs.

@ruanwenjun   hello,There was a problem when verifying the version. See the picture. I have added dependencies for related configurations.

@Jackzeng1224 I can run the test in AsyncPublishInstance, could you please clean the local cache class, and test again.

@Jackzeng1224 I can run the test in AsyncPublishInstance success, could you please clean the local cache class, and test again.

@ruanwenjun     Every time I work on a new project. Now the newly downloaded project has a new problem.

@Jackzeng1224 This may be caused by the TCP Server plugin have not been installed.
You can add this dependency in build.gradle, or remove the tcp in eventmesh.yml.
implementation project(":eventmesh-protocol-plugin:eventmesh-protocol-tcp")

I will optimize this tonignt

@Jackzeng1224 This may be caused by the TCP Server plugin have not been installed.
You can add this dependency in build.gradle, or remove the tcp in eventmesh.yml.
implementation project(":eventmesh-protocol-plugin:eventmesh-protocol-tcp")

I will optimize this tonignt

ok.I add it and try.
I have a question.Why can't I configure one separately? If there are 3 or 4 ways, but I only want to use one.

@Jackzeng1224 Of course you can. You can config use which plugin in eventmesh.yml.
You can remove the tcp and then you can just use http plugin

@ruanwenjun    hello， Has this protocol adapter plugin been submitted?

@Jackzeng1224 Yes, I have rebased the latest code.

@Jackzeng1224 Yes, I have rebased the latest code.

OK.

@ruanwenjun
hello.  I tried the tcp plugin mode, cannot find the protocol plugin: tcp.

@Jackzeng1224 When you add the dependency in build.gradle, you need to refresh the gradle.
And you can also use ./gradlew clean jar dist to install the plugins.

@Jackzeng1224 When you add the dependency in build.gradle, you need to refresh the gradle.
And you can also use ./gradlew clean jar dist to install the plugins.

ok.I will try again.

@Jackzeng1224 Do you meet any other problem?

@Jackzeng1224 Do you meet any other problem?

Not yet, the functions can be used normally.

@Jackzeng1224 Thanks for your kind assistance.

this pr current implementation just separate the server to http server plugin and tcp server plugin maybe call server plugin more appropriate, not protocol plugin. I think we need to design a protocol layer api(tcp and http) which is depended by server plugin, to make the protocol layer more extensible.

@xwm1992 @Jackzeng1224 Yes, the module has been renamed to eventmesh-server-plugin, and I will try to design the protocol plugin, maybe this pr can be merged, since the other pr will be blocked.

I think protocol adapter is more needed.

Closed by too many conflicts, if this is needed, we can submit a new pr.


Multi Kiosk Package

Hi
When selecting Advanced Provisioning, there is no Assigned Access in the WCD editor. Only when selecting the Kiosk Template but this states single package kiosk. When using this one, it gets applied only the shell is replaced which is not what you want with multi app config. What am I missing?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78038d67-04a1-f4ae-6a69-98e157688a31
Version Independent ID: c86b4460-e8be-8537-a6c8-3cb094ef14a3
Content: Set up a multi-app kiosk  (Windows 10)
Content Source: windows/configuration/lock-down-windows-10-to-specific-apps.md
Product: w10
GitHub Login: @jdeckerMS
Microsoft Alias: jdecker

@JGezels When you start the advanced provisioning project, make sure you select "Windows 10 desktop editions". If you use the default "All Windows 10 editions", you won't have the AssignedAccess settings.

Got it figured out 😊 thanks !
Jan GEZELS
Groupe Architecture & Project - DSI SUEZ HQ
Toutes les enterprises du Groupe portent désormais la marque SUEZ
SUEZ
Tour CB21 - 16 place de l’Iris
92040 Paris La Défense - France
Mob.: +32 475 69 05 58
[1476175783464_PastedImage]
From: Jeanie Decker<EMAIL_ADDRESS>Sent: dinsdag 11 september 2018 17:50
To: MicrosoftDocs/windows-itpro-docs<EMAIL_ADDRESS>Cc: Gezels, Jan<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windows-itpro-docs] Multi Kiosk Package (#1609)
@JGezelshttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJGezels&data=02|01|jan.gezels%40suez.com|f1ac16561bae4f897d1308d617fe3ed3|f4a12867922d4b9dbb859ee7898512a0|0|0|636722778079491596&sdata=bljrSnc697Con%2FQMqHiNFbKhcF8yXzyNgCkwMgd40p0%3D&reserved=0 When you start the advanced provisioning project, make sure you select "Windows 10 desktop editions". If you use the default "All Windows 10 editions", you won't have the AssignedAccess settings.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fwindows-itpro-docs%2Fissues%2F1609%23issuecomment-420322407&data=02|01|jan.gezels%40suez.com|f1ac16561bae4f897d1308d617fe3ed3|f4a12867922d4b9dbb859ee7898512a0|0|0|636722778079491596&sdata=JvBtWxgZhmAqEJce75om1DUz0i2tg%2FFBha%2BC%2Byrp4aM%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAbht3UoeTNSrVISO8FSzFET5dRRHR06Yks5uZ9utgaJpZM4Wf7JX&data=02|01|jan.gezels%40suez.com|f1ac16561bae4f897d1308d617fe3ed3|f4a12867922d4b9dbb859ee7898512a0|0|0|636722778079501604&sdata=K6iFB%2BwFoxIlXUloX4jbyN73gjP3F4SQzCf9iqyypEM%3D&reserved=0.

I can't seem to get the multi-app xml configuration working. I need help getting the XML configured properly.


Enable to use the real user profile

Add switches to the configuration, which (de)activate the overriding of USERPROFILE, APPDATA, ...

solved with 4874a787e1972725c9cd73bf805c30b02dde7676


Implement all casts and boundedint

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
Attention: Patch coverage is 23.30247% with 497 lines in your changes are missing coverage. Please review.

Project coverage is 76.91%. Comparing base (baf57d2) to head (114e79d).
 Consider uploading reports for the commit a284636 to get more accurate results

Files
Patch %
Lines

src/libfuncs/cast.rs
37.50%
195 Missing :warning:

src/bin/cairo-native-run.rs
0.00%
156 Missing :warning:

src/bin/cairo-native-compile.rs
0.00%
47 Missing :warning:

src/metadata/debug_utils.rs
4.16%
46 Missing :warning:

src/types.rs
21.95%
32 Missing :warning:

src/types/bounded_int.rs
0.00%
15 Missing :warning:

src/context.rs
81.81%
4 Missing :warning:

src/bin/cairo-native-test.rs
0.00%
1 Missing :warning:

src/ffi.rs
83.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   77.54%   76.91%   -0.63%
==========================================
  Files         110      111       +1
  Lines       32413    32838     +425
==========================================
+ Hits        25134    25258     +124
- Misses       7279     7580     +301

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: 🐛 refractor Javascript to add spin loading for API request

✅ Closes: #19
This pull request introduces several enhancements to the ambulance tracking system, including the addition of loading spinners, asynchronous script loading, and real-time updates for the driver's location. The most important changes are summarized below:
UI Enhancements:

ambtracker.html: Added a loading spinner for the map to improve user experience during map loading. [1] [2] [3]
driver.html: Introduced a loading spinner for the map and implemented real-time updates for the driver's location. [1] [2] [3] [4]

Script Loading:

ambtracker.html, driver.html, hospital.html: Modified the Google Maps JavaScript API script to load asynchronously and defer execution to improve page load performance. [1] [2] [3]

Code Simplification:

hospital.html: Simplified the map initialization and marker update logic in the ambulance management modal. [1] [2] [3]

CSS Adjustments:

src/css/driver.css: Removed unnecessary comments to clean up the CSS file.

Review the changes & add level3 label to it. @mansiruhil13

The changes introduced in Pull Request #32 fix issue #19 by introducing enhancements like

adding loading spinners,
asynchronous script loading,
and real-time updates for the driver's location.

also add labels of hacktoberfest here @mansiruhil13

also add labels of hacktoberfest here @mansiruhil13 if your project is in hacktoberfest

my project is in hactoberfest but there is not showing pull request? how to enable

also add labels of hacktoberfest here @mansiruhil13 if your project is in hacktoberfest

my project is in hactoberfest but there is not showing pull request? how to enable

ask the program manager sanjay or mastan.


How to combine multiple supposed-to-fail contract calls in one test case?

Hey Guys,
I am coding a Testhelper.sol contract which features some standard tests that should be inherited and executed by multiple other test files. We have numerous diamond facets and we want to make sure that they all pass the same tests whilst reducing boilerplate code.
Aggregating and calling positive tests works fine.
But aggregating negative tests does not work since after the first test failed, the tx is reverted already and the following tests will never be executed.
I cannot work with try/catch here since these are internal calls.
In Hardhat I could apply the following principle:
expectRevert(testFailNegative1());
expectRevert(testFailNegative2());
...
But with foundry I have not found a way to have several reverting calls in one test case.
Do you have a suggestion for me how I could implement such a pattern?
file Testhelper.sol
contract TestHelper {
   function testPositiveA() public {....}
   function testPositiveB() public {....}
   function testFailNegative1() public {....}
   function testFailNegative() public {....}

   function runAllPositiveTests() internal {      // this works fine
     testPositiveA();
     testPositiveB();
   }

  function runAllNegativeTests() internal {
     testFailNegative1();   // fails here (as expected)
     testFailNegative2();  // will never be executed, but should
  }
}

file TestFacet.t.sol
contract TestFacet is Testhelper {

   function testPositiveStandardTests() public {
       runAllPositiveTests();   // this works fine
   }

   function testFailNegativeStandardTests() public {
       runAllNegativeTests();    // this will never execute all negative standard tests but stop after the first one failed
   }
}

@odyslam thoughts about this?
iirc we discussed multi expectRevert at some point, so maybe you have some insight here

Actually, I just realized that by making the functions public in the Testhelper.sol contract, the test run will pick them up automatically. So I dont even need to aggregate the functions and call them explicitly. This helps me partially.
But nevertheless I see benefits of having multiple reverts in one call
(e.g. testing to fail a function with several wrong parameters - would be nice to combine that in one test case)

@mattsse I think this is another use-case for the combinators we talked about:

not
or
and


How to provide App ID dynamically, not via the nuxt.config?

Hello.
Thank you for the nice plugin.
We have few sites with a single code base.
Is there a way to provide App ID dynamically, not via the nuxt.config?

Hey @koresar
I think the most sensible solution for you would be to put the ID into a .env file, and use Nuxt’s publicRuntimeConfig key. This will allow you to set a different ID per environment. We do this for the same use case as you and it works great.
Alternatively, you can use a function in place of the ID which resolves on module load. You could use this to make an API call to get the ID.
See: https://github.com/hex-digital/nuxt-intercom/blob/master/lib/module.js

Ah. Forgot to tell very important detail.
The App ID is fetched during the app start from the server.
But I like your second suggestion. The module load happens in build time, in the browser. Correct?

I think so, yeah. Let me know if it doesn't seem to work for you though

It should work. Thanks for your help.

Well... it didn't work for us. We deploy same exact (zip) bundle to
different domains. But that's okay. We have a workaround.
On Tue, 8 Dec 2020, 20:22 Jamie Warburton<EMAIL_ADDRESS>wrote:

I think so, yeah. Let me know if it doesn't seem to work for you though
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hex-digital/nuxt-intercom/issues/13#issuecomment-740495870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMMEL26WDFCAXF4MRIMF7DSTXV4BANCNFSM4UP2CEMQ
.


Update akka-http, akka-http-spray-json to 10.2.4

Updates

com.typesafe.akka:akka-http
com.typesafe.akka:akka-http-spray-json

from 10.2.1 to 10.2.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

Superseded by #66.


Temporary Default Character Sheets

Allow users to temporarily alter their default character sheet for some set duration with something like a /latch char:name/id time:(optional,default 1day)duration command.

I think this would effectively require a new database entry. It would be a column structured like the "defaults" column, but each entry is a tuple, with the first value being the sheet ID and the second being the timestamp at which to remove the latch.
However, this increases the overhead of each reference, since it'd first check if there's an entry in this column, and then if there is, it'd then check whether to remove it.


Consume new split language server/service package

When https://github.com/Microsoft/azure-pipelines-language-server/issues/5 lands, consume it.

@joscol did this one already.


[Feature Request] Don't scroll if max docs < scroll size (update by query/delete by query)

Is your feature request related to a problem? Please describe
Using update_by_query and delete_by_query over a small amount of docs, where the max docs is less than scroll size, still uses a scroll and contributes to the max_open_scroll_context limit.
Describe the solution you'd like
Don't scroll unless necessary. This has been patched in ES as of 7.17.0
Related component
Search:Performance
Describe alternatives you've considered
I'm aware of https://github.com/opensearch-project/OpenSearch/issues/12923 which should also eventually solve this problem, but it may take a while to get there. Would be great to have this patched before then.
Additional context
No response

@luisfavila If you bring in a fix, please make sure not to be copying/looking at non-APLv2 code.

@luisfavila will this help speed up those queries or just bring down the scroll count?

@harshavamsi I'm not entirely sure whether it speeds up the queries. It helps immensively if you're running a big number of queries that affect a small number of documents (<10k) as you won't hit the 500 max within the scroll window defined. I'm also under the impression scrolls aren't cleared when the query finishes, only when they expire, but am not entirely sure (would have to check the actual code)

Discussed this briefly in our weekly search meetup (https://www.meetup.com/opensearch/events/300759986/).
I'm not sure if we have a great way of preventing the scroll from being created in the first place, but if the scrolls aren't being cleaned up once we hit the end (especially for a delete_by_query or update_by_query), we should fix that.
Why can't we prevent the scroll from being created in the first place?
As far as I know, the flow should be roughly:

Create a scroll to paginate through all docs with a consistent view of the world.
Get page 1 of results. No pages left.
Ideally, remove the scroll.

If we fetch page 1 and it's not the last page and then create a scroll, it might not match the same reader state as the page that we fetched. That could lead to bizarre outcomes (docs skipped or visited twice). AFAIK, that's why we always create the scroll first.

Will it also be useful to identify if its technically feasible to know upfront if there are less number of documents - based on if  max docs is less than scroll size, then skip using the scroll altogether and avoid creating the max_open_scroll_context? Else we fallback to aggressively clean up the context as Froh suggested above.
@harshavamsi  do you think we can quickly validate that?

Oh... I was thinking about the internals of how a search works anyway. For every search, we create a SearchContext that persists from the query phase to the fetch phase. A scroll or a point-in-time search are essentially just fancy ways of keeping the SearchContext around even after returning results.
Maybe the solution is to fix the scroll logic to let the SearchContext get closed anyway if the query phase comes back with fewer than scroll_size results? Functionally, it would be like preventing the scroll from being created.

@msfroh Would it still add to the scroll context limit that way? It'd be nice if it didn't unless it needs to, so there's no actual limit on how many UpdateByQuery / DeleteByQuery you can run concurrently, given they don't need to scroll.
Separately, is this still planned to be implemented?


Path length calculations in Overlord.lifetimeFilter()

Issue summary
In Overlord.ts, if we have colony A incubating colony B claiming colony C, the path length can be overcomputed as A->C rather than B->C even if B is capable of spawning the claimer.

Closing as this mechanic has been replaced by SpawnGroups


Bad Gateway

Summary of the Bug
Visiting https://agagd.usgo.org/ gives a 502 Bad Gateway
Steps to Reproduce the Behaviour

Go to https://agagd.usgo.org/

The Expected Behaviour
A web page with some HTML
Hardware and Software Information
Desktop

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

I assume this is an infrastructure issue. Is this hosted on AWS? Does someone with access to that have time to look at it?

This is a known issue. No one working on the project currently has credentials, and I have been unable to make progress with the AGA leadership to resolve this.


RTCPeerConnection.getRemoteStreams deprecated and not work in safari > 11

Hello, @Blancduman!
When I use web version of my app in safari browser and connect from other device, safari inspector throws an error:
NoSuchMethodError: method not found: 'getRemoteStreams' (s.getRemoteStreams is not a function. (In 's.getRemoteStreams()', 's.getRemoteStreams' is undefined)) a8f — main.dart.js:26852:82
This is most likely due to
https://github.com/Blancduman/mediasoup-client-flutter/blob/ef97db661fb0892ad79de36c7f1815db7adb42a6/lib/src/handlers/unified_plan.dart#L252-L254
WebRTC api notes that is deprecated method.
Any ideas how to get the stream in another way? I'm trying to use WebRTC createLocalMediaStream, but have no sound from peers

Hello.
mediasoup_client_flutter is outdated right now. And I didn't have a macos at the time I was developing this library.
I was overwhelmed for a long time, but I will have free time at weekend.
Issue is that my handler works only in native and chromium browsers.
Do me a favour and find how to get browser's name in flutter : )
A lot of work should be done.
Have a nice day.

Thanks for the quick response!
If I understand you correctly, you can get name of the browser using the package https://pub.dev/packages/device_info_plus
Browser name contains in userAgent String or you can get it following that code example:
Future<String> webBrowserName() async {
      final DeviceInfoPlugin deviceInfoPlugin = DeviceInfoPlugin();
      final WebBrowserInfo webBrowserInfo = await deviceInfoPlugin.webBrowserInfo;
      final String webBrowserName = webBrowserInfo.browserName.name;
      return webBrowserName;
}


Enhance API-Testing-Guidelines.md

What type of PR is this?

documentation

What this PR does / why we need it:
Enhances API testing guidelines with much more details and explanations. Initial version was too basic to assure consistent and coherent testing plans.
Which issue(s) this PR fixes:
Fixes #158
Special notes for reviewers:
This is a first draft following proposal and initial feedback in  #158.
Changelog input
* Enhancement of API-Testing-Guidelines

In the latter commit:
Proposal updated with comments and feedback after dedicated session on May 16th.

Tests coverage section moved to to the top, merging legacy section "Test Cases contribution for APIs".
Added distinction between basic and enhanced test plan, to be aligned with Release Management proposal. There is no proper definition of what is basic or enhanced, so I suggested some initial test.
Added explicitly that environment variables may be kept in a separated file. We should enhance this part with more details and a suggested template.

Please review these changes.

I think I have incorporated all suggestions and feedback, please double check

@jlurien  Except above 1 comment PR looks fine to us .

Final comments addressed. Thanks for the feedback and corrections.

@jlurien Thanks for accommodating comments .LGTM  now cc @akoshunyadi  @shilpa-padgaonkar


vue+ts, when props are passed, the same type check error is reported

Acknowledgement

[x] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

This is migrated from an independent project, and the original project does not report an error. pnpm-lock.yaml cannot be imported into the workspace. In fact, I tried to spend a lot of time modifying the pnpm-loc.yaml file to fix the problem, but after adjusting the version, it still reports an error.

Thanks for your help

Can you condense this into a minimal self-contained reproduction?  The fact that it did not occur in your original project suggests some package shenanigans, possibly pnpm-related, outside of Typescript's control.

We don't control the vue extension. Please provide a new issue that doesn't require vue if you'd like us to investigate. Thanks!


Adding cache policy support to HTTPRequest

Override FoundationClients default caching policy on a pre-request basis
Requires:

[x] Add caching to FoundationClient: https://github.com/vapor/vapor/pull/1674
[ ] Support HTTPRequest caching in FoundationClient: https://github.com/vapor/vapor/pull/1684

Well, I wanted to set a different caching policy on only one of my requests but with the last change I was setting it on the entire FoundationClient so there was no space for customisation ...

Is there any development on this? I can imagine this can be an issue for many developers working on libs/fws for Vapor (eg. the AWS S3 from @rafiki270).

Is there any development on this? I can imagine this can be an issue for many developers working on libs/fws for Vapor (eg. the AWS S3 from @rafiki270).
Cache behaviour control seems like an important part of any HTTP client.

Is there any development on this? I can imagine this can be an issue for many developers working on libs/fws for Vapor (eg. the AWS S3 from @rafiki270).
Cache behaviour control seems like an important part of any HTTP client.

Is there any development on this? I can imagine this can be an issue for many developers working on libs/fws for Vapor (eg. the AWS S3 from @rafiki270).
Cache behaviour control seems like an important part of any HTTP client.

Is there any development on this? I can imagine this can be an issue for many developers working on libs/fws for Vapor (eg. the AWS S3 from @rafiki270).
Cache behaviour control seems like an important part of any HTTP client.

@zdnk @rafiki270's first PR (https://github.com/vapor/vapor/pull/1674) was merged, which means you can create an instance of FoundationClient that has your desired caching policy:
let client = FoundationClient(cachePolicy:  ..., on: req)
client.send(...)

You could even override Vapor's default Client with it if you wanted:
services.register(Client.self) { c in
    return FoundationClient(cachePolicy: ..., on: c)
}

Closing this PR as cache policy on HTTP request does seem out of scope to me. But feel free to continue discussion here if you think otherwise.


List::MoreUtils::XS is no longer installed by default when XS is available

This could be considered a regression due to the split dist, as the XS code was always installed before. Unless it's specifically requested as a dependency, List::MoreUtils::XS will not be installed anymore in a fresh install. For reference, List::SomeUtils solves this with dynamic config and ExtUtils::HasCompiler (via dzil plugins): https://metacpan.org/source/DROLSKY/List-SomeUtils-0.53/Makefile.PL#L65. Similarly JSON::MaybeXS using ExtUtils::CBuilder but with much more complicated logic due to JSON::XS issues: https://metacpan.org/source/ETHER/JSON-MaybeXS-1.003009/Makefile.PL#L88. In both of these cases the decision is made based on whether can_xs is true (as defined by the appropriate module) and whether PUREPERL_ONLY is specified.

Since List::MoreUtils::XS needs List::MoreUtils as loader, it is not possible to install it automatically when XS is found. Even more: there is no trivial way to reliable detect XS availability.
So I had to make a decision. I made the decision when reworking issues beginning with 0.400 - and I rethink last 6 month where the code was under development.
A regression in my understanding means, that something what worked before don't work now. But there is nothing what couldn't be done by List::Moreutils::PP - and those who explicitely need XS had always require List::MoreUtils::XS to state so.

This is a massive performance regression, and for some production loads means an upgrade of List::MoreUtils will result in production services failing.
installing the XS component by default if possible is standard. If you still insist on using your own build tools, you could at least make them work properly.

Since List::MoreUtils::XS needs List::MoreUtils as loader, it is not possible to install it automatically when XS is found.

Then you made the wrong decision in the way these modules depend on each other.
Also, passing PUREPERL_ONLY=<anything> causes a build failure, which is unacceptable.  Some cpan clients will pass this value.
PUREPERL_ONLY=0 should result in the XS module being installed/upgraded.  PUREPERL_ONLY=1 should always work unless an older version of the XS module is already installed, in which case a failure is reasonable because the user is providing conflicting information and it would be difficult to prevent the older XS bindings from being loaded.
The way you (try to) manually detect conflicts in Makefile.PL is wrong and will result in too many false positives.
I can't imagine how vendor packagers will be able to deal with this Makefile.PL at all.

I think over that and find a solution

I think over that

Come talk to #toolchain --  many different permutations of PP/XS have been tried, and there is some wisdom to be gained from people who have tried and fallen down in the past :)

Never again

Opened a #26 to give us a fresh discussion of the specific issues.
You should try #toolchain again eventually though - it's been far more civilised since riba's tantrum+ragequit.

Since List::MoreUtils::XS needs List::MoreUtils as loader, it is not possible to install it automatically when XS is found.

Could you explain why this is necessary?

Even more: there is no trivial way to reliable detect XS availability.

I am surprised by this statement coming from you.

A regression in my understanding means, that something what worked before don't work now. But there is nothing what couldn't be done by List::Moreutils::PP - and those who explicitely need XS had always require List::MoreUtils::XS to state so.

I may be mistaken, but I had the impression that they're not identical in the way they're dealing with @_.

@shadowcat-mst - sorry when I do not believe, even you're engagement speaks another language.

Since List::MoreUtils::XS needs List::MoreUtils as loader, it is not possible to install it automatically when XS is found.

Could you explain why this is necessary?

@Leont - it's just developed that way because when designing pure LMU at niederrhein.pm ages ago, this was simply recommended by all discussion attendees.
You can call it a mistake or bad design or whatever - it's at the moment at it is and was out for nearly 8 weeks and could be reviewed.

Even more: there is no trivial way to reliable detect XS availability.

I am surprised by this statement coming from you.

Well, the split was done to remove C::AC from List::MoreUtils ...
Clearer?

A regression in my understanding means, that something what worked before don't work now. But there is nothing what couldn't be done by List::Moreutils::PP - and those who explicitely need XS had always require List::MoreUtils::XS to state so.

I may be mistaken, but I had the impression that they're not identical in the way they're dealing with @_.

That would be bad. Please file tickets when you find such a behavior when it should be identical.

@rehsack just closed #26 as well. We need to either re-open one of these issues or somebody needs to file a new one that @rehsack promises to listen to instead of closing them every time somebody points out he made a mistake.

@shadowcat-mst - I promise to listen to any reasonable point. But I do not listen to shout contest.

@rehsack and yet in spite of saying that asking to re-open an issue is fine, in spite of there being a valid problem here, you've left both issues closed.
Please pick one to re-open or create a new one or give us permission to create a new one without you claiming it's "pressuring".
Leaving both closed while telling me off for creating a still open one is not constructive.

Oh yes, if you like it being open, I'm doing that for you. I don't mind - since I realized the point and don't need the open issue to remember.

To summarise where we're currently up to:

List::MoreUtils must install ::XS by default if a compiler is available

PUREPERL_ONLY=1 must override this and ensure List::MoreUtils is installed pp-only in that case

PUREPERL_ONLY=0 must be a no-op rather than crashing Makefile.PL

Provided all three of these are true, exactly how you ensure they are true is up to you.
These three requirements reflect the standard requirements of PP/XS splits, as previously discussed when we were comparing the standard build approaches for low level modules to your new/preferred approaches.

I can't imagine how vendor packagers will be able to deal with this Makefile.PL at all.

As a vendor, I'm just going to say that this specific interaction is likely not going to be a problem.
Mostly, because if I want to make users have the ability to install ::XS, I can do just that without needing to have Makefile.PL make it happen.
The only fun part for me is making sure the Makefile.PL doesn't spontaneously die() on me in either condition and respects the wishes the user indicated.
Which means the only really hard thing is understanding the flow of the code in Makefile.PL, and identifying how to push it in the right direction, and if the code doesn't allow this as-is, understanding the code sufficient so I can patch it to do the right thing.
Ideally though, we do encourage upstream to make their Makefile.PL's such that we can authoritatively declare what we want out of it, and have it respect that, as that is typically superior to maintaining our own patches ( because the further we deviate from upstream, the more work there is to continue maintaining upstreams releases )
Granted: I haven't yet assessed the nature of the latest LMU updates, and there might be problems in there other than this magic. I'm just not jumping the gun until I find a problem that is too hard to circumvent downstream.
In short though: we can make LMU do the right thing, even if its too hard to do the right thing on CPAN.
"configuration avoiding automagic" is the only thing that makes me truely miserable.

As a vendor, I'm just going to say that this specific interaction is likely not going to be a problem.
Mostly, because if I want to make users have the ability to install ::XS, I can do just that without needing to have Makefile.PL make it happen.

I expect that @shadowcat-mst see's his opan as a vendor-tool, either. I don't want to discuss that here (separation of concerns) and for the moment I accept this as a sane reason.

The only fun part for me is making sure the Makefile.PL doesn't spontaneously die() on me in either condition and respects the wishes the user indicated.

If there is something nasty on Makefile.PL's behavior (in doubt, don't try to understand the code - just tell me what you expect and what you got and maybe why you think that's wrong), I'll fix that immediately (see https://rt.cpan.org/Ticket/Display.html?id=120799). This thread is about mislead design decisions and is somewhere between serious issue and wishlist. Kind of both - so (as long as this thread doesn't start eating time by spamming comments (not yours), it'll be in line directly after the blead-perl fixes (blockers) of some other distributions of me).

Which means the only really hard thing is understanding the flow of the code in Makefile.PL, and identifying how to push it in the right direction, and if the code doesn't allow this as-is, understanding the code sufficient so I can patch it to do the right thing.

This shouldn't be necessary.

Ideally though, we do encourage upstream to make their Makefile.PL's such that we can authoritatively declare what we want out of it, and have it respect that, as that is typically superior to maintaining our own patches ( because the further we deviate from upstream, the more work there is to continue maintaining upstreams releases )

And I will gracefully support this approach as long as it doesn't try to add insane code snippets ;)

Granted: I haven't yet assessed the nature of the latest LMU updates, and there might be problems in there other than this magic. I'm just not jumping the gun until I find a problem that is too hard to circumvent downstream.

In short though: we can make LMU do the right thing, even if its too hard to do the right thing on CPAN.
"configuration avoiding automagic" is the only thing that makes me truely miserable.

I can't parse the last sentence. Is there something you expect from Makefile.PL to do or to avoid?

To summarise where we're currently up to:

List::MoreUtils must install ::XS by default if a compiler is available

The primary reason to split PP and XS was to remove the XS-availability stuff. I will not re-introduce them.

PUREPERL_ONLY=1 must override this and ensure List::MoreUtils is installed pp-only in that case

PUREPERL_ONLY=1 will not install ::XS

PUREPERL_ONLY=0 must be a no-op rather than crashing Makefile.PL

PUREPERL_ONLY=0 can recommend or suggest the ::XS.
It'll not test anything.

List::MoreUtils::XS must function on its own so we don't have circular dep problems with (1)

Agreed.

Provided all three of these are true, exactly how you ensure they are true is up to you.

Four and no. (1) is not reasonable compared to former requirements (se #9 and #11). If this discussion explodes again because of this topic - we close and don't come back. (3) bases on (1) and is therefore not applicable in the described way.

These requirements reflect the standard requirements of PP/XS splits, as previously discussed when we were comparing the standard build approaches for low level modules to your new/preferred approaches.

IEEE nnnn?  Standards are bigger than Perl(5) - and we don't want to discuss "standards" here (otherwise explode, bla bla).

I can't parse the last sentence. Is there something you expect from Makefile.PL to do or to avoid?

At this point I don't have any specific requests, I'm mostly just trying to give a more objective view of what vendor concerns look like, in contrast to ether's suggestion they'll be too difficult.
If I have anything specific I need fixed, I'll work that out next week sometime when I get around to packaging the latest release. :)
But most of my commentary so far in this thread is not necessarily just for you, but for the other participants, in effort to give a better understanding of the general needs of downstream.
Because while downstream does have a different set of needs than CPAN, they also have a different set of powers, and we can pull fancy tricks that aren't possible on CPAN :)

Adding List::MoreUtils::XS to suggests or recommends dynamically isn't going to work well, unfortunately.  Adding suggests or recommends would be done with META_ADD or META_MERGE, since EUMM doesn't support a parameter to specify them.  But META_ADD and META_MERGE are ignored when configuring on user machines.  You would need a hack of some kind to get EUMM to adjust suggests or recommends dynamically.

Unfortunately you (requestors) cannot have all - No C::AC, XS depend on PP, XS standalone, bla bla bla - it is insane.
What can be done is adding it (hard!) to requirements and remove it from there dynamically when PUREPERL_ONLY (or similar) is set appropriately.

This issue is solved. Further details are discussed in https://rt.cpan.org/Ticket/Display.html?id=122875

I don't agree that this issue is solved. Recommends is not a solution, as no CPAN installers use it by default. Relying only on PUREPERL_ONLY=1 for a hard dependency would be acceptable but unfortunate, detecting the lack of a compiler automatically and using PUREPERL_ONLY=1 only as a manual override is much more user-friendly.

This seems to be fixed now with 0.425.


first version, might need some review

Proposed changes
Briefly describe the changes you've made here. Remember to add a link to the preview page of your branch.
Checklist before requesting a review

[x] I have followed the instructions in the Contributing and Styleguide documents.
[x] My pull request passes the automated tests. If not, visit pull requests at Travis CI and have a look at the job log.
[x] I have included a link to the appropriate preview page (select your branch from the list).

Well explained. LGTM


Upgrade state-fold's tonic version

📚 Context
The state-fold library is still using tonic 0.8 (in place of the newer 0.9).
For this reason, the dispatcher and the state-server have to use a different version than the rest of the project.
✔ Solution
Upgrade tonic's version in the state-fold library and in the aforementioned packages.

We won't do that because we will move to a new architecture in https://github.com/cartesi/rollups-node/issues/101


Error in URL maskedInput

i am using maskedInput widget for url masking, inside activeForm
this is my code
<?= $form->field($model, 'video_url')->widget(MaskedInput::className(),[
                'name' => 'video_url',
                'clientOptions' => [
                    'alias' =>  'url',
                ],
]); ?>

and this is my output

initialy it looks fine but when u input something and focus out from the text field then the widget itself will add extra '/ '
something like this

and hapenz every time when it focus out

i am using yii2,
can anyone pls help me

i don't know whether its a bug or my mistake, similarly i am using
<?= $form->field($model, 'email')->widget(MaskedInput::className(), [                     'name' => 'email',                     'clientOptions' => [                         'alias' => 'email'                     ],                 ]) ?>
for email masking
and
<?= $form->field($model, 'fax')->widget(MaskedInput::className(), [                     'name' => 'fax',                     'mask' => '+9{1,3}-99{1,3} 99{1,3}'                 ]) ?>
for fax, and many other, that all working fine but i don't know why URL masking is got this issue, at least give me a regular expression for URL masking which is supported by this widget


feat: add initial from and to pipe command versions

Closes #55
Aims to add to and from pipe to next-ls

Can you also write a couple of full integration tests?

Okay, I tested this out and wasn't able to get it to work (after making some changes, I'll push them up on another branch so you can see, I rebased so i don't want to force push to your branch).
I think the integration tests will reveal where it breaks. I'll paste some of the errors I was seeing
to-pipe errors
NextLS: -32700: {[line: 1, column: 42], "missing terminator: } (for \"{\" starting at line 1)", ""}

from-pipe errors
NextLS: -32700: {[line: 1, column: 5], "syntax error before: ", "'|>'"}

Changes i made: https://github.com/elixir-tools/next-ls/commit/fb33786927f8e986b460a2370848ca3b2fc40ea5

Changes i made: fb33786

I have added the changes from this branch as well

i'll try and review/demo this before the weekend

Tested this out, seems to break in quite a few cases.
I was able to turn parser = code |> new(opts) |> next_token() |> next_token() into parser = next_token(next_token(new(code, opts))), but not the other way around. No error, just did nothing.
trying to do it on with the cursor on parse_program or parser here results in an error
    case parse_program(parser) do
      {ast, %{errors: []}} ->
        {:ok, ast}

      {ast, %{errors: errors}} ->
        {:error, ast, errors}
    end
  end

The error being NextLS: -32700: {[line: 1, column: 34], "missing terminator: end (for \"do\" starting at line 1)", ""}

Thanks for testing it out, I'll add those as test scenarios.
The first scenario no idea why it didn't work, I'll have to take a look, also I'll do a better job of reporting the errors.
The second scenario I think it's an easy fix - I just have to add do/end as tokens to the bracket counting as well and I think it'll work fine, since currently it doesn't know to get more pieces of code until it compiles the case.
I will think of similar cases as this one

You can use the error tolerant parser be been building (Spitfire) in Next LS now, so it might make this easier.

https://github.com/elixir-tools/next-ls/assets/5523984/3e5d2da4-1e1b-414b-92a1-d079315ea5bf
found a case where it leaves a stray variable above the function it un-pipes

Also that one was a little odd in that it un-piped the begging of the pipe chain instead of the one under the cursor.
I would have expected this more or less
Enum.map(
  file |> NextLS.ASTHelpers.Variables.list_variable_references({line, col}),
  fn {_name, {startl..endl, startc..endc}} ->
    [file, startl, endl, startc, endc]
end)

I'm not sure if that is enough to stop this from merging, can improve it later

also putting the cursor here results in the error
#    👇
Enum.map(
  NextLS.ASTHelpers.Variables.list_variable_references(file, {line, col}),
  fn {_name, {startl..endl, startc..endc}} ->
    [file, startl, endl, startc, endc]
  end
)

[Error] [NextLS] ** (ArithmeticError) bad argument in arithmetic expression

I'll see if i can't get some time to address those test cases tonight

I have some local changes but haven't finished them yet, I'll try to get that done tomorrow.

Fixing a test and the nix flake and then it'll be mergeable.
I decided to include the Sourceror library as it has a lot of functions around positions that I was about to remake. As well as its zipper implementation which is useful

Also I broke out from-pipe into a second PR


Donut-Vend add

About the PR
Add donut-vend for heavy roleplay officers. There are not many regular donuts in the build that would be worth inserting into the machine, so there are not enough of them now.
by Theta Station.
Screenshots

Changelog

:cl:

add: Added donut-vend.

Excuse me?

Excuse me? Is there an issue here.

no, i'm just wondering why it works like this?

Excuse me? Is there an issue here.

no, i'm just wondering why it works like this?

Remie is a codeowner on something you added, so she gets added to the reviewer list.

Done

Fixed as requested in review

Presently, you can hack security vending machines to dispense donuts. If donut dispensers become more commonplace, should donuts be removed from the hacked security vendor list?

Maybe, I just thought that it would be necessary to give donuts with cyanide for a hacked donut-vend

Presently, you can hack security vending machines to dispense donuts. If donut dispensers become more commonplace, should donuts be removed from the hacked security vendor list?

I looked, it contains a reference and for some reason boxes of donuts. I can remove the boxes, but I think the reference should be left there.


Missing Ingredients filter broken

[X] I have read the FAQ.

Describe the bug
Go to Cocktails and filter by Missing Ingredients selecting 1, 2, or >=3. In all cases, the results are just incorrect.  There seems to be no rhyme or reason.
To Reproduce
For example I select 2

It lists things like Screwdriver and gemist

But when I open them up I have all the ingredients

Whereas others might have 1 or 2 ingredients missing as well

Selecting 1 brings up no results despite the previous Mimosa only missing one

Versions:

Bar Assistant: v4.2.4
Salt Rim: v3.6.0
Browser: chrome

I've added missing ingredients by bar shelf filter. But currently it will not count complex ingredients and substitutes

@karlomikus can confirms it's working (and almost submitted an issue for the complex ingredients/substitutions 😅)

Yeah, it's a bit difficult to count complex/substitute ingredients in the current filtering query


Maven issue

When i run mvn install as described in the readme i get the following
Downloading: https://app.camunda.com/nexus/content/groups/public/org/camunda/camunda-release-parent/2.5/camunda-release-parent-2.5.pom
Downloaded: https://app.camunda.com/nexus/content/groups/public/org/camunda/camunda-release-parent/2.5/camunda-release-parent-2.5.pom (13 KB at 108.2 KB/sec)
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Non-resolvable import POM: Could not find artifact org.camunda.bpm:camunda-bom:pom:7.7.3-ee in camunda-bpm-nexus (https://app.camunda.com/nexus/content/groups/public) @ line 20, column 16
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
Thanks

Tried 7.7.0 worked until next error when it needs 7.7.2-ee that does not exist and the saga continues

removed the provide 7.7.2-ee dependencies went further
Running from maven the main failed, but it workd from intelliJ 👍
starting the first services checkout ,inventory and monitoring...worked
failed on OrderApplication :(
2017-11-12 17:10:53.719  WARN 6691 --- [           main] ationConfigEmbeddedWebApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'lazyInitRegistration' defined in class path resource [org/camunda/bpm/spring/boot/starter/webapp/CamundaBpmWebappAutoConfiguration.class]: Initialization of bean failed; nested exception is java.lang.RuntimeException: javax.servlet.ServletException: Could not read security filter config file '/securityFilterRules.json': no such resource in servlet context.

If you have time please take a look as for the moment I am stuck.
Would be nice to have a working version out of the box. (even without automatic topic creation)
Let me know please how can I help.
Regards
Cristian

Should be fixed with https://github.com/flowing/flowing-retail/commit/8af6e6bb0497817ac2a0498e5a71d06572e4a5f8 - works fine locally for me. Can you confirm?

I have such code to init Camunda beans, it work well on Camunda  7.9-EE, Springboot starter 3.0 and StringBoot 2.0.2.
@Component
public class ScriptingEngineInitializer implements ApplicationContextAware {
@Autowired
private ProcessEngine processEngine;

@Override
public void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
    ProcessEngineConfigurationImpl config = (ProcessEngineConfigurationImpl)processEngine.getProcessEngineConfiguration();
    final Map<Object, Object > beans = config.getBeans();
    Arrays.asList(applicationContext.getBeanDefinitionNames()).forEach(beanName -> {
        beans.putIfAbsent(beanName, applicationContext.getBean(beanName));
    });

}

}
On upgrade to  Camunda  7.10-EE, Springboot starter 3.2 and StringBoot 2.1.1.
I am getting similar error:
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'scriptingEngineInitializer' defined in file [C:\Mycode\target\classes\com\kn\knflow\platform\embedded\engine\scripting\ScriptingEngineInitializer.class]:  Initialization of bean failed; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'lazyInitRegistration' defined in class path resource   [org/camunda/bpm/spring/boot/starter/webapp/CamundaBpmWebappAutoConfiguration.class]: Initialization of bean failed; nested exception is java.lang.RuntimeException: javax.servlet.ServletException:   Could not read security filter config file '/securityFilterRules.json': no such resource in servlet context. 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:584) 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:498) 	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320) 	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222) 	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
Similar error comes on Camunda 7.11-ee aswell, because of the fact that XML libraries are moved for Spring boot in 2.1 releases.
Using this external dependancy because of new Spring boot.
        <dependency>             <groupId>org.glassfish.jaxb</groupId>             <artifactId>jaxb-runtime</artifactId>             <version>2.3.0</version>         </dependency>
Any ideas how to overcome the same issue on latest Camunda versions running on Spring boot 2.1.X


Change variable vbmc_host to ansible_host to get the host that playbo…

TestBos2: virt
…ok run against this need to run the playbook on ansible navigator container

retest

Found the way to bypass it


tests/net/ieee802154/crypto fails on Quark SE / x86

commit v1.12.0-rc2-45-g43553da9b2
No output is printed upon booting (no Booting Zephyr or anything at all) [same result on six different boards]

I'll check but not even the boot message... isn't this the same as #8039 ?

not sure if it is the same -- the symptoms look the same,

Confirmed fixed.


Skip lib sources when rebuilding opened files

Files that are opened in the editor automatically rebuilt (to show diagnostics without the need to update and save it), but it is not so actual for the library sources, esp considering that compiler currently rebuilds if they are not changed (and rebuild is actually not needed to be rebuilt, that may unnecessarily trigger file watching tools). So this checks if the file path contains .spago or bower_components to skip it.

To be clear, this is just skipping triggering a rebuild on dependency files on open, it will still be triggered if one edits and saves the file? That seems like a good compromise, of course people may occasionally make quick edits to dependencies inside .spago for example and that should still show diagnostics.

To be clear, this is just skipping triggering a rebuild on dependency files on open, it will still be triggered if one edits and saves the file? That seems like a good compromise, of course people may occasionally make quick edits to dependencies inside .spago for example and that should still show diagnostics.

Absolutely, this branch only affects opened (activated) files, the next handler onDidSaveDocument responsible for pushing diagnostics when the file is changed and saved.


Error parsing docs for Js.re.exec_ in stdlib

Should I file this on bucklescript?

We'll just remove special odoc parsing.


react-native-navigation (wix) fix

Hey man, I was initiating using your lib but it has a problema with wix navigation lib. When you call System.exit(0) and start a new activity, the hole application is launched again. By doing this I can prevent the restart of the app and show the error activity.

Hi @faogustavo  Great ! looks good. Can you also add this detail onto the README file ?
That will help everyone using this library to know about this android specific feature.

Sure, Tomorrow I do that. :D

@master-atul Updated readme and index.js to only apply the parameter on Android. Our app is not adjusted to iOS yet. But asap I will test on iOS and if need to change the iOS native module too I made another PR.

@master-atul no needs to change on iOS :D

@faogustavo  Thanks for the PR. I will merge this code to develop branch and will bump version and other minor changes and push it into new version on master.
Thanks for the contribution.


Allow executing a paused step in SimulationRunner

This PR enables the execution of paused steps as described in #51.
While this is a very small change, I suspect that it's quite delicate. I'd like to start the discussion of what's needed to make it land upstream. Any recommendation about possible tests? I can initially start with something confined as in the linked issue.
Let me know if I have to change the target branch, I initially pointed ign-gazebo3.
cc @chapulina @azeey

OT
I take advantage of this PR to congratulate with all the team for the massive migration! Having the project in GitHub is amazing and believe it will pay off in the long run, I'm sure the community involvement will increase.

@osrf-jenkins run tests

It seems that the following assertions are failing:
https://github.com/ignitionrobotics/ign-gazebo/blob/98199d18d22e06631c4b3f23fc08e8e9c124bb40/src/Server_TEST.cc#L422
https://github.com/ignitionrobotics/ign-gazebo/blob/98199d18d22e06631c4b3f23fc08e8e9c124bb40/test/performance/each.cc#L141

I'd like to start the discussion of what's needed to make it land upstream.

Friendly ping @azeey @chapulina

Hi @diegoferigo , this looks like a change of behaviour to me. There could be users starting simulation paused on purpose and choosing when the iterations start being run. Would you be open to targeting this at master?

The performance/each.cc test is flaky so I don't believe it's related to this PR. The Server_TEST.cc, however, is something we need to resolve. It looks to me that, currently, calling Server::Run(false, 100, true) will block until Server::IterationCount == 100, but since it is paused, that will never happen unless another thread calls Server::SetPaused(false). This implies that there is an expectation that when the Server::Run call returns, Server::IterationCount will be 100. But, with the change in this PR, Server::Run(false, 100, true) will return after a little while and there is no guarantee that  Server::IterationCount will be 100.
Similarly, as demonstrated in the failing test RunNonBlockingPaused of Server_Test.cc, Server::Run(true, 100, true) will run in the background and will keep running until Server::SetPaused(false) is called and iterations can count up again. The test fails because it expects the server to be running immediately after calling Server::SetPaused(false), but with this PR, the server is likely done running before the Server::SetPaused(false) is even called.
I agree that it would be nice to allow executing a paused step, but I think we need a new API for it. I'm not sure what that would like like yet. I need to think about it some more.

Similarly, as demonstrated in the failing test RunNonBlockingPaused of Server_Test.cc, Server::Run(true, 100, true) will run in the background and will keep running until Server::SetPaused(false) is called and iterations can count up again. The test fails because it expects the server to be running immediately after calling Server::SetPaused(false), but with this PR, the server is likely done running before the Server::SetPaused(false) is even called.

My understanding of the failure is the change of behaviour about how simulator iterations are counted internally:

Currently: the server can perform a number of paused steps and calling server.IterationCount() would provide 0. Though, the numbers of steps to excute are cached internally and they are processed as soon as the server gets unpaused.
With this PR: the server can perform a number of paused steps and calling server.IterationCount() would provide 0. Though, the numbers of steps to execute are not cached internally and they are eaten by paused steps. This means that when the server gets unpaused, there are less (or no) iterations left to be executed.

I agree that it would be nice to allow executing a paused step, but I think we need a new API for it. I'm not sure what that would like like yet. I need to think about it some more.

Awesome, thanks, I'll be waiting further information then! A use case that I found very interesting with single paused steps is to create a server object that starts paused and provides the possibility to get stepped deterministically:
ignition::gazebo::ServerConfig config;
config.SetSdfFile("empty.sdf");
config.SetUpdateRate(1000);

ignition::gazebo::Server server(config);

server->Run(/*blocking=*/true, /*iterations=*/1, /*paused=*/true)

After this operation, the caller has complete control of the simulation, and it is able to perform either other paused steps (e.g. to insert models and trigger the ECM to add their entities and components) or start running the simulation issuing uppaused commands. I've been using this branch for a while now, and I'm very happy of the performance.

Hi @diegoferigo , this looks like a change of behaviour to me. There could be users starting simulation paused on purpose and choosing when the iterations start being run. Would you be open to targeting this at master?

I can surely change the target branch. Considering also @azeey comments, it seems that new APIs are needed in any case.

a server object that starts paused and provides the possibility to get stepped deterministically

+1, this is an important use case that's currently underserved.

I can surely change the target branch. Considering also @azeey comments, it seems that new APIs are needed in any case.

Depending on the APIs, they could be backwards compatible. My main concern is not breaking the current behaviour. If we can support your use case while still keeping the current behaviour by default, it would be great to do it in Citadel.

Depending on the APIs, they could be backwards compatible. My main concern is not breaking the current behaviour. If we can support your use case while still keeping the current behaviour by default, it would be great to do it in Citadel.

In the meantime I updated the PR to target master. If we find a backward-compatible solution I'd be more than happy to rebase it again to target Citadel.

Is there any chance to get this merged within the Dome window? For other few weeks I won't have much time for major extensions, but I'd like at least to start the discussion of the actions to take waiting August.

Hi Diego, sorry for the wait. I'm leaning towards adding new API for ECS iterations (as opposed to simulation iterations) in Dome. This would allow us to maintain the current behaviour, as well as support your use case. Is this something you'd be interested in helping with?
Sorry for the back-and-forth, thanks for redirecting this PR to master, but I think that's the right thing to do in order to avoid confusion in the future. The current semantics of iteration is "simulation iterations", so if you're running paused and blocked, it should loop until unpaused.
My proposal:

Close this PR (sorry again)
Brainstorm the ECS iteration API in #51
Once there's an agreement, open a new PR against Dome with the new API (or against Citadel if it's backwards-compatible)

Hi @chapulina, no problem, that sounds a good plan to me. I can definitely help with this task :wink: I tried to recap the current status in https://github.com/ignitionrobotics/ign-gazebo/issues/51#issuecomment-655979495, please let me know if you already have something more concrete in mind. Closing.


Connection reset when attempting to join voice channel

I'm getting this exception sometimes when someone requests my music bot to join a voice channel:
[21:31:55] [Fatal] [JDASocket]: Encountered an exception:
[21:31:55] [Fatal] [JDASocket]: java.lang.RuntimeException: com.neovisionaries.ws.client.WebSocketException: Failed to send an opening handshake request to the server: Connection reset
        at net.dv8tion.jda.audio.AudioWebSocket.<init>(AudioWebSocket.java:109)
        at net.dv8tion.jda.handle.VoiceServerUpdateHandler.handleInternally(VoiceServerUpdateHandler.java:68)
        at net.dv8tion.jda.handle.SocketHandler.handle(SocketHandler.java:38)
        at net.dv8tion.jda.requests.WebSocketClient.handleEvent(WebSocketClient.java:615)
        at net.dv8tion.jda.requests.WebSocketClient.onTextMessage(WebSocketClient.java:324)
        at com.neovisionaries.ws.client.ListenerManager.callOnTextMessage(ListenerManager.java:352)
        at com.neovisionaries.ws.client.ReadingThread.callOnTextMessage(ReadingThread.java:233)
        at com.neovisionaries.ws.client.ReadingThread.callOnTextMessage(ReadingThread.java:211)
        at com.neovisionaries.ws.client.ReadingThread.handleTextFrame(ReadingThread.java:910)
        at com.neovisionaries.ws.client.ReadingThread.handleFrame(ReadingThread.java:693)
        at com.neovisionaries.ws.client.ReadingThread.main(ReadingThread.java:102)
        at com.neovisionaries.ws.client.ReadingThread.run(ReadingThread.java:61)
Caused by: com.neovisionaries.ws.client.WebSocketException: Failed to send an opening handshake request to the server: Connection reset
        at com.neovisionaries.ws.client.WebSocket.writeHandshake(WebSocket.java:2546)
        at com.neovisionaries.ws.client.WebSocket.shakeHands(WebSocket.java:2437)
        at com.neovisionaries.ws.client.WebSocket.connect(WebSocket.java:1583)
        at net.dv8tion.jda.audio.AudioWebSocket.<init>(AudioWebSocket.java:104)
        ... 11 more
Caused by: java.net.SocketException: Connection reset
        at java.net.SocketInputStream.read(SocketInputStream.java:209)
        at java.net.SocketInputStream.read(SocketInputStream.java:141)
        at sun.security.ssl.InputRecord.readFully(InputRecord.java:465)
        at sun.security.ssl.InputRecord.read(InputRecord.java:503)
        at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:973)
        at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1375)
        at sun.security.ssl.SSLSocketImpl.writeRecord(SSLSocketImpl.java:747)
        at sun.security.ssl.AppOutputStream.write(AppOutputStream.java:123)
        at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
        at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
        at java.io.FilterOutputStream.flush(FilterOutputStream.java:140)
        at com.neovisionaries.ws.client.WebSocket.writeHandshake(WebSocket.java:2539)
        ... 14 more

As a result of this the bot doesn't actually connect to the voice channel, but the audio manager will still think it is trying to connect to the voice channel, since it throws this exception the second time:
java.lang.IllegalStateException: Already attempting to start an AudioConnection with a VoiceChannel!
Currently Attempting Channel ID:<PHONE_NUMBER>7848960  |  New Attempt Channel ID:<PHONE_NUMBER>7848960
        net.dv8tion.jda.managers.impl.AudioManagerImpl.openAudioConnection(AudioManagerImpl.java:71)
        fredboat.audio.GuildPlayer.joinChannel(GuildPlayer.java:70)
        fredboat.audio.GuildPlayer.joinChannel(GuildPlayer.java:47)
        fredboat.command.music.JoinCommand.onInvoke(JoinCommand.java:17)
        fredboat.commandmeta.CommandManager.prefixCalled(CommandManager.java:39)

I have also noticed that sometimes the bot will appear to be connected to a voice channel on the client but is unable to play audio or closing the connection with AudioManager.closeAudioConnection(), having no effect at all. In this case trying to connect to the voice channel results in the same IllegalStateException.
Restarting the bot seems to be the only temporary fix, as kicking and reinviting the bot will not fix it.
It might be that the WebSocketException is only triggered after the bug has first occurred and the bot is reinvited.
This has been going on for several versions now. The bot is currently running JDA 2.2.1_355.

The has to do with JDA not being able to establish the connection. An audio connection is a 3 part system.

We tell Discord we are joining which immediately puts us in the room visually on the client.

Discord sends us information to connect. Sometimes, if Discord does not have enough resources, it will send us a null endpoint which is a promise that Discord will send a valid endpoint later to connect with. JDA currently doesn't handle this.

After getting the info, JDA attempts to setup the audio connection. We first open a Websocket connection, send identifying information and then attempt to connect a UDP socket for audio connection.

The above error occurs in step 3 when JDA attempts to open a Websocket connection to discord. Discord is ignoring our Websocket's attempt at a connection handshake, thus, things are failing. Not quite sure why.  My guess would be that you briefly have a loss of internet when the socket is opening, thus making the request never reach Discord. A possible fix would be to retry establishing the connection similarly to the past fix for the UDP socket not connecting.
The issue with the AudioManager believing it is in the channel is because JDA expects things to go well and, in this situation, doesn't fully handle the possibilities of failure on connection. I'll look into implementing a fix.


#2336, remove the front end submodule

Fix #2336

Codecov Report

Merging #2350 (e09f244) into master (001ffba) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2350      +/-   ##
============================================
- Coverage     58.13%   57.90%   -0.24%
+ Complexity     3952     3944       -8
============================================
  Files           629      629
  Lines         18061    18058       -3
  Branches       1695     1693       -2
============================================
- Hits          10500    10456      -44
- Misses         6725     6763      +38
- Partials        836      839       +3

Impacted Files
Coverage Δ

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-18.45%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
82.35% <0.00%> (-11.77%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.73% <0.00%> (-9.48%)
:arrow_down:

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
8.69% <0.00%> (-4.35%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
23.20% <0.00%> (-4.00%)
:arrow_down:

...che/shenyu/admin/model/vo/SelectorConditionVO.java
96.07% <0.00%> (-1.97%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
54.54% <0.00%> (-1.82%)
:arrow_down:

...rg/apache/shenyu/plugin/hystrix/HystrixPlugin.java
74.07% <0.00%> (-0.93%)
:arrow_down:

.../plugin/grpc/loadbalance/AbstractLoadBalancer.java
69.56% <0.00%> (-0.33%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001ffba...e09f244. Read the comment docs.


pygtk build is broken

http://hydra.nixos.org/build/44579911 has the log of a failing build, which I can reproduce verbatim locally (so it would not appear to be transient).
This would appear to be a consequence of the big python infrastructure changes?  Maybe @FRidh (I'm guessing, and I apologize in advance if I'm guessing incorrectly)?

Thanks for the report.
So it seems that c1d98d959b38df00a1d933a5a9a381aa80096024 fixed certain packages but broke others.

@FRidh may be
configurePhase = attrs.configurePhase or '' runHook ....

will works better?

yes

@FRidh at least it fix pygtk, I can make PR when my build complete (if you like)

@avnik I'm testing a couple of other packages first and then I'll push it. But thanks!


Update README.md

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: TrafalgarZZZ
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Ensure power_demand_divider is considered when checking the maximum power limit

Easy fix for https://github.com/syssi/esphome-soyosource-gtn-virtual-meter/issues/86

Tested with a manual setting of 703 Watts leading to a power generation of about 1.4 kW:

The uppermost value "Solarstrom" is independently measured using a "real" power meter read by the ESP through the 10.000 pulses/kWh output.
Even if probably not relevant at all, I feel I should still say it here: I use this setup to deliver additional power (if needed) to my solar island with an inverter that is just a tiny bit too small sometimes. My inverters are not connected to the public power grid.

Closing in favor of https://github.com/syssi/esphome-soyosource-gtn-virtual-meter/pull/88


Is there any way plugin http.browse args could be a absolute path?

(Are you asking for help with using Caddy? Please use our forum instead: https://caddy.community. If you are filing a bug report, please take a few minutes to carefully answer the following questions. If your issue is not a bug report, you do not need to use this template. Thanks!)
1. What version of Caddy are you using (caddy -version)?

Caddy 0.10.3

2. What are you trying to do?

File browser

3. What is your entire Caddyfile?
<IP_ADDRESS> {
        browse /
}

4.  Please paste any relevant HTTP request(s) here.

http://<IP_ADDRESS>:2015/

6. What did you expect to see?

Now plugin http.browse args relative to current command running path.
Is there any way plugin http.browse args could be a absolute path?

Yes, specify root.
https://caddyserver.com/docs/root
For future reference, questions like this should be asked on the forums, as noted in the issue template.


Use Icons from Manifest on Layout

Refactored manifest.js to be a class.
Added Icons and background colors to UI.
Need to fetch the icons and serve from Gulliver server

@ithinkihaveacat PTAL

LGTM, Just one small comment.

Moved the user-agent to a static variable. @juliantoledo  PTAL.

LGTM


Remove duplicate update definitions in jobs

YAML permits only one definition of hash. The 2nd definition is over-
riding the 1st one, which then never takes effect. Remove the 1st
definition to remove potential confusion.

@mtekel - thank you for this submission - we'd like to merge it; but we don't seem to have a signed Contributors License Agreement on record for you.
Please could you print & sign the relevant CLA from https://github.com/logsearch/licensing#signing-the-contributors-license-agreement and forward to<EMAIL_ADDRESS>Thanks!
D


apply suggestions to fix the xfail error and the case if no fields supplied

Three lines change - adding a default value for fields, and removing pytest xfail lines

@danielballan the xfail removal makes the tests fail, I think I forgot the minutiae of that part of the ticket - should the failing tests be removed or modified?

IIRC those tests should work, but they were xfailed because we broke our simulation tools so we should leave the tests alone and either fix or modify the simulated devices we are handing in.

Discussion on call: Merge the change to BEC to fix that issue, but defer removing the xfail and fixing the simulation code to a separate issue.

limiting the PR to the default fields, to make the new issue for the xfail logic which interlaces with the ophyd.sim.
hw.det (module in ophyd)


[SPARK-26929][SQL]fix table owner use user instead of principal when create table through spark-sql or beeline

…create table through spark-sql or beeline
What changes were proposed in this pull request?
fix table owner use user instead of principal when create table through spark-sql
private val userName = conf.getUser will get ugi's userName which is principal info, and i copy the source code into HiveClientImpl, and use ugi.getShortUserName() instead of ugi.getUserName(). The owner display correctly.
How was this patch tested?

create a table in kerberos cluster
use "desc formatted tbName" check owner

Please review http://spark.apache.org/contributing.html before opening a pull request.

link to https://github.com/apache/spark/pull/23837
@HyukjinKwon , i created a new PR, please review here, thanks.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@HyukjinKwon @felixcheung @vanzin , could you help to review this?

I think it’s best you find someone on the SQL side to review this.

cc @dongjoon-hyun FYI.

Can one of the admins verify this patch?

@dongjoon-hyun  could you help to review this?

@rxin , @cloud-fan could you help to review?

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9164/
Test PASSed.

Test build #103790 has started for PR 23952 at commit 2609c9c.

Test build #103790 has finished for PR 23952 at commit 2609c9c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103790/
Test FAILed.

@cloud-fan, how to fix error 'fails Scala style tests ', should i move code to function? Could you give some suggest.

cc @rxin , @cloud-fan, @dongjoon-hyun

ok to test

Test build #108151 has started for PR 23952 at commit 05e54fe.

Test build #108151 has finished for PR 23952 at commit 05e54fe.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108151/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13253/
Test PASSed.

Merged build finished. Test PASSed.

Only fix table owner is not enough. we should create table will the right user  not just change table owner

Only fix table owner is not enough. we should create table will the right user not just change table owner
Just owner display error information, other is correct.

Test build #108153 has started for PR 23952 at commit bdcc9fa.

Test build #108153 has finished for PR 23952 at commit bdcc9fa.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108153/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13255/
Test PASSed.

Test build #108154 has started for PR 23952 at commit c4e3468.

Test build #108154 has finished for PR 23952 at commit c4e3468.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108154/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13258/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13259/
Test PASSed.

Test build #108158 has started for PR 23952 at commit e8c0571.

Test build #108158 has finished for PR 23952 at commit e8c0571.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108158/
Test FAILed.

Test build #108161 has started for PR 23952 at commit c27d4af.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13264/
Test PASSed.

Test build #108161 has finished for PR 23952 at commit c27d4af.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108161/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13290/
Test PASSed.

Test build #108189 has started for PR 23952 at commit f1eb8cf.

Test build #108189 has finished for PR 23952 at commit f1eb8cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108189/
Test PASSed.

cc @rxin , @cloud-fan, @dongjoon-hyun

@rxin , @cloud-fan, @dongjoon-hyun  could you help to review?

I'm not sure whether it's easy or challenging, but if possible could we have UT for this? You already know it has been back-and-forth, principal -> username -> principal, and you're fixing it again to username. Ideally we need to try our best to avoid regression.

Can one of the admins verify this patch?

I'm not sure whether it's easy or challenging, but if possible could we have UT for this? You already know it has been back-and-forth, principal -> username -> principal, and you're fixing it again to username. Ideally we need to try our best to avoid regression.

I think it's should be username, and user's name is better than principal here.

I tend to agree, just wanted to say without UT we may have regression even after this patch.

I'm addressing test part as #25696 - I didn't raise a PR against this PR as the change was more than what I expected. This patch can reflect the change (change to shortUserName) once #25696 is merged.

FYI, #17311 explained why #23952 should be applied.

In the kerberized hadoop cluster, when Spark creates tables, the owner of tables are filled with PRINCIPAL strings instead of USER names. This is inconsistent with Hive and causes problems when using ROLE in Hive. We had better to fix this.

Let me try to ping again cc. @cloud-fan @gatorsmile @dongjoon-hyun

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15387/
Test PASSed.

Test build #110401 has started for PR 23952 at commit 6011598.

Test build #110401 has finished for PR 23952 at commit 6011598.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110401/
Test FAILed.

Rebased.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15397/
Test PASSed.

Test build #110412 has started for PR 23952 at commit 76192b2.

Test build #110412 has finished for PR 23952 at commit 76192b2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110412/
Test FAILed.

retest this, please

Test build #110416 has started for PR 23952 at commit 76192b2.

Test build #110416 has finished for PR 23952 at commit 76192b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110416/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15435/
Test PASSed.

Test build #110451 has started for PR 23952 at commit a8d6b1d.

@HeartSaVioR
An unrelated question, why most tests failed, and passed all after your reset.

Hive test seems to be a bit flaky. So the Spark community tries to fix the flay tests as many as possible, but there're many cases Spark community can't fix the flakiness. Rerunning build doesn't matter - if the test is failing consistently that's the matter.

Hive test seems to be a bit flaky. So the Spark community tries to fix the flay tests as many as possible, but there're many cases Spark community can't fix the flakiness. Rerunning build doesn't matter - if the test is failing consistently that's the matter.

Thanks.

Test build #110451 has finished for PR 23952 at commit a8d6b1d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110451/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15471/
Test PASSed.

Test build #110496 has started for PR 23952 at commit 2f37513.

Test build #110496 has finished for PR 23952 at commit 2f37513.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110496/
Test PASSed.

Merging to master.

Thanks again @hddong for making this patch - pretty useful.