Backport: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…

…e-site.xml (#1310)
Signed-off-by: Nick Dimiduk<EMAIL_ADDRESS>Signed-off-by: stack<EMAIL_ADDRESS>

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 42s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 39s
branch-1 passed

+1 :green_heart:
shadedjars
2m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 53s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 51s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 55s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
checkstyle
1m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
xml
0m  0s
The patch has 1 ill-formed XML file(s).

+1 :green_heart:
shadedjars
2m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 54s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 39s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
128m 43s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

175m 12s

Reason
Tests

XML
Parsing Error(s):

hbase-server/src/test/resources/override-hbase-site.xml

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1344/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1344

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml

uname
Linux e0f6b89feaac 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1344/out/precommit/personality/provided.sh

git revision
branch-1 / 61e17d7

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

xml
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1344/1/artifact/out/xml.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1344/1/testReport/

Max. process+thread count
4178 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1344/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hbase-site2.xml is renamed to override-hbase-site.xml, checked the format of xml, hbase-site2.xml has similar format as hbase-site.xml. Ignoring xml error for now.


skawarePackages.skalibs: empty default path

If PATH is unset, the exec wrappers in skalibs set a default path to
/usr/bin:bin.
This has very unfortunate effects when you e.g. try to run tests on CI
in an empty environment (minus tools explicitely provided by nix with
absolute store paths), because suddenly binaries from outside are
picked up again, especially on non-NixOS.
Even on NixOS, /bin/sh provides another escape hatch if it’s available
from PATH. But on systems like Ubuntu or MacOS (which most CI systems
run on), this picks up all the non-nix binaries.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @pmahoney

@GrahamcOfBorg build skawarePackages

nix-review is happy, macos 10.13.

Is OfBorg supposed to have skipped Darwin?


Added GOTV CVARs

Hello, I'm using this image for my development
Could you add GOTV related cvars for server? I can add more cvars if needed
Thanks

Ty @FlowingSPDG ! ofc, i'll merge this one, but will take until tomorrow to actually build and push it with the features, since i also have to find a better solution for the automatic docker hub update.

Cool cool! Thanks you!

currently the image is pushing, but it seems that its going to take around 1-1.5h until its up.
If you want to add more features, it would be great to PR them together, since the rebuild takes a lot of time to build and expecially push :D Sadly the gh runners have not enough space to do that in the ci, so i have to do it on my local machine (40Mbit/s upload). ntl, i appreciate any contributions, but it maybe takes a few days until i can merge and push stuff :)

Oh okay! I was thinking to add 128tick settings(sv_mincmdrate or smt, sv_minupraterate?) and few more stuffs so I'll put them together when I send PR!


Handle authorize and forbid for redirecting handlers.

#667 - Authenticated but not authorized infinite loop
#801 - Authenticate remote provider by name
When a user lacks a specific claim the authorization service issues a Challenge. For Bearer or Cookies they accept this challenge, verify that they produced the identity, and switch to Forbid. This isn't happening for the remote providers because they do not maintain the identity, they delegate that to Cookies. As such they end up in an infinite challenge loop. See https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication/AuthenticationHandler.cs#L310-L332 for reference on Challenge behaviors.
Similarly, [Authorize(ActiveAuthenticationSchemes = OpenIdConnectDefaults.AuthenticationScheme)] doesn't work because the remote auth handler does not store the identity internally so HttpContext.Authentication.AuthenticateAsync(scheme) always returns null. [Authorize] works because Cookies has AutomaticAuthenticate and OIDC has AutomaticChallenge.
Fix: When a remote handler is 'Authenticating', have it delegate to the handler specified by SignInScheme.
@HaoK @PinpointTownes Thoughts?
@vibronet I think this will break your background refresh sample where you challenge for the current auth type to refresh the identity. I think it can still work if we make an easy way to avoid ChallengeBehavior.Automatic.

Hi @Tratcher, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Hrm this feels a bit weird, but I guess that's what this handler boils down to logically, we want the challenge to go remote, but Forbid/Authenticate really are going against the SignInScheme.

When a user lacks a specific claim the authorization service issues a Challenge. For Bearer or Cookies they accept this challenge, verify that they produced the identity, and switch to Forbid.

This is the real problem. Get rid of this terrible voodoo magic and all these weird problems will suddenly disappear, without having to introduce odd work arounds.

@HaoK @PinpointTownes Thoughts?

IMHO, this fix seems fragile as it relies on the informational ClaimsIssuer property. If you really like this approach, I think it would be preferable to bind ClaimsIdentity.AuthenticationType with AuthenticationScheme.

I think its too late at this point to revisit the Challenge behavior again.  But that magic is specific to  MVC's authorize filter implementation, in general you can opt out of that challenge magic anyways by calling the Challenge passing in the specific ChallengeBehavior you want (Unauthorized/Forbidden)

Updated to be less strict about the identity check. We'll see if it causes any confusion.

:shipit:


Tor Browser: add-ons disabled on start

Describe the bug
In Tor Browser, all add-ons, including HTTPS Everywhere and NoScript are disabled when you start up the browser.
To Reproduce
Steps to reproduce the behavior:

Ensure you have Tor Browser 9.0.6 (from 20.03 or unstable).
Right-click on the starting page.
Observe that the "NoScript" option is missing.

Expected behavior
All add-ons should be enabled on startup.
Additional context
This appears to be a regression since 9.0.5 introduced in https://github.com/NixOS/nixpkgs/pull/82754
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.4.24-gnu, NixOS, 20.03beta591.99a3d7a86fc (Markhor)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.2
channels(root): "nixos-20.03beta695.b2935fbecea, u-20.09pre217526.9b3515eb95d"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: nixos.tor-browser-bundle-bin
# a list of nixos modules affected by the problem
module:

After deleting $HOME/.local/share/tor-browser and re-starting Tor Browser, this problem seems to have gone away. I'm not sure what caused it.

It seems like switching between Tor Browser versions causes it, for instance switching from mediaSupport = false to mediaSupport = true. After deleting the Tor Browser directory once, the issue is solved until you switch again,

This happens to me even after simply quitting Tor Browser and starting again, no upgrade or change in-between, although it's not 100% reproducible - I haven't yet figured out what are the exact conditions that trigger this. It's peculiar because NoScript is missing from the UI, although it shows as enabled in about:addons.
pinging the maintainers: @offlinehacker  @matejc  @doublec  @thoughtpolice  @joachifm  @hax404 @scaredmushroom

With the upgrade to Tor Browser 10.0.2, NoScript is missing 100% of the time, the Hightest Security Level doesn't disable javascript.
I wouldn't consider using Tor Browser in this state - it's too different from its normal behavior.

It needs to be marked broken until this is resolved, imo.

potentially related upstream issue: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40208

I have a fix for the noscript issue, feel free to check it out, and see if it works for you.
But the HTTPS Everywhere addon is loaded via a different mechanism I think?
At least on my system it used to work even with the 10.* version before this fix.

And do we have a channel to notify users about the fact that they potentially used a broken version of the tor-browser since c68911714f08c2f7616ddb34c150cded80a67c61 (Sep 23)?
This is rather critical software..


Still using old bluemix urls

I think this client needs to be updated to use the new cloud.ibm.com endpoints. It seems to be still using the old bluemix.net ones.
Current endpoints are .kms.cloud.ibm.com

Good catch, opened https://github.com/IBM/redstone/issues/16 to fix


User can access to all other folders and files

If a user knows the layout of the storage provider can access another user's data without share it.
Reproduce on local instance, Reva version commit ca9721ca7acf42ebf9bbcec4ad90c8c5ca0a2a2a:

Run Riva with config https://github.com/cs3org/reva/tree/master/examples/storage-references and example https://developer.sciencemesh.io/docs/iop/deployment/kubernetes/providers/
Login as Marie, list folder with "/reva" path, write and get contents from different user files.

$ ./reva --insecure
reva-cli v1.4.0-44-gca9721c (rev-ca9721c)
Please use `exit` or `Ctrl-D` to exit this program.
>> login basic
username: marie
password: OK
>>
>> ls /home
non_zero_marie.txt
...
>> ls /reva
cb27b026-0cf3-40eb-a918-07c41d28aee3
d32275cd-0496-419d-8b91-6d2bd741d6c2
einstein
f7b27773-d4dc-4d41-8927-d7ff9ed6952e
...
>>
>> ls /reva/einstein
example1.txt
example2.txt
...
>> ls /reva/einstein/test2
note3a-Copy1.ipynb
note3a-Copy2.ipynb
>>
>> download /reva/einstein/text.txt text.txt
Downloading from: http://......:19001/datagateway
 8 B / 8 B [=========================================================================================================================================================================================] 100.00% 0s
>>
>> upload text.txt /reva/einstein/new_text.txt
Local file size: 8 bytes
Data server: http://......:19001/datagateway
Allowed checksums: [type:RESOURCE_CHECKSUM_TYPE_MD5 priority:100  type:RESOURCE_CHECKSUM_TYPE_UNSET priority:1000 ]
Checksum selected: RESOURCE_CHECKSUM_TYPE_MD5
Local XS: RESOURCE_CHECKSUM_TYPE_MD5:3993f469779dfab0f7c9fd819a12f329
File uploaded: 123e4567-e89b-12d3-a456-426655440000:fileid-%2Feinstein%2Fnew_text.txt 8 /reva/einstein/new_text.txt
>>

Reproduce in Kubernetes cluster:

Using deployment: https://wiki.cs3mesh4eosc.eu/en/wps/3/deployments#ailleron
Login as "jarek" and list folders from users: dawid and mateusz

>> login basic
username: jarek
password: OK
>>
>> ls /home
MyShares
>>
>>
>> ls /reva/
dawid
jarek
mateusz
test
>> ls /reva/dawid
example.txt
example2.odt
...
>> ls /reva/mateusz
ail-mun.txt
...
>> download /reva/dawid/example.txt example.txt
Downloading from: https://sciencemesh.softwaremind.com/iop/datagateway
 7 B / 7 B [=========================================================================================================================================================================================] 100.00% 0s
>>
>>
>> upload example.txt /reva/dawid/example2.txt
Local file size: 7 bytes
Data server: https://sciencemesh.softwaremind.com/iop/datagateway
Allowed checksums: [type:RESOURCE_CHECKSUM_TYPE_MD5 priority:100  type:RESOURCE_CHECKSUM_TYPE_UNSET priority:1000 ]
Checksum selected: RESOURCE_CHECKSUM_TYPE_MD5
Local XS: RESOURCE_CHECKSUM_TYPE_MD5:e1930b4927e6b6d92d120c7c1bba3421
File uploaded: 123e4567-e89b-12d3-a456-426655440000:fileid-%2Fdawid%2Fexample2.txt 7 /reva/dawid/example2.txt
>>

Won't fix in localfs.


Feat/plugins mesh field 1/2

This PR includes:

A fix on the schema, found by chance while studying how to best implement the new field
A new field called mesh_mode to tag plugins with inbound, outbound or two-way. Note that two-way plugin instances can be individually tagged as inbound or outbound on creation, but plugins tagged as inbound can only have inbound instances, and the same goes for outbound pluggins.

I have tagged 15 plugins as two-way on this PR. There are multiple commits with explanations for my reasons.

@kikito You have added a new top-level field to the Plugins entity in the db, but in the schemas you added it as a subfield of the config entry. If mesh_mode is a top-level Plugins field, it should be alongside config in the schemas, and not inside it.

The auth plugins are all two-way, but I think their default value should be outbound. The functional effect will be the same. You want it to run on outbound to stop 'unwanted' traffic asap, and if it passes on one end, it will also pass on the other end (inbound), so there is no use in authenticating again.
Conceptually: currently the available values are tied to the default value. And I think they should be separate.

The auth plugins are all two-way, but I think their default value should be outbound. The functional effect will be the same. You want it to run on outbound to stop 'unwanted' traffic asap, and if it passes on one end, it will also pass on the other end (inbound), so there is no use in authenticating again.

I was imagining all the auth plugins would be inbound - that is conceptually most similar to how Kong API Gateway works, and I think it is easier to reason about (eg. "OK, I'm configuring an auth plugin that'll decide who gets past the proxy and gets to talk to my application..." - that makes it all about inbound traffic to the local proxy+application, and makes no assumptions about the source of the traffic)

In service mesh it is different. The forward proxy already knows that authentication is going to fail, so it stops the traffic on a sidecar (Kong proxy) before even entering the network. Eg. traffic is stopped on forward proxy's incoming traffic and not on the callee service reverse proxy incoming traffic. I'd like to call these forward and reverse proxies, e.g. plugin is executed on forward proxy or reverse proxy or both. Most of the auth plugins will be executed on service mesh only on forward proxy e.g. The traffic that is trying to enter the mesh. After The traffic has entered the mesh, it is trusted traffic by mutual tls. All The plugins still have same incoming and outgoing nginx phases. It is just a matter that will the plugin run on one proxy (and which) or both. I would use forward proxy, reverse proxy and both|always|..., e.g. run-on="forward-proxy". You could call forward and reverse proxies as exit and enter If you think about network structure. Traffic exits the service a and enters service b. But forward-proxy and reverse-proxy are My favourites.

After talking with James, I got new info, so new proposal for naming:
run-on="gateway|mesh|both"
Because we don't know before actual connection is made whether or not we are in service mesh or not we call everything by default a gateway. All forward proxies in service mesh are gateways (gw to the mesh), all reverse proxies in service mesh are mesh nodes. So only the incoming can be a mesh node in service mesh. If there is no service mesh, then all Kong nodes are gateways, and usually they are reverse proxies (e.g. ingress). The role cannot change between different Nginx phases (by design).
So if you think about this, then all our current plugins should be marked run-on="gateway". But we may adjust some (the zipkin tracing to be "both"). We do not have mesh only plugins, e.g. run only on incoming (reverse proxy) mesh.

^ the above is the default hard coded plugin level settings. The next question obviously is that do we allow change these defaults on plugin instance level, e.g. plugin.config.run_on=mesh overrides the hardcoded plugin.run_on=gateway.

Okay, another take on this:
run_on="untrusted|trusted|both"
(pick a better name for run_on)
The untrusted is the default. E.g. all the traffic that enters Kong will be untrusted. And all the plugins are by default configured untrusted. It makes sense to run e.g. auth plugins on untrusted connections, e.g. service 1 connecting its own side car proxy (that is untrusted). The traffic can only become trusted when the connection is made in service mesh and authenticated with mutual tls.
The trusted can thus only be the receiving end of the mesh in this simple exercise of SERVICE-A -> KONG-FORWARD-PROXY (a sidecar for SERVICE-A) -> KONG-REVERSE-PROXY (a sidecar for SERVICE-B) -> SERVICE-B. Yes the KONG-REVERSE-PROXY is the trusted and KONG-FORWARD-PROXY is the untrusted.
And then we have both (possibly for zipkin only for now) which just means that plugin runloop will execute regardless if the source of the request (it doesn't matter if the connection was trusted or untrusted).
And again we can have hard-coded default on plugin schema:
plugin.run_on="untrusted" (probably all except zipkin)
and then a runtime override on plugin configuration (if the user for some weird reason wants to run it differently than the sane default):
plugin.config.run_on="both"


MAINT: f2py build output cleanup

As can be seen from the appveyor outputs, f2py, while building the LAPACK sources, gets confused when it encounters <...> in the comments since it uses these for iterating over different dtypes.
This removes the following, ignored, parse failures from the build output.
\build\src.win-amd64-3.6\scipy\linalg
    adding 'build\src.win-amd64-3.6\build\src.win-amd64-3.6\scipy\linalg\_fblas-f2pywrappers.f' to sources.
  building extension "scipy.linalg._flapack" sources
  from_template:> build\src.win-amd64-3.6\scipy\linalg\flapack.pyf
  Including file scipy\linalg\flapack_user.pyf.src
  Mismatch in number of replacements (base <prefix=s,d,c,z>) for <__l1=c,z>. Ignoring.
  Mismatch in number of replacements (base <prefix=s,d,c,z>) for <__l1=c,z>. Ignoring.
  Mismatch in number of replacements (base <prefix2=s,d>) for <__l1=S/D>. Ignoring.
  Mismatch in number of replacements (base <prefix2c=c,z>) for <__l1=C/Z>. Ignoring.
  Mismatch in number of replacements (base <prefix2=s,d>) for <__l1=S/D>. Ignoring.
  Mismatch in number of replacements (base <prefix2c=c,z>) for <__l1=C/Z>. Ignoring.
  Mismatch in number of replacements (base <prefix2=s,d>) for <__l1=S/D>. Ignoring.
  Mismatch in number of replacements (base <prefix2=s,d>) for <__l1=S/D>. Ignoring.
  Mismatch in number of replacements (base <prefix2c=c,z>) for <__l1=C/Z>. Ignoring.
  Mismatch in number of replacements (base <prefix2c=c,z>) for <__l1=C/Z>. Ignoring.

Thanks @ilayn, that noise has always annoyed me so glad it's gone!


[BUG] Automatically Reconnect after 'Error: Socket closed'

Describe the bug
After some time, the connection to Qlik is closed.
It is no longer possible to access the Qlik files until the connection is re-established.
Running VSQlik: Connect to Qlik Server doesn't reconnect, because 'The workspace already exists'.
The only way to recover the connection is to quit and relaunch VS Code, then run VSQlik: Connect to Qlik Server.
Looking at the developer console, the error is  ERR Unable to read file 'qix://localhost.qlikaddress.example/Test/script/main.qvs' (Error: Socket closed).
To Reproduce

Connect to Qlik
Load file from Qlik
Wait for some time
Close the file and open it again. If the connection is closed, there will be an error.

Expected behavior
VS Code Qlik would automatically re-connect if the connection is closed.
Desktop (please complete the following information):

OS: Windows 10 build 1909
VS Code Version: 1.46.1
vscode-qlik version: 0.4.0

Additional context
Add any other context about the problem here.
 If this token is invalid because of a very long not use, it should reauthenticate.
extend the settings panel and add a connection ping setting with an standard time of 5000msec. Add an interval that just call global.getengineversion to transport at least any 5 sec. anything through the websocket connection, so that the network boxes (NAT, Firewallls & Co) don't kill that session.

@konne @r-hannuschka This was working for awhile, but seems to have stopped working since I updated to 1.7. (I was previously on 1.5.)

I will take a look onto this one, i got the same after some time (30 minutes maybe longer) my session is gone.


Include fastai in frameworks using Accelerate

Adds fastai to the frameworks using accelerate section of the README

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


DSA 2.1 Strings: Subsequence - Documentation

Description
What are subsequences and how do you implement them in strings? Give examples. Also, write a program to show how to generate all possible subsequences.
Important: Do not use assign command for this issue.
Task

[ ] Documentation

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to Issue Guidelines.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be same as the issue.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

Mageshkrishna R
DSA batch 6
Willing to take up this issue, assign it to me.

Mageshkrishna R DSA batch 6
Willing to take up this issue, assign it to me.

Assigning this issue to you @silicolicious, all the best!

@silicolicious any update?

@nimisha-yadav Please check my PR #6268


Add & use python binding for lpnamer and benders[mpi,sequential]

Summary
Several executables are called iteratively. They mainly communicate through files. This approach has two drawbacks :

Need for many disk read/writes, which are possibly slow
Rounding errors when reading/writing floats

This could be solved by turning these executables into python modules (libraries). Many frameworks exist to allow this kind of binding. One of them is pybind11.
The idea would be to expose a minimal number of classes and functions to python : whatever is needed to communicate between these executables.
The python script would look like this
import lpnamer
import benders

my_constraints = lpnamer.constraints(...)
my_lp = lpnamer.lp_namer(config_path, lpnamer.relaxed, constraints)

while gap > threshold:
    benders.run(...)

In the following, we make a list of I/O of lpnamer, benders, etc. that could fall into the scope of this work.
lpnamer
Input
usage:

xpansion study output => keep path
optimization strategy : relaxed/integer => py enum
additional constraints / exclusion files => Turn into py object

Output
Variable correspondence written into "lp" files.
std::map<std::string, std::map<std::string, int> > output;
// ...
output["master"][name] = i;
// ...
for (auto const & mps : output) {
	for (auto const & pmax : mps.second) {
		coupling_file << std::setw(50) << mps.first;
		coupling_file << std::setw(50) << pmax.first;
		coupling_file << std::setw(10) << pmax.second;
		coupling_file << std::endl;
	}
}

benders[mpi,sequential]
Input
Config file loaded into BendersOptions object
Output
JSON files containing the optimization results, among other things.
Merge/analyse MPS ?

Another solution could be to turn benders and lp_namer into libraries whose functions would be called in the same executable. Comments are welcome.

I'm closing this issue because we don't see how to implement a Python binding for an MPI program.


Use local authentication system for login

I see that Qiita manages its own users. Would it be possible to fit it into an existing ldap or active directory system?
I looked how the Galaxy project is doing this. They first used nginx or apache to get a authenticated username [1], but now they moved to using the python-ldap (https://www.python-ldap.org/) library to authenticate users [2,3].
I am not familiar with the qiita codebase, but would it be possible to have also ldap authentication besides the currently used oauth method [4]? Or is there another way to have a user authenticate with already elsewhere registered credentials?
[1] https://wiki.galaxyproject.org/Admin/Config/ApacheExternalUserAuth
[2] https://wiki.galaxyproject.org/Admin/Config/ExternalUserAuth
[3] https://github.com/galaxyproject/galaxy/blob/master/lib/galaxy/auth/providers/ldap_ad.py
[4] https://github.com/biocore/qiita/blob/master/qiita_db/handlers/oauth2.py

hi @mdehollander !
Currently Qiita doesn't support a local authentication system for login. Although it may be possible to add this functionality, some thinking is required to make sure that all cases are covered, and some functionality need to be deactivated if configured that way (i.e. reset passwords, etc).
The actual login of the user doesn't use oauth2. I don't think we can have both authentication systems side by side, but rather having one or the other.
In any case, I don't foresee this happening before the end of the year. If you're interested on contributing to the project and speed up the implementation of this functionality, we can provide some direction on the relevant code.
Thanks!

Thanks for the information. I won't be able to contribute before the end of the year either, but its good to know the current status. I will look more into the general system first and if we are going to use it with more users I am willing to help out where I can to get this supported.

Awesome! Thanks @mdehollander

+1 for reusing logins!

With the perspective that only time can give you, I don't think we would add this functionality to main Qiita (UCSD deployment); however, if there is interest in adding this functionality please open a PR.
Now, another option is to do this via Globus Auth authentication; the only issue with this approach is that it is tricky to share the current authentication and Globus in the same system + there isn't a handbook of how to "easily" transition users and/or deal with users that doesn't have Globus credentials.
Anyway, closing.


Is the training based on LoRA or just tune the original model parameters!

Excellent work! I was ispired by it and want to try it with some other work. I understand the you for not release the training code, but I will appreciate if you could tell more about the details.

The fine-tuning is with the help of LoRA or just the original parameters? will use LoRA get a relatively bad results?
How could I train the controlnet if I have some other conditions? Is it a off-the-shelf one or trained one? Can I use a T2I-Adapter instead? Is the training process before or after the training of denoising UNet?
How far could the noise schedule effect? Is it possible that I use \epsilon-prediction and original noise-schedule but still get a satisfying results?

Thank you!

And another thing that confuses me is that "scaled by a factor of 5" in the paper, is that implemented in the code? I could not find that.

Original parameters; LoRA would barely work if the rank is as low as 4, but can work to some extent if the rank is more than 64.
ControlNet generally assume local spatial correlations between input condition and output image, so you will need multi-view control images; for off-the-shelf ones you may want to try https://github.com/haofanwang/ControlNet-for-Diffusers; I am not familiar with T2I-Adapter so I cannot tell now. The training process is after the training of UNet, the same as regular ControlNets.
It is not possible; in general you will need other tricks such as Gaussian blob initialization (I am referring to the Instant3D paper by Adobe) to provide more global clues if you do not change the schedule. I think changing the schedule is the principly-correct way to go though. Epsilon models can be used to enhance local details, which is one of the future works I mentioned in Zero123++ report and I am currently working on.

By default the SD VAE output needs to be rescaled by about 0.18 (vae.config.scaling_factor) before sending into diffusion; we skipped that step for the condition branch (so it is roughly scaled by a factor of 5), and we have an extra function called scale_latents that normalizes the residual by shifting and rescaling the latents according to statistics we compute with Objaverse renders and LAION-ART.


Investigate supporting Windows Containers

Should be possible as long as we don't hard-code dependency on bash.
https://learn.microsoft.com/en-us/virtualization/windowscontainers/about/

This is working now, example in the windows_example branch

Is there any chance this could be added to main?

Sorry, we lost our funding for this since the one customer who needed it gave up on Bazel when they learned the IntelliJ plugin doesn't support Windows https://github.com/bazelbuild/intellij/issues/5040

Ah, that's a shame. Was the windows branch working? What would be required to resurrect it? It's not a high priority for us, as we are mainly linux, but would be good to know.


Makefiles for linters

Setup makefile for some linters - icarus, svlint &
Yosys readverilog 'linter'
Only few testcases were being linted: Resolved issue with exiting of process on encountering an error (includes verilator) so all testcases are read and stderr's outputed to txt files.
Added 3x tools to 'main' Makefile: All 4x tools run and write errors to 'out' directory when make is run.

Syntaxes changed to GNU make standard. Recipes prefixed with -.


fix(message-signing): add working message verification utility fn

In changing the signature format, the current docs & blog post has broken code examples.
See https://github.com/hirosystems/stacks-wallet-web/issues/2435
I copied parseRecoverableSignature from @stacks/transactions. What's best solution to reuse the fn? Atm encryption doesn't rely on tx package. Should we move to common?
Open to other solutions. Would be good to come up with a quick fix though, so users don't hit a wall when trying to use msg signing.

Codecov Report

Merging #1260 (e24f8c5) into master (8ad4d83) will decrease coverage by 0.07%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   64.57%   64.50%   -0.08%
==========================================
  Files         124      124
  Lines        8642     8655      +13
  Branches     1854     1859       +5
==========================================
+ Hits         5581     5583       +2
- Misses       2818     2828      +10
- Partials      243      244       +1

Impacted Files
Coverage Δ

packages/encryption/src/ec.ts
70.11% <21.42%> (-4.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad4d83...e24f8c5. Read the comment docs.


Installation via npm

Hi,
can I install the plugin via npm? We try to move from Bower to npm and it seems that MassAutocomplete is not registered in npm registry.
Publishing a package should be quite straightforward: https://gist.github.com/coolaj86/1318304
What do you think about this suggestion?
Have a nice day,
Martin

http://gofore.com/ohjelmistokehitys/stop-using-bower/

Sounds like a good idea !

:+1: It should only take a minute, if I understand the process correcly :-)

You can now install massautocomplete from npm using
npm install angular-mass-autocomplete

Thanks @MartyIX for making me do this.

Thanks!


Update pages.txt

https://gtmetrix.com/reports/arc-x.org/Ia2ESFlx/

Already added, thanks for your submission!


New version: ImageMagick.ImageMagick.Q16 version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #7596.

Log
Updated: <IP_ADDRESS> → <IP_ADDRESS>
Submitting WinGet manifests
Creating manifests
WinGet exits with exitcode -1978335231
Uploading manifests and making commits
The manifests for the last version <IP_ADDRESS> will be removed. Reason: This task is configured to remove the last version
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Program Files\ImageMagick-7.1.1-Q16\magick.exe returned exit code: 1

(Automated response - build 888.)


Add terrajet-to-upjet migration guide

Description of your changes

This guide aims to help the community to migrate their Terrajet-based Crossplane providers to Upjet as Terrajet is being deprecated.
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested following the guide on github.com/crossplane-contrib/provider-aws.

Hi @muvaf,

I think we should also tell them to check some files in upjet-provider-template and sync with their repository.

Added new steps to be followed after the module migration from terrajet to upjet is done so that new upjet features can be used.

I almost wonder if we should just suggest starting from upjet-provider-template by cloning it and move their config package into that and regenerate

I think this is a good idea. It would make a full migration to utilize all upjet features and to publish the provider package in the Upbound marketplace (like what's been done for the https://github.com/crossplane-contrib/provider-pagerduty repo) easier.
And I think there's utility in a Go module migration guide that tells the steps needed to replace the github.com/crossplane/terrajet module with the github.com/upbound/upjet because there may be terrajet-based repos (maybe private ones) with heavily customized CI pipelines, or some new features that we enable by default in Upjet template repo like shared gRPC server, metadata extraction, doc/example generation may not be wanted/required and even not working for those providers.
What I would suggest would be to have a module migration guide that allows more flexibility and control on the migration process with some optional steps and may be in this guide point to another guide with proper explanation, which would instruct the user to bootstrap (initial cloning) from the upjet-provider-template repo.
What do you think?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove redundant sentence

Remove redundant sentence

"like to hang out outside of work, as much as working with one another"

Thanks, @Stephan202 and @WillemGerritzen


nix: put each version in a separate file

Description of changes
Some of us need to keep around specific versions of nix.
The recent churn of which Nix versions are or are not in nixpkgs is causing a lot of merge conflicts for us.
Let's put each version in a separate file, so these churn commits aren't constantly conflicting with nearby lines of code.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux

[x] Fits CONTRIBUTING.md.

Please do not squash the commits; there is important history in there.

@grahamc the darwin builders are wedged again

@ofborg eval

This PR shouldn't revert commits which are not really related to it.

It doesn't.  OfBorg shows zero rebuilds.

It doesn't. OfBorg shows zero rebuilds

I was looking at the commit history which shows some reverts and back and forth https://github.com/NixOS/nixpkgs/pull/211172/commits

This PR shouldn't revert commits which are not really related to it.

It doesn't. OfBorg shows zero rebuilds

I was looking at the commit history which shows some reverts and back and forth https://github.com/NixOS/nixpkgs/pull/211172/commits

And none of them are left unreverted.

Resolved (non-hypothetical) merge conflict (this is the churn I'm talking about).

Needs rebase

Done.
Note: rebasing this PR is extremely labor-intensive.

Some of us need to keep around specific versions of nix.
The recent churn of which Nix versions are or are not in nixpkgs is causing a lot of merge conflicts for us.
Let's put each version in a separate file, so these churn commits aren't constantly conflicting with nearby lines of code.

I am doing that myself here https://github.com/supersandro2000/nixpkgs/tree/nixos-22.11 with 120 commits on top of stable and rebasing it usually twice or more a week and do not have such problems.
I am using the following commands to rebase:
git co nixos-22-11
git rebase origin/nixos-22.11 nixos-22.11
git rebase upstream/nixos-22.11 nixos-22.11
git push --force-with-lease

So from my perspective this change is not necessary.

Also if we are going to merge this, can we just squash the history together? Having those 2 revert commits makes the history a bit messy.

I am doing that myself here https://github.com/supersandro2000/nixpkgs/tree/nixos-22.11 with 120 commits on top of stable and rebasing it usually twice or more a week and do not have such problems.

Because you're rebasing against the slow-moving 22.11 instead of master.   You haven't had any problems because you're rebasing against an incredibly slowly-moving branch.  You also haven't yet tried to rebase upon 172347745ffb457e47cf5386f2ae3ff6678c2b02 which is the one that causes all the pain:
$ git merge-base origin/master 756797b47fe316b6795103fc2065e60ef700ecbf
550e897a481b769bda516e4543166796fb455b7d

I "live at head" and run origin/master so I can eat our own dogfood.
I know that not everybody can do this, but if nobody did it we wouldn't find out about most bugs until ZHF.  I also build everything myself (--trusted-public-keys "") which is the same situation: painful for me, but I catch things (like broken FODs) that nobody else does.

Also if we are going to merge this, can we just squash the history together? Having those 2 revert commits makes the history a bit messy.

I've squashed it into only three commits:

Revert the deletion
Move into separate files
Re-do the deletion

The reason for this is so that people who want the old versions back can git revert the last commit (and carry that revert forward in their local tree).  So it is really valuable to have that change isolated as a single commit -- it makes it straightforward for people to re-enable the no-longer-supported versions.
I suppose the first two commits could be fused together.  I think it conveys useful information about what happened here.  I've rewritten the commit message so it doesn't "look like" an obvious revert (see fc8b055249fbd315f09dad6085a64caedfbf9aa0) since I mean no offense toward the people who wrote the commit that I am reverting.
If you still feel strongly about reducing the number of commits I can squash the first two commits together.  Squashing all three would make it obnoxiously difficult for people to bring back the deleted versions; I don't think that's a good idea.

Also if we are going to merge this, can we just squash the history together? Having those 2 revert commits makes the history a bit messy.

I've squashed it into only three commits:

Revert the deletion
Move into separate files
Re-do the deletion

The reason for this is so that people who want the old versions back can git revert the last commit (and carry that revert forward in their local tree).  So it is really valuable to have that change isolated as a single commit -- it makes it straightforward for people to re-enable the no-longer-supported versions.
I suppose the first two commits could be fused together.  I think it conveys useful information about what happened here.  I've rewritten the commit message so it doesn't "look like" an obvious revert (see fc8b055249fbd315f09dad6085a64caedfbf9aa0) since I mean no offense toward the people who wrote the commit that I am reverting.
If you still feel strongly about reducing the number of commits I can squash the first two commits together.  Squashing all three would make it obnoxiously difficult for people to bring back the deleted versions; I don't think that's a good idea.

Because you're rebasing against the slow-moving 22.11 instead of master. You haven't had any problems because you're rebasing against an incredibly slowly-moving branch. You also haven't yet tried to rebase upon 1723477 which is the one that causes all the pain:

I am doing the same with nixos-unstable and also run into very little problems.

I "live at head" and run origin/master so I can eat our own dogfood.

Feel free to do that but I would highly recommended against directly tracking master and instead suggest to anyone to use nixos-unstable.

The reason for this is so that people who want the old versions back can git revert the last commit (and carry that revert forward in their local tree). So it is really valuable to have that change isolated as a single commit -- it makes it straightforward for people to re-enable the no-longer-supported versions.

This will probably only ever be useful for a handful of people while way more people need to live with the messy history and wrap their head around the back and forth in the history.
A PR that first introduces code that is later deleted in the same PR has a messy history. We should avoid that if it is easily possible which it is here. You can do whatever change you like on your fork but we should keep the history try to keep the history clean especially if it is easily done.

way more people need to live with the messy history and wrap their head around the back and forth in the history.

I laughed at this.
The nixpkgs history is a complete rat's nest already.  Squashing two commits together isn't going to fix that.  I don't think anybody sits down and reads the whole thing from start to finish.

I would also like to point out that when we carry multiple versions of a package it is nixpkgs convention to put each one in a separate file.

Rebased.

Rebased.

There is no CI checking that these packages actually work in even those 2 commits.

There is no CI checking a lot of things, unfortunately.


Proposal: MatTextField accepts in bind-value only string

Currently MatTextField accepts only a string. But it quite often happens, that a developer would like to bind another value type, like int or double. Currently this is not possible. This could be validated in connection with Type attribute, so when

Type="text" => string or cast to string

Type="number" => accept any number type

Type="date" => accept date type

etc.
This probably would mean a change in BaseMatTextField of property Value to accept object and then run appropriate validation based on Type property?

@anddrzejb  I ran into this issue as well. I didn't spend too much time on it but maybe you can come up with a solution.

<MatTextField  @Bind-Value="@IntegerNumber" />   not work


Support both qt5 (Kinetic) and qt4 (Jade)

I've tested this on Ubuntu 14.04 Jade and 16.04 Kinetic.

Awesome! Thanks very much.


Add TeX Gyre Pagella Math font

Add TeX Gyre Pagella Math font.

I have applied your comments. Sorry for the confusion, I followed the font-tex-gyre-* fonts naming convention without checking further.

We’ll need to fix those as well. You did well looking for a convention, it’s just that in this case the present casks are wrong.
Could you please squash your commits?

Done!

I'm confused about the naming convention change here. The token reference page you link specifically says:

Spaces become hyphens.

What am I missing?

@alerque What’s the confusion, then? There are no spaces in the file name.

@vitorgalvao I guess where I differ is I don't think you're starting with the right piece of data. This isn't an app bundle and the upstream filename does not translate to a user-facing name in the way that "name on disk" does for an app bundle. The user facing name is the font name as it identifies itself. Run fc-list | grep Gyre and look at the names it reports. That's the name the project has given to the font and the most logical name to parse to come up with a token. Without the spaces (or hyphens) these fonts become an unintelligible mass of letters as opposed to having semantic meaning of the source, modification,  and specific family names.
Using the distribution file name does not make sense for fonts. If you go down this road all sorts of fonts are going to have to be changed from sensible names to obscure rubbish. Almost all fonts are distributed in files without spaces to accommodate systems where they don't work right, and often comply with 8 character restrictions, etc.

@alerque I had no knowledge of fc-list (and I see other related) command.
I agree with your arguments, but here’s the one thing to keep in mind: we need clear unambiguous rules about how to name casks, as avoiding duplicates is a priority. That, however, does not mean we cannot have different rules for fonts in relation to app bundles, but said rules do need to be documented.
With that in mind, I invite you (if you’re interested) to draft up clear easy to apply rules for fonts that we can discuss. “Easy to apply” is a must, here, and it’d be great if that also meant “easy to verify”, for maintainers, but start with what you think is right and we can continue the discussion from that.


Code of Conduct

@sjDCC , @stephaniesimms :
GitHub suggests adding a Code of Conduct to our project. I'm pretty sure the GitHub project ranking algorithm is affected by this so I think it's best we adopt one for optimum project visibility/discoverability. The template they suggest using is the following:
https://github.com/DMPRoadmap/roadmap/community/code-of-conduct/new?template=contributor-covenant

Yeah, I'm happy to include a code of conduct. Good to get that in place before the MVP release as that's when we'll be encouraging others to contribute. Maybe add to Tuesday call for other comments?
The contact email in here reminds me that we should setup a DMPRoadmap email that feeds through to our two helpdesks. When I was editing the pootle page on wiki the other day I just added<EMAIL_ADDRESS>but I think it would be good to have a generic one that covers both teams

fine by me too. just to clarify @sjDCC - are you referring to the larger roadmap MVP release? if you want it in time for your v0.3 release i just want to note that we have a holiday next Tues and would need to work on it via other comms.

I think the main release in August is fine schedule wise as that's when we'll be opening it up to the world and encouraging other devs to migrate and join with us. The only ones who are likely to migrate sooner are Weiwei and Benjamin as test cases and we're already liaising with them so less need for a code of conduct

still need to update Contact email and verify that this is ready to go

I think the ROADMAP-L@listserv can only be posted to by members (seem to recall we had a helpdesk issue about this as we'd forgotten to switch out details). Happy for<EMAIL_ADDRESS>to be used, or we could have a mail address that alerts both helpdesks if desired?

yes, you're right about posting to ROADMAP-L listserv @sjDCC
it would be great to alert both helpdesks to jive with our current workflows. i guess we can just include both email addresses in the Code? if that's messy we can just use<EMAIL_ADDRESS>

Or setup a mailbox like<EMAIL_ADDRESS>that directs to both?

i'd say go ahead with<EMAIL_ADDRESS>rather than complicate things
we can always confer about code of conduct stuff as needed

Have just added<EMAIL_ADDRESS>for now as I couldn't find an email for your helpdesk (just webform). By all means add it through and resend PR

one email address should be sufficient and we can consult on any queries that come through together. PR looks good to me. closing issue.


Your code is building fine on MSYS2 MINGW64

Only want to let you know.

Well, thank you, but there is no need to create an issue for this. In general, this code should work with any compiler. The test suite runs on Mac OS, Linux and Windows, with different compilers every time, so this not working on Mingw64 would be a bug in my opinion, and if that were the case you're welcome to create an issue.


Add Bugzilla functionality to multi-message module

Signed-off-by: Ido Burstein<EMAIL_ADDRESS>

For multi-channel message, maybe the bugzilla create new bug function is too much, let's only add the bug comment function in it. If user want to create a new bug, better use the bugzilla endpoint api.


Per-app volume control

Is your feature request related to a problem? Please describe
I got many android application open, and currently windows only showing "Windows Subsytem for Android" in volume mixer.
Describe the solution you'd like
Show all android application that outputing media sound to windows volume mixer.
Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2210.40000.7.0

Hi, thank you for this feature request. Currently this isn't on our immediate roadmap, but we're always listening to the community!


request for robots.txt crashes server

This weekend the press.curationexperts.com server got a a request from a webcrawler for press.curationexperts.com/robots.txt. Instead of returning the contents of public/robots.txt, the server interpreted the request as seekeing a subdomain (press) callled "robots" and crashed. I think this will go away when #107 is done, and the press home pages look like umich,press.curationexperts.com instead of press.curationexperts.com/umich.
Gist of the production log is here: https://gist.github.com/acozine/b22f24ff5caccb36e8ab9f30976c5c93.

Problem fixed by an extension of the ProxyPass directives in /etc/apache2/sites-available/heliotrope.conf. Once I added specific directives for the files in public/, the errors went away. Full VirtualHost definition for use with Puma is:
<VirtualHost *:80>
  ServerName <IP_ADDRESS>
  # !!! Be sure to point DocumentRoot to 'public'!
  DocumentRoot /opt/heliotrope/current/public

  ProxyPass /assets !
  ProxyPass /favicon.ico !
  ProxyPass /robots.txt !
  ProxyPass /system !
  ProxyPassMatch ^/(404|422|500).html$ !

  ProxyPass / http://<IP_ADDRESS>:3030/
  ProxyPassReverse / http://<IP_ADDRESS>:3030/

  # allows forward slashes for IIIF
  AllowEncodedSlashes NoDecode
  <Directory /opt/heliotrope/current/public>
        # MultiViews must be turned off.
        Options -MultiViews
        # Uncomment this if you're on Apache >= 2.4:
        Require all granted
  </Directory>
</VirtualHost>

where Puma is running on port 3030.


Speakers

Requirements:

A patched eleven secret herbs and spices kernel (or a certain kernel cmdline parameter)

Unfortunately I was unable to make this branch work on my machine (should be j316, 2021 M1 Max MBP 16"), nor cherry-pick the audio commits to make this work.
Please rebase and test on the latest release to ensure we are both on the same page. I will do the same, then we can discuss privately if that doesn't work.
I genuinely appreciate your work and pioneering on these matters and will try more myself, but you might have a faster solution.

Thanks for the contribution. I've taken and cleaned this up and merged this stuff in the latest release.


New function request

Hi.
I am using AGE Viewer well and thank you.
The "Connection Status" scrolls too fast.
Please Change at a speed similar to scrolling "Query Results".
Thank you.

I agree with you.
Let's adjust the wheel sensitivity.


How to implement user with "admin" role, which is able to edit another users?

Hi, I've got this in my user.server.routes.js
app.route('/users/:userId')
	.get(users.read)
	.put(users.hasAuthorization(['admin']), users.update)
	.delete(users.hasAuthorization(['admin']), users.delete);
app.param('userId', users.userByID);

Problem is with app.param, because method userByID is returning logged in user, so when I click on delete, it will delete my account...If I change app.param to find user from DB by userId, I'm getting authorization problems (403 forbidden) :( Could someone help me to solve this problem?
Thank you very much!

If I neglect safety ...
app.param('userId', users.userByID);
app.route('/users/:idUser')
	.get(users.read)
	.put(users.updateById)
	.delete(users.delete);
app.param('idUser', users.userById);

Now I can delete users, but if I edit some user, I am logged in as the edited user :(

You need a middleware that uses req.profile and not req.user. This is the line that causes issues for you in this case.

Yeah, I got it few minutes ago too :D Thanks! :)

Hi, one query
How you add more than one user role ?
Thanks!

Having > 1 role for an user can be achieved through direct MongoDB database manipulation, e.g. in the mongo shell.

The solution is this: In users.server.controller.js
You should comment the line " delete req.body.roles; " , and in Angular create an array with roles you need. when you pass to server.
exports.signup = function(req, res) {
	// For security measurement we remove the roles from the req.body object
	/*delete req.body.roles;*/

	// Init Variables
	var user = new User(req.body);
	var message = null;

	// Add missing user fields
	user.provider = 'local';
	user.displayName = user.firstName + ' ' + user.lastName;

	// Then save the user
	user.save(function(err) {
		if (err) {
			return res.status(400).send({
				message: errorHandler.getErrorMessage(err)
			});
		} else {
			// Remove sensitive data before login
			user.password = undefined;
			user.salt = undefined;

			req.login(user, function(err) {
				if (err) {
					res.status(400).send(err);
				} else {
					res.json(user);
				}
			});
		}
	});
};

@marianoqueirel remember that then you'll also need a middleware to validate roles. Otherwise you might as well just leave all admin pages open...

Ofcourse, in the route you can do this:
app.route('/home/onlyAdmin')
  .get(users.requiresLogin, customers.read)
  .put(users.requiresLogin, customers.update)
  .delete(users.requiresLogin, users.hasAuthorization(['admin']), customers.delete);

Or if you want, you could do this from the Angular.

We are adding an admin module in the very near future for the specific purpose of adding additional roles to users:
https://github.com/meanjs/mean/pull/676
Can prolly close this issue

yep, thanks @trainerbill

Hello! Can someone please help me with a  step by step tutorial about setting up an admin user on my meanjs app? Thank you!

@bruna94 You can use the seed feature
MONGO_SEED=true grunt
The users and passwords will appear in the console

im sorry i executed this in GitBash but the console of the page does not show anything... am i doing something wrong?

What version of MEAN are you running?  The seed feature was added within
the last 2 months.
On Thu, Sep 24, 2015 at 12:15 PM, bruna94<EMAIL_ADDRESS>wrote:

im sorry i executed this in GitBash but the console of the page does not
show anything... am i doing something wrong?
—
Reply to this email directly or view it on GitHub
https://github.com/meanjs/mean/issues/515#issuecomment-142992787.

@bruna94 Take this to the gitter chat so we don't revive this issue.

@marianoqueirel
By commenting this line really help me sign up a user with some roles.
//delete req.body.roles;

The issue I think I am running into is when editing other users profiles the password gets changed due to the 'pre' hook on user save whenever you try and save the changed profile:
UserSchema.pre('save', function(next) {
if (this.password && this.password.length > 6) {
this.salt = new Buffer(crypto.randomBytes(16).toString('base64'), 'base64');
this.password = this.hashPassword(this.password);
}
next();

});

@ckapop What version of MEANJS are you seeing this behavior?
The password field should never be present in either the request, or response. If the password is updated, in a request other than the create profile, then this would indeed be a bug. However, I think we took care of any issues with this already.

@mleanos How can I check to be sure? It is probably not as current as it should be.
I have this method that was generated for me which looks like the new password is in the request, correct?
/**

Change Password
*/
exports.changePassword = function(req, res) {
// Init Variables
var passwordDetails = req.body;
if (req.user) {
if (passwordDetails.newPassword) {
User.findById(req.user.id, function(err, user) {
...


Voice files in Safetensors format?

I'd love to use Piper for my program but there are no safetensor models for the voice models, so I can't guarantee people will be safe to use it. Can you guys convert the models to safetensors? Or will the program at least read them if I convert myself?

Which part(s) of piper do you think is/are unsafe?
Looking at the README for safetensor they highlight that they provide safety by avoiding pickle, yet pickle isn't used in this repo, it uses onnx. The onnx/protobuf entry in the table in the safetensor repo marks it as safe so I'm not convinced of the validity of your concern, but do say if there's a particular aspect I'm overlooking.

Yeah, this doesn't make sense to me either. Piper voices are onnx, which does not use pickle.


U5: Add OCTOSPI peripheral

Originally part of #974.
Not many actual changes, but I extracted the common parts of peripherals/octospi/l4.yaml to peripherals/octospi/common.yaml so it shows quite a bit of noise.

Since you move most of code I propose to use slightly different way to include:
https://github.com/stm32-rs/stm32-rs/commit/f4c36240e320ae2dd2234a9a82227d7f8d4171e8


Impl line_style for Canvas

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.78%. Comparing base (5633813) to head (6bfd5a0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   99.78%   99.78%
=======================================
  Files          17       17
  Lines        4700     4714   +14
=======================================
+ Hits         4690     4704   +14
  Misses         10       10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cant configure webpack to bundle css from node_module/dist

how to load css files from a lib installed with npm and exist in node_module/dist.
I would expected that when using a component from that lib (witch was installed) it would load the css files that were imported and used inside that component.
can i do it with craco.config.js?

A plugin for webpack like css-loader will probably work well here. However, it requires webpack 5, which we don't fully support yet. I'm working on it though!


Add circle CI for building PyTorch 1.1/1.2/1.3

Adding one more CI to have built with all major PyTorch releases. Adding this to existing Travis will make each build too long since Travis and CircleCI will run in parallel...
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[x] Did you read the contributor guideline?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Fixes #462. Reaction to #491.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

well, it seems that the CricleCI is so slow... :-(

also tests/test_gpu_models.py::test_cpu_slurm_save_load Too long with no output (exceeded 10m0s) so it should be revisited...


frontend:ui:impl should not depend on frontend:actions

This introduced heaaavy coupling... to be reverted (introduced on PR #1301).

Turned out there's no actual dependency... I just just needed to remove the entry from build.gradle


Request Mobile Site preference

That was pretty easy. This creates the ability to set the useragent (UA) to load mobile sites. It does so by updating the webview’s useragent. For a good example navigate to Twitter, The New York Times, Google or Github.
A few things to note:
Preferences
Updated the preferences with a new one called request_mobile_site, which defaults to false. There is also a menu item toggle under Tools called Request Mobile Site. The shortcut is CmdOrCtrl+Alt+U, as M was taken. U for useragent? Not the clearest… Toggling this option updates the UA and reloads the site to reflect the change.
UA Storage
We must store the mobile/desktop useragents. I couldn’t quickly find a way of requesting the default Electron UA. The webview must be mounted to the DOM before you can request it’s current UA. To get around this, I define the UA through setAttribute, as suggested here to avoid first load without the correct UA defined, effectively overwriting any requests for the current UA as a way of storing the default/desktop.
Default (desktop) is what my current machine reads:
 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Oryoki/0.2.1 Chrome/58.0.3029.110 Electron/1.7.9 Safari/537.36'

Mobile is an iPhone running iOS 11 in Safari:
'Mozilla/5.0 (iPhone; CPU iPhone OS 11_0 like Mac OS X) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Mobile/15A356 Safari/604.1'

This is probably fine for OSX releases, but we’ll want to find a better way of doing this if building for another OS.

Hey this is great! Thanks a bunch. Sorry it took so long for me to check it out. I've tested it on your branch and it seems to work, but for some reason I'm having issues like these:
– Preference can carry to new windows
– Preference doesn't work on first window
– Doesn't switch back to desktop site from website.com/mobile
– Navigating to a different website still loads desktop
So, generally, it does what you'd think after a couple tries, but the behavior isn't consistent. Not sure how to approach this—did you run into any of these issues before?

Here's an alternative scenario:
– Use Request Mobile Site as an action rather than a toggle
– Reset the UA often or only set it for one window and one website
That way you can just smash the shortcut to get a mobile redirect on a site you just loaded—maybe more forgiving?

Hey! Thanks for giving it a look. I could see this being an array of sites in your user preferences json. Triggering the action adds or removes the site from that array. Having used this over the past two weeks I really do find it useful; having it reset or only applied per-window would be an annoyance.

I’m also seeing the bug where the preference does not get applied to the first window.
Toggling off works depending upon the site. For instance, the nytimes redirects you to mobile.nytimes.com, as you point out. Unsure how we could elegantly resolve that.
Can you clarify “Navigating to a different website still loads desktop”? This is true for me if continuing to navigate in the original window, however opening a new window resolves this. Likely related to the first bug on this list.

To summarize, the primary bug of requiring a new window to take effect can likely be resolved within toggleRequestMobile() under /lib/components/view.js. The functionality to toggle per-site and store in user preferences sounds useful!

Gotcha—my issue with “Navigating to a different website still loads desktop” was related to the original window bug, I think. Just got weirded out by the behavior of the thing.

Agree that the main issue is the UA spoofing not working on the app's first window.
Replacing load(webview.getURL()) with reload() fixes this for me (don't ask me why). With that fix, we could make "Request Mobile Website" a global toggle (for all windows), and we'd be set, no?

On toggling off: looked into it a bit and it seems browsers like Chrome or Safari do more than switching UA + Refresh, though. They seem to remember what was your original request and can revert to that when disabling the browsing mode, except if you explicitly typed mobile.website.com. Not sure we need all that, though.

Glad to hear reload() fixes it! Was hoping it’d be a simple (although mysterious) one.
Oh interesting. I think that would be a good feature to add progressively.

I think that this is a nice first implimentation. Perhaps if there is a roadmap for additional functionality we could append that second note!

About those commits earlier: I couldn't find a way to enforce the UA on a window basis (once it's set on one webview, all other ones follow), so I made the changes to make it an app-wide parameter.
You can test it the following way:
– Open the app (with preference set to false)
– Navigate to a wikipedia page or such
– Open a new window, navigate to twitter or such
– Toggle Request Mobile Site on
– All windows will reload with the mobile version of the pages
– New windows will also load mobile versions
Disabling Request Mobile Site roughly works as expected (disables UA on future requests but doesn't reload open pages to desktop sites).
The key in oryoki-preferences.json allow to start the app with the toggle on.
Will let you have a look at it, and if that looks okay I'll merge into /dev.

This looks great! Clicked around a bit and was able to replicate everything you mentioned above. Seems good to me!


Added feature to start in tray

I've added a feature toggle to the Settings menu to "Start In Tray". If set, the window will automatically hide after loading everything. This is my first time working with Electron so it may not be perfect.

I just committed those two changes @ajivoin

Did some testing in Windows and your preference setting is working properly, good job! 😄
The behavior when opening and hiding seems odd though. I'm able to see the window flash then hide, rather than the application starting in tray. I'd like to see if we can prevent this from happening. Here's a link to an issue in the Electron repository about this behavior.
In the Electron issue, as well as issue #4, the npm package auto-launch was mentioned. auto-launch provides the functionality of starting the app hidden on Windows, macOS, and Linux. I'll have to test it to see if it starts the application hidden to tray how I expected it to.
I was planning on picking up work to implement this package this week, and the work you've done so far will definitely help out!

@ajivoin I've managed to get it working without the auto-launch package. You can set show: false in the window creation so I just pulled that from the settings.
I also added the Linux tray click event, single-clicking the tray icon will open the window. I thought about toggling between shown/hidden which wouldn't be hard to do at all if that is preferred, let me know your thoughts but I followed along with the other platforms for now, could be something to try in another branch.
I did notice Windows is explicitly calling a double-click. The Linux one I used is for a single-click event, is mac single or double? Are we set on double for all platforms or is that a Windows-only thing?

@ajivoin I've done a little more checking and here are my findings:
Single-click in Linux seems to be the standard. I've checked multiple other popular applications that minimize to tray and this is the behavior they all had.
I have the tray click working in my WM which is i3. I've tested in XFCE and it works there as well.
There are a couple "issues" with other desktop environments that I will note:
Gnome does not have a system tray anymore (not sure when they did that but I checked and it doesn't show the tray. In this case if you select the option it will be running in the background, you will get notifications and you will need to click the notification or "launch" the app to see your messages.
KDE Plasma does not work. There is an open issue in the Electron repository for this, #10163 so there isn't any way around that.
As far as toggling it shown/hidden I tested that with other apps and they all just open and clicking again will focus the window so I would keep it as is based on that.

Thanks for this! I would like to put this in 0.5.0 to stagger this from the changes in #43 (which will be 0.4.0), and because I want to implement the behavior requested in #44 . I'll post here again when I'm ready to merge. Should be within a day or two.

Hey @jacob-swenson and @ajivoin , would you mind updating this branch to resolve the conflicts? I'd love to get it merged and released! The only conflict should be around where we do mainWindow = createWindow in background.js. The object we pass is now a const so we can conditionally add or manipulate properties in it.

@chrisknepper the conflict has been resolved and I've tested this feature still working after the resolve in Linux.

Sounds good. Thanks for your work on this! I'll get it merged and released soon along with a couple of other requested features.


Logup: more documentation

Run RUSTDOCFLAGS="-D warnings" cargo doc --all-features --no-deps.

Oh I was too late :|


Feature request: Specific format for date

Hi! Very cool plugin, thanks!
Would it be possible to add a feature so that ypu could choose from some format options to insert the date? For example in bold font or as H2 heading.
... I realize this is pretty easy to add 'by hand', I just think it would be a cool little feature

Hi,
Thank you for the suggestion. I believe that formatting the date text falls outside the scope of this plugin. There are numerous methods to edit text formatting in Obsidian, such as using built-in commands like Toggle bold, heading, strikethrough, etc., and there are also several plugins available that facilitate easy text formatting.
However, a potentially useful feature would be to add a setting that allows the date picker to automatically select the entire date text. This would streamline the process of applying any formatting to the date text using the methods mentioned above.

I added a new setting to the plugin: Select date/time text in release 0.3.19. Although not full formatting support, I believe it can make formatting quicker and easier.
Please let me know if you have any comments before I close this issue.

I added a new setting to the plugin: Select date/time text in release 0.3.19. Although not full formatting support, I believe it can make formatting quicker and easier. Please let me know if you have any comments before I close this issue.

yeah that is very useful, thanks!


Decode revert error data when selector is 0x08c379a

See https://ethereum.stackexchange.com/questions/142752/yul-inline-assembly-revert-with-a-custom-error-message.

Fixed in

#88


My issue is that this is perfect and thanks so much

The service you built makes my life so much better. Thank you thank you thank you!

Thanks!


Is this package being maintained?

I see a lot of open issues and PRs but the last commit was over a year ago. Is this package being maintained by anyone? It's a useful package and it would be a shame for it to die.

active forks

beefjelly/ffmpeg-python - 16 commits ahead, last commit 2023

Sadly the beef jelly hasn't pushed any releases to pypi.  I remember running into some issues with the current packaged version not working as well with multiple maps or something like that.  I agree its sad that this may die since I have a project that works great with it, and I don't really want to convert to an alternative.


refactor: simplify build optimizer node_env handling

Description
We can workaround the change in optimizer/index.ts with define: { 'process.env.NODE_ENV': 'process.env.NODE_ENV' } instead. (esbuild example)
Also I'm not sure if the check was wrong. The comment mentioned lib builds but we were checking generic builds. I changed the condition to check lib builds instead (same as define.ts)
Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Hmm looks like we don't. All tests pass if I set it like this:
  const define = {
    'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV || config.mode),
  }

I suppose we don't have a lot of test for the build optimizer + lib mode. Let me try to add a test.

I tried to add a test (in main for testing) and it's not quite working for the build optimizer with lib mode I think. Getting strange errors:

trace
vite v5.0.0-beta.14 building for production...
Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:
(vite:build-import-analysis) transform "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(commonjs--resolver) resolveId "@vitejs/test-pkg-with-process-node-env" "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(vite:optimized-deps-build) load<EMAIL_ADDRESS>error during build:
Error: Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:
(vite:build-import-analysis) transform "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(commonjs--resolver) resolveId "@vitejs/test-pkg-with-process-node-env" "/Users/bjorn/Work/oss/vite/playground/lib/src/build-optimize.js"
(vite:optimized-deps-build) load<EMAIL_ADDRESS>    at process.handleBeforeExit (file:///Users/bjorn/Work/oss/vite/node_modules/.pnpm/rollup@4.2.0/node_modules/rollup/dist/es/shared/node-entry.js:18801:28)
    at Object.onceWrapper (node:events:628:26)
    at process.emit (node:events:513:28)
    at process.emit (/Users/bjorn/Work/oss/vite/node_modules/.pnpm/source-map-support@0.5.21/node_modules/source-map-support/source-map-support.js:516:21)
 ELIFECYCLE  Command failed with exit code 1.


Add basic CI

@quantco/ci WDYT?

Fine with this but would prefer a Github action here that auto-updates. That would be more valuable :D


Resume from last playback time

Is there a feature/way to start video from same playback time where I left last time just like youtube?

Fixed with playTime value from getStats()


Update flow

Update flow and flow types to address latest flow changes, described here.
I had to also update prettier, otherwise prettier formatting was making code invalid.

Hmm... for some reason weirdly formatted flow types end up in lib/unstated.js
var StateContext = createReactContext < ContainerMapType | null > null;

Ok, I made it work by updating babel, rollup and jest. Should I push it and just rename PR to 'Update deps'?


HBASE-26680 Close and do not write trailer for the broken WAL writer(addendum)

Address the source compatibility problem caused by adding method to the LimitedPrivate(CONFIG) abstract class.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 19s
Docker mode activated.


Added nuget package to VA and Skills

Description

Installed Microsoft.Bot.Builder.Solutions package from myget
Removed Microsoft.Bot.Solutions package from assistant folder
Changed namespace throughout

To do:

[x] Update docs to add myget as package source

Future PRs:

Update skill template to use package

@lauren-mills Is there anything that I need to update in Visual Studio for this to work?  I'm getting some errors:

@outofthecave, I’ve added the package source in the nuget.config for the solution, so you shouldn’t have to add anything manually... can you verify that the file is there? And can you see the extra package source in the Package Manager Settings window?

Thanks, @lauren-mills.  The file solutions/Virtual-Assistant/src/csharp/nuget.config is present and contains an entry for MyGet.  But the package source is not showing up in Visual Studio when I right-click on "Virtual Assistant", select "Manage NuGet Packages", and check the "Package source" drop-down.  If I click the little gear next to that drop-down to get to the settings window, it's not showing up either.  I only see "nuget.org" and "Microsoft Visual Studio Offline Packages" in both places.

Never mind, it turns out this was one of those issues with file name capitalization that only show up on my end because I use the WSL for git operations.  I'll make a PR to correct the capitalization of the file name.


ghost warping out of a test area deletes all your actions

Description

Not sure what causes this.
As far as I can test on a live server, it's only a bug with the admin test area...
Reproduction

I use the verb to teleport to the test area, then use the ghost warp menu to go to any location on the station. I lose all my actions.

Closing this as it is likely a duplicate of #21063


Removed -WhatIf references

Removed references to the -WhatIf parameter, since that is currently unsupported in this cmdlet.

Thanks for the feedback. I'll raise a fresh PR just updating the description for WhatIf, communicating that it isn't supported. Closing this PR now.


Try improve performance

This improves performance primarily for serializing basic objects (without relationships for example), however because the changes target the ResourceObjectConverter it probably has a knock on effect for other use cases but I didn't measure those. In my not so scientific testing process (comparing wall clock runtime for a unit test and picking the best of 3) this reduces serializing in the performance test case from 35.925s to 21.270s.

Use string operations instead of regexes
Cache Type to string type names
Inline some methods that are in the main loop
Switch from linq to for loops
Process well known attributes ahead of iterating through other properties
Do not add resource objects to the Included collection
A slightly better GetHashCode for ResourceObjectReference

The biggest wins were (5) and (6).

@codecutout I need to do some clean up on this to DRY up some of the copy/paste but this is otherwise ready to go.  I started with this round of changes because I wanted to baseline against the default serialization.

@jonnii are you running into issues where performance of the serializer is a problem? If so where is the problem, is it CPU usage, memory usage, inconsistent execution times?

The only performance that currently affects our applications is serialization, we have some endpoints which (for reasons that are not easy to change) can return thousands of records with an equal number of includes and when serializing this much data you start to see the json serialization show up on the profiler. The problem (if you can even call it that) is that out of the box using JsonApiSerializer does add some overhead vs converting to a jsonapi-like data structure and using the default serialization so for certain use cases we're been hesitant to switch to it even though it reduces a ton of boilerplate.
I don't expect to be at parity with the out of the box speed, but there's lots of low hanging fruit here to claw back performance to a reasonable level for large-ish responses.

@codecutout I made a few more changes, by special casing some common used types it brings the time down to 17.382s from 35.925s.

Ive added some comments, but will need to have a good read and play through the code to make sure the optimizations dont break anything
The type of changes that are being done here a very much micro optimizations and although I love having a fast library, I cant help but feel that the time in fetching and processing the data would be more of a bottleneck than the allocations we are dong during serialization. But i'm not familiar with your particular use case
It seems you are also only optimizing the writes, are reads a concern for you?
A better approach to increasing the performance may to calculate up front for a given class which properties are present and which should be attributes/relationships. Then at serialization time it can just focus on performing the writes. It means the calculation can still retain easier readability as its less performance critical but the serialization will be fast as it is performing minimal logic

The type of changes that are being done here a very much micro optimizations and although I love having a fast library, I cant help but feel that the time in fetching and processing the data would be more of a bottleneck than the allocations we are dong during serialization. But i'm not familiar with your particular use case

We serve most of our data from memory, the time spent serializing (currently) vastly outweighs the time it takes to fetch, even with these optimizations this is still the case.

It seems you are also only optimizing the writes, are reads a concern for you?

Not currently, we tend to not post so much data and the speed of the reads where we do is fine and (usually) dwarfed by the writes happening downstream (e.g. to databases etc).

A better approach to increasing the performance may to calculate up front for a given class which properties are present and which should be attributes/relationships. Then at serialization time it can just focus on performing the writes. It means the calculation can still retain easier readability as its less performance critical but the serialization will be fast as it is performing minimal logic

I want to do this! My thinking was do what I can with the existing structure which can act as a blueprint for doing the code generation required. I did a bunch of experimentation to see how much would be possible to squeeze out of the existing process if we didn't (for example) track includes or generate relationships - and it seems that for now the biggest win will be changing how we track includes.

@codecutout BTW when I switched to using ConcurrentDictionary I had to drop support for netstandard1.0...

Im going to merge this onto a branch for now. There are a number of other performance tweaks that i've been experimenting which I can combine with your changes


vTPM: switch model from tpm-tis to tpm-crb

What this PR does / why we need it:
tpm-crb is now the preferred vTPM model:
https://bugzilla.redhat.com/show_bug.cgi?id=1519013#c20
https://bugzilla.redhat.com/show_bug.cgi?id=1867917#c8
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
This change should not cause issues with existing VM(I)s, since KubeVirt has yet to release with persistent vTPM support.
Release note:

Now using the tpm-crb model for vTPM

So depending on the model I may/need to be using a different driver. With this change will I be able to run VM which is running with a driver for tis spec?

I believe, for Linux guests at least, that the tpm_crb module will be needed instead of tpm_tis. However, I would be surprised if any distro shipped one and not the other...

/retest

So depending on the model I may/need to be using a different driver. With this change will I be able to run VM which is running with a driver for tis spec?

I believe, for Linux guests at least, that the tpm_crb module will be needed instead of tpm_tis. However, I would be surprised if any distro shipped one and not the other...

It is not a matter of availability of the module. That is most likely true. But it is a matter of breaking change when I perform a restart or start of an existing VM in the cluster. The admin/owner of the VM might need to do manual steps.
I would suggest an alternative. Set different default for persistent vTPM which was not released yet or add a new default option that needs to be opt-in.

@xpivarc switched to using tpm-crb only for the persistent use-case, with a comment explaining why. PTAL!


Rename the github project l2t_scaffolder

Since this is not only for plaso development, rename the project into l2t_scaffolder.

Create a PR that renames plasoscaffolder to l2tscaffolder in every file and rename directory.
Rename the github project
Create a release
Push the new version to pypi.

This is all dependent on:

https://github.com/log2timeline/PlasoScaffolder/pull/40: New frontend
https://github.com/log2timeline/PlasoScaffolder/pull/42: Deleting/removing old code

These dependencies need to be checked in first.

Rather than rename the project, why not move this to l2tdevtools? That's what we'd discussed earlier.

This is the first step, to rename the project, the move to l2tdevtools was somewhat dependent on python3 readiness of that tool

This is done, I'll create a new issue to track migration to l2tdevtools


EKF: update wind covariance initialization

Update the initialization of the wind state covariance submatrix as discussed here
Here is a SITL mission where the plane take off facing east and then turns to the north. Synthetic sideslip fusion is turned off
master/pr

As can be seen on the PR the initial wind uncertainty in east direction is lower than in north which makes sense.
@priseborough Compared to our precious discussion I did not set the wind along body y to zero in the covariance initialization. When looking through the derivation I simply did not see a reason for that, would be happy if you could review
The derivation is done using the following sympy script
import sympy as sp
Wx, Wy, yaw, R_TAS, initial_wind_var_body_y, R_yaw = sp.symbols('Wx Wy yaw R_TAS initial_wind_var_body_y R_yaw')
Wn = Wx * sp.cos(yaw) - Wy * sp.sin(yaw)
We = Wx * sp.sin(yaw) + Wy * sp.cos(yaw)

Wn_Wx = sp.diff(Wn, Wx)
Wn_Wy = sp.diff(Wn, Wy)
Wn_yaw = sp.diff(Wn, yaw)
We_Wx = sp.diff(We, Wx)
We_Wy = sp.diff(We, Wy)
We_yaw = sp.diff(We, yaw)

G = sp.Matrix([[Wn_Wx, Wn_Wy, Wn_yaw],[We_Wx, We_Wy, We_yaw]])
wind_body_cov = sp.Matrix([[R_TAS, 0.0, 0.0], [0.0,initial_wind_var_body_y, 0.0], [0.0, 0.0, R_yaw]])
wind_cov = G * wind_body_cov * G.T

print('P[22][22] = ' + str(wind_cov[0,0]))
print('P[22][23] = ' + str(wind_cov[0,1]))
print('P[23][22] = ' + str(wind_cov[1,0]))
print('P[23][23] = ' + str(wind_cov[1,1]))

I've gone through the equations and have done some testing using different inout values including varying the hardcoded values for  initial_sideslip_uncertainty and R_yaw.
Something I noticed when doing this is  that when the wind estimate is is zero, the yaw angle uncertainty has no effect on the resultant P matrix entries. For example if:
euler_yaw = 90 deg flying east
wind_vel_0 = 0
wind_vel_1 = 0
true_airspeed = 15 m/s
R_TAS = 4.0
initial_sideslip_uncertainty = 0
R_yaw = (deg2rad * 10.0)^2;
The P(22,23) sub matrix produced is:
P =
0.0000    0.0000
0.0000    4.0000

In this instance I would have expected when flying east with a yaw uncertainty and zero diselip uncertainty that there would be some uncertainty in the North velocity component due to the yaw uncertainty.
Should we the equations for Wn and We explicitly include  the sideslip angle? eg:
Wn = Wx * sp.cos(yaw+beta) - Wy * sp.sin(yaw+beta)
We = Wx * sp.sin(yaw+beta) + Wy * sp.cos(yaw+beta)

@priseborough As we already discussed I agree with your points above, unfortunately I don't have time to implement and test this at the moment.
However, we have done a couple of thousand flights with the current logic and it seems to work well. So how do you feel about adding a todo comment regarding the sideslip angle in the code and merging this as it is?

okey will do the changes

@priseborough I finally got the time to push the derivation script. For now I put it in the matlab folder even though it is written in python. I guess we will have to clean that up at some point


Example please?

Hi there would anyone have an example of using this with redux and connect?
When I connect it to redux and use the props it renders all the rows, however, it only renders the data of the last row?
I assume its my ignorance in using redux, so any help would be appreciated.
Thanks for this component!

...?

Hey @AlisonWonderlandApps! That doesn't quite sound like an issue with this component but if you'd like to share the code you're using I'd be happy to take a look and try to help.

Thanks jemise.. I have added my code... The output is as follows

Hm @AlisonWonderlandApps looking through your code there's one thing that jumps out at me. In your constructor you're setting listViewData on your state here:
this.state = {
  listViewData: this.ds.cloneWithRows(this.props.receiptList)
};

Let's say initially receiptList is an array with only one object in it, and then something changes so redux updates and receiptList has 10 objects in it. Your component would never update because you're not setting the state again on every prop change. You can use componentWillReceiveProps to listen for props changes and update your state.. but this is an anti pattern.
If I were you I would take the listViewData out of the state entirely. In your render function I would just return:
<SwipeListView
  dataSource={this.ds.cloneWithRows(this.props.receiptList)}
/>

And if Redux ever updates and receiptList changes, your view will update accordingly.
Maybe give that a shot and see if it does the trick

Hi jemise I have tried this and it also does not work. Which Is why I changed back to using a state at all.. otherwise I would have just used componentShouldUpdate..

UPDATE...WOW.... it seems to be TouchableHighlight causing the issue in renderRow...

Ah gotcha, so it wasn't the data.. just the rendering. Nice find. Glad you were able to figure it out!


publish<EMAIL_ADDRESS>

Requested by: @jan-auer
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Targets

[ ] crates
[ ] pypi
[ ] github

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

The error occurs in the x86 Linux wheel build:
Status: Downloaded newer image for quay.io/pypa/manylinux2010_i686:latest
Error: Cannot retrieve repository metadata (repomd.xml) for repository: base. Please verify its path and try again


Scroll to top on restoration visits when scrollPosition is empty is bad for UX

Hello,
I was experiencing scroll to top jumps on iOS devices whenever I use swipe back gesture. More concrete, I had turbolinks for certain pages disabled, therefore no scroll position was stored. Navigating back it tried to restore scroll position with Visit.performScroll(), but because of the missing scroll position, it simply jumps to the top. This is a little bit annoying when you have a long list of items, you want to go back from a detail page and you have to scroll back to the previous scroll position manually.
Is there any particular reason to hard code this behaviour and let it jump to the top? Why not only jump to a scroll position whenever previous scroll position was stored and is available? For testing purposes I removed this function call to scrollToTop() and had no issues at all. Maybe I'm missing something.
Thanks a lot!

More concrete, I had turbolinks for certain pages disabled, therefore no scroll position was stored.

Hi @berndartmueller, would you be able to demonstrate this with an example? https://turbolinks-demo.glitch.me/ might be useful as a starting point. Thanks!

Closing as inactive.


Empty recycle bin option should be grayed out when no file is in the Recycle bin

Attempted to do it in https://github.com/files-community/files-uwp/pull/1334

This has been fixed with #1358


./bamboo.go:152: unknown lumberjack.Logger field 'Filename' in struct literal

ALARM: The Logger struct in 'https://github.com/natefinch/lumberjack/blob/master/lumberjack.go' is CHANGED!! So it make a mistake due to  'go get github.com/natefinch/lumberjack' in Dockerfile.

Pull Requested & Merged.


Fix typo in markdown for URL

Checklist:

[x] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
[x] Make sure all of the significant new logic is covered by tests
[x] Try to include the Pull Request inside of CHANGELOG.md

@jacquerie could you sign up the CLA?

@jacquerie could you sign up the CLA?

I just did!


Sending money - User can't search for a currency because the search function is blocked

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Access staging.new.expensify.com
Log into a verified user
Search for any user and open a chat
Click on the "Plus" icon
Click on "Send Money"
Click on the "Currency symbol"
In the search bar, attempt to write something

Expected Result:
The user expects to be able to search for his/her desired currency
Actual Result:
The search toggle is completely blocked and the user is forced to scroll through the currencies to try and find the correct one
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Mobile Web
-IOS

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/167715434-d62f7ace-5251-4756-a7c4-ac194596da13.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Looks like this is reproducible on dev as well and does not happen on production.

I suspect this commit - https://github.com/Expensify/App/commit/f88b00529881642b661414f64833744cdc474c2f

Cool looks like the issue is because the code is calling onBlur. So when the currency icon is clicked here,

The onblur gets called and is locking focus to the currency numbers which is why we can't type anything here,

Okay i'll just revert the offending PR and let them know about it.

This should be resolved in version 1.1.57-14 or higher.
@kbecciv, can you retest and if it passes then remove deployBlocker and check if off the checklist? 🙇♂

Thanks for investigating & reverting - can this issue now be closed?

I think we're just awaiting @Expensify/applause testing

QA mentioned it was tested. removing deploy blocker label. Actually yeah i'll close these as well since there is no reason to continue seeing them and it takes a while to go to prod.


Remove useless additionnal blur call

I noticed that the _onBlur method was not exactly similar to the _onFocus one in the TextInput component.
After digging, I found that the blurTextInput method in the TextInputState.js file was call twice in a raw instead of once when the textinput component should blur.
By removing this line, I fix this unecessary multiple call.

cc @sahrens. It seems like you introduced this line back in 2015. This looks like it's fairly harmless, but I wonder if you intentionally added this in to fix some weird bug. Should we just land this as is?

Apparently this "extra" blur call was necessary on Android. Reverting this PR fixes https://github.com/facebook/react-native/issues/22425