cmake find_package cannot find boost

Describe the bug
A clear and concise description of what the bug is.
Environment

OS: Windows
Compiler: MSVC

To Reproduce
Steps to reproduce the behavior:

./vcpkg install boost --triplet x64-windows
Use VS Code with CMakeTools and path to CMAKE_TOOLCHAIN_FILE=<path-to-vckpg.cmake>
See error when configuring the project

Expected behavior
Expected a clean build
Failure logs
** Console Output **
[cmake] CMake Error at C:/dev/src/Microsoft/vcpkg/installed/x64-windows/share/boost/vcpkg-cmake-wrapper.cmake:11 (_find_package):
[cmake]   Could not find a package configuration file provided by "Boost" with any of
[cmake]   the following names:
[cmake]
[cmake]     BoostConfig.cmake
[cmake]     boost-config.cmake
[cmake]
[cmake]   Add the installation prefix of "Boost" to CMAKE_PREFIX_PATH or set
[cmake]   "Boost_DIR" to a directory containing one of the above files.  If "Boost"
[cmake]   provides a separate development package or SDK, be sure it has been
[cmake]   installed.
[cmake] Call Stack (most recent call first):
[cmake]   C:/dev/src/Microsoft/vcpkg/scripts/buildsystems/vcpkg.cmake:797 (include)
[cmake]   CMakeLists.txt:6 (find_package)
[cmake]
[cmake]
[cmake] -- Configuring incomplete, errors occurred!
[cmake] See also "C:/dev/src/Microsoft/test_vcpkg/build/Windows/Debug/CMakeFiles/CMakeOutput.log".
** CMakeOutput.log **
The system is: Windows - 10.0.19045 - AMD64
Compiling the C compiler identification source file "CMakeCCompilerId.c" succeeded.
Compiler:
Build flags:
Id flags:
The output was:
0
MSBuild version 17.4.0+18d5aef85 for .NET Framework
Build started 12/23/2022 4:30:20 PM.
Project "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdC\CompilerIdC.vcxproj" on node 1 (default targets).
PrepareForBuild:
Creating directory "Debug".
Creating directory "Debug\CompilerIdC.tlog".
InitializeBuildStatus:
Creating "Debug\CompilerIdC.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
VcpkgTripletSelection:
Using triplet "x64-windows" from "C:\dev\src\Microsoft\vcpkg\installed\x64-windows"
Using normalized configuration "Release"
ClCompile:
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\bin\HostX64\x64\CL.exe /c /I"C:\dev\src\Microsoft\vcpkg\installed\x64-windows\include" /nologo /W0 /WX- /diagnostics:column /Od /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"Debug\" /Fd"Debug\vc143.pdb" /external:W0 /Gd /TC /FC /errorReport:queue CMakeCCompilerId.c
CMakeCCompilerId.c
Link:
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:".\CompilerIdC.exe" /INCREMENTAL:NO /NOLOGO /LIBPATH:"C:\dev\src\Microsoft\vcpkg\installed\x64-windows\lib" /LIBPATH:"C:\dev\src\Microsoft\vcpkg\installed\x64-windows\lib\manual-link" kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\lib*.lib" /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /PDB:".\CompilerIdC.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:".\CompilerIdC.lib" /MACHINE:X64 Debug\CMakeCCompilerId.obj
CompilerIdC.vcxproj -> C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdC\CompilerIdC.exe
AppLocalFromInstalled:
pwsh.exe -ExecutionPolicy Bypass -noprofile -File "C:\dev\src\Microsoft\vcpkg\scripts\buildsystems\msbuild\applocal.ps1" "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdC\CompilerIdC.exe" "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\bin" "Debug\CompilerIdC.tlog\CompilerIdC.write.1u.tlog" "Debug\vcpkg.applocal.log"
'pwsh.exe' is not recognized as an internal or external command,
operable program or batch file.
The command "pwsh.exe -ExecutionPolicy Bypass -noprofile -File "C:\dev\src\Microsoft\vcpkg\scripts\buildsystems\msbuild\applocal.ps1" "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdC\CompilerIdC.exe" "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\bin" "Debug\CompilerIdC.tlog\CompilerIdC.write.1u.tlog" "Debug\vcpkg.applocal.log"" exited with code 9009.
"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -ExecutionPolicy Bypass -noprofile -File "C:\dev\src\Microsoft\vcpkg\scripts\buildsystems\msbuild\applocal.ps1" "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdC\CompilerIdC.exe" "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\bin" "Debug\CompilerIdC.tlog\CompilerIdC.write.1u.tlog" "Debug\vcpkg.applocal.log"
PostBuildEvent:
for %%i in (cl.exe) do @echo CMAKE_C_COMPILER=%%~$PATH:i
:VCEnd
CMAKE_C_COMPILER=C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\bin\Hostx64\x64\cl.exe
FinalizeBuildStatus:
Deleting file "Debug\CompilerIdC.tlog\unsuccessfulbuild".
Touching "Debug\CompilerIdC.tlog\CompilerIdC.lastbuildstate".
Done Building Project "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdC\CompilerIdC.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.95
Compilation of the C compiler identification source "CMakeCCompilerId.c" produced "CompilerIdC.exe"
Compilation of the C compiler identification source "CMakeCCompilerId.c" produced "CompilerIdC.vcxproj"
The C compiler identification is MSVC, found in "C:/dev/src/Microsoft/test_vcpkg/build/Windows/Debug/CMakeFiles/3.24.3/CompilerIdC/CompilerIdC.exe"
Compiling the CXX compiler identification source file "CMakeCXXCompilerId.cpp" succeeded.
Compiler:
Build flags:
Id flags:
The output was:
0
MSBuild version 17.4.0+18d5aef85 for .NET Framework
Build started 12/23/2022 4:30:22 PM.
Project "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdCXX\CompilerIdCXX.vcxproj" on node 1 (default targets).
PrepareForBuild:
Creating directory "Debug".
Creating directory "Debug\CompilerIdCXX.tlog".
InitializeBuildStatus:
Creating "Debug\CompilerIdCXX.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
VcpkgTripletSelection:
Using triplet "x64-windows" from "C:\dev\src\Microsoft\vcpkg\installed\x64-windows"
Using normalized configuration "Release"
ClCompile:
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\bin\HostX64\x64\CL.exe /c /I"C:\dev\src\Microsoft\vcpkg\installed\x64-windows\include" /nologo /W0 /WX- /diagnostics:column /Od /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"Debug\" /Fd"Debug\vc143.pdb" /external:W0 /Gd /TP /FC /errorReport:queue CMakeCXXCompilerId.cpp
CMakeCXXCompilerId.cpp
Link:
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:".\CompilerIdCXX.exe" /INCREMENTAL:NO /NOLOGO /LIBPATH:"C:\dev\src\Microsoft\vcpkg\installed\x64-windows\lib" /LIBPATH:"C:\dev\src\Microsoft\vcpkg\installed\x64-windows\lib\manual-link" kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\lib*.lib" /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /PDB:".\CompilerIdCXX.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:".\CompilerIdCXX.lib" /MACHINE:X64 Debug\CMakeCXXCompilerId.obj
CompilerIdCXX.vcxproj -> C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdCXX\CompilerIdCXX.exe
AppLocalFromInstalled:
pwsh.exe -ExecutionPolicy Bypass -noprofile -File "C:\dev\src\Microsoft\vcpkg\scripts\buildsystems\msbuild\applocal.ps1" "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdCXX\CompilerIdCXX.exe" "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\bin" "Debug\CompilerIdCXX.tlog\CompilerIdCXX.write.1u.tlog" "Debug\vcpkg.applocal.log"
'pwsh.exe' is not recognized as an internal or external command,
operable program or batch file.
The command "pwsh.exe -ExecutionPolicy Bypass -noprofile -File "C:\dev\src\Microsoft\vcpkg\scripts\buildsystems\msbuild\applocal.ps1" "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdCXX\CompilerIdCXX.exe" "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\bin" "Debug\CompilerIdCXX.tlog\CompilerIdCXX.write.1u.tlog" "Debug\vcpkg.applocal.log"" exited with code 9009.
"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -ExecutionPolicy Bypass -noprofile -File "C:\dev\src\Microsoft\vcpkg\scripts\buildsystems\msbuild\applocal.ps1" "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdCXX\CompilerIdCXX.exe" "C:\dev\src\Microsoft\vcpkg\installed\x64-windows\bin" "Debug\CompilerIdCXX.tlog\CompilerIdCXX.write.1u.tlog" "Debug\vcpkg.applocal.log"
PostBuildEvent:
for %%i in (cl.exe) do @echo CMAKE_CXX_COMPILER=%%~$PATH:i
:VCEnd
CMAKE_CXX_COMPILER=C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\bin\Hostx64\x64\cl.exe
FinalizeBuildStatus:
Deleting file "Debug\CompilerIdCXX.tlog\unsuccessfulbuild".
Touching "Debug\CompilerIdCXX.tlog\CompilerIdCXX.lastbuildstate".
Done Building Project "C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\3.24.3\CompilerIdCXX\CompilerIdCXX.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.94
Compilation of the CXX compiler identification source "CMakeCXXCompilerId.cpp" produced "CompilerIdCXX.exe"
Compilation of the CXX compiler identification source "CMakeCXXCompilerId.cpp" produced "CompilerIdCXX.vcxproj"
The CXX compiler identification is MSVC, found in "C:/dev/src/Microsoft/test_vcpkg/build/Windows/Debug/CMakeFiles/3.24.3/CompilerIdCXX/CompilerIdCXX.exe"
Detecting C compiler ABI info compiled with the following output:
Change Dir: C:/dev/src/Microsoft/test_vcpkg/build/Windows/Debug/CMakeFiles/CMakeTmp
Run Build Command(s):C:/Program Files/Microsoft Visual Studio/2022/Community/MSBuild/Current/Bin/amd64/MSBuild.exe cmTC_089de.vcxproj /p:Configuration=Debug /p:Platform=x64 /p:VisualStudioVersion=17.0 /v:m && MSBuild version 17.4.0+18d5aef85 for .NET Framework
Microsoft (R) C/C++ Optimizing Compiler Version 19.34.31933 for x64
CMakeCCompilerABI.c
Copyright (C) Microsoft Corporation.  All rights reserved.
cl /c /Zi /W1 /WX- /diagnostics:column /Od /Ob0 /D _MBCS /D WIN32 /D _WINDOWS /D "CMAKE_INTDIR="Debug"" /Gm- /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_089de.dir\Debug\" /Fd"cmTC_089de.dir\Debug\vc143.pdb" /external:W1 /Gd /TC /errorReport:queue "C:\Program Files\CMake\share\cmake-3.24\Modules\CMakeCCompilerABI.c"
cmTC_089de.vcxproj -> C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\CMakeTmp\Debug\cmTC_089de.exe
Detecting CXX compiler ABI info compiled with the following output:
Change Dir: C:/dev/src/Microsoft/test_vcpkg/build/Windows/Debug/CMakeFiles/CMakeTmp
Run Build Command(s):C:/Program Files/Microsoft Visual Studio/2022/Community/MSBuild/Current/Bin/amd64/MSBuild.exe cmTC_a8218.vcxproj /p:Configuration=Debug /p:Platform=x64 /p:VisualStudioVersion=17.0 /v:m && MSBuild version 17.4.0+18d5aef85 for .NET Framework
Microsoft (R) C/C++ Optimizing Compiler Version 19.34.31933 for x64
CMakeCXXCompilerABI.cpp
Copyright (C) Microsoft Corporation.  All rights reserved.
cl /c /Zi /W1 /WX- /diagnostics:column /Od /Ob0 /D _MBCS /D WIN32 /D _WINDOWS /D "CMAKE_INTDIR="Debug"" /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_a8218.dir\Debug\" /Fd"cmTC_a8218.dir\Debug\vc143.pdb" /external:W1 /Gd /TP /errorReport:queue "C:\Program Files\CMake\share\cmake-3.24\Modules\CMakeCXXCompilerABI.cpp"
cmTC_a8218.vcxproj -> C:\dev\src\Microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles\CMakeTmp\Debug\cmTC_a8218.exe
Additional context
Add any other context about the problem here.

This is the same as another issue, both initiated by you.
Would you mind providing CMakeLists.txt, I'd like to see how you wrote it.

`cmake_minimum_required(VERSION 3.21)
project(test_vcpkg)
find_package(Boost CONFIG REQUIRED)
add_executable(main main.cpp)
target_link_libraries(main PRIVATE Boost::Boost)
`

Main file (from boost asio tutorial
//
// timer.cpp
// ~~~~~~~~~
//
// Copyright (c) 2003-2022 Christopher M. Kohlhoff (chris at kohlhoff dot com)
//
// Distributed under the Boost Software License, Version 1.0. (See accompanying
// file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
//

#include <boost/asio.hpp>
#include <iostream>

int main() {
  boost::asio::io_context io;

  boost::asio::steady_timer t(io, boost::asio::chrono::seconds(5));
  t.wait();

  std::cout << "Hello, world!" << std::endl;

  return 0;
}

VS Code workspace settings.json file:
{
    "cmake.configureArgs": [
        "-DCMAKE_TOOLCHAIN_FILE=C:/dev/src/microsoft/vcpkg/scripts/buildsystems/vcpkg.cmake"
    ]
}

I have searched a bit about and found that I can provide BOOST_ROOT during configuration. But the problem is that vcpkg has different archives for each individual component in boost.

To find boost you have to use find_package(Boost REQUIRED)

Tried with:
cmake_minimum_required(VERSION 3.21)
project(test_vcpkg)

find_package(Boost REQUIRED)

add_executable(main main.cpp)
target_link_libraries(main PRIVATE Boost::Boost)

Result:
[main] Configuring folder: test_vcpkg
[driver] Removing c:/dev/src/microsoft/test_vcpkg/build/Windows/Debug/CMakeCache.txt
[driver] Removing c:\dev\src\microsoft\test_vcpkg\build\Windows\Debug\CMakeFiles
[proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_TOOLCHAIN_FILE=C:/dev/src/microsoft/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -Sc:/dev/src/microsoft/test_vcpkg -Bc:/dev/src/microsoft/test_vcpkg/build/Windows/Debug -G "Visual Studio 17 2022" -T host=x64 -A x64
[cmake] Not searching for unused variables given on the command line.
[cmake] -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.22621.
[cmake] -- The C compiler identification is MSVC 19.34.31937.0
[cmake] -- The CXX compiler identification is MSVC 19.34.31937.0
[cmake] -- Detecting C compiler ABI info
[cmake] -- Detecting C compiler ABI info - done
[cmake] -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe - skipped
[cmake] -- Detecting C compile features
[cmake] -- Detecting C compile features - done
[cmake] -- Detecting CXX compiler ABI info
[cmake] -- Detecting CXX compiler ABI info - done
[cmake] -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe - skipped
[cmake] -- Detecting CXX compile features
[cmake] -- Detecting CXX compile features - done
[cmake] CMake Error at C:/Program Files/CMake/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
[cmake]   Could NOT find Boost (missing: Boost_INCLUDE_DIR)
[cmake] Call Stack (most recent call first):
[cmake]   C:/Program Files/CMake/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
[cmake]   C:/Program Files/CMake/share/cmake-3.23/Modules/FindBoost.cmake:2376 (find_package_handle_standard_args)
[cmake]   C:/dev/src/microsoft/vcpkg/installed/x64-windows/share/boost/vcpkg-cmake-wrapper.cmake:11 (_find_package)
[cmake]   C:/dev/src/microsoft/vcpkg/scripts/buildsystems/vcpkg.cmake:797 (include)
[cmake]   CMakeLists.txt:4 (find_package)
[cmake]
[cmake]
[cmake] -- Configuring incomplete, errors occurred!
[cmake] See also "C:/dev/src/microsoft/test_vcpkg/build/Windows/Debug/CMakeFiles/CMakeOutput.log".
[proc] The command: "C:\Program Files\CMake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_TOOLCHAIN_FILE=C:/dev/src/microsoft/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -Sc:/dev/src/microsoft/test_vcpkg -Bc:/dev/src/microsoft/test_vcpkg/build/Windows/Debug -G "Visual Studio 17 2022" -T host=x64 -A x64 exited with code: 1 and signal: null
[visual-studio] Patch Windows SDK path from C:\Program Files (x86)\Windows Kits\10\bin\x64 to C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64 for C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat

Are you using manifest mode?

What is manifest mode?

https://learn.microsoft.com/en-us/vcpkg/examples/manifest-mode-cmake

I think I was using vcpkg install boost instead of vcpkg install boost --triplet x64-windows. But shouldn't that be the default behavior on a 64-bit Windows version?

But shouldn't that be the default behavior on a 64-bit Windows version?

https://github.com/microsoft/vcpkg-tool/pull/640#issuecomment-1194431232

Can I set VCPKG_DEFAULT_TRIPLET in the vcpkg.json (that's what sets the manifest mode right?)

Can I set VCPKG_DEFAULT_TRIPLET in the vcpkg.json

You don't have to.

that's what sets the manifest mode right?

Yes

Going to close this issue. I think the Getting Started page should be updated and at least have a warning about this there. But after diving into vcpkg, the solution is easy.
Thanks for the support.

Going to close this issue. I think the Getting Started page should be updated and at least have a warning about this there. But after diving into vcpkg, the solution is easy. Thanks for the support.

So how did you solve the problem in the end? I've encountered the same problem during installation of CGAL which depends on boost using visual studio.

I think (don't really remember now) that I just installed boost on my system.
My take with dependencies is that, in general, it is just easier and simpler to install common dependencies (spdlog, gtest, boost) and let vcpkg take care of minor dependencies (specific for each project). But maybe I will tackle this in the future.
Sorry I can't help.

I think (don't really remember now) that I just installed boost on my system.
My take with dependencies is that, in general, it is just easier and simpler to install common dependencies (spdlog, gtest, boost) and let vcpkg take care of minor dependencies (specific for each project). But maybe I will tackle this in the future.
Sorry I can't help.

I solved this problem by installing the static version instead by vcpkg install boost --triplet x64-windows-static. Then CMake does not complain about missing Boost_INCLUDE_DIR any more. In case this can be helpful for others, I also share this solution here.

Here is my setup for boost linux x64.
I used vckplg.json along side with CmakeLists.txt
{
    "dependencies": [
        "boost"
    ]
}

This installs all boost v1.83.0
Cmake
set(CMAKE_TOOLCHAIN_FILE "${PATH_TO_INSTALL_VCPKG}/vcpkg/scripts/buildsystems/vcpkg.cmake"
  CACHE STRING "Vcpkg toolchain file")

find_package(Boost REQUIRED)
if (Boost_FOUND)
    include_directories(${Boost_INCLUDE_DIRS})
    link_directories(${Boost_LIBRARY_DIRS})
endif ()

target_link_libraries(MyLib PUBLIC ${Boost_LIBRARIES})

Reference :
https://zhuanlan.zhihu.com/p/454233496
https://learn.microsoft.com/en-us/vcpkg/consume/boost-versions

@yhyu13 Given the absence of a project command in your example, set(CMAKE_TOOLCHAIN_FILE ...) is probably coming too late. This variable must be set before the project is seen the first time. Literally, in the first run of cmake for a clean binary dir.
And better don't depend on all of boost, i.e. use specificboost-<component> ports in the manifest, and use boost COMPONENTS in CMake.

I recently encounter this problem too. I use VS2019. I change the cmake generator from "Ninja" to "Visual Studio 16 2019", and the error becomes a warning from FindBoost.cmake.


Angular validation classes -> remove ng-valid/invalid style

Please could you revert the commit: https://github.com/coreui/coreui/commit/90f99f31ad5e44423dd6d5acb16b35c3414f52d0
this is a big problem in many cases, adding style directly to ng-valid and ng-invalid classes produces a few problems:

usually visual validation/invalidation visual effects are shown only after users touch or submit forms. Now with that commit is always visible
many times developers just add a specific class to add validation styles...for example (see is-invalid class)

<input class="form-control" type="text" name="subject" [(ngModel)]="subject"
              #subjectModel="ngModel" placeholder="Inserisci il titolo..." autocomplete="subject" required
              [ngClass]="{ 'is-invalid': f.submitted && subjectModel.invalid }">
            <div *ngIf="f.submitted && subjectModel.invalid" class="invalid-feedback">
              <ng-container *ngIf="subjectModel.errors?.required">Titolo richiesto</ng-container>
            </div>

now it is impossible to control it.
The hack I use right now to make things work as before:
.form-control.ng-valid {
  border-color: #b1b7c1;
  background-image: none;
}

.form-control.ng-invalid {
  border-color: #b1b7c1;
  background-image: none;
}

.ng-submitted {
  .form-control.ng-invalid {
    border-color: $form-feedback-invalid-color;
    background-image: $form-feedback-icon-invalid;
  }
}

fixed in v4.1.5


Ooops, something went wrong :(

Thank you for this project. I have set up your project per your README and guidance in your /docs. I keep getting this error when I load the project for the first time. I am sure its some config I am missing. How do I get more detailed information about what is breaking?

fixed. Some issue with pnpm


How to use this model to infer on own images

Hello, I think you've done great work here. One of the most comprehensive models that is trained on multiple types of datasets for a more one size fits all approach.
I would also like to use your model for my own images to get my own headcount on my own computer, how would I do that? I am able to follow your instructions for making the JSTL_large_dataset, and I had edited the code to see the headcount for each image. But I cannot get it to infer my own images that do not have ground truth.
Could I get some help, please? Please treat me as a newbie and be very clear on even things you find simple. Thank you.

I have added test_unknown folder for your case.


🚀 Feature: Delete share once Maximal views are reached

🔖 Feature description
Not sure if it's a bug or a feature request but I just noticed that shares do not get deleted if the Maximal views are reached.
Since nobody can access the share after the Maximal views are reached anyways it would be great if the share and it's files then get removed or at least make it an option.
🎤 Pitch
Shares with Maximal views reached can't be accessed no more, IMO there is no point in keeping the share and it's files.

Expired shares should get deleted every hour. Can you check if your share is deleted after an hour?

This is not possible, here is an example:
You create a share with a visitor limit of 1. When I open your link the view count gets increased and the limit is exceeded. When I now want to download the files, the share would already be deleted.
I hope you understand what I mean.

I get it, thanks for the clarification.
Sorry for the unqualified question but is there a way to restrict shares by downloads and not views? I mean something like a feature called Maximal downloads so the share gets deleted after the download happens?
This feature is really not that important to me I'm asking out of personal interest since it would be nice to have.
IMHO the restriction by views as it's implemented now comes with the risk of orphaned shares on your disk once the view limit is reached.

@mztiq Questions are always welcome :) The problem is that a share can have multiple files, so it's really difficult to limit the downloads. Maybe you have an idea to solve that? As a workaround you can delete the share manually in the My Shares section, but yeah it isn't an elegant solution.

I understand the problem on this feature better now, sadly I've no idea on how to solve this, just wanted to hear your opinion on it.
Thanks again for taking the time.

Is it okay when I close the issue for now? If we find a solution we can reopen it later.
Unrelated: Btw. thank you so much for your sponsorship! I wanted to thank you with an email but your mail server declines emails

Yes, issue can be closed for now.
And you're welcome, I appreciate your work and I'm impressed by what you can do, especially considering your age.
Thanks for pointing out the problem with my mail server, I barely use this E-Mail but it's fixed now :-).


To improve dev experience: gopath bin in path

I've tried to compile all this and I've got bit by this. I know it's very minor stuff but it may help.
@cdoan1 FYI

/approve
/lgtm

/approve
/lgtm


Prevent the user from changing the value of the progress bar

Any way to prevent the user from changing the progress bar?

I have the same question, please someone help, i tried to use these methods :
       slidr.setActivated(false);         slidr.setPressed(false);         slidr.setSelected(false);         slidr.setClickable(false);         slidr.setSaveEnabled(false);         slidr.setEnabled(false);
but non of them worked.

Simply use this code. It worked perfect for me
myView.setOnTouchListener(new View.OnTouchListener() {
  return true;
});

Simply use this code. It worked perfect for me
myView.setOnTouchListener(new View.OnTouchListener() {
  return true;
});

Enviado desde mi Redmi Note 6 Pro usando FastHub

that worked for me too, thanks so much for the answer 👍

You are welcome


Poc/permissions in UI

Check permissions in button and view access

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jason Becker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


README cleanup + consistent-ization

Went through all the READMEs (except LLM) and:

Added mention of how to train with mcloud
Made them a bit more consistent
Made only the example name H1, with everything else H2 or less
Tweaked prose a little
Ripped out the 500-word essay on why should pretrain from the BERT readme. It's good content but this readme is 2700 words even without it so we really need to cut length.

BERT is still kind of the odd one out with a different structure and a way longer. We need to think carefully about how to structure this one to handle the cartesian product of {pretrain, finetune} {local, mcloud}.
To review, I would recommend previewing the resulting markdown real fast.

Added several people as reviewers in the hopes that one of you will have bandwidth before the start of the bug bash


Fix exception on unload domain

Fix for https://github.com/AlexxIT/YandexStation/issues/435

https://github.com/AlexxIT/YandexStation/releases/tag/v3.13.3


Update copy in Activity feed to be more Supercharge-focused

Description
Each week users receive supercharge rewards which are shown in their activity feed and push notifications as CELO Rewards received. We want to update the copy to be more Supercharge-focused
User Stories
As a Valora user, I want to clearly connect rewards to the supercharge program so I know what I'm participating.
Change request
Current:
Sender: Celo Network
Comment: Weekly Rewards
Logo: Celo icon
Update to:
Sender: Supercharge
Comment: Weekly Rewards
Logo: Supercharge bolt icon
Not sure what the copy is in the push notification but it should also be updated please!

Closing for backlog spring clean May 2022


fix prepare_inputs_for_generation logic for Prompt Learning methods

What does this PR do?

The current logic from PR https://github.com/huggingface/peft/pull/1252 is incorrect as explained in https://github.com/huggingface/peft/pull/1252#issuecomment-1888604086 and https://github.com/huggingface/peft/pull/1252#issuecomment-1888614334.
This PR fixes it.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

(LGTM)

Do you have an example where the current logic fails.

The current logic doesn't fail in the sense of runtime errors but will produce wrong outputs as the initial input ids are again run through the model and they involve in self-attention with themselves. Will look into test in a follow up PR.

The current logic doesn't fail in the sense of runtime errors but will produce wrong outputs as the initial input ids are again run through the model and they involve in self-attention with themselves. Will look into test in a follow up PR.

Ah, got it, thanks. That makes it indeed very tricky to test.

The current logic doesn't fail in the sense of runtime errors but will produce wrong outputs as the initial input ids are again run through the model and they involve in self-attention with themselves.

@pacman100 @BenjaminBossan for these cases, in generate-related tasks in transformers, we often test the some of the returned logits against hardcoded expected values (e.g. here). In some cases, when the point is to test the logic (and not so much a model architecture), we use a tiny dummy model.


Code to stop CSRF attacks.

With suggested changes, the code fails to compile with:
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(44,49): error FS0039: The value, namespace, type or module 'af' is not defined. [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(43,5): warning FS0020: The result of this expression has type 'HttpFuncResult' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'. [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(45,12): error FS0039: The value, namespace, type or module 'af' is not defined. [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(47,49): error FS0039: The value, namespace, type or module 'af' is not defined. [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(55,38): error FS0001: The type 'HttpFunc' is not compatible with the type 'HttpContext' [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(55,51): error FS0001: The type 'AntiforgeryTokenSet' does not match the type 'int' [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(55,65): error FS0001: This expression was expected to have type    'HttpFunc'    but here has type    'int' [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
/home/jeff/gitrepos/blazor-compared/GiraffeApp/Program.fs(55,38): error FS0001: The type 'HttpFunc' does not match the type 'HttpFuncResult' [/home/jeff/gitrepos/blazor-compared/GiraffeApp/GiraffeApp.fsproj]
The build failed. Fix the build errors and run again.

Please check at my recent PR. (Fix  AntiForgery) @surferjeff


Profiles: profile display in tribes - Android App

Service involved:
Android app
Goal:
Create a display for a user's tribe-specific profile information, which is returned from the tribes-server when someone clicks on their username in a tribe.
Method:

Profile information will be returned here: tribes.sphinx.chat/person/uuid/{uuid}
It should be displayed according to Milan's design below: (tbd)

This repo is not used anymore


environment-specific env configuration files

I would like to use dotenv for setting in development Sentry's SENTRY_DSN variable, and checking out from version control the env file. So my main concern is to set this variable only for development.
Given for granted that I inserted the gem in both the development and test sections of the Gemfile, how can I tell dotenv to use this variable only in development?
As far as I have understood reading the documentation, I could create a specific .env.development file in the root of my application and define there my environment-specific variable(s). Is that enough and the only way to do it?
I came here after reading an article at launchschool.com where it is written that "yaml-like configs come baked in", which gave me the (probably wrong) idea that I could create a unique .env file and write specific sections for each environment using yaml notation. Is that possible?
That also might be interesting, but I could not find documentation in here.

So you're using rails?
And mabye this section will help: https://github.com/bkeepers/dotenv#what-other-env-files-can-i-use

@knzudgt I updated the comment a bit :grin:

Thanks for the exaustive explanation :)
To tell the truth, I would rather follow the recommendation I found in the Raven-Ruby GitHub page than configuring Raven directly in config/application.rb, just because I do not want to check in my Sentry key to Git. The Raven-Ruby GitHub page advises against this, and recommends instead to set this variable in the desired environment.
Doing this in production is quite straightforward.
In development I chose to avoid to set variables in the Linux environment, because I might need different values for different applications.
That's why I decided to install dotenv.

Yeah sure, if your repository is public, it's obvious that you need to hide it from public access..
At our company every time we have private repositories we just check it in.
And FYI I don't have this code block inside my config/application.rb I always write an initializer in config/initializers/sentry.rb.
dotenv is really good to store env variables, it keeps everything in place and if you have sensitive information like tokens/passwords I always prefer to use dotenv (to keep them secure, creating a sample) than configuring the environment variables on the according system :grin:

You can also see my comment on #254 (https://github.com/bkeepers/dotenv/issues/254#issuecomment-274742626) to get a little inspiration.
If there are no more questions open, you can close this issue 😁

@siegy22 Last question, if you do not mind.
My repository is a private repository at BitBucket.
In your opinion, would you say it is safe to check my Sentry key into Git or it is still advisable to avoid it?

It's honestly opinion based.
In my opinion, you could check it in because only people have access who are also allowed.
And if it somehow gets leaked, it's not that critical, because the only thing you can do is report errors and infos with those credentials..
Anyway when you see some awkward things going on, you can revoke the sentry key: https:///sentry//settings/keys/


fix issue https://github.com/alibaba/fastjson/issues/3473

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.fanzhongwei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #3474 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3474      +/-   ##
============================================
- Coverage     80.38%   80.37%   -0.02%
- Complexity     7472     7473       +1
============================================
  Files           157      157
  Lines         27912    27912
  Branches       6731     6731
============================================
- Hits          22438    22435       -3
- Misses         3457     3459       +2
- Partials       2017     2018       +1

Impacted Files
Coverage Δ
Complexity Δ

...ava/com/alibaba/fastjson/serializer/DateCodec.java
92.00% <100.00%> (ø)
53.00 <0.00> (+1.00)

...com/alibaba/fastjson/serializer/SerialContext.java
82.69% <0.00%> (-3.85%)
21.00% <0.00%> (-1.00%)

...main/java/com/alibaba/fastjson/util/FieldInfo.java
86.62% <0.00%> (-0.34%)
99.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea25de...5020cd4. Read the comment docs.


Allow configuration of source address for host->pod traffic

We use calico as Kubernetes CNI  within our Leaf and Spine Layer 3 only setup.
The Calico ippools are configured without NAT or IPIPMode.
The hosts have multiple interface and use a loopback interface for the nodeip / bgp peering
eno1 "<IP_ADDRESS> "> cooper mgt
loe0  "<IP_ADDRESS>" > loopback
enp65s0f0 > leaf1
enp65s0f1 > leaf2

Per default all cali interfaces use the wrong host interface eno1 as src ip address
ip r get <IP_ADDRESS>
<IP_ADDRESS> dev calif2badd712b3 src <IP_ADDRESS>
    cache

instead it should look like
ip r get <IP_ADDRESS>
<IP_ADDRESS> dev calif2badd712b3 src <IP_ADDRESS>
    cache

Expected Behavior

All cali interfaces should use the configured nodeip as src address
Current Behavior

All cali interfaces use eno1 as src ip address
Possible Solution

manual route change fix this behaviour ex:
ip route change <IP_ADDRESS> dev calif2badd712b3 scope link  src <IP_ADDRESS>
To get this persistent.
There must be a felix config value which add the correct src statement during cali interface creation on the host nodes.
Context

We want to separate the mgt traffic from the prod k8s traffic via pbr policies.
As the cali interfaces use the mgt interface ip as source the k8s traffic gets also affected from the pbr rules. Which leads to failed liveness and readiness probes within the local pods.
Example. The kubernetes-dashboard has a probe on port 8443 but the cali interface from this pod use the wrong src ip / interface for the probe connection.
10:24:47.007577 IP <IP_ADDRESS>.43536 > <IP_ADDRESS>.8443: Flags [S], seq<PHONE_NUMBER>, win 29200, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
10:24:47.007763 IP <IP_ADDRESS>.43536 > <IP_ADDRESS>.8443: Flags [S], seq<PHONE_NUMBER>, win 29200, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
10:24:48.008735 IP <IP_ADDRESS>.43536 > <IP_ADDRESS>.8443: Flags [S], seq<PHONE_NUMBER>, win 29200, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
10:24:48.008938 IP <IP_ADDRESS>.43536 > <IP_ADDRESS>.8443: Flags [S], seq<PHONE_NUMBER>, win 29200, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0

When i change the src address to the loopback interface everything is working.
Many thanks in advanced for your help.
Your Environment

Calico version 3.3
Orchestrator version (e.g. kubernetes, mesos, rkt): K8s
Operating System and version: Debian
Link to your project (optional):

Hm, I don't think Calico sets the src attribute on the routes it programs. This code seems to confirm that: https://github.com/projectcalico/felix/blob/e0ce0bca201da59671dd166e80a9c96f2bca6201/routetable/route_table.go#L465-L471
So, it looks like the source that is showing up in your ip r get is the source chosen by linux for that route.
Need to think about the options here a bit more, but I suspect it may be solvable with configuration changes on the host to make it select the desired source address.

i tried to solve this via a pbr rule which set the loopback ip as default route for the pod network.
But then i see only arp requests from the pod:
10:33:51.880733 ARP, Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28
10:33:52.904733 ARP, Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28
10:34:00.482752 ARP, Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28
10:34:01.512731 ARP, Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28

I also tried the the proxy_arp flag for the loopback interface but i got the same result an saw only arp request in the tcpdump.
Any kind of help is highly appreciated

I faced(am facing) this same issue and ended up modifying felix to accept a parameter to use for the device route source address. (This can't do anything about the route the CNI plugin sets up, but for us the time between the route existing and the source update occurring is small enough that it is okay for us). A smarter solution may be to try and get the source address for a default route and use that one or add a flag for using the BGP address, but I'm wondering if there are any thoughts from the Calico side. Otherwise I'd like to submit the PRs that include our changes for this.

Added here: https://github.com/projectcalico/calico/pull/2779

Thanks a lot for the fix @maxstr


Fix project token authentication for api/v1/projects/name/{name}

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


FormFragment Tablayout and Pageradapter implementatio error

Good afternoon.
It's good to have changed NexusDialog to handle fragments, when testing started to use it in a Tablayou and PagerAdapter, so far I could not make it work properly, adding the fragments to the tabs of tablayout, only the first TAB display properly, the rest does not display the form is left blank, could make an example of the proper implementation in tablayout and pageradapter, thank you very much.

The error is:
java.lang.IllegalStateException: Can't change container ID of fragment MovieFragment{5244ee0 id=0x7f0b006d android:switcher:2131427439:0}: was<PHONE_NUMBER> now<PHONE_NUMBER>


Update virtual-machines-linux-extensions-customscript.md

fixed some small typos

Hi @MartinGoodwell, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@MartinGoodwell : Thanks for your contribution to the Azure documentation! The author, @kundanap, has been notified to review your proposed change.

#sign-off

#sign-off


[FrictionlessQA] Enhancements

Per request, fired a view event when loaded
Handles invalid locales more gracefully

Test URLs:

Before: https://stage--express--adobecom.hlx.page/express/feature/image/remove-background
After: https://frictionless-misc--express--adobecom.hlx.page/express/feature/image/remove-background

Codecov Report
Attention: Patch coverage is 97.72727% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 36.69%. Comparing base (8f28a3d) to head (e22408b).

Files
Patch %
Lines

...tionless-quick-action/frictionless-quick-action.js
97.72%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #795      +/-   ##
==========================================
+ Coverage   36.45%   36.69%   +0.23%
==========================================
  Files         132      132
  Lines       25939    25982      +43
==========================================
+ Hits         9457     9533      +76
+ Misses      16482    16449      -33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updated Willow (though WAS) and also WIS on server.

Then I updated to the latest (willow-RC2) software on each of the ESP32-S3 (and one S3-lite) device and none is responding. They respond to the wakework, but just sits there. This is a screenshot from what's happening on WIS:

I'll flash the previous RC-1 to the first S3 and see what happens. All the willow were working fine still this morning, util I updated everything.

I am running WIS on a GTX 1080Ti.
As I said I did a full upgrade of the Ubuntu 22.04.1 only a coupld of days ago and everything was still working fine. The  today I noticed that there were some repository changes and upgraded everything.
Well, it is working now - so for me that is what matters most. Let me know if you need any reports or other testing to be done with this - I am willing to help.

The GTX 1080Ti has 12GB VRAM which is enough to run several instances of WIS concurrently, you definitely shouldn't be having any issues running any models at any beam size. Your issue with beam size five does point to some kind of strange card/driver quirk we have never seen before.
I mentioned doing Nvidia driver upgrades carefully in the general sense as there is definitely potential to encounter some rough edges given how fundamental they are. It's generally safe but every once in a while things go wrong.

I think the Nvidia drivers could have been the issue as I updated the ESP-
Willows and WIS, before I did a system upgrade.
But even after I did the driver update and reboot, WIS still defaults to
Beam-size=1. And when size=5 is specified in willow, WIS rejects the
response.
Is there a way to chance the default size in WIS, it seems that it must be
an option for this, but I do not know where to look for it? In utils.sh?
Thanks
Bert
On Wed, Sep 27, 2023, 07:01 Kristian Kielhofner @.***>
wrote:

The GTX 1080Ti has 12GB VRAM which is enough to run several instances of
WIS concurrently, you definitely shouldn't be having any issues running any
models at any beam size. Your issue with beam size five does point to some
kind of strange card/driver quirk we have never seen before.
I mentioned doing Nvidia driver upgrades carefully in the general sense as
there is definitely potential to encounter some rough edges given how
fundamental they are. It's generally safe but every once in a while things
go wrong.
—
Reply to this email directly, view it on GitHub
https://github.com/toverainc/willow-inference-server/issues/121#issuecomment-1737356381,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEN5KAAMXXUV27JY2CQURJTX4QPTTANCNFSM6AAAAAA5IL5KHM
.
You are receiving this because you authored the thread.Message ID:
@.***>

https://github.com/toverainc/willow-inference-server#configuration :)

@bert269 - It is still very strange you're having problems with beam_size=5. Can you provide your configured full WIS URL when you try that option?
On another note, you almost certainly don't need and probably don't want model=large and beam_size=5. We have found that for typical short speech commands those settings are almost too smart and reduce the consistency of responses, which is important because HA, etc match on the exact text returned for processing commands.

I had to re-install everything this rmorning. I will test this out as soon as I get the other issue resolved and provide feedback.


Upgrade Camel K to 1.3.0 in community operators

Signed-off-by: nicolaferraro<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/ok-to-test

/ok-to-test

/lgtm

/lgtm

@nicolaferraro, maybe you forgot to edit package.yaml which means the latest version is not in use. Which causes a pipeline failure. Please update.

@nicolaferraro, maybe you forgot to edit package.yaml which means the latest version is not in use. Which causes a pipeline failure. Please update.

/test deploy-operator-on-openshift

/test deploy-operator-on-openshift

@nicolaferraro, maybe you forgot to edit package.yaml which means the latest version is not in use. Which causes a pipeline failure. Please update.

Thanks, fixed!

@nicolaferraro, maybe you forgot to edit package.yaml which means the latest version is not in use. Which causes a pipeline failure. Please update.

Thanks, fixed!

/lgtm

/lgtm


Data files should not be tracked in GitHub

Related to the reorganization issue... recall that we do NOT want data files to be tracked (pushed and pulled) as part of your project repository. Even small files like the condition files should not be part of the repo.
Instead, these files should be downloaded with the make data command.

I take care of this issue


[Character Creation] Thug

When creating a Rogue and looking into the subclasses, the description for Thug is not being loaded properly

fixed on <IP_ADDRESS> to be released today or tomorrow top.


Possible code injection

When using autolink on a text including a link like this one
www.google.com"onclick="alert('gotcha!')

And render the output as it is suggested in the example:
String result = Autolink.renderLinks(input, links, (link, text, sb) -> {
    sb.append("");
    sb.append(text, link.getBeginIndex(), link.getEndIndex());
    sb.append("");
});

the output will be
www.google.com"onclick="alert('gotcha!')"

which is strictly speaking invalid HTML, but browsers will still execute the click handler. See https://jsfiddle.net/vLjLLo8n/2/ to try it out.
I understand that appending a subsequence to the StringBuilder is the more efficient than providing the link as a String, but to make this secure, you would need to get the substring and perform encoding on it.
So, for example using OWASP Java Encoder, the rendering needs to be done like this:
String result = Autolink.renderLinks(input, links, (link, text, sb) -> {
    String linkString = new StringBuilder().append(text, link.getBeginIndex(), link.getEndIndex()).toString();

    sb.append("");
    sb.append(Encode.forHtml(linkString));
    sb.append("");
});

resulting in a safe output:
www.google.com"onclick="alert('gotcha!')

Easiest fix for this particular problem would probably be if autolink would not include single or double quotes, or any other character not legal in a URL.
(EDIT: single quotes are legal characters)
A possibly breaking API change would be to provide the linkString as part of the LinkSpan interface.

Yeah, I'm fully aware of this, that's why there is a note for that example:

Note that it doesn't handle escaping at all

But maybe I should either:

Not include this example at all, as it's dangerous if someone copied it like that
Change the example so that it escapes all parts of text
Change the example so that it parses the input as HTML and only finds links in text (to prevent double linking)

Note that even your suggested change of using Encode would have problems in the real world, as it wouldn't escape text outside links.
What do you think?

First, the URLs really should not include characters not allowed in URLs. According to this post on Stackoverflow double quotes are not legal.
Giving an example in the readme is important, I wouldn't have learned about the AutoLink class otherwise. As a general effort to spread knowledge about important security best practices, it's maybe a good thing to include usage of Encode.
If you are using the library as a tool to create HTML out of some kind of plaintext, that plaintext needs to be sanitized before using it to autolink. That's what I do in my real world application; only during autolinking some of it becomes unwanted code again.

I was following Rinku's behavior in this case. Having said that, I don't think stopping URL's at " would be a problem in practice, so I'm open to changing it. Or did you want to work on that?
I'll update the example when I find some time.

Ok, I've:

Pushed a change to stop URLs at "
Created PR #25 to deprecate renderLinks by making it possible to write the example in a much more straightforward way (and handle escaping correctly for the rest of the text too):

Iterable spans = linkExtractor.extractSpans(input);

StringBuilder sb = new StringBuilder();
for (Span span : spans) {
    String text = input.substring(span.getBeginIndex(), span.getEndIndex());
    if (span instanceof LinkSpan) {
        // span is a URL
        sb.append("");
        sb.append(Encode.forHtml(text));
        sb.append("");
    } else {
        // span is plain text before/after link
        sb.append(Encode.forHtml(text));
    }
}
result = sb.toString();

@mindhaq nothing? Ok. I'm gonna merge that PR.

I have since released this change as 0.9.0, see CHANGELOG: https://github.com/robinst/autolink-java/blob/master/CHANGELOG.md#090---2018-06-04


Update sidplay to 4.2

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Unsure how to verify this sha256 change – can't find methods to contact the developer other than by email (which, of course, is not in the public domain, so cannot be verified).
Any help?

@giannitm In these cases, a maintainer should contact the developer for the verification.
However, you’ve shown yourself to be a trustworthy contributor, so you may do so yourself and report back.

@vitorgalvao I've sent them an email, and will report back when they respond.
Also, how long will the pull requests which need to be verified stay open for? If the developer does not respond within a certain number of days/weeks/months, will the pull requests be closed? We don't want to clutter up the repository with pull requests which are neither merged nor closed.

I’ve thought about that. Eventually (presumably) the apps will get a new version, which kind of solves the problem, but waiting for that is definitely not ideal.
Some of them, since we can see they were correctly signed and there were no reports of wrongdoing by the developers, we can assume to be fine. As for the others, no idea. I’ll have to think a bit on it.

Eventually (presumably) the apps will get a new version, which kind of solves the problem, but waiting for that is definitely not ideal.

I've been thinking about this since the verification policy was implemented.
For casks that can't be verified, could we add a unverified caveat and say something like "checksum for #{token} could not be verified, use at your own risk"?
Could also change the malware caveat as it does not seem to currently be used in a cask.

For casks that can't be verified, could we add a unverified caveat and say something like "checksum for #{@cask} could not be verified, use at your own risk"?

That’s certainly a possibility. Mind opening an issue for the discussion?

VirusTotal:
https://www.virustotal.com/en-gb/file/11d713325deeceadf0948c239ec353ee3b2346ca9cee47e2c7680113f34ba66e/analysis/1494477913/

Untrusted signature; no developer reply. Closing.


fix(GODT-1618): properly handle empty LIST pattern

RFC3501 states:
An empty ("" string) mailbox name argument is a special request to
return the hierarchy delimiter and the root name of the name given
in the reference. The value returned as the root MAY be the empty
string if the reference is non-rooted or is an empty string.
We didn't return the empty string for non-rooted references.

Looks good, but could you also add an example test for the case:

Create mailboxes foo and foo.bar using . as a separator
Run query LIST "foo.bar" "", expect result * LIST "." foo.

The above was tested on dovecot.

If i'm not mistaken, that's already covered by TestListRef, specifically at list_test.go:100:
func TestListRef(t *testing.T) {
	runOneToOneTestWithAuth(t, defaultServerOptions(t, withDelimiter(".")), func(c *testConnection, s *testSession) {
		c.C(`tag create some`).OK(`tag`)
		c.C(`tag create some.thing`).OK(`tag`)

		...

		c.C(`tag list "some.thing" ""`).S(`* LIST (\Noselect) "." "some."`).OK(`tag`)
	})
}


Media Collection support

Description
Adding actions and events to support Media Collection in Launch.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[ ] I have made any necessary test changes and all tests pass.
[ ] I have run the Sandbox successfully.
[ ] I've updated the schema in extension.json or no changes are necessary.
[ ] My change requires a change to the documentation.

Should we change the destination branch to beta instead of main?


Environment variables for portability

Description
This is an environment variables for Franz (FRANZ_APPDATA_DIR) that I already used in a hard-fork (Ferdi). Where it can change where the folder "Franz" is used/created.
Motivation and Context
I want this feature to help me to create a better FranzPortable with PortableApps.com format. And for other people who maybe prefer something else of %AppData%.
How Has This Been Tested?
I already tested with a fork but I will build Franz myself later and confirming is functionnallity.
UPDATE: From this build; everything is working fine.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project (run $ yarn lint).

🙌 thanks @Makazzz for taking care of this!


run_qc - failures

Hi,
I am using methylprep 0.5.4.
python -m methylprep -v process -d ./ --all  This runs successfully.
When I try to run the QC module in jupyter , i get some errors:
methylcheck.run_qc()
i get the error:

Attribute Error: can't delete an attribute

When I run the plotting manually i get the same error with below:
methylcheck.qc_signal_intensity(meth=meth_df, unmeth=unmeth_df)

Any idea why this is happening?
Thanks,
Ray

changed:
#del qc.index.name
qc.index.name = None
in v0.6.x, and maybe earlier versions. So this bug is resolved.


Feat: Add publish test code

I can confirm this fixes a bug from me that a I have experienced on http://localhost:3000/_junhoyeo

I can confirm this fixes a bug from me that a I have experienced on http://localhost:3000/_junhoyeo

@threaderzero I'm refactoring the web-ui part with components from junhoyeo/react-threads.
@Mineru98 Would like if you open separate PRs for each topic/fix/feature!

Feat: Add publish test code
Is this test code for local scripting? Cuz auth just doesn't work with username/password data, so it's hard to say that this is a valid testing code. Can we move this to scripts?

@threaderzero I'm refactoring the web-ui part with components from junhoyeo/react-threads.
@Mineru98 Would like if you open separate PRs for each topic/fix/feature!

web-ui issue was fixed in #59


Fan device configuration

Hi!
So I was trying to add my fan to Homebridge using your plugin, the problem is, I didn't find any clear description of how to configure it. So I tried multiple things like this:
   {         "accessory": "HttpMulti",         "name": "Fan",         "deviceType": "fan",         "model": "myFan",         "on_url": "http://myFanIp/on",         "off_url": "http://myFanIp/off",         "status_url": "http://myFanIp/powerPercent",         "speed_url": "http://myFanIp/set/%VALUE%"    }
I tried it without the "speed_url", without the "status_url" too, but nothing worked and Homebridge kept bugging. Note that /powerPercent return  a value between 0 and 100. And that /set/%VALUE% must be a value between 0 and 100. Please help me!

It looks like you've done everything right. Here's what I have which is working for me:
{
"accessory": "HttpMulti",
"name": "Room Fan",
"on_url": "http://IP/SET?select_item=$room_fan&select_state=on",
"off_url": "http://IP/SET?select_item=$room_fan&select_state=off",
"speed_url": "http://IP/SET?select_item=$room_fan&select_state=%VALUE%",
"status_url": "http://IP/get_status%28room_fan%29",
"deviceType": "fan"
},

The get_status will return a value between 0 and 100.

I've tried it in this order and it works, awesome! thanks!

Thanks for the follow-up. Weird, since the order of the elements shouldn't really matter, but glad that it's working for you.


Enable network share

Changed SERVE_EXTERNALLY env variable to ENABLE_NETWORK_SHARE #1

Do you mind updating the corresponding documentation as well? https://github.com/ashokgelal/alpasdev/blob/master/src/main/resources/docs/installation.md

PR has been raised.

Thank you!


Added "Emphasize Outflows" feature

Just a simple CSS feature. The striped rows are #219, not this PR.

Cool!


[FEAT] PDF to Markdown convert

It would be nice to have a feature to enable user file uploads and conversion of PDF to markdown. This would enable us to iterate on the UX of submitting your own Taxonomy, as well as it could be leveraged to improve the Triager experience creating and auditing QNA submissions.
More info: https://instruct-lab.slack.com/archives/C076C9RNKSA/p1718381515763659
/cc @nerdalert @mingxzhao @vishnoianil

@Gregory-Pereira Let's track this through #137. is it okay to close this issue?


[examples] Model picking

In  models_mesh_picking.c
when I change tower model's position ie
Vector3 towerPos = { -10.0f, 0.0f, 0.0f };                    // Set model position
picking doesnt work right anymore.
GetCollisionRayModel() function needs models to be in origin?

@kororro It happens because model vertex position transformation happens in the drawing but it's not directly assigned to the model. To attach the transformation to the model to be considered by GetCollisionRayModel(), just do at init:
model.transform = MatrixTranslate(-10.0f, 0.0f, 0.0f);
Vector3 towerPos = { 0.0f, 0.0f, 0.0f };

That way, model translation is defined inside model and considered on mesh picking.


gl-320-draw-instanced

In
gl4.glDrawArraysInstanced(GL_TRIANGLES, 0, vertexCount, 5);
there should be 2 instance rather than 5..

This issue is fixed in master branch for next release.
Thanks for reporting,
Christophe


Error during cURL Installation (Mac)

OS: MacOS
$ curl -sf https://raw.githubusercontent.com/livebud/bud/main/install.sh | sh

livebud/bud: checking GitHub for latest version
curl: (22) The requested URL returned error: 401

Hey @chriswalz , do you mind trying again? I'm seeing:
$ curl -sf https://raw.githubusercontent.com/livebud/bud/main/install.sh | sh
livebud/bud: checking GitHub for latest version
livebud/bud: found version 0.2.5 for darwin/arm64
livebud/bud: downloading https://github.com/livebud/bud/releases/download/v0.2.5/bud_v0.2.5_darwin_arm64.tar.gz
livebud/bud: verifying checksums
livebud/bud: installed as /usr/local/bin/bud

Hi Matthew. I appreciate you taking the time to look into this. Still doesn't work on my end but can look into whether it's my firewall or something

Just dug in a bit further. Since it's a 401, it seems like an unauthorized request.
I could see that happening if a GITHUB_TOKEN is set and maybe it's expired or not allowed to access repos: https://github.com/livebud/bud/blob/93a621e30dcf62885b2735b80444d255591c8dfd/install.sh#L241
Do you happen to have a GITHUB_TOKEN set in your environment?
I can also probably remove this line since it's a public repo.

You're right that was the problem! I removed that line and it fixed the issue.
$ sh install-bud.sh

livebud/bud: checking GitHub for latest version
livebud/bud: found version 0.2.5 for darwin/amd64
livebud/bud: downloading https://github.com/livebud/bud/releases/download/v0.2.5/bud_v0.2.5_darwin_amd64.tar.gz
livebud/bud: verifying checksums
livebud/bud: installed as /usr/local/bin/bud
$ bud

  Usage:
    bud [flags] [command]

  Flags:
    -C, --chdir  change the working directory
    -h, --help   show this help message
    -L, --log    filter logs with this pattern

  Commands:
    build    build your app into a single binary
    create   create a new app
    new      scaffold code for your app
    run      run the dev server
    tool     extra tools
    version  show the current version

Awesome, thanks for reporting this! Fixed in main. Let me know if you run into anything else or have any feature requests!


Revert the location of the setupFolder

Summary of the Pull Request
The change introduced in #3432 will update the path of the setup folder which could change the string used to deduplicates bugs in the ado templates.
This change reverts the path of the setup folder to the original path.

Codecov Report

Merging #3460 (8a23862) into main (ead63eb) will decrease coverage by 3.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3460      +/-   ##
==========================================
- Coverage   34.46%   30.70%   -3.76%
==========================================
  Files         299      135     -164
  Lines       36201    14504   -21697
==========================================
- Hits        12478     4454    -8024
+ Misses      23723    10050   -13673

see 164 files with indirect coverage changes


Native modules compiled incorrectly

Operating system:
OS X 10.11.5
Apex Version:
0.10.2

I'm using apex to deploy my code. However, modules like bcrypt aren't compiled correctly on my local machine for lambda. I'm getting an "Invalid ELF header" error.
Shouldn't there be a way for apex to automatically support connecting to an Amazon Linux EC2 instance to compile and deploy the code?
Am I missing something, because this seems like a very manual and tedious process to do every time that I want to deploy the code?

Lambda function will be ran in Amazon Linux Instance. So you should compile/build native modules on Amazon Linux Instance if you are using apex on Mac. You can make your build pipeline by using hooks.

Yep like @mooyoul mentioned, anything native has to be built on the same platform. For example this is not a problem with Go, because you can cross-compiled on a Mac to the target Linux environment, Node however does not have this features so you're stuck building in CI or in a VM.

Closing for now, it's a good question but unrelated to apex itself. Might be nice to have in the FAQ though

CI resolved this issue for me. 3.5/4 would recommend.

Sorry to comment on a closed issue, I came across this one and had a hard time to come up with a good solution. I wanted something light, without having to setup an entire build system on a Linux box.
I just wanted to share my solution as some people may find it useful. I build my python functions in a Docker container using Docker for Mac.
Then I simply added this hook to my function.json:
  "hooks":{
    "build": "docker run -v $(pwd):/build --rm -w /build python:3.6 pip3 install -r requirements.txt -t .",
    "clean": "git ls-files --directory --others --exclude-standard | xargs rm -rf ; rm -rf __pycache__ ; rm -f *.so"
  }

Then, when you run your apex deploy, the python dependencies are built in a temporary container (which runs on Linux). It allows you to still use apex from your Mac.


[Bugfix][CI/Build] Fix CUTLASS FetchContent

Conflict between https://github.com/vllm-project/vllm/pull/7085 and https://github.com/vllm-project/vllm/pull/7034.
Since the 3.5.1 tag is not out yet, the tag I pointed to is not supported by FetchContent with GIT_SHALLOW.
From https://cmake.org/cmake/help/latest/module/ExternalProject.html

If GIT_SHALLOW is enabled then GIT_TAG works only with branch names and tags. A commit hash is not allowed.

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Actually not sure why this wasn't an issue for landing #7085, b2a03a3cbc13c362e1318d99e0312d927fd16419 was green and I it had the GIT_SHALLOW TRUE line as well.


apk file?

Thank you for sharing your code.
Is there any apk file?

No， you can build it from source code.

Thank you for sharing your code.
Is there any apk file?

No, you can build apk by code.