React storybook

Hi, I successfully integrated react storybook with this project. However there are small discrepancies (mostly in the CSS) because storybook uses its own webpack config, and react storybook generates its own webpack config.
Any Idea on how to make those two work together ?

Maybe use react-story instead? Haha. Sorry. In all seriousness this why
react storybook is kindof a pain. There's effectively no way to use it in
another build system because of its strict requirements of its own crazy
build system.
On Sun, Oct 29, 2017 at 9:45 AM Vincent Lecrubier<EMAIL_ADDRESS>wrote:

Hi, I successfully integrated react storybook with this project. However
there are small discrepancies (mostly in the CSS) because storybook uses
its own webpack config, and react storybook generates its own webpack
config.
Any Idea on how to make those two work together ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/101, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCR7Z0dfn1aUNSMqjwirNf_TIgg5Xks5sxJ2dgaJpZM4QKXD8
.

@crubier maybe react-styleguidist is a good alternative because it feels more flexible at the first sight.

I used react-styleguidist for a while but react-storybook has ten times more github stars and overall support.
I agree with the problems with react-storybook, but it is the leading solution for this matter, and we have to live with it. I have around 100 stories, using storybook addons such as apollo connector and others...
The only thing that would be needed for react-storybook to be compatible with react-static, would be for react-static to export a function that outputs its webpack config. This would allow this kind of config in .storybook/weback.config.js
import exportWebpackConfig from "react-static/lib/webpackXXX"
import reactStaticConfig from "../static.config"
return exportWebpackConfig(reactStaticConfig)

@zsherman

This function that I call getWebPackStaticWebpackConfig already exists internally, I would just need a way to access it as a user of react-static


Duplicate copy of old witness appears when online during a witness change

Two copies of "verbaltech2" appear.
Environment:  Head block #34850 on BitShares main network via bitshares.org/wallet, had the tab open for approximately 3 hours, Firefox on Ubuntu Linux 14.04.
I suspect this bug was triggered by a witness change at 2015-10-14T20:00:00 or so.
Related: #270

Need some guidance on this. It needs to be claimed if it's a valid bug. @valzav can you assist?

I'll have a look but it's a tough one to reproduce which is why it's not been handled yet..


TODO: make buttons better

Extend the timeout a bit and also show when the time is up by making them greyed out.
Fix the reddit ones not working on mobile.

Done the greyed out bit


fix: TOOLS-2979 Include sindex as size

sindex-stage-size must be allowed as humanised form like 128M

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.04%. Comparing base (e1f5e48) to head (14283c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   79.04%   79.04%
=======================================
  Files          14       14
  Lines        1021     1021
=======================================
  Hits          807      807
  Misses        145      145
  Partials       69       69

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


how to convert to base 64 and DATA URI.

controller
$scope.PhotoData = [];
$scope.choosePhotos = function () {
var options = {
maximumImagesCount: 10,
quality: 80,
targetWidth: 1000,
targetHeight: 1000,
};
$cordovaImagePicker.getPictures(options).then(function (results) {
for (var i = 0; i < results.length; i++) {
$scope.PhotoData.push(results[i]);
console.log(results[i]);
        }
    if(!$scope.$$phase) {
      $scope.$apply();
      }
        }, function (err) {
                    // An error occured. Show a message to the user
                });
                };

view code
ion-slide ng-repeat="item in PhotoData"
img ng-src="data:image/jpg;base64,{{item}}" style="max-width: 100%"

I'm having the same problem; the plugin outputs the file in a "content://com.android.providers.media.documents/document/{anything}" path and Android doesn't allow to access files from content:// in order to make it a base64 file

If you guys have solved this I'd like to know how. My solution to draw them on canvas and converting them that way is resulting in huge images

just managed to do this.
might now be the most elegant way
imageBase64 = function (url, callback, outputFormat) {         var canvas = document.createElement('CANVAS'),                 ctx = canvas.getContext('2d'),                 img = new Image;         img.crossOrigin = 'Anonymous';         img.onload = function () {             var dataURL;             canvas.height = img.height;             canvas.width = img.width;             ctx.drawImage(img, 0, 0);             dataURL = canvas.toDataURL(outputFormat); // the base64 data of the image             dataURL = dataURL.substring("data:image/png;base64,".length);             callback.call(this, dataURL);             canvas = null;         };         img.src = url;     }
then
selectedImage.imageBase64(results[0], function (base64Img) {                console.log(base64Img);             });

yes, this works, but the problem with is it you take for example a compressed jpeg and convert it to an uncompressed png, resulting in a double the size of the file or more.

You can use FileReader:
function processImage(file) {
    fileReader = new FileReader();
    fileReader.onload = onload;
    fileReader.onprogress = progress;
    resolveFile(file).then(function(actualFile) {
        fileReader.readAsBinaryString(actualFile);
    });
}

var resolveFile = function(entry) {
    var deferred = $q.defer();
    // first convert to local file system URL
    window.resolveLocalFileSystemURL(entry, function(fileEntry) {
        // now read/convert the file to file object.
        fileEntry.file(function(file) {
            console.log("File converted to file entry");
            deferred.resolve(file);
        }, function(err) {
            console.log("Failed to convert to file entry", err);
            deferred.reject(err);
        });
    }, function(err) {
        console.log("Failed to resolve to file URL", err);
        deferred.reject(err);
    });

    return deferred.promise;
};

var onload = function (evt) {
    var encoded = window.btoa(evt.target.result);
    // now encoded contains the base64 image.
    // note it is without the "header"
    // img.src = "data:image/jpeg;base64," + encoded
};

Initially I tried to use fileReader.readAsDataURL(actualFile); which give you the base64 data in one shot but it resulted in corrupt images. A workaround was suggested with readAsBinaryString() and then window.btoa() and solved it. See SO question here.


Explore converting to PDF with javascript

Currently the only way to convert a notebook to PDF uses latex under the hood, which creates many differences in the appearance of the output doc, and also adds some complexity to the build.
Another option would be to explore using javascript libraries to do this...it seems like an HTML element could be converted to PDF using some version of this code:
https://stackoverflow.com/questions/53985512/failed-to-execute-drawimage-on-canvasrenderingcontext2d

I'm gonna close this one in order to move focus over to https://github.com/jupyter/jupyter-book/issues/267 which I think has some more concrete ideas


[Feature request] Raise exception on Stop Task

I'm not sure if this is within the scope of the project, but would it be possible to raise an exception when the Stop button is clicked (much like you would have a KeyboardInterrupt when a user interrupts the program with Ctrl-C) so you can clean up?

This is a dupe of https://github.com/chriskiehl/Gooey/issues/232. Closing in favor of that issue.
Good news is that I'm actually working on this feature right now ^_^ It's a bit trickier than expected thanks to Windows being Windows, but it should be ready to go soon.
You'll be able to pass in an arbitrary signal to control what happens when you click the stop button. For instance,
@Gooey(terminate_using=signal.CTRL_C_EVENT)

Which could be caught in your app as a KeyboardInterrupt.

That's great news. Thanks!

Hey @fijam   , I've added the ability to customize the stop strategy to the release branch. This'll let you catch when Gooey is doing a force stop. Wanna give it try and let me know if you hit any issues? Getting the signals sorted out on Windows took a fair bit of fiddling, so I'd love to hear if you run into any problems.
Branch: https://github.com/chriskiehl/Gooey/tree/1.0.9-release
You can checkout the docs here: https://github.com/chriskiehl/Gooey/blob/1.0.9-release/docs/Gracefully-Stopping.md
tl;dr: you can now pass a signal to the gooey decorator.
import signal
@Gooey(shutdown_signal=signal.CTRL_C_EVENT)
def main():
   ...

Hi, I tested it quickly and while it seems to work in the sense that except clause is executed (yay!), pressing Yes on the Stop Task modal immediately closes the Gooey window and the except clause continues to run in the background. Is this the intended behavior or a problem between keyboard and chair? It would be nice to communicate to the user that the program is cleaning up (it can take a few minutes for me). Can the window be kept up until the process actually exits?
My environment is Python (3.8.10) on Windows 10 (19043.1110)

Thanks for testing!
Arg.. these are the Windows quirks I mentioned which is making this tricky... Signals get sent to the whole process group, which I thought I was able to ignore in Gooey land, but I guess it's unreliable. So, it's definitely unexpected that Gooey is itself is terminating and not the desired behavior.
Are you seeing the problem when you send the CTRL_C_EVENT or for all events (CTRL_C_EVENT, CTRL_BREAK_EVENT, SIGTERM)?
One option is to change how Gooey spawns the process such that a new ProcessGroup is made. However, what sucks is that, for whatever reason, you can only send CTRL_BREAK signals under that setup, which cannot be caught in the child process via the nicer KeyboardInterrupt exception and instead require a signal handler to be added.

I tested with a handler and CTRL_BREAK_EVENT and looks like it works! Cheers.

I have also noticed that the exception handler does not work in an application built with PyInstaller (4.5) which may be a whole 'nother can of worms.

Ok! I think I've got this a little more pinned down. All signals should work as expected, and none of them should cause the parent Gooey process to inadvertently close. It took trawling through the Python issue tracker to finally figure out that both the Python docs and Microsoft's docs are either outright incorrect, or missing very important info with regards to how signals get handled in Windows. TL;DR: I think we're in good shape (at least on Windows).
Release branch has the latest fixes.
Thanks again for testing! It's super helpful having additional feedback for fiddly OS stuff like this! ^_^

@Duke-Pickle @MrSassyBritches (for visibility, since there was past interest in this issue)

Hi again, I re-tested the updated 1.0.9 release branch and now CTRL_C_EVENT / KeyboardInterrupt works as expected. Nice!
I have also been fumbling around some more with pyinstaller and discovered that building my app in --onedir mode with a default generated .spec file (https://gist.github.com/fijam/d5ef98f365d2ba6c4a3f2984eebc5a61) results in working interrupt signalling. A single executable does not work correctly, but that looks like a pyinstaller bug.

By the way, I see a similar behavior when packaging with cx_freeze: an interrupt works well if there is a console window alongside Gooey, but fails without console shown (base = "Win32GUI"). In the second case, clicking Stop once does nothing, and a second click kills the process without raising an exception.

Hi @chriskiehl I was wondering if this still holds true for a function being called from another script? I'm using the decorator
@Gooey(shutdown_signal=signal.CTRL_C_EVENT)
main():
...

When Gooey parses the arguments, those are sent to another function, and within that function if a user presses stop, I'd like to be able to cut out early, but then still save some results. When doing as @fijam using the combination of  CTRL_C_EVENT / KeyboardInterrupt, but when pressing stop, I get the normal error of data corruption, and nothing after the except clause (within in the function) runs. I'm guessing the except clauses needs to be on the outside of the function being called?


CNV-28953: Virtualization Settings section enhancements - part 1

📝 Description
Changing Overview -> Settings tab layout and adding a new section to opt-in and out of the IT feature.
related UX doc
Jira issue
🎥 Demo

/lgtm


Bump candiedyaml

As suggested in #173, I fixed the underlying issue in candiedyaml that was causing certain strings to be incorrectly parsed as maps. Since then I've also noticed that libcompose fails to parse strings that begin with a colon, so I put in a PR to address that issue too.
This bump includes both of the fixes, so libcompose shouldn't run into those parsing problems anymore.
Signed-off-by: Josh Curl<EMAIL_ADDRESS>

LGTM 🐼


feat: simplify eval_results.json

Implement #95
new format of eval_results.json is like:

(set --test_details to fetch all failed test cases)

Closes #95


Update Python test matrix (drop EOL Pythons and add new ones)'

Python 2.6 and 3.3 are EOL. They are no longer receiving bug fixes,
including for security issues. Python 2.6 went EOL on 2013-10-29 and
Python 3.3 went EOL on 2017-09-29. For details, see:
https://devguide.python.org/#status-of-python-branches
Additionally, the latest pytest release dropped support for these Python
versions. This change is causing CI failures for Python 2.6 and 3.3. For
details on the pytest changes, see:
https://pytest.readthedocs.io/en/latest/changelog.html#pytest-3-3-0-2017-11-23
For additional discussion on why project maintainers may wish to drop
Python 2.6 support, please see:
https://snarky.ca/stop-using-python-2-6/
http://www.curiousefficiency.org/posts/2015/04/stop-supporting-python26.html
Reduces testing resources.

Since this PR originally went up, there have been new Python releases and now Python 3.4 is EOL. I have updated the test matrix to test all new Pythons.


Cannot install because these package versions have conflicting dependencies.

What is the correct version number please? Below is the error message：
ERROR: Cannot install -r requirements.txt (line 4) and torch==1.9.1 because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested torch==1.9.1
torchvision 0.8.2 depends on torch==1.7.1
To fix this you could try to:

loosen the range of package versions you've specified
remove package versions to allow pip attempt to solve the dependency conflict

Sorry for the inconvenience, currently I am trying to complete the setup.py file and make pypi installation available.
The version conflict is due to some legacy issues. I solve it manually by:
$ pip install torchvision==0.8.2 --no-deps

很抱歉给您带来不便，目前我正在尝试完成 setup.py 文件并使 pypi 安装可用。 版本冲突是由于一些遗留问题。我通过以下方式手动解决它： $ pip install torchvision==0.8.2 --no-deps
Thank you for your reply, the problem has been solved, can I ask you by the way, do you need to send real international mail to apply for the UDIVA dataset? Or just need an email? I have some doubts after looking at the application requirements for this dataset

On its official web https://chalearnlap.cvc.uab.es/dataset/41/description/#
Stated as:

The UDIVA v0.5 dataset is available upon request. Users will have access to the dataset after the Dataset License has been signed and returned to the dataset administrators.
Researchers interested in participating in the ChaLearn LAP Understanding Social Behavior in Dyadic and Small Group Interactions Challenge at ICCV 2021 may find the Challenge-Oriented Dataset License in the Codalab platform (please, check the instructions here).
Researchers interested in using the dataset for research purposes other than the challenge are requested to fill in the UDIVA v0.5 General-Purpose Dataset License.

And you need to connect the dataset owner following the links provided above


refactor: remove unused class imports

It's likely that most of the classes are autogenerated, if that is the case then please ignore and close this pr.
Modifications
This PR removes all the imports that are not used.

most change under libra.types and novi are generated code, should fix original code generator instead of generated code, as next time we generate code, they will be added again.


Add a Gitter chat badge to README.md

typesafehub/config now has a Chat Room on Gitter
@havocp has just created a chat room. You can visit it here: https://gitter.im/typesafehub/config.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Hi @gitter-badger,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:
http://www.typesafe.com/contribute/cla

Doing this differently, but thanks bot for the patch.


Questions about how to use different clock domain?

Do I need do trace_process again, after I set this setting at config and get pftrace file?

Another question is that I do not know how to check this setting is enable or not , after I apply primary_trace_clock?

I want to change to BUILTIN_CLOCK_MONOTONIC_RAW, not default boot time.
primary_trace_clock  :   I noticed that this setting.

So I add below setting to my cocfig file.

builtin_data_sources: {
primary_trace_clock: BUILTIN_CLOCK_MONOTONIC_RAW
}

Does Trace Package need to re-build as a config? (Example I found from perfetto doc)

I want to change "timestamp_clock_id" of package.

protoc --encode=perfetto.protos.TraceConfig
-I. protos/perfetto/config/perfetto_config.proto
< config.txpb
> config.bin

Do I need do trace_process again, after I set this setting at config and get pftrace file?

Well it will be a new trace so yes.

Another question is that I do not know how to check this setting is enable or not , after I apply primary_trace_clock?

You need to recollect the trace. The trace will have the option set if it is present in the config.

Does Trace Package need to re-build as a config? (Example I found from perfetto doc)

If you are passing the config as a binary proto, then yes.


client: improve multi-client output

@robertgzr do you have an example of what the output looks like with this fix you've made

@robertgzr @vipulgupta2048 looks good to me


[8.0.0] Client-side code being accessed by server causes crashes

Previously the sound error: https://github.com/aidancbrady/Mekanism/issues/2223
now this one: http://paste.fedoraproject.org/199748/26707473/

sorry, forgot to copy the URL, fixed it.

^That's the BuildCraft API issue crash, I think you got the wrong link.

oops

fixed the original comment

Hmm, that's odd. getRenderType shouldn't be called on the server side, I'm pretty sure, but it's not @SideOnly(Side.CLIENT)ed in the Block source, so I guess that is our issue?
...5 minutes later...
I've just had a look at EU's issue tracker, multiple people have reported this to RWTema, and apparently it's used by the vanilla server. I'll move it to not be client-only in Mekanism code, then.

Is there an alternate solution or was there code for that that WAS set to client only that was causing a crash?

Our getRenderType() was assuming it was only going to be called on the client side, and was referencing our ClientProxy class (which is client side-only), so causing crashes on the server-side when EU called getRenderType() on the server side. I've now moved the fields it was referencing to the common proxy, which is available on the server side.

Solar panels did it too.
should probably go through all the machines and make sure your fix gets applied
@unpairedbracket

when i place machines in the world that make noise, it crashes server

Yeah, I'll go through them all and check. Thanks for helping us smooth all this over before release.

Fixed Generators, and an issue with reactor controllers. Let me know if you find any more

oh i dont mind, I really like mekanism ;D

Closing as I don't see where else this could mess up.  If it does, though, please comment here and I'll reopen!


Cleanup QPACK comment in the code: Required Insert Count

I assume this the comment refers to this section.

Merged, thank you @kachayev!


Skip re-checking ACME account status if Issuer is ready and URL hosts match

What this PR does / why we need it:
This PR updates the ACME setup function to only verify the ACME account when the Ready condition is not currently True, or the Host part of the acme server URL does not match the registered acme account URL.
In future, we can look at storing a hash of either the private key or something else in order to re-check more frequently.
cc @jsha
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1013
Release note:
NONE

Why not just delete the part of registerAccount that verifies the account exists? I think that would be a better solution to this problem and more likely to reliably work.

Assuming you are talking about this line/API call here: https://github.com/jetstack/cert-manager/blob/04deb186b5937b2ece2bba56aa698ee0a0678d73/pkg/issuer/acme/setup.go#L181
This would reduce the number of API calls per call to Setup by one for every two (i.e. 50%), however from what I understand of the issue here, the issue is not that we make two calls, the issue is that we make any calls more than once.
Previously, we would call GetAccount each time Setup was called, regardless of the 'status' of the Issuer. This should mean that we only call GetAccount each time the Issuer resource changes, however, as we've found, there are some cases where Setup can be called despite the Issuer not having changed.
In order to properly stop us making API calls after we already have verified the account with the server, this patch implements a check to see if the 'issuer.status.acme.url' (i.e. the acme account URL) is already set. If it is already set, we will no longer make any API calls to the ACME server.
These extra lines here, where we parse the account URL as well as the server URL, are important in order to handle the case where a user updates an Issuer resource with a new ACME server address (i.e. switching staging to prod). Without this check, we would not call Register again to register the account with the ACME server: https://github.com/jetstack/cert-manager/blob/04deb186b5937b2ece2bba56aa698ee0a0678d73/pkg/issuer/acme/setup.go#L125-L146
Hope that clears up the justification for why it is implemented in this way. Simply removing the call to GetAccount would halve the number of requests, however it wouldn't solve the underlying issue of "Don't re-verify the ACME account after initial creation".

This would reduce the number of API calls per call to Setup by one for every two (i.e. 50%), however from what I understand of the issue here, the issue is not that we make two calls, the issue is that we make any calls more than once.

That's true, but a natural consequence of this is that registerAccount should only ever be called once, and should therefore not contain a call to GetAccount.
Structurally, my objection to this PR is that it is too complex, and I think is likely to lead to more bugs, and ones that are hard to diagnose. Also, the needsRecheck function (which should really be called needsAccountCreation) defaults to "call the API" when it should default to "error out and inform the user."
For instance:
			glog.V(4).Infof("Failed to parse existing ACME account URI %q - "+
				"re-validating ACME account registration: %v", rawAccountURL, err)

This is an internal error in cert-manager -- somehow it stored an invalid account URI. It should not result in revalidating.

			glog.V(4).Infof("Failed to parse existing ACME server URI %q - "+
				"re-validating ACME server registration: %v", rawServerURL, err)

This is also an internal cert-manager error and should not send traffic to the server.
Here's the conceptual framework I would like to see:

On first run, create an account.

If successful: store the private key and account URL.
If failed: store an error result; if there are three error results give up until user intervention. For instance, if the user enters an invalid email address, this will error forever; don't keep trying.

On subsequent runs, if a private key and account URL exist, just start using them. If there is an error reading the private key, or an error parsing any URLs, give up until user intervention.

That's true, but a natural consequence of this is that registerAccount should only ever be called once, and should therefore not contain a call to GetAccount.

+1, my thinking for the GetAccount call before RegisterAccount was to handle the case where a user is migrating their account to cert-manager, and it already exists. I am fairly sure however, that RegisterAccount will return the existing account in this case anyway, so I'll remove this check.

Structurally, my objection to this PR is that it is too complex, and I think is likely to lead to more bugs, and ones that are hard to diagnose. Also, the needsRecheck function (which should really be called needsAccountCreation) defaults to "call the API" when it should default to "error out and inform the user."

I'll update the PR to not default to calling the API, and instead erroring and surfacing the error to the user in the event the either the server URL or account URL are invalid. That should result in no API calls in these instances 😄

If failed: store an error result; if there are three error results give up until user intervention. For instance, if the user enters an invalid email address, this will error forever; don't keep trying.

Your expected behaviour makes perfect sense to me 😄 however I think this particular point may be a bit more complex to implement, especially in a patch like this that is intended to be back-ported. With #981 too, in the case of a user entering an invalid email, we will enter a retry loop with an exponential back-off applied capping at every 1 minute.
Is it possible for us to assume a BadRequest (i.e. 400) response code means that the error is due to either an invalid email or private key? If so, I can add a check for 400 errors, surface the error to users and not retry again in these instances quite easily, which would save us retrying bad requests every minute 😄

Sorry for the delay getting this PR through - we've had our company off-site last week and so am only just back at the keyboard full time! This is my top priority for the week, and once merged we can get it cherry picked (along with some of the other fixes we've had over the last week or so) and cut v0.5.1 😄

+1, my thinking for the GetAccount call before RegisterAccount was to handle the case where a user is migrating their account to cert-manager, and it already exists. I am fairly sure however, that RegisterAccount will return the existing account in this case anyway, so I'll remove this check.

So after digging into the underlying ACME client library, I've found that this is in fact not the case in the Golang implementation of acme: https://github.com/jetstack/cert-manager/blob/ae6f14c83c6c1f2ca2dd5126c991d5aef961e47f/third_party/crypto/acme/acme.go#L354
The third parameter to doAccount (getExistingWithKey) is set to false when CreateAccount is called. As doAccount is not exported, it is not possible for me to set this to true during the CreateAccount call. Therefore, if we remove the call to GetAccount, it won't be possible for users to use an existing account. This sounds like an edge case, but actually can happen whenever a user deletes and then re-creates their Issuer resource (as this is where we store the account URL/state about the private key).
Users shouldn't do this very often, but during debugging they often will delete and re-create things. We can't really drop this behaviour, so for the time being we'll have to leave this additional call to GetAccount in there.
That said, with these changes, this method should only be called once anyway which should help considerably 😄
I've updated the PR with the changes mentioned in my previous comment 😄


Add lang utils - helps lint and format lang term additions and changes

Adding a couple commands my team has taken advantage of across our repos. Helps reduce painful copy/paste exercises as well as catches any missing lang terms across files. Let me know if you have any concerns. We have used this for awhile on my team with no issues.
This PR:

adds the commands for formatting/linting
I ran npm run format:lang which sorted all the lang terms alphabetically (no changes have actually been made)
Adds util for checking for unused lang terms - warns user so they can double check and manually delete

Still getting unused check working... not ready quite yet.

Output of npm run lint:lang-unused-check. Util will not actually error out or delete anything, will just warn user so they can double check and manually delete.

I can open a separate PR deleting unused terms if this is approved to be merged.


added new types and corrected transactions for dai to xdai

Added all the types used in ethereum and updated the card to show the correct transaction

Fixes #124

@farrahfazirah your layout is here, the functionality cannot be completed yet however.

@James-Sangalli I noticed the .shtml file doesn't validate. I remember Weiwu thinks that developers can write well-formed HTML :P

Completes https://gist.github.com/hboon/7be08b075e3f1b43fe979bc7c0681d64


Mongock build AOT fail in Spring Boot 3.0.1

Description
Mongock build AOT fail in Spring Boot 3.0.1
Mongock

        <groupId>io.mongock</groupId>
        <artifactId>mongock-springboot-v3</artifactId>
        <version>5.2.1</version>
    </dependency>
    <dependency>
        <groupId>io.mongock</groupId>
        <artifactId>mongodb-springdata-v4-driver</artifactId>
        <version>5.2.1</version>
    </dependency>

Environment

Spring boot 3.0.1, graalvm-ce-17(version 17.0.5)

Steps to Reproduce

Run cli mvn spring-boot:process-aot

Behaviour
Actual behavior:
Constructor binding in a native image requires compilation with -parameters but the following classes were compiled without it:  	  io.mongock.driver.mongodb.springdata.v4.config.MongoDBConfiguration$WriteConcernLevel
Link to repository using Mongock
[While not mandatory, accessing to the real code that uses Mongock, would help to solve the issue]
Additional context
Log

.   ____          _            __ _ _
/\ / ' __ _ () __  __ _ \ \ \
( ( )__ | '_ | '| | ' / ` | \ \ \
\/  )| |)| | | | | || (| |  ) ) ) )
'  || .__|| ||| |_, | / / / /
=========||==============|/=////
:: Spring Boot ::                (v3.0.1)

11:59:21.451 [main] INFO  vn.dolenglish.exercise.Application - No active profile set, falling back to 1 default profile: "default"
11:59:22.035 [main] INFO  o.s.d.r.c.RepositoryConfigurationDelegate - Bootstrapping Spring Data MongoDB repositories in DEFAULT mode.
11:59:22.068 [main] INFO  o.s.d.r.c.RepositoryConfigurationDelegate - Finished Spring Data repository scanning in 30 ms. Found 8 MongoDB repository interfaces.
11:59:22.358 [main] INFO  o.s.cloud.context.scope.GenericScope - BeanFactory id=a4ba64fd-1372-3075-bf0e-03f8404705bc

Constructor binding in a native image requires compilation with -parameters but the following classes were compiled without it:
io.mongock.driver.mongodb.springdata.v4.config.MongoDBConfiguration$WriteConcernLevel
at org.springframework.boot.context.properties.bind.BindableRuntimeHintsRegistrar.registerHints(BindableRuntimeHintsRegistrar.java:87)
at org.springframework.boot.context.properties.ConfigurationPropertiesBeanFactoryInitializationAotProcessor$ConfigurationPropertiesReflectionHintsContribution.applyTo(ConfigurationPropertiesBeanFactoryInitializationAotProcessor.java:70)
at org.springframework.context.aot.BeanFactoryInitializationAotContributions.applyTo(BeanFactoryInitializationAotContributions.java:78)
at org.springframework.context.aot.ApplicationContextAotGenerator.lambda$processAheadOfTime$0(ApplicationContextAotGenerator.java:58)
at org.springframework.context.aot.ApplicationContextAotGenerator.withCglibClassHandler(ApplicationContextAotGenerator.java:67)
at org.springframework.context.aot.ApplicationContextAotGenerator.processAheadOfTime(ApplicationContextAotGenerator.java:53)
at org.springframework.context.aot.ContextAotProcessor.performAotProcessing(ContextAotProcessor.java:106)
at org.springframework.context.aot.ContextAotProcessor.doProcess(ContextAotProcessor.java:84)
at org.springframework.context.aot.ContextAotProcessor.doProcess(ContextAotProcessor.java:49)
at org.springframework.context.aot.AbstractAotProcessor.process(AbstractAotProcessor.java:82)
at org.springframework.boot.SpringApplicationAotProcessor.main(SpringApplicationAotProcessor.java:76)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.577 s

Hello, we need to take a look to this in detail, but I bet is related to the conflict between Mongock using reflection and Graal Naive AOT compilation.
Although that's something will support in the next version, Mongock currently doesn't provide explicit support for AOT.
Anyway, we'll keep you updated as this is something that we need to address soon.

@nhandev552 if you can build a small project we can access via github and try ourselves would help a lot. Thanks

Hello @nhandev552 , could you provide that, so we can help you  faster?

Hi, @dieppa thanks for supporting.
The simple project to reproduce: https://github.com/nhandev552/mongck-with-aot.
I worked around by clone mongodb-springdata-v4-driver source code and adding @NestedConfigurationProperty on the field io.mongock.driver.mongodb.springdata.v4.config.MongoDBConfiguration.WriteConcernLevel, building AOT works well

Thanks @nhandev552, for the project. We'll let you know soon.
Anyway, If you thing that it's a workaround that is valiable for now, you may want to create a PR and we can take a look.
Thanks!!

Even after the changes proposed, I still have issues with Mongock. Mongock works fine when the same app runs on JVM, unfortunately, the GraalVM build has the following issues. For some reason MongoSync4ChangeEntryRepository#getEntriesLog doesn't return any result. I've tried registering native hints for MongoDB Document, FindIterable, but it didn't help. The other issue is that MigrateExecutorBase#fetchAndPrepareChangeLogs doesn't return any result, even though I've registered all changelogs in native hints as well.

Sorry, we under estimate it, not because it's complex, we know what we need to do, but because we have a lot in our plates. We expect to have it soon, but I prefer notify you when it is ready.

We wanted to provide official support in the next major release. However, this is getting more and more attention and we won't be able to contain it much longer. So we have decided to provide a decent workaround to allow you guys to carry on working and add it in the next release as part of the core.
We did a POC to check the work needed and we are confident in releasing the workaround soon.

Hello @mathieuales , @Rocker93 and @nhandev552 , sorry for the delay.
As  mentioned, we'll provide official support with a proper solution in the next major release, however, as there is a clear demand for this, we have release a workaround with the expectation you can carry on working until the official GraaVM support is released.
We have create an example that you can pull form this repo.
Please let us know if you find anything or you need some help.
Thanks for the patience.

hello,
what is the current state @dieppa ?

In the next major release we'll provide official support, but it won't be in this first quarter. Probably, starting Q2


Question: is it possible to use ghostunnel without CA?

Hi,
I have newbie question. I have read the documentation (https://github.com/square/ghostunnel) but  I will happy for the clarification: Is it possible to use ghostunnel without CA?
I have 2 servers, and I need to start ghostunnel in the server mode on one server and in the client mode on other server.
I want to generate PKI key pair on each server, to exchange public keys between servers and to add these public keys into trust store on each server respectively.
Is it supported?
Do you have commands example?

You can use self-signed certificates for this, sure.
Unfortunately I do not have an example for how to generate those. Once you have a self-signed server.crt and .key, along with a self-signed client.crt and .key, you can do something like this:
server ... --cert=server.crt --key=server.key --cacert=client.crt
client ... --cert=client.crt --key=client.key --cacert=server.crt

Thanks!

@mcpherrinm, I was able to configure ghostunnel without CA and have published it here:
https://ultimatesecurity.pro/post/ghostunnel/


Show Torn nicknames instead of Discord names

Need to show Torn names instead of Discord names so we know who we're talking about. For example Tyrael is actually bloodsheder

Fixed by a4fc3106cf510cae5e21fd04493586894b705d04


[New API] : Lung Cancer Survival Months Predictor API

Brief Description 🤓
The API will allow to predict survival months for Lung Cancer using Linear Regression Algorithm.
How will you develop it?🤩
The API will be build in JavaScript in the NodeJS environment. The data is added into the API. The Linear Regression algorithm will train the data and will predict the survival months for the input data.
Deployment
None
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

/gssoc24

Greetings @SatwikMohan🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣


pdctl: config should show replication config

Please answer these questions before submitting your issue. Thanks!

What did you do?
pdctl show config.

What did you expect to see?

also see
....
location-labels: "zone, host"

What did you see instead?

pd-ctl>> config show
{
  "max-snapshot-count": 3,
  "max-pending-peer-count": 16,
  "max-merge-region-size": 0,
  "max-merge-region-keys": 0,
  "split-merge-interval": "1h0m0s",
  "patrol-region-interval": "100ms",
  "max-store-down-time": "30m0s",
  "leader-schedule-limit": 40,
  "region-schedule-limit": 40,
  "replica-schedule-limit": 8,
  "merge-schedule-limit": 8,
  "tolerant-size-ratio": 5,
  "low-space-ratio": 0.9,
  "high-space-ratio": 0.6,
  "disable-raft-learner": "false",
  "disable-remove-down-replica": "false",
  "disable-replace-offline-replica": "false",
  "disable-make-up-replica": "false",
  "disable-remove-extra-replica": "false",
  "disable-location-replacement": "false",
  "disable-namespace-relocation": "false",
  "schedulers-v2": [
    {
      "type": "balance-region",
      "args": null,
      "disable": false
    },
    {
      "type": "balance-leader",
      "args": null,
      "disable": false
    },
    {
      "type": "hot-region",
      "args": null,
      "disable": false
    },
    {
      "type": "label",
      "args": null,
      "disable": false
    },
    {
      "type": "evict-leader",
      "args": [
        "4"
      ],
      "disable": true
    },
    {
      "type": "evict-leader",
      "args": [
        "1"
      ],
      "disable": true
    },
    {
      "type": "evict-leader",
      "args": [
        "6"
      ],
      "disable": false
    }
  ]
}

What version of PD are you using (pd-server -V)?
2.1.1

pd-ctl config show replication and pd-ctl config show all command display replication configs, do we need it in pd-ctl config show?

@b41sh  Yes, I think config show should show scheduler config along with replication config, the two configs are important.


Raise syntax no longer accepts comma-separated arguments in python3

@montiniz could you add test for it? I suspect we didn't catch that before because there wasn't any test for this before.

ready for review.
not sure why pypy fails. i'm not getting that on my pc.

Hi @montiniz . I've restarted tests. We will see how they will go.

Thanks @montiniz ! Tests are passing I've merged that.


Dashboard configuation API/CLI

Is there anyway I can dynamically configure new Dashboards via REST API or any CLI options ?

We do not provide any specific API for this through "Insights" product. You will need to use Grafana API and should work.

Closing this issue as there are no more comments on this.


added citation to README.md type =  inproceeding

these are the changes
@inproceedings{"Microsoft Research, Redmond WA USA",
  author       =  {Wu Qingyun, Bansal Gargan, Zhang Jieyu, Wu Yiran, Zhang Shaokun, Zhu Eric, Li Beibin, Jiang Li, Zhang Xiaoyun, Wang Chi},
  title        = {AutoGen: Enabling Next-Gen LLM Applications via Multi-Agent Conversation Framework},
  booktitle    = {ArXiv preprint arXiv:2308.08155},
  year         = {2023},
}

Why are these changes needed?

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Closing this PR considering the existence of #43.


Release Flatcar Container Linux 3033.3.0 for LTS-2022

Release Flatcar Container Linux lts-3033.3.0
The release of Flatcar Container Linux 3033.3.0 is planned for May 5th/6th, 2022.
Tasks

[x] Go / No Go tracking folder created, tracking doc added: https://hackmd.io/0o9ilUkXSbCLZdehyaKqVA?view
[x] All planned changes are merged & blocker bugs are fixed (@pothos)
[x] Tag build branch (@pothos)
[x] Generate manifest (@pothos)
[x] Start Jenkins builds (@pothos)
[x] Test status captured in test status tracker
[x] All tests are green (@pothos)
[x] Archive TAP report, create Go / No Go doc (TAP report includes unrelated failures)
[x] Release notes / announcements added to Go/No Go doc (@pothos)
[x] QA: check diff for image file list, packages, and image size (@pothos) [found that there was no networkd.conf drop-in file for disabling foreign route management → rebuilding]
[x] Matrix Go/No Go meeting (inc. release notes review) (@pothos)
[x] Manifest release created on GitHub (@pothos)
[x] Images uploaded (@pothos)
[x] Run the os/release job (@pothos)
[ ] Publish EC2 Marketplace Images (@sayanchowdhury)
[x] Azure offer updated & publishing started (@dongsupark)
[x] Azure Go Live (@dongsupark)
[ ] GCP offers updated (@sayanchowdhury)
[x] Update payload signed/published (@pothos)
[x] Symlink to "current" updated (@pothos)
[x] Website updated (@pothos)
[x] Update CloudFormation templates (@pothos)
[x] Release package published in Nebraska (@pothos)
[x] Send announcement to Mailing Lists, and tweet out! (@pothos, @ahrkrak)

Restarted tests:

Packet arm64: because of timeout
Packet amd64:  coreos.auth.verify cl.ignition.v2.xfsroot cl.update.reboot because auf timeout/kernel warning arch/x86/kernel/apic/ipi.c:68 native_smp_send_reschedule+0x34/0x40
AWS arm64: cl.cloudinit.basic kubeadm.v1.23.4.flannel.base because of timeout

(arm64 qemu_uefi update test can't run because there was no previous LTS arm64 release)

The TAP summary has wrong entries but all tests have passed except the Packet arm64 test which is still running (takes ~10 hours).

Found an issue when doing FILE=flatcar_production_image_contents.txt FILESONLY=1 CUTKERNEL=1   CHANNEL_A=stable CHANNEL_B=lts ~/kinvolk/flatcar-build-scripts/package-diff  3033.2.4  3033.3.0, rebuilding now and will check that the missing networkd.conf.d drop-in file shows up then.

Sayan posted the last state for the GCP offer update in Matrix:

I've created the Flatcar LTS Product on the GCP, and uploaded a deployment package based on Flatcar LTS 3033.3.0. It's running the validating tests. Let's see how it goes

@sayanchowdhury Can we close this?


Modularize the project

This PR closes #237 .

Nice work @Adyasha8105. I would suggest you give some more PRs later to update the branch since we will be having some more updates for the pages over the next few weeks

Nice work @Adyasha8105. I would suggest you give some more PRs later to update the branch since we will be having some more updates for the pages over the next few weeks

Ya ofcourse I will do it.


Comments are getting shifted on imports

I believe #1562 introduced a regression for us in jupyter-server/jupyter_server_terminals@b536f62 (#73).
We had formerly used:
from jupyter_server.prometheus.metrics import (  # type:ignore[attr-defined]
    TERMINAL_CURRENTLY_RUNNING_TOTAL,
)

But it now gets mangled to:
from jupyter_server.prometheus.metrics import (
    TERMINAL_CURRENTLY_RUNNING_TOTAL,  # type:ignore[attr-defined]
)

Which results in a mypy error.

Thanks! Will take a look.

Looks like it was introduced in #1380.

I'll fix this today (but probably not for a few hours).

No worries, we have a work-around for now.  Thanks!

Thanks for filing :)

\cc @squiddy in case he gets to it first

Thanks again!


Power_Of_Two.cpp

Example 1:
Input: n = 1
Output: true
Explanation: 20 = 1
Example 2:
Input: n = 16
Output: true
Explanation: 24 = 16
Example 3:
Input: n = 3
Output: false

Kindly merge this code


WINC1500 Support

This is a takeover of the PR #60
With proper style applied, all unaccepted part removed, and further improvements on top.
There will be a proper wifi control interface (via net-mgmt) worked out.
Note: do not merge, this has not been fully tested as the hardware is missing (panther board is not sold, has old winc1500 firmware, etc...)

I still don't get why github shows the commit in the wrong order...

I'm going to close #60 than, since this takes it over.

Btw, I hope interested parties are aware that WINC1500 supports proper L2 integration mode (Ethernet emulation, as common), so could be integrated without NET_OFFLOAD hacks. (Just a FYI note.)

@pfalcon I noticed it, looking at the HAL. However, that won't fit with future work bringing wifi generic net_mgmt interface. Also, in future, we could make the net stack building only the bare necessary parts when there would be only offloaded interface(s), to reduce the amount of code on host side. Such a thing we could not do if winc1500 appears as an ethernet interface.

@SebastianBoe Thanks, indeed works just fine.

@SebastianBoe  I applied your changes btw.

@tbursztyka : Please treat my +1 as a 0. I did not mean to affect the merge-ability, only give some feedback.

@SebastianBoe ok

I'll remove this TEST patch, which is not meant to get in the tree anyway.

Codecov Report

Merging #4711 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4711   +/-   ##
=======================================
  Coverage   54.31%   54.31%
=======================================
  Files         444      444
  Lines       42179    42179
  Branches     7995     7995
=======================================
  Hits        22911    22911
  Misses      16060    16060
  Partials     3208     3208

Impacted Files
Coverage Δ

include/net/net_if.h
54.66% <ø> (ø)
:arrow_up:

subsys/net/ip/net_if.c
55.07% <ø> (ø)
:arrow_up:

subsys/net/ip/net_mgmt.c
71.75% <ø> (ø)
:arrow_up:

subsys/net/ip/net_private.h
35.71% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43bc304...012a344. Read the comment docs.

This needs license review by TSC & board as its pulling code into ext/

@galak there are already ASF components into ext/hal. Does that mean that everytime a bit of code goes to ext/hal it needs to go through TSC? (First time I play in that ext field, so just asking)

@galak there are already ASF components into ext/hal. Does that mean that everytime a bit of code goes to ext/hal it needs to go through TSC? (First time I play in that ext field, so just asking)

Yes, we haven't been great about this, but any new import of code int EXT needs to go through the TSC and board for license review.

@nashif See 13th commit of this PR. (I guess it won't need to be applied though?)

@nashif See 13th commit of this PR. (I guess it won't need to be applied though?)
thanks, I submitted this for review.

Any reason not to pull in the 3.39 release of asf?  Also can we add somewhere in the readme where the code we are pull in is coming from inside of ASF since its a pretty large package (ie some comment about grabbing code from ./common/components/wifi/winc1500/drivers + whatever else we need to import).

Any reason not to pull in the 3.39 release of asf? Also can we add somewhere in the readme where the code we are pull in is coming from inside of ASF since its a pretty large package (ie some comment about grabbing code from ./common/components/wifi/winc1500/drivers + whatever else we need to import).

ASF is changing of minor version pretty fast (and this export dates already from last December), but the big issue is they change their API minor version after minor version. When I did the switch to 3.35 I had to change all the relevant code coming from legacy PR, which was not a small task.  etc... no logic changes at all.) So it works with 3.35, let's just keep it that way.

this has been approved by the board now.

@galak  can you unlock the PR?

@tbursztyka

Also can we add somewhere in the readme where the code we are pull in is coming from inside of ASF since its a pretty large package (ie some comment about grabbing code from ./common/components/wifi/winc1500/drivers + whatever else we need to import).

can you address this please?

updated.


Add FunctionalIntegrationTestCase class and extensions, plus example articles_controller_integration_test

This PR aims to create a parallel new class for our functional tests that inherits from ActionDispatch::IntegrationTest instead of ActionController::TestCase.
It also includes an example integration-style controller test, for Articles, which attempts to exactly duplicate the existing controller test, in parallel. It's called articles_controller_integration_test.rb
Here are the new files added:
- test
-- functional_integration_test_case.rb
-- controller_integration_extensions.rb
-- controllers
--- articles_controller_integration_test.rb

Revised files
- app
-- controllers
--- application_controller.rb (adding a line to include ObjectLinkHelper at the top)
-- helpers
--- object_link_helper.rb (adding the new object link methods)
- test
-- test_helper.rb (requiring the new files above in the list of test cases and extensions)

So far, so good. (The integration-controller test runs in 8 seconds, just like the controller test it's based on!)
All tests in the new articles_controller_integration_test are green in this branch, except one assertion in test_update.
Here's that part of the revised method.
    # Prove removing title provokes warning
    params[:article][:title] = ""
    patch(article_path(params))
    # NOTE: The flash text seems to give all possible messages at once.
    #
Successfully updated article #788338338.

No changes made.

Title Required

    assert_flash_text(:article_title_required.l)
    assert_equal(edit_article_path(params), path)
    assert_form_action(action: :update) # "edit" form

(Note that with CRUD resources/paths, you PUT or PATCH to the article_path(params) to update the article, as shown in rake routes for articles currently.)
Here's the error message:
        Flash text incorrect.
        --- expected
        +++ actual
        @@ -1 +1 @@
        -"
Title Required
"
        +"
Successfully updated article #788338338.

No changes made.

Title Required
"
        test/flash_extensions.rb:84:in `assert_flash_text'
        test/controllers/articles_controller_test.rb:220:in `test_update'

I wonder if maybe the integration test is reporting the actual response accurately?
Maybe someone who is an actual admin can try removing the title of an article, and see what flash response you get in the wild.

Coverage decreased (-0.5%) to 91.662% when pulling 7d4f9d45b9db259582cccfdb566b994b3f273a51 on nimmo-controller-integration-tests-09-20 into 09c731a438d1e80389aaec0e92d7b241f385caab on master.

Copied from email - Joe has tested the edit-article form in the wild and he does NOT get multiple flash messages.
Hmm.

Nimmo: I probably won't have time to dig into this until Fri.
I did notice that the gems are out of date:
vagrant@ubuntu-focal /vagrant/mushroom-observer (nimmo-controller-integration-tests-09-20)
$ rails lang:update
Could not find proper version of railties (<IP_ADDRESS>) in any of the sources

master is on railties 5.2.6

Thats weird. I forked this branch straight off Master yesterday. I did not edit railties version afaik.
Feel free to edit the gemfile and bundle install again!

On Oct 11, 2021, at 6:21 PM, Joseph D. Cohen @.***> wrote:
Nimmo: I probably won't have time to dig into this until Fri.
I did notice that the gems are out of date:
@.*** /vagrant/mushroom-observer (nimmo-controller-integration-tests-09-20)
$ rails lang:update
Could not find proper version of railties (<IP_ADDRESS>) in any of the sources
master is on railties 5.2.6
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Disabling Note Splash RGB in general.

Describe your problem here.
I want to know how to make certain note splashes not use the RGB Shader used in the engine.
Like if a note splash is not meant for RGB like the example below, then I want to disable it at all times.
If anyone can tell me how I can do this in source, I thank you.
(P.S. It's supposed to be a note splash that's unselectable in the visual and ui settings. And the version is v0.7.1h.)

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Not Anything Major.

ok


Remove runtime dependency on activesupport

This PR removes the undeclared runtime dependency on the present? method from Active Support. It changes the semantics of a field's deprecated attribute slightly to now consider fields with non-null, blank deprecation reasons as deprecated. This matches the behavior of graphql-ruby introspection so it's probably a good change anyway.
Unfortunately Active Support is loaded when running tests so it's pretty hard to ensure this won't break in the future. In theory Active Support core extensions shouldn't be loaded by default via a require 'active_support' but in reality there's a dependency chain from ActiveSupport::TestCase to ActiveSupport::XmlMini_REXML to active_support/core_ext/object/blank. Longer term it might be worth removing the Active Support test dependency to ensure this doesn't break.
Fixes #28.

Thank you :)


[OCCM] Restore the previous name for e2e-conformance job

What this PR does / why we need it:
The job name is still used in https://github.com/kubernetes/test-infra/blob/master/config/testgrids/kubernetes/sig-cloud-provider/openstack/config.yaml, this PR changes the job name back (but using the new job definition, see here) to avoid test-infra change.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/test cloud-provider-openstack-acceptance-test-e2e-conformance

/lgtm
/approve
Just the name change


Question: Is there a mobile application?

We are considering OpenDuty because PagerDuty turns out prohibitively expensive.

Is anyone aware of a good alternative? Is the mobile web interface or Slack integration a good enough replacement?

@amosshapira Sort of.  You can configure push notifications via PushOver (a paid application that you have to configure.)  You can also make your OpenDuty site internet facing which allows integration via browser on mobile devices.


⚠ ClamAV has degraded performance

In b31cf9c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in 6a2f716.


Add indent to the ignore comment

Closes #206

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Great! Could you add a test for it?

Awesome, thanks!


Yatin: Watch (?-i:UC09QoJ38MOctFTN7DIgB5mg)(?#youtube channel)

Yatin requests the watch of the watch_keyword (?-i:UC09QoJ38MOctFTN7DIgB5mg)(?#youtube channel). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:UC09QoJ38MOctFTN7DIgB5mg)(?#youtube channel) has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Never upgrade the debs we're trying to test

We need to pin the debs we're trying to test or apt may try to upgrade them from one of the repositories instead of using the local deb file.
Should unblock the CI failure in #3

I think I either got all of the conditional logic correct or I reversed all of them.


Add nr of points/nodes stats back

Duing angulirfication the nr of points and nr of nodes and current mouse location did not get transfered.

They are back.


Set NODE_ENV on start/build, use distPath for html template

Is this a bug report?
Yes
Environment

react-static -v: 4.3.0
node -v: 8.9.0
yarn --version: 1.3.2

Steps to Reproduce

Add paths: { devDist: 'local' } to static.config.js
Start the dev server with yarn start

Expected Behavior
Creates a local folder and uses that instead of dist
Actual Behavior
Uses the dist folder
Probable explanation
process.env.NODE_ENV is not set properly, so the process.env.NODE_ENV === 'development' check when giving paths.DIST a value is not working as intended. Explicitly giving it a value on start and build works great.
The HTML_TEMPLATE path also had to be made dynamic, and all the files were now created in the correct folder.
Closes
https://github.com/nozzle/react-static/issues/181

Sorry, I'm not quite sure I understand. With the value HTML_TEMPLATE: path.join(resolvePath(config.paths.dist), 'index.html'), two folders are created.

Was that intended?

Oh never mind. It looks like it's good to go. Just an early morning ;)


feature request: workflow names as tabtitles

hi i modded your app.tsx and added this
document.title = ComfyUI - ${curWorkflow.name ?? "Untitled"};
in line 161 in checkIsDirty function..
looks like this

very handy ..
i can mod it myself after each update of course but its a nice feature and would be nice if you implement it in your programming style .. i just put it there becasue getWorkflow(curFlowID.current) is called already and just updating the title on workflow load will be overridden after a while
edit:
or maybe even better without "comfyui" ??

since workflow names can be long, i think without "comfyui -" is better now. the icon is pretty unique and its probabnly best to create a chrome profile just for comfy with just comfy tabs anyways.

. the icon is pretty unique
i think this icon only comes with the Custom Scripts plugin, its not default by comfyui 🫠

the icon is pretty unique

i think this icon only comes with the Custom Scripts plugin, its not default by comfyui 🫠... or not? correct me if I'm wrong!

which script ? does it? i have this little anime cat girl as icon, i think that was there from the get go
if you are at it maybe you could also create an icon from the most recent generated image in each flow for each tab
here this is how Ill setup my "AI Toolbox" from now on (or very similar at least)

woww your setup looks dope my friend! I should get that side bar tabs too 💯 I always find myself overwhelmed by 10000 tabs in my browser
yeah verified again, that golden angel like girl icon is from this scrip:
https://github.com/pythongosssss/ComfyUI-Custom-Scripts
without that plugin, it has no favicon

another thing: when i reload a browser session (or just restore  a closed tab) comfy will just load the default workflow in each tab .. wouldnt it be possible to save the workflow id to a cookie/localstorage/sessiostorage/whatever and read it on restore and load the right workflows ? im 90% confident thats possible and not even that hard , will try to look into it tommorrow.

Hi in the beta version this is solved by adding the workflow id to the url hash, it’s like @.***
So every time you refresh, the tab should reload the right workflow
BTW are u interested in previewing out beta version ? We have some exciting new features!
https://github.com/11cafe/comfyui-workspace-manager/tree/main#beta-preview
Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Mehler @.>
Sent: Thursday, January 25, 2024 9:46:06 AM
To: 11cafe/comfyui-workspace-manager @.>
Cc: Weixuan Fu @.>; Comment @.>
Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)
another thing: when i reload a browser session (or just restore a closed tab) comfy will just load the default workflow in each tab .. wouldnt it be possible to save the workflow id to a cookie/localstorage/sessiostorage/whatever and read it on restore and load the right workflows ? im 90% confident thats possible and not even that hard , will try to look into it tommorrow.
—
Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/143#issuecomment-1909208888, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOIFGHZLWRQP3LGBKTTYQG2N5AVCNFSM6AAAAABCGBXMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIYDQOBYHA.
You are receiving this because you commented.Message ID: @.***>

If you decided to checkout beta, make sure you make a copy of your current comfyui-workspace-manager folder somewhere else, just in case anything unexpected happens
Get Outlook for iOShttps://aka.ms/o0ukef

From: Weixuan F @.>
Sent: Thursday, January 25, 2024 9:57:10 AM
To: 11cafe/comfyui-workspace-manager @.>; 11cafe/comfyui-workspace-manager @.>
Cc: Comment @.>
Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)
Hi in the beta version this is solved by adding the workflow id to the url hash, it’s like @.***
So every time you refresh, the tab should reload the right workflow
BTW are u interested in previewing out beta version ? We have some exciting new features!
https://github.com/11cafe/comfyui-workspace-manager/tree/main#beta-preview
Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Mehler @.>
Sent: Thursday, January 25, 2024 9:46:06 AM
To: 11cafe/comfyui-workspace-manager @.>
Cc: Weixuan Fu @.>; Comment @.>
Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)
another thing: when i reload a browser session (or just restore a closed tab) comfy will just load the default workflow in each tab .. wouldnt it be possible to save the workflow id to a cookie/localstorage/sessiostorage/whatever and read it on restore and load the right workflows ? im 90% confident thats possible and not even that hard , will try to look into it tommorrow.
—
Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/143#issuecomment-1909208888, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOIFGHZLWRQP3LGBKTTYQG2N5AVCNFSM6AAAAABCGBXMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIYDQOBYHA.
You are receiving this because you commented.Message ID: @.***>

BTW are u interested in previewing out beta version ? We have some exciting new features!

sure! will check it out

Great! Let me know if that works for you!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Mehler @.>
Sent: Thursday, January 25, 2024 10:06:25 AM
To: 11cafe/comfyui-workspace-manager @.>
Cc: Weixuan Fu @.>; Comment @.>
Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)
BTW are u interested in previewing out beta version ? We have some exciting new features!
sure! will check it out
—
Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/143#issuecomment-1909225677, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOPWLOTR33DY4Q7O5Q3YQG42DAVCNFSM6AAAAABCGBXMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIZDKNRXG4.
You are receiving this because you commented.Message ID: @.***>

ok i tested it , the workflow restores fine when a tab is restored .. but after a browser restart the most recent flow is just loaded into every comfy ui tab. On Chrome

Oh that’s weird. How did you restart the browser? Just closing all windows?
Before and after restart, does your url looks like:
@.***
If it looks like just "http://<IP_ADDRESS>:8188/" then it will load the most recent workflow
It has to have the id in the url to load the certain workflow
Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Mehler @.>
Sent: Friday, January 26, 2024 6:42:19 AM
To: 11cafe/comfyui-workspace-manager @.>
Cc: Weixuan Fu @.>; Comment @.>
Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)
ok i tested it , the workflow restores fine when a tab is restored .. but after a browser restart the most recent flow is just loaded into every comfy ui tab. On Chrome
—
Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/143#issuecomment-1911114442, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOMHQXJUDHEGELS6RTLYQLNUXAVCNFSM6AAAAABCGBXMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJRGEYTINBUGI.
You are receiving this because you commented.Message ID: @.***>

make sure you clicked this "Open in new tab" button when opening a workflow

 make sure you clicked this "Open in new tab" button when opening a workflow

it were only the old tabs from before installing the beta, after closing them and loading new tabs it worked   ..
i tested if the string changes on new flow, flow load , restart, restore tab .. seems to work nicely !
one improvement could be that when closing a tab or the browser, it will alert you that the changes are discarded .. i think using the message to ask for saving with yes/no would be nice.

one improvement could be that when closing a tab or the browser, it will alert you that the changes are discarded .. i think using the message to ask for saving with yes/no would be nice.

like this?

I just added this new dev branch, not yet launched ^^

fixed in latest version


[mob-598] - format using swift formatter

A LOT of it looks great, but I'm interested in knowing if we can fix:

the indentation removal on blank lines; I like having the indentation so that adding in new code is easier by not needing to hit tab to get to the proper level
putting certain files on an avoid list; namely the ones related to Dwifft


fix download file generation logic

Merging this into dev so it can be reviewed before release therefore closing this PR


Feature request: "python.debug.settings.console"

Very similar to the "java.debug.settings.console" setting described below, I'd love to be able to provide a default console setting to all debug configuration that don't have one defined. This would allow separating personal preferences (Debug Console vs. Terminal, possible to be defined in user settings) from work-space-specific debug settings (which module to load and start, defined by the work space).

console - The specified console to launch the program. If not specified, use the console specified by the java.debug.settings.console user setting.

https://code.visualstudio.com/docs/java/java-debugging#_launch

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.
We do encourage people to continue 👍 the first/opening comment as it helps us prioritize our work based on what the community seems to want the most.


Update parity-wasm 0.42 -> 0.45

Codecov Report

Merging #389 (1f4399c) into master (2236434) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   78.69%   78.69%
=======================================
  Files          98       98
  Lines       11300    11300
=======================================
  Hits         8892     8892
  Misses       2408     2408

Help us with your feedback. Take ten seconds to tell us how you rate us.


Is this project abandoned?

Main Java sources https://github.com/polkadot-java/api/tree/master/packages/src
were not updated for 2 years, and there were never public release to maven Central #13
This looks like dead project.

From 2 years old README

The working substrate version is 1.0.0-41ccb19c-x86_64-macos. Newer substrate may be not supported.

Current substrate version is 3.0 https://github.com/paritytech/substrate
So of course there we breaking changes.

I have spent some time trying to build, see #35
And them I came across https://github.com/emeraldpay/polkaj alternative.
If this project is abandoned, then it would be nice to give like to these and other option.

So is this API still alive?


mod not supported in LoopVectorization

I use a mod in my loop and LoopVectorization gives: ERROR: LoadError: mod not defined for VectorizationBase.Vec{8, Float64}  in statement fi = mod(i_pos, 1)
Would it be possible to support mod?

We could add a Vec{8,Float64} definition to VectorizationBase.

Should be fixed by https://github.com/JuliaSIMD/VectorizationBase.jl/commit/1b6cdc4d721bce66f724ef08d831994720ab420b


bug: Incorrect message when removing upvote or downvote

Describe the bug
When a user removes an upvote or downvote on a comment, the success message always displays "Comment has been upvoted" or "Comment has been downvoted," even when the vote is being removed.
To Reproduce
Steps to reproduce the behaviour:

Upvote or downvote a comment.
Remove the upvote or downvote.
Notice that the message still says the comment has been upvoted or downvoted, even when removing the vote.

Expected behaviour
A clear message indicating whether the upvote or downvote has been removed should be displayed. For example:

"Upvote has been removed."
"Downvote has been removed."

Video of the Bug
https://github.com/user-attachments/assets/e406966c-7dd2-43a0-b53a-a518abe51573
Additional context
This bug can cause confusion for users, as they are not clearly informed whether their vote has been removed or added. Clarifying the messages will improve user experience.

Hey, I just saw this issue has already been fixed recently, it's just not deployed yet. I am closing this PR. Sorry for the inconvenience.

This has been fixed sir


Open stream in dart

You can "manually" open a Stream in dart to read stream information directly, without creating a local file.
A typical usage method is http file upload.

The code part has been completed, and there may be some use cases that require additional testing.
The document is incomplete.


How do I get the 'grantsObject' or 'grantList'

How do I get the 'grantsObject' or 'grantList' from an AccessControl object already instantiated, ie the inverse process of "const ac = new AccessControl (grantsObject);" or "" const ac = new AccessControl (grantList); "?

Please read the docs: #getGrants()

@onury this endpoint only gets you the grantsObject not the grantsList. Also it would be nice to export a typing for each of those.


Improve api documentation

The api is only partially documented in the online docs, for instance the flags page lists attributes (but capitalises them) and does not list methods - it would be good to document the public methods
https://waffle.readthedocs.io/en/stable/types/flag.html
Switches lists neither attributes nor methods
Samples lists attributes (but capitalises them) and does not list methods

@dancergraham I would like to pick this issue.

Great, let me know if you need any help getting started


Not reacting to html updates

Vite doesn't detect html changes and page(Browser) not reloading(No HMR request).
My code same as on documentation ( postHtml example )
import vituum from "vituum";
import posthtml from "@vituum/vite-plugin-posthtml";

export default {
  plugins: [
    vituum(),
    posthtml({
      root: "./src",
    }),
  ],
  build: {
    rollupOptions: {
      input: ["./src/pages/**/*.html"],
    },
  },
};

if someone faced this problem -  just update Vite to the latest version.It's worked for me

all the same, this is definitely bugged at times. Sometimes the page does not react at all to changes

Hello @kiyoshi-satoo
I am experiencing a similar issue; however, I have developed my own plugin to reload the entire page upon detecting any changes. This is merely a temporary solution until the issue is resolved.
vite.config.js
...
    plugins: [
        vituum(),
        posthtml({
            root: "./src",
        }),

        // Custom HMR
        {
            name: "custom-hmr",
            enforce: "post",
            handleHotUpdate({file, server}) {
                if (file.endsWith(".html")) {
                    server.ws.send({
                        type: "full-reload",
                        path: "*"
                    })
                }
            }
        }
    ],
...

Hey @nawafinity @kiyoshi-satoo that should indeed fix it. I forgot to include hmr in posthtml plugin, will fix this soon 👍

Hi, @nawafinity .Thanks for the answer. It helped

This still seems to be an issue. Is a fix still being worked on?


Bug with merging users

I'm trying to merge user accounts for an org admin who accidentally created two accounts for herself (https://dmptool.org/super_admin/users/29374/edit).
I am able to select the account to merge, the dialog box with the explanation of what is being moved and which account will be deleted displays as expected, however, after clicking Ok the application gives a 500 error.

Just confirmed this is working on our live service, but we have v2.1.7 deployed, not 2.2.0.

This is working now


Ontobot can now read commands from issue comments

Fixes #7853
In the past, ontobot-change-agent only processed the text in the issue body to look for Hey ontobot, apply:.
With this PR, it not only does that but also looks for comments that have KGCL commands starting with the phrase above. The latest comment containing the command takes precedence.
The latest version of ontobot-change-agent (v0.4.12) is capable of doing so and the workflow update in this PR facilitates for the smooth transition to getting the new feature.
Update: Also installed ontobot-change-agent (a GitHub app) to run QCs. Fixes #7871

I do not know how to test this because I don't know how to an issue in the context of this specific branch.
I think we can just merge, and test after it is merged.

This PR can only be tested after merging it unfortunately.
How to test?

Open a new issue
Write anything in the body doesn't matter
Add this as comment after the issue is created

Hey Ontobot! apply:

- create narrow synonym 'Low-flow priapism(test)' for MONDO:0004745

This should trigger the workflow to generate a PR. The PR is generated under the name ontobot-change-agent and this should trigger QC workflows for this repository.
I have tested this in my fork to make sure the internet isn't wiped clean!

One way of testing this is:

Fork MONDO
Copy paste the workflow file into your fork's ontobot.yml file
Follow the instructions above.

I reviewed again and tested in Harshad's repo and all still looks good.


MEMORY_LIMIT_EXCEEDED error while uploading huge file on click house.

MEMORY_LIMIT_EXCEEDED error while uploading huge file on click house.
I am using the below method to upload the local file on click house.
static long insert(String tableName, String csvFilePath) throws Exception {
        ClickHouseNode server = getServer();
        try (BufferedInputStream bufferedInputStream = new BufferedInputStream(new FileInputStream(csvFilePath))) {
            ClickHousePassThruStream stream = ClickHousePassThruStream.of(
                    bufferedInputStream,
                    ClickHouseCompression.NONE,
                    0,
                    ClickHouseFormat.CSVWithNames
            );
            CompletableFuture<ClickHouseResponseSummary> load = ClickHouseClient.load(server, tableName, stream);
            ClickHouseResponseSummary clickHouseResponse = load.get();
            return clickHouseResponse.getWrittenRows();
        } catch (Exception e) {
            System.out.println("Failed to  load");
            e.printStackTrace();
            throw new Exception();
        }
    }

But on huge files, it failed with memory issues, Most failures occurred on the file that contained more than 300 columns.
ERROR [2023-07-27 06:20:36,451] com.datoin.library.dataset.sql.utility.commons.abstracts.sql.AbstractDBEngine: Failed to load dataset
java.util.concurrent.ExecutionException: com.clickhouse.client.ClickHouseException: Code: 241. DB::Exception: Memory limit (total) exceeded:
would use 3.36 GiB (attempt to allocate chunk of 4360384 bytes), maximum: 3.24 GiB. OvercommitTracker decision: Query was selected to stop by
 OvercommitTracker. (MEMORY_LIMIT_EXCEEDED) (version <IP_ADDRESS> (official build))
, server ClickHouseNode [uri=http://localhost:8123/cayleytest95814, options={connect_timeout=5000000,socket_timeout=5000000}]@75218225
        at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
        at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)

Is there any way to upload huge files 30-40GB files on Clickhouse without any memory issues? which directly reads from the disk and uploads on click house. Optimal way in terms of

duplicate of https://github.com/ClickHouse/clickhouse-java/issues/1401


[Feature] Domain disks configuration for Ceph network disks

Reason
As mentioned in #585 support for some of the common network drives would be useful in the provider. Also as mentioned in the issue it would be somewhat simpler to separate different implementations by just simply providing them when requested/implemented. I went ahead and got the Ceph version here.
Changes
When provided with a Ceph configuration in the libvirt_domain.disks resource the provider will assume that the linked volume is provided by a network storage. If the Ceph config is not provided no further action will be taken.
If the config does exist the required set of XML domain configurations will be added to the VM.
Breaking Changes
None I can think of but to use the clone functionality e.g. for OS base images, as given in the example, the PR #591 needs to be merged first. Normal empty disks work just fine without.
(Closes: GH-585)

@lhw Could you please rebase on master? There is a good chance the checks pass now. :)

We are currently not using the terraform-libvirt-provider anymore and I don't have the time to work on this anymore.


Re-enable multinode e2e tests

In https://github.com/timescale/promscale/pull/1248 we've disabled the multinode e2e tests because they're failing against the latest (development) promscale extension version.
That issue is being tracked in https://github.com/timescale/promscale_extension/issues/138.
Once we have those issues fixed, we should come back and re-enable the multinode e2e tests.

Multinode not supported for now


New: scaling up of png images and have a good default for high dpi screens

by default, it matches what you see on the screen, for instance on a mac with window.devicePixelRatio == 2 it will give you an image of twice the resolution.

Left: previous result (scale=1). Right: new result (scale=2), much sharper!


[Question] How can you get the config.php array in webpack.mix.js

As the title says, is it possible to get the final config array (after Jigsaw merges env-specific configs) in JS, in order to use a key inside a script?

Yes, you can access it by echoing the $page variable in you master Blade template, something like this:
<script type="text/javascript">
    var jigsaw = @json($page)
</script>

That'll populate the JS jigsaw variable with the parsed contents of config.php, including collection details and environment-specific config items.

Thanks for answering my silly question, @damiani. Yes, of course we can do it like that in a Blade template - apologies for not being clear.
What I meant was how could one get the config in the Webpack/Gulp script.
So for example, say I needed to use a config key in webpack.mix.js, presumably in the AfterBuild plugin after Jigsaw compiles Blade and outputs them.
I've tried something and it does work, but I feel it's a bit hacky and I would appreciate any input here.
In my use case, I want to be able to specify whether pretty permalinks should be used, directly in the config. It may not be the best example, but you can imagine it could be anything:

config.production.php :
<?php

return [
    'baseUrl' => 'site.example.com',
    'production' => true,
    'prettyUrls' => true,
    'collections' => [],
];

I have a tasks/php/config script where I get the (merged) configuration, based on the environment:
#!/usr/bin/env php
<?php

/*
|--------------------------------------------------------------------------
| Get Site Config
|--------------------------------------------------------------------------
|
| Get the environment-specific site configuration and output it as JSON.
| This JSON is then used in webpack.mix.js, to trigger scripts based
| on your config files, respecting the build environment.
|
*/

$env = getopt('e:');
$config_dev = require_once('config.php');

if($env) {

    $file = 'config.' . $env['e'] . '.php';

    if(file_exists($file)) {

        $config_env = require_once($file);
        $out = array_merge($config_dev, $config_env);

        print json_encode($out);
        exit();

    }

}

print json_encode($config_dev);

exit();

In the AfterBuild Webpack plugin, I run that task with command.get(), passing the command to jigsaw build as a callback:
new AfterBuild(() => {

        command.get('php tasks/php/config -e' + env, (error, stdout, stderr) => {
            if (error) {
                console.log(stderr)
                process.exit(1)
            }

            config = JSON.parse(stdout)

            const prettyUrls = (config && !config.prettyUrls) ? '--pretty=false ' : ''

            command.get(jigsaw.path() + ' build ' + prettyUrls + env, (error, stdout, stderr) => {
                console.log(error ? stderr : stdout)

                if (browserSyncInstance) {
                    browserSyncInstance.reload()
                }
            });
        });

    })

This does work, but I don't know if it's a good approach.
Again, I would be grateful for your input. And thank you so much for the wonderful work on Jigsaw - love it!

Ah, I see. In general, there's no easy way to access any of the data that gets built when the PHP side of Jigsaw runs (like the merged config) in the JS AfterBuild() step, since the PHP hasn't run yet. There is the ability to monkey with things in bootstrap.php, or, shortly, in the beforeBuild event, but that wouldn't help for your specific use case either, since there's no way to change the outputPathResolver before the Jigsaw class is instantiated.
So, your solution is as good as any :)
If there seems to be a common need to change the prettyUrl setting based on something other than the --pretty flag in the console command, we can consider adding another event hook and/or a setter method in SiteBuilder.php to allow you to change the outputPathResolver in bootstrap.php.

Found another use case :)
As I'm using collections to build individual sites, I realized I could use per-collection control over pretty URLs, so that some sites use pretty URLs, while other's don't.
Ideally, maybe a key on the collection?
'collections' => [
    'site-1' => [
        'prettyUrls' => true, // if missing, default to true or let --pretty flag handle it?
    ],
    'site-2' => [
        'prettyUrls' => false,
    ],
],

For regular, non-collection folders, maybe let --pretty handle them, or perhaps check for a prettyUrl: true in Front Matter?
What do you think?


Add new school domain

@OuchattiKhadija There are several files in the request, along with file.zip. It must not be there. Please remove file.zip and make pull request again.  I have to close this request without merging. Thank you for your understanding.


fix: fix & refactor miRNA extension script

I had a bit of time and felt like coding, so I refactored the script a bit (well, maybe a bit more than a bit).
It should now do what it's supposed to do, I hope. Or in any case, it's broken down into more, simpler steps, so if it isn't fully there yet (the tests would show), then it should be easy enough to change.
I suppose you could merge this in your branch, if you like, and then update the tests to match and cover all edge cases. Note that I have included two or three specific error checks that were not covered before, so apart from refactoring, you'd probably need to add a couple more tests to check for these.

Of course you can also update/add the tests first, in this branch, so that the tests pass. Probably makes more sense :)

Here are some small comments; besides the last one, everything is related to the docstrings .
In the meantime, if it's alright, I'll be working on fixing the unit tests and static code analyses for this PR.

Awesome, thanks a lot :)
Will you address these points when you are adding the tests etc? 🙏

Here are some small comments; besides the last one, everything is related to the docstrings .
In the meantime, if it's alright, I'll be working on fixing the unit tests and static code analyses for this PR.

Awesome, thanks a lot :)
Will you address these points when you are adding the tests etc? 🙏

On it! The unit tests will take me the rest of today, luckily not that much of tomorrow.
Just a small comment. The following line has more than 80 char therefore, it fails the static code analysis:
precursor.attributes["Name"][0] += f"_-{pre_orig_start - precursor.start}"

black suggests to apply the following style:
precursor.attributes["Name"][
        0
    ] += f"_-{pre_orig_start - precursor.start}"

I find it horrible. So I want to know which one of the following approach you want me to follow:

Create the suffix variable, blending both formatted strings to afterwards modify the precursor name.
Change the precursor name to something shorter.
Change the pre_orig_start name to something shorter.
Use black's suggestion.

I'd rather go with the first one but it's up to you :)

The changes applied in the last push are:

Update the unit test and the required files for the script 'mirna_extension.py'
Refactor the 'mirna_extension.py' script
Update expected output (only the extended GFF3 files change) to match the new script (see this comment for more information on the changes)
Two new errors have been add to ignore (W0719 in order to use rise Exception and E0606 (possibly-used-before-assignment) as an error is raised prior to using that variable in the script 'mirna_quantification.py' lines 260, 304 and 330)

Here are some small comments; besides the last one, everything is related to the docstrings .
In the meantime, if it's alright, I'll be working on fixing the unit tests and static code analyses for this PR.

Awesome, thanks a lot :)
Will you address these points when you are adding the tests etc? 🙏

On it! The unit tests will take me the rest of today, luckily not that much of tomorrow.
Just a small comment. The following line has more than 80 char therefore, it fails the static code analysis:
precursor.attributes["Name"][0] += f"_-{pre_orig_start - precursor.start}"

black suggests to apply the following style:
precursor.attributes["Name"][
        0
    ] += f"_-{pre_orig_start - precursor.start}"

I find it horrible. So I want to know which one of the following approach you want me to follow:

Create the suffix variable, blending both formatted strings to afterwards modify the precursor name.
Change the precursor name to something shorter.
Change the pre_orig_start name to something shorter.
Use black's suggestion.

I'd rather go with the first one but it's up to you :)

Either way is fine by me :)

The pushed changes are:

Create custom exception to accurately catch and raise annotation errors
Account for possible illegal coordinates in the user-provided GFF3 file (add try-except block + one unit test + one unit test file)
Remove added errors to ignore in pylint.cfg
fix minor static code analysis errors in mirna_quantification.py and in validation_fasta.py

LGTM :)


complete Likelihood

To make the CC and BAO likelihood..
Likelihood_GP_save.py.txt

Run_GP.py.txt

Ok, let me check it

Ok, I will check that

ok I will check it

Done in https://github.com/antolonappan/marcia/commit/58ab2bcc815a4e5524c9db6766d30f37955dfcf8


Task15

Concatenate

@Rahamathunisa30591
Task -13
Code verified. Provide correct excel file path with extentions
Task -14
Code verified.


light theme for airline and lightline

I see that you've started working on a light theme around 1.5 years ago, but never continued after creating the base vim colorscheme. I really want to see the light theme released, so here I am, doing what I can.
So far, I've added light colorscheme to airline and lightline.
It's would be perfectly usable right now, if not for the contrast between background color and cursor.

Dark and light themes side by side, for comparison

Not sure why, but the issue above applies to terminal only. Everything looks fine in GUIs (tested in gvim and neovide).
Completely lost on this one, so any help would be appreciated!

Thank you for the contribution!
As you said development of light theme is pending for 1.5 years, but now is a good time to restart because...

I need one (dark theme is hard to see in a bright room...)
You also need one :)
The number of GitHub stars will soon reach 1,000 🌟

airline and lightline theme will be compiled from src/template-airline.vim and src/template-lightline.vim so we also need to modify them. I'll review your changes and apply it for them later.
Please refer #62 to see the development status.

Fixed merge conflicts, ready to merge now! 👍

Thank you for resolving conflicts! Finally, could you squash multiple commits into a single commit and force-push it? This makes your changes simple and clear.

Whoops, forgot some whitespace... Sorry for the force-push spam!

Merged. Big thanks to your contribution!!


Can't get dashes to work in demo

See this fiddle: http://jsfiddle.net/pmorch/bJwY8/1/ whenever dashes are turned on the series vanishes?

Most likely this is due to the fact that the jquery-flot-dashes.js script is loaded via plain HTTP (http://yourjavascript.com/5022388132/jquery-flot-dashes.js) and the browser refuses to load it while jsfiddle.net itself is loaded with https.
The error can be seen in the developer console while jsfiddle is loading.
Copy and paste the library directly into jsfiddle and it will work.


Support for Managed Disks in Container Instances?

With Container Instances, we can easily mount Azure Files. This is a great capability, but it is extremely slow to use File shares in storage accounts (even the Premium ones, which are in public preview). As a reference, with AKS, I've circumvented the performance bottlenecks by using Managed Disks instead of Azure Files, where we can then provision a Premium SSD disk and do any operations there with great performance. I've documented the performance differences and it's hundreds of times faster with the Premium SSD drive than Azure Files, with no logical code changes or changes in data.
So with that brief background, I wonder if there's anything on the roadmap for supporting Managed Disks, or Azure Files will be the only goto-solution for this?
Thanks,
Tobias.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b730fc95-951e-1acd-770d-88b3e6f2f6ef
Version Independent ID: b6445fd2-46ea-aedd-2f2c-294faa660660
Content: Mount an Azure Files volume in Azure Container Instances
Content Source: articles/container-instances/container-instances-volume-azure-files.md
Service: container-instances
GitHub Login: @dlepow
Microsoft Alias: danlep

@Zimmergren Thanks for posting your query here. We have seen you post in feedback.azure.com. We will check with the product team and will update you on this.

Thanks @VikasPullagura-MSFT, looking forward to learn more about this roadmap.
Cheers,
Tobias

+1

@dkkapur - Please comment if you have more info. Thanks.

@Zimmergren - Thanks for your question and providing additional feedback. At this time I don't have more information on where managed disks support stands on the engineering roadmap for Container Instances. If you can, I encourage you to add further detail at the feedback site which might help the team understand your scenario better and find ways to address it.
#please-close

Actually I am also missing Azure disks. I wanted to run Seq on ACI, but that doesn't work well with file shares (see https://docs.datalust.co/v4.2/discuss/5d0027a10db450002d119fb9). Woud love to see support for Azure disks.

We were also very disappointed with the slow performance of the SMB file shared. We're using docker ACI to deploy.

hi @Zimmergren, did you find a solution for this?

@pieterlukasse, unfortunately, it's been quite some time since this scenario was valid for me. We have since moved on to use different solutions for our problems.

I would love to see this as well, I am using ACI for Azure DevOps build agents however the performance is about twice as slow as alternative options.

Our scenario is using Azure Files file share, but it does not support "alternate data streams", so we cannot automate execution of powershell scripts, or loading of .NET assemblies. Set-ExecutionPolicy Bypass and Unblock-File do not have any effect.
Managed Disks support "alternate data streams" and would be nice to see an option to mount them into a container running in ACI.