[question] How to Use --env-kwargs correctly?

How do you use --env-kwargs correctly?
I have this code in a custom environment.
custom_env = gym.make('forex-v0',
               df = FOREX_EURUSD_1H_ASK,
               window_size = 10,
               frame_bound = (10, 300),
               unit_side = 'right')

let us say I want to use the df = FOREX_EURUSD_1H_ASK
--env-kwargs df = FOREX_EURUSD_1H_ASK post an error.

Traceback (most recent call last):
  File "train.py", line 79, in <module>
    args = parser.parse_args()
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1755, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1787, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1993, in _parse_known_args
    start_index = consume_optional(start_index)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1933, in consume_optional
    take_action(action, args, option_string)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1861, in take_action
    action(self, namespace, argument_values, option_string)
  File "E:\ML\reinforcementlearning\zoo\rl-baselines-zoo\utils\utils.py", line 394, in __call__
    arg_dict[key] = eval(value)
  File "<string>", line 0

I have tried multiple key.
--env-kwargs=df:'FOREX_EURUSD_1H_ASK' frame_bound:(50, 100) window_size:10

I encountered an error here.
in utils.py
values
["df:...w_size=10 ']
special variables
function variables
0:"df:'FOREX_EURUSD_1H_ASK' frame_bound:(50, 100) window_size=10 "
len():1

    def __call__(self, parser, namespace, values, option_string=None):
        arg_dict = {}
        for arguments in values:
            key = arguments.split(":")[0]
            value = ":".join(arguments.split(":")[1:])
            # Evaluate the string as python code
            arg_dict[key] = eval(value)
        setattr(namespace, self.dest, arg_dict)

key will retrieve the value: df
value will retrieve the value: 'FOREX_EURUSD_1H_ASK' frame_bound:(50, 100) window_size=10
    args = parser.parse_args()
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1755, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1787, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1993, in _parse_known_args
    start_index = consume_optional(start_index)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1933, in consume_optional
    take_action(action, args, option_string)
  File "C:\anaconda\envs\zootesting\lib\argparse.py", line 1861, in take_action
    action(self, namespace, argument_values, option_string)
  File "e:\ML\reinforcementlearning\zoo\rl-baselines-zoo\utils\utils.py", line 394, in __call__
    arg_dict[key] = eval(value)
  File "<string>", line 1
    'FOREX_EURUSD_1H_ASK' frame_bound:(50, 100) window_size=10
                                    ^
SyntaxError: invalid syntax

Is it a bug?

everything you pass to the command line must be a string...
so, in your case frame_bound:'(50,100)'

I tried to do it.
key: df
value: 'FOREX_EURUSD_1H_ASK' frame_bound:(50, 100) window_size:10
It fails on
arg_dict[key] = eval(value)

But if the value is just  'FOREX_EURUSD_1H_ASK'
It will be an ok.

@toksis could you inform the entire command line you have used?
In a previous comment you have used an unexpected equal sign = after --env-kwargs

I have tried multiple key.
--env-kwargs=df:'FOREX_EURUSD_1H_ASK' frame_bound:(50, 100) window_size:10

That should be:
--env-kwargs df:'FOREX_EURUSD_1H_ASK' frame_bound:'(50, 100)' window_size:10

@caburu  sorry for that. I am using Launch.json in Visual Studio Code to add the arguments.
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Current File",
            "justMyCode":false,
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "integratedTerminal",
            "args": ["--algo=acktr","--env=forex-v0","-n 50000","-optimize","--n-trials=1000 ","--n-jobs=2",
                     "--sampler=tpe","--pruner=median","--env-kwargs=df:'FOREX_EURUSD_1H_ASK' frame_bound:'(50, 100)' window_size:'10' "]
        }
    ]
}

@toksis Did you solve your issue?
I try reproducing it but couldn't...
What I did:
python train.py --algo a2c --env CartPole-v1 --env-kwargs a:'TEST' b:'(3,4)' c:5

and I just printed the parsed arguments as CartPole does not accept those:
print(arg_dict)
# outputs: {'a': 1, 'b': (3, 4), 'c': 5} because I defined TEST = 1 in `utils/utils.py`

Note: I defined the variable TEST in utils/utils.py so it is in the right scope.

@toksis I believe the problem is yet with the equal sign.
The other command line parameters has only one value. For example: for --algo, in a terminal, you could use --algo=acktr or --algo acktr, and both it would work. But for --env-kwargs you need to pass more than one value, so you can't use the equal sign.
If you were using a terminal you would only need to replace the equal sign by space character. But this will not work with  Visual Studio Code because when there is a space inside the arg, VS code put quotes around the arg. So I believe the solution is to separate the args.
Replace this line:

                     "--sampler=tpe","--pruner=median","--env-kwargs=df:'FOREX_EURUSD_1H_ASK' frame_bound:'(50, 100)' window_size:'10' "]

by this:
                     "--sampler=tpe","--pruner=median","--env-kwargs", "df:'FOREX_EURUSD_1H_ASK'", "frame_bound:'(50, 100)'", "window_size:'10'"]

And tell us if it works.

Thank you for your help @araffin  and @caburu cabu. Sorry for the delay, but I did this directly after waking up hehe.
To this:

From this:

The way I put the argument in Launch.json is the culprit. It works now!


Steam Family Sharing & Amazon Prime Games

Not being able to see the games I have access to through Steam Family Sharing is the main reason I'm not using GOG Galaxy 2.0. Is there any chance this will be added at some point?
Support for Games With Prime would be great too, I have 50+ games through Amazon.

The Prime games are shown if you use the Twitch plugin

The Prime games are shown if you use the Twitch plugin

Does the Twitch Plugin count as official support or is it third party?

I think it is 3rd party

You can find it here (along with other 3rd party plugins): https://github.com/Mixaill/awesome-gog-galaxy

What is the reason that some integrations can't be found within Galaxy?

You can find it here (along with other 3rd party plugins): https://github.com/Mixaill/awesome-gog-galaxy

Thank you for linking that, I'll give it a shot and hopefully it works.

Steam Family Sharing is done in community plugin: https://github.com/FriendsOfGalaxy/galaxy-integration-steam/issues/12
both amazon and twitch are in platform game list. Closing as not problem with Amazon Prime support is not related to this repository anymore.


Support for image_url

This allows images to be passed to chat completions via URI e.g:
c = openai(KEY).chat URI("https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg").chat "What's in this image?"
c.thread.last

=>
#<LLM::Message:0x00007598b9902c58
 @content=
  "The image shows a wooden boardwalk that stretches through a field of tall, green grass. The landscape features a bright blue sky with soft clouds, and there are trees and bushes in the background. The scene conveys a serene, natural setting, inviting exploration and appreciation of the outdoors.",
 @role="assistant">

@antaz Can you document this as well ? How does it work with Gemini ? And Anthropic ?

Closing in favor of #31


Error: Cannot find module 'prop-types'

Does not load and throws an Error in dev tools:
bundle.js:1 Error: Cannot find module 'prop-types'
    at Module._resolveFilename (module.js:470:15)
    at Function.Module._resolveFilename (/Applications/Hyper.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._load (module.js:418:25)
    at Function.c._load (file:///Applications/Hyper.app/Contents/Resources/app.asar/renderer/bundle.js:1:8001)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/gbriel/.hyper_plugins/node_modules/hyperline/dist/hyperline.js:128:18)
    at __webpack_require__ (/Users/gbriel/.hyper_plugins/node_modules/hyperline/dist/hyperline.js:20:30)
    at Object.<anonymous> (/Users/gbriel/.hyper_plugins/node_modules/hyperline/dist/hyperline.js:1339:69)
    at __webpack_require__ (/Users/gbriel/.hyper_plugins/node_modules/hyperline/dist/hyperline.js:20:30)

I have the exact same error on Hyper 1.4.8.  I tried the latest pre-release of Hyper as well, but had the same error.

yup I have to manual add prop-types to .hyper_plugins/ dir

@gabemeola with installing prop-types it started working, but it continued complaining about other missing packages, like react and the style is kinda broken.

Hey all - this was caused by a new version that switched the plugin over to using prop-types. Did a rollback to the old version, hopefully everything should be fine. Will look into a better fix soon!

@NickTikhonov I keep getting this error while installing the plugin, how can I roll back the version?

I had the same issue so rolled back (as suggested by @mloberg in issue Error: Cannot find module 'react' "Using version "0.6.1" fixed Hyperline for me. Use hyperline#0.6.1 instead of hyperline in your plugins list.")

@jacec Thanks!


Respect user provided absolute path

When the environment variable CARGO_MANIFEST_DIR is not present as is the default when opening a workspace project in vs code and running the tests. expect-test panics.
The problem can be reproduced with this minimal project https://github.com/mvtec-bergdolll/expect-test-repro-proj/tree/main. Open it in vs code and run the integration tests. They panic. However running them from the shell does not panic. That's unfortunate.
As user trying to debug this I was confused why it failed even when providing an absolute path.
This change includes:

Do not query CARGO_MANIFEST_DIR if the user already provided an absolute path when calculating an absolute path
Better error message when CARGO_MANIFEST_DIR is not present

I'm not sure how to easily test this so I've not added automated testing.

Yeah, it makes sense. Could you change the type of WORKSPACE_ROOT to be a Result though, to make sure we correctly handle its absence at every call-site?

Or maybe make it private and provide something like fn to_abs_path(p: &Path) -> PathBuf which does the following:

use p if that is abs
join to workpsace dir if that is provided
panics with a clear message

@matklad I've switch to Result and provided explicit error messages in the two places.


Fix uninitialized memory read and associated crash.

Linux doesn't set the amaster parameter of forkpty() to a valid file descriptor in the child, but we pass this value to OwnedFd::from_raw_fd, which panics if the passed value is 0xffff_ffff.
A simple reproducer:
fn effify()
{
    let x: [u8; 1024] = [0xff; 1024];
}

fn main()
{
    effify();

    let dupped = nix::unistd::dup(1).unwrap();
    let result = unsafe { nix::pty::forkpty(None, None).unwrap() };

    match result.fork_result
    {
        nix::unistd::ForkResult::Child =>
        {
            nix::unistd::dup2(dupped, 1).unwrap();
            println!("Child is happy");
        }
        nix::unistd::ForkResult::Parent { child } =>
        {
            println!("Parent is happy");
            println!("{:?}", nix::sys::wait::waitpid(child, None).unwrap());
        }
    }
}

The child process panics in the above code without this patch applied.
What does this PR do
Checklist:

[x] I have read CONTRIBUTING.md
[ ] I have written necessary tests and rustdoc comments
[ ] A change log has been added if this PR modifies nix's API

Apologies for the spelling mistakes in the commit message, I was sleepy when I wrote this.
Now I'm awake however, I've realized that this patch fixes my particular crash, but not the more general issue that we're putting an uninitialized value into an OwnedFd in the child process.
In my case, I immediately call exec() in my child process, so this doesn't matter for my use case, but if I didn't, then the OwnedFd in the ForkptyResult would be dropped in the child process, closing an uninitialized file descriptor. My patch would simply cause this file descriptor to always be stdin, which doesn't help too much.
A proper fix for this problem would be to change the structure of ForkptyResult so that master is present only in the parent process.

I can reproduce this on my Linux host (kernel 6.7.4/glibc 2.38). And from the source code of glibc 2.39, in the spawned child process, the amster buffer won't be accessed.

A proper fix for this problem would be to change the structure of ForkptyResult so that master is present only in the parent process.

This makes sense to me, at least on Linux/Glibc.
Unfortunately, the Linux manual does not mention this behavior. This syscall comes from BSD, the FreeBSD manual, does mention this:

In the child process, it closes the descriptor for the	master side of the pty

So I think we can apply the patch to all the platforms.
And I think the child process doesn't need this parameter as it already has its stdin/stdout/stderr fds open.

superseded by #2315


Composition Vietnamese characters break with redux-form FIELD and react-native TextInput

Are you submitting a bug report or a feature request?

A bug report
What is the current behavior?

For example, Vietnamese character ''ứ" is from Roma-ji  'u' , 'w' and 's'. But in IOS device with redux-form, we cannot do that. And it's happened in most Vietnamese character with signs. We cannot type normally Vietnamese character in redux-form.
What is the expected behavior?

But in android device it's work normally.
What's your environment?

react 16.2.0
react-native 16.2.0
redux-form 7.3.0
redux-form-validators 2.4.3
redux 3.7.2
react-reux 5.0.6
Android 6.0
IOS 11.3

@gustavohenke I also have the similar problem. It is critical to our application. Do you have the solution for it, please consult me. Thank You!?

I think it is quite similar to bug #3938  .  I am very tired because of this error. Please let me know when it is fixed. Thanks a lot.

If either of you would like to look at this, remember that PRs are welcome 🙂 it's unlikely that this will be looked at anytime soon by the maintainers.

Use Formik instead. It is similar to redux-form but this bug and another language composition has been fixed.

I got one solution.
you have you change your textInput where you do value={this.props.value} and the props value comes from a redux form. Instead of this use state in value something like value={this.state.value} and in the componentDidMount add the props.value to state value.
also, create a separate function for onChangeText and set the state value first and the call this.props.onChangeText in the callback function of the setState. this worked for me.
Pasting the code for you. I hope this helps
import PropTypes from "prop-types";
import React, {Component} from "react";
import {TextInput, Text, View, StyleSheet} from "react-native";
const propTypes = {
mapElement: PropTypes.func,
onSubmitEditing: PropTypes.func,
onChangeText: PropTypes.func,
value: PropTypes.string,
placeholder: PropTypes.string,
maxLength: PropTypes.number,
keyboardType: PropTypes.string,
secureTextEntry: PropTypes.bool,
label: PropTypes.string
};
const defaultProps = {
mapElement: (n) => {},
onSubmitEditing: () => {},
onChangeText: () => {},
value: "",
placeholder: "",
maxLength: 200,
keyboardType: "default",
secureTextEntry: false,
label: ""
};
const styles = StyleSheet.create({
inputBox: {
width:300,
backgroundColor:'rgba(255, 255,255,0.2)',
borderRadius: 25,
paddingHorizontal:16,
fontSize:16,
color:'#ffffff',
marginVertical: 10
}
});
class InputText extends Component<{}> {
state = {
    value: ""
}

componentDidMount() {
    this.setState({
        value: this.props.value
    })
}

onChangeText = (value) => {
    this.setState({
      value
    }, () => {
        this.props.onChangeText(value);
    })
}

render() {
    const {placeholder, secureTextEntry, keyboardType, maxLength, value, onChangeText, onSubmitEditing, style} = this.props;
    return (
        <View>
            <TextInput
                style={[styles.inputBox, style]}
                underlineColorAndroid="rgba(0,0,0,0)"
                placeholder={placeholder}
                placeholderTextColor="rgba(255,255,255,0.8)"
                selectionColor="#999999"
                secureTextEntry={secureTextEntry}
                keyboardType={keyboardType}
                maxLength={maxLength}
                returnKeyType="next"
                value={this.state.value}
                onSubmitEditing={onSubmitEditing}
                onChangeText={this.onChangeText} />
        </View>
    );
}

}
InputText.defaultProps = defaultProps;
InputText.propTypes = propTypes;
export default InputText;


Update NullabilityInfoContext.cs.pp with bug fix from MS repo

See:

https://github.com/dotnet/runtime/pull/63556

@SimonCropp When using this source-only repo, does the code get injected for all frameworks, or only pre-.NET 6 frameworks?  If the latter, is there any way to make this work in a .NET 6 environment, so that the fixed code is used rather than the buggy .NET 6 code?

thanks for this. i will deploy it now.

When using this source-only repo, does the code get injected for all frameworks, or only pre-.NET 6 frameworks

only pre-.NET 6 frameworks

is there any way to make this work in a .NET 6 environment, so that the fixed code is used rather than the buggy .NET 6 code?

not currently. TBH it is no a scenario that i considered. although it is obviously valid. thoughts on how it could be achieved? perhaps via compilation constant?

or i could deploy a new nuget that has all the types in a diff namespace

Between me and another person, we have found a multitude of bugs with NullabilityInfoContext.  But to be honest, it's unlikely most people would run into issues for my specific use case within GraphQL.NET.
Just for reference:

https://github.com/dotnet/runtime/pull/63556
https://github.com/dotnet/runtime/issues/63853
https://github.com/dotnet/runtime/issues/63849
https://github.com/dotnet/runtime/issues/63848
https://github.com/dotnet/runtime/issues/63847
https://github.com/dotnet/runtime/issues/63846
https://github.com/dotnet/runtime/issues/63660
https://github.com/dotnet/runtime/issues/63555

Plus another bug when a generic type definition of a generic class has a class constraint - but I have not created an issue yet.

or i could deploy a new nuget that has all the types in a diff namespace

I'll let you know if it would be beneficial.  Thanks!!!

😕 What happens with the MS code?

It is slated for .NET 7

it should have been a nuget that is shipped out of band


404 page error

https://codelabs.developers.google.com/codelabs/android-testing/index.html?index=..%2F..index#11
Espresso Cheat Sheet(https://google.github.io/android-testing-support-library/docs/espresso/cheatsheet/) this link is broken

Should be fixed now; "Espresso Cheat Sheet" should link to https://developer.android.com/training/testing/espresso/cheat-sheet


Docker-compose setup for ML4Kids

I had a go at a docker-compose setup to build and run a containerised version of ML4Kids:

postgres container
node container that builds ML4Kids.

Possible next steps:

clean the ML4Kids container of build artefacts;
try a docker buildx crossbuild Github Action to try to build versions for RPi (crib example)

I just tried a variant Dockerfile using docker buildx on arm7l and arm64 and the installer seems to insist on trying to install https://github.com/lovell/sharp-libvips/releases/download/v8.10.0/libvips-8.10.0-linux-x64.tar.br rather than the required armv7 or arm64v8 flavours?
I'm not a node user and have spent more time than has been productive trying to find the solution! FWIW, Dockerfile I tried here.


Complare to ErwinM/acts_as_tenant

https://github.com/ErwinM/acts_as_tenant gem uses same approach to row based tenancy and nearly same api & default_scopes & also appeared in 2011 (as this one, wow)
Could you shortly overview what makes the difference?

I hadn't been on board when milia was planted but the use of wordings like tenant, current_tenant and set_current_tenant seems to be an obvious decision when developing a multi tenanting gem. ;)
Decision for row based instead of schema based architecture was made for good reasons, see http://myrailscraft.blogspot.de/2013/05/multi-tenanting-ruby-on-rails_4470.html and https://github.com/jekuno/milia/blob/master/README_DETAILS.md#row-based-vs-schema-based-tenanting for details. Using default scopes is the most natural way to fulfill the multi tenanting requriements.
I don't know the other gem too well but a big difference is that milia supports devise out of the box (see https://github.com/jekuno/milia#milia-highlights). Also milia is very strict in enforcing tenanting and preventing illegal access but also allows you to designate universal models which will not get tenanted at the same time.
Feel free to compare the two gems in more detail yourself. Both gems seem to have a mature state so you won't make a mistake choosing either of them!


Stores Kafka message timestamp as part of the encoded information

This PR allows to store Kafka messages timestamp information as part of the encoded MessagePack record.
This has been discussed here https://github.com/pinterest/secor/issues/342

Thanks @HenryCaiHaiying for taking the time to review these changes. I have addressed your comments and added a new test case for the scenario you were describing: a record with no key but with timestamp.

Thanks for the contribution.


Allow using libraries built into SML/NJ

Environment

VS Code version: n/a
Millet version: 71988b9cfea4faed3c0aa77ad5f417895a55f99d
OS version: macOS 10.15.7

Steps to reproduce
git clone https://github.com/jez/vim-better-sml
cd multi-grep/support
mv vbs-util.cm sources.cm # See issue #3
~/github/millet/target/debgug/cli

Expected behavior
no error
Actual behavior
❯ ~/github/millet/target/debug/cli
config.sml:15:18: error[4002]: undefined structure: JSONUtil
config.sml:20:6: error[4002]: undefined structure: JSONPrinter
config.sml:26:20: error[4002]: undefined structure: JSONParser
config.sml:29:22: error[4002]: undefined value: SEL
config.sml:31:29: error[4002]: undefined value: get
config.sml:31:16: error[4002]: undefined value: asString
config.sml:34:13: error[4002]: undefined value: NotString
config.sml:35:10: error[4002]: undefined value: NotObject
config.sml:36:10: error[4002]: undefined value: FieldNotFound
config.sml:35:10: error[4012]: unreachable pattern
config.sml:36:10: error[4012]: unreachable pattern
unused-defs.sml:19:11: error[4014]: non-exhaustive binding: missing [_, _, _], [_, _], and 2 others
util.sml:9:34: error[4007]: expected vector, found string
Error: 13 errors

The sources.cm file uses two libraries that ship with SML/NJ: the basis library and the SML/NJ json library.
The CM file declares those dependencies like this:
Group is
  $/basis.cm
  $/json-lib.cm

  util.sml

  config.sml
  invert-def-use.sml
  unused-defs.sml

  main.sml

yeah, so right now millet only ships knowing about (most of) the standard basis library (plus some extra bits like Fn and Random).
to teach it about non standard other libraries like the ones sml nj ships with, we’d need to either add their signature in this repo (which is what i did for the two just mentioned), or somehow read them from an existing sml nj installation.
i predict the latter to be highly troublesome, since i’m not even sure eg sml nj ships with the source, it seemed to only ship compiled artifacts when i was looking into adding std basis support. not to mention the problem of locating an existing sml implementation on the user’s computer.

another idea: something like .d.sml (like .d.ts for typescript) or .smli (like .rbi for sorbet) for writing “interface files” for 3rd party deps. then it would be the responsibility of millet users to arrange the correct such files for whatever deps they use. this would probably “scale” better.

I also haven't found a way to read the basis library sources out of the SML/NJ installation on disk.
However, MLton ships with a command line flag -show-basis:
mlton -show-basis foo.sml

This dumps the entire contents of the basis library into foo.sml.
There might be existing SML/NJ flags to inspect which libraries are available and their locations dynamically. You could consider emailing the SML/NJ maintainers and see if they have suggestions on how to discover that information.
In any case, these libraries basically never change—you could download the SML/NJ repo, copy the sig files from there, and include them in Millet's installation. Sorbet does something similar for the Ruby standard library.

something like .d.sml (like .d.ts for typescript) or .smli (like .rbi for sorbet) for writing “interface files” for 3rd party deps

Isn't this already what signature files are? Is there a need to duplicate that? Especially if you already have a system that is capable of processing *.sml and *.sig files, it seems redundant.

ok, i think since the std basis libraries change infrequently we can probably include them here. though i think we’d need a config option for what sml impl you’re using since mlton and smlnj (and others) probably ship with different specific libraries.

Isn't this already what signature files are?

not quite. something i currently do for the std basis library files in tree is not check that a structure expression actually ascribes to a signature. this allows me to “conjure up” a structure that ascribes to a signature. this is handy because it allows me to skip providing definitions that would typecheck, since millet doesn’t actually care about the implementation since it doesn’t run code.
if millet allowed user defined .d.sml files or similar i’d probably have it do something similar.

place that defines the mode for not checking for ascription: https://github.com/azdavis/millet/blob/71988b9cfea4faed3c0aa77ad5f417895a55f99d/crates/statics/src/info.rs#L126
an example of that usage: https://github.com/azdavis/millet/blob/71988b9cfea4faed3c0aa77ad5f417895a55f99d/crates/analysis/src/sml/bool.sml#L29

looks like the sml nj libs are doc'd here: https://www.smlnj.org/doc/smlnj-lib/
i might try to scrape them with something similar to what i did for the sml basis libraries: https://github.com/azdavis/sml-basis


vaultwarden-vault: 2.27.0 -> 2022.5.2

Description of changes
Update to the latest upstream release 2022.05.0.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 178575 run on x86_64-linux 1

1 package built:

vaultwarden-vault

I just bumped it to the latest release, 2022.5.2


Added Ellipsoid and Capsule geometries

This PR allows to visualize in Gazebo capsules and ellipsoides.
As you can see in the images I still have some issues with the collisions:

Related with

ign-rendering https://github.com/ignitionrobotics/ign-rendering/pull/203 and https://github.com/ignitionrobotics/ign-rendering/pull/200
ign-msgs https://github.com/ignitionrobotics/ign-msgs/pull/128
ign-physics

dartsim: https://github.com/ignitionrobotics/ign-physics/pull/203
tpe: https://github.com/ignitionrobotics/ign-physics/pull/203

Signed-off-by: ahcorde<EMAIL_ADDRESS>

@ahcorde , I pushed commit ac55ced directly to this branch to add an ellipsoid and a capsule to the markers example. It works for me with https://github.com/ignitionrobotics/ign-rendering/pull/276:

The capsule is currently rotated 90 degrees, this fixes it: https://github.com/ignitionrobotics/ign-common/pull/186

the only thing left to solve is not requiring that all physics engines support these shapes

Looking into it again now, I see that the current implementation doesn't prevent physics engines that don't support capsules and ellipsoids from being loaded. So I think this is good for now. We can always come back and move these shapes into a separate feature if we see the need.
Just pending the ign-physics PR :+1:

We're running out of space for so many features! I updated the top toolbar to look like this:

There are no related failures on CI, merging!


Suzakucoin.eth domain

Hi! What is your PR about?

[ ] Add or edit a skin
[x] Add custom domain for your space
[ ] Add alias for migrate your space
~Add images for your space~ (deprecated) Add the image URL on the space settings directly
~Edit your space with GitHub?~ (deprecated) Please migrate your space to ENS https://docs.snapshot.page/spaces/migrate
~Create your space with GitHub~ (deprecated) Create your space with ENS instead https://docs.snapshot.page/spaces/create

hay, i did add the logo as well but noticed its deprecated now, so just add domain pretty please


closes #908

[x] This patch includes any updated documentation of the proposed changes
[ ] This patch includes tests that verify the proposed changes work as expected

Codecov Report

Merging #983 into master will decrease coverage by 0.51%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   77.11%   76.59%   -0.52%
==========================================
  Files          52       52
  Lines        5593     5606      +13
==========================================
- Hits         4313     4294      -19
- Misses       1280     1312      +32

Impacted Files
Coverage Δ

vent/helpers/meta.py
68.04% <41.17%> (-4.88%)
:arrow_down:

vent/menus/services.py
72.72% <0%> (-27.28%)
:arrow_down:

vent/api/plugins.py
77.54% <0%> (-1.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea67bc3...0bdaf22. Read the comment docs.


Refactoring to allow multiple transports in GAPIC clients

This is ready to review; it is only WIP because gax-java won't be released until this PR is approved.

gax-java and toolkit are approved, PTAL here

LGTM, others should approve also

LGTM, assuming @shinfan 's concerns are addressed.

@pongad I don't think the extra stack frame matters. I think what does matter is that gax was refactored a bit to make this happen, so allocation characteristics may have changed at that level. Like you say, I don't think possible performance changes should impact this PR; however, I think it might be worth doing a perf test before we do a release of google-cloud-java.

@garrettjonesgoogle I agree. That's what I meant; I just didn't think of this when looking at the gax PR. I'll work on measurement when I get cycles.

Changes Unknown when pulling d5575d85105fa932c91c15fd3ab029cc541707b2 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.


web audio nodes in subpatch

Found the problem. Web audio nodes can not be connected with io box (node) and it makes it impossible to work in sub-patches?

I think this is related to the problem I observed with (Node) nodes + audio nodes in general. For example: connect two Oscillators with different frequencies to a Switch (Node), and the output to the AudioDestination. When switching the switch, you'd expect to hear different tones, But it stays with the first one.
I think it is because the audio nodes only react to connection changes (connect/disconnect), but don't care about pinIsChanged(). I had a look a the code and tried for a quick fix, but wasn't successful.
Can you help, @geloescht ?

Hmm... maybe it's time for some restructuring of the really fragile connection maintenance code. Right now it reacts to connection changes only because I thought that would be enough to basically mirror the connections to the Web Audio API. But probably the information about audio connections should be inside the data. This means getting rid of audioConnectionChanged, apiIndex and apiName on audio nodes and replacing them by a data object, which we transport between nodes via the normal setValue() -> evaluate() -> pinIsChanged() -> getValue() routine.

OK, I found there's a catch with this idea: We not only need to establish new Web Audio connections but also disconnect the old ones, when a vvvvjs connection changes. Right now, this works because the outgoing nodes are responsible for maintaining Web Audio connections. They simply re-establish every outgoing Web Audio connection. Nodes like Switch (Node) don't know they should do this. In the proposed implementation, the incoming nodes would have to maintain Web Audio connections. However, they do not posess enough information about old data to properly disconnect the previous Web Audio connection. Even worse, browsers currently do not even implement a AudioNode.disconnect() method that can target just one specific Web Audio connection. It's only in the newest proposal of the spec.
I believe this is some kind of chicken-and-egg-situation. How did you solve this with WebGL resources, @zauner?
Maybe every audio node should maintain an internal list of its current connections that it can compare to when a pinIsChanged(). This list should also be consulted in order to re-establish Web Audio connections that we lose due to a deficient implementation of AudioNode.disconnect().

I started on an implementation. It is going to be kinda complicated, keeping track of previous and current connections.
Here are some links to the issue that is preventing an easy implementation in current browsers:
https://github.com/WebAudio/web-audio-api/issues/6
https://bugzilla.mozilla.org/show_bug.cgi?id=1130010
I could not find a corresponding bug report for Chrome

Did I understand correctly? Now to disconnect node from a particular node (not all at once) should be used ChannelSplitterNode and ChannelMergerNode? Is it really so? horror)

@artofmus : No, these two nodes are not even implemented yet. What I discussed before was just some implementation detail.
@zauner : Please review the new implementation in a22c23203f63f6a16293cd0384cf509beb7008b8 . I have tested this positively with Switch (Node) but not subpatches. I have no experience whatsoever with subpatches in vvvv.js.
I am not sure how to handle conventional (non-Web Audio) outputs in AnalyserNode (which should be renamed to FFT, really) and DynamicsCompressor. They require continuous calls to evaluate() but the new implementation only changes pin values when it is required to change a Web Audio connection. Should those nodes have auto_evalute set to true? Or should we call markPinAsChanged() every frame for audio output pins, as before? Both approaches should be safe but I am not sure about the performance implications.
@artofmus : No, these two nodes are not even implemented yet. What I discussed before was just some implementation detail.
@zauner : Please review the new implementation in a22c23203f63f6a16293cd0384cf509beb7008b8 . I have tested this positively with Switch (Node) but not subpatches. I have no experience whatsoever with subpatches in vvvv.js.
I am not sure how to handle conventional (non-Web Audio) outputs in AnalyserNode (which should be renamed to FFT, really) and DynamicsCompressor. They require continuous calls to evaluate() but the new implementation only marks pins as dirty when it is required to change a Web Audio connection. Should those nodes have auto_evalute set to true? Or should we call markPinAsChanged() every frame for audio output pins, as before? Both approaches should be safe but I am not sure about the performance implications.

Looks good, and works great with Switch (Node) and IOBox (Node) (no other (Node)-nodes yet). Didn't have the chance to test subpatches, but I'm optimistic that this solved it too.
I think an audio pin marked as changed should mean "the connecting, upstream api node changed", and not "the audio signal changed". Therefore it's fine as it is now, and the Analyser and Compressor nodes should be auto-evaluating.


Workaround for Bug in Drone AI

Q
A

Bug fix?
kind of?

New feature?
yes

Needs wipe?
no

Description:
Currently there is a bug with Arma 3 that causes the AI unit inside an aerial drone to cease accepting new orders after it completes a "LAND" order. This, of course, makes it impossible to rearm and refuel them making them non-viable to actually use without constantly reloading the mission.
I found a workaround by deleting the "units" inside the drone and replacing them with a fresh set of units. This pull request adds another action onto any drone similar to the "unflip" action. It just deletes the old crew and puts in a new one with createVehicleCrew.
Successfully tested on:

[ ] Local MP
[x] Dedicated MP

I've only tested on Dedicated MP as that was the easiest way for me to test, but considering 90% of my PR is copy pasted from the unflip action's code I wasn't in a rush to test it on Local MP.
The only original code in this PR is
params ["_target", "_caller", "_actionId", "_arguments"];

// Delete the old crew
{
	(vehicle _x) deleteVehicleCrew _x;
} forEach (crew _target);

// Creates a new crew, which will work again.
createVehicleCrew _target;

Closed as I want to clean the branches up and resubmit

Maybe you can have a look to implement this via the objectInits on uavs with enabled inheritance. That's much cleaner, as we currently also going away from these ugly loops for action managing.
Example refs
https://github.com/KillahPotatoes/KP-Liberation/blob/master/Missionframework/kp_objectInits.sqf
https://github.com/KillahPotatoes/KP-Liberation/blob/master/Missionframework/functions/fn_addActionsFob.sqf


Allow XR Session starting and stopping at runtime

Restructures a lot of code to allow creation and destruction of the openxr session at runtime, allowing for hotswitching between xr and desktop or for recreation when the session is lost
wip pr

bevy 0.13 update based in #67

from my testing works on: quest 2, wirvn(monado), steamvr windows. doesn't get past first waitframe on oculus pc runtime


Log Text Changes (Do for Timeline and Notification if needed)

Change the text like applied to this service instead of application done.
Change the text as canceled instead of deleted as well.
Change the text complaint for to complaint about.

Texts are changed.


table newSelected optimization

Signed-off-by: James Talton<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/21937
Had to roll back some packages updates as the travis build were broken.

/lgtm


Unexpected logic for the default store lookup URI

PR #18070 made changes to the default URI used for the store so that the default certificate directory is no longer used - so there is no default store added in this case.
This is arguably a breaking change since it also impacts cases where only the store lookup method is in use without specifying an alternative default URI and without the directory lookup method (in this case there will suddenly be no lookup method at all).
Strangely though specifying the SSL_CERT_DIR environment variable on the command line and specifying the same directory as would have been used anyway suddenly causes the default store URI to use that directory and the store lookup method does get added. The logic here seems unexpected.

See also https://github.com/openssl/openssl/pull/20952#issuecomment-1564232273

Yeah, this is a breaking change in master. The default URI is winstore on Windows and nothing for other platforms. We need to discuss this within OTC if we want to revert it completely (on all platforms) or partially (everything except Windows).

These are the lines with the default store URI for reference:
https://github.com/openssl/openssl/blob/master/include/internal/common.h#L78-L82

I originally wrote a compliant URI parser for STORE use...  I wonder if I still have it around somewhere.

OTC: We should revert the changes to the store handling code. We can keep the winstore provider but it would have to be loaded explicitly.
It will be revisited post 3.2 release.


Added possibility to register multiple verbs for a route

This PR adds support for registering routes with multiple verbs, which comes in handy at times. Essentially, I just widened the method parameter of the Route attribute to accept an array of verbs - everything else is just a consequence of that modification.
The most complex part is uppercasing common HTTP methods, as they are case-sensitive per RFC 7231, so to not break existing implementations and keep the convenience of Route('get'), all methods exposed by the Laravel router will be converted to uppercase.
This PR does not contain any breaking changes.

Thanks! Could you also update the readme with an example of the new functionality?

Sure thing, completely forgot that. I also added a sentence on Any.

Thanks!

Thanks!


implement Path and Slot

close #7

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

1.0.0
GitHub release

Your semantic-release bot :package::rocket:


Blend Data Tab : Feature not available in VS 2022

This feature seems to be missing from Blend for Visual Studio 2022.
I double checked on different project targeting .Net Framework, the data tab never appears. It does appear on Blend for Visual Studio 2019. So either the feature no longer exist or the documentation is lacking information on how to access it.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8b99aa95-1284-6dbc-22a4-e94a713822c3
Version Independent ID: d089529d-cb4d-eb0f-7d97-79179618f04b
Content: Visualize sample data in a XAML UI - Blend for Visual Studio
Content Source: docs/xaml-tools/display-data-in-blend.md
Service: visual-studio-windows
Sub-service: xaml-tools
GitHub Login: @maddymontaquila
Microsoft Alias: maleger

@ttermeer-reboundcg -- Thorvald, thank you for your feedback.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

@maddymontaquila -- Maddy, please look into this issue.

@maddymontaquila Maddy, is the View sample data feature still supported in Blend for VS 2022?

Looks like a bug is already filed for this: https://developercommunity.visualstudio.com/t/triggers-and-data-window-not-available-in-blend-fo/1616950
though it is currently closed.

Closing since this is a product bug. We will need to revisit whether the feature should be identified as VS 2019 only.


Fix min/max restriction in datetime.ts

Short description of what this resolves:
Min/Max restriction doesn't work when min/max hour, minute or second is 0.
0 is falsy and therefore replaced with 23 or 59.
A explicit check for "null" fixes this.
Changes proposed in this pull request:

Ionic Version: >= 3.8, probably earlier too
Fixes: #

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!


Integrate to autodiff lecture the visualization from Simon Shaub

https://simeonschaub.github.io/ReverseModePluto/notebook.html

@pevnak damn, this would be awesome. do you think we can/should try to include pluto notebooks in the course webpage? I have not idea how this plays with Documenter.jl though...


SD-XL cannot be run on a 16G VRAM device with 1024x1024

”Inference at recommended resolution of 16 frames usually requires ~13GB VRAM.“, but I cannot run the SD-XL 1024x1024 on 16G VRAM device. OOM occurs. And I use torch=2.0.1, xformers=0.0.20.

I'm running it on 8GB of VRAM (Actually a bit over 11GB) so perhaps if you share more information about your hardware, drivers as well as inference method we can find what is happening.
I'm running SDXL-16 Frames without OOM on:
GPU: RTX 4060 8GB (Entirely used by the process)
RAM: 32GB (About 3.5GB borrowed during inference)
Nvidia Driver: 545.84
https://github.com/comfyanonymous/ComfyUI/commit/728613bb3e9a42a3e05abf19b1b893eb6ef35081 with the AnimateDiff Evolved extension
Screenshot taken during the inference process:


feat:add-allowedHosts-for-webpack

Support case of remote devserver proxy where webpack hmr server side may validate origin.


contains check on a Collection<? extends Base> gives compiler error

Summary
The example below gives a compiler error.
But if you do a simple list.contains(new ContreteBase()), the program compiles. May be because the method is defined as List.contains(Object o) and not List.contains(E o).
Is there solution for that assertion case in AssertJ already?
Example
public class GenericsHell {

    void aMethod() {
        List<? extends Base> list = new ArrayList<>();

        // Error:(17, 37) java: The method contains(capture#1-of ? extends Base...) in the type org.assertj.core.api.AbstractIterableAssert<capture#2-of ?,java.util.List<? extends capture#1-of ? extends Base>,capture#1-of ? extends Base,org.assertj.core.api.ObjectAssert<capture#1-of ? extends Base>> is not applicable for the arguments (ContreteBase)
        Assertions.assertThat(list).contains(new ContreteBase());
    }

}

interface Base {
}

class ContreteBase implements Base {
}

I think the only solution would be to use Object instead of the generic type in contains, this has been done for isEqualTo but not for any collection assertions, for the time being there is no plan to make collection assertions to take Object type parameter (I'm opened to change this if a majority of users wants it).
Anyway, the not-so-nice workaround is to cast your collection to a List<Base> or List<Object>.

@joel-costigliola Yes, you need to cast it to List<Base> and suppress the warning for the unchecked operation. Ok, let's see if others need it.

+1

So far I feel most of the users expect generics assertions.
Anyone, feel free to comment on this to prove me wrong.

I'm new to AssertJ, so sorry for the question: Is the cast to List<Base> outside of AssertJ still the only option, or is there now a better or an AssertJ-way to narrow down the wildcard?


fix(cta): load icon default variant

What I did

Corrected icon not loading on default variant when no icon attr is present.

Closes #1832
Testing Instructions

Notes to Reviewers

👊 🗯 rebase.  Just gonna close and reopen on main. /stugglefest


Fix dataprovider

Apparently some people try to access data providers not assigned to them. First commit fixes the issue
Cannot read property 'id' of undefined but it's not a really fix for the issue itself.
In the second commit I tried to cover case when user access data provider which is not managed by them. If it happens user is redirected to /data-providers which redirect them to the fist available data provider. It's probably better than blank screen.  I am not entirely sure about the second commit. I had to do some changes I sort of don't  like but there was no other option I could think of.
Based on https://sentry.io/organizations/oacore/issues/1781836363/?project=2091955&query=is%3Aunresolved

case when user access data provider which is not managed by them. If it happens user is redirected to /data-providers which redirect them to the fist available data provider.

It should display an error page. I wonder if Next allows redirecting to the _error with 403 status code and maybe another parameter for the scope but it may not be needed.
I think for such data providers the dataProvider to either null, an instance of the Error or an object like { error: theAccessError }. It can be done in another PR or handled here, the contract is up to you, to me all of them are the same bad at the moment 😁
I will review a bit later

I like the code overall but I did not check how it works. Should I?

Let's hope I tested it correctly
From all options 404 page would suit us best. With the upcoming new version of @oacore/design I will add it.


Run e2e tests in arbitrary namespace

Fixes #166

@houshengbo can you identify exactly why the update test is failing? I've never been able to run it locally as I think it assumes GKE. Some of the infra stuff may assume the knative-serving namespace, too. I'm hoping we can PR changes upstream to make that configurable, if so.


Create window pairs from labeled data

@lsantuari: The create_window_pairs.py fails with the new test data with two chr (see here). I've also ran it locally (use iss27 branch)
./run_local.sh data/test/chr12_chr22.44Mb_45Mb.GRCh37.bam 12 22
...
+ python create_window_pairs.py -b data/test/chr12_chr22.44Mb_45Mb.GRCh37.bam -c 22 -sv gridss -w 200 -p . -l create_window_pairs.log
Traceback (most recent call last):
  File "create_window_pairs.py", line 275, in <module>
    main()
  File "create_window_pairs.py", line 267, in main
    npz_mode=args.save_npz
  File "create_window_pairs.py", line 171, in get_windows
    d = chr_array[chr1][pos1 - win_hlen:pos1 + win_hlen, :]
KeyError: '12'

cat scripts/genome_wide/windows/create_window_pairs.log
2020-03-14 10:09:19,788 Loading file: ./chr_array/22_carray
2020-03-14 10:09:19,797 Array shape: (1000000, 46)
2020-03-14 10:09:19,798 46 channels
2020-03-14 10:09:19,801 593 labels found: Counter({'DEL': 568, 'UK_single_partial': 20, 'noDEL': 4, 'UK_multiple_on_either_windows': 1})
2020-03-14 10:09:19,802 Creating test...
2020-03-14 10:09:19,852 Creating dask_arrays_win1 and dask_arrays_win2...
2020-03-14 10:09:19,852 chr1=12 pos1=392083 chr2=12 pos2=392614

Here label_window_pairs_on_split_read_positions, label_window_pairs_on_svcallset and create_window_pairs should be outside of the for loop.

label_window_pairs_on_split_read_positions, label_window_pairs_on_svcallset and create_window_pairs should be outside of the for loop (see here)

In the commit 9688e3eb79a5f8bbceea71742590c0cda53ba9d6 this has been addressed (see here) but the chr_array jobs still fail for the same reason.
See job accounting info:
https://travis-ci.org/github/GooglingTheCancerGenome/CNN/jobs/665253281#L5828
https://travis-ci.org/github/GooglingTheCancerGenome/CNN/jobs/665253281#L6662
and stderr logs:
https://travis-ci.org/github/GooglingTheCancerGenome/CNN/jobs/665253281#L7029
https://travis-ci.org/github/GooglingTheCancerGenome/CNN/jobs/665253281#L7076
Could you investigate further?

This issue can be closed.


problem with unofficial ROM based on microG

Device name: FP3 - Fairphone 3
Android version: none - ungoogled /e/ v0.23-q based on Android 10
App version: CWA v2.21.1

Describe the bug
I am running the Corona-Warn-App on an ungoogled phone based on the Android 10.
The system is called /e/OS,  a Lineage derivative with nicroG replacing the Google Framework.
MicroG services is used in version v<IP_ADDRESS>816.1
Since the latest update of Corona-Warn-App I am notified that my system is rooted (which is not the case). There must be a misperception. The system is not rooted but not running Google's Android.
Steps to reproduce the issue

Install /e/OS v.023 from https://doc.e.foundation/devices on any compatible device
Install CWA 2.21.1 from the built-in appstore

Expected behaviour
...CWA is running in a flawless manner as on any officially "googled" Andoid deivces

Issue reported as well to microG: https://github.com/microg/GmsCore/issues/1709

@ralxxx
According to https://github.com/scottyab/rootbeer/issues?q=is%3Aissue+is%3Aopen+%2Fe+fairphone there is a known issue (147 - "detect non rooted device as rooted device") with RootBeer reporting root on Fairphone 3 with "/e/OS". There is also a proposed solution in (PR 192 - "checkForDangerousProps: only return true if both props have a bad value") in that repository.
If you tap on "Meldung bis zum nächsten Update unterdrücken" in CWA you will not be bothered by the message until the next update. The "Sicherheitshinweis" is just a warning. It does not block any functions of the app.

Issue reported as well to microG: microg/GmsCore#1709

@bubu wrote in https://github.com/microg/GmsCore/issues/1709#issuecomment-1106919470 that this is not a microG issue. He also mentioned the above RootBeer issue.

This topic was also mentioned in https://github.com/corona-warn-app/cwa-app-android/issues/4268#issuecomment-962694162

what release channel are you on, dev or stable?
/e/ is doing userdebug builds on "dev" (it gets debated now and then), just like LineageOS. The userdebug builds offer a root option via adb (what rootbeer is tripping up on in the prefs). So technically it is rooted, as you can get a root shell.


Using UUID, ForeignKey, and custom tag simultaneously raises IntegrityError

I am trying to implement a Manager that:

Uses a custom tag model
Uses a ForeignKey instead of a GenericForeignKey
Uses UUID as a primary key

I followed the docs and came up with the following:
from django.db import models

from taggit.models import GenericUUIDTaggedItemBase, TaggedItemBase, TagBase

class MyCustomTag(TagBase):
    name = models.CharField(max_length=140)

class UUIDTaggedItem(GenericUUIDTaggedItemBase, TaggedItemBase):
    content_object = models.ForeignKey('docs.Document', on_delete=models.CASCADE)
    tag = models.ForeignKey(
        MyCustomTag,
        on_delete=models.CASCADE,
        related_name="%(app_label)s_%(class)s_items",
    )

My model is as follows:
from django.db import models
from taggit.managers import TaggableManager

from .tags import UUIDTaggedItem

class Document(models.Model):
    name = models.CharField(max_length=140)

    tags = TaggableManager(through=UUIDTaggedItem)

Trying to save the document in the admin raises and IntegrityError. More specifically NOT NULL constraint failed: docs_uuidtaggeditem.content_object_id and UUIDTaggedItem matching query does not exist..
I guess inheriting from TaggedItemBase allows to use a ForeignKey by setting content_object, but then excludes the possibility to add a custom tag attribute. Is it either/or or is there a way to achieve what I am trying to do?
I pushed a minimal repository where the error can be reproduced. Just run the migrations, go to the admin and try to save a document. Thanks.

were you able to generate migrations with them?

were you able to generate migrations with them?

Yes. You can reproduce the error on the example repo I posted.

@pierremonico sorry for the delay on this, I have looked through your example and I think you have kind of mixed up several concepts here, leading to your issues. The short version is "just use TaggedItemBase".
Firstly, I'm going to try and cover the UUID thing. UUID-based primary keys are a propery of the model itself, not of the tags. So for example if you want a UUID-based primary key on your model you end up doing
import uuid
from django.db import models

class MyUUIDModel(models.Model):
    id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)

^ in particular the primary_key=True thing determines that you end up using a UUID as a primary key. Once you do that you gotta fidget with your ForeignKey to get those to work, gonna leave that as homework. The main thing tho is that the UUID stuff isn't really a property of the tagged items, but of the original model.
So what is GenericUUIDTaggedItemBase for? It's for Generic UUID stuff. Generic foreign keys are basically "some primary key + a content type", which means that tags can be used across model types (your tags can be used on documents and clients, for example). But here you want a non-generic thing, so you can just use TaggedItemBase! Basically your error is because you weren't using a generic foreign key, but a standard one.
Aside: while you might want UUIDs on your document, I would recommend not using them as primary keys, and instead just defining a uuid field but letting the database use the default pk internally. For stuff like APIs etc, you can still use UUIDs for lookup, of course! But the default integer stuff is more performant (supposedly, might be less true nowadays) and you won't be swimming upstream. I use UUIDs as exposed identifiers and then override lookup functions to use that instead of the pk.
Anyways yeah if you use TaggedItemBase your problems in your sample go away (tested with your sample app, thank you for going through that! Very helpful). And you won't be using a GFK, and you'll have your custom tag. Making UUIDs be your primary key is a bit of a separate thing you might need to do (and if this is a running system it might be hard to migrate to).


Parse vanguard pdf activity

Provide support to convert Vanguard Activity PDFs into csv files and update Vanguard transaction parsing to use columns from Vanguard Activity PDFs.

This change uses the camelot-py package for PDF table parsing, which in turn requires ghostwriter. That may requires some additional installation to get working. For more details see: https://camelot-py.readthedocs.io/en/master/user/install-deps.html#install-deps

FWIW the tests passed for me without installing ghostwriter or tcl-tk, and CircleCI seems to agree. 🤷♂

The primary motivation of the convert support to go from PDF to CSV is indeed speed. I can export all of my Vanguard activity, which goes back to 2015 and is 116 pages. Converting that to csv takes about 90 seconds, which isn't too bad, but would be limiting if I had to do it frequently.

Got it, thanks. In that case, I suggest that we treat CSV as the expected input, with an optional (convenience) PDF conversion step in front.
In other words, you can provide:

Vanguard-exported CSV, for Positions only
bankroll-exported CSV, for Trades only
Vanguard-exported PDF, which is converted into bankroll-exported CSV, which reveals Trades only

And we could disallow loading Trades without a cost basis (i.e., Trades from Vanguard-exported CSV). What do you think?

I revised my PR here to allow caching the PDF results as a csv so that the user doesn't need to care after the initial run. This removes the need for the convert operation, although I am still allowing a csv output when parsing PDFs. Let me know if this direction works. We may still need to prevent loading without a cost basic.


Apply sx prop to Select's parent for custom styles

Closes https://github.com/primer/react/issues/3599
This PR fixes a bug where the sx prop for the Select component didn't have any effect.
Given the following custom styles, here is the before/after:
<Select sx={{borderRadius: '12px', border: '1px dashed #000000'}}>

Before
After

It seems as though the custom styles need to be applied to the TextInputWrapper component rather than the StyledSelect component, but I'm wondering if there are any drawbacks or complications from applying all of the custom styles to this element.
Rollout strategy

[x] Patch release
[ ] Minor release
[ ] Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[x] Added/updated previews (Storybook)
[x] Changes are SSR compatible
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

⚠ No Changeset found

Here's the format we follow for changesets:
---
"@primer/react": patch
---

Select: Add support for `sx` prop

<!-- Changed components: Select -->


WIP: Add draft of well-documented checklist

Summary
Here I'm adding what will be a checklist for course participants to follow along the course with in regards to their own tool.
The links are not working yet, and I also expect more edits to be made to this checklist as I go through. But I wanted to make sure that this is somewhat uploaded to GitHub.

Oops these changes accidentally snuck in in another PR. https://github.com/jhudsl/ITCR_Documentation_and_Usability/tree/main/templates
I guess I'm closing this for now and will make updates to that checklist as needed.


Revendor in oracle provider support

Sign the opc-compartment-id header

@jan-g looks good, shall we also do a non-bugfix version bump on this?


pkg/ansible/runner; Set role path as env var for runner

This is a short-term fix for https://github.com/ansible/ansible-runner/issues/152. Setting the role path as an environment variable works since --roles-path is not respected from the CLI.

@dymurray The master branch is on lockdown until #615 gets merged.
You should probably make this PR against the rebase-master-add-AO-commands branch.

https://github.com/ansible/ansible-runner/pull/157
This issue was resolved in Runner


Install helmfile from source

what

Install helmfile from source

why

0.19.0 has not yet been released

references

https://github.com/roboll/helmfile/issues/175

https://github.com/roboll/helmfile/releases/tag/v0.20.0 released. Closing this one.


Add API to get status of package name Approval

Resolves https://github.com/Azure/azure-sdk-tools/issues/5364

Are there any tests we can write for this?

Right now we only have manual testing. But we could probably setup automated testing for our APIs


use latest powershell

/infra

Hey, @eosho!
:rocket: Deploying infra to 'wbademo-RG' is beginning! :rocket:


Unable to jspm bundle aurelia-dependency-injection 1.4

I've recently updated to aurelia-dependency-injection 1.4 and I'm unable to bundle with JSPM:
jspm bundle myty/backend/services/* + myty/core/services/* + aurelia-framework + aurelia-bootstrapper + aurelia-loader-default + aurelia-templating-binding + aurelia-templating-router + aurelia-templating-resources + aurelia-pal + aurelia-pal-browser + aurelia-router + aurelia-history + aurelia-history-browser + aurelia-logging-console + aurelia-validation + aurelia-fetch-client + aurelia-plugins-cookies + aurelia-i18n + aurelia-animator-css + aurelia-loader + text + i18next-xhr-backend + url-parse + moment + aurelia-orm + aurelia-api ./tycon/modules/backend/js/myty-aurelia.min.js --skip-source-maps --minify

err  Error on fetch for<EMAIL_ADDRESS>at<EMAIL_ADDRESS>        Loading<EMAIL_ADDRESS>        Loading<EMAIL_ADDRESS>        Loading myty/backend/services/attributes.js
        Error: ENOENT: no such file or directory, open<EMAIL_ADDRESS>
When I downgrade to 1.3.2 its everything fine, because<EMAIL_ADDRESS>is present.

Same when using Webpack. See this post on Discourse: https://discourse.aurelia.io/t/try-to-install-aurelia-cli-but-get-some-issue/1351

this is all going to be - I suspect at least - related to #166 and #167

Released 1.4.1. Please give that a try.

[16:54:15] Finished 'bundleProd' after 6.51 s


Format earnings stats in log output

Format earnings stats in log output.

Format of values (avoid exponential format for small values)
Add separator between values
Add database files to .gitignore

would love to see them in raw_data->[each coin]->earned24h .

@tamaskan @mahiso new PR for AccountStats https://github.com/BitBotFactory/poloniexlendingbot/pull/378


New Sample: Anonymous users support in meetings apps and Anonymous user authentication flow -

Closing this PR as it's a duplicate of: https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/708


Added precompress script

This adds the ability to inject a script before compression.
Can be used for code signing the binaries.
Test needs to be added still.

Rebase had too many conflicts so I created a new branch, see #218


Debug minimal functionality

[ ] Provide minimal code example of needed but buggy functionality
[ ] Write test if possible
[ ] Open related issue for the solution

not relevant anymore


Update status logic to be more customizable

Allow group owners to specify which status that member rule submissions go to. Add dropdown on status selection for owner/admins

Added commit 7ace90a for most of logic. Still need UI element in group manager to update initial status for non-privileged member submissions.

Added commit a749cf0 for UI elements.


feat(tree): unconnected block buffering

Added BlockBuffer that has three main functions:

insert_block for inserting unconnected blocks
take_all_childrens for connecting blocks if the parent gets received and inserted.
clean_old_blocks to clear old blocks that are below finalized line.

It has a limit on the number of blocks that can contain and eviction is done by LRU.
The limit is set to 200 blocks.
On every new blocks that is inserted inside the tree or on the restoration of canonical cache, the tree will try to connect buffered blocks and insert them.

🤖 Generated by Copilot at e7820b2
Summary
📦🌳📝

The pull request implements a block buffer mechanism for the blockchain-tree crate, which allows storing unconnected blocks that are not yet executed and processing them later when their parent blocks arrive. The pull request also modifies the block validation and insertion logic, returns the blocks added to the canonical chain, and adds new configuration and logging features.

Sing, O Muse, of the mighty blockchain tree, the wondrous work of code
That stores the blocks of transactions, the records of the network's load
And how the skilled developers, with lru and tracing tools
Improved its performance and memory, by adding caches and rules

Walkthrough

Add and use BlockBuffer struct to store and process unconnected blocks (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
Change update_block_hashes method to return added blocks and use them to connect buffered blocks (link, link, link, link, link, link, link)
Add and use validate_block method to perform validation checks using consensus layer (link, link, link)
Rename try_insert_block method to try_block_insert and add connected_unconected_blocks method to handle block insertion and buffering logic (link, link)
Add max_unconnected_blocks field to BlockchainTreeConfig struct and use it to limit buffer size (link, link, link)
Add BlockNumHash struct and use it to represent block number and hash pairs (link, link, link, link, link, link, link, link, link, link)
Add tracing dependency and use info macro for logging (link, link)
Remove redundant check for future blocks and change ForkBlock constructor argument (link, link)

great work @rakita! will approve once nits are resolved, no functional change requests

great work @rakita! will approve once nits are resolved, no functional change requests from me

Should be ready for merge :)


bug: Single line comments do not work as intended in .c files

Did you check docs and existing issues?

[X] I have read all the todo-comments.nvim docs
[X] I have searched the existing issues of todo-comments.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.9.4 Build type: RelWithDebInfo LuaJIT 2.1.1692716794
Operating system/version
Windows 10, Ubuntu 24.04 Distro running on WSL 2
Describe the bug
The single line comments // do not work as intended in .c files.
Please have a look at the below snippet:

My question is why are the comments below // NOTE: are also highlighted ?
I also could not find relevant doc regarding behavior with C programming.

I'm not sure if this is intended behavior of the plugin.
Steps To Reproduce

1] Nvim setup using kickstart.nvim
2] There is no modification done to the folke/todo-comments plugin.
3] Create a c file and use NOTE:, the issue is reproduced.

Expected Behavior
There should be no highlighting for the next comment written below //NOTE:
// NOTE: this is highlighted with todo-comment [ This is correct ]
// The line below should not be highlighted, it should be a separate comment

as in C programming, // are defined as single line comment.

Repro
-- Highlight todo, notes, etc in comments
  { 'folke/todo-comments.nvim', event = 'VimEnter', dependencies = { 'nvim-lua/plenary.nvim' }, opts = { signs = false } },
-- There is no other modification done to the plugin.
-- This is the config present under init.lua

This is expected behavior, since option highlight.multiline = true by default. Should close.


Don't bind JSDoc type parameter in a TS file

Fixes #16358
Now that we no longer bind @template tags, had to add some code to getSymbolAtLocation to get find-all-references working again.
Also discovered #16411.

@rbuckton can you please review this change.


Juliaup installer crashes

Hi everyone,
when trying to install Juliaup on my machine, the installer itself crashes immediately after downloading the Juliaup file. During the installation I just kept all settings on their defaults. To install Juliaup I used the recommended curl method described within the README file.
The generated crash report:
name = 'Juliainstaller'
operating_system = 'unix:Arch'
crate_version = '1.7.24'
explanation = '''
Panic occurred in file 'src/operations.rs' at line 675
'''
cause = 'called `Result::unwrap()` on an `Err` value: stream did not contain valid UTF-8'
method = 'Panic'
backtrace = '''

   0: 0x55c073266e04 - juliainstaller::main::h84fedc54940da11e
   1: 0x55c073251d23 - std::sys_common::backtrace::__rust_begin_short_backtrace::hed5660ccc12c4739
   2: 0x55c073251fd1 - std::rt::lang_start::{{closure}}::h2c3639270a40ed75
   3: 0x55c07326acf2 - main
   4: 0x7f41f3890290 - <unresolved>
   5: 0x7f41f389034a - __libc_start_main
   6: 0x55c073251539 - _start
   7:        0x0 - <unresolved>'''

@FireSpike0 This is just a guess without digging too deep:
Do you have any non-UTF8 characters in your path or in your .zshrc / .bashrc / ...?
Narrowing this down further would probably require building a new juliaup version with additional context in the error message.

That would be my guess as well. Unfortunately file systems basically all allow invalid Unicode (true on UNIX where it's invalid UTF-8 and true on Windows where it's potentially invalid UTF-16). For that reason paths in Rust use different types that permit invalid Unicode and you have to unwrap that get a string and that unwrapping operation can fail if the path contains invalid data. What's extra annoying about this is that string operations would work just fine if the language's string type weren't so pedantic about this (which is why Burnt Sushi made a popular string library that allows invalid data in strings; this is how Julia's built-in String type works). Anyway, the upshot is that you probably need to avoid converting to string here to be robust against invalid path names.

My best guess is that this is crashing here. We read the content of your startup shell scripts there, so if there is any non UTF-8 character in say your .zshrc file or something like that it will crash. We can't get around this by using specific path types, the code there is manipulating the content of these files to add the Juliaup folder to the PATH, so I guess what we really need to do is make that code work with non UTF-8 files, if it is actually legal on Unix to have shell scripts that contain non UTF-8 characters...
To get a better error message that would confirm my hypothesis, we would replace
file.read_to_string(&mut buffer)?;

with something like
file.read_to_string(&mut buffer)
    .with_context(|| "Failed to put file content into UTF-8 string type.")?;

@davidanthoff As we briefly discussed, I would be interested in taking a shot at this.
If I had to take a guess, this could be related to environment variables / file system paths in the shell startup scripts. Since non-UTF-8 Paths are allowed, this is the most likely offender.
While googling around a little, there are a number of issues where other applications stumbled over similar problems (e.g. homebrew).
My suggested approach would be to move the file handling from the implicit UTF8-requirement to working with raw bytes.
We do not add non-ASCII characters to the shell startup script under any circumstances, right?
If so, the byte-approach should even be compatible with ASCII-only files.
Finally, regarding the implementation:

Is the block managed by juliaup supposed to be replaced in its entirety when already present?
When not present, it should just be appended to the end, right?
Would you mind taking a dependency on regex? (That would probably be the easiest solution. Just use the regex::bytes functionality and match+replace the entire block.)

My suggested approach would be to move the file handling from the implicit UTF8-requirement to working with raw bytes.

Sounds right.

We do not add non-ASCII characters to the shell startup script under any circumstances, right?

Not from our end. We might end up handling non-ASCII characters in a path, I guess, but if we just pass them through unmodified that should all work, right?

If so, the byte-approach should even be compatible with ASCII-only files.

Yes, agreed.

Is the block managed by juliaup supposed to be replaced in its entirety when already present?

Yes.

When not present, it should just be appended to the end, right?

Yep.

Would you mind taking a dependency on regex? (That would probably be the easiest solution. Just use the regex::bytes functionality and match+replace the entire block.) Edit: bstr should suffice and is probably much lighter than regex

I'm really only concerned about dependencies for julialauncher, I'm trying to keep that as small as possible in terms of binary size. But for juliaup and julialauncher I think it really doesn't matter much. I'm really not good with regex in general, so that was probably the primary reason I just went with an entirely hand rolled implementation ;)
I think essentially all the changes you would have to make are confined to https://github.com/JuliaLang/juliaup/blob/c50a4af79be93a51adb76027ea96c6403f8f0b29/src/operations.rs#L575-L685.


K29-31 for Chives

Is it possible to add k29,30&31 options for Chives? Thank you

Good idea. I also will look into this.

This is how it appears for chives ....


Sorting the table by column is reset when refresh is triggered

If the table is sorted by name and a refresh is triggered, sorting gets reset.

I believe this is the reason...

I just checked the bug and it seems like they fixed it at some point since I put this here. This whole thing was also discussed with @MatthijsSmets in the past when I put this there.
I'll create a PR for a fix.


add Jeju National University

add Jeju National University

@KimJinWoong0802 I am sorry, the domain jejunu.ac.kr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


proxy.golang.org/RegaHawlery

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?

What did you expect to see?
What did you see instead?

By RegaHawlery


Tinkers construct dusts/powder localization

Latest TC, latest EnderIO
Cobalt and Ardite powder for me at least are not properly localized.
E.g. enderio.powderArdite.name
enderio.powderCobalt.name
I assume this is an issue with EnderIO localization.
Thanks.

Oops, I completely forgot to give those items names...
Fixed in next build (157).

Oops, I completely forgot to give those items names...
Fixed in next build (157).


[C++][Parquet] Support INT96 and FIXED_LEN_BYTE_ARRAY types

I would like to add support for INT96 and FIXED_LEN_BYTE_ARRAY parquet types.
Hive data types DATE and TIMESTAMP get mapped to INT96 parquet type.
Hive DECIMAL gets mapped to parquet FIXED_LEN_BYTE_ARRAY type.
Reporter: Deepak Majeti / @majetideepak
Assignee: Deepak Majeti](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mdeepak) / @majetideepak
Note: This issue was originally created as PARQUET-428. Please see the migration documentation for further details.

Deepak Majeti / @majetideepak:
@rdblue, My plan is to first extend the parquet reader to read bits of all the Parquet types (as of today only INT96 and FIXED_LEN_BYTE_ARRAY are missing). Once we complete this, we can support other primitive and complex types (of hive) by just re-interpreting these bits.
I have already started implementing support for INT96 in the reader. I will be happy to discuss the compatibility story at this point. Thanks!

Julien Le Dem / @julienledem:
Issue resolved by pull request 27
https://github.com/apache/parquet-cpp/pull/27

Ryan Blue / @rdblue:
@majetideepak, thanks for taking this on! You're right about the Hive mappings so you'll need this to support DECIMAL and the current TIMESTAMP. A couple of things to keep in mind on that eventual goal: first, while Hive maps decimal to an underlying fixed, there are several primitive types allowed by the spec that need to be supported when it comes time. I'm happy to help when it comes to ensuring compatibility so just open up a JIRA and ping me. Second, the int96 timestamp type has a lot of problems that I'm trying to fix in various processing engines. Again, when it comes time to implement we can help you through the compatibility story.


Doesn't integrate easily

Really wanted to use this but wasted all day on it, too many errors.

Did you try to run my example? I have a few websites that use this component without issues at all. What kind of errors?


Add explanation to bid table

When a bid is carried out, it should be possible to provide an explanation.

An explanation field (TEXT) has been added


Create Web Server command

Feature description
On of the webfren features should be simple web server. It should receive connections and respond with HTML content. User should be able to specify what content will be sent to user.
Technical details
Example usage of command:
$ webfren web-server -p 8000 -r "/home" -c home.html

After running this command webfren should serve home.html file under http://localhost:8000/home route and should display server stats:
Web Server is running:
   - Port: 8000
   - Registered routes (1):
       - /home  -> home.html

As long as server is running it should display stats on every connection:
Web Server is running:
   - Port: 8000
   - Registered routes (1):
       - /home  -> home.html

   Server requests:
      Path: /home Response: 200 -> home.html
      Path: /about Response: 404

Other details
No response

Closed by #13


drivers: display: add support for grayscale displays, st7528i driver

This adds PIXEL_FORMAT_GRAY4 and PIXEL_FORMAT_GRAY16, as well as a driver for the st7528i 16-level grayscale display controller.

I would appreciate some productive feedback.

I would appreciate some productive feedback.

To start, I think it would have been better to engage with the maintainer on the original pull request #53596 that he blocked rather than to close it and make a new one

To start, I think it would have been better to engage with the maintainer on the original pull request #53596 that he blocked rather than to close it and make a new one

Fair, but it didn't seem to be going anywhere, and at the time I didn't have the resources or patience to deal with that.

Fair, but it didn't seem to be going anywhere, and at the time I didn't have the resources or patience to deal with that.

that's fine, but it is possible to reopen a pull request at a later time in situations like this

@arbrauns if you want to implement support for this display, you will likely need to reopen #53596 and address the comments there.


docs: content outline for generator docs

Description

Created a initial outline for generator docs
Added overview section for generator
Created a dummy template creation section for each programming language/framework
I have not added the CLI section yet since parts of the current version are going to be deprecated soon, I can still add the present version and update it once new CLI is introduced, what do you guys think?!

Related issue(s)
Fixes #789

Hey @derberg @alequetzalli @Florence-Njeri !
I need your suggestions on the docs architecture I've created and the content inside introduction.md and how-to-create-a-template.md file.
I have discussed with Florence and she is currently working on authoring.md content. After the docs structure is approved, we will shift the content present in the current files according to the new format right away! (that is, if the reallocation is really needed🤔) what do you think?

also tagging @starlightknown @Annysah @nelsonmic @thulieblack for reviews and suggestions!

@pratik2315 First, apologies for not noticing this PR until now, thank you so much for your patience. In the future, you can also DM me if you notice I am lagging behind in seeing your PR. Just wanted you to not feel shy to remind me. 😸
Second, the main problem to fix here is that you added Generator Tool docs into our /Concepts content bucket. That doesn't make sense, because remember that the /Concepts content bucket is to explain our API spec terms.
Remember: Your docs PR is about the Generator Tool, and that is why this all needs to be moved to the /Tools content bucket. (you should have nothing about tools inside concepts)
Assuming we kept your current outline, you would have URLs along the line of...

docs/tools/generator/overview
docs/tools/generator/filters
docs/tools/generator/hooks
docs/tools/generator/templates
etc

I need your suggestions on the docs architecture I've created and the content inside introduction.md and how-to-create-a-template.md file.

@pratik2315  Ok! I will take extra notice there, thank you for letting me know 😃

I have discussed with Florence as well, she is currently working on authoring.md content.

Great! I look forward to seeing it @florence-njeri ⭐

So I am assuming this is a work in progress, but I was wondering (confused? 🤔 😆) about the and files. What were these empty files added for?

@pratik2315 @florence-njeri Ok, assuming this is the only content you need to add, here's the outline I'm proposing so far... (of course, you should veto me in the order if you know best)...
NOTE: let's put the installation guide inside the TOOLs content bucket, not in tutorials. ❤😄✌🏽 In addition, should we end up with a CLI doc, that too should be in our TOOLs content bucket, not in tutorials.
Tools content bucket URLs:

docs/tools/generator/overview
docs/tools/generator/installation-guide
docs/tools/generator/cli-command-reference (ONLY if this isn't deprecated)
docs/tools/generator/filters
docs/tools/generator/hooks
docs/tools/generator/parser
docs/tools/generator/templates
etc

For this section, I also want you to think about order of your new pages. Does it matter to the user the order of the following pages?

filters
hooks
parsers
templates

If order does matter, then make sure you add page weights that reflect the order in which these pages should be read. 👍🏽

Tutorials content bucket URLs:

docs/tutorials/generator/overview
docs/tutorials/generator/how-to-create-a-template
etc

@pratik2315 Let me know if this doesn't make sense! We can always hop on a call. 📞 😄

@florence-njeri @pratik2315 Would like to recommend you subscribe to the FREE plan of Grammarly: https://www.grammarly.com/plans
The truth is that I will be doing this for all of our work, so it's good for budding TWs to get in the habit of using these tools too. 😄✌🏽
You need to run all your TW drafts through a program like this to catch your first round of grammatical errors, typos, etc. :slightly_smiling_face: I promise this will make your life easier!

And idk how I missed your

Ok @pratik2315 @Florence-Njeri, I have added my preliminary review for the outline, URL structures, and some important info for adding page weights/sub-sections.
I have not conducted an editorial review of your written content yet because I agree with Pratik that the first step is to agree on the new outline.
I look forward to your next draft and response to my feedback! This is great work so far, I am so excited to get to work and learn with you! 🤩🤩🤩🤩

I just saw your responses when I opened this PR, I have no idea how I missed your feedback😓 For some reason, Github didnt send me any notifications about your comments! Yes the content inside needs tons of modifications, I have yet to discuss and confirm with @derberg about the technical terms used in the docs😁 I'll be running my docs through Grammarly first! Thanks a bunchh for your feedback🤩🤩 I'll respond to each of your comments in a moment. And as always, I look forward to work and learn with you too😆😆

@pratik2315 First, apologies for not noticing this PR until now, thank you so much for your patience. In the future, you can also DM me if you notice I am lagging behind in seeing your PR. Just wanted you to not feel shy to remind me. 😸
Second, the main problem to fix here is that you added Generator Tool docs into our /Concepts content bucket. That doesn't make sense, because remember that the /Concepts content bucket is to explain our API spec terms.
Remember: Your docs PR is about the Generator Tool, and that is why this all needs to be moved to the /Tools content bucket. (you should have nothing about tools inside concepts)
Let's pretend we kept your current outline; you'd end up with URLs such as...

docs/tools/generator/overview
docs/tools/generator/filters
docs/tools/generator/hooks
docs/tools/generator/templates
etc

Ohh okay! My mistake, I thought we were having second concepts file under tools🤦♂ thanks for clarifying! I'll move all of those files under tools asap!

@pratik2315 @Florence-Njeri Ok, assuming this is the only content you need to add, here's the outline I'm proposing so far... (of course, you should veto me in the order if you know best)...
NOTE: let's put the installation guide inside the TOOLs content bucket, not in tutorials. ❤😄✌🏽 In addition, should we end up with a CLI doc, that too should be in our TOOLs content bucket, not in tutorials.
Tools content bucket URLs:

docs/tools/generator/overview
docs/tools/generator/installation-guide
docs/tools/generator/cli-command-reference (ONLY if this isn't deprecated)
docs/tools/generator/filters
docs/tools/generator/hooks
docs/tools/generator/parser
docs/tools/generator/templates
etc

For this section, I also want you to think about order of your new pages. Does it matter to the user the order of the following pages?

filters
hooks
parsers
templates

If order does matter, then make sure you add page weights that reflect the order in which these pages should be read. 👍🏽

I may be wrong but order does matter (for me at least). I think its best to explain the concepts in the order in which they are used in Generator library. When I look at it from user point of view, it seems logical😄 but I may be incorrect, What do you think @derberg @Florence-Njeri ?!

Tutorials content bucket URLs:

docs/tutorials/generator/overview
docs/tutorials/generator/how-to-create-a-template
etc

@pratik2315 Let me know if this doesn't make sense! We can always hop on a call. 📞 😄

Hi Pratik, asyncapi-context, I think if I remember correctly, it was just context (not asyncapi-template)
Why would we have an overview again in tutorials I think about it as an introduction to the generator tool just before the user checks how to create a template. Alternatively, instead of adding an overview section in the tutorials, I can link the tools/generator/overview in the how to create template tutorial.
I'll add a note section after the introduction. e.g

NOTE:  This tutorial assumes you have some background knowledge of what the generator tool is and how to use the available templates. If you are unfamiliar with the generator tool, you can checkout our [tools](link to the docs)documentation

thats what I was thinking😁 seems like a perfect way to link users with needed information as you said

Hey there @derberg and @alequetzalli !
Me and @Florence-Njeri  have worked on some changes👨💻👩💻. I have also restructured the content from authoring.md and got it reviewed by Florence since a lot of her previous work was focused on authoring.md. The readmein the docs contains the order in which we have assigned the weights to each section. Can you pls review the these changes😁

@alequetzalli

The new outline is looking better already, we just need to fix the lack of content buckets.

Please have a look at #793 (review). We want to first focus on content, identify missing parts, update and add new ones. Then once we have the content, we can actually focus on a structure. Basically one step at a time, one PR at a time.

thank goodness, I was worried no one had understood the content buckets 😂😂
That sounds great, honestly, with all the comments here that one got lost so now, I read it and feel up to speed. ✌🏽
@derberg

great job so far folks!!!
I left comments, also please:

remove https://github.com/asyncapi/generator/blob/master/docs/templates-recipes.md as it is also not really maintained
update https://github.com/asyncapi/generator#how-to-create-a-template
also we will need to fix links in other repos https://github.com/search?q=org%3Aasyncapi+authoring.md&type=code as because after merging this PR, CI will fail because of broken links

@derberg @alequetzalli I made changes to fix links in the other repos

https://github.com/asyncapi/website/pull/845
https://github.com/asyncapi/ts-nats-template/pull/478
https://github.com/asyncapi/dotnet-nats-template/pull/277
https://github.com/asyncapi/template-for-generator-templates/pull/190

Hey @derberg @alequetzalli ! I think we have made all the needed changes🤔 Can you check if I missed something😅

As per Lukasz's suggestion, I have removed the common assumptions header for now. The content inside Common assumptions is in the same file and not removed. Since, the header discussion is out of scope for this PR and will be discussed in the next one, I thought it best not to remove any of the content stuff.
Special file names is a different section and at the end of the navigation as per this comment😀

Can you pls review if any other changes are needed and point out any mistakes, Thanks a bunch😀

@magicmatatjahu @jonaslagoni @fmvilas yo folks, any objections to getting this PR merged?
it is the first step, just restructuring and splitting what we have, no changes in content itself (like new or rewrite). Followup PRs will be about adding missing documentation, missing reference docs and missing tutorials. And then having it on the website.
it is all part of Google Season of Docs and assignment for @Florence-Njeri and @pratik2315

hmm seems like 1 check is failing and im not sure what is that. any idea @derberg @Florence-Njeri ?🤔

I just checked and saw that this 1 test is failing for all the pending pr's in the generator repository🤔👩💻

@pratik2315 do not worry about it, it is related to https://github.com/asyncapi/generator/issues/8. You did nothing wrong

@pratik2315 do not worry about it, it is related to #8. You did nothing wrong

Ah i see! Thanks😃

@pratik2315 @Florence-Njeri congrats folks 🥳


fix: update to use karpv1 taint

Fixes #N/A
Description
Use the taint defined in kubernetes-sigs/karpenter
How was this change tested?
make presubmit
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 79.134%

Totals

Change from base Build<PHONE_NUMBER>8:
0.01%

Covered Lines:
5943

Relevant Lines:
7510

💛  - Coveralls


operator: stop logging not found as errors

Fixes pruning controller that logs no-op as error and status controller that logs not found as error when deleting cluster operator.

/lgtm
/approve


Added 'Download Audio' button.

Added Audio download button.
I added new function similar to download video, to download audio.
Next small modification I did is,
Added "Youtube Video Title" as downloaded file name instead of "sample"

Everything is Fine but after clicking on Download Audio Button there is a "[Errnno 22] Invalid argument" Error.
Fix this.

Hello, I checked in mine. It is working perfectly no errors![Attached Screenshot] Can you please check it once more?
Or send the error screenshot.

Everythig is working fine.
There is a conflict in your PR, resolve this and again send the PR then I will merge it.

Removed conflicts and added option to ask save location before downloading.

Fix the Erroe and then resend the PR

Now fixed all errors.

@sagarparmar881 Thank you for you for adding this feature.


Bio-Formats 6.8.0 updates

Updates to bump the Bio-Formats version and add the release announcement

https://github.com/ome/www.openmicroscopy.org/blob/master/_data/bio-formats.json should also be reviewed to include the recent contributors

Builds failures due to 6.8.0 docs not yet deployed


refactor: partialize graphql to separate customizations from core wordpress calls

[x] Reorg graphql into more files refs #69

Last thing to do here is to resolve the issue with category pages not building (in case one of you wants to grab today before next client rollout). If not I can get tomorrow.

@ccorda categories are resolved (please note that I commented out a few things in queryContent)


Different lengths compared to Python's struct.calcsize

For a string like BBBBBBBh, jspack and Python give different sizes:
FMT="BBBBBBBh"
$ node -e "console.log(require('jspack').jspack.CalcLength('$FMT'))"
9
$ python -c "import struct; print(struct.calcsize('$FMT'))"
10

This is expected behavior.
Per the readme:
Character | Byte Order
----------------------------------
    <     | little-endian
    >     | big-endian
    !     | network (= big-endian)

If the first character is not one of these, "!" is assumed.

This is different than Python's default choice

If the first character is not one of these, '@' is assumed.

The difference between these is that '@' is native byte order. System dependent. And it's not supported by jspack. The python docs also say

Padding is only automatically added between successive structure members. No padding is added at the beginning or the end of the encoded struct.

Padding i being added for the h because it sites at byte 7. When using the native format, Python wants to put the short at byte 8.
>>> struct.calcsize('BBBBBBBh')
10
>>> struct.calcsize('<BBBBBBBh')
9
>>> struct.calcsize('!BBBBBBBh')
9