webpack-rails now prevents errors from being shown in console

Hi @mipearson. Thanks for webpack-rails! We've been using it successfully for the last few months, with no complaints until now.
Seems this commit prevents linter and compile errors from getting through to the browser console via webpack-dev-server. Instead I see this annoying Rails error screen:

This prevents the project from loading and is a show stopper. Is there a way to turn this off? Also, having this behaviour as default is a breaking change, so I think you should have bumped major version (if you're following semver).
Also I know it's a PITA, but it would be really helpful if you maintained a changelog somewhere. Took us a while to find the issue.
Anybody else hitting this problem: 0.9.7 seems to be the most recent working version.

Ah, right.
Yes, I'm happy for it to be made a flag.
I didn't consider this a breaking change, as at the time I considered that
webpack-rails silently allowing compile bugs to go unnoticed was a bug in
and of itself, and the correct behaviour was to error out. It's worth
noting, also, that this gem is still in 0.x-land, and per semver can be a
bit fast and loose with breaking changes, although I've tried my best not
to be. I'm waiting on integrating react-rails support before I mark 1.0.
I agree regarding a CHANGELOG. I think I will start tracking changes,
almost certainly will be doing so once it hits 1.x.
On Tue, Oct 18, 2016 at 2:31 PM, Rhys van der Waerden <
<EMAIL_ADDRESS>wrote:

Hi @mipearson https://github.com/mipearson. Thanks for webpack-rails!
We've been using it successfully for the last few months, with no
complaints until now.
Seems this commit
https://github.com/mipearson/webpack-rails/commit/882b29f004856f6e76c5a67684df0c73f6ebd983
prevents linter and compile errors from getting through to the browser
console via webpack-dev-server. Instead I see this annoying Rails error
screen:
[image: image]
https://cloud.githubusercontent.com/assets/822105/19463277/5945f230-953e-11e6-9682-f09db0784c72.png
This prevents the project from loading and is a show stopper. Is there a
way to turn this off? Also, having this behaviour as default is a breaking
change, so I think you should have bumped major version (if you're
following semver).
Also I know it's a PITA, but it would be really helpful if you maintained
a changelog somewhere. Took us a while to find the issue.
Anybody else hitting this problem: 0.9.7 seems to be the most recent
working version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mipearson/webpack-rails/issues/63, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF8JfqauGl8itqzoa0hpzhflxArP-ftks5q1D2fgaJpZM4KZVyx
.

--
Michael Pearson

Also, recent changes have been merged (or will be soon) that filter out
"non-error" (ie linter) errors. The intent was this change was for the
Rails developer to see instantly that their JS wasn't available - similar
to if you break something in sprockets - rather than going "what the hell
happened to my JS?" and having to check the webpack log.
On Tue, Oct 18, 2016 at 6:07 PM, Michael Pearson<EMAIL_ADDRESS>wrote:

Ah, right.
Yes, I'm happy for it to be made a flag.
I didn't consider this a breaking change, as at the time I considered that
webpack-rails silently allowing compile bugs to go unnoticed was a bug in
and of itself, and the correct behaviour was to error out. It's worth
noting, also, that this gem is still in 0.x-land, and per semver can be a
bit fast and loose with breaking changes, although I've tried my best not
to be. I'm waiting on integrating react-rails support before I mark 1.0.
I agree regarding a CHANGELOG. I think I will start tracking changes,
almost certainly will be doing so once it hits 1.x.
On Tue, Oct 18, 2016 at 2:31 PM, Rhys van der Waerden <
<EMAIL_ADDRESS>wrote:

Hi @mipearson https://github.com/mipearson. Thanks for webpack-rails!
We've been using it successfully for the last few months, with no
complaints until now.
Seems this commit
https://github.com/mipearson/webpack-rails/commit/882b29f004856f6e76c5a67684df0c73f6ebd983
prevents linter and compile errors from getting through to the browser
console via webpack-dev-server. Instead I see this annoying Rails error
screen:
[image: image]
https://cloud.githubusercontent.com/assets/822105/19463277/5945f230-953e-11e6-9682-f09db0784c72.png
This prevents the project from loading and is a show stopper. Is there a
way to turn this off? Also, having this behaviour as default is a breaking
change, so I think you should have bumped major version (if you're
following semver).
Also I know it's a PITA, but it would be really helpful if you maintained
a changelog somewhere. Took us a while to find the issue.
Anybody else hitting this problem: 0.9.7 seems to be the most recent
working version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mipearson/webpack-rails/issues/63, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAF8JfqauGl8itqzoa0hpzhflxArP-ftks5q1D2fgaJpZM4KZVyx
.

--
Michael Pearson

--
Michael Pearson

@mipearson Right. The webpack log is displayed in console for me via react-dev-server. I'm not sure if this is an optional config or not, but it's one of the main advantages of using webpack - so you don't need to lose your page when you make a mistake. Particularly when using hot module reloading it's pretty annoying to be dragged back to that sprockets-esque error screen.

@mipearson Any chance of cutting a release with an option on top of 0.9.9? I'm using a config option only available in 0.9.9 but want to opt out of this feature.

We've remained had to locked to 0.9.7 until this issue is resolved.

@rhys-vdw I need a config option not available in 0.9.7 or else I can't setup my webpack-dev-server properly so it's accessible both inside and outside a VM. I actually tried rolling back after reading your response.

Oh that might be a problem for us soon when we move to a container based
system. I've linked the commit in the issue report above, so you could fork
and reverse it.
Is there a changelog somewhere? I couldn't find one.
On Sat, Jan 14, 2017, 8:43 AM Nathan<EMAIL_ADDRESS>wrote:

@rhys-vdw https://github.com/rhys-vdw I need a config option not
available in 0.9.7 or else I can't setup my webpack-dev-server properly
so it's accessible both inside and outside a VM. I actually tried rolling
back after reading your response.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mipearson/webpack-rails/issues/63#issuecomment-272555733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyLWbllXx8sdQWwHLsL7SOlWiqermvLks5rR-_jgaJpZM4KZVyx
.

Fixed merged in to  0.9.10

We've just upgraded to latest. How do we disable the page load on JS error?

Actually it seems to be okay now. I experienced an issue where I first loaded the page and was given the Rails error screen with my linter errors and warnings. When I fixed them and reloaded the page the errors remained. I'm not sure if this is related but I'll report in more detail if I see it again.

Okay, I've just had the error again:

Full text:
Webpack::Rails::Manifest::WebpackError at /tests/2b0338793f2/edit
Error in webpack compile, details follow below:
./app/assets/javascripts/components/test-form/usability-test-form.js

/Users/rhys/Projects/usability-hub/usability_hub/app/assets/javascripts/components/test-form/usability-test-form.js
  432:16  error    'DeviceFrameSelect' is not defined  react/jsx-no-undef
  463:14  warning  Unexpected 'todo' comment           no-warning-comments

✖ 2 problems (1 error, 1 warning)

 @ ./app/assets/javascripts/initialize-react.js.erb 460:28-81 473:6-86
 @ ./app/assets/javascripts/application.js
 @ multi (webpack)-dev-server/client?http://localhost:3808 webpack/hot/dev-server application.js

./app/assets/javascripts/components/test-form/usability-test-form.js
Module build failed: SyntaxError: Unexpected token, expected , (815:2)

  813 |   ).isRequired,
  814 |   deviceFrames: PropTypes.arrayOf(UhPropTypes.deviceFrame.require('name', 'id').isRequired).isRequired
> 815 |   projects: PropTypes.arrayOf(PropTypes.string.isRequired).isRequired,
      |   ^
  816 |   testSteps: PropTypes.arrayOf(UhPropTypes.testStep.isRequired).isRequired,
  817 |   s3Config: UhPropTypes.s3Config.isRequired,
  818 |   screenshots: PropTypes.arrayOf(UhPropTypes.screenshot.isRequired).isRequired,

BabelLoaderError: SyntaxError: Unexpected token, expected , (815:2)

  813 |   ).isRequired,
  814 |   deviceFrames: PropTypes.arrayOf(UhPropTypes.deviceFrame.require('name', 'id').isRequired).isRequired
> 815 |   projects: PropTypes.arrayOf(PropTypes.string.isRequired).isRequired,
      |   ^
  816 |   testSteps: PropTypes.arrayOf(UhPropTypes.testStep.isRequired).isRequired,
  817 |   s3Config: UhPropTypes.s3Config.isRequired,
  818 |   screenshots: PropTypes.arrayOf(UhPropTypes.screenshot.isRequired).isRequired,

    at transpile (/Users/rhys/Projects/usability-hub/usability_hub/node_modules/babel-loader/lib/index.js:61:13)
    at Object.module.exports (/Users/rhys/Projects/usability-hub/usability_hub/node_modules/babel-loader/lib/index.js:155:20)
 @ ./app/assets/javascripts/initialize-react.js.erb 460:28-81 473:6-86
 @ ./app/assets/javascripts/application.js
 @ multi (webpack)-dev-server/client?http://localhost:3808 webpack/hot/dev-server application.js

Compare to my webpack output:
16:18:28 webpack.1 | WARNING in ./app/assets/javascripts/components/test-form/usability-test-form.js
16:18:28 webpack.1 |
16:18:28 webpack.1 | /Users/rhys/Projects/usability-hub/usability_hub/app/assets/javascripts/components/test-form/usability-test-form.js
16:18:28 webpack.1 |   166:30  warning  'deviceFrames' is missing in props validation   react/prop-types
16:18:28 webpack.1 |   166:44  warning  'deviceFrameId' is missing in props validation  react/prop-types
16:18:28 webpack.1 |   470:14  warning  Unexpected 'todo' comment                       no-warning-comments
16:18:28 webpack.1 |
16:18:28 webpack.1 | ✖ 3 problems (0 errors, 3 warnings)
16:18:28 webpack.1 |
16:18:28 webpack.1 |  @ ./app/assets/javascripts/initialize-react.js.erb 460:28-81 473:6-86
16:18:28 webpack.1 |  @ ./app/assets/javascripts/application.js
16:18:28 webpack.1 |  @ multi (webpack)-dev-server/client?http://localhost:3808 webpack/hot/dev-server application.js

Note that the errors described in the Rails error have been corrected, but on reload I still get the same error screen from Rails.
Restarting the server seems to be the only way to clear the issue.
It seems the error information is being cached somehow and not updated on reload.
Before this happened I played around by deliberately adding in compile errors into the view and HMR was presenting the errors as usual. Would you prefer I opened a new issue for this @mipearson ?

Resolving all warnings and errors from ESLint permitted the page to load again, but until that time it will show the errors displayed the first time (not the current warnings and errors).

Okay, not always. Now I can fix all the warnings and errors and reloading the page will not clear the error page. I can fix the error by restarting foreman.

PS: Sorry for the influx of comments, @mipearson. I should also point out that I can probably find time to look into this problem myself if that would be helpful.


Next release

When is the next release planned? It's been 2 months since the last one and not all changes are available in https://github.com/angular/material2-builds.

@jakpaw What is missing the material2-builds?

@DevVersion For example this commit: https://github.com/angular/material2/commit/8bb54ca4565a7d55d4f74ca0af4c8e7e02efb462

@jakpaw That's interesting. Those gaps in the material2-builds repository might be caused by various CI flakes. Anyway you should be still able to get 8bb54ca installed by just using the HEAD of material2-builds.
But I suppose you want to install a specific commit (e.g 8bb54ca) of the builds right?

@DevVersion Yes, it would be best if I could install a specific commit. I think I tried to install HEAD of material2-builds and the changes still weren't there, but I'm going to check again.

@DevVersion still about the next release(s), I want to suggest(request) something here...
In many libs/frameworks there's a section in CHANGELOG of non-released changes. Can we have the same here?
I think it could help a lot... for us (who use the material2 to know what will be changed in the next version) and (maybe) up to you because you could write the changes gradually.
See this example.

Released beta.10 today. So far we've been doing one beta release per calendar month (albeit cutting it close for August). They'll be more frequent going forward.
As for changelog, we generate them from the commit messages. GitHub can show you all of the commits from a release, e.g.:
https://github.com/angular/material2/compare/2.0.0-beta.8...master


style() helper with existing material theme

[X] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
I'm looking for this to work similar to the example in the docs under Variants but using the inherited material-ui theme.
Examples 🌈
Attached is a link to sandbox with the replaced code: https://codesandbox.io/s/material-demo-8cs5j?fontsize=14&hidenavigation=1&theme=dark
Motivation 🔦
We're already using material UI in our theme but the existing components don't fit our needs in some cases so we'd like to use the styled() function to build custom typography types.

I'm not sure I understand the issue. Could you expand on actual vs expected outcome. Thanks.

Oh sorry, I just realized I should have specified the problem here. So in the Variants example variant=h1 fontWeight=300 are inheriting the font-size: 30.
In my linked sandbox example, I'm trying to use the styled() function to in inherit the material-ui theme instead as defined here:
const theme = createMuiTheme({
  typography: {
    h1: {
      fontSize: 30,
      lineHeight: 1.5
    },
    h2: {
      fontSize: 25,
      lineHeight: 1.5
    }
  }
});

I've replaced the theme provider with the material-theme provider: <MuiThemeProvider theme={theme}>
This does not work however so I'm trying to find out how to use the styled() with a material theme provider.

Tip: if you use styled-components to render the style, you need to provide the theme to styled-component.


setup.py not copying config files into d2go/configs directory

Instructions To Reproduce the 🐛 Bug:
When running D2Go in Google Colab the setup.py file doesn't copy the configs directory from the d2go folder into the d2go/d2go folder correctly, which leads to the following error when trying to load the model.
RuntimeError: <config path> not available in Model Zoo!

This error comes from the the get_config_file method that attempts to load the config file from the d2go/d2go/configs folder.
https://github.com/facebookresearch/d2go/blob/5aadaaa4b30d19fe8a86970a64aab007dbad6dab/d2go/model_zoo/model_zoo.py#L44-L58
After adding some debug code the method I found out the the configs folder doesn't exist after installing d2go but until now I was unable to find the cause of this error. I suspect that it's caused by the setup.py file  and the changes made in c12469c20a2b3c3d041253ba9903e04eecdc4c89 though.
Also the setup.py file from Detectron2 looks almost identical but there the copying of the configs is working without any issues.
Any suggestions are greatly appreciated.
Related issues:

#173
#170
TannerGilbert/Object-Detection-and-Image-Segmentation-with-Detectron2#11

facing same problem!!

Still facing same problem in google colab. Is there any solution for this.
Note : The very first time i didn't get any issues it works fine and model gets train after some time i tried to train the model I am facing this issue

@Srini138 @dipu0 Does @TannerGilbert 's fix work for you?

@Srini138 @dipu0 Does @TannerGilbert 's fix work for you?

No I didn't try @TannerGilbert fix. I just copy pasted configs folder inside this folder "usr/local/lib/python3.9/dist-packages/d2go" in colab the model runs fine without any error for me

@Srini138 @dipu0 Does @TannerGilbert 's fix work for you?

No I didn't try @TannerGilbert fix. I just copy pasted configs folder inside this folder "usr/local/lib/python3.9/dist-packages/d2go" in colab the model runs fine without any error for me

How did you do this?? Can be more clear, please?


[SPARK-32025][SQL] Csv schema inference problems with different types in the same column

What changes were proposed in this pull request?

This pull request fixes a bug present in the csv type inference.
We have problems when we have different types in the same column.
Previously:
$ cat /example/f1.csv
col1
43200000
true

spark.read.csv(path="file:///example/*.csv", header=True, inferSchema=True).show()
+----+
|col1|
+----+
|null|
|true|
+----+

root
 |-- col1: boolean (nullable = true)

Now
spark.read.csv(path="file:///example/*.csv", header=True, inferSchema=True).show()
+-------------+
|col1          |
+-------------+
|43200000 |
|true           |
+-------------+

root
 |-- col1: string (nullable = true)

Previously the hierarchy of type inference is the following:

IntegerType

LongType

DecimalType

DoubleType

TimestampType

BooleanType

StringType

So, when, for example, we have integers in one column, and the last element is a boolean, all the column is inferred as a boolean column incorrectly and all the number are shown as null when you see the data
We need the following hierarchy. When we have different numeric types in the column it will be resolved correctly. And when we have other different types it will be resolved as a String type column

IntegerType

LongType

DecimalType

DoubleType

StringType

TimestampType

StringType

BooleanType

StringType

StringType

Why are the changes needed?

Fix the bug explained
Does this PR introduce any user-facing change?

No
How was this patch tested?

Unit test and manual tests

Can one of the admins verify this patch?

Can one of the admins verify this patch?

CC @HyukjinKwon @cloud-fan @MaxGekk

@MaxGekk Yes, the last type in inference is StringType in all inference chains. I have change the description to show it better.
The principal difference is than now we have different chains instead of one

Does JSON source have the same problem?

@HyukjinKwon It's exactly what you say, it only happens when the incompatibility is inside one partition. I will change the PR to use compatibleType, and I will make some performance test. Thanks for your help!
@cloud-fan I tested the same situation with json and it works fine, we don't have problems there

I have done some performance tests in my local machine

File: 999999999 lines integers / 10 GB
Resources: 4 Cores

Result without changes:

21m10,114s
20m18,626s
19m46,158s

Results after changes

19m46,388s
22m10,784s
21m15,937s

It seems that we don't have a very significant impact but the tests in local are not the best way to be sure

retest this please

ok to test

Test build #124510 has started for PR 28896 at commit 4629bb5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29130/
Test PASSed.

retest this please

Test build #124512 has started for PR 28896 at commit 4629bb5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29132/
Test PASSed.

Test build #124512 has finished for PR 28896 at commit 4629bb5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124512/
Test PASSed.

Merged to master.

Is that possible we can document the type inference rule? something like the traditional database like https://www.ibm.com/support/knowledgecenter/SSEPGG_10.1.0/com.ibm.db2.luw.sql.ref.doc/doc/r0008477.html
cc @huaxingao @planga82

@gatorsmile I will take a look.

Thanks @huaxingao  If you can't do it for any reason tell me.


Add Assignee

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
Describe each of your changes here to communicate to the maintainers why we should accept this pull request.
Assignee is a simple, instant app switcher. No more mashing Command-Tab to switch to different apps, just assign a shortcut to an app and switch to it instantly
PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[x] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ninjaprox The function is too simple to make any sense


REFACTOR: improve import_nastran method

Codecov Report
Attention: Patch coverage is 85.71429% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 75.89%. Comparing base (1fc4252) to head (84648f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4637      +/-   ##
==========================================
- Coverage   80.83%   75.89%   -4.95%
==========================================
  Files         119      118       -1
  Lines       54524    54469      -55
==========================================
- Hits        44077    41339    -2738
- Misses      10447    13130    +2683


[vcpkg baseline][gpgmm] Don't use bundled vulkan-headers

Describe the pull request

What does your PR fix?
gpgmm has file conflicts with vulkan-headers.

Note that CI didn't test this port and I didn't test it because neither CI nor myself have installed Vulkan SDK. Maybe @bbernhar can help to test this.

This PR does not fix this issue completely, I will open a new PR to fix this completely.

Will be fixed by https://github.com/microsoft/vcpkg/pull/25831.


Create Service Principal Token Provider

Some folks will continue to authenticate using Service Principals (SPs). If there are available SP credentials via popular environment variables (i.e. AZURE_CLIENT_ID and AZURE_CLIENT_SECRET), or if the MSAL Cache is extended to hold these credentials (see https://github.com/AzureAD/microsoft-authentication-library-for-python/issues/14), there should be a token provider to retrieve them.

Closing old PR/issues. The "token provider chain" concept has since been implemented in Azure SDK's Azure Identity package. The MSAL EX package here specialized to become a lower-level building block that focuses on data encryption and cross-process locking.


Codespace sw5park expert dollop wg5q4w5xvqg2974w

Oops, my apologies. I meant to open this on my forked repo


pathogen detection from (direct Nanopore) sequencing data using Galaxy - Updating the training with FAQ and adding an explanation concept

adding FAQ from Feb. workshop to the training, and adding more explanation for whey we keep the human sequences assigned by standardpf to the training

Converting this to a draft for now, please mark it as ready when you're ready for it to be merged :)

Now all the FAQs are updated based on the comments :) Currently I am working on updating the training based on the new workflows, which takes collection not a single file now

@EngyNasr Is this PR ready to be merged?

yup :)


OpenVPN configuration with static challenge

Hello!
I've been trying to configure google-authenticator-libpam to be used with OpenVPNs lib-pam module using a static challenge from the client.
This would allow us to have the user first enter their password and then get another prompt to enter their OTP code.
However this setup requires that OpenVPN is configured with a named query that is supposed to be sent to the pam module for verification:

For example:
plugin openvpn-auth-pam.so "login login USERNAME password PASSWORD pin OTP"
tells auth-pam to (a) use the "login" PAM module, (b) answer a "login" query with the username given by the OpenVPN client, (c) answer a "password" query with the password, and (d) answer a
"pin" query with the OTP given by the OpenVPN client.

source: https://github.com/OpenVPN/openvpn/tree/master/src/plugins/auth-pam
I've tried to configure the plugin to send the static challenge with the named answer pin but it does not seem to be picked up by your pam module.
Is there any way to configure OpenVPN and/or your pam module to be used together with a static challenge?
Thanks!

And the solution of concattenated password and OTP is suboptimal for you?
It sounds like the openvpn-auth-pam.so is expecting a prompt of "pin". Could you try making the prompt be "pin" by passing "authtok_prompt=pin" to the GA module?
Also: please provide exact configs (I assume you don't actually use the login PAM service? In any case what does the service you do use look like in PAM?) and relevant logs (e.g. /var/log/auth.log).
Add debug option to the GA PAM module to get more verbose logs.

Thanks for your quick response, it works perfect now, thanks!
For reference, relevant parts of /etc/pam.d/openvpn for password + OTP with static challenge:
auth    required      pam_google_authenticator.so authtok_prompt=pin
auth    [success=1 default=ignore]      pam_unix.so nullok_secure

And the OpenVPN plugin is configured as:
plugin /path/to/openvpn-plugin-auth-pam.so "openvpn login USERNAME password PASSWORD pin OTP"

Hey @ThomasHabets,
I am trying something similar to what @montaniasystemab is doing. But can't seem to get the Password + OTP static challenge to work, tried a similar configuration.
Logs with debug:
Apr 17 11:06:38 ip-x-x-x-x openvpn(pam_google_authenticator)[17204]: debug: start of google_authenticator for "abcd"
Apr 17 11:06:38 ip-x-x-x-x openvpn(pam_google_authenticator)[17204]: debug: Secret file permissions are 0400. Allowed permissions are 0600
Apr 17 11:06:38 ip-x-x-x-x openvpn(pam_google_authenticator)[17204]: debug: "/etc/openvpn/google-authenticator/abcd" read
Apr 17 11:06:38 ip-x-x-x-x openvpn(pam_google_authenticator)[17204]: debug: shared secret in "/etc/openvpn/google-authenticator/abcd" processed
Apr 17 11:06:38 ip-x-x-x-x openvpn(pam_google_authenticator)[17204]: Invalid verification code for abcd
Apr 17 11:06:38 ip-x-x-x-x openvpn(pam_google_authenticator)[17204]: debug: "/etc/openvpn/google-authenticator/abcd" written
Apr 17 11:06:38 ip-x-x-x-x openvpn[17204]: pam_unix(openvpn:auth): authentication failure; logname= uid=0 euid=0 tty= ruser= rhost=  user=abcd

I was able to get password+OTP working with a different set of configuration, the problem occurs when I try static-challenge.

@pratikjoy7 that sounds more like an OpenVPN question. How to properly send down these things to PAM from OpenVPN.
But in any case you need to prive OpenVPN client and server config, and PAM config, in order for anyone to help you.

Thanks for the quick reply!
Here's my /etc/pam.d/openvpn config:
auth    required      /lib/security/pam_google_authenticator.so secret=/etc/openvpn/google-authenticator/${USER} user=gauth authtok_prompt=pin debug
auth    [success=1 default=ignore]      pam_unix.so nullok_secure

And the OpenVPN plugin config:
plugin /path/to/openvpn-plugin-auth-pam.so "openvpn login USERNAME password PASSWORD pin OTP"

Added auth-user-pass and static-challenge <text> <echo> to the client conf.

Well, if it works without static-challenge then likely the PAM module is configured correctly. I don't know how static-challenge works, so like I said this is more of an OpenVPN question.
But you did not provide your config. Did you put static-challenge pin 1 in the client config? Just a guess. The docs for it are unclear.

As far as I know, the  after static-challenge is what they user would see in the prompt. For example,
static-challenge "Enter google authenticator code" 1 would ask with user for entering OTP with that text. Documentation regarding this is really hard to find. Thanks for your time.

Is there any way I can output the verification code pam_google_authenticator received to syslog or any other relevant logs?

Not without editing the code. You should be able to add a print statement here.

Hello @montaniasystemab,
Can you share your config? and what version are you running?
I've configured the same way as you, but its not working, (works for password+otp).
Thanks!

@franlaborda our OpenVPN server is configured with the plugin directive
plugin /opt/lib/openvpn/plugins/openvpn-plugin-auth-pam.so "openvpn login USERNAME password PASSWORD pin OTP"

Clients need to have the static-challenge directive
static-challenge "Verification code:" 1

Pam configuration:
auth       required                        /opt/lib/security/pam_google_authenticator.so authtok_prompt=pin

In October when we were setting this up we had to compile both the pam module and OpenVPN from source in order to get it to work. At that time there were no public releases available that we could get to work. But current releases might have proper support now..


Bootstrap after installer

Waits for installer to run before calling bootstrap.

Renderer process triggers 'install-check' event to run installer (on main process), instead of main process running installer async on startup.
When installer finishes returns 'installed' to renderer process. On non-MacOS platforms, this returns immediately because we only run installer on start for MacOS.
When 'installed' event received, we dispatch readyForBootstrap and then bootstrap.
readForBootstrap defaults to true on mobile (it doesn't need to wait for anything)

Also added more comments and ability to test this behavior from dev by using KEYBASE_GET_APP_PATH:
KEYBASE_GET_APP_PATH=/Applications/Keybase.app/Contents/Resources/app/ yarn run start-hot

and you'll see the installer run on startup via the app bundle at /Applications/Keybase.app

@keybase/react-hackers

This also has the following benefits:

Don't get connect errors in log when app loads faster than service
Don't need to queue RPC calls (which could remove source of bugs?)

Tested, appears to fix DESKTOP-2845.


New feature @FieldNameConstants(asEnum = true)

This is feature request
Short description
FieldNameConstants with asEnum is not working
Expected behavior
All details are here:
"New features for @FieldNameConstants"
https://github.com/rzwitserloot/lombok/issues/1774

@vyemialyanchyk This feature was already implemented for #547 and will be available in the next plugin release (0.24)

Hello. In the 24th version @FieldNameConstants still does not work as it should. Namely, I mean the parameter asEnum - it just does not work.


feat: upgradeable contracts starter kit, complete with upgrade-safe c…

Purpose:
This PR introduces a new starter kit for upgradeable contracts using the OpenZeppelin Upgrades API (since there is no starter kits right now for this yet, it seems).
Includes:

Upgrade-safe contract (UUPS)
Upgradeable contract deploy script
Updated readme instructions to get contracts deployed, ready for frontend
Script for upgrading function implementation

Testing:

Contracts wise, trivial modifications were made to the original scaffold-eth contract
Otherwise, all upgrade-related items (deployment, upgrade script) was tested by following the readme instructions from start to finish on localhost

Suggestion:

To include this inside a new branch of this repo, or the scaffold eth examples repo.
Feedback welcome, wondering if we should also do a Typescript version of this (wouldn't be too difficult)

@xBalbinus I like this!
Want to make sure it is introduced properly to the community and how we show the new folks how to use SE 🏗
Let's coordinate on this and figure out the best way to introduce 🙌

Great new feature!!
But I think that is best to push it to a new branch. I think that is better to keep the main branch as simple as we can, and then you have the branches with a lot of other examples if you need something else.


[IDEA] Think about usage of js-callgraph project

Hello people and firstly I should to say you are amazing :star: ! Great project ! So long I've searched for something that can help me to understand huge codebase more faster, and I found it I think !
I just want to point you (but maybe you've already seen that) to look into js-callgraph project, maybe it can somehow to help you to create more features

Hi, thanks for the feedback;)
Nice, thanks, will definitely check it out!


Storage config generation

Support generating storage config for each dataset
Ensure it supports the transitive dependency (except for reference)

This means it needs to be released in the correct order.

Unactioned because it's in our driver, but allow it to write configs to a hail bucket. I just don't have an easy way to tell which place to write configs.

I just don't have an easy way to tell which place to write configs.

Aren't you writing to gs://cpg-config/templates/storage/ at the moment, which seems a good place for this?


Can this be used for strategy alerts?

Wondering if the same tool can be used with strategy alerts instead of indicator alerts?
By the way this is a wonderful application and contribution of your part!!!🙏

I think so? Alerts are alerts


Small updates

CircleCi update for chacing ( https://levans.fr/rust_travis_cache.html )
Cargo.toml update
Makefile.toml clean up

Cool!
I will tweak the license thing. As we spoke we can choose Apache-2.0/MIT for the crate. I will add a text in the readme that states that any contribution will be under that licensing too.


Customize the Dark Theme

Issue Title: Customize the Dark Theme
Issue Description:
Enhance the customization options for the dark theme to make it more flexible and user-friendly.
Tasks:
Review the existing dark theme configuration.
Identify areas where customization options can be added, such as additional color choices or typography variations.
Implement these customization options in the theme.
Acceptance Criteria:
Users can easily customize the dark theme by adjusting colors or typography.
The customization options are well-documented for users.

i would like to work on this issue can you please assign to me @Curtis-Thomas

@venkataraviraja5 done, let me know if you need anything :)

dark mode feature is working fine,can you please explain more about this

@venkataraviraja5 dark mode is working but needs some tweaking still, check through for anything that needs to be changed, such as this button hover colors:

@Curtis-Thomas  can i change to white color on hover


Clicking Backup on the "LaunchpadConfig" item makes the count decrease until it hits 1

Turns out this was resolved previously, and I just had an old config file.


Create charts comparing all practices in [CCG] on a measure

Commonly requested by users. Eg. see at a glance which practices have changed in response to CCG policy. Avoids need for printing whole page full of charts, which in any case doesn't work well due to Highcharts issues.
Not really feasible as time trend charts (except maybe for smaller groups like PCNs) but could be done as a bar chart.
Example we could follow:

Or there may be other ways of presenting this.
Ideally we would have available:

A choice of time periods to compare (e.g. years, quarters, months) and a choice of baseline comparison period (e.g. previous quarter (Q4 vs Q3) or matched quarter in previous year (Q4 2018-19 vs Q4 2017-18). Or sliding scales so people choose precise periods of interest.
For all organisations
A horizontal line for Organisation mean / median and/or National mean/median.
Option to download data (for each month to allow other desired custom time periods or subsets of practices to be shown)

In the short term we could stick to doing this for:

CCGs only
latest 12 month period vs previous 12 month period

Options:
1. Individual pages for each measure (i.e. one chart per page).

Title e.g "Pregabalin prescribed as Lyrica by practices in NHS AIREDALE, WHARFEDALE AND CRAVEN CCG - Performance snapshot"
Add additional text e.g. "this chart shows how all the practices in [CCG] performed in the last 12 months compared to the previous 12 months. To see full time trends click [here]"
These could be standalone pages under e.g. https://openprescribing.net/ccg/02N/lyrica/spinechart or https://openprescribing.net/ccg/02N/lyrica/snapshot
Navigate from a CCG page, e.g. under the Explore option we could have:

Split the measure into charts for individual practices (time trends)
Show the measure as a bar chart for individual practices (latest 12 months)

Sort order for practices would need to be decided:

suggest highest to lowest, in latest period
Might be useful to offer alphabetical (later) as well to allow comparisons between performance on different measures.

2.  Embed at top of existing practice breakdown pages

(e.g. https://openprescribing.net/ccg/02N/lyrica/)
People may not realise the charts are still there below (especially if page is slow to load).
We currently have savings and sort order detailed at top of page which are based on 6-month periods which may cause confusion.

3.  Show all measures on one page

This is quite a lot of charts
Might be less useful for users who want to look at single measures, but if sorted in order of performance (somehow), it could help to highlight issues in a different way to what we currently offer.

To me this meshes with the discussion about making custom analysis and measures into the same thing, and with custom groupings.
For any combination of numerator and denominator, I think a user should be able to see:

Time trends with deciles;
Maps;
Single point in time as spine chart and/or histogram; and, per this proposal:
Compare two points in time

And they should be able to do all of these at any grouping level, e.g.:

All practices in a CCG
All practices in an STP
All PCNs in a Region
All EHR software types in England

Related to #1748

Agree @sebbacon - however it seems that could take some time to implement, so if this can be done relatively quickly it would be very useful


Remove CNY Price

No longer exists https://api.cryptonator.com/api/ticker/ark-cny and just causes an error in the console

duplicate of https://github.com/ArkEcosystem/ark-explorer/pull/38


replace use of NSUUID with UUID

motivation: user modern version of foundation utilities
changes: replace use of NSUUID with UUID

@swift-ci please smoke test


Remove class checks for a bunch of quests

@MazeEQ

This isn't every single class check but it should fix all epics at least.


use "isFunction" insteadof "instanceof Function"

why not use "isFunction" insteadof "instanceof Function"  in https://github.com/moment/moment/blob/develop/moment.js#L647 ?
I meet some problem when instanceof Function return false.
isFuntion:https://github.com/moment/moment/blob/develop/moment.js#L340
thank you!

AFAIK, no reason -- it should use isFunction()

Close in favor of PR #3712.  Thanks.


Update eduVPNClient to 3.255.16

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?
[X] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installer Verification Analysis Context Information:
Installer https://github.com/Amebis/eduVPN/releases/download/3.255.16/eduVPNClient_3.255.16_ARM64.msi
Scan request id: 'c5e04d22-4f17-4d7d-a3af-6d487c31009b'

Installer https://github.com/Amebis/eduVPN/releases/download/3.255.16/eduVPNClient_3.255.16_x64.msi
Scan request id: '3bad1167-1ff3-4375-8ef9-7d9be009e455'
Installer https://github.com/Amebis/eduVPN/releases/download/3.255.16/eduVPNClient_3.255.16_x86.msi
Scan request id: '60fd666f-c39d-49af-9e86-c7fe487ce2dc'
Error information: RequestContainsTooManyFlaggedFiles
(Automated response - build 876.)

Unfortunately, there were some false-positives in antivirus solutions. Went through the list on VirusTotal and submitted requests to remove eduVPNClient_3.255.16_x86.msi from their lists.

URL: https://github.com/Amebis/eduVPN/releases/download/3.255.17/eduVPNClient_3.255.17_ARM64.msi
Status code: 200
(Automated message - build 613)


Added a list of source to get Datasets

This PR contains an additional classification for US specific datasets which are a good source of machine learning.

Thanks!


bug fix in .Read(), null is not 0 in RunFileCallSync

This is the error I was getting
`
$file = Get-NtFile <some_path> -win32path
$file.read(5)
Exception calling "Read" with "1" argument(s): "(0xC000000D) - An invalid parameter was passed to a service or
function."
At line:1 char:187

... t-NtFile C:\Users\ben\Documents\desktop.ini -Win32Path; $file.read(3)

                                                        ~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : NtException
`

I'm not a c# person and I didn't dive into if there are underlying problems beyond where I made my fix.  While I would have expected null and 0 to be the same, they don't appear to be so I just made the lowest level fix that made sense to me.
let me know if you have any questions.

added CLA

Thanks for that, however the behavior is intentional. By default the code opens the file in asynchronous mode. In this mode the kernel does not track the current position of the file pointer so you must always explicitly specify the offset you want to read the bytes from. The reason there's a difference between null and 0 is in synchronous mode you don't need to specify the offset at all. That parameter is optional so it's okay to pass null, however you can specify it if you wanted to. For async you must specify the offset regardless, but the Read method does not try and help you here as it doesn't even know what offset you want to read from.
Therefore you'd need to do one of two things to correctly read data, either pass the position e.g. $file.Read(5, 0) or open the file in synchronous mode e.g. $file = Get-NtFile <some path> -Win32Path -Options SynchronousIoNonAlert -Access GenericAll,Synchronize

Got it!  Thanks for the response!  Sorry!


Don't update retry state when failed to get ack response. fix #1665

Ack failure is not buffer flush error so it should not update retry state.
It create invalid retry state and this causes busy loop.
The problematic node is disabled and its node is excluded at next flush after rollback.
So non-acked chunk should be retried next flush.
To resolve this problem, we add update_retry parameter to Output#rollback_write.
This parameter controls rollback considers retry or not.

I can't fully get what this commit means yet, but I feel that retry strategies should be applied to the set of "commit_write + rollback_write" in the case of async buffered output.

I feel that retry strategies should be applied to the set of "commit_write + rollback_write" in the case of async buffered output.

Yeah, generally yes. But out_forward removes problematic node from the active node list, so immediate retry is no problem. If we retry flush with same destination, retry state should be updated.

@repeatedly I'm currently testing this behavior and I will patch my 14.22.rc2 with this and report back

Use keyword argument. This is more clear than before.

@mururu How about this? I will consider changing retry status management but it needs more time to re-desing internal mechanzim. So this temporary fix seems acceptable for out_forward.

@repeatedly Fair enough. Then it is good to add comments for that.


Model smart contract does not publish GET method on ICON block explorer

[x] Access to ICON block explorer, check our deployed smart contract and see that  tab doesn't show any GET methods: https://bicon.tracker.solidwallet.io/contract/cx26d2757d45ea7e559940d86761330005b0e9f2d8#readcontract

[x] Fix issue that cannot deploy sm via SDK: error [RPC ERROR] fail tx invalid signature

Fixed #106


[POC][Do not merge] ESM module distribution improvements

POC for improving the ESM module distribution of the packages.

Add exports key pointing to import and require files
Add file extensions with babel-plugin-add-import-extension

Missing:

Types
UMD build broke, have to figure out why, removed it for the POC

The first test is working as expected ✅
The next step is to sort the CI tests out.

All of this looks reasonable to me 👍

Regarding the CI issues. It looks like the snapshot size test is looking for the umd build. Which was removed in this PR. We can also get rid of the size test as well:
diff --git a/scripts/sizeSnapshot/create.js b/scripts/sizeSnapshot/create.js
index b8b68e60b4..1ed2f343e1 100644
--- a/scripts/sizeSnapshot/create.js
+++ b/scripts/sizeSnapshot/create.js
@@ -56,11 +56,7 @@ async function getWebpackSizes(webpackEnvironment) {
 async function run(argv) {
   const { analyze, accurateBundles } = argv;

-  const rollupBundles = [path.join(workspaceRoot, 'packages/mui-material/size-snapshot.json')];
-  const bundleSizes = lodash.fromPairs([
-    ...(await getWebpackSizes({ analyze, accurateBundles })),
-    ...lodash.flatten(await Promise.all(rollupBundles.map(getRollupSize))),
-  ]);
+  const bundleSizes = lodash.fromPairs(await getWebpackSizes({ analyze, accurateBundles }));

   await fse.writeJSON(snapshotDestPath, bundleSizes, { spaces: 2 });
 }


Revert "Set assembly versions by MSBuild"

Reverts PowerShell/PowerShell#3917
Allowing additional time for review

@mirichmo Thanks for the quick turnaround on this!


stress: fixup with latest Reconnect api

Codecov Report

Merging #289 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   99.24%   99.23%   -0.01%
==========================================
  Files          72       59      -13
  Lines        3162     2490     -672
==========================================
- Hits         3138     2471     -667
+ Misses         14       11       -3
+ Partials       10        8       -2

Flag
Coverage Δ

#dot
99.23% <ø> (-0.01%)
:arrow_down:

#dot_changes
100% <ø> (ø)
:arrow_up:

#dot_changes_diff
100% <ø> (ø)
:arrow_up:

#dot_changes_run
100% <ø> (ø)
:arrow_up:

#dot_changes_table
100% <ø> (ø)
:arrow_up:

#dot_changes_types
100% <ø> (ø)
:arrow_up:

#dot_example
100% <ø> (ø)
:arrow_up:

#dot_log
100% <ø> (ø)
:arrow_up:

#dot_ops
98.32% <ø> (ø)
:arrow_up:

#dot_ops_bolt
97.56% <ø> (ø)
:arrow_up:

#dot_ops_nw
96.74% <ø> (ø)
:arrow_up:

#dot_ops_pg
97.6% <ø> (ø)
:arrow_up:

#dot_ops_sync
99.06% <ø> (ø)
:arrow_up:

#dot_refs
100% <ø> (ø)
:arrow_up:

#dot_streams
98.91% <ø> (ø)
:arrow_up:

#dot_streams_undo
100% <ø> (ø)
:arrow_up:

#dot_test_seqtest
100% <ø> (ø)
:arrow_up:

#dot_test_testops
100% <ø> (ø)
:arrow_up:

#dot_x_dotc
98.76% <ø> (ø)
:arrow_up:

#dot_x_fold
?

#dot_x_heap
?

#dot_x_meta
?

#dot_x_rt
?

#dot_x_ui_collab
?

#dot_x_ui_dom
?

#dot_x_ui_html
?

#dot_x_ui_input
?

Impacted Files
Coverage Δ

x/ui/collab/keyboard.go

x/ui/html/html.go

x/ui/html/reconciler.go

x/ui/html/events.go

x/meta/stream.go

x/fold/fold.go

x/meta/meta.go

x/ui/collab/text.go

x/ui/dom/dom.go

x/rt/formatted.go

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fca247...1c14873. Read the comment docs.


Difference between PS rule and template analyzer of microsoft/security-devops-action

As title
It seems that both of them can analysis the IaC bicep

Duplicate of https://github.com/microsoft/PSRule/issues/1866


default weather module appears to be showing the 'feels like'

The default weather module appears to be showing the 'feels like' temperature in the 5 day forecast rather than the forecast temperature.
snippet from config.js attached
{
			module: "weather",
			position: "top_right",
			config: {
				weatherProvider: "openweathermap",
				type: "current",
				roundTemp: "true",
				location: "Fresno",
				locationID: "4692400", //ID from http://bulk.openweathermap.org/sample/city.list.json.gz; unzip the gz file and find your city
				apiKey: "xxxxxx"
			}
		},
		{
			module: "weather",
			position: "top_right",
			header: "Weather Forecast",
			config: {
				weatherProvider: "openweathermap",
				type: "forecast",
				roundTemp: "true",
				fade: false,
				location: "Fresno",
				locationID: "4692400", //ID from http://bulk.openweathermap.org/sample/city.list.json.gz; unzip the gz file and find your city
				apiKey: "xxx"
			}
		},
		```

The forecast shows not one temperature but rather max and min temperature for the day. So it might appear like the feelslike temp but I think it isnt.

related to forum thread https://forum.magicmirror.builders/topic/17916/default-weather-module-question

you can use a web browser and get the delivered json by using this url: https://api.openweathermap.org/data/2.5/forecast?id=4692400&units=metric&lang=en&APPID=xxx
you have to substitute xxx by your apiKey.
You can see the values in the json.
I used jq and tested some days for your location with
❯ cat tmp.json | jq -r '.list[] | select(.dt_txt? | match("2023-07-20.*")) | "\(.main.temp_min) \(.main.temp_max)"'
34.99 35.38
27.53 27.53
25.53 25.53
25.1 25.1
25.04 25.04
31.86 31.86
38.28 38.28
39.9 39.9

❯ cat tmp.json | jq -r '.list[] | select(.dt_txt? | match("2023-07-21.*")) | "\(.main.temp_min) \(.main.temp_max)"'
34.41 34.41
27.65 27.65
25.88 25.88
25.48 25.48
25.56 25.56
32.1 32.1
38.66 38.66
39.91 39.91

and the displayed values in the mirror (Tomorrow and Fri) are correct

Is there any update on this issue? The Weather module forecast (openweathermap) is showing the "feels like" (heat index) temperatures (at least for the high/max) in the five day forecast. This has been going on for a while.

As I wrote above, I cannot redproduce the error yet. @jca2112 you have the problem with the openweathermap provider?

@jca2112 you have the problem with the openweathermap provider?

Yes, using the default openweathermap config I've had for a long time - have not tried another provider.
I know that the weather forecast config does not use "showFeelsLike: false", but I tried adding it (and also to the weather current module above it) and confirmed that setting had no effect on the 5 day forecast. I believe this is the api url:
https://api.openweathermap.org/data/2.5/forecast?id=4076607&units=imperial&lang=en&APPID=enterkeyhere

Is there any update on this issue?

I did already a deeper analysis in a comment above which prooved that the weather module displays the forecast temperature data provided by openweathermap.
If someone can provide the json (as file) from openweathermap and a corresponding screenshot of mm we can discuss it deeper again.

closing for now, if someone provides an example we can reopen.


LaTeX in text control

Description
Add the possibilty to use LaTeX within the pages using this type of expression :
$$ your equation $$
This could be interesting to display the equation at the origin of a calculation made in our Taipy app.
Solution Proposed
Add a 'latex' mode to the text control.
Impact of Solution
No response
Additional Context
No response
Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

Can I take this issue for Hacktoberfest and DevFest AI?

@kaze-droid Thank you for your help.


Extension checks for roms

It seems like, only a few extensions are allowed to pass through the uploader.
My GBA roms are zipped (and I guess only *.gba are allowed) and the *.bin were blocked for the Atari2600.
Not sure if there are other missing extensions somewhere else, but I guess it's not so tough to extend the list for each system.

@rockaddicted has pulled some changes to add zip extension support for some system, you can see its changes on https://github.com/recalbox/recalbox-manager/pull/44/files
All in all, Recalbox should include the Manifest so i dont have to manage it myself, because i dont really follow the systems news, better to talk with @rockaddicted or @digitalLumberjack about extension support, as i won't add support myself without their acknowledgement

Ok 'bin' extension support has been confirmed and added to the manifest to come in 1.1.5, 'zip' extension support for GBA has allready been added by @rockaddicted in its pull request.


Got an error on Dockerfile

File: get-started/part2.md, CC @johndmulhausen
Adding following line
COPY . /app

before
WORKDIR /app

fixed it.

Can you share the Dockerfile you were using and the error that you got? I can't seem to reproduce this.

No response from user, no idea what they were doing or what page if any they were on; I think we should just close this.


TEI-export of written date

https://pmb.acdh.oeaw.ac.at/apis/tei/person/14946
see here, we have a <ISO-DATE> in the export. this is not valid

change TEI export to exclude the part after <or between <and >


Custom  field design changes in company , contact

Custom field k baju me bracket me group name aa raha hai woh hatana hai
Custom field me (-) dalna jaroori hai user ko yeh takleef nahi honi chahiye. woh backhand me manage karna hai baki jaise simple text hota hai wasa dikhna chahiye

Too much at stake to enable this

I mean user is typing display text and we can manage rest of things. this field will still be there not visible to user

Later on jub search ayega, user wahi search karega jo use dikhega,
Uniqueness maintain karne ke liye kiya gaya he


Write log-levels system

Currently, we debug everything. We should have some log-levels defined, and we can select what level we want in regolith.json.
Maybe Error, Warning, Log, Verbose, VeryVerbose?

We already have levels. Those are Panic, Fatal, Error, Warning, Info and Debug. Currently there is only switch between Info and up and debug flag, that will also show debug info. I think it's enough log levels. We just need to move all stuff, that's not critical to debug.


Error from Azure

When running this and going to /task it just bounces me back with an error:
error: "invalid_request",
error_description: "AADSTS90014: The request body must contain the following parameter: 'response_type'. Trace ID: ******************* Correlation ID: ******************* Timestamp: 2015-03-17 20:55:34Z"

Even though the URL clearly has a response_type in it:
https://login.windows.net/***************/oauth2/authorize?api-version=1.0?response_type=code&redirect_uri=**************&client_id=***********

Did you ever get this to work? I can't reproduce it on this side.

Azure Portal ("View Endpoints") displays the OAuth2 Authorize URL as https://login.windows.net/***************/oauth2/authorize?api-version=1.0. When this URL is set for auth_endpoint in token.js, Passport will append all of its parameters starting with another question mark, effectively sticking all parameters into the api-version parameter.
I tried removing the api-version parameter. This results in TokenError: AADSTS50001: Resource identifier is not provided. .  Just in case there is actually more than one API version, I also tried with a correct URL containing the api-version parameter (by modifying passport-oauth's strategy.js), but that also results in that same error.
To fix the missing resource identifier, I tried adding a resource parameter (set to 00000002-0000-0000-c000-000000000000, similar to what I've seen in the Azure AD Node.js sample code). This does seem to result in a token, but the sample code then fails with ReferenceError: User is not defined at OAuth2Strategy._verify. I believe this has already been reported as a bug here.

Can you try this again? We've made many changes since April.


Debian 12 - NanoPi R5C Unsupported machine

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
NanoPi r5c being unsupported machine while proxmox itself is running on debian 12.
What settings are you currently utilizing?
Advanced Settings
Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
Installing Debian 12 VM on NanoPi R5C through the script

Can you give some of the errors you encountered?

Can you give some of the errors you encountered?

Using Advanced Settings
Virtual Machine ID: 102
Using Machine Type: q35
Using Disk Cache: None
Using Hostname: debian
Using CPU Model: Host
Allocated Cores: 1
Allocated RAM: 2048
Using Bridge: bridge
Using MAC Address: 02:B3:80:C8:E9:56
Using Vlan: Default
Using Interface MTU Size: Default
Start VM when completed: yes
Creating a Debian 12 VM using the above advanced settings
✓ Using local for Storage Location.
✓ Virtual Machine ID is 102.
✓ https://cloud.debian.org/images/cloud/bookworm/20240507-1740/debian-12-nocloud-arm64-20240507-1740.qcow2
✓ Downloaded debian-12-nocloud-arm64-20240507-1740.qcow2
✓ Created a Debian 12 VM (debian)

Starting Debian 12 VM...kvm: unsupported machine type
Use -machine help to list supported machines
start failed: QEMU exited with code 1

[ERROR] in line 412: exit code 255: while executing command qm start $VMID

Are you able to run uname -m for me please to make sure its aarch64?

Are you able to run uname -m for me please to make sure its aarch64?

uname -m:
aarch64

try i440fx machine type in script advanced mode, if that works for you then ill get rid of q35 from script


beta crop long images issue

Steps to reproduce
This is just an inconvenience that happens when you activate the feature and don't have a proper steps to reproduce.
When you have slow internet or the site have low bandwidth or your device have low processing power and the pages don't load on time the reader will not catch with the request and try to jump pages but then the cut pages feature caught with the pages and advance
-load a webtoon with long pages (usually I read the ones that have 3 pages long)
-the page don't load on time and the page is skipped
-the page then load and instead of start still or go back one page it goes forward the same amount of pages cut in this case it goes forward 3 pages
Expected behavior
The reader jumps pages when there is no loaded pages
Actual behavior
The cut pages feature should be disable when the current page don't load and activate itself again when the user prompt 1 or 2 actions one or two taps, because it means you notice the no loading or continue
Crash logs
No response
Tachiyomi version
App version: 1.8.5 (standard, 792746dce, 42, 2022-11-03T01:47Z) Preview build: 489
Android version
12 (SDK 31) Android build ID: SP1A.210812.016.X200XXU1BVI6
Device
Device manufacturer: samsung Device name: gta8wifi Device model: SM-X200 Device product name: gta8wifixx
Other details
No response
Acknowledgements

[X] This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.8.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Long page crop is a main Tachi thing, if you have issues with it please direct them to the main Tachi repo


Support url starting with www

I wanted to support url like www.github.com also, I could have add it using a patter but I thought it could bu useful for someone else, let me know if you think this is relevant :grin:

@kemcake sorry for the late reply, thanks for the PR. I think this might be good but what you changed might not allow http://www.google.com anymore, can you write a test for it? thanks

@jrichardlai  I tested this PR with http://www.bing.com and http://bing.com and it works fine :)

Yes both should work, but agree I should write a test!
(Sorry I missed the previous reply 🙃)

any plan to merge and bump npm version for this?

Woops, I was waiting for a test and forgot about it, I'll test it out and merge it then add a test.

@teyou available in 0.0.16

cool. However, I noticed one issue with Linking.openURL().
seems http:// or https:// is a must
so either this library will auto append "http://" or we have to do it manually in order to open the weburl using LInking.openURL() method.
reference: http://facebook.github.io/react-native/releases/0.34/docs/linking.html#openurl

This library is just about parsing a text and doing some action with it it could also replace the text before rendering it. So in this case you will have to append this manually.
Sent from my iPhone

On Sep 24, 2016, at 10:00 PM, Rudy<EMAIL_ADDRESS>wrote:
cool. However, I noticed one issue with Linking.openURL().
seems http:// or https:// is a must
so either this library will auto append "http://" or we have to do it manually in order to open the weburl using LInking.openURL() method.
reference: http://facebook.github.io/react-native/releases/0.34/docs/linking.html#openurl
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the merge !


Does it make sense to use both DllReferencePlugin and HardSourceWebpackPlugin?

I have been looking into ways to optimize our build speed, and arrived at the caching options offered by DllPlugin/DllReferencePlugin and HardSourceWebpackPlugin.
Installed and examined both HardSourceWebpackPlugin and DllPlugin/DllReferencePlugin. (Side note: I used AutoDllPlugin, which provides similar behavior to HardSource in terms of detecting when DllPlugin should recompile its cache).
Both plugins seem to do great work. I measured the following with webpack-dev-server:
Vanilla
Original build time: ~48 seconds
Rebuild after quitting the dev server: ~44 seconds
Subsequent HMR after small JS change: ~7 seconds
Subsequent HMR after small CSS change: ~1 second
DllPlugin/DllReferencePlugin (using AutoDLLPlugin)
AutoDLLPlugin initial build time: ~50 seconds
Rebuild after quitting the dev server: ~42 seconds
Subsequent HMR after small JS change: ~6 seconds
Subsequent HMR after small CSS change: 2-3 seconds
HardSource
HardSource initial build time: ~58 seconds
Rebuild after quitting the dev server: ~2.5 seconds
Subsequent HMR after small JS change: ~3 seconds
Subsequent HMR after small CSS change: ~1 second
HardSource and AutoDLLPlugin
Initial build time: ~62 seconds
Rebuild after quitting the dev server: ~3.6 seconds
Subsequent HMR after small JS change: ~3 seconds
Subsequent HMR after small CSS change: 2-3 seconds
I took these measurements because I am under the impression people are using both plugins in tandem (please see the references at the bottom). However, through my experiment I can draw a few conclusions:

HardSource exhibits marginally better results than DllPlugin, except for:
The area with the largest impact: consecutive full builds (ie. quitting the dev-server and starting it again). It is clear as day that HardSource really shines here and it is evident that the improvement here is on a whole other scale comparing to the rest of the measurements.
Overall and except for the previous point (which is arguably the most important one if we are considering CI/CD), in all other measurements the gains are nothing to write home about.
DllPlugin actually improved full rebuild time (not nearly as much as HardSource though), and very slightly improved JS HMR, but actually slowed down the time it takes to HMR CSS changes.
Combining HardSource and DllPlugin in this experiment did not prove to be beneficial. In fact, all of the gains made possible by HardSource (except JS HMR) were actually hurt by introducing DllPlugin (by way of AutoDllPlugin).

@mzgoddard @sokra @timse @asfktz
I made this experiment in the hope of sparking a discussion and hopefully a process towards a community standard for tackling performance and build caching with Webpack.
References:

0–100 in two seconds — speed up webpack

Keep webpack Fast: A Field Guide for Better Build Performance

How we improved webpack build performance by 95%
High-performance webpack config for front-end delivery

I'll try alpha 0.6 and update here! Cheers :)

I started timing even more extensive metrics than last time. I'll update soon ;)

@mzgoddard @TheLarkInn @timse @asfktz
I have an update for ya'all!
I'll start with the takeaways and if you want all the fine details, you will find them below.

Takeaway no. 1: With webpack-dev-server, the gains introduced by HardSource are just mind blowing. AutoDllPlugin on the other hand, not only does not speed things up but it actually slows WSD down.
Takeaway no. 2: On production builds, AutoDllPlugin reduces the initial build time (before DllPlugin caches anything!). HardSource shortens consecutive builds, but increases the initial build time.
Takeaway no. 3: Using HardSource and AutoDllPlugin in tandem in our production build cut its time by 66% (ie. 3 times shorter!)

Let's get straight down to business. All measurements are in seconds and shorter is better:
Dev builds with webpack-dev-server

In the above chart it is obvious and incredible how HardSource just blows DllPlugin out of the water by reducing the cold rebuild* time comparatively to the time it takes WDS to do one HMR. AutoDLL fails to optimize anything, and combining it with HardSource only takes away from the its staggering optimization.
* cold rebuild means running WDS for the second time, after running it once and quitting it entirely.

Comparing first HMR to subsequent HMRs: I noticed a telling pattern where the time to HMR decreases exponentially up to a certain point. In other words, the first HMR after WDS finishes initialization would take the longest, and any subsequent HMR sequence takes less and less time until, I guess, a technical limit. The difference between the two is small (4 seconds at the most), but it was repeatable and therefore is another metric to go by when comparing the performance of the plugins.
Takeaway: HardSource's superiority is again evident and based on all of my WDS measurements, it can be said DllPlugin brings no value with WDS.
Production builds with webpack
Comparing dev to production: I decided this time to take a more extensive approach and measure not only webpack-dev-server but also our production configuration.

Takeaway: There's something very interesting happening here: AutoDLLPlugin cut our initial build time, that is, before it was able to cache anything, by 10% (8 seconds). That took me by surprise! Using HardSource, reduces the build time with its cache, but results in a longer initial build time.

Now we'll look at the most significant metric. In the last chart featured right above, I am comparing between the initial production build time and rebuild with each plugin by itself and finally with both of their superpowers combined. As the numbers tell, for non-dev-server webpack, the combination of HardSource and AutoDllPlugin shortened the build from 75 seconds to 25 seconds. That's 3 times shorter!

Similar question, does it make sense to use cache-loader and hard-source-webpack ? I seem to get similar results with either one:
Default build time: ~1min15sec
CacheLoader
 SMP  ⏱
General output time took 30.31 secs

 SMP  ⏱  Plugins
BrotliPlugin took 9.7 secs
OptimizeCssAssetsWebpackPlugin took 9.48 secs
TerserPlugin took 0.652 secs
VueLoaderPlugin took 0.303 secs
WebpackWatchedGlobEntries took 0.132 secs
AssetsWebpackPlugin took 0.041 secs
MiniCssExtractPlugin took 0.016 secs
ContextReplacementPlugin took 0.009 secs
ProvidePlugin took 0.006 secs

HardSource (default settings):
 SMP  ⏱
General output time took 35.39 secs

 SMP  ⏱  Plugins
TerserPlugin took 12.94 secs
OptimizeCssAssetsWebpackPlugin took 10.026 secs
BrotliPlugin took 9.77 secs
HardSourceWebpackPlugin took 1.29 secs
WebpackWatchedGlobEntries took 0.127 secs
AssetsWebpackPlugin took 0.109 secs
MiniCssExtractPlugin took 0.023 secs
ContextReplacementPlugin took 0 secs
ProvidePlugin took 0 secs
VueLoaderPlugin took 0 secs


Interactive 3D Cross Plot

What is your suggestion?
I have not seen a method to make a 3D cross plot in Altair. Please excuse me if I missed it.
Have you considered any alternative solutions?
We use the interactive capabilities of Altair to help us explore our data. For example, we calculate NDVI from our spectrometer data and then plot NDVI for all of our Test targets. Altair lets us observe the actual photos of our test targets on this plot for a better understanding of our data. In Red, Near IR and NDVI space, each test target cluster very nicely too in a 3D cross plot. It would be great to have the same came capabilities for displaying photos for each reading on our 3D plot too.

Thanks for raising. You did not miss it. For now it is recommended to use a (2D) faceted chart: https://altair-viz.github.io/user_guide/compound_charts.html#facet-chart

Thanks, we actually have a nice cross plot that works well, but would love to be able to create a 3D cross plot some day.


fix: pass path to local-unit-test-backend

#TICKET_NUMBER

Reviewers
Functional:
@sienacizdziel
Readability:

Changes

fixed small syntax errors, call python3 directly (symlink python->python3 call not working on my local)
Can use path arg for make local-unit-test-backend again

QA steps (optional)

Use locally for targeted unit tests

Notes for Reviewer

Works on my code too, thanks Nayib!!


NullInjectorError: No provider for MatDialogRef!

Hi
I can't inject MatDialogRef as it described in documentation https://material.angular.io/components/dialog/overview
When i'm trying to do it i'v got error:
ERROR Error: StaticInjectorError[MatDialogRef]:
StaticInjectorError[MatDialogRef]:
NullInjectorError: No provider for MatDialogRef!

It's hard to know what's going on without seeing a code sample. All of the examples in the docs should work since they're being used to build the live examples.

Closing this issue as it does not follow the issue template. Please file a new issue that follows the template, which gives the team the information needed to investigate.

i'v solved the problem by importing MatDialogModule, MatDialog and MatDialogRef from @angular/material/dialog instead of @angular/material

I am also running into this problem. My dialog component works fine in my app, but in the test I get
Failed: StaticInjectorError(DynamicTestModule)[MatDialogTitle -> MatDialogRef]:
	  StaticInjectorError(Platform: core)[MatDialogTitle -> MatDialogRef]:
	    NullInjectorError: No provider for MatDialogRef!
	Error: NullInjectorError: No provider for MatDialogRef

even when adding MatDialogModule directly to the test bed module.

Any MatDialogRef methods being used also need to be included in the providers:
providers: [{
  provide: MatDialogRef,
  useValue: {
    close: (dialogResult: any) => { }
  }
}]

An official MatDialogRefTestingMock type asset would be really helpful

The same happens in unit tests for a BottomSheet based component with MAT_BOTTOM_SHEET_DATA and MatBottomSheetRef. Can be worked-around as above:
      providers: [
        { provide: MatBottomSheetRef, useValue: {} },
        { provide: MAT_BOTTOM_SHEET_DATA, useValue: {} }
      ],
      imports: [
         MatBottomSheetModule
      ]

Thank you, this saved me hours!!!!!

The same issue also occurs in AOT compilations. ng serve --aot

Still happening with @angular/material: 7.3.7, I'm not sure to understand why MatDialogRef cannot be injected during unit test execution.

Can anybody point me to a definition of "correctly written application" (specific to Angular, modules and injectors) that is practical, apropos, reasonably detailed and less than a book?  I'm assuming I'm not the only person in this well-visited thread to have seen this comment in the NullInjector source code:
if (notFoundValue === THROW_IF_NOT_FOUND) {
// Intentionally left behind: With dev tools open the debugger will stop here. There is no
// reason why correctly written application should cause this exception.
// TODO(misko): uncomment the next line once `ngDevMode` works with closure.
// if(ngDevMode) debugger;
const error = new Error(`NullInjectorError:   No provider for ${stringify(token)}!`);
error.name = 'NullInjectorError';

i was getting this error:
StaticInjectorError(DynamicTestModule)[MyDialogComponent -> MatDialogRef]:
StaticInjectorError(Platform: core)[MyDialogComponent -> MatDialogRef]:
NullInjectorError: No provider for MatDialogRef!

after rebuilding the entire component line by line out of frustration, i found my issue was an automatic IDE import that resolved to @angular/material/dialog instead of @angular/material... hopefully this helps somebody!


⚠ ClamAV has degraded performance

In ca79564, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 174 ms

Resolved: ClamAV performance has improved in 339b2ff.


chromium: fix rust toolchain and remove M121 workaround, {ungoogled-,}chromium: 121.0.6167.85 -> 121.0.6167.139

Description of changes
This fixes and enables our rust toolchain for chromium, which is required since M121.
In the last major bump (M120 -> M121 #283371) we had to work around this requirement because we hadn't had our that part of our toolchain ready.
Until now :)
So this fixes and enables the toolchain for any chromium/electron >= 121 and removes the workaround from #283371.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 285327 run on x86_64-linux 1

2 packages marked as broken and skipped:

python312Packages.pytest-playwright
python312Packages.pytest-playwright.dist

2 packages failed to build:

sharedown
sitespeed-io

17 packages built:

aws-azure-login
chromium
chromium.sandbox
fast-cli
google-chrome
mermaid-cli
mermaid-filter
netflix
percollate
playwright-test
puppeteer-cli
python311Packages.pytest-playwright
python311Packages.pytest-playwright.dist
ungoogled-chromium
ungoogled-chromium.sandbox
vhs
wayback

# git describe --abbrev=40
24.05-pre-27391-g69633e5dd8262aa5f7e6a251117dc848ef5631e7
# nix-build nixos/tests/chromium.nix -A ungoogled -A stable
/nix/store/bppjfjgxd0nd07m685061ira97zgkk7z-vm-test-run-chromium-ungoogled
/nix/store/z8fp1hl36ljz5przi4wsnq9k6b73m38s-vm-test-run-chromium-stable


feat: impl list dep packages

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

Close #281

2. What is the scope of this PR (e.g. component or file name):

pkg/tools/list/dep_parser.go
pkg/tools/list/list.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

pkg/tools/list/list_test.go

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

50 of 73 (68.49%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 61.925%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/tools/list/list.go
15
21
71.43%

pkg/tools/list/dep_parser.go
31
48
64.58%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
3230

Relevant Lines:
5216

💛  - Coveralls


Hash metadata attribute strings via Fnv1a

Provides a limited form of access to the string contents in ue
materials.

Thank you so much for the pull request @installgentoo! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

See my case for this on the forums https://community.cesium.com/t/getting-string-from-metadata-into-unreal-material/19490

As per the conversation in the forum conversation, I don't think we can merge this in the current state. When we get ready to implement #829, we might be able to add this as an option (or it might become application-level logic).


Operator Api | Add User to Ride model

This will add the user to the ride model.

I miss the spec

Usually we don't need specs for the models, but I added some 👍


Modern tabs not working on first pane if sidebar is collapsed

Is the bug present when using the default Obsidian theme?
No
Is the bug present when snippets and plugins are disabled?
Yes
Minimal theme version
6.1.4
Describe the bug
Sidebar collapsed:

Sidebar expanded:

Debug info
SYSTEM INFO:
Obsidian version: v1.0.0
Installer version: v0.15.9
Operating system: Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 21.5.0
Login status: not logged in
Insider build toggle: off
Live preview: on
Legacy editor: off
Base theme: light
Community theme: Minimal
Snippets enabled: 5
Restricted mode: on
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.

Hmm, weird. Just restarted the app and the issue persists.
SYSTEM INFO:
	Obsidian version: v1.0.0
	Installer version: v0.15.9
	Operating system: Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 21.5.0
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: light
	Community theme: Minimal
	Snippets enabled: 6
	Restricted mode: off
	Plugins installed: 41
	Plugins enabled: 2
		1: Minimal Theme Settings v6.1.0
		2: Style Settings v0.4.12

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Actually, nevermind. I just updated to 6.1.5 and now this problem is gone :)


OS 2.1: unexpected screen jumps when marking persons as elected

create a vote with many persons to be elected. Take e.g. 10 persons.
do the election and now mark a person as elected by clicking into the box in front of its name

result: the person is marked as elected but the screen view jumps to the top of the page. So for every person to be marked one has to scroll a lot. This is annoying if one has e.g. elections for a board of many persons

Confirmed. Richt, this is very annoying.
@FinnStutzenstein Any idea how to fix it?

@emanuelschuetze this has something todo with the ng-repeat (it does create the table new, if the data has changed), so that in a small moment of time the table has no body. Then the whole OS-page shrinks in size, so the browser scrolls up that the end of the page is at the bottom. After that, ng-repeat builds the table, the page gets larger but the browser stays at its scroll position.
You can reproduce this very easy: Inspect the table and search for the  tag (in Dev-Tools). Then add display: none;. The page scrolls up. Then remove the new style, so that the table is displayed, but the browser stays there.

Debugged together with @FinnStutzenstein:
The screen jumps are not caused by using uib-tab. It is caused by ng-repeat="poll in assignment.polls"  of election results. After each assignment autoupdate the ng-repeat-poll container is scrolled. We assume that the ng-repeat container gets a height of 0 if assignment is updated. We have to find a solution for that. Workaround: a min height for the ng-repeat container... Not very nice...

@emanuelschuetze Can we move this? The ratio between the effort to fix this and the usability benefit is not very high..

Many thanks, confirmed fixed.

Please reopen because this bug is back in OS 2.3b4.

Sorry, this is a minor issue. Works good enough for 2.2 -> moved to 2.3

this is a minor issue

Not for me. I took unnecessary long time to mark 15 persons as elected before I could publish the result. In this time the audience had to wait - not a comfortable situation for me as admin. To repeat myself, what admins don't have during an assembly is time.
Moreover, it is a regression, because it was already fixed.

Since the client is completely rewritten for OpenSlides 3.0, this shouldn't be an issue anymore. Please reopen if otherwise.


Validator

Coverage decreased (-0.06%) to 93.159% when pulling eba049e9d22ac18224b2113a8a52c7e10e92326c on validator into cace112e29d165c0bb33e91bd8f2a023b779d612 on develope.


Add Test Account (not default)

[x] Test Account to be hidden by default when a new wallet is created.

[x] The user can add a Test Account like Border Wallet or LN. Once added, the account is unhidden.

(Currently Checking Account is showing at the bottom and Test on the top. Does not look right)

Home:
https://xd.adobe.com/view/f11ee4be-fef5-4c9b-9e22-4ae72872c584-a44d/screen/1d82e7da-4b46-45da-8a65-46adea2097a9/
Add Account/ Wallet
https://xd.adobe.com/view/f11ee4be-fef5-4c9b-9e22-4ae72872c584-a44d/screen/6d2d2939-b83f-4fbe-9f2f-3a652ef3fb63/

Done.

Verified this issue on Tribe app v 2.3.0(616)


Rearrange modules

The sensor_data and data files could be renamed or re-organized.
A lot of the functionality has been somewhat merged between them.

The 'register.rs' file wasn't really used so it should be removed. It made sense before finding out that the i2c device didn't expose the names of the actual registers behind the scenes that would be used to configure the sensor itself.


fix(storage): fix unexpected l0->lbase input more than limit

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix https://github.com/risingwavelabs/risingwave/issues/11154

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR contains user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

nexmark q4

nexmark q16


Fix: Remove empty categories from the result page

Fix #869

Pull request checklist
Make sure you:

[x] Signed the Contributor License Agreement
[x] Followed the commit message guidelines

Short description of the change(s)

@molant this is ready to review/merge


Setup Failure - RALI

With setup option --rali on --neural_net off

Boost failure on RPP

CMake Error at /usr/local/lib/cmake/Boost-1.72.0/BoostConfig.cmake:120 (find_package):
  Found package configuration file:

    /usr/local/lib/cmake/boost_filesystem-1.72.0/boost_filesystem-config.cmake

  but it set boost_filesystem_FOUND to FALSE so package "boost_filesystem" is
  considered to be NOT FOUND.  Reason given by package:

  No suitable build variant has been found.

  The following variants have been tried and rejected:

  * libboost_filesystem.so.1.72.0 (shared, Boost_USE_STATIC_LIBS=ON)

Call Stack (most recent call first):
  /usr/local/lib/cmake/Boost-1.72.0/BoostConfig.cmake:185 (boost_find_component)
  /usr/share/cmake-3.10/Modules/FindBoost.cmake:242 (find_package)
  CMakeLists.txt:289 (find_package)

-- Configuring incomplete, errors occurred!
See also "/root/mivisionx-deps/rpp/build/CMakeFiles/CMakeOutput.log".

@kiritigowda try with 'yes/no' instead of 'on/off'

@kiritigowda Please add 'sudo ./b2 install threading=multi' after line 209 of the setup script

sudo ./b2 install threading=multi

209 has below
'(cd '+deps_dir+'/boost_1_72_0/; sudo ./b2 install threading=multi link=shared --with-system --with-filesystem)')

sudo ./b2 install threading=multi

209 has below
'(cd '+deps_dir+'/boost_1_72_0/; sudo ./b2 install threading=multi link=shared --with-system --with-filesystem)')

I meant after that. That line installs the shared linked libraries. The line I sent is to add static .a files

with PR #370 this issue id fixed.
@LakshmiKumar23 why do we need static and shared? can we investigate?
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Radeon Performance Primitives (RPP) Version -- 0.5
-- RPP install path set to -- /opt/rocm/rpp
-- cmake minimum version required: 3.5
-- cmake version found: 3.10.2
-- Clang tidy not found
-- Clang tidy checks: *,-cert-env33-c,-android-cloexec-fopen,-cert-msc30-c,-cert-msc50-cpp,-clang-analyzer-alpha.core.CastToStruct,-clang-analyzer-optin.performance.Padding,-clang-diagnostic-deprecated-declarations,-clang-diagnostic-extern-c-compat,-clang-diagnostic-unused-command-line-argument,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-special-member-functions,-fuchsia-*,-google-explicit-constructor,-google-readability-braces-around-statements,-google-readability-todo,-google-runtime-int,-google-runtime-references,-hicpp-braces-around-statements,-hicpp-explicit-conversions,-hicpp-no-array-decay,-hicpp-signed-bitwise,-hicpp-special-member-functions,-hicpp-use-equals-default,-hicpp-use-override,-llvm-header-guard,-llvm-include-order,-misc-misplaced-const,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-default,-modernize-use-transparent-functors,-performance-unnecessary-value-param,-readability-braces-around-statements,-readability-else-after-return,-readability-named-parameter,-hicpp-use-auto,-modernize-use-auto,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-cppcoreguidelines-macro-usage,-misc-non-private-member-variables-in-classes,-cppcoreguidelines-non-private-member-variables-in-classes,-readability-isolate-declaration,-cppcoreguidelines-avoid-c-arrays,-hicpp-avoid-c-arrays,-modernize-avoid-c-arrays,-readability-uppercase-literal-suffix,-hicpp-uppercase-literal-suffix,-cert-msc32-c,-cert-msc51-cpp,-bugprone-exception-escape
-- Found OPENCL: /opt/rocm/opencl/lib/libOpenCL.so
-- extractkernel found: /opt/rocm/bin/extractkernel
Add Custome Command
OPenCL incude directories are /opt/rocm/opencl/include;/root/mivisionx-deps/rpp/src/include/cl/
-- amd_rpp built with ENABLE_SIMD_INTRINSICS
-- Boost  found.
-- Found Boost components:
   filesystem;system
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- CentOS detected   -- .rpm package will be created
-- Configuring done
-- Generating done
-- Build files have been written to: /root/mivisionx-deps/rpp/build

@kiritigowda RPP uses the static librarires, where MIOpen the shared. We can discuss more offline


rewrite docker stuff

as gitea grows, we have to rewrite docker stuff in the docker dir.
this issue will stays open until PR is merged and will serve a repo for comments.
feel free to add what you think should be done regarding docker build

keep s6 as an init replacement.

rewrite en variables

dockerfile cleanup

I would suggest to have the smaller image as possible and by doing so, the compilation should be done outside and the binary pushed to the docker (maybe from scratch instead alpine).
I could provide later a link to a docker images that can be used to build Go program and make docker images without compiler program.

We will use drone to build the binary outside of the docker image, the drone pipeline is in preparation ;)

@tboerger nice !
then @DblK send the link to me :) i'd be happy to learn moaaarrrr go :)

why do we need that s6 stuff instead of setting things up in the dockerfile?

@willemvd we need s6 as process manager because we will run more than a single service within the container, at least we need Gitea and openSSH.

I would strongly recommend against using scratch as that renders any form of shell scripting invalid.

The way you say it makes it sound like avoiding shell scripts is a bad thing

Yes, it removes the functionality of git hooks.

Yes, it breaks many things. Including git-hooks and https://github.com/go-gitea/git.

Nobody wants to use scratch, alpine is a perfect base

@tboerger, I just wanted to let anyone that likes @DblK's idea know that it's not going to be good if we use scratch as base.

Using scratch as base not is (in this case) a good idea cause you need OpenSSH and shell scripts.

We already refactored docker