Cannot delete any text in the TextField with GlobalKey using Sogou input

Steps to Reproduce

Hi, thank you for the wonderful framework! I find a bug as follows, which prevents people in China (which has 1.3 billion people) from using Flutter :(

Run flutter create bug.
Update the files as follows:

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final _textKey = GlobalKey();
  var _mode = false;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: Text('Bug')),
        body: Column(
          children: [
            OutlinedButton(onPressed: () => setState(() => _mode = !_mode), child: Text('ToggleMode')),
            // THE FOLLOWING LINE IS THE CORE PROBLEM! (The "color" is unrelated to the bug - just to make it easier to see)
            _mode ? Container(color: Colors.blue[50], child: TextField(key: _textKey)) : TextField(key: _textKey),
          ],
        ),
      ),
    );
  }
}

Run the app, and do these steps one by one:

i. Tap the text field. (The keyboard should be opened automatically, and the text field is focused now.)
ii. Tap the "toggle" button. (The text field should be blue now. Indeed the bug has nothing to do with color, but the color is for simplicity to debug)
iii. Use input method (keyboard) to input some text.
iv. Use the "delete" button on the Chinese input method to delete text. Should see the text is not deleted! (Must be a input method with Chinese character input mode; English input mode will not trigger the bug) (Maybe use Android, since I have not tried it on iOS)
The core problem is: Cannot delete any text, when using TextField with GlobalKey, and when the TextField is "moved" to another location.
Expected results:
Text should be deleted when the delete button in the input keyboard is pressed.
Actual results:
Text not deleted.

Logs

no useful logs

Analyzing bug...
No issues found! (ran in 1.6s)

[✓] Flutter (Channel stable, 2.0.3, on Mac OS X 10.15.7 19H524 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.0.3 at /Users/tom/opt/flutter
    • Framework revision 4d7946a68d (3 周前), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tom/Library/Android/sdk
    • Platform android-30, build-tools 29.0.3
    • ANDROID_SDK_ROOT = /Users/tom/Library/Android/sdk
    • Java binary at: /Users/tom/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7042882/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/tom/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.7042882/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Ultimate Edition (version 2020.3)
    • IntelliJ at /Users/tom/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.54.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Proxy Configuration
    • HTTP_PROXY is set
    • NO_PROXY is <IP_ADDRESS>,localhost
    • NO_PROXY contains <IP_ADDRESS>
    • NO_PROXY contains localhost

[✓] Connected device (3 available)
    • JSN AL00a (mobile) • 7XBNW19215005473                     • android-arm64  • Android 10 (API
      29)
    • iPhone 11 (mobile) • 14CE77E4-C2C5-4267-B565-520FA291E237 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome
      89.0.4389.114

• No issues found!

@fzyzcjy
I cannot reproduce the issue with the latest master using the code above

logs
francesco@francesco-yoga720:~/projects/issue_80192$ flutter run --release -v
[  +66 ms] executing: uname -m
[  +30 ms] Exit code 0 from: uname -m
[        ] x86_64
[   +8 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +8 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[        ] executing: [/home/francesco/snap/flutter/common/flutter/] git tag --points-at 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[  +92 ms] Exit code 0 from: git tag --points-at 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[   +1 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git describe --match *.*.* --long --tags 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[  +60 ms] Exit code 0 from: git describe --match *.*.* --long --tags 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[        ] 2.1.0-12.0.pre-574-g02efffc134
[   +5 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[   +5 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/master
[        ] executing: [/home/francesco/snap/flutter/common/flutter/] git ls-remote --get-url origin
[   +6 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +88 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git rev-parse --abbrev-ref HEAD
[   +5 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] master
[  +77 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +108 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb devices -l
[  +35 ms] List of devices attached
           965AY0WP5C             device usb:1-2 product:sargo model:Pixel_3a device:sargo transport_id:2
[   +6 ms] /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell getprop
[ +127 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +88 ms] Skipping pub get: version match.
[ +122 ms] Generating /home/francesco/projects/issue_80192/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +72 ms] ro.hardware = sargo
[        ] ro.build.characteristics = nosdcard
[  +55 ms] Launching lib/main.dart on Pixel 3a in release mode...
[   +4 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell -x logcat -v time -t 1
[ +107 ms] --------- beginning of main
                    04-10 17:12:01.337 D/ASH     (  988): @ 2427730.254: SensorType 195 resampler quality 2
[  +23 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb version
[  +48 ms] Android Debug Bridge version 1.0.41
           Version 30.0.5-6877874
           Installed as /home/francesco/Android/Sdk/platform-tools/adb
[   +1 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb start-server
[   +6 ms] Building APK
[  +18 ms] Running Gradle task 'assembleRelease'...
[   +4 ms] Using gradle from /home/francesco/projects/issue_80192/android/gradlew.
[  +26 ms] executing: [/home/francesco/projects/issue_80192/android/] /home/francesco/projects/issue_80192/android/gradlew -Pverbose=true -Ptarget-platform=android-arm64
-Ptarget=/home/francesco/projects/issue_80192/lib/main.dart -Pdart-defines=RkxVVFRFUl9XRUJfQVVUT19ERVRFQ1Q9dHJ1ZQ== -Pdart-obfuscation=false -Ptrack-widget-creation=true -Ptree-shake-icons=false
-Pfilesystem-scheme=org-dartlang-root assembleRelease
[ +950 ms] Starting a Gradle Daemon, 1 busy Daemon could not be reused, use --status for details
[+28981 ms] > Task :app:compileFlutterBuildRelease
[        ] [  +62 ms] executing: uname -m
[        ] [  +32 ms] Exit code 0 from: uname -m
[        ] [        ] x86_64
[        ] [   +6 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] [   +5 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] [        ] 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[        ] [        ] executing: [/home/francesco/snap/flutter/common/flutter/] git tag --points-at 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[        ] [  +11 ms] Exit code 0 from: git tag --points-at 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[        ] [   +1 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git describe --match *.*.* --long --tags 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[        ] [  +62 ms] Exit code 0 from: git describe --match *.*.* --long --tags 02efffc134ab4ce4ff50a9ddd86c832efdb80462
[        ] [        ] 2.1.0-12.0.pre-574-g02efffc134
[        ] [   +5 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[        ] [   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] [        ] origin/master
[        ] [        ] executing: [/home/francesco/snap/flutter/common/flutter/] git ls-remote --get-url origin
[        ] [   +4 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] [        ] https://github.com/flutter/flutter.git
[        ] [  +54 ms] executing: [/home/francesco/snap/flutter/common/flutter/] git rev-parse --abbrev-ref HEAD
[        ] [   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] [        ] master
[        ] [  +49 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] [   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] [  +93 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] [   +2 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[        ] [  +34 ms] Initializing file store
[        ] [  +23 ms] Skipping target: gen_localizations
[        ] [   +6 ms] kernel_snapshot: Starting due to {}
[   +1 ms] [  +11 ms] /home/francesco/snap/flutter/common/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev
/home/francesco/snap/flutter/common/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot --sdk-root
/home/francesco/snap/flutter/common/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk_product/ --target=flutter --no-print-incremental-dependencies -DFLUTTER_WEB_AUTO_DETECT=true
-Ddart.vm.profile=false -Ddart.vm.product=true --aot --tfa --packages /home/francesco/projects/issue_80192/.dart_tool/package_config.json --output-dill
/home/francesco/projects/issue_80192/.dart_tool/flutter_build/f4dafad92da4e25bdb9d8bb66695b4a9/app.dill --depfile
/home/francesco/projects/issue_80192/.dart_tool/flutter_build/f4dafad92da4e25bdb9d8bb66695b4a9/kernel_snapshot.d package:issue_80192/main.dart
[+16583 ms] [+17623 ms] kernel_snapshot: Complete
[ +499 ms] [ +509 ms] android_aot_release_android-arm64: Starting due to {}
[ +100 ms] [  +13 ms] executing: /home/francesco/snap/flutter/common/flutter/bin/cache/artifacts/engine/android-arm64-release/linux-x64/gen_snapshot --deterministic --snapshot_kind=app-aot-elf
--elf=/home/francesco/projects/issue_80192/.dart_tool/flutter_build/f4dafad92da4e25bdb9d8bb66695b4a9/arm64-v8a/app.so --strip
/home/francesco/projects/issue_80192/.dart_tool/flutter_build/f4dafad92da4e25bdb9d8bb66695b4a9/app.dill
[   +2 ms] [        ] aot_android_asset_bundle: Starting due to {}
[  +97 ms] [ +161 ms] aot_android_asset_bundle: Complete
[+8899 ms] [+8831 ms] android_aot_release_android-arm64: Complete
[ +202 ms] [ +283 ms] android_aot_bundle_release_android-arm64: Starting due to {}
[  +97 ms] [  +19 ms] android_aot_bundle_release_android-arm64: Complete
[        ] [  +86 ms] Persisting file store
[  +99 ms] [   +9 ms] Done persisting file store
[        ] [   +9 ms] build succeeded.
[        ] [  +14 ms] "flutter assemble" took 27,748ms.
[ +199 ms] [ +175 ms] ensureAnalyticsSent: 169ms
[        ] [   +4 ms] Running shutdown hooks
[        ] [   +1 ms] Shutdown hooks complete
[        ] [   +1 ms] exiting with code 0
[ +499 ms] > Task :app:packLibsflutterBuildRelease
[        ] > Task :app:preBuild UP-TO-DATE
[        ] > Task :app:extractProguardFiles
[        ] > Task :app:preReleaseBuild
[        ] > Task :app:compileReleaseAidl NO-SOURCE
[        ] > Task :app:compileReleaseRenderscript NO-SOURCE
[  +98 ms] > Task :app:generateReleaseBuildConfig
[        ] > Task :app:checkReleaseAarMetadata
[        ] > Task :app:cleanMergeReleaseAssets UP-TO-DATE
[  +99 ms] > Task :app:mergeReleaseShaders
[        ] > Task :app:compileReleaseShaders NO-SOURCE
[        ] > Task :app:generateReleaseAssets UP-TO-DATE
[  +99 ms] > Task :app:mergeReleaseAssets
[ +100 ms] > Task :app:copyFlutterAssetsRelease
[        ] > Task :app:generateReleaseResValues
[        ] > Task :app:generateReleaseResources
[+1100 ms] > Task :app:createReleaseCompatibleScreenManifests
[        ] > Task :app:extractDeepLinksRelease
[ +597 ms] > Task :app:mergeReleaseResources
[        ] > Task :app:processReleaseMainManifest
[ +399 ms] > Task :app:processReleaseManifest
[  +99 ms] > Task :app:processReleaseManifestForPackage
[        ] > Task :app:javaPreCompileRelease
[ +599 ms] > Task :app:processReleaseResources
[+8099 ms] > Task :app:compileReleaseKotlin
[+2700 ms] > Task :app:compileReleaseJavaWithJavac
[        ] > Task :app:compileReleaseSources
[+8298 ms] > Task :app:lintVitalRelease
[        ] > Task :app:mergeReleaseNativeDebugMetadata NO-SOURCE
[ +199 ms] > Task :app:compressReleaseAssets
[ +102 ms] > Task :app:mergeReleaseGeneratedProguardFiles
[        ] > Task :app:checkReleaseDuplicateClasses
[        ] > Task :app:processReleaseJavaRes NO-SOURCE
[ +396 ms] > Task :app:collectReleaseDependencies
[ +100 ms] > Task :app:sdkReleaseDependencyData
[        ] > Task :app:mergeReleaseJniLibFolders
[ +100 ms] > Task :app:validateSigningRelease
[ +299 ms] > Task :app:mergeReleaseJavaResource
[ +999 ms] > Task :app:mergeReleaseNativeLibs
[+1400 ms] > Task :app:minifyReleaseWithR8
[        ] R8: Missing class: com.google.android.play.core.splitcompat.SplitCompatApplication
[        ] R8: Missing class: com.google.android.play.core.splitinstall.SplitInstallStateUpdatedListener
[+6602 ms] > Task :app:stripReleaseDebugSymbols
[        ] Unable to strip the following libraries, packaging them as they are: libapp.so, libflutter.so.
[ +296 ms] > Task :app:shrinkReleaseRes
[+1000 ms] > Task :app:packageRelease
[  +99 ms] > Task :app:assembleRelease
[  +99 ms] Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
[        ] Use '--warning-mode all' to show the individual deprecation warnings.
[        ] See https://docs.gradle.org/6.7/userguide/command_line_interface.html#sec:command_line_warnings
[        ] BUILD SUCCESSFUL in 1m 31s
[        ] 35 actionable tasks: 34 executed, 1 up-to-date
[ +409 ms] Running Gradle task 'assembleRelease'... (completed in 91.6s)
[  +78 ms] calculateSha: LocalDirectory: '/home/francesco/projects/issue_80192/build/app/outputs/flutter-apk'/app.apk
[ +127 ms] ✓  Built build/app/outputs/flutter-apk/app-release.apk (6.2MB).
[   +5 ms] executing: /home/francesco/Android/Sdk/build-tools/30.0.2/aapt dump xmltree /home/francesco/projects/issue_80192/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[  +18 ms] Exit code 0 from: /home/francesco/Android/Sdk/build-tools/30.0.2/aapt dump xmltree /home/francesco/projects/issue_80192/build/app/outputs/flutter-apk/app.apk AndroidManifest.xml
[        ] N: android=http://schemas.android.com/apk/res/android
             E: manifest (line=2)
               A: android:versionCode(0x0101021b)=(type 0x10)0x1
               A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0")
               A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1e
               A: android:compileSdkVersionCodename(0x01010573)="11" (Raw: "11")
               A: package="com.example.issue_80192" (Raw: "com.example.issue_80192")
               A: platformBuildVersionCode=(type 0x10)0x1e
               A: platformBuildVersionName=(type 0x10)0xb
               E: uses-sdk (line=7)
                 A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10
                 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1e
               E: application (line=11)
                 A: android:label(0x01010001)="issue_80192" (Raw: "issue_80192")
                 A: android:icon(0x01010002)=@0x7f080000
                 A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw: "androidx.core.app.CoreComponentFactory")
                 E: activity (line=15)
                   A: android:theme(0x01010000)=@0x7f0a0000
                   A: android:name(0x01010003)="com.example.issue_80192.MainActivity" (Raw: "com.example.issue_80192.MainActivity")
                   A: android:launchMode(0x0101001d)=(type 0x10)0x1
                   A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4
                   A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10
                   A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff
                   E: meta-data (line=29)
                     A: android:name(0x01010003)="io.flutter.embedding.android.NormalTheme" (Raw: "io.flutter.embedding.android.NormalTheme")
                     A: android:resource(0x01010025)=@0x7f0a0001
                   E: meta-data (line=39)
                     A: android:name(0x01010003)="io.flutter.embedding.android.SplashScreenDrawable" (Raw: "io.flutter.embedding.android.SplashScreenDrawable")
                     A: android:resource(0x01010025)=@0x7f040000
                   E: intent-filter (line=43)
                     E: action (line=44)
                       A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
                     E: category (line=46)
                       A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
                 E: meta-data (line=53)
                   A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding")
                   A: android:value(0x01010024)=(type 0x10)0x2
[   +5 ms] Stopping app 'app.apk' on Pixel 3a.
[        ] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell am force-stop com.example.issue_80192
[ +197 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell pm list packages com.example.issue_80192
[ +135 ms] Installing APK.
[   +4 ms] Installing build/app/outputs/flutter-apk/app.apk...
[        ] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C install -t -r /home/francesco/projects/issue_80192/build/app/outputs/flutter-apk/app.apk
[+2159 ms] Performing Streamed Install
                    Success
[   +4 ms] Installing build/app/outputs/flutter-apk/app.apk... (completed in 2,160ms)
[   +4 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell echo -n 78d219359dbb9007473e8a44053a0b0ba65037eb > /data/local/tmp/sky.com.example.issue_80192.sha1
[  +35 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez
enable-dart-profiling true com.example.issue_80192/com.example.issue_80192.MainActivity
[  +97 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.example.issue_80192/.MainActivity (has extras) }
[   +6 ms] Application running.
[   +8 ms] Flutter run key commands.
[   +5 ms] h Repeat this help message.
[   +1 ms] c Clear the screen
[        ] q Quit (terminate the application on the device).
[+385144 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell am force-stop com.example.issue_80192
[ +160 ms] executing: /home/francesco/Android/Sdk/platform-tools/adb -s 965AY0WP5C shell am force-stop com.example.issue_80192
[  +98 ms] Application finished.
[  +27 ms] "flutter run" took 480,874ms.
[ +242 ms] ensureAnalyticsSent: 232ms
[   +5 ms] Running shutdown hooks
[   +1 ms] Shutdown hooks complete
[   +2 ms] exiting with code 0

doctor
[✓] Flutter (Channel master, 2.1.0-13.0.pre.574, on Linux, locale en_US.UTF-8)
    • Flutter version 2.1.0-13.0.pre.574 at /home/francesco/snap/flutter/common/flutter
    • Framework revision 02efffc134 (7 hours ago), 2021-04-10 03:49:01 -0400
    • Engine revision 8863afff16
    • Dart version 2.13.0 (build 2.13.0-222.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/francesco/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_SDK_ROOT = /home/francesco/Android/Sdk
    • Java binary at: /usr/lib/jvm/java-1.8.0-openjdk-amd64/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_282-8u282-b08-0ubuntu1~20.04-b08)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /snap/bin/chromium

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] Connected device (3 available)
    • Pixel 3a (mobile) • 965AY0WP5C • android-arm64  • Android 11 (API 30)
    • Linux (desktop)   • linux      • linux-x64      • Linux
    • Chrome (web)      • chrome     • web-javascript • Chromium 89.0.4389.114 snap

! Doctor found issues in 1 category.

I find a bug as follows, which prevents people in China (which has 1.3 billion people) from using Flutter :(

I have mixed feelings about leveraging the population of a country to prioritize a (alleged) bug

@iapicca Thanks for the reply! I reproduced it using stable channel + sogou input method or baidu input method (two input methods with a large number of users so I have no choice but to support them).

I have mixed feelings about leveraging the population of a country to prioritize a (alleged) bug

I deleted the words in the title; however, it is not leveraging, because if I simply mention "using Chinese keyboard" then this issue may have a low priority since it is not universal - I need to mention the number of people using Chinese keyboard.

I reproduced it using stable channel + sogou input method or baidu input method

@fzyzcjy
the default android keyboard doesn't seem to support the input methods you are referring
seem possible that the issue depends from the keyboard itself rather than flutter,
regardless
I tried the to reproduce with an alleged sogou keyboard,
but I still cannot reproduce the issue, can you confirm that it's indeed the input method you are referring to

@iapicca Aha interesting! It is sogou input method looking at the screenshot. Now possibilities are:

different channels: stable vs master (maybe have a try on stable channel?)
different phones: honor vs pixel 3a

different channels: stable vs master (maybe have a try on stable channel?)

@fzyzcjy
today's master is tomorrow stable, I don't see the point of addressing an issue that is already fixed in master

different phones: honor vs pixel 3a
different android versions: a version of android customized by honor (but has millions and millions of users) vs original android

I strongly suspect that it's a device (or devices) specific issue
can you try repo the issue upgrading to the latest master and using the keyboard I tested above

I tried an alleged sogou keyboard

@iapicca Thanks! I will try to test it.
p.s. Indeed flutter's channel is not that isolated... Using anaconda (for python), I can simply create one environment for version A and another for version B. But with flutter, I have to change the channel which affects the whole machine...

@iapicca Thanks! I will try to test it.
p.s. Indeed flutter's channel is not that isolated... Using anaconda (for python), I can simply create one environment for version A and another for version B. But with flutter, I have to change the channel which affects the whole machine...

https://github.com/leoafarias/fvm

@iapicca sounds interesting!

Hi @fzyzcjy
I just tried all channels with the same sogou keyboard and it only reproduces on stable channel, labelling this issue for stable

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.4, on Microsoft Windows [Version 10.0.19042.870], locale en-US)
    • Flutter version 2.0.4 at C:\Users\Taha\Code\flutter_stable
    • Framework revision b1395592de (11 days ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.2)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31112.23
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3
    • Flutter plugin version 55.0.5
    • Dart plugin version 211.6693.108

[✓] VS Code (version 1.55.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • RMX2001 (mobile)  • EUYTFEUSQSRGDA6D • android-arm64  • Android 10 (API 29)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.19042.870]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 89.0.4389.114
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 89.0.774.68

! Doctor found issues in 1 category.

@TahaTesser Thanks! I wonder when will it be fixed on the stable channel? (I guess when the next beta becomes stable, is it correct?)
Seems that it will take a few months... Is there any way I can use the fix while using stable (since it is an app in production, i should never use beta or master).

@TahaTesser @chinmaygarde Hi, any updates? This bug is quite annoying and it strongly affects our app (in production). And since it is in production, we can never use the beta channel :(

@fzyzcjy Hello. I have tested this on the latest stable and master and have not been able to re-produce it. The Sagou keyboard initially used to test this was not working for me, so I tried a keyboard by Desh keybaords which came up on a search for Sagou keyboards (link here).
Can you please verify if this issue still persists on your end?
Code sample used
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final _textKey = GlobalKey();
  var _mode = false;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: const Text('Bug')),
        body: Column(
          children: [
            OutlinedButton(
              onPressed: () => setState(() => _mode = !_mode),
              child: const Text('ToggleMode'),
            ),
            // THE FOLLOWING LINE IS THE CORE PROBLEM! (The "color" is unrelated to the bug - just to make it easier to see)
            _mode
                ? Container(
                    color: Colors.blue[50],
                    child: TextField(
                      key: _textKey,
                    ),
                  )
                : TextField(key: _textKey),
          ],
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 3.1.0-0.0.pre.666, on macOS 12.3.1 21E258 darwin-arm, locale en-US)
    • Flutter version 3.1.0-0.0.pre.666 at /Users/nabeelparkar/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 496049263e (5 hours ago), 2022-05-11 23:14:11 -0700
    • Engine revision b8ca6a5e0e
    • Dart version 2.18.0 (build 2.18.0-106.0.dev)
    • DevTools version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
    • Android SDK at /Users/nabeelparkar/Library/Android/sdk/
    • Platform android-32, build-tools 32.0.0-rc1
    • ANDROID_SDK_ROOT = /Users/nabeelparkar/Library/Android/sdk/
    • Java binary at: /opt/homebrew/opt/openjdk@11/bin/java
    • Java version OpenJDK Runtime Environment Homebrew (build 11.0.15+0)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 67.1.4
    • Dart plugin version 221.5591.52

[✓] VS Code (version 1.67.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (3 available)
    • V2050 (mobile)  •<PHONE_NUMBER>000NM • android-arm64  • Android 12 (API 31)
    • macOS (desktop) • macos           • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)    • chrome          • web-javascript • Brave Browser <IP_ADDRESS>

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

I have not see problems in stable channel for a while. So I guess maybe it is solved.
Thanks!

@exaby73 By the way, I am quite curious how did you add the label "waiting for customer response"? I have not found a way to add it.

@fzyzcjy I'm part of the Flutter organization on Github, therefore I am able to add that label :D

@exaby73 How do you apply for that? That sounds interesting :)

@fzyzcjy This is my full-time job actually. I work for Nevercode, the company behind Codemagic, on the triage team that handles these issues :)

@exaby73 Interesting! I did not know that Flutter triage bugs via Codemagic :)

@fzyzcjy Yes! Here's a bit of an old article explaining this partnership with Flutter :)


STOR-1601: Rebase to upstream v1.29.7 for OCP 4.17

Issue link:
https://issues.redhat.com/browse/STOR-1601
Diff to upstream v1.29.7:
https://github.com/kubernetes-sigs/azuredisk-csi-driver/compare/v1.29.7...dfajmon:rebase-1.29.7
Changes between 1.29.3 (OCP 4.16) and 1.29.7 (OCP 4.17):

https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2352
https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2295
https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2307
https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2227

Full changelogs:
https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/releases/tag/v1.29.7
https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/releases/tag/v1.29.6
https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/releases/tag/v1.29.5
https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/releases/tag/v1.29.4
@openshift/storage

/assign @duanwei33
For QE approval

/retest

/approve

/label px-approved
/label docs-approved

/lgtm

/label qe-approved

/retest

/retest
image pull failed ?!


Sleigh: Tables not working when constraint on context variable starts from non-zero value

Describe the bug
I am creating a rule for the RXv2 MOV instruction post-increment/pre-decrement register operands. I created a field called ad2_2 to pull out the bits that determine the addressing mode:
00b | Rs, [Rd+]
01b | Rs, [-Rd]
10b | [Rs+], Rd
11b | [-Rs], Rd
I want to handle source vs. destination registers a bit differently (let me know if there is a better way), so I created a separate table for Rs and Rd operands:
## Registers with pre-increment/post-decrement
rd_post: [reg4_4+]    is mode_ad = 0x0 & mode_sz = 0x0 & reg4_4 { local tmp:4 = reg4_4; reg4_4 = reg4_4 + 1; export tmp; }
rd_post: [reg4_4+]    is mode_ad = 0x0 & mode_sz = 0x1 & reg4_4 { local tmp:4 = reg4_4; reg4_4 = reg4_4 + 2; export tmp; }
rd_post: [reg4_4+]    is mode_ad = 0x0 & mode_sz = 0x2 & reg4_4 { local tmp:4 = reg4_4; reg4_4 = reg4_4 + 4; export tmp; }

rd_post: [-reg4_4]    is mode_ad = 0x1 & mode_sz = 0x0 & reg4_4 { reg4_4 = reg4_4 - 1; local tmp:4 = reg4_4; export tmp; }
rd_post: [-reg4_4]    is mode_ad = 0x1 & mode_sz = 0x1 & reg4_4 { reg4_4 = reg4_4 - 2; local tmp:4 = reg4_4; export tmp; }
rd_post: [-reg4_4]    is mode_ad = 0x1 & mode_sz = 0x2 & reg4_4 { reg4_4 = reg4_4 - 4; local tmp:4 = reg4_4; export tmp; }

rs_post: [reg4_4+]    is mode_ad = 0x2 & mode_sz = 0x0 & reg4_4 { local tmp:4 = sext(*:1 reg4_4); reg4_4 = reg4_4 + 1; export tmp; }
rs_post: [reg4_4+]    is mode_ad = 0x2 & mode_sz = 0x1 & reg4_4 { local tmp:4 = sext(*:2 reg4_4); reg4_4 = reg4_4 + 2; export tmp; }
rs_post: [reg4_4+]    is mode_ad = 0x2 & mode_sz = 0x2 & reg4_4 { local tmp:4 = *:4 reg4_4; reg4_4 = reg4_4 + 4; export tmp; }

rs_post: [-reg4_4]    is mode_ad = 0x3 & mode_sz = 0x0 & reg4_4 { reg4_4 = reg4_4 - 1; local tmp:4 = sext(*:1 reg4_4); export tmp; }
rs_post: [-reg4_4]    is mode_ad = 0x3 & mode_sz = 0x1 & reg4_4 { reg4_4 = reg4_4 - 2; local tmp:4 = sext(*:2 reg4_4); export tmp; }
rs_post: [-reg4_4]    is mode_ad = 0x3 & mode_sz = 0x2 & reg4_4 { reg4_4 = reg4_4 - 4; local tmp:4 = *:4 reg4_4; export tmp; }

Note that rd_post only has constraints for mode_ad values of 0 and 1. rs_post only has constraints for values 2 and 3.
The rd_post table worked fine, but rs_post did not and exhibited really strange behavior related to the mode_ad constraint. The instruction definition that uses rs_post looks like this:
:MOV^szdsc rs_post, reg0_4    is szdsc & op0_8 = 0xFD; op4_4 = 0x2 & ad2_2 >= 0x2 & ad2_2 & sz0_2; rs_post & reg0_4 [ mode_ad = ad2_2; mode_sz = sz0_2; ] {
    reg0_4 = rs_post;
}

After a lot of fumbling around, I finally found that the rs_post table setup would not work unless constraints for values of 0 and 1 were defined:
rs_post: "DUMMY"    is mode_ad = 0x0 & reg4_4 unimpl  # rules for ad = 2 and 3 don't work without these
rs_post: "DUMMY"    is mode_ad = 0x1 & reg4_4 unimpl  # rules for ad = 2 and 3 don't work without these

To Reproduce
This is a minimal test file for reproducing:
define token opbyte (8)
   op0_8     = (0,7)
   op4_4     = (4,7)
   ad2_2     = (2,3)
   ld2_2     = (2,3)
   sz0_2     = (0,1)

   reg4_4    = (4,7)
   reg0_4    = (0,3)
;

define context contextreg
  mode_sz = (2,3) noflow
  mode_ad = (0,1) noflow
;

attach variables [ reg0_4 reg4_4 ] [ SP R1 R2 R3 R4 R5 R6 R7 R8 R9 R10 R11 R12 R13 R14 R15 ];

#rspost: reg4_4^"ad0:"^ad^":"^sz is reg4_4 & mode_ad = 0x0 [ ad = mode_ad; sz = mode_sz; ] { local tmp:4 = reg4_4; export tmp; }
#rspost: reg4_4^"ad1:"^ad^":"^sz is reg4_4 & mode_ad = 0x1 [ ad = mode_ad; sz = mode_sz; ] { local tmp:4 = reg4_4; export tmp; }
rspost: reg4_4^"ad2:"^ad^":"^sz is reg4_4 & mode_ad = 0x2 [ ad = mode_ad; sz = mode_sz; ] { local tmp:4 = reg4_4; export tmp; }
rspost: reg4_4^"ad3:"^ad^":"^sz is reg4_4 & mode_ad = 0x3 [ ad = mode_ad; sz = mode_sz; ] { local tmp:4 = reg4_4; export tmp; }

:TEST rspost, reg0_4 is op0_8 = 0xFD; op4_4 = 0x2 & ad2_2 & sz0_2; reg0_4 & rspost [ mode_ad = ad2_2; mode_sz = sz0_2; ] unimpl

A binary blob containing FD 28 12 should disassemble to TEST R1ad2:2:0, R2. It does not work unless the first two rules with constraints for mode_ad = 0x0 and mode_ad = 0x1 are uncommented.
Expected behavior
When ad2_2 has a value of 2 or 3, mode_ad should be set accordingly and match the constraints in the rs_post table for mode_ad = 0x2 or mode_ad = 0x3 (without defining extra rules with constraints for unused lower values).

Your use of opbyte seems broken, for a quick fix you might consider multiple define token to avoid confusion on which byte you're reading from.
I may be wrong, but the way i read this is when mode_ad and mode_sz are assigned, they are reading from the 3rd byte 0x12 (you have processed 2 fields so far with ;), so you have mode_ad=0x0 and mode_sz=0x2.  A helpful tool inside the code browser is the DebugSleighInstructionParse script, to see exactly how Ghidra processes the instruction's bytes.

I believe the issue is associated with trying to use a disassemble action to set context in the base constructor and using it in the sub-constructor.  My suspicion is, if you haven't fully specified the match in the sub-constructor, the disassembly actions can't be applied since the base constructor hasn't fully matched.  I'd have to look at the exact semantics of the disassembly actions and when it is applied.
In general I wouldn't use the disassembly context in the base constructor, unless you are setting it for follow on instructions with global context.
You could try using parentheses around the match patterns in the base constructor to allow the sub-constructor access the bits of the addressing mode.  Not sure this will quite work or the syntax may be off.  You could also define a new 16-bit token that encompasses the second and third bytes.
rspost: reg4_4^"ad3:"^ad^":"^sz is reg4_4 & sz0_2; & ad2_2 = 0x3 [ ad = ad2_2; sz = mode_sz; ] { local tmp:4 = reg4_4; export tmp; }

:TEST rspost, reg0_4 is op0_8 = 0xFD; (op4_4 = 0x2 & ad2_2 & sz0_2; reg0_4) ... & rspost   [ mode_ad = ad2_2; mode_sz = sz0_2; ] unimpl

not sure you need the ...
As @mumbel mentioned, the DebugSleighInstructionParse can tell you the state of the context bits, the bits and values being matched at each stage, and where the match is failing.

The motivation behind the use of the context variables is that the bits for address mode, size, etc. are not in consistent locations, so instead of writing a duplicate rule for each possible position of the mode bits I wanted to pass the value in a variable. It works as intended except in the case described in the bug report. Is it something that really shouldn't be used this way and might be broken by future updates?
Thanks for the debug script tip. Here is the test file I'm using:
$ hexdump test_mov15.bin
000000 fd 28 12 fd 29 12 fd 2a 12 fd 20 12 fd 24 12     >.(..)..*.. ..$.<
00000f

With the "dummy" rules commented, all disassembly fails. The debug output for the given example is:
initial context bits: 00000000.00000000.00000000.00000000
resolving constructor for instruction bytes at: ram:00000000
check pattern[1 of 1]: {line# 26} TEST <rspost>, <reg0_4>
   (  byte pattern: mask=11111111.11110000.00000000.00000000
              bytes[0-3]=11111101.00101000.00010010.11111101
             match-value=11111101.00100000.00000000.00000000 Matched
   ) -and- (
      context pattern: mask=10000000.00000000.00000000.00000000
             context(0..31)=00000000.00000000.00000000.00000000
                match-value=10000000.00000000.00000000.00000000 Failed
                  *mode_ad(0,1) == 0x2 Failed (=0x0)
   ) Failed
Unable to resolve constructor

Prototype parse failed: Unable to resolve constructor at ram:00000000
DebugSleighInstructionParse.java> Finished!

Byte pattern matches but not the context pattern. Is that what you were saying about the base constructor failing?
With the two "dummy" lines uncommented, the disassembly is:
    ram:00000000 fd 28 12        TEST       R1ad2:0x2:0x0,R2
    ram:00000003 fd 29 12        TEST       R1ad2:0x2:0x1,R2
    ram:00000006 fd 2a 12        TEST       R1ad2:0x2:0x2,R2
    ram:00000009 fd 20 12        TEST       R1ad0:0x0:0x0,R2
    ram:0000000c fd 24 12        TEST       R1ad1:0x1:0x0,R2

The address and size mode bits are being pulled out correctly here. The debug output is:
initial context bits: 00000000.00000000.00000000.00000000
resolving constructor for instruction bytes at: ram:00000000
check pattern[1 of 1]: {line# 26} TEST <rspost>, <reg0_4>
   byte pattern: mask=11111111.11110000.00000000.00000000
           bytes[0-3]=11111101.00101000.00010010.11111101
          match-value=11111101.00100000.00000000.00000000 Matched
      Set mode_ad(0,1) = 0x2
      Set mode_sz(2,3) = 0x0
ad2_2: TokenField = 0x2
sz0_2: TokenField = 0x0
reg0_4: resolving...
   reg0_4: register R13 (size:4)
rspost: resolving...
   decide on context bits: bitrange=(0,1), value=0x2, context=(10)000000.00000000.00000000.00000000
      decendent constructors for decision node (complete tree dump ordered by line number):
       rspost: {line# 23} <reg4_4>ad2:<ad>:<sz>
   check pattern[1 of 1] rspost: {line# 23} <reg4_4>ad2:<ad>:<sz>
      context pattern: mask=11000000.00000000.00000000.00000000
             context(0..31)=10000000.00000000.00000000.00000000
                match-value=10000000.00000000.00000000.00000000 Matched
                  mode_ad(0,1) == 0x2 Match
      reg4_4: resolving...
         reg4_4: register R1 (size:4)
      ad: ContextField = 0x2
      sz: ContextField = 0x0

Prototype parse successful: TEST R1ad2:0x2:0x0,R2
Instruction length = 3 bytes
Instr Mask:  11111111.11110000.00000000
Instr Value: 11111101.00100000.00000000
Op-0 Mask:   00000000.00000000.11110000
Op-0 Value:  00000000.00000000.00010000
Op-1 Mask:   00000000.00000000.00001111
Op-1 Value:  00000000.00000000.00000010
DebugSleighInstructionParse.java> Finished!

So the Set mode_ad(0,1) = 0x2 and Set mode_sz(2,3) = 0x0 are clearly missing from the first run. I'm not familiar with the inner workings of Sleigh to know why it's applied for the byte pattern match in the second case but not the first.

This was my suspicion with the matching.  The original intent of the disassembly action was to be applied when the base constructor matches.  So you may have uncovered a bug.
From the debug parse, it does appear the base constructor disassembly action isn't applied until after the sub-constructor matches if the all possibilities aren't available.
How many variants are there for the source versus destination?   If there are only two or so, I would just duplicate.
You could have a sub-constructor that does the context setting.  That might get around the "feature" although the same thing could happen here.  Not sure the exact syntax, but below is the general idea.
rspost: reg4_4^"ad2:"^ad^":"^sz is reg4_4 & mode_ad = 0x2 [ ad = mode_ad; sz = mode_sz; ] { local tmp:4 = reg4_4; export tmp; }
rspost: reg4_4^"ad3:"^ad^":"^sz is reg4_4 & mode_ad = 0x3 [ ad = mode_ad; sz = mode_sz; ] { local tmp:4 = reg4_4; export tmp; }

ModePos1:   is  ad2_2 & sz0_2 [ mode_ad = ad2_2; mode_sz = sz0_2; ] { }

:TEST rspost, reg0_4 is op0_8 = 0xFD; op4_4 = 0x2 & ModePos1; reg0_4 & rspost  unimpl

For example the data size value is used in about a dozen tables and can be encoded in any of these locations:
   sz6_2      = (6,7)
   sz4_2      = (4,5)
   sz4_1      = (4,4)
   sz3_1      = (3,3)
   sz2_2      = (2,3)
   sz2_1      = (2,2)
   sz0_2      = (0,1)
   sz0_1      = (0,0)

Many of the tables also combine data size mode with other modes like the type of base register displacement to use or size of immediate value to load, which also have multiple possible locations.


referenceContainer can't be displayed in xref result

I turnned on this option ,but there is no container info in the result .
(setq cquery-extra-init-params '(:extension (:referenceContainer t))

No one has implemented the feature.

I found that cquery server returned the container info, but the client didn't parse it to output , right?

Yes, this is a cquery extension and not standardized in the specification. Neither lsp-mode nor lsp-ui visualize it. https://github.com/emacs-lsp/lsp-ui/issues/73


app-metrics/pcp-5.3.7 wrong USE flag postgresql

The USE flags should be postgres. https://www.gentoo.org/support/use-flags/
Description could be: "Enable PCP Performance Metrics Domain Agent (PMDA) for collecting metrics about the PostgreSQL database."

Fix in commit #68273ea136cf494da15579d1f2f224e00f7b06fe
Thanks!!


Mobile updater never finishes

Describe the bug
After updating Smartwatch Extensions, a foreground service starts and spawns an Updater to run any migrations needed. This service never finishes, and leaves a notification in the shade permanently.
To Reproduce
Steps to reproduce the behavior:

Update Smartwatch Extensions
See updater notification

Expected behavior
A clear and concise description of what you expected to happen.
Device:

Phone: Pixel 3 running Android 12 Beta 2
Watch: Fossil Gen 5 running Wear OS H MR2
App Version 4.2.1 (Debugging)

This bug still seems to be present, although it doesn't happen quite as often as before


Refactor layout

This gonna break templates?

yup, going to add old directories in for time being and then migrate the frontend to point to new templates


Add UDef-ARP

Insert URLs to the project here:
https://github.com/ClarkCGA/UDef-ARP

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@YaoTingYao @agcopenhaver


spacy load not loading

Had to add
import spacy.cli
spacy.cli.download("de_core_news_sm")

else it would not load de_core_news_sm
See https://stackoverflow.com/questions/62822737/oserror-e050-cant-find-model-de-it-doesnt-seem-to-be-a-shortcut-link-a

Did you make sure to run the commands for downloading the models first?
python -m spacy download en_core_web_sm
python -m spacy download de_core_news_sm

This is listed in the README and in the first section of the first notebook.


Check recent reports in allspam

Implemented check for recent reports before a post is reported in allspam, to prevent duplicate reports.
Potentially fixed issue #2795

Rather than having a lot of special purpose logic in allspam, which not only fetches a list of post URLs, but also actually goes and fetches the posts, why are we not just having allspam fetch the list of post URLs, and then call report_posts(), which would share the logic that's there with !!/report? report_posts() might need some moderate adjustments, but conceptually !!/allspam is just "go fetch what posts this user has and !!/report them". It looks like the logic in SD could just be that, and it would clean allspam() up quite a bit.

Closed for reasons suggested by Makyen and the next step is outlined here.


HELM PUSH --version

Output of helm version:
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.0", GitCommit:"e19964183377d0ec2052d1f1fa930c4d7575bd50", GitTreeState:"clean", BuildDate:"2020-08-26T14:30:33Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): baremetal
I used the push plugin (https://github.com/chartmuseum/helm-push) and now you have replaced it with your own. (helm push)
The --version option is sorely missing!

@helldweller try helm version

helm push only accepts charts that were packaged with helm package. Once a chart has been packaged, Helm does not make any changes to its metadata as that will invalidate any signatures generated with helm package --sign. Therefore we will not be introducing a --version flag to helm push, as that will modify the chart's metadata and invalidate the signature.
chartmuseum's helm push plugin was an early concept design that both packages and pushes a chart in one command, but did not include core concepts like package attestation or signing in its design.
In your case, chartmuseum's helm push --version is identical to helm's helm package --version && helm push.
Please use the helm package --version flag before a helm push.
Thanks.


Throttle callbacks (again) + crash fix

This reverts the removal of throttling, and adds two changes that seem to resolve the crash.  The likely fix is https://github.com/nodegit/nodegit/commit/1e585eae28fae98e1807cf20d88e643dae5cf7de, which restores some logic I omitted in the refactoring, thinking it should not make a difference... but it looks like it did.
I am a little worried about the state of the raw object making a difference after its wrapper has been deconstructed, but maybe I'm just missing the big picture of what's happening here.  In any case, the logic matches what we were doing before, and no crash is better than crash.

This will fix #919

We've been running this in GK now with no reports of breakage. :+1: this is gtg. Thanks @srajko!


[resotoshell][fix] Fix sort suggestion and improve option information

Description

To-Dos

[x] Add test coverage for new or updated functionality
[x] Lint and test with tox

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Codecov Report

Merging #829 (ca7e719) into main (12dea08) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   89.86%   89.86%   -0.01%
==========================================
  Files          69       69
  Lines        9995     9993       -2
==========================================
- Hits         8982     8980       -2
  Misses       1013     1013

Flag
Coverage Δ

resotocore
89.86% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

resotocore/resotocore/cli/command.py
87.55% <100.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12dea08...ca7e719. Read the comment docs.


Import ASM from dav1d 0.7.1 and 0.8.0

No measureable performance change for x86_64-AVX2. Would be nice to have some testing done by someone with access to ARM.

Coverage decreased (-0.07%) to 65.525% when pulling 4ff303dc5b3289eb398da837ea9d8068cb03f980 on shssoichiro:dav1d-080-asm into 0fd6cc63f99c298d75d80ab2b5c7da8e0a5eee90 on xiph:master.

Is there any new code we hadn't wired in yet?

On x86_64, it looks like there is now an AVX-2, SSSE3, and SSE2 version of put/prep_8tap/bilin. On ARM, there seem to be several new items.


yAxis.smartAxis: smartAxis of true no longer shows the top data value

code sample:
$(function () {
    var data = [{x: 0, y: 103},{x: 44, y: 103},{x: 154, y: 36},{x: 309, y: 150},{x: 376, y: 150},{x: 400, y: 171}];

    new Contour({
        el: '.myLineChart',
        yAxis: { smartAxis: true }
      })
    .cartesian()
    .line(data)
    .render();
});

behavior with 0.9.80:

behavior with 0.9.105:

we'd like smartAxis to have a yAxis tick mark equal to the largest data value, even if that value is not a round or pretty number.

verified in 0.9.107 from 1/2/15


Update README.md

Updating our read.me such that it is aligned with our current material and mission.

Thanks! Can you add your name to the list of contributors as well? Unless you prefer to remain anonymous...


Installation troubles because of existing "scan" executable (from Avast antivirus package)

When I'm trying to install using
sudo gem install fastlane --verbose
I get this warning/error message while installing "scan":
/Library/Ruby/Gems/2.0.0/gems/scan-0.3.2/lib/scan/version.rb
scan's executable "scan" conflicts with /usr/local/bin/scan
Overwrite the executable? [yN]  n
ERROR:  Error installing fastlane:
"scan" from scan conflicts with /usr/local/bin/scan
Apparently, my "Avast Internet Security" already installed /usr/local/bin/scan
How to proceed? Can I somehow change the default name of the "scan" executable used by fastlane?
Thanks, Thomas

bump Any Idea for a workaround? I'd really like to use fastlane...

Not to be taken seriously: I'd uninstall Avast
More serious reply: you can always run all fastlane tools using fastlane run scan or even better: create a Fastfile for your project (using fastlane init) and add a lane with your scan call from there

Thanks, but the problem is that the installation of the "scan" gem fails, so fastlane does not get installed.

@thomers  One potential workaround is to install RVM since it puts the gems in a directory where only gems can exist (No apps) :) I find it solves a lot of issues.

You could also use --bindir to change the directory where the binstubs get installed in.

I'm going to close this issue since it has been open for a while without follow up.


Volume Overlay (Key Press layer conditional override) is delayed by several seconds.

Expected Behaviour
Volume Overlay (Key Press layer conditional override) should respond immediately.
Actual Behaviour
It takes several seconds of repeatedly pressing VolumeUp / VolumeDown before they are recognized by the Key Press layer conditional override to enable the Volume Overlay layer.
Reproduction steps
Press the volume keys once, and the overlay does not trigger. Repeatedly press the volume keys for several seconds, and the overlay finally appears. While the overlay is enabled for 3 seconds, all volume changes are instantly recognized.
Frequency
Every time
Aurora Version
0.7.0
Previously an Issue?
No

Does it behave like this if you were to use other keys?
In the meanwhile, you could also try replacing the two keydown conditions with a "Numeric change detector" and setting the watch value of that to be the LocalPCInfo\Volume game state.

I'll test it and report back. I created another solid fill layer below the volume overlay for a dimming effect, and assigned it the same volume key press override. The two layers activate at different times when pressing the volume keys, and sometimes only one activates/

Does it behave like this if you were to use other keys?
In the meanwhile, you could also try replacing the two keydown conditions with a "Numeric change detector" and setting the watch value of that to be the LocalPCInfo\Volume game state.

Other keys respond instantly. The problem is only with the volume roller. I have a Logitech G810.
The Numeric State Variable does not list any expressions in the drop down if it is a child of Number Change Detector. It only lists expressions if it's the top level element. I entered LocalPCInfo/SystemVolume manually into default.json as a workaround. It now detects instantly, but the lighting flickers only when pressing the volume keys as it has no retain duration.

Yeah there's a known issue with the variables propogating down properly. Sometimes the vars reappear if you select a different property and then go back, but not always. :\
There should be a "True extender" (I think that's what it's called) which does what it's name suggests - extends the length of a true signal. If you put the change detector in one of these (you can use the copy and paste buttons so you don't have to repeat the JSON editing process), you should be able to make it stay on for a few seconds.


Issue with locating artifact using maven

Steps to Resolve:

Clean .m2 (local repo) on machine
Tried other versions
Re ordering repos
Tried separate machine

Error: Could not find artifact com.github.Xezard.XGlow:XGlow:jar:1.1.0
<dependency>
    <groupId>com.github.Xezard.XGlow</groupId>
    <artifactId>XGlow</artifactId>
    <version>1.1.0</version>
</dependency>

Ref: #23

Don't know why but changing the artifact ID to XGlowAPI fixed it.


websocket和actor改成typed actor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like

最后做这个

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

akkahttp 使用classic actorSystem，其他使用typed


Use different artifact name for shuffle manager 2/3

[BUG]/[FEATURE] title
What changes were proposed in this pull request?
Use different artifact names for shuffle manager 2/3
Why are the changes needed?
Duplicated module name may cause some issues for Maven command, e.g.
build/mvn versions:set -DnewVersion=0.2.0-netease -DgenerateBackupPoms=false -Pspark-3.1

the bump version command does not work well before, but does after this change.
What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
dev/make-distribution.sh -Pspark-2.4

dev/make-distribution.sh -Pspark-3.1

build/mvn versions:set -DnewVersion=0.2.0-netease -DgenerateBackupPoms=false -Pspark-3.1

/cc @related-reviewer
/assign @main-reviewer

This is really useful!


Parameter setting for training the RDN ArtefactCancelling models?

Dear cfrancesco,
I am very interested about how you train the ArtefactCancelling RDN model as you provided in the 'sample_weights/' dir.
I tried to try the model, but didn't get a very good result.
Below is my training scripts.
from ISR.models import RDN
from ISR.models import Discriminator
from ISR.models import Cut_VGG19

lr_train_patch_size = 40
layers_to_extract = [5, 9]
scale = 2
hr_train_patch_size = lr_train_patch_size * scale

rdn  = RDN(arch_params={'C':3, 'D':10, 'G':64, 'G0':64, 'x':scale}, patch_size=lr_train_patch_size)
f_ext = Cut_VGG19(patch_size=hr_train_patch_size, layers_to_extract=layers_to_extract)
discr = Discriminator(patch_size=hr_train_patch_size, kernel_size=3)

from ISR.train import Trainer
loss_weights = {
  'generator': 0.0,
  'feature_extractor': 0.0833,
  'discriminator': 0.01
}
losses = {
  'generator': 'mae',
  'feature_extractor': 'mse',
  'discriminator': 'binary_crossentropy'
}

log_dirs = {'logs': './logs', 'weights': './weights'}

learning_rate = {'initial_value': 0.0004, 'decay_factor': 0.5, 'decay_frequency': 30}

flatness = {'min': 0.0, 'max': 0.15, 'increase': 0.01, 'increase_frequency': 5}

trainer = Trainer(
    generator=rdn,
    discriminator=discr,
    feature_extractor=f_ext,
    lr_train_dir= '/data1/wjb/div2k/DIV2K_train_LR_bicubic/X2/',  #'div2k/DIV2K_train_LR_bicubic/X2/'
    hr_train_dir= '/data1/wjb/div2k/DIV2K_train_HR/',  #'div2k/DIV2K_train_HR/'
    lr_valid_dir= '/data1/wjb/div2k/DIV2K_valid_LR_bicubic/X2', #'div2k/DIV2K_train_LR_bicubic/X2/',
    hr_valid_dir='/data1/wjb/div2k/DIV2K_valid_HR/', #'div2k/DIV2K_train_HR/',
    loss_weights=loss_weights,
    learning_rate=learning_rate,
    flatness=flatness,
    dataname='div2k',
    log_dirs=log_dirs,
    weights_generator=None,
    weights_discriminator=None,
    n_validation=100,
)

trainer.train(
    epochs=300,
    steps_per_epoch=100,
    batch_size=16,
    #monitored_metrics={'val_generator_PSNR': 'max'}
    monitored_metrics={'val_generator_PSNR_Y': 'max'}
)

Best Regard,
Even

Hi,
the first few epochs (~20) you might want to train the model only with the MAE instead than adversarial loss (maybe without adding noise?).
There is not automatic switch yet though, so you have to train and then train again loading the pre-trained weights you obtained in the first part

Hi,
the first few epochs (~20) you might want to train the model only with the MAE instead than adversarial loss (maybe without adding noise?).
There is not automatic switch yet though, so you have to train and then train again loading the pre-trained weights you obtained in the first part

HI @cfrancesco,
Thank you very much for your reply!
I will try it!
By the way, do you think it's possible to train the RDN ArtefactCancelling models with smaller models? like the one I used above (rdn  = RDN(arch_params={'C':3, 'D':10, 'G':64, 'G0':64, 'x':scale})
And do you think my configurations to train the ArtefactCancelling model ( after loading the pre-trained weights ) is correct above?

If you have an adequate dataset, I would use a 4x upscaling.
For the rest, your configuration looks fine. In my experiment I observed no to very little qualitative difference between the larger and smaller models.
I would however recommend  to use the RRDN model, with a similar configuration to what we provide already: you could for instance retrain the provided RRDN GANS model, with proper preprocessing have it learn noise (et al.) cancelling and share here your results ;)

@cfrancesco
Hi cfrancesco,
My idea is to train a model that can resize images to any size.
To achieve this,
during the training phase, I would like to train an SR model with 1x scale factor;
during the inference phase, I would resize the image to the desired size first, and then use the SR model to enhance it.
I am not sure if this idea is practical?
Second, the reason I would like to use a smaller model is that I found the original model is very slow during training and inference time even with the support of GPU resources.
It took me about 10 minutes to process 100 images, I don't know why.
By the way, I found the model doesn't use too much GPU resources during the training process. I have a GPU with 32GB memory, but it looks like only about 300MB GPU memory are used during the training phase. Do you know how to make the model runs faster?
Best Regard,
Even.

Nice idea, but that kinda means to go back in time. Image restoration used to be the pre-2015(16?) approach, which according to the literature delivers worse results.
Yes, these models are slow due to the high number of operations needed (the model does not shrink through the layers). You could try to parallelize the inference of different images to speed up, if your gpu allows for it

haha @cfrancesco , you are right !!!
Upscale image to a larger size and then downscaling it would be a better idea!
But the speed of the model could still be a tricky problem~!
I don't know how you solve it~ Maybe I should try to explore the light-weight model ！


Menu route items are not visible

Describe the bug
An example project from Copilot and a project downloaded from start do not have any route items in Drawer  However frontend/generated/file-routes.ts has the route definitions. Additionally, routes are visible on flow projects.

import type { AgnosticRoute } from<EMAIL_ADDRESS>import { createRoute } from<EMAIL_ADDRESS>import * as Page0 from<EMAIL_ADDRESS>import * as Page1 from "../views/hello-world.js";
import * as Layout2 from<EMAIL_ADDRESS>const routes: readonly AgnosticRoute[] = [createRoute("", Layout2, [createRoute("", Page0), createRoute("hello-world", Page1)])];
export default routes;

Expected-behavior
Routes should be rendered in Sidenav properly.
Reproduction
Download a project from start.vaadin.com or open the project.
my-app (39).zip
System Info
Vaadin version: 24..5-SNAPSHOT
OS: MacOS 14.4.1 (23E224)

This is probably because 24.5-SNAPSHOT downgrades hilla npm dependencies from 24.4 beta2 to 24.4 beta1

Just a side note:
Apart from what the actual cause of this issue is, the menus are populated based on the value of the window.Vaadin.views global object, that in turn is being initialized based on the entries of file-routes.json not the file-routes.ts. However, when there are proper routes imported in the file-routes.ts, it can be assumed that the proper values are also present in the file-routes.json.

Hi @abdullahtellioglu,
I gave your attached application a try with beta3 and couldn't reproduce the issue, the output looks like this:

Is this still an issue for you or could we close it?

I cannot reproduce it either. Closing the issue as complete 👍  Thanks @taefi


Revert "Merge pull request #4339 from bartvde/issue-4337"

This reverts commit 7f4c6e363464ed72e35d2465e0b38bf68afeea22, reversing
changes made to c5dac0aa70548a33df7a1b9308a218ad030df91e.
fixes #4406

Looks good @bartvde.


Provide support for prisma DB tool

Prisma replaces traditional ORMs and custom data access layers with a universal database abstraction used via the Prisma client. It provides Type-safe database access including filters, aggregations, pagination and transactions.
The necessary configurations is to be automated as required.

I will also work on this please assign me.


Getting this error when compiling on Windows (mingw32 with partial C++11 support)

does your compiler version has support for std::future? I've come across a few posts of other devs with similar error and it was a version that did not had that function implemented.

I confirm that I have this error with msvc version 14.0 (both x64 and x86). Mingw64 with latest gcc compiles successfully. Also I don't see any point in this callback. If I comment it out everything works just fine with both mingw and msvc. Maybe it should be deleted? By the way, custom title is not displayed even with callback. I just see standard "Browse folders" title.

@funbiscuit can you paste your msvc error? The error above is from GCC on a platform that only partly supports C++11 and does not have std::future.

@samhocevar
C:\projects\portable-file-dialogs\portable-file-dialogs.h(499): error C2065: 'callback': undeclared identifier
C:\projects\portable-file-dialogs\portable-file-dialogs.h(499): error C2100: illegal indirection

Commenting out lines 497 to 501 gets rid of it and everything works fine. You did mention in Issue #14 that this is a compiler bug (in VS2015)

@wheremyfoodat it appears that your current toolchain (mingw32) does not fully support C++11, namely the std::future feature.
It would seem that installing the POSIX threads API for mingw32 could solve the issue. Please let me know!

@wheremyfoodat the mingw-std-threads project now also supports std::future, it could be a good solution for you. I have successfully used that project in the past.

I am closing this issue because std::future is too convenient and I do not wish to replace it with something else that would probably be cumbersome to maintain. There are several ways to fix it:

use a compiler that fully supports C++11
use the mingw-std-threads project
install the POSIX threads API for mingw32


Pagination on get by location

Is this possible on the current version? I do not see an function for it.
Any possibility of this being added in the future?

any idea why this is coming up?
[Symfony\Component\Debug\Exception\FatalErrorException]
Call to undefined method InstagramScraper\Instagram::withCredentials()
I cant seem to login with the API

If anyone is wondering the above error means you have failed to require the API properly.


Consider redesigning how :relayout() works as its functionality can be redundant

Why is it necessary to do this in some situations?
function MyElement:relayout()
   for j = 1, 10 do
      local x = self.x + 60
      local y = j * 18
      self.icons[i]:relayout(x, y)
   end
end

function MyElement:draw()
   for j = 1, 10 do
      local x = self.x + 60
      local y = j * 18
      self.icons[i]:draw()
      Draw.text("Text " .. j, x + 20, y)
   end
end

The problem is that Draw.text() is stateless, while icons[i] is a stateful UiElement. You could just call relayout(x, y) in the draw() method, but then why would we even call it in the parent element's relayout() as above? It sounds leaky to me.
Maybe we should pass x and y to IElement:draw(x, y) and only leave IUiLayer:draw() as a 0-argument method (or maybe a two-argument method where you can supply an optional x/y pair that overrides self.x/self.y?). Then the IUiLayer would become the only GUI component to have knowledge of its own position/size.
function MyElement:relayout()
end

function MyElement:draw(x, y)
   for j = 1, 10 do
      local x = self.x + 60
      local y = j * 18
      self.icons[i]:draw(x, y)
      Draw.text("Text " .. j, x + 20, y)
   end
end

Could still be somewhat leaky when it comes to IUiLayers drawing/updating nested IUiLayers, as some of the code already does. You'd call :relayout() on the child layers in the parent's :relayout() still, and call :draw() with no arguments like before.
I don't think it makes sense to have an IUiElement draw/update an IUiLayer. Kind of useless because the IUiElement won't be able to send input to its sublayer, unless it implements IInput.

Or in this case you could just use Draw.make_text() in case you have some stateful elements that you want to relayout all at once.


make public setters for all gui controls, not just the color picker

added everywhere except gradientPicker and button, good enough


How to get total VAI minted and amount of borrowers and suppliers

Hi,
Can you please tell me how I can get the total VAI mintend directly from the smart contract?
And also would like to know how I can read the the total borrowers and suppliers from the smart contract.

you can get total VAI minted amount from VAI contract as total supply.
and for total borrowers and suppliers, you should get from venus api
please check this doc
https://docs.venus.io

Thank you!


Disabling generation of dummy elements of fixed arrays.

Okay, I'm either blind or dumb, but I can't find a way to disable generating dummy fields for fixed arrays, i.e:
double m_lastAccessTime[1024];

becomes:
[FieldOffset(16)]
public fixed double m_lastAccessTime[1024];

[FieldOffset(24)]
public double __dummy_m_lastAccessTime_1;

...(Tons of dummies)

[FieldOffset(8200)]
public double __dummy_m_lastAccessTime_1023;

As you can see, I'm getting a lot of garbage code. How can I get rid of it?

I am afraid this hack is necessary to work around a bug in Mono: https://bugzilla.xamarin.com/show_bug.cgi?id=33571 . I have reported it nearly a year ago but nobody has paid any attention to it, in fact, a Mono project member even argued it wasn't a bug.

Oh wow, that was unexpected, I'll try to figure out if it's possible to workaround it in other way. Thanks for reply.

If you only need to use the generated code with .NET then you can safely remove those dummy fields from generation. We have fixing this Mono bug in the roadmap so hopefully soon we can get rid of these workarounds.

How can I do it via pass?

Unfortunately, you can't. You'll have remove the relevant code from the C# generator - https://github.com/mono/CppSharp/blob/573dc623f8887324636f9011c3e887c5eb7804cc/src/Generator/Generators/CSharp/CSharpSources.cs#L851 - and build C++# yourself.


Update versions - 21.7

Codecov Report
Base: 72.98% // Head: 67.32% // Decreases project coverage by -5.66% :warning:

Coverage data is based on head (1f2d583) compared to base (bf4c095).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   72.98%   67.32%   -5.67%
==========================================
  Files          41       41
  Lines        1784     1784
==========================================
- Hits         1302     1201     -101
- Misses        482      583     +101

Impacted Files
Coverage Δ

contracts/base-minter/src/state.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

contracts/base-minter/src/contract.rs
0.00% <0.00%> (-85.85%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


update actions core to 1 9 1

Update @actions/core to 1.9.1.
Rebuild dist/ after updating @actions/core to 1.9.1.

See:

https://github.com/gh640/command-result-action/security/dependabot/1


feat(rust): wrap stored policy expressions

To future-proof the policy storage, expressions are wrapped in another struct to enable the addition of metadata, version information etc.

@mergifyio rebase


i suggest this

where do I put in ideas i think you should make a setting to make different suits from different mods have the same thicc model

Consider asking the person who actually made the mod. This github is for the API.


Symfony 2.7 update

ping @wachterjohannes

this should make it into 1.1 /cc @danrot @wachterjohannes @berndhep

The PHPCR-ODM library still has version 1.3 not released, with the fix for the deprecation notice. If we merge that we are probably having a lot of deprecation notices...

hi @danrot ,
PHPCR-ODM has been released https://github.com/doctrine/phpcr-odm/releases/tag/1.3.0
Can we bump symfony's dep version to 2.7 ? :) it's a blocking point sf 2.6.* for us :+1:

@cbastienbaron Yeah, I've seen that. We said that we will make a direct upgrade to 2.8. Would that also be ok for you?

that would be perfect :+1:  :+1:  :+1:

Ok, that will be done on develop quite soon. 1.2 will then be released with Symfony 2.8. In the mean time you could simply change the dependency to 2.7, I think @tomsvogel uses it like that.

seems to have some test failed with 2.8
2) Sulu\Bundle\SnippetBundle\Controller\SnippetControllerTest::testCopyLocale
Symfony\Component\DependencyInjection\Exception\RuntimeException: You have requested a synthetic service ("kernel"). The DIC does not know how to construct this service.


Attribute with collection with generic annotation return type generates incorrect PHPDoc

Versions:

ide-helper Version: 2.12.3
Laravel Version: 8.83.25
PHP Version: 7.4

Description:
Incorrect PHPDoc was generated for attribute with Laravel Collection with generic annotation return type, for example:
	/**
	 * @return \Illuminate\Support\Collection<int, \App\Models\Answer>
	 */
	public function getAnswersAttribute(): Collection
	{
		return collect();
	}

result:
 * @property-read \Illuminate\Support\Collection<int, $answers

@bbprojectnet This would improve code-completion in e.g. PHPStorm greatly. What else is needed to support this in laravel-ide-helper?

Hi @grEvenX,
nothing :) this bug was fixed by https://github.com/barryvdh/ReflectionDocBlock/pull/9

@bbprojectnet Hm, maybe I'm just not understanding the scope of the issue.
I was able to get updated ReflectionDocBlock but when I ran the Laravel IDE helper, the generated doc-block for models using php artisan ide-helper:models "App\Db\User" --write --reset still used the old formation without type-hints.
I was expecting
* @property-read Collection<int, \App\Db\UserFeedback> $feedbacks

but instead got
* @property-read Collection|\App\Db\UserFeedback[] $feedbacks
* ```

This issue is not about that :) It is talking about broken PHPDoc for attributes which returns Collection, but You probably have case with model relation. Am I right?
If yes, this PR is more accurate what You looking for: https://github.com/barryvdh/laravel-ide-helper/pull/1298 - I'm also waiting for that :)

@bbprojectnet Thanks. I guess this issue can be closed as solved then?

Yes.


Update virtual-machines-windows-troubleshoot-rdp-connection.md

Removed old diagnostic KB from references. Requested by Craig Landis and Ram Kakani.

@JarrettRenshaw,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@JarrettRenshaw : Thanks for your contribution to the Azure documentation! The author, @iainfoulds, has been notified to review your proposed change.

Looks good, can merge. Thanks.
#sign-off


document DNS spoofing vulnerability

note that even though the hunter exploits the ARP spoofing vulnerability https://github.com/aquasecurity/kube-hunter/blob/master/docs/kb/KHV020.md, it is still distinct as there could be other ways to spoof. I tried not to mix the two.

added site.baseurl as discussed in https://github.com/aquasecurity/kube-hunter/pull/210#discussion_r335545390


problem support custom primary

Description
this builds on #250 BUT if we fix that issue ... we run into the next one
this line
        condition_key = meilisearch_options[:type].primary_key if has_virtual_column_as_pk

calls the primary_key method on the model. Mongoid doesn't have a primary_key method and it seem to be doing anything with the fact that I've added the following to my model. It should be calling my ms_id method but it's hardcoded to call primary_key
meilisearch primary_key: :ms_id

this may actually be an issue that extends beyond mongoid, but i can't test that at the moment.
Expected behavior
call the primary key method i told it to.
Current behavior
it called .primary_key which is a non-existent method.
Task.find('foo')
/Users/masukomi/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/meilisearch-rails-0.9.0/lib/meilisearch-rails.rb:650:in `ms_search': undefined method `primary_key' for Task:Class (NoMethodError)

        condition_key = meilisearch_options[:type].primary_key if has_virtual_column_as_pk

Environment (please complete the following information):

OS: [macOS]
Meilisearch server version: [e.g. v.1.1.1] (irrelevant though)
meilisearch-rails version: [e.g v0.9.0]
Rails version: [e.g. <IP_ADDRESS>]

the problem appears to be putting the meilisearch primary_key: :ms_id line after my meilisearch do block. If i move it above it it isn't a problem. The documentation does not show how to combine the block form and the non-block form and it's not clear how to specify a primary key in the block form (or if that's even possible)
so, the temp fix here may be to just fix the readme to provide examples of the block and non-block forms in the same model, OR documenting how to not need that. This would be until the longer term fix can be put in place such that ordering isn't important.

Following my comment in the previous issue #250 we need to proper test and fix the issues in the MongoId.

I'm going to close this issue because all the MongoDB requests are going to be tracked in the issue https://github.com/meilisearch/meilisearch-rails/issues/175.


Give explicit permalinks to old posts

Relying on the generated URLs is too constraining; it prevents recategorizing.

[x] 03 May 2014 » Storing Bandwidth with Superdense Coding
[ ] ...


[SUPPORT] update-bot-staging-explorer-eth

📝 Description
Since the ethereum family does not exist anymore, replace it's reference in the update-bot-staging-explorer-eth job by evm
Questions:
Based on the name of the jobs, it seems like we are expecting to test a currency and not a full family.
Does it make sense for this job (as well as for the bitcoin one) to test the whole family or should they rather only test the ethereum and bitcoin currencies (replacing BOT_FILTER_FAMILIES: bitcoin by BOT_FILTER_CURRENCIES: bitcoin and BOT_FILTER_FAMILIES: evm by BOT_FILTER_CURRENCIES: ethereum)?
❓ Context

Impacted projects: ``
Linked resource(s): https://github.com/LedgerHQ/ledger-live/pull/4285

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

@chabroA Yes your analysis is mostly correct.
Bots used for staging explorers are only relevant for Ledger explorers, so :

EVM should now indeed use BOT_FILTER_CURRENCIES instead of BOT_FILTER_FAMILIES, however the currencies should be all the ones coming from the legacy ethereum family: ethereum, ethereum_goerli, ethereum_classic, polygon, bnb, avalanche_c_chain (list to be confirmed).
Bitcoin should keep using BOT_FILTER_FAMILIES though, since there were no changes there and the whole family still relies on Ledger explorers.

@chabroA Yes your analysis is mostly correct.
Bots used for staging explorers are only relevant for Ledger explorers, so :

EVM should now indeed use BOT_FILTER_CURRENCIES instead of BOT_FILTER_FAMILIES, however the currencies should be all the ones coming from the legacy ethereum family: ethereum, ethereum_goerli, ethereum_classic, polygon, bnb, avalanche_c_chain (list to be confirmed).
Bitcoin should keep using BOT_FILTER_FAMILIES though, since there were no changes there and the whole family still relies on Ledger explorers.

Indeed if we want to be "iso" we'd need to filter on old ethereum family with a currency filter

@chabroA Yes your analysis is mostly correct.
Bots used for staging explorers are only relevant for Ledger explorers, so :

EVM should now indeed use BOT_FILTER_CURRENCIES instead of BOT_FILTER_FAMILIES, however the currencies should be all the ones coming from the legacy ethereum family: ethereum, ethereum_goerli, ethereum_classic, polygon, bnb, avalanche_c_chain (list to be confirmed).
Bitcoin should keep using BOT_FILTER_FAMILIES though, since there were no changes there and the whole family still relies on Ledger explorers.

Filtered on the list of currencies previously handled by the ethereum specs:
https://github.com/LedgerHQ/ledger-live/blob/18b4a47b4878a23695a50096b7770134883b8a2e/libs/ledger-live-common/src/families/ethereum/specs.ts#L284-L291


Help needed with MacOS: UioHookResult.ErrorAxApiDisabled

First of all, thank you for all your work here! I could create some hotkeys in a MAUI app for Windows in a couple of minutes without any problem.
But I'm having issues with Mac Catalyst. I keep receiving the ErrorAxApiDisabled exception and I already gave permissions. Am I missing something? The code is being executed in the main thread.

I have MacOs Sonoma 14.4.

Hi! Thanks for posting this issue! This is definitely weird, the app shouldn't ask for permissions again. Could you please share a minimal reproducible example so that I can poke it around on my machine?
Maybe - and this is a long shot - you should also enable accessibility permissions for VS Code? Since this application is a child process of VS Code, it may help, but I'm not sure since I don't really know how macOS manages these permissions. Might as well try it out though.
Also, you shouldn't run the global hook on the main thread in MAUI apps since the main thread should be used as the UI thread. You should instead call RunAsync and ignore the result - it will then run on a separate thread.

Also, it would be nice if you shared the debug logs of libuiohook. You can find more info in the docs.

Had same problem. Seems to be running when not attaching the debugger (Using Rider as IDE). Thanks for the heads up on not running on the UI thread. This was also my initial thought, but thought I not to question it.

Thanks @PayProff-Don, that's an interesting thought I haven't considered earlier. I'll check it out when I have some time (I'm not sure when that will actually be, sorry).

@TolikPylypchuk Hello! The same issue. Works on Release build, fail on Debug. Does any chance there is some progress? Or maybe any workaround to make it work with debug

Hello, @titan19! No, I didn't have any progress with that, sorry. I still cannot reproduce the issue on my MacBook, everything works just fine for me :/


Reduce the size of Iaso docker image

We were adding the node_modules of Polio and other useless stuff in the image.

should be unneed with #195

nevermind we still need it for the Webpack docker


chore: Documentation for plugins

Added basic documentation for the Plugins mechanism and surface it offers
in the Tools section of the documentation.
Fixes #717

This commit should be prefixed with docs (or feat) so it will appear in the changelog.

Any update on where Plugins are at? @eladb
For us, we would LOVE for a way to just create plugins to simplify deployments.
Currently, with Serverless Framework we need to inject various stack outputs into the JS of our frontend (ReactJS). To do this now, we use a plugin that outputs all stack outputs to a .env file and then Webpack slurps those vars in at build time. So translating this for CDK we'd need a way to:

Deploy Stack
Build Assets
Deploy Assets to S3

In this way there are many plugins that could make our job easier:

Upload/Delete assets to S3 on Deploy/Remove (since needs to happen after deploy and can't then be part of stack)
Save Stack Outputs to file
Invalidate CloudFront Distro based on files changed

etc.
One common theme of all these is that they need CDK lifecycle hooks and inputs into the various values.
Thoughts? Better channel to chat on?


It is throwing error "Cannot find module '@schematics/angular/utility/project-targets' " while adding ng add @ng-toolkit/universal

I'm submitting a...

[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request

In package

[ ] @ng-toolkit/init
[ ] @ng-toolkit/serverless
[ ] @ng-toolkit/universal
[ ] @ng-toolkit/pwa
[ ] @ng-toolkit/firebug

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Example repository

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

- Node version: XX
- Platform:

Others:

Angular Environment
Angular CLI: 6.1.5
Node: 8.12.0
OS: linux x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package                           Version
@angular-devkit/architect         0.7.5
@angular-devkit/build-angular     0.7.5
@angular-devkit/build-optimizer   0.7.5
@angular-devkit/build-webpack     0.7.5
@angular-devkit/core              0.7.5
@angular-devkit/schematics        0.7.5
@angular/cli                      6.1.5
@ngtools/webpack                  6.1.5
@schematics/angular               0.7.5
@schematics/update                0.7.5
rxjs                              6.3.3
typescript                        2.7.2
webpack                           4.9.2

Closing now for housekeeping purposes.