Fix some issues with the xds-protos package

Last PR https://github.com/grpc/grpc/pull/25975 failed to discover several important issues, because the test was way too weak. A pre-release package has been uploaded to https://pypi.org/project/xds-protos/. Manually tested. I will upload a new release after this PR.
Fixes

0.0.1 failed to include non-envoy protos
Make xds-protos compatible with Google's namespace packages
Split the build process from setup.py (setup.py will always be imported during the install process)

Improvements

Added a README
Make sure the test is truly isolated

This change is

@gnossen PTAL.

Known failures: https://github.com/grpc/grpc/issues/25242 https://github.com/grpc/grpc/issues/26022 https://github.com/grpc/grpc/issues/26023


[Feature] Edit existing yaml frontmatter field's name.

nam: Frank
Think that there is a bunch of files that include this yaml field. In this situation, I want to change "nam:" to "name:" but  I didn't find a feature that exist in this plugin.
I could change the name of the field in fileclass' settings, but it doesn't change the files that include this field.

Hi, renaming fields isn't in the scope of this plugin.
You could do this with a text editor such as VSCode for example : it has strong search and replace capabilities (that's what i'm using currently)

I am aware of VSCode search replace function but thank you. I mean this plugin is about metadata and I think that this should be in this plugin's scope. Because, I use this plugin for my academic research and analysing this data. So, I have lots of page and metadata. Therefore, I have to change the metadata name sometimes.
Thank you very much because this plugin so helpful for me.

I fully support the viewpoint expressed by @ertugruluyar-github . While I understand that the requested feature might currently fall outside the scope of this plugin, I'd like to emphasize the significance of embracing a more object-oriented approach within Obsidian, especially considering the superior functionality provided by Supertags in Tana.
The capacity to seamlessly modify YAML frontmatter fields across multiple notes not only complements the principles of object-oriented programming and design, but it also aligns with the overall flexibility and adaptability that users seek. In an application embracing object-oriented principles, the ability to define and modify specific attributes for individual notes is essential for better reflecting the real entities and concepts represented within those notes.


Project Collaboration

Hello, I’m really impressed with your work! I’d like to talk to you about an exciting opportunity. Please reach out.
Telegram: @the_vereckel
Discord: vereckel
WhatsApp: +44 7341 822373

I am happy to accept pull requests.


conda-forge feedstock

Let's make that one as well please -- would assist in making git-annex available through conda without invoking pip.

@yarikoptic Conda-forge PR: https://github.com/conda-forge/staged-recipes/pull/15317

feedstock merged now and there is even https://anaconda.org/conda-forge/datalad-installer so -- resolved


🐞 Inspector sidebar not resizable

https://user-images.githubusercontent.com/806104/211731225-d59d9e87-3af1-46ca-89e0-8a8ad55db765.mov
The inspector sidebar should be resizable. If resizing and user exceeds the total width of the sidebar, the sidebar closes, however if the user has not let go of the mouse and the user returns to where the sidebar was, it opens again.

I've opened #970 to fix this using the current CodeEditSplitViewController implementation. @Wouter01 and I talked on Discord as they're experimenting with using SwiftUI's NavigationSplitView instead. We're going to fix this now and not close this issue, and if we come back and use NavigationSplitView in the future we'll close this.

Can we not close this and open an issue around using the SwiftUI lifecycle? I say this because the issue described was technically addressed and by doing this we are changing its scope.

Sure! We can do that


[Python APIView] Nested return type not displaying inner type

In this method (and multiple others), the return type is defined as List[ServiceBusReceivedMessage]. However, the APIView only shows List. I think it may have something to do with adding the type hint to the method signature. It did not display incorrectly before we updated to type hints in the method signature, rather than only in the docstring.

@swathipil can you provide the link to the APIView?

yes it's here: https://apiview.dev/Assemblies/Review/fb319de65d2b4eca86b215c62d0cbe7b/76c6cea520e141c289728df4ad1aba84?doc=False

And can you provide a link to the source code that is generating this? Copy-paste is fine too

It looks like APIView 0.2.8 (which was merged yesterday) might fix your issue. I tried to repro in a unit test and it passed. But it's also possible that the code I'm looking at isn't what generated this.

Well, I can repro this error the Python 3 typehint case.

This is the specific method that I was referring to, but there are other ones in this file as well that had the same issue: https://github.com/Azure/azure-sdk-for-python/blob/6807eb431ba79df48388927d788f34ab7efa1cdb/sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py#L743

Ah okay, well, yes, that does make sense then that you are seeing this. So the issue isn't Python 2 typehints at all, just the Python 3 ones. And it turns out this is the same regression due to breaking changes after Python 3.6 as (https://github.com/Azure/azure-sdk-tools/issues/2478). In the same way it started just generating "Optional", that is the same reason it is now just generating "List".


Editing a project in 3.1 makes it impossible to open in 3.0.x

Godot version: v3.1.alpha.02490db and 3.0.5.stable
OS/device including versionWindows 10 : Windows 10
Issue description:
If you edit a project in Godot 3.1, you cannot open it anymore in Godot 3.0. It throws this error:

ERROR: _load_settings_text: Condition ' config_version > 3 ' is true. returned: ERR_FILE_CANT_OPEN
   At: core/project_settings.cpp:495
ERROR: _load_settings_text_or_binary: Couldn't load file 'C:/Users/matth/Documents/Godot/testBug/project.godot', error code 12.
   At: core/project_settings.cpp:519

Steps to reproduce:

Create a project in v 3.1 and try to open it in Godot 3.0.
OR : Create a project in 3.0, edit it in 3.1 and try to open it again in 3.0

Minimal reproduction project:
This project was made in 3.1, I cannot open it again in 3.0
testBug.zip

It is not a bug
Open project.godot and edit config_version=4 to config_version=3

Thank you very much!
Also, this post was a duplicate of #18758. I am closing it.


still used/best choice

Just raising an issue to ask if this is still in use and still makes sense to use, sorry to bother

@FalseProtagonist if you're exploring other options, take a look at tributary. Both libraries work with the same ideas in mind (and probably the same underlying proprietary libraries as inspiration!). You can do some pretty cool things.

I have used dask custom graphs in combination with dask distributed dataframe transforms in recent projects. Limited DAG functionality, but you can easily scale and use same framework for distributed dataframes (if you need them) as well as your custom DAG...


cross compile to arm64

how can i cross compile to arm64 linux i tried my self but not succesful
i installed every dependency but just the x86_64 compile was successfull

See https://mesonbuild.com/Cross-compilation.html


Distance Calculation with AVFoundation has been implemented

From testing, it appears that the distance calculation using the depth data appears to work well. Using the camera intrinsics, x,y pixel coordinates are transformed into real world coordinates, which then are used in conjunction with depth values to give a distance in meters.
To-Do in the future: Incorporate some kind of depth image rectification (seems like that is recommended), test further on points not at the edges, get pipeline point information once that is implemented, and display/store this data somewhere

Moving to ARKit, so merge not needed for now


Request 2 Windows machines for testing

We are adding some MBCS testing at AdoptOpenJDK.
For Linux/AIX, the language settings can be done dynamically for each process by setting LANG environment variable.
Ansible could install language packs into English Windows and switch the language, but it requires to reboot.  Ultimately this will be best done when we have a dynamically allocated build/test farm as suggested by https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/609.
As that may take some time to achieve, so in the meantime, we would like to request 2 additional Windows machines to allow for greater language coverage.

@gdams - Do we still have Azure credits we can use up?

yeah we do :)

@smlambert What version of Windows and what machine spec are you requesting?
Common options include:
Windows Server 2016 Datacenter
Windows Server 2012r2 Datacenter
Windows Server 2008r2 SP1
2 vCPUs and 4Gb RAM ok, or do you require more?
Data disk size?

Windows Server 2012r2 Datacenter, 2 vCPUs and 4Gb RAM should be fine

The typical windows ansible test setup is a good start, there will be an additional setup on these 2 machines (for setting to Japanese and Korean locales for MBCS testing).
@toshiona @takiguc - can you please advise on what additional configuration needs to be done on these machines to ready them for use by MBCS tests?  Thanks!

Created test-2012r2-2 (<IP_ADDRESS>) and test-2012r2-3 (<IP_ADDRESS>) for the purpose.
Each of these are Windows 2012r2 Datacenter, 2vCPUs, 4Gb RAM, 127 Gb SSD data disk machines.

Unassigning myself so that somebody can pick up the task for configuring via Ansible, and adding to Jenkins.  I'll pass on the login info to the next person.

-3 is mostly ready now (Doesn't have all the compilers installed but hopefully enough)
I haven't put the character sets on yet though, and it's not connected to jenkins.
This has been set up as per the playbooks so will be a good test of whether the playbooks are in a reasonable state at the moment ..

-3 now connected to jenkins although without the test tags. I think it's got most of what test needs so @smlambert if you can try kicking off something on there and see what might still be missing that would be appreciated

Something is not quite right, same test on -1 vs -3:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/716 run on test-azure-win2012r2-x64-1
and
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/715  run on test-azure-win2012r2-x64-3
chokes on get.sh script:
$ ssh-agent
16:00:44 ++ pwd
16:00:44 ++ pwd
16:00:44 + ./openjdk-tests/get.sh -s /cygdrive/c/Users/jenkins/workspace/Grinder -t /cygdrive/c/Users/jenkins/workspace/Grinder/openjdk-tests -p x64_windows -r nightly -j SE80 -i openj9 --openj9_repo https://github.com/eclipse/openj9.git --openj9_branch master
16:00:44 ./openjdk-tests/get.sh: line 14: $'\r': command not found
16:00:44 ./openjdk-tests/get.sh: line 15: set: -
: invalid option
16:00:44 set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
16:00:44 ./openjdk-tests/get.sh: line 16: $'\r': command not found
16:00:44 ./openjdk-tests/get.sh: line 34: $'\r': command not found
16:00:44 ./openjdk-tests/get.sh: line 35: $'\r': command not found
16:00:44 ./openjdk-tests/get.sh: line 36: syntax error near unexpected token $'\r'' 16:00:44 ./openjdk-tests/get.sh: line 36: usage ()
'
[Pipeline] }
16:00:45 [ssh-agent] Stopped.

That looks like a git checkout thing with it translating the scripts to DOS CRLF line endings instead of leaving them in UNIX format ... Will take a look

Path issue ... Now resolved https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/721/console

So, next one is to install all the test prereqs:
From 721/console output:
make: ant: Command not found

ant hadn't been added to PATH - now fixed.

-2 now set up via playbooks (first production machine to be done this way, so may be teething trouble) but with c:\openjdk\jdk-* symlinks created manually. Korean and Japanese locales installed. Let me know by reopening this issue if this causes any problems. I'll try and keep an eye on it
https://ci.adoptopenjdk.net/computer/test-azure-win2012r2-x64-2/

-2 currently offline (reason unknown). -3 is not fully configured (JAVA_HOME wasn't set - pointed system environment variable to the right place for the adoptopenjdk 8 SDK). Currently failing on missing perl. Will run playbooks against -3 today.

Re-enabled test-azure-win2012r2-x64-3 to see if the issues that @sxa555 encountered that made him disable the machine, crop up again. Attempting to run a Grinder on it too : https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1524/console
However that didn't go to well..

Reinstalled Git in cygwin, removed git-for-windows and a Grinder running the 32 bit tests passed, despite that being the thing the machine was disabled for on Jenkins: https://ci.adoptopenjdk.net/job/Grinder/1539/

Running the tests related to #964 , test-azure-win2012r2-x64-3 passed:
https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/964#issuecomment-571111368
Is there anything to left to be done with this issue ?

-2 is offline, so yes :-)

@Willsparker I think you previously had access to test-azure-win2012r2-x64-2 so can you see if we can get it back into a usable state? If you've lost the credentials I can get them to you again

(NOTE: Two new windows server 2019 machines were also added under #1103)

@Willsparker I think you previously had access to test-azure-win2012r2-x64-2 so can you see if we can get it back into a usable state? If you've lost the credentials I can get them to you again - it would be good to get this finished

@adam-thorpe On second thoughts if you're looking for infra issues this might be a good one for you to take on :-)

Sure, I can pick this up. I imagine running the sanity openjdk tests against this machine is a good start? @sxa555 could I get the credentials please

Have sent them to you :-) Good luck!

Seems it's not responding to remote desktop connections - have asked @d3r3kk to look into it again

Splitting off the issue with azure -2 since the original request for extra machines has been met


Make EOL constant for CygWin on win

this will fix #7 and list-repos#1.
The reason to do this is that EOL will be either \n or \r\n and \n will always there and windows has CygWin like emulators which don't have \r\n as EOL.
The current logic works on the split by EOL and then either count the splitted array length or match the initial characters of the splitted array items. So EOL as \n will also work, but universally.

Ah, that makes sense 👍 Thanks for figuring out how to fix this.
To make sure that a line that ends in \r\n doesn't have a dangling \r left at the end when the \n is removed, I think the EOL constant should be a regex instead that makes the \r optional: /\r?\n/. That way the split() function will remove the \r as well 😃
Example:
> var s = 'foo\r\nbar\nbaz'
undefined
> s.split('\n')
[ 'foo\r', 'bar', 'baz' ]
> s.split(/\r?\n/)
[ 'foo', 'bar', 'baz' ]
>

Published on npm as v3.1.1


Update TOC.md

Add SensitivityLabelId.md

Docs Build status updates of commit 2eaf050:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/TOC.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Deal with relative links in Formatter::asUrl()

When using relative links (or links w/o http protocol) with Formatter::asUrl() they become broken:
/some/page.html -> /some/page.html
#anch123 -> #anch123
//example.com/page/ -> //example.com/page/
Is a good idea to add some checks in method asUrl()? Like this:
if (strpos($url, '://') === false) {
    if (strpos($url, '/') !== 0 && strpos($url, '//') !== 0 && strpos($url, '#') !== 0) {
        $url = 'http://' . $url;
    }
}

Additional info

Q
A

Yii version
2.0.*

PHP version
all

Operating system
all

can you explain why you want to display relative URLs to a user?
It is not easy to support what you want in the current implementation because the formatter adds http:// to the link in cases where it is missing, e.g. www.example.com will be completed as http://www.example.com, while www.example.com could as well be considered a relative url, a better example for that is localhost which has no dots in it.

Sometime need property with ability to set link in various format: absolute for external site or relative for current site. Useful for promotion elements on site.
Relative links need for sites with variable base URL. My proposition considers only URLs with single slash at begin or hash.

👍 I always override this method in formatter because default implementation breaks root-relative URLs.


[MBO-160] Make forgotten password link language dependant

@sowbiba  Nice to add this on the LinksProvider
But it will need a rework from this PR maybe #163 ?


Updated Alert.js with docs on options parameter

While reading the docs on the Alert API, I could not find any documentation for the options parameter, and after a few minutes of searching I found it towards the bottom and looking at the code.
I added the options cancelable documentation to the method documentation.

Good catch, thanks for improving the docs!
It looks like someone fixed this on master in the meantime, see the cancelable option mentioned here: http://facebook.github.io/react-native/releases/next/docs/alert.html
I'll close this since the description we have on master now looks good:

Note that by default alerts on Android can be dismissed by clicking outside of their alert box. To prevent this behavior, you can provide an optional options parameter { cancelable: false } to the Alert method.


libcap_ng: 0.7.8 -> 0.7.9

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/bin/captest -h got 0 exit code
ran /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/bin/captest --help got 0 exit code
ran /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/bin/captest help got 0 exit code
found 0.7.9 with grep in /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9
directory tree listing: https://gist.github.com/eec1818588ca8e5fe720bfe3febec73b

cc @wkennington for review

No attempt on x86_64-darwin
The following builds were skipped because they don't evaluate on x86_64-darwin: libcap_ng
No partial log is available.

Success on aarch64-linux (full log)
Attempted: libcap_ng
Partial log (click to expand)
shrinking /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9/bin/filecap
shrinking /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9/bin/netcap
shrinking /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9/bin/pscap
shrinking /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9/lib/libcap-ng.so.0.0.0
gzipping man pages under /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9/lib  /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9/bin
patching script interpreter paths in /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9
checking for references to /build in /nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9...
/nix/store/gbg847vxvifvj4a9ha4k2kkcrk0g07iz-libcap-ng-0.7.9

Success on x86_64-linux (full log)
Attempted: libcap_ng
Partial log (click to expand)
shrinking /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/bin/filecap
shrinking /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/bin/pscap
shrinking /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/bin/netcap
shrinking /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/lib/libcap-ng.so.0.0.0
gzipping man pages under /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/share/man/
/nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/lib  /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9/bin
patching script interpreter paths in /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9
checking for references to /tmp/nix-build-libcap-ng-0.7.9.drv-0 in /nix/store/s6hxbgihfzp3phh3904idpw3jpn1k371-libcap-ng-0.7.9...

Success on x86_64-linux (full log)
Attempted: libcap_ng
Partial log (click to expand)
shrinking /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9/bin/filecap
shrinking /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9/bin/pscap
shrinking /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9/bin/netcap
/nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9
shrinking /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9/lib/libcap-ng.so.0.0.0
gzipping man pages under /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9/share/man/
strip is /nix/store/5x9nfqa9sxj1dr9z8ln8sy9q6mhkkcqs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9/lib  /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9/bin
patching script interpreter paths in /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9
checking for references to /tmp/nix-build-libcap-ng-0.7.9.drv-0 in /nix/store/3ag1ll9511ib1carix14h2y5hpalf9xq-libcap-ng-0.7.9...

No attempt on x86_64-darwin
The following builds were skipped because they don't evaluate on x86_64-darwin: libcap_ng
No partial log is available.

Success on aarch64-linux (full log)
Attempted: libcap_ng
Partial log (click to expand)
shrinking /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9/bin/filecap
shrinking /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9/bin/netcap
shrinking /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9/bin/pscap
shrinking /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9/lib/libcap-ng.so.0.0.0
gzipping man pages under /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9/share/man/
strip is /nix/store/ijmisi52n5wbwybg5ldysa6af01zy5dl-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9/lib  /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9/bin
patching script interpreter paths in /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9
checking for references to /build in /nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9...
/nix/store/iz2j9crd11ilj97lmz6q3jggrbqwc4bb-libcap-ng-0.7.9


[Feature] Image fields for multi-modal models

I'm trying to evaluate Claude v3's performance for some document understanding tasks, with a workflow that includes passing the image of the page in as one of the inputs.
Is fmeval considering native handling for image/multi-modal fields in input datasets?

Hey @athewsey, thanks for reaching out. At this time, we only support LLMs (that text based models).
Adding support for multi-model fields is a future roadmap item.


reporter: do not add empty attributes

PR #212 changed the behaviour of addProfileAttributes(). Before adding an attribute the length of the string was checked - see https://github.com/open-telemetry/opentelemetry-ebpf-profiler/blob/0c58efd41280bce80cca9804896c76874d383b35/reporter/otlp_reporter.go#L747-L749
This returns to the original behaivour, where string attributes with no values are not added.

PR #212 changed the behaviour of addProfileAttributes(). Before adding an attribute the length of the string was checked.

This has been changed on purpose because how else are we going to differentiate in the backend
a) key exists with empty value
b) key does not exist
?
If the backend doesn't want to store empty values, these should be filtered out in the backend.
Other backends may want to store empty and NULL values.

To meet OTel SemConv requirements, a field was added to attrKeyValue indicating Required attributes, so that they are sent also with empty values. I have checked the OTel SemConv attributes we are sending out atm and non of them is marked as a Required attribute so far.

To meet OTel SemConv requirements, a field was added to attrKeyValue indicating Required attributes, so that they are sent also with empty values. I have checked the OTel SemConv attributes we are sending out atm and non of them is marked as a Required attribute so far.

IMO these are two different pairs of shoes.
To my understanding, a "semconv required" field is required because otherwise parts or all of the data doesn't make much sense to the backend/receiver.
And in this PR it is about allowing the backend/receiver to differentiate between "information not available" and "information available: empty string" or not. We should allow the backend/receiver to distinguish these cases and act accordingly. In other words, the client makes this decision without knowing anything about the backend, which is plain wrong in my eyes.

IMO these are two different pairs of shoes.
To my understanding, a "semconv required" field is required because otherwise parts or all of the data doesn't make much sense to the backend/receiver.

Please provide a list of attributes that should be always sent, also with empty values. What qualifies an attribute to be required to be sent always, also without value, if the OTel SemConv does not set the requirement level Required for this attribute?

IMO these are two different pairs of shoes.
To my understanding, a "semconv required" field is required because otherwise parts or all of the data doesn't make much sense to the backend/receiver.

Please provide a list of attributes that should be always sent, also with empty values. What qualifies an attribute to be required to be sent always, also without value, if the OTel SemConv does not set the requirement level Required for this attribute?

It's two different things. I am seeking for clarification for how to transport the information "no value" and "empty value" to the server, no matter if the attribute is required or not.
This PR skips sending an attribute in both cases, so the server side can simply not say if that is due to a missing value or due to an explicit empty string.
At least the Elastic backend currently doesn't distinguish between those two cases for the existing attributes, so I am fine with this PR. And the cases where it matters are mostly theoretical and can be worked around in other ways.

I am seeking for clarification for how to transport the information "no value" and "empty value" to the server, no matter if the attribute is required or not.

If there is an essential attribute that should be sent always, please name it. Then the required field in attrKeyValue can be set for it and it will be send always - even with empty values.

I am seeking for clarification for how to transport the information "no value" and "empty value" to the server, no matter if the attribute is required or not.

If there is an essential attribute that should be sent always, please name it. Then the required field in attrKeyValue can be set for it and it will be send always - even with empty values.

I originally thought about the COMM value (thread name), which can be set to an arbitrary value by the application, even to an empty string. But currently it won't matter to our backend if it is empty or not available.
Another thought: should we also skip sending integer attributes if the value is 0?

Is there any blocker or can this be merged?

sorry - I did forget about this one. too many tasks on the radar.


Rebased on Current dev With a Conflict Resolved and CodeGen Rerun

The PR was 86 commits behind dev so I brought it up to date.

The conflicts above shouldbn't be resolved. The original branch should just be replaced if you are happy with the new version.


Hardhat caching does not verify files are there/up to date

I upgraded to v5.
Ran compile which failed
Generating typings for: 20 artifacts in dir: types/truffle-contracts for target: truffle-v5
Successfully generated 19 typings!
Compilation finished successfully
migrations/1_initial_migration.ts:1:10 - error TS2305: Module '"../types/truffle-contracts"' has no exported member 'MigrationsContract'.

1 import { MigrationsContract } from '../types/truffle-contracts';

Removed the types folder, ran it again
Nothing to compile
No need to generate any newer typings.

But the files were not there.
Removed the hardhat build and cache folder
Then it worked
Generating typings for: 21 artifacts in dir: types/truffle-contracts for target: truffle-v5
Successfully generated 20 typings!
Compilation finished successfully

So I think a) the first time it did not regenerate the index.d.ts and b) maybe some light checking if the files are actually there? Then again, it is just when upgrading, so maybe a notice in the changelog is enough?

I had to downgrade to keep my development flow. The caching keeps messing up on contract changes.

Oh, right currently incremental generation is supported only in ethers target but still, this shouldn't misbehave.
I will work on a fix in a bit.

@krzkaczor have you had a chance to work on this issue? I'm still experiencing the same problem with "typechain": "6.0.4" and "@typechain/ethers-v5": "8.0.4".


.NET 4.8 support

Hi, Please update this article for .net 4.8 support.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f082a39c-4081-f5c3-1e1d-effcfecb2fd7
Version Independent ID: e57c7222-bb36-5fa1-bdc5-f8f3cd87e3d8
Content: Install .NET on Azure Cloud Services roles
Content Source: articles/cloud-services/cloud-services-dotnet-install-dotnet.md
Service: cloud-services
GitHub Login: @jpconnock
Microsoft Alias: jeconnoc

Thanks for the feedback! We are currently investigating and will update you shortly.

@StannieV I added a link to download .NET 4.8 and added it as an option in the script along with the other versions of 4.8
For the rest of the doc I am keeping it at 4.7.2 as that is a current version that is known to work and 4.8 just released. But this should give people the option to use 4.8 if they want.
Once the PR merges the changes will go live in a few hours.
CC @cynthn @jpconnock

Thanks!

I have not tried the script but there doesn't seem to be a section for :NDP48 like the others. Is this supposed to be working? I don't see where the script references the .NET Framework 4.8 installer ndp48-web.exe and the right netfxregkey?

Hi maboivin,
You're right. MicahMcKittrick-MSFT only added a reference to the new .net version 4.8, but didn't add support for it. See his response to me:
_

I added a link to download .NET 4.8 and added it as an option in the script along with the other versions of 4.8
For the rest of the doc I am keeping it at 4.7.2 as that is a current version that is known to work and 4.8 just released. But this should give people the option to use 4.8 if they want.

_

I read that answer but I may not get the point of adding a link to just download the framework but not adding any other logic to handle it. How is this useful, the script remains incomplete? I know this PR is from April but was there any concerns of running .NET framework 4.8 with cloud services at that time?

Here the script for 4.8:
`REM Set the value of netfx to install appropriate .NET Framework.
REM ***** To install .NET 4.5.2 set the variable netfx to "NDP452" *****
REM ***** To install .NET 4.6 set the variable netfx to "NDP46" *****
REM ***** To install .NET 4.6.1 set the variable netfx to "NDP461" ***** https://go.microsoft.com/fwlink/?LinkId=671729
REM ***** To install .NET 4.6.2 set the variable netfx to "NDP462" ***** https://www.microsoft.com/download/details.aspx?id=53345
REM ***** To install .NET 4.7 set the variable netfx to "NDP47" *****
REM ***** To install .NET 4.7.1 set the variable netfx to "NDP471" ***** https://go.microsoft.com/fwlink/?LinkId=852095
REM ***** To install .NET 4.7.2 set the variable netfx to "NDP472" ***** https://go.microsoft.com/fwlink/?LinkId=863262
REM ***** To install .NET 4.8 set the variable netfx to "NDP48" ***** https://dotnet.microsoft.com/download/thank-you/net48
set netfx="NDP48"
REM ***** Set script start timestamp *****
set timehour=%time:~0,2%
set timestamp=%date:~-4,4%%date:~-10,2%%date:~-7,2%-%timehour: =0%%time:~3,2%
set "log=install.cmd started %timestamp%."
REM ***** Exit script if running in Emulator *****
if "%ComputeEmulatorRunning%"=="true" goto exit
REM ***** Needed to correctly install .NET 4.6.1, otherwise you may see an out of disk space error *****
set TMP=%PathToNETFXInstall%
set TEMP=%PathToNETFXInstall%
REM ***** Setup .NET filenames and registry keys *****
if %netfx%=="NDP48" goto NDP48
if %netfx%=="NDP472" goto NDP472
if %netfx%=="NDP471" goto NDP471
if %netfx%=="NDP47" goto NDP47
if %netfx%=="NDP462" goto NDP462
if %netfx%=="NDP461" goto NDP461
if %netfx%=="NDP46" goto NDP46
set "netfxinstallfile=NDP452-KB2901954-Web.exe"
set netfxregkey="0x5cbf5"
goto logtimestamp
:NDP46
set "netfxinstallfile=NDP46-KB3045560-Web.exe"
set netfxregkey="0x6004f"
goto logtimestamp
:NDP461
set "netfxinstallfile=NDP461-KB3102438-Web.exe"
set netfxregkey="0x6040e"
goto logtimestamp
:NDP462
set "netfxinstallfile=NDP462-KB3151802-Web.exe"
set netfxregkey="0x60632"
goto logtimestamp
:NDP47
set "netfxinstallfile=NDP47-KB3186500-Web.exe"
set netfxregkey="0x707FE"
goto logtimestamp
:NDP471
set "netfxinstallfile=NDP471-KB4033344-Web.exe"
set netfxregkey="0x709fc"
goto logtimestamp
:NDP472
set "netfxinstallfile=NDP472-KB4054531-Web.exe"
set netfxregkey="0x70BF6"
goto logtimestamp
:NDP48
set "netfxinstallfile=NDP48-Web.exe"
set netfxregkey="0x80EB1"
goto logtimestamp
:logtimestamp
REM ***** Setup LogFile with timestamp *****
md "%PathToNETFXInstall%\log"
set startuptasklog="%PathToNETFXInstall%log\startuptasklog-%timestamp%.txt"
set netfxinstallerlog="%PathToNETFXInstall%log\NetFXInstallerLog-%timestamp%"
echo %log% >> %startuptasklog%
echo Logfile generated at: %startuptasklog% >> %startuptasklog%
echo TMP set to: %TMP% >> %startuptasklog%
echo TEMP set to: %TEMP% >> %startuptasklog%
REM ***** Check if .NET is installed *****
echo Checking if .NET (%netfx%) is installed >> %startuptasklog%
set /A netfxregkeydecimal=%netfxregkey%
set foundkey=0
FOR /F "usebackq skip=2 tokens=1,2*" %%A in (reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full" /v Release 2^>nul) do @set /A foundkey=%%C
echo Minimum required key: %netfxregkeydecimal% -- found key: %foundkey% >> %startuptasklog%
if %foundkey% GEQ %netfxregkeydecimal% goto installed
REM ***** Installing .NET *****
echo Installing .NET with commandline: start /wait %~dp0%netfxinstallfile% /q /serialdownload /log %netfxinstallerlog%  /chainingpackage "CloudService Startup Task" >> %startuptasklog%
start /wait %~dp0%netfxinstallfile% /q /serialdownload /log %netfxinstallerlog% /chainingpackage "CloudService Startup Task" >> %startuptasklog% 2>>&1
if %ERRORLEVEL%== 0 goto installed
echo .NET installer exited with code %ERRORLEVEL% >> %startuptasklog%
if %ERRORLEVEL%== 3010 goto restart
if %ERRORLEVEL%== 1641 goto restart
echo .NET (%netfx%) install failed with Error Code %ERRORLEVEL%. Further logs can be found in %netfxinstallerlog% >> %startuptasklog%
goto exit
:restart
echo Restarting to complete .NET (%netfx%) installation >> %startuptasklog%
shutdown.exe /r /t 5 /c "Installed .NET framework" /f /d p:2:4
:installed
echo .NET (%netfx%) is installed >> %startuptasklog%
:end
echo install.cmd completed: %date:~-4,4%%date:~-10,2%%date:~-7,2%-%timehour: =0%%time:~3,2% >> %startuptasklog%
:exit
EXIT /B 0`

The above script didn't work for me because the log file names ended up in a wrong format. They have the %timestamp% at the end which makes the file names to have a few / chars.
This resulted in the The system cannot find the path specified. error, which ended the script (with success), when it tried to write to the log. The script stopped before creating any logs or installing the .NET Framework.
My fix was to replace the %timestamp% variable in the REM ***** Set script start timestamp ***** section with the %dtStamp% which I computed with below script:
REM ***** Set script start timestamp *****
@ECHO OFF
SET HOUR=%time:~0,2%
SET dtStamp9=%date:~-4%%date:~4,2%%date:~7,2%_0%time:~1,1%%time:~3,2%%time:~6,2%
SET dtStamp24=%date:~-4%%date:~4,2%%date:~7,2%_%time:~0,2%%time:~3,2%%time:~6,2%
if "%HOUR:~0,1%" == " " (SET dtStamp=%dtStamp9%) else (SET dtStamp=%dtStamp24%)
echo timestamp: %dtStamp%
@ECHO ON

I know this is a closed issue, etc .. but this page NEEDS to have the proper .NET48 data updated to accurately reflect NET48 installs. NET48 has been out in the wild for a while .. so can this please get an update?

Why is this not yet updated to properly support .NET48?
Is it a matter of "no one picked up the ball so it hasn't yet been done" or "4.8 is not yet stable so use 4.7.2"?

We are no longer updating the Cloud Services (classic) documentation. We suggest those who still need to use Cloud Services migrate their applications to the Azure Resource Manager based deployment model of Cloud Services (extended support)
https://docs.microsoft.com/en-us/azure/cloud-services-extended-support/

Thanks for the update @mimckitt


/etc/hosts management

Currently the hosts management is skipped when starting a project via the plugin, as this is a non interactive process and entering the sudo password is required for this step.
Another problem is, that using ddev inside wsl the host entry needs to be set in Windows and not the WSL environment.
The ddev integration plugin should have all required information and permissions to do the /etc/hosts management bypassing the ddev internal one to allow a better OS compatible permission management and a better WSL integration.

This issue might be solved or at least by changing the way DDEV is used inside WSL.
As I currently discuss this with @rfay, I will delay  the work on this issue.

Installing DDEV like like described in this documentation, solves the WSL part of this issue.
It is based on this concept: https://gist.github.com/nico-loeber/6d6e8261827c5e4efa4ccf5b5cd04140
Sadly this way will probably no become the officially supported one.

Note that /etc/hosts is not a part of the picture when using *.ddev.site, only when using additional_fqdns or an alternate tld.  The hosts file does not have to be touched either on Windows or inside WSL2 in the "normal" workflow.
I would like to see dual-hosts-file management for the non-ddev.site situation though in

https://github.com/drud/ddev/issues/3277

Created the issue https://github.com/drud/ddev/issues/3818 for this.
@rfay, sorry noticed your comment just after creating the issue. In case I normally don't need to touch the hosts file, there might be a misconfiguration or misunderstand on my side. Lets discuss this in the ddev issue.

As @rfay already stated there is no need for editing host files in common sitations.
The problem we encountered here was that the resolution of *.ddev.site was rejected by the router for sercurity reasons.
This behavior is explained in the DDEV documentation: https://ddev.readthedocs.io/en/latest/users/troubleshooting/#dns-rebinding-prohibited
There seems to be no need to resolve this issue on the plugin side, so this issue is closed.


how to change data-min and data-max dynamically?

Hello, is there any possible way to change dynamically data-min and data-max? I need it now and I see I can only change the step.

@ilievZlatko So , has your problem been solved?

@aitlp how to do this?

Unfortunately, you can't change the options of a spinner plugin instance.
But, you can re-render your DOM and setup a new spinner plugin for it.
Also, you can fork this repo.


Update description for the setting editor.useTabStops

I'd like to update the description for the setting editor.useTabStops
Right now it reads

Inserting and deleting whitespace follows tab stops

I've been programming for a long time and this doesn't make any sense to me.  I'd like to change it to something that's more intuitive to developers.  I can suggest more dev-friendly wording once someone explains what this setting does,

Feel free to just create a PR for this. Thanks!

@hediet sure, but can you tell me what the setting does so i can create a PR with updated wording ?

Hi @olsonpm, I came across a helpful YouTube video that explains the concept behind this setting. Would you like me to take a shot at improving the documentation for this issue, or are you already working on it?

I haven't - go ahead

Hey @olsonpm, I've located the code related to the previous description:

Inserting and deleting whitespace follows tab stops.

I'm considering updating it to:

Inserting and deleting whitespace follows tab stops. Full tab deletion occurs upon removing indentation.

Do you think this provides a better description? I wanted to confirm with you before submitting a pull request.

Thanks @BrookMaoDev, personally "Inserting and deleting whitespace follows tab stops" feels gramatically incorrect to me.  I would go with something like

Add a tab stop after the group of spaces when [Insert Spaces](<link to setting>) is set to true.  For example, if tab is configured to insert four spaces then the editor will insert four spaces plus a tab stop.

I'm no english expert so my verbage may be gramatically incorrect as well.  I also tend to be too wordy - however I couldn't understand the previous wording at all.  It didn't help I hadn't heard of a tab stop mixed with spaces ha.  The video you linked was very helpful.

Yeah @olsonpm, I think it's a bit wordy, but I'll take your suggestion into account since I don't think my improvement was descriptive enough either.

yeah I think it will be difficult to convey this concept succinctly - my main issue is 'follows' feels incorrect.  i.e. what does it mean for "Inserting and deleting whitespace follows tabstops" ?  Examples of 'follows' being correct would be things like Bob follows Tom.  Bob follows the instructions.  Inserting and deleting whitespace can't follow tabstops - that simply doesn't make sense.

Perhaps a better word is "aligns". Do you think that this makes sense?

Inserting and deleting whitespace aligns with tab stops.

go for it.  If people comment here again I can add more context and further explanation in a PR then


update readme and changelog for old release

Signed-off-by: Mohit Suman<EMAIL_ADDRESS>

Codecov Report

Merging #252 (3bbb4cc) into main (cc5217b) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   85.22%   85.03%   -0.20%
==========================================
  Files          77       77
  Lines        3140     3140
  Branches      531      531
==========================================
- Hits         2676     2670       -6
- Misses        464      470       +6

Impacted Files
Coverage Δ

src/util/watch.ts
83.33% <0.00%> (-13.34%)
:arrow_down:

src/util/platform.ts
88.23% <0.00%> (-11.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5217b...3bbb4cc. Read the comment docs.


Compare with deployed translations

Nice feature/change would be if the compare with deployed option could strip 'id' attributes, add CDATA tags, and undo some translation done by iiq to allow for cleaner compares.   I've come to expect &,<,'id' items to appear as differences and ignore them  but if the process could cleanup some of these it would make comparisons a little bit easier.

That's a cool idea, Derek. My only concern would be when the user selects
the "Compare Local with Deployed" command, they might be a bit confused
seeing stuff that should be missing or different on the server side.
Also if you insert CDATA tags, you need to know where to insert them (same
line as  or below) so that you wouldn't see a difference.
But I get your point, I like it, let me think about it and put it in the
wish list.
On Thu, Jan 6, 2022 at 5:24 PM derekhackbardt @.***>
wrote:

Nice feature/change would be if the compare with deployed option could
strip 'id' attributes, add CDATA tags, and undo some translation done by
iiq to allow for cleaner compares. I've come to expect &,<,'id' items to
appear as differences and ignore them but if the process could cleanup some
of these it would make comparisons a little bit easier.
—
Reply to this email directly, view it on GitHub
https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/22,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCZB7WQOZ5TI4YAFHP42DUUYJBLANCNFSM5LNLRLMQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Also I noticed that indentation for XML blocks that come back from the
server is different from your original code.
Removing ids may be beneficial in some cases, but some people may choose to
use some ids in their original source code (we do that in some cases) so
removing ids could be misleading for some.
On Fri, Jan 7, 2022 at 12:09 PM Andrei Stebakov @.***> wrote:

That's a cool idea, Derek. My only concern would be when the user selects
the "Compare Local with Deployed" command, they might be a bit confused
seeing stuff that should be missing or different on the server side.
Also if you insert CDATA tags, you need to know where to insert them (same
line as  or below) so that you wouldn't see a difference.
But I get your point, I like it, let me think about it and put it in the
wish list.
On Thu, Jan 6, 2022 at 5:24 PM derekhackbardt @.***>
wrote:

Nice feature/change would be if the compare with deployed option could
strip 'id' attributes, add CDATA tags, and undo some translation done by
iiq to allow for cleaner compares. I've come to expect &,<,'id' items to
appear as differences and ignore them but if the process could cleanup some
of these it would make comparisons a little bit easier.
—
Reply to this email directly, view it on GitHub
https://github.com/lispercat/sailpoint-iiq-dev-accelerator/issues/22,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCZB7WQOZ5TI4YAFHP42DUUYJBLANCNFSM5LNLRLMQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Closing as the feature has been implemented as of version 1.0.35


Updated the titanic example readme with mlflow commands

Signed-off-by: Kasirajan Alayappan<EMAIL_ADDRESS>This PR is dependent on https://github.com/mlflow/mlflow-torchserve/pull/70
What changes are proposed in this pull request?
Updated the titanic example readme with mlflow deployment commands instead of curl commands.
How is this patch tested?
Existing unittests
Release Notes
Is this a user-facing change?

[x] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release notes for MLflow TorchServe Deployment Plugin users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s) does this PR affect?
Components

[ ] area/deploy: Main deployment plugin logic
[ ] area/build: Build and test infrastructure for MLflow TorchServe Deployment Plugin
[ ] area/docs: MLflow TorchServe Deployment Plugin documentation pages
[x] area/examples: Example code

How should the PR be classified in the release notes? Choose one:

[ ] rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
[x] rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
[ ] rn/feature - A new user-facing feature worth mentioning in the release notes
[ ] rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
[ ] rn/documentation - A user-facing documentation change worth mentioning in the release notes

Existing Unit test breakage is fixed in https://github.com/mlflow/mlflow-torchserve/pull/69

tested with torchserve 0.4.0
titanic_predict_explain.txt


Add option for disabling IPv6 (#1163)

Add option for disabling IPv6

Fixes https://github.com/istio/ztunnel/issues/1131
Testing was manual. I don't see any way we can test this in CI, since it
only works if the kernel is booted with IPv6 turned off - the sysctl to
dynamically set it will NOT break.

rename

(cherry picked from commit 3a41b096746580a6a7f1c956717b2b38024dd48c)

Fixes https://github.com/istio/ztunnel/issues/1164

does this have any impact on https://github.com/istio/test-infra/pull/5401

@kfaseela not really, this is about making it so you can run on a pure IPv4 kernel. The other flag is about making IPv6 work. Actually they are really for opposite purposes

@kfaseela not really, this is about making it so you can run on a pure IPv4 kernel. The other flag is about making IPv6 work. Actually they are really for opposite purposes

Are they? I'm not sure how?

If you want pure IPv4 you set ambient.enableIPv6=false
If you want (v4 && v6 or just V6) ambient.enableIPv6=true

That's all the cases?

@bleggett the majority of users run on ipv4 only platforms which have kernel support for IPv6. So there is really 3 cases:

No IPv6 at all
IPv6 kernel but only using ipv4 in kubernetes
Full IPv6+IPv4

We just collapse (2) and (3) under one flag. Meaningfully, we do not do this in sidecars, but that is mostly legacy decisions.

@bleggett the majority of users run on ipv4 only platforms which have kernel support for IPv6. So there is really 3 cases:
1. No IPv6 at all

2. IPv6 kernel but only using ipv4 in kubernetes

3. Full IPv6+IPv4

We just collapse (2) and (3) under one flag. Meaningfully, we do not do this in sidecars, but that is mostly legacy decisions.

I get that, I am asking why we need to support a configurable distinction between 1 and 2 there. Simpler to treat them as the same case?
You either want to use V6 or you do not (using it in concert with V4 is sort of unrelated to that). If you do not, do we need to make a distinction between (kernel support || kube support) in our config API surface? I don't see that we need to.

We don't, I am agreeing with 2 config knobs. The disagreement (if there is one? I am not sure?) is whether it is "1 or {2+3}" or "{1+2} or {3}".
Given (1) is legacy niche poorly-configured OS, I am very inclined to make that a niche opt-out and let the rest of the world live in a modern state.

@howardjohn Agree with that, but am mostly concerned that until we can safely enable-v6-by-default in the rest of Istio as well, we will have to carry two flags which

do the same thing
both need to be synchronized
will (confusingly) need to have inverted values

The plan was to enable IPv6 by default in 1.23, and send another PR to have
to fix this up to invert the bool to be consistent.
On Mon, Jun 24, 2024 at 10:59 AM Ben Leggett @.***>
wrote:

@howardjohn https://github.com/howardjohn Agree with that, but am
mostly concerned that until we can safely enable-v6-by-default in the rest
of Istio as well, we will have to carry two flags which

do the same thing
both need to be synchronized
will (confusingly) need to have inverted values

—
Reply to this email directly, view it on GitHub
https://github.com/istio/ztunnel/pull/1166#issuecomment-2187115711, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNWNJWP5LNMEETSWNTZJBM7LAVCNFSM6AAAAABJUJWGS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGEYTKNZRGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

There is basically no flags unless you are in the 0.01% of users that
disable IPv6 in the kernel. Then there is a consistent flag to set on
ztunnel and CNI
On Mon, Jun 24, 2024 at 11:00 AM John Howard @.***> wrote:

The plan was to enable IPv6 by default in 1.23, and send another PR to
have to fix this up to invert the bool to be consistent.
On Mon, Jun 24, 2024 at 10:59 AM Ben Leggett @.***>
wrote:

@howardjohn https://github.com/howardjohn Agree with that, but am
mostly concerned that until we can safely enable-v6-by-default in the rest
of Istio as well, we will have to carry two flags which

do the same thing
both need to be synchronized
will (confusingly) need to have inverted values

—
Reply to this email directly, view it on GitHub
https://github.com/istio/ztunnel/pull/1166#issuecomment-2187115711, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNWNJWP5LNMEETSWNTZJBM7LAVCNFSM6AAAAABJUJWGS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGEYTKNZRGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

We don't, I am agreeing with 2 config knobs. The disagreement (if there is one? I am not sure?) is whether it is "1 or {2+3}" or "{1+2} or {3}".
Given (1) is legacy niche poorly-configured OS, I am very inclined to make that a niche opt-out and let the rest of the world live in a modern state.

@howardjohn @bleggett : Ehmm...It would be possible to argue that it is not a legacy poorly-configured OS, but actually a well hardened system that opts out for all unused modules to minimize the attack surface.
A recommended security measure compared to the most of the 'out of the box' installations.

We don't, I am agreeing with 2 config knobs. The disagreement (if there is one? I am not sure?) is whether it is "1 or {2+3}" or "{1+2} or {3}".
Given (1) is legacy niche poorly-configured OS, I am very inclined to make that a niche opt-out and let the rest of the world live in a modern state.

@howardjohn @bleggett : Ehmm...It would be possible to argue that it is not a legacy poorly-configured OS, but actually a well hardened system that opts out for all unused modules to minimize the attack surface.
A recommended security measure compared to the most of the 'out of the box' installations.

Regardless of my personal commentary on anti-IPv6 folks, it is fully supported in the product now :slightly_smiling_face:


Mac patch issue 2024

Hello,
I am having issues on mac since the old patch stopped working I have installed the new one but any browser I use is not seeing the snap camera input. I see all the filters in the app properly but it's just not porting thru to the browsers. I have tried installing an older version (1.9) as well as the latest (1.21). I have also checked the camera permissions but I can't seem to find where the problem is.
Any idea how to fix it?

Restoring legacy video device support solves the issue.
https://support.apple.com/en-us/HT213969


Add fstack protector.

Fix for https://github.com/scottyab/rootbeer/issues/77
A rebuild and a new version will be needed after adding this PR

Hi possible to make a release for this ?

Hi possible to make a release for this ?


After wandb is deployed locally, how can a user who has not registered with wandb access public projects?

Hi @suiyan538, thank you for writing in about this! Can you send me the link to this page so I can look more into why you're running into it? Did this page used to exist before for you and you're running into this 404 afterwards?

Hi @suiyan538, thank you for writing in about this! Can you send me the link to this page so I can look more into why you're running into it? Did this page used to exist before for you and you're running into this 404 afterwards?

Thank you very much for your reply, but sorry, I can't post the link of this page.

I see. If you're uncomfortable posting it in a public forum, can you please send it to<EMAIL_ADDRESS>and put 'For Leslie' in the subject line please? If you still can't then I don't know how to help you out further here


Bubbles are inefficient and incorrect

By the time we moved there, the target had changed.

So here's another idea that I had, how about we don't create the bubble markers at all. We re-use the underline markers and check if the user cursor is it in and then show a bubble at that point. It would not only help us not create excessive markers but it'll also be more efficient IMO. Also we need a debounce mechanism when creating bubbles, we shouldn't do it instantly, we should wait lets say 300ms for the user to complete it's navigation and then show the marker.

They are no longer inefficient, I fixed it in https://github.com/atom-community/linter/pull/939
They are still incorrect sometimes though


Errno::EPIPE: Broken pipe when running nanoc check css

As the subject says, I get an error when running nanoc check css:
  Running check css…
Captain! We’ve been hit!

Message:

Errno::EPIPE: Broken pipe

Compilation stack:

  (empty)

Stack trace:

  0. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/protocol.rb:211:in `write'
  1. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/protocol.rb:211:in `write0'
  2. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/protocol.rb:185:in `block in write'
  3. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/protocol.rb:202:in `writing'
  4. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/protocol.rb:184:in `write'
  5. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/http/generic_request.rb:328:in `write_header'
  6. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/http/generic_request.rb:126:in `exec'
  7. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/http.rb:1412:in `block in transport_request'
  8. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/http.rb:1411:in `catch'
  9. /Users/me/.rubies/ruby-2.2.2/lib/ruby/2.2.0/net/http.rb:1411:in `transport_request'
  ... 34 more lines omitted. See full crash log for details.

All other checks work. Is this reproducible or is it something in my setup?

In fact, on another site nanoc check css produces different errors: either
Errno::ECONNRESET: Connection reset by peer

or
W3CValidators::ValidatorUnavailable: unable to connect to the validator at http://jigsaw.w3.org/css-validator/validator (response was 400 "Bad request").

Which of the two seems to be random.

Are you using the most recent W3C validators gem? It sounds more like a problem within that gem rather than with nanoc itself.

Yes, it's up to date. I'll try the gem directly and report the result.

Hello,
I just had the same problem, and it was related to css file bootstrap.min.css.
When I temporarily remove this file from the output directory, the check is working fine.
Perhaps we could add a new setting to be able to list the css files to exclude from the check.
Your thoughts on this ?

This seems like an issue that’s not inside nanoc but in the W3C validators gem.
Does the gem directly (without using nanoc) work?

You are correct, the w3c_validators gem has an issue with big files.
I fixed it through https://github.com/alexdunae/w3c_validators/pull/17, but not sure if this repo is still active.
If I have no answers in the coming week, I might start a community fork to publish a new version (waiting for repo owner answer so far).

Doesn’t look like the repo is active anymore. :/
I’ll close this issue since the problem is not within nanoc, but rather a dependency.


Error when call cp.generate_quadrature

I have this error when try the example in chaospy. Could anyone let me know what was the problem and how to fix it? I am new in Python. Thank you so much.
Mai

import chaospy as cp
import numpy as np
import odespy
a = cp.Uniform(0, 0.1)
I = cp.Uniform(8, 10)
dist = cp.J(a, I)
order = 5
P, norms = cp.orth_ttr(order, dist, retall=True)
nodes, weights = cp.generate_quadrature(order+1, dist, rule="G")
Traceback (most recent call last):
File "", line 1, in
File "/home/trunghieumai/src/chaospy/chaospy/quadrature.py", line 105, in generate_quadrature
x, w = golub_welsch(order, domain, acc)
File "/home/trunghieumai/src/chaospy/chaospy/quadrature.py", line 242, in golub_welsch
for k in range(2*o[d]-3)])
File "/home/trunghieumai/src/chaospy/chaospy/dist/backend.py", line 399, in mom
return out.reshape(shape)
ValueError: total size of new array must be unchanged

Ah, yes. It seems I added in the last push.
I removed it now and the software should be functioning again I think. Let me know if that isn't the case, and I'll reopen.


Buzzer Sound Files Swap

I am trying to figure out how to host an amended version of this app. I have a specific sound effect which I have used to swap out the existing buzzer noise. Ideally if we had a scoring system allowing 5 or 10 point increase increments that would make it perfect but can always use a seperate system for scoring. The priority is to have this buzzer app hosted with the different sound effect. How do I go about hosting this under a different URL with the new buzzer sound effect? Or could the original project be changed to allow a host to set the buzzer noise to one they want to use?

Hi! I can look into what might make sense for customizable buzzer sounds - just to clarify, would this only be for yourself? (or would you want the host to be able to override the sound for everyone in the room with the custom buzzer?)
In the meantime, you're welcome to fork this project, and you can host it on any platform that can host Node.js web apps. Heroku or Render are pretty straightforward options with decent tutorials about how to get started, and of course it could work on AWS or Google too.


Switch generated methods to pointer receivers

Changed for Encoding, Marshalling, Getters and Size methods.
Rationale is that on non-pointer receivers will cause the objects to be copied as part of method invocation. That causes additional allocs and pressure on the GC. For applications which do a lot of serialisation, this may well be noticable - a lot of performance tuning in Go focuses on optimising memory usage.
All tests still pass.

Oh, I've just discovered that just doing go test ./... does not actually compile and test the generated go. Converting this PR to draft until I'm happier I understand how to test it.


Possibly new API to get character showcase in game profile picture

I found a new web who can access that information: https://enka.shinshin.moe

This most likely gets data directly from genshin rather than through the API.

This has been confirmed by the author of shinshin.


Diff breaks if csv deleted from base and head

Description
Deleting a .csv file from both the base and head branch in a compare will result in a 500 error.
https://try.gitea.io/kdumontnu/test/compare/main...delete-csv
Gitea Version
d9c6cb71e
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Seen on 1.17 initially. Reproduced on try.gitea.
Database
None

2023/02/17 02:58:03 ...s/context/context.go:231:HTML() [E] [63eeed3b-8] Render failed: template: repo/diff/csv_diff:3:15: executing "repo/diff/csv_diff" at <call .root.CreateCsvDiff .file .blobBase .blobHead>: error calling call: runtime error: invalid memory address or nil pointer dereference

Some contexts of this problem (just FYI):

Issue #19530
PR #19552
PR #21189

OK, I fully understand the problem now. If a CSV file is deleted from both branch, then baseReader and headReader can both be nil.


[SPARK-7524][SPARK-7846]add configs for keytab and principal, pass these two configs with different way in different modes

As spark now supports long running service by updating tokens for namenode, but only accept parameters passed with "--k=v" format which is not very convinient. This patch add spark.* configs in properties file and system property.

--principal and --keytabl options are passed to client but when we started thrift server or spark-shell these two are also passed into the Main class (org.apache.spark.sql.hive.thriftserver.HiveThriftServer2 and org.apache.spark.repl.Main).
In these two main class, arguments passed in will be processed with some 3rd libraries, which will lead to some error: "Invalid option: --principal" or "Unrecgnised option: --principal".
We should pass these command args in different forms, say system properties.

Merged build triggered.

Merged build started.

Test build #32382 has started for   PR 6051 at commit 73afa64.

Merged build triggered.

Merged build started.

Test build #32383 has started for   PR 6051 at commit 08bb4e8.

Test build #32383 has finished for   PR 6051 at commit 08bb4e8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32383/
Test FAILed.

Test build #32382 has finished for   PR 6051 at commit 73afa64.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32382/
Test PASSed.

Have you actually run this one a cluster with the various options:

Use --principal + spark.yarn.keytab (and vice versa)
Both set and making sure command line gets picked up
Only command line and only spark.yarn.*

Also, I have not seen spark.internal. options elsewhere in Spark? Are there are other config options like this? I am wondering if it makes sense to just re-use the current configs? If the command line params are set, just overwrite the ones we read from the configuration?

No spark doesn't use the .internal. elsewhere. Please don't rename any of the ones we haven't documented as internal.
I agree that we should just expand the use of the current ones since they are going to be propagated anyway.

@WangTaoTheTonic  can you update based on comments?

@tgravescs Okay, I will do it right now.

Build triggered.

Build started.

Test build #33438 has started for   PR 6051 at commit ecfe43a.

Merged build triggered.

Merged build started.

Test build #33439 has started for   PR 6051 at commit ebd9ea0.

Merged build triggered.

Merged build started.

Test build #33441 has started for   PR 6051 at commit e65699a.

Test build #33439 has finished for   PR 6051 at commit ebd9ea0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33439/
Test FAILed.

Test build #33438 has finished for   PR 6051 at commit ecfe43a.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33438/
Test FAILed.

Test build #33441 has finished for   PR 6051 at commit e65699a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33441/
Test PASSed.

I updated per comments and add fix for SPARK-7846. Haven't tested as there is some problem with my cluster and will do it ASAP.

@harishreedharan
I have tested per your comments, using spark-shell:

Use --principal + spark.yarn.keytab (and vice versa) (double check)
Both set and making sure command line gets picked up (check)
Only command line (check) and only spark.yarn.* (check)

ping? @harishreedharan  @tgravescs

lgtm.  going to kick jenkins once more.

Jenkins, test this please

Merged build triggered.

Merged build started.

Test build #33736 has started for   PR 6051 at commit e65699a.

Test build #33736 has finished for   PR 6051 at commit e65699a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@WangTaoTheTonic  can you please fix the description on this pr.  Remove the [YARN]1 from heading.

@tgravescs Done.

Sorry, I am late to this to this one. Could you create a followup PR to update the security.md file with info about running in client vs cluster modes and that this is supported only in cluster mode via command line params.
@tgravescs - If 1.4 gets released without this patch, there will be a regression in client mode (--principal and --keytab won't work in client mode). Should this + docs for this one also go into 1.4?

@harishreedharan  I'm pretty sure the --keytab and --principal options still work in client mode to SparkSubmit. Its simply the way it passes it on to the client.  in yarn client mode it uses the config and in yarn cluster mode it uses the command line options.
OptionAssigner(args.principal, YARN, CLIENT, sysProp = "spark.yarn.principal"),
OptionAssigner(args.keytab, YARN, CLIENT, sysProp = "spark.yarn.keytab"),
I'm building now and will test it to double check.  Did you try it yourself?
That would not be a blocker for 1.4 though.  We would revert and fix.

Ah, right - my bad! I wasn't reading the code properly. I will try it out later today to confirm.

@harishreedharan How about the confirm? Should we do some changes in branh 1.4?


Update related processes roles

This change is

Pull Request Test Coverage Report for Build 2827

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.014%

Totals

Change from base Build 2825:
0.0%

Covered Lines:
1884

Relevant Lines:
2653

💛  - Coveralls


[BUG] Improve text formatting on verse page

🙁 Actual behavior

Text is quite hotchpotch and hard to read.
🙂 Expected behavior

Add proper headings, spacing in between text and proper text styles to make it easy on the eye.
🔢 Steps to Reproduce the Problem
No response

I have formatted the code by adding appropriate indentation and line breaks to improve readability.
Here's the code from version #139 with improved formatting and readability:
import { connect } from "react-redux";
import NotificationBanner from "./Shared/NotificationBanner";
const Main = ({ Component, pageProps, notification }) => {
const getLayout = Component.getLayout || ((page) => page);
return (
<>
{notification && (

)}
{getLayout(<Component {...pageProps} />)}
</>
);
};
const mapStateToProps = (state) => {
return {
notification: state.main?.notification,
};
};
export default connect(mapStateToProps)(Main);

@anoopg512 can you please make a PR?


Performance at high loads

Is there a theoretical limit to how many requests per second the server can handle? I'm running this on a  Ubuntu 22baremetal server with plenty of hardware capacity, in a CDN + P2P video streaming setup (https://github.com/Novage/p2p-media-loader).
Once we have about 40,000 viewers, the server seems to struggle, But CPU and RAM usage are nearly idle.
Is there anything I can do to increase this?

Hi there @eTiMaGo
Before I renamed the DNS entry form stun.stunprotocol.org to stunserver.stunprotocol.org, the t3.small instance of the public STUN server on AWS served between 200 million and up to 1.4 billion STUN requests per day: https://imgur.com/a/2JiTsJX
These are insane numbers because STUN binding requests are just a handful per P2P/WebRtc session.
STUN doesn't have any impact on media quality.  So when you say "struggle", that implies that there are other issues at play here.  Can you elaborate on that?  Why do you think the STUN server is having an issue?  Please define "struggle".
Obviously, if you need more STUN capacity, you can deploy another server and use round-robin DNS to load balance.  Another option is to use the "development" branch from this project. There's a command line option called --threading where you can specify the number of threads (CPU cores) you want to consume. That's what's deployed now. I use --threading 2.  But I suspect this isn't the issue.
Please let me know more details.

OK, that is interesting, from my monitoring, I can reach about 220k packets/sec then the network bandwidth just drops out, like at 2:40 on the following graph:
https://imgur.com/pyBtgYD
During this time, the number of viewers is steady
That being said, since my post, I have been digging more into my trackers configuration, this seems more likely to be the bottleneck. I'm also hosting this server at OVH, it's possible the increased traffic triggered their automatic firewall.
Anyway thanks for the quick reply!


Feature Request: Support retrieving metadata from TraceProcessor

Background
A TraceUriResolver can append metadata when a trace URI is being resolved. This metadata can be accessed when using BatchTraceProcessor as the metadata is saved under tps_and_metadata. However, when using TraceProcessor the metadata is not preserved when a trace URI is resolved.
Workaround
Manually resolve a given Trace URI using the ResolverRegistry and then pass in the TraceReference into TraceProcessor constructor.
Feature Request
Expose metadata field from TraceProcessor.

This is a fair request and should be quite staightforward. @aMayzner can I ask you to take this?


OL tag updated to 2022.03.01_02.48.31 from 2022.02.23_02.50.41

Signed-off-by: vijayank88<EMAIL_ADDRESS>

Flow failed only for yonga-lz4-decoder with LVS error. All other designs passed successfully.
[2022-03-01T11:01:18.481Z] Circuit 1 contains 10157 devices, Circuit 2 contains 10124 devices. *** MISMATCH ***
[2022-03-01T11:01:18.481Z] Circuit 1 contains 10255 nets,    Circuit 2 contains 10249 nets. *** MISMATCH ***
[2022-03-01T11:01:18.481Z]
[2022-03-01T11:01:54.904Z] Result: Netlists do not match.
[2022-03-01T11:01:54.904Z] Logging to file "/openlane/designs/yonga-lz4-decoder/runs/RUN_2022.03.01_10.44.36/logs/finishing/35-user_proj_example.lef.log" disabled
[2022-03-01T11:01:54.904Z] LVS Done.
[2022-03-01T11:01:54.904Z] LVS reports:
[2022-03-01T11:01:54.904Z]     net count difference = 6
[2022-03-01T11:01:54.904Z]     device count difference = 33
[2022-03-01T11:01:54.904Z]     unmatched nets = 797
[2022-03-01T11:01:54.904Z]     unmatched devices = 130
[2022-03-01T11:01:54.904Z]     unmatched pins = 0
[2022-03-01T11:01:54.904Z]     property failures = 0
[2022-03-01T11:01:54.904Z]
[2022-03-01T11:01:54.904Z] Total errors = 966
[2022-03-01T11:01:55.389Z] [ERROR]: There are LVS errors in the design according to Netgen LVS.
[2022-03-01T11:01:55.389Z] [INFO]: Calculating Runtime From the Start...
[2022-03-01T11:01:55.389Z] [INFO]: Generating Final Summary Report...
[2022-03-01T11:02:00.359Z] [INFO]: Design Name: user_proj_example
[2022-03-01T11:02:00.359Z] Run Directory: /openlane/designs/yonga-lz4-decoder/runs/RUN_2022.03.01_10.44.36
[2022-03-01T11:02:00.359Z] Source not found.
[2022-03-01T11:02:00.359Z] ----------------------------------------
[2022-03-01T11:02:00.359Z]
[2022-03-01T11:02:00.359Z] LVS Summary:
[2022-03-01T11:02:00.359Z] Source: /openlane/designs/yonga-lz4-decoder/runs/RUN_2022.03.01_10.44.36/logs/finishing/35-user_proj_example.lvs.lef.log
[2022-03-01T11:02:00.359Z]     net count difference = 6
[2022-03-01T11:02:00.359Z]     unmatched nets = 797
[2022-03-01T11:02:00.359Z] Total errors = 966
[2022-03-01T11:02:00.359Z] ----------------------------------------

@dralabeing  FYI

@dralabeing FYI
As I mentioned earlier randomly yonga_lz4_decoder fails with hold violations.
Commit bf2412f successfully passed with OL tag.
Same OL tag today got failed during CI.
@vvbandeira How to download yonga-lz4-decoder project from CI repo for debugging the issue?

@vvbandeira 768649a
The design which got failed in CI for the commit soric_soc while I ran locally no hold violations. See the log below:
Antenna Summary:
Source: /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/finishing/antenna.rpt
Number of pins violated: 204
Number of nets violated: 180
[INFO]: check full report here: /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/final_summary_report.csv
[WARNING]: There are max slew violations in the design at the typical corner. Please refer to /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/routing/28-parasitics_sta.slew.rpt
[INFO]: There are no hold violations in the design at the typical corner.
[INFO]: There are no setup violations in the design at the typical corner.
[SUCCESS]: Flow complete.
[INFO]: Note that the following warnings have been generated:
[WARNING]: There are max slew violations in the design at the typical corner. Please refer to /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/routing/28-parasitics_sta.slew.rpt

Based on exception we can ignore the soric_soc failure and merge the commit and move on.
@dralabeing share your view please

@dralabeing FYI As I mentioned earlier randomly yonga_lz4_decoder fails with hold violations. Commit bf2412f successfully passed with OL tag. Same OL tag today got failed during CI.
@vvbandeira How to download yonga-lz4-decoder project from CI repo for debugging the issue?

You can find the files here:
https://jenkins.openroad.tools/job/OpenLane-MPW-CI-Public/job/PR-8-merge/4/artifact/OpenLane-2022.03.03_02.36.44/designs/yonga-lz4-decoder/

@vvbandeira 768649a The design which got failed in CI for the commit soric_soc while I ran locally no hold violations. See the log below:
Antenna Summary:
Source: /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/finishing/antenna.rpt
Number of pins violated: 204
Number of nets violated: 180
[INFO]: check full report here: /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/final_summary_report.csv
[WARNING]: There are max slew violations in the design at the typical corner. Please refer to /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/routing/28-parasitics_sta.slew.rpt
[INFO]: There are no hold violations in the design at the typical corner.
[INFO]: There are no setup violations in the design at the typical corner.
[SUCCESS]: Flow complete.
[INFO]: Note that the following warnings have been generated:
[WARNING]: There are max slew violations in the design at the typical corner. Please refer to /openlane/designs/soric_soc/runs/RUN_2022.03.05_10.03.37/reports/routing/28-parasitics_sta.slew.rpt

Based on exception we can ignore the soric_soc failure and merge the commit and move on.

We cannot just ignore if the CI is red, this need to be fixed or removed from CI.

@vvbandeira
While I test locally with ./scripts/run-design.sh soric_soc or yonga-lz4-decoder designs not facing hold violations or LVS mismatch.
But during CI at different runs these issue coming.
What will be the root cause?

@vijayank88 do you know if the OL tag we use contains the commits from this PR?
https://github.com/The-OpenROAD-Project/OpenROAD/pull/1681/commits

@vijayank88 do you know if the OL tag we use contains the commits from this PR? https://github.com/The-OpenROAD-Project/OpenROAD/pull/1681/commits

Yes @vvbandeira currently OL tag uses this OpenROAD commit:<PHONE_NUMBER>23e651e7b9c7c50efcce1fb04b4fee
https://github.com/The-OpenROAD-Project/OpenROAD/commit/944855835623e651e7b9c7c50efcce1fb04b4fee
https://github.com/The-OpenROAD-Project/OpenLane/blob/master/dependencies/tool_metadata.yml

@vvbandeira  then I'll revert my OL tag to 2022.03.02_02.59.05 this. Will check CI status?

@vvbandeira Please approve and merge it. Thanks


Clear the URL if there's no parent state to go by

As it writes in the title, I want to achieve something like this:
if ($state.exists("^")) $state.go("^"); else $location.path('/');
But apparently there's no exists function and therefore I can't do a check. Is there some workaround, or UI Router needs to be updated (with such function included), in order to solve this problem?

I've solved it via this workaround:
if ($state.href("^")) $state.go("^"); else $location.path('/');


KeyError when first trying to run a jit decorated function

I'm working with numerical integration of ODEs, using numba to speed up python implementations of various integrators. I have my jit-decorated functions specified in files, and I use @jit(nopython=True, cache=True). There are three files, file1 defines some functions that are used by functions in file2, which in turn are used by functions in file3. I don't pass these as arguments, but import them and just use them as global names within other functions. All functions are decorated in the same way.
Then, I finally use the functions from file3 in a jupyter notebook. The first time I call one of these functions, I get an error: KeyError: '_440_21'. Then, I re-run the cell, nothing changed, and the second time it works. There is nothing called 440 or 21 or similar in my functions, so I have no idea where this error is coming from. I include the rest of the error message below. I'm happy to provide my code as well, if required.

---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-5-6b60cf260044> in <module>()
     21
     22 tic = time()
---> 23 Xdopri5c, Nsteps = traj_dopri5c(U, V, xc, yc, tc, X0[:,n], T0[n], hout, days = days, atol = tol, rtol = tol)
     24 toc = time()
     25 print('Dormand-Prince, cubic:   ', toc - tic)

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/dispatcher.py in _compile_for_args(self, *args, **kws)
    275             else:
    276                 real_args.append(self.typeof_pyval(a))
--> 277         return self.compile(tuple(real_args))
    278
    279     def inspect_llvm(self, signature=None):

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/dispatcher.py in compile(self, sig)
    495             cres = self._compiler.compile(args, return_type)
    496             self.add_overload(cres)
--> 497             self._cache.save_overload(sig, cres)
    498             return cres.entry_point
    499

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/caching.py in save_overload(self, sig, cres)
    381             self._save_index(overloads)
    382
--> 383         self._save_data(data_name, cres)
    384
    385     def _check_cachable(self, cres):

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/caching.py in _save_data(self, name, cres)
    478
    479     def _save_data(self, name, cres):
--> 480         data = cres._reduce()
    481         data = self._dump(data)
    482         path = self._data_path(name)

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/compiler.py in _reduce(self)
     71         libdata = self.library.serialize_using_object_code()
     72         # Make it (un)picklable efficiently
---> 73         typeann = str(self.type_annotation)
     74         fndesc = self.fndesc
     75         # Those don't need to be pickled and may fail

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/annotations/type_annotations.py in __str__(self)
    258
    259     def __str__(self):
--> 260         return self.annotate()
    261
    262

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/annotations/type_annotations.py in annotate(self)
    119         #     return "Source code unavailable"
    120
--> 121         groupedinst = self.prepare_annotations()
    122
    123         # Format annotations

/Users/nordam/anaconda/lib/python3.5/site-packages/numba/annotations/type_annotations.py in prepare_annotations(self)
    103                         found_lifted_loop = True
    104                     else:
--> 105                         atype = self.typemap[inst.target.name]
    106
    107                     aline = "%s = %s  :: %s" % (inst.target, inst.value, atype)

KeyError: '_440_21'

Thanks for the report. I would guess that _440_21 is possibly some internal reference in Jupyter to the location/name of the function being called. If you have a small reproducer that would be great thanks.

Closing since we don't have example code to work with.


Episode edits 2

A quick pass at the complete lessons. The main changes are the examples list in lesson 1 and rewording parts of the random forest lesson.

Looks good to me as well


Add option to mark all items read

Since it was inconvenient to have to open each page in order to mark them read I've added a context menu item to mark items as read.
Unfortunately I wasn't able to add all of the corresponding locales entries for it as I do not speak most of those languages. It works fine in English.

This solves #312.

Hey, no problems, given the holidays I wasn't expecting a quick reply.
I've added your suggested change.
Happy holidays to you too!

@evilpie wdyt of this PR? It does what it should, but not sure it's going to be expected for users to have their history filled when they click this item

I have the same concern. Maybe we could make this side-effect more obvious with some different language like "Mark all as read/visited", but I honestly don't like that phrasing myself.
Maybe it's fine to add, worst case you can always delete something from your history?

As a user who has lots of unread items due to losing his history, I agree with this design. Given that currently there is no other way to mark items as read (and I'm not saying there should be), I think it's a good solution.

Can this be merged pls?


Socket null issue while discovering Sonos speaker in android pie devices.

So currently i am trying to connect with speakers which works pretty well for the devices below  android Pie. But for the particular devices (Samsung Galaxy S10, vivo,Samsung Galaxy A50) with android pie version i am getting null socket which leads to speakers not found for these particular devices.
Also, I came across weird scenario: when I turned on airplane mode, speaker are getting detected. which is not the correct solution for me.

I am facing the same issue on my SAMSUNG GALAXY S10. It is very strange that SONOS speakers are discovered only when Airplane mode is ON. I am getting null socket every time I try to connect


False positive for operator-no-unspaced when setting unicode ranges

Unicode ranges take a form like U+0000-00FF, and should not have spacing internally. These values should not trigger the operator lint rules.

Thanks! Looks like a bug.

@mirisuzanne I had a look at the rule, and it ignores the unicode-range property. Is the error that you are getting related to saving those unicode ranges to variables?

Huh, I'm not sure why it was throwing - I can't reproduce this anymore. There must have been another issue confusing the parser. Closing.


How do I add a font?

I'm came across your nuget package.  Then I downloaded the samples and started playing around.  This is really a great library and wrapper.  I'm new to tesseract in general.  I'm running on Windows and I'm looking for some help on how to add a font (Arial Narrow Bold).  Any help would be really appreciated!

Hi Jon, Glad you like the library. For adding a new font see the official
tesseract doco. Once you've trained a new language, using your font, just
drop them into your Tess data dir and you should be good to go.
On 01/07/2015 7:39 am, "jonmiller1"<EMAIL_ADDRESS>wrote:

I'm came across your nuget package. Then I downloaded the samples and
started playing around. This is really a great library and wrapper. I'm new
to tesseract in general. I'm running on Windows and I'm looking for some
help on how to add a font (Arial Narrow Bold). Any help would be really
appreciated!
—
Reply to this email directly or view it on GitHub
https://github.com/charlesw/tesseract/issues/185.


Make actually good emails

Reopening this because they have gotten worse lately.

Research https://markdownmail.com/

In order best solve this, I'm running an experiment. I'm splitting the email list in half, randomly sending half the population the new template and half the existing one. This experiment will run until either I'm happy with the new template or I scrap it and search for a different one

In order best solve this, I'm running an experiment. I'm splitting the email list in half, randomly sending half the population the new template and half the existing one. This experiment will run until either I'm happy with the new template or I scrap it and search for a different one

In new email template, remove underlines on links.

The new template seems to actually be working! Just need to check desktop Gmail.


Make OrElse Primary subclass strict

Follow up #791
My only argument in favour is that this works best for kittens.

The extra Lazy increases compile time :/

Codecov Report

Merging #792 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   87.95%   87.95%
=======================================
  Files          64       64
  Lines        1494     1494
  Branches        4        6    +2
=======================================
  Hits         1314     1314
  Misses        180      180

Impacted Files
Coverage Δ

core/src/main/scala/shapeless/orelse.scala
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abda46...f9d6fa7. Read the comment docs.

LGTM. Many thanks ... merging :-)


Scheduler comptime constants for systems

Allow scheduler to be created with custom comptime constants that systems then can use
This can be useful for testing and reduce the dependency of global constants in systems

Not sure what I was thinking. You can just read a comptime constant in your system


Feature Request --deleteall

I think it would be good for some cases if there was a handle for a delete all flag. It would come in handy when you need to enforce a specific dock layout ( my scenario is Online Testing, where we need to have safari and the browser on the dock ). It would help so that we could clear the dock and start from scratch that way we know exactly what the dock is. I realize we can do this with profiles, but sometimes those are not the best case.

dockutil --remove all

Thank you. Didn't see anything documented about that sorry to waste your time.

It's in the help :)

...
usage:     dockutil --remove  | all [ plist_location_specification ] [--no-restart]
all
...

Note: I am not the maintainer, just a user :)


lnd:v0.14.3-beta + releash.sh path fix

This PR updates all lnd references to v0.14.3-beta.
I saw an existing tag but it looks like it still used some 0.14.2 components. When I updated the tag to the contents of this branch, release.sh encountered a path error due to the tag containing docker/.... I'm unsure if this happens during the github build, but replacing / in the tag with _ allowed it to succeed. If this change is unnecessary, please let me know and I'll remove that commit.

Do I also need to bump AppPatch since the go modules are updated?

It's nice to have all the versions updated. But if you're just looking for a build that contains lnd v0.14.3-beta, it is already there: https://hub.docker.com/layers/lndinit/lightninglabs/lndinit/v0.1.3-beta-lnd-v0.14.3-beta/images/sha256-05ad190de0a13b086b785f43514269f6c9ddbfe828b45b439e49dd12f6191c08?context=explore
I pushed a tag yesterday, that's all that was needed (since no new functionality apart from README updates and the daily docker build was added to lndinit, no new version of it needed to be tagged).

Ah that's right, the github workflow handles creating images for new LND versions entirely based on tag.
Closing this PR since we don't need to update the contents of this repo unless we're updating the lndinit binary.


Updated Parsedown dependency to the latest version

Updated Parsedown dependency to the latest version
Now supports PHP 7 where it didn't before

Thanks!


Version 8.14.2 is broken at least for Windows

This is actually a bug, but for some reason bug report template wouldn't let me Submit it, button is disabled despite all required fields entered.
I tried on two different setups and version 8.14.2 for Windows doesn't work anymore. Downgrading back to 8.14.1 and everything works again. The problem is in driver initialization, which fails.
The attached log shows first run with 8.14.2 which fails and then run of 8.14.1 which works fine.
zwavejs_2023-05-03.log

@AlCalzone Dunno why this happens with 10.16.0:
2023-05-03T07:33:06.354Z DRIVER   Failed to initialize the driver: ZWaveError: Timeout while waiting for an ACK
                                  from the controller (ZW0200)
                                      at Driver.sendMessage (C:\snapshot\zwave-js-ui\node_modules\zwave-js\src\l
                                  ib\driver\Driver.ts:4199:23)
                                      at ZWaveController.identify (C:\snapshot\zwave-js-ui\node_modules\zwave-js
                                  \src\lib\controller\Controller.ts:930:33)
                                      at Driver.initializeControllerAndNodes (C:\snapshot\zwave-js-ui\node_modul
                                  es\zwave-js\src\lib\driver\Driver.ts:1292:26)
                                      at Immediate.<anonymous> (C:\snapshot\zwave-js-ui\node_modules\zwave-js\sr
                                  c\lib\driver\Driver.ts:1098:16)
2023-05-03T07:33:06.355Z DRIVER   destroying driver instance...
2023-05-03T07:33:06.381Z DRIVER   driver instance destroyed

Any clue?

This seems to be the same issue as https://github.com/zwave-js/node-zwave-js/issues/5024
The problem is that I can't reproduce any longer - the latest version is working fine on my Windows 11 machine. And I have no clue what could even cause this - Linux is working fine and Windows is too sometimes.

@bostjane please follow updates on that issue (just click on subscribe button)


axs.utils.elementIsOutsideScrollArea is wrong when there are absolute positioned elements positioned outside of the body element

Example snippet (but note that tab contents should be long enough to scroll off the screen):

  Title bar

    Tab 1 (hidden)

    Tab 2 (shown)

    Tab 3 (hidden)

This will cause document.body.scrollHeight to be less than the height of all content, and thus the logic in axs.utils.elementIsOutsideScrollArea will incorrectly detect elements as being outside the scroll area when they are not.

I believe this was fixed in 6573d39b75667981d636eaf1cd5c2c0d351de03f.


Checkstyle fixes

Unbreak checkstyle_suppressions.xml, "checks" and "message" seem to be mutually exclusive.
Fix style
Ignore ConstantName checks in Architecture2Test

Sorry Sven,
but i guess it was my fault - the checkstyle_suppressions.xml was using an really outdated dtd - now the ci build passes again.

Not needed any more


WIP:add multiple build targets

This adds multiple build targets (static and shared) and builds on Windows with WinSSL if you have CURL installed in the system directory C:\Program Files (x86)\CURL. I will need to look at how the build machine deals with building, as I don't know why that last test would fail...
Also, this adds static and shared targets.
This PR is a WIP and should NOT be merged.

I don't think building static and shared is what is needed in the general case. I'd very much prefer if the existing STATIC just got dropped and the user is put into the choice via: https://cmake.org/cmake/help/v3.8/variable/BUILD_SHARED_LIBS.html

Yeah, I was using cpr for a project, but ended up not using it, so I dont have time to work on this anyway, if someone wants to take over, be my guest.

@ethanhs What did you end up with instead if you don't mind me asking? I am currently also toying with cpr and open to alternatives.

The project I was using ended up not happening, so nothing. But using plain curl is decent. The cpprestsdk is pretty nice, but I like cpr.

I have lost time and interest in working on this, so I am closing.


Fix copyright check when the build directory is in the source directory.

The IDE I am using places the cmake build directory inside the source
directory.  When that happens the copyright check fails because the
build process creates a file CMakeCXXCompilerId.cpp.  That file does
not have the copyright information, so the test fails.
I want this file to be ignored, so I added its directory, CompilerIdCXX,
to the list of directories to be ignored.

Rebased and pushed into master as b1b494835d


Address failing tests in repo-review

PR #456 added repo-review as a pre-commit hook using the sp-repo-review plugin (https://pypi.org/project/sp-repo-review/)
Several of the checks are failing for the cf-units repository (expected). The failing tests are currently set in an ignore list in pyproject.toml to avoid failures in the workflow, but it would be good practice if we could address them:
### Test
- [ ] PY005: Has tests folder
- [ ] PP003: Does not list wheel as a build-dep
- [x] PP304: Sets the log level in pytest
- [x] PP305: Specifies xfail_strict
- [x] PP306: Specifies strict config
- [x] PP307: Specifies strict markers
- [ ] PP309: Filter warnings specified
- [x] GH104:  Use unique names for upload-artifact
- [ ] GH212: Require GHA update grouping
- [x] PC110: Uses black or ruff-format
- [x] PC140: Uses a type checker
- [x] PC160: Uses a spell checker
- [ ] PC170:Uses PyGrep hooks (only needed if rST present)
- [ ] PC180:Uses a markdown formatter
- [x] PC190: Uses Ruff
- [ ] PC901:Custom pre-commit CI message
- [x] MY100:  Uses MyPy (pyproject config)
- [ ] MY105" MyPy enables redundant-expr
- [x] RF001:Uses RUFF

We may decide some checks are not relevant, in which case they can be removed from this above TODO list and left in the ignore list in pyproject.toml

Several tests resolved in #522


[cli] app:build, app:serve, app:test, app:lint

There should be app:build/serve/test/lint commands that are used by packages/app and any other instance of backstage.
App package.json:
"scripts": {
  "build": "backstage-cli app:build",
  ...
}

Not sure if we want to base this on react-scripts or a custom webpack. Leaning towards custom webpack, especially since we have the custom optimization.

[x] A
[ ] B