Nostalgie is vulnerable to XSS if SSR data is ever accidentally under visitor or user control

As reminded by @Ephem on a recent podcast episode, an SSR project needs to take care in how it serializes untrusted code into the generated markup. Any user-submitted code could take advantage of some of the surprising nuances of html parsing and attempt to get something like </script> injected. After that, game over. Full XSS 😱 .

Nice find and fix! As I mentioned in the episode I've had this vulnerability myself in the past, I'm glad sharing that was helpful. 😄


Response code 201 not showing in documentation

Hello all, I was wondering how would I show a 201 Created response? I have a method which does the following:
The problem is when I access the documentation via url/swagger it doesn't show 201 as a possible response? I imagine it is related to the return type being a HttpResponseMessage?
    /// <summary>
    /// Initialises something
    /// </summary>
    /// <remarks>
    /// Some remarks.
    /// </remarks>
    /// <param name="request">Request to initiate.</param>
    /// <response code="201">Account created</response>
    /// <response code="202">Lovely.</response>
    /// <response code="301">Jubbly.</response>
    /// <response code="400">Invalid request.</response>
    /// <returns></returns>
    [Route("helloworld")]
    public HttpResponseMessage Post(RequestV1 request)
    {
        return this.Request.CreateResponse(HttpStatusCode.Created, new RequestV1());
    }

Hmmm - this maybe an issue with the swagger-ui as opposed to SB. Can you navigate directly to the raw  swagger (e.g. yourapi.com/swagger/docs/v1) and ensure the responses are ate least present in the Swagger description. If so, then SB is doing it's job correctly but the swagger-ui doesn't seem to support multiple 2xx codes on the same operation and you should probably create an issue in that repo

Just a note: It seems swagger-ui will take the first 2xx response code and use that as the sample response. It'll also omit this from the additional response codes that are displayed afterwards.

Closing this issue as the Swagger JSON, generated by Swashbuckle, includes the additional responses but the swagger-ui chooses not to show multiple 2XX responses.
I took a quick look in the swagger-ui repo (https://github.com/swagger-api/swagger-ui) and couldn't find any related issues. If this is still a problem for you, I would recommend submitting one there.
Thanks


After Packing Into ASAR I am facing Issues With Path(Windows)

var win=path.join(__dirname,'config.EXE');
var exec = require('child_process').execFile;
exec(win);
this Is working Fine But After Packing it into ASAR .Exe is not getting Executed
getting Error As Path Unspecified
Tried Without Path.join As Well but No Sucess
Can Anyone Faced The Same issue And Able to Resolve?

Facing the same issue. Any help would be highly appreciated :)

Is the config.exe inside the .asar archive?

that issue is resolved
we kept it inside archive then we unpacked that and it worked.

that issue is resolved

Great to hear, closing this out 👍


Versioning

Hi Thomas,
thanks for this role, it is awesome and really helpful in maintaining my Gitea server.
One small request I have is to implement versioning and tagging for this role. It would be good if it would be possible to deploy a known working or older version for some scenarios.
Thanks!

Hey @wzzrd ! I'll will have a look at how it works in galaxy (i.e. just a yaml field) and implement that with git tags, if that looks good to you

Sounds great!

Just published v0.0.0, I will keep incrementing the version every time I merge a bunch of PRs !


Delete Buglist and AUTH_HOWTO

are these still necessary?
AUTH_HOWTO moved to the wiki

Ok for me. It comes from ancient times...


Reading line by line and ignoring empty lines

Hello
Is there an example of reading a file line by line?
Also how can I handle empty lines
e.g.
x, y, z
1,2,3
4,5,6

7,8,9

Hi @MaxHayman - while rapidcsv may be used to read CSV data line by line, its API is not really intended for it. At the time I wrote rapidcsv there were a couple open source C++ CSV parsers available which all required the application to do the line iteration and handling. I needed a CSV reader which directly could give me a specific column, cell (or row) without reading line by line.
One can use rapidcsv to read an entire CSV file and iterate over each line with something like:
#include <iostream>
#include <vector>
#include "rapidcsv.h"

int main()
{
  rapidcsv::Document doc("examples/colrowhdr.csv");
  const size_t rowCount = doc.GetRowCount();
  for (size_t i = 0; i < rowCount; ++i)
  {
    std::vector<std::string> row = doc.GetRow<std::string>(i);
    std::cout << row[0] << std::endl;
  }
}

But "reading a file line by line" is currently not possible using rapidcsv. Please check out the other parsers linked under https://github.com/d99kris/rapidcsv#alternatives - I think most of them work that way (reading line by line).
Regarding empty lines, it's currently not supported. If you still consider rapidcsv after above limitation (no line-by-line processing) please let me know?
I'll see if I can come up with a good handling for empty lines.

Closing this issue, feel free to re-open if you want to pursue this in the future.


A VALID AND FAIR CONCERN.

Ok so I have this cookbook in my kitchen right
I open it up
Wow! Look at all the amazing food!
I can see the ingredients... exactly what I need to make the product
I can see the recipe... exactly what I need to do to make the product
But where is the product? There is no product? I want to see a working version of the product!
(A gif of like an arm/slides moving for a PIDF controller is a good example)
kthxloveyoubye

will be added to the contributors guide, very valid concern good sir


[OCaml] exclude type constraints from scope in type bindings

This has the extra benefit of leaving two type bindings in ocaml.mli as they originally were (the initial formatting is better).
Closes #451

Neat!


Dinamically add input pickers and instantiate each by class, no by ID

Do you want to request a feature or report a bug?
feature?
What is the current behavior?
In a form where I can add dinamically multiple input fields for the pickers, i don't know how to instantiate each of it. It work only for first. I can't use ID, only classes.
If the current behavior is a bug, please provide the steps to reproduce and create a JSFiddle.
https://jsfiddle.net/dvx79gz1/2/
What is the expected behavior?
I'd like to instantiate in a simple way multiple inputs by class only. no ID.

Duplicate of #127, #57 and #30

no fiddle (working) found about my question.
Tried loop method without success (updated fiddle): https://jsfiddle.net/dvx79gz1/12/

Checkout how to use it with input-elements. And this example of how to do it.
I'll add this as an example to the README since a lot of people struggle with it.


⚠ Bofrost.es has degraded performance

In 38d16d6, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1532 ms

Resolved: Bofrost.es performance has improved in a58525d after 6 minutes.


Heart disease prediction

Aim

Heart disease prediction using machine learning

Details

This script predicts whether a person has heart disease or not using machine learning

Assigned to you, refer to this PR files on how to structure your files and creating the prediction script https://github.com/avinashkranjan/Amazing-Python-Scripts/pull/556


chore(master): release 2.8.6

:robot: I have created a release beep boop
2.8.6 (2024-12-12)
Dependencies

deps: update ansible/ansible-lint action to v24.12.2 (#120) (dae2040)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.8.6
:sunflower:


-v argument to output version is detected anywhere in command, preventing calling any command with a -v argument

Node 12.16.3
env-cmd 10.1.0
npx env-cmd node -v

Output: 10.1.0
Expected output: 12.16.3
If I comment out this line in my node_modules, then it works as expected:
https://github.com/toddbluhm/env-cmd/blob/master/dist/parse-args.js#L77
I don't know enough about commander to propose a fix.

This is still a thing. I wasn't able to assign a docker volume using -v, workaround is to use --volume


Feature: Arm helper scripts

Description
It can get quite tiring to have to keep manually resetting the arm to retune its controllers, so I wrote some scripts to return the arm to its home position and send it out again to a pickup-ready position. This needs to be done because commanding the arm through the MoveIt! interface will cause the planner to think that it is colliding with itself and abort the command.
The arm home position is gotten from the startup angles parameters. The individual scripts have other tunable variables, but I don't expect them to need changing.
Also, the script has an inbuilt intermediate goal skipping check implemented. The arm will skip an intermediate goal if its current position is already close to it or the final goal.
 Implementing the scripts for left arms should be a fairly easy matter of changing the topic names.
Note that no collision avoidance will occur when using these scripts.
I also made the controllers turn on by default since the scripts can then go ahead and control the arm.

This looks useful!
Like #62 though, it seems kind of specific and I'm not completely sure it belongs in blue_core. Maybe we could make a separate repo or package for things like this? blue_demos? blue_examples?

This looks useful!
Like #62 though, it seems kind of specific and I'm not completely sure it belongs in blue_core. Maybe we could make a separate repo or package for things like this? blue_demos? blue_examples?

Sure!

Done! You are welcome to add the helper scripts here.
https://github.com/berkeleyopenarms/blue_helpers

Alrighty, I'll close this PR then.

Relevant PR added here: https://github.com/berkeleyopenarms/blue_helpers/pull/2


UTY-2126: deployment launcher window no longer accepts 33-character tags

Description

UTY-2126
deployment launcher window no longer accepts 33-character tags
previously the regex accepted a character and then 2-32 more*
now we accept upto 31 more

separate rules because the first character can't be an underscore

Tests
the relevant error appears when a 33 character tag is entered
Documentation
changelog
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Note: test-writing in progress


Add Advanced Search to Top Bar.

Like in Showcase we have Top bar with advanced search: https://www.screencast.com/t/gTEzvPp1uVC
Approx. estimate time: 6-8h

http://docs.pulsetile.com/react-search.html

search is available by surname or ID
need to extend the API to enable further searches
@BogdanScherban to update

linked to #29

Client side of this issue was done. But now we can search patients by lastName and by patientId:
https://drive.google.com/file/d/1kcseeS_0xizc5-1iIkXr5xQs7iIbwepg/view
PatientID has more priority than lastname.
All other fields aren't used in search, because we don't have API-method for this.

dependent on FHIR searching for work by Dima

@PhilBarrett @tony-shannon
Dima working on this issue at the moment

PR being reviewed by Alexey
https://github.com/QEWD-Courier/fhir-mpi/pull/1


add entropy calculation for each PE section

add entropy calculation for each PE section

done and will be in next release


Improve error message for repeat after group or assertion case.

Give a tip for ([a-z]){3},Repeat after capture group, only the last appearance will be captured. For example: /([a-z]){3}/.exec("abc") will result   ["abc","c"]
/a(?=bc){3}/、/a(?=bc)+/  should warn "It works same as /a(?=bc)/"
/a(?=bc)*/, /a(?=bc){0,3}/ should warn "It works same as /a(?=bc)?/ "
And  /a(?=bc)?/ should not warn.

And /a(?=bc)?/ should not warn.

Why not  btw? What's the effect of it?

@RReverser
I think maybe I need to make a distinction between error and warning.
You're right,(and I was right, last night I'm confused and forgot this :wine_glass:  :sleeping:  :laughing:  ), It should warn explicitly  /a(?=bc)?/ is same as /a/.


Fix README.md code example

Hi! You have missed quote symbol in README.md code example.

Specifically "flashed"


updated community.md to include projects/use case section

Description

Updated community.md to include the GitHub to airtable integration I'll be using for my TechLancaster Talk. This PR includes no code changes
Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Love it!


patch: add hasOwnProperty checks into for...in loops to prevent iteration over unexpected members

patch: add hasOwnProperty checks into for...in loops to prevent iteration over unexpected members
docs: fix broken link in CONTRIBUTING.md

Prototypical extension of built-in classes (e.g. Object) is a known antipattern, however there are still people out there, who use this option. As a developer creating generic modules, I think testing a library against these extensions is a real use case.

So, there are a few things that are blocking landing this as-is.

The JS style should be 2-space indents everywhere.
The added test doesn't fail without the code changes, so I'm not exactly sure what it is testing?
In general, adding for (x in y) { if (y.hasOwnProperty(x)) { ...  is not ever the best approach.  Either the prototype chain is relevant, or it is not.  If it is, then the hasOwnProperty check is incorrect.  If it is not, then Object.keys(y).forEach(function (x) { ... }) is a better pattern.  Furthermore, if the prototype chain is not trustworthy for some reason, or if the object is a generic bag o' data which can contain any key, then it's better to do var hasOwnProperty = Object.prototype.hasOwnProperty at the top of the file, and then test with hasOwnProperty.call(obj, key) (since the hasOwnProperty key may be overwritten, or not a function, or some other function, etc.)

If you feel like rebasing onto the latest master, and fixing these things, I'd be happy to merge this.  Please let me know if I can be of any assistance.
Thanks!

Thank you for your response!
I realised that my original issue has been fixed meanwhile by the replacement of for...in here: https://github.com/tapjs/node-tap/blob/master/lib/assert.js#L189-L191
However, tap still breaks if I require() it after Object.prototype has been extended, because of this loop: https://github.com/tapjs/node-tap/blob/master/lib/synonyms.js#L67
My latest commit on this fork fixes that. I also replaced the for...in loops everywhere in the code base with Object.keys(y).forEach(function (x) { ... }) to prevent any further issues like this. Sorry for the indentation mistake in my test file (that you mentioned in point 1.), it is also fixed now.
I had difficulties and conflicts during the rebasing process, so please double-check my changes, but I think everything is ok.

Unsurprisingly, your observations were perfectly valid, so I made the proposed changes. Is there anything else that's blocking this request to be merged?


Relax assertion in BoundedReadFromUnboundedSourceTest

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Deflakes the test

R: @dhalperi

LGTM per discussion


Could we change the cask update deprecation message to use a more ordered date?

I don't know whether 2017-07-01 is referring to 1 July or 7 January to be honest; I think it'd be better if the deprecation notice used a date format like "7 January 2017" so no ambiguity in the format.

If you think this is an odd request, note that @Numbermaniac and myself (and @fanquake I believe) are in Australia, and we read 07-01 as the 7th of January, where many around the world would read 07-01 as the 1st of July.

has America infected the world with this much uncertainty around dates?

Yes, they have.

Shame on them.

Shaming them does not accomplish anything, though.

ISO 8601 universality (…) and it follows convention used around most of the world

No one in this issue is disputing the merits of ISO 8601 or arguing it shouldn’t be universal. However, none of that helps. Seeing 2017-01-07 and wishing it’s ISO 8601 does nothing.
Just over half of the maintainers of this project are non-American. Yet, by convention we still default to the American-english version of software when there is an alternative, because it makes sense to do so. There’s no reason to assume right out the bat that we use ISO 8601.
I do agree with your sentiment, just not with your argument. Yes, it would be great if we could all use the same agreed upon system. Unfortunately, computer system are made by humans (obligatory XKCD).
In sum, here’s the main flaw in your argument: this message is to be read by humans, not machines. Ambiguity matters not because the code breaks, but because users are confused.

In the future, let's just use the 15th of the month. 😂


DDb Indexer Property during SerializeToDocument causes TargetParameterCountException

Describe the bug
Attempting to save/serialize a DynamoDB class with SaveAsync / SaveHelper causes the reflection to attempt to call GetValue with limited parameters when there is an indexer property and save fails / throws an exception.
Expected Behavior
I would like if there is some workaround that is also fast and/or acknowledgement that this is an issue that is already ignored because I want an indexer property with my serialized class.
Current Behavior
SaveAsync fails:
System.Reflection.TargetParameterCountException
  HResult=0x8002000E
  Message=Parameter count mismatch.
  Source=System.Private.CoreLib
  StackTrace:
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.RuntimePropertyInfo.GetValue(Object obj, BindingFlags invokeAttr, Binder binder, Object[] index, CultureInfo culture)
   at System.Reflection.RuntimePropertyInfo.GetValue(Object obj, Object[] index)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.TryGetValue(Object instance, MemberInfo member, Object& value)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.PopulateItemStorage(Object toStore, ItemStorage storage, DynamoDBFlatConfig flatConfig, Boolean keysOnly, Boolean ignoreNullValues)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.SerializeToDocument(Object value, Type type, DynamoDBFlatConfig flatConfig)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.ToDynamoDBEntry(SimplePropertyStorage propertyStorage, Object value, DynamoDBFlatConfig flatConfig, Boolean canReturnScalarInsteadOfList)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.PopulateItemStorage(Object toStore, ItemStorage storage, DynamoDBFlatConfig flatConfig, Boolean keysOnly, Boolean ignoreNullValues)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.SerializeToDocument(Object value, Type type, DynamoDBFlatConfig flatConfig)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.ToDynamoDBEntry(SimplePropertyStorage propertyStorage, Object value, DynamoDBFlatConfig flatConfig, Boolean canReturnScalarInsteadOfList)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.PopulateItemStorage(Object toStore, ItemStorage storage, DynamoDBFlatConfig flatConfig, Boolean keysOnly, Boolean ignoreNullValues)
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.<SaveHelperAsync>d__42.MoveNext()
   at Amazon.DynamoDBv2.DataModel.DynamoDBContext.<SaveHelperAsync>d__41`1.MoveNext()

Problem area:
        private static bool TryGetValue(object instance, MemberInfo member, out object value)
        {
            FieldInfo fieldInfo = member as FieldInfo;
            PropertyInfo propertyInfo = member as PropertyInfo;
            if (fieldInfo != null)
            {
                value = fieldInfo.GetValue(instance);
                return true;
            }

            if (propertyInfo != null)
            {
                value = propertyInfo.GetValue(instance, null);
                return true;
            }

            value = null;
            return false;
        }

The exact area is probably here:
            if (propertyInfo != null)
            {
                value = propertyInfo.GetValue(instance, null);
                return true;
            }

Reproduction Steps

Create a class with DynamoDBTable annotation
A nested property has an indexer property
Create indexer
for example

        public T this[int index]
        {
            get
            {
                return Items[index];
            }
            set
            {
                Items[index] = value;
            }
        }

The use was like this
[DynamoDBTable("A")]
public class A {
    public B B {get;set;}
    public A() {}
}
public class B:C {

    public B() {}
}
public class C {
    public D<E> {get; set;}
    public C() {}
}

public class D<T> {
    public T[] Items {get;set;}
        public T this[int index]
        {
            get
            {
                return Items[index];
            }
            set
            {
                Items[index] = value;
            }
        }
}

Sorry if it's kind of confusing but I think this was the case it was used in although I think it would happen in any case with an indexer.
4. Attempt to save with DynamoDBContext.SaveAsync
Possible Solution
No workarounds for having both get and set on the indexer.
References:
Maybe only a read-only indexer
https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/indexers/
Good answer on SO:
https://stackoverflow.com/questions/46855438/c-sharp-parameter-count-mismatch-converting-list-to-datatable
If this line is throwing the exception

values[i] = Props[i].GetValue(item, null);
...then it means you have a property that requires a parameter. In c#, the only type of property that takes a parameter is an [indexer](https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/indexers/using-indexers). My guess is you should just exclude the indexer from the loop.

See [this question](https://stackoverflow.com/questions/4746188/propertyinfo-is-the-property-an-indexer) which tells you how to detect an indexer.

You can probably fix this by changing one line. Change this...

Questionable solution:
private static bool TryGetValue(object instance, MemberInfo member, out object value)
{
    FieldInfo fieldInfo = member as FieldInfo;
    PropertyInfo propertyInfo = member as PropertyInfo;

    if (fieldInfo != null)
    {
        value = fieldInfo.GetValue(instance);
        return true;
    }

    if (propertyInfo != null)
    {
        // Check if the property is an indexer and skip it
        if (propertyInfo.GetIndexParameters().Length > 0)
        {
            value = null;
            return false;
        }

        value = propertyInfo.GetValue(instance, null);
        return true;
    }

    value = null;
    return false;
}

Additional Information/Context
No response
AWS .NET SDK and/or Package version used
AWSSDK.DynamoDBv2 <IP_ADDRESS>
Targeted .NET Platform
.NET 6
Operating System and version
Windows 10

I'm observing this same issue. I have slightly newer version 3.7.301.7 of AWSSDK.DynamoDBv2 but it behaves the same.

In my case I was trying to save List<MyClass> items in one SaveAsync call, like await ddbContext.SaveAsync(items).
It helped to just save each item individually:
foreach (var item in items) {   await Program.DynamoDBContext.SaveAsync(car); }
Good enough for me at this point.

@tnurmi82 Good afternoon. Could you please let us know if you are still blocked and/or have a workaround? Or if this is still an issue?
Thanks,
Ashish

@ashishdhingra I'm good, thanks!

@taesookim0412 Good afternoon. Could you please confirm if this is still an issue with the latest version of AWSSDK.DynamoDBv2 and if the workaround suggested by @tnurmi82 works?


Disable "Start Discussion" window

Is possible to add an option to disable this window from popping when you click on a Step?

Sometimes I create tours just to quickly navigate between the code/files, would be nice having an option to don't open this window and just jump to the line silently.

So you're looking to create a tour simply as a series of file locations? But without any descriptions at all?
I wonder if the solution is to leave the description blank when you record the tour, and upon playback, CodeTour could detect empty steps and hide the comment popular?

I wonder if the solution is to leave the description blank when you record the tour

Not really, as I could still want to leave any description in the tour, I mean an option to just don't open the start discussion when jumping to the tour line.
Maybe an option in the .tour file?
"silent": true  (jump to step line without opening any window)
Anyway, people would still be able to read the description by hovering over the tour at the explorer panel.

Yep this seems like a pretty straight forward change.

So can I expect it to be implemented?

@lostintangent could you answer? you're not supporting the extension anymore?

If you'd be down to submit a PR, that would be great, and I could help review it. At the moment, I have a few other priorities across this extension, and my others, and so it would be a huge help to get some community assistance. Otherwise, I can try to get to this in a couple weeks.

If you'd be down to submit a PR

I would like to, but I have never worked in any extension, I'm a beginner in programming, and while I was searching for some extensions to help in this process, I have found Codetour and I like it a lot, great extension!

Otherwise, I can try to get to this in a couple weeks.
Thank you, I will wait for you to get some time for it!

Sounds good! I'll use this issue to report any progress in the next couple weeks.
Regarding the design: in addition to attaching a step to a line of code in a file, a tour can also have steps that are associated with a directory, and also, "content-only steps", which aren't associated with either a file or directory (e.g. providing an intro to the tour, or summarizing some content in the middle of a tour). In these two cases, we need to think about how they'd behave in "silent" mode.
For directory-based steps, the directory is auto-focused in the file tree when it's navigate to, but that's pretty subtle. And so I'd worry that a user might be confused if they navigate to a directory step, and we didn't display the step description UI. Furthermore, the content-only step wouldn't have anything else to show besides its description, and therefore, you'd either need to choose between 1) showing these steps, which might feel inconsistent, or 2) skipping these steps entirely, which might seem confusing.
Since the request for "silent" tours hasn't come up before, I'm not entirely sure what the expected behavior here is. In your case, I'm not sure if you're using directory or content steps, but we'll need to design this feature in a way that works for them, since this needs to be a general-purpose feature of CodeTour.
I'd love your thoughts on this 👍

@lostintangent  I'm using regex to match the steps, the other options you mentioned I don't know how they work

Why not make all options behave the same? Click goes to the line without opening anything? I could not understand your doubt (sorry English is not my main language)

In the case of "directory steps" we could do this, but there isn't a line of code to navigate to. CodeTour is simply selecting the associated directory in the file tree (as if you single-clicked it yourself). Since this is a subtle UX gesture, I'd worry that without displaying the step description, people might get confused and think it's broken. That said, I suppose the status bar and CodeTour tree would indicate what the step represents, and so maybe this behavior is OK.
But for "content only steps", they aren't associated with a file or folder, and so if we didn't show their descriptions, then they'd be effectively skipped. So I think to start, we should make "content only steps" effectively ignore the silent setting, and behave normally.

@lostintangent hello

@lostintangent i got it, now the window doesn't open anymore and everything else still working correctly
i needed just to comment this line: https://github.com/microsoft/codetour/blob/e7018e228c64f9dde061af56217927159cd42950/src/player/index.ts#L363
any idea in how i could also hide this mark?


Filter actions

I have certain actions which are generated very frequently. When the devTools middleware is applied, this makes things very slow and clutters the monitors with lots of data.
It would be great if there were a way to specify a filter for an action to be ignored by devtools.
Thanks!

I have certain actions which are generated very frequently. When the devTools middleware is applied, this makes things very slow and clutters the monitors with lots of data.

The slowness is no longer an issue as of<EMAIL_ADDRESS>#133.

It would be great if there were a way to specify a filter for an action to be ignored by devtools.

There is a plan for a more modular UI that would allow this, please track https://github.com/gaearon/redux-devtools/issues/74.

Thanks!

I have this working in a fork right now as I couldn't wait and a dirty dirty hack.
It's using React-0.14-rc and has a terrible label statement to break loops but it works, you can supply an array of regex values that will not be displayed in the logMonitor
          <DevTools
            select={state =>get(state, 'myForm')}
            actionTypeFilters={[/UPDATE_FORM/, /IGNORE/]}
            store={store}
            monitor={LogMonitor}
          />

"redux-devtools": "tomatau/redux-devtools",

:+1: Would love to see this built-in. We have async actions that save data in the back-end and they clutter the whole devtool

This would be a great. Specially when working with redux-form, which sends A BUNCH of actions. When I use redux-form with dev tools, it lags pretty hard if I type a little faster.

I'm in the same boat: getting overwhelmed by state updates, particularly with redux-forms.. +1 for filtering!

Sorry but +1's don't help anyhow. :wink:
Monitors can already be developed by users.
Feel free to fork the log monitor, add filtering to it, and then propose your changes.

Please use https://github.com/zalmoxisus/redux-devtools-filter-actions.
It can be composed with any monitor.


Issue to send PID Code

Hi Tomiwa,
I used your library where I found one issue we are unable to send code when we are successfully connected with the ELM OBD device.
ISSUE Found :
dataOutputStream.writeChars(command);
Solution :
out = new BufferedWriter(new OutputStreamWriter(outStream), 1);
out.write(msg.toCharArray());
You can connect with me on Skype if you have any issue regarding that
davinder_syall or emailId<EMAIL_ADDRESS>

Hi Tomiwa,
I used your library where I found one issue we are unable to send code when we are successfully connected with the ELM OBD device.
ISSUE Found : dataOutputStream.writeChars(command);
Solution : out = new BufferedWriter(new OutputStreamWriter(outStream), 1); out.write(msg.toCharArray());
You can connect with me on Skype if you have any issue regarding that davinder_syall or emailId<EMAIL_ADDRESS>
Can you send the full solution or make a PR?


How forward search work?

i am not sure it is caused by LSP or LSP-TexLab or TexLab
i cannot use forward search with "Alt+DoubleClick", what is the correct way?
my config file:
	"texlab.forwardSearch.executable": "D:/Software/SumatraPDF/SumatraPDF.exe",
	"texlab.forwardSearch.args": [
		"-reuse-instance",
		"%p",
		"-forward-search",
		"%f",
		"%l"
	],

Forward search is unbound. You must set up a key bind executing the command lsp_texlab_forward_search.

{ "keys": ["alt+b"], "command": "lsp_texlab_forward_search"},
it works

I hope it can appear in the right click menu in the future


Removal Reasons and Removal Messages support

Feature Summary and Justification
Adds support for the new removal-reason-related API endpoints: adding, editing, and deleting the removal reasons of subreddits, setting the removal reasons of submissions and comments, and sending removal messages about submissions and comments.
It's possible to set one removal reason and note on many Things at once.  The support for that here mimics other bulk operations in PRAW.
There's a new string-enum (passed directly to the API), with options explained in the docstring for send_removal_message.
Some of these endpoints won't accept URL encoded input.  Requests are sent using prawcore in these cases, because I couldn't see another way to send JSON encoded input.
References
These endpoints are undocumented, so I spent a while using removal reasons in the redesign and watching the requests to see how they worked.

I just want to say that this is looking really awesome. Please comment if you run into any issues getting the tests to work.

@NetwideRogue it's been awhile since I looked at this. Looks like it's in need of a rebase. I'd also like to ask if you could split this PR in to independent sets of functionality so that the PR can more easily be reviewed. Is that something you're interested in doing? Thanks!

sure, I'll start splitting it up into smaller PRs in a few days


Using multiple entryPoints with entryPointStrategy set to "expand" fails to build if out folder exists.

Search terms

There is currently no fool-proof way to use an entryPointStrategy of "expand" for multiple folders. It can be done, but if an output folder already exists, the build fails.
Expected Behavior
If you use a typedoc.json file such as
{
"entryPointStrategy": "expand",
"entryPoints": ["./tests", "./utils"],
"out": "docs",
}
I would expect this to build documentation from the two listed folders.

Actual Behavior
It only works if an output folder does not exist. You must delete the folder before re-running otherwise there the build fails. Oddly, this happens even if the folder has been renamed. It must be deleting before re-running options command.

Steps to reproduce the bug

use a typedoc.json file like this:
{
"entryPointStrategy": "expand",
"entryPoints": ["./tests", "./utils"],
"out": "docs",
}
run: npx typedoc --options ./typedoc.json
run again: npx typedoc --options ./typedoc.json

Environment

Typedoc version: 0.22.13
TypeScript version: 4.5.5
Node.js version: 16.13.0
OS: Windows 10 Pro

I can't seem to reproduce this. I set up a project with the specified structure, and ran TypeDoc several times without ever deleting the output folder. It succeeded in generating documentation each time.

I can't seem to reproduce this. I set up a project with the specified structure, and ran TypeDoc several times without ever deleting the output folder. It succeeded in generating documentation each time.

I'll try and make a minimal repo as soon as I can :)
Thanks

Okay. I recently realised typescript builds were also failing to build with the docs folder present. The issue is actually because I need to add the output "docs" folder to my excluded list in my tsconfig.json otherwise it tries to build from the js files in the docs folder (which are present in docs/assets due to plugins).

Well, yep, that'll do it! Glad you got it figured out.


QR-Code Dashboard

The QR-Codes of the services in the new OSA have the old lay-out.
Please connect to the correct branding.

@GertCornelis: Did you upload the QR template when creating this app in BOB? If you didn't, then you'll need to upload it at https://rogerth.at/mobiadmin/apps and all newly created services will have that new QR template.


issue close test

body...

Job gh:amihaiemil/docker-java-api#354 is not assigned, can't get performer


The default performance of greykite silverkite is far worse than default prophet

I am recently familiar with this time series modeling library. I am trying to use this model for some regular sales data which have some trends and some seasonality and do not contain outliers.
Question: How to change default parameters of greykite so that it gives some realiable output?
In my usecase I have following results:

Greykite ==> 122% percentage difference between validation sum and prediction sum
Prophet ==> -2% percentage difference between validation sum and prediction sum

I am looking for some suggestions how to improve the performance of greykite model.
Vanill Greykite code
# imports
import time
time_start_notebook = time.time()
import numpy as np
import pandas as pd
import matplotlib.pyplot as plt

# timeseries
import greykite
from greykite.framework.templates.autogen.forecast_config import MetadataParam
from greykite.framework.templates.forecaster import Forecaster
from greykite.framework.templates.autogen.forecast_config import ForecastConfig
from greykite.framework.templates.model_templates import ModelTemplateEnum
from greykite.framework.templates.autogen.forecast_config import ComputationParam

import warnings
warnings.filterwarnings("ignore")

# variables
col_date = 'BillingDate'
col_val = 'y_true'

fh_val = 90
freq='D'
verbose=1

# data
url = "https://github.com/bhishanpdl/Shared/blob/master/data/daily_0600075027.csv"
dfs = pd.read_html(url,parse_dates=[col_date])
df = dfs[0].iloc[:,1:]

# modelling
metadata = MetadataParam(time_col=col_date,value_col=col_val,freq="D")
computation_param = ComputationParam(hyperparameter_budget=None,n_jobs=-1,verbose=verbose)
config=ForecastConfig(
    model_template=ModelTemplateEnum.AUTO.name,
    forecast_horizon=fh_val,
    coverage=0.95,
    metadata_param=metadata,
    computation_param=computation_param
)

forecaster = Forecaster()
result = forecaster.run_forecast_config(df=df,config=config)
df_val = result.backtest.df.tail(fh_val)

# model evaluation
sum_val_true = df_val['actual'].sum()
sum_val_pred = df_val['forecast'].sum()
pct_diff = (sum_val_true - sum_val_pred) / sum_val_true * 100
print(f"""
val  = {sum_val_true:,.0f}
pred = {sum_val_pred:,.0f}
pct diff = {pct_diff:,.2f}%
""")

_ = df_val.set_index(col_date)[['actual','forecast']].plot(figsize=(12,8))
_ = plt.title(f"pct diff = {pct_diff:,.2f}%")
_ = plt.show()

time_taken = time.time() - time_start_notebook
m,s = divmod(time_taken,60)
print(f'Time taken: {m:.0f} min {s:.0f} sec')

Vanilla Prophet code
# imports
import time
time_start_notebook = time.time()

import numpy as np
import pandas as pd
import matplotlib.pyplot as plt
import prophet
from prophet import Prophet

# get the data
col_date = 'BillingDate'
col_val = 'y_true'
fh_val = 90

# data
url = "https://github.com/bhishanpdl/Shared/blob/master/data/daily_0600075027.csv"
dfs = pd.read_html(url,parse_dates=[col_date])
df = dfs[0].iloc[:,1:]

print(df.shape)
print(df.head())

# prophet expects two columns: ds and y
df_prophet = pd.DataFrame({'ds': df[col_date].values, 'y': df[col_val].to_numpy()})

# train-validation split
df_train = df_prophet.iloc[:-fh_val,:]
df_val = df_prophet.iloc[-fh_val:,:]

# modelling
model = Prophet()

# fit the model
_ = model.fit(df_train);

# prediction
periods = fh_val
df_fut = model.make_future_dataframe(periods=periods)
df_pred = model.predict(df_fut)
df_fut = df_pred.iloc[-fh_val:, [0,1,-2,-1]]

# model evaluation
df_eval = pd.DataFrame({'y_true': df_val['y'].values,
                       'y_pred': df_fut['yhat'].values},
                      index=df_val['ds'].values)

sum_val_true = df_eval['y_true'].sum()
sum_val_pred = df_eval['y_pred'].sum()
pct_diff = (sum_val_true - sum_val_pred) / sum_val_true * 100
print(f"""
val  = {sum_val_true:,.0f}
pred = {sum_val_pred:,.0f}

pct diff = {pct_diff:,.2f}%
""")

df_eval.plot()

time_taken = time.time() - time_start_notebook
m,s = divmod(time_taken,60)
print(f'Time taken: {m:.0f} min {s:.0f} sec')

Hi,
The AUTO template seemed to have picked up a changepoint at the end of the training period, and hence the difference. You can visualize it by plotting the backtest via
fig = result.backtest.plot()
fig.show()

Because of the inherent volatility in your data, the SILVERKITE template should perform better. You can do that by simply replacing model_template=ModelTemplateEnum.AUTO.name by model_template=ModelTemplateEnum.SILVERKITE.name.
This reduces the percent difference to -1.53%.

For any time-series data, we advise checking the performance on multiple test sets and taking the average. For example, if you drop the last 10 days from df, then the percent error becomes -7.59%.

Thanks a lot for your feedback. I was assuming AUTO means SILVERKITE. Also, Looking at the changepoints in TEST data is not possible, but we could surely look at the cv results and see if there are any cross-validation data.
This was my very first attempt to use greykite in production and the very first dataset I compared between prophet and greykite, i was very disappointed.
I was putting the thought of using greykite on hold and move on with prophet as status quo, but now I see the potential again and am happy to give it a try.

We have multiple templates for different datasets, AUTO template tries to pick the best one. For highly volatile data such as yours, it is better to pick SILVERKITE, which builds a more complex, but robust model.
You can easily enable CV and grid-search, check this tutorial.


Don't recommend keeping nuget packages in source control

The following tip seems obsolete:
"Even if you decide to use NuGet, you should probably still add the binaries to version control so that you can reproduce and build historical versions of your code."
This seems to be an outdated recommendation. Especially when using git repos, you want to keep the repos small, as documented in https://docs.microsoft.com/en-us/nuget/consume-packages/packages-and-source-control

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6221f95f-b9c3-10d5-63d8-ba6182185dca
Version Independent ID: cee686a8-5600-3e7a-3f1e-c6cfc28ec65b
Content
Content Source
Service: unspecified

@jawn Sorry for the delay in responding to this, we just implemented a new feedback control that files customer feedback as GitHub issues (which I really like) but as a result we started off with a bit of a backlog. I've added this to our TFVC documentation backlog and I'll get this updated shortly. Thank you.

@jawn I just checked in an update to this topic, it should be live soon.


STEAMCMD: Retry update in case 0xE after update job

Feature Request
Symptoms
https://pastebin.pl/view/4201e326
Add auto update retry for the following case:
Waiting for user info...OK
Update state (0x3) reconfiguring, progress: 0.00 (0 / 0)
17:31:22
Update state (0x3) reconfiguring, progress: 0.00 (0 / 0)
17:31:24
Update state (0x61) downloading, progress: 30.72 (26785670 / 87188267)
17:31:26
Update state (0x61) downloading, progress: 85.57 (74605355 / 87188267)
Error! App '90' state is 0xE after update job.

SteamCMD games sometimes requires several UPDATEs till 0xE state is resolved.
Reproduction
Install AMP on Debian 10 machine and try to install CS 1.6 and play for first time. You will need to UPDATE the APP two times in order to run the server, this can bring a lot of confusion.

I've implemented a 'retry N times' facility on all states that don't indicate success. It's disabled by default but should accommodate this situation.


Create initial value for __theme_mode attribute in Page class.

This change resolves #1153 by initializing self.__theme_mode in the __init__ method of the Page class to avoid the AttributeError raised by the theme_mode property method on line 1205.
I've set this attribute to ThemeMode.SYSTEM as noted in the documentation for the default value of page.theme_mode

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix(client): replace react-responsive with media queries for menu

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

This is related to #35931, it specifically fixes the problem during page load on small screens. Namely that the menu briefly displays as expanded when the page is reloaded:

It touches the code for the menu button, removing the wrapping Media element, so it could affect that part of the issue.  However, that would need to be verified by someone with a Mac.
Finally, I was not sure if the nav menu should appear on the guide pages.  I opted not to display it at all, to be consistent with smaller screens and how it currently works in production.  That's part of why this is a draft PR.

Thank you for looking into this @ojeytonwilliams.
On my side, your solution does display the menu on guides as expected. (refer to the current state of .rocks reference for the full functionality)
However, the rest of the nav buttons are not displayed on larger screens on the guides

@ahmadabdolsaheb I should have checked for that, thanks for catching it!  It should look fine at all screen sizes now.  It should also behave properly when the page is reloaded, even when it has been built.
One thing that tripped me up was that the wrapPageElement appearing in gatsby-ssr and gatsby-browser wasn't quite the same, but it seems like it should be.  Is that deliberate, or would it be worth DRYing them out a little?

@ojeytonwilliams They only difference is having disableMenuButtonBehavior={true} on one.
I think both disableMenuButtonBehavior={true} and OnGuide={true} are there to accomplish the same goal. so feel free to tighten things up.
Additionally, I believe the props could be passed down from the wrapPageElement of either gatsby-ssr or gatsby-browser. So ideally we could get rid of one of them.
@ValeraS, since you have more context. what to you think of drying one of thewrapPageElements?

@ahmadabdolsaheb Good point about disableMenuButtonBehavior and onGuide.  I've simplified things a bit and removed what seems like unnecessary duplication.  Let me know if this is okay.
Finally, I added a comment about what disableMenuButtonBehaviour does, since that confused me a little the first time I looked at this.

@ojeytonwilliams thanks for the comment.
Also, the nav items don't show on large screens.

@ahmadabdolsaheb I wasn't sure if they were supposed to be there since they're inaccessible on small screens, so I erred on the side of consistency.  Anyway, thanks for clarifying - I'll fix that now.

Just to clarify, I was referring to the navigation items on the guide.

@ahmadabdolsaheb This should be a bit better, I tried to match the behaviour on rocks.  It still has a version of the bug I mentioned in #35952, but this should display correctly otherwise.
In future, I'll create some more gifs/pictures to clarify things before I get to work, as I'm terrible at describing UI changes without them!

Is there anyway I could help? @ojeytonwilliams

@ahmadabdolsaheb  I fixed the issue in #35952 with my last commit, but completely forgot to mention it - sorry about that!  And, definitely, if you have time to give this another look, that would be much appreciated.

@ojeytonwilliams for some reason non of the CI builds have triggered with any of your commits. Can you try and rebase this off of master and force push? Thanks.

@raisedadead A quick google turned up this: https://travis-ci.community/t/draft-pull-requests-not-being-built/2434/12 I guess this is related.

Thanks for sharing that topic. Although it was worth the rebase anyways 😅 ! Thanks for working on this. I will leave this for a QA and merge from the team.

Adding @ValeraS for additional review because this touched Gatsby's critical files.

@ValeraS Thanks for the review.  I tested and committed all your suggested changes, they all look good to me!
Isn't there always going to be a difference between what the server renders and what Media renders?  The problem is that the server doesn't know what size your page is, so it can't always match what Media does.
Finally, should I change the Gatsby configuration now or is it better to just fix the merge conflict later?

One possible solution would be not to render server-side parts that depend on Media.
For example:
<Media maxWidth={mediaBreakpoint} onChange={this.handleMediaChange}>
  <MenuButton />
  {displayMenu && !disableMenuButtonBehavior && <MenuLinks />}
</Media>
<Media minWidth={mediaBreakpoint + 1}>
  <MenuLinks />
</Media>

By default, media queries are resolved to false, and children are not rendered.

I tried this change, but ran into similar problems again.  Basically, whatever I do, the first client rendering makes menus appear or disappear.  It works well in development mode, but when you build it, the initial page load does not have the menus or the buttons.
For large windows it looks like this:

For smaller ones, it looks like this:

I created a branch for this, so you can see the code, without mixing it with the rest.
Also, the refactor you suggested made a lot of sense to me, so I put that in here.  I think that should be in whatever fix we end up with.

Of cause, this is how it works. On the first load, it shows static SSR page and, after load js bundle, hydrates with client-side render. After this, it works as a client app and does not use static pages from the server. So we get such behavior only on the load/reload whole page.

Yeah, I just thought it would look better if that never happened at all.

@raisedadead @ahmadabdolsaheb @ojeytonwilliams Let's do not change menu behavior on guide and use another control for side navigation. Something like this:

@ValeraS, it makes sense. we discussed this in #35249, it was differed to the next iteration due to the feature freeze. Also we have plans to move away from icons to words throughout our services.
To expand on the benefits of your suggestion:

a secondary nav for guide and  forum will become necessary as we ship our universal nav across services.
it would reduce redux wiring.
it would be less confusing to users because the same bottom does two different things on different pages at the moment.

That being said, it might be better to stick with the current functionality until we find a solution for a  secondary navigation across our services in the next iteration.
I defer the decision to @raisedadead on this.

Yes, that is correct. @ValeraS you have a valid point. But for now, we should get this in and overhaul the nav completely in the planned redesign.
If you are fine with the current change in this PR, let merge it. Thanks once again for the QA.

@ojeytonwilliams I don't like that the header contains logic specific for the guide. One more approach: we can pass a navigation block through props. And make two blocks, one for the guide and one for other layouts. But should we do it, if we plan to change the behavior of the guide?

@ValeraS I take your point that it will require a little bit more work, overall.  However, I think it's worth it to deal with these two bugs and the refactoring will make the redesign easier (or at least not harder!) to implement.
I'll take a look at it and let you know what I come up with.

@ValeraS it turned out to be far more involved and messy than I thought it would be.  I do agree that having the logic in the header is not good.  However, I've changed my mind and I now think trying to fix that creates more problems than it solves.
So, to answer your question

But should we do it, if we plan to change the behavior of the guide?

I no longer think so, but I still think it's worth fixing the two bugs for now.

@ValeraS I took at look at your changes and they seem good.  However, I thought we could go further and move the nav menu logic out of the Header and put it in gatsby-browser i.e. where the decision is actually made.  Also, could you explain why you changed from just passing menuButtonRef to using forwardRef?
Anyway, regardless, this LGTM.  Let me know if you're okay with my changes.

@ValeraS   I understand your reasoning now and I'm happy with the changes you suggested.  However, I'm about to leave and I'll be travelling for about a week. I'm not sure how much time I'll have to implement them before I get back.  If you have time to make them yourself, please do, otherwise I'll do them as soon as I can.

@ValeraS Thanks for sorting that out!


ServiceGraphBuilder

This PR adds two classes:

CoordinatedService2 which is intended to replace the existing CoordinatedService
ServiceGraphBuilder which is a builder class for Guava ServiceManagers that manage CoordinatedService2s

CoordinatedService2 adds the concept of "enhancements" in addition to the traditional downstream dependencies. Hopefully the documentation is clear as this was tricky to reason about at first!

cool stuff! What problem does it solve?

@mightyguava: cool stuff! What problem does it solve?

Jesse and I added an example of a use case in the docstring for CoordinatedService2! Hopefully its a helpful illustration of the problem :)


Crash during planning if goal is set for the second time

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
Hi,
I had a crash during planning (using simple simulator) test. I debugged it for 2 days but had no clue, I'd like to seek any help if possible.

the route with color is the first route, which is ok.
Then I changed the goal position to the next lane (as show in the picture, just one lane upward), there is a crash.

The "Auto" button is ready
don't change pose, but change goal position
-> the "Auto" button is disabled
-> there is a crash log in the terminal, as showed above.

Versions
os: ubuntu 22
ros2: humber
autoware: main branch
Possible causes
From the crash log, it seems some pointer is access but it is not valid.
The call stack is all for ros/dds, I didn't see my code. I can attach GDB to the node, but from gdb/backtrace, I don't see my code in the stack.
If I comment out  line 446 of behavior_path_planner_node.cpp
void BehaviorPathPlannerNode::run()

it will not crash but of course autoware will not enter autonomous state either.
Additional context
No response

from the same node [component_container_mt-28], the last log before crash is:
[INFO] [1706696104.509989803] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = out_of_lane, id = 0

I have added some log into behavior_path_planner_node.cpp file, the output before crash is kind of random: maybe there are many threads running but the logs are from different threads so in the terminal, it's kind of random

Thank you for reporting the issue and for the initial investigation.
It looks like you are using a custom map and I am not able to reproduce the issue on the sample map. Are you able to share your map ?
Otherwise, I can assist you in debugging the issue. First, I would recommend running the behavior_planning_container in a separate terminal (and ideally with gdb). This can be done by adding a launch-prefix in the behavior_planning.launch.xml like this:
  <node_container pkg="rclcpp_components" exec="$(var container_type)" name="behavior_planning_container" namespace="" args="" output="screen" launch-prefix="gnome-terminal -- gdb -ex run --args">

You should also make sure you build the behavior_path_planner with debug symbols:
colcon build --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo --packages-select behavior_path_planner

If you now reproduce the issue, you should be able to use gdb in the separate terminal to investigate the crash in more details.

Thanks for the comment, the crash is not related to the map, I uploaded a screenshot of the crash on the original map from autoware installation.
Screencast from 02-02-2024 06:50:49 PM.webm
In the screenshot, I modified the code just a little bit:
BehaviorPathPlannerNode::run() is a timer callback, originally it is called every 100ms, which makes it difficult to debug. So I changed the interval to 20 seconds. So in the screenshot, you can see the delay.

00:09: I set the pose
00:14: since the timer callback is set to 20 seconds, so the function of BehaviorPathPlannerNode::run() is not called right after the setting of the goal but delayed to be called at the time. The 'Auto' button is enabled. (but it's disabled again after a very shot while, which is also strange to me)
00:52 I waited for another cycle (20 seconds), then I re-set the goal
01:13 BehaviorPathPlannerNode::run() is called again, and the crash log is shown in the terminal.

I have been able to reproduce the issue with Eprosima DDS.
sudo apt install ros-humble-rmw-fastrtps-cpp
RMW_IMPLEMENTATION=rmw_fastrtps_cpp ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$MAP_PATH vehicle_model:=$VEHICLE_MODEL sensor_model:=$SENSOR_MODEL

The issue does not seem to occur when launching the behavior_path_planner as a normal node (instead of the current composable_node). I do not understand the problem but I guess there is some problem with memory access when behavior_path_planner receives a new route.
More investigation will be required and in the meantime I recommend using another DDS if you can.

launching the behavior_path_planner as a normal node (instead of the current composable_node)

Can you share how should I do this? I'm considering the same solution but don't know how to change the startup scripts/configs.

Can you share how should I do this?

Here is a commit with the change: https://github.com/maxime-clem/autoware.universe/commit/8856575fced1a571249a2e33e3481db442fa7d7d

I have been able to reproduce the issue with Eprosima DDS
there seems to be a similar issue at https://github.com/autowarefoundation/autoware.universe/issues/5221#issuecomment-1797870252, I'm not very sure if DDS is the root cause.

btw, can some one move this issue to https://github.com/autowarefoundation/autoware.universe/issues, I just realized that it should be there

@felixf4xu I do not think this issue is solved. Did you close it to move it to the universe issues ?

@maxime-clem yes I know it's not solved, but I didn't see any more actions taken, so I think it's better to close it.
I also see you linked this issue to https://github.com/autowarefoundation/autoware.universe/issues/6452 then I think it's safe to close this one.
For anyone else interested, my current workaround is using RMW_IMPLEMENTATION=rmw_cyclonedds_cpp.

@maxime-clem yes I know it's not solved, but I didn't see any more actions taken, so I think it's better to close it.
I also see you linked this issue to https://github.com/autowarefoundation/autoware.universe/issues/6452 then I think it's safe to close this one.
For anyone else interested, my current workaround is using RMW_IMPLEMENTATION=rmw_cyclonedds_cpp.

Hello，have you solved this problem? I have encountered this problem as well, but it only occurs occasionally without a specific trigger scenario. I have setted RMW_IMPLEMENTATION=rmw_cyclonedds_cpp

Here is a commit with the change: maxime-clem/autoware.universe@8856575

Can we merge this commit? I have several dev environment (different PC hardware, Ubuntu level, docker, non-docker) all have the crash issue and the workaround in the commit is the only way to fix it.

The node container is used for performance reasons so I do not think we want to merge that commit sorry.
I will try to find another solution.

@felixf4xu the issue seemed to be coming from rclcpp and rmw_fastrtps_cpp.
This looks like the same issue: https://github.com/ros2/rmw_fastrtps/issues/728
A fix PR exists for the rolling branch of rclcpp but I am not sure if it is on other branches as well :thinking:

@felixf4xu I tested with a locally build rclcpp package and could not reproduce the issue.
I was using this version: https://github.com/tier4/rclcpp/tree/t4-main
So the fix seems to be on the rclcpp side.

Great, thanks!


[5.9] Change TargetGroup enum param to packageAccess bool in target declaration

Target declaration now contains packageAccess bool param instead of enum group param
Resolves rdar://108361064

@swift-ci smoke test

main https://github.com/apple/swift-package-manager/pull/6463

@elsh please refrain from setting auto-merge on PRs. The SwiftPM team prefers to be the one merging based PRs on the time that works best for the release and other PRs in flight

did not have a chance to review the PR on "main" before it was merged, but left a few comments there. the change set may needs to be amended before taking to 5.9

Replied to the comments on https://github.com/apple/swift-package-manager/pull/6463

This PR includes https://github.com/apple/swift-package-manager/pull/6473

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test windows

@tomerd Should we not merge this PR this week? FYI the feature is still not enabled for 5.9. After the proposal is accepted, a separate PR will be created to enable it.

@elsh this be updated to include all the recent changes on the main branch

@elsh this be updated to include all the recent changes to this feature (eg default) that went on the main branch

It includes them as posted in the earlier comment.


Add fileContentsUrl option for CreateYamlFile

What's changed?
New option fileContentsUrl for the CreateYamlFile recipe to allow file contents from a URL.
The fileContents option takes precedence, if both the fileContents and fileContentsUrl has a value.
What's your motivation?
Closes #4011
Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?
No
Any additional context

Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've read and applied the recipe conventions and best practices
[x] I've used the IntelliJ IDEA auto-formatter on affected files

Having some trouble getting the tests to work; will revisit later. To get the same result locally be sure to clear out ~/.rewrite/remote/.


[FLINK-4648] Implement BipartiteGraph generator

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Hi @greghogan ,
Thank you for your review. I've update my PR accordingly.


bug setting .filename

Try as I might I can't get the new Note.filename setter to work properly. Whatever combination of folder path I append to the front of the filename, it renames to the root folder.

Nudge.
This is blocking a new release of NoteHelpers plugin.

Fix just released. Let me know if we can close it once tested.

This now works with release 828. Though the open note in the Editor gets closed in the process.

Thanks. If possible can you re-open to the same kind of window (main, split, float)?


[Core] Add new concept, EVENT

Hi SkyWalking team
I have been thinking about this concept for a long time, I am going to officially propose this concept now.
Right now, we have tracing and metrics fully supported, logging is on the way due to the browser provided and satellite is going to do more in this field. We have the typical 3 concepts, logging/tracing/metrics, in the observability.
But in the real world, it is more complex than those 3. EVENT is one of the most typical things.
System performance could be changed due to different variables, such as upgrading, rebooting, chaos testing, hosted VM overload. Some of them are detectable in some tools, such as rebooting in k8s, upgrading in CI/CD pipeline. But at the same time, they are only accessible through agent tech. We call this the event.
Event should include owner(affected instance/service/etc.) with time range(start/end). This would be easy to implement in OAP as actually, it is a new kind of record only. The major difference is, one event would include 2 records, typically, one for the start, the other for ending, linked by an UUID. Because an event could take a long time, 2 records could make the event started shows up ASAP.

gRPC/HTTP interface should be provided to report events. CLI should follow this to give a command to report events too.
GraphQL interface should be provided for UI to visualize the event.

As a special request to UI, @Fine0830

We need to add a timeline based on the selected time range, showing the event dot(if even hasn't stopped), or a bar(covering start to end timestamp). When the mouse clicks the dot or bar, all charts(if in the dashboard), should show a vertical line(or range) to highlight the metrics values at this special time points.

Who will be the owner of this feature? I’d like to take this if no one is working on it yet.

Who will be the owner of this feature? I’d like to take this if no one is working on it yet.

We don't have yet.

We don't have yet.

We don't have yet.

OK. Let me kick it off by some further discussions (later)

We don't have yet.

OK. Let me kick it off by some further discussions (later)

@BFergerson You pinged me about the similar thing, if you like, join the discussion here.

@BFergerson You pinged me about the similar thing, if you like, join the discussion here.

@wu-sheng @BFergerson I just drafted a simple doc about the event concept, please take a look at https://github.com/apache/skywalking/pull/6183

@wu-sheng @BFergerson I just drafted a simple doc about the event concept, please take a look at https://github.com/apache/skywalking/pull/6183

#6183 implements the concept in terms of protocol, storage and analysis, https://github.com/apache/skywalking-cli/pull/88 implements the reporting CLI, my next plan would be building an event exporter targeting Kubernetes. As for the (Java) agent toolkit, I don't see much sense it makes so I'll just push it into the backlog until someone asks for that or is willing to contribute

#6183 implements the concept in terms of protocol, storage and analysis, https://github.com/apache/skywalking-cli/pull/88 implements the reporting CLI, my next plan would be building an event exporter targeting Kubernetes. As for the (Java) agent toolkit, I don't see much sense it makes so I'll just push it into the backlog until someone asks for that or is willing to contribute

my next plan would be building an event exporter targeting Kubernetes

This is a good one for sure. I want to add another interesting things. We could report an booting/shutdown event in the javaagent code, by using service#boot and JVM close hook. What do you think?

As for the (Java) agent toolkit, I don't see much sense it makes so I'll just push it into the backlog until someone asks for that or is willing to contribute

Agree. Don't have idea who will need that at the codes level.
About more use cases, we could consider an event called JVM arguments changed, such as GC, Xmx. We could make CLI + shell + local file cache to determine the change, or use the instance name to find the previous arguments at the OAP side.

my next plan would be building an event exporter targeting Kubernetes

This is a good one for sure. I want to add another interesting things. We could report an booting/shutdown event in the javaagent code, by using service#boot and JVM close hook. What do you think?

As for the (Java) agent toolkit, I don't see much sense it makes so I'll just push it into the backlog until someone asks for that or is willing to contribute

Agree. Don't have idea who will need that at the codes level.
About more use cases, we could consider an event called JVM arguments changed, such as GC, Xmx. We could make CLI + shell + local file cache to determine the change, or use the instance name to find the previous arguments at the OAP side.

I want to add another interesting things. We could report an booting/shutdown event in the javaagent code, by using service#boot and JVM close hook. What do you think?

Great idea!

About more use cases, we could consider an event called JVM arguments changed, such as GC, Xmx. We could make CLI + shell + local file cache to determine the change, or use the instance name to find the previous arguments at the OAP side.

I think both have their limitations, using CLI requires the users to bind the CLI tool to their (CD) workflows manually. If we do this in OAP side, the instance names may be randomly generated, making every instance independent.

I want to add another interesting things. We could report an booting/shutdown event in the javaagent code, by using service#boot and JVM close hook. What do you think?

Great idea!

About more use cases, we could consider an event called JVM arguments changed, such as GC, Xmx. We could make CLI + shell + local file cache to determine the change, or use the instance name to find the previous arguments at the OAP side.

I think both have their limitations, using CLI requires the users to bind the CLI tool to their (CD) workflows manually. If we do this in OAP side, the instance names may be randomly generated, making every instance independent.

I think both have their limitations

All event detection will have limitation. Such as JVM close hook may not be executed, if user doesn't shut down the service elegantly.

If we do this in OAP side, the instance names may be randomly generated, making every instance independent.

Definitely yes. My point is once we detected this, we generate an event, if this is a new instance, we don't need this. The idea behind this proposal is, we need an OAP core-level API for change detection for contributors to enhance.

I think both have their limitations

All event detection will have limitation. Such as JVM close hook may not be executed, if user doesn't shut down the service elegantly.

If we do this in OAP side, the instance names may be randomly generated, making every instance independent.

Definitely yes. My point is once we detected this, we generate an event, if this is a new instance, we don't need this. The idea behind this proposal is, we need an OAP core-level API for change detection for contributors to enhance.

To summarize, to todo list includes:

[ ] UI implementations
[ ] Agent booting / shutdown events
[ ] Kubernetes event exporter
[ ] OAP internal report mechanism
[ ] Agent start up JAVA_OPTS changes events detection

OAP internal report mechanism

@kezhenxu94 Do we have this? We have internal event API?

OAP internal report mechanism

@kezhenxu94 Do we have this? We have internal event API?

We have shared event-analyzer module, so I think moduleManager.find(EventAnalyzerModule.NAME).provider().getService(EventAnalyzerService.class).analyze(Event.newBuilder().setXXX().build()) is enough for internal use, do you think we should provide dedicated APIs for this?

I am not sure whether this is enough, let's wait and see. This API will be used in the alarm module.


Zammad ticket integration

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
New Notification
🔖 Feature description
I would like to propose that through the Zammad API automated tickets can be created to inform users of crashes.
✔ Solution
When using this type of notification, what should happen is the following:

When giving an error, a monitor would have to create a ticket (with the priority previously configured in the add notification panel)
When reestablishing the connection with the monitor, the ticket should be closed automatically.

❓ Alternatives
The existing alternative is email notification.
📝 Additional Context
No response

Unsure why this has been closed, it hasn't been added as far as I can see and such an integration would be really helpful :)

I close it because you can use mail to create a ticket in zamad, its true one think : Surely it is more efficient using the api and not mail but if you want I'll open the issue again

Thats true!
Would still be neat if it's get integrated via API at some point, doesn't need to be highly prioritised tho as E-Mail still works ofc.


Make it possible for a linter to register itself via atom.services.

The goal is for clients of linter to avoid the following declaration
that they have to do today:
var Linter = require(atom.packages.getLoadedPackage('linter').path + '/lib/linter');

I don't know whether this change is a good idea, but I tested it and
it does [mostly] work. This amends package.json to declare the following
services:
  "consumedServices": {
    "linter.addLinterClass": {
      "versions": {
        "0.1.0": "addLinterClass"
      }
    }
  },
  "providedServices": {
    "linter.provideLinterClass": {
      "versions": {
        "0.1.0": "provideLinterClass"
      }
    }
  },

A client would then add the following to its package.json:
  "consumedServices": {
    "linter.provideLinterClass": {
      "versions": {
        "0.1.0": "createSubclassForLinterClass"
      }
    }
  },

which it would implement as:
'use 6to5';

module.exports = {
  createSubclassForLinterClass(linterClass) {
    class MyLinter extends linterClass {

    }
    MyLinter.prototype.cmd = 'some command';
    MyLinter.prototype.linterName = 'my-linter';
    MyLinter.prototype.regex = /some regex/;
    MyLinter.syntax = 'source.js';

    atom.services.provide(
        'linter.addLinterClass',
        '0.1.0',
        MyLinter);
  },
};

The major drawback to this scheme (other than it being weird) is
that MyLinter will be registered after the initial set of
LinterViews have been created. Therefore, messages from MyLinter
will not be shown in existing editors, but they will be shown in
any new editors that are created.
This could be worked out if this scheme were determined to be worth pursuing.
An alternative approach to avoiding the atom.packages.getLoadedPackage('linter').path
call would be to offer Linter via npm so it can be require()'d directly.
This would also make it easier for clients of linter to unit test their code.

Has there been any discussion around moving linter.coffee to npm? I concede that maintaining both an apm package and an npm package is more work, but it's probably simpler for developers (modulo version skew).
One other approach would be to favor composition over inheritance. That is, if the client provided some object that was composed by Linter rather than one that extended it, it would decouple things further.


check appending enabled for ingestion through http

Codecov Report

Merging #282 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   71.75%   71.71%   -0.05%
==========================================
  Files         166      166
  Lines       23073    23079       +6
==========================================
- Hits        16557    16551       -6
- Misses       5224     5236      +12
  Partials     1292     1292

Impacted Files
Coverage Δ

redolog/file_redolog_manager.go
73.3% <0%> (-0.72%)
:arrow_down:

redolog/composite_redolog_manager.go
85.45% <0%> (-3.23%)
:arrow_down:

redolog/kafka_redolog_manager.go
74.28% <0%> (-0.86%)
:arrow_down:

memstore/ingestion.go
81.15% <0%> (ø)
:arrow_up:

controller/mutators/etcd/schema_mutator.go
61.84% <0%> (-1.74%)
:arrow_down:

memstore/cuckoo_index.go
90.26% <0%> (-1.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a057e8...8b87b7d. Read the comment docs.


Ignore whitespace in csv files

Nothing big :) Just adds three .trims() to remove any unnecessary whitespace in the csv file when loading.
Whitespace in csvs shouldn't have meaning. Still caring the whitespace over just makes it more annoying to work with the csv data in typst.
The csv
asdlkf, asldkfjasdf
asd,     asdlkf
a   ,    asdf

will end up like this (after the change)
(
  ("asdlkf", "asldkfjasdf"),
  ("asd", "asdlkf"),
  ("a", "asdf"),
)

instead of this (before the change)
(
  ("asdlkf", " asldkfjasdf"),
  ("asd", "     asdlkf"),
  ("a   ", "    asdf"),
)

The spec https://datatracker.ietf.org/doc/html/rfc4180 explicitly says

Spaces are considered part of a field and should not be ignored.

Why not just use csv("file.csv").map(x => x.map(y => y.trim()))? This is simple enough to do in typst that it wouldn't seem to make much sense to have a separate feature for it.

I agree that this is best handled by normal scripting rather than a new parameter. Often, you'll need to do things like convert to an integer anyway and the .trim() can go right in between.

If we were to add a parameter, it would have to be spec-compliant by default in my opinion. And if it doesn't ignore spaces by default, I don't think
csv("test.csv", trim: true).map(row => row.map(e => int(e)))

is really better than
csv("test.csv").map(row => row.map(e => int(e.trim())))

It's actually longer.

it would have to be spec-compliant by default in my opinion

I am curious. Why?

it would have to be spec-compliant by default in my opinion

I am curious. Why?

Isn't that fairly evident? The point is to have a common standard that people can rely on functioning (almost) the same wherever they use it.
While the csv spec isn't official, per se, it's still a good idea to follow it by default.

Deviating from the spec in the name of convenience is why CSV data is the wild is so wildly irregular and often incompatible. Sticking to the spec is by far the best approach. There are lots of tools to normalize input data from weird unquoted, unescaped, over spaced, or whatever other issues to something that is spec compliant. Use one of those tools and then use clean spec compliant data. Don't make even more of a mess by adding one more app that doesn't follow the spec by default and hence creates more unexpected edge cases.

Isn't that fairly evident?

It really isn't to me. That any software has to support the official spec is out of question. Whenever designing software I just always ask myself "What design choice/default makes the software the most enjoyable to use for the majority of people?". In this case the answer seems so clear to me. That's why I am wondering what other guiding principle leads you to value the spec so highly as the default. Isn't the goal to make a tool that makes as many people happy as possible? The contributing guide says "The core question is "Does this help to make Typst the prime technical typesetting app?"" I think anything that makes Typst more enjoyable to use for most of the users does help make it the prime technical typesetting app.
But yeah this question is obviously out of the scope of this PR. We can talk about this further on Discord. It's not the first time that this came up with me ^^ Since you are all against this change I will close this PR. (We can still continue talking here though if we don't want to switch to Discord)


Broken layout on Firefox 40.0

Hi fellows,
I have been trying to set up django-cms==3.1.2 for an existing project, and almost everything went smoothly. I just added one plugin to my project: djangocms-text-ckeditor. I'm very happy with the way django-cms is going. The only one detail I found is that the rich text editor (that comes from djangocms-text-ckeditor) does not show up properly on the version of Firefox (40.0) I'm using, when trying to add content to me pages through the placeholders I have defined. The layout is broken. It works like a charm on Chrome though. I just wanted to let know to the community, so that perhaps someone has a solution already for this. If I find time I will try to fix that myself, but I wanted to share my experiences here :). I know it is not a big issue, we can live with that ;), but the goal is to be closer of the perfection, isn't it? Thanks in advance.
Best regards,
Vladir.

@vladir cannot reproduce this. Could you provide some details on how to reproduce it and some screenshots?

Thanks for your quick response @yakky , you are totally right, it seems as it was something I had wrong on my configuration. Our front-end developer confirmed that everything was ok. I'm going to mark this as invalid. Thanks a lot again for your time.

Thanks for the update


run-operation exited with success on a connection error

Issue Description
On a dbt run-operation command in Cloud:
2019-04-12 16:40:04,489 (MainThread): Got an error when attempting to open a snowflake connection: '250001 (08001): None: Failed to connect to DB: XXX.snowflakecomputing.com:443. Incorrect username or password was specified.'

Despite the error, the exit status of the command was 0 and the run step was marked as successful.
System information
Executed in Cloud on dbt 0.13.0

This looks like a duplicate of #1377 - right?

AH you're so right -- closing


Hangs when deleting mod and not keep config

Version 0.90, no game detected

Reset config of a mod.
Delete the mod, say yes to delete all.
Freeze.

Fixed in release 1.0.


Split the app in a participant and admin app

** Breaking change for surveys **
This is a  big PR, which solves 3 issues: #51, #78 and #79. Each individual commit is standalone, but they break the application's functionalities until they are all there, so there are part of a single PR.

It uses the participants table to link to the interviews instead of the users table (current users with interviews are copied to the participant table so current survey apps still work)
There's a separate participant authentication model, which can use the same authentication methods as the user model, but uses the participants table instead of the users
A participant app has a login page that uses the participant authentication model and can only display the participant's interview. It has no other rights.
An admin app has a login page using the users authentication model. Users do not have an interview, their default home page displays their allowed pages.

When this PR is merged, all current surveys will need to be updated to use the latest evolution. See instructions in the individual commits for how to update

This probably need a big update to the README of the app. Just having the configuration information in the commit message is not enough.

@greenscientist you're right about the readme, totally forgot about it!
As for the participant table, all those fields are for the login support of various methods (facebook, google, local login, anonymous, with confirmation, reset password, etc), mostly copy of the users table minus the user specific fields (is_admin, preferences, etc). Actually, the participant table is a side table for the sv_interviews.

@greenscientist just added the README

I'll merge so it can be used by projects right away. If anything is not clear or not completely working, we can fix later.


Slow intelligent Vscode when install @mui/icons-material v6

Steps to reproduce
Steps:

Install @mui/icons-material
Try importing suggestions for anything in your project, but it takes 3-4 seconds to get the result.

Current behavior
https://github.com/user-attachments/assets/33db8009-af50-416a-856a-56ea6f062985
Expected behavior
Expected suggestion faster
https://github.com/user-attachments/assets/9b9c063e-7f27-46df-946d-09c9b9b96128
Context
Packages and configs:
package.json

tsconfig.app.json

tsconfig.node.json

Search keywords: Slow intelligent Vscode

Hey! Thanks for the report.
@Janpot any ideas on how we might improve this?

No concrete ones. we've been trying some profiling in the past but not much came out of it in the limited time we've spent on it. to state the obvious, I guess it'll all come down to simplifying the types, and figuring out what that means exactly in the first place.

I tried downgrading to v5, and the IntelliSense in VSCode started working normally again. This isn't a fix, but just a way to quickly continue working on the project.

can you try with a low v6 version? v6.0.2 or so?

can you try with a low v6 version? v6.0.2 or so?

I tried installing several versions of v6, including v6.0.2, but none of them resolved the issue.


Crashes after a few minutes of using as of today

Type: Bug
No steps to reproduce. Just having it installed crashes.
Extension version: 0.12.2024012401
VS Code version: Code - Insiders 1.86.0-insider (1091f68d834974d78cd4f9769034b4ae4581ff2a, 2024-01-24T05:35:58.929Z)
OS version: Linux x64 6.7.1-arch1-1
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 4299)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 2

Memory (System)
125.73GB (115.47GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id 82ac9485-e2d2-4cad-988f-73e4fa79c21a

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:30784851
c4g48928:30535728
2i9eh265:30646982
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
b5d27386:30943795
fegfb526:30945144
bg6jg535:30946824

Hi @ryandward ,
Can you reproduce this issue with the latest vscode insiders and Copilot Chat pre-release versions?
If yes, please provide logs from the output panel for Copilot Chat and developer console (invoke the vscode command "Developer: Toggle Developer Tools" to open dev console)
Output panel:

It actually was quite intermittent, after 4-5 days and an update or two, it seems to have stopped altogether now.
For reference, the complete freezing behavior frequently occurred even when there was no document being edited, with no repo open, and only this extension loaded.
Not sure why VS code became so sluggish, even when system available resources over 100 gb and virtually no processing load.
Thanks for checking in.

Hi, Copilot makes VS Code crash minutes after the startup

VSCode is very slow and crashes every time.
My system :

RAM 16GB
Version: 1.86.0 (user setup)
Commit: 05047486b6df5eb8d44b2ecd70ea3bdf775fd937
Date: 2024-01-31T10:28:19.990Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
Copilot: V1.156.0
More Info
Published
2021-06-29, 16:26:17
Last released
2024-02-06, 02:36:09
Last updated
2024-01-31, 13:44:52
Identifier
github.copilot
@ulugbekna  What do you mean by "latest vscode insiders" ? How can I switch to pre-release ?


Invalid Security Handling in CashBuyingPowerModel

Expected Behavior
If CashBuyingPowerModel finds an invalid security, throw an exception.
Actual Behavior
If CashBuyingPowerModel finds an invalid security, throw an exception, the order is invalid and we don't know why:
Order Error: id: 1, Error executing margin models: Object reference not set to an instance of an object.
In the syslog, we can read:
2024-06-14T20:53:43.6886306Z ERROR:: BrokerageTransactionHandler.HandleSubmitOrderRequest():  System.NullReferenceException: Object reference not set to an instance of an object.
   at QuantConnect.Securities.CashBuyingPowerModel.GetOpenOrdersReservedQuantity(SecurityPortfolioManager portfolio, Security security, Order order) in /Common/Securities/CashBuyingPowerModel.cs:line 416

It happens because the BaseCurrency of one of the securities is null. For example if the algorithm adds BTGUSDT crypto future:
self.add_crypto_future("BTGUSDT")

it's not in our database, so the base currency is null.
Potential Solution
When we create a CryptoFuture object, we should throw an exception if the baseCurrency parameter is null (CryptoFuture.cs#L76)
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues
[x] I have provided detailed steps to reproduce the issue

Potential Solution

I think generically, when we create a security in the SecurityService which required base currency and it's null, we should throw a nice exception


[Testing, do not review]Change on credscan template

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API changes have been detected in com.azure:azure-sdk-template. You can review API changes here
API changes
-     public class Hello {
-         public Hello()
-         public final String getMessage()
+     public class GitChange {
+         public GitChange()
+         public final String getMessage()


Using CPU limit with share influence under load (limits.cpu.allowance & priority & cgroup shares)

Required information

Distribution: independent
LXD version: branch master (currently commit sha ed9782036ed847a0306bf6873bf8f96cf1786204)

Issue description: Feature request
Currently it's not possible to use a hard cpu time limit (currently limits.cpu.allowance with _ms/_ms notation, which basically sets cgroup cpu quota and period) with a cpu time sharing indicator under load (currently limits.cpu.allowance with _%, which sets cgroup cpu shares) because it's the same field. The way how it's currently implemented: If you use the hard cpu time limit, the average cpu time you get under heavy load is basically around a 1/th of all available cpu assuming all containers are using cpu. I'd like to influence that a container can have more or less of that share under load than others. The knob limits.cpu.priority only sets the cgroup cpu shares up to 10 shares less, which is very marginal with the default cpu share of 1024 (sounds like it influences around 1% at max). Side note: Is limits.cpu.priority in any case impactful?
I would like to use limits.cpu.allowance with the cpu time limit notation, and some additional field to greatly influence the cgroup cpu shares (also setting it above 1024).
Suggestion
I assume it's wished to not having exactly the raw field value, so:

changing the limits.cpu.priority to another format (would be an API change - and I don't know if that knob changes somewhere anything else)
introduce another field name, E.g. weight or share_weight or priority_weight), which allows us to set a percentage value which can go above 100%. 100% = 1024, 200% = 2048, and so on. But I kinda also don't like the percentage suggestion.

At least, I'd like to set something like, this container has a share 1.4 times bigger than that other container which has the default 1. And the third container only 0.5 times the share - and so on. So, some dotted relative weightings at least.

Looks like this request missed 4.0, any plans when at least some sort of decision will be made on that? I understand with support of VM's the scope got probably a bit more complex.


[Power Lora Loader] Add context menu option to fetch all Civitai data

Why?
I don't like having to open the info dialog and fetch each time.
Notes
I could also expose a "Force" option, but that feels like it might be too much.
Do you think this should go under the rgthree submenu?

Oh, the other function I'd like to add is "Fix LoRA locations"

I have the commit to add that functionality ready here: https://github.com/DrJKL/rgthree-comfy/commit/1da2c175dabe3b0ee6f2a0b413495b584bfb5903


Squash Commits in Master

what do we need to approve here?

Just wanted to let you know that I squashed small commits as you suggested, also I protected the master branch as suggested by the walkthrough and wasn't sure if I should push anything to master without approval.