Scale down does not delete the node from the backend - DO

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Deploy an RKE cluster - etcd/control plane - 3 nodes and 2 worker nodes pools wit 2/3 nodes
"Scale Down" on a  worker node in a nodepool.
The nodes get removed from the Rancher UI
But it does not get deleted from the backend in DO console

Note:
Hit this issue once and was not able to reproduce this
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5.6
Installation option (single install/HA): Single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): DO RKE
Kubernetes version (use kubectl version):

1.20 (Any)

@sowmyav27 tested this with all the fixes going into 2.5.8 including the fixes coming for https://github.com/rancher/rancher/issues/31507 and this scenario worked in my environment. I'm going to get everything merged in and this to test as it should be solved. if you see this again please leave the environment up and let me investigate. (note, leaving same message on the other DO nodepool ticket)

On 2.5.8-rc4 and master-head - commit id: 1c3629

Tried the steps as mentioned in the original issue's description
Was not able to reproduce this issue.

Closing this. If this issue is seen, will open a new one.


Should react/no-did-mount-set-state trigger on ES7 async componentDidMount?

The rule react/no-did-mount-set-state triggers error on async componentDidMount function for a deferred setState. Basically, this.setState() is being called here after an async operation has been completed. It is not re-rendering straight after mounting, but only after some data has been retrieved from a server. Does it make sense to error on this?
async componentDidMount() {
    try {
      await someAsyncOperation();
    } catch (e) {
      this.setState({errorMessage: 'Failed to load data!'});
    }
  }

Duplicate of/related to #56

I agree it is related, but the fix for #56 at https://github.com/yannickcr/eslint-plugin-react/commit/70fef7194783c1603f2b7d89e698647706aab658 will not cover the async await case. Could a similar logic be added to any calls to setState after an await within the componentDidMount body?

Yes, that seems reasonable.

I believe that unfortunately, we can't be sure that a given statement is after an await statement:
async componentDidMount() {
    try {
      if (condition) {
        await someAsyncOperation();
      }
      this.setState({ ... }); // here
    } catch (e) {
      this.setState({ ... });
    }
  }

Depending on the condition, the line marked // here can be executed synchronously or asynchronously.
We can verify this by executing this snippet:
async function f(condition) {
    if (condition) {
      await 1;
    }
    console.log("after condition");
}
// will log "after call", then "after condition", proving that the execution was asynchronous
f(true);
console.log("after call");

// will log "after condition", then "after call", proving that the execution was synchronous
f(false);
console.log("after call");

No, the spec for await means that the line after the await will be async no matter what is returned.

I haven't written anything about a "returned" value. I'm not saying that await somethingSync() is synchronous.
I'm talking about a not executed await expression. Note that the await line is in an if statement.
I was surprised by the results, I was expecting an async execution even if the await line isn't executed.
Please run my example in the Chrome console and see for yourself.

ahh, i see what you mean. sure, async functions execute synchronously until the first await, and if that code path isn't traversed, it will remain sync.

Exactly. Because of that we can't always statically determine if a setState() is called asynchronously or not. I don't see how we could implement the suggested rule except for the simple cases (e.g. a setState immediately after an await).

You're right; we'd have to treat a setState as sync unless all possible code paths included at least one await.

What about an option to never trigger when componentDidMount is async ?
It lets the user shoot himself in the foot but less so than turning off the rule altogether

I would also like such an option. When componentDidMount is async it's rarely the case that the user would try to do a setState before having waited for some promise

Rarely isn’t the same as never; it’s better to overwarn than underwarn here imo.

@ljharb not saying to make it a default, just an option to opt-out for overwarn

I’d prefer to fix the default so it properly warns.

@ljharb any news on this? Can I help? What do you mean with

I’d prefer to fix the default so it properly warns.

@ljharb?
Can we use setState in an async componentDidMount() after an await something()?

There's no news; this issue is still awaiting a PR.


Updated: registry-finder 2.43.0

${}

4717c49a-aece-4689-b56a-290a71371eef

Newer version of registry-finder (2.44.0) is now available in master. 13eb244ac0cf3bf3f4e8d0676c25cd8fda8b48e9


release 0.1.0 test

This will happen after all other steps.
Initially we should release to pypi test so we can iterate.  Then release to pypi prod once confident.
Blocks #6

0.1.0 has been manually released.  Testing the new release process will be done as part of #5.


Custom View for Spinner

Is your feature request related to a problem?
There's no option to set a custom view for the spinner.
Describe the solution you'd like:
PowerSpinnerView should be extending ConstraintLayout (or an other ViewGroup) instead of AppCompatTextView. That way it have the same view as the adapter below.
Describe alternatives you've considered:
As a workaround I placed a fake view above the spinner.

Hi, I don't understand the meaning of the custom view for the spinner.
You can change the spinner's drawable using this attribute.
spinner_arrow_drawable

Custom view for spinner meaning that you need you to add some listeners or something on the spinner?

This is a custom view. Although not clearly visible, there are three TextViews and an ImageView. When you select an item, the selected view inside of the closed spinner has also the same layout as the ones in the dropdown menu. I think this option isn't available in the library.

Gotcha. You can implement it using the custom adapter.
Also, you can check an example for the custom adapter.

That's what I did! What you see in the GIF is my implementation of the custom adapter and it works great.
But... you don't have the option to have anything other than a String displayed after the selection is done.
In the example this this.spinnerView.notifyItemSelected(index, item.text) passes the String to the spinnerView to be displayed, correct?
Is it possible to have a spinnerView with a custom inner layout?

Sorry for the late response. You can implement your own item layout, and custom notification functions in your custom adapter.  If you have further problems, please let me know. Thank you!


KDE PIM Applications

Motivation
This adds the KDE PIM applications suite to Nixpkgs.
Checklist

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

All credit here goes to @vandenoever; the only thing I actually contributed to this work is some housekeeping and finding one or two patches from upstream.

I am currently debugging a bad rebase. (Oops!)
The update to KDE Frameworks 5.34 and Applications 17.04.2 also introduced non-trivial changes in the dependencies of certain packages, so I have to debug that also.

Please let me know when rebase is done so I can test. I assume this should be tested on NixOS unstable.

@vandenoever This is ready for testing now. I am running it without any ill effects.

akonadi fails to build:
CMake Error at /nix/store/5dh82kd6qppsap7b12llcbp6w4d2i6a9-cmake-3.8.2/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find SharedMimeInfo (missing: UPDATE_MIME_DATABASE_EXECUTABLE)
  (Required is at least version "0.20")
Call Stack (most recent call first):
  /nix/store/5dh82kd6qppsap7b12llcbp6w4d2i6a9-cmake-3.8.2/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE)
  /nix/store/yk2v9qp15989i9pnb7bmik9y3fbly8kk-extra-cmake-modules-5.34.0/share/ECM/find-modules/FindSharedMimeInfo.cmake:74 (find_package_handle_standard_args)
  CMakeLists.txt:108 (find_package)

That's weird, because it's running for me... I had that error earlier due to the bad rebase, but I fixed it... I don't know what's going on, so I'm going to close this pull request and try again.

For what it's worth, i was using your unadulterated branch with the unstable nixos channel.


How to call actions right after each other

Hello
I have a problem that I cannot figure out how to tackle that with react-readux
I have an app which constantly produce some logs (from beacon device) and store them in state (consider 2 logs/second). Then I need to send this logs sequentially to server api and remove them from the state.
Since calling api might take times I cannot call them in loop, because I need the first api call be done and call for the next row then (the second call needs some information from the first call)
Right now I have the logs ready to send in store, but I cannot figure out how to process them.

Please ask the usage questions on StackOverflow.
We use the issue tracker for bug and feature requests only.
Thanks!

OK, this is the link for my question http://stackoverflow.com/questions/37350783/how-to-call-actions-right-after-each-other-in-react-redux


Contributor page added

issue #48
i have added the contributor section to the page

@Jagroop2001 plz check


Support byteswap

I am trying to add Dask support to astropy.io.fits and because it's such a lovely file format FITS is big endian on disk, so before I can .store() the data to the file I need to byteswap the array.
What I have currently done which seems to work is:
        @delayed
        def _byteswap(arr):
            return np.array(arr).byteswap(True).newbyteorder("S")

        return dask.array.from_delayed(_byteswap(array), shape=array.shape,
                                       dtype=array.dtype.newbyteorder("S"))

which appears to work but is somewhat weird.
I was wondering what would be involved in adding .byteswap to Array this seems to suggest it wouldn't be that hard, but I wouldn't know where to start.

@Cadair it looks like this is an embarassingly parallel operation, in which case, your current workaround might be faster as ...
out = x.map_blocks(np.ndarray.byteswap, True).map_blocks(np.ndarray.newbyteorder, "S")

Or, if you wanted to keep things numpy agnostic, maybe swap out np.ndarray for M as follows
from dask.utils import M

out = x.map_blocks(M.byteswap, True).map_blocks(M.newbyteorder, "S")

See https://docs.dask.org/en/latest/best-practices.html#learn-techniques-for-customization
If it is this simple then this would probably make a fine contribution to the dask array module.  You might search for similarly simple methoods, like clip to see examples of what needs to be touched.

Thanks @mrocklin
I swapped out my implementation with what you suggested, and it didn't work right away. I haven't looked into it any more though, will try and debug later.

How are things going here @Cadair? Anything we can help with?


Add e2e/snapshot tests

Add nightwatch, chromedriver, etc and set up some E2E tests with the github workflow

replaced with #140


*** NoMethodError Exception: undefined method `set_attribute_was' for

rails: 6.0.0.rc1
set_attribute_was method has been removed from ActiveModel. Now previous changes are being tracked by ActiveModel::AttributeMutationTracker, I think.
Anyways, I just commented the set_attribute_was in a forked branch to make it work. This might have some consequences not sure how severe.
Do you want me to raise that request? or do you have any other suggestion as to How to handle this?
Please let me know, I'll be glad to help out.

tried to understand how to recreate the old behavior with the new mutation tracker .... so far no luck :(
when the line in question is removed you won't see the actual change when using changes on the dirty object, it will always assume that the original value is nil

From what I could gather they have changed the implementation of changes.
See:
https://github.com/rails/rails/blob/5-2-stable/activemodel/lib/active_model/dirty.rb#L234
and
https://github.com/rails/rails/blob/6-0-stable/activemodel/lib/active_model/dirty.rb#L217

#set_attribute_was was removed in this PR https://github.com/rails/rails/pull/35933/files

Are there plans to fix this?

Any updates on this?
I can attach tags to different models but the tag_list always appear to be nil.
When I do @model.tag_list , I can see the tags!
Thanks ❤

I tested and found https://github.com/mbleigh/acts-as-taggable-on/pull/968 solved this issue!


Remove ui-component dependency from application

Fixes #785

Moves the error handling ui to ui-components
Updates RequestHandler to return rejected Promises instead of the error dialog
Updates Service classes to pass error handling onto the callee (not use await)
Renames FrontendServices to MetadataService

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

This is an alternate implementation to #1088 based on discussions with @lresende
I've marked this WIP because I was unable to test the error case where the Elyra api endpoint can't be found due to running into a new bug.
I'll take another look at said bug when I get back on Tuesday, but @kevin-bates if you are able to look at it a bit, when I ran jupyter serverextension disable elyra to disable the server extension for testing it is correctly listed as disabled, but when I run lab the elyra api is still available (ie the server extension is running). This seems like it may be similar to the same issue with front end extensions I found in https://github.com/jupyterlab/jupyterlab/issues/9234

build dep chart for ref

@kevin-bates pointed out that for server extensions the command for disabling is different, so I was able to test the 404 case and this is now ready for general review.
I also opened https://github.com/elyra-ai/elyra/pull/1127 to display server extensions properly to avoid future confusion

@lresende I made the changes you recommended, there's still some Dialog related code there, but that will be removed in my work for https://github.com/elyra-ai/elyra/issues/1091 once I finish that (I have a local wip that I'm working on)

@lresende I believe I've address all your previous review comments


Download error

Whenever I try to download a file, it says "expected whitespace to end one argument, but found trailing data.". For example, "https://etc" will be red, but when removing all the non-letter characters it will be blue. My server is spigot.

I found the answer, had to put the link in quotation marks.


Xamarin: MDProgress linear type showing both linear and circular

Hi everyone! Thank you for this awesome library / binding for Xamarin.
I'm trying to add a MDProgress programatically but I can't find a way to display just a linear one. I'm using the following config:
var indeterminateProgress = new MDProgress();
indeterminateProgress.ProgressStyle = MDProgressStyle.Linear;
indeterminateProgressProgressType = MDProgressType.Indeterminate;

View.AddSubview(indeterminateProgress);

//
... constraints here
//

The expected behavior would be to have a linear indeterminate progress, but the current result is a linear and a circular progress both showing in the screen.

Hi, I've been struggling with this too and can't get to display just a linear one.

Hi, try this fix https://github.com/fpt-software/Material-Controls-For-iOS/pull/139

Since I'm having the issue with the Xamarin Binding version of the library, I would need a compiled version of the code and then make the binding compile again. I will do it this asap and come back with an answer. Thanks!

Hi @progress44 I'm not really able to test your fix. I am a Xamarin developer, would it be possible to ask you to update the .a file? After that I can test / modify the Xamarin binding project.

Hi @nmilcoff, this is the library file with the fix.
https://github.com/caffeinalab/ti.material/blob/master/iphone/libMaterialControls.a
Let me know

Thank you @progress44! I updated the lib and the issue is gone 💯


move to multi-model pipeline

The benchmark shows the performances between two selected version are pretty close.
selected version: 16.5.11 (single-model AutoML) && 16.5.17 ( multi-model AutoML + multi-model pipeline)
failure ratio (1m1c)

failure ratio (10m1c)

metric (1m1c classification)

metric (10m1c classification)

metric (1m1c regression)
link to visualize board
https://dataexplorer.azure.com/dashboards/fbc94028-62b1-4f32-a1a8-3875d54c7a75?_constraint=1m1c&_frameworks=MLNet_16.5.11&_frameworks=MLNet_16.5.17#5a03b7a5-561f-4828-a2fe-32cb09240997


[quick_actions] Android support only calling initialize once

Fixes flutter/flutter#87259
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Adding @blasten to review the Android intent flow aspect of this.

Thanks for the reviews! 😄 Responded to the comments.

Per @bparrishMines 's suggestions in a separate discussion, added unit tests for the new functionality


TypeScript Declaration Publishing

See TypeScript Declaration Publishing
Right now VS Code doesn't automatically load bundled TypeScript definitions. Either two of the options from the link above should solve the problem.
I've only checked adding types: "./dist/common.d.ts" property to package.json and it kind of worked (but still throwing errors about tough-cookie).

Please search existing issues before opening a new one. I know how it all works, I'm stuck with a lack of TypeScript supporting what I need to make it work. See https://github.com/Microsoft/types-publisher/issues/4 and https://github.com/Microsoft/TypeScript/issues/7753, with duplicate issues being https://github.com/blakeembrey/popsicle/issues/89, https://github.com/blakeembrey/popsicle/issues/88 and  https://github.com/blakeembrey/popsicle/pull/77.

Sorry, my bad, should have looked into closed issues first. Went with typings after all.

Sorry for the pain, I know it's annoying! I wish I could replace Typings today too, but I need to get all the dependencies into DefinitelyTyped and even then, I can't support browser module resolution in case anyone is using popsicle in browsers.


CORE-17766: config redaction on arrays

Arrange to replace secrets in arrays as well as objects, by pulling out the logic.
Supplement the SmartConfig implementation to implement config lists.
Add some tests.
(cherry picked from commit 1777fc50a96f64b2f027c552048a25de3d7e4c67)

This cherry-picks the fix and brings a small required change in SoftCryptoServiceProvider. LGTM.


Re-use buffer or hide other buffers for results

This is possible by modifying the function call for InsertResultsToNewBuffer to be
function! InsertResultsToNewBuffer(local_filetype, query_results)

    let window_for_buffer = bufwinnr('^_sqhell_$')

    if window_for_buffer >= 0
        buffers window_for_buffer
        normal ggdG
        put =a:query_results
    else
        new _sqhell_ | put =a:query_results
    endif

    setlocal buftype=nofile
    setlocal bufhidden=hide
    setlocal noswapfile
    execute 'setlocal filetype=' . a:local_filetype
endfunction

However, the drawback is that once we navigate to our new buffer, we can't jump back to the old one (with ctrl-o).
Figure this out...

Hanged my mind on this, I quite like multiple buffers being open. If there's demand for this we can revisit


ANIMATION CLIP CONTROLLER

Random rest positions (loop and clip auto change)
Movement to stopped and vice versa transitions (from rest to connection point, loop, and connection point to rest)

https://github.com/Selinux24/GamePlay

Going on 10ee64170cfeed079fa2ad5d904f4f4d74f51de5

Work done! (mostly)
e221c0ad1937bf6de2d51b051dd7eaed6b5fa278


gsim: generate cpp extmodule functions

When using GSIM for simulation, we will use generated cpp function to replace extern verilog modules.
This change support generating cppExtFuncs with dependent header, including dpic wrappers and extern module funcs, such as xxHelper.
Note we rename extern module name from DifftestXX to DiffExtXX to avoid extern func name conflicts with stuct. Also, we add uint16_t and shortint support to DPIC args.

Logic in LogPerfHelper wait for gsim fix chisel annotation and save donTouch top signals.

Sequential Logic seems still not supported in externModule cpp-funcs of GSIM. Need further effort.


Issue with POST example,

Hi,
The line server.resource["^/string$"]["POST"] from the http_examples.cpp does not seem to match for me using std::regex.
I am using curl to send a POST request like this: curl --form<EMAIL_ADDRESS>http://<IP_ADDRESS>/string
My gcc version: 4.8.1 and i am cross compiling for ARM.
regards,
Fabian Büttner

Does it work in another environment? With a more recent GCC?
As you might know, there is no support for std::regex in 4.8.x but Simple-Web-Server is using boost::regex if GCC's version is lower than 4.9.
Could you check whether the command line when compiling contains -DUSE_BOOST_REGEX?
How do you do the cross-compilation? With CMAKE_TOOLCHAIN_FILE?

I haven't tried it with a newer version of GCC, yet.
No, i didn't know that std::regex is not supported by gcc 4.8.x.
I just found out that the compiler is checked in the CMakeLists.txt.
I am using my custom CMakeLists.txt and copied server_http.hpp into my directory and wanted to try out one of your examples in my code base. That's the reason why i am compiling without -DUSE_BOOST_REGEX.
Yes i am using CMAKE_TOOLCHAIN_FILE.

Well, to have regex work with gcc 4.8 you have to use boost::regex and enable it with defining USE_BOOST_REGEX for files which include server_http.hpp.

Thank you for your support!
I find it strange that i can compile the source although the compiler does not support std::regex.
This issue can be closed then.

Does it work with the flag set?
For a discussion regarding std::regex and gcc 4.8 read the comment on the StackOverflow Answer

Unfortunately, I currently don't have boost::regex compiled for my target platform that's why i made a workaround like this: server.resource["/string"]["POST"]
Thanks for the interesting link. At the moment, my workaround is good enough.

@pboettch It works with the flag set. Thanks.


Writing into the import memory of a wasm module

Summary
Is it currently possible to access and write into the import memory of a wasm module?
Additional details
I would like to run a wasm module which exports a function that reads from the import memory (env.memory). Is this supported currently? If yes it would be good to see an example or a test.

I noticed issue #46 is related. I'm trying to call a function that takes a C char* argument.


Import of types nested 2+ levels deep fail to be found when loading schema

Describe the bug
When types are utilized in a "nesting" structure (see sandbox/pasted schema below) 2 or more levels deep, graphql-codegen fails when loading the schema with an Unknown type error.  If the nesting is only 1 level deep (i.e.you change the type of aList below to be a list of Strings instead of a list of the nestedB type), it successfully generates the .ts file.
NOTE that this specifically only happens when the nested types are imported from another file.  If, in the sandbox reproduction, you copy everything out of user.graphql, paste it into schema.graphql, and remove the import in schema.graphql, it works.  However, I'm working on a fairly large/complex project, and so the ability to decompose into multiple component files is key.
If I'm missing something obvious, please let me know!
To Reproduce
https://codesandbox.io/s/unknown-type-error-with-2-levels-of-nesting-keqok

My GraphQL schema:

schema.graphql
# import User from 'types/user.graphql'

type Query {
    user(id: ID!): User!
}

user.graphql
type User {
    id: ID!
    username: String!
    email: String!
    nestedFields: [nestedA]
}

type nestedA {
  aList: [nestedB]
}

type nestedB {
  aField: String
}

My GraphQL operations:
N/A

My codegen.yml config file:

schema: schema.graphql
documents: document.graphql
generates:
  types.ts:
    plugins:
      - typescript
      - typescript-operations

Expected behavior
Same behavior is expected when the types are declared in another file vs. in the main schema.graphql file (in other words, the .ts file is generated successfully).
Environment:

OS: Ubuntu 18.04.4
"@graphql-codegen/cli": "^1.15.3",
"@graphql-codegen/schema-ast": "^1.15.3",
"@graphql-codegen/typescript": "^1.15.3",
NodeJS: 12.x

Hi @melissag ! Thank you for reporting this. It seems like another issue related to graphql-import.
@ardatan can you please take a look?

Any update you can share on this issue?  This is blocking the upgrade of my team's codegen dependencies.

@melissag You can use glob patterns like **/*.graphql by disabling import for now if it is urgent.

@ardatan I don't think I follow.  For one, I'm not seeingnoGraphQLImport as an available option: https://graphql-code-generator.com/docs/getting-started/codegen-config; but beyond that, I can't see how disabling import is a tenable option for us.  As called out in the original description, we need the ability to decompose into multiple component files.  But, perhaps I'm missing something in your suggestion?

Sorry for the confusion @melissag. The option is actually named skipGraphQLImport. It's an option that's passed down to the underlying graphql-tools library so it's not explicitly called out in the generated documentation. We should definitely make sure we mention it somewhere though. Here's an example usage
schema: ./**/*.graphql
generates:
  types.ts:
    plugins:
      - typescript
      - typescript-operations
    config:
      skipGraphQLImport: true

With skipGraphQLImport set to false, codegen supports the #import syntax and is supposed to merge all the imported definitions into a single document. This means you should be able to set the schema property in your codegen.yml to just one "root" file (i.e. schema.graphql) and use #import to merge additional files.
However, codegen also supports using a glob pattern for specifying the relevant schema files. So instead of schema.graphql, we can specify something like **/*.graphql. This makes #import mostly obsolete. You can just specify a glob pattern that will match all the relevant .graphql files and codegen will combine them just like they'd be combined if you used #import.
Note that you can use a glob (and skipGraphQLImport) with codegen while still relying on #import if you so choose. However, you could also use the same glob for loading your schema as well by using loadSchema or loadTypedefs from graphql-tools (which is what codegen uses under the hood).
Ideally, #import would just work and you wouldn't need any workarounds. We'll investigate the issue on the graphql-tools side of things but hopefully the above workaround can get you unblocked.

Thanks so much for this detailed response @danielrearden!
While I haven't yet been able to get the glob + skipGraphQLImport pattern to work, I understand the approach now and believe that it's the complex dependency graph in our project that's causing it to fail, since the order in which the .graphql files must be combined is very specific (at least, it is with the way they are defined today).  I'll keep playing with this and see if I can't get it to work, but I have to shift priorities for the immediate future and just wanted to make sure to respond to this.  Thanks again!

I have the same problem and the suggested workaround does not work. Could we get this fixed soon?

@willpomac Did you try to use glob expressions with skipGraphQLImport?

Yeah I tried --- doesn't work --- see attached images for my codegen.yaml config and also the schema file which has the issue. The Step type is not visible at all it seems to the CreditCard type

so the problem it appears to be related to @graphql-tools/load and or @graphql-tools/graphql-file-loader.
So spent more time debugging this this time, and even without codegen, graphql loaders break with the nesting....for me anyway, it is not a code gen issue.
Ideally what I want is this:
type StepUp {
    type: String!
    mandatory: Boolean!
    url: String!
    sessionId: ID!
}

type PaymentInstruments {
    creditCards: [CreditCard!]!
}

type CreditCard {
    paymentInstrumentId: ID!
    paymentToken: String!
    expiryMonth: String!
    cardSuffix: String!
    scheme: String!
    stepUp: StepUp
}

but that doesn't work (StepUp is seen as an unknown type).
so then I did this ugly workaround:
type StepUp {
    type: String!
    mandatory: Boolean!
    url: String!
    sessionId: ID!
}

type PaymentInstruments {
    creditCards: [CreditCard!]!

    _stepUp: StepUp  # Not used - to overcome nesting limitation of graphql-import (https://github.com/graphql/graphql-js/issues/2945)
}

type CreditCard {
    paymentInstrumentId: ID!
    paymentToken: String!
    expiryMonth: String!
    cardSuffix: String!
    scheme: String!
    stepUp: StepUp
}

thank you for the new info @willpomac
Do you think you can maybe create a simple reproduction on Code sandbox reproducing this?
Maybe even not on Codegen but on GraphQL Tools?

Apologies for my long delay on this.
I concur with @willpomac that it appears to be related to @graphql-tools/load.  Though I was able to successfully execute codegen with glob expressions and skipGraphQLImport, when I got to the stage of attempting to load my schema to create my graphQL handler, I encountered the same Unknown type failure.
@ardatan It seems highly likely that this is related to (or potentially a duplicate of) graphql-tools/issues/1591, and I notice that you just released a fix for that.  Can you keep us posted on when the graphql-tools dependency is updated in this repo?  Keeping fingers crossed that it resolves this issue as well.

Yup, confirmed that the latest version of @graphql-codegen/cli (1.21.4) completely fixes this issue.


improvement(migrate): help output

Suggestions:
dev -> Create migrations from Prisma schema, apply migrations to database, generate artifacts (Prisma Client).
reset -> Reset your database and apply all migrations.
deploy -> Apply migrations to update the database schema.
resolve -> Resolve issues with database migrations, i.e. baselining databases, failed migrations, hotfixes.
I know some of these now feel too long? If I had an easy way to preview how ti looks in terminal I would have...
What do you think?

BTW, I like the structuring of these into development and not development...

will be in 2.13.0-dev.16


Handle JSON params in LuckyWeb::Params

Closed by https://github.com/luckyframework/web/commit/2f05a3820916d50beb03f45468414ecbbe1c13a4 and https://github.com/luckyframework/web/commit/9b7d5de3c09dbdd3db9a9ef985e1011e172d1a4a


Remove visual limit for damping in CPUParticles

See https://github.com/godotengine/godot/pull/73528.
Fixes https://github.com/godotengine/godot/issues/56324. Supersedes https://github.com/godotengine/godot/pull/57261.

@albinaask Thanks and congrats on the first merged pull request!


Include failure details in scheduled test failure reporting

Engineering Improvement
Area for Improvement (required)
Testing
Observed behavior (required)
We have an automated process for reporting functional test failures in our scheduled test runs. This creates an issue like: https://github.com/radius-project/radius/issues/6682 for each scheduled test run that fails.
This is great, and the functionality that's there already is really valuable. The automation creates and issue and links to the failing workflow. It doesn't include any of the details or logs in the issue itself.
This can cause problems because a re-run of the tests will overwrite the results for the failing workflow. Additionally workflows time-out and their data will be erased after a period of tiem. We also expect the on-call engineer to copy over the relevant logs and do an RCA in the issue. We could automate the part where the on-call engineer has to hunt through the logs.
Desired behavior (required)
The goal I'm proposing is that the issues created by our scheduled test runs are self-contained and can be investigated without needing additional data.
The automation should include:

The names of failing tests (if tests ran)
The console logs of those failing tests
The artifacts from the test run as a zip (includes the logs of all pods in Kubernetes)

Proposed Fix (optional)
We have some existing actions/scripts to:

Output a JSON results file from Go test (this is a Go-specific format and not widely used)
Convert that JSON results file into JUnit format (supported by a wide array of tools)
Parse the JUnit results file and add annotations to the test run

We use this for our UNIT TEST failure reporting. Not many people know about it because unit test failures are pretty rare in CI 😉.
We could extend this to build most of what I'm suggesting for our functional tests.
AB#10297

removing important tag - can reevaluate if there is disagreement


Comment as 'Work in progress' to keep members from merging the PRs too soon.

@tymsai/tymsai
This should be in our rules. (like in CONTRIBUTION.md)
https://github.com/tymsai/marmoym-web/pull/15#issuecomment-321244802

Issues like this should be moved in repos like marmoym-dev-support


Add zimnx as required dependency reviewer

Adds zimnx as required dependency reviewer.

/lgtm
/retest

/override ci/prow/images

/override ci/prow/e2e-gke-parallel
/override ci/prow/e2e-gke-serial


Adds build system to easier maintenance and distribution

While using with require, I encountered random errors due to the requirements between to-markdown and he.
I've written a gulpfile and a small build system in order to concat and minify the files to the dist folder
Also replaced the main file with the dist one and the documentation!

Hi @flovilmart
Thanks for this, and apologies for the delay in getting back to you.
I have chosen to use browserify to separate things into modules, and to keep things simple.
FWIW he is no longer a dependency in the latest version
Thanks again.


[BUG] Autocompletion for For should prefer ForwardDiff over for

Please search existing issues to avoid duplicates.
Details

Atom version: 0.12.5
Julia version: 1.4.1
OS: MacOS
Package versions:

Atom.jl: 0.12.11
julia-client: 0.12.5
ink: 0.12.4

Steps to reproduce

using ForwardDiff
Type For and press <TAB>

Given that I type For with a capital F, I am looking for a package (or maybe a type) starting with For, rather than a for loop.
In general, capitalisation should be respected in autocompletions.

close in favour of https://github.com/JunoLab/FuzzyCompletions.jl/issues/2#issue-623086414
you can also go back to previons REPL like  completions via config

Thanks. I am trying to work out where the config option is, but can't find it.

OK, found it: "Julia options" in the julia-client package.


Configured VMs stopped outside of their configured schedules

I created Stop/start schedules for VMs.
VMs Stoped outside of their configured schedules after 'enabling' the logic app. Time was configured for CST
Im afraid to re-enable the policy

I needed to add the parameter of when the job first runs.


GEOMESA-1882 - Unit test for accessing last element of json array in Converter

Signed-off-by: David Seapy<EMAIL_ADDRESS>

Not sure about why this is failing or if it's valid syntax but I have found a workaround. You can use array[start:end] access method like $.colors[-1:].color to access the last item in the array.

Online example


Adding Lessalay academy domain

@chessnok lib/domains/academy/lesallay: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@philipto Sorry about it, I just updated it. Am I need to create new pull request?

@chessnok First stage of verification passed, official domain is lesallay.academy as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Response time from HAproxy stats

Is there a way to get the response time from HAProxy exporter? The HAProxy stats shows the average response time for the last 1024 successful connections.

The problem is that we need a counter to do it properly, and that's not a counter. From when I looked into this about a year ago it's an exponentially decaying average, and depending on your request rate may be quite off the true value. What we really need to do is add counters for latency to haproxy.

Sorry I didn't look into that @brian-brazil. In my case that number is better than nothing right now, but is nice to know it doesn't necessarily represents the real value.

Why don't cut a version with this as a gauge? Even though the numbers are not 100% reliable it is better than nothing, awaiting a better counter from HAProxy.
Perhaps a flag to include these values by choice would be an ok solution?

I have been exporting response time (more specifically, as histogram on the Tr timer in the HAProxy HTTP log) from the HAProxy logs with this exporter http://git.cbaines.net/prometheus-haproxy-log-exporter/ (which I wrote for this purpose).
I'm not sure the stats page is fit for this purpose, but exporting data from the logs works very well.

Thankz @cbaines - looks interesting. I will definitely havce a look.

I want to throw my vote in that we include this in a release. I understand it may not be perfect, but we currently use these metrics in various graphs and operators will miss them if we migrated to this exporter. Maybe we only enable them with a flag?

I'm in favour of including the times that are there, even if gated behind a flag and/or equipped with a big warning. That the ideal form of the data is not available does not mean we should ignore the information that is there out of spite.

And "it's not 100% correct but at least allows you to know what's there" is perfectly fine for an operational monitoring system – we don't promise exactness anywhere. There are plenty of cases with a steady enough request stream that these numbers are at least indicative.

Tossing our hat in here that we would like this, even though it's not perfect.


Bug fixes and unit tests for org_team

Unit tests for models/org_team.go
Fix a bug in DeleteTeam(..) where stale entries in the team_repo table were not deleted.
Some minor cleanups in models/org_team.go (remove unused functions, fix misformated error message, etc.)

LGTM

Build faild

@lunny Lint error from #1017, restarted.

LGTM


Add UCS Support

Add support to F5 Python SDK for managing UCS archives (create/save, restore, list).
/mgmt/tm/sys/ucs

Due to ID504814 we cannot list the UCS archives that are on the system. Load and Save should be achievable using command mixin.

It seems this feature is riddled with bugs, as per research and testing:
11.6.0

Listing UCS does not work due to ID504814

Simple GET to '/mgmt/tm/sys/ucs/' returns just the below:
{"kind":"tm:sys:ucs:ucscollectionstate","selfLink":"https://localhost/mgmt/tm/sys/ucs?ver=11.6.0"}

Loading UCS returns { "command":"load", "name": "test.ucs"} :

{"code":500,"message":"UCS loading process failed.","errorStack":[]}

And we have no way of telling if this succeeded or not

Saving UCS returns { "command":"save", "name": "test2.ucs"}:

{"code":500,"message":"UCS saving process failed.","errorStack":[]}

but it succeeds as the ucs file is created, verified on the device.
There are some other syntax examples where one uses payload like this:
{ "command":"save", "options":[{"ucs":"test6.ucs"}]}
but on 11.6.0 and 12.x it returns the error:
{"code":400,"message":"\"test6.ucs\" unknown property","errorStack":[]}

12.x.0

Listing UCS does works in 12.1.0 and  simple GET to '/mgmt/tm/sys/ucs/' returns something like this:

{
  "kind": "tm:sys:ucs:ucscollectionstate",
  "selfLink": "https://localhost/mgmt/tm/sys/ucs?ver=12.1.0",
  "items": [
    {
      "kind": "tm:sys:ucs:ucsstate",
      "generation": 0,
      "apiRawValues": {
        "base_build": "0.0.606",
        "build": "0.3.606",
        "built": "150930180821",
        "changelist": "1513591",
        "edition": "Engineering Hotfix",
        "encrypted": "no",
        "file_size": "104923292 (in bytes)",
        "filename": "/var/local/ucs/config.ucs",
        "install_date": "Wed Sep 30 18:08:21 PDT 2015",
        "job_id": "553417",
        "product": "BIG-IP",
        "sequence": "<IP_ADDRESS>.3.606.3",
        "version": "12.0.0"
      }
    },

Loading UCS returns { "command":"load", "name": "test.ucs"} :

Bad Gateway!

    The proxy server received an invalid
    response from an upstream server.

    The proxy server could not handle the request POST /mgmt/tm/sys/ucs/.

Reason: Error reading from remote server

Error 502

<address>
  ltm6

  Thu Jun 23 00:30:39 2016

</address>

Again we have no way of telling if it suceeded or not

Saving UCS returns { "command":"save", "name":"test4.ucs"}:

{"kind":"tm:sys:ucs:savestate","command":"save","name":"test4.ucs"}
Which is what we want
I am going to try few other things but it does not look good now

Good News! the below works on both 11.6.0 and 12.x.0, but it still returns Bad Gateway 502
This is definitely a bug with REST not returning proper response.
To verify this was successful I did tail -f /var/log/ltm and I have seen config loading.
{"command":"load", "utilCmdArgs": "test4.ucs no-license"}

<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<title>Bad Gateway!</title>
<link rev="made"<EMAIL_ADDRESS>/>

Bad Gateway!

    The proxy server received an invalid
    response from an upstream server.

    The proxy server could not handle the request POST /mgmt/tm/sys/ucs/.

Reason: Error reading from remote server

Error 502

<address>
  ltm5

  Thu Jun 23 00:44:22 2016

</address>

Running the command:

{"command":"save", "utilCmdArgs": "test4.ucs"}

still returns on 11.6.0 Final
{"code":500,"message":"UCS saving process failed.","errorStack":[]}

SIDENOTE:
Seems like utilizing OPTIONS is not the best approach, could be due to the fact that the examples I have found did not have correct syntax, i found it easier to use 'utilCmdArgs' as it felt more natural in mimicking tmsh syntax

@zancas @pjbreaux @caphrim007
I need some insight on how we wanna approach this, given the amount of issues implementing of this 'feature' would present.
I am going to open an internal escalation to clarify why we do not get valid response when attempting to load the UCS on 12.1.0.

Update to my SIDENOTE, it seems the syntax observed is correct, so it does look like node.js issue. I am querying this in my escalation as well.

Looks like 502 response is expected due to daemons restarting upon UCS load. Will raise RFE to improve this behavior but for now, I have to get creative and hack this a bit so it is workable. It won't be pretty

I was a bit hasty with 11.6.0 Final, it seems load UCS does not work on this version. Due to the amount of issues, I am arbitarily,  making this feature v12.x and up only for now


python311Packages.kaggle: 1.6.3 -> 1.6.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.kaggle is: Official API for https://www.kaggle.com, accessible using a command line tool implemented in Python 3
meta.homepage for python311Packages.kaggle is: https://github.com/Kaggle/kaggle-api
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.4 with grep in /nix/store/w2v40h7m4a52kb7yc7fqbbdx96lj1rjh-python3.11-kaggle-1.6.4
found 1.6.4 in filename of file in /nix/store/w2v40h7m4a52kb7yc7fqbbdx96lj1rjh-python3.11-kaggle-1.6.4

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
kaggle
python311Packages.kaggle

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/w2v40h7m4a52kb7yc7fqbbdx96lj1rjh-python3.11-kaggle-1.6.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.kaggle https://github.com/r-ryantm/nixpkgs/archive/2c219b958a18ee03ff7b3d6e6fbf5fd1f1e58097.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2c219b958a18ee03ff7b3d6e6fbf5fd1f1e58097#python311Packages.kaggle

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/w2v40h7m4a52kb7yc7fqbbdx96lj1rjh-python3.11-kaggle-1.6.4
ls -la /nix/store/w2v40h7m4a52kb7yc7fqbbdx96lj1rjh-python3.11-kaggle-1.6.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

kaggle (python311Packages.kaggle)
kaggle.dist (python311Packages.kaggle.dist)

Maintainer pings
cc @mbalatsko for testing.

The source code in GitHub is still at 1.6.3. Is the development not open?
https://github.com/Kaggle/kaggle-api

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.kaggle is: Official API for https://www.kaggle.com, accessible using a command line tool implemented in Python 3
meta.homepage for python311Packages.kaggle is: https://github.com/Kaggle/kaggle-api
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.6 with grep in /nix/store/1h2ivw4hg2qsafmb023bjqm9hzy7dk0z-python3.11-kaggle-1.6.6
found 1.6.6 in filename of file in /nix/store/1h2ivw4hg2qsafmb023bjqm9hzy7dk0z-python3.11-kaggle-1.6.6

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
kaggle
python311Packages.kaggle
python312Packages.kaggle

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1h2ivw4hg2qsafmb023bjqm9hzy7dk0z-python3.11-kaggle-1.6.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.kaggle https://github.com/r-ryantm/nixpkgs/archive/8b2d667ecc9c7532d063a3f361045cfc529ce705.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8b2d667ecc9c7532d063a3f361045cfc529ce705#python311Packages.kaggle

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1h2ivw4hg2qsafmb023bjqm9hzy7dk0z-python3.11-kaggle-1.6.6
ls -la /nix/store/1h2ivw4hg2qsafmb023bjqm9hzy7dk0z-python3.11-kaggle-1.6.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

kaggle (python311Packages.kaggle)
python312Packages.kaggle

Maintainer pings
cc @mbalatsko for testing.


Stream Enrich: fix parent event context in PII events

Project: Stream Enrich
Version: R109
Expected behavior: PII event contexts contains valid iglu schema
Actual behavior: PII event does not contain valid iglu schema
Steps to reproduce:
Run Stream enrich and observe the PII events (look in the contexts[0].schema)
The bug is here:
https://github.com/snowplow/snowplow/blob/d8f028f533c80196a68f2a61af9d635079ab6852/3-enrich/stream-enrich/core/src/main/scala/com.snowplowanalytics.snowplow.enrich.stream/sources/Source.scala#L145

Yes


Turn on dev site

I think from (these docs)[https://pkgdown.r-lib.org/articles/how-to-update-released-site.html] that this is enough?
I had some trouble following the bit at the end about cherry-picking stuff around, but it sounds like when mode is auto that it watches and updates appropriately based on version.
Let me know if this isn't right Sam and I'll give it a tweak.
Closes #99

/wordlist


Prelude/package.dhall checksum incorrect

I'm trying to run the example, using an import and it's failing with:
dhall:
↳ https://raw.githubusercontent.com/bgamari/dhall-gitlab-ci/master/package.dhall
  ↳ https://raw.githubusercontent.com/bgamari/dhall-gitlab-ci/master/GitLab/package.dhall
    ↳ https://raw.githubusercontent.com/bgamari/dhall-gitlab-ci/master/GitLab/Job/package.dhall
      ↳ https://raw.githubusercontent.com/bgamari/dhall-gitlab-ci/master/GitLab/Job/Type.dhall
        ↳ https://raw.githubusercontent.com/bgamari/dhall-gitlab-ci/master/GitLab/Prelude.dhall
          ↳ https://raw.githubusercontent.com/bgamari/dhall-gitlab-ci/master/Prelude.dhall
            ↳ https://raw.githubusercontent.com/dhall-lang/dhall-lang/v17.0.0/Prelude/package.dhall
  sha256:0c04cbe34f1f2d408e8c8b8cb0aa3ff4d5656336910f7e86190a6d14326f966d

Error: Import integrity check failed

Expected hash:

↳ 0c04cbe34f1f2d408e8c8b8cb0aa3ff4d5656336910f7e86190a6d14326f966d

Actual hash:

↳ 10db3c919c25e9046833df897a8ffe2701dc390fa0893d958c3430524be5a43e

24│   https://raw.githubusercontent.com/dhall-lang/dhall-lang/v17.0.0/Prelude/package.dhall sha256:0c04cbe34f1f2d408e8c8b8cb0aa3ff4d5656336910f7e86190a6d14326f966d

https://raw.githubusercontent.com/bgamari/dhall-gitlab-ci/master/Prelude.dhall:24:3

It seems like the checksum committed is wrong.

Yeah, I'm using the latest:
% dhall --version
1.41.1

I can't see any obvious reason in the changelog why this would have broken: https://hackage.haskell.org/package/dhall-1.41.1/changelog

For the record, same problem here when upgrading to dhall in version 1.40.2. For now I'm using @bobdoah's PR directly, otherwise the pipeline won't build.

I was hoping to get a bit more familiar with dhall by using it for gitlab-ci, any recs on a temporary workaround?
Could I somehow get that version of the Prelude cached on my machine? Or fork and deal with fixing the sha check w/in the code of this repo?

You can use the PR, or my fork: https://github.com/bobdoah/dhall-gitlab-ci

I have merged the MR. Thanks everyone!


Make SnapshotTesting Accessibility Functions for ContentSizeCategory public

The two extending functions on Snapshotting for UIView and UIViewController in SnapshotTesting+Accessibility.swift which make it possible to modify the content size category for the snapshot should be public, so they can be used outside the target.
Issue exists in Version 0.4.0 of AccessibilitySnapshot

Just saw that this functionality is available from the original SnapshotLibrary (https://github.com/cashapp/AccessibilitySnapshot/issues/4#issuecomment-711072620). So feel free to close this issue and the PR.
This was the change I needed to make to get the same functionality, if others are having the same issue.
-            as: .image(at: .accessibilityLarge)
+            as: .image(traits: .init(preferredContentSizeCategory: .accessibilityLarge))

Closing this issue as a duplicate since it's already tracked by #4. Thanks for the reminder though! I'll try to carve out some time to verify whether there's anything additional we need to do for the SnapshotTesting subspec, and if not then remove the methods. We definitely still need to do work for the iOSSnapshotTestCase subspec.


Add github code annotation for failed test

It would be be great if you can add code annotation to failed cypress e2e test.
There is a nice example with Jest

I was just thinking about this. We could add annotations (super useful), but an update to the output from the Cypress project would be required to get file name/line numbers. A PR to at least add annotations would be a good first step

@NicholasBoll Actually we have this information. Specifically as part of this PR: https://github.com/cypress-io/cypress/pull/3930
I will have to investigate whether this is being passed through to the reporting output though.

Awesome! Once there is output that can be processed by regular expressions, annotation support is fairly easy to add.
As an example, the parse config for eslint-stylish in the setup-node action is here: https://github.com/actions/setup-node/blob/master/.github/eslint-stylish.json. This is what activates that matcher: https://github.com/actions/setup-node/blob/releases/v1/src/setup-node.ts#L30


Add solvers fields in Let's Encrypt/nginx quick start guide

What this PR does / why we need it:
Adds the solvers field in the related issuer.yaml files for the quick start guide doc.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1608
Special notes for your reviewer:
Just copies code blocks from https://docs.cert-manager.io/en/latest/tasks/issuers/setup-acme/index.html
Release note:

NONE

There's a few extra places that I can see in the doc that still need updating:

Both of these issuers are configured to use the
:doc:`HTTP01 </tasks/issuers/setup-acme/http01/index>` challenge provider.

Check on the status of the issuer after you create it:

.. code-block::shell
  :emphasize-lines: 28-32

    $ kubectl describe issuer letsencrypt-staging

    Name:         letsencrypt-staging
    Namespace:    default
    Labels:       <none>
    Annotations:  kubectl.kubernetes.io/last-applied-configuration={"apiVersion":"certmanager.k8s.io/v1alpha1","kind":"Issuer","metadata":{"annotations":{},"name":"letsencrypt-staging","namespace":"default"},"spec":{"a...
    API Version:  certmanager.k8s.io/v1alpha1
    Kind:         Issuer
    Metadata:
      Cluster Name:
      Creation Timestamp:  2018-11-17T18:03:54Z
      Generation:          0
      Resource Version:    9092
      Self Link:           /apis/certmanager.k8s.io/v1alpha1/namespaces/default/issuers/letsencrypt-staging
      UID:                 25b7ae77-ea93-11e8-82f8-42010a8a00b5
    Spec:
      Acme:
        Email<EMAIL_ADDRESS>        Http 01:
        Private Key Secret Ref:
          Key:

We need to remove Http 01: and replace it with the new output from describe that includes the solvers field instead

This will start the process to get a new certificate, and using describe
you can see the status. Once the production certificate has been updated,
you should see the example KUARD running at your domain with a signed TLS
certificate.

.. code-block:: shell
   :emphasize-lines: 47-48

    $ kubectl describe certificate

    Name:         quickstart-example-tls
    Namespace:    default
    Labels:       <none>
    Annotations:  <none>
    API Version:  certmanager.k8s.io/v1alpha1
    Kind:         Certificate
    Metadata:
      Cluster Name:
      Creation Timestamp:  2018-11-17T18:36:48Z
      Generation:          0
      Owner References:
        API Version:           extensions/v1beta1
        Block Owner Deletion:  true
        Controller:            true
        Kind:                  Ingress
        Name:                  kuard
        UID:                   a3e9f935-ea87-11e8-82f8-42010a8a00b5
      Resource Version:        283686
      Self Link:               /apis/certmanager.k8s.io/v1alpha1/namespaces/default/certificates/quickstart-example-tls
      UID:                     bdd93b32-ea97-11e8-82f8-42010a8a00b5
    Spec:
      Acme:
        Config:
          Domains:
            example.your-domain.com
          Http 01:
            Ingress:
            Ingress Class:  nginx
      Dns Names:
        example.your-domain.com

This shows a Certificate that still uses the old format. Given the changes in this PR, the actual resulting Certificate resource created here should not have the spec.acme field at all 😄

The following lines should be removed:
https://github.com/jetstack/cert-manager/blob/80e97c984b0f71c568879c8c44562832f2311f5e/docs/tutorials/acme/quick-start/example/ingress-tls.yaml#L8
https://github.com/jetstack/cert-manager/blob/80e97c984b0f71c568879c8c44562832f2311f5e/docs/tutorials/acme/quick-start/example/ingress-tls-final.yaml#L8
https://github.com/jetstack/cert-manager/blob/master/docs/tutorials/acme/quick-start/example/ingress.yaml#L8

Whoops, made those changes now.

/lgtm
/approve


about the NODE_END_SLOT_ID of twr_tag_nranges_tdma

I would like to test the TDOA application, in the process of using mynewt-dw1000-apps\apps\twr_tag_nranges_tdma example, the configuration of tag at compile time is as follows:
Newt target amend tag syscfg=NRNG_NNODES=16:NRNG_NFRAMES=32:NODE_START_SLOT_ID=0:NODE_END_SLOT_ID=8
I have 4 nodes now, I will set NRNG_NNODES=4:NRNG_NFRAMES=8, NODE_END_SLOT_ID should I set it to 4?
RNG has 7 data and tdoa has 7 data. When set to 4, RNG only has 4 data sets. Is there any difference?
Looking forward to your reply.

I have a project that needs to use tdoa-related applications. It needs time synchronization, TDOA ranging, wireless communication. What test cases can be used to achieve these functions?

@ihuajiu,
The mynewt-dw1000-apps\apps\twr_tag(node)_nranges_tdma is the closest fit to your requirements.
Regards Paul

mynewt-dw1000-apps\apps\twr_tag(node)_nranges_tdma is still two way ranging, right? It's not TDOA ranging.

Hi Feng,
twr_tag(node)_nranges_tdma is still slotted TWR, however, with WCS enabled you can also do Reverse-TDOA with the same examples. With WCS enabled all timestamps are converted to the clock master reference frame.
Regards Paul.

Hello,
@ihuajiu  since you have already run this nranges example, I hope you can help me in some way.
Kindly check this thread. Hope to get your response
https://github.com/Decawave/mynewt-dw1000-apps/issues/18
Thanks & regards
Asmita


Added ~200 entries (and fixed a typo in en-us)

Thank you for the contributions! There were some conflicts with the changes done by FreakyWaves, I picked ones that seemed better, but I don't understand French, so please feel free to change them in another pull request if some of them are wrong.


Bug when using .iter() over a reference

The following code crashes with an assertion failure:
pub fn baz(v: &Vec<i32>) {
    for x in v {}
}

See below for notes.
Ok did some digging, this is indeed a bug somewhere else.
When calling Iter::next we "downgrade" a pointer to a reference (this line) changing the lifetime to something that makes the assertion fail.
So, we start with
r: ptr(x), x: Iter<'?11, i32>

Then, just before the call, we have
r: &mut Iter<?20, i32>, x: †Iter<'?20, i32>

i.e., the pointer r is now a mutable reference, and the type of x has been strongly updated (and blocked). The issue is that lifetimes should never be strongly updated. The call to block_with should update everything but lifetimes. That's what we do in assignments https://github.com/flux-rs/flux/blob/main/crates/flux-refineck/src/type_env.rs#L172.
The fix is a bit tricky because we are updating through a path not a place, so we can't do the same as we do in assign.
Originally posted by @nilehmann in https://github.com/flux-rs/flux/pull/575#discussion_r1430773298

Ideally we'd want stuff like this to work

#[flux::sig(fn (bool[true]))]
fn assert(_b: bool) {}

pub fn test() {
    let mut s: Vec<i32> = vec![];
    s.push(666);
    for v in &s {
        assert(*v >= 0);
    }
}

and
pub fn test() {
    let mut s: RSet<i32> = RSet::new();
    s.insert(10);
    s.insert(20);
    s.insert(30);

     for v in s.iter() {
         assert(*v >= 10);
     }
}


🚜 Sample data generator

Create user profiles, sample listings, and sample offers.
Make as many as you want! Load test your app!
Currently made to run against a local truffle environment, but should not be hard to change to work on a testnet.

(Fixing the eslint issue)

@tyleryasaka I really don't want to add large dependency just for this. Faker is 14mb zipped, and I'd rather keep our list of dependencies low for security reasons as well. One less way developers can get attacked.
In this case, it's just a list of words so it's not going to need to be upgraded. The words used to not take up that much space in the file -- until prettier wanted to put each word on it's own line. :) The only disadvantage is that you have to scroll before editing the file.

@DanielVF Yeah Faker is big, but we would just add it as a dev dependency. That won't affect the size of our production build and won't introduce any security risks in production. Not a big deal though, I'm fine with this list.
As far as the words being inline - how about we move the list of words to a separate json file and import it?

A separate file would be great - where you recommend we put it?
Dev dependencies are still possible security problems, since it's an attack vector on an blockchain developer, which is a nice route into other valuable things.

Meh, scripts/sample-data.json would work for me. Or wherever you think it would make sense.

Using this to test search functionality. Works perfectly 💪

ah. the build fails because:
/home/travis/build/OriginProtocol/origin-js/scripts/sample-data.js
  36:44  error  Strings must use singlequote  quotes

@DanielVF I hope you don't mind... I have added the commission into the PR since I need it to test search... Also fixed a small bug in listeners. Looks like adapters have moved from marketplace to marketplace.resolvers

Great. Do all the default accounts have starting OGN now? Otherwise does it break when you include a commission amount, but have no OGN?

Looks like they do, because the listings get added to blockchain and the indexing listener picks them up and indexes them

Yes the migration scripts give 200 OGN to all accounts. See this script.

@DanielVF @sparrowDom
Going to merge this in a few minutes unless there is any objection...


Updating master with release 0.6.3

Codecov Report

Merging #767 into master will decrease coverage by 0.26%.
The diff coverage is 31.78%.

@@             Coverage Diff              @@
##             master     #767      +/-   ##
============================================
- Coverage     60.07%   59.81%   -0.27%
- Complexity     2800     2803       +3
============================================
  Files           424      433       +9
  Lines         12828    12874      +46
  Branches       1434     1438       +4
============================================
- Hits           7707     7700       -7
- Misses         4519     4574      +55
+ Partials        602      600       -2

Impacted Files
Coverage Δ
Complexity Δ

...er/accumulostore/utils/IteratorOptionsBuilder.java
0% <ø> (ø)
0 <0> (ø)
:x:

...ostore/key/exception/IteratorSettingException.java
0% <ø> (ø)
0 <0> (ø)
:x:

.../java/uk/gov/gchq/gaffer/store/StoreException.java
0% <ø> (ø)
0 <0> (ø)
:x:

.../gov/gchq/gaffer/rest/service/ExamplesService.java
58.73% <ø> (+0.13%)
34 <0> (ø)
:x:

...va/uk/gov/gchq/gaffer/rest/service/JobService.java
0% <ø> (ø)
0 <0> (ø)
:x:

...gaffer/rest/service/GraphConfigurationService.java
91.52% <ø> (+2.46%)
20 <0> (ø)
:x:

...mulostore/key/exception/RangeFactoryException.java
0% <ø> (ø)
0 <0> (ø)
:x:

...gov/gchq/gaffer/rest/service/OperationService.java
0% <ø> (ø)
0 <0> (ø)
:x:

...er/accumulostore/utils/AccumuloStoreConstants.java
33.33% <ø> (-26.67%)
1 <0> (ø)

...hq/gaffer/accumulostore/key/IteratorException.java
0% <ø> (ø)
0 <0> (ø)
:x:

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de67c8b...601d2a2. Read the comment docs.


Dateline issues - basemaps and initial exents

From Judy Kesler/ Rhea Hood:
Regan,
Several us have agreed that in order to benefit from the use of Story Map for any stories or resources that span Alaska, specifically the Aleutian area, that it is critical to provide a solution to this issue, if Story Map is going to be used to display content.
I think a lot of information related to thematically telling Alaska's stories such as WW2, Russian History, Natural Resource migration, and even climate change, can't be addressed fully in a professional manner with the current issues.
What can we do to move forward on solving this issue? How do we increase the priority, or what would it take to get it done?
Thanks.

Close with f648b32a381ceb50cb815f4fc20af62a0a7d30ce


change repository name

Repository name could be related to your assigned topic for clarity.

Agreed :)

Also change the names of the branches to something more meaningful (what does konstantin mean?)

agreed!


Sortable Grid - Variable Sizes demo has unexpected behaviour

First of all, thanks for your work on this library.
In the example of sortable grid - variable sizes, even though elements get reorderd on drag drop, the sizes retain on prior positions.
This kind of behaves like the "large first tile" example above it.
While the variable width / variable height demos work as expected with the items retaining its width.
Initial

After drag and drop

Is this the intended behaviour?

Thanks @clauderic - understood the usecase, but in this case, it is very similar to the Large first tile demo right? (apart from position 10 also having fixed size here)
Whereas, retaining the size even after moving to a different position would be another usecase - aligned to variable width and height demos.


How to increase max message size in http endpoint

There is no config to increase max message size for http endpoint . I am unable to send messages greater than 1 Mb in size

Will add this as an option into 4.0 👍

Added, maxMessageSize option is now available in V4 branch and will be published under rc.10


@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/r-ssh-feedstock#3.


[BUG] Fails with Mocker

Describe the bug
Using mocker causes a failure during serialization. It appears snappiershot is trying to serialize the mocker object but is unable to do so
To Reproduce
Write a simple test using mocker:
def test_mocker(snapshot, mocker):
    snapshot.assert_match(1)

produces the following call stack
/home/ttb/.venv/bin/python /home/ttb/ttb/test/test_tag_usb.py
Traceback (most recent call last):
  File "/home/ttb/ttb/test/test_tag_usb.py", line 160, in <module>
    test_mocker(snapshot, mock)
  File "/home/ttb/.venv/lib/python3.7/site-packages/snappiershot/snapshot.py", line 188, in __exit__
    self._snapshot_file.write()
  File "/home/ttb/.venv/lib/python3.7/site-packages/snappiershot/snapshot.py", line 430, in write
    sort_keys=True,
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/__init__.py", line 179, in dump
    for chunk in iterable:
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 431, in _iterencode
    yield from _iterencode_dict(o, _current_indent_level)
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 405, in _iterencode_dict
    yield from chunks
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 405, in _iterencode_dict
    yield from chunks
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 325, in _iterencode_list
    yield from chunks
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 405, in _iterencode_dict
    yield from chunks
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 405, in _iterencode_dict
    yield from chunks
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 405, in _iterencode_dict
    yield from chunks
  File "/home/ttb/.pyenv/versions/3.7.3/lib/python3.7/json/encoder.py", line 438, in _iterencode
    o = _default(o)
  File "/home/ttb/.venv/lib/python3.7/site-packages/snappiershot/serializers/json.py", line 80, in default
    f"Encoding for this object is not yet implemented: {value} ({type(value)})"
NotImplementedError: Encoding for this object is not yet implemented: <module 'mock' from '/home/ttb/.venv/lib/python3.7/site-packages/mock/__init__.py'> (<class 'module'>)

Process finished with exit code 1

Expected behavior
Not crashing?
Screenshots
Versions:

Python version: 3.7.3 (via pyenv; ubuntu 18.04)
Snappiershot version: 0.2.0

Additional context
Add any other context about the problem here.

update: with snappiershot 1.0.0, the error is different. It ends up with infinite recursion.

Thanks for the bug reports! We are still working to figure this out how to fix this bug, but it most likely has to do with the complex nature of those Mocker objects. Just wanted to let you know that we are working on this

due to complex nature of mocker objects, current developers suggest not to snapshot them and ignoring them in the metadata via ignore=["name_of_mocker_obj_variable"] in the assert_match call


I will also make a similar change to Agent. However, in the Agent I think we will still need the "service" package to be replaced so that we can embed the OTel Collector's metrics in the Agent's /metrics endpoint.

This copying is not "a little", but I think it's still better than the go mod replace 😄

To avoid copied code, I reimplemented the feature using the exported tools otelcol expects you to use in this other PR: https://github.com/grafana/alloy/pull/2148

Closing this PR in favour of #2148, which doesn't require copying code 🥳


Update reportTemplates.json

Some minor edits to match the title with the selected form template.

@talebib Vance is on leave. But changes small and logical!


Add tests for reporting system

https://github.com/pwwang/pyppl-report/commit/6df400b150877265806ff5ff555f5ccca208962d


Switch to using Node Single Executable Applications (SEA) if possible, instead of using pkg

The pkg tool (used to create binaries for macOs, Windows, Linux) is no longer developed/supported.
Node SEA apps is on the other hand maturing and has been proved to work well for Ctrl-Q.
Switch to using SEA also for BSI, if possible.

Released as part of 3.6.4.


Add test for Superb info

Related to change #19, should have been done it there :)

Seems there is something else to fix. I will have a look on this later.

Fixes #20


mlterm: init at 3.3.8

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

A multi-lingual terminal that supports REGIS and SIXEL graphics

Help! I am not able to reproduce the build failure even on a chroot envt.

Seen this error quite a bit lately, pretty sure it's spurious.

All good with nox-review


Is there a way to set a default value for restart_policy?

As far as I know docker itself does not support this. It has to be set for each container separately. However portainer could for the containers it creates. Is this implemented?

We tend to follow the defaults that Docker uses in order to make the transition between command-line and Portainer more straightforward for users. As you've mentioned Docker doesn't support changing the default restart policy away from no so neither does Portainer. I will convert this to a feature request however as something we may look at in the future if there is enough demand for the functionality.

I understand. That makes sense. Thank you for keeping it for future consideration.


Date formatting in the table html builder

The date formatting - in the table data page - reflects a number other than date, for US locale browsing.
I guess the issue must be addressed here in the abstract table Doc builder, with a type matching for DateTime and with a proper Moment.js formatting.

Indeed, after choosing US from chrome://settings/languages and rebooting chrome, the breakpoint on the above said line
return[Doc.Element("td",[],[Doc.TextNode(Global.String(m[1]))])];

confirms the issue
m
(2) ["ContractEndDate",<PHONE_NUMBER>000]
Date(m[2])
"Tue Sep 10 2019 08:57:23 GMT+0200 (Central European Summer Time)"

Stepping one step up in the call stack, I've stopped chrome debugger on breakpoint here
 Client.TableRetrieve=function(input_received)
 {
  var str,err,input,tradeTableDoc,nominTableDoc,costTableDoc,plTableDoc;
  return input_received.$==1?(str=input_received.$0,(console.log("response no input: "+str),Doc.Element("div",[],[Doc.TextNode(str)]))):input_received.$==2?(err=input_received.$0,(console.log("response error: "+err),Doc.Element("div",[],[Doc.Element("h2",[],[Doc.TextNode("¯\\_(\u30c4)_/¯")]),Doc.TextNode(err)]))):(input=input_received.$0,(tradeTableDoc=Client.buildTableHtml(input.tradeResp,function(resp)

and, from the console output, it seems that it's the server response to blame, not the client...
input_received.$0.tradeResp.$0.trades[0][5]
(2) ["ContractEndDate",<PHONE_NUMBER>000]

So next breakpoint will be inside the RPC function, therefore I'm going to open Visual Studio. ¯\(ツ)/¯

Also the F# on the server works as expected
match tradesTry with
| Result.Ok trades ->
if (trades |> Array.length > 0) then
    return Response {
    table = tableDB;
    items = trades;
    headers =
    [|for (k,v) in trades.[0] do
        match v with
        |  :? int
        |  :? decimal -> yield Numeric k
        | _ -> yield Alphanumeric k
        |]
    }

according to Visual Studio debugger

I suspect that the issue is due to the RPC bindings: let me ask a clarification on gitter.


fix todo of handling runtime errors in server callback method

TODO:

[X] Make sure all of the significant new logic is covered by tests
[X] Rebase your changes on master so that they can be merged easily
[X] Make sure all tests and linter rules pass
[X] Update CHANGELOG.md with your change

@helfer I believe that case is already covered by should call error handler when graphql result has errors: https://github.com/apollostack/subscriptions-transport-ws/blob/master/src/test/tests.ts#L239-L264

@NeoPhi yes, you're right! :)


Merged the multiple small PRs so you don't have to merge / rebase

Replaces the following PRs:

#66
#67
#68
#69

The ram cleanup is great, but the inner core messaging is my favorite part of this update.


pull request for e2e test at 01/12/2017 00:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


URL prefix?

Hey there,
My company has been using httpbin copiously and while we think it's fantastic, one consistent problem we've been having is trying to set httpbin behind a url path prefix (e.g. no httpbin.mydomain.com but mydomain.com/httpbin). We've scoured the documentation and it does not seem like this is possible although a flask app is supposed to be able to support this. Is there any documentation I'm missing, or could it be possible to add support for this feature?

I tried to do it but it seems that either Flask or GUnicorn need to support it first.


Not possible to create new files on mounted drive, save file works fine on the same location for existing files

Description of your problem
I have a notebook, running Windows 10, VMWare and Linux (Fedora) is running on VM.
Spyder is installed on Linux.
I have my work data  on windows folders, shared to VM mounted with correct write permisisons.
I can not create a new file to save on the mounted drive from Spyder "Save file" dialog (save button is unactive). I can however overwrite any existing file on the same drive from the same dialog.
Please provide any additional information below
Version and main components

Spyder Version: 3.2.4
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Linux

Dependencies
IPython >=4.0    :  6.1.0 (OK)
cython >=0.21    :  0.26.1 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
numpy >=1.7      :  1.13.3 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
psutil >=0.3     :  5.4.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pyflakes >=0.6.0 :  1.6.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
pylint >=0.25    :  1.7.4 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
rope >=0.9.4     :  0.10.5 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
sympy >=0.7.3    :  1.1.1 (OK)

To confirm, does this work in other applications in the VM?

I can use the mounted drives from the VM without restrictions on BASH and shell.
It works fine in Atom, Firefox can save on mounted drives. It does not seem to wrok on any application what runs within Anaconda environment. Tried and have the same issue with R-studio. Possibly the QT handling the dialog is the culprit...


Fix typo in generate_dict from generate.py

Fix typo in generate_dict from generate.py
    result[newkey] = merge(result[key], val)
except KeyError:
    result[newkey] = val

For exemple with range =node1-3 the value of key is node1-3.
So this key never exist in the result array. You always go to KeyError exception.
result[key] in merge will be replaced by result[newkey] (newkey example : node1).

Ok. My permission problem on this repo is fixed. I will write some unittests and reopen a pull requests on the generate_fix branch


usb: cdc_acm: allow to configure CDC ACM UART device from devicetree

Add hidden Kconfig option to Kconfig.cdc and allow
to configure CDC ACM UART device from devicetree.

Please DO NOT merge. Im currently reviewing.

We need to check how it will impact mcuboot serial recovery, which currently uses the zephyr,console as a default port.
I have already tried to change that (https://github.com/mcu-tools/mcuboot/pull/951); with the addition of this PR we should probably also remove the Kconfig options there and relay on the DTS.

@emob-nordic could you please take another look?

Is config USB_CDC_ACM_DEVICE_NAME still needed?

Is config USB_CDC_ACM_DEVICE_NAME still needed?

no, thanks for the hint.

I've tested changes for ARC (both GNU and MWDT toolchains) - everything seems to be OK.

@emob-nordic @mbolivar-nordic could you please take another look?

I think you could put some more info in release notes. Especially that cdc_acm is no longer being enabled by Kconfig option and dts overlays are used instead. You just wrote about removing *_ON_DEV_NAME options.

Especially that cdc_acm is no longer being enabled by Kconfig option and dts overlays are used instead.

It is still enabled/disabled by Kconfig option CONFIG_USB_CDC_ACM, it is default to 'y' if a compatible node is enabled, but even then one can still disable CDC ACM class support in prj.conf file with CONFIG_USB_CDC_ACM=n.

^^ @jfischer-no Unfortunately I discovered build bug after the merge of zephyr-project/mcuboot/pull/57.

^^ @jfischer-no Unfortunately I discovered build bug after the merge of zephyr-project/mcuboot/pull/57.

https://github.com/zephyrproject-rtos/mcuboot/pull/59 should fix it.


Links and tabs drag and dropping into bookmark folders are moved to default bookmark folder

This makes managing bookmarks outside of the new default bookmark folder difficult.
Instead only bookmarks added via the instant bookmark button or the context menu "Bookmark tab(s)" should be directed to the default bookmark folder but other bookmarks added to a specific location should be allowed to go into the place where they've been put.
I can't use default bookmark folder in its current state unfortunately.  I struggle to even add new links to my bookmark toolbar

Having this issue as well. I really just want to use the default folder for when I press ctrl D or hit the star. If I am dragging a tab or link into a specific folder I would think it should go there, rather than to the default (only to be sorted again)

"This regression cannot be fixed in the current state of the APIs" according to release notes for version 3.0, however this bug is not present in the prior version(2.13.0), which I've simply never updated from due to this issue.

Confirming this bug is still present in 4.0. This breaks a daily use case of bookmarks for me so I still cannot update. 2.13 functionality still working perfectly


Feat/add settings to write

Summary
Support ClickHouse insert settings for table writes (#369)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mahdi Malverdi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Cpu Memory leak

i used craft in different environment :
with pytorch 1.2 yet i dont observe any memory leak( cpu memory)
with pytorch 1.4 yet i dont observe any memory leak( cpu memory)
with pytorch 1.6 ---------------!!!! MEMORY LEAK----------- (After 3 hours run)
is this proven for this rep or am i wrong?
you know that memory leak can have many reasons so i'm not sure

I can confirm memory leak as well, CPU or GPU, at every prediction I register a 10 to 100 MB leak. Do you have any news?


Update main.c (IDFGH-3769)

Fix to make example work multiple times, i.e. every time GPIO0 changes from low to high or high to low the main processor wakes from deep sleep

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

Hi @uLipe
thank you very much for getting back to me. I appreciate it. I tried your suggestion and added ulp_riscv_shutdown() instead of the break statement. The result is the same as with the original, unmodified example - the main processor is woken up once, then ULP enters low power mode and the main processor goes into deep sleep.
Since the example is meant to do exactly that, my pull request is obsolete and I will close it.
Thanks
Felix


Refactor repo structure

Making this as a draft PR to allow for comments and questions. There's also a problem with the build, I think I dropped a -fPIC at some point so will fix that if I can see where it's coming from. Also you might hate this refactor which is completely fine, happy to drop it!
Large structural changes involved are:

Creation of an apps directory which stores the binaries output from pymatching (happy to rename this to bin or anything similar)
Creation of an include directory which stores all of the headers
Abstraction of some of the libraries (which is reflected in src and include
Conditionally building the python package (There's probably better conditions we can add to this, maybe a -DBUILD_PYTHON which we can add in the setup.py file)

I hope these changes make the code a little more extensible and modular. In the future if there's separable logic that can have it's own library (own directory in src) then this facilitates that and decouples the code. It should also improve build times overall since it has a proper dependency graph and can compile once link many as required.
Thanks so much Oscar for all the work on this!

Codecov Report
Patch and project coverage have no change.

Comparison is base (a58fe36) 100.00% compared to head (614059f) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          331       331
=========================================
  Hits           331       331

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I don't like moving the headers into include/ and tests into test/. Subjectively speaking, I don't like you're taking files that are strongly related and putting them far apart so I can't as easily key between them in clion. Slightly less subjectively, the google style guide is to put headers next to source. Also, it's creating a huge diff that's obscuring the actual changes.
One issue that grouping the files solves is the cmakelist file having to say every file. cmake unfortunately has much worse file globbing than bazel, so you can't just say "match this pattern but not that one". In stim the workaround was to use file lists and a script to regenerate the list and a CI check that the file list was up to date.

Hi Craig, thanks for the feedback. The refactoring here mostly follows other CMake projects I've made and worked on which uses this sort of structure as in this example. I didn't consider the google style guide explicitly but had it in the back of my mind. I'm assuming the relevant sentence from the link was

All of a project's header files should be listed as descendants of the project's source directory without use of UNIX directory aliases . (the current directory) or .. (the parent directory).

But that only seems to say that the paths in the include string shouldn't include . or .. not necessarily saying where the header should be. Sorry if I've missed the relevant part of the style guide but I couldn't find a sentence explicitly saying include directories should be avoided. I don't use CLion so can't comment on that.
I personally don't find the globbing problem too difficult, once it's done once it doesn't take much maintenance and is less error prone than a glob. I agree though that whilst the glob support of CMake is there it's not the most helpful.
Just to clarify that the only changes I really wanted to add here is this refactor, other changes such as removing the pybind submodule is purely a consequence of that.

I was referring to this line. I guess it's more of a suggestion line than a requirement:

dir/foo.cc and dir2/foo2.h are usually in the same directory (e.g., base/basictypes_test.cc and base/basictypes.h), but may sometimes be in different directories too.

I can at least confirm that internally the .h is in fact usually next to the .cc

Hi Adam, many thanks for your work on this. While it would be nice to improve build times/extensibility/modularity, I do also have the same subjective preference as Craig for having the related .cc/.h/.perf.cc/.test.cc files next to each other for ease of access in an IDE, so I'd prefer to leave that structure intact if possible. Are there any changes you'd still propose making without this aspect of the refactor?


Add support for font-specific formats

Text: ← filenames: FONTLOG http://scripts.sil.org/cms/scripts/page.php?item_id=OFL-FAQ_web#43cecb44
OpenType: ← extensions: .fea https://www.adobe.com/devnet/opentype/afdko/topic_feature_file_syntax.html
Spline Font: ← extensions: .sfd http://fontforge.github.io/en-US/documentation/developers/sfdformat/

You'll need to fix the order of file extensions. From the build's feedback:
TestPedantic#test_nonprimary_extensions_are_sorted [/home/travis/build/github/linguist/test/test_pedantic.rb:15]:
.mkdown should come after .md.txt

@Crissov Thanks for the pull request! Please see the guidelines to add support for a new extension to Linguist to complete the additional steps required.

@Crissov You can use this package to provide syntax highlighting for OpenType feature files and spline-font databases. The relevant scopes are:

OpenType feature file: source.opentype
SFD: text.sfd

Also, it appears the "proper" name for the former is "OpenType feature file", not "OpenType font feature". That's going by how the spec refers to the format.
You'll also need to change OpenType's language type to data, as previous suggested. It's not markup.

Sorry about the long wait! Didn't mean to take this long to get back to you. 😞
Alright, great news: all three additions check out.
.sfd
Bit surprised by the abundance of these files; I hadn't expected FontForge's .sfd format was so well-distributed, heh. 11,018 files on GitHub, hosted among 880 users among 1,042 unique repositories. Definitely worth inclusion.
Each of the .sfd files harvested from search results turned out to be a Spline Font Database, so I don't predict there'll be any files misclassified here.
.fea
These are slightly less distributed than .sfd files, but still too abundant to ignore: 14,236 indexed results, and among the 2,695 files I downloaded, half of which were duplicates, but distributed between 278 users among 404 unique repositories.
FONTLOG
Can't really go wrong here... 17,730 results, each with consistently similar content and structure.

Now, you'll need to fix a few things before we can merge this:

Pull/merge the latest changes from master into your branch
Rerun script/set-language-ids --update to fix missing/conflicting language IDs
Tweak each entry's name in languages.yml

/cc @pchaigno, @larsbrinkhoff

@Crissov Uhm, you've... kind of committed the conflicts you were supposed to fix. The diff for languages.yml is too large to open on GitHub, so I can't comment on the conflicted areas directly.
The affected regions are lines 2956-2969 and 4041-4052. Just erase the the blank lines and <<<<====>>>> junk, and rerun script/set-language-ids --update.

@Crissov Just paging you with a reminder we're still waiting for the conflicts to be fixed before we can finish our review. =)

@Crissov looks like this is near the finish line, but you have some additional conflicts to resolve.

@Crissov I sense you may be having difficulties, so I sent you a pull request to resolve these conflicts.

Alright, there're two build failures, but only one of them we can fix (the second failure isn't your fault; it's currently a known issue).
This is the one we still have to fix:
  1) Failure:
TestLanguage#test_all_languages_have_grammars [/home/travis/build/github/linguist/test/test_language.rb:409]:
The following languages' scopes are not listed in grammars.yml. Please add grammars for all new languages.
If no grammar exists for a language, mark the language with `tm_scope: none` in lib/linguist/languages.yml.
OpenType Feature File source.opentype
Spline Font Database  text.sfd

I admit the error here was probably mine, since I hastily deleted my fork before seeing what the build result was. Silly me.
@Crissov Try these steps:

Clone your fork to a new directory on your system.
Checkout your branch patch-2
Run script/bootstrap to install the necessary submodules
Run the following:

perl -pi -e 's|script\K (?=list-grammars)|/|;' script/add-grammar
script/add-grammar Alhadis/language-fontforge
git add --all && git commit -m "Update submodules and fix grammar-list script"

Then push to your fork as you would normally.
Using script/add-grammar is the simplest fix here, but the current state of the script isn't working due an error in 43fa563b. I've added an extra step that fixes it in order to allow the script to run.
Probably not a clean way to do it, but hey.

@Crissov I've sent you a second pull request in the hopes of closing the book on this.
@pchaigno Tests were still failing locally for the Ant submodule (even after merging master into the fork's branch). Could this be related to licensee somehow?

@Alhadis You'll need to update dependencies: bundle update.

Ah, right. My understanding of what bundle even is is still really shaky.
Is it because I'm from the land of JavaScript, not Ruby? ;)

Is it because I'm from the land of JavaScript, not Ruby? ;)

I'm not sure I get it myself, but then I'm not sure either of which land I'm from :p

Actually, serious question: shouldn't there be a version check or something to ensure dependencies are up to date? Because I had no idea what was going on.

We could increase the version of Licensee needed in github-linguist.gemspec. I'm a little hesitant to do that because Licensee 8.7.0 isn't actually needed for anything else than tests.

@Crissov Could you please merge the PR so we can get this wrapped up?

@brandonblack This looks merge-ready to me. :shipit: ?
Please also remember to squash-merge; the PR's commit history is extremely convoluted and would pollute the codebase's revision history.

Thanks @Crissov!

It was really @Alhadis who did all the nasty work.


docs: Added release notes for kubespray v2.18.0-ck8s1

Added release notes for kubespray v2.18.0-ck8s1

Lovely!
Any reason why you favored <a> instead of Markdown-style [text](url)?

Only reason was that previous links were that way, so I assumed that's how you wanted it. But I'll gladly change it


CORS Flask (EB Deploy tweaks)

@BobTorgerson I think this still needs to be merged in, yeah?  Will keep as draft PR until you confirm!

No, it looks like this has already been merged into main and I'm going to close it.


audio effects

create audio effects to allow for effects such as fade in when audio is starting to play.
current pr allows for the following two options but can be enhanced to allow a group of effects. Other effects should be added prior to merging...

fadeInAudio: true,
fadeInLength: 10000,
fadeOutAudio: true,
fadeOutLength: 10000

todo

[x] add fade in audio
[ ] add fade out audio
[ ] other audio effects?
[ ] allow multiple effects to be applied in options?

discussion #2688

@entonbiba do you think this could be something better handled in a plugin maybe?

@entonbiba I suggest we close this PR then. Please feel free to make a new one with a plugin. Cheers!


show full error_chain

{"success":false,"errors":[{"code":6003,"message":"Invalid request headers","error_chain":[{"code":6100,"message":"Missing X-Auth-Email header"},{"code":6101,"message":"Missing X-Auth-Key header"}]}],"messages":[],"result":null}

@gnowxilef - this is now done in python-cloudflare under [Cloudflare)(https://github.com/cloudflare). I made the return value from an exception a class and allowed it to be a single value or an array/list.
import sys
import CloudFlare
import CloudFlare.exceptions

    ...
    try
        r = ...
    except CloudFlare.exceptions.CloudFlareAPIError as e:
        if len(e) > 0:
            sys.stderr.write('api error - more than one error value returned!\n')
            for x in e:
                sys.stderr.write('api error: %d %s\n' % (x, x))
        exit('api error: %d %s' % (e, e))
    ...

It's implemented in exceptions.py.
Enjoy!


(GH-96) Support installation through background service

Support installation through background service
FIxes #96

Once https://github.com/chocolatey-community/chocolatey-coreteampackages/pull/1560 is merged this can be rewritten to use the extension