Watchdog fires during task_wdt_add()

The task watchdog will fire while the calling thread is in the middle of the task_wdt_add() function.
To Reproduce
Build Zephyr, add preemptible thread that only activates the watchdog while the thread is active.
Expected behavior
Watchdog does not fire before timeout.
Impact
Critical bug - watchdog must be reliable.
Logs and console output
N/A - See stack information in description.
Environment (please complete the following information):

OS: Windows 11
Hardware: nRF52840 DK board
Toolchain: nRF Connect SDK v2.2.0
Zephyr: Tag v3.2.99-ncs1

Additional context
I captured the condition in a debugger and this is what's happening at the point of failure.
for (int id = 0; id < ARRAY_SIZE(channels); id++) {
	if (channels[id].reload_period == 0) {
		channels[id].reload_period = reload_period;
		channels[id].user_data = user_data;
		channels[id].timeout_abs_ticks = K_TICKS_FOREVER;
		channels[id].callback = callback;

		####<<<< TASK PC IS HERE >>>>####
		if (!hw_wdt_started && hw_wdt_dev) {
			/* also start fallback hw wdt *

The "expiration" happens because reload_period has been set to a non-zero value and wdt_feed() has not yet occurred.
if (bg_channel || channels[channel_id].reload_period == 0) {
	schedule_next_timeout(sys_clock_tick_get());
	return;
}

if (channels[channel_id].callback) {
	####<<<< SYSWORKQ PC IS HERE >>>>####
	channels[channel_id].callback(channel_id,
		channels[channel_id].user_data);
} else {

It should be noted that the task calling task_wdt_add() uses preemptible priority, whereas the sysworkq and timer threads are cooperative.  There are no synchronization primitives being used in task_wdt to guard against timer expiration between the reload value becoming non-zero and the initial feeding of the watchdog (added in #39523).
The use case behind this is having a watchdog that is only active when the task is not sleeping.  task_wdt does not support suspending a watchdog after being added, so the main loop executes code like this:
// Start of (preemptible) thread loop
int wd_id = task_wdt_add(5000, my_watchdog_handler, k_current_get());
// Do stuff with watchdog active...
task_wdt_delete(wd_id);
// End of thread loop

Thanks @dpkristensen for reporting the bug.
I'm not quite sure if I fully understand the circumstances where this race condition happens. Do you have a complete example to reproduce the issue that you could push to a git repo somewhere? I've got a nRF52840 DK which I could use to test.
And do you think another k_sched_lock() in the task_wdt_add() function would do the trick?

The "expiration" happens because reload_period has been set to a non-zero value (-1 in this case) and wdt_feed() has not yet occurred.

How can reload_period be set to -1? It is a uint32_t.

WRT your other question:

And do you think another k_sched_lock() in the task_wdt_add() function would do the trick?

Yes, it should fix it too; my solution with the boolean may not be ideal, just offering it up since it did work for me on this MCU.


sim: add sqlite to further analyze sim runs

What is the purpose of the change
This PR introduces basic sqlite functionality to the simulator. Once this gets approved, we can gather more data as well as provide make commands to show basic trends with the provided dataset.
If WriteStatsToDB is set to True, after a simulator run a file named blocks.db will be written to the osmosis/tests/simulator/ folder. This database file provides the following information:

Brief Changelog

Adds sqlite to simulator
Adds flag WriteStatsToDB
Adds basic gas info to new messages (legacy messages had been added through an SDK PR)
Adds the following data struct used by SQL:

blocks(height, module, name, comment, passed, gasWanted, gasUsed)

Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? not applicable

Err, can you add blocks.db to the gitignore and delete it from repo! Happy to merge this after that, and we can do followups subsequently


custom bottom navigation bar.

I want to use the images in the bottom navigation bar instead of the predefined icons.
In a way like one image for the selected state and another (2nd image) for the unselected state. or any other possible way regarding that?

@Ammar-Ishfaq - we'll add this feature as an enhancement to the menu

Support custom widget for bottom navigation bar item. Include selected and unselected state.

Sharing few menu examples for reference

@vinothvino42 please start by proposing a YAML on how to handle these use cases. We should mostly similar to the menu today so it's not a huge lift to implement these.

@vinothvino42 please start by proposing a YAML on how to handle these use cases. We should mostly similar to the menu today so it's not a huge lift to implement these.

Sure I'll look into it

@vusters Currently, we're the BottomNavigationBarItem with an icon widgets by default from different sources (default material icons, fontawesome, etc).
Can we create a new CustomBottomNavigationBar with activeIcon and inactiveIcon as a parameter that accepts any widget?
View:
  title: "Menu: bottomNavBar"
  menu:
    CustomBottomNavBar:
      items:
        - label: Home
          activeIcon: MyCustomActiveIconWidget
          inactiveIcon: MyCustomIconWidget
          page: Home

        - label: Search
          activeIcon: MyCustomActiveIconWidget
          inactiveIcon: MyCustomIconWidget
          page: Search

        - label: Chat
          activeIcon: MyCustomActiveIconWidget
          inactiveIcon: MyCustomIconWidget
          page: Chat
          selected: true
  body:
    Column:
      styles: { gap: 16, padding: 24, scrollable: true }
      children:
        - Markdown:
            text: |
              This page includes menu displayed as bottomNavBar

It's closed now with the PR #412


The "Spell" text in the Edit Spell window is cut off at the top

If the user goes to the "Spells" tab and attempts to edit a spell, in the window they are presented with, the "Spell" text is cut off at the top.

@ckwk Is this in the app, or in a browser?

@mooped In the browser, Firefox - Linux.  Wouldn't surprise me if it was a Firefox issue

As with https://github.com/cyface/foundryvtt-dcc/issues/23 , this seems to happen in the windows for editing Equipment, Mounts, and Ammunition as well.

Equipment, mounts, and ammunition currently share a template. Spells are a variant on that template and I consider them a rough placeholder currently.
I'll try and fix the styling on that text, but I'm also open to ideas on better ways to indicate the type of the item being viewed.


Namespace flag causes completion error.

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Kubernetes version (use kubectl version):
(Output is current, but this is after I upgraded from 1.6.4 where I first saw the problem)
Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.5", GitCommit:"490c6f13df1cb6612e0993c4c14f2ff90f8cdbf3", GitTreeState:"clean", BuildDate:"2017-06-14T20:15:53Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.5", GitCommit:"894ff23729bbc0055907dd3a496afb725396adda", GitTreeState:"clean", BuildDate:"2017-03-22T00:17:51Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}
Environment:

Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): VERSION="16.04.2 LTS (Xenial Xerus)"
Kernel (e.g. uname -a): 4.8.0-56-generic
Install tools:
Others: using zsh

What happened:
typed: kubectl --namespace=$NAMESPACE g then hit tab
kubectl threw an error kubectl --namespace=foo g__handle_flag:25: bad math expression: operand expected at end of string
What you expected to happen:
g would complete to 'get'
How to reproduce it (as minimally and precisely as possible):
enter  kubectl --namespace=foo g and hit tab
Anything else we need to know:
Does not happen without the --namespace flag

This is not an issue specific to --namespace. It can happen with all flags in the format --flag=val in zsh only.
$ kubectl --context=minikube __handle_flag:25: bad math expression: operand expected at end of string

Then, I found that this issue is caused by the flaghash variable in __start_kubectl() to be not a global variable. The following is the minimum reproduction code.
https://gist.github.com/superbrothers/6427b3a7853aa4043dc436189794245a
The following is the fixed code.
https://gist.github.com/superbrothers/41cdb44d30658c42ab5df8b936a66eb8
This issue is complicated because the code in the flaghash part is generated by cobra, but cobra does not support zsh. It is implemented by kubectl.
https://github.com/spf13/cobra/blob/8c6fa02d2225de0f9bdcb7ca912556f68d172d8c/bash_completions.go#L259
There are two ways to fix this issue.

Create a PR that fixes the flaghash variable in cobra/bash_completion.go to be a global variable.

https://github.com/superbrothers/cobra/commit/d4ea9c4fcd6fc1d2b1ed5ec9de87a3f1e4a35da8
As bash works fine, so is this PR appropriate for cobra?

Convert the flaghash variable to be a global variable by __kubectl_convert_bash_zsh().

https://github.com/superbrothers/kubernetes/commit/174a1e952c31be5ae95540b5447394d8a76ff12c
This way is vulnerable to changes in cobra.

I've tested both changes with both bash and zsh.

@superbrothers If you think this is a bug for cobra, you can try to fix it upstream.

@mengqiy I was thinking about this, I found out that this is not a bug for cobra. I will create a PR for kubectl.


Add check for onOuterMovement

Working on a solution for #76

@jasonkuhrt Could you review this PR?

@Kerumen could you check this PR out? Would like to know if there's better ways of managing it.

Thanks @kartikluke! I'd like to get some test coverage going on this before merging, ideally. I've been learning how to work with puppeteer recently. I'll bring those learnings back to this project in the future.

@jasonkuhrt @kartikluke Any updates here?


Specifying latest PSR log to avoid minimum-stability issues

If a 3rd party has minimum-stability: stable set in their composer.json, they are un able to install rollbar-php.  This is due to rollbar-php requiring psr/log @ dev-master which is not a stable release.
It is best practice to include a specific version for a vendor library

This is resolved with #305

Closed it by mistake

Seems reasonable to me


Subgraph package updates from se2 main

Description
Tested and all is working well.
Additional Information

[X] I have read the contributing docs (if this is your first contribution)
[X] This is not a duplicate of any existing pull request

Related Issues
NA
Your ENS/address: Shutterblock.eth

Tested this - works like a charm. Thanks @technophile-04 !


buy credits screen hangs on desktop

Go past country selection and then this happens

Probably related to electron update, see this in console:
Uncaught (in promise) DOMException: Renderer process could not establish or lost IPC connection to the PaymentRequest service in the browser process.

This is still broken with the recent fix.

This is still broken with the recent fix.


Fix app crashes after setting date range

Fixes #336, #331, #301
Hooks should only be called from the top-level of React Function Components or custom Hooks, which is why there have been various crash issues reported.
This PR is a quick-fix to prevent severe crashes, but there is likely a more elegant solution that can be submitted in a follow-up PR

Thank you for your contribution! :)

You're welcome, thank you for creating this tool! I have gotten many compliments from interviewers regarding the layout + style of my resume


chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.2.3

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.2.0 -> v1.2.3

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper
v1.2.3
Compare Source
Bug Fixes

deps: update module github.com/ibm/platform-services-go-sdk to v0.29.1 (#162) (c0d1a05)

v1.2.2
Compare Source
Bug Fixes

deps: update module github.com/ibm/platform-services-go-sdk to v0.29.0 (#161) (7f9fe3c)

v1.2.1
Compare Source
Bug Fixes

deps: update gomod (#157) (0baa3b2)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Invalid exports in package.json

exports["."].browser.import points to ./dist/react-textarea-autosize.browser.cjs.mjs, which doesn't exist.
There are a few other paths in exports which don't exist, but I'm having problems with that one (in Jest environment with ESM).

Thank you for the report! I located the problem and I'm fixing it here


Display elements filtered out at the end with a given opacity

Hi!
This plugin is awesome!
Im wondering how could I display elements filtered out, but arranging them at the end with opacity 0.4?
So basically everything remains visible, but order and opacity changes.
Example: if im filtering apples they go to the beginning and bananas oranges etc to the end with 0.4 opcaity.

I would suggest the following:

Use MixItUp only to sort the container
Use the sort API with an element collection to move the elements you want to fade out to the end of the list.
On completion, query the DOM again for those elements, and apply a styling class via JavaScript to each of them which result in a reduced opacity.
At the start of any subsequent operations, remove this styling class from all elements.


Upload & Bulk Upload

Feature request
Summary
I've created new feature upload & multiple file upload, can i contribute ?
Why is it needed?
It's helpful when we have upload feature
Suggested solution(s)
Related issue(s)/PR(s)

Hi @aldycavalera
Can you provide more informations about what you plan to do like code snippet, examples? ☺

Okay, so strapi had upload feature, it seems like strapi-sdk-js doesn't have the features that allow user to upload their files yet. So i made a simple function to achieve that, i created these two :
upload(file, callback)
to upload single file
const file = new File(['foo'], 'bar')
await strapi.upload(file, (res) => {
    console.log(res)
})

bulkUpload(files, callback)
Upload multiple files at once
const files = [new File(['foos'], 'bars'), new File(['bars'], 'foos')]
await strapi.bulkUpload(files, (res) => {
    console.log(res)
})

it would be awesome if you allow me to create a pr, and submit a review :)

hey, what is the current status of this issue

For now there is no plan to add an upload method set but will look into it to check if it's relatively needed

@Stun3R  can I make a PR for this


sticky top-nav

Hello, greetings!
I would like assistance in creating a sticky top bar for my website. Could you please help me with that?
Thank you.

You can use shadcn nav components here : https://ui.shadcn.com/docs/components/navigation-menu


Update IronPython.wxs

Add "VSNet45ReferenceAssemblyKey" back, so that VS can find the IronPython related dll files.
Reference: https://github.com/dotnet/msbuild/blob/main/src/Tasks/Microsoft.Common.CurrentVersion.targets#L641

Not sure if it relates to https://github.com/IronLanguages/ironpython3/pull/1601#issuecomment-1339587979

Why would you not use a PackageReference instead?

I have a project which only refers (and only want to refer) IronPython.dll.
With PackageReference, the project will refer IronPython.Modules.dll, IronPython.SQLite.dll and IronPython.Wpf.dll

PackageReference shouldn't add an assembly reference if you don't use anything from the assemblies. For example, if you only use Python.CreateEngine then your assembly will only reference IronPython.dll. You can also srt it up so the assemblies are only available at compile time (e.g. with IncludeAssets="compile").


Use CircleCI to paralellize the build.

Use a CircleCI matrix param to parallelize the build.

Update build-bumper to include circleci config
Use docker image save trick to persist docker images between build and
publish.

Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

Still needs some work, but getting closer.

I'm also thinking about completely eliminating the versioned directories, and moving to a template-based Dockerfile setup.
Something like this Dockerfile.j2.

Is this still WIP?

Ok, fixed the image saving in the workflow, this should publish correctly now.

Ping


NoneType has no len() error.

Describe the bug
I'm getting a cryptic error message after removing a module.: TypeError: object of type 'NoneType' has no len()
Steps To Reproduce
dbt clean
dbt run
(I'm sure the problem is something to do with my project.yml but i'm not sure what exactly is throwing the error.... will report back when i can.)
Expected behavior
An error message that will help me fix my configs/project.yml
Screenshots and log output
2021-01-15 11:19:42.774812 (MainThread): Traceback (most recent call last):
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/main.py", line 124, in main
results, succeeded = handle_and_check(args)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/main.py", line 202, in handle_and_check
task, res = run_from_args(parsed)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/main.py", line 255, in run_from_args
results = task.run()
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/task/runnable.py", line 399, in run
self._runtime_initialize()
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/task/runnable.py", line 118, in _runtime_initialize
super()._runtime_initialize()
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/task/runnable.py", line 78, in _runtime_initialize
self.load_manifest()
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/task/runnable.py", line 65, in load_manifest
self.manifest = get_full_manifest(self.config)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/perf_utils.py", line 31, in get_full_manifest
adapter.connections.set_query_header,
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/manifest.py", line 678, in load_manifest
return ManifestLoader.load_all(config, macro_manifest, macro_hook)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/manifest.py", line 348, in load_all
loader.load(macro_manifest=macro_manifest)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/manifest.py", line 204, in load
self.parse_project(project, macro_manifest, old_results)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/manifest.py", line 177, in parse_project
self.parse_with_cache(path, parser, old_results)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/manifest.py", line 133, in parse_with_cache
parser.parse_file(block)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/base.py", line 429, in parse_file
self.parse_node(file_block)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/base.py", line 402, in parse_node
self.render_update(node, config)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/base.py", line 377, in render_update
self.render_with_context(node, config)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/parser/base.py", line 289, in render_with_context
parsed_node.raw_sql, context, parsed_node, capture_macros=True
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/clients/jinja.py", line 577, in get_rendered
return render_template(template, ctx, node)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/dbt/clients/jinja.py", line 528, in render_template
return template.render(ctx)
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/jinja2/environment.py", line 1090, in render
self.environment.handle_exception()
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/jinja2/environment.py", line 832, in handle_exception
reraise(*rewrite_traceback_stack(source=source))
File "/Users/JoshuaLayton-Wood/venvs/dbt/lib/python3.7/site-packages/jinja2/_compat.py", line 28, in reraise
raise value.with_traceback(tb)
File "
System information
Which database are you using dbt with?

[X ] bigquery

The output of dbt --version:
0.18.0

The operating system you're using:
MAC OS
The output of python --version:
3.7.3
Additional context
I've recently removed the snowplow module and copied some of the models into my own models folder.  reversing these steps gets rid of the problem.

Hey @joshuaLW, this is indeed a cryptic error. The question of removing the Snowplow package seems like a good place to start debugging.

Do you have anything else in packages.yml?
Do you still have references to the snowplow package in dbt_project.yml?

Hey @joshuaLW, this is indeed a cryptic error. The question of removing the Snowplow package seems like a good place to start debugging.

Do you have anything else in packages.yml?
Do you still have references to the snowplow package in dbt_project.yml?

@jtcohen6  three things... I never actually checked that the snowplow modules were removed from packages when i ran "dbt clean" but now having reversed these changes with "dbt deps" I've only this in that file:
packages:

package: fishtown-analytics/snowplow
version: 0.11.0

I did comment out all variables and models referencing the snowplow package in the project.yml
I didn't remove all dependencies upon snowplow from my models  but i expected to get an error of the kind model x refers to model y that does not exist.

@jtcohen6  three things... I never actually checked that the snowplow modules were removed from packages when i ran "dbt clean" but now having reversed these changes with "dbt deps" I've only this in that file:
packages:

package: fishtown-analytics/snowplow
version: 0.11.0

I did comment out all variables and models referencing the snowplow package in the project.yml
I didn't remove all dependencies upon snowplow from my models  but i expected to get an error of the kind model x refers to model y that does not exist.

I did comment out all variables and models referencing the snowplow package in the project.yml

If I had to pick one of the three as the likeliest cause, I'd say it's this one. Try removing snowplow from packages.yml, run dbt clean, leave the vars in place, and then see what error you get back. (I hope it will be of the missing-ref kind.)

I did comment out all variables and models referencing the snowplow package in the project.yml

If I had to pick one of the three as the likeliest cause, I'd say it's this one. Try removing snowplow from packages.yml, run dbt clean, leave the vars in place, and then see what error you get back. (I hope it will be of the missing-ref kind.)

@jtcohen6  good shout.  I've just tried emptying the packages.yml then running dbt clean and i'm getting the errors i expected  eg. "model x depends on y" so i'll keep going with cleaning up my models till all dependancies are removed... and hopefully it was just that... :) FWIW I thought dbt clean would have cleaned my packages.yml too... but computers can't read my mind can they?

@jtcohen6  good shout.  I've just tried emptying the packages.yml then running dbt clean and i'm getting the errors i expected  eg. "model x depends on y" so i'll keep going with cleaning up my models till all dependancies are removed... and hopefully it was just that... :) FWIW I thought dbt clean would have cleaned my packages.yml too... but computers can't read my mind can they?

@jtcohen6  yup  i found the line that was causing the problem.  It was a reference to a variable that was nested in the package i'd removed.

@jtcohen6  yup  i found the line that was causing the problem.  It was a reference to a variable that was nested in the package i'd removed.

There it is! Well found.
I think it would be an improvement to the snowplow package if its models handled better the case when var('snowplow:pass_through_columns) is undefined in the project (None), rather than merely empty ([]`).
Perhaps by rewriting that line to be:
{% if var('snowplow_pass_through_columns', []) | length > 0 %}

That way, if you do want to copy-paste the model code into your own project, and (sensibly) remove the snowplow-specific vars from your project config, you won't be stymied by a cryptic error.
I'm going to transfer this issue to the snowplow package repository, since that's where the change should take place.

There it is! Well found.
I think it would be an improvement to the snowplow package if its models handled better the case when var('snowplow:pass_through_columns) is undefined in the project (None), rather than merely empty ([]`).
Perhaps by rewriting that line to be:
{% if var('snowplow_pass_through_columns', []) | length > 0 %}

That way, if you do want to copy-paste the model code into your own project, and (sensibly) remove the snowplow-specific vars from your project config, you won't be stymied by a cryptic error.
I'm going to transfer this issue to the snowplow package repository, since that's where the change should take place.


fix: 修复紧凑模式下数值单元格错误的展示了省略号

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #0

📝 Description

紧凑模式下列宽以单元格文本宽度为准 (前50), 不应该出现省略号
🖼 Screenshot

Before
After

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v2.0.0-next.17 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v2.0.0-next.16 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add a few interesting UI Demo

Hi @CuriousNikhil , Great K5 Compose Playground! Loving it!!
I have added a few interesting demo, e.g.

More info at https://medium.com/mobile-app-development-publication/jetpack-compose-animation-under-50-lines-using-k5-compose-playground-bef35060c471
Feel free to merge if you see fit. Thanks!

Awesome!!!! This is super cool!
Thanks a lot for this PR! I loved playing with your examples! 🚀


Extension seems to break apple.com logins

Hey there, thanks for building this! I haven't debugged the issue at all, but I noticed that having this extension activated seems to subtly break all apple.com logins (appleid, developer and support all had different errors/behaviors) in different ways. Just opening an issue as a heads up.

Thanks for taking the time to report this @tlancina! I haven't been able to reproduce this. Would you be able to provide some steps to reproduce as well as some specs of your local setup (OS, browser, browser version, extension version).

@tlancina I've pushed a fix for this. The new version (1.1.1) is currently being published in both the Chrome and the Firefox webstores. Hope you give the extension another try 😃

Thanks for the fix! I’ll give it a shot and let you know if I have any
issues.
On Sun, Aug 6, 2023 at 13:29 Dimitrios Dedoussis @.***>
wrote:

@tlancina https://github.com/tlancina I've pushed a fix for this. The
new version (1.1.1) is currently being published in both the Chrome and
the Firefox webstores. Hope you give the extension another try 😃
—
Reply to this email directly, view it on GitHub
https://github.com/dedoussis/icloud-hide-my-email-browser-extension/issues/30#issuecomment-1666961056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGEL24QROKJ3CAPCI7JYMDXT75BFANCNFSM6AAAAAAW5XJG3I
.
You are receiving this because you were mentioned.Message ID:
<dedoussis/icloud-hide-my-email-browser-extension/issues/30/1666961056@
github.com>


Add ReferencesArray and DynamicReferencesArray helpers

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

This is helpers for references from factory. May be move them to yiisoft/factory?

This is helpers for references from factory. May be move them to yiisoft/factory?

It is used in the container configs only

Need usage examples in phpdoc. Now it's not clear what's the benefit in having these.

Need usage examples in phpdoc. Now it's not clear what's the benefit in having these.

See https://github.com/yiisoft/data-response/pull/60


Definition of correct answer not on the screen long enough to read.

The word is checked against free dictionary API to validate that the answer is a real word and if it is, the definition of the word is displayed on screen.  As the aim of the game is to find as many words as you can within the 3 minutes The time that the definition is on screen for is not long enough to read.

I will pick this one up

Have updated this, so the word and definition now show below the answer window until the next correct answer is submitted.


Compatible with NOT operator which is not sharding-column in SQL for where condition

Please answer these questions before submitting your issue. Thanks!
Which version of Sharding-Jdbc do you using?
1.5.2

fixed at 1.5.3


refactor: ModelKind with strum + derive_more

This is something to consider, but would be a bit awkward without replacing ModelKind as a breaking change.
It was something I explored after https://github.com/EricLBuehler/mistral.rs/pull/334 and depends on it for strum, likewise I've not added the derive-more crate here either. Going forward with such a change for this type would be rather large, but can be done if deemed worthwhile.
I noticed quite a bit of logic to support the different kinds is mostly repeated with very little if any differences. Meanwhile some logic looks like it's already falling out of sync, thus reducing the noise throughout the codebase may help focus on minimizing that concern?

I'm not sure if Lora quantized kinds were intentionally excluded here, could simply be a call to kind.is_quantized()?:
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-bench/src/main.rs#L316-L326
There seems to be some logic to detect a difference between lora and xlora types? (the ModelKind could better indicate that or similar?):
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-core/src/pipeline/gguf.rs#L406-L407
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-core/src/pipeline/gguf.rs#L473-L476
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-core/src/pipeline/gguf.rs#L498-L507
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-core/src/pipeline/normal.rs#L297

Many of these would be collapsed to the compound type proposed by the PR:
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-core/src/pipeline/normal.rs#L231-L234
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-core/src/pipeline/normal.rs#L277-L284
Whereas these would need additional refactoring, but all have the same shape for parameters that they could pass in a struct?
https://github.com/EricLBuehler/mistral.rs/blob/1d5f9f3a4cb5a0e4bd408cabd1f2b8fb549b4c57/mistralrs-core/src/pipeline/normal.rs#L235-L276

The builder methods also seem rather suitable for deferring to a crate to derive, and that would work better with a breaking change away from these large parameterized methods funneling data through them.
I won't have time to tackle such any time soon, but something to consider as more models and features are added before this sprawls further 😅

@polarathene, thanks for proposing these changes. Currently, this code is a bit obscure, so any changes to make it more idiomatic is much appreciated. I left some comments below. It also looks like the Clippy lints are failing like #334, can you please take a look?

I'm not sure if Lora quantized kinds were intentionally excluded here, could simply be a call to kind.is_quantized()?:

Yes, that is a mistake. Can you please add an kind.is_quantized() function?

There seems to be some logic to detect a difference between lora and xlora types? (the ModelKind could better indicate that or similar?):

I think some methods on ModelKind would make this possible.

Many of these would be collapsed to the compound type proposed by the PR:

Sounds good!

Whereas these would need additional refactoring, but all have the same shape for parameters that they could pass in a struct?

Yes, I think we could do that. Please feel free to draft something here!1

Sure I'll tackle the feedback later today, current tasks for this project are:

Wrap another refactor PR (larger).
Get the earlier strum PR merged.
Rebase here and resolve concerns + additions.

Great! I think that making the code more idiomatic now before I merge #309 (Idefics 2 vision model) or #324 (Nomic embedding model) which would add lots of complexity.

Can you please add an kind.is_quantized() function?

@EricLBuehler how should this work for Speculative? At a glance it seems both target and draft fields can vary in model used, the toml-selectors  examples I saw have one that is a base + quantized and another that is quantized + quantized.
I don't know how this type/feature works, so what would be the expectation if is_quantized() was called on that kind variant? Likewise I was thinking to add a quantized_type() and adapter_type() that returns an option of the quantized/adapter kind when valid else None. Since target and draft can differ in ModelKind I'm not sure how I should approach that beyond None 🤷♂

I think for these methods, we should return a vector of the resulting data or perhaps some sort of struct. That way, there is much more type-safe control, which really fits the spirit of this PR. For example, you can check if any are quantized with .any().

For the CI failed checks, I am a bit confused why these do not show up for me locally? Do you have any idea?:
# Commands used by CI:
cargo clippy --workspace --tests --examples -- -D warnings
cargo fmt --all -- --check

I have been using those before my commit and push, and both gave me changes to apply. But running them on the same content as what I pushed does not produce the CI failures 🤔

clippy:
error: unused import: `ModelKind`
Error:   --> mistralrs-server/src/main.rs:12:23

error: unused import: `ModelKind`
Error:  --> mistralrs-bench/src/main.rs:5:88

rustfmt:
-    if use_flash_attn && !loader.get_kind().is_quantized()
-    {
+    if use_flash_attn && !loader.get_kind().is_quantized() {
         warn!("Using flash attention with a quantized model has no effect!")
     }

I think the logic is inverted?

Good spotting! 😬
I'll resolve that shortly 👍

Just to confirm this concern I raised (as it'll be hidden in the resolved review comment):
https://github.com/EricLBuehler/mistral.rs/pull/335#discussion_r1609259445

NOTE: Speculative kind will also trigger this now. I am not 100% sure if that's desired?
This is due to the any() call, as I assume if either target or draft are quantized it may not be compatible, but likewise this does not guarantee is_quantized == true equates to Speculative having both as true.

ModelKind::Speculative { .. } may only be partially quantized (I've seen the draft always as quantized? While target may be quantized).

I assume it's better for is_quantized() to return true when there is any hint of quantization in the kind?
Unlike every other variant, you'd have a caveat where this must be kept in mind that it does not guarantee a kind that stores multiple kinds are all quantized.
Same applies for is_adapted() and the _and(|| { ... }) methods (which also use .any()).

Using .all() instead doesn't resolve the concern either.. so it might need to be documented with some context that variants like Speculative are prone to bugs?

Looks good. It seems like there are a few compat impls here which perhaps you can remove in a future PR by using ModelKindB? It seems much cleaner.

Yes, as I wasn't sure about breaking changes being approved I've been a bit cautious. A follow-up PR can remove the compat layers here when ModelKindB becomes the new ModelKind 👍

I think this breaking change is acceptable in a future PR. We're pre v1, so it is fine.

I'll tackle that after my next PR (dependent upon changes here) is sorted out 👍

I decided to mirror is_some + is_some_and that exist for Option type, this way you have a bit more flexibility and under the hood it handles the vec iteration without having to think about it.

I like this API. The old way with the boolean wasn't very idiomatic anyway.

NOTE: I have not applied this to gguf.rs and ggml.rs as I have a large refactoring PR already touching that. I can apply the same changes there after this PR is merged.

Sounds like a good idea.

In my upcoming PR it was a little awkward/noisy with this new approach to check if the kind has an Adapter and set variables is_lora + is_xlora.
Speculative isn't supported in the match arms for GGUF/GGML pipeline (probably a good reason for that?), so I can probably just assume only the first element returned from adapter_type() is relevant and use if let Some(a) with a.is_lora() + a.is_xlora() called directly instead of as a closure 👍

As I'm not really familiar with these features yet, am I right to assume that future adapters may be supported that aren't "LoRA" specific?
I am new to this domain, so I only have a surface understanding that LoRA is a technique to direct output towards a preferred style (I've noticed it can be applied with image, audio and text generation models). I think it's often referred to as a way to approach "fine-tuning" as a light-weight alternative via a separate file(s), as opposed to duplicating the model (weights?) data but with the adjustments merged (requiring much more disk space and inefficient for changing styles/adapters at runtime? Which the LoRAX project describes).
I have no idea about X-LoRA, and haven't found time to look into it yet.
Not too important to resolve for now, I'll continue with my refactoring and adjust when appropriate 😅
EDIT: I just took a glance at LoRAX docs for Adapters and noticed an Adapter type called Medusa that mentions "Speculative Decoding", which I assume is what Speculative is meant to represent?

I rebased and squashed the commit suggestions into the prior commit.
The two main.rs conditions for flash attention have been inverted. Should be good to merge 👍

If you're new to squash merge on Github, it should provide by default the content of each commit message I wrote, and use the PR name as the squash commit name (with link ref to this PR).

Speculative isn't supported in the match arms for GGUF/GGML pipeline (probably a good reason for that?), so I can probably just assume only the first element returned from adapter_type() is relevant and use if let Some(a) with a.is_lora() + a.is_xlora() called directly instead of as a closure 👍

Speculative needs 2 models, so all other pipelines can just ignore the possibility of loading it.

EDIT: I just took a glance at LoRAX docs for Adapters and noticed an Adapter type called Medusa that mentions "Speculative Decoding", which I assume is what Speculative is meant to represent?

Yes, but the Medusa method is a bit different. Speculative Decoding is a sampling technique which uses a (smaller, faster, less precise) "draft" model to accelerate inference of a (larger, slower, more precise) "target" model.


Refactored method Flask.make_response to improve readability

The method now looks at the type of the object returned from the view function, and returns a self.response_class object based on that type.
The docstring for the method has also been improved and contains a more
detailed explanation for what can be returned from a view function.
Also refactored the test for response creation.

The build seems to fail on Python 3. Any idea why?

In this project should I always prefix ascii strings with b? The build seems to fail because I didn't.

I fixed the test where I previously used try .. except: assert instead of pytest.raises. The problem was that I forgot to do app.testing = True. Otherwise exceptions aren't propagated to the test client, so the pytest.raises assertion failes. Now fixed.

@ThiefMaster Hey :) Any other improvements to this pull request?

@guyskk

the origin code rv, status_or_headers, headers = rv + (None,) * (3 - len(rv)) is better, shorter and cleaner.

I respectfully disagree. I think using status_or_headers makes the code very hard to follow. At any point it may hold different types depending on the input, and It is also used as a sort of flag throughout the function to infer what was passed in from the view function. It's very difficult to understand all the possible paths in the code.
IMHO my refactoring turns the function into a simple series of if - elif - else clauses. The logic is now far clearer.

the origin rv tuple
response,
response, status
response, headers
response, status,  headers

after append None
response, None,    None
response, status,  None
response, headers, None
response, status,  headers

so the 3 items is
response, status_or_headers ,headers

@guyskk Yes, I understand the idea in rv, status_or_headers, headers = rv + (None,) * (3 - len(rv)).
I just think the same thing can be achieved with a little more code and far better readability. As demonstrated in the PR.
IMHO this function could be implemented simply with a series of elifs, so I don't see why not :)

Your implement of _make_response_from_tuple is too verbose, you need not split it into some functions, it just a little bit of code and you make it complicated.
What's more, you should not change code and tests in the same commit, can your refactor pass the origin tests?
The 2th item can be string(status) or int(statuc_code), I wonder you refactor changed this behavior.

What's more, you should not change code and tests in the same commit

Why? By doing so you have working code with passing tests in each commit.

this is a refactor other than new feature，so the behavior shouldn't change，and should pass the origin tests.

@guyskk I agree, I might have refactored into too many sub-functions.
Other than that, IMHO the refactoring is good because it gives the function a structure of simple if - elif statements, instead of the weird structure it had before.
The 'rules' governing the behavior of the function are now visible to the eye, as opposed to the way the original is structured.
However as I said, I think you are right that I refactored into too many function levels.
@ThiefMaster Should I update the PR to not split into many sub-functions?

I have simplified the PR.
make_response is now a simple chain of if - elif statements. It calls a single function, _make_response_from_tuple. This function is a single block of code and doesn't call any other functions.
If you look at make_response, I think you'll agree it's clean and understandable.
def make_response(self, view_func_rv):
    """... docs ..."""
    if view_func_rv is None:
        raise ValueError('View function did not return a response')

    if isinstance(view_func_rv, self.response_class):
        return view_func_rv
    elif isinstance(view_func_rv, (text_type, bytes, bytearray)):
        return self.response_class(view_func_rv)
    elif isinstance(view_func_rv, tuple):
        return self._make_response_from_tuple(view_func_rv)
    else:
        return self.response_class.force_type(view_func_rv, request.environ)

Good job!

But the tests tuple1 tuple2 ... didn't changed, the numbers is meaningless and has bad taste.
I suggest that split into 2 commit, the first one just refactor code, don't touch tests, so that we can confirm that the refactor didn't change the origin behavior. the second one improve tests.

Thanks for looking into this. I agree that it was hard to follow. However, this introduced a bug where None was accepted as a response in a tuple, and the response in the tuple couldn't be a WSGI callable (although that's probably beyond rare).
I expanded on your idea by breaking out the tuple unpacking, adding more error messages, improving the documentation, and adding more tests. See #2256.


Audio Panic on Windows

Hi team,
trying to build this on a Windows machine and getting an error with the audio config that's created. It seems not every device would support the 44100 sample_rate and cpal expects that you match the output of the device that's chosen.
It seems some resampling would need to take place before the step of outputting to the cpal audio device.

Hello, thanks for raising this, You are right, I went with the easiest solution for this
I'll try to fix this when I have the time

@dcvz if you don't mind can you send me the output of the cpal supported configs for your machine?
you can try this code (you need to run it on your machine with cpal installed.


feat(datagrid): disable single or multi rows from selection

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Right now there is no way to disable a row from Datagrid and prevent interaction with the row.
Issue Number: #1018
What is the new behavior?
Added new input to ClrDatagridRow called cldDgUnselectable that except boolean. When set to true it will prevent the click event from firing and won't let the user change the state of the row. Also will mark the checkbox or radio button as disabled and change the cursor to mark the row as locked.
This is valid for both Single and Multi selectable rows.
Single selection

Normal
Disabled and can't be changed
Disabled and marked as selected, also can't be changed

Multi selection

Disabled and marked as selected
Disabled and can't be changed
Normal

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Close: #1018
Todo: need to be backported to V1

You don't have to be able to check them from the header toggle - so this is not ok ;)

Ignore the dco-required it will be fixed when I rebase the code

Could you provide me with some example of:

If I want to use [(clrDgSelected)] for setting selection in multi-select mode, locking breaks this behavior. It works fine until I lock something.

Hello @bdryanovski .
Could you please share an example using this clrDgUnselectable attribute? I've tried this but it's not working for me.

@hamza1100 you could read and find an example here


Integrate with TypedDocumentNode

Didn't realize https://github.com/dotansimha/graphql-typed-document-node existed; could utilize.
Integrating with a library.
GraphQL JS v16+ exports a generic DocumentNode natively.

Example: DocumentNode<RatesQuery, RatesQueryVariables>;   So our integration could look like DocumentNode<Result<typeof selectionSet>, Variables<typeof variables>> or something.

Done in ast-rewrite.


chore(main): release 0.3.2

:robot: I have created a release beep boop
0.3.2 (2024-01-18)
Bug Fixes

forgot name change in config.py (aa3c894)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/engeir/volcano-base/releases/tag/v0.3.2 :sunflower:


[DISCUSS] More extensive pre-release testing

Is your feature request related to a problem or challenge?

Part of https://github.com/apache/datafusion/issues/13648

Up to now, when we have made DataFusion releases, we have mostly focused on validated that DataFusion's own unit tests have passed, (see dev/release/README.md) but haven't tested the upgrade with other downstream projects (like ballista, ray, InfluxDB IOx, etc) until after we have release the code
This results sometimes in downstream users finding issues after release. Some recent examples

delta-rs upgrade: https://github.com/delta-io/delta-rs/pull/2886
https://github.com/apache/datafusion/issues/13481
https://github.com/apache/datafusion/issues/13568
https://github.com/apache/datafusion/issues/13510

Describe the solution you'd like
I would like to  improve the testing / release process for DataFusion releases to reduce the number of regressions found after release.
This would likely take the form of updating the dev/release/README.md
Describe alternatives you've considered
One idea mentioned by @Omega359 and @andygrove on  https://github.com/apache/datafusion/issues/13525#issuecomment-2496487538

Upgrading our own subprojects (Ballista, Comet, DF Python, DF Ray) as part of the DataFusion release process makes a lot of sense to validate that the upgrade guide is complete.

Additional context
No response

BTW I often create WIP PRs to test releases of sqlparser-rs and arow-rs with DataFusion before the release
For example:

https://github.com/apache/datafusion/pull/13546

This caught at least one regression before release recently (https://github.com/apache/datafusion-sqlparser-rs/pull/1556, fixed by @goldmedal  🙏 )

I would like to improve the testing / release process for DataFusion releases to reduce the number of regressions found after release.

I agree with the goal, but i am concerned about the cost/overhead involved. We don't have infinite bandwith at disposal.
Additionally, orchestrating testing across several downstream projects creates new problems we didn't have before

which downstream projects can stop the release train? what kind of problems are able to stop the release train?

this is especially important question for closed-source downstream projects

how long are we willing to wait for external teams to report back? Downstream project maintainers will obviously be willing and motivated to help, but their availability cannot be assumed

So what if we focused instead on:

improving testing within DF itself? if a downstream project is concerned about stability of feature X, they can contribute to improve test coverage for feature X (eg https://github.com/apache/datafusion/issues/13470)
easy low-overhead (automated) releases. If we see a big problem / regression after a major release, this can be patched on a maintenance branch. A maintenance branch can release daily without human intervention.

I agree with the goal, but i am concerned about the cost/overhead involved. We don't have infinite bandwith at disposal.
Additionally, orchestrating testing across several downstream projects creates new problems we didn't have before

Yes, this is true. I imagine an incremental rollout type approach -- where we start with one project (datafusion-python is a natural example, and maybe we can get delta-rs to help too). In my (likely naieve) thinking the downstream projects will be willing to help as they are directly affected

easy low-ceremony low-overhead (automated) releases. If we see a big problem / regression after a major release, this can be patched on a maintenance branch. A maintenance branch can release daily without human intervention

It is my understanding that the apache voting / approval process prevents automated builds
Creating a maintenance branch is also a compelling idea where we can focus on stability / shoring up test coverage 🤔

It is my understanding that the apache voting / approval process prevents automated builds

That's my understanding too, but i hope this process isn't nonnegotiable.
Processes are there to serve the project & the community after all, not the other way around.

That would work for me as long as these releases are the only once we publish. I would want automation for 'the releases' the people use. Especially if we have a maintenance branch, it would reasonable to release after every PR merge.
I don't know what problems the manual release process solves that cannot be solved with automated releases.
anyway, did we hijack the thread?

anyway, did we hijack the thread?

Yeah, we should probably file a separate discussion about more frequent releases if we want to pursue that option


Improve eng.istio.io

I noticed the following issues with eng.istio.io.

Menu options not visible on mobile browsers (Safari)
Failed page loads (e.g. /maintainers)
Slow page loads (e.g. /members)
Unsecured domain (currently http not https)

/cc @geeknoid

I see the issues as well (didn't test mobile safari though)

The issue exists on mobile Chrome as well.

You can connect with https: too, at least I do with Chrome. Not sure how to turn off http:, I'll see if there's an option for that somewhere.
As for the latency, well, yeah, this is still very preliminary. It'll get better.

Should we redirect http to https then?

These are all addressed I think.


Add option to search for subtitles

 Issue by MizzleDK
Wednesday Nov 06, 2013 at 01:09 GMT
Originally opened as https://github.com/MizzleDK/MizuuApp/issues/11

Should support at least one of the major subtitle sites, i.e. subscene, podnapisi or opensubtitles.

I'm waiting for this one for quite some time now. Is it still on the to-do list?

There's like 80 suggestions on GitHub and even more in my email inbox. I simply don't have time to do everything at once, and this one in particular has never been of high priority. The main reason being that it'd be an overly complicated user flow. Ideally, this should be available from within a video player, where you can immediately see if the selected subtitles match.
If anyone wants to do it, by all means feel free.


Add contributors

Just to keep track of contributors :)

@all-contributors add @chartgerink for maintenance, doc, ideas, questions, financial


RTC-S1 SAS CalVal Point Release 4.1 Acceptance Test

Ticket to track acceptance testing for the v4.1 point delivery of the RTC-S1 CalVal SAS. Existing wiki page should be updated as necessary to reflect procedure/results using this latest version.

Acceptance testing has been completed, updated wiki is available here: https://github.com/nasa/opera-sds-pge/wiki/RTC-S1-CalVal-Acceptance-Testing-Instructions


QSIprep

https://qsiprep.readthedocs.io/en/latest/index.html
Running qsiprep via docker:

docker pull pennbbl/qsiprep

has --infant flag

This is not relevant anymore


Explore feasibility of using likelihood profiling to get uncertainty in HC estimates

Repeatable and definitive? but potentially slow.

Seems to me that ultimately data cloning would be best approach because can deal with missing data, weighting etc but not sensitive to priors.


When I launch it, it runs without pressing the button

When I launch it, it runs without pressing the button.
Could you please fix this?

Yeah, sure, it will be in the next release :D

Found that bug...


Export From: [day], to: [day] is the same day export is empty.

When attempting to export messages from a group chat, I had set the 'From' date and the 'To' date as the same to not pull anything outside the targeted date, after exportation the generated HTML file read 'No exported messages'
I had expected the desktop app to either start from GMT 0 midnight to 23:59 the same day or local midnight to 23:59.
Zip file of generated export ChatExport_09_01_2020 (1).zip

This is not related to TDLib. Feel free to create an issue in https://github.com/telegramdesktop/tdesktop.


Item not found: Invalid column: typarray

BI tools such as Apache Superset can connect to Risingwave by using https://github.com/risingwavelabs/sqlalchemy-risingwave to bypass fetching some catalog information.
But some SAAS products that commercialize Apache Superset, e.g., Preset, may not allow users to use the plugin and can only connect to a few popular databases.
https://www.postgresql.org/docs/current/catalog-pg-type.html###

link #9939


HELP!!

Summary
I have two services:

http://services.groupkt.com/state/get/{countryCode}/all

https://restcountries.eu/rest/v2/all

The first api is not secured. The second api is secured. Please I need urgent HELP on how to add these  apis on KONG, forward them through KONG and then send requests.
From the documentation, adding api is achieved using this:
curl -i -X POST
--url http://localhost:8001/apis/
--data 'name=example-api'
--data 'hosts=example.com'
--data 'upstream_url=http://httpbin.org'
But I cannot seem to get it work for my apis since when i try to forward the request through KONG using
curl -i -X GET
--url http://localhost:8000/
--header 'Host: example.com'
it tells me "message":"no API found with those values". Please i need help to identify what is my upstream url and hosts for both services.
I am using KONG v0.10.x

We got that working changing hosts to the domain of the upstream url, in your case: httpbin.org


[Doc] Translation of documents [01-release.md]

Search before asking

[X] I had searched in the issues and found no similar issues.

Documentation Related
Documents to be translated are located at:docs/en/contribute/01-release.md
The current directory 01-release.md is in Chinese, please translate it to English, because this directory belongs to English directory.

Note: This issue is only for contributors who have not contributed to eventmesh and want to contribute to eventmesh, and can only be claimed once per contributor!

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

can i do this?

I am interested in doing this issue .Please assign me this task. And to which directory I need to translate

I am interested in doing this issue .Please assign me this task. And to which directory I need to translate

@hanshal101 Welcome! Of course you can, you can submit a pr first.

@Alonexc Done say if any changes to be made.


Instructions on how to find Report Problem in VS

Making it easier to understand how to launch Report Problem in VS

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ide/how-to-report-a-problem-with-visual-studio-2017.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nikolami Thanks for your PR. I've made one small change to fit our best practice for listing commands in a sequence: We use the right angle bracket instead of a pipette. Again though, thanks for your contribution to the documentation!

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ide/how-to-report-a-problem-with-visual-studio-2017.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nikolami FYI: I also added a period punctuation mark at the end of the first instruction, and changed "Report Problem" to "Report a Problem", to match the UI.
We appreciate your contribution!
Cheers,
~ Terry

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ide/how-to-report-a-problem-with-visual-studio-2017.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks Terry!


Overview Page

This PR completes a good portion of the Overview page and creates a Table of Contents to guide the reset of the documentation process.

These code changes have been moved to a new project here:
UniversalToken Extendable


Dataset name for message feedback is incorrect

Issue in ./help/using/data/datasets-query-examples.md
The sample query shows the dataset name as cjm_message_feedback_event_dataset but the dataset name is actually ajo_message_feedback_event_dataset . It was probably changed at some point after the documentation was created.

This has been resolved. Thanks for your feedback @abhardwaj-dev


Create Specs for Whales

Bros [ @jaimegarciae  @VictorElizalde ] and Ladybro [ @GalaRamos ],
Please create the specs, TDD is quite great. You'll see it eventually.
Live long and prosper,
Me


Cannot install GPU drivers using the provided documentation.

The commands are not working for Azure VM with Ubuntu 20.04 with size Standard NC16as T4 v3
Specifically, instructions for installing the GPU drivers with Secure Boot on Ubuntu 20.04 are not working.
I get an error on the second step.
sudo apt install -y linux-modules-nvidia-${NVIDIA_DRIVER_VERSION}-azure nvidia-driver-${NVIDIA_DRIVER_VERSION}
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
linux-image-5.15.0-1041-azure : Depends: linux-modules-5.15.0-1041-azure but it is not installable
E: Unable to correct problems, you have held broken packages.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0e03790a-1bf9-146d-704b-6816d475064b
Version Independent ID: ad5f6be7-e089-161f-306c-39d10e7ab0a0
Content: Azure N-series GPU driver setup for Linux - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/n-series-driver-setup.md
Service: virtual-machines
Sub-service: sizes
GitHub Login: @vikancha-MSFT
Microsoft Alias: vikancha

@v-burak
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@vikancha-MSFT
Can you please check and add your comments on this doc update request as applicable.

Ack!
Will update on it ASAP.

+1 here. I'm trying it on "Standard NC6s v3" and got stuck on this step:
$ sudo apt install -y cuda-drivers-${NVIDIA_DRIVER_MAPPING}=${CUDA_DRIVER_VERSION} cuda-drivers=${CUDA_DRIVER_VERSION}
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 cuda-drivers-530 : Depends: nvidia-modprobe (>= 530.30.02) but 470.103.01-1 is to be installed
                    Depends: nvidia-settings (>= 530.30.02) but 510.47.03-0ubuntu1 is to be installed
E: Unable to correct problems, you have held broken packages.

Doc has been updated: https://github.com/MicrosoftDocs/azure-docs-pr/pull/245529

I am facing a similar problem when I execute:

 sudo apt install -y linux-modules-nvidia-525-azure nvidia-driver-525

 The following packages have unmet dependencies:
 linux-modules-nvidia-525-azure : Depends: linux-modules-nvidia-525-5.15.0-1042-azure (= 5.15.0-1042.49~20.04.1+1) but it is not going to be installed
                                  Depends: nvidia-kernel-common-525 (>= 525.125.06) but it is not going to be installed
 nvidia-driver-525 : Depends: libnvidia-gl-525 (= 525.125.06-0ubuntu<IP_ADDRESS>) but it is not going to be installed
                     Depends: nvidia-kernel-common-525 (<= 525.125.06-1) but it is not going to be installed
                     Depends: nvidia-kernel-common-525 (>= 525.125.06) but it is not going to be installed
                     Depends: nvidia-kernel-source-525 (= 525.125.06-0ubuntu<IP_ADDRESS>) but it is not going to be installed
                     Depends: nvidia-compute-utils-525 (= 525.125.06-0ubuntu<IP_ADDRESS>) but it is not going to be installed
                     Depends: libnvidia-encode-525 (= 525.125.06-0ubuntu<IP_ADDRESS>) but it is not going to be installed
                     Depends: xserver-xorg-video-nvidia-525 (= 525.125.06-0ubuntu<IP_ADDRESS>) but it is not going to be installed
                     Depends: libnvidia-cfg1-525 (= 525.125.06-0ubuntu<IP_ADDRESS>) but it is not going to be installed
                     Recommends: libnvidia-compute-525:i386 (= 525.125.06-0ubuntu<IP_ADDRESS>)
                     Recommends: libnvidia-decode-525:i386 (= 525.125.06-0ubuntu<IP_ADDRESS>)
                     Recommends: libnvidia-encode-525:i386 (= 525.125.06-0ubuntu<IP_ADDRESS>)
                     Recommends: libnvidia-fbc1-525:i386 (= 525.125.06-0ubuntu<IP_ADDRESS>)
                     Recommends: libnvidia-gl-525:i386 (= 525.125.06-0ubuntu<IP_ADDRESS>)
E: Unable to correct problems, you have held broken packages.

I was not able to access the link provided by @darkwhite29 , so I don't know if I miss something.

@evelinamorim This is the latest instructions: https://learn.microsoft.com/en-us/azure/virtual-machines/linux/n-series-driver-setup#install-cuda-driver-on-ubuntu-with-secure-boot-enabled
Could you please create a VM from scratch and start all over all steps to confirm it does not work for you? Those steps work for me and my colleagues. Thanks!

Just to be clear for other people that can access this thread. It worked, but I had to delete the machine and create a new one since in the old machine I followed the instructions in https://learn.microsoft.com/en-us/azure/virtual-machines/linux/n-series-driver-setup#ubuntu. This can be very confusing.
Thanks @darkwhite29 !

If your VM is trusted launched (now it is the default option on the portal), you need to following the special instructions I posted. Otherwise, common instructions work.

If you follow the instructions for regular VM and then run the instructions for trust launched VMs, it probably won't work since your old installation messes up the driver/package versions.

Since the issue is resolved and the document is updated/live, #please-close


Draft email with clearification on how Moore grant can be spend

The finance comitee is looking at the Moore grant application. The application
lays out a budget, but it seems that the rules for spending are not as strict
as some of us are used to from e.g. NASA grants. However, its always better
to be upfront and ask early, rather than to find out later that the deadline for
spending money has already passed and money has to be returned.
Thus, we plan to contact the Moore foundation to ask for the rules.
Deadline: Feb 15 2020
This PR will be merged and the email send after the deadline, so any comments
have to be done before that date.
closes #47

The answers to these questions are all in the Moore grant contract, thus I'm closing this issue.


Fixed crash on non-existent port with version override

Fixes this issue reported in the vcpkg project:
https://github.com/microsoft/vcpkg/issues/36994
The "entry" function does not return an error but an empty RegistryEntry in some situations, needs to be checked for.
An alternative solution would be to refactor all registry implementations to never return an empty RegistryEntry, but an error instead.
That should be done in a separate issue after this fix is merged.

Thank you for the fix, this looks great!
Could you also add an end-to-end test that verifies this behavior and prevents future regressions? It should hopefully be pretty straightforward to extend https://github.com/microsoft/vcpkg-tool/blob/main/azure-pipelines/end-to-end-tests-dir/registries.ps1 to cover this case.

I added such a test. I verified that the un-fixed product failed:

@microsoft-github-policy-service agree

Thanks again for your help!

Glad to be of help,
thanks for creating a great tool for the C++ community!


Wrong categoryCode in ram:ApplicableHeaderTradeSettlement

When there are several entries of ram:SpecifiedLineTradeSettlement with different CategoryCode (e.g. "S" for nominal tax and "Z" for tax free) then the summary in ram:ApplicableHeaderTradeSettlement contains only categoryCode "S". This results in validationErrors.

was corrected with https://github.com/ZUGFeRD/mustangproject/pull/187 , thank you


Proposal Management under the admin view should be merged with the Service learning page.

Currently, there is a Service learning page and a separate Proposal Management page under the Admin dropdown. Brian has proposed that these two pages are similar enough to warrant merging them into one. This would also avoid the confusing naming between Course Proposal and Proposal Management.

 CELTS #251: Proposal Management under the admin view should be merged with the Service learning page.

https://trello.com/c/btFrXUnn/399-celts-251-proposal-management-under-the-admin-view-should-be-merged-with-the-service-learning-page

Pull request merged.


react_weather_app

i would like to contribute my simple react weather app to this repository

could I make this weather app

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-all


Previous view is not dismissed

OK, so say I'm on view A (View A is the second view on the sidebar menu). When I click on the third item on the menu, I am navigated to view B. All works fine so far.
The problem arises when I click on the second item on the menu again. I open the view A, but as it was originally. So in other words, a new instance of view A Controller is not created.
This also happens in another way. My fourth item on the menu is supposed to be another instance of view A controller (let's call it View A+1), but for a different purpose. When I click on the fourth button of the menu, I only get the already created view A, not the view A+1.
The first item of the menu is nothing, I'm using it as title for the menu.
I'm not sure why this happens. This is the code I use in my side menu to navigate:
- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath
{
    UIStoryboard *mainStoryboard = [UIStoryboard storyboardWithName:@"Main"
                                                             bundle: nil];

    UIViewController *vc ;
    if (indexPath.row==0) {
        [[SlideNavigationController sharedInstance]closeMenuWithCompletion:nil];
    }else{
        vc = [mainStoryboard instantiateViewControllerWithIdentifier: [[self.menuItems objectAtIndex:1]objectAtIndex:indexPath.row]];
        if (indexPath.row==1) {
//This is where View A is initialised and the purpose is set
            [(MyProfileViewController*)vc setPurpose:@"Purpose for view A"];
        }
        if (indexPath.row==2) {
//This is where View A is initialised and the purpose is set
           //I don't pass anything to the view B (which is in the cell with indexPath row of 1)
        }
        if (indexPath.row==3) {
             [(MyProfileViewController*)vc setPurpose:@"Purpose for view A+1"];
        }
        [[SlideNavigationController sharedInstance] popAllAndSwitchToViewController:vc withSlideOutAnimation:self.slideOutAnimationEnabled andCompletion:nil];

    }
}

Thanks in advance for any help you can give and if you need more code, please let me know.

set avoidSwitchingToSameClassViewController  to false

You're a life saver!! :) Thanks a lot

:+1: :)


[W5.7][T03-2]Ngoh Wen Jun

Add a command to search addressbook for a particular phone number

@Scrubbius More importantly, please title your PR correctly in future so that the bot will assign it to me! The correct format for you should be [W5.7][W16-2]Ngoh Wen Jun...


❓👂 Question/Feedback - PLEASE CHANGE ME TO SOMETHING DESCRIPTIVE

Question/Feedback
Hey team, we tried to add network watcher as part of our deployment, but the deployment failed, the error was suggesting that network watcher already exist, but I don't see the code in any of Bicep files.
resource symbolicname 'Microsoft.Network/networkWatchers@2022-07-01' = {
name: 'string'
location: 'string'
tags: {
tagName1: 'tagValue1'
tagName2: 'tagValue2'
}
properties: {}
}
Possible Answers/Solutions?
Can you please advise how ALZ-BICEP handles networkWatchers' creation in its Bicep scripts?

Hi @jamesyoung007,
The azure platform automatically enables network watcher in the same region as where you create a vnet, as documented here https://learn.microsoft.com/en-us/azure/network-watcher/network-watcher-create#network-watcher-is-automatically-enabled
So ALZ Bicep doesn't need to do this in its code.
Thanks
Jack


nashorn support

i took a peek at the code and it looks like it assumes its running in the browser or in node. how about nashorn support?
I'm new to this project and I'm curious if there's been any discussion around this.

Nashorn support actually hasn't been considered to date, but could certainly be an option. The main APIs we need to access I believe are readFile, eval and cwd. If the implementations of those are short enough not to bloat the codebase, then there's no reason not to support it.

please re-open
following https://github.com/systemjs/systemjs/issues/1113#issuecomment-193304506

This specific project does not provide individual loader implementations, but this could be tracked at the system-register-loader project for example.
Also, you are welcome to construct your own loader with nashorn support based on the principles, and that would definitely be great to feed back into the projects here.


Chat answering to sample date after deleting it from storage

This issue is for a: (mark with an x)
- [ x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

I used Northwind data first, then deleted it from storage and uploaded my own pdfs.
Then I asked about Northwind data and it gives answers, it also shows the .pdf sources with the information

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 10

azd version?

run azd version and copy paste here.

Versions

azd version 1.5.0

Mention any other details that might be useful
I deleted the Northwind files from the storage, and also run 'azd up' several times...
Thanks!

You need to remove it from the search index as well, please read our guide here:
https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/docs/data_ingestion.md#removing-documents

Thanks! I removed all and reuploaded my files!


Add string prefix to matcher arg to scope match to just the path portion of the URL

IMO it seems like people are more often just going to match against just the URL path and not the full URL from protocol to URL fragment and so having a prefix like path: for the string version of the matcher arg for .mock(), .get(), et al would be a nice convenience to scope the match to just the URL path. It could still be treated as a full match or use the glob * character to match a dynamic last segment.
Without this, you need to use a RegExp to match just the path which means you either need to write out a full constructor for it or escape all the forward slashes for the regex literal.

You can use end:, which, granted, will also need to match any query string. The express: prefix also supports the full express path syntax, of which just using a path, with no params in it, is a subset.
So it is technically supported, though perhaps not obviously. I've been thinking for ages about putting together an examples and recipes section of the docs, but not had the time

Ok cool. Probably better to have an explicit one for this (probably) common use case. I'll try to tackle it in the next few weeks.

For the PR, it looks like all I need to do is:

Add a new entry (probably keyed as path) to the stringMatchers object and import any necessary libraries for extracting the path (I'll try to find the most lightweight dependency possible since all that's needed is to break apart a URL and extract the path portion)
Add whatever unit tests for browser and Node environments
Update the docs

Does that sound about right?

yep totally correct, other than that you shouldn't need any dependencies as both node and browsers have URL parsers built in: https://nodejs.org/api/url.html, https://developer.mozilla.org/en-US/docs/Web/API/URL (older browsers don't, but I'm working on tweaking the babel settings to polyfill any missing apis, so you can assume that it's available)

w00t! That makes life much easier.


[decryption] unable to use an identity provided via stdin

Environment

OS: NixOS 22.11
rage version: 0.9.0 (from nixpkgs-22.11)

What were you trying to do
Use an identity that was generated on the fly from an ssh private key:
$ rage -d -i <(sudo ssh-to-age -private-key -i /etc/ssh/ssh_host_ed25519_key)  secret.age
Error: Missing identities.
Did you forget to specify -i/--identity?

Expected behavior
Seems to work with age:
$ aage -d -i <(sudo ssh-to-age -private-key -i /etc/ssh/ssh_host_ed25519_key)  secret.age
<plaintext>

The issue here is that because -i currently only supports on-disk files with filenames (because #177 has not yet been implemented), we assume that we can read from the identity file more than once. This assumption is broken by named pipes (as well as stdin). #354 was one approach to fixing this; I plan on taking the approach I outlined in https://github.com/str4d/rage/pull/354#issuecomment-1587732589.


Open with custom should be removed

Since we're at 100% we need to remove the custom editor.

This is pending changes from the core to support this and how would we handle hot exit for the files that were open in this editor.


Site now working as intended.

Are you experiencing an issue with...

[x] shields.io
[ ] My own instance
[ ] gh-badges NPM package

react-dom.production.min.js:198 TypeError: Cannot read property 'replace' of undefined
at o (make-badge-url.js:53)
at Array.map ()
at staticBadgeUrl (make-badge-url.js:65)
at a.r.renderExample (badge-examples.js:42)
at badge-examples.js:87
at Array.map ()
at a.r.render (badge-examples.js:87)
at Oi (react-dom.production.min.js:173)
at Ri (react-dom.production.min.js:172)
at Mi (react-dom.production.min.js:180)
da @ react-dom.production.min.js:198
make-badge-url.js:53 Uncaught (in promise) TypeError: Cannot read property 'replace' of undefined
at o (make-badge-url.js:53)
at Array.map ()
at staticBadgeUrl (make-badge-url.js:65)
at a.r.renderExample (badge-examples.js:42)
at badge-examples.js:87
at Array.map ()
at a.r.render (badge-examples.js:87)
at Oi (react-dom.production.min.js:173)
at Ri (react-dom.production.min.js:172)
at Mi (react-dom.production.min.js:180)

:link: Link to the badge

:bulb: Possible Solution

Hi @ParveenBhadooOfficial, can you provide a little more info? The badge template for bugs includes a few sections where different data points can be shared that really helps in debugging issues. It would be great if you could fill some of those in!

Could you let us know what you were trying to do at the time you hit this error and what browser/OS you're using. Cheers

when i open https://shields.io/ and enter https://github.com/ParveenBhadooOfficial/hashhackers.com it shows blank page and below code in inspect element
loader.js:229 Network quality values are overridden using a holdback experiment, and so may be inaccurate
enqueue @ loader.js:229
2react-dom.production.min.js:198 TypeError: Cannot read property 'replace' of undefined
at o (make-badge-url.js:53)
at Array.map ()
at staticBadgeUrl (make-badge-url.js:65)
at a.r.renderExample (badge-examples.js:42)
at badge-examples.js:87
at Array.map ()
at a.r.render (badge-examples.js:87)
at Oi (react-dom.production.min.js:173)
at Ri (react-dom.production.min.js:172)
at Mi (react-dom.production.min.js:180)
da @ react-dom.production.min.js:198
make-badge-url.js:53 Uncaught (in promise) TypeError: Cannot read property 'replace' of undefined
at o (make-badge-url.js:53)
at Array.map ()
at staticBadgeUrl (make-badge-url.js:65)
at a.r.renderExample (badge-examples.js:42)
at badge-examples.js:87
at Array.map ()
at a.r.render (badge-examples.js:87)
at Oi (react-dom.production.min.js:173)
at Ri (react-dom.production.min.js:172)
at Mi (react-dom.production.min.js:180)

Are you trying to use the suggest badges feature?

Yes it sounds like this is a duplicate of #3033. Lets track it there - thanks for reporting


Issue with manager.startDeviceScan callback not being fired on iOS when used outside manager.onStateChange callback

Expected Behaviour
I have created a button that sets a state variable, scanning to true. I am using an effect that has this state variable as a dependancy and will start scanning when it is set to true:
  useEffect(() => {
    if(scanning) {
      setDevices([]);
      scanAndConnect();
    }
  }, [scanning]);

My scanAndConnect() function:
const scanAndConnect = function() {
    manager.startDeviceScan(null, null, (error, device) => {
      if (error) {
        // Handle error (scanning will be stopped automatically)
        return;
      }

      console.log(device);
    });
  };

However I am finding that this is not working (the function gets called however it seems like the listener callback is never fired), and the only way to get the scanning working (on iOS) is to fire my scanAndConnect() function inside the manager.onStateChange callback:
  const subscription = manager.onStateChange((state) => {
    if (state === 'PoweredOn' && scanning === false) {
      setCanScan(true);
      subscription.remove();
      scanAndConnect(); #the function properly gets called here
    }
  }, true);

Please describe the behaviour you are expecting
Current Behaviour
See above
Steps to Reproduce
Please provide detailed steps for reproducing the issue.
See above
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions. Both JS and platform logs can be enabled via setLogLevel function call.

Library version: ^2.0.1
Platform: Android/iOS.
Platform logs (logcat/XCode):

These are some errors that I believe are related:
error	16:28:33.457562+1000	Boilerplate	API MISUSE: <CBCentralManager: 0x2839cc800> has no restore identifier but the delegate implements the centralManager:willRestoreState: method. Restoring will not be supported
error	16:28:33.486466+1000	Boilerplate	API MISUSE: <CBCentralManager: 0x2839edb00> has no restore identifier but the delegate implements the centralManager:willRestoreState: method. Restoring will not be supported
error	16:28:33.489156+1000	Boilerplate	XPC connection invalid
error	16:28:33.503813+1000	Boilerplate	API MISUSE: <CBCentralManager: 0x2839c8980> has no restore identifier but the delegate implements the centralManager:willRestoreState: method. Restoring will not be supported
error	16:28:33.506644+1000	Boilerplate	XPC connection invalid

error	16:29:29.509341+1000	Boilerplate	API MISUSE: <CBCentralManager: 0x2839e6280> has no restore identifier but the delegate implements the centralManager:willRestoreState: method. Restoring will not be supported
error	16:29:29.522149+1000	Boilerplate	XPC connection invalid
error	16:29:29.573470+1000	Boilerplate	API MISUSE: <CBCentralManager: 0x2839c9c80> has no restore identifier but the delegate implements the centralManager:willRestoreState: method. Restoring will not be supported
error	16:29:29.585231+1000	Boilerplate	XPC connection invalid

JS logs: No obvious errors or anything to point to an issue
Contents of the package.json file:

{
  "name": "Boilerplate",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "react-native start",
    "test": "jest",
    "cocoapods": "cd ios && pod install && cd ..",
    "ios": "react-native run-ios --simulator=\"iPhone 8\"",
    "build:ios": "react-native bundle --entry-file='index.js' --bundle-output='./ios/main.jsbundle' --dev=false --platform='ios'",
    "android": "react-native run-android",
    "rename": "react-native-rename",
    "redux:remove": "yarn remove redux react-redux redux-thunk",
    "typescript:add": "sh scripts/add-typescript/script.sh",
    "lint": "eslint ."
  },
  "dependencies": {
    "@react-native-async-storage/async-storage": "^1.13.2",
    "@react-native-community/masked-view": "^0.1.10",
    "@react-navigation/drawer": "^5.10.4",
    "@react-navigation/native": "^5.2.4",
    "@react-navigation/stack": "^5.2.19",
    "appcenter": "3.1.2",
    "appcenter-analytics": "3.1.2",
    "appcenter-crashes": "3.1.2",
    "dayjs": "^1.9.5",
    "engine.io-client": "^4.0.4",
    "laravel-echo": "^1.9.0",
    "moment": "^2.29.1",
    "native-base": "^2.13.14",
    "react": "16.13.1",
    "react-native": "0.63.2",
    "react-native-asyncstorage": "^1.0.0",
    "react-native-ble-plx": "^2.0.1",
    "react-native-gesture-handler": "^1.8.0",
    "react-native-map-clustering": "^3.3.9",
    "react-native-maps": "^0.27.1",
    "react-native-paper": "^4.3.1",
    "react-native-permissions": "^3.0.0-beta.2",
    "react-native-reanimated": "^2.0.0-alpha.8",
    "react-native-safe-area-context": "^0.7.3",
    "react-native-screens": "^2.7.0",
    "react-native-swipe-gestures": "^1.0.5",
    "react-native-vector-icons": "^7.0.0",
    "react-redux": "^7.2.0",
    "redux": "^4.0.5",
    "redux-thunk": "^2.3.0",
    "socket.io-client": "^2.3.1",
    "util": "^0.12.3"
  },
  "devDependencies": {
    "@babel/core": "^7.8.4",
    "@babel/runtime": "^7.8.4",
    "@react-native-community/eslint-config": "^1.1.0",
    "babel-jest": "^25.1.0",
    "babel-plugin-module-resolver": "^4.0.0",
    "eslint": "^6.5.1",
    "jest": "^25.1.0",
    "metro-react-native-babel-preset": "^0.59.0",
    "react-native-rename": "^2.4.1",
    "react-test-renderer": "16.13.1"
  },
  "jest": {
    "preset": "react-native"
  }
}

Formatted code sample or link to a repository:

import React, { useState, useEffect } from 'react';
import {Image, StyleSheet, TouchableHighlight, View} from 'react-native';
import { useSelector } from 'react-redux';
import Logo from '../../../assets/images/qhdc-logo-transparent.png';
import { MaterialColors, FontWeights, FontSizes } from '@app/theme';
import { BleManager } from 'react-native-ble-plx';
import { setAssetViewId, handleGetAllAssets } from '../../store/actions/index';
import { useDispatch } from 'react-redux';
import { getObject } from '../../utils/index';
import dayjs from 'dayjs';
import Sidebar from '../../components/Sidebar/index';
import { Avatar, Button, Card, Title, Paragraph, Text, Chip, ActivityIndicator, Colors } from 'react-native-paper';
import { useNavigation } from '@react-navigation/native';

var relativeTime = require('dayjs/plugin/relativeTime');
dayjs.extend(relativeTime);

function AssetScreen() {
  const dispatch = useDispatch();
  const navigation = useNavigation();
  const { status, page, loginError, user, assets } = useSelector(({ data }) => data);
  const [devices, setDevices] = useState([]);
  const [scanning, setScanning] = useState(false);
  const [canScan, setCanScan] = useState(false);
  const [spidersPressed, setSpidersPressed] = useState(false);

  var assetMacs = {};

  const handleScan = () => {
    setScanning(true);
  };

  const manager = new BleManager();

  useEffect(() => {
    if(scanning) {
      setDevices([]);
      scanAndConnect();
    }
  }, [scanning]);

  const handleDeviceFound = async (device) => {
    delete device._manager;

    device.timestamp = dayjs().toISOString();
    setDevices(prevDevices => {
      let found = false;
      prevDevices.forEach((prevDevice, index) => {
        if (prevDevice.id === device.id) {
          found = true;
        }
      });
      const deviceMacNoColons = device.id.replace(/\:/g, '');

      if(typeof assetMacs[deviceMacNoColons] !== 'undefined') {
        device.name = assetMacs[deviceMacNoColons].name;
        device.device_id = assetMacs[deviceMacNoColons].device_id;
        device.asset_id = assetMacs[deviceMacNoColons].id;
        device.type = assetMacs[deviceMacNoColons].type;
        device.site = assetMacs[deviceMacNoColons].site;
      }

      if (found) {
        return [
          ...prevDevices
        ];
      } else {
        return [
          ...prevDevices,
          device
        ];
      }
    });
  };

  const scanAndConnect = function() {
    manager.startDeviceScan(null, null, (error, device) => {
      if (error) {
        // Handle error (scanning will be stopped automatically)
        return;
      }

      console.log(device);
    });
  };

  const subscription = manager.onStateChange((state) => {
    if (state === 'PoweredOn' && scanning === false) {
      setCanScan(true);
      subscription.remove();
    }
  }, true);

  function ScanButton() {
    if (scanning) {
      return (
        <Button style={{width:200}} mode="contained" loading={true} onPress={() => setScanning(false)}>
          Scanning...
        </Button>
      );
    }
    return (
      <Button style={{width:200}} mode="contained" onPress={() => handleScan()}>
        Scan
      </Button>
    );
  }

  const handleDevicePressed = (deviceId) => {
    dispatch(setAssetViewId(deviceId));
    navigation.navigate('AssetViewScreen');
  };

  return (
    <View style={{zIndex: 2, paddingLeft: 20, backgroundColor: '#fff', position: 'relative', height:'100%'}}>
      <View style={{zIndex: 2, position: 'relative', flex: 1, flexDirection:'row'}}>
        <View style={{position: 'relative', zIndex:2, paddingTop:20, backgroundColor:'#fff', height:'100%', flex:1}}>
          { canScan &&
          <View style={{marginTop: 5}}>
            { ScanButton() }
          </View>
          }

          {
            spidersPressed &&
            <View>
              <Text>
                { JSON.stringify(assets) }
              </Text>
            </View>
          }

          <View>
            <View style={{flexDirection: 'column', alignItems: 'flex-start', justifyContent: 'flex-start'}}>
              { devices.sort((a, b) => {
                if (a.rssi > b.rssi) {
                  return -1;
                } else if(a.rssi < b.rssi) {
                  return 1;
                }
                return 0;
              }).map(function(device) {
                if(typeof device.device_id !== 'undefined') {
                  return (
                    <Chip key={device.id} style={{marginTop:5}} icon="information" onPress={() => handleDevicePressed(device.asset_id)}>
                      {device.name + ' - ' + device.type.name} - seen { dayjs(device.timestamp).toNow(true) } ago @ {device.rssi}
                    </Chip>
                  );
                }
              }) }
            </View>
          </View>
        </View>
      </View>
    </View>
  );
}

export default AssetScreen;

Let me cite the doc of BleManager

/**
*

BleManager is an entry point for react-native-ble-plx library. It provides all means to discover and work with
{@link Device} instances. It should be initialized only once with new keyword and method
{@link #blemanagerdestroy|destroy()} should be called on its instance when user wants to deallocate all resources.

In case you want to properly support Background Mode, you should provide restoreStateIdentifier and
restoreStateFunction in {@link BleManagerOptions}.

@example
const manager = new BleManager();
// ... work with BLE manager ...
manager.destroy();
*/

You are using RN hooks. Guess what may be happening in your code and what can be done to prevent it?

@dariuszseweryn Thanks for your comment... it did lead me to discover this issue https://github.com/Polidea/react-native-ble-plx/issues/603 where it looks like there are issues with the way I am doing things.. seems like my useEffect may be getting called too early before the manager is ready, also looks like I need to pass the restoreStateIdentifier and restoreStateFunction... are you able to point me in the right direction?

It should be initialized only once with new keyword and method
{@link #blemanagerdestroy|destroy()} should be called on its instance when user wants to deallocate all resources

You are creating a new manager with each render in the above mentioned code. Waiting for the correct state is also important.

@dariuszseweryn Thank you again. I will close this issue until I implement the changes that you have nudged me towards making. Really appreciate the help. If I am still having troubles I will reopen it / create a new issue.


Can't import xml to codewalker

Forgive me if I'm missing something obvious but I followed all the steps in this tutorial got the model exported as an ydr.xml and I can't figure out how on earth I import it into codewalker

this isnt an issue with Sollumz, in the future please dont make bug reports for issues not related to Sollumz

Sorry about that do you know how I can do it at least? or maybe how to convert the xml into a usable ydr?


docs: fix links in Python articles (rc/1.23)

Fixes some broken links reported here: https://github.slack.com/archives/CQ43CJH1U/p1585254672055900
They were fixed in master in https://github.com/Semmle/ql/pull/2609
I thought i had ported the changes to rc/1.23 in https://github.com/Semmle/ql/pull/2612, but I targeted the wrong branch 🤦♂

These are cherry-picked commits that have previously been approved, so merging.

LGTM
🚢

Thanks @hubwriter


The number of AX25 preamble bytes should vary based on baud rate and back to back packets

Right now the number of preamble bytes is hard coded to a value that works for 9600bps in the lab.  This value should be configurable and should vary based on the rate.  Testing should be performed to optimize the value.
In addition, the preamble bytes may not be required if frames are sent back to back.  This would greatly improve efficiency.

This should be implemented so that it also solves #15.  We should commit the packet bytes 200 at a time to the FIFO and wait for the interrupt to add more.  If we have another packet available as we are adding the last bytes for a packet, then just insert a very short preamble.  If it is the first transmission after a gap then insert the full preamble.

Fixed in 0.1g but does not solve #15.  Just implemented as a check in TxTask()


Move redirect handling entirely to PoolManager

Redirect handling code was duplicated in urllib3, being present in two places: in the ConnectionPool, and the PoolManager. This centralises all redirect handling code into the PoolManager, where it needs to be to handle cross-host redirects. ConnectionPool objects are no longer capable of doing redirects.
After this I'll provide a PR that moves all retry handling up to PoolManager as well, at which point ConnectionPool will have been greatly simplified.

Will review in the next couple days.

Codecov Report

Merging #1146 into v2 will decrease coverage by 2.66%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             v2    #1146      +/-   ##
========================================
- Coverage   100%   97.33%   -2.67%
========================================
  Files        22       22
  Lines      1998     1991       -7
========================================
- Hits       1998     1938      -60
- Misses        0       53      +53

Impacted Files
Coverage Δ

urllib3/connectionpool.py
100% <ø> (ø)
:arrow_up:

urllib3/poolmanager.py
100% <100%> (ø)
:arrow_up:

urllib3/util/selectors.py
83.64% <0%> (-16.36%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9913c81...b0bbe06. Read the comment docs.

Am I understanding correctly that this loses the redirect history since we put the onus of managing redirects on the Retry object?

I don't think so, the tests for RedirectHistory continue to pass.

Ok, tests are green, this is good to review.

Nits addressed.


Update dump-required-ini-params.sh

For some reason on my install + composer.phar here, this script borked in the toArray() method on something that was already an array. Removing the toArray() solved all my problems.

@arothuis could you please verify this? Haven't had this issue before.
@mrvanes did you have anything configured for the trustedProxyIps?

Hi @mrvanes, thanks for the PR. we have not encountered this issue before and will look into it.
In the meantime, could you tell us what you have configured for the trustedProxyIps in both your application.ini (in the codebase) and in the engineblock.ini (on the VM)?
Also, what VM (branch, environment) did you provision?

I'm doing a manual install without OpenConext-deploy and never supplied trustedProxyIps in engineblock.ini so I suspect it's the default. I did see two ip addrs in trustedProxyIps config as a result of prepare-env (after I fixed dump-required-ini-params.sh).

Indeed, if the configured value is empty, $config->get('trustedProxyIps', array()) will return an array and ->toArray() will not work. That should be fixed.
However, removing ->toArray(), results in trusted_proxies = null in ini_parameters.yml (the result of dump_ini_params.sh), if trustedProxyIps was configured in engineblock.ini.
We could fix this by:

Getting the configuration first and only calling toArray() on it if it is not already an array; or
Passing an EngineBlockConfiguration wrapping an empty array as a default value

I think solution 1 would be most transparent. If there were more array configurations to be extracted we could encapsulate such behaviour in a function.

:+1:  for the first option.

:+1:

This now breaks on line 34.. I guess the $trustedProxies var should be used there, instead of pulling it from the config again.

That's odd, thanks for reporting it.
Looking into it, something might have gone wrong using commit -p.