Search in the IETF category is unintuitive

How am I supposed to find rfc 3261?

I tried variations on capitalization and space/no-space, and got the same results.

Thanks @rjsparks . Related to #54 .

Yes, the document ID search is doing literal matches, but the freeform search form further down searches more extensively. Working on more search options and making freeform match faster.

Correction, exact match for RFC3261 should work, because the document exists: https://dev.bibxml.org/indexed-sources/rfcs/RFC3261/
The problem is that "RFC3261" identifier is specified with "scope=anchor". Looking into adjusting matching so that it is not thrown off by that structure.
This problem with duplicate identifiers (in this case, RFC 3261 and RFC3261 are both specified in Relaton data, which seems wrong) ctually this relates to https://github.com/ietf-ribose/relaton-data-rfcsubseries/issues/4. cc @ronaldtse, apparently this is to be discussed with Nick

Meanwhile, specifying RFC 3261 (with the space) in search matches the other identifier and opens the correct document.

in this case, RFC 3261 and RFC3261 are both specified in Relaton data, which seems wrong

"RFC 3261" is the canonical identifier for the document.
" "RFC3261" is the "anchor" used in the authoritative information. This "anchor" is commonly used as the citation reference in xml2rfc.

People will search using both patterns. Both should exist, and therefore what we have now is correct.

Both should exist, and therefore what we have now is correct.

Citations shouldn’t have two canonical identifiers so similar but subtly different. Fuzzy search is a different matter.

@strogonoff I need to clarify some terminology here.

A bibliographic item is a representation of the metadata of an information resource.
A citation reference is an entry in the bibliography that allows a reader to locate the cited information resource.
A citation is the "instance" of referring to a citation reference.

And clarification of what Relaton is:

Relaton is a bibliographic item data model.
It can be used for citations.
Citation styles dictate the format of the document identifier written in the document.

Relaton cannot tell you what a citation should look like.

An example of different document identifier citation styles:

In IETF, IETF documents are cited as "RFCXXXX"
In ISO and OGC, IETF documents are cited as "IETF RFC XXXX".

In ISO and OGC, IETF documents are cited as "IETF RFC XXXX".

In this example, shouldn’t they use a different type then? E.g., “ISO” and “OGC”. Currently, we have two docids with the same type: docid = [{'type': 'IETF', 'id': 'RFCXXXX'}, {'type': 'IETF', 'id': 'RFC XXXX', scope: 'anchor'}]

A citation reference is an entry in the bibliography that allows a reader to locate the cited information resource.
A citation is the "instance" of referring to a citation reference.

I’m not sure I have a complete picture of how citation reference and citation would look like.
It’s nice to have shared terminology, once I wrap my head around this I’ll add it to the glossary in bibxml-service docs. Currently it uses citation as an alias for bibliographic item.

In this example, shouldn’t they use a different type then? E.g., “ISO” and “OGC”.

Here's the thing. IETF (the authoritative source) won't be able to specify the document identifier type used by other organizations, it can only give its own "canonical identifier". So "ISO" or "OGC" should not be in the bibliographic data.
From my perspective, downstream users like "ISO" or "OGC" can only be facilitated with the additional pieces of data (as in structured data).

docid = [{'type': 'IETF', 'id': 'RFCXXXX'}, {'type': 'IETF', 'id': 'RFC XXXX', scope: 'anchor'}]

I'm not sure what else I can say here. As mentioned above:

RFCXXXX comes from the original source being the "anchor". This is used by the xml2rfc software which is the main consumer of the BibXML Service.
'RFC XXXX also comes from the original source as identifier.

Technically, we can omit the "anchor", and have the BibXML Service generate that for the xml2rfc fetches (remember in legacy paths, the "anchor" attribute must match the filename of the request).

Samples of terminology:

A bibliographic item is a representation of the metadata of an information resource.

A bibliographic item can be expressed in YAML or XML.

A citation reference is an entry in the bibliography that allows a reader to locate the cited information resource.

These are references:

A citation is the "instance" of referring to a citation reference.

The SOURCE here is a citation. A citation allows also incorporation of a "locality".

This is a citation:

Okay, so where I used “citation” in context of BibXML service I probably meant “bibliographic item”.

IETF (the authoritative source) won't be able to specify the document identifier type used by other organizations, it can only give its own "canonical identifier". So "ISO" or "OGC" should not be in the bibliographic data.

Well, you previously said that ISO and OGC cite "RFCXXXX" as "IETF RFC XXXX". Immediately it looked to me that to accommodate this citation Relaton would provide { type: "ISO", id: "IETF RFC XXXX" }. If not, then how would ISO and OGC obtain this "IETF RFC XXXX" string they use for citing?
This may be a Relaton question rather than BibXML service, but I want to understand what’s going on here if we’re using Relaton data model.

If not, then how would ISO and OGC obtain this "IETF RFC XXXX" string they use for citing?

The author either writes it, or the authoring software "builds" this string given raw data (e.g. {"series": "RFC", "number":"XXXX"}), themselves.

IETF (the authoritative source) won't be able to specify the document identifier type used by other organizations, it can only give its own "canonical identifier".

But DOI is used by Crossref, which is another organization, so how come IETF documents can have a DOI?
Relaton model seems to be confused as to type semantics. In some cases it’s used as a namespace for third-party publication identifier (DOI, ISBN). In other cases it’s used to specify the publishing organization (IETF, 3GPP).

But DOI is used by Crossref, which is another organization, so how come IETF documents can have a DOI?

As previously mentioned:

A document has an authoritative identifier.
A document can have multiple identifiers. The DOI is this.

Relaton model seems to be confused as to type semantics.

I cannot claim that the semantics are perfect but I disagree.

In some cases it’s used as a namespace (or schema) for some publication identifier (DOI, ISBN).

DOI and ISBN identifiers are what they are.

The former is a unique identifier that contains a "scope" and publication ID.
ISBN Is a 9 or 13 digit unique number that identifies a publication.

In other cases it’s used to specify the publishing organization (IETF, 3GPP).

No, they are used to indicate the "identifier". In this case, IETF and 3GPP are publishers, as well as the organization assigning the authoritative identifier.

In yet other cases it’s used for something else entirely (e.g., in case where it appears more than once with different scope values).

Different identifiers of the same publisher need to be distinguishable.
Why is this a problem?

No, they are used to indicate the "identifier". In this case, IETF and 3GPP are publishers, as well as the organization assigning the authoritative identifier.

So we seem to have different types that are not captured by the schema
It’d make more sense to indicate the actual type of the identifier in the type field, and have it determine type-specific payload schema. For example, we can have type=authoritative and type=external with type-specific payloads, and for type=authoritative we can have publisher=IETF or publisher=3GPP while for type=external we can have namespace=DOI or schema=DOI, etc.

Why is this a problem?

I am forced to add a hard-coded, manually maintained enum saying “these particular values of docid.type mean that id is authoritative identifier formatted for human readability, and those other values mean strict externally resolvable ID” as a crutch to address user confusion and work around a poorly normalized source data model.

My latest comments have been addressed per internal discussion about the meaning of docid and docid.type, and the original ticket description I believe no longer applies to current GUI.


Portrait Stats explicit install directive

Portrait Stats bundles CommunityTraitIcons for manual installs. If I understand correctly, should not include the bundled dependency when doing CKAN install so it can be obtained and updated separately.
Will this fix the existing ckans in CKAN-meta automatically or should I PR corresponding changes there as well?

When there's no install property, the default is
    {
        "find": "<identifier>",
        "install_to": "GameData"
    }

https://github.com/KSP-CKAN/CKAN/blob/5331bf9344f6729a6b96f52bea45bdec245a3bb3/Core/Types/ModuleInstallDescriptor.cs#L109-L120
So this change would have no effect and is unnecessary.

Thanks for clarification.


Download url with query string

I'm having issues with this.
Downloading from url like this 'https://somedownloadsite.com/download/video.mp4?param=123123
Throws this log message
video.mp4?param=123123 does not exist, download it now.
Seems that query string params are being used along with the name to search if the file is already downloaded.

what is the expected behavior? to download the file with different params or to not download it?

Just to ignore the params when checking if the file is already downloaded.
Now is using the video name with the url query string params to check if the video exists.

Resolved with #33, thank you!


Write a JavaScript program to find volume of a cube

Description
Write a JavaScript program to find volume of a cube
Volume of cube = Side^3
Side : 2

Volume : 8

How to contribute

Save the solution in program/FindVolumeOfACube.js file
Add FindVolumeOfACube.js file in find-volume-of-a-cube folder

!assign

!assign

Duplicate of #63


Use radio buttons for the noise types

The pros that I see of converting the ToggleButton's to RadioButton's is that:

More obvious that only one noise type can be selected at a time.
Remove the manual handling of setting and unsetting whether a button was checked or not.
Another benefit of the above point is that a lot of duplicated logic is removed.

Looks good. The only change I made was I set textAppearance to large which matches the labels used in the layout. Thanks for the help!

Thanks and your welcome!


fix(deps): :arrow_up: update dependency vega to v5.26.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

vega
5.25.0 -> 5.26.0

Release Notes

vega/vega (vega)
v5.26.0
Compare Source
Changes from v5.25.0:
vega-functions

Add geoScale expression function. (thanks @binste)

vega-scale

Fix tickMinStep calculation. (thanks @kanitw)

vega-scenegraph

Add experimental hybrid canvas/SVG renderer (thanks @jonmmease)
Fall back to textMetrics.width for user defined width function (thanks @jonmmease)

vega-selections

Fix null handling in vlSelectionTest (thanks @arvind, @jonmmease)

vega-transforms

Add aggregate parameters to vega-transform, and exponential moving average. (thanks @Xitian9)

vega-typings

Bump typings to a 1.0 release. (thanks @domoritz)

vega-voronoi

Fix reference for voronoi path point. (thanks @suchanlee)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm WARN cli npm v10.2.3 does not support Node.js v20.2.0. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^18.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/material
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   2 more (@angular/platform-browser, @ngneat/spectator)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-11-10T17_34_51_124Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-11-10T17_34_51_124Z-debug-0.log


nswag openapi2csclient generates class twice - compilation error

I just updated from 13.19.0 to 14.0.7 and it seems that the swagger2csclient has been removed.
I switched to openapi2csclient now, but the generated code is vaulty. It generates the client class twice into the same file and hence causes an compilation error.
The command I ran: .\nswag\Net80\dotnet-nswag.exe openapi2csclient /input:http://somewhere:1234/swagger/v1/swagger.json /classname:MyApiClient /namespace:SomeWhere.Clients /output:.\Somewhere\Clients\MyApiClient.cs
here is the generated code. I collapsed everything except of the classes and the entire code is inserted twice:

When you define a single class name, but there are multiple endpoints in the openapi description with overlapping names, those are generated inside the same class, which yields duplicate code, see  https://github.com/RicoSuter/NSwag/issues/2660


If the embassy feature is enabled, ensure that a time driver implementation is available

Closes #564

(Forgot to add the label when I opened the PR so the Changelog job will never pass here)


MAINT: Update README check

On master I see this warning:
warning: Check: This command has been deprecated. Use `twine check` instead: https://packaging.python.org/guides/making-a-pypi-friendly-readme#validating-restructuredtext-markup

Following their advice we now build the dist/ and check it, eventually seeing:
twine check dist/*
Checking distribution dist/mne-0.19.dev0-py3-none-any.whl: Passed
Checking distribution dist/mne-0.19.dev0.tar.gz: Passed

This reminds me, perhaps we should use twine to upload a 0.19 wheel to to PyPi instead of just doing our standard source distribution. Modernize the process a bit.

thx @larsoner


Tabnine Hub: Lost Connection

I'm fairly certain I've gotten everything configured properly and I'm logged into TabNine, but for some reason :CmpTabnineHub does not want to connect. CmpStatus also lists TabNine as "unused".
Here's my relevant config:
cmp.setup {
  experimental = {
    native_menu = false,
    ghost_text = true,
  },
  snippet = {
    expand = function(args)
      require('luasnip').lsp_expand(args.body)
    end,
  },
  mapping = cmp.mapping.preset.insert {
    ['<C-b>'] = cmp.mapping(cmp.mapping.scroll_docs(-4), { 'i', 'c' }),
    ['<C-f>'] = cmp.mapping(cmp.mapping.scroll_docs(4), { 'i', 'c' }),
    ['<C-p'] = cmp.mapping.select_prev_item(),
    ['<C-n'] = cmp.mapping.select_next_item(),
    ['<C-e'] = cmp.mapping.close(),
    ['<Shift-Space>'] = cmp.mapping.complete(),
    ['<CR>'] = cmp.mapping.confirm { select = true },
  },
  formatting = {
    fields = { 'kind', 'abbr', 'menu' },
    format = function(_, vim_item)
      vim_item.menu = vim_item.kind
      vim_item.kind = icons[vim_item.kind]

      return vim_item
    end,
  },
  sources = {
    { name = 'nvim_lsp' },
    { name = 'luasnip' },
    { name = 'cmp_tabnine' },
    { name = 'buffer' },
    { name = 'path' },
  },
  preselect = cmp.PreselectMode.None,
}

cmp.setup.cmdline('/', {
  mapping = cmp.mapping.preset.cmdline(),
  sources = {
    { name = 'buffer' },
  },
})

tabnine.setup {
  show_prediction_strength = true,
}

Am I overlooking something?

Service seems to be running, but when I hit the URL in the browser, it appears some verification needs to happen - but this is not my TabNine account. ???

This is not enough information to help you.

How can you tell its another account? Its not apparent from the image above.
Anyway, you need to use this page to login into your own account.

I'm already logged into Tabnine Hub:

The screenshot above is a completely different account (with over 1600) notifications - that is not my account.

This could have been an anomaly. I just tested and :CmpTabnineHub does attach the correct URL as query parameter, but nevertheless the connection fails because it assumes I'm not logged in. When I open the hub directly in the browser, I'm logged in.

I think you are missing something.
Opening the hub of you locally running tabnine process enables you to configure it, and set your account info.
Did you do this?

Again, I just ran :CmpTabnineHubUrl and and opened the URL this returned in my browser - this is not my account.

I have no idea what configuration needs to be done - you mention it in the README but this links to a document header, which is not very clear. For the record, I have logged into the Tabnine Hub so I would expect this to just work, unless you can be clearer on what exact configuration needs to be done.

once you open the hub from within nvim, you should be able to login via the top left menu.
anyway, this should not stop you from getting completions. maybe you disabled the tabnine source for a specific file type?
try giving a minimal working config which recreates the problem.

I had the same issue. I was experimenting with Tabnine with a different Nvim plugins something might have got messed up. What helped me was to delete all the contents in the Engine file path, and reinstall this plugin. Mine was found in /home/.local/share/nvim/site/pack/packer/start/cmp-tabnine
If you go to Tabnine Hub -> Support -> General Info you can find where the Engine Path is.

Just FYI - I got into this issue on my PC with Brave. It works after it turns off the shield. Refer https://gyazo.com/67d6bdedeacbc78c30b34141744a9004

Closing this, as it seems to be related to specific browsers.


propose-update does not generate proper changelog from release tag

As discussed in issue #298, the idea was that the changelog gets generated from the upstream release tag (or the github description, etc). I think that even worked right when I tested that, but it seems to have regressed. For cockpit-ostree 179 it now just generates:
--- a/cockpit-ostree.spec
+++ b/cockpit-ostree.spec
@@ -1,12 +1,17 @@
 Name: cockpit-ostree
-Version: 178
+Version: 179
 Release: 1%{?dist}
 BuildArch: noarch
 Summary: Cockpit user interface for rpm-ostree
 License: LGPLv2+
 Requires: cockpit-bridge >= 125
 Requires: cockpit-system >= 125
-Requires: /usr/libexec/rpm-ostreed
+# On RHEL Atomic 7, the package name is different (curiously not on CentOS Atomic)
+%if 0%{?rhel} == 7
+Requires: rpm-ostree-client
+%else
+Requires: rpm-ostree
+%endif

 # Download from https://github.com/cockpit-project/cockpit-ostree/releases
 Source: cockpit-ostree-%{version}.tar.gz
@@ -27,6 +32,9 @@ find %{buildroot}%{_datadir}/cockpit/ -name '*.map' | xargs rm --verbose
 %{_datadir}/cockpit/*

 %changelog
+* Wed Jul 24 2019 Martin Pitt<EMAIL_ADDRESS>- 179-1
+- new upstream release: 179
+
 * Fri Jul 12 2019 Martin Pitt<EMAIL_ADDRESS>- 178-1
 - new upstream release: 178

(that's just the .spec change, ignoring changes to sources and .gitignore).
This is a bit sad, the changelog should include some useful information, bug refs, etc. I did 178 with an earlier packit master as well, same problem (but that was after #298 landed).
❱❱❱ git -C ~/tmp/packit/ rev-parse HEAD
efb466df8567c2050b09f6854b515250ac1dfa7a

So your expectation is to get a full-blown upstream release changelog included in the %changelog?
Could you please provide a sample entry which would make you cheerful?

Maybe I was just imagining that it worked before then? Ideally we want to copy the upstream git tag description, i. e. what can be seen on the GitHub /releases page. In this case:
 %changelog
* Wed Jul 24 2019 Martin Pitt<EMAIL_ADDRESS>- 179-1
- spec: Depend on package instead of file path (rhbz#1731687)
- Add packit configuration

If packit can't or doesn't want to (for clean architecture reasons) look at the tag, would it be possible to feed that in through an option?

that makes sense to me and sounds like a pretty solid RFE

Thanks @TomasTomecek! Sorry if I considered that a regression, sometimes one sees what one wants to see :)

This is a solid RFE, let's keep this one.

I am not sure about the priority, but it looks still relevant to me.

We definitely want to provide a way for everyone to populate %changelog in the spec file with some sane default.

bump

Our plan here was to "outsource" this task to GSoC or RHOSC but afaik we did not pull it off :/
completely agree this would be really useful to have in packit by default

bump :-)

@martinpitt sorry for the stale-bot

bump

Franto, I just adding this to the upstream project and wanna discuss with you.

This looks like a great feature. I'm looking forward to test this!


Can't publish process-execution-automator

Hello,
I update the repository according the last documentation, but the workflow failed during the publication
Here is the action:
https://github.com/camunda-community-hub/process-execution-automator/actions/runs/6255409771/job/16984910326
It failed here
#7 [2/4] COPY target/process-execution-automator-*-exec.jar /app.jar
#7 ERROR: lstat /var/lib/docker/tmp/buildkit-mount359220097/target: no such file or directory
------
 > [2/4] COPY target/process-execution-automator-*-exec.jar /app.jar:
------
Dockerfile:4
--------------------
   2 |     FROM openjdk:17-alpine
   3 |     EXPOSE 9081
   4 | >>> COPY target/process-execution-automator-*-exec.jar /app.jar
   5 |     COPY src/main/resources /app/scenarii
   6 |     COPY src/test/resources /app/scenarii
--------------------
ERROR: failed to solve: lstat /var/lib/docker/tmp/buildkit-mount359220097/target: no such file or directory
Error: buildx failed with: ERROR: failed to solve: lstat /var/lib/docker/tmp/buildkit-mount359220097/target: no such file or directory

The file process-execution-automator-1.2.0-exec.jar is correctly generated on my PC via a mvn install
What's going on?
Thanks

Hi @pierre-yves-monnet , is this issue still present?


Add support for passing arbitrary flags to test executables.

This also removes the support for specifying multiple binaries,
which shouldn't be too much of an issue since it's easy to script
a loop if multiple binaries are to be executed.

@pbos can you have a look?

I submitted 363e11aa0d70b88b0ef1364687bd10171425a3f9 instead. Does this work for you? Additional arguments must be specified after a '--'.

It doesn't help with the problems we're seeing in http://build.chromium.org/p/client.webrtc.fyi/waterfall unfortunately, since it's passing --no-sandbox without any -- terminator.
Then we'd have to change runtest.py instead...

(Make that bc6168b08623a4be83b31e825944bcdca1818d81, had a bug.)

Considering this fixed since we found a way to add -- before --no-sandbox gets added. Closing. :)


Source Code for Max Array Sum in C++

Related Issue
Closes: #1038
Describe the changes you've made
Adding Source Code for Max Array Sum in C++
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Language used for coding
C++
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have documented the code.
[x] New and existing unit tests pass locally with my changes.

Please review the code ;-)


How to find out why the results are inconsistent with vllm

The model I'm using is vicuna-13b.
I tested more than 100 cases, and about 10% of the results of inference on tensorrt-backend are different from the results of inference on vllm. How to find out the specific reason?
All the parameters during vllm inference are here, but I don’t know how to pass them on tensorrt.
sampling params: SamplingParams(n=1, best_of=1, presence_penalty=0.0, frequency_penalty=0.0, temperature=0.1, top_p=0.35, top_k=-1, use_beam_search=False, length_penalty=1.0, early_stopping=False, stop=['</s>'], ignore_eos=False, max_tokens=512, logprobs=None, prompt_logprobs=None, skip_special_tokens=True

The different results of TRT-LLM and vllm are expected because we do many optimization and affect the computation order. Besides, using sampling also leads to different results.
If you want to see fully same results, you can try running both models on FP32 and use greedy search. From our experience, most outputs should be same under such case.


[reconfiguration] fix bug caused by #8484

Motivation
The bug is that we expect a compute result for every transaction in the block,
without considering the fact that if a block is suffix of a reconfiguration block, its
compute result is carried from its parent and should be viewed as empty.
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
ENABLE_FAILPOINTS=1 ./scripts/cti --pr 8879 --run reconfiguration
Reconfiguration: total epoch: 101 finished in 131 seconds
Related PRs
(If this PR adds or changes functionality, please take some time to update or suggest changes to the docs at https://developers.diem.com, and link to your PR here.)
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

/land

/cherry-pick release-1.4

@zekun000 :cherries: Opened PR #8884 to cherry-pick these changes into release-1.4


Make AutoLinkPlugin matchers export

close: #3940

Should we export factory function instead that will accept reg exp? There's a lot of url/email patterns and apps are often very sensitive about it

Should we export factory function instead that will accept reg exp? There's a lot of url/email patterns and apps are often very sensitive about it

Yea, this might be a good idea. I was hesitant about this change for the same reason. We are getting into the business of maintaining reg ex patterns that are notoriously fickle. At the same time, it's nice for users to have something that usually works by default, and they can always eject and do their own pattern.
Factory function seems like a good idea, regardless

Is it like exporting a factory function like the one below?
function createLinkMatcherWithRegExp(
  regExp: RegExp,
  urlTransformer: (text: string) => string = (text) => text,
) {
  return (text: string) => {
    const match = regExp.exec(text);
    if (match === null) return null;
    return {
      index: match.index,
      length: match[0].length,
      text: match[0],
      url: urlTransformer(text),
    };
  };
}

@fantactuka @acywatson
I have fixed it, please review.


Comment field contents cannot be emptied when filled

PDA version
0.4.0
Python version
3.6
Steps to Reproduce

Create a comment (Edit, add comment and save)
Press "Save Changes" button (Apply Changes, close)
Remove the comment (Edit, remove comment and save)
Press "Save Changes" button (Apply Changes, close)
The removed comment will show up again

It is possible to change the comment, but it's not possible to clear it. Putting in some spaces does not work to clear it.
If the comment is removed of a similar named record (i.e. "@") of same type (I tested with TXT) and a new comment added to a similar named record (i.e. "@") with same type (again TXT) it will remove the comment from the first and add the new comment to the second record. If you change a different named (i.e. test) record with same type (TXT) it does not affect the comment on the "@" record. Removing the comment on the different named record (i.e. test) has the same result as with the "@" record of type TXT.
I'm using PowerDNS Auth 4.7.3 with MySQL backend.
PowerDNS-Admin is running in the docker container as supplied on https://hub.docker.com/r/powerdnsadmin/pda-legacy:latest
Previously I was running PowerDNS-Admin of 11 months ago (likely version 0.2.4) from https://hub.docker.com/r/ngoduykhanh/powerdns-admin
With old version this did not happen.
I've tested with different zones and they all show this behavior.
I've checked the open and closed issues for similar bug but could not find it.
If you have questions, please let me know.
Expected Behavior
The expected behaviour would be that the comment can be removed and not show up again after "Save Changes" (Apply Changes and Close).
Observed Behavior
Removing the comment will show it again after "Save Changes" (Apply Changes and Close) unless a new comment is added under the same named record with same type.

It seems this issue revolves around a scenario where there is a single record existing / remaining in an RRSet. I found I was able to remove comments from records when there was more than one matching record in the RRSet. Once I tried clearing the comment on the only remaining record in the RRSet that had a comment, the comment would return after saving.

Should I test with 0.4.1 (new latest as of this week)? If yes, I can hopefully do so tomorrow.
The quote in the comment you made before the latest, is that something from PowerDNS itself?

@alm-nl no, nothing new to test here. This is likely an issue in all versions based on the comment I found. That comment is in the current code base. From what I gather, it seems like a pretty nasty issue to try and overcome due to the general design of PDA Legacy.
This just goes on the list of reasons why PDA Next will become more of a synchronization strategy as opposed to the facade strategy that PDA Legacy currently creates on top of PowerDNS Authoritative server.
If you have noticed, I tagged this particular issue as wont-fix, because overcoming this is just not worth the effort. PDA Next will definitely solve this kind of problem much better.

@corubba Thank you for your extensive reply, I'm not sure if I will be able to fix it myself though. Would have to learn Python to be able to do so, next to fully understand what is happening or what should happen.

One solution for next-gen, besides the app better fits with the RRSet concept, and the way records from the same RRSet share some properties, would be an option to set the PDNS Backend type in the backend config, to enable comment support.


My account - Add text field to instruct users to contact support to change email

Description:
Let's add here a text field on all the apps. We do not have automated way for users to change their email so we need to instruct here to contact support if the are looking for a way to do it.
Text:
Contact<EMAIL_ADDRESS>if you wish to change email address.

iOS card: https://github.com/ruuvi/com.ruuvi.station.ios/issues/2132
Web card: https://github.com/ruuvi/com.ruuvi.station.webui/issues/434

@andreevdenis text was showed on top of buttons not below.
Please move the text underneath the buttons, also new language strings added to localisation file.

Not underneath buttons in latest build, assuming build is coming.

QA passed


How to retrieve webpack config from elsewhere ?

Hi there,
is someone have an idea on how to retrieve the actual webpack config object from mix ?
I'm trying to setup an e2e testing and want to retrieve those settings... :-/

It's in this directory  --config=node_modules/laravel-mix/setup/webpack.config.js
See docs/installation.md#npm-scripts

Thank you @ruchern ! I'll try that ASAP and let you know.


Relationship is automatically deleted from entity payload when its target entity is deleted

Let's suppose that we have 2 entities A and B, where entity A have a relationship attribute targeting the entity B.
If entity B is deleted, we notice that the entity A is automatically modified by deleting the relationship targeting the entity B.

Fixed in<PHONE_NUMBER>f933910682c3ebfdf613be1f9e9b19


Play animation when custom note is pressed

Self explanatory title. I have a custom animation for BF and i want it to play whenever a specific custom note is pressed.


Links not underlined if link uses :

Dear all,
In reference to https://github.com/nylas/N1/issues/1842, I am still seeing the issue that links are not always underlined. It seems to occur if a : is used in the link.

Warmly,
-Robert

@orschiro Good find. We'll need to update autolinker. Thanks for the test cases.

Welcome! :-)

Same issue here, but I do not see broken links in other mail clients (e.g., Gmail web, ios Outlook). This is really a pain to deal with, when you get several emails per day with broken links.


[bug] running build never finishes on a vite/tamagui/typescript project

Description
running yarn build for the web project does build the project but never reaches the Done and has to be stopped manually.

when removing the tamaguiPlugin(...) from vite.config.ts AND also removing the destructuring of it the build does succeed.

also, when attempting to import {tamaguiExtractPlugin, tamaguiPlugin} from '@tamagui/vite-plugin'; i am getting this error when trying to yarn build AND when trying to yarn dev:

using v1.0.1-beta.216 of Tamagui
this repo can be used to reproduce this issue.

@natew
Any idea about what might be the cause for this issue?

Tried out your repo and I see something different when I enable compiler.

Next release will have a loadModule console log for debugging why it tries to get that path if you set DEBUG=tamagui 03d3545eb

Tested on a new repo and it works for me


Easy fuzzy issues

Fixing some of the smaller issues from #2017. I foresee the other couple of issues taking a bit longer to fix, but these ones can be merged now.

Apparently there's also a change to the fuzzer I forgor 💀


https ?

Regarding: line 508 in update.py
Should it be "https://" ?

Hmmm. Possibly. Although if someone has a proxy setup without HTTPS, it'll fail.
I only hardcode HTTPS other places because I know arcgis.com supports this.
I may need to make this a doc point in the proxy setting or add it to the ini.


RPCs not compliant with the JSON-RPC spec

Dear Continuum Team,
I hope this message finds you well. My name is Josep, and I'm the technical lead of the Polkadot-API (PAPI) team.
In case you're not familiar with Polkadot-API, it's a modern library designed to replace PolkadotJS, built on top of a properly specified and standardized JSON-RPC API for Polkadot-based networks. The modern JSON-RPC APIs offer many advantages over the legacy ones; you can read more about it here and here.
We've noticed that there are no available public Continuum RPCs that expose the modern JSON-RPC API. At least, the only one that we are aware of (wss://continuum-rpc-1.metaverse.network/wss) doesn't expose it. Also, I wasn't able to test if your chain works using the light-client provider because it seems that your chainspecs are outdated 😞.
Our team has developed a middleware solution to ensure that Polkadot-API can function seamlessly with chains running older versions of the Polkadot-SDK node. Unfortunately, it appears that the RPC providers for Continuum are using an even older version, which the middleware does not support.
We kindly request that you consider working with your RPC providers to upgrade the PolkadotSDK node to a more modern version that supports the new JSON-RPC API. This upgrade would enable DApp developers to easily interact with your chain using PAPI, unlocking benefits such as improved performance, reduced resource usage, out-of-the-box strong type generation for your chain, and the ability for developers to handle runtime upgrades on the fly.
Thank you for your time and consideration.
Best regards,
Josep

Hi Josep,
Thank you for reaching out.
Yes, the reason we haven't pushed the latest RPC yet is that a recent dApp in our ecosystem depends on the current RPC endpoints, which have been seamlessly integrated into their application. We need to evaluate some recent changes in the latest API to avoid any interruptions.
Our engineering team has already pushed some changes to the latest Polkadot-SDK, which are in the branch but haven't been deployed yet due to the above concerns.
We will keep you updated on the release when it is ready.
Regards,
Justin

Yes, the reason we haven't pushed the latest RPC yet is that a recent dApp in our ecosystem depends on the current RPC endpoints, which have been seamlessly integrated into their application. We need to evaluate some recent changes in the latest API to avoid any interruptions.

This makes no sense. The new PolkadotSDK node versions still expose all the old RPCs.

Yes, the reason we haven't pushed the latest RPC yet is that a recent dApp in our ecosystem depends on the current RPC endpoints, which have been seamlessly integrated into their application. We need to evaluate some recent changes in the latest API to avoid any interruptions.

This makes no sense. The new PolkadotSDK node versions still expose all the old RPCs.

Hi Joseph,
Last time we tested, it broke the dApp integration. I will push it through to the team to evaluate.


Docs: Fix spelling mistakes

Overview
I was using the repository and noted some spelling mistakes. This PR aims to fix them. Particularly, in the README.md and CONTRIBUTING.md files.
README.md
'reuse' instead of 'resuse':
-as it maximizes the resuse value of your workflow for non-tag pushes.
+as it maximizes the reuse value of your workflow for non-tag pushes.

Remove stutter of "can can":
-You can can configure a number of options for your
+You can configure a number of options for your

Capitalize 'Docker':
-> **⚠ Note:** This action was previously implemented as a docker container, limiting its use to GitHub Actions Linux virtual environments only. With recent releases, we now support cross platform usage. You'll need to remove the `docker://` prefix in these versions
+> **⚠ Note:** This action was previously implemented as a Docker container, limiting its use to GitHub Actions Linux virtual environments only. With recent releases, we now support cross platform usage. You'll need to remove the `docker://` prefix in these versions

Rename 'OSX' to 'macOS':
-   A GitHub Action for creating GitHub Releases on Linux, Windows, and OSX virtual environments
+   A GitHub Action for creating GitHub Releases on Linux, Windows, and macOS virtual environments

CONTRIBUTING.md
Additional space removed:
-This a [JavaScript](https://help.github.com/en/articles/about-actions#types-of-actions)  action but uses [TypeScript](https://www.typescriptlang.org/docs/home.html) to generate that JavaScript.
+This a [JavaScript](https://help.github.com/en/articles/about-actions#types-of-actions) action but uses [TypeScript](https://www.typescriptlang.org/docs/home.html) to generate that JavaScript.

End sentences with period:
-Tests can be found under under `__tests__` directory and are runnable with the `npm t` command
+Tests can be found under under `__tests__` directory and are runnable with the `npm t` command.

-A minimal attempt at keeping a consistent code style is can be applied by running `npm run fmt`
-
+A minimal attempt at keeping a consistent code style is can be applied by running `npm run fmt`.

Let me know what you think of these changes!

Thanks @yanyi!


[Microsoft Generator CSharp] Properly Dispose of Custom Assembly Resolve Event

As part of https://github.com/jorgerangel-msft/Microsoft.Generator.CSharp/pull/4, the nuget catalog now contains a custom assembly resolve event to handle resolving a plugin's dependencies dynamically. If the event is removed from the app context, the app will hold a reference to it throughout the lifecycle of the app. The event should be properly disposed of when it is no longer needed, preferably within the implementation of the NugetCatalog.

closed due to using npm packaging instead


⚠ Thumbnails API Endpoint has degraded performance

In 079e1cb, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 4630 ms

Resolved: Thumbnails API Endpoint performance has improved in ccc56c4 after 4 minutes.


Review Architecture Diagram for Security SIA (Need By Last Week of July 7/25)

Review Diagram and edit for completeness/correctness for SIA
To be Reviewed by the last week of July
Link to File

@maheese I have reviewed the diagram and the only thing I see missing would be the Auth API where the token service is hosted. CAMPD uses that to get the client token for the camd services endpoints that are protected.

I am good with this so closing


Domino 14: OutOfMemoryError: Java heap space

Dear Jesse,
after you fixed #327, I was able to continue compiling the project. However, after a few minutes an error occurred and Domino crashed.
This is the maven output:
[INFO] --- nsfodp:4.0.6:compile (default-compile) @ Edy ---
[INFO] Compiling ODP
[INFO] Writing ACL from pom.xml into AppProperties/database.properties
[INFO] Compiling with server: http://myserver:8052/org.openntf.nsfodp/compiler
[INFO] Installing bundles
[INFO] - Installed no bundles
[INFO] Initializing libraries
[INFO] Compiling Java source
[INFO] - Compiling 1,288 classes
[INFO] Compiling custom controls
[INFO] Compiling XPages
[INFO] Creating destination NSF
[INFO] Importing DB properties
[INFO] Importing basic design elements - early part (Java libs)
[INFO] Importing LotusScript libraries
[INFO] Importing basic design elements

Then after some minutes Domino crashes and i get this error (while using  the -e flag for maven). I was not able to increase the heap space.
I'm not really sure, but this seems to be a place in the code that receives the successful build after the POST request.
java.lang.OutOfMemoryError: Java heap space
    at java.util.Arrays.copyOf (Arrays.java:3541)
    at java.io.ByteArrayOutputStream.ensureCapacity (ByteArrayOutputStream.java:100)
    at java.io.ByteArrayOutputStream.write (ByteArrayOutputStream.java:112)
    at org.openntf.maven.nsfodp.util.ResponseUtil.readLine (ResponseUtil.java:128)
    at org.openntf.maven.nsfodp.util.ResponseUtil.monitorResponse (ResponseUtil.java:75)
    at org.openntf.maven.nsfodp.CompileODPMojo.compileOdpOnServer (CompileODPMojo.java:564)
    at org.openntf.maven.nsfodp.CompileODPMojo.execute (CompileODPMojo.java:370)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at java.lang.invoke.DirectMethodHandle$Holder.invokeStatic (DirectMethodHandle$Holder)
    at java.lang.invoke.LambdaForm$MH/0x0000011b44009400.invoke (LambdaForm$MH)
    at java.lang.invoke.LambdaForm$MH/0x0000011b44009800.invokeExact_MT (LambdaForm$MH)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invokeImpl (DirectMethodHandleAccessor.java:155)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)

With Domino 12 we get an nsf of about 70mb.

I found a project that reproduces it, but it makes the situation thornier: it looks like the trouble is that the call to compile LotusScript in a note will crash the server given some combination of input, even though the same won't happen on 12.0.2. I see this stack from the NSD:
#0  0x00007f93b2e3ee7d in select () from /lib64/libc.so.6
#1  0x00007f93b35a5f0f in FRDoSleep (secs=secs@entry=1, usecs=usecs@entry=0) at cleanup.c:944
#2  0x00007f93b35ad6bd in OSRunExternalScript (passed_script=passed_script@entry=0x7f92e68189e0 "\"/opt/hcl/domino/notes/latest/linux/nsd.sh\" -batch -crashpid 1164 -crashtid<PHONE_NUMBER>", flags=flags@entry=1) at cleanup.c:3909
#3  0x00007f93b35b0587 in OSFaultCleanupExt (action2take=action2take@entry=0, CleanupScriptExecFlag=CleanupScriptExecFlag@entry=4096, iniFileName=iniFileName@entry=0x0, szProcess=szProcess@entry=0x0, Length=Length@entry=0, CrashedPID=CrashedPID@entry=0x0) at cleanup.c:1495
#4  0x00007f93b35b05c1 in OSFaultCleanup (action2take=action2take@entry=0, CleanupScriptExecFlag=CleanupScriptExecFlag@entry=4096, iniFileName=iniFileName@entry=0x0) at cleanup.c:1281
#5  0x00007f93b357a6cf in fatal_error (signl=11, info=<optimized out>, context=<optimized out>) at break.c:2207
#6  <signal handler called>
#7  LSsExprList::GetNumExprs (this=0x0, pMoreExprs=pMoreExprs@entry=0x7f92e681998e) at lsprsnod.cpp:398
#8  0x00007f93b542a0cd in SIcParser::DoArray (this=this@entry=0x7f913c3ed850, iArraySymRel=iArraySymRel@entry=6108, arrSize=@0x7f92e6819a18: 0, bRedim=<optimized out>) at lsprsd2.cpp:1774
#9  0x00007f93b542aea6 in SIcParser::vardcl (this=this@entry=0x7f913c3ed850) at lsprsd2.cpp:322
#10 0x00007f93b542ffa5 in SIcParser::WalkSubTree (this=0x7f913c3ed850, pnode=0x7f913c445430) at lsprss2.cpp:1787
#11 0x00007f93b542fcb9 in SIcParser::WalkSubTree (this=0x7f913c3ed850, pnode=0x7f913c445470) at lsprss2.cpp:1607
#12 0x00007f93b542fcb9 in SIcParser::WalkSubTree (this=0x7f913c3ed850, pnode=0x7f913c4454b0) at lsprss2.cpp:1607
#13 0x00007f93b542fcb9 in SIcParser::WalkSubTree (this=this@entry=0x7f913c3ed850, pnode=0x7f913c449230, pnode@entry=0x7f913c40e770) at lsprss2.cpp:1607
#14 0x00007f93b5430050 in SIcParser::_script (this=0x7f913c3ed850) at lsprss2.cpp:103
#15 0x00007f93b541e340 in SIcParser::attach (this=this@entry=0x7f913c3ed850) at lsparse.cpp:1373
#16 0x00007f93b541ffd1 in SIcParser::Parse (this=this@entry=0x7f913c3ed850) at lsparse.cpp:1029
#17 0x00007f93b54215f8 in SIcParser::doParse (this=this@entry=0x7f913c3ed850, hMod=hMod@entry=0x7f913c3d8500, pfGetc=pfGetc@entry=0x7f93b53ee820 <GetcFromMem(LShINSTANCE, LShMODULE, PLSMEMSOURCE)>, pfErr=pfErr@entry=0x7f93b53ee0a0 <ApiErrorProc(LShINSTANCE, LShMODULE, LSUSHORT, LSUSHORT, LSLINE, LSREGNAME, LSREGNAME)>) at lsparse.cpp:260
#18 0x00007f93b53ed975 in LSsInstance::Compile (this=0x7f913c301e98, ModName=0x7f913c31c520, ModRefCon=0x7f913c0984c8, pMemSource=0x7f92e681a400, pModUseList=0x7f92e681a420, pGetcProc=0x7f93b53ee820 <GetcFromMem(LShINSTANCE, LShMODULE, PLSMEMSOURCE)>, pErrProc=0x7f93b3ca0fa3 <LsCompileErrorCallback>, flags=133, retMod=0x7f913c0984e0) at apimod.cpp:234
#19 0x00007f93b53b0352 in LSIModule::CompileScriptForSave(char*, unsigned int, short, unsigned short, unsigned char**) () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#20 0x00007f93b53ba7dd in CLSIDocument::CompileTheLibrary(unsigned int, unsigned int, unsigned int) () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#21 0x00007f93b53bb6fb in CLSIDocument::CompileTheNote(unsigned int, unsigned int, unsigned int) () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#22 0x00007f93b53bc8ec in LSCompileNoteExt () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#23 0x00007f93b3ca1335 in NSFNoteLSCompileExt (hDB=250, hNote=100, dwFlags=0, pfnErrProc=0x7f92dc653b28 <J_LSCOMPILEERRPROC::FCT_LSCOMPILEERRPROC(LSCOMPILE_ERR_INFO const*, void*)>, pCtx=0x7f92e681a8a0) at wrap4.c:220
#24 0x00007f92dc64ed59 in Java_com_darwino_domino_napi_DominoAPIImpl_NSFNoteLSCompileExt () from /tmp/libdominonapi11296583853798654116.so

That's lower-level than anything I'm explicitly doing, and it seems like it's dying during parsing. I'll have to try to track down if there's a specific construct in LotusScript that causes this, which would be ideal for a support case. That could be a long process, though, since the app I picked has a huge amount of LS code in it.

Oh: it's also on Linux specifically for me. 14.5 EAP1 on Windows worked without issue for me, while 14.0 and 14.5 EAP1 crash on Linux in containers.

Ah, some good news! I was able to narrow it down to a single library, and it's a common one at that: this NSF uses OpenLog, and OpenLogFunctions reliably crashes the server when I add it to an ODP that was previously working fine. Even better, OpenLogFunctions has no external Use or Uselsx statement, so this should let me narrow it down. It may end up being a matter for HCL Support, but the simpler the reproduction the better.

Hey Jesse, thank you for the support. I'm not sure if it helps but we use SLF4J for logging

Since it seems like yours dies on "basic design elements", it could be that you have something in there that trips up the parser in the same way as OpenLog does.
Do you see NSDs from server crashes around when you try this compilation? That could help prove that it's the same problem, especially if you see "NSFNoteLSCompileExt" or "LSCompileNoteExt" anywhere in there.

i'll try to get the nsd when i'm back from a business trip on saturday and get back to you

I also see NSFNoteLSCompileExt and LSCompileNoteExt in the nsd
Thread 148 (Thread 0x7f02b3359640 (LWP 18829) "Thread-103"):
#0  0x00007f034cf4ce7d in select () from /lib64/libc.so.6
#1  0x00007f034d696c77 in FRDoSleep (secs=secs@entry=1, usecs=usecs@entry=0) at cleanup.c:944
#2  0x00007f034d69e425 in OSRunExternalScript (passed_script=passed_script@entry=0x7f02b33546e0 "\"/opt/hcl/domino/notes/latest/linux/nsd.sh\" -batch -crashpid 6592 -crashtid<PHONE_NUMBER>", flags=flags@entry=1) at cleanup.c:3908
#3  0x00007f034d6a12ef in OSFaultCleanupExt (action2take=action2take@entry=0, CleanupScriptExecFlag=CleanupScriptExecFlag@entry=4096, iniFileName=iniFileName@entry=0x0, szProcess=szProcess@entry=0x0, Length=Length@entry=0, CrashedPID=CrashedPID@entry=0x0) at cleanup.c:1494
#4  0x00007f034d6a1329 in OSFaultCleanup (action2take=action2take@entry=0, CleanupScriptExecFlag=CleanupScriptExecFlag@entry=4096, iniFileName=iniFileName@entry=0x0) at cleanup.c:1280
#5  0x00007f034d66b6cf in fatal_error (signl=11, info=<optimized out>, context=<optimized out>) at break.c:2202
#6  <signal handler called>
#7  LSsExprList::GetNumExprs (this=0x0, pMoreExprs=pMoreExprs@entry=0x7f02b335505e) at lsprsnod.cpp:398
#8  0x00007f034f4bf2cd in SIcParser::DoArray (this=this@entry=0x7f0292110270, iArraySymRel=iArraySymRel@entry=4036, arrSize=@0x7f02b33550e8: 0, bRedim=<optimized out>) at lsprsd2.cpp:1764
#9  0x00007f034f4bfdd6 in SIcParser::vardcl (this=this@entry=0x7f0292110270) at lsprsd2.cpp:312
#10 0x00007f034f4c5151 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292132ba0) at lsprss2.cpp:1787
#11 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292132be0) at lsprss2.cpp:1607
#12 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292132c20) at lsprss2.cpp:1607
#13 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f02921336e0) at lsprss2.cpp:1607
#14 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292133760) at lsprss2.cpp:1607
#15 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f02921337a0) at lsprss2.cpp:1607
#16 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f02921337e0) at lsprss2.cpp:1607
#17 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292133860) at lsprss2.cpp:1607
#18 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f02921338a0) at lsprss2.cpp:1607
#19 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292136ee0) at lsprss2.cpp:1607
#20 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292136f60) at lsprss2.cpp:1607
#21 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=0x7f0292110270, pnode=0x7f0292136fa0) at lsprss2.cpp:1607
#22 0x00007f034f4c4e65 in SIcParser::WalkSubTree (this=this@entry=0x7f0292110270, pnode=0x7f0292137060, pnode@entry=0x7f0292124560) at lsprss2.cpp:1607
#23 0x00007f034f4c51fc in SIcParser::_script (this=0x7f0292110270) at lsprss2.cpp:103
#24 0x00007f034f4b3540 in SIcParser::attach (this=this@entry=0x7f0292110270) at lsparse.cpp:1373
#25 0x00007f034f4b51d1 in SIcParser::Parse (this=this@entry=0x7f0292110270) at lsparse.cpp:1029
#26 0x00007f034f4b67f8 in SIcParser::doParse (this=this@entry=0x7f0292110270, hMod=hMod@entry=0x7f0319ebb5d0, pfGetc=pfGetc@entry=0x7f034f483aca <GetcFromMem(LShINSTANCE, LShMODULE, PLSMEMSOURCE)>, pfErr=pfErr@entry=0x7f034f48334a <ApiErrorProc(LShINSTANCE, LShMODULE, LSUSHORT, LSUSHORT, LSLINE, LSREGNAME, LSREGNAME)>) at lsparse.cpp:260
#27 0x00007f034f482c1f in LSsInstance::Compile (this=0x7f0291da5648, ModName=0x7f0291cead80, ModRefCon=0x7f0291aee768, pMemSource=0x7f02b3355c80, pModUseList=0x7f02b3355ca0, pGetcProc=0x7f034f483aca <GetcFromMem(LShINSTANCE, LShMODULE, PLSMEMSOURCE)>, pErrProc=0x7f034dd6d3e2 <LsCompileErrorCallback>, flags=133, retMod=0x7f0291aee780) at apimod.cpp:234
#28 0x00007f034f44597a in LSIModule::CompileScriptForSave(char*, unsigned int, short, unsigned short, unsigned char**) () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#29 0x00007f034f44d4f7 in CLSIDocument::CompileTheScript(unsigned int, unsigned int, unsigned int*, unsigned char*, unsigned short) () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#30 0x00007f034f44d6cb in CLSIDocument::CompileFormatField(char*, char*, char*, char*, unsigned int, unsigned int) () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#31 0x00007f034f450d4b in CLSIDocument::CompileTheNote(unsigned int, unsigned int, unsigned int) () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#32 0x00007f034f451ecc in LSCompileNoteExt () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#33 0x00007f034dd6d774 in NSFNoteLSCompileExt (hDB=248, hNote=49, dwFlags=0, pfnErrProc=0x7f01ab0a8507 <LsCompileErrorCallback(LSCOMPILE_ERR_INFO const*, void*)>, pCtx=0x7f0291ca80e0) at wrap4.c:220
#34 0x00007f01ab0a9886 in DxlNote::compileLotusScript() () from /opt/hcl/domino/notes/latest/linux/libdxli2.so
#35 0x00007f01ab0ad36c in DxlNote::processEpilogContent() () from /opt/hcl/domino/notes/latest/linux/libdxli2.so
#36 0x00007f01ab0a84e9 in DxlNote::process() () from /opt/hcl/domino/notes/latest/linux/libdxli2.so
#37 0x00007f01ab0977ec in DxlImporter::processDxl(XmlInputSource*, unsigned int) () from /opt/hcl/domino/notes/latest/linux/libdxli2.so
#38 0x00007f01ab0932f8 in DxliImpl::Process(XmlInputSource*, unsigned int, unsigned int*, char const*) () from /opt/hcl/domino/notes/latest/linux/libdxli2.so
#39 0x00007f034d6e7534 in DXLImport () from /opt/hcl/domino/notes/latest/linux/libnotes.so
#40 0x00007f01ab15fdc3 in Java_com_darwino_domino_napi_DominoAPIImpl_DXLImport () from /tmp/libdominonapi14039922458816362763.so

Excellent, thank you. And that one comes from a slightly-different path to the same end, since that happens during the DXL import. Presumably, that means it’d be reproducible using just the normal LotusScript or Java API, removing another layer of user code in the stack - always a plus when narrowing things down.

Is there something where I can help?

It’s in HCL’s hands for now - I opened a support ticket a few weeks ago and they’ve been looking at it since.

Domino 14.0FP3 is out, but is still broken 😔


Confirm file overwriting on upload / download showing differences between files

Is this a similar or duplicate feature request?

[x] I don't know. I will go check it.
[ ] No.

Is your feature request related to a problem? Please describe.
I work with a team developer where we could edit the same remote files, so the problem is when someone edits a file I'm working on and it overwrites the changes I've made, because he didn't do a file comparison before uploading it.
Describe the solution you'd like
My proposal is about adding functionality that is optional to show the comparison of the files before uploading or downloading and the user can confirm the operation according to the changes that will be applied to the destination file.
Describe alternatives you've considered
I don't have alternative
Does this project help you?

[x] Yes. SFTP IS AWESOME!
[ ] Yes. I want to support you.

Detecting changes automatically between local and remote is missing to this extension.  Is it possible one day ?
And a configuration to automatically download an open file from the local explorer would be a real advantage.
Every SFTP extension is missing something major like this.
If someone guide me, maybe I could try to do it ?

or at least a confirmation box before upload/download, because I accidentally click "download" instead of "upload" and that overrides my local file which is bad


Remove unnecessary mention of Box

Use Owned instead of Box when Owned's implementation details are not neccessary

bors r+


Add an example of "contribution" in use

https://github.com/palewire/moneyinpolitics.wtf/blob/main/_data/dictionary/contribution.yaml

Grabbing this issue to contribute to.


Update 01-functions.md with ES2015 function features [Ref #560]

Add information about annotating ES2015 default values and arrow functions (based on current behavior) to the Functions docs.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jrajav Thanks Jonathan!
@facebook-github-bot import

Thanks for importing. If you are an FB employee go to Phabricator to review.


Windows namespace issue.

As of now, in Windows, the user file name input prompt populates the path with backward slashes. Because of that, the plugin is unable to detect the composer file by using the findClosestComposerFile method. This method uses forward slash for checks.
This windows OS related bug can be resolved by replacing \ in the argument filePath with /.
With the existing bug, the plugin is only half useful. It is quite annoying to type in the namespace every time. Please check, merge and update on visual studio store.
Thank you.

Could you please merge it, if all checks have passed. I don't have write access.

fixes #7


[question] Release quality?

Can someone (perhaps @andreabertagnolli ) explain to me the reason behind this:
https://github.com/orika-mapper/orika/commit/7baf708de1be0c8e9b29f32664e90857fdc5a804
The message to this commit says: "Move methods from TypeFactory to MapperFacadeImpl, as private methods". This is a breaking change. What is the reason to have it? Is it really necessary??? What if people were using those public methods? 1.5 is not a major release and nothing was deprecated - you just make it private. How is this normal???? How can I change my code now in order to use have the same behaviour???

I'm sorry, I didn't know that there's so much legacy code, the tests was all green and no test used that methods.
Please can you tell an use case where you use that methods so the test suite can improve.

Well we were using it in the following way:
Type<P> targetType = TypeFactory.resolveTypeOf(result, TypeFactory.valueOf(itemType));

so now I had to copy the method in my own class:
Type<P> targetType = resolveTypeOf(result, TypeFactory.valueOf(itemType));

I just don't think removing a method is the right approach. If you were to provide an alternative (like with ClassUtil.isConcrete(type) now becomes type.isConcrete()) then I would be fine. But simply making a public method private, without documenting it, or providing an alternative method, or deprecating it - that's just way too much.

A side comment here: there is a lot still to be done on the documentation. The new jdk8 java-doc linter shows errors (outdated javadoc comments) we needed to make it this way so we can have some feedbacks (when beta0 was out there was no feedback on the quality).
Also it's really difficult to keep issues open indefinetely (makes a lot of noise) if there is no activity on the issue and no way to reproduce it then it's better to close it.
@ptahchiev Issues, pull requests or feedbacks are always welcomed :)

@ptahchiev I took a look at the whole documentation but I can't find that use case.
In my idea, if there's no documented use of some classes/methods, we can't consider them as part of the "public usage", their scope is limited to the internal need of the library, and I'm not sure they need the "deprecated" thing to change.
But this is my humble opinion ;)


Avoid autofilling by Password Manager

Could you please change input:type to search, to prevent password manager embedding widget-button on input field?
I have an issue with 1 Password widget, as long some password-field exists in the form, all inputs are covered by 1password-widgets. I tried to prevent it by changing type of input field to search, and it works to me.
Also it helps against widgets like "Fake data". An action "Fill entire form" by "Fake Data" breaks multiselect by putting some stuff into input, ignoring option list. I'm sure, native autofill-action by browsers would also break it.

I think lets have this as a new feature in V4, and focus the current version for major bug fixes


Support Optional Plugins

Plugins like https://github.com/alpancs/protoc-gen-pubsub-schema which are helpful but not necessary for the build, are essentially optional. Could we have an option to make a plugin optional?
I trialed this locally and it worked perfectly:
  public boolean generate(GenerationRequest request) throws ResolutionException, IOException {
    var protocPath = discoverProtocPath(request);

    var plugins = discoverPlugins(request);
    var importPaths = discoverImportPaths(request);
    var sourcePaths = discoverCompilableSources(request);

    if (sourcePaths.isEmpty()) {
      if (request.isFailOnMissingSources()) {
        log.error("No protobuf sources found. If this is unexpected, check your "
            + "configuration and try again.");
        return false;
      } else {
        log.warn("No protobuf sources found; nothing to do!");
        return true;
      }
    }

    if (request.isPluginOnly() && plugins.isEmpty()) {
      log.warn("No plugins found; nothing to do!");
      return true;
    }

It's currently using my <isPluginOnly> attribute to make it cleaner.

For my understanding, what sort of situations would this be needed in? In the example of the pubsub schema plugin, are you unable to resolve it locally?
I ask because if this is purely due to development vs CI access or configuration, a Maven profile might be more appropriate for enabling and disabling plugin functionality.
For example...
<profiles>
  <profile>
    <id>generate-pubsub-schemas</id>
    <build>
      <plugins>
        <plugin>
          <groupId>io.github.ascopes</groupId>
          <artifactId>protobuf-maven-plugin</artifactId>
          <version>${protobuf-maven-plugin.version}</version>
          <executions>
            <execution>
              <id>generate-pubsub-schema</id>
              <goals><goal>generate</goal></goals>
              <configuration>
                <binaryUrlPlugins>
                  <binaryUrlPlugin>
                    <url>http://...</url>
                  </binaryUrlPlugin>
                </binaryUrlPlugins>
              </configuration>
            </execution>
          </executions>
        </plugin>
      </plugins>
    </build>
  </profile>
</profiles>

If this doesn't address your use case then I'll be happy to look into adding this but I might need a few more details on exactly why it is needed.
My main concern is ignoring missing plugins may affect build reproducibility (e.g. if you expect it to work in CI but it silently doesn't run, then you may get malformed deployments of your project).

@ascopes great points. At first a profile (inherited from a parent pom) wasn't working for me. I just went back to it after reading you message and it is indeed working now. I think a profile is definitely the right approach. Closing this up, thanks!

After some fiddling, I remembered why I moved away from a profile. Let's say I want to run just the plugin, with that particular profile.
When I try something like this:
mvn protobuf:generate -P my-extra-setup

It's not running the executions behind the profile, it's only running the non-profiled (default java generation) part.
When I run this:
mvn compile -P ardi-generate

It works. I hit that issue, and hacked in a "ignore plugin if not found" to get around this. Any idea why?

After some fiddling, I remembered why I moved away from a profile. Let's say I want to run just the plugin, with that particular profile.
When I try something like this:
mvn protobuf:generate -P my-extra-setup

It's not running the executions behind the profile, it's only running the non-profiled (default java generation) part.
When I run this:
mvn compile -P ardi-generate

It works. I hit that issue, and hacked in a "ignore plugin if not found" to get around this. Any idea why?

After some fiddling, I remembered why I moved away from a profile. Let's say I want to run just the plugin, with that particular profile.
When I try something like this:
mvn protobuf:generate -P my-extra-setup

It's not running the executions behind the profile, it's only running the non-profiled (default java generation) part.
When I run this:
mvn compile -P my-extra-setup

It works. I hit that issue, and hacked in a "ignore plugin if not found" to get around this. Any idea why?

ahh, have you tried adding a phase on the profile execution?

@ascopes I dug into this, and I believe that when executing a plugin goal directly, it won't actually invoke a profile:

That was a diff of the two commands above run with -X. With that being said, the idea of an optional plugin starts to become more necessary. I can simply run mvn protobuf:generate -P my-extra-setup locally when needed, and my CI environment won't fail due to extra binaries that aren't available. What do you think?

Yeah, sounds good to me. I was thinking about adding an attribute to each plugin block with the v2 changes to allow  opting specific plugins in and out... would that be something of interest to you to work on?

Yeah sure, i'll make a PR for it. Any preference on naming?

probably skipIfMissing, which just defaults to false.
It might actually just be worth applying it to the URL and Path plugin interfaces.
You might need to do a bit of internal plumbing to get it to work nicely though.
If at all possible it'd be cool to throw together an integration test for this as well as the unit tests are not in the best shape at the moment (unless you fancy a go at that).
Thanks :-)

How's this @ascopes ? https://github.com/ascopes/protobuf-maven-plugin/pull/183

How's this @ascopes ? https://github.com/ascopes/protobuf-maven-plugin/pull/183
I have to context switch to some other tasks, but feel free to take it to the finish line if there's anything you don't like?

Cool, I can pick it up if you want me to, it might need to wait until the weekend when I am not working though so I can review it properly.

No worries, same boat here, just added what I could to your latest comments. Appreciate it!

Released 2.0.0-alpha2 with this on it. Should be up on Maven Central for use.

Thanks @ascopes !

Released under v2.0.0 as stable!


Bitcoin syncer

Still a work in progress.
Dependent on https://github.com/farcaster-project/farcaster-core/pull/44.
Doesn't compile at the time of PR due to the lack of some Event definitions.

Superseded by #43


Unable to transcode mkv to mp4 on Debian Jessie

Q
A

Bug?
yes

New Feature?
no

Version Used
0.6.1

FFmpeg Version
avconv version 11.7-6:11.7-1~deb8u1

OS
Debian 8.0.4 Jessie: Linux storage 3.16.0-4-amd64 1 SMP Debian 3.16.7-ckt25-2+deb8u3 (2016-07-02) x86_64 GNU/Linux

PHP-Version
PHP 7.0.8-1~dotdeb+8.1 (cli) ( NTS )

Actual Behavior
PHP-FFMpeg is sending me a PHP Fatal Error.
PHP Fatal error:  Uncaught Alchemy\BinaryDriver\Exception\ExecutionFailureException: ffmpeg failed to execute command '/usr/bin/avconv' '-y' '-i' '/media/disk/git/video-encoding/videos/test.mkv' '-vcodec' 'libx264' '-acodec' 'libfaac' '-b:v' '1000k' '-refs' '6' '-coder' '1' '-sc_threshold' '40' '-flags' '+loop' '-me_range' '16' '-subq' '7' '-i_qfactor' '0.71' '-qcomp' '0.6' '-qdiff' '4' '-trellis' '1' '-b:a' '128k' '-pass' '1' '-passlogfile' '/tmp/ffmpeg-passes579341d3262b8kkw4s/pass-579341d32643e' '/media/disk/git/video-encoding/test-X264.mp4' in /media/disk/git/video-encoding/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/ProcessRunner.php:100
Stack trace:
#0 /media/disk/git/video-encoding/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/ProcessRunner.php(72): Alchemy\BinaryDriver\ProcessRunner->doExecutionFailure(''/usr/bin/avcon...')
#1 /media/disk/git/video-encoding/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/AbstractBinary.php(209): Alchemy\BinaryDriver\ProcessRunner->run(Object( in /media/disk/git/video-encoding/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Media/Video.php on line 168

As I'm executing the command PHP-FFMpeg ran on the console I see that avconv is complaining about the audio-encoder libfaac.
avconv version 11.7-6:11.7-1~deb8u1, Copyright (c) 2000-2016 the Libav developers
  built on Jun 12 2016 21:51:35 with gcc 4.9.2 (Debian 4.9.2-10)
Input #0, matroska,webm, from '/media/disk/git/video-encoding/videos/test.mkv':
  Metadata:
    title           : Test
  Duration: 01:45:28.41, start: 0.000000, bitrate: N/A
    Chapter #0.0: start 0.000000, end 340.833000
    Metadata:
      title           : 00:00:00.000
    Chapter #0.1: start 340.833000, end 668.292000
    Metadata:
      title           : 00:05:40.833
    Chapter #0.2: start 668.292000, end 1032.917000
    Metadata:
      title           : 00:11:08.292
    Chapter #0.3: start 1032.917000, end 1354.958000
    Metadata:
      title           : 00:17:12.917
    Chapter #0.4: start 1354.958000, end 1688.792000
    Metadata:
      title           : 00:22:34.958
    Chapter #0.5: start 1688.792000, end 2050.625000
    Metadata:
      title           : 00:28:08.792
    Chapter #0.6: start 2050.625000, end 2318.333000
    Metadata:
      title           : 00:34:10.625
    Chapter #0.7: start 2318.333000, end 2693.333000
    Metadata:
      title           : 00:38:38.333
    Chapter #0.8: start 2693.333000, end 3001.583000
    Metadata:
      title           : 00:44:53.333
    Chapter #0.9: start 3001.583000, end 3366.125000
    Metadata:
      title           : 00:50:01.583
    Chapter #0.10: start 3366.125000, end 3669.292000
    Metadata:
      title           : 00:56:06.125
    Chapter #0.11: start 3669.292000, end 3989.250000
    Metadata:
      title           : 01:01:09.292
    Chapter #0.12: start 3989.250000, end 4294.542000
    Metadata:
      title           : 01:06:29.250
    Chapter #0.13: start 4294.542000, end 4621.167000
    Metadata:
      title           : 01:11:34.542
    Chapter #0.14: start 4621.167000, end 4957.375000
    Metadata:
      title           : 01:17:01.167
    Chapter #0.15: start 4957.375000, end 5262.750000
    Metadata:
      title           : 01:22:37.375
    Chapter #0.16: start 5262.750000, end 5578.417000
    Metadata:
      title           : 01:27:42.750
    Chapter #0.17: start 5578.417000, end 5871.458000
    Metadata:
      title           : 01:32:58.417
    Chapter #0.18: start 5871.458000, end 6027.542000
    Metadata:
      title           : 01:37:51.458
    Chapter #0.19: start 6027.542000, end 6328.417000
    Metadata:
      title           : 01:40:27.542
    Stream #0.0(eng): Video: h264 (High), yuv420p, 720x390 [PAR 1:1 DAR 24:13], 24 fps, 1k tbn, 48 tbc (default)
    Stream #0.1(ger): Audio: ac3, 48000 Hz, 5.1, fltp, 384 kb/s (default)
Unknown encoder 'libfaac'

I also ran that command with ajusted parameters ('aac' instead of 'libfaac') and got the following:
Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height

Here is my execution log created with monolog:
[2016-07-23 10:07:14] Execution.INFO: ffprobe running command '/usr/bin/avprobe' '-help' '-loglevel' 'quiet' [] []
[2016-07-23 10:07:14] Execution.INFO: ffprobe executed command successfully [] []
[2016-07-23 10:07:14] Execution.INFO: ffprobe running command '/usr/bin/avprobe' '/media/disk/git/video-encoding/videos/test.mkv' '-show_streams' '-of' 'json' [] []
[2016-07-23 10:07:15] Execution.INFO: ffprobe executed command successfully [] []
[2016-07-23 10:07:15] Execution.INFO: ffmpeg running command '/usr/bin/avconv' '-y' '-i' '/media/disk/git/video-encoding/videos/test.mkv' '-vcodec' 'libx264' '-acodec' 'libfaac' '-b:v' '1000k' '-refs' '6' '-coder' '1' '-sc_threshold' '40' '-flags' '+loop' '-me_range' '16' '-subq' '7' '-i_qfactor' '0.71' '-qcomp' '0.6' '-qdiff' '4' '-trellis' '1' '-b:a' '128k' '-pass' '1' '-passlogfile' '/tmp/ffmpeg-passes579341d3262b8kkw4s/pass-579341d32643e' '/media/disk/git/video-encoding/test-X264.mp4' [] []
[2016-07-23 10:07:15] Execution.INFO: ffprobe running command '/usr/bin/avprobe' '/media/disk/git/video-encoding/videos/test.mkv' '-show_format' '-of' 'json' [] []
[2016-07-23 10:07:15] Execution.INFO: ffprobe executed command successfully [] []
[2016-07-23 10:07:15] Execution.ERROR: ffmpeg failed to execute command '/usr/bin/avconv' '-y' '-i' '/media/disk/git/video-encoding/videos/test.mkv' '-vcodec' 'libx264' '-acodec' 'libfaac' '-b:v' '1000k' '-refs' '6' '-coder' '1' '-sc_threshold' '40' '-flags' '+loop' '-me_range' '16' '-subq' '7' '-i_qfactor' '0.71' '-qcomp' '0.6' '-qdiff' '4' '-trellis' '1' '-b:a' '128k' '-pass' '1' '-passlogfile' '/tmp/ffmpeg-passes579341d3262b8kkw4s/pass-579341d32643e' '/media/disk/git/video-encoding/test-X264.mp4' [] []

Expected Behavior
Save my file to desired location encoded with the expected codec (H.264) in .mp4 format.
Steps to Reproduce
Transcode mkv video to .mp4 (H.264) with PHP-FFMpeg on my platform:
$this->video->save(new \FFMpeg\Format\Video\X264(), $path);

Possible Solutions
At this time now I kind of think, that PHP-FFMpeg got this "libfaac" from some kind of previous command with avprobe. If not: might some deprecated relation between AAC-codec and libfaac.

Same problem here, also cannot create frame images. Just can convert to webm. x264 lib is installed.
System: Debian Jessie arm64

Problem was solved by installing newer libraries from multimedia rep. About the frame images bug I've created a new issue:
https://github.com/PHP-FFMpeg/PHP-FFMpeg/issues/235

@Ninos What did you do to get this to work? I now fully recompiled FFMpeg v 3.2.1 from source on my machine with following options:
./configure --enable-gpl --enable-postproc --enable-swscale --enable-avfilter --enable-libmp3lame --enable-libvorbis --enable-libtheora --enable-libx264 --enable-libx265 --enable-libspeex --enable-shared --enable-pthreads --enable-libopenjpeg --enable-nonfree

Though --enable-libfaac ins not available with this FFMpeg version anymore.
Before that I installed all libraries:
apt install libmp3lame-dev libvorbis-dev libtheora-dev libspeex-dev yasm pkg-config libfaac-dev libopenjpeg-dev libx264-dev libx265-dev

And it still does not work!
What could I try next?

I now fixed this.
I followed #137 and changed the constructor for /src/FFMpeg/Format/Video/X264.php
I updated /src/FFMpeg/Format/Video/X264.php to:
22: -    public function __construct($audioCodec = 'libfaac', $videoCodec = 'libx264')
22: +    public function __construct($audioCodec = 'aac', $videoCodec = 'libx264')
54: -         return array('libvo_aacenc', 'libfaac', 'libmp3lame', 'libfdk_aac');
54: +        return array('libvo_aacenc', 'libfaac', 'libmp3lame', 'libfdk_aac', 'aac');

I may now file a Pull Request for that.

I just installed latest packages on my debian jessie machine to get my problem fixed. Thx for the changes. Is it possible to create a PR for that? :)

Maybe. But I also found a already existing PR. Look here for my changes: jankal/PHP-FFMpeg and this PR #222 should already start to fix this.

@Ninos which ffmpeg version do you use?

I'm using following version:
ffmpeg version 3.1.1 Copyright (c) 2000-2016 the FFmpeg developers
  built with gcc 4.9.2 (Debian 4.9.2-10)
  configuration: --enable-gpl --enable-postproc --enable-swscale --enable-avfilter --enable-libmp3lame --enable-libvorbis --enable-libtheora --enable-libx264 --enable-libspeex --enable-shared --enable-pthreads --enable-libopenjpeg --enable-libfaac --enable-nonfree
  libavutil      55. 28.100 / 55. 28.100
  libavcodec     57. 48.101 / 57. 48.101
  libavformat    57. 41.100 / 57. 41.100
  libavdevice    57.  0.101 / 57.  0.101
  libavfilter     6. 47.100 /  6. 47.100
  libswscale      4.  1.100 /  4.  1.100
  libswresample   2.  1.100 /  2.  1.100
  libpostproc    54.  0.100 / 54.  0.100

Okay. Then you are not affected. Should be starting at like FFMPeg 3.2 to get that problem. Libav is affacted too, as I see now.


721 property added for rel to allow

Description

Updates to the following uui components to add the option for a rel property to allow it to be set by the component rather than just relying on the target="_blank"
uui-button
uui-button-inline - not sure if this is being maintained as the stories and test don't map 100% to the compoment
uui-card
uui-card-block-type
uui-card-content-node
uui-card-media
uui-card-user
uui-menu-item
uui-ref-node
uui-tabs
To ensure it doesn't effect existing links with a target _blank I have left the original logic in to set it to what was previously there but allow it to be overidden by rel prop.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Proposed fix for issue https://github.com/umbraco/Umbraco.UI/issues/721
Gived the ability to define the rel on a link
Picked this up as my first contribution to Umbraco
How to test?
Within the following components there is a new prop for rel if you set the rel the value will be set on the anchor tag.
uui-button
uui-button-inline - not sure if this is being maintained as the stories and test don't map 100% to the compoment
uui-card
uui-card-block-type
uui-card-content-node
uui-card-media
uui-card-user
uui-menu-item
uui-ref-node
uui-tabs
Screenshots (if appropriate)

Checklist

[ ] If my change requires a change to the documentation, I have updated the documentation in this pull request.
[x ] I have read the CONTRIBUTING document.
[x ] I have added tests to cover my changes.

There where a few errors when running test that where from original code should I try and fix those or do want a different issue raised for that?
Sonar Cloud scan seems to be new but do you want me to update anything to fix these errors?


dart2js: unnecessary return statement in setter

This setter 'returns' the value of the assignment:
   set data(Data value) => _data = value;

The generated code literally does the same:
   set$data: function(value) {
      this._data = value;
      return value;
    }

AFAIK setters can never be called in a manner that gives access to the returned value, so the return statement is useless.
@munificent I have always wanted tear-offs for setters which would expose the returned value, but they could be defined to be void and always return null. What is the language direction here?
@kmillikin Should Kernel convert the => to a statement for us, or is this observable on the VM, e.g. via mirrors? (It is simple enough for dart2js to deal with it.)
@johnniwinther It is an interesting global property of a function that the return value is never used because we can disconnect the return from the value expression and let dead code elimination nibble away the effect- and exception-free part of the expression and its dependencies.

AFAIK setters can never be called in a manner that gives access to the returned value, so the return statement is useless.

You're correct. I think in the context of a setter, a => member body should be treated like it doesn't have a return when you generate JS.

What is the language direction here?

I don't think there's been any discussion about changing this.

The current language specification says that the return type of setters is void. It's the only type you can write, and if you don't write any type, it's still void.
Any attempt to make such a void value useful is going to be resisted (so no, tearing off a setter will not give you access to the return value, that would invalidate a lot of existing code that uses => knowing that the result is unreachable.
The returned value is not accessible now, and I'd vote a definite no to getting access to the returned value in the future too.
Even dart:mirrors seem to hide the return value of setters, you can only invoke them through setField.
With that in mind, it seems like a safe optimization to ignore the return. I'd be perfectly happy if the CFE does that for you.
(I still hope to eventually make all void foo() => e; functions return null instead of the value of e, since I didn't succeed in making the syntax invalid).

@lrhn Thanks for the clarifications.

Fixed in dart2js via 711dd8e82e022bb57a40d6473444b1696eb0e991


Modules are not installed

I created a virtual environment and pip installed all the requirements. When I run the file, it tells me that the lag chain module is not installed. Where is the error here?

The issue hasn't been resolved.


Fix command ID, fix install of the extension only once

This request contains changes for internal use only. I will create the separated request later.

@AndrewAdov I noticed during testing today that the default Xunit behavior is one test collection for each test class, and this behavior resulted in the test framework restarting Visual Studio between the tests in each class. I was able to get the tests to share an instance by adding the following:
[assembly: CollectionBehavior(CollectionBehavior.CollectionPerAssembly, DisableTestParallelization = true)]

@AndrewAdov I noticed during testing today that the default Xunit behavior is one test collection for each test class, and this behavior resulted in the test framework restarting Visual Studio between the tests in each class. I was able to get the tests to share an instance by adding the following:
[assembly: CollectionBehavior(CollectionBehavior.CollectionPerAssembly, DisableTestParallelization = true)]

Sure. I'm pretty sure the extension shouldn't be reinstalled every time the visual studio is restarted.

Agreed, but haven't made it to that part yet. The CollectionBehavior change makes it less critical that the restart behavior be fixed though.


Validate container status in volume mount tests

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We fixed an issue in CRI-O returning an invalid container status on different mount propagations: https://github.com/cri-o/cri-o/pull/5981
To avoid such failures everywhere, we now also validate the container status in critest.
Which issue(s) this PR fixes:

Refers to https://github.com/cri-o/cri-o/pull/5981
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Verify container status on all three "Container Mount Propagation" critest cases.

Ready for review :+1:


M1 arm64 issues I guess ?

Hey I just downloaded the demo because I wanted to figure out how I can use your WebRTC implementation, but when I try to build the app I get this tracelog:
It occurs at: Link WebRTC-Demo (arm64)
ld: warning: ignoring file /Users/lucasgoldner/Library/Developer/Xcode/DerivedData/WebRTC-Demo-bdqvxahvrhxqczexgpdlclbijqxh/Build/Products/Debug-iphonesimulator/WebRTC.framework/WebRTC, missing required architecture arm64 in file /Users/lucasgoldner/Library/Developer/Xcode/DerivedData/WebRTC-Demo-bdqvxahvrhxqczexgpdlclbijqxh/Build/Products/Debug-iphonesimulator/WebRTC.framework/WebRTC (1 slices)
ld: warning: all bitcode will be dropped because '/Users/lucasgoldner/Library/Developer/Xcode/DerivedData/WebRTC-Demo-bdqvxahvrhxqczexgpdlclbijqxh/Build/Products/Debug-iphonesimulator/Starscream.o' was built without bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target.
Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_RTCDefaultVideoEncoderFactory", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCPeerConnectionFactory", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCVideoTrack", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCAudioTrack", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCRtpTransceiver", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCDataBuffer", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCConfiguration", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCIceCandidate", referenced from:
      objc-class-ref in IceCandidate.o
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCIceServer", referenced from:
      objc-class-ref in WebRTCClient.o
  "_RTCInitializeSSL", referenced from:
      closure #1 () -> __C.RTCPeerConnectionFactory in variable initialization expression of static WebRTC_Demo.WebRTCClient.(factory in _08FB3D1CC6B5042F2650C4103C361173) : __C.RTCPeerConnectionFactory in WebRTCClient.o
  "_OBJC_CLASS_$_RTCDataChannelConfiguration", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCAudioSession", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCCameraVideoCapturer", referenced from:
      objc-class-ref in WebRTCClient.o
  "_kRTCMediaConstraintsOfferToReceiveAudio", referenced from:
      variable initialization expression of WebRTC_Demo.WebRTCClient.(mediaConstrains in _08FB3D1CC6B5042F2650C4103C361173) : [Swift.String : Swift.String] in WebRTCClient.o
      WebRTC_Demo.WebRTCClient.init() -> WebRTC_Demo.WebRTCClient in WebRTCClient.o
      WebRTC_Demo.WebRTCClient.init(iceServers: [Swift.String]) -> WebRTC_Demo.WebRTCClient in WebRTCClient.o
  "_kRTCMediaConstraintsValueTrue", referenced from:
      variable initialization expression of WebRTC_Demo.WebRTCClient.(mediaConstrains in _08FB3D1CC6B5042F2650C4103C361173) : [Swift.String : Swift.String] in WebRTCClient.o
      WebRTC_Demo.WebRTCClient.init() -> WebRTC_Demo.WebRTCClient in WebRTCClient.o
      WebRTC_Demo.WebRTCClient.init(iceServers: [Swift.String]) -> WebRTC_Demo.WebRTCClient in WebRTCClient.o
  "_OBJC_CLASS_$_RTCSessionDescription", referenced from:
      objc-class-ref in SessionDescription.o
  "_kRTCMediaConstraintsOfferToReceiveVideo", referenced from:
      variable initialization expression of WebRTC_Demo.WebRTCClient.(mediaConstrains in _08FB3D1CC6B5042F2650C4103C361173) : [Swift.String : Swift.String] in WebRTCClient.o
      WebRTC_Demo.WebRTCClient.init() -> WebRTC_Demo.WebRTCClient in WebRTCClient.o
      WebRTC_Demo.WebRTCClient.init(iceServers: [Swift.String]) -> WebRTC_Demo.WebRTCClient in WebRTCClient.o
  "_OBJC_CLASS_$_RTCMediaConstraints", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCDefaultVideoDecoderFactory", referenced from:
      objc-class-ref in WebRTCClient.o
  "_OBJC_CLASS_$_RTCMTLVideoView", referenced from:
      objc-class-ref in VideoViewController.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Hey, thanks for reporting the issue. Unfortunately I don't have access to Apple Silicon mac at the moment so I can't test it myself. I would be awesome if you could check those things for me:

Is the demo project running well on a device?
Can you maybe link the xcframework manually and try again? Just to make sure it is not Swift Package Manager issue

Also, if anyone else is having the issue, feel free to comment here.

I tried running it with the xcframework but nothing changed... Cannot test it on real device

Also, if anyone else is having the issue, feel free to comment here.

Hi Stasel,
The current version of your Project is working fine, Great job. Thank you so much!

I am on an M1 Mac mini, iPhone12 and Current version of the iPad all with current iOS and OS X.
I downloaded the entire project zip, unzipped and opened the .xcworkspace.
Allowed all the Swift Packages to download automagically.
Changed to my Apple Developer ID in both the General, and Build Settings tabs.
Locally launched the node server by ‘node app.js’ then changed the server name in the config.swift file to my local machines IP address from local etc.
I did have to close and relaunch Xcode a few times, to get everything settled.
I did get one xcode notice that I've attached as a screen shot...
Otherwise ... with my ipad and iphone connected directly into the Mac Mini M1 all is working.
I tested on Wifi and Verizon Wireless.  All working.. after a bit of this and that with xcode.
Great job thank you

Also, if anyone else is having the issue, feel free to comment here.
My only one comment is that if you don't follow the "Run instructions" from the README, and tap the buttons out of order... one device will get a black screen, but be broadcasting the image.

Thanks @pdxbenjamin for confirming it works on M1 macs. That warning in the screenshot is because I removed support for 32 bit devices in the project settings and it seems that Xcode doesn't like it. I changed it back to normal architectures to avoid this warning message.
@lucas-goldner Are you still experiencing issues with linking or can we close this issue?


permit increasing print size via resolution

pass resolution option to sim or analyze to get larger plots.

also made margins a little bigger in dsPlot since often cut off.


[BUG] Settings aren't saving at all.

Module Version:
v3.2.0
Describe the bug
Setting won't save. I change anything, press save, reopen, and the defaults are there.
To Reproduce
Attempt to change any setting
Foundry Version:
0.8.9
Game System:
PF1E 0.79.7

Confirmed, the settings are not saving or changing the behavior.
Like:

Chat is always being triggered.
Rider is always aligned to the top left, etc.

Even though some times when you hit save it changes the checkbox, that does not interfere with the in-game module behavior.

Sorry for the trouble i made a patch , try out 3.2.1 and let me know


Android Crashes on Seed Restore

Need change BCC to BCH, because BCC is used by BitConnect Coin.
I install electron android wallet 2.9.3. When I probe to recover wallet by seed i have crash and wallet closing. I use phone with Android 5.1.1. On Windows 10 recover by seed work perfect.

Confirmed! Electron Cash crashes on Android when trying to restore from seed (I already have a seed). It crashes on both Nexus 5 (Android 6.0.1) and Google Pixel XL (Android 7.1.2)

now experiencing this problem too...  crashes when trying to restore from seed (I already have a seed)...  in addition to previous network 16 error

i was able to recreate this on my new phone.  give me some time to look into it.  i have to root the phone in order to set up logcat

found the problem.  i will fix it tonight.  i believe i broke it in the last release with the new coin type.  new parameters arent passed to the on_restore_seed from the android seed restore.

This is now fixed and uploaded on electroncash.org as <IP_ADDRESS>.apk.
The fix is commit
e8116831d3dedaa7edab47981297ef304f32821f
<IP_ADDRESS> also includes an additional fix for android
viewing of tx detail in commit  a312ca7af2e3cda652b313245c67cd1f69073b9c

Hi, now restore from seed work perfect. Thanks.


test: verify multiplatform cleanup

This is needed for STONEBLD-1779 to verify we are not leaving credentials on the remote host
Description
Verifies that after a multi platform build the cleanup is successful.
Issue ticket number and link
https://issues.redhat.com/browse/STONEBLD-1779

/retest

/lgtm

/retest

Another failure in an unrelated test suite

/retest

/retest


Fix unexpected ADC behavior due to uninitialized data being sent over SPI

Zero-initialize the buffer used for ADC reads, as the buffer is always written over the wire as part of the SPI transaction. In unlucky circumstances the uninitialized buffer would encode a valid command, resetting the device or triggering other undesired behavior.
Note that uint8_t buffer[s] = {0}; won't work due to the variable-length of the array.

I've put this up against the develop branch, but I'm happy to retarget or duplicate it against main if desired.
The conditions for this to cause an issue seem to be fairly application and device specific; I've reliably hit it with an STM32H7 in one application, but never hit it with an STM32L0 in another. It's UB regardless, so it'd be nice to see it fixed.

thank you for contributing.
never have seen this issue, but totally agree to fix it.


Cannot see when a user has changed nickname on discord

No event appears to be raised that allows one to see if someone changes nickname on the discord server

discord.js has this function. https://discord.js.org/#/docs/main/stable/class/Client?scrollTo=e-guildMemberUpdate


feat: make it possible to supply an existing photo, and add a callback when a new photo is taken

Looks good to me, and now travis is happy as well. +1


Remove NHS dataset

We've taken down the NHS Data Explorer this week. This PR removes it from the https://app.terra.bio/#library/datasets page.
Tested by running locally and visiting the page.

Thanks @pantheos! Can someone on your team merge for me (I don't have write access). And I believe the CircleCI tests fail because this is from a fork.


rename maxClassNameLen to LongClassNameCheck

how about renaming maxClassNameLen maven plugin parameter to LongClassNameCheck?
I have idea of printing the name of the check that was failed:
blah blah blah... (LongClassNameCheck)

@l3r8yJ what do you think?

@h1alexbel thank you for reporting this. I'll assign someone to take care of it soon.

@l3r8yJ this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2024-01-13T07:10:04.380653.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@h1alexbel LongClassNameCheck contains check and i'm not sure that we need to assign some value to check

@l3r8yJ yeah, that's a reasonable point

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Problem in internal function call.

I met a SIGSEGV when running the code below.
When remove call (->cilk_println_i32), the code terminates normally.
Do you figure any reason out about this?
Any problems about save/restore physical registers around the func call?
use cilk::{
    exec::{jit::x64::compiler},
    *,
};

pub fn sample() {
    let mut m = module::Module::new("cilk");

    // Internal function must be defined when you use it
    let cilk_println_i32 = m.add_function(ir::function::Function::new(
        "cilk.println.i32",
        ir::types::Type::Void,
        vec![ir::types::Type::Int32],
    ));

    let main = cilk_ir!(m; define [void] main () {
        entry:
            i = alloca i32;
            store (i32 10), (%i);
            li = load (%i);
            __ = call (->cilk_println_i32) [(%li)];    // If remove this line, this code works.
            ret (void);
    });

    let mut jit = compiler::JITCompiler::new(&m);
    jit.compile_module();
    jit.run(main, vec![]);
}

error: process didn't exit successfully: `~/Documents/GitHub/cilk/target/debug/deps/sample-9b41210e16725396 --nocapture sample` (signal: 11, SIGSEGV: invalid memory reference)

I got no error, when using libc::printf() instead of println!() in fn cilk_println_i32().
But jit_prime.rs in tests directory works with println!().
What's going on...

No SEGV occurs when saving and restoring rax around cilk_println_i32() func call.
But... still seems to be something wrong.

I tried it and the test jit_prime failed

(because of 16byte alignment?)

I found the solution :)

Fixed the bug. I'll make a commit asap.

I checked it out.
It works completely!