Kinematic move() and move_and_slide() slows down randomly with multiple objects

Operating system or device - Godot version:
Windows 7 (also tested on Ubuntu)
Issue description (what happened, and what was expected):
Multiple kinematic bodies using move_and_slide() cause random slow downs, it seems to happen less if the collision shapes are circles, and is the worst when using a capsule shape.
Originally Juan pointed out that if the velocity returned from using move() wasn't used with slide() or capped manually then the values might increase (like the Y value with gravity) and eventually cause slow down when the values become too large. However, in the example linked below, I'm using move_and_slide() and I'm also manually clamping the velocity values, and this problem still persists.
The problem happens more frequently with more objects, but I've had it happen in my own game project with as little as 5-6 objects, and it will drag the framerate down to single digits when it happens.
If there's enough objects, like in the example, once the problem occurs it doesn't seem to go away. If you have fewer objects (say less than 20), then the problem takes longer to appear but also goes away after a few seconds, as seen in the graph below.
Here's what the profile graph looks like:

and as you can see, when the usage spikes the fixed process count goes from 33 to 264 (when I had 33 objects)

Steps to reproduce:
Download the example linked below, run the profiler and then run the scene. The more objects there are, the quicker the problem appears. The example has about 26 objects, so it should happen within a few seconds of starting the scene.
Link to minimal example project (optional but very welcome):
slow_kinematic.zip
https://dl.dropboxusercontent.com/u/3292249/slow_kinematic.zip

Reducing the max_bounces to 1 solves the fps problem in the example, if I double the numbers of nodes, the problem appears again.
Tried forcing velocity x = 0 on the script (with double amount) and slowly drops to < 30fps.

Where is the max_bounces setting? I can't seem to find it on any of the nodes or in the project settings

@sketchyfun is the 4th parameter:
move_and_slide(linear_velocity, floor_direction=Vector2(0,0), slope_stop_min_velocity=5,max_bounces=4)
Controls a loop, I guess is a form of precision control for the slide.

Ah thanks, that at least lets me carrying on working without slow down in the mean time!

I've fixed this issue with the help of eon-s.
What I did was edit physics_body_2d.cpp so that it uses a bool to check if "body_test_motion()" needs to be done.
In that file, if put
//Bool to say if the body_test_motion has already been done.
bool body_test_motion_DONE = false;

at the top of the file, on line 32, after the includes.
Then, I replaced
colliding = Physics2DServer::get_singleton()->body_test_motion(get_rid(),gt,p_motion,margin,&result);

on line 1066, or around there, with
	//Only do body_test_motion on the first call of this function.
	if(body_test_motion_DONE == false)
	{
		colliding = Physics2DServer::get_singleton()->body_test_motion(get_rid(),gt,p_motion,margin,&result);
		body_test_motion_DONE = true;
	}

in the "Vector2 KinematicBody2D::move(const Vector2& p_motion)" function.
Then, I put
	//Reset the motion test so it can be done next time.
	body_test_motion_DONE = false;

on around line 1328, which is after the while loop, "while(p_max_bounces)", so that it will reset the bool so the next call to "move_and_slide" it can be called.
Here is the file itself:
physics_body_2d_cpp.txt

But now that I've tested it some more, there is some slow down after adding more objects, but it's not the same problem. It seems to be "_fixed_process" that is being slowish (only 0.014 seconds), but it's getting 74 calls.
Anyway, here is the minimal project file:
slow_kinematic_update_01.zip
This will run at 60 FPS on my machine. But, if I add 2 or 3 more kinematic objects, it will go down to 7.5 FPS. And remember that this is with a build with the additions in my previous post.

@leiget now with that fix in this demo, it stays around 900 fps with CircleShape2D, which is pretty insane :D , and 1/3-1/2 that value with rectangle.
I was going to blame the capsule but dies at 1fps with CollisionPolygon, the problem may go up to the server and the way it manages the shapes.

@eon-s What are your PC specs? I have a AMD 860K and a 960 GTX and I get ~3500 FPS with a capsule shape collision.

I've encountered a problem. On platformers which use move_and_slide(), when you are walking on the ground, the character moves slowly, but when you jump the character moves at the speed that he is supposed to.

@leiget I have noticed the jump thing too, in the other issue (not in the demo), and that move_and_slide uses the full velocity vector (then I thought I was doing something wrong).

After realizing that collision margin pushes a bit the bodies, tested the project (with no fixes on move_and_slide) with minimum collision margin and got an average of 300fps on the monitor (with the label showing over 1000).
The script on this project example has a lot of small movements for all the bodies, maybe the margin is creating a bottleneck on the physics server.

the algorithm has been considerably optimized in 3.0, so any testing would be appreciated

Still the same, here is a version of the examples exported to 3 with 2.1.4b2
slowkinematic3.zip

I ran some callgrind on it. The main reasons why this is slow are:

First and foremost, KinematicBody motion is a LOT more complex than a RigidBody, they are not supposed to be fast, specially when you have tons of them collising against lots of things
Demo uses ConvexPolygon+Capsule. This is a pretty complex collision resolution
That said, the SAT code needs to be changed eventually in 3.1 for simplified version
But the main reason for the slowness is that 2D math in Godot is not inlined.. this should be done at some point, but is always kicked back. If anyone wants to volunteer, feel welcome.

I'll remove the bug tag and replace by enhancement. Will kick for 3.1

I am seeing something similar in 3.3. but in 3D.

@Zireael07 Do you have a minimal reproduction project?

@Zireael07 this issue was for 2D which is a very different engine than the (two) used for 3D, and I'm not sure if this already solved or not, it may be better to open a new one and show results with Godot and Bullet physics.

Tested this issue with 3.3 using move_and_collide and move_and_slide and I have not experienced any slowdown using CircleShape2D, CapsuleShape2D and irregular CollisionPolygon2D in solid mode.

I can't reproduce the issue on any 3.x release either with the MRP from https://github.com/godotengine/godot/issues/6507#issuecomment-320446220 (after fixing scripts with s/_fixed_process/_physics_process/g).
So closing, please open a new issue with an up to date MRP for 3.3+ if you still reproduce a similar issue.


added feedback form

added html, CSS and jquery

@ACLM can you deploy your changes to bluemix so that we can test them with a live version ?

http://tone-analyzer-nodejs-aclm.mybluemix.net/

These changes are also available in public version now. Can you let me know how I can access the feedback that user give. Do you log the payload, along with "yes" and "no". Also, so that feedback becomes actionable, it would be good to get separate feedback for each tone category.


Add SemanticVersion to API docs

Adds SemanticVersion to docs_main.cr to include it in doc generation.
Adds additional docs on the SemanticVersion class.

Resolves #6999

Sorry, I was thinking about dash, like in the examples you've given.

Anything else need done on this?


Implement final referral rewards/cashback system

Implement the system as described in http://bitshares.github.io/referral-program/
This issue supercedes #13

As per issue #34, make sure the vesting threshold is respected prior to closing this issue.

Still needs to implement threshold for vesting fees


Disabling nested sortable lists

Hello,
can someone help me to disable making nested sortables in this list
https://jsbin.com/juqosoyeni/1/edit?html,css,js,console,output
I'd like to move items from group 1 fo/from group 2 and to/from root list, but i don't want to make nested groups in Group 1, Group 2. Group 1, Group 2 can be moved only in root list.
Thanks

You can use pull/put logic for this: https://github.com/SortableJS/Sortable/blob/master/README.md#group-option

@owen-m1  Thanks. But when i'm using pull/put options, i can't put to the list any other items, but i need to put other items except other sortable lists.
BTW. Do you know is it possible to disable some items from dragging ?

@tonykor You would do something like this: https://jsbin.com/xemahijinu/2/edit?js,output
For disabling items from dragging, use the filter option: https://sortablejs.github.io/Sortable/#filter

thanks, it works


OAuth2 and ACL plugins not working as expected

Summary
Hi, I have created:

Two APIs:
      API A: request_host = host_one.com, ...
      API B: request_host = host_two.com, ...

Two Consumers (Jason, Alice)

Assign OAuth2 and ACL plugins to both APIs, using Group 1 to be in the whitelist of the API A and using Group 2 to be in the whitelist of the API B

Assign Jason to Group 1

Assign Alice to Group 2

At the end of the previous steps I can get the following OAuth2 info:
-------------------   Jason API A    ----------------------
Host = host_one.com
grant_type: client_credentials
client_id: 12b1c51156e445d89f6038de8ef46942
client_secret: 1c43b4a04c7f48ek8ba21aac2e420b79
---------------------------------------------------------

-------------------   Alice API B   -----------------------
Host = host_two.com
grant_type: client_credentials
client_id: 50eb4afb85d24660a9w99d602a11da85
client_secret: 6a185438f5524f02cb3bc145083f19da
---------------------------------------------------------

Now, when I try:
curl -k -X POST https://my-kong.com:8443/oauth2/token \
	--header "Host: host_one.com" \
	--data "grant_type=client_credentials" \
    --data "client_id=12b1c51156e445d89f6038de8ef46942" \
    --data "client_secret=1c43b4a04c7f48ek8ba21aac2e420b79"

It returns:
		{
		  "token_type": "bearer",
		  "access_token": "c48abd34afd54241a26e5b1434692674",
		  "expires_in": 7200
		}

So far, so good; but when I change the host and keep the other data:
curl -k -X POST https://my-kong.com:8443/oauth2/token \
	--header "Host: host_two.com" \
	--data "grant_type=client_credentials" \
    --data "client_id=12b1c51156e445d89f6038de8ef46942" \
    --data "client_secret=1c43b4a04c7f48ek8ba21aac2e420b79"

Is returning:
		{
		  "token_type": "bearer",
		  "access_token": "2cec2f0d10d14fd8b702b7c726d2f8f1",
		  "expires_in": 7200
		}

which is something unexpected; it should have prevented the access because is not allow to do queries in the whitelist group of API's host_two.
Any ideas why?
The main goal is that Jason shouldn't be able to get OAuth2 tokens for API B, and that Alice shouldn't be able to get OAuth2 tokens for API A.
Additional Details & Logs

Kong version 0.8.3 and 0.9.2
Operating System: Ubuntu 14.04 x 64Bits

@Edenshaw - Just to satisfy my curiosity: When you try to use the access token for Group 1 with the API os host_two.com, it does get rejected by the acl plugin? So that it's "just" that the access token is created, but it's not valid for the second API?


Exercises-w1

Exercises
Name
Pelle Borst
Class
206
GitHub username
pelleborst
Bootcamp exercises
https://github.com/PelleBorst/js-bootcamp/tree/master/template-repo
Bootcamp notes
https://github.com/PelleBorst/js-bootcamp/blob/master/template-repo/notes.md

The exercises for the first week were not on time, will look at the exercises from w-2.


 The label should be made multiline to wrap when needed.

I want to work on this issue

assign me this issue

@Prince-kushwaha please feel free to work on it, thanks!

ok

this issue is solved in latest version 2.13.2 ~757c7b008

Thanks for debugging it @Prince-kushwaha

Re-opening this as I could still observe the issue in the latest master (2ed5a74b4d24f80e8f24c2cb642f457e953e5b28). I believe the truncation depends on the screen size. So, to observe this it's best to try testing in a smaller screen device. For completeness, I observe this in a 4.2" screen device.

I want to work on this issue. I think I can fix that. Assign me this issue.
Thank You.

Sure @Saral-code ! Feel free to work on it and let us know how it goes :)

but i work on this issue

@Prince-kushwaha You can continue working and i ll also try to correct it. No problem.

ok

Actually we don't assign the same issue to 2 people. We don't want to waste you efforts.
@Prince-kushwaha you said you can't replicate the issue, right? It this still the case?
@Saral-code , if @Prince-kushwaha is still willing to work on the issue, please pick another issue for yourself.
Thanks both for your interest:)

Ok then , i m also facing issue in running Android studio in my laptop.
See ya

Anyone review my pull request #4041 and #4028


Added TestGetUserInfo

Added test TestGetUserInfo

a pure test?! unsolicited?!
You sir are a gentleman and a scholar.
Thank you.


4.2.7 preparations merged, missing 4.2.6 tag

Also missing pypi release https://pypi.python.org/pypi/isort

missing tag and pypi release caused Fedora packaging to not pick up the new release: http://koji.fedoraproject.org/koji/packageinfo?packageID=22885

So sorry about this! I'm not sure exactly what happened, most likely these where place holder version numbers for what would be released, once a release happened, since even the code still had it at 4.2.5. In any case I've just released 4.2.8 which is correctly tagged and pushed to PYPI, and rolled in all changes from 4.2.6 & 4.2.7 into it.
Thanks!
~Timothy


show redundancy switchover history

ewlc1#show redundancy switchover history
Index  Previous  Current  Switchover             Switchover
       active    active   reason                 time
-----  --------  -------  ----------             ----------
   1       1        2     Active lost GW         03:26:09 UTC Wed Sep 23 2020
   2       2        1     user forced            05:40:13 UTC Thu Oct 1 2020

ewlc2#show redundancy switchover history
ewlc2#

ewlc3#show redundancy switchover history
Index  Previous  Current  Switchover             Switchover
       active    active   reason                 time
-----  --------  -------  ----------             ----------
   1       1        2     user forced            16:01:34 UTC Tue Jul 7 2020
   2       2        1     user forced            16:37:10 UTC Tue Jul 7 2020
   3       1        2     user forced            10:12:15 UTC Wed Aug 12 2020
   4       2        1     user forced            10:42:32 UTC Wed Aug 12 2020

^\s+(?P<index>\d+)\s+(?P<previous_active>\d+)\s+(?P<current_active>\d+)\s+(?P<switchover_reason>.+)\s+(?P<switchover_time>\d+:\d+:\d+\sUTC\s\S+\s\S+\s\d+\s\d+)


XamariniOS: mdtool builds with default solution configuration rather than supplied one

Single quotes around the configuration result in mdtool
incorrectly parsing the argument and selecting the default solution
configuration instead of the one passed in the argument. This is probably a hangover from when the toolRunners’ method of execution was changed.
Also, ToolRunner does nothing with the ‘raw’ argument, so we won’t pass it if
we don’t need it.

Hi @milliamp, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Correct that raw was simply left as back compat - good to not pass.
I'm adding Madhuri to this PR since she's more familiar with mdtool.
But, in the meantime - it's true that single quotes won't interpret anything.
http://stackoverflow.com/questions/6697753/difference-between-single-and-double-quotes-in-bash
But, double quotes will.  My questions are (1) can configuration ever have a space in it? (2) does double quotes work instead removing the single quotes?

Is there a know time or schedule when, or if, this changed is also available on the Visual Studio Online environment?


tooling: release automation

Releasing a new SDK version has an 18-step process. It seems as though this could be simplified a bit using make recipes, or a possibly using a tool like goreleaser.

[ ] update RELEASING.md to reflect new steps we're introducing for the OSS license process
[ ] where possible, create make targets for the steps in RELEASING.md
[ ] see if we can make the tagging steps a bit less cumbersome
[ ] look into whether drafting the release using the github UI is the best approach - the auto-generated release notes have been a great starting point for previous release notes
[ ] look into whether letting the github UI create the tag for us is the best approach

[ ] maybe we can make tool that suggests the next release version string for us

[ ] maybe we can do something automated with OSM tooling to create a PR to update the open_source_licenses.txt file


FESVUU:: Undexiting Victini signatures for Eldetini

Full disclosure here the edits to aliases.ts are just a bandaid fix


pixi-projection plugin externs

I'm attempting to create externs for pixi-projection plugin, and would intend to have them within pixi.plugins.projection.  But I'm struggling with understanding the best way to resolve extra methods attached to core classes.  For example "pixi.core.display.Container" will receive method "convertTo2d()" when the plugin is used.  Suggestions welcomed with thanks.

I dont know how to do it in haxe. Mixins should be possible, right?
I even found a way to do them in typescript with usage of ES6 modules


OPSEXP-2893 Add step which cleans the bakery-cache tags older than given period

Description
Added step in cleanup images workflow which cleans the bakery-cache repo from the tags older than 2 weeks after every PR merge.
Related Issue
ref: OPSEXP-2893
Checklist

[x] My code follows the project's coding standards.
[ ] I have updated the documentation accordingly.

Dry run: https://github.com/Alfresco/alfresco-dockerfiles-bakery/actions/runs/11837118840


R3 pep8/flake8 cleanup

To prepare for Release 3 PGE development, now is a good time to burn down some of the pep8/flake8 findings that have crept in during the R2 development cycle.
The goal of this ticket is to address as many legitimate findings from the pep8/flake8 logs. For findings that we want to ignore, we should add the appropriate inline comments to ignore said findings going forward.

Merged with #241


UIVisualEffectView support

Hey, thanks for a great framework!
I have a question/feature request.
As I can see currently one can't use UIVisualEffectView in layout. If I add it with some subviews I get a runtime crash saying that subviews shouldn't be added directly, instead one should add them to  UIVisualEffectView's contentView.
It'd would be nice to support this automatically and also allow to set a visual effect like UIBlurEffect  in that view definition.

@algrid thanks for reporting this - I'll try to get it fixed asap.

@algrid this is fixed in 0.6.28.

@nicklockwood it works great, thank you!


Improve agent telemetry tracking in GraphRAG for trip planning

This PR provides a robust example on the value of Telemetry data to improve visibility into Swarm behavior for complex sceanrios:  agentchat_swarm_graphrag_telemetry_trip_planner.ipynb.
The notebook walks through the process of setting up telemetry using Arize Phoenix, improving visibility to the swarm's decision-making process throughout trip planning. This includes:

improved fine-grained telemetry information to better understand node selection behavior.
Logging time taken for various stages of agent processing.
(Future) Adding real-time performance monitoring visualizations.

These changes address gaps in observability that were experienced while reviewing the agentchat_swarm_graphrag_trip_planner.ipynb notebook.
Recommended reviewer:  marklysze
Related issue number:  N / A
Checks

[x] I've included any doc changes needed for https://ag2ai.github.io/ag2/. See https://ag2ai.github.io/ag2/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Thanks @donbr, works great, I've sent through a few tweaks via our chat on Discord, look forward to merging it :)

@marklysze - please review requested changes


Allow viewing message edit history

@timabbott said:

I think this is a checkbox feature, where there's a lot of value in it, even if the polish isn't great.  (FWIW, the Zulip webapp's display of topic edits is semi-broken and has been since it was first implemented, for example)

See more discussion around that quoted message.

The endpoint it looks like we'll want to use is documented here.
We have a binding for it, in src/api/messages/getMessageHistory.js, that currently isn't used.
Conveniently, just as with messages themselves, it looks like the diff we want to display, content_html_diff, is HTML, which we can render in a WebView.
I think a major question we'll need to answer first is whether the edit history should be viewed in the same WebView used to display the message list, or if it should be a new WebView.
There's been some discussion around here of introducing a new WebView for the particular reason that we want to replicate a complicated (but useful) bit of the web app's UI so we don't have to reinvent it ourselves: in that case, the settings UI (which indeed has a lot of stuff going on).
Here, though:

The stuff we want to display isn't particularly various or complicated: a list of edit items, where each edit item shows the diff, the timestamp, and the person who made the edit (I'm guessing there's an admin feature to allow non-authors to edit messages).

Also, Tim says this about the web app's implementation:
@timabbott said:

the webapp's implementation of it is one of our least polished features, but people clearly do like it despite that.

Given these observations, I'm currently inclined against dropping the web app's implementation into its own WebView (with the tweaks necessary to make that possible), even though it might be a win for developing our code-sharing infrastructure.
In this train of thought, if we do put it in its own WebView (separating it from the MessageList), then we should do so for different reasons. Possibly, just wanting to avoid complicating the existing WebView is sufficient. I'm leaning that way, currently; presumably, we'd be responding to a long-press, or something in the action sheet, and the bulk of the logic for those handlers is already already outside the message list's WebView. But I could anticipate hesitation about a multiplicity of WebViews.
@gnprice, thoughts?

if we do put it in its own WebView (separating it from the MessageList), then we should do so for different reasons. Possibly, just wanting to avoid complicating the existing WebView is sufficient. I'm leaning that way, currently; presumably, we'd be responding to a long-press, or something in the action sheet, and the bulk of the logic for those handlers is already already outside the message list's WebView.

That sounds like a good reason to me.
This will be a lot like MessageReactionList -- it's an additional screen in the navigation, which you get to from long-press to see more details about a specific message. That seems a lot simpler to implement and maintain than adding to the existing WebView, and on a phone's (small) display it's probably a nicer UX anyway.


[CPU][ArmSME] Enable transposes for f32 and f64

This patch enables transposes for ArmSME for f32 and f64 types now that they
may get eliminated by folding into defining vector.transfer_read since [1].
This is done by extending setTransposeLikeOpRootConfig which currently only
supports x86 (no changes there). The transpose is represented by a
linalg.generic, since linalg.transpose gets converted by
GeneralizeLinalgNamedOps.
[1] https://github.com/llvm/llvm-project/pull/92562
ci-extra: build_test_all_arm64

Can you add ci-extra: build_test_all_arm64 as the last line of your PR summary (and push something to re-trigger CI)?

Can you add ci-extra: build_test_all_arm64 as the last line of your PR summary (and push something to re-trigger CI)?

Looks like CI ran but I'll add it to summary for any updates.

Can you add ci-extra: build_test_all_arm64 as the last line of your PR summary (and push something to re-trigger CI)?

Looks like CI ran but I'll add it to summary for any updates.

Just noticed ci-extra: build_test_all_arm64 was skipped, will push to trigger.

I've moved this to draft, will re-open once https://github.com/llvm/llvm-project/pull/92562 lands in the next LLVM integration.

Thanks Cullen!
Sorry for the delay, I've kept skipping this one without realising that this is the patch :) I blame the title:

[CPU][ArmSME] Enable transposes for f32 and f64

That's not what's happening here, is it? IIUC, this patch adds logic to identify transpose-like linalg.generic Ops and then, for ArmSME, adds "scalable" flags to the tiling config. For X86 there should be no changes, right?
That's my understanding based on the code - is this correct? If yes, could you update the summary?

Thanks Cullen!
Sorry for the delay, I've kept skipping this one without realising that this is the patch :) I blame the title:

[CPU][ArmSME] Enable transposes for f32 and f64

That's not what's happening here, is it? IIUC, this patch adds logic to identify transpose-like linalg.generic Ops and then, for ArmSME, adds "scalable" flags to the tiling config. For X86 there should be no changes, right?

It is what's happening, albeit indirectly since linalg.transpose ops are converted to linalg.generic by GeneralizeLinalgNamedOps`. But yes, no changes to X86.

That's my understanding based on the code - is this correct? If yes, could you update the summary?

Not quite, but I'll clarify in the summary to make it clearer 👍

Would be good to wait for either @hanhanW or @dcaballe review.

AFAIK, Diego is distracted with other activities these days :)
This looks good to me, what do you think @hanhanW and @MacDue ?

Thanks, just one nit! LGTM!

thanks for reviewing! Fixed the final nit 👍


Enable TLS support for CLI

Adds support for making TLS requests to the requester node for both v1 and v2 API clients.
By default, all communication with the requester API will remain HTTP as switching to HTTPS would be a breaking change. Making TLS calls can be activated with the command line flag --tls or by setting the environment variable BACALHAU_API_TLS=1.
If the server is using a self-signed certificate, it will be necessary to either accept insecure requests (no certificate verification) or to provide a CA certificate file.
By specifying --cacert [filename.crt] the client will use a provided CA certificate to verify the certificate when communicating with the requester node. This certificate (often called ca.crt) must be provided by the certificate issuer (which may be the cluster owner in a self-signed scenario). In addition to the command line flag, it is possible to set the BACALHAU_API_CACERT environment variable to point to the file.
The least preferable option, but possibly the easiest is to use the --insecure flag to make HTTPS requests without verifying the certificate. You may also set BACALHAU_API_INSECURE.
TODO
Needs tests

@simonwo @frrist is it possible to get a review on this PR in its current state please and once we've agreed it is (or isn't) the correct approach I can fix it up.


Bringing the 3.2 branch in line with Godot 3.2

Bringing the 3.2 branch in line with Godot 3.2 as at the 2nd of June 2020

I'll merge this before the week is out, want to wait until people are informed about the master of godot-headers being brought into sync with Godot master (separate PR)

Waiting for an upstream change in master before I merge those updates but I think it's safe to merge this now.


Error in retrieving context for some diseases

Hi @karthiksoman,
I am trying to run the true_false_generation notebook and came across this error where it's not able to retrieve context from SPOKE for some diseases.
for index, row in question_df.iterrows():
    question = row["text"]
    context =  retrieve_context(row["text"], vectorstore, embedding_function_for_context_retrieval, node_context_df, CONTEXT_VOLUME, QUESTION_VS_CONTEXT_SIMILARITY_PERCENTILE_THRESHOLD, QUESTION_VS_CONTEXT_MINIMUM_SIMILARITY)
    # print few context lines
    context_lines = context.split("\n")[:3]
    print(context_lines)

Eg: for question and disease : Neurofibromatosis 2 is not associated with Gene NF2 it is failing and showing the error:

IndexError                                Traceback (most recent call last)
File ~/miniconda3/envs/kg_rag/lib/python3.10/site-packages/tenacity/init.py:382, in Retrying.call(self, fn, *args, **kwargs)
381 try:
--> 382     result = fn(*args, **kwargs)
383 except BaseException:  # noqa: B902
File ~/sulab_projects/KG_RAG/kg_rag/utility.py:125, in get_context_using_spoke_api(node_value)
124 context = merge_2['context'].str.cat(sep=' ')
--> 125 context += node_value + " has a " + node_context[0]["data"]["properties"]["source"] + " identifier of " + node_context[0]["data"]["properties"]["identifier"] + " and Provenance of this association is " + node_context[0]["data"]["properties"]["source"] + "."
126 return context
IndexError: list index out of range
The above exception was the direct cause of the following exception:
RetryError                                Traceback (most recent call last)
Cell In[132], line 3
1 for index, row in question_df.iterrows():
2     question = row["text"]
----> 3     context =  retrieve_context(row["text"], vectorstore, embedding_function_for_context_retrieval, node_context_df, CONTEXT_VOLUME, QUESTION_VS_CONTEXT_SIMILARITY_PERCENTILE_THRESHOLD, QUESTION_VS_CONTEXT_MINIMUM_SIMILARITY)
4     # find context first few lines  and last few lines
5     context_lines = context.split("\n")[:3]
Cell In[79], line 15
...
--> 326     raise retry_exc from fut.exception()
328 if self.wait:
329     sleep = self.wait(retry_state)
RetryError: RetryError[<Future at 0x7fa2361b66e0 state=finished raised IndexError>]

@janjoy can you post the link to the notebook that you mentioned? I couldn't locate the notebook named 'true_false_generation' in the notebooks directory of KG-RAG.

@karthiksoman https://github.com/BaranziniLab/KG_RAG/blob/main/kg_rag/rag_based_generation/GPT/run_true_false_generation.py trying to run this file and it was giving some errors. So I tried to see for which questions (https://github.com/BaranziniLab/KG_RAG/blob/main/data/benchmark_data/true_false_questions.csv) it is not retrieving context.
One example where it was failing was "Neurofibromatosis 2 is not associated with Gene NF2" statement in the csv file. It was giving error as it was not retrieving any context from SPOKE.
I hope this is clear. Please let me know if you have more questions. Thank you =)

@karthiksoman I checked again and found that SPOKE is not able to retrieve context for these two diseases from the list: Neurofibromatosis 2 and Familial Mediterranean Fever

@janjoy Apologies for the delay! I was on vacation :)
Reason why KG-RAG is not able to fetch the context for these two diseases from SPOKE is because SPOKE got updated and the names of these two diseases also got updated and is currently not in accordance with the names stored in the vector database. That is the reason it is not returning any context for these two diseases.
For example:
When you ask 'Neurofibromatosis 2 is not associated with Gene NF2', KG-RAG extracts 'Neurofibromatosis 2' from the query. But currently, 'Neurofibromatosis 2' is not part of SPOKE graph (after the update, but previously it was). Hence, it is not returning the context, because it does not have that node in the graph.
This happened because the underlying Disease Ontology database (https://disease-ontology.org/) updated their data which got reflected in SPOKE (because SPOKE always synchronize its data with the underlying parent database, in this case Disease Ontology database)
I presume this update should have affected only a handful of disease nodes. If you happen to encounter more such cases, please let me know, so that I can give the file that contains the disease names based on the current version of SPOKE and you may need to re-create the vectorDB so that it will be in-sync with the current version of SPOKE.

@janjoy I am closing this issue since it addressed the reason for your question. Feel free to re-open it if you have more follow-up questions on this.

Thanks Karthik!
On Fri, Apr 26, 2024 at 8:54 AM karthik-soman @.***>
wrote:

@janjoy https://github.com/janjoy I am closing this issue since it
addressed the reason for your question. Feel free to re-open it if you have
more follow-up questions on this.
—
Reply to this email directly, view it on GitHub
https://github.com/BaranziniLab/KG_RAG/issues/28#issuecomment-2079661043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APRASEL5J53QSDHXNXMVV2TY7J2CPAVCNFSM6AAAAABGKEWGNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGY3DCMBUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @karthiksoman , I would like to request the file that contains the disease names based on the current version of SPOKE. Having trouble retrieving content for many such diseases especially while executing the MCQ test questions. Thank you!


BadMigrationError with Django 1.8.6

When trying to run python manage.py makemigrations or python manage.py migrate, the following error occurs:
django.db.migrations.loader.BadMigrationError: Migrated app 'django_extensions' contains South migrations. Make sure all numbered South migrations are deleted prior to creating Django migrations.

Fixed with #757 .

There will be a new release shortly.

:+1:


azcore: refactor TracerOptions.SpanFromContext

At minimum, change the sig to remove the bool return parameter.  Ideally, find a way to populate the az.namespace attribute for ARM modules that precludes the need for this (used in the trace namespace policy).

Fix will go out in<EMAIL_ADDRESS>


fix Fix wrong results when select from view which has with clause

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.66 seconds
load time: 445 seconds
storage size:<PHONE_NUMBER>1 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221201183126_clickbench_pr_56393.html


Input range is not working properly in Chrome under Ubuntu OS

cc @piensaenpixel

We know @AbelVM :( the last release of chrome broke it :(
So now... we need use jquery ui for this.

Hey, is it still happening?

Yep. Chrome/Ubuntu here


[UIMA-6160] add startAt with one int, incl doc and test

retest this please

test this please

retest this please

test this please

Jenkins, can you test this please?


fix: expand patterns in file

patternsFile was not being used.

Made it a function.

The patternsFile in action.getInput('files', { required: !patternsFile }) doesn't exist.

Ok. Works now: https://github.com/tree-sitter/tree-sitter-ocaml/pull/87
One peculiarity that is maybe not obvious for everyone, is that the files and files-list patterns are expanded separately. So you can't do files: examples/**/*.ext and then add exclusions in files-list. Maybe it's good to mention that in the documentation, or even recommend not to combine files and files-list.

Won't tree-sitter handle the exclusions?

No, we're passing a file with paths to tree-sitter, not patterns.
The behaviour of negated patterns depends on the order. They can only exclude files that were included before, not after. So if you want to combine files and files-list in a single "pattern collection", the order in which you do so becomes important.
I don't really see a use case for having both files and files-list, and the consequences can be confusing. Not allowing it at all is an option too.

I'll figure something out tomorrow.

Can you try v4?

As I said before, I don't think it's a good idea to combine the patterns like that.
With your new implementation, this will work as expected:
files: |
  examples/**/*.ext
files-list: files.txt

files.txt
---------
!examples/invalid1.ext
!examples/invalid2.ext

But this will not work
files-list: files.txt
files: |
  !examples/invalid1.ext
  !examples/invalid2.ext

files.txt
---------
examples/**/*.ext

That seems like a limitation of @actions/glob and there's nothing I can do about it.

That's not a limitation of @actions/glob, it's how git patterns are supposed to work.
But it does mean that the combination of files with files-list doesn't make sense. So it's a lot better to give a clear error message when someone tries to use them both (for which I don't see a use case), than to try to support it and do it badly.


OpenSSL 3.x FIPS self test query

Hi,
As per the deatils provided in https://www.openssl.org/docs/man3.0/man7/fips_module.html (Making all applications use the FIPS module by default), I have updated Openssl 3.x config file to make sure FIPS module is enabled for all applications which are linking libcrypto.
Based on above mentioned information, I have created a sample C++ application and compiled it by linking with libcrypto. On executing sample application binary, self test result is not getting printed on screen.
Note: On running OpenSSL fipsinstall command, self-test result is printed on screen.
Any suggestions?
Regards

Please look at the apps/fipsinstall.c. The OSSL_SELF_TEST_set_callback(NULL, self_test_events, NULL); call along with the self_test_events() callback function provide the self-test result printing.

Note that the self tests are run during installation, but not each time that the module is loaded.

Please look at the apps/fipsinstall.c. The OSSL_SELF_TEST_set_callback(NULL, self_test_events, NULL); call along with the self_test_events() callback function provide the self-test result printing.

Does this mean that the sample application is suppose to explicitly call OSSL_SELF_TEST_set_callback API to know the self test result ?

Note that the self tests are run during installation, but not each time that the module is loaded.

As far as I know, for FIPS validation, any application linking libcrypto should run self test on every startup.

NIST introduced IG 9.11 which relaxed the rules around when and how often the self tests needed to be run.  It suffices to run most of them at installation time which is what fipsinstall does.

Does this mean that the sample application is suppose to explicitly call OSSL_SELF_TEST_set_callback API to know the self test result ?

You can find out the result of the self test implicitly - when OSSL_PROVIDER_load(libctx, "fips") returns NULL the self test failed (or the provider was not found). If you load the fips provider by means of loading the configuration file you can also test for it with OSSL_PROVIDER_available() function to avoid calling load/unload.
The provider is never loaded into the libctx if the self tests fail (or failed during the installation).
You can make the fips provider to always run the self tests on startup if you remove the install-mac and install-status variables from the fipsmodule.cnf file.
You can also trigger the self test explicitly by calling OSSL_PROVIDER_self_test().

Thanks, it was very helful. Fips provider is loaded successfully in my sample application using the configuration method.
Is there a way to fail a particular selftest algorthim programatically?

@t8m
Hi Tomas,
Sry to comment here as it is closed issue
we are also trying to run the self test on demand and not very much successful
i could see your comment as "You can make the fips provider to always run the self tests on startup if you remove the install-mac and install-status variables from the fipsmodule.cnf file."
but in our cnf file i dont see these attributes
[fips_sect]
#activate = 1
conditional-errors = 1
security-checks = 1
module-mac = 53:C8:
Any inputs please here

@raghupcr
Did you run “fipsinstall” command ?

but in our cnf file i dont see these attributes

In that case you probably did not run the openssl fipsinstall command and that actually means the self tests will be always run on load of the fips provider.

@raghupcr Did you run “fipsinstall” command ?

Hi we didnt run the fipsinstall command manually, but when we configure the openssl we gave enable-fips which intern calls the install-fips which intern calls the fipsinstall command is what we read? correct me if i m wrong plz

but in our cnf file i dont see these attributes

In that case you probably did not run the openssl fipsinstall command and that actually means the self tests will be always run on load of the fips provider.

Hi Tomas,
So when ever we do ossL_provider_load("fips") it will call the self test at the startup ?
is that right

@raghupcr
OpenSSL fipsinstall execution is required to calculate the MAC of fips.so which gets validated on the system.

@raghupcr OpenSSL fipsinstall execution is required to calculate the MAC of fips.so which gets validated on the system.

Hi @iamwum ,
MAC is calculated already and is available in the fipsmodule.cnf
module-mac = 53:C8:E8:xxxxxxxxxxx
as we have installed with enable-fips in the configure it has taken care of this

For on demand selftest (on application startup),  openssl.cnf can be updated to load fips provider which will enable fips mode in libcrypto  thus executing self test on startup (or) load it programmatically in your application as you stated earlier. OpenSSL.cnf change is simpler approach.

I doubt if fipsinstall got executed as part of install because fipsmodule.cnf is not updated with install-mac and install-status attributes, try running fipsinstall and launch your application, that should give some clarity.

So when ever we do ossL_provider_load("fips") it will call the self test at the startup ?
is that right

Not entirely.  Fipsinstall runs the power up self tests.  When the FIPS provider is loaded, the power up self tests are not generally run.  There are some mandated tests which do get run -- entropy continuous tests e.g.

… which will enable fips mode in libcrypto …

A small point: libcrypto doesn't have a FIPS mode anymore.  Libcrypto knows nothing about FIPS.  All FIPS specific things are in the FIPS provider.

So when ever we do ossL_provider_load("fips") it will call the self test at the startup ?
is that right

Not entirely. Fipsinstall runs the power up self tests. When the FIPS provider is loaded, the power up self tests are not generally run. There are some mandated tests which do get run -- entropy continuous tests e.g.
On demand tests require your application to start them. That's the reason they are called on demand. If you want the self tests to run on load, rerun fipsinstall with the -self_test_onload command line option. Given the comments above, I suspect fipsinstall was run as part of the build process.

Thanks Dr.Paul,
Given the comments above, I suspect fipsinstall was run as part of the build process.
------- Means we need to run this command manually, will it not take place automatically when we configure enable-fips and build?
readme-fips.md
==============make install
effectively executes the following install targets
$ make install_sw
$ make install_ssldirs
$ make install_docs
$ make install_fips     # for enable-fips only
The Installation of the FIPS provider consists of two steps. In the first step, the shared library is copied to its installed location, which by default is
/usr/local/lib/ossl-modules/fips.so                  on Unix, and
C:\Program Files\OpenSSL\lib\ossl-modules\fips.dll   on Windows.
In the second step, the openssl fipsinstall command is executed, which completes the installation by doing the following two things:

You'll only need to run it manually if you want the on load self tests.

hi Tomas & Paul @t8m @paulidale
Sorry, I am searching the openssl selftest function and find this topic, and this topic helps a lot for me. But I have another questions is does openssl implemented the conditional test such as Pair-Wise Consistency Test when module generates public or private key pairs? I remember the conditional test function was implemented in the legacy versoin but not found in the 3.0, maybe I missed something, could you give some suggestion? Thanks in advance.

Yes it does.

@paulidale Another question is reseed test, does the openssl also implemented it as a conditional test? Thanks.

@paulidale Thanks for confirmation. I asked this question because I remember reseed test is new requirement for fips-140-3, not sure openssl has implemented it. Thanks again.


libGL error: No matching fbConfigs or visuals found

Hi!
Thanks for this great game.
I'm on Manjaro XFCE. I have an old nVidia GeForce GTS 250 graphics card.
When using the video-linux driver in the Manjaro Settings Manager which installs the Nouveau driver, the game starts and works flawless. However when I use video-nvidia-340xx I get the error:
marco@keks ~ rttr.sh
Return To The Roots v20200212-b7f38122f97f08a21c0b55b673d8d06c113a5639
Compiled with GNU C++ version 9.2.0 for linux 64 Bit

Starting in /usr

WARNING: Your application version has changed - please recheck your settings!

Searching for drivers in /usr/lib/s25rttr/driver/video
2 video drivers found!
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
X Error of failed request:  GLXBadContext
  Major opcode of failed request:  154 (GLX)
  Minor opcode of failed request:  6 (X_GLXIsDirect)
  Serial number of failed request:  107
  Current serial number in output stream:  106

This might be problem with nvidia driver and my old GTS 250 card, but maybe you have a hint how to fix this.

Hmm, on the page https://wiki.archlinux.org/index.php/NVIDIA I see in section Unsupported drivers:

For GeForce 2/3/4 MX/Ti series cards [NV11, NV17-NV28], install the nvidia-96xx-dkms (AUR) package. Last supported Xorg version is 1.12.

I however have X.Org X Server 1.20.7. Can anyone confirm that's my problem?

I just checked if I can run other 3D programs like glxgears and glmark2 using the . Both run flawless using the nvidia driver.
marco@keks ~ glmark2
=======================================================
    glmark2 2014.03
=======================================================
    OpenGL Information
    GL_VENDOR:     NVIDIA Corporation
    GL_RENDERER:   GeForce GTS 250/PCIe/SSE2
    GL_VERSION:    3.3.0 NVIDIA 340.108
=======================================================
[build] use-vbo=false: FPS: 1907 FrameTime: 0.524 ms
[build] use-vbo=true: FPS: 2604 FrameTime: 0.384 ms
...

Sorry, this does not belong here. It belongs to https://github.com/Return-To-The-Roots/s25client; I confused rttr with return-to-the-roots.


Load Balancer inconsistent behaviour for new containers

Apologies if this is an duplicate error. I did a search and couldn't find any similar issues. So here goes:
Rancher Version: v0.56.1
Docker Version: 1.9.1
OS: RancherOS 0.4.2 AMI
Steps to Reproduce:

Add 2 nodes in Rancher using the "Custom" method (logging in and running docker agent)
Create a Load Balancer service which would spawn 2 containers, one on each node
Add a 3rd Custom node by running docker agent.

Results:
The 3rd Load Balancer container running on the 3rd node has a different configuration to the first 2 containers. It contains linked services where as the first 2 containers are blank (see attached images)
If the Load Balancer was edited at a Service level (e.g. link a new service), the first 2 containers would automatically pick up the changes. Where as the 3rd Load Balancer will not update and return 503 errors. Until the container is restarted.
Expected:
New Load Balancer containers created as part of newly created nodes should behave exactly the same as the existing Load Balancer nodes on existing nodes.
All Load Balancers should consistently reflect the changes made at the Service level.

 When I try to save in the UI, it won't save.
Should they all have the links or not have the links?
If you have multiple environments, you might be hitting #1389, which wasn't fixed until v0.59.0+.
I have not been able to reproduce. My additional container has been updating like the other ones.

Thanks I will try it out with 0.59.0

@yunspace Please re-open if you are able to reproduce with v0.59.1+. Our current latest is v0.63.0


specifying list of colors does not work for me

MCVE Code Sample

import xarray as xr
import numpy as np

airtemps = xr.tutorial.load_dataset('air_temperature')

air = airtemps.air.isel(time=0)

levels = np.arange(225, 301, 25)

colors = ['#ffffb2', '#fecc5c', '#fd8d3c', '#e31a1c']

# this does not work for me
air.plot.pcolormesh(levels=levels, colors=colors)

Expected Output
Should create a plot with the specified colors. According to the the docstring this should work. Or maybe I am doing something wrong here?
Problem Description
Instead I get the following error:
/usr/local/Miniconda3-envs/envs/2019/envs/iacpy3_2019/lib/python3.7/site-packages/xarray/plot/utils.py in _process_cmap_cbar_kwargs(func, kwargs, data)
    683     # colors is only valid when levels is supplied or the plot is of type
    684     # contour or contourf
--> 685     if colors and (('contour' not in func.__name__) and (not levels)):
    686         raise ValueError("Can only specify colors with contour or levels")
    687

ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

Instead I use the following, which works:
air.plot.pcolormesh(levels=levels, cmap=colors)

Output of xr.show_versions()

INSTALLED VERSIONS
------------------
commit: None
python: 3.7.1 | packaged by conda-forge | (default, Feb 18 2019, 01:42:00)
[GCC 7.3.0]
python-bits: 64
OS: Linux
OS-release: 4.12.14-lp151.28.13-default
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_GB.UTF-8
LOCALE: en_US.UTF-8
libhdf5: 1.10.4
libnetcdf: 4.6.2
xarray: 0.12.1
pandas: 0.24.2
numpy: 1.16.2
scipy: 1.2.1
netCDF4: <IP_ADDRESS>
pydap: installed
h5netcdf: 0.7.1
h5py: 2.9.0
Nio: None
zarr: 2.3.1
cftime: <IP_ADDRESS>
nc_time_axis: 1.2.0
PseudonetCDF: None
rasterio: 1.0.22
cfgrib: 0.9.7
iris: 2.2.0
bottleneck: 1.2.1
dask: 1.1.5
distributed: 1.26.1
matplotlib: 3.0.3
cartopy: 0.17.0
seaborn: 0.9.0
setuptools: 41.0.0
pip: 19.0.3
conda: None
pytest: 4.4.0
IPython: 7.4.0
sphinx: 2.0.1

I just found out - the error actually comes from using a numpy array to the define the levels (and (not levels))  and not from using colors. So it is in a way a user error. However, I suppose it would be good to support numpy arrays?


Campaign stuck after sending 30% Users

Hello, we were looking to send our weekly newsletter campaign with Parcelvoy. We setup a campaign to send to a list of 350K+ users.
The campaign sent 99K emails and is still stuck in the Running state after 14+ hours. We checked AWS SES limits etc and everything seems to be in order. Till now, we have been using another tool to send newsletters and it sent the same email to a similar-sized audience the same day properly.

How can we debug this? (I tried checking the docker worker logs, however since we also have journeys running in PV, its difficult to find.)
While the email was sent to only 99k users, the DB usage increased by more than 3GB. Here are the table sizes

Here are some rows of the user_events table dump.csv
Our SES rate limit is 500 emails per sec. PV AWS SES integration is configured at 200 per second.

Thank you for your help!

Need some more details:

What queue are you using?
If you look at the campaign_sends table what state are the records in that are not complete?

I have used the normal docker installation. How do i check the queue i am using?
Here is the campaign_sends table

I have a thought - the basic difference between this newsletter campaign and the other campaigns (that are working fine) is that this one was scheduled for a specific time and not based on an event/or is part of a journey. Is that causing the remaining emails not to be sent as the (cron/batch?) job is not picking these up to be sent to the queue?

Thats quite a few emails stuck in pending for campaign 70 (which I'm assuming is the one with issues?). If you are using the default installation then you should be using the Redis queue. The first thing I would check is the memory limits on it and if they are being reached or not. If so it could be that the job queue isn't functioning properly and so you are only getting a fraction of sends every few minutes instead of all of them being in there. If they were all in the queue I would expect to see a bunch of messages with a status of "throttled" or something similar

Hello! Thank you for your revert.
This is what the stats look like - it seems Redis is not using more memory.

At a server level, we have 50% RAM unused. Should I allocate more memory and check?
I also checked the campaign_sends stats now and they look the same as my last screenshot. It seems that the remaining emails from the campaign are not being picked up for sending.
Is there something more i can check? Thank you for your help!

We did some more investigations. Something seems to be off. I see these kinds of logs in "parceloy-worker-1"
[1730698344233] INFO (email/8 on 04464afff320): queue:job:completed
data: {
"campaign_id": 70,
"user_id": 699868,
"send_id": 717855
}
options: {
"delay": 0,
"attempts": 3,
"jobId": "sid717855"
}
token: "8295e9c9-59c0-41cb-9871-3469a50087d6:9"
For the given user_id, the status in the campaign_sends table is not getting changed, there are no emails triggered since Friday evening.
More importantly  -

Users are not being added via the API / are not entering journeys.
The parcelvoy-api-1 logs show requests being received, however users are not getting added to MySQL.
Essentially, the entire journeys are shut at this point of time.

The sequence of events for us:

Parcelvoy running nicely with multiple email, push journeys being triggered via APIs.
Added around 350K users via CSV upload and scheduled a campaign.
Campaign stuck and users stop getting added to the MySQL via APIs once the large list of users is pushed in.
Updated PV via docker pull, and upgraded/restored database.

Any help will be appreciated.
I assume if nothing works, we might need to spawn a new instance and redo all journeys?

Were you ever able to get to the bottom of this? My gut still thinks it is probably related to either Redis consuming too much memory and items getting purged or your job queue getting too backed up. You can see how the queue is performing by going to the Performance section under Settings -> Performance.
Also, depending on how many messages you are sending you may want to have more than one worker running to make sure you are actually able to hit your desired send rate. The default is concurrency for a worker is 40 sends and depending on response times from the API requests per second per concurrency may vary. If response time for a send is 200ms than you would be getting only 200 messages per second with one worker. To increase send rates you can just add additional workers to your Docker compose file.

Thank you for the comment and my apologies for not sharing updates here.
We did the following:

Upgraded PV (the upgrade got stuck midway and i had to reset the migrations table for it to work).
the campaign started sending again post the upgrade was done.
the rest of the journeys resumed after the campaign finished (I think i had to restart PV couple of times before the journeys started working again)
I noticed you are working on improving the send performance. I tried upgrading PV but don't see the Settings -> Perormance yet. So decided to wait for the upgrade before we try sending the newsletter again.

Next steps:

Will upgrade PV and also increase the worker count.
Will send the newsletter and then get back with the status.

Closing this issue for now. Thank you for your help!


How do I set up GoAccess with Caddy reverse proxy?

Hi,
I stumbled over your open source project, and I'm pretty new to selfhosting, therefore I wanted something to see my traffic through my Caddy2 reverse proxy.
Sadly I didn't find any guides on how to set it up with caddy, could you guide me in the right direction on where I should look?
Thanks for your help :)

Hello,
Please take a look at the getting started section on how to best install it. Then you can simply run it against your caddy's access log. e.g.,
# goaccess access.log --log-format=CADDY -o report.html

Then you can open your report.html directly in your browser (Ctrl+o) or simply drop it in your document/site root path and access via https://your-domain.com/report.html.
Let me know if you have any additional questions.

BTW, this assumes your Caddy's access log is in a valid JSON format. Otherwise, you can always set your log format under Caddy's config file as log { format json } ....

Hey, thanks for your help, so I got GoAccess to work, but I can't get Caddy to output any log data.
At the moment, my Caddy file looks like this:
superchargejs.com {
  log {
    output file /var/log/caddy/superchargejs.com-access.log
    format json
    level INFO
  }
}
service1.domain.ch:443 {
    reverse_proxy localhost:8096
}
service2.domain.ch:443 {
    reverse_proxy <IP_ADDRESS>:3001
}
service3.domain.ch:443 {
    reverse_proxy <IP_ADDRESS>:8008
}

Maybe you have some experience with the Caddy reverse proxy and can help me out. :)
What would be the command for the rolling report.html files?
Thanks for your help, greatly appreciated!

Glad you got goaccess to work.
I haven't set up Caddy as a reverse proxy myself, but maybe this post can give you a hint? If it's not spitting out any data, I'd post the question on their community forum.

Any updates on this? Thanks

Closing this. Feel free to reopen it if needed.


Only access point or wifi is enabled at one time

Fixes #755.

Ensures that extra wifi-iface lines aren't generated.
Disables wifi when an access point is enabled
Disabled access points when wifi is enabled

@Frijol found that you can't have both wifi and access points enabled at the same time or else the access point doesn't show up.

@Frijol want to give this a try?

Don't listen to AppVeyer. It's trying to clone an old branch.

@johnnyman727

Ensures that extra wifi-iface lines aren't generated.

Awesome fix! I'm glad that shouldn't be an issue after this PR lands.

Disables wifi when an access point is enabled
Disabled access points when wifi is enabled

I don't think this needs to be a constraint on the Tessel. I've successfully run both wifi and an access point connections on the Tessel. Having both enabled means Tessel can connect to wifi configured by a user through a web interface served by the AP. Plus, while a user may not access the external internet through Tessel (yet), the Tessel can connect to outside services while serving a web app through an AP.
If we just fix the extra wifi-iface, does the contraint around wifi and ap both being enabled go away?

I don't think this needs to be a constraint on the Tessel. I've successfully run both wifi and an access point connections on the Tessel.

Now that I'm on a separate network, I see that you're right. sigh.
Previously, I had Tessel on a paywalled network so it didn't actually have access to the internet. I wonder if that had some impact. I could consistently connect to wifi, then create an AP and have the AP undiscoverable.

@Frijol and I are running a workshop right now and several people have had issues where they connected to wifi then made an AP and the AP didn't show up in discovered networks until they ran t2 wifi --off.

@johnnyman727 For the workshop, was there anything unique about the wifi conditions? Was the wifi-blocking issue immediately reproducible on other networks, besides the paywall and workshop networks?

What's the status?

This needs to be rebased to include an updated/corrected git history

@HipsterBrown I've heard from a couple other people anecdotally that having an AP enabled was blocking the wifi access but I'm not able to reproduce reliably. :( I'm not sure what the best path forward is.

@johnnyman727 I would pull out the fix for the extra wifi-iface lines being generated into its own PR so we can get that pushed out as soon as possible. Then I would like to give the other issue of having an AP enabled was blocking the wifi access isolated for more research, but we can add a note around the AP/Wifi docs to help with troubleshooting for folks who run into that issue.

@HipsterBrown sorry about the long delay - updated to just fix the multiple ifaces issue.

ping @HipsterBrown

Ok great. LGTM :+1: I updated the description for this PR for future reference.


Latest Node.js is now 5.11.0

therefore "raspberry.sh" does not work.

Should be fixed. If anyone has an idea how to do this automatically, feel free to send a PR.


KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

remove deprecated --zookeeper option in ReassignPartitionsCommand. And also the zookeeper dependent methods, and the tests.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ijuma , could you help review this PR? Thanks.

@ijuma , thanks for the comments. I've updated with:

move Admin.create into try block
check --bootstrap-server option manually, so that help text can be displayed when no option provided.

Thanks.

@ijuma , could you please help review the PR? Thank you.
The failed tests are all un-related.

    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplicationWithEmptyPartition()
    Build / JDK 11 and Scala 2.13 / kafka.controller.ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir()
    Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
    Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 15 and Scala 2.13 / kafka.log.LogCleanerIntegrationTest.testMarksPartitionsAsOfflineAndPopulatesUncleanableMetrics()
    Build / JDK 15 and Scala 2.13 / kafka.network.SocketServerTest.testUnmuteChannelWithBufferedReceives()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync

@ijuma , could you take a look again for this PR? Thanks.

@ijuma , could you help check this PR again? Thanks.

Failed tests are flaky RaftClusterTest tests. Thanks.
    Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
    Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()

@ijuma , thanks for your comments. I've addressed them and add a note in upgrade.html in this commit: https://github.com/apache/kafka/pull/10471/commits/92157779ce7fa347337916b01c88f9cc415165fe. For the system  tests, I've created another jira ticket to track it: KAFKA-12884. Thank you.

Unrelated test failures:

Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
16 sec
1

Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
24 sec
1

Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()

Thanks @ijuma , I should have listed all failed tests and verify they are all un-related failure to reduce your review task. Thank you. :)


upgrade CircuitPython

At most time, it works well on Windows 11. I even can see the left Battery volume. It is great.
But sometimes, when I am typing, Bluetooth got lost and I can't type anything. After a while, it connect again. I also noticed device status switched bettwen "paired" and "connected".
Wireless device: Wi-Fi 6 AX200.
Is there way to log error so we can debug and find root cause.

try to upgrade firmware by myself:

https://circuitpython.org/board/makerdiary_m60_keyboard/ download latest firmware
https://github.com/makerdiary/python-keyboard this is m60 keyboard module, aka main module
https://github.com/adafruit/Adafruit_CircuitPython_BLE second module
Then code can run. But sometimes failed:

code.py output:
Traceback (most recent call last):
  File "code.py", line 7, in <module>
  File "/lib/keyboard/__init__.py", line 97, in __init__
  File "/lib/keyboard/__init__.py", line 254, in set_bt_id
AttributeError: 'Keyboard' object has no attribute 'ble_hid'

And keyboard will not response even connects to USB. Ctl+D reload then it will ok. But if usb disconnect, can't  connect BLE. At this time, UART reset so I didn't know what happened. It is bad design to debug by an emulated UART.

I upgraded Circuitpython to latest version 7.1. M60 works well when USB connected. But no response when USB disconnected and power by battery.
Any clue on this issue? @xiongyihui

I just tried ZMK, so far so good. https://github.com/fkpwolf/zmk-config/actions

I picked up some changes from https://github.com/adafruit/circuitpython/compare/main...xiongyihui:m60
with modifications to suits CPY 7.x, and compiled an experimental firmware (CPY v7.3.1).
The keyboard should work fine without usb connection. The matrix module is also ported.
Be aware the patches aren't suitable for upstreaming.
For anyone interested, please go to my repo.

@hyx0329 Thanks for the new firmware.
Can you share some information about the process of building a new firmware (cf: https://github.com/makerdiary/python-keyboard/issues/8)?

I upgraded Circuitpython to latest version 7.1. M60 works well when USB connected. But no response when USB disconnected and powered by battery. M60 goes to safe model?

Current upstream version doesn't preserve the state of the battery control pin(p0.28), which seems need to be addressed. That's why the keyboard won't work without a USB power.


Follow 'Protocol Buffers' style guide in file externalscaler.proto

Proposal
Creating this issue on behalf of https://github.com/kedacore/keda-external-scaler-azure-cosmos-db/issues/5. It seems the main ask here is to use snake_case for field names. As the other issue mentions, this would be a breaking change and can be taken up in next major release.

Protocol Buffers Style Guide
externalscaler.proto

Use-Case
No response
Anything else?
No response

Good catch.
@ahmelsayed FYI


Add service e2e tests and Github actions workflow

Bootstraps the S3 e2e tests directory and configures Github actions workflows for unit and e2e tests.
Tracking wider project as part of https://github.com/aws-controllers-k8s/community/issues/735

@RedbackThomson please rebase and squash these many "sausage-making commits" into a single commit. Thanks!


Addition of Gain Control, Noise Suppression, and

Addtion of Gain Control, Noise Suppression, and VAD.
This commit introduces automatic gain control and automatic noise suppression from the filter_audio (webrtc) library. In addition, the webrtcvad dependency has been removed in favor of using our VAD extension. The major changes are:

Added AutomaticGainControl extension
Added AutomaticNoiseSuppression extension
Added WebRtcVad extension
Changed webrtcvad to our WebRtcVad extension

First of all, nice work here. I suspect it was quite the learning curve, but it was good to get some experience with cython.

First of all, nice work here. I suspect it was quite the learning curve, but it was good to get some experience with cython.

One thing we'll want to do is to add the new components to the pipeline profiles, so that the profile configurations line up with those in the android repo. This can be done on a separate PR if you want.
https://github.com/spokestack/spokestack-android/tree/master/src/main/java/io/spokestack/spokestack/profile

One thing we'll want to do is to add the new components to the pipeline profiles, so that the profile configurations line up with those in the android repo. This can be done on a separate PR if you want.
https://github.com/spokestack/spokestack-android/tree/master/src/main/java/io/spokestack/spokestack/profile


Rearranged Profile dropdown menu and moved Sign Out and Feedback up bef…

…ore Add Organisation
What does this pull request aim to achieve? 💯
Please be concise and link any related issue(s):

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[ ] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix. The branch is created in a cloned version of this repo, not a forked repo.
[ ] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[ ] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

I assigned QAs but I don't see build URL.

I think the reason is thart the branch isn't named in the specified format

I have DM Sergej, I will close this one up for now. Will reopen a new one soon.

Okay. Thanks JV


Adds support for the tournament api to baseriotapi

Half of the files were using \r\n as line endings and the other half \n ; the first commit normalizes it to \n. If you want to view the actual changes, have a look at the two other commits.

Hey, unfortunately this ended up being duplicated effort as I'm already in the process of my own implementation of the tournament API. It should be finished and merged into master soon.


Passive Perception Score is wrong

@Ithiloneth   The Passive Perception in the module Token Info Icons seems to be based on Active Perception score.
If I give a character an effect which increases Passive Perception using Dynamic Effects the change is shown on the character sheet, but not on the HUD.

D&D 5e passive persaption equals wisdom mod + perseption skill modifier.
This module doesn't know it.


[BUG] share-manager for a given pvc keep restarting (other pvc are working fine)

Describe the bug (🐛 if you encounter this issue)
the pod share manager keep restarting, end of share-manager logs look like (logs shortened):
nfs-ganesha-29[main] longhorn_recov_init :CLIENT ID :EVENT :Initialize recovery backend 'share-manager-pvc-XXXXX'
nfs-ganesha-29[main] http_call :CLIENT ID :EVENT :Failed to perform CURL operation: Server returned nothing (no headers, no data)
nfs-ganesha-29[main] longhorn_recov_init :CLIENT ID :FATAL :HTTP call error: res=-1 ((null))
level=error msg="NFS server exited with error" encrypted=false error="ganesha.nfsd failed with error: exit status 2, output: " volume=pvc-XXX
mount_helper_common.go:133] Warning: "/export/pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c" is not a mountpoint, deleting
To Reproduce
always hapened on my 3 node home k8s cluster for this share
Steps to reproduce the behavior:
Expected behavior
share-manager  should work
Log or Support bundle
will generate a support bundle ASAP
Environment

Longhorn version: 1.4.1
Installation method : Kubectl
Kubernetes version 1.23 (updating to 1.26 did not resolv the issue)

Number of management node in the cluster: 3
Number of worker node in the cluster: 3 (manager are the worker too)

Node config

OS type and version: ubuntu
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe):
Network bandwidth between the nodes: 1gb

Underlying Infrastructure baremetal, flannel, kubevip for the external IP
Number of Longhorn volumes in the cluster: 23

Additional context
does look like #5385 but I cannot find any remaining mounted nfs

@viknet365
Can you provide the dmesg of each worker node?

2023-05-17T15:37:22.647559454+02:00 17/05/2023 13:37:22 : epoch 6464d892 : share-manager-pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c : nfs-ganesha-30[main] http_call :CLIENT ID :EVENT :Failed to perform CURL operation: Server returned nothing (no headers, no data)
2023-05-17T15:37:22.648103364+02:00 17/05/2023 13:37:22 : epoch 6464d892 : share-manager-pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c : nfs-ganesha-30[main] longhorn_recov_init :CLIENT ID :FATAL :HTTP call error: res=-1 ((null))

It seems that the nfs server cannot talk to the longhorn-recovery-backend service. Can you detach the RWX volume and attach it again?

I am not sure how do I detach/reatach but scaling rhe deployment to 0 ensuring the workload pod is deleted and scaling back to 1 does not resolv the issue

I am not sure how do I detach/reatach but scaling rhe deployment to 0 ensuring the workload pod is deleted and scaling back to 1 does not resolv the issue

Can you scale down and scale up again, and provide us with the latest support bundle if the error remains? Thank you.

I scaled down the deployment to 0, waited for the pod to be deleted and scaled back to 1, issue is still there
supportbundle_5324d387-a423-4a96-97f6-096e80634490_2023-05-19T14-51-31Z.zip
I can confirm that other rwx volume are working fine

an update: the volume was trying to be mounted on node2 so I cordoned node2 to check if the issue existed on another node. and when trying to be mounted on node 3 issues still exist.
Bad news: while doing so I lost the replica on node2.  I tried to mount it in maintenance mode on node1 and now  the volume loop continuously between attaching then detaching, and is faulted. I attached a new support bundled if it can help
supportbundle_5324d387-a423-4a96-97f6-096e80634490_2023-05-19T19-03-01Z.zip

upgrading to longhorn 1.4.2 does not solve the issue.

@viknet365
Can you scale the workload of the problematic volume to 0, delete the configmap recovery-backend-share-manager-pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c by manual, and scale up the workload?
kubectl  -n longhorn-system delete configmap recovery-backend-share-manager-pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c
The data of the share-manager configmap is somehow missing. We need to improve the resilience.
2023-05-19T17:01:07.945944249+02:00 time="2023-05-19T15:01:07Z" level=info msg="Creating a recovery backend share-manager-pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c (version TJXAIAVR)"
2023-05-19T17:01:07.964126106+02:00 2023/05/19 15:01:07 http: panic serving <IP_ADDRESS>:46514: assignment to entry in nil map
2023-05-19T17:01:07.964147633+02:00 goroutine 178611 [running]:
2023-05-19T17:01:07.964152197+02:00 net/http.(*conn).serve.func1()
2023-05-19T17:01:07.964156043+02:00 	/usr/local/go/src/net/http/server.go:1802 +0xb9
2023-05-19T17:01:07.964159553+02:00 panic({0x1d805a0, 0x2340280})
2023-05-19T17:01:07.964163141+02:00 	/usr/local/go/src/runtime/panic.go:1047 +0x266
2023-05-19T17:01:07.964167178+02:00 github.com/longhorn/longhorn-manager/recovery_backend/backend.(*RecoveryBackend).CreateConfigMap(0xc001a8b098, {0xc0017e2640, 0x36}, {0xc00236ea88, 0x8})
2023-05-19T17:01:07.964170697+02:00 	/go/src/github.com/longhorn/longhorn-manager/recovery_backend/backend/configmap.go:67 +0x199
2023-05-19T17:01:07.964174161+02:00 github.com/longhorn/longhorn-manager/recovery_backend/server.(*RecoveryBackendServer).Create(0xc00000fc40, {0xc001d305d0, 0xc002d41c00}, 0xedbf98633)
2023-05-19T17:01:07.964178023+02:00 	/go/src/github.com/longhorn/longhorn-manager/recovery_backend/server/recovery_backend.go:24 +0x1ae
2023-05-19T17:01:07.964181473+02:00 github.com/longhorn/longhorn-manager/api.HandleError.func1({0x2386340, 0xc00131e2a0}, 0x2386340)
2023-05-19T17:01:07.964185054+02:00 	/go/src/github.com/longhorn/longhorn-manager/api/router.go:18 +0x30
2023-05-19T17:01:07.964188479+02:00 net/http.HandlerFunc.ServeHTTP(0x2386340, {0x2386340, 0xc00131e2a0}, 0xc0000b3800)
2023-05-19T17:01:07.964191908+02:00 	/usr/local/go/src/net/http/server.go:2047 +0x2f
2023-05-19T17:01:07.964195347+02:00 github.com/rancher/go-rancher/api.ApiHandler.func1({0x2386340, 0xc00131e2a0}, 0x90)
2023-05-19T17:01:07.964198779+02:00 	/go/src/github.com/longhorn/longhorn-manager/vendor/github.com/rancher/go-rancher/api/handler.go:27 +0xcd
2023-05-19T17:01:07.964202198+02:00 net/http.HandlerFunc.ServeHTTP(0xc0008f4988, {0x2386340, 0xc00131e2a0}, 0xc001d30510)
2023-05-19T17:01:07.964205596+02:00 	/usr/local/go/src/net/http/server.go:2047 +0x2f
2023-05-19T17:01:07.964209049+02:00 github.com/gorilla/context.ClearHandler.func1({0x2386340, 0xc00131e2a0}, 0xc001d30540)
2023-05-19T17:01:07.964212530+02:00 	/go/src/github.com/longhorn/longhorn-manager/vendor/github.com/gorilla/context/context.go:141 +0x73
2023-05-19T17:01:07.964216027+02:00 net/http.HandlerFunc.ServeHTTP(0xc002d41b00, {0x2386340, 0xc00131e2a0}, 0xc0008f49f8)
2023-05-19T17:01:07.964219458+02:00 	/usr/local/go/src/net/http/server.go:2047 +0x2f
2023-05-19T17:01:07.964234726+02:00 github.com/gorilla/mux.(*Router).ServeHTTP(0xc00082e000, {0x2386340, 0xc00131e2a0}, 0xc002d41a00)
2023-05-19T17:01:07.964238438+02:00 	/go/src/github.com/longhorn/longhorn-manager/vendor/github.com/gorilla/mux/mux.go:210 +0x1cf
2023-05-19T17:01:07.964241851+02:00 net/http.serverHandler.ServeHTTP({0x2374c00}, {0x2386340, 0xc00131e2a0}, 0xc002d41a00)
2023-05-19T17:01:07.964245468+02:00 	/usr/local/go/src/net/http/server.go:2879 +0x43b
2023-05-19T17:01:07.964248898+02:00 net/http.(*conn).serve(0xc00051d400, {0x2392cb8, 0xc000c0e240})
2023-05-19T17:01:07.964252374+02:00 	/usr/local/go/src/net/http/server.go:1930 +0xb08
2023-05-19T17:01:07.964255795+02:00 created by net/http.(*Server).Serve
2023-05-19T17:01:07.964259344+02:00 	/usr/local/go/src/net/http/server.go:3034 +0x4e8

I can't : I am now stuck in detaching/reattaching state after trying to manually attach to a node in maintenance mode
deleting the configmap recovery-backend-share-manager-pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c did no change anything

Weird...
If the configmap is deleted, a new configmap should be created and run into the error assignment to entry in nil map.
func (rb *RecoveryBackend) CreateConfigMap(hostname, version string) error {
	configMapName := types.GetConfigMapNameFromHostname(hostname)
	cm, err := rb.newConfigMap(rb.Namespace, configMapName, version, hostname)
	if err != nil {
		return err
	}

	if _, err := rb.Datastore.CreateConfigMap(cm); err != nil {
		if !apierrors.IsAlreadyExists(err) {
			return errors.Wrapf(err, "failed to create a configmap %v", configMapName)
		}

		cm, err := rb.Datastore.GetConfigMapWithoutCache(rb.Namespace, configMapName)
		if err != nil {
			return errors.Wrapf(err, "failed to get the configmap %v", configMapName)
		}

		cm.Data[version] = "{}"
		if _, err = rb.Datastore.UpdateConfigMap(cm); err != nil {
			return errors.Wrapf(err, "failed to update the configmap %v", configMapName)
		}
	}

	return nil
}

I can't : I am now stuck in detaching/reattaching state after trying to manually attach to a node in maintenance mode deleting the configmap recovery-backend-share-manager-pvc-e4b378af-2775-4a9b-be65-5b8c08c3770c did no change anything

Can you provide a support bundle again after deleting the configmap? Thank you.

sorry my mistake: I did not scale up the deployment because the volume was stuck detaching/reattaching: but if I do with the configmap deleted, it solve the issue.
thanks

@derekbit I'm not sure how to verify this ticket. Delete the config map or remove the content of the config map? Should we need to scale down/up the workload? Can you help to elaborate more? Thank you!

@derekbit I'm not sure how to verify this ticket. Delete the config map or remove the content of the config map? Should we need to scale down/up the workload? Can you help to elaborate more? Thank you!

Yes, you can try the steps to reproduce.

Yes, you can try the steps to reproduce.

@derekbit After the config map deleted or the content of the config map removed, it won't be re-generated or recovered automatically. Does it need manually scaling down/up to get the correct config map?

Does it need manually scaling down/up to get the correct config map?
Yes, can you try it?

Verified passed on master-head (longhorn-manager 705e770) following the test steps:

Create RWX statefulset
Delete the config map or remove the content of the config map
Scale down/up the workload, the config map can be recovered


NodeResizer doesn't trigger a re-render for memoized custom nodes

Describe the Bug
The default NodeResizer is not triggering a node re-render for a memoized custom node, but only on the bottom-right corner.  I assume this has something to do with top/left not updating for any size changes from the bottom right.  This affects custom graphics elements like SVGs which do not updated because the base node element is not re-rendered.
Your Example Website or App
https://codesandbox.io/p/sandbox/fancy-cloud-fqqqp9
Steps to Reproduce the Bug or Issue

Go to attached codesandbox
Open console
Resize custom node using bottom-right resize handle
Note no console log
Resize custom node using any other resize handle

Expected behavior
As a user I expect the custom node to be re-rendered for all resize handles when following the recommended pattern of memoizing custom nodes.  This will allow me to update SVG shapes within the node without handling events myself.
Screenshots or Videos
https://github.com/xyflow/xyflow/assets/18201458/ea37bc30-098c-44f8-9b27-699c8cc372ee
Platform

OS: Windows
Browser: Chrome, Firefox, Edge
Version: 120.0.6099.110, 120.0.1, 120.0.2210.77

Additional context
We have a pro membership through another developer during our PoC phase.  DM for details if required.

This is meant to be a feature 😅 But I understand that it wasn't a good idea and we will probably change it with the next major release. The reason for this is that we don't pass the dimensions to the custom node to safe a re-render when nodes are getting initialized.
You can easily ~fix it on your end by getting the node dimensions from the store https://codesandbox.io/p/sandbox/young-meadow-f5spz5?file=%2FCustomResizerNode.js%3A10%2C1-14%2C1


restoring old/new layout

Restoring redesigned layout from 2016/2017 which was lost.

Zak -- just saw this pull-request... sorry I missed it. But I'm going to close it and instead ask that you submit pull-requests to the 'dev' branch. That way, I can accept them, release them onto the dev-server, have Elli take a look, and if they're ok, then I'll update the master branch and deploy to production.


⚠ Redacted has degraded performance

In 4bb061f, Redacted ($RED) experienced degraded performance:

HTTP code: 200
Response time: 11445 ms

Resolved: Redacted performance has improved in e09ac9b after 10 minutes.


Milestone 1: Math Magician Project Setup

Hi Reviewer 👋

Here are the changes I implemented

Set up a React app.
Used React documentation.
Configured proper linter configuration for react app.
Made sure that I used the correct Gitflows.

@Strangeal  Thank you very much for the review!


README: how to submit patches

Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

waiting for #580 to merge this :)


Outer layer of hands and body not only head

What the title says, it just doesnt show the outer layer on body except heads.

The hat layer only applies to the full body since 1.8. So this is simply not supported by the game.

But this is a mod, it changes the game, y not add a support for that?

I am not interested in adding features that where not there during beta. Feel free to fork though.

Kk, idk how to code in java tho, but if ill learn, ill fork it


Add option to import sqlite database files

Currently we already have an option to import CSV file. We should also include ".db" files since older versions of the app were exporting the databases in that format.

I think this was already implemented. In any case, it no longer seem any useful nowadays. So I'm just closing this issue.


adds an analysis prefix generator

Proposal - adds a Dataset method for generating -analysis bucket paths

LGTM but I will leave to @vladsavelyev


Build Error: C++ compilation of rule '@com_github_grpc_grpc//:grpc_plugin_support' failed (Exit 1)

Describe the bug
There is a build error while building grpc_plugin_support.
To Reproduce
Steps to reproduce the behavior:

Run ./apollo.sh build

Expected behavior
Build succeeded
Screenshots

Desktop (please complete the following information):

OS: [Ubuntu 18.04]
Apollo: e2f94a1

After commit f4e7d40 this error seems to be fixed. Can i close issue now?

Thanks @ShepelIlya for confirming. I am currently closing this issue.

I had the excat same Issue and after deleting .cache/bazel folder and clean -> build Apollo again it worked.


Make the code visualizable

Hello,
For helping people to write slang syntax, it could be nice to implement a visual of all instruments and his notes.
Why not a graphical builder too ?

Great ideas! There are some hooks in the code that could help to both display the current instruments and visualize their audio output.

Great idea! but it will be a little hard for me to read the document without the knowledge of the music. Considering the audience, can you improve more document 😹?

Wow ;D this is cool

I can create an interface if you want. You wish? ;D

Okay; D
I'm thinking of something like that:
https://codepen.io/hans/pen/tKDGo with this https://codepen.io/Onfe/pen/zmvmRJ
What do you think? It would be nice

A new repository or  this repositor? What would be best?

Not quite sure what you're suggesting, but you should definitely fork the repo and try this stuff out!


Tracking Issues: Add support of RediSearch

RediSearch is a Redis module that provides querying, secondary indexing, and full-text search for Redis.
If Kvrocks supports RediSearch, it will offer users a range of powerful features with significant potential applications. This will enable Kvrocks to have query capabilities that are comparable to those of relational databases.
Also, RediSearch is the foundation of the vector search feature. To enable vector search, Kvrocks must first possess the framework and fundamental capabilities of RediSearch.
We believe that RediSearch represents the current direction of development.
To support RediSearch, we need to:

design the encoding of various types of indexing,
indexing construction, indexed key monitoring,
redis query syntax, SQL syntax supporting,
query plan generator, optimizer, executor,
vector indexing and querying

Index types to be supported:

tag
numeric
TBD

vector
text
geo

Task breakdown:

[x] #2065
[ ] #2070
[ ] #2071
[ ] ...

Hey, does kvrocks support RedisSearch as a module, or does it just include RedisSearch functionality directly?


added hacker news site

Screenshots

Note to reviewers
added hacker news site

hey @rupali-codes can you review my PR


[BUG]:- Fixed the mobile view

fixes #53
Description:- The mobile version of the app was messed up, so I fixed it at every different level of screen size.
Screenshots:-

which one?

@mohit-bhandari45 for width 988px

from from 1470 to 999 ui is broken.

Actually it is breaking due to height

actually some screen sizes doesn't exist, but this is responsive for most of the screen

fine !


Fixed migration issue renameColumn is failed when there is foreign key reference in another table

link to issue tgriesser/knex/issues/889

Thanks @taurencoder. Nice work.


unable to get the wmi_cpu_time_total value

when i'm running http://localhost:5000/metrics
i am not getting values for wmi_cpu_time_total

Hi @Vitthal4288264,
Could you elaborate a bit more? How are you running the exporter? Do you get any other metrics than wmi_cpu_time_total?

Hi @carlpett
attached the file for the list of metrics which I am getting
list of metrics.txt

It seems the cpu collector, and additionally the process and logical_disk collectors, fails (wmi_exporter_collector_success{collector="cpu"} 0). There should be something logged in the Windows Event Viewer that shows the error message.
One question though - why are you using the 32-bit version of the exporter? From the list of services running, you seem to be running on Windows 10 or 2016, which as far as I know are only available in 64-bit? Not sure if this could cause this type of issue.

Even if I am running 64bit exporter I am getting the same result

Ok, please check in the event viewer what errors are reported.

I am sorry where can get event viewer.

It is built into Windows. You can for example start it via the Run dialog with eventwvr.

Ya got it .
Most of them "Exception occurred : invalid class"
failed collecting iis  metrics: Exception occurred. Invalid class
Even CPU also failed

Get-WmiObject : Invalid class "Win32_PerfRawData_PerfOS_Processor"
At line:1 char:1

Get-WmiObject Win32_PerfRawData_PerfOS_Processor

Ok, this would indicate that your local WMI setup is broken (this seems to happen sometimes without clear explanation). Try running lodctr /r.

Closing for lack of activity, if it is still a problem, we can reopen.

This appears to still be an issue for the IIS stats. All other metrics report in my case except for IIS.
Running the Get-WMIObject yields results.  In the event log for IIS I was getting:
failed collecting iis metrics: Exception occurred. (Invalid class )
collector iis failed after 0.444111s: Exception occurred. (Invalid class )
after running lodctr /r I am now getting:
failed collecting iis metrics: WMI query returned empty result set
collector iis failed after 0.550491s: WMI query returned empty result set
If there is other information I can provide that might shed some light on this I am happy to oblige

Sorry @jeremy-balmos, I missed this! If you are still having issues, please open a new issue, since it seems slightly different.


[Docs] MelBands + BufMelBands Translation

As the title suggests.

this is great and thorought and sounds amazing!


label: add support for pango markup and justification

this adds ability to use Pango markup in label text
also adds justify config key, defaulting to center
it aligns multi-line text in label container, the label itself still aligned with width and height
other options are:

fill
right
left

font icons are rendered much better than PNG or SVG, besides, it is possible to add some css stuff to text like shadows
https://github.com/AMNatty/wleave/assets/130279855/d0d0211e-f128-4c34-972a-62d6400c000d

The changes look good and don't break default behavior, so I'll merge it, thank you

Battle with GitHub not considering it merged :sweat_smile:


druid格式化Mysql的查询语句会自动去除()，导致无法执行

dbtype:  MYSQL
dbversion:  5.7.42
druid verion: 1.2.22
error sql:
testcase code:
public static void main(String[] args) throws JSQLParserException {
        String sql = "SELECT a.aab001, COUNT(DISTINCT a.aac001) AS 住院人数, SUM(a.bka030) AS 住院天数\n" +
                "\t, SUM((\n" +
                "\t\tSELECT SUM(b.aae019)\n" +
                "\t\tFROM kc27 b\n" +
                "\t\tWHERE b.aaa157 IN ('350100','350300','350806')\n" +
                "\t\t\tAND a.AKB020 = b.AKB020\n" +
                "\t        AND a.AAZ217 = b.AAZ217\n" +
                "\t        AND b.AAE100 = '1'\n" +
                "\t)) AS '住院记账医疗费用'\n" +
                "FROM kc21 a\n" +
                "WHERE a.aae100 = '1'\n" +
                "\tAND a.aka130 = '62'\n" +
                "\tAND a.BAA027 = '440111'\n" +
                "\tAND a.AKC194 >= DATE_FORMAT('20240401', '%Y-%m-%d %T')\n" +
                "\tAND a.AKC194 <  DATE_FORMAT('20240501', '%Y-%m-%d %T')\n" +
                "\tGROUP BY a.aab001;";

        SQLStatementParser parser = new SQLStatementParser(sql, DbType.mysql);
        List<SQLStatement> statementList = parser.parseStatementList();
        for (SQLStatement statement : statementList) {
            System.out.println(statement.toString());
        }

    }

输出结果:
SELECT a.aab001, COUNT(DISTINCT a.aac001) AS 住院人数, SUM(a.bka030) AS 住院天数
	, SUM(
		SELECT SUM(b.aae019)
		FROM kc27 b
		WHERE b.aaa157 IN ('350100', '350300', '350806')
			AND a.AKB020 = b.AKB020
			AND a.AAZ217 = b.AAZ217
			AND b.AAE100 = '1'
	) AS "住院记账医疗费用"
FROM kc21 a
WHERE a.aae100 = '1'
	AND a.aka130 = '62'
	AND a.BAA027 = '440111'
	AND a.AKC194 >= DATE_FORMAT('20240401', '%Y-%m-%d %T')
	AND a.AKC194 < DATE_FORMAT('20240501', '%Y-%m-%d %T')
GROUP BY a.aab001;

error info:
原本的能执行的SQL:
SELECT a.aab001, COUNT(DISTINCT a.aac001) AS 住院人数, SUM(a.bka030) AS 住院天数
	, SUM((    <!--这里有 (括号，格式化之后就没了-->
		SELECT SUM(b.aae019)
		FROM kc27 b
		WHERE b.aaa157 IN ('350100', '350300', '350806')
			AND a.AKB020 = b.AKB020
			AND a.AAZ217 = b.AAZ217
			AND b.AAE100 = '1'
       <!--这个后面也有)括号，格式化之后就没了-->
	)) AS "住院记账医疗费用"
FROM kc21 a
WHERE a.aae100 = '1'
	AND a.aka130 = '62'
	AND a.BAA027 = '440111'
	AND a.AKC194 >= DATE_FORMAT('20240401', '%Y-%m-%d %T')
	AND a.AKC194 < DATE_FORMAT('20240501', '%Y-%m-%d %T')
GROUP BY a.aab001;

转换之后的SQL:
SELECT a.aab001, COUNT(DISTINCT a.aac001) AS 住院人数, SUM(a.bka030) AS 住院天数
	, SUM(
		SELECT SUM(b.aae019)
		FROM kc27 b
		WHERE b.aaa157 IN ('350100', '350300', '350806')
			AND a.AKB020 = b.AKB020
			AND a.AAZ217 = b.AAZ217
			AND b.AAE100 = '1'
	) AS "住院记账医疗费用"
FROM kc21 a
WHERE a.aae100 = '1'
	AND a.aka130 = '62'
	AND a.BAA027 = '440111'
	AND a.AKC194 >= DATE_FORMAT('20240401', '%Y-%m-%d %T')
	AND a.AKC194 < DATE_FORMAT('20240501', '%Y-%m-%d %T')
GROUP BY a.aab001;

执行转换后的SQL报错：
错误代码： 1064
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'SELECT sum(b.aae019)
		FROM kc27 b
		WHERE b.aaa157 in ('350100','350300','350' at line 3

加这个双层括号的支持会影响30多个测试用例，等这几天1.2.23发布之后，我再优化支持

加这个双层括号的支持会影响30多个测试用例，等这几天1.2.23发布之后，我再优化支持


feat(alerting): Persist triggered alerts across application restart

Summary

Fixes #679
Checklist

[X] Tested and/or added tests to validate that the changes work as intended, if applicable.
[ ] Updated documentation in README.md, if applicable.

Codecov Report
Attention: Patch coverage is 64.28571% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 80.14%. Comparing base (9d151fc) to head (bd841a0).

Files
Patch %
Lines

storage/store/sql/sql.go
65.47%
22 Missing and 7 partials :warning:

storage/store/memory/memory.go
0.00%
8 Missing :warning:

watchdog/alerting.go
50.00%
3 Missing and 3 partials :warning:

storage/store/sql/specific_sqlite.go
83.33%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   80.56%   80.14%   -0.42%
==========================================
  Files          64       64
  Lines        4249     4357     +108
==========================================
+ Hits         3423     3492      +69
- Misses        627      655      +28
- Partials      199      210      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@TwiN  I tried you PR since I was trying to look at this feature myself. When I restart gatus for the second time I re-receive all the OK notification.  The KO ones seems fine.

@LCerebo Much appreciated! Due to the nature of the change, I will probably let it sit in latest for a few weeks in case somebody reports an issue with it.


feat(semantic): node -> symbol lookup

Currently there's no method for look up a symbol from a BindingIdentifier / IdentifierReference inside the linter.
The minifier also need this for the printer to print mangled names.
One possible solution is to create an index for a Span -> SymbolId lookup.
I wonder we should make an overhaul on the Symbol Table. I had no idea what I was doing when I wrote the symbol table, and I wrote whatever is sensible.

When working on #247 I found that the extra hashing steps make the semantic builder 10x slower. Is it an option to remove the hashing altogether and store an additional SymbolIdwith BindingIdentifier and ReferenceId with IdentifierReference?


bug: jenkins test executors tied up waiting for previous jobs to finish

If multiple executions of the test-ec2 job-- let's call them A and B-- are running concurrently and A starts before B, but B finishes before A, then job B hangs on the Slack notification step while waiting on a "checkpoint" from job A.
The negative implication of this is that executors can be tied up for a long time when they could be actively testing something instead.
Example (from job 2501):
Slack Notifications is waiting for a checkpoint on test-ec2 #2500

Possible references to this issue:
https://issues.jenkins-ci.org/browse/JENKINS-29696
https://issues.jenkins-ci.org/browse/JENKINS-9913

This should be fixed in a future version of the Slack notifier plugin for Jenkins: see jenkinsci/slack-plugin#121

The Slack notification plugin for Jenkins can't be updated until someone can write a data migration for it as mentioned in jenkinsci/slack-plugin#106. I built and pinned a local version of the v1.8 plugin with jenkinsci/slack-plugin#122 added, so hopefully this fixes the issue for Deis CI until a new plugin is released.

This was fixed in the Slack plugin itself, so my local-hack version isn't needed, and jobs won't serialize on Slack notifications any more. :rabbit2: