Question on building the AuthenticatorSelectionCriteria

https://github.com/googlecodelabs/fido2-codelab/blob/ac04b3e8d29a1c6f77ce8aea99b5fe943bf68f4d/android/app/src/main/java/com/example/android/fido2/api/AuthApi.kt#L369
When preparing the AuthenticatorSelectionCriteria (https://developers.google.com/android/reference/com/google/android/gms/fido/fido2/api/common/AuthenticatorSelectionCriteria) using the Builder (https://developers.google.com/android/reference/com/google/android/gms/fido/fido2/api/common/AuthenticatorSelectionCriteria.Builder), the builder does not allow to set the requireResidentKey and userVerification which defined in the spec
https://www.w3.org/TR/webauthn/#dom-authenticatorselectioncriteria-requireresidentkey, is there a reason for that?

I don't think skipping those values mean much.
@yaraki any particular reasons?

The residentkey provides a username-less experience. When setting the requireResidentKey to true, will direct the authenticator to create a new resident credential for short. With resident credentials, the authenticator is able to select the appropriate credential private key based on the relying party ID.

Resident keys are not supported on Android yet anyway.

Do you know if Google plans to support it, any channel that I can ask about it?

Yes, we plan to support it, but can't tell when.

Thanks for the information.

@agektmr I know this thread is old, but I'm running into the same issue as @witrisna . Are there any solutions that have come up since this thread? I'm in dire need of saving some kind of information with the authenticator to allow the usernameless flow. My app is completely clientside and saving username/id information is critical.

@mreedr did you figure out a solution here?

Is there any progress? Google is one of first who implemented FIDO and now we are waiting years to get "passwordless" sign in on Android... It's totaly inconsistent as of now, I am disappointed.
There is even not proper dark theme on selection of type of HW key (USB/NFC/BT..). black font on dark background, outdated UI.

You can already use the resident key (discoverable credential) in Android. To try that I recommend you check out https://codelabs.developers.google.com/credential-manager-api-for-android .
This codelab is outdated. We are considering revising it but no specific timeline.

You can already use the resident key (discoverable credential) in Android. To try that I recommend you check out https://codelabs.developers.google.com/credential-manager-api-for-android .
This codelab is outdated. We are considering revising it but no specific timeline.

Sure but I am not able to use chrome with yubikey and resident keys yet. even other apps don't support resident keys. I am not developer of android apps but I see there is some API that should be used within apps? Why is it not yet working with android when there's support for it?

Unfortunately, roaming authenticators with resident keys are not supported yet in Android. We are working on it.

Is there some ETA?


PFA: Getting this error when clicked on login button.

npx prisma generate with properly set .env file should do the trick

Getting this error now @pospile

Error is pretty self explanatory. Missing env variable with postmark api key. Sign up and obtain a key.

I'm getting a callback error when trying to authenticate using github on localhost. My github oauth app callback url is currently set to http://localhost:3000/api/auth/callback/github. Wondering if anyone has experienced this?

@theDheerajjha were you able to solve this? Did you create a Postmark API key ?


Added web.config file to support IIS URLrewrite (like the .htaccess)

Reference: https://framework.zend.com/manual/1.12/en/project-structure.rewrite.html
Discussion: https://groups.google.com/a/zend.com/d/msg/apigility-users/YyDKXKRM8do/UxzqftzdCAAJ
Signed-off-by: Chisomo Sakala<EMAIL_ADDRESS>

Useful for IIS users, thanks @Makombo!


Typo in the folder name fixed

What type of PR is this?
/kind bug
What this PR does / why we need it:
A typo in the folder name in the Dockerfile.openshift is fixed.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Release note:
none

@mkumatag can you review this?


Is it possible to build caffe-fast-rcnn without GPU?

I'm getting make errors when I run 'make all'.

You should be able to build it with the right changes in your makefile. Please refer to caffe for that...

Hi!
In makefile.config, I have already set the CPU_ONLY mode to 1 and WITH_PYTHON_LAYER to 1 as well. But still I am getting the following error when I run make all.
`CXX src/caffe/layers/sigmoid_layer.cpp
In file included from ./include/caffe/common.hpp:19:0,
from ./include/caffe/blob.hpp:8,
from ./include/caffe/layer.hpp:8,
from src/caffe/layers/sigmoid_cross_entropy_weighted_loss_layer.cpp:5:
./include/caffe/util/device_alternate.hpp:30:39: error: no ‘void caffe::SigmoidCrossEntropyWeightedLossLayer::Backward_gpu(const std::vector<caffe::Blob>&, const std::vector&, const std::vector<caffe::Blob>&)’ member function declared in class ‘caffe::SigmoidCrossEntropyWeightedLossLayer’
const vector<Blob>& bottom) { NO_GPU; }
^
src/caffe/layers/sigmoid_cross_entropy_weighted_loss_layer.cpp:87:1: note: in expansion of macro ‘STUB_GPU_BACKWARD’
STUB_GPU_BACKWARD(SigmoidCrossEntropyWeightedLossLayer, Backward);
^
make: *** [.build_release/src/caffe/layers/sigmoid_cross_entropy_weighted_loss_layer.o] Error 1
make: *** Waiting for unfinished jobs....
src/caffe/layers/mil_layer.cpp: In instantiation of ‘void caffe::MILLayer::Forward_cpu(const std::vector<caffe::Blob>&, const std::vector<caffe::Blob>&) [with Dtype = float]’:
src/caffe/layers/mil_layer.cpp:85:1:   required from here
src/caffe/layers/mil_layer.cpp:48:19: warning: unused variable ‘max_prob’ [-Wunused-variable]
Dtype prob, max_prob;
^
src/caffe/layers/mil_layer.cpp: In instantiation of ‘void caffe::MILLayer::Forward_cpu(const std::vector<caffe::Blob>&, const std::vector<caffe::Blob*>&) [with Dtype = double]’:
src/caffe/layers/mil_layer.cpp:85:1:   required from here
src/caffe/layers/mil_layer.cpp:48:19: warning: unused variable ‘max_prob’ [-Wunused-variable]`
I am already following all the instructions in Caffe's website. So, it would be great if you could help me with this issue.
TIA

I'm getting the same problem when trying make in CPU mode !

In src/caffe/layers/sigmoid_cross_entropy_weighted_loss_layer.cpp try removing lines:
#ifdef CPU_ONLY
STUB_GPU_BACKWARD(SigmoidCrossEntropyWeightedLossLayer, Backward);
#endif


InlineFirehose does not work with index_parallel ingestion

In Druid 0.16.0
As the title says, if you try to submit a task like:
{
  "type": "index_parallel",
  "spec": {
    "type": "index_parallel",
    "ioConfig": {
      "type": "index_parallel",
      "firehose": {
        "type": "inline",
        "data": "{\"name\":\"Vadim\"}"
      }
    },
    "tuningConfig": {
      "type": "index_parallel"
    },
    "dataSchema": {
      "dataSource": "some_data",
      "granularitySpec": {
        "type": "uniform",
        "queryGranularity": "HOUR",
        "rollup": true,
        "segmentGranularity": "DAY"
      },
      "parser": {
        "type": "string",
        "parseSpec": {
          "format": "json",
          "timestampSpec": {
            "column": "!!!_no_such_column_!!!",
            "missingValue": "2010-01-01T00:00:00Z"
          },
          "dimensionsSpec": {
            "dimensions": [
              "name"
            ]
          }
        }
      },
      "metricsSpec": [
        {
          "name": "count",
          "type": "count"
        }
      ]
    }
  }
}

You get an error of:
{"error":"Instantiation of [simple type, class org.apache.druid.indexing.common.task.batch.parallel.ParallelIndexSupervisorTask] value failed: [InlineFirehoseFactory] should implement FiniteFirehoseFactory"}

However changing the ingestion to just index:
{
  "type": "index",
  "spec": {
    "type": "index",
    "ioConfig": {
      "type": "index",
      "firehose": {
        "type": "inline",
        "data": "{\"name\":\"Vadim\"}"
      }
    },
    "tuningConfig": {
      "type": "index"
    },
    "dataSchema": {
      "dataSource": "some_data",
      "granularitySpec": {
        "type": "uniform",
        "queryGranularity": "HOUR",
        "rollup": true,
        "segmentGranularity": "DAY"
      },
      "parser": {
        "type": "string",
        "parseSpec": {
          "format": "json",
          "timestampSpec": {
            "column": "!!!_no_such_column_!!!",
            "missingValue": "2010-01-01T00:00:00Z"
          },
          "dimensionsSpec": {
            "dimensions": [
              "name"
            ]
          }
        }
      },
      "metricsSpec": [
        {
          "name": "count",
          "type": "count"
        }
      ]
    }
  }
}

Makes it all work

To work with parallel indexing, one possibility is to modifyInlineFirehose to implement FiniteFirehoseFactory so that it is splittable and always returns 1 split (that contains the entire contents).

I was writing about the same comment with @ccaominh. InlineFirehose could implement FiniteFirehoseFactory but it should always run in the sequential mode.

If this gets fixed, is it possible to fix these cryptic messages that are
sent out? I assume it's because of Jackson deserialization exceptions being
regurgitated to the user?
On Mon, Oct 14, 2019 at 8:53 PM Jihoon Son<EMAIL_ADDRESS>wrote:

I was writing about the same comment with @ccaominh
https://github.com/ccaominh. InlineFirehose could implement
FiniteFirehoseFactory but it should always run in the sequential mode.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-druid/issues/8673?email_source=notifications&email_token=AAPSYCRI3DMSFMEPLPPWR4DQOU5DRA5CNFSM4JAWTAT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBHKGOQ#issuecomment-542024506,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPSYCV6EA3XXBLRKGW5PCTQOU5DRANCNFSM4JAWTATQ
.

--
Jad Naous
Imply | VP R&D
650-521-3425
<EMAIL_ADDRESS>


Fixed search not working issue on SODA Documentation

What type of PR is this?
/kind bug fix
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #257
Test Report Added?:
/kind TESTED
Test Report:
Special notes for your reviewer:

@skdwriting Seems like this fixes the broken search. Tested with the deploy preview.


Generate API docs for sky_services

We no longer publish/push sky_services to pub.dartlang.org. Therefore, we need to start generating and hosting API docs for sky_services.
Once we have this, I can link to it from our Services doc page.

@devoncarew is this something you can add to how we generate API docs for docs.flutter.io ? I'm compiling a list of all our services, and I'd like to link to docs for the services that come from sky_services. I'm not actually sure what's in there :) Thanks!

The doc generation is now entirely controlled by this script: https://github.com/flutter/flutter/blob/master/dev/dartdoc.dart#L52
If you pass another --include-external flag in there for sky_services, it should show up as well. You can run the script locally; the results are written to dev/docs/doc/api.

Nice! Trying it now.

Thanks to @devoncarew , I am now using library names and not package names.
Addressed by https://github.com/flutter/flutter/pull/3170

We are now generating docs for the libraries in sky_services.


Interactive Scripting

Description

This PR is an attempt to provide interactivity with napari viewer while scripting as easy as possible. This is a work in progress, please provide feedback to make it better. Main idea is letting API user write a python closure and pass it to viewer.update_viewer() method to create a separate thread without killing the main thread. Hence we can update UI without disrupting Qt event loop.
Type of change

[X] New feature (non-breaking change which adds functionality)
[X] This change requires a documentation update

References

#520 here we discussed about this feature and this is one of the best ways we can provide. Feel free to give feedback and offer different ways.
How has this been tested?

[X] a little example is written to test implementation

Final checklist:

[X] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Hi @jni ! I updated example with arg and kwarg usage. It seems ready to review to me. Please provide feedback.
@sofroniewn i changed method name and right now the API is like viewer.update(). Please provide any other feedback you have.

@sofroniewn I also want to add docstrings before merge. Please wait for that

This indeed needs some docstrings but also some tests!

To reiterate my comments from the meeting, I love this design!

I made couple updates and it is ready for another round of reviews. implemented a test. It passes but not totally happy with the warnings. and i failed black formatting task? :D what. let me check and fix that

Those aborts in the test reminded of a thought I had here.  Since the new QtUpdateUI threads introduce the possibility that a thread may be running when the user quits the program, you might want to clean those up in the qt_main_window closeEvent (otherwise users will see abort errors and segmentation faults upon closing).  Setting a parent Qobject on those QThreads would make finding them easier.

hen the user quit

You are right, but while scripting you won't be seeing anything(see the example i created). That's why API returns thread object to caller. So thread object will not be garbage collected while thread is running.
To make it more clear @tlambert03 , with what i can achieve same functionality in close event of qt_main_window?

You are right, but while scripting you won't be seeing anything

I'm not sure I'm following... are you saying that the intended use case for scripting is such that the user wouldn't ever be able to quit while a script was still running?   Garbage collection of the thread is not the problem I was referring to, but rather this:  If you run your example with ipython --gui=qt instead of using the napari.gui_qt() context manager, and then run exit() while the thread is still running, you'll get this:
In [2]: exit()
WARNING: QThread: Destroyed while thread is still running
Abort trap: 6

One way to prevent that would be to assign all QtUpdateUI threads a parent QObject.  Then, in the closeEvent, you can search that object for all children() of type QtUpdateUI and call their quit() and wait() (or just terminate) methods to gracefully shut down the thread before closing napari.  Being a static method though (and lacking self), I'm not sure how to give the newly created thread a known parent behind the scenes without the end-user being required to provide it (which would be confusing to a lot of people).
Does having it as a static method provide a lot of freedom?  or is it always going to be associated with a viewer in one way or another?  If so, you change update slightly to be:
    def update(self, func, *args, **kwargs):
        t = QtUpdateUI(self.window._qt_window, func, *args, **kwargs)
        t.start()
        return t  # returns thread object as it has to live on calling script

and then add some logic to the qt_main_window.Window.closeEvent() to look through its self._qt_window.children() for QtUpdateUI threads to quit.  Let me know if you want me to make that clearer in comments... or if I'm way off base here and shouldn't worry about it 😄

... Except I just saw that tests are failing... 🤦♂ LOL

Longer term, I wonder whether the same thing can be achieved independently of Qt. I also wonder whether there is some way to ensure that the threads are killed eventually, see e.g. https://vorpus.org/blog/notes-on-structured-concurrency-or-go-statement-considered-harmful/
Right now, it seems that in a long-running IPython session, you could have many "phantom threads" continuously doing work if you forget to kill them... Am I right here?

... Perhaps I should read @tlambert03's helpful comments before providing my own. 😂 What he said! Adding the threads to a viewer and killing them when the viewer is closed seems like the right approach. The viewer then does the job of the "nursery" in the trio blog post.

Right now, it seems that in a long-running IPython session, you could have many "phantom threads" continuously doing work if you forget to kill them... Am I right here?

yeah, more generally: what I really like about this PR is that it's going to allow people to achieve some amount of concurrency without having to know anything about QThreads.  But by giving them the thread handle, we are leaving them responsible for (quitting) it.  We should go the extra mile and take care of that for them

You are right, but while scripting you won't be seeing anything

I'm not sure I'm following... are you saying that the intended use case for scripting is such that the user wouldn't ever be able to quit while a script was still running? Garbage collection of the thread is not the problem I was referring to, but rather this: If you run your example with ipython --gui=qt instead of using the napari.gui_qt() context manager, and then run exit() while the thread is still running, you'll get this:
In [2]: exit()
WARNING: QThread: Destroyed while thread is still running
Abort trap: 6

This is happening fundamentally due to garbage collector when you run exit().

One way to prevent that would be to assign all QtUpdateUI threads a parent QObject. Then, in the closeEvent, you can search that object for all children() of type QtUpdateUI and call their quit() and wait() (or just terminate) methods to gracefully shut down the thread before closing napari. Being a static method though (and lacking self), I'm not sure how to give the newly created thread a known parent behind the scenes without the end-user being required to provide it (which would be confusing to a lot of people).
Does having it as a static method provide a lot of freedom? or is it always going to be associated with a viewer in one way or another? If so, you change update slightly to be:
    def update(self, func, *args, **kwargs):
        t = QtUpdateUI(self.window._qt_window, func, *args, **kwargs)
        t.start()
        return t  # returns thread object as it has to live on calling script

and then add some logic to the qt_main_window.Window.closeEvent() to look through its self._qt_window.children() for QtUpdateUI threads to quit. Let me know if you want me to make that clearer in comments... or if I'm way off base here and shouldn't worry about it 😄

Now i got what you offer better. Thank you for bearing with me and giving detailed reply @tlambert03 :D Being a static method gives a lot of freedom but i liked what you are offering here. Let me update the PR and will ask for another round of review. Thank you too @jni !

one more thing I forgot to add ... in my example above with the modified update function, you would also need to modify the QtUpdateUI as follows:
class QtUpdateUI(QThread):
    def __init__(self, parent, fn, *args, **kwargs):
        super().__init__(parent)
        ...

Updated PR, cleaned API further and NOT returning thread object back to user thanks to QThreadPool. Also instead of subclassing QThread now extending QRunnable class and let QThreadPool create thread accordingly for us. Due to this now our threads are daemon like threads as @royerloic requested.
Unfortunately, i introduced a sleep() call in test. Dropped a comment about what we need to do around view components to get rid of such sleep call.
Looking forward to hear more feedbacks from you guys!

The use of a threadpool is a good move.

Seems everybody okay, i am merging this now. We can continue discussion about QWidget objects lifetime somewhere else.

@AhmetCanSolak thanks for merging, do you want to make a new issue to discuss the QWidget objects lifetime? Also do you mind making a quick PR to remove those commented lines, just keeps things a little cleaner

Commented lines cleaning PR merged and i dropped an issue for discussion here #689 . Thank you @sofroniewn !


Avoid unnecessarty unwwrap of _lastPendingEventTimestamp

Takeover of flutter/flutter/pull/117551
This fixes flutter/flutter/issues/112403 and b/249091367

Avoid unnecessary unwrap of _lastPendingEventTimestamp which sometimes causes "Null check operator used on a null"
Fix formatting again
expose checkStart to tests and verify that null timestamp does not crash

Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.


Google STT does not accept an API key

To use STT, Jasper requires an API key however Google STT only accepts OAuth or Service Account credentials.
Is there still a valid way to use Google STT or would this require a code change to Jasper?

The work on Jasper - specifically making it work as-is and refactoring to Python 3 is being conducted at https://github.com/aplawson/jasper-client -- including a tutorial on how to build it and/or deploy it with a custom Raspbian ISO image. //adam


Django42 cache edit

Summary Change Description
See affected issue(s).
Affected Issues/Pull Requests

Partially addresses #775
Makes some other minor improvements that I happened upon while investigating test slowness

Review Notes
See comments in-line.
Checklist
This pull request will be merged once the following requirements are met.  The
author and/or reviewers should uncheck any unmet requirements:

Review requirements

Minimum approvals: 1
No changes requested
All blocking issues resolved by reviewers
Specific reviewers: none
Review period: 2 days

Associated issue/pull request requirements:

[x] All requirements in affected issues marked "resolved" are satisfied
[x] All required pull requests are merged (or none)

Basic requirements

[x] All linters pass
[x] All tests pass
[ ] All conflicts resolved

Overhead requirements

[x] New/changed method tests implemented/updated (or no change)
[ ] Added changes to Unreleased section of changelog.md
[x] Migrations created & committed (or no change)

Haven't requested review yet. I merged in main and am waiting for tests to pass.  Once I get that pushed out, I will request a review.

Please create a separate PR for the bug fixes and the speed improvements. The bug fixes seems like they are required changes, while I'm not so sure about some of the speed improvements.
I don't think we should skip cache updates in the tests, instead we should make the tests smaller. I'd rather not have the code run differently in the tests than it does in production.

Caching operations aren't removed everywhere.  I left the cache updates operational for tests that test the caching functionality.  I explicitly skip them for tests that will pass/fail regardless of the caching operations, because they just took time and were unnecessary.
All the cache updating does is it deletes cached values associated with linked records.  E.g. if a PeakData record is inserted, many calculations can be affected, so all caches under the associated Animal are deleted.  That operation takes time even though no caches may have yet been created for the associated records - and that could definitely be improved.  In fact, ideally, I'd like to implement a context manager, to handle caching update cessation like I implemented with MaintainedModel, ...
but this was easy/quick, and I mostly was doing it to debug the slowness issue before I learned it was related to postgres 13.  So instead of splitting this up, I'll probably prefer to just delete the skip of caching updates.  It didn't significantly improve running time.  So if you agree, I'll just remove those improvements.

So instead of splitting this up, I'll probably prefer to just delete the skip of caching updates. It didn't significantly improve running time. So if you agree, I'll just remove those improvements.

I think if you remove the caching updates, this will be good to go in my book. 👍🏻

@lparsons - I'm going to open this back up (perhaps a bit prematurely*).  I haven't removed the skipping of caching updates to tests yet*.  I got side-tracked with more improvements to exception handling (or rather, avoiding triggering exceptions [that I was catching] in the first place) based on what I've continued to learn since Django 4.2.
Basically, I pared everything back to not trigger/catch any exceptions, then I put a new one in (ObjectDoesNotExist) because I learned that checking the database is the only reliable way to know whether a model object (e.g. in the buffer) has been deleted or not.  self.pk having a value only tells you whether or not an object once existed in the database.  It doesn't tell you whether or not it currently exists.
Once I removed the exception handling, I discovered one thing that I hadn't realized catching IntegrityError was doing for us WRT UniqueConstraints.  And it explains the test failures that I had commented on (see the deleted comments) but didn't fully understand.  The new immediate mode and some testing in the shell revealed that when autoupdates happen in immediate mode, they go through intermediate state updates.  With Tracer.name, if for example, tracer valine-[13C5] existed and you tried to use get_or_create_tracer for valine-[13C5,15N2], it was creating a tracer with no name, and eventually, when TracerLabel 13C5 was "added", it triggered an intermediate update of the Tracer.name to valine-[13C5] before it would be updated to valine-[13C5,15N2], but that ran afoul of the unique constraint. The catch and ignore of the error was allowing it to proceed to that eventual name.
That instance of that exception was correct, but after eliminating that catch/ignore, you end up with a bad tracer record that existed when the exception was raised.
The (partial) solution (after eliminating the catch) was to apply the @transaction.atomic decorator to get_or_create_tracer (and get_or_create_infusate).  That means, as of this PR, you would get an exception and the infusate would not be created.  BUT - that won't affect us because tracers are only ever created in deferred mode, where that never happens.  I created an issue (#777) to fix it so that immediate mode will either be made to work in this edge case, or it will wrap an exception with a specific exception that suggests applying a deferred mode context manager decorator - which would fully solve the problem.
* At this stopping point, I decided I would check if "remove those changes if you like", meant it's OK to keep the skipping of the cache updates.  Note, I did suppress the help output of the added skip option and I could alternatively write a context manager decorator for select test classes where caching functionality is not being tested (instead of provide it as an option to the load command).

OK @lparsons - take another look.


Detect and log FIPS mode

What this PR does / why we need it:
With this PR the controllers are able to detect and log whether the container is running in FIPS mode or not.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Controllers now detect and log if FIPS mode is enabled.

/cc @stu-gott

With this PR the controllers are able to detect and log whether the container is running in FIPS mode or not.

Could you explain why this PR is needed? I see that you seem to more or less detect if a node uses FIPS, but that does not mean that kubevirt is compiled fips-compatible if I am not mistaken.

/close
After talking with @rmohr about this I decided to close this as it would merely mean that the host is running in FIPS mode but not that KubeVirt itself will run in FIPS mode for a couple of reasons:

Any vendor dependency might be using non-FIPS valid algos
The controller themselves might not be compiled in FIPS-capable way


Fix installer failure

The problem
When creating an installer on image builder, if that request fails, we were not setting the image status with an error.
The solution
Set the error status properly when an error occurs while sending this request, alongside with some refactors on tests to use the new ginko and gomega libraries.

Codecov Report

Merging #352 (1ba4a8b) into main (51f3b84) will decrease coverage by 0.11%.
The diff coverage is 2.17%.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   27.69%   27.58%   -0.12%
==========================================
  Files          30       30
  Lines        2784     2799      +15
==========================================
+ Hits          771      772       +1
- Misses       1929     1943      +14
  Partials       84       84

Impacted Files
Coverage Δ

pkg/clients/imagebuilder/client.go
22.28% <0.00%> (-1.84%)
:arrow_down:

pkg/routes/images.go
25.92% <0.00%> (+1.52%)
:arrow_up:

pkg/services/images.go
3.22% <0.00%> (-0.19%)
:arrow_down:

pkg/services/repobuilder.go
3.55% <100.00%> (+0.57%)
:arrow_up:

pkg/services/updates.go
35.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f3b84...1ba4a8b. Read the comment docs.

/retest

/retest

/retest

/retest


Completion of DoD for 11/26; New m2g release candidate v1.1.2

Overview
Committed here are the following additions/changes to m2g since the last release. This pull request contains what is the recommended pipeline for the next release of m2g, v1.1.2, and has been shown to perform as a reliable, large-scale, and robust pipeline for structural MR connectome generation. Reliability remains paralleled to that of the previous release, though accessibility of the code as well as versatility for computing graphs with downstream inference in mind has been greatly increased. The documentation has been expanded upon to allow users to more easily navigate using and benefiting from m2g.
Functionality

Integrated multi-atlas small graph generation
Integrated list-files
Improved performance on large clusters by resolving unintentional multithreading
Standalone evaluation of pipeline performance
Compliance of derivatives and pipeline output with defined data specification

Organization

Removed unnecessarily workflows/dev pipelines

Documentation

Rearranged tutorials and docs pages
Provided thorough explanation of how to install, run, and analyze pipeline (either all together or each independently)

Data Products

Pushed graphs to MROCP service (approx. 1000)

m2g officially works. Amazing job team and especially @gkiar


job delivered event only works half the time

job.on("delivered") events seems to only works half the time for me, for example:
1st Job -> delivered event emitted
2nd Job -> delivered event not emitted
3rd Job -> delivered event emitted
4th Job -> delivered event not emitted
5th Job -> delivered event emitted
... and so on
Upon investigation, it seems like this is caused by events.job.delivered.active is not being set with the proper value, it's supposed to be false when a job isn't delivered, instead the events.job.delivered.active value seems to be like this:
When taking 1st job -> delivered.active = false
When finished 1st job -> delivered.active is set to true and emits delivered event
When taking 2nd job -> delivered.active is still true and isn't set back to false
When finished 2nd job -> delivered event isn't emitted because delivered.active is true, then delivered.active  being set to false
and 3rd job behaves like when 1st job, and so on

Hi, sorry for the late reply.
Can you try setting the interval option on the watch function to 16ms?
By default it's set to 100ms, meaning it checks the game for changes every 100ms and those events are some times active for less than that.
In a future update this will be changed to match the game.
~16ms should match the game's framerate (60 FPS)
const tst = require("trucksim-telemetry")

const telemetry = tst()

telemetry.job.on("delivered", function(data) {
  // use data
})

telemetry.watch({interval: 16})

Upon farther testing it seems that this is an issue with the plugin itself.
I have submitted an issue there about it.
https://github.com/RenCloud/scs-sdk-plugin/issues/98

Behaviour confirmed to be intentional.
Will try to look into updating the module for it later this week.
https://github.com/RenCloud/scs-sdk-plugin/issues/98#issuecomment-1047065111

This issue should now be resolved
Part from the refuel-paid event, there seems to be an issue with the plugin for that one
https://github.com/kniffen/TruckSim-Telemetry/commit/509c14622c3a376d341d0ba91c1d4bc48f9bb842


typo in Lift example code

🍍

oh I see, but you only talk about it, later in Applicative Functor, maybe changing the order of Lift?

Maybe, though there's been people pushing to alphabetize the page so I
think the definitions should stand on their own if possible
On Tue, Oct 25, 2016, 10:11 AM Luis Silva<EMAIL_ADDRESS>wrote:

oh I see, but you only talk about it, later in Applicative Functor, maybe
changing the order of Lift?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hemanth/functional-programming-jargon/pull/123#issuecomment-256098555,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB-4NhiBaSdz6vx4sPzc-BiE8WzgiiPks5q3jgwgaJpZM4KgDLR
.

I think this definitely needs a comment. It just looks far too much like a typo.

Done


JSONAPIError

Hi,
the jsonapi-serializer also contains a class JSONAPIError which is missing in this library. It could be useful to also port it.
thanks for this library!

You are welcome. Let me take a look at the error class. Thanks for the pointer.


Enhancement: Make sure splunk is running to allow indexer bundle push

When updating apps on the master (app_dest = '/etc/master-apps') we should make sure splunk is running or the 'apply indexer cluster bundle' handler will fail.
in install_apps.yml after the last handler setting (need to make sure handler has a value):
First part is unchanged, just for reference.
- name: "Set default restart splunk handler for all other paths (e.g. etc/auth)"
  set_fact:
    handler: "restart splunk"
  when:
    - app_dest != 'etc/shcluster/apps'
    - app_dest != 'etc/deployment-apps'
    - app_dest != 'etc/master-apps'

- name: make sure splunk is running when handler = apply indexer cluster bundle
  include: splunk_start.yml
  when: handler == "apply indexer cluster bundle"
  run_once: true

I don't think that this should be addressed by our role. One could argue that if Splunk is not running on your cluster master (or any host for that matter), then you probably should not be trying to perform an app deployment to it/push a new bundle. This role was written for production environments, and aside from the check_splunk.yml task (which handles both fresh installs and upgrades), it assumes that you have an operational (i.e. splunkd is running) environment. It may also be undesirable to start a cluster master and then immediately push an indexer cluster bundle to it, since the CM usually needs some time for all of the peers to register and reach the configured target replication factor and search factor.


Release 1.0.0

Does 727a9a760cd5b4219561b417abf6601f52e611ac actually improve anything or is it just a question of taste? I personally prefer the languages/mod.rs version and so does rust 1.29.0.
Applying rustfmt project-wide should always be followed by adding a rustfmt check to CI imo, so that it doesn't diverge again over time (this is assuming that rustfmt is somewhat stable and won't break builds every second week).

Oh, well https://github.com/rust-bitcoin/rust-bip39/commit/727a9a760cd5b4219561b417abf6601f52e611ac made it easy to git checkout src/languages/* after doing cargo fmt because Rust 1.29 also doesn't support adding rustfmt skip tags to the language files.
The language files are also what prevents a CI check mostly. I'd hold off of having a CI check until there's no more manual fiddling required to get things right. Now it was mostly because a bunch of copy-pasted code from other places made for mixed indentation.
I'll take out https://github.com/rust-bitcoin/rust-bip39/commit/727a9a760cd5b4219561b417abf6601f52e611ac.


Add disk encryption

Hi,
It would be nice to add optional encryption/decryption. So only the data which is Written and Read from Disk is encrypted (not the in-memory part).
What do you think?
Best Regards

Thank you for the suggestion. It is an interesting idea, but I have some questions.

Why we should encrypt data only on a disk? I think, it's not very difficult to get the data from RAM too.
Why not to use minio/sio for encryption?

I just think the package go-disk-buffer should have only a single responsibility – storing data on a disk when bytes.Buffer is overflowed

Data in memory is classified as "Data In Use/Transit" https://en.wikipedia.org/wiki/Data_in_use
Data on disk is classified as "Data At Rest" (may needs encryption)
Thats why it would be nice to have a optional encryption function for the "data at rest".
If you for example process alot of mails to the Buffer, most mails are small and doesnt need encryption in memory, but if you store them to disk a encryption is usefull
If memory is not safe i would recommend github.com/awnumar/memguard


Run on real device

Feature Request
Please, review this feature request once again: https://github.com/fastlane/fastlane/issues/1635. The reason why it's needed is that some apps work with the camera which doesn't start on a simulator, but there is a need to take a screenshot of that screen. Thanks!

We are happy to review and merge a Pull Request containing code that makes this possible.

Thanks for the response! I'll keep it in mind.


Pin dependency versions

As of early June 2024, rashdf relies on three major dependencies:

h5py
geopandas
pyarrow

We should figure out what the minimum version numbers of these dependencies should be and set them in pyproject.toml. GeoPandas is probably the most sensitive one.
Pinning dependency versions for tests and docs would be good, too.

Relevant issue with the following file from the Kanawha bucket via @zherbz:
.../sims/ressim/383/ras/LowerKanawha/LowerKanawha.p01.hdf

When rashdf is installed with pandas==2.1.4 and numpy==1.26.0, there's an error extracting mesh cell points.
Python 3.10.14 (main, Apr 18 2024, 16:25:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from src.rashdf import RasPlanHdf
>>> plan_hdf = RasPlanHdf("LowerKanawha.p01.hdf")
>>> plan_hdf.mesh_cell_points()
Traceback (most recent call last):
  File "offsets.pyx", line 4548, in pandas._libs.tslibs.offsets.to_offset
ValueError: invalid literal for int() with base 10: '0.1'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/plan.py", line 719, in mesh_cell_points
    return self._mesh_summary_outputs_gdf(
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/plan.py", line 686, in _mesh_summary_outputs_gdf
    df = self.mesh_summary_output(var, round_to=round_to)
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/plan.py", line 602, in mesh_summary_output
    df = methods_with_times[var](round_to=round_to)
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/plan.py", line 567, in mesh_max_ws_err
    df = self._mesh_summary_output_min_max(
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/plan.py", line 359, in _mesh_summary_output_min_max
    times = self._mesh_summary_output_min_max_times(
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/plan.py", line 323, in _mesh_summary_output_min_max_times
    max_ws_times = ras_timesteps_to_datetimes(
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/utils.py", line 307, in ras_timesteps_to_datetimes
    return [
  File "/home/thomaswilliams/dev/rashdf/src/rashdf/utils.py", line 308, in <listcomp>
    start_time + pd.Timedelta(timestep, unit=time_unit).round(round_to)
  File "timedeltas.pyx", line 1949, in pandas._libs.tslibs.timedeltas.Timedelta.round
  File "timedeltas.pyx", line 1912, in pandas._libs.tslibs.timedeltas.Timedelta._round
  File "offsets.pyx", line 4460, in pandas._libs.tslibs.offsets.to_offset
  File "offsets.pyx", line 4557, in pandas._libs.tslibs.offsets.to_offset
ValueError: Invalid frequency: 0.1 s

Sure enough, Pandas 2.1.x doesn't seem to like non-integer offsets:
>>> pd.tseries.frequencies.to_offset("1s")
<Second>
>>> pd.tseries.frequencies.to_offset("10s")
<10 * Seconds>
>>> pd.tseries.frequencies.to_offset("1.0s")
Traceback (most recent call last):
  File "offsets.pyx", line 4548, in pandas._libs.tslibs.offsets.to_offset
ValueError: invalid literal for int() with base 10: '1.0'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "offsets.pyx", line 4460, in pandas._libs.tslibs.offsets.to_offset
  File "offsets.pyx", line 4557, in pandas._libs.tslibs.offsets.to_offset
ValueError: Invalid frequency: 1.0s
>>> pd.tseries.frequencies.to_offset("0.001s")
Traceback (most recent call last):
  File "offsets.pyx", line 4548, in pandas._libs.tslibs.offsets.to_offset
ValueError: invalid literal for int() with base 10: '0.001'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "offsets.pyx", line 4460, in pandas._libs.tslibs.offsets.to_offset
  File "offsets.pyx", line 4557, in pandas._libs.tslibs.offsets.to_offset
ValueError: Invalid frequency: 0.001s

But things work fine with pandas==2.2.2 and numpy==2.0.0:
>>> pd.tseries.frequencies.to_offset("1.0s")
<Second>
>>> pd.tseries.frequencies.to_offset("0.1s")
<100 * Millis>


storage Explorer issue

Unable to retrieve child resources.
Details:
["Error:connect ENOENT \\?\pipe\51fe928aee3946a0ada30c54055ff8f3"]

@sudhaguda
Can you give us some more info like:

What OS are you on?
What version of Storage Explorer are you using?
At what point in the tree did you get this error message? Expanding a subscription, Storage Account, Blob Containers?

Closing due to lack of response. Please open a new issue if you are still having problems.


libbfd-2.28-system.so missing

libbfd-2.28-system.so is missing in Ubuntu 16.04.6 LTS (Xenial)
ctrlr builds fine but won't start.

Same on open-suse.
$ ./Ctrlr
./Ctrlr: error while loading shared libraries: libbfd-2.28-system.so:
$ locate libbfd
/usr/lib64/libbfd-2.32.so

I have the same issue with this version here on antergos/arch.
it's always a version of libbfd that prevents Ctrlr resp. the vst-plugin from working.
if anybody has an idea ...
thanks!

I just stumbled upon this thread about the same issue with Ctrlr 6.0.1: http://ctrlr.org/forums/users/arcangeli/replies/
right now I don't have time to figure out if it helps but the hints do seem helpful.

I did a sudo ln -s /usr/lib/x86_64-linux-gnu/libbfd-2.31.1-system.so /usr/lib/x86_64-linux-gnu/libbfd-2.28-system.so to make the latest build work (that's Ctrlr-x86_64-6.0.1.sh).

@dromer yes, or you could use patchelf --replace-needed in order not to mess with your system. But then I get:
./Ctrlr: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by ./Ctrlr)

i'm linking to whatever the latest ubuntu provides, different distros might use different lib versions this is when you have to build ctrlr yourself, i'm considering using snap or some similar way to distribute ctrlr but i'm far away from it


[terra-alert]Change customStatusColor prop to themeable customColorClass prop.

Summary
Resolves #2307

Spacing looks weird here.  It'd be nice to fix as part of this:

Nit: need a space between "a" and "custom" in the custom alert example.

+1
Reviewed:

Solves for adding new customColorClass for the custom Alert type variant with appropriate documentation on how to implement.

Verified by @neilpfeiffer, Ready for Release.

Pass

UX Review


does not remember

I disabled the logs panel but for some reason it doesn’t remember and it will show me again. please fix that

Do you mean you closed it and exited mrv2 and still shows up (without any error triggering it)?
Or:
You went to Preferences->Errors and set it to Do Nothing (and still shows up with an error triggering it)?

Yes, the panel does not close, I disabled it in the parameters but it appears again and again, please check it yourself
I think you understand me

I'll rollback previous versions for now

I'll need more information (be clear, please), as I cannot reproduce it.  Please answer each of these questions:

First, what OS are you on?
You set Preferences->Errors->Do Nothing, is that right?
Your Log is on a panel or on a floating window?
You closed the Log Panel/Window and then exited mrv2 cleanly by closing the main window or pressing Esc.
The Log Panel/Window appears even when there is no error?

i mean it
my oc is windows 11

You set Preferences->Errors->Do Nothing, is that right? - yes i do the same

Ah.  Okay, you are getting the Hotkey corruption issue which was reported earlier by someone else.
Please delete this file from your disk (reported in the Log Window):
C:\Users\turdi.filmaura\mrv2.keys.prefs
That should fix the issue.

its helped me thank you so much.
I  think such problems will not arise again


Update "wait" utility functions for tests with Selenium Wait API

There are a couple of functions we're using in our tests, for example the wait_for style functions in the utils.py file, that we could update to use https://selenium-python.readthedocs.io/waits.html instead of our own functions.

@byronz I'm going to close this one, I think you have a good handle on wait_for and have already made some changes along the lines suggested here.


Please Publish a winget package

Suggested new feature or improvement
Please publish a winget package as this would help with automated installs.
Scenario
Configuring a developer's new laptop could be completely automated if this app could be installed via winget. Additionally, developers could install it on their machines if they don't have access to the store.
Additional details
No response

@AndrewOttavianoAbb  Are you asking for being able to install DevHome via winget?
If so, it is already available.  See below:
C:\Users>winget search devhome
Name               Id                Version     Match            Source
Dev Home (Preview) Microsoft.DevHome <IP_ADDRESS> Moniker: devhome winget

Is the winget version installable on windows 10? I remember seeing a PR or issue somewhere about adding win 10 support, I guess that hasn't been added yet? I'm probably just hallucinating (I promise I'm not an AI 😆).

@AndrewOttavianoAbb You're not hallucinating :-) But Dev Home is not currently available on Windows 10.


add FLS models

Presently not ready to merge.  SeaBat f50 .png may not be being accessed.  BlueView has "hollow" spots in power plug.  Also, collision and physics properties are not ready.

In order to have gazebo be aware of the models you'll need to add the following to the package.xml file
 <export>
    <gazebo_ros gazebo_model_path="${prefix}/models"/>
    <gazebo_ros gazebo_media_path="${prefix}"/>
  </export>

See the dave/uuv_dave/package.xml for an example.

In order to have gazebo be aware of the models you'll need to add the following to the package.xml file
 <export>
    <gazebo_ros gazebo_model_path="${prefix}/models"/>
    <gazebo_ros gazebo_media_path="${prefix}"/>
  </export>

See the dave/uuv_dave/package.xml for an example.

I believe this is also already done on the uwlidar branch.

Currently waiting on updated meshes / textures and updated physical params.

We additionally need gazebo_ros to make the export work:
gazebo_ros

<gazebo_ros gazebo_model_path="${prefix}/models"/>
<gazebo_ros gazebo_media_path="${prefix}"/>

Currently only waiting on meshes / textures.  Physical parameters are done and example launch files are in place.

Meshes are in place.  In future we may want a simpler P900 mesh and we may want to patch minor holes in the M450 and F50 meshes views.


Vital Signs or Lab Results?

Firstly, loving the medspacy project - it's awesome!! Thanks for putting it together.
I have a question though, and if this is not the right forum please could you point me towards something more suitable.
Do you have any sample projects to extract Vital Signs or Lab Results?
I'm thinking something like:
PHYSICAL EXAMINATION:  Blood pressure 146/91, pulse 76.  Normal conjunctivae.  Ears, nose, throat normal.  Neck is supple.  Chest clear.  Heart tones normal.  Abdomen soft.  Positive bowel sounds.  No hepatosplenomegaly.  No adenopathy in the neck, supraclavicular or axillary regions.  Neurologically alert.  Cranial nerves are intact.  Strength is 5/5 throughout.
LABORATORY WORK:  White blood count 10.4, hemoglobin 16, platelets not noted.  Sodium 137, calcium 9.1.
My initial thoughts are Target Match to get the Reading / Measurement, and a Context Rule to find the associated 'thing' that has been measured, but I wondered if this is the kind of thing you have any examples of, and any better suggestions as to how to approach it?
Thanks

Hi, thanks for your comments about medspaCy and sharing what you're working on! I think your approach sounds like a good one, but I don't know of any specific examples that already exist for this. @turbosheep this seems like the kind of work you guys may have done before?

Thanks Alec.
Yes if anyone has any ideas / suggestions, I'd appreciate it. In the meantime I'll try my initial idea.
Thanks

Thanks @patrickthealba. That is really useful.
I've only had a quick look but that looks really helpful re rules and terms, as you say.
Much appreciated :)


Pipeline YAML Editor

[x] Include CodeMirror
[x] Very basic auto-complete and linter

Goodbye 👋


Self reference circle position option

So it can be tested with the following setup:
var nodes = new vis.DataSet([
    {id: 1, shape:"box", label: 'Node 1', title: 'I have a popup!', widthConstraint:{minimum:270}, heightConstraint:{minimum:200}, color: {background: "transparent"}},
    {id: 2, shape:"box", label: 'Node 2', title: 'I have a popup!', widthConstraint:{minimum:270}, heightConstraint:{minimum:200}, color: {background: "transparent"}},
    {id: 3, shape:"box", label: 'Node 3', title: 'I have a popup!', widthConstraint:{minimum:270}, heightConstraint:{minimum:200}, color: {background: "transparent"}},
    {id: 4, shape:"box", label: 'Node 4', title: 'I have a popup!', widthConstraint:{minimum:270}, heightConstraint:{minimum:200}, color: {background: "transparent"}}
]);

var edges = new vis.DataSet([
    {label:"Test", from: 1, to: 1, arrows:'to, middle, from'},
    {label:"Test", from: 2, to: 2, arrows:'to, middle, from'},
    {label:"Test", from: 3, to: 3, arrows:'to, middle, from'},
    {label:"Test", from: 4, to: 4, arrows:'to, middle from'},
]);

OR
var edges = new vis.DataSet([
    {label:"Test", from: 1, to: 1, arrows:'to, middle, from', selfReferenceSize: 20, selfReference: {size: 40, side:"left"}},
    {label:"Test", from: 2, to: 2, arrows:'to, middle, from', selfReferenceSize: 20},
    {label:"Test", from: 3, to: 3, arrows:'to, middle, from', selfReference: {size: 20, side:"right"}},
    {label:"Test", from: 4, to: 4, arrows:'to, middle from', selfReference: {side:"left"}},
]);

OR
var data = {
    nodes: nodes,
    edges: edges,
    options:{
        edges:{
            selfReferenceSize:60,
            selfReference: {side:"right"}
        }
    }
};

fixes #200

* [ ]  Could you make it so that the angle can be chosen freely? For example `Math.PI / 2` for right, `0` for top but also `Math.PI / 4` for topright.

What do you mean by this ?

* [ ]  Could you make it so that the angle can be chosen freely? For example `Math.PI / 2` for right, `0` for top but also `Math.PI / 4` for topright.

What do you mean by this ?

For example
selfReference: {
  size: 30,
  angle: Math.PI / 4
}

instead of
selfReference: {
  size: 30,
  side: "right"
}

It would allow the circle to be placed anywhere around the node not just at few predefined angles.

@Thomaash  I think i made changes based on your request. Created diff property as we discussed  With deprecated selfReferenceSize for backwards compatibility. However the only change i have not touched is that angle thing. Could expand on the logic, because i am not really understand how you gonna calculate x and y for the circle if you provide angle. Because right now if i say top then mean x is the same as the parent node and y is the top border of parent node. So now if you provide Math.PI / 4 how is that gonna work?

@piratuks I don't know if this is the best solution but you can use Node.distanceToBorder() to get the distance from the center of the node to the border of the node at given angle. This way you'll get the polar coordinates of the point you want relative to the center of the node. The rest is elementary school math.

Also trying to build your repo and run with (modified Basic Usage):
// create an array with nodes
var nodes = new vis.DataSet([
  { id: 1, label: "Node 1" },
  { id: 2, label: "Node 2" },
  { id: 3, label: "Node 3" },
  { id: 4, label: "Node 4" },
  { id: 5, label: "Node 5" }
]);

// create an array with edges
var edges = new vis.DataSet([
  { from: 1, to: 3 },
  { from: 1, to: 2 },
  { from: 2, to: 4 },
  { from: 2, to: 5 },
  { from: 3, to: 3 }
]);

// create a network
var container = document.getElementById("mynetwork");
var data = {
  nodes: nodes,
  edges: edges
};
var options = {};
var network = new vis.Network(container, data, options);

(async () => {
  let angle = -10;

  for (;;) {
    await new Promise(resolve => setTimeout(resolve, 1000));

    ++angle;
    console.log("set self reference angle to", angle / 10);
    network.setOptions({
      edges: {
        selfReference: {
          angle: angle / 10
        }
      }
    });
  }
})();

It doesn't do anything. Not even any errors. It's like if the option was never even set.

@Thomaash thx for quick feedback. i am gonna check your comments. Was off for a bit so that is why no progress on this PR. Now i am back wanna finish this one.

@Thomaash I updated PR. Added changes based on your recent feedback, some comments for most important parts and checked your example. Please try again and give me your thoughts.


package management about pnpm

Description
I want to try using pnpm
Version
0.69.4
Output of npx react-native info
FAILURE: Build failed with an exception.

* Where:
Settings file 'C:\Users\whaij\Desktop\movie\android\settings.gradle' line: 2

* What went wrong:
A problem occurred evaluating settings 'movie'.
> Could not read script<EMAIL_ADDRESS>as it does not exist.

Steps to reproduce
FAILURE: Build failed with an exception.

* Where:
Settings file 'C:\Users\whaij\Desktop\movie\android\settings.gradle' line: 2

* What went wrong:
A problem occurred evaluating settings 'movie'.
> Could not read script<EMAIL_ADDRESS>as it does not exist.

Snack, code example, screenshot, or link to a repository
react-native cli

build successful Application flash back

The operation is as follows:
pnpm add -D @react-native-community/cli
pnpm add -D @react-native-community/cli-platform-android

exec scripts pnpm android
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
Jetifier found 1850 file(s) to forward-jetify. Using 8 workers...
info Starting JS server...
info Installing the app...

> Task :app:installDebug
Installing APK 'app-debug.apk' on 'SKW-A0 - 11' for :app:debug
Installed on 1 device.

BUILD SUCCESSFUL in 9s
38 actionable tasks: 2 executed, 36 up-to-date
info Connecting to the development server...
info Starting the app on "77e6c004"...
Starting: Intent { cmp=com.movie/.MainActivity }

In the mobile phone, click the movie app to directly flash back

Closing as this looks like resolved + if this is an issue with the CLI should be opened on https://github.com/react-native-community/cli

thank your I try

Closing as this looks like resolved + if this is an issue with the CLI should be opened on https://github.com/react-native-community/cli

thank your I try

same problem.
pnpm install
android can not resolve many node libs
<EMAIL_ADDRESS>as it does not exist.
because of @react-native-community/cli-platform-android in .pnpm/@react-native-community/cli-platform-android@11.3.5/node_modules/@react-native-community/cli-platform-android


github repo could not resolve dependency if forced or legacy unit tests wont work

Reproduction Link
https://github.com/shentao/vue-multiselect/commit/904d10fb1ba92ae9656cd1e569e539e775be3614
Steps to reproduce
clone repo
checkout tag 2.1.6
npm install
Expected behaviour
install node modules
Actual behaviour
vue-multiselect on  tags/2.1.5 [$?] is 📦 v2.1.6 via ⬢ v14.16.0
➜ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/babel-core
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/babel-loader
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/dbehrends/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/dbehrends/.npm/_logs/2021-09-14T07_37_36_969Z-debug.log

Hi @code1x1. I'm a bit unsure on what you are trying to achieve here by checking out an old commit. I also couldn't replicate your issue. I'm going to close the issue for now, but if you can provide more details on what you are trying to achieve, we might be able to re-open this and figure out what is going on


Lexer line numbers

Line numbers are sometimes not correct depending on the format of the file/text.
This is due to the fact that \r\n or \r or \n are used as EOL.
To resolve the issue one must replace all \r\n or \r if no \n to \n.
Is it possible to define this behaviour.

Thanks @Zumbala.
Do you mean to say that the line numbers are incorrectly calculated?
Or that you want to dynamically define line terminators?
or both?

Yes the line numbers are incorrectly calculated.
I solved it like this:
var source = fs.readFileSync("article.jsonscheme",'utf8').replace(/\r\n/g,"\n")
sample:

Error:
{"name":"MismatchedTokenException","message":"Expecting token of type --> root <-- but found --> 'error' <--","token":{"image":"error","startOffset":176,"startLine":28,"startColumn":1,"endLine":28,"endColumn":5,"isInsertedInRecovery":false}
As you can see from the picture this should be 18 instead of 28
{"name":"MismatchedTokenException","message":"Expecting token of type --> root <-- but found --> 'error' <--","token":{"image":"error","startOffset":159,"startLine":18,"startColumn":1,"endLine":18,"endColumn":5,"isInsertedInRecovery":false}

I've tried reproducing this without success. So I will need more information,
specifically a reproducible example, which means a lexer definition and a sample input that causes the problem.
I do have one suspicion tough, so before providing a full reproduceable example.
can you provide just the definition you used for whitespace/line terminator tokens?
var whitespace = extendToken("whitespace", / |\t/)
var lineTerminator = extendToken("whitespace", ???)

I only have this rule:
TOKEN("WhiteSpace", /\s+/).GROUP = Lexer.SKIPPED
where TOKEN is a helper function:
function TOKEN(name,value) {
TOKENS =  TOKENS || {};
return TOKENS[name] = exToken(name,value);
}

Alright my suspicion seem to be irrelevant.
I can think of one situation in which this could happen.
And this is when the "\r\n" input is divided between two separate Tokens.
Do you have any other Tokens which can match (even partially) whitespace/line terminators?
Anyhow I will need to debug this to figure it out, and for this I need a running example to debug.
preferably  a minimal example:

Few Token classes.
Lexer only (no need for parser for this bug).
small sample input.

You can upload your example to github / jsfiddle or anything else you find convenient.
as long as I have access to the source code...

I tried to reproduce it on my computer and online on the playground.
But i cant.
Strange.
I think it has something todo with the VSCode editor, when copy paste data from another editor with another setup for EOL it will not correct it.
So its resolved

Allright.
re-open this if/when you manage to reproduce this.
Thanks for feedback.


Macro tag and comment search

Hey @PolRod, I know you're busy with bloc, so no worries if it takes a while for you to get to this. I'm not expecting much, I mostly wanted to show you this so you have an idea how it works.
With this version, it goes through these steps when the search button is clicked:

Loads all macros via ZD API
Filters the results based on the checked options using && logic (rather than 'or').
Render the results and insert them into the template

Next steps will be adding in date conditions:

filter by updated date range
filter by created date range

For the rest, it looks like :fire: to me!

Thanks for reviewing!


How to use different secrety_key per user (eg to invalidate devices on password-change)

Looks like AuthJWT loads config one time, then sets that secret_key to be used for later fetch via self._get_secret_key()
class Settings(BaseModel):
    authjwt_secret_key: str = SECRET

@AuthJWT.load_config
def get_config():
    return Settings()

A pattern I've seen in tutorials to invalidate other devices after a user changes their password (if they got hacked, or just want to be on the safe side) is this. refresh_token is encoded and decoded using secret_key=f"{SERVER_SECRET}-{user.hashed_password}". Then since the latter is different post password-change, the hacked refresh_token will throw a decode error. I think the same can be done for access_token, but maybe less critical since they can expire quickly?
Anyway, would it be worth consideration to add a custom secret_key per Authorize.jwt_required() call, maybe an argument to that function? Or is there another way about this you can think of, eg adding the hashed password as a claim (is that insecure? I'm thinking it gets double-hashed here?)

well if you adding a password as a claim is that insecure because the user or attacker can see the raw token in jwt.io, if you consider about double hashed you can use the Asymmetric Algorithm which uses a public-private key to hash the token, and for a custom secret key you can add when you create the token because in protected endpoint function is that dynamic decode token

Thanks for the response, I'll scrap the claims idea then & think about Asymmetric.

for a custom secret key you can add when you create the token because in protected endpoint function is that dynamic decode token

I'll chew on this a bit. I think custom key is the right way here, so I'll see if there's a solution here.

maybe in the next version, I'll be considering your idea and do some research about it, thank you 😄🙏

Thank you!

Hey everybody, since I am currently faced with implementing a refresh pattern and how to do it best (Using fastapi-user, maybe fastapi-jwt-auth, other options) I was wondering if this is still being considered or how the status in general is?

+1


Stop destroying panadapters

It turns out #16 was created without understanding the problem. Panadapters were not being destroyed. In order to free up the flex for multiple pan support the included fixes DOES destroy all pans on the flex.

These latest commits can be included too @cjam

I simplified as you suggested. I just got rid of destroyed_pans altogether. I was being overly verbose to debug.
When I replaced the whole segment with:
        print("flex::WaitForPanadaptersSync")
        existing_pans = FlexApi.radio.WaitForPanadaptersSync(2000, 1000)
        print("Number of active panadapters: {0}".format(
            len(existing_pans)))
        for p in existing_pans:
            p.Close(True)

I get the following failure. It seems to be something pythonnet related (see pythonnet/pythonnet/#226)
flex::WaitForPanadaptersSync
handler caught exception: No method matches given arguments
Traceback (most recent call last):
  File "/home/nsbruce/pybombs-prefix/GR-for-FlexRadio/lib/python2.7/dist-packages/gnuradio/gr/gateway.py", line 55, in eval
    try: self._callback()
  File "/home/nsbruce/pybombs-prefix/GR-for-FlexRadio/lib/python2.7/dist-packages/gnuradio/gr/gateway.py", line 170, in __gr_block_handle
    self.__message.start_args_return_value = self.start()
  File "/home/nsbruce/pybombs-prefix/GR-for-FlexRadio/lib/python2.7/dist-packages/flex/FlexSource.py", line 154, in start
    self.radio = FlexApi().getRadio()
  File "/home/nsbruce/pybombs-prefix/GR-for-FlexRadio/lib/python2.7/dist-packages/flex/flex.py", line 85, in getRadio
    self.__initRadio()
  File "/home/nsbruce/pybombs-prefix/GR-for-FlexRadio/lib/python2.7/dist-packages/flex/flex.py", line 77, in __initRadio
    existing_pans = FlexApi.radio.WaitForPanadaptersSync(2000, 1000)
TypeError: No method matches given arguments
thread[thread-per-block[0]: <block source (3)>]: caught unrecognized exception

Okay I think that does it @cjam

Nick, About the error that your getting.  Can you double check what your FlexLibMono radio.WaitForPanadaptersSync looks like.  I just want to make sure that your branch has those latest updates.

@cjam Yea everything is up to date. I could just hard set the delay longer in Radio.cs but that feels like a huge cop-out. I wonder if the pythonnet error is stopping something from loading those changes though? I'll fiddle on Monday. We can consider it a future finicky enhancement.


chore(deps): bump https://github.com/jenkins-x/jx-cli to 3.0.402

Update jenkins-x/jx-cli to 3.0.402
Command run was ./promote/main

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rajdavies
You can assign the PR to them by writing /assign @rajdavies in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rawlingsj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Emmet in typescript-tsx-mode expands .hoge to class="hoge"

What did you expect to happen?
When Emmet expands .hoge in typescript-tsx-mode, it will be expanded to className="hoge".
What actually happened?
When Emmet expands .hoge in typescript-tsx-mode, it will be expanded to class="hoge".
Describe your attempts to resolve the issue
Add below:
  (setq-hook! 'typescript-tsx-mode-hook emmet-expand-jsx-className? t)

And it worked.
Steps to reproduce

Open Emacs
Create a new buffer and M-x typescript-tsx-mode
Try to expand .hoge with Emmet.

System Information
https://pastebin.com/q6fc1wUC

This issue should now be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!


Master

For CCMission, EVENT_MISSION_COMPLETED is generated two time causing
duplicate events one for CCMission gate open and another on mission
completion. So better to check if the mission is already completed or
not.
Ref:
http://answers.soom.la/t/duplicate-events-fired-in-cocos2dx-levelup/1957
?u=saffron_state

Please review this change carefully as I am not much aware of internal functionality of cocos2dx-LevelUp and it may break some other functionality.

@vedi can you take a look at this PR?


Remove rlibc and use compiler-builtins-mem feature

Part of #862
I can also remove the references to rlibc from the blog posts if that saves you time

@robert-w-gries Thanks a lot! You missed the base branch by one, as we already introduce rlibc in post-02. I therefore rebased your commit on top of post-02 used GitHub's feature for changing the base branch of this PR.

I opened #866 to update the blog for this.

Sorry about that! Thanks for fixing it!

No worries, thanks for the PR!


Can we generate a fixed size image?

Dear authors, thankyou for providing synthtiger.
I was wondering that can we generate fixed size images like a 128x128 or 256x256?
If yes than how?

Alright Thankyou.


Fix default value for page in Model::paginate()

Description
This PR fixes the default value for the $page parameter in Model::paginate().
Ref: #3188
Checklist:

[x] Securely signed commits
[x] Conforms to style guide

@michalsn pagination not working now.
It shows same data on every page , data isn't change.
I have 16 rows. I want to show 4 data per page. But it shows same data every page. Maybe it's not fixed yet.

Apparently there is another bug with segment support. I will look into it tomorrow.

Thank you @michalsn .
I am making a magazine on codeigniter. So I need pagination to display per page posts by category. I already doing pagination with page query parameter, but my boss rejected it because it is not seo friendly url.
Almost all works are done in this project. I already two times rejected for not seo friendly pagination link.
Pagination links() method also have a problem.
If I didn't need to use pagination group, but I need to use my own pagination template.
So I basically do like
<?= $pager->links(null, 'moshiur') ?>

It gives me a error, because links first Argument must be a string null given.
Is it possible to give null value on links method both Arguments ?

@mmrtonmoybd  instead of null you should use default for group name.

@michalsn do you fixed paginate show results with segment bug ?

@mmrtonmoybd Yes, I hope it's fixed. The tests fail because of a random test failure.

Well done @michalsn
I am seeing that you fixed many issue in codeigniter like Super Man. You are the coding hero. Thank you 😊❤❤
Now it is working. But codeigniter ignore your pull request.

@mmrtonmoybd I was only waiting for you to confirm that it's working fine. Thanks for your feedback!

@michalsn
Codeigniter $pager->links() array contain the active boolean not working.
It return false for every page.
My current page is 5, but it return active=false for the page 5.
array(3) { [0]=> array(3) { ["uri"]=> string(42) "http://localhost:8080/category/exclusive/3" ["title"]=> int(3) ["active"]=> bool(false) } [1]=> array(3) { ["uri"]=> string(42) "http://localhost:8080/category/exclusive/4" ["title"]=> int(4) ["active"]=> bool(false) } [2]=> array(3) { ["uri"]=> string(42) "http://localhost:8080/category/exclusive/5" ["title"]=> int(5) ["active"]=> bool(false) } }


[Retiarii] cross-graph optimization: input deduplication

test_cgo_engine and test_dedup_input have passed the tests

Since this PR depends on the modification of training service #3897 , I prefer not merging this PR before #3897 is merged.


Support gen block syntax

Add support for the gen block syntax, currently gated after #![feature(gen_blocks)] in nightly Rust.

regenerate the parser too 🙂 but use the latest tree-sitter version please (0.24.3)

regenerate the parser too 🙂 but use the latest tree-sitter version please (0.24.3)

I'm not that familiar with how things go around here :sweat_smile:
In any case, I've regenerated the parser.


Umbraco UI Form not working after upgrade

Which exact UI Library version are you using? For example: 1.0.1 - don't just write v1.
1.3.0
Bug summary
I have two simple forms in two custom dashboards. Both of them stop working after installing the version 11.4.2 from version 11.2.1. Now when it loads I get the following error:

Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegistry': the name "uui-modal-sidebar" has already been used with this registry
at https://cdn.jsdelivr.net/npm/@umbraco-ui/uui@latest/dist/uui.min.js:187:64
at https://cdn.jsdelivr.net/npm/@umbraco-ui/uui@latest/dist/uui.min.js:187:79
at ts (https://cdn.jsdelivr.net/npm/@umbraco-ui/uui@latest/dist/uui.min.js:272:10690)
at https://cdn.jsdelivr.net/npm/@umbraco-ui/uui@latest/dist/uui.min.js:272:12779
at https://cdn.jsdelivr.net/npm/@umbraco-ui/uui@latest/dist/uui.min.js:1:178
at https://cdn.jsdelivr.net/npm/@umbraco-ui/uui@latest/dist/uui.min.js:1:193

Specifics
No response
Steps to reproduce

Add a custom dashboard in Umbraco 12.4.2
Try to add the JS for UUI 1.3.0.
Run and open the dashboard.
Check the console and look for the error.

Expected result / actual result
No response

Hi @HugoBecerra
It should not be necessary for you to add UUI manually to the backoffice through a CDN, since UUI is already included with Umbraco. You are getting this error because two different installations of the UI library is trying to register the same component. It should work if you remove any references to https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>Let me know how it goes.


Add gif and webp support to Fresco

Motivation #7760
Test plan
Build from source with a gif image, everything works fine.
However, i'm not sure about the BUCK part. While building I saw the dependencies I added being downloaded, but the app built with BUCK doesn't support gif. Maybe someone with more experience with BUCK than me can check this?

By analyzing the blame information on this pull request, we identified @cjhopman and @mkonicek to be potential reviewers.

@andreicoman11 do you guys want this on facebook's side?

I think we want this.
@bestander these libraries don't automatically get built as part of the app, unless you explicitly include each library, right?

@andreicoman11, regarding app sizes.

Gradle will include these libraries by default because they are on "compile" target now. Prod apps would want to exclude them with proguard or some custom gradle scripts.
Buck will include everything that is required via dependency tree, i.e. if there are modules that use imagepipeline target those will be downloaded and included

The short answer to all is yes, they will automatically get built as part of the app

That is bad news. Afaik, these libraries are quite big, it sounds like we shouldn't include them automatically for everybody.

@andreicoman11, before version 0.10 of Fresco these libraries were included by default into the Fresco library. Since 0.10, these libraries has been split up, so in theory we don't add much weight to React Native since it was there previously. But I understand what you mean, I just want to be sure you know all facts.
If you still don't want it into React Native, I will add some documentation about gif and webp support into the Image component, just let me know.

Thanks for the info @charpeni . The fresco split up was requested by multiple parties, since the whole library was so big. I think we should keep the core size as small as we can, and in this case, the majority of the people won't be needing those libraries.
If you could add docs about gif and webp support, that would be much appreciated.

Good, I will do that.


Does StyleSheet.create really help with performance?

I have just started using this library after reading this article from the author of this library. In the article it is mentioned:

This helper needs to be called globally in the file as React Native StyleSheet performs some optimizations so that it only creates styles once and they are never re-updated. This means there are less trips across the JS-Native bridge, which are very expensive.

but after some research I have come across the claim that Stylesheet.create does not add performance gains (See https://github.com/DefinitelyTyped/DefinitelyTyped/issues/29265#issuecomment-430783289).

Hi @YoushaExT, yes the performance gains of StyleSheet.create() are a lot of times mis-interpreted. StyleSheet.create() used to provide some pretty good performance improvements, however those have been mostly all removed now. From my understanding StyleSheet.create() currently provides no additional benefits from creating a plain object outside the component. The snippet from the article is saying how you should create the StyleSheet outside the components body vs inside, this is because if you define it in the component then every re-render will re-create the StyleSheet which is much less performant than having it outside where it is only created once.
With that being said you may be wondering why I am still in support of using StyleSheet.create() instead of just an object. I am using it because it is the way react-native has built to do styling, so in the future I am guessing they will come up with performance improvements and re-implement them into the stylesheet. In addition react-native-web has been doing some interesting things with StyleSheet performance that only applied to styles using StyleSheets briefly described here but I have seen it in their release notes more often.
So while I have nothing against using plain objects as styles, I like to use StyleSheets whenever possible to support any future improvements automatically, and there is no downside to using them in my opinion.
Let me know if you have any questions on that.
So:
function Component() {
  return <View style={styles.container} />
}
const styles = StyleSheet.create({ container: { color: 'red' } })

Is just as performant as:
function Component() {
  return <View style={styles.container} />
}
const styles = { container: { color: 'red' } }

but both are more performant as
function Component() {
  const styles = { container: { color: 'red' } }
  return <View style={styles.container} />
}


Stay in fullscreen between episodes + rename and move the skip button.

Describe your suggested feature
I went searching for some kind of application I could use on Windows as a replacement for going directly to a website in hopes of gaining a couple of features that I sorely miss from Aniwave (formerly 9anime and now defunct) and another older site called AnimeTwist (also defunct)
Have been using HiAnime but it lacks one important feature and that is the ability for it to stay in fullscreen when going to the next episode.
I downloaded this app because it so far is the only thing I can find that is made to run on PC and actually works hoping that despite it lacking in some areas I could use it to watch anime in fullscreen and have it just stay that way between episodes but it seems that it doesn't do that and just like with going directly to the site, it kicks you out of fullscreen every time.
This ultimately makes the app not that great for anime, especially when it's lacking in a lot of QoL UX features.
So the feature request I ultimately have is that it needs to stay in fullscreen when going between episodes.
Other feature I might suggest is changing the skip intro/outro button to actually say the word "Skip" instead of just showing seconds to be a little more intuitive to a new user who never goes into settings and sees the options for it and then sees the button and puts two and two together. (I didn't even know it was a button at first cuz it's so small and in the left corner and not the right corner like literally every single video streaming platform just further lending to it's not so intuitive design)
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.

More > Settings > Player > Use Fullscreen
Enable that toggle and the player will stay in fullscreen between episodes.
Also, open another issue for your suggestion instead of combining it here.


Fix fsnotify import path

The original go-fsnotify package was moved to "fsnotify/fsnotify", and so the import path has to be changed into the second form of the import alias. (described at http://labix.org/gopkg.in)

#138 handles this issue better.


Command jf aud for gradle project always returns exit code 0

Describe the bug
The jf aud command returns exit code 0 even if vulnerable dependencies are found in the Gradle project. According to the documentation, the jf aud command has a 'fail' flag, which specifies that exit code 3 should be returned.
This bug is critical if the command needs to be implemented in CI, as running this command from the pipeline does not trigger an error when vulnerabilities are found.
Current behavior
The jf aud command returns exit code 0 even if vulnerable dependencies are found in the Gradle project.

Reproduction steps

jf aud --gradle
echo $?
0

Expected behavior

jf aud --gradle
echo $?
3 (any none zero exit code)

JFrog CLI version
jf version 2.53.2
Operating system type and version
Linux Ubuntu 22.04.4 LTS
JFrog Artifactory version
No response
JFrog Xray version
3.69.3

This bug is also relevant for npm projects.

Hey @vhryshchenko-source.
This behavior is by design.
The fail flag indicates in the documentation:
"Set to false if you do not wish the command to return exit code 3, even if the 'Fail Build' rule is matched by Xray"
jf aud matches the vulnerabilities with a certain Xray Watch that contains policies and if the policy contains a Fail Build option it will return exit code 3.
To get exit code 3 you should use the --watches flag with a watch that contains such a policy.
See the documentation for Xray policies and watches:
https://jfrog.com/help/r/jfrog-security-documentation/create-an-xray-policy
https://jfrog.com/help/r/jfrog-security-documentation/create-a-watch
Let us know if it works with --watches flag as expected.


Monorepo migration breaks the pre-commit mvn fmt step

Pre-commit hooks setup via DEVELOPMENT.md result in this error on commit:
[ERROR] No plugin found for prefix 'fmt' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/home/alicejli/.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]

The mvn fmt plugin has to be invoked by:
mvn com.coveo:fmt-maven-plugin:format to run.
The temp solution is to remove the pre-commit hooks and manually invoke the command above to format the repo.

When a solution is found, please also update the DEVELOPMENT.md file!

This issue is already fixed in #1266


[Bug]: Intermittent startup issues with Opensearch 1.3.3 Docker container

Describe the bug
We are seeing intermittent but pretty regular issues when using the Opensearch docker image in CI. All we see in the logs for the docker-compose container output is:
opensearch_1 | Killing opensearch process 10
opensearch_1 | Killing performance analyzer process 11

This is even after enabling trace level logging with rootLogger.level = trace in the log4j2 config. The full docker-compose config is:
elasticsearch:
    image: public.ecr.aws/peakon/opensearch:1.3.3
    environment:
      - discovery.type=single-node
      - http.cors.enabled=true
      - http.cors.allow-origin=*
      - bootstrap.memory_lock=true
      - 'OPENSEARCH_JAVA_OPTS=-Xms2G -Xmx2G'
    restart: always
    shm_size: 2gb
    ulimits:
      memlock:
        soft: -1
        hard: -1
      nofile:
        soft: 65536
        hard: 65536
    volumes:
      - ./docker/log4j2.properties:/usr/share/opensearch/config/log4j2.properties

We are also extending the Opensearch image to remove the security plugin and add analysis-icu plugin and our image can be found on public ECR as public.ecr.aws/peakon/opensearch:1.3.3
FROM opensearchproject/opensearch:1.3.3

RUN /usr/share/opensearch/bin/opensearch-plugin install --batch --verbose analysis-icu \
    && /usr/share/opensearch/bin/opensearch-plugin remove --verbose opensearch-security

The container continues to run and after execing into it the logs directory contains some output from the performance analyser plugin with some errors like:
ERROR org.opensearch.performanceanalyzer.rca.RcaController - Error reading file /usr/share/opensearch/data/rca_enabled.conf

However simply running opensearch within the container works, but using the entrypoint script results in the same error. It seems to be something to do with the terminateProcesses function.
We have found that removing CHILD from the line trap terminateProcesses TERM INT EXIT CHLD in the script allows Opensearch to start up.
To reproduce
This issue is hard for us to reproduce locally but happens fairly regularly in our CI infrastructure. If there is anything else we can do to debug this or get some more information that would be extremely handy.
Expected behavior
The docker image should start Opensearch or exit with some error in the logs
Screenshots
No response
Host / Environment
Docker version 20.10.17, build 100c701
Additional context
No response
Relevant log output
No response

Hi @threesquared,
The design is ensure that if either PA or OS process get killed, both process will get killed to ensure both process always running together.
It was a design back in the day to remove dependencies on supervisord as it is not favored by docker hub official images.
The thing that seems suspicious is the PA log error accessing:
ERROR org.opensearch.performanceanalyzer.rca.RcaController - Error reading file /usr/share/opensearch/data/rca_enabled.conf

I dont recall if PA would stop if the conf is not accessible, but even then there should not have any permission problem with that file, let me take a look on it.
Have you guys try to use the official docker-compose.yml on opensearch.org?
https://opensearch.org/samples/docker-compose.yml
We have tested with above compose file and havent seen issues yet.
At least not happening when we start the cluster.
Do you guys see the issues right after startup, or hours later?
Thanks.

@peterzhuamazon Did you mean to move it back to opensearch-build. Curious why?

Hey @threesquared just checking back if you have tried with the suggested docker-compose file by @peterzhuamazon and still notice the issue?

So it's really hard to pin down as its very intermittent. The compose file we use in CI is only a single-node but otherwise is the same as the official compose file.
We have hacked around this with a script that catches an exit code from dockerize that the port has not come up and then uses docker-compose restart to try again.
I will try and catch the issue again but there are no logs in the container other than the ones for the performance analyser I mentioned above but I will attach the full contents next time.

We also encounter this issue in OS Javascript repo's workflow. One of our workflow runs a matrix of 24 configurations, and often one or two of those configurations will encounter this issue.
Those "Killing process" messages came from opensearch-build repo. It's most likely that said script encountered an error and trigger the trap EXIT and killed these 2 processes.
Grepping the container's logs for those messages to restart the container is a workaround we're considering.

The workaround in https://github.com/opensearch-project/opensearch-js/pull/304 is not pretty, but it seems to work.

Added an issue on the meta repo with my findings and a couple of workarounds: https://github.com/opensearch-project/project-meta/issues/62

@threesquared do you have a complete set of logs from a failed to start container by any chance?

@dblock we just see the same as https://github.com/opensearch-project/project-meta/issues/62 all that comes out of the container logs is:
opensearch_1 | Killing opensearch process 10
opensearch_1 | Killing performance analyzer process 11

@threesquared But you also have a log inside opensearch/logs inside the container. That's what I'm after.

Ah ok sorry I wish I had saved the whole output when I last caught it. I will try and reproduce and upload a full log

So I managed to catch this again using a script like this using dockerize in our CI platform:
RETRIES=100

for ((i=0; i<RETRIES; i++)); do
  ./docker/scripts/dockerize.sh \
    -wait http://elasticsearch:9200 \
    -timeout 30s

  if [[ $? -eq 1 ]]
  then
    sleep 1h
  else
    docker-compose up -d --force-recreate --no-deps elasticsearch
  fi
done

This gist is the last 200 lines of the logs/performance-analyzer.log
Let me know if you need any more info from the container. No other log files in that directory and as usual only those two lines in the docker logs.

I've collected some logs via github workflow. Opensearch container can fail in 2 ways:

Open Search crashes as soon as the container is created but the container still appears to be running and the docker logs only shows the 2 "Killing Process" lines mentioned above.
The Container crashes after some time, and we see a lot more in docker logs.

I also collected OpenSearch logs inside the container along with Kernel and System logs of the workflow runner.
For comparision, here's what a successful run looks like.

@dblock There 2 ways the runs could fail, one of it produces almost no logs, and just
Killing opensearch process 10
Killing performance analyzer process 11

Where did you see [2022-10-06T22:08:58,320][INFO ][o.o.s.c.ConfigurationRepository] [5fb0eef93fa0] Node '5fb0eef93fa0' in that run?
In the makefile I used to recreate these fail runs, I actually used 45 seconds sleep time. In 2 fail runs, whether the container was stopped or not, the docker logs show the "Kill process" message in both cases. Are you saying that this service will restart automatically after some time if Opensearch is not running?

I was comparing the other two runs that had more logs. This one puzzles me.
My running theory rn is that we start the container, do something that fails (run a test), don't properly report it or fail to see it, visibly shutdown the container (e.g. job killed in GHA), which causes the container to kill the process because it has received a termination signal itself.

The workflow I ran did not do any tests. It marked a run as failed if the container was unhealthy, and collected a bunch of logs. So, the only interactions OpenSearch had were from the curl command that runs every 5 seconds for health check. And the first healthcheck happens 20 seconds after the container's been booted up.
I don't think there was anything from outside of the container that sent the kill signal to OS. OOMKilled: false when you inspect the container after a crash. The trap was likely triggered by the EXIT or CHLD signals.

See https://github.com/opensearch-project/opensearch-js/pull/304 for a retry implementation. I propose we leave this open until we can get to the bottom of the issue, maybe someone will be more successful?

Hey the resolved issue https://github.com/opensearch-project/opensearch-build/issues/1185, should fix this intermittent startup issues. Keeping the memory setting setting/adjustment aside, we can now disable the performance analyzer https://github.com/opensearch-project/opensearch-build/tree/main/docker/release#disable-performance-analyzer-agent-cli-and-related-configurations, this is be out for 2.4.0, should we backport this to 1.3.x? @gaiksaya @dblock @bbarani @peterzhuamazon WDTY?
Thank you

Hi @prudhvigodithi this change is already in 1.3.x as we release it in 1.3.7.
Thanks.

Thanks @peterzhuamazon since 1.3.7 is already out, we should be closing this issue, @threesquared can you please test with 1.3.7 and add your thoughts here please?
Thank you

Closing this issue since we have released 1.3.7 version and haven't noticed this behavior. Feel free to re-open if required.


RealmDB doesnt works properly on the old versions of Safari.

RealmDB doesn't works properly on the old versions of Safari.
The error messages related to the AbortController class appears in the console
Logger label and error stack are referenced to the RealmDB
Steps to reproduce:

Sign up/login into the app
Observe the result

Actual result:
The "Ooops... Wallet could not be loaded. Please refresh" popup is shown
Expected result:
The user is able to sign up/login into the app
Environment:
DEV 1.30.l-11
Devices:
iPhone 6 Plus // iOS 11.1
Attachments:
video - https://www.screencast.com/t/ecWHWsBY
screen - https://www.screencast.com/t/p5Q8QRoxn1F4

@sirpy @serdiukov-o-nordwhale
The issue is not reproduced. There is the possibility to login without any issues.
Environment:
QA 1.30.1-13
Devices:
iPhone 6 Plus // iOS 11.1
Attachments:
https://www.screencast.com/t/jCjAWXbW64jR


feat: One new dashboard and 2 new metrics in existing one

/lgtm

/approve

/retest

/lgtm

/retest

Newer PR was already merged: https://github.com/redhat-appstudio/infra-deployments/pull/2185


Nsynth data question: organ_acoustic_003 one velocity?

Hello,
In the NSynth dataset, the training data instrument organ_acoustic_003 only has one velocity, and it appears to have an unusual value: 127. Is this intentional? e.g.
.../nsynth/nsynth-train/audio/organ_acoustic_003-053-127.wav

It appears some instruments only have one velocity (127 - the max). I don't think this is explicitly stated in the documentation here (but could be wrong!): https://magenta.tensorflow.org/datasets/nsynth. I was expecting 5 velocities per note where some are duplicates.

Hi James,
That's not a mistake, different instruments have different amounts of pitches and velocities available to them. As it says on the dataset page:
"Some instruments are not capable of producing all 88 pitches in this range, resulting in an average of 65.4 pitches per instrument. Furthermore, the commercial sample packs occasionally contain duplicate sounds across multiple velocities, leaving an average of 4.75 unique velocities per pitch."
If a sound had no variation across velocity, we only included the highest velocity, which is 127 as MIDI is 7-bit.

Grand, cheers for clarifying.
On Mon, 22 May 2017, 21:45 Jesse Engel<EMAIL_ADDRESS>wrote:

Closed #646 https://github.com/tensorflow/magenta/issues/646.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/magenta/issues/646#event-1092530485, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADXIc9EGAHmNC7ufMzUIafxMqGwLgkmxks5r8fP2gaJpZM4NeE8k
.


Implementation of Attention is wrong.

Mistake 1. The attention heads are all summed together; they should be concatenated (see code and image of attention equation).
Mistake 2. After the missing concatenation there should have been another linear layer (see code and image of attention equation).
Note. Using a for-loop for heads doesn't seem to be efficiently compiled by Jax.
Note. The weight initialization is different to minGPT.
Code: https://github.com/awf/functional-transformer/blob/e44f4606efd663b0c6454d81010f536966dbd990/transformer.py#L161C9-L180C69
# Multi-head self-attention
for head in layer.heads:

    # Project into this head's query/key space
    query = linear(head.query, t1)                  # L x Dk
    key = linear(head.key, t1)                      # L x Dk

    # Compute L x L attention matrix
    score = query @ key.T + mask                    # L x L
    attn = jax.nn.softmax(cfg.tau * score, axis=1)  # L x L

    value = linear(head.value, t1)                  # L x Dm
    self_attn = attn @ value                        # L x Dm

    # Add this head's contribution into embeddings
    embeddings += self_attn                         # L x Dm     <---- sum instead of concatenate

# <-- after concatenating all attention heads there should be another linear layer here.

Ahh this is the same as #6

Ahh, this is the same as #6 and #7


display error

if you add the new mobs to the hunter config for example a fox it shows up as panda.
I think it has to do becasue the mobs are listed as the same number (916)
as seen as below
https://prnt.sc/oo774x
https://prnt.sc/oo77j8
Server Type Spigot:
Server Version (1,14,4):
edit: sorry for the text being in full bold

Already added: https://github.com/Zrips/Jobs/commit/01898220ccbcc891ea3b17a3028a51cf8859dfe1
Install the dev version from releases tab.
Next time follow the commits.


Client Allocation Request for: Julien NOEL

Client Allocation Questions
Core Information

Name: Julien NOEL
Website / Social Media: https://www.linkedin.com/in/julien42/
Region: Europe
DataCap Requested: 5TiB
Addresses to be Notarized: f3vlzrzb6wjzlogdkhd5bsu2dzq6hrqryciu7bysmb7glimexcqfxzxrcfnygrco7j3zcw4346vb6oeue4uvhq
Notary Requested: philippbanhardt

Hi @philippbanhardt ,
I'm following my previous datacap allocation (https://github.com/keyko-io/filecoin-clients-onboarding/issues/32) to store the freerainbowtables dataset to filecoin.
I updated the previous allocation issue with the CIDs. The files have been store to 5 miners own by 5 different entities.
Thank you,
Julien

Fantastic, thanks @s0nik42

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzaceck4capojay6k32b6ezrk3rwf73y5zhhryugpzsdfnqnyqdycuhs2

Address

f3vlzrzb6wjzlogdkhd5bsu2dzq6hrqryciu7bysmb7glimexcqfxzxrcfnygrco7j3zcw4346vb6oeue4uvhq

Datacap Allocated

5 TiB

This user’s identity has been verified through filplus.storage


Rust: Add geo-traits reader implementation

We have a new core geo crate: geo-traits! This enables zero-copy vector data interchange throughout the GeoRust ecosystem.
This PR implements these traits on new-types around a flatgeobuf::Geometry.
Since Flatbuffers are zero-copy, this means that you could memory-map a FlatGeobuf file and pass those geometry references directly to any consumer accepting these traits.
Change list

Adds a public method onto FgbFeature to return a struct that implements geo_traits::GeometryTrait.
Since the method returns an impl geo_traits::GeometryTrait, none of the new structs need to be exposed publicly.
This provides a standard way to access FlatGeobuf data with Z and M values as well.

Questions

How to handle FlatGeobuf files with t values? Those are currently omitted
How should we handle curve types? This PR currently panics on those.

Note that we may want to wait for geo-traits 0.2 before merging and releasing: https://github.com/georust/geo/pull/1263

@kylebarron seems like very nice work (even though I seem to get less rather than more into rust, unfortunately) - I'll merge now and see if I can make it into a published crate not too far off.