Add emulation for CPU without FMA instruction set

Description
FMA instruction set was introduced in 2012 (AMD Piledriver, Intel Haswell),  but architectures before that already had AVX and SSE4.2 instruction sets.  Dr. Jit doesn't currently verify whether a CPU supports the FMA instruction set. As a result, LLVM generates a global offset table when FMA is not available, which leads to a critical compiler failure in Dr. Jit.
To address this issue, emulation of the FMA instruction was implemented using the existing fmul and fadd instructions. This will ensure that the code runs smoothly on CPUs that do not have native FMA support, preventing any potential failures caused by the absence of the instruction set.
This PR should also fix: mitsuba-renderer/drjit/#46
Code to reproduce:
import drjit as dr
dr.set_log_level(dr.LogLevel.Trace)
a = dr.llvm.Array3f([1.], [2.], [3.])
b = dr.fma(a, a, a)
print(b)

Error message:
Critical Dr.Jit compiler failure: jit_llvm_compile(): a global offset table was generated by LLVM, which typically means that a compiler intrinsic was not supported by the target architecture. DrJit cannot handle this case and will terminate the application now. For reference, the following kernel code was responsible for this problem:

define void @drjit_4300624cc1a9b63fa571334796cbc01c(i64 %start, i64 %end, i8** noalias %params) #0 {
entry:
    br label %body

body:
    %index = phi i64 [ %index_next, %suffix ], [ %start, %entry ]
    %f1_p1 = getelementptr inbounds i8*, i8** %params, i32 3
    %f1_p2 = load i8*, i8** %f1_p1, align 8, !alias.scope !2
    %f1_p3 = bitcast i8* %f1_p2 to float*
    %f1_0 = load float, float* %f1_p3, align 4, !alias.scope !2
    %f1_1 = insertelement <8 x float> undef, float %f1_0, i32 0
    %f1 = shufflevector <8 x float> %f1_1, <8 x float> undef, <8 x i32> zeroinitializer
    %f2_p1 = getelementptr inbounds i8*, i8** %params, i32 4
    %f2_p2 = load i8*, i8** %f2_p1, align 8, !alias.scope !2
    %f2_p3 = bitcast i8* %f2_p2 to float*
    %f2_p4 = getelementptr inbounds float, float* %f2_p3, i64 %index
    %f2_p5 = bitcast float* %f2_p4 to <8 x float>*
    %f2 = call <8 x float> @llvm.fma.v8f32(<8 x float> %f1, <8 x float> %f1, <8 x float> %f1)
    store <8 x float> %f2, <8 x float>* %f2_p5, align 32, !noalias !2, !nontemporal !3
    %f3_p1 = getelementptr inbounds i8*, i8** %params, i32 5
    %f3_p2 = load i8*, i8** %f3_p1, align 8, !alias.scope !2
    %f3_p3 = bitcast i8* %f3_p2 to float*
    %f3_0 = load float, float* %f3_p3, align 4, !alias.scope !2
    %f3_1 = insertelement <8 x float> undef, float %f3_0, i32 0
    %f3 = shufflevector <8 x float> %f3_1, <8 x float> undef, <8 x i32> zeroinitializer
    %f4_p1 = getelementptr inbounds i8*, i8** %params, i32 6
    %f4_p2 = load i8*, i8** %f4_p1, align 8, !alias.scope !2
    %f4_p3 = bitcast i8* %f4_p2 to float*
    %f4_p4 = getelementptr inbounds float, float* %f4_p3, i64 %index
    %f4_p5 = bitcast float* %f4_p4 to <8 x float>*
    %f4 = call <8 x float> @llvm.fma.v8f32(<8 x float> %f3, <8 x float> %f3, <8 x float> %f3)
    store <8 x float> %f4, <8 x float>* %f4_p5, align 32, !noalias !2, !nontemporal !3
    %f5_p1 = getelementptr inbounds i8*, i8** %params, i32 7
    %f5_p2 = load i8*, i8** %f5_p1, align 8, !alias.scope !2
    %f5_p3 = bitcast i8* %f5_p2 to float*
    %f5_0 = load float, float* %f5_p3, align 4, !alias.scope !2
    %f5_1 = insertelement <8 x float> undef, float %f5_0, i32 0
    %f5 = shufflevector <8 x float> %f5_1, <8 x float> undef, <8 x i32> zeroinitializer
    %f6_p1 = getelementptr inbounds i8*, i8** %params, i32 8
    %f6_p2 = load i8*, i8** %f6_p1, align 8, !alias.scope !2
    %f6_p3 = bitcast i8* %f6_p2 to float*
    %f6_p4 = getelementptr inbounds float, float* %f6_p3, i64 %index
    %f6_p5 = bitcast float* %f6_p4 to <8 x float>*
    %f6 = call <8 x float> @llvm.fma.v8f32(<8 x float> %f5, <8 x float> %f5, <8 x float> %f5)
    store <8 x float> %f6, <8 x float>* %f6_p5, align 32, !noalias !2, !nontemporal !3
    br label %suffix

suffix:
    %index_next = add i64 %index, 8
    %cond = icmp uge i64 %index_next, %end
    br i1 %cond, label %done, label %body, !llvm.loop !4

done:
    ret void
}

declare <8 x float> @llvm.fma.v8f32(<8 x float>, <8 x float>, <8 x float>)

!0 = !{!0}
!1 = !{!1, !0}
!2 = !{!1}
!3 = !{i32 1}
!4 = !{!"llvm.loop.unroll.disable", !"llvm.loop.vectorize.enable", i1 0}

attributes #0 = { norecurse nounwind "frame-pointer"="none" "no-builtins" "no-stack-arg-probe" "target-cpu"="ivybridge" "target-features"="-vzeroupper,+sse2,-tsxldtrk,+cx16,+sahf,-tbm,-avx512ifma,-sha,-gfni,-fma4,-vpclmulqdq,-prfchw,-bmi2,-cldemote,+fsgsbase,-ptwrite,-amx-tile,-uintr,+popcnt,-widekl,+aes,-avx512bitalg,-movdiri,-xsaves,-avx512er,-avxvnni,-avx512vnni,-amx-bf16,-avx512vpopcntdq,-pconfig,-clwb,-avx512f,-xsavec,-clzero,-pku,+mmx,-lwp,-rdpid,-xop,-rdseed,-waitpkg,-kl,-movdir64b,-sse4a,-avx512bw,-clflushopt,+xsave,-avx512vbmi2,+64bit,-avx512vl,-serialize,-hreset,-invpcid,-avx512cd,+avx,-vaes,-avx512bf16,+cx8,-fma,-rtm,-bmi,-enqcmd,+rdrnd,-mwaitx,+sse4.1,+sse4.2,-avx2,+fxsr,-wbnoinvd,+sse,-lzcnt,+pclmul,-prefetchwt1,+f16c,+ssse3,-sgx,-shstk,+cmov,-avx512vbmi,-amx-int8,-movbe,-avx512vp2intersect,+xsaveopt,-avx512dq,-adx,-avx512pf,+sse3" }
[1]    19864 abort      python drjit_test.py

Hi @lnuic
This looks good to me.
One question, have you taken a look at the fmuladd LLVM intrinsic (link? It's unclear to me if we shouldn't just always use this or at least when fma is not supported on the target cpu.

Follows-up here: https://github.com/mitsuba-renderer/drjit-core/pull/60


Feature - TSS-925 - Public file updates

Codecov Report
Patch coverage: 83.33% and project coverage change: +0.02% :tada:

Comparison is base (8d30f2a) 55.65% compared to head (394e170) 55.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #414      +/-   ##
===========================================
+ Coverage    55.65%   55.68%   +0.02%
===========================================
  Files          212      212
  Lines        12473    12482       +9
  Branches      1618     1619       +1
===========================================
+ Hits          6942     6950       +8
- Misses        5531     5532       +1

Files Changed
Coverage Δ

trade_remedies_api/cases/services/v2/views.py
58.87% <83.33%> (+2.75%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Code refactor to Python 3 compatible

Code refactor of Private and Public calls to be Python 3 compatible

Can one of the admins verify this patch?


This type cannot unbox to a native integer: P6opaque, Scalar   in sub want-lines

jdv@jdv-lap:~$ cd rakudo
jdv@jdv-lap:~/rakudo$ rak role
docs/announce/2009-02
56:* Existing parameterized roles are now reused instead of creating new ones.
...
src/core.c/Rakudo/Internals/HyperToIterator.pm6
2:my role X::HyperRace::Died {
src/core.c/Rakudo/Internals/HyperWorkStage.pm6
4:my role Rakudo::Internals::HyperWorkStage {
12:my role Rakudo::Internals::HyperBatcher does Rakudo::Internals::HyperWorkStage {
18:my role Rakudo::Internals::HyperProcessor does Rakudo::Internals::HyperWorkStage {
29:my role Rakudo::Internals::HyperRebatcher does Rakudo::Internals::HyperWorkStage {
39:my role Rakudo::Internals::HyperJoiner does Rakudo::Internals::HyperWorkStage {
src/core.c/Rakudo/Iterator.pm6
20:# Generic role for iterating over a Blob / Buf.  You need to
23:our role Blobby does PredictiveIterator {
58:# Generic role for iterating over a Map / Hash.  You must
61:our role Mappy does Iterator {
82:# Generic role for iterating over a Map / Hash that has pairs
86:our role Mappy-kv-from-pairs does Iterator {
148:# Generic role for iterating over a >1 dimensional shaped list
156:our role ShapeBranch does Iterator {
246:# Generic role for iterating over a >1 dimensional shaped list
253:# role supplies an optimized .sink-all.
254:our role ShapeLeaf does Iterator {
417:my role AllButLastRole {
1788:# XXX TODO: Make this code DRYer by moving common bits to a role,
1790:# signature complains about immutable ints if done in a role, and
1791:# private methods in roles are slow, so we duplicated stuff here
2414:my role ListIndex {
2525:# An often occurring use of the Mappy role to generate all of the
2542:# An often occurring use of the Mappy role to generate alternating
2550:# An often occurring use of the Mappy role to generate all of the
4212:# ShapeBranchi roles, but without any additional processing.
This type cannot unbox to a native integer: P6opaque, Scalar
in sub want-lines at /home/jdv/rakudo/install/share/perl6/site/sources/15066A5E79B965690BA65EFE60430F617F71BC47 (App::Rak) line 991
in sub rak at /home/jdv/rakudo/install/share/perl6/site/sources/15066A5E79B965690BA65EFE60430F617F71BC47 (App::Rak) line 609
in block  at /home/jdv/rakudo/install/share/perl6/site/resources/0FFDA62CBE59FDD572FDAC1C05E0FDEB24029390 line 4
in sub MAIN at /home/jdv/rakudo/install/share/perl6/site/bin/rak line 3
in block  at /home/jdv/rakudo/install/share/perl6/site/bin/rak line 1
jdv@jdv-lap:~/rakudo$ raku -v
Welcome to Rakudo™ v2022.06-3-gd4e8b671a.
Implementing the Raku® Programming Language v6.d.
Built on MoarVM version 2022.06.
jdv@jdv-lap:~/rakudo$

This is actually a bug in spesh, that I haven't been able to golf yet :-(

Version 0.97 (just uploaded to fez) works around the spesh issue, afaik.  So closing this issue.  Please re-open if I got it wrong


Feature request: Auto-Completion Option

System Details

posh-git version/path: v<IP_ADDRESS>
PowerShell version: 5 .1.19041 .546
Git version: 2.17.1.windows.2
Operating system name and version: Windows 10, 19041.572

Issue Description
I want to request feature.
Example scenario:
I have two branches:

feature/first
feature/second

As of now, if I type f and hit tab autocompletion gives → feature/first.
I want it to give feature/ and after I type:
f then → feature/first or if I type s → feature/second

see https://github.com/dahlbyk/posh-git/issues/803


Remove COMCOM_HOST_EXTERNAL_IP and COMCOM_HOST_INTERNAL_IP_MAP.

Removed COMCOM_HOST_EXTERNAL_IP and COMCOM_HOST_INTERNAL_IP_MAP.
Updated getIpAddress() and getNetworkStatus() logic for HOSTING_ENV='comcom'

Thanks for the quick review! Now merging~


Update README coverage badge to point to actual coverage results

Right now, the project's README file shows a hardcoded 100% coverage badge (see here). To provide more accurate and dynamic coverage data, it would be ideal to link the badge to a coverage reporting service.
Suggested Solution:
I recommend using a coverage service like Codecov which is easy to set up and widely supported. There are other alternatives such as:

Coveralls: A popular alternative for code coverage tracking.
SonarCloud: Provides code quality and security analysis alongside test coverage.
Code Climate: Another robust option for code quality metrics including coverage reporting.

See #1 for the Codecov integration example.
Goal: Replace the hardcoded 100% coverage badge with one that dynamically reflects the actual coverage results hosted by one of the services above.

Blocked by https://github.com/Flexonze/django-auto-actions/issues/6


Mobile UI is broken

Safari nor Chrome show the hamburger menu. I can't even remember what the app should look like.

safari
chrome

iPhone 11 Pro
ios 14.4.2
Apologies if this is a duplicate issue, I skimmed and couldn't find it.

Mhm, Android has similar issue:

The menu can be pulled up which scrolls the browser down. So it seems we're not making the app full-viewport on mobile.

Should be fixed via https://github.com/excalidraw/excalidraw/pull/3508 — comment/reopen if there are any issues still.

Fixed indeed <3


Cannot send contact vcf files on Android

In this video, the app simply exits whenever I tap the vcf file

This is also an issue with the Android App. Moving it there. Closing this one. here is the new link: https://github.com/BlueBubblesApp/BlueBubbles-Android-App/issues/530


Need help on the elastic version

Hi,
Can some one please help me on this version. I am planning to update the gem .
Does the 7.1 version supports elastic 7.8 version with ruby 2.3 and rails 4.0.2?

Hi @nandueverurs,
7.1 should work fine with Elastic Stack 7.8. However Ruby 2.3 has reached it's end of life and is not receiving updates anymore. The gem might still work with this version of Ruby, but we can't guarantee it does since we don't test newer releases with EOL'd versions of Ruby. If you find any specific problems on the update, please open a new issue and I'll try to help out.

Hi @picandocodigo
Thanks Very much for your help. Will post here if we run into any problems. Closing this now.


Update to Espree 2.0

This includes, at a minimum, the following breaking changes that we'll need to adapt to:

[x] Remove guardedHandlers/handlers from try (eslint/espree#71)
[x] Change rest parameters to implement ESTree (eslint/espree#84)
[x] implement ESTree default parameters (eslint/espree#114)
[x] Implement ESTree Super node (eslint/espree#115)

Fixed on master.

Hello,
we're investigating the dependencies of jsdoc for making a debian package.
Doing so, i don't understand clearly why you moved to Espree.
Esprima doesn't look like it's dead, and so many modules depend on it.
We're trying to avoid packaging plural forks of a software, as you can understand, so i'm asking
to see if your answer can help me choose which one of Espree or Esprima should be packaged
in debian.
Thank you for your help.


Tyscript Failing when editing files on SharePoint 365 mapped drive

VSCode Version: Code 1.9.0 (27240e71ef390bf2d66307e677c2a333cebf75af, 2017-02-02T08:31:00.827Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: None installed

Extension
Author
Version

Steps to Reproduce:

Open folder on a mapped drive (in this case the mapped drive is to a SharePoint 365 site)
Receiving a recurring message about Typescript failing

Thanks. We're working with TypeScript to fix this: https://github.com/Microsoft/TypeScript/issues/13874
Closing as a duplicate


Remove third-party dependencies

see #2

LGTM. I just want to ask why the one named font file was replaced with multiple files not clearly named. It seems to be for different languages, yet I was curious if the old font file could still be used (albeit potentially with some added bandwidth) or if you could provide provenance on the replacement files. Thanks :)

I've now renamed the font files to make it more clear what they are used for. In the beginning, I tried to use the font file that was already there, but that didn't work out. Now the fonts files from Google are simply hosted locally.

Thanks for the clarification. I'll verify these are the actual font files (no reason to believe they aren't, just doing my job), and then will merge. Thanks :D


BUG: Fix Docker startup errors

The .jupyter directory does not exist in the Docker image.  This was the error output:
Generating a 2048 bit RSA private key
......................................................+++
.+++
writing new private key to '/root/.jupyter/jupyter.key'
/root/.jupyter/jupyter.key: No such file or directory
[...]
self.ssl_options['certfile'])
ValueError: certfile "/root/.jupyter/jupyter.pem" does not exist

Conflicts with https://github.com/quantopian/zipline/pull/1823

Coverage remained the same at 87.666% when pulling 028bbae10012375fde4ca1234fffe701b56e896d on Gaffney:fix-docker-errors into 30813860f52749efd0a53963d16e88a45491ef13 on quantopian:master.

Hey @Gaffney thanks for the PR! I've gone ahead and merged your branch into https://github.com/quantopian/zipline/pull/1823/files to include your commit and also fixed the merge conflict; I figured this might be easier so that one PR is reviewed rather than the 3 Docker PRs that are currently opened. Once #1823 is merged I'll go ahead and close this PR 😃

👍 sounds good.

superseded by https://github.com/quantopian/zipline/pull/1823


Remove legacy escaping

This uses the newly added conditionally escaped HTML from #569 in combination with text-element adjacency from #511 to remove some special cased exceptions for HTML to circumvent the AST. In doing so we can get rid of the last of the old ways of escaping things.
Before merge I'm going to apply similar tests to those I did in #495 (i.e. a combination of manual testing and seeing if OWASP Zap can find any XSS with safe mode enabled).
cc: @PhrozenByte for review :)

Fixes #573

No (actual) XSS issues found by Zap (one false-positive which is given below).


Save planned maintenance in separate file before deleting

In Zino1 there is a function that is not implemented that is supposed to dump the state of a planned maintenance to a file before deleting the planned maintenance (just like with events).

in this PM file, is it possible to get a list of the ids for tickets created and ignored by this PM?

in this PM file, is it possible to get a list of the ids for tickets created and ignored by this PM?

Yes, since one of the attributes of a PM is event_ids, which is a list that contains all events created/ignored by this PM and that will be dumped as well.


CI/CD: helm charts are bumped when there are changes to CRDs

Describe the bug
Build process was designed to fail with warning when there are CRD or Roles changes between 2 tags. With v0.0.0.alpha.2 it didn't happen and older helm chart was published.
To Reproduce
Steps to reproduce the behavior
In the local repository copy this should output the files list that changed, but it doesn't:
git diff  $(git rev-list --tags --max-count=2) --stat config/crd config/rbac

Expected behavior
Fail when CRD/Roles changed.

Apparently git rev-list --tags --max-count=2 returns:
3d517238438b618b5836f2bcf6753f79097da118
29e94ec1c86e5cd62eecddbe478b619ed73f5895

and the latter is not a tag.


Radial Status is missing from users image

Describe the bug
Radial Status is missing from users image - see image
Screenshots

Infomation (please complete the following information)
Discord channel: Stable
OS: Windows
Mod: BetterDiscord
Discord language: English
Unless I'm mistaken there used to be one there

No you're not mistaken. I removed it from that Avatar so it wouldn't conflict when talking in a voice chat.

No you're not mistaken. I removed it from that Avatar so it wouldn't conflict when talking in a voice chat.

Is there a way i can add it back? As i have hidden the circle that appears when in a voice chat, assuming we are talking about the same thing.
Are u talking about the ring that comes up in around the pfp in the image i sent?

this seeeeems to do it, could be more lines that should effect it but i can't tell the difference between having this and removing all :not(.avatar-1EWyVD)
#app-mount .wrapper-1VLyxH svg:not(:root) {
  overflow: visible;
}
#app-mount .wrapper-1VLyxH rect {
  x: 0;
  y: 0;
  width: 100%;
  height: 100%;
  -webkit-mask: none;
          mask: none;
  display: block;
  rx: var(--rs-avatar-shape);
  ry: var(--rs-avatar-shape);
  fill: transparent !important;
  stroke-width: var(--rs-small-width);
}
#app-mount .wrapper-1VLyxH:not([style*="80px;"]):not([style*="120px;"]):not([style*="16px"]) > svg > foreignObject:not(:only-child) img {
  -webkit-clip-path: inset(calc(var(--rs-small-spacing) + 1px) calc(var(--rs-small-spacing) + 1px) round var(--rs-avatar-shape));
          clip-path: inset(calc(var(--rs-small-spacing) + 1px) calc(var(--rs-small-spacing) + 1px) round var(--rs-avatar-shape));
}

this seeeeems to do it, could be more lines that should effect it but i can't tell the difference between having this and removing all :not(.avatar-1EWyVD)
#app-mount .wrapper-1VLyxH svg:not(:root) {
  overflow: visible;
}
#app-mount .wrapper-1VLyxH rect {
  x: 0;
  y: 0;
  width: 100%;
  height: 100%;
  -webkit-mask: none;
          mask: none;
  display: block;
  rx: var(--rs-avatar-shape);
  ry: var(--rs-avatar-shape);
  fill: transparent !important;
  stroke-width: var(--rs-small-width);
}
#app-mount .wrapper-1VLyxH:not([style*="80px;"]):not([style*="120px;"]):not([style*="16px"]) > svg > foreignObject:not(:only-child) img {
  -webkit-clip-path: inset(calc(var(--rs-small-spacing) + 1px) calc(var(--rs-small-spacing) + 1px) round var(--rs-avatar-shape));
          clip-path: inset(calc(var(--rs-small-spacing) + 1px) calc(var(--rs-small-spacing) + 1px) round var(--rs-avatar-shape));
}

I'll try this in a bit, think i tried removing :not(.avatar-1EWyVD) and it didnt work, i might have just done something wrong tho.
I went to the import link and copied the code for "--rs-dnd...." and pasted it into my theme file then removed the :not(.avatar-1EWyVD)

I just realized this was incorrect before editing cause I was fixing compatibility with another theme, just remove all instances of :not(.avatar-1EWyVD) from https://discordstyles.github.io/RadialStatus/dist/RadialStatus.css, and replace the import in your theme file with the entire result. but then you wont auto update which is tear moment

Ok will do, i replied before refreshing and only just saw ur edit. Thanks for the help.

I'm going to add it back. Last night I was not thinking. At all. I'm going to add a new variable --rs-self-speaking or something like that. But just decreasing the size of the speaking circle.
Example:

Should be good now.


Fix #2601 misuses of LMDB API

Only open DBI once, doesn't need closing.
Never reuse a txn handle after commit.
Use MDB_RDONLY for txns that aren't doing any writes

Hello @hyc ,
I finally had a chance to look at this in detail and one thing I wondered about:
There is a new member variable 'MDB_dbi m_dbi;' in the LMDB class -- which makes sense.
MDB_dbi is typedef'd to 'unsigned int', which means m_dbi is undefined initially.
The LMDB constructor will initialize it with a successful call to mdb_dbi_open.
But what if it fails? The return code from mdb_dbi_open isn't checked and we proceed as if it had been successful.
I had a look at both the LMDB documentation and (a brief) skim of the code and it doesn't look like a failure condition within mdb_dbi_open will result in the MDB_dbi out-parameter being updated to a special value or anything (that might have been checked for in subsequent calls to other functions).
Thoughts?

The default dbi, which is what your code uses, always exists and is always valid, so the mdb_dbi_open call will never fail.


Adding coco to voc conversion script.

Description
Adding functionality to convert from COCO to VOC.
Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[x] I have added tests covering my contributions.
[x] I have updated the documentation accordingly.
[x] This PR is being made to staging and not master
[x] I will squash merge this PR into staging

i didn't look with too much detail bc it looks like this notebook will still be edited(?) but this is great. really cool to see this analysis with coco dataset.

@jiata I finished the 04 notebook and addressed you questions - with questions of my own mostly :)

@jiata Regarding "update the dataset object itself to accept coco-annotations": totally agree. When we have an AI lab on object detection then could re-visit, based on the script I added in this PR. This could be a bit more work if we also want to support mask and keypoint annotations. For now I wanted to mainly unblock Raj.

@jiata ps, tried to run black on the cell, but it splits it up onto way too many lines.


Support OpenSearch Serverless

Fixes

#2036
#2302

Small question, otherwise looks good!

Hi guys,
Any updates on this, may i know the route map when the langchain-ai supports aoss?

Had a small question above, also can you please run yarn format and  yarn lint?

Had a small question above, also can you please run yarn format and yarn lint?

I'm not familiar with NodeJS, just noticed its JS branch, so it's available for python branch already?

Thank you!


Added support for /jobs endpoint

This PR adds support for the /jobs endpoint, adding Salt::Api.jobs(). This method takes an optional argument, jid. Without the argument, the method should return all jobs from the API; with the jid argument, it should return just the job with the matching JID.
EDIT: Updated the title, it was erroneous.

Awesome! Thank you!!

This should now be included in gem version >= 0.1.5


chore: split stack trace logic into separate module (#1854)

This change is

#1939  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.04%. Comparing base (992746e) to head (e19f218).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1939   +/-   ##
=======================================
  Coverage   78.04%   78.04%
=======================================
  Files          61       61
  Lines        8759     8759
  Branches     8759     8759
=======================================
  Hits         6836     6836
  Misses       1485     1485
  Partials      438      438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

+reviewer:@giladchase


Rename MatrixStatsAggregation.php to MaxAggregation.php

Cherry pick of #313 for Elasticsearch 6 and Symfony 3/4

@84m Would you please cut a new release 6.1.x release?

@jdreesen @saimaz @mvar @einorler
Hello everyone!
This Pull-Request is needed.
Composer v2.0.8 shows warning message when require "ongr/elasticsearch-dsl": "6.1.2":
Generating optimized autoload files
Class ONGR\ElasticsearchDSL\Aggregation\Matrix\MaxAggregation located in ./vendor/ongr/elasticsearch-dsl/src/Aggregation/Matrix/MatrixStatsAggregation.php does not comply with psr-4 autoloading standard. Skipping.

@jdreesen @saimaz @mvar @einorler
Hello everyone!
This Pull-Request is needed.
Composer v2.0.8 shows warning message when require "ongr/elasticsearch-dsl": "6.1.2":
Generating optimized autoload files
Class ONGR\ElasticsearchDSL\Aggregation\Matrix\MaxAggregation located in ./vendor/ongr/elasticsearch-dsl/src/Aggregation/Matrix/MatrixStatsAggregation.php does not comply with psr-4 autoloading standard. Skipping.


Build and publish Snapshot maven artifacts with build pipeline.

Signed-off-by: Marc Handalian<EMAIL_ADDRESS>Description
Add a parallel step to the nightly build job to build and publish snapshots to https://aws.oss.sonatype.org/content/repositories/snapshots/
Corrected publish-snapshot script to use the correct URL and credential variables.
Ran this and verified artifacts are present.
Issues Resolved
closes #349
Check List

[x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Do we want to also implement maven publishing in our bundle-workflow system in Python in the future? Would make it testable and probably more reliable.


Instance segementation support for YOLOX

Hi, do you have plans to support instance segementation ?

No.

OK, thanks for your response.


Add esmav.edu.mx Institution

@fgalicia Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@emr058 Please create a separate pull request for your school.

@fgalicia You might miss my previous comment. Please react.

@fgalicia I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Factor asciimathteximg

Ahoy! Without changing too much, I packaged up AMTparseAMtoTeX into an npm module as we discussed in #47 . I tried to make it so you could easily publish this to npm if you'd like.
The api for the module is:
var AMTinit = require('ascii-math-to-latex');
var convert = AMTinit(options);

var latex = convert('y = (-b +- sqrt(b^2-4ac))/2a');

I included two ultra-simple tests, which honestly I just trusted the existing output w/o verification.

(actually as discussed in #48 )
Note: this duplicates a bunch of code - if you were interested in incorporating this back into the original project, you'd require this code in the old code. Let me know if I can help w/ any of that!
Thanks again for a great project!

My OCD wants me to close this PR, but feel free to use the code in this branch with or without attribution as you see fit!


How can I filter the data?

Hi, if I want to move a subset of the records of an entity, how can I do that? For example, I want to extract the roles modified in the last 2 weeks? Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 939451f0-9363-a3bd-047c-da83f1e717d0
Version Independent ID: 94942fce-cd1d-284d-f22d-f7e21e93d19c
Content: Create a schema to export configuration data (Dynamics 365 for Customer Engagement)
Content Source: ce/admin/create-schema-export-configuration-data.md
Service: crm-online
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@charliechen179
Filtering of entity records isn’t supported by the tool as mentioned here: https://docs.microsoft.com/en-us/dynamics365/customer-engagement/admin/manage-configuration-data.

@jimholtz Thanks.


Consistent tests for calculate trajectory function in Scwarzschild

🐞 Problem
Even though, schwarzschild and kerr geometries are pretty similar, their tests seem different.
🎯 Goal

Edit test_calculate_trajectory() in tests/test_metric/test_schwarzschild.py on the lines of same function present in test_kerr.py for consistency.
Get the schwarzschild metric by from einsteinpy.utils import schwarzschild_utils and g = schwarzschild_utils.metric()

📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Fixes #168
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

@shreyasbapat Seems like a good first issue

i would like to work on this.

i would like to work on this.

@alpeshjamgade Thanks for your interest.
Issue is all yours!

My question is why do you want consistency in tests?

My question is why do you want consistency in tests?

When the test was written, metric() was not there in schwarzschild_utils.py. Now that it is there, it seems like a good idea that test_calcultate_trajectory() in test_schwarzschild.py, test_kerr.py and test_kerrnewman.py follows the same pattern. Plus, it was also a good first issue.

When the test was written, metric() was not there in schwarzschild_utils.py. Now that it is there, it seems like a good idea that test_calcultate_trajectory() in test_schwarzschild.py, test_kerr.py and test_kerrnewman.py follows the same pattern. Plus, it was also a good first issue.

Great!

When the test was written, metric() was not there in schwarzschild_utils.py. Now that it is there, it seems like a good idea that test_calcultate_trajectory() in test_schwarzschild.py, test_kerr.py and test_kerrnewman.py follows the same pattern. Plus, it was also a good first issue.

Great!


Assertion failure in ScheduledMerges prototype

https://github.com/IntersectMBO/lsm-tree/actions/runs/9351899757/job/25738763256?pr=235

I found the problem. A last level merge can result in a run of length 0, triggering an underflow issue:
tieringRunSizeToLevel r =
    1 + (finiteBitSize s - countLeadingZeros (s-1) - 1) `div` 2
  where
    s = Map.size r

I could reproduce the failure using the Quickcheck seed and the error goes away when handling s == 0 in the calculation above. I will open a PR later.


@azure/arm-consumption - Issues on getting correct data - v9.0.0

Hi,
I'm currently upgrading @azure/arm-consumption from 6.3.0 to 9.0.0, but I'm hitting issues on 9.0.0 that I'm not able to overcome.
I'm using the library in the following way:
let azConsumptionClient = new ConsumptionManagementClient(new DefaultAzureCredential(), subscriptionId);

const query = `properties/usageStart eq '2022-01-01T00:00:00.000Z' and properties/usageEnd eq '2022-01-01T23:59:59.999Z'`

let azBillingData = azConsumptionClient.usageDetails.list(`subscriptions/${subscriptionId}`, { filter: query });

for await (const azBillingEntity of azBillingData) {
            console.log(azBillingEntity);
}

My problem then comes in the form of missing information in the azBillingEntity, there is no information about the actual UsageDetails  there should be available on the response.
I've tried to use used the exact same parameters on the API documentation website, and with the same parameters I get the correct information.
Please advice on how to proceed, is it me that is using the iterators in a wrong way?
Br,
Jesper

Just to add some context, the JSON I'm getting back from the code above are in the following format.
[{
    "id": "<USAGEID>",
    "name": "<NAME>",
    "type": "Microsoft.Consumption/usageDetails",
    "tags": null,
    "kind": "legacy",
    "meterId": "<METERID>"
}]

So it's basically missing all the useful information in the JSON object, as far as I can see I'm only getting UsageDetail and not the full LegacyUsageDetail.

I will take a look at this issue later

@JesperJakobsen Hi, I can't repo your issue, could you try it again and see if it has been resolved ?

Hi @qiaozha,
I'll take a look look ASAP report back if the issues has been resolved!

So I just tried to use the code above and it's still not working as i only get partial information back, but I can get the information directly from the API which will have to do for now.

Hi @qiaozha,
I can confirm I'm running @azure/arm-consumption v9.0.0.
I'm not quite sure what my subscription type has to do with this issues as I can get the data directly from the REST API, which I assume is used in the SDK.
I'm calling the API directly with the code below, with the same AZ CLI identity, and I'm getting the correct data back.
let queryFilter = `properties/usageStart eq '${startDate}T00:00:00.000Z' and properties/usageEnd eq '${endDate}T23:59:59.999Z'`;
let queryScope = `subscriptions/${subscriptionId}`;

let url = `https://management.azure.com/${queryScope}/providers/Microsoft.Consumption/usageDetails?api-version=2021-10-01&$filter=${queryFilter}`;
let result = await fetch(url, {
    headers: {
        "Authorization": `Bearer ${azAuthTokenResponse.token}`
    }
});
let json = await result.json();
let billingData = json.value;

Do you do any filtering inside the SDK based on Offer Type?

SDK won't do any filter. can you debug in your side and see what the original response look like in the SDK as I can not repro it on my side.

I'm having the same issue as @JesperJakobsen
Still having the same result
[{     "id": "<USAGEID>",     "name": "<NAME>",     "type": "Microsoft.Consumption/usageDetails",     "tags": null,     "kind": "modern",     "meterId": "<METERID>" }]
I even tried copying @qiaozha 's work.. but still  not luck

I don't think Service Principal could be the cause, but let me try and get back to this.

here are the versions I'm using
all other items I pull returns the way they are, except for usageDetails
"dependencies": {
        "@azure/arm-billing": "^4.0.0",
        "@azure/arm-compute": "^17.1.0",
        "@azure/arm-consumption": "^9.0.0",
        "@azure/arm-dns": "^5.0.0",
        "@azure/arm-locks": "^2.0.0",
        "@azure/arm-network": "^26.0.0",
        "@azure/arm-resources": "^5.0.0",
        "@azure/arm-storage": "^17.0.0",
        "@azure/identity": "^2.0.1",
        "@azure/keyvault-secrets": "^4.3.0",
        ...

verified Service Principal is not the cause
I tried it on postman and got the needed details using same details:
client Id
client secret
subscription
tenant id
scope
I think this is only an sdk issue

can you also share the package-lock.json about the @azure/arm-consumption part?

It's weird that I can't repro it and when you call rest api directly, it works fine.

this is my yarn.lock
"<EMAIL_ADDRESS>  version "9.0.0"
  resolved<EMAIL_ADDRESS>  integrity sha512-TUPIdTGWE28sFBs7XDK//OZKlGtblbo1T7zs+lK0f1CaVzjitgbrohk7T24dfF2hinaKBkyFv3/od7qhj4oBtg==
  dependencies:
    "@azure/core-auth" "^1.3.0"
    "@azure/core-client" "^1.0.0"
    "@azure/core-paging" "^1.2.0"
    "@azure/core-rest-pipeline" "^1.1.0"
    tslib "^2.2.0"
    ```

    it's same as yours

    I hate it when code God is playing with me

@qiaozha could this be caused by node version? currently we are using 12.22.6 and we can't upgrade it for now

I don't think so, because I am using node 12 as well.

@JesperJakobsen  can you try to debug into the SDK code to see what's the original response the SDK get when you call the SDK ?

I have the same issue running on v.9.0.1

@pedrosaraiva Thanks for the information. I will look into it.


Fixing WS-RM test

WildFly pull requests Build 3677 outcome was SUCCESS using a merge of 4599a2bd80d82bfb24b4ffb289311c5ba9489a39
Summary: Running Build time: 00:00:03


Cleaned hyperparams and save hyperparams feature

Small PR to clean up the hyperparameter treatment to make it similar to flowMC's.
Also added a small function that saves the hyperparameter values used for both flowMC as well as jim to a JSON file, for reproducibility of jim runs. Let me know if you think this is useful to have.

Thanks for updating the API. Would you mind going through the pre-commit to make sure the code is formatted correctly?

Sure! I will get back to you ASAP with the fixed formatting

This needs to be checked again with the jim version update, I will close it for now and get back to it later on.


allow maintainers to apply for badge

This issue came up from this slack conversation

@kaxada I think we can close this issue for now since the decision was made to only have project owners apply for badges. Site has been updated now accordingly to indicate ownership requirement.

yeah sure. Thanks @dm-murphy


Communicator API improvement

The name allreduce_grad is not right because it is only for models and also does division. Would be a good time to update its name.
Make communicator contextmanager - https://github.com/chainer/chainer/pull/6636 revealed an issue that object lifecycle (the timing GC'd) cannot be controlled.

maybe I had a case I needed scatter_obj for re-inventing scatter_dataset

I had a case for supporting more operators in allreduce_obj()  for calculating max and min.

I made a todo list.

[ ] rename allreduce_grad() and functions related with it
[ ] add finalize()
[ ] support for more operators in allreduce() and allreduce_obj() for calculating max and min.
[ ] support for batched copy mode in all communicators

It's not an API improvement, but let me add another TODO:

[ ] removed deprecated communicators / functions

support for batched copy mode in all communicators
is related to #7543

We've changed our mind that we won't work on "allreduce() and allreduce_obj() for calculating max and min" so soon as we don't need it right now.

done


The Weeknd - Hold Your Heart

Can you make it with The Weeknd AHTD Live vocals

yes if it's the official recording from the live which not have much noise from viewer


Adding Alonzo UTXOS rules to the ledger

Description
This pull request adds the additional Alonzo script definitions detailed in issue  #153.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] Code is formatted according to CONTRIBUTING.md
[ ] Self-reviewed the diff

Thank you for that fix, I was just about to work on it


Improved .net build and package.

Produce 2 types of Nuget packages:

One managed package: Google.OrTools with the managed binary for Swig C# wrapper and Protobuf C# classes.
3 unmanaged packages: Google.OrTools.runtime.{win-x64, linux-x64, osx-x64} with the native binaries for Swig C++ Wrapper and OrTools for each platform.

Simplified/unified .net projects (csproj files).
Added symbols (pdb) file to Nuget package for managed binaries.
Added documentation (xml files) to Nuget package for managed binaries.
Added target framework net452 in order to provide support for consumers using .net framework >= 4.5.2 (on Windows only).
Added build target (Google.OrTools.runtime.win-x64.target) for .net framework consumers that handles copying of native binaries to build output directory (in order to prevent "FileNotFoundException" for Google.OrTools.runtime.win-x64.dll).
MakeFile: added explicit build and packaging arguments for "Release", "x64", "include-symbols".
Removed producing of reference assembly approach.
Removed Protobuf files (.proto) from Nuget package in order to prevent copying them into Nuget consumers project.

Deployment:

On Osx: make dotnet => take Google.OrTools.runtime.osx-x64.nupkg
On Linux: make dotnet => take Google.OrTools.runtime.linux-x64.nupkg
On Windows:

Put all runtime dependent Nugets from pervious steps into ortols/packages folder: Google.OrTools.runtime.osx-x64.nupkg, Google.OrTools.runtime.linux-x64.nupkg
make dotnet =>  produces Google.OrTools.runtime.win-x64.nupkg (with netstandard, net452), Google.OrTools.7.3.7113.nupkg (with netstandard, net452), Google.OrTools.FSharp.7.3.7113.nupkg (with netstandard, net452) (and symbols nugets)

=> Deployment of NuGet files: ensure you took Google.OrTools.runtime.win-x64.nupkg, Google.OrTools.7.3.7113.nupkg, Google.OrTools.FSharp.7.3.7113.nupkg  (and symbols Nugets) from the Windows build, only these contain the netstandard and net452 managed binaries
General advises for consumers of the Nuget packages:

ensure solution and project configuration is x64
for netframework users on Windows: a restart of the IDE  may be needed after install/update NuGet.

Sample Solution with netFramework (Windows only) and netCore (cross-platform) project consuming OrtTools:
ConsumerExamplesNet.zip
Current Nugets, build for Windows and Linux (Can not upload symbol packages, because they are too big to upload):
Google.OrTools.7.3.7113.nupkg.zip
Google.OrTools.FSharp.7.3.7113.nupkg.zip
Google.OrTools.runtime.linux-x<IP_ADDRESS>13.nupkg.zip
Google.OrTools.runtime.win-x<IP_ADDRESS>13.nupkg.zip

@googlebot I fixed it..

A good test would be to go in tools/docker and type make archive. It will test various linux builds.
In particular, there is a workaround for inconsistent naming on the CentOs platform.

Still, very impressive.

Sorry, Can you build this against master. I know this is a pain.

Still, very impressive.

Thanks!

Can you build this against master. I know this is a pain.

Do you mean rebase my PR on master?

all PR shoud be against master.
Stable is just a delivery branch
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mer. 14 août 2019 à 07:48, Peter Bruch<EMAIL_ADDRESS>a
écrit :

Still, very impressive.
Thanks!
Can you build this against master. I know this is a pain.
Do you mean rebase my PR on master?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1500?email_source=notifications&email_token=ACUPL3JSP5PLOZ5OMGVJF5TQEQLLBA5CNFSM4ILTYZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JBFNQ#issuecomment-521278134,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3KW7ZMB57L3QAJTMF3QEQLLBANCNFSM4ILTYZFQ
.

And don't worry on the timing.
I will not release anything before September.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mer. 14 août 2019 à 07:52, Laurent Perron<EMAIL_ADDRESS>a écrit :

all PR shoud be against master.
Stable is just a delivery branch
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68
53 00
Le mer. 14 août 2019 à 07:48, Peter Bruch<EMAIL_ADDRESS>a
écrit :

Still, very impressive.
Thanks!
Can you build this against master. I know this is a pain.
Do you mean rebase my PR on master?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1500?email_source=notifications&email_token=ACUPL3JSP5PLOZ5OMGVJF5TQEQLLBA5CNFSM4ILTYZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JBFNQ#issuecomment-521278134,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3KW7ZMB57L3QAJTMF3QEQLLBANCNFSM4ILTYZFQ
.

Some short ideas:

Later it would be possible to create 1 Nuget package containing the managed (cross-platform) binary and all the platform-dependent binaries. See for example the Microsoft sqlite Nuget:

But therefore we would need to separate building of platform-dependent binaries and packaging  of the built binaries
I targeted the Nugets to netstandard2.0 (as before) and netframework 4.5.2. In my opinion, the could be easily targeted to netstandard1.1 and netframework45. This would allow more people using OrTools. The code generated by Swig/Protobuf is very low level and does not need any of the later .net features.

Cannot use net standard 1.1. it is not compatible.with swig.
Le mer. 14 août 2019 à 08:15, Peter Bruch<EMAIL_ADDRESS>a
écrit :

Closed #1500 https://github.com/google/or-tools/pull/1500.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1500?email_source=notifications&email_token=ACUPL3LO22R3U7FI357QH53QEQORLA5CNFSM4ILTYZF2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTBUBURA#event-2556959300,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3JZD3K3R3FGAD3PX4DQEQORLANCNFSM4ILTYZFQ
.

You need to re-sign the CLA I believe (and do not undestand why)

and there is only one file in the re-opened PR. I guess you are rebuilding it.

Sorry rebasing was confusing, I hope now it's done.

I do not get it with the tests:
\tools\docker>..\make.exe archives
mkdir -p export/centos-7
The syntax of the command is incorrect.
..\make.exe: [export/centos-7/docker_devel.tar] Error 1 (ignored)
docker image rm -f or-tools_centos-7:devel 2>/dev/null
The system cannot find the path specified.
..\make.exe: [export/centos-7/docker_devel.tar] Error 1 (ignored)
rm -f export/centos-7/docker_devel.tar
process_begin: CreateProcess((null), rm -f export/centos-7/docker_devel.tar, ...) failed.
make (e=2): The system cannot find the file specified.
..\make.exe: [export/centos-7/docker_devel.tar] Error 2 (ignored)
cp or-tools.snk export/centos-7/
process_begin: CreateProcess((null), cp or-tools.snk export/centos-7/, ...) failed.
make (e=2): The system cannot find the file specified.
..\make.exe: *** [export/centos-7/docker_devel.tar] Error 2

Because XML doc is not defined (SWIG does not create it), I get a lot of errors
https://travis-ci.org/google/or-tools/jobs/571910201
This breaks Travis.
Can you silence warning CS1591?
/home/travis/build/google/or-tools/ortools/sat/csharp/IntegerExpressions.cs(76,24): warning CS1591: Missing XML comment for publicly visible type or member 'LinearExpr.GetIndex()' [/home/travis/build/google/or-tools/ortools/dotnet/Google.OrTools/Google.OrTools.csproj]

I always build it on mac or linux. Not sure the makefile works on windows.
I looked at travis. There are too much warning (my previous message).
Also, there was a trick for CentOS that created assemblies in a different
directory. I wanted to test that.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mer. 14 août 2019 à 09:55, Peter Bruch<EMAIL_ADDRESS>a
écrit :

I do not get it with the tests:
\tools\docker>..\make.exe archives
mkdir -p export/centos-7
The syntax of the command is incorrect.
..\make.exe: [export/centos-7/docker_devel.tar] Error 1 (ignored)
docker image rm -f or-tools_centos-7:devel 2>/dev/null
The system cannot find the path specified.
..\make.exe: [export/centos-7/docker_devel.tar] Error 1 (ignored)
rm -f export/centos-7/docker_devel.tar
process_begin: CreateProcess((null), rm -f export/centos-7/docker_devel.tar, ...) failed.
make (e=2): The system cannot find the file specified.
..\make.exe: [export/centos-7/docker_devel.tar] Error 2 (ignored)
cp or-tools.snk export/centos-7/
process_begin: CreateProcess((null), cp or-tools.snk export/centos-7/, ...) failed.
make (e=2): The system cannot find the file specified.
..\make.exe: *** [export/centos-7/docker_devel.tar] Error 2
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1500?email_source=notifications&email_token=ACUPL3KMC4LWUKUAR5CTCQLQEQ2HPA5CNFSM4ILTYZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JNR6A#issuecomment-521328888,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3PIAJL5ABHFU6NCJHDQEQ2HPANCNFSM4ILTYZFQ
.

I disabled the CS1591 in the projects.
On Linux I also can not make archives. The problem was the missing signing key (or-tools.snk). I copied it and now it seems to run.

Now make archives hangs on
The command '/bin/sh -c git clone -b "${SRC_GIT_BRANCH}" --single-branch https://github.com/google/or-tools && echo "sha1: $(cd or-tools && git rev-parse --verify HEAD)" && echo "expected sha1: ${SRC_GIT_SHA1}"' returned a non-zero code: 128
make: *** [Makefile:147: export/centos-7/docker_devel.tar] Error 128

I will check that after the holiday.

A good test would be to go in tools/docker and type make archive. It will test various linux builds.
In particular, there is a workaround for inconsistent naming on the CentOs platform.
Actually, you need it to be committed :-(

I ran make archive  in tools/docker with success.

I additionally changed the name of the native libraries from Google.OrTools.runtime.{win-x64, linux-x64, osx-x64} to google-ortools-native.
Before we produced 3 different managed dll's for the Swig C# wrapper and used the name of the runtime as argument for the DLLIport of the PInvoke interfaces:

Now we only produce one managed dll and therefore can not use the runtime suffix for the dll import (because it will the only have the name of one build platform).
We let the runtime decide which dll/so/dynlib will be referenced. This is also recommended for referencing different platform native libraries from PInvoke see: Interop with Native Libraries

Will these be separate nuget packages ?
if yes, please keep the name. We do not own google-ortools-native.
It no, then you can proceed.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mer. 4 sept. 2019 à 16:43, Peter Bruch<EMAIL_ADDRESS>a
écrit :

I additionally changed the name of the native libraries from Google.OrTools.runtime.{win-x64,
linux-x64, osx-x64} to google-ortools-native.
Before we produced 3 different managed dll's for the Swig C# wrapper and
used the name of the runtime as argument for the DLLIport of the PInvoke
interfaces:
[image: before]
https://user-images.githubusercontent.com/582627/64264655-f0b12880-cf31-11e9-97eb-2a4381bc36c1.png
Now we only produce one managed dll and therefore can not use the
runtime suffix for the dll import (because it will the only have the name
of one build platform).
We let the runtime decide which dll/so/dynlib will be referenced. This is
also recommended for referencing different platform native libraries from
PInvoke see: Interop with Native Libraries
https://www.mono-project.com/docs/advanced/pinvoke/#library-names
[image: now]
https://user-images.githubusercontent.com/582627/64264824-3837b480-cf32-11e9-930d-4e97d08e6ddc.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1500?email_source=notifications&email_token=ACUPL3JEHUXUV7RBE3DADIDQH7CP5A5CNFSM4ILTYZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53Z4ZY#issuecomment-527933031,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3N7WPTMU73UT75RDTLQH7CP5ANCNFSM4ILTYZFQ
.

The name of the NuGet packages dit not change! Only the name of the native library (binary).

From my point of view I am finished with the PR . Did I miss something?

Thanks a lot!

@ptr1120 as you pointed out by renaming the rid dll now it should work.
For the record:
Before the Google.OrTools package (let's call it meta package) only contains the reference files (i.e. the symbols list) while each rid packages contain all the .cs implementation i.e. the C# classes which are platform agnostic BUT also the *PInvoke.cs file which were platform specific (especially the library suffix name) by using a generic name without suffix we can now effectively move all the code in the meta package and only keep the rid package to load the C++, platform specific, libraries and dependencies.
I'll try to update the dotnet devel doc here: https://github.com/google/or-tools/tree/master/ortools/dotnet
ps: sorry to not talk about this 17 day ago during my first review, my bad.

@Mizux: no problem. If I understand you correctly you want to make one Nuget package which contains the managed (C#) library and the platform-dependent native binaries (as mentioned here ???

@ptr1120 I don't think so, currently we have/use a windows vm, a macos and a linux desktop to generate each dependencies and the release since most of them don't support cross toolchain etc...
So I guess we will keep rid package to encapsulate the dependencies and the C++ stuff (which are build on their respective platforms BTW) and one meta package containing all the managed/PInvoke CS stuff which is platform agnostic thanks to your patches.
Up to now we were compiling the cs code on each platform and hoping to have a identical reference file so we can put it in the meta package.
Making one package means to be able to first grab all artifacts (i.e. libraries) then generate the monolithic package but i don't see any advantage here. Also we have few user we just want to build for their local host so currently if you build only one rid and the meta it also works if we put some condition like having all the artifacts from all platforms available to build the mono package (to avoid the break a release) we may loose this scenario.
Also I pretty sure we should be able to only depends on the needed rid so a windows user won't have to download the linux and mac rid in the future to use OrTools with a mono package you'll always download the three...
note: Microsoft also have rid packages https://www.nuget.org/packages?q=-x64.Microsoft.NETCore this is where our naming convention comes from modulo we only own "Google." (only Microsoft can reserve ^runtime.. packages

Ok, thanks for the explanations, now I understood that your comment was just for information.
Just a reminder: it would be great if the described release build order will be respected as mentioned in : 1. Linux, 2. Osx and important 3. Windows. Because of the meta NuGet package Google.OrTools.nuget is generated at all runtimes, but only the last from Windows contains the netframework binary (additionally to net netstandard2.0 binary).

@ptr1120 agree with you, when we upload a new release we must take the windows meta package. Thx for the reminder

Which date can we expect to get this released. I am waiting eagerly for the improvement.
Thanks
Andreas

Before the end of september.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mar. 10 sept. 2019 à 11:56, CubusAnderl<EMAIL_ADDRESS>a
écrit :

Which date can we expect to get this released. I am waiting eagerly for
the improvement.
Thanks
Andreas
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1500?email_source=notifications&email_token=ACUPL3LED3RRKTWVWATLKZLQI5VL5A5CNFSM4ILTYZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6KRFAY#issuecomment-529863299,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3LPTT7GW6BZNYLLVUDQI5VL5ANCNFSM4ILTYZFQ
.

I am travelling. Mid October at the earliest.
Le mer. 2 oct. 2019 à 11:41, Quentin Douziech<EMAIL_ADDRESS>a
écrit :

Hello !
First of all thank you so much for your work !
Is there any planned release date (on Nuget) for this ticket ? I work on
.Net Framework and this will help me a lot.
Once again thanks for the amazing work :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1500?email_source=notifications&email_token=ACUPL3KWC46YIAZENH2WRX3QMS6KDA5CNFSM4ILTYZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFGQ5Q#issuecomment-537553014,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3IVTGR3N247OY6YVMDQMS6KDANCNFSM4ILTYZFQ
.


[FEATURE] allow disabling of axis updates

When multiple lines are drawn ChartJS appears to dynamically calculate a sensible maximum for the corresponding axis based on all displayed data.  When a line is disabled the axis values are dynamically updated to fit the revised data.
Some users may find this behaviour confusing and I'd like to disable it.  I looked hard for an option to do so but couldn't find one.
I know you can set [axis].ticks.max manually; but I'm displaying dynamic data and scales change significantly between datasets.  Since ChartJS already calculates a sensible maximum value it would make sense to have an option to apply this as a permanent maximum for the axis; or alternatively to provide an option to disable the updating of axis values when lines are disabled.
I managed to hack around this by iterating over myChartInstance.scales and then myChartInstance.options.scales.yAxes in order to dynamically apply the max to the axis; but that feels rather convoluted!

I think this would make a good plugin that calculates the same data min/max as the internal code and updates the axis min and max settings accordingly

+1 for a simple workaround. After digging into the code, it seems the min/max calculation is non-trivial. That said, I'm curious what plugin hook(s) might be helpful here. Does anybody know of an existing plugin?
I hacked together a convoluted workaround that temporarily sets each dataset's associated meta.hidden to false, which tricks determineDataLimits into using all of the data for min/max. Here it is, applied as a default to linear scales:

Chart.scaleService.updateScaleDefaults('linear', {
    beforeDataLimits: function (axis) {
        var chart = axis.chart;
        Chart.helpers.each(chart.data.datasets, function(dataset, datasetIndex) {
            var meta = chart.getDatasetMeta(datasetIndex);
            meta._hidden = meta.hidden;
            meta.hidden = false;
        });
    },
    afterDataLimits: function (axis) {
        var chart = axis.chart;
        Chart.helpers.each(chart.data.datasets, function(dataset, datasetIndex) {
            var meta = chart.getDatasetMeta(datasetIndex);
            meta.hidden = meta._hidden;
        });
    },
});

Here's a simpler hack, that seems to work better for me:
Chart.scaleService.updateScaleDefaults('linear', {
    afterUpdate: function (axis) {
        // Fix scale range after initial update, if not already fixed
        _.defaults(axis.options.ticks, { suggestedMin: axis.min, suggestedMax: axis.max });
    }
});

The work around above is probably the best way to achieve this, even now. Maintain functionality that updates the user's options is not something we want to ship as a core feature.


Form fields with Bulma CSS framework get styled with x-danger after load

I have integrated vue-form in my vuejs project that uses bulma css framework for styling. I am using .vue (template + script + style) as opposed to .js and it was a bit of a challenge because I am new in vuejs as well as there isn't any instructions in the repo.
My questions are

Is the setup of VueForm correct? in main.js as well as how the formstate is inside the return {} as a property?
How can I make the form fields with bulma css behave like fields with bootstrap? I might have to disable/enable some state|value of formstate on created maybe.

Here is a JSFiddle link with Bulma https://jsfiddle.net/rhamedy/xxrLctok/1/
Converted css classes from bootstrap to bulma
has-success  to is-success
has-danger to is-danger
definition of VueForm in main.js
import VueForm from 'vue-form';
Vue.use(VueForm, {
 inputClasses: {
    valid: 'is-success',
    invalid: 'is-danger'
  }
});

the script block looks as follow
export default {
    data() {
      return {
        data: {
          formstate: {},
          email: '',
          password: '',
          name: ''
        }
      };
    },
    methods: {
      onSubmit: function() {
        if(this.data.formstate.$valid) {
          alert('Valid form submitted!');
        } else {
          alert('Form is not valid.')
        }
      },
      fieldClassName: function (field) {
        console.log(field);
        if(!field) {
          return '';
        }
        if((field.$touched || field.$submitted) && field.$valid) {
          return 'is-success';
        }
        if((field.$touched || field.$submitted) && field.$invalid) {
          return 'is-danger';
        }
      }
    }
  }

style
.required-field > label::after {
    content: '*';
    color: red;
    margin-left: 0.25rem;
  }

and the vue-form looks as follow
<vue-form :state="data.formstate" @submit.prevent="onSubmit">
<validate auto-label class="form-group required-field" :class="fieldClassName(data.formstate.name)">
          Name
          <input type="text" name="name" class="input" required v-model.lazy="data.name">
          <field-messages name="name" show="$touched || $submitted" class="form-control-feedback">

Success!

Name is a required field

          </field-messages>
        </validate>
</vue-form>

And loading the page before interacting with the fields, the fields by default has the is-danger css styling.
Thanks.

One way to do it is remove the inputClasses config
 inputClasses: {
    valid: 'is-success',
    invalid: 'is-danger'
  }

And move :class="fieldClassName(formstate.name)" from the <validate> element to the <input> element.
https://jsfiddle.net/xxrLctok/2/


Missing Markers for every jigsaw object

Describe the problem
Missing Markers for every jigsaw object
What Should Happen
Add those markers
What Biome
Every biome they appear
Object Id
No response
Minecraft Version
1.17
Iris Version
1.8.10
Relevant log output. (IF APPLICABLE)
No response
Checklist

[X] I am using an unmodified version of the overworld. (If you modified the overworld and see an issue, contact support)
[X] I am using the latest version of the overworld OR I have made sure this issue was not already resolved on the latest version.
[X] I am using Spigot, Paper, Tuinity, or Purpur. (If you are not, and still think it is a valid issue, contact support)

Working on 1.9


Misalignment in text and design view's + sign in Switch mediator.

Description:
When creating cases in the Switch mediator, if a long text is provided for the case regex, the text in the case branch and the + sign in the design view become misaligned, as shown in the image below.

Product Version
v1.0.3
Describe your problem(s)
Describe your solution(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

The latest release v1.1.1 has resolved the issue. Please reopen if the problem persists.


Adding LICENSE file to patches directory

Adding license to patches directory. https://github.com/ZOSOpenTools/meta/issues/103

incorporate into current PR


Xcode 15 changes and warnings fixes

Xcode 15 compatibility changes.
Merged warnings fixes from @gongzhang

Maintained fork here: https://github.com/segment-integrations/swift-create-xcframework


Qt viewer

Add a useful qt-based viewer to allow better parameter tweaking and easier start with the project.

Coverage remained the same at 77.883% when pulling 75a413af91c3b5b4550c70736eb7731b559301a5 on qt_viewer into a70d6c51b5f5542ea57eabaa34e2a2faab78c601 on master.

Coverage remained the same at 77.883% when pulling 75a413af91c3b5b4550c70736eb7731b559301a5 on qt_viewer into a70d6c51b5f5542ea57eabaa34e2a2faab78c601 on master.

Coverage remained the same at 77.883% when pulling 43d5b745b7de85710a6f194dbf1c6114bc675883 on qt_viewer into a70d6c51b5f5542ea57eabaa34e2a2faab78c601 on master.


feat: integrate ibc fee middleware

Description
This PR integrates ibc fee middleware for ibc modules, allowing the relayer operators to receive tokens when submit the ibc transactions.
This integration follows this guide.
Note:
The channel to support ibc fee middleware should have the version like:
{"fee_version": "ics29-1", "app_version": "ics20-1"}

If the version does not include fee_version, for example ics20-1, then the channel will be considered without middleware, then passing the version onto underlying IBC module and also tagging the channel is not FeeEnabled. The channel version is set in relayer side. So it should work properly integrate ibc fee in our side app only. See here.
Depends-On: #1079

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[x] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

@dependabot rebase

@dadamu Can you rebase this PR on top of master?


Update AliCloud for VPC support and some small changes

Support perf test in VPC network in AliCloud.
Fix a bug when creating instance with I/O optimized
Prefix the flag with ali_
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/611/files#diff-f0e4cdc27d0409f2edd6208085ce97cbR43

@ehankland  Can you review this as well.  Thanks.

Thank you for review again, I just updated.

@ehankland @voellm
Can you review the last commit  'b1e6ea5' ? thanks!

LGTM - I recommend squashing some of the commits to make the history cleaner. Let me know when you want me to merge

How about today?  What can I do for you?
Thanks!

correct some mistakes in README.md

Merged - thanks!


[Enhancement]: Improving UI and adding Home Icon in "Brain Burst Game"

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Game enhancement

I will enhance the UI of the game as enhancing the game's visual appeal is essential for creating a compelling, enjoyable, and professional experience that attracts and retains players.
I will add a Home Icon, adding it will improve the game's usability, making it more user friendly and accessible, which can lead to higher user satisfaction and retention.

Describe the solution you'd like
Solution steps

Visual Appeal: Adding gradients, shadows, and rounded corners to create a modern look.
Interactivity: Implementing hover effects and transitions for a more engaging user experience.
Readability and Usability: Improving text visibility and providing clear visual feedback.
Home Icon: Adding Home Icon at the top of the game, it will help players to navigate to the Home Page easily.

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

/assign


Documentation editor does not allow saving Unicode Supplementary Characters

I was editing the following page:
String.fromCodePoint()
and was attempting to add the actual character(s) returned by each statement in the existing inline comment to the right of each statement. This would greatly help readers more quickly comprehend the relationship between the input values and the actual behavior of the method. However, each time I tried to "Publish", I would get a "500 Internal Server Error" message. Figuring that the problem was most likely the Unicode characters (and even more likely the supplementary characters), I removed them and was finally able to publish the page.
The two code blocks in the Examples section should have appeared as follows:
String.fromCodePoint(42);       // "*"
String.fromCodePoint(65, 90);   // "AZ"
String.fromCodePoint(0x404);    // "\u0404" == "Є"
String.fromCodePoint(0x2F804);  // "\uD87E\uDC04" == "你"
String.fromCodePoint(194564);   // "\uD87E\uDC04" == "你"
String.fromCodePoint(0x1D306, 0x61, 0x1D307); // "\uD834\uDF06a\uD834\uDF07" == "𝌆a𝌇"

// String.fromCharCode() cannot return supplementary characters (i.e. code points
// 0x010000 - 0x10FFFF) by specifying their code point. Instead it requires the
// UTF-16 surrogate pair in order to return a supplementary character:
String.fromCharCode(0xD83C, 0xDF03); // "🌃" == Code Point U+1F303 "Night with
String.fromCharCode(55356, 57091);   // Stars" == "\uD83C\uDF03"

// String.fromCodePoint(), on the other hand, can return 4-byte supplementary characters,
// as well as the more common 2-byte BMP characters, by specifying their code point:
String.fromCodePoint(0x1F303); // or 127747 in decimal == "🌃"

I will attempt another update to at least add the U+0404 character, "Є", as that will also help narrow down if this bug is isolated to supplementary characters or not. I will add a comment with the results.

Success on saving U+0404 character: "Є". Next I will try "\uD87E\uDC04" == "你"

Adding the  == "你" to the two relevant comments again produced the "500 Internal Server Error". So, it appears that the issue (so far) is isolated to supplementary characters.

Final comment (for now): I think the editor is attempting to translate / convert / do something with the supplementary character rather than just saving it. I had previously tried to specify the characters in question using HTML encoding (e.g. 🌃 ) but it just appeared as "🌃" in the Preview. I then realized that the & was being translated into & even when not in a code block. This is evident when I clicked on the Source button and it had already translated it. I then  tried entering in 🌃 while in the "Source" view, and that did work when previewing. HOWEVER, it's a one-shot deal as it gets translated into the actual supplementary character when going back to the HTML view. So, I discarded my edit with the properly encoded characters because while it would work this one time for me, the next time someone edits the page, those encoded sequences would be translated into characters and the person would then get the "500 Internal Server Error" upon saving and most likely not know how to handle it (or not even know what was causing it). It would be really nice if HTML-encoded entities did not get translated 😸 .

@schalkneethling again, this sounds like a platform issue rather than a docs issue. Is it ok if I pass this one over to you?

@chrisdavidmills Sorry, didn't know the preferred place to file it.

@srutzky no problem at all! We are just happy you reported it, and are fine with rerouting it if needed.

@escattone Thoughts?


Bump fideslog to v1.1.0, send async analytics event requests

Related to ethyca/fideslog#50
Code Changes
These changes are dependent upon the release/deployment of fideslog v1.1.0. Do not merge this PR until after the fideslog v1.1.0 release.

[x] Bump fideslog to v1.1.0
[x] Remove the usage of asyncio.run when sending AnalyticsEvents

Steps to Confirm

[ ] Run make cli
[ ] Execute any command that sends analytics
[ ] Observe no errors, and improved command latency
[ ] Query the fideslog database to ensure your event was written successfully

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded

Description Of Changes
Fideslog v1.1.0 changes the AnalyticsClient.send interface such that it automatically executes the request in a separate event loop. There is no longer a need to manually wrap the call in asyncio.run or similar.

@PSalant726 i moved this back to draft while we wait for fideslog 1.1.0


[Feature Request] VTable improvements

As requested on the docs page for VTable, here's some thoughts on what's missing and could be improved:

[ ] Remove component styles (they're interfering with my tailwind classes due to increased specificity)
[ ] Being able to add classes to tbody (I'd prefer using the default/body slot and being able to write the element myself)
[ ] Add slots to customize thead and tfoot (I know there's already plans for tfoot but it's currently disabled). Expose sorting methods and a11y attributes using scoped slots.

Then a question I have is, do we really need the table wrapper to be focusable? Wouldn't it make more sense to leave it as is, with just the buttons on thead being focusable and maybe the tbody rows in case users wanna highlight one of them or something on focus (but I guess they can implement this themselves using slots so…)

Hey @hacknug, thanks for the feedback. It's really valuable to get comments from folks like you so I'm not working entirely in a silo.
To be honest with you, VTable is probably the component I am least proud of. I agree that there are several changes that need to be made. I've been keeping these changes until V1 because I didn't want to introduce breaking changes on a minor release (even though it is currently technically in beta). V1 will be a major release, and as such can accommodate some breaking changes.
I plan on adding several of your recommendations already.
Regarding styles, which styles are conflicting with your own? I think the only styles VTable should have are
.table-container {
  overflow-x: auto;
}
@media (min-width: 400px) {
  .table-container {
    display: block;
  }
}

I think this component needs a lot of work, which also means I need to spend a lot of time actually implementing to see how it all feels and get that right. It'll come though. I don't use tables too often, but I know how working with a good one or a bad one can mean a lot when you actually need it.

Regarding styles, which styles are conflicting with your own?

Mostly this:
@media (min-width: 400px) {
  .table-container {
    display: block;
  }
}

I don't think we need that since all divs are already block elements by default, no?

I think this component needs a lot of work, which also means I need to spend a lot of time actually implementing to see how it all feels and get that right. It'll come though. I don't use tables too often, but I know how working with a good one or a bad one can mean a lot when you actually need it.

Agree. I'll use VTable as a base for my needs and will try to get back to this once everything is implemented to see what could/should be ported back to the library (final call on what gets added is yours, of course).

Yeah, well feedback is welcome. As for the styles, it's there in preparation for some other work that was intended but never got done. I played with the idea of making it responsive so that the layout changes. That's why there is a media query. On small screens, it would look much more different.
I still need to use the tables more to see how I like it. Ultimately I want all these components to feel very natural and intuitive.

@media (min-width: 400px) seems like a vary arbitrary value anyway. Tables in particularly need very individual "breakpoints" and styles to go with them to make them somewhat responsive to the view-port and their content.
Maybe nowadays (2,5 years later) @container would make more sense, but it remains in the realm of the designer to decide how to apply breaks and style it.

Yeah, I think this also changes with CSS vars. But maybe the right approach for now is to just leave the table as a table.


Only deploy for NodeJS 8 and docs environment

Changes three things:

Make sure to deploy the right folder (hopefully environment variables are supported there, documentation is not quite clear on that)
Only deploy for NodeJS 8
Only deploy when we are actually testing docs and not the root repo

lets hope so


initial_state in keras rnn

I'm trying to put different initial hidden state into recurrent layers. I saw many issues about initializing states using keras and most of the solutions were using layer.reset_state(state). But in my application, I have to set stateful = False and I cannot use reset_state.
As it is written in the document, I tried initial_state argument in calling layers.
Using the code below, I compared the outputs and the resulting outputs were always the same.
I tried different initializers and different initial states but the both outputs were the same.
When the stateful is False, is there other possible way to set initial hidden state???
    for size in dimension[1:]:
        initial_ = tf.ones(shape=[batchnum, size])
        recurrent_layer = GRU(units=size, return_sequences=True, kernel_initializer=one,
                                     recurrent_initializer=one)
        recurrent_layertest = GRU(units=size, return_sequences=True, kernel_initializer=one,
                                     recurrent_initializer=one)

        x = recurrent_layer(inputs=x)
        xtest = recurrent_layertest(inputs=xtest, **initial_state = initial_**)

I think the call() function is ignoring the initial_state.

Yes, the first element in input is taken as the initial state in call.

@junja94


Migrate detekt-rules-style tests to JUnit

#4450

Is there anything I can do to support? Monkey work is my specialty ;) .

That's ok, I'll try and wrap it up this weekend! Thanks though.

Any objections to merging this?

Not from my side. Let's do it.


WIP: ✨ Add probes endpoints

Summary
More like a prototype of /liveness and /readiness endpoints supported natively.
Proposed Solution :sunglasses:
This solution proposes storing the probes_state. In that state, we define two attributes: alive and ready. Based on those two attributes, we're able to change the response of the liveness and readiness probes.
Those two attributes can be changed at any moment using the request.app.probes_state.<alive|ready> for now. This is obviously a solution that @tiangolo will not accept, neither I think is a good one. :sweat_smile: I think we should have a duck typed solution here. That being said, some ideas:

Global variable imported instead of storing the state inside the FastAPI class (which doesn't look that good and it will be exceptional way to do something in FastAPI), for instance:

from fastapi import probes_state

Provide a new object the same way BackgroundTasks and Request is inserted, for instance:

from fastapi import FastAPI, LivenessState, ReadinessState

app = FastAPI()

@app.get("/")
async def potato(liveness_state: LivenessState, readiness_state: ReadinessState):
    liveness_state.broken() # Turn alive to False
    liveness_state.correct() # Turn alive to True
    readiness_state.accepting_traffic() # Turn ready to True
    readiness_state.refusing_traffic() # Turn ready to False

Pros :heavy_check_mark:

Looks like people want this feature (check related issue thumbs up).

Cons :x:

Easy to implement i.e. doesn't need to be on FastAPI natively.

Related issues :nerd_face:

https://github.com/tiangolo/fastapi/issues/1907

References

https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
https://spring.io/blog/2020/03/25/liveness-and-readiness-probes-with-spring-boot
https://www.baeldung.com/spring-liveness-readiness-probes

Personal note for curious readers
Let your like here if you want this feature, but don't assume this will be merged, please.

I don't see why this is something that needs to be built into fastapi itself, instead of an externally available package?

@Mause  one reason being even external libraries like fastapi-health or fastapi-healthcheck are not working as any other fastapi module when integrated like they are missing out some advantages or features which fastapi has

@Mause You're right. It's even mentioned in the "Cons" section.
But I'm not sure when we cross the line between "should be on FastAPI or not". A clear example is the swagger generation, or even better, the redoc. Why having redoc if we already have the swagger?
I think we should take in consideration for what FastAPI is being used.

@Divyadarshee That's a completely different issue 😅
If a good package that does that doesn't exist already, maybe the community don't need it that much. 😗
But if you want something better than what is around, you should at least open an issue on those packages. It has far higher probability of being attended there than here. 🧐

Yes @Kludex  I agree with that thought process my naïve thought was it would have been a good to have feature but yeah your point is better👍

What are the benefits of this solution over doing:
@api.get('/notify/v1/health')
def get_health():
    return dict(msg='OK')

        readinessProbe:
          httpGet:
            path: /notify/v1/health
            port: 80
        livenessProbe:
          httpGet:
            path: /notify/v1/health
            port: 80

As addition to comment above, FastAPI's main feature is being modern, i can't see anything modern than built-in probes.

It only took 1 g search to discover that these endpoints are used in kubernetes...
May I propose adding a k8: to the PR title?
My 2c: I wish there was a more elegant way to extend or mix in additional functionality (such as 2x docs) into FastAPI than the current keyword arguments.

relevant https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06

This PR has a lot of 👍 , but I don't think it will land. I wouldn't accept it.

This PR has a lot of 👍 , but I don't think it will land. I wouldn't accept it.

@Kludex I don't see why, only if you don't want this anymore. If you want, first thing I would make it pass the CI checks.. it is a good step in making things approved from my experience.

@Kludex I don't see why, only if you don't want this anymore. If you want, first thing make it pass the CI checks.. it is a good step in making things approved from my experience.

... ???
In any case, I'm not going to rebase, add tests, or whatever here without @tiangolo's feedback.

It looks like there are not enough startup probes: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

Thanks for the proposal @Kludex! 🤓
And thanks for the discussion everyone! ☕
Here's my rationale (more or less) to decide these things:
I consider two options:

Teaching people how to build something directly, explaining the needed concepts, code, and teaching them how to do it themselves.
Include some of that functionality in the library (in this one or an additional library, etc), teaching them the needed concepts, and how to use this new feature/library (instead of teaching them how to do things directly themselves).

If the effort required from users to learn the new functionality in the library is a lot less than what wold be needed to learn how to build it themselves, I would put it in the library, if not, I would rather teach them the underlying concepts and code.
At some point, they might still need to learn the underlying concepts and code anyway, and if they had to learn an abstraction before learning the actual concepts, in the end, they had to learn the double.
Also, if the new feature/library adds some noticeable improvement in some way, e.g. developer experience (autocompletion, type annotations) compared to doing things by hand, or makes things particularly easier, then I add the feature/library.
The other thing is, if I document how to add probes by hand, people that come searching for that can find it. But if it's part of the library as a feature, and more keyword arguments, everyone will end up seeing them, and maybe wondering what that's for, and having to learn it or feel they don't know a part of the tool.
I probably consider other things that I don't remember right now from the top of my head, but you get the point.

In this particular case, I don't think having this as part of the library is saving users that much effort compared to teaching them how to write the code themselves. And also "liveness" and "readiness" will be quite dependent on the application. So, adding all the needed parameters and configs would require quite some complexity on the library and complexity people would have to learn. So I would prefer to teach them how to add the endpoints themselves and what things to consider.
So, I'll pass on this PR. But I would take a PR adding docs about creating probes by hand. 🤓 ☕


Add help menu

Cate Desktop provided a help menu with various links to external resources. We need the same as web version:

Cate docs
Cate issue tracker
Cate web site
KE web site

Fixed.


Add celltypist

Mandatory
Name of the tool: celltypist
Short description: CellTypist is an automated cell type annotation tool for scRNA-seq datasets.
How does the package use scverse data structures (please describe in a few sentences): CellTypist uses anndata for most analyses and is dependent on Scanpy.

[x] The code is publicly available under an OSI-approved license
[x] The package provides versioned releases
[x] The package can be installed from a standard registry (e.g. PyPI, conda-forge, bioconda)
[x] The package uses automated software tests and runs them via continuous integration (CI)
[x] The package provides API documentation via a website or README
[x] The package uses scverse datastructures where appropriate (i.e. AnnData, MuData or SpatialData and their modality-specific extensions)
[x] I am an author or maintainer of the tool and agree on listing the package on the scverse website

Recommended

[ ] Please announce this package on scverse communication channels (zulip, discourse, twitter)
[ ] Please tag the author(s) these announcements. Handles (e.g. @scverse_team) to include are:

Twitter:
Zulip:
Discourse:
Mastodon:

[x] The package provides tutorials (or "vignettes") that help getting users started quickly
[ ] The package uses the scverse cookiecutter template.

The package uses automated software tests and runs them via continuous integration (CI)

I can't find any tests nor continous integration in the repo or am I overlooking something?
The rest is fine!
For a test/CI setup, you can check out how it's done in our cookiecutter template.
The probably lowest hanging fruit for test-cases are high-level "smoke tests", i.e. you just test the public interface on a test dataset and compare the results against a snapshot. Additionally lower level "unit test" could be implemented that test individual functions, including internal ones. Just having the former would be ok from our side, we mainly just want to make sure that there's an automated way to detect if something breaks.

I see. Will incorporate this and inform you then :)


On validation error, should log details

Observed in Kana's use case: when a prediction validation request is not validated (returning a 422), we do not log what the issue was.
We should log the details of the error (either here or in AtmosphereX) to be able to inform users when such error occurs, but it should not include the values from the request, only the keys which created the error (which I think is the default behaviour from the detail message created by the pydantic validation module).

We will need to be sure that the customer is not expected us to provide this logs, as they are currently receiving this information.
AtmosphereX seems simpler to be the place logging it, as custom activities may be implemented by client.


Docs need clarification regarding dependency pinning for apps and core

Environment

Nautobot version (Docker tag too if applicable): 1.6, 2.0

Users are frequently encountering issues with managing the installed versions of Nautobot versus its various apps due to pip's default aggressive upgrading/downgrading of dependencies. For example, a user on Nautobot 1.6 might install the latest version of an app, not realizing that that app version specifies Nautobot 2.0 as a dependency, and find their Nautobot installation unexpectedly and unintentionally upgraded. Conversely, a plugin might not yet be updated to Nautobot 2.0 support, and installing it would downgrade Nautobot to 1.x and break an existing Nautobot installation as a consequence.
Our documentation in core and in the apps cookiecutter needs to be updated to provide best practices and procedures to follow for managing apps, and more generally the Nautobot virtual environment, to avoid such headaches.
Ideas include (but are not limited to):

Use of constraints files when managing installation with pip
Use of poetry and dependency specification through pyproject.toml

Special consideration also should be taken for users using the Nautobot Docker image as a base image and how they should manage app installation in their custom Docker builds.
This story should be considered complete when:

installation docs for Nautobot 2.0 are updated accordingly
installation docs for Nautobot 1.x LTM are updated accordingly
the cookiecutter project for nautobot apps is updated accordingly so these best practices can be propagated to existing apps via drift-manager.

Hey team! Please add your planning poker estimate with Zenhub @gsnider2195 @HanlinMiao @timizuoebideri1


Please add auto suggestions for coders who are new to dart and flutter

it's very difficult to know what are the properties of the given funtion...widget...and vs code not shows well the real suggestions please

This is a tooling issue, not a language issue, so I moved the issue to the sdk repository.
Our completion support ought to provide all of the valid options. For example given the code
void f(String s) {
  s.
}

if you request completions after the period they ought to include all of the methods (including getters and setters) that are visible on the class String. If you're not seeing this, could you please provide at least one concrete example of code in which completions are not being suggested as expected?

suppose u want to add an widget... say a buttin widget... when we press ctrl+space  it should first show the possible properties in suggestions etc

Could you provide me with a small piece of sample code in which you're not seeing the suggestions you're expecting to see? It's hard to fix issues unless we can reproduce them, so some reproduction steps would be useful.
Also, which IDE are you using?

Thanks for your response. sorry i am too busy right now, BUT , i just moved
from beta sdk to master SDk now 99% issue is solved. the suggestions
somehow now show up...
[image: image.png]
On Thu, Jun 3, 2021 at 2:42 AM Brian Wilkerson @.***>
wrote:

Could you provide me with a small piece of sample code in which you're not
seeing the suggestions you're expecting to see? It's hard to fix issues
unless we can reproduce them, so some reproduction steps would be useful.
Also, which IDE are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/46189#issuecomment-853403016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSCPGPHMJPDWLNM44ATTQ2QVPANCNFSM45ZNQR7Q
.

I'm glad to hear that most of the problem has been resolved. Given that, I'm going to close this issue, but when you have time please open new issues for any remaining problems you're still seeing.


[Improvement][API] Zookeeper dependence

Describe the question
Currently, the dolphinscheduler-api module relies on zookeeper to do some operations about the worker group. The problem is that if the api cannot connect with zookeeper, then api will not start successfully, this caused by ZookeeperOperator init block.
I think the dependence of api to zookeeper should be a weak dependence, it shouldn't affect the core function of api.
Which version of DolphinScheduler:
-[1.3.6]
-[dev]
Describe alternatives you've considered

Yes, weak dependence will be a good choice


Remove org.apache.commons.lang3 usage from Ballerina Runtime

Purpose

Remove the use of org.apache.commons.lang3 in the repository.

Fixes #41530
Approach

Remove org.apache.commons.lang3 library from relevant dependency lists.
Implement the lost functionality within the codebase.

org.apache.commons.lang3.StringEscapeUtils.unescapeJava() was replaced by io.ballerina.identifier.Utils.unescapeJava()
The functionality obtained from org.apache.commons.lang3.ArrayUtils.addAll() was implemented within addModuleConfigData()

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It was observed that the newly added functionality is already covered by the existing integration tests but codecov doesn't seem to notice that.


OLS-197: Reconcile logic in OLS Operator

Description
Reconcile the number of replicas in the CR. The deployment reflects the new replica count.
Reconcile deployment resources in the CR. The deployment reflects the new resource limits/requests.
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue https://issues.redhat.com/browse/OLS-197
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Do we want to take unit tests for this change in a different PR?

/lgtm
I think we can put the tests in another PR :)

/approve

/lgtm
/approve


fix: added the TDP of CPU Intel Core i7-1360P

Added the TDP of the CPU Intel Core i7-1360P to cpu_power.csv
Source: https://www.intel.com/content/www/us/en/products/sku/232155/intel-core-i71360p-processor-18m-cache-up-to-5-00-ghz/specifications.html

Thanks for your contribution !


"DEFAULT_ALLOW_CREATE_ORGANIZATION = false" is ignored during new user creation

Gitea version: 1.8.0-rc2
Operating system: Linux
Database:

[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Not relevant

Description
Precondition:
[service]
DEFAULT_ALLOW_CREATE_ORGANIZATION = false

After a brand new user is created he/she is able to create organization.
Screenshots

There is also another config item DISABLE_REGULAR_ORG_CREATION to control organization creation.

Too many options ?

Yes, maybe only one is necessary.

@lunny , thanks for [admin] DISABLE_REGULAR_ORG_CREATION = false, I wasn't aware about it.
Despite the non obvious name, actually it's what I do really need.

DEFAULT_ALLOW_CREATE_ORGANIZATION is used in ldap sync and user creation so this should be kept. Don't know about use case for disabling org creation completely

#7017 will rewire it back in. Restoring it's functionality


Serial groups for cd-smoke-test

What

pipelineString is deprecated, we should use config with all it's YAMLy
goodness
add serial_group to build and deploy jobs

Why
This is a workaround for a rare issue, that has started to show up more
since increasing the cd-smoke-test frequency.
we don't want the deploy job to run at the same time as the build job as
this increases the chance that we hit the "not signed by notary" bug if
a new build finishes before the previous deploy job has really begun.

@philandstuff is that really what we want?
I feel like a "successful" smoke test is one complete pass of a build+deploy pipeline run.... and so im not sure i see the value in having the jobs run together and it seems like not having serial group was just an oversight.
If im wrong, then probably just close this PR and we'll ignore the problem until notary thing goes away.

I agree with your goal (that we want to see one successful build+deploy), but I don't see how serial_group helps achieve it? From my POV it just slows things down?

I guess I'm thinking about looking at the stat of a "pipeline run" ... and don't want to muddy it with the case that the runs are overlapping ... it feels like running a test a second time before the first one has finished.
I don't feel strongly about this at all though

I know that appealing to etymology is not a good argument style... but... the reason we even call deployment pipelines "pipelines" is by analogy with CPU pipelines - and the ability to start the next one before the previous one has finished. See 'The origin of the term "Deployment Pipeline"' from http://www.informit.com/articles/article.aspx?p=1621865&seqNum=4
Popping context back to this case: I feel that blocking the next build until the current one is entirely fixed is not a goal in itself and in general is something I would seek to avoid if we can.

I'm gonna merge this because we're seeing the race cause the unsigned bug too often which is causing the deployer to go red  ... someone can come back and change it later if they don't like it :stuck_out_tongue:


Cannot right click token due to tooltip appearing on top of it

VSCode Version: Version: 1.52.1, Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523, Date: 2020-12-16T16:30:02.420Z (6 days ago), Electron: 9.3.5, Chrome: 83.0.4103.122, Node.js: 12.14.1, V8: <IP_ADDRESS>-electron.0
OS Version: Darwin x64 20.2.0

Steps to Reproduce

Create a fresh name for something, e.g. let unusedVar;
Hover over unusedVar
Right click

Expected behavior
Brings up normal right-click context menu for unusedVar token
Actual behavior
Right-click is intercepted by a tooltip that gets in the way of the token, saying that unusedVar is unused
Suggested fix
The tooltip should appear above/below the hovered token, rather than on top of it
Does this issue occur when all extensions are disabled?
Yes
Screen recording
See https://user-images.githubusercontent.com/166966/102981086-cd383580-4508-11eb-8cc4-cc8b7eaaa79c.mov

Duplicate of #112391 . A fix is available in our Insiders Release Channel.

Ah great, thanks @alexdima 🎉