remove the gpgkey line from the red hat storage repo template

See: https://bugzilla.redhat.com/show_bug.cgi?id=1339439
Signed-off-by: Andrew Schoen<EMAIL_ADDRESS>Resolves: rhbz#1339439

This looks OK to me

LGTM (it would be good to test this)

@ktdreyer I've tested this on rhel 7 with a beta signed ISO, everything installed fine after importing the beta key.

awesome!

@andrewschoen @leseb  perfect and thanks


Add support for draft-ietf-suit-manifest-16

It's similar to manifest14 but with lots of stuff removed.
This repurposes the manifest14 tests to run on manifest16 as well.

Nice! Do we really need to keep manifest-14? Wouldn't it be better to get rid of it and only have -16 for now?

Nice! Do we really need to keep manifest-14? Wouldn't it be better to get rid of it and only have -16 for now?

Maybe not, but I'd like to keep it since it doesn't cost more than a handful of seconds every test run.


Future of the project

Hi Julia.
The idea for this project is pretty cool!
Do you plan to go on with it in the future, or was it just for the hackathon?

Hey @ctoffanin. Thank you for your comment and interest. Actually, I do plan on going on with this project pretty soon.

That's good to hear! I'd love to help you if you need any (based on my skills, of course).
Glad the project is not left for dead!
Thank you for your reply, and you can close the issue if you want.
Cheers.


Support --skip-dir options

Getting false positives on dockerized rails apps due to https://github.com/aquasecurity/trivy/issues/282
The solution is to use --skip-dirs
Would you be open to a PR?

hi @brianlow - https://github.com/aquasecurity/trivy-action/pull/33 was committed. Let us know if you run into problems.


Discussion: should we be able to stop a redraw with startComputation/endComputation?

Hello,
I tried the following, it redraws:
m.startComputation();
m.redraw.strategy('none');
m.endComputation();

Sometimes it is easier to: draw by default and prevent drawing on exception
than to: not draw by default and draw every time except a special case.
Would that break something?

m.startComputation() and m.endComputation() block the rendering loop to work with external libraries. m.redraw.strategy("none") skips the next redraw, but only with synchronous ones that are part of the normal lifecycle (e.g. not by m.redraw() or m.request() either). But in this case, your behavior is documented and intentional.
@lhorie I think you are better to answer this question, as I'm lost as to why this is and/or should be the case.

Thanks for the follow up!
It seems that the m.redraw.strategy() is used only during dom events.
I have several services that emulate "events" and I'm using m.startComputation() and m.endComputation() to redraw by default. But that way I can't prevent a redraw.
Not using m.startComputation() and m.endComputation() in my services and letting the client call m.redraw() everywhere is a little bit tedious.
The real question is, how can I achieve what I'm describing?!

After having read the code, I understand why only sync events can prevent a redraw. After a redraw is prevented, the strategy is immediately set back to diff so that any other pending request can redraw afterwards.
When doing async stuff, there could be a situation where 3 async calls are overlapping. If the last one would prevent a redraw (when pendingRequests reaches 0), nothing would be redrawn. Even if the first two would have liked a redraw.
We could implement something though for async events. Always use code like in endFirstComputation() where we meant to do endComputation(). But keeping a global flag to determine the most expensive type of redraw needed by all the pending requests (all wins over diff which wins over none). When pendingRequests reaches 0 and the strategy is none but the global flag is set, we redraw() anyway using the proper strategy.
ex.:

Let's say we use 3 m.request() calls at the same time. pendingRequests is now 3. The first one resolves and the client calls m.redraw.strategy('none'). The global flag has none.

The second call resolves, the client doesn't change the redraw strategy, it is diff by default so the global flag now contains diff.

The third call resolves, the client set the strategy to none. The pendingRequests counter reaches 0. The current strategy tells to not redraw but the global flag contains diff, we redraw anyway.

What do you guys think?

Thanks for bringing this up and putting due thought into it.
I think the one thing that 'computations' do that nothing else can is to prevent redraw for a duration. Everything else about the API is contentious, often unexpected, and achievable by direct access to other API methods. In my experience most people confused by start / end computation call one after the other synchronously just to trigger a redraw, which gives some indication of how confusing this API space is.
IMO the API should be renamed to something more explicit about what it is for (the relationship between 'computations' and redraws is unintuitive at best), and there should be no opinionated implicit behaviour on resolution — authors are perfectly capable of setting redraw strategy and calling a redraw, synchronous out otherwise, before or after resolution — and as you say, intervening calls to redraw APIs should be intercepted and re-invoked on resolution.
Here's a little proof of concept (the Promise API is something I stick by in all asynch code where possible simply to reduce esoteric API surface and stick to standards that exist elsewhere, but we can ignore that):
function lockRedraw( resumeRedraw ){
	var redraw   = m.redraw
	var called   = false
	var forced   = false
	var strategy = m.prop()

	m.redraw          = function( input ){
		called = true
		forced = input
	}
	m.redraw.strategy = strategy

	return new Promise( resumeRedraw ).then( function(){
		m.redraw = redraw

		redraw.strategy( strategy() )

		if( called ) redraw( force )
	} )
}

This also tracks whether there were any redraw calls.
The thing this doesn't do that you're suggesting and sounds intuitive is to give calls for more aggressive strategies and synchronous redraws precedence over later weaker calls.
I can completely understand the logic behind wanting that: if a given action requests a diff or total redraw, then the fact a later action requests a 'none' redraw (the standard method for marking a DOM event handler as no-op) should not supersede the earlier intent. However this isn't how Mithril behaves currently (regardless of computation implementation logic), as demonstrated in this fiddle — redraw strategy is a setter function with string validation, nothing more.
At the end of the day, I believe that behaviour is something that should be addressed — if at all — as a separate issue by the redraw strategy API itself, external to the concerns of the redraw lock / computation API — again this falls into the contentious pit of inconsistent implicit behaviour with one API making up for the failings of another, which we desperately need to avoid in order to mitigate further mixed concerns and thwarted expectations.

Thanks @barneycarroll for you thorough explanation. I too have made some code during the night to test my theory out.
I have a modified endComputation() that does what I describe above and all the tests are passing:
	var pendingRequests = 0;
	var pendingRedrawStrategy = "none";
	m.startComputation = function() { pendingRequests++; };
	m.endComputation = function() {
		if (m.redraw.strategy() === "diff" && pendingRedrawStrategy !== "all") pendingRedrawStrategy = "diff";
		else if (m.redraw.strategy() === "all") pendingRedrawStrategy = "all";

		if (pendingRequests > 1) {
			pendingRequests--;
			m.redraw.strategy("diff");
		} else {
			pendingRequests = 0;
			if (pendingRedrawStrategy !== "none") {
				m.redraw.strategy(pendingRedrawStrategy);
				m.redraw();
			}
			else {
				m.redraw.strategy("diff");
			}
			pendingRedrawStrategy = "none";
		}
	}

You should also replace any endFirstComputation(); calls by the regular m.endComputation();
That's it

@mikegleasonjr I think I would like your idea better, although I wouldn't merge it until 0.2.2 gets released (i.e. past -rc). It could break for some uncommon cases. Conceptually, it's more consistent, which is almost always better. [1]
[1]: ES5 functions are a case where consistency didn't work, because people got confused over every function having its own this. Hence, ES6 arrow functions.

Okay I will fork / document / test this feature and submit a PR for the future.
I am very happy with the community here and this project. The library is amazingly small and fast which satisfies all of my OCDs :) I admit the documentation for the corner cases are a little bit scattered here and there and you have to look at the source to understand what's going on but hey, you're only at 0.2.
Can't wait to show you the project I'm working on with Mithril.

After a discussion on the channel (and despite successfully implementing this feature in a branch), I decided not to pursue this route. I will fork and remove the auto-redrawing system from Mithril altogether and cann m.redraw in userland on demand (except on route change, I will keep that in Mithril). I will at the same time get rid of deferreds to save size. I think it should be bring your own if you want to use Promises. If anyone is interested, I can explain my choices somewhere.


 As requested in this issue. Visual examples:
Error used to be like this:

It will become like this:

What warn used to look like:

And will become:

There won't be stack trace for console.log, but for consistency, it's proposed to print like this:

Instead of this:

In the original feature request, there were discussion possibility to opt out. This can be achieved by exposing a new cli option --noCodeFrame.
Closes #8819
Test plan
To pass CI, some snapshots will need to be updated.

Hi @SimenB,
Can you take a look at the proposed output in the Summary above when you are available? I think many snapshot tests need to be updated accordingly. Please let me know which areas I can improve the code, too. Thank you very much!

Oh yeah, this is looking good! I like it 👍
Let's drop the --noCodeFrame option for now - easier to add if somebody complains than removing if nobody uses it 🙂

@gaearon thoughts on the output here?

I think this is shaping up great @ychi! 👍 Could you add some tests, update the snapshots and add an entry to the changelog?

Hi @SimenB:
Trying to fix failed checks. Among all failed checks, Node v10 and earlier consistently fail prints console.logs when run with forceExit; the printed function name is at Object.<anonymous>.test when Node version <= 10, at Object.<anonymous> for Node version > 10. Does it make sense to split this test into 2 ( Node <=10 versus Node > 10)? Or we can just test Node > 10?
Another failed check is test-jest-circus, it seems something happened after beforeAll and before those beforeEachs, introducing difference in error.stack output. Can you give me some guidance?
Thank you in advance 🙂

Does it make sense to split this test into 2 ( Node <=10 versus Node > 10)?

Yeah, I think so.
Not sure about circus, I'd have to play with it. Can do so tonight 🙂

Codecov Report

Merging #9741 into master will decrease coverage by 0.04%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##           master    #9741      +/-   ##
==========================================
- Coverage   64.87%   64.83%   -0.05%
==========================================
  Files         288      288
  Lines       12206    12217      +11
  Branches     3025     3025
==========================================
+ Hits         7919     7921       +2
- Misses       3646     3653       +7
- Partials      641      643       +2

Impacted Files
Coverage Δ

packages/jest-console/src/getConsoleOutput.ts
0.00% <0.00%> (ø)

packages/jest-reporters/src/default_reporter.ts
82.60% <ø> (ø)

packages/jest-runner/src/runTest.ts
2.22% <0.00%> (+0.04%)
:arrow_up:

packages/jest-message-util/src/index.ts
65.77% <30.00%> (-1.13%)
:arrow_down:

packages/jest-console/src/BufferedConsole.ts
67.92% <42.85%> (-2.08%)
:arrow_down:

packages/expect/src/utils.ts
96.22% <0.00%> (+1.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539f057...8b6b76d. Read the comment docs.

Thanks @ychi!

Oh! So much going on in one day. Thank you very much @SimenB for helping with so many things in this PR!

Hooray!!! Thank you @ychi and @SimenB and everyone else 👏👏👏👏

@SimenB  Sorry, but I'm not interested in those stacktraces, they only add noise in my case. Can you please reconsider adding noCodeFrame CLI and config option?

We have a --noStackTrace flag, but I guess you still want the stacks for actual errors?

Generally, I do, but I think I'll try to live with this option a bit, thanks.
UPD: it doesn't seem to affect console stacktraces

Oh, that's a bug I think

I can look into the bug later today :)

It's because getStackTraceLines() always return at least the first line, if noCodeFrame is not explicitly set to true, this if condition will still be evaluated to true, therefore rendering the whole callsite.
One way I can see would be like this:
if ((!options.noStackTrace) && (!options.noCodeFrame)) {
    ...
}

In which --noStackTrace flag will disable code frame.

It should respect noStackTrace as well, yeah

hi,
in my case it adds noise as well. How do i get rid of console errors and warn?
Thanks

If there are errors/warn in your console, you should find where those are appearing (which this new feature should help with) and why, and change your code so those don't show up. It's dangerous to simply hide errors and warnings. They probably exist for a reason and are indicative of a problem.

Im aware of that but i want to have the option to not include them in my tests. dont want to change my source code for that..

If you want to get rid of the stack trace, then it sounds like the next version will support that with noStackTrace. Or is it that you don't want to see any of the error or warn logs at all? If that's the case, you can add this to the top of your tests or in a setupFilesAfterEnv file:
console.error = () => {}
console.warn = () => {}

I don't advise this for the reasons I mentioned earlier :)

thanks!

Why does it also apply to console.log and console.group?
https://github.com/facebook/jest/pull/9741/files#diff-b701d764ec6d4ad18067c4124271cd75

Call sites were moved to a different line for all console methods, while warn and error prints code frame and stack trace. Probably caused console.group to behave strangely, I can take a look this week.

Before v25.4.0, console.log and console group print like this:

After v25.4.0, they print like this:

The motivation was to make different console methods print in similar ways regardless of stack trace.

I'd say that this IS a stacktrace, just reduced to one line

Hi guys,
Is there any updates with --noCodeFrame option?
Actually I'm not interested in stack trace for console output, but I want the stacks for actual errors, that's why I cannot use --noStackTrace  flag. And I see I'm not the only one :)


the parameterlist is not consistent

We use snake_case, camelCase and writtentogether ... choose one! Your call HGustavs.
...
shaker.hasGeoLocation = false;
shaker.geolocationcallback = null;
...

My vote goes to snake_case ...

My preference is camels, if I have to choose.
As the slogan says, more doctors smoke camels than any other brand.
http://tobacco.stanford.edu/tobacco_main/images_body.php?token1=fm_img0081.php

Ok. Deal.


[FR] Start/Finish of each run marker

Something like this
___________           .___         _____  __________
\_   _____/ ____    __| _/   _____/ ____\ \______   \__ __  ____
 |    __)_ /    \  / __ |   /  _ \   __\   |       _/  |  \/    \
 |        \   |  \/ /_/ |  (  <_> )  |     |    |   \  |  /   |  \
/_______  /___|  /\____ |   \____/|__|     |____|_  /____/|___|  /
        \/     \/      \/                         \/           \/
unregistered torrents found:        X torrents
new torrents to tag:                X torrents
torrents categorize:                X torrents
tag/set ratio limit/seeding time:   X torrents
Items thrown to RecyclingBin.       X torrents/data
info                                X blah blah blah
infoooooooooooo
Stuffs
More info
Yup

This way it is easier to read between runs and know what was done on the run above.

Changed FR name to match more of the idea. The Synopsis would clutter up if you run often.


[Dropdown] Dynamically changing the DropdownOptions throws an error

Describe the bug
When we dynamically change the options of a multiselect Dropdown, to be disabled or not based on other fields, it throws an error in the updated method.
The error is there for both the case where, value is a blank array or has some value.
The value is also updated to remove the disabled options.

I think this needs some more information. The line that error is on only applies to single select dropdowns.

Attaching the screenshot with the code used for the Dropdown
and yes, the value provided to the Dropdown is of type Array<String>

I bet it's related to building the options separately. Can you move the options rendering loop so it's inside of the Dropdown instead of it's own function? If the Dropdown renders initially without any options, it could throw this error.

tried with the following code, still the same.

This will need some further investigation then. Would you be able to re-create this in a code sandbox for me?

In 1.6.11 I added some logic to try and prevent that error. You can try it and see if it helps, but there may still be a larger problem with what you're doing here.

Still the same with 1.6.11
will re-create the issue on code sandbox

Closing since this issue has gone stale.


licensing (license versions) unclear.

Hi,
currently packaging libnumbertext for Debian for LibreOffice 6.1.
README says:

License: LGPL/BSD dual-license, 2009-2018 (C) László Németh (nemeth at numbertext dot org)
Numbertext language data (Soros programs):
LGPL/BSD dual-license, 2009-2018 (C) László Németh et al. (see AUTHORS)
Serbian modules:
CC/LGPL/BSD tri-license, 2009 (C) Goran Rakić (grakic at devbase dot net)

CC is mentioned in data/sr.sor as Creative Commons 3.0 Attribution - Share Alike license.
So far OK, but which versions of the LGPL? and which BSD one? (3-clause I assume?). Maybe you even mean the MIT/Expat one? Or is this LGPL-3+ as one can deduce from

and relicensed under GNU Lesser General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

in above-mentioned data/sr.sor?
This should be clarified and license headers/COPYING file(s) added.
Regards,
Rene

I have pushed the following commit:
Disambiguate license: Modified BSD, LGPL-3+ dual-license
for code and language data

and CC-BY-SA/Modified BSD/LGPL-3+ tri-license for Serbian

COPYING: add most permissive modified BSD license

Thanks, László

thanks, that makes more sense. Did https://salsa.debian.org/libreoffice-team/libnumbertext/commit/238a6ae2c298b018d2766f9ac868836094d393a1 and https://salsa.debian.org/libreoffice-team/libnumbertext/commit/7c07a68d8e5b813b63d4f82474932f294d57da39


Remove Database type from Connection Setup

Remove the Database type option from the connection form

I would like to work on it

Please assign, I'll work on this.

Please assign me to this


Added support for 32-bit Windows

Adds support for Windows 32-bit.


Avoid conflict of configuration file.

@artur-shaik
now the plugin support eclipse's .classpath maven's pom.xml and gralde's build.gradle.if a project has more than one configuration file.we should provid a g:var which can  control the priority order  of loadding the files.
for example by default it is g:JavaComplete_ClassPathLoaddingOrder = ['eclipse','maven','gradle']
and for gradle, there should be a g:var for disable build script ./gradlew and let user just use gradle instead of ./gradlew or .\gradlew.bat.
I'd like to open a PR for this feature.
and as @Shougo says the plugin freeze his vim/neovim when he open his android project, I think maybe it is due to the conflict of gradle and the build script. I will try to fix it.

Sounds reasonable.
On 02-21 (19:40), Wang Shidong wrote:

[1]@artur-shaik
now the plugin support eclipse's .classpath maven's pom.xml and gralde's
build.gradle.if a project has more than one configuration file.we should
provid a g:var which can control the priority order of loadding the files.
for example by default it is g:JavaComplete_ClassPathLoaddingOrder =
['eclipse','maven','gradle']
and for gradle, there should be a g:var for disable build script ./gradlew
and let user just use gradle instead of ./gradlew or .\gradlew.bat.
I'd like to open a PR for this feature.
and as [2]@Shougo says the plugin freeze his vim/neovim when he open his
android project, I think maybe it is due to the conflict of gradle and the
build script. I will try to fix it.
—
Reply to this email directly or [3]view it on GitHub.
Reverse link: [4]unknown
References
Visible links

https://github.com/artur-shaik
https://github.com/Shougo
https://github.com/artur-shaik/vim-javacomplete2/issues/202
https://github.com/artur-shaik/vim-javacomplete2/issues/202

--
Best regards,
Artur Shaikhullin

here is how I will do for this PR,
fu! s:eclipse()
    echo 'Use_eclipse'
endf

fu! s:maven()
    echo 'Use_maven'
endf

fu! s:gradle()
    echo 'Use_gradle'
endf

fu! s:test()
for key in [ 'gradle' ,'aa','eclipse', 'maven']
    try
        exec "call s:".key."()"
    catch
    endtry
endfor
endf

call s:test()

the out put is
Use_gradle
Use_eclipse
Use_maven

I just let the functions be called in order


[DMS-68] Remove tuple from Map definition

In comparison with #14
Map comparison

binary_size
generate
max mem
batch_get 50
batch_put 50
batch_remove 50
upgrade

rbtree+100
189_877
225_155
42_540
50_045
135_367
133_686
565_657

persistentmap+100
186_955
229_348
47_144
50_288
140_952
137_667
460_161

persistentmap_baseline+100
187_490
226_832
45_672
49_945
139_070
134_191
512_457

rbtree+1000
189_877
3_118_490
580_948
67_516
181_375
180_396
5_409_805

persistentmap+1000
186_955
3_184_398
641_512
67_943
187_881
186_161
4_360_346

persistentmap_baseline+1000
187_490
3_133_922
612_880
67_416
184_117
181_732
4_878_488

rbtree+10000
189_877
51_301_049
520_428
83_465
224_135
230_257
53_866_589

persistentmap+10000
186_955
49_094_738
400_360
84_056
231_495
237_546
43_379_739

persistentmap_baseline+10000
187_490
51_438_500
520_360
83_365
227_294
231_116
48_561_107

rbtree+100000
189_877
606_914_881
5_200_428
98_012
270_465
276_802
698_928_540

persistentmap+100000
186_955
587_225_673
4_000_360
98_776
279_162
285_517
563_062_175

persistentmap_baseline+100000
187_490
608_157_242
5_200_360
97_912
273_597
277_661
645_876_276

rbtree+1000000
189_877
6_993_676_959
52_000_464
116_417
317_299
330_296
6_988_883_198

persistentmap+1000000
186_955
6_819_487_795
40_000_396
117_370
327_152
340_806
5_630_238_790

persistentmap_baseline+1000000
187_490
7_005_190_168
52_000_396
116_317
320_359
331_196
6_458_379_331

Persistent map API

size
foldLeft
foldRight
mapfilter
map

persistentmap
100
18_397
18_309
98_430
26_043

persistentmap_baseline
100
18_597
18_509
97_613
29_443

persistentmap
1000
152_997
151_945
1_791_712
224_120

persistentmap_baseline
1000
154_997
153_509
1_763_344
258_079

persistentmap
10000
1_501_863
1_483_591
33_511_740
2_204_441

persistentmap_baseline
10000
1_521_863
1_503_632
36_132_684
2_544_359

persistentmap
100000
14_998_975
14_804_493
409_663_616
97_809_311

persistentmap_baseline
100000
15_198_893
15_004_493
434_003_881
132_210_500

persistentmap
1000000
149_997_225
906_008_093
4_820_688_381
978_026_892

persistentmap_baseline
1000000
151_997_225
150_013_513
5_045_781_583
1_322_035_748

Actually, what the hell happened with foldRight on size 1000000?

Actually, what the hell happened with foldRight on size 1000000?

benchmarks are deterministic?
Maybe try to run foldRight isolated from others?

Why the first table doesn't have comparision with baseline ?

Why the first table doesn't have comparision with baseline ?

It almost the same as rbtree, so I didn't include it first.
Adding it now, because it still worth to have a full picture in one place.

Okay, I think the conclusion from these results is that all general operations like get, put, remove become slower because of the overhead of creating nodes. In the original implementation, we often reuse a pair of (key, value).
The new functionality is a bit faster. So a couple of percentages here against a couple of percentages of general operations.
I would prefer to keep a tuple version (original).

@GoPavel the max memory requirements do seem to go down quite a  bit for larger tests (is that like 20%?). Maybe that's worth it?
I wonder if it would be good for the benchmarks tor report allocated_bytes (rather than max-memory). Maybe that would be a better measure of how much allocation is happening.

Yeah, I think I missed it. 20%  (even 25% I see) sounds significant.
But it's a bit suspicious because persistentmap+1000 consumes more than persistentmap+10000. Probably I was looking at small benchmarks only and overlooked it.
Maybe the effect could be explained by the implementation specifics of the GC or the allocator.
I will rise a discussion in the slack about  it

On the other hand, probably upgrade speedup shows a real situation with memory consumption. Indeed it is always less for the new version.

Merged into #34


Update 3rd party libraries

The third party libraries should all be updated (when possible). In particular, python, Qt, and NetCDF are out of date

And HDF5.
On Fri, Aug 2, 2019 at 2:57 PM clyne<EMAIL_ADDRESS>wrote:

The third party libraries should all be updated (when possible). In
particular, python, Qt, and NetCDF are out of date
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NCAR/VAPOR/issues/1820?email_source=notifications&email_token=AAGG6JOWX5IBBDT65XX4MV3QCSNSBA5CNFSM4IJA7R72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDESMDQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGG6JMC2H7BDAU6DKSKHILQCSNSBANCNFSM4IJA7R7Q
.

We should probably abandon the old glade installation path and see if we can come up with something that makes more sense. E.g.:
/usr/local/vapor-libs

Mac/Linux:
/usr/local/vapor/2019

Note on Assimp: since loading 3D objects isn't on the to-do list of release 3.2, it's not included in the 2019-Aug build.

Note on FTGL: vapor3.2 calls freetype directly, so no need to build FTGL anymore.

Sam, I’d suggest including Assimp so that we don’t have to change the library collection when we do add Model rendering. Also, model rendering was something we had listed as a “might do” for 3.2.

On Aug 14, 2019, at 3:14 PM, Samuel Li<EMAIL_ADDRESS>wrote:
Note on Assimp: since loading 3D objects isn't on the to-do list of release 3.2, it's not included in the 2019-Aug build.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>

Note on jpeg: it was used to build tiff, but currently tiff seems to have jpeg enabled even without our build of jpeg, so no need to build jpeg anymore.

Note on SQLite: this is a new dependency, since it's required by proj.

Note on Grib-api: we don't include it for this round. If in the future we decide to use it, we can add it back.

Good call.  Looks like the GRIP API has been discontinued.  They've moved on to a product called ecCodes.
https://confluence.ecmwf.int/display/GRIB/Home


Use format: 'M d, Y h:i A', has error

When we user format: 'M d, Y h:i A', I select time to 19:00, but for input we get 6:00 pm, the time always minus one。I find this error and fix this error, please contact me

Had the same issue, and I fixed it doing this:
https://github.com/xdan/datetimepicker/issues/724
I think your fix doesn't do enough because 12 PM changes to 12 AM unless you use my fix.

I was able to fix this by choosing moment.js as the date formatter.
https://github.com/xdan/datetimepicker/issues/596#issuecomment-724113347

I was able to fix this by choosing moment.js as the date formatter.
#596 (comment)

Why would we need to install another heavy library instead of just fixing the bug?


Medusa Provider

Is there any plan to add Medusa to the current providers? If this is something interesting for people I could send a PR

Let us know if you do any progress on this. Don't use Medusa myself but would be interesting seeing a provider for this as well🙂

That is a fantastic idea 👌🏼

I saw that this https://github.com/vercel/commerce/pull/486 was actually closed one day before this new issue was opened. Does anybody know what happened with #486? CC: @kasperkristensen

Nvm, this explains it https://github.com/medusajs/medusa/issues/1428.

Hey there! Thank you for opening this issue. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: https://github.com/vercel/commerce/pull/966


Add setting for where terminal opens (in workspace)

It's not clear to me what determines what folder gets opened in the integrated terminal when I toggle the terminal (when there are none currently open). Ideally, I'd like a setting similar to terminal.integrated.splitCwd that gives me the same options such that I can choose each time.

Here's what happens:

Multi-root: Whatever was the last active root (based on files opened), falling back to the first (I think)
One folder: The folder
No folders: "home" fallback folder

It seems the only complication is when multi-root happens, but the difference here is that the terminal panel must launch asap without user intervention (we cannot have a picker here) I'm not sure what the options would be and if it's worth adding a new setting for. @martellaj what options were you thinking here?

When there's no terminal open (in the multi-root case), it's not always the case that the one I want to open is the last one I was working in.

In that case I would recommend using ctrl+shift+` as you will get the picker then, just not with the general toggle panel commands.


Probably example from the docs is not working

Hello,
Please take a look at the example from the docs
It doesn't look to me that it caches. The value is updated right away.
I never used vue caching so I'm not sure whether it's me missing smth, or it is not working.
I tried both production and development modes

You have to look at the source code directly @OlzhasAlexandrov
I will update the cache option since it brings a lot of confusion and will instead cache the page and avoid re-rendering the page on the SSR, it's planned for a future release.

@Atinux
Seems like that you talking about will resolve my confusion #550 .
right ?


Has Integrated been integrated with Laravel core

I upgraded to 5.2 and all my Integrated tests broke. I have read that all the functionality of Integrated has been integrated into the core. I just can't see how to use Laravel's TestCase with Selenium.
If this is true can you update the Readme.md.

So I did a little more reading and it looks like the majority of functionality has been moved over to Laravel core, just not the Selenium bits. I'd be happy to update this to a 5.2 release. Can you point me in the right direction as to what are the Selenium (and non-integrated) bits that we need to keep.
By the way, the Selenium integration has been a life saver for us. Thanks!

+1 how can i just add the selenium part to Laravel 5.1


Dataset warehouse

Hi @izhengfan ,
Great work! I read your both papers and tried your both repository including your ORB_SLAM2 odometry adaptation with your dataset attached (Dataset Room) in the repository. I wanted to give try with "Dataset warehouse" which you mentioned in your papers. The reason why i wanted to try is to see horizontal faced camera. I tried to create my own dataset using a camera and AMCL pose in "x,y,theta" , so far it did not give me a good results. It would be nice if you share "Dataset warehouse" with our community.  Well appreciated.
Thank you.
Shashika

Hi,  I am sorry Dataset Warehouse can not be shared because it comes from one of our partner  companies.

Hi @izhengfan
It is okay. Thank you. And one thing, are you using 'millimeters' instead of 'meters' as your odometry linear measurement units ?
Thank you.
Shashika

yes, it is mm

@izhengfan Thank you.


Some problems about torch_sampling when running the reproduction code

Dear authors,
Your work is quite impressive and insightful.
After installing all the dependencies as you noted, I still failed to run your reproduction code. Specifically, I ran the command ./tsp{N}_test_{decoder}.sh tsp{N}, and it reported:
Traceback (most recent call last):
  File "./test_AS_MCTS.py", line 1, in <module>
    from inc.tsp_args import *
  File "/home/Documents/DIMES-main/TSP/TSP-KNN/inc/tsp_args.py", line 3, in <module>
    from inc.utils import *
  File "/home/Documents/DIMES-main/TSP/TSP-KNN/inc/utils.py", line 1, in <module>
    from inc.header import *
  File "/home/Documents/DIMES-main/TSP/TSP-KNN/inc/header.py", line 24, in <module>
    import torch_sampling as pysa
ImportError: /home/.conda/envs/dimes/lib/python3.8/site-packages/torch_sampling.cpython-38-x86_64-linux-gnu.so: undefined symbol: _Z15segment_csr_cpuN2at6TensorES0_N3c108optionalIS0_EESs

After many trials and reinstallation, the issue persist. So I wonder how to fix it.
Thanks a lot.

I updated all the pyg-related dependencies to the latest version, and it works.

Thank you for your interest in our work.
We appreciate your valuable feedback about pyg dependency. We will add a notice into the readme file.

I updated all the pyg-related dependencies to the latest version, and it works.

Hello, I also have the same issue, and I cannot tackle it for a whole day. Can  you provide the specific versions of  the pyg-related dependencies?  Thank you very much.

@L-fu-des22 Thank you for your interest in our work.

Hello, I also have the same issue, and I cannot tackle it for a whole day. Can you provide the specific versions of the pyg-related dependencies? Thank you very much.

I have already posted the specific versions of dependencies in README.md.
To be more specific, my commands to install the dependencies were:
pip install --no-index torch-scatter==2.0.7 -f https://pytorch-geometric.com/whl/torch-1.7.0+cu110.html
pip install --no-index torch-sparse==0.6.9 -f https://pytorch-geometric.com/whl/torch-1.7.0+cu110.html
pip install --no-index torch-cluster==1.5.9 -f https://pytorch-geometric.com/whl/torch-1.7.0+cu110.html
pip install torch-geometric==2.0.4
pip install ./torch_sampling

Does this work for you? If this still does not work, would you mind providing more information about your issue?

Thanks for your so quick response. I will try it again. By the way, can I ask that what's the version of the python? python3.7 or 3.8? Thanks again.

Finall, eventually, the provided code <sh ./tsp500_test_G.sh tsp500> successfully run! After a whole day strugglling! I will write down how I to do so.

Finall, eventually, the provided code <sh ./tsp500_test_G.sh tsp500> successfully run! After a whole day strugglling! I will write down how I to do so.

Thank you so much for sharing your valuable experience! This will considerably help others who run the code in the future. I will add a link to your reply into our README so that others can see it as well.

By the way, can I ask that what's the version of the python? python3.7 or 3.8? Thanks again.

I was using Python 3.7.10 (packaged by conda-forge). Thanks for pointing out that this information is missing in our README. I will add it to README, too.


Filter silenced client events

This PR has two components, related to https://github.com/sensu/uchiwa/issues/264

Adds a filter, hideClientSilenced, which will hide events from the Event view if the event's client.acknowleged property is true. Also adds a "Silenced Clients" option to the Hide drop down menu which toggles this filter.
Modifies the event view such that the icons in the second column silence/unsilence/show the silence status of the event source (client) and adds a column after the third column containing icons that silence/unsilence/show the silence status of the check.

This is dependent on a forthcoming PR to sensu/uchiwa which will add the client.acknowleged property to events.

The dependent PR is https://github.com/sensu/uchiwa/pull/268

Sorry for the delay, it has been a busy week at work.
I like the hideClientSilenced filter, great work!
Concerning the additional speaker icon, I feel like it might be confusing. Also, I'm not convinced that we need the icon for the client status in the events view, if we have the hideClientSilenced filter. Any thoughts @amdprophet ?

I definitely understand how having two icons could be seen as confusing, particularly since the function of the icons in the second column of the Events table changes but the appearance does not.
I see them as a benefit as they provide better visibility into the suppression status of an event. In one view, you can now definitively tell whether an event has been suppressed by a stash, and what the source of that stash is. It also makes it easier to see which events will be hidden when when toggling the Silenced Clients filter.
There's also precedent for this in sensu-dashboard, which I see as a spiritual ancestor of Uchiwa. However, that also makes me biased -- because I used sensu-dashboard and worked on another dashboard that displayed Sensu data with a similar design in the Events view, it makes perfect sense to me, when it might not to someone who has never used those projects.
I'm happy to remove that functionality if there's consensus that it's too confusing to be worthwhile.

For visibility, fixed merge conflict preserving ng-if="user.canPost()" on the stash() buttons.

@palourde @rmc3 I like the idea of additional visibility by showing that a client is silenced on the events page. I have no opinions on how it should be shown.

@amdprophet @palourde If there are ideas on how we might indicate that the client is silenced on the events page in a less confusing manner, I'm happy to work on implementing them.

@rmc3 can you attach a screenshot of what it currently looks like?
My thoughts are that the speaker icons should be grouped somehow with the check & client names. I'm not quite sure of how to illustrate it other than putting both in a div that has a border around it. Maybe we can just get this functionality merged in and worry about styling in a separate PR.

@amdprophet

names sloppily obscured to protect the innocent

@rmc3 @palourde I can see the possibility for confusion with the speaker icons not being directly under the Source & Check columns. Anyone who has used Sensu Dashboard in the past should feel right at home though.
@palourde do you have any ideas for stylistic improvements?

@amdprophet @palourde how about this? I'm not terribly great with HTML, probably some clean way to adjust for the difference in width between fa-volume-on and fa-volume-off, but it's a stab at what @amdprophet was talking about.

@rmc3 apply the fa-fw class to the icons - it will set a fixed width.

@amdprophet @palourde with fa-fw on the icon spans. Most recent commit contains this update.

Sorry about the second merge -- forgot to git pull before implementing that change :)

Thanks @rmc3 for the PR!
I like the few adjustments you made, much more cleaner. I'll worry about the stylistic improvements later!


2.0.3 release

Could you roll out a new release to have the tomcat 8.5.x support also generally available?

Until that is done, is 2.0.3-SNAPSHOT available on a SNAPSHOT repository somewhere?

Hey there! :wave:
Thanks for opening an issue with jspc-maven-plugin. :+1: :bowing_man:
At the moment, the jspc maven plugin does not have an active maintainer to process your request. :no_entry:
While the Jasig jspc maven plugin is without an active maintainer, we recommend the Apache Sling jspc maven plugin and the Jetty jspc maven plugin as alternatives that are actively maintained. :white_check_mark:
If you are interested in becoming a project maintainer, there is a uPortal-dev list post where you can register your interest. :email:
Thanks again for contributing to the  jspc-maven-plugin! :sparkles:

Any changes here?

Not yet, still waiting for new maintainers to step forward.
If you're interested in becoming a maintainer, feel free to reach out at on the uPortal-dev list.

To whom it might concern:
I've released a JspC Compiler for Tomcat 9.0+ on maven central for this plugin.
https://search.maven.org/artifact/de.grundid/jspc-compiler-tomcat
Please use version 9.0.2 or above.


Read contacts using Node

Code sample to read contacts using Nylas Node SDK.

I would like to work on this one

Awesome @danielevilela - looking forward to reviewing your PR within the next few days.


Add support for streaming pull receipts.

Closes #4325

test

I didn't intend for the modack_on_receipt  functionality to be optional, rather, whether to process them before or along with the callbacks (which I thought could possibly take a long time).  My wording could have been better though.

@lukesneeringer I removed the extra "knob" as you suggested.  PTAL.  thanks.

@chemelnucfin can you re-base this now that request batching is in?

@jonparrott rebased

Is this intended to close #4325?  It should say so in the description (and the initial commit message).
Also, that issue was marked as release blocking but we released pubsub-0.31.0 without merging this PR (yesterday).  The issue is also marked triaged for GA, so maybe this PR just needs to be merged before pubsub-1.0.0?  @jonparrott can you clarify?

@tseaver Yes, I believe that it's 1.0.0 release blocking, not 0.31.0 release blocking.

@tseaver I'll change the commit message before I merge it.

Yes, "release blocking" in this instance means it's blocking GA. I released 0.31.0 yesterday because it contained two significant fixes to memory consumption problems.

Approved post hoc. :-)


Get all automated checks passing

Closes
Code Changes

[ ] get everything working again

Steps to Confirm

[ ] list any manual steps taken to confirm the changes

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation Updated:

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md

Description Of Changes
Write some things here about the changes and any potential caveats

looks like some stuff around FE broke (specifically the newer classify stuff

non-external ctl tests are passing, now to fix everything else

down to 22 ops unit tests failing


⚠ Bofrost.lu has degraded performance

In b12a56c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1822 ms

Resolved: Bofrost.lu performance has improved in af2525e after 8 minutes.


Extensible connector in AAD connect

Let's assume we have user getting provisioned from On prem AD to Azure AD using Azure AD connect.
We have a application (ABC) that is exposing web service. this application is not connected to on prem AD. We want to provision application user which we are having from web service end point to Azure AD using extensible connector in ADD connect. Is it possible to keep ABC => Azure AD provisioning in AAD connect where those set of user not at all present in on prem AD.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 938c7dba-41d9-92c4-fb2f-feeba1878c13
Version Independent ID: b221ae33-5625-b912-839c-14aeef5ac744
Content: Tutorial:  Integrate a single AD forest to Azure using PHS
Content Source: articles/active-directory/hybrid/tutorial-password-hash-sync.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@AmitavaHazra
Thanks for your feedback! We will investigate and update as appropriate.

@AmitavaHazra, I apologize for the delay in my response, as it took me sometime to dig into this. This issue would needs to be tried out and for that I would recommend you to get a case opened with the Microsoft Support team, so that they can help you further.
Hope this helps. Closing this thread for now.

@souravmishra-msft ,
Actually I was exploring this in my lab and hence there is no provision for me to create MS ticket with trial subscription. It would be good to take this as feedback and extend AAD connect's functionality.
Reference: you can also refer below thread that indicates that we should not add connector to AAD connect except multiple domain one.
https://github.com/MicrosoftDocs/azure-docs/issues/54518
Please suggest whether MS should extend AAD connect functionality like MIM sync engine does.


...is not in the window scope

Im storing the collections indies an object. I get the above error. I'm new to JS and not sure if this is a bug or my ignorance.
Thanks.

I get this error. My collection is not even a nested object. And I am doing this within a package. Any help?

Some error in here with the package.


classpath error starting repl in freshly created app

I fail to start the app following the instructions here: https://juxt.pro/edge/docs/setup.html
This is what I did:

created a new repository
added Edge to my project
created a new app: $ ./bin/app acme/app --cljs
started a terminal repl: $ ../bin/rebel --cljs -A:dev:dev/build:build

It gives me the following error:
Error building classpath. Manifest type not detected when finding deps for juxt.edge/app.logging in coordinate #:local{:root "../edge.app.logging"}

This would probably indicate you have an out of date version of clj, can you do clj -Sdescribe ?

Yes, that was the problem. (clj -Sdescribe didn't even work).


remove unused functions (identified by cppcheck)

[src/Cedar/Account.c:854]: (style) The function 'AddGroupTraffic' is never used.
[src/Mayaqua/Secure.c:1455]: (style) The function 'AddSecObjToEnumCache' is never used.
[src/Mayaqua/Network.c:18445]: (style) The function 'AddSockList' is never used.
[src/Cedar/Account.c:870]: (style) The function 'AddUserTraffic' is never used.
[src/Cedar/Server.c:1045]: (style) The function 'AdjoinEnumLogFile' is never used.
[src/Cedar/Admin.c:13780]: (style) The function 'AdminConnect' is never used.
[src/Mayaqua/Encrypt.c:855]: (style) The function 'BigNumToStr' is never used.
[src/Mayaqua/Str.c:2113]: (style) The function 'Bit128ToStr' is never used.
[src/Mayaqua/Encrypt.c:898]: (style) The function 'BufToBigNum' is never used.
[src/Mayaqua/Internat.c:1874]: (style) The function 'CalcStrToUtf8' is never used.
[src/Cedar/Hub.c:6689]: (style) The function 'CalcTrafficDiff' is never used.
[src/Mayaqua/Internat.c:1819]: (style) The function 'CalcUtf8ToStr' is never used.
[src/Mayaqua/Network.c:6495]: (style) The function 'CanGetTcpProcessId' is never used.
[src/Cedar/WinUi.c:7226]: (style) The function 'CbInsertStrA' is never used.
[src/Cedar/Client.c:3035]: (style) The function 'CcEnumObjectInSecure' is never used.
[src/Cedar/Client.c:2826]: (style) The function 'CcGetCommonProxySetting' is never used.
[src/Cedar/Client.c:2857]: (style) The function 'CcSetCommonProxySetting' is never used.
[src/Cedar/Cedar.c:575]: (style) The function 'CedarLog' is never used.
[src/Cedar/WinUi.c:9841]: (style) The function 'Center2' is never used.
[src/Mayaqua/Encrypt.c:814]: (style) The function 'CertTest' is never used.
[src/Mayaqua/Encrypt.c:809]: (style) The function 'CertTest2' is never used.
[src/Mayaqua/Encrypt.c:819]: (style) The function 'CertTest_' is never used.
[src/Mayaqua/Cfg.c:1705]: (style) The function 'CfgIsFolder' is never used.
Changes proposed in this pull request:

remove unused functions

Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.
SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

1

This is a nice PR and I'd love to merge it. We need one more +1 to do that. Cheers

PR has been merged. Thank you for your hard work and the great addition/subtraction :)


[WIP] [release-1.12] OIDC support

Backport of the OIDC bits from EKB upstream main.

update of encryption/auth tests to run OIDC tests too (21053d4ade7caac93821739f2418c8c080c7b077)

/test all

/test all

Tests are failing (at least) because we deploy eventing-core 1.11, which does not support OIDC yet (e.g. missing audience field in broker CRD)...

/hold
as WIP

/retest

/retest

/retest

/retest-required

/test 414-test-reconciler-keda-aws-414

/test 415-test-reconciler-aws-415

/test 415-test-reconciler-aws-415

/test ?

/test 412-test-reconciler-aws-412

/retest-required

/unhold


Support for DataLoafPackageDirFmt format to import ANCOM-BC results QZA files

Hello, thank you so much for the qiime2r package. I recently tried to import my ANCOM-BC results (output of qiime composition ancombc) but it seems that its format (DataLoafPackageDirFmt) is not supported by read_qza.
Looking at the code I think I might try to add it myself, but since that would be my first time submitting a PR to someone else's repo I want to ensure that I follow the correct process and adhere to your projects contributing guidelines. I couldn't find any Contributing section in the README, so I would like to know if it's okay if I just fork the repo, work on it, and then do a PR and remove my fork. If you prefer to add the functionality yourself, that's fine with me too.

@IrshadUlHaq1 I opened a PR addressing this. In the meantime, you can read ANCOM-BC results in R using any CSV package.


opendistro_security_roles is a bit unclear

Hi,
I'm setting up a multi tenant cluster and trying to figure out the mappings. It might be that I have misunderstood something fundamental, but this was a bit of a head-scratcher.
https://opendistro.github.io/for-elasticsearch-docs/docs/security-access-control/api/#patch-user only mention how to map users to backend_roles but not to opendistro_security_roles. This meant that I spent way to long trying to map my normal user to backend_role instead of an opendistro_security_roles .
In the end this closed issue solved the problem for me https://github.com/opendistro-for-elasticsearch/community/issues/155 . I guess security roles (not opendistro security roles)  is only mentioned once https://opendistro.github.io/for-elasticsearch-docs/docs/security-access-control/users-roles/ .
I guess in my case I would not have had this issue if there where an API example of how to map to an opendistro_security_roles .
Overall the user experience have been pretty nice.

Hi @oscarkraemer, thanks a bunch for reporting. When we first released the Security plugin, you could only add backend roles to users. I don't know when we added the ability to also directly map security roles, but in short, the docs haven't kept up with the times. When we get some free cycles, we'll reexamine our recommendations around how to work with users and roles, along with the API calls.

Hi @oscarkraemer, thanks for letting us know about this issue. We've updated the documentation to include how to map users to opendistro_security_roles when creating a user and updating a user's attributes, which you can find in the Create User API section and Patch User section.
Hope this helps!


sync with master branch

[Current coverage][cc-pull] is 100%

Merging [#360][cc-pull] into [master][cc-base-branch] will decrease coverage by +0.80%

2 files (not in diff) in ...ameBundle/Service/AI were modified. more

Hits -2

1 files (not in diff) in ...c/GameBundle/Service were modified. more

Hits -1

2 files (not in diff) in ...rc/GameBundle/Entity were modified. more

Hits -2

1 files (not in diff) in src/GameBundle were modified. more

Hits -1

2 files in src/GameBundle/Model were modified. more

Misses -1

2 files in src/GameBundle were modified. more

Misses -2
Hits +1

@@             master   #360   diff @@
======================================
  Files            24     24
  Lines           374    365     -9
  Methods          77     77
  Messages        154      0   -154
  Branches          0      0
======================================
- Hits            371    365     -6
+ Misses            3      0     -3
  Partials          0      0

Powered by Codecov. Last updated by [51406e7...64c40bd][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/51406e7d13e5a39550127c84662697f938b23442...64c40bdc2f8b656835479b614ddd8b7d6163a34b
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/360?src=pr


Section on TFS 2017 agent versions is incomplete and incorrect

TFS 2017u2 provided agent version 2.117.2 and TFS 2017u3.1 (and presumably also 2017u3) provided agent version 2.122.1, so it seems very unlikely that the listed agent version 2.112.0 is correct - maybe that's the correct agent version for TFS 2017u1, but surely not for 2017u3.  Currently the list doesn't include TFS 2017u1 and 2017u2; I suppose we can assume that 2017u3.1 (also not listed) provides the same agent version as 2017u3, but I believe it would be better to have that explicitly listed as well, or at least include a note that it is the same.  Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43799c5d-2f13-cc76-a1c0-a3f850e16d4e
Version Independent ID: 97a5b73f-faf7-f9c0-9269-fc79984616d6
Content: Deploy a build and release agent on Windows
Content Source: docs/pipelines/agents/v2-windows.md
Service: unspecified
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Addressed in a pending docs change


Justification in table rendering does not work in HTML5

Justification in tables (using the table extension) does not work in HTML5.
Let's consider an example below.
|testtest1|testtest2|testtest3|
|--------:|:--------|:-------:|
|right    |     left|   center|

This should be rendered like this (in ASCII art):
|testtest1|testtest2|testtest3|
|---------|---------|---------|
|    right|left     | center  |

and works fine without CSS, but does not work at least in some cases.
After a couple of minutes of struggling, I found it was the same problem with this.
A column in the last row is always rendered using  in markdown/extensions/tables.py, although align property is deprecated (at least) in HTML5 (I don't know when it was deprecated) so it will not override the text justification specified in CSS properly (I confirmed it with Chrome 31.0.1650.57m on Windows). It should use  instead when the output format is compatible with CSS.

Would it be acceptable to have an option to have the extension put the alignment in a style attribute? I'd be willing to submit a pull request if it has any chance of getting accepted.
I validate all my generated HTML using the validator.nu checker and this is causing a lot of red lines in the test report.

@mthuurne you are free to build your own table extension which has whatever behavior you want. Whether you start from scratch or fork the existing extension (within the confines of the license), doesn't matter to me. For that matter, perhaps one of the existing third party extensions already meets your needs.

I already implemented a workaround by having a Treeprocessor change the align attribute to style. But I was hoping for a solution that would lead to less code to maintain, while forking the extension would increase the maintenance burden instead (it's only ~200 lines, but that's still a lot more than the workaround).


Assignment to container column ignores values from database

Here is an odd issue I'm encountering:
let(:klass) do
  TestRecord = Class.new(ActiveRecord::Base) do
    include AttrJson::Record
    self.table_name = "products"

    attr_json :foo, :integer, default: 1
    attr_json :bar, :string
  end
end
let(:instance) { klass.new }

it 'works for the simplest case' do
  instance.bar = 2
  instance.save
  expect(instance.foo).to eq 1
  expect(instance.bar).to eq '2'

  instance.foo = 9
  instance.save
  expect(instance.foo).to eq 9
  expect(instance.json_attributes).to eq({ 'foo' => 9, 'bar' => '2'})

  instance.json_attributes = { a: 1, b: 2 }
  instance.save

  # Expected this:
  # expect(instance.json_attributes).to eq({ 'a' => 1, 'b' => '2', 'foo'=>9, 'bar'=>'2' })

  # But it's actually this....
  expect(instance.json_attributes).to eq({ 'a' => 1, 'b' => '2', 'foo' => 1})
end

Hmm, I'm confused what's going on.
I would assume if you set  instance.json_attributes = { a: 1, b: 2 }, that is the new hash for json_attributes, and it would overwrite anything that was there before.
You say you are expecting it not to overwrite all the keys... I think you probably should expect it to overwrite all the keys. I think this is just Rails db column handling, and attr_json isn't really involved. For what you say you expect, you might instead want to do: instance.json_attributes.merge(a: 1, b:2).
But you also say your actual result was not just {a: 1, b:2}, but also included foo -- that's the part that surprises me, I wouldn't expect it to include foo either, since you said instance.json_attributes = { a: 1, b: 2 }, which should just set the container to exactly that, without foo.
I'll try to find some time this week to look at your example and confirm that foo is there, and see if I can figure out why if so.

Oh yes, you’re right. I was working on the merge feature when I came across
this, so the expectation is incorrect.( I should add that this behavior is
unrelated to the merge feature and occurs on the master branch as well.)
On Sun, Jun 16, 2019 at 11:04 AM Jonathan Rochkind<EMAIL_ADDRESS>wrote:

Hmm, I'm confused what's going on.
I would assume if you set instance.json_attributes = { a: 1, b: 2 }, that
is the new hash for json_attributes, and it would overwrite anything that
was there before.
You say you are expecting it not to overwrite all the keys... I think
you probably should expect it to overwrite all the keys. I think this is
just Rails db column handling, and attr_json isn't really involved. For
what you say you expect, you might instead want to do: instance.json_attributes.merge(a:
1, b:2).
But you also say your actual result was not just {a: 1, b:2}, but also
included foo -- that's the part that surprises me, I wouldn't expect it
to include foo either, since you said instance.json_attributes = { a: 1,
b: 2 }, which should just set the container to exactly that, without foo.
I'll try to find some time this week to look at your example and confirm
that foo is there, and see if I can figure out why if so.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jrochkind/attr_json/issues/69?email_source=notifications&email_token=AABFAMFFPLYE6K3TABNNI53P2ZI73A5CNFSM4HYQ7NE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZO6IY#issuecomment-502460195,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABFAMAHMXD4VAV7YTC3ENTP2ZI73ANCNFSM4HYQ7NEQ
.

--
Volkan Unsal
Product Engineer
volkanunsal.com

To get your "failure case expectation" to pass, I had to change the b value to an integer. But this one does pass:
expect(instance.json_attributes).to eq({ 'a' => 1, 'b' => 2, 'foo' => 1})

And I don't expect it to, I actually expect:
expect(instance.json_attributes).to eq({ a: 1, b: 2 })

Will try to debug/diagnose.

Aha, wait!
It's the default value for foo that makes this happen. attr_json :foo, :integer, default: 1
At present in attr_json, defaults will be enforced at every read/write -- if the key does not exist at all -- not just for a newly created object. That may be something you are not expecting?
But that's why it adds the value 'foo' => 1 to the Hash you manually set, on save -- it's enforcing the default.
So knowing how defaults work, all of these are expected:
inst = klass.new
inst.save
expect(inst.json_attributes).to eq {"foo"=>1}

inst = klass.new
inst.json_attributes = {"other_key_1" => "value", "other_key_2" => "value"}
inst.save
# foo added due to default
expect(inst.json_attributes).to eq({"other_key_1"=>"value", "other_key_2"=>"value", "foo"=>1})

And your example is just a case of that, the default value being added. If you remove the default setting for attribute foo, your example works as we expect -- the value of json_attributes is exactly what you set it to. But with the "default" setting for foo, the default value you specified is added.
Does this make sense?  This may be an unexpected or undesirable way that "defaults" work -- which we could talk about separately and try to spec out how we'd want it to be working. Although it might be difficult to implement in a way other than the way it's currently implemented, and I kind of suspect the way it's currently implemented might be good enough, dissenting opinions welcome (ideally with concrete use cases).
But there is no bug or unexpected behavior in the container attribute itself, or with "old" values. And indeed, I was surprised, because the way attr_json implements things, it would be really surprising for "old values" to somehow come back -- attr_json doesn't keep any state except in the Hash that is the value of the container attribute (which is a more or less ordinary Rails attribute), there's not really any place for "old" state to come back from.

That works for me. But I also think it's be a good idea to have a way to get the raw value of the attribute without the defaults. Maybe if I were to add the prefix raw_ it would give me the raw value. What do you think?

Can you give me a use case?
Can we compare to ordinary Rails with new Attributes API default values, is there any way to get the values without defaults there? I don't think so, I think it will work similarly. https://metova.com/rails-5-attributes-api/
You can't see the value "without the default" because the default is really there.  In current code there is no way to read or write the value without the default being applied (if the key is otherwise missing; if you set it to nil that's a legitimate value that can be differnet from the default). So there's no way to see it "without the defaults", because there's no way to have it "without the defaults*.
Do you have a use case where you need/want defaults to not be applied in cases attr_json is currently applying them?

I am definitely very reluctant to add more API/features to attr_json, like a raw_ method corresponding to every container attribute mentioned in an attr_json. I would not look fondly on that solution.

Yes, I think you're right. I can't think of a use case for it right now.


Question to TimMcCool (and possibly other contributors)

Do I have permission to rewrite this library in C++ (maybe with a little bit of modifications for my own taste, but mostly the same methods and code)?

This is because I need really fast code and Python is pretty slow.

Yes, you have permission if you credit the original library. But I don't think the C rewrite will be faster in a way that makes a difference


fix TestCheckHeader

Signed-off-by: yxxhero<EMAIL_ADDRESS>
Description
fix TestCheckHeader

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] Code compiles correctly.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #1201 (96ee160) into main (fa3c2c7) will decrease coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   46.59%   46.06%   -0.54%
==========================================
  Files         133      133
  Lines       10528    10528
==========================================
- Hits         4906     4850      -56
- Misses       5068     5133      +65
+ Partials      554      545       -9

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
46.06% <ø> (-0.54%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_piecetask_poller.go
30.37% <0.00%> (-22.97%)
:arrow_down:

...ent/daemon/peer/peertask_piecetask_synchronizer.go
46.95% <0.00%> (-9.76%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
56.47% <0.00%> (-1.22%)
:arrow_down:

client/config/dfget.go
29.06% <0.00%> (+2.32%)
:arrow_up:


SPARKC-412: Optimize Spark SQL count() performance by calling C cou…

…nt()

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with success

Two questions:

what to handle if  optimizer returns empty column for query other than count query?
Is it possible to create a virtual column called count and returns the C* count result directly?

Optimiser pass empty column set by any reason:
I do not see problem here. The connector should return row RDD with no columns. That is exactly what it did. count is called internally
passing count directly to Spark
I did not find how to make it.


Fixes API compatibility issues on wasm and native

This makes the API on wasm and native compatible while being "generic" in the inner implementation on each target.

also #41


Fix the way of getting  Instagram Account ID

The way Facebook allow to get Instagram Account ID has changed. Now for
the user to be able to use with this lib their Instagram Accounts has to
meet to requirements:

Be an Instagram Business Account
Be this Instagram Business Account linked to a Facebook page.

This is super annoying and a terrible DX and UX experience. But is the
price to play with a big corp I guess.
So this PR try to fix this lib by adding 2 new endpoints and removing
the old /me which is not used anymore.
The new endpoints are

/me/accounts to get a list of authorized FB pages by the user
(accessToken)
/${facebook-page-id} to get the linked Instagram Business account of
that page.

This involves some UI thinking. This is what I think I would do:

Prompt users to log in with Facebook. Set the needed API permissions
When they log in with Facebook and accept necesary permissions I show
then the name of the pages they authorized. They chose one
I do a second request to get the linked Instagram Business Account

For login the user with Facebook on my Node app I'm using passport-facebook
☝ Those points in code:
import {
  GetAuthorizedFacebookPagesRequest,
  GetAuthorizedFacebookPagesResponse,
  GetLinkedInstagramAccountRequest,
  GetLinkedInstagramAccountResponse,
} from 'instagram-graph-api'

// Get the accessToken from the user.  (Ex.: Using Passport.js in a Node project)

async function getInstagramId (): string | null {
  const pagesRequest: GetAuthorizedFacebookPagesRequest = new GetAuthorizedFacebookPagesRequest(accessToken)
  const pagesResponse: GetAuthorizedFacebookPagesResponse = await pagesRequest.execute()
  // This can be done showing a UI with authorized pages. Here I'm picking the first
  // to make the example shorter
  const firstPage = pagesResponse.authorizedFacebookPages()[0]

  if (!firstPage) return null

  const instagramAccountRequest = new GetLinkedInstagramAccountRequest(
    accessToken, firstPage.id
  )
  const instagramResponse = await instagramAccountRequest.execute()

  return instagramResponse.instagramPageId()
}

Now is when we can start publishing content on behave of the user. 😅
TODO

[ ] Fix tests
[ ] Fix documentation comments
[ ] Finish adding documentation on the README.md to explain how to develop this lib

Hey @andresgutgon , thank you so much for this contribution! A couple of things:

I'm going to be on holidays until July 23th, I'll test the functionality and fully review this then
Do check this out: https://github.com/TiagoGrosso/instagram-graph-api-lib/blob/master/CONTRIBUTING.md

Don't forget to replace the @author tags
The @since tags should be replaced by  `next.release`

Let's not add anything to the ReadMe about "Development" on this PR. I understand what you're getting at, and I'll add it to the CONTRIBUTING.md file once I get back

Once again thanks a lot for this 😀

@TiagoGrosso I did the tests and fixed the documentation. Please let me know if you see it ok

Codecov Report

Merging #69 (4bf8a57) into master (0d51af2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           69        75    +6
  Lines         1102      1145   +43
  Branches        43        42    -1
=========================================
+ Hits          1102      1145   +43

Impacted Files
Coverage Δ

...acebook_pages/GetAuthorizedFacebookPagesRequest.ts
100.00% <100.00%> (ø)

...cebook_pages/GetAuthorizedFacebookPagesResponse.ts
100.00% <100.00%> (ø)

...ram_account_info/GetInstagramAccountInfoRequest.ts
100.00% <100.00%> (ø)

...am_account_info/GetInstagramAccountInfoResponse.ts
100.00% <100.00%> (ø)

...tagram_account/GetLinkedInstagramAccountRequest.ts
100.00% <100.00%> (ø)

...agram_account/GetLinkedInstagramAccountResponse.ts
100.00% <100.00%> (ø)

...r_long_lived_token/GetUserLongLivedTokenRequest.ts
100.00% <100.00%> (ø)

..._long_lived_token/GetUserLongLivedTokenResponse.ts
100.00% <100.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d51af2...4bf8a57. Read the comment docs.

Thanks 🙏 this month I'm offline


Parent view is losing background color if swipe to go back is enabled inside navigation controller

if i had a switch turned on inside a view and i do swipe right to navigate to previous controller, the parent view of the switch has lost his color

override method in your cell
prepareForReuse() {
  super. prepareForReuse()
  // SET CURRENT COLOR
}

The parent views aren't cells, they are UIView inside a stackview.
I must use a table row for achieving what I need and avoid this problem or I can still go my way and resolve this issue in some way?

Can't resolve this issue, any hint?
I would love to integrate your switch in production

Even with the last commit, the problem is still there.
Parent view is losing color if I'm swiping back from a navigation controller

Now it's working! Thank u very much!


misleading installation instructions in readme

you should get rid if the Install Linuxbrew (tl;dr) section in the Readme. It's misleading

Which other instructions are critical? I think this for sure:
export PATH="$HOME/.linuxbrew/bin:$PATH"

It's just this header with the first instruction for ruby. The entire
process should be shown in one place and one place only so as not to
confuse users regarding the installation process.
On Wed, Aug 5, 2015 at 2:55 PM, Shaun Jackman<EMAIL_ADDRESS>wrote:

Which other instructions are critical? I think this for sure:
export PATH="$HOME/.linuxbrew/bin:$PATH"
—
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/linuxbrew/issues/503#issuecomment-128160651.

The entire process is in that one command.  The rest is just installing dependencies and pointing your system to use Linuxbrew stuff by default.

Don't you agree that that's part of the installation process?
On Aug 5, 2015 3:05 PM, "iggyvolz"<EMAIL_ADDRESS>wrote:

The entire process is in that one command. The rest is just installing
dependencies and pointing your system to use Linuxbrew stuff by default.
—
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/linuxbrew/issues/503#issuecomment-128163655.

Many systems already have the dependencies installed. The only really critical steps that's missing from the tl;dr modifying the PATH.

Oh, gotcha. Excuse me for using issues like stackoverflow
On Aug 5, 2015 3:54 PM, "Shaun Jackman"<EMAIL_ADDRESS>wrote:

Many systems already have the dependencies installed. The only really
critical steps that's missing from the tl;dr modifying the PATH.
—
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/linuxbrew/issues/503#issuecomment-128174571.


SHIFT-Curso, CTRL-C and CTRL-V not working but where in old console

Environment
Windows build number: Microsoft Windows [Version 10.0.18362.356]
Windows Terminal version (if applicable): 0.5.2681.0

# Steps to reproduce

Try to select, copy and paste with the normal windows shortcuts for these operations.

# Expected behavior

I can select, copy and paste text with these shortcuts just like in the old console

# Actual behavior

The operations do not work

This is mostly: /dup #2285 #2749
Additionally, keyboard selection is in spec currently at /dup #2840, with the original issue being /dup #715.
From elsewhere in #2749:

Don't do that, just add a keybinding for copy (that was my bad the action is copy not copyText).
{ "command": "copy", "keys": ["ctrl+c"] },
{ "command": "paste", "keys": ["ctrl+v"] }

should do the trick.
You can set the keybinding to whatever you want. Ctrl+C, Ctrl+Shift+C, Shift+Insert.


moved google benchmark to v1.9.0

qualification: locally built on Windows 11 w/ VS2022

Looks fine. But we need to make sure to update the third_party/README for the benchmark version and commit level right?

yes, you are absolutely right. I forgot to do that. Will do.


fix(feedback): fix migration issues

fixing migration issues
@mannyrivera2010 @lsemesky @cwilliams2017

:+1:


Determining training steps

In run_squad.py, num_train_steps is decided by len(train_examples).
But I think training steps should be decided by train_writer.num_features.
Guess the code is just copied from run_classifier.py?

Hi,
I also have this question. Have you got any ideas?

Haven't changed codes but maybe we need to call convert_examples_to_features() right after read_squad_examples() is done.
As model_fn_builder() needs num_train_steps as a parameter, the only place to put convert_examples_to_features() is there.
It would be like
# codes are simplified
if FLAGS.do_train:
  train_examples = read_squad_examples()

  train_writer = FeatureWriter()
  convert_examples_to_features()
  train_writer.close()

  num_train_steps = int(
      train_writer.num_features / FLAGS.train_batch_size * FLAGS.num_train_epochs)
  # num_warmup_steps =
  # shuffling
  # tf.logging.info * 4 stuffs
model_fn = model_fn_builder()
estimator = tf.contrib.tpu.TPUEstimator()

if FLAGS.do_train:
  train_input_fn = input_fn_builder()
  estimator.train()

@kwonmha Does the above method help? Did you implement it?
Thanks!

I haven't implemented it.
And I don't think that modification results in visible performance improvement.
This may increase training steps a little and the training steps have small effect on the performance.
(I understood "help" in the aspect of performance)
Just thought the code should be like that.


Did the song Infos + Lyrics disappear?

Hi Craig,
I no longer have access to this menu!
Is this normal?
Thanks for all
brannou

What menu? Material shows, and still does, artist, album, and song (lyrics) in separate view accessed via the "(i)" button - same as always.

The button is now grey. Not sure what happened on my side... Thanks

Then you don't have "Music and artist information" installed.
Please, use forums.slimdevices.com for support queries.

It is installed and works on iPeng ( I checked before informing you). Sorry for the annoyance!

Sorry, but I do not have the time to debug everyone's system - hence directing you to the LMS forums. This feature does work, I use it and multiple others do so. Why its not working for you is an issue with your system. I suggest you 100% confirm that its the "Music and Artist information" plugin that is installed - this is required.

My mistake sorry, I deleted it and I don't even know how... have a great day!


About backbone frozen training

Thank you for your outstanding contribution! When reading your code, I found that you froze the backbone (i.e. CLIPVisionTransformer) by setting its learning rate to zero in the settings. However, in the backbone, in addition to the original part of the CLIP, there are also some newly defined fpn layers, including some untrained ConvTranspose2d layers. Do these layers not need to be trained?

Hi, ZiYuTou!
The current version is the intermediate version code of WeakCLIP. In the final version, we separate the FPN from the visual backbone to ensure the parameter updating. We are cleaning the final version of the code and commit it to GitHub soon.


RTView: access to all log items

Currently, RTView provides an access to "problems" items (like Warnings or Errors), but it would be great to have an access to all log items.

We have expanded the scope of this task, to create a simple, unified UX for both historic and filtered views.


LinkType enum is uint8 but tcpdump defines linktypes > 255

The LinkType type is a uint8:
https://github.com/google/gopacket/blob/master/layers/enums.go#L93
However, the canonical list of linktype numbers currently has a max of 266.
http://www.tcpdump.org/linktypes.html
Additionally, looking at the pcap documentation, it looks like that is returned as an int
http://www.tcpdump.org/manpages/pcap_datalink.3pcap.txt
and when we use that function, we also use an int
https://github.com/google/gopacket/blob/master/pcap/pcap.go#L651
Edit: oh, I see how that works. The layers.LinkType() is casting the int to uint8.
I'm also not sure how to solve this in a fully backwards compatible way, but I figured I should bring it up since I noticed it...

Hi. Thanks for reporting it. Uint8 are used to optimize the lookup per the number of layer we actually support. I think that would be updated once we'll see the need for it.


single item orders with promotions do not get recategorized

https://github.com/jprouty/mint-amazon-tagger/blob/0d8a8ef102f5a5caad5f922babf51a1c2b9deb7e/tagger.py#L202-L204
https://github.com/jprouty/mint-amazon-tagger/blob/0d8a8ef102f5a5caad5f922babf51a1c2b9deb7e/mint.py#L199-L202
orders with subscribe and save show up as a single item order with a 5% promotion discount, resulting in a single item, but multiple transactions, in this case, the default category is used.

Hi @elgoldman. Are you using --verbose_itemize? I'm a bit confused on what behavior you're seeing vs what you're expecting. Can you clarify? Thanks!

thanks @jprouty, you are right, using --verbose_itemize  does result in the behavior I'm looking for.  I'm curious why this isn't the default behavior? If you order one shirt and have a category mapping from 'Apparel' on Amazon to 'Clothing' in Mint, why would you want it to not get recategorized just because there was a promotion?
the behavior I'm seeing (without --verbose_itemize) is this:
Case#1: the order has one item and no promotions. the mint transaction will get recategorized.
Case#2: the order has one item and a promotion. the mint transacction will NOT get recategorized.
maybe there's some use case I'm just not thinking of, where this would be desirable, but I would expect if you wanted to assign a category in one case you would want it in the other as well.
thanks for developing this great tool!

@elgoldman I hear you! I think I've got a fix for you (I also just added a shit ton of unit tests). Give that a shot. I'm closing for now; feel free to reopen or file new issues if it's not working as expected! Thanks for your feedback!


Add an optional route information codec

The serialization and deserialization was hard coded in _RestorableRouteInformation, which forces the RouteInformation.state to be serializable. This pr add a custom codec parameter to router so that customer can have complex data type as state object as long as they provide a custom codec.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This will be a breaking change, the go_router package will need to be migrate before the ci pass. I will do that if we move forward with this pr

This will be a breaking change,

Why is this? The new codec argument is optional and if not provided, we seem to be doing what we were doing before this change and use the StandardCodec for serialization?

Closing as not planned, we shouldn't be storing complex data in RouteInformation.state where it is designed to be serialized later.


Trigger support?

Hello,
first of all thank you for the rust picoscope library.
 I do miss trigger setup though. Have seen it in *-sys but not implemented on e.g. the streaming level. Did I miss something, or does the library need some more love?
Thanks,
Jiri

Hi Jiri,
I built this library for my own usage to stream gap-less data from any Pico oscilloscope and it was designed to give a simple single API over all the different drivers.
There's no triggering support because I haven't needed it. I've also found that triggering is much more useful in block mode which is also not yet supported.
I am open to any help or PRs adding these features and have many devices to test with, I just don't have the time to do it all myself!


add kubeconfig for cluster and public access

Currently kubeadmin kubeconfig points to <IP_ADDRESS>. This IP doesn't work outside of the localhost.

ClusterConfig.URL is already the URL of the API server. Instead of introducing a new config parameter (which we should only do if there's no better alternative, as one of our design goals is to minimise params) we may want to default to binding to the host's primary IP (=hostIP) instead of loopback or (more future-proof for multi-node) allocate a VIP and bind to that.
Of course, the URL param can always be overridden explicitly. Also, note that by design we default to not having any network access from the internet (i.e. no public IP/URL or open network ports for SSH).

@fzdarsky Currently ClusterConfig.URL is currently <IP_ADDRESS>. This is for local access. The new public URL is for Pods or external access, which is set to the host IP by default. They serve different purposes. <IP_ADDRESS> works as long as the command runs locally, while public URL, in the long term, should be bind to the public facing IP (host IP or load balancer IP). So calls from outside the host or inside the Pods can access the API service.
We need two URLs for HA: when the public URL is only temporary (e.g. DHCP, load balancer IP, etc), the local access can be a reliable backup for local access.

@rootfs yes. ClusterConfig.URL is currently <IP_ADDRESS>, which is why I suggested changing that to default to the hostIP (or auto-allocated VIP) instead. It'll be used for "internal" API traffic (as by default, there isn't any "public" access; if a user wants it, they can override the default URL param) between multiple nodes.
If running single node, using loopback instead of the hostIP is a relatively small optimization, but if users want that, they could still configure loopback explicitly.

@fzdarsky what if the host IP changes (e.g. acquired from DHCP)

@fzdarsky what if the host IP changes (e.g. acquired from DHCP)

That's when we'll have to switch to using a DNS name instead of an IP anyway. Basing off the host IP wouldn't work in this case.

@fzdarsky @rootfs if we switch to DNS name I think this would fix #266 bc then I could put an elastic or float IP in front of a host then assign the DNS to that address. This would allow for us to have a different IP than the address of localhost and the system private IP address. Although, I dont know if this would cause a larger issue or not but we wouldn't want to force traffic out of the host private address -> elastic or floating IP -> back to the host itself.

Although, I dont know if this would cause a larger issue or not but we wouldn't want to force traffic out of the host private address -> elastic or floating IP -> back to the host itself.

We cannot rely on the existence of an external load balancer. Instead, we'll probably need to allocate a VIP from DHCP and float it across control plane instances (e.g. assign VIP to leader) or use client-side load balancing. That also depends on how we want to handle DNS (e.g. whether to use mDNS or not). Probably needs some analysis / design discussions considering the multi-node case.
@mangelajo @oglok ^?

@fzdarsky I agree. I do think if we had some sort of way to provide alternate FQDNs we can solve a lot of problems regardless of the hosting provider. I don't think a config file would be the best solution but it could be an easy way for us to provide the option for additional hostname to validate the certificate with. I think a config file or even an after the fact parameter that we can issue against the microshift binary we could add the additional FQDN to the certificate or regenerate


_.defaults should have for-in fixes

_.defaults should have for-in fixes like _.extend.

Meager newb to the underscore.js source here, so feel free to shoot me down! :)
Anyway, this seems like a good idea to me and a fairly easy change to make, unless I'm missing something. Two suggestions. One is to simply call _.keysIn or _.keys (depending on which exact behavior we want) in _.defaults itself, as in:
  _.defaults = function(obj) {
    if (!_.isObject(obj)) return obj;
    for (var i = 1, length = arguments.length; i < length; i++) {
      var source = arguments[i],
            keys = _.keysIn(source), // or _.keys(source), depending on whether we want only "own" keys here
            l = keys.length;
      for (var j = 0; j < l; j++) {
        var key = keys[j];
        if (obj[key] === void 0) obj[key] = source[key];
      }
    }
    return obj;
  };

That solution duplicates a lot of the functionality already provided by the createAssigner internal function, though. It doesn't look like we can easily make use of createAssigner for _.defaults as it is, but maybe a small modification to createAssigner is in order: have it take a second (Boolean) argument that tells it whether to only assign properties/values when the property is undefined, as in:
  var createAssigner = function(keysFunc, undefinedOnly) {
    return function(obj) {
      var length = arguments.length;
      if (length < 2 || obj == null) return obj;
      for (var index = 0; index < length; index++) {
        var source = arguments[index],
            keys = keysFunc(source),
            l = keys.length;
        for (var i = 0; i < l; i++) {
          var key = keys[i];
          // not sure about the preferred coding style below; input welcome
          if ((undefinedOnly && obj[prop] === void 0) || !undefinedOnly) {
            obj[key] = source[key];
          }
        }
      }
      return obj;
    };
  };

  // ... and then ...

  _.defaults = createAssigner(_.keysIn, true); // or use _.keys, depending on which is preferred

The second option would require a very small  (non-breaking, AFAICT) addition of a conditional check to createAssigner but would have the benefit of making the creation of _.defaults nearly identical to the creation of _.extends and _.assign.
Thoughts? I'm happy to create a pull request for either of these, but don't to immediately do that, being a newb.

Thoughts? I'm happy to create a pull request for either of these, but don't to immediately do that, being a newb.

I think the undefinedOnly is a great solution. :+1:
My only suggestion: the if conditional could be simplified
if (!undefinedOnly || obj[key] === void 0) obj[key] = source[key];

Yep, do it @jmrog

Okay, thanks guys. I've submitted the pull request, with the small change mentioned by @jridgewell  (good call!).
Sorry about the multiple references showing up above this comment; was having some issues with git. The first commit reference above (5c58807) should be ignored. It doesn't affect the later commit and doesn't even exist anymore; didn't expect that it would still be showing up here.


[T2A2] [T15-A3] Lai Yingchen

Ready for Review

@yingchen0505 unique approach.

Use meaningful commit messages as discussed during tutorial.
Create different branches and pull requests for different activities.


Sidebar menu doesn't scroll

Description
When there are many items in the sidebar menu, and we scroll the page, the last items are not visible because they go under the footer component.
Expected behavior
If the menu is too long for the screen, it scrolls and it's possible to comfortably access the last item on it.
Actual behavior
If the menu is too long for the screen, the last items are not visible or accessible.
https://user-images.githubusercontent.com/38889364/103779198-2a0c1380-5012-11eb-859c-940f5a88576b.mp4

Closed by #16.

Closed by #16.


Can I upload and publish bot to external server except Microsoft Azure and still accessible from Microsoft bot directory

Yes. You can publish bot anywhere with only requirement that it should be accessible over internet over HTTPS.

ankitbko is correct, you can publish anywhere, as long as you have a public https endpoint.


ROS extension

Generators for Niryo one
https://github.com/NiryoRobotics/niryo_one_ros/tree/e8a218cbafd03111298c7752f9b272e3b0b623bd/niryo_one_user_interface/blockly_code_generator
cc @wolfv

We have a new extension for Niryo here: https://github.com/QuantStack/jupyterlab-niryo-one


A way to extract component properties in Typescript

Hey 👋  Thanks for this awesome project!
At Storybook we provide types for frameworks that we support, and we have a type Story which looks a bit like this:
type Story<Args> {
  args: Args
 // other properties
}

supposedly a button type that has two properties { label: string; primary: boolean }, one could use the type like this:
const template: Story<{ label: string; primary: boolean }>;
template.args = {
  // will autocomplete and validate label and primary properties
}

When using Storybook with lit, I was hoping that it would be possible to automatically extract properties from a LitElement instance, the ones defined via @property decorator, so that this would be possible:
class MyButton extends LitElement {
  @property({ type: String }) label: string
  // ...
}

const template: Story<MyButton>;
template.args = {
  // will autocomplete and validate label and primary properties
}

Is there any available mechanism for this already? Or plans to implement as such?
Thank you!

In the context of Storybook, it would be great if a "lit" version (if such a thing were needed) were to follow in the footsteps of the "web components" version and support this sort of data via a Custom Elements Manifest, this being the next version of the custom-elements.json file that the "web components" version of Storybook already supports. This would allow developers leveraging this version (or the next version of a "web components" general version of Storybook) to be able to surface attributes, properties, events, css custom properties, etc. no matter what technology (be it lit or something else) with which they developed the custom elements found in their project. This would further allow then to focus making the right technical decisions to ensure those custom elements best support the use cases they mean to solve for without feeling the need to split up their project or short change specific parts of their project in support of the Storybook build they leveraged in ways that were not beneficial to their teams and their consumers.

Tools really shouldn't consider @property to be that special. Relevant properties on an element could be plain class fields, getters and setters, or provided with the static properties block.
I think the element type itself is the best type to use, since reflecting properties like id, tabIndex, className could be observed and used by an element, but if including all of HTMLElement is to much for your tastes, you can omit those properties, like:
class MyElement extends HTMLElement {
  foo?: number;
}

type MyElementOnly = Omit<MyElement, keyof HTMLElement>;
const template: Story<MyElementOnly>;

Hi @yannbf, closing this issue. please re-open if you are still facing this.


header above menu , pull to request

I want to add pull to request in header view

is there any workaround in this issue?

This definitely possible, but not really specific to Parchment. Check out the example projects on how add things like headers


PHOENIX-3757 System mutex table not being created in SYSTEM namespace…

… when namespace mapping is enabled
On fresh cluster with system table namespace mapping enabled, SYSMUTEX will be created in SYSTEM namespace directly.
It will be migrated to SYSTEM namespace if that property is enabled
The migrations also require locking in SYSMUTEX table since it disables and enables SYSCAT.
SYSCAT upgrades will acquire lock in appropriate SYSMUTEX table based on the client properties.

@twdsilva Please review.
@aertoria

@ankitsinghal @samarthjain @joshelser
in case you guys want to take a look as well

Looks alright to me, but I don't have a lot of context to the intricacy of the change.

It would be great if you can apply this patch locally and try out a sqlline based end to end testing.

Thanks for your hard work here, Karan!

Thank you and Thanks for your inputs!

These commits also resolve PHOENIX-4227.

+1 LGTM
Thanks for the excellent work.


move to system

Should I use Lucky Patcher to move package to /system/app
android 4.4.4

readme

Copy NetworkLocation.apk to /system/priv-app (from your PC, call adb push NetworkLocation.apk /system/priv-app/NetworkLocation.apk)

my package is /data/app/org.microg.nlp-2.apk
does the readme refer to something other than UnifiedNLP?

The readme refer to moving it manually with a file manager or with adb (that make it a system app directly without the need to install it before).
The filename doesn't really matter, just the position.

need i first Uninstall it?

Moving it with an app (in this case Lucky Patcher) should be the same.
Doesn't it work?

@climf: Moving it with an app (in this case Lucky Patcher) should be the same.
Doesn't it work?
PS: Please close the issue if it works.


How to handle building LFE on different versions of Erlang

As most have noticed it is getting rather messy to build LFE on different versions of Erlang. While it has worked with testing at compile time which version of Erlang we are using and then defining macros to indicate when something in the system has changed, for example NEW_RAND, now some of the alternate handling is getting pretty difficult. The stacktrace handling will not be trivial.
One idea I have is for me to make separate releases for the different versions which are then pre-packaged and ready for downloading and building. This should not be difficult to do EXCEPT for updating old versions. So if I do this it might mean that once a release has been made for an older version of Erlang maybe once an "old" release has been built then it will no longer be upgraded.
What do people think of this? Is anyone running LFE on older versions of Erlang?

I would vote for the option that is the least burden on you :-) Technically, I have absolutely no objections to you proposal!

It would be nice to have an LFE version for the latest Erlang. Older LFE releases could be frozen.

@ prokopiy most BEAM projects provide a little more backwards compatibility than that. rebar3, for instance, runs their tests in CI/CD against 19, 20, 21, 22, and 23.
The new/updated LFE rebar3 plugin is not supporting anything older than 19 for the simple matter that the rebar project isn't ... but that's a nice spread of versions, so I feel okay about it :-)
But I do think we should do something similar to what you suggest:

support some minimal set of Erlang versions
make sure we have CI/CD set up to use a test matrix against all of these
freeze the LFE -> Erlang version for older releases
provide all LFE versions in a table showing the corresponding Erlang versions supported for each

We're doing this with our CI/CD build setup using Github Actions:

https://github.com/rvirding/lfe/actions


add region to sts client config

add region to sts client config
:heavy_check_mark: Checklist

[ ] Added tests for new functionality and regression tests for bug fixes
[x] Added changeset (run yarn changeset in the root)
[ ] Screenshots of before and after attached (for UI changes)
[ ] Added or updated documentation (if applicable)

https://app.shortcut.com/larder/story/21014/koho-aws-resources-missing-in-catalog

https://app.shortcut.com/larder/story/20724/koho-issues-loading-resources


Issue with address being stored

I used the address: "Tromsøgata 19, Oslo", but in the dashboard's Order data, I got the below:

Not sure if widget related or API

This is what the order widget is sending:

Maybe the building is not properly handled?

Can it be a dashboard issue?

Its an issue on the dashboard. We do not take building into consideration. Closing here.


Dependency problem

I'm using centos 6 and i install openNebula but it show a package error
Error: Package: opennebula-ruby-4.6.2-1.x86_64 (opennebula)
Requires: rubygem-uuidtools
please somebody help me in this

It solved


Refactor tooltip component

The current implementation of the tooltip component is pretty bad at is causing alot of issues ( see: #119 #78 and more accessibility issues  ).
We should use an existent solution like the  reach-ui tooltip component.
https://github.com/reach/reach-ui
https://github.com/reakit/reakit

Fixed by https://github.com/btzr-io/Villain/commit/ef517acf9f8c219676e81439b3110ec7e6f5379f


compact is too complex

Given an iterable x, you can remove all falsey values with just filter(None, x).
It's literally in the docs.

Oops, duplicate of issue 4; apologies.