Uncaught ObjectDisposedError: Object has been disposed

[Enter steps to reproduce below:]

opened project with cs files
Updated to new version of omni-sharp
disabled omni-sharp

Atom Version: 1.0.10
System: Microsoft Windows 8.1 Enterprise
Thrown From: omnisharp-atom package, v0.24.4
Stack Trace
Uncaught ObjectDisposedError: Object has been disposed
At C:\Users\jobe\.atom\packages\omnisharp-atom\node_modules\omnisharp-client\node_modules\rx\dist\rx.js:71

undefined

Commands
     -4:08.5.0 pane:decrease-size (div.release-notes.padded.pane-item.native-key-bindings)
     -3:47.7.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Config
{
  "core": {
    "disabledPackages": [
      "omnisharp-atom"
    ]
  }
}

Installed Packages
# User
.bin, vundefined
atom-typescript, vundefined
atom-yeoman, v0.3.13
javascript-snippets, v1.0.0
json-schema, v0.1.13
language-javascript-jsx, v0.3.7
linter, v1.5.0
minimap, v4.13.2

# Dev
No dev packages

Following these steps today, seems to be working, let us know if you're still having an issue!

Just got the same issue when playing around with the jabbr v2/dev source which I had cloned to my local (on OS X). Ran the build script as per instructions and opened atom from the terminal (atom .).
[Enter steps to reproduce below:]

Open HomeController.cs
Click on and navigate to SettingsViewModel from HomeController (CMD+Click)
Click around SettingsViewModel a bit.
Close SettingsViewModel (CMD+W)
Error appears.

Also, I have enhanced highlighting and code lens turned on. Have been able to consistently reproduce this issue by following the above steps.
Atom Version: 1.0.19
System: Mac OS X 10.10.5
Thrown From: omnisharp-atom package, v0.25.0
Stack Trace
Uncaught ObjectDisposedError: Object has been disposed
At /Users/willl/.atom/packages/omnisharp-atom/node_modules/rx/dist/rx.js:77

undefined

Commands
     -2:22.1.0 omnisharp-atom:restart-server (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -2:18.1.0 core:close (atom-text-editor.editor.is-focused)
     -2:03.1.0 omnisharp-atom:toggle-dock (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
  2x -1:33.2.0 omnisharp-atom:solution-status (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -1:30.1.0 omnisharp-atom:toggle-dock (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
  2x -1:03.5.0 core:close (atom-text-editor.editor.omnisharp-editor.is-focused)
     -0:39.5.0 omnisharp-atom:toggle-dock (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "monokai"
    ]
  },
  "omnisharp-atom": {
    "enhancedHighlighting": true
  }
}

Installed Packages
# User
.bin, vundefined
atom-typescript, v7.4.1
atom-yeoman, v0.3.15
browser-plus, v0.0.35
editorconfig, v1.2.0
json-schema, v0.1.15
language-cshtml, v0.1.1
linter, v1.8.1
monokai, v0.18.0
omnisharp-atom, v0.25.0

# Dev
No dev packages

I also have this error appear intermittently. Unclear to me what's causing the problem, but it seems to appear every few minutes, and often happens shortly after switching tabs to another open file.
Config
"*":
  editor:
    invisibles: {}
    softWrapAtPreferredLineLength: true
  core:
    themes: [
      "seti-ui"
      "monokai-slate"
    ]
    projectHome: "~/Active/"
    disabledPackages: [
      ".bin"
      "auto-indent"
      "pigments"
    ]
  "exception-reporting":
    userId: "8871a555-6e0f-91ee-e68b-39df173f46fe"
  welcome:
    showOnStartup: false
  "vim-mode": {}
  "tree-view":
    hideIgnoredNames: true
  "omnisharp-atom":
    enhancedHighlighting: true
  linter:
    showErrorPanel: false
  "atom-typescript": {}

Installed Packages
/Users/Joel/.atom/packages (10)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Haven't been able to reproduce as of yet. Will update later if I find anything
Atom Version: 1.1.0
System: Ubuntu 15.10
Thrown From: omnisharp-atom package, v0.25.10
Stack Trace
Uncaught ObjectDisposedError: Object has been disposed
At /home/jalict/.atom/packages/omnisharp-atom/node_modules/rx/dist/rx.js:77

undefined

Commands
     -7:58.9.0 core:move-down (atom-text-editor.editor.omnisharp-editor.is-focused)
  2x -7:58.8.0 core:move-left (atom-text-editor.editor.omnisharp-editor.is-focused)
     -7:57.2.0 core:save (atom-text-editor.editor.omnisharp-editor.is-focused)
     -7:39.8.0 core:delete (atom-text-editor.editor.omnisharp-editor.is-focused)
     -7:39.6.0 core:save (atom-text-editor.editor.omnisharp-editor.is-focused)
  2x -1:09.5.0 editor:newline (atom-text-editor.editor.omnisharp-editor.is-focused)
  2x -1:05.6.0 core:backspace (atom-text-editor.editor.omnisharp-editor.is-focused)
     -0:59.5.0 autocomplete-plus:confirm (atom-text-editor.editor.omnisharp-editor.is-focused.autocomplete-active)
  3x -0:56.4.0 core:backspace (atom-text-editor.editor.omnisharp-editor.is-focused)
     -0:53.5.0 core:save (atom-text-editor.editor.omnisharp-editor.is-focused)
  2x -0:47.4.0 omnisharp-atom:solution-status (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:45.3.0 omnisharp-atom:toggle-dock (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:43.9.0 omnisharp-atom:settings (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:39.2.0 omnisharp-atom:toggle-dock (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:04.2.0 core:cancel (div.package-detail.panels-item)
     -0:03.0 core:close (div.package-detail.panels-item)

Config
{
  "omnisharp-atom": {
    "enhancedHighlighting": true,
    "autoAddExternalProjects": true
  }
}

Installed Packages
# User
atom-yeoman, v0.3.15
json-schema, v0.1.15
linter, v1.10.0
omnisharp-atom, v0.25.10
unity-shader-files, v0.1.0

# Dev
No dev packages

I'm getting it when I switch branches (git checkout <branch>) when I have an open tab where the file is different in both branches.

still suffering, and no code completion
just install atom, install omnisharp, new project, open HomeController.cs type code, 50% got this error

Just got this one from simply opening a .cs file.

Seems to be common when I do something like this, although Omnisharp does automatically restart successfully:

Open Atom, edit several files
Switch over to Unity and change some data
Wait a while
Switch back to Atom

Atom Version: 1.2.4
System: Mac OS X 10.11.1
Thrown From: omnisharp-atom package, v0.26.4
Stack Trace
Uncaught ObjectDisposedError: Object has been disposed
At /Users/tommunro/.atom/packages/omnisharp-atom/node_modules/rx/dist/rx.js:77

undefined

Commands
     -0:17.1.0 omnisharp-atom:restart-server (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-solarized-light-syntax.theme-one-light-ui)
     -0:05.0 blur (atom-text-editor.editor.vim-mode-plus.normal-mode.is-focused)

Config
{
  "core": {
    "themes": [
      "one-light-ui",
      "solarized-light-syntax"
    ],
    "ignoredNames": [
      ".git",
      ".hg",
      ".svn",
      ".DS_STORE",
      "._*",
      "Thumbs.db",
      ".png",
      ".prefab",
      ".scene",
      ".meta",
      "spine-runtimes/spine-!(csharp)*"
    ],
    "packagesWithKeymapsDisabled": [
      "advanced-new-file",
      "recent-files-fuzzy-finder",
      "omnisharp-atom"
    ],
    "disabledPackages": [
      "vim-mode"
    ]
  },
  "omnisharp-atom": {
    "nagAddExternalProjects": false,
    "nagAdjustTreeView": false,
    "codeLens": false
  }
}

Installed Packages
# User
.bin, vundefined
atom-yeoman, v0.3.15
clipboard-plus, v0.5.1
cursor-history, v0.5.9
custom-search, v0.0.1
fuzzy-finder, v0.93.0
json-schema, v0.1.15
language-csharp, v0.11.0
linter, v1.11.3
linter-coffeelint, v1.1.2
omnisharp-atom, v0.26.4
recent-files-fuzzy-finder, v0.2.4
remember-file-positions, v0.2.0
save-session, vundefined
symbols-tree-view, v0.10.1
theme-switcher, v1.1.0
vim-mode-plus, v0.7.1
zentabs, v0.8.6

# Dev
omnisharp-atom, v0.22.5
settings-view, v0.223.0

I can reliably create this exception if I toggle Omnisharp when a solution is loaded.

[Enter steps to reproduce below:]

...
...

Atom Version: 1.3.2
System: Ubuntu 15.10
Thrown From: omnisharp-atom package, v0.26.7
Stack Trace
Uncaught ObjectDisposedError: Object has been disposed
At /home/karl/.atom/packages/omnisharp-atom/node_modules/rx/dist/rx.js:77

undefined

Commands
     -1:45 core:move-up (atom-text-editor.editor.omnisharp-editor.is-focused)
  2x -1:44.6.0 core:move-right (atom-text-editor.editor.omnisharp-editor.is-focused)
     -1:43.7.0 core:move-down (atom-text-editor.editor.omnisharp-editor.is-focused)
     -1:42.2.0 core:save (atom-text-editor.editor.omnisharp-editor.is-focused)
     -1:42.1.0 omnisharp-atom:restart-server (atom-workspace.workspace.scrollbars-visible-always.theme-solarized-dark-syntax.theme-one-dark-ui)
     -0:20.9.0 fuzzy-finder:toggle-file-finder (ul.list-inline.tab-bar.inset-panel)
     -0:18.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "solarized-dark-syntax"
    ],
    "ignoredNames": [
      ".git",
      ".hg",
      ".svn",
      ".DS_Store",
      "._*",
      "Thumbs.db",
      ".pkg",
      "*.pyc"
    ]
  }
}

Installed Packages
# User
atom-yeoman, v0.3.15
go-plus, v3.5.2
json-schema, v0.1.15
language-docker, v1.1.6
language-salt, v0.4.0
linter, v1.11.3
minimap, v4.19.0
nuclide-hg-repository, v0.0.35
omnisharp-atom, v0.26.7
pretty-json, v0.4.1

# Dev
No dev packages

i'm not quite sure how to reproduce, but i'll mention some of the states before this happened:

Had a project folder already added to atom. It's a non-cs-related folder (jekyll blog) and is a git repo.
i added a project folder to atom containing a solution utilizing vb and cs. it's also a git folder.
Experience this issue?

Atom Version: 1.5.0
System: Microsoft Windows 10 Pro
Thrown From: omnisharp-atom package, v0.26.9
Stack Trace
Uncaught ObjectDisposedError: Object has been disposed
At C:\Users\james\.atom\packages\omnisharp-atom\node_modules\rx\dist\rx.js:77

undefined

Commands
     -0:39.8.0 tree-view:toggle (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
  4x -0:39.7.0 blur (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -0:38.2.0 core:close (div.markdown-preview.native-key-bindings)
  7x -0:38.2.0 blur (div.markdown-preview.native-key-bindings)
     -0:31.2.0 command-palette:toggle (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:30.8.0 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:29.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:29.1.0 blur (atom-text-editor.editor.mini.is-focused)
     -0:29.1.0 application:add-project-folder (atom-text-editor.editor.vim-mode.normal-mode)
  2x -0:29 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:19.7.0 omnisharp-atom:restart-server (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
  2x -0:06.4.0 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:03.7.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:03.7.0 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "linter-js-standard",
      "standard-formatter",
      "standardjs-snippets"
    ]
  }
}

Installed Packages
# User
atom-yeoman, v0.3.15
editorconfig, v1.2.4
go-plus, v3.5.2
jekyll, v1.1.3
json-schema, v0.1.15
language-arduino, v0.4.1
language-cshtml, v0.1.1
language-powershell, v2.1.0
language-vbdotnet, v0.1.0
linter, v1.11.3
omnisharp-atom, v0.26.9
regex-railroad-diagram, v0.11.0
vim-mode, v0.64.0

# Dev
No dev packages

Repros for me editing a cake file in an aspnet5 rc1 solution
-- using vim-mode-plus

open up a cake file
enter insert mode
observe error

Atom Version: 1.5.3
System: Mac OS X 10.11
Thrown From: omnisharp-atom package, v0.26.13
Stack Trace
Uncaught ObjectDisposedError: Object has been disposed
At /Users/acunningham/.atom/packages/omnisharp-atom/node_modules/rx/dist/rx.js:710

undefined

Commands
     -2:07.5.0 omnisharp-atom:restart-server (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-base16-papercolor-dark-syntax.theme-one-dark-ui)
     -1:15.7.0 vim-mode-plus:move-up (atom-text-editor.editor.vim-mode-plus.normal-mode.is-focused)
     -1:14.8.0 vim-mode-plus:insert-after-end-of-line (atom-text-editor.editor.vim-mode-plus.normal-mode.is-focused)
  2x -1:14.7.0 editor:newline (atom-text-editor.editor.vim-mode-plus.is-focused.insert-mode)
     -1:13 autocomplete-plus:confirm (atom-text-editor.editor.vim-mode-plus.is-focused.insert-mode.omnisharp-editor.autocomplete-active)
  9x -1:01.5.0 blur (atom-text-editor.editor.vim-mode-plus.is-focused.insert-mode.omnisharp-editor)

Config
{
  "core": {
    "disabledPackages": [
      "vim-mode",
      "vim-surround",
      "json-schema",
      "language-aspx",
      "language-cshtml"
    ],
    "packagesWithKeymapsDisabled": [
      "language-csharp"
    ],
    "themes": [
      "one-dark-ui",
      "base16-papercolor-dark-syntax"
    ]
  },
  "omnisharp-atom": {
    "ExcludeClassifications": false,
    "altGotoDefinition": true,
    "autoAdjustTreeView": true,
    "developerMode": true,
    "enhancedHighlighting": true,
    "showDiagnosticsForAllSolutions": true
  }
}

Installed Packages
# User
atom-yeoman, v0.3.15
base16-papercolor-dark-syntax, v0.2.0
character-table, v0.4.3
file-icons, v1.6.15
language-cs, v0.1.1
language-docker, v1.1.6
linter, v1.11.3
linter-docker, v0.1.2
omnisharp-atom, v0.26.13
relative-numbers, v0.5.0
vim-mode-plus, v0.21.3

# Dev
language-csharp, v0.11.0


Add --molecule-idempotence-notest tag to skip-tags during idempotence…

Hello,
please consider including this small patch which adds a new feature.
During the idempotence action ansible-playbook is called with a third skip-tag:
molecule-idempotence-notest
The tag is only used during the idempotence action and
allows to ignore tasks during this run like notest and molecule-notest do for all actions.
This provides another means to control the behaviour during task execution during
the idempotence action run. So that one is not forced to set changed_when: false and
similiar to make the idempotence action run cleanly.
PR Type

Feature Pull Request

Re-running the CI on this one! Thanks for patience on this one, we're waiting on one final packaging issue before we can start to merge these long standing PRs.

Ah, wait a second, it seems be a related failure: https://travis-ci.com/ansible/molecule/jobs/182727979#L1059. You're using a _inventory_file fixture that isn't accessible to pytest? Can you fix up @lwilke? Thanks!

pls check if ok now. Thanks

<3

I just wanted to chime in to +1 the need for the feature and say thank you! We're striving for idempotence and agree it should be the goal but have a certain task that we intentionally want to execute on each run of a certain role.


SSH keys in Alpine

In order to make the SSH demon work in Alpine you need to previously generate ssh keys, otherwise sshd raises an error stating keys are not found. This is an example code of the start-up script of the container in order to make SSH work:
starting sshd process
sed -i "s/SSH_PORT/$SSH_PORT/g" /etc/ssh/sshd_config
ssh-keygen -A -q
/usr/sbin/sshd

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6489b871-9cf8-7c99-9834-076ec646d0e6
Version Independent ID: fa5d2995-5833-c04b-2530-c100bcd1e76b
Content: Configure a custom Linux container - Azure App Service
Content Source: articles/app-service/containers/configure-custom-container.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@pjmartorell Thanks for the comment. We are actively investigating on the issue and will get back to you shortly with an update.

@pjmartorell, Thanks for sharing the start-up script that works for you. While I check on this, to understand the issue better, do you see the behavior with the specific sample mentioned in the document or any custom container? As noted, all built-in Linux containers have added the SSH instructions in their image repositories.

I tried it with a custom container and with the code snippet provided in the documentation. But without generating SSH keys the code snippet itself does not work, so keys must be generated before running the SSH demon in order to make it work. Thanks


Extend radio styles for checkmark behaviour

It's impossible to set line height for radio in selected picker item. Radio has property standardStyle as false by default. lineHeight has value as 25 in this case :(

<Icon
    style={{
    color: this.props.selectedColor
        ? this.props.selectedColor
        : variables.radioColor,
    lineHeight: 25,
    height: 20,
    fontSize: variables.radioBtnSize
    }}
    name="ios-checkmark"
/>

I want to set different styles for standard radio and radio in selected picker item.
So i divided variables to radioBtnLineHeight and radioCheckmarkBtnLineHeight, radioBtnSize and radioCheckmarkBtnSize and created radioCheckmarkBtnHeight variable support. If those variables not defined (for existing custom themes), they will be default values (as previous).

If you find my contribution useful, could you update the version as soon as possible?
Thank you very much for your excellent product 👍

@SupriyaKalghatgi Hi! Could you check my PR please?

@indapublic Heavy conflicting files
Can you exclude dist files and update this PR?

@SupriyaKalghatgi Unfortunetaly, I closed this PR. So I reopened as new #2496


fix(BForm*): Revert use of defineModel to prevent model warnings (fixed #1846)

Describe the PR
Using defineModel with a type defined outside of the .vue file is causing the sfc to infer the wrong type.  I was unable to get defineModel to work for the BFrom* classes, so this PR is reverting to useVModel.  See my comment here for more details.
Small replication
This repros in the playground examples for BFromRadio* and BFromCheckbox* as well as the smaller repro in #1846.
PR checklist

What kind of change does this PR introduce? (check at least one)

[X] Bugfix :bug: - fix(...)
[ ] Feature - feat(...)
[ ] ARIA accessibility - fix(...)
[ ] Documentation update - docs(...)
[ ] Other (please describe)

The PR fulfills these requirements:

[X] Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

@VividLemon This reverts the defineModel changes that were causing the sfc to infer the wrong type for the models of these components and throwing runtime warnings.
I'm not sure if there is a functional purpose for declaring the component types in ComponentProps.ts so I didn't revert those changes.  But since they are they are not used in the component definitions, I'd lean towards deleting them if they're not used for anything else.

@dwgray This is a bug in vue, it's fixed on the newest version. I'll release a new version tonight, after I get some stuff in.

@dwgray This is a bug in vue, it's fixed on the newest version. I'll release a new version tonight, after I get some stuff in.

@xvaara Thanks - it looks like they've fixed some bugs in the SFC, including at least one that involves defineModel co-ercing strings to bools (which is what @VividLemon noted).  It still looks like the SFC is not pulling in external type definitions  vue docs, so I'm not 100% those bug fixes will cover the issue we're seeing with radio button/checkbox models.

In dev mode, the compiler will try to infer corresponding runtime validation from the types. For example here foo: String is inferred from the foo: string type. If the type is a reference to an imported type, the inferred result will be foo: null (equal to any type) since the compiler does not have information of external files.

It's easy enough to validate, though - if it's not fixed, you'll see a lot of model warnings in the console window for the radio button and checkbox playground examples.  I'm at OSS this week but I will try to get a few cycles to play with this in the evening.  Hopefully it will just work :-)


Convert test30 into a new style test

Codecov Report

Merging #4440 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4440      +/-   ##
==========================================
+ Coverage   80.48%   80.48%   +<.01%
==========================================
  Files         110      110
  Lines      142992   143027      +35
==========================================
+ Hits       115082   115122      +40
+ Misses      27910    27905       -5

Impacted Files
Coverage Δ

src/gui_beval.c
62.06% <0%> (-0.87%)
:arrow_down:

src/charset.c
88.36% <0%> (-0.14%)
:arrow_down:

src/window.c
87.08% <0%> (-0.07%)
:arrow_down:

src/screen.c
81.75% <0%> (-0.02%)
:arrow_down:

src/version.c
88.93% <0%> (ø)
:arrow_up:

src/textprop.c
85.86% <0%> (+0.05%)
:arrow_up:

src/term.c
73.89% <0%> (+0.05%)
:arrow_up:

src/sign.c
93.5% <0%> (+0.12%)
:arrow_up:

src/gui_gtk_x11.c
49.01% <0%> (+0.14%)
:arrow_up:

src/if_xcmdsrv.c
84.56% <0%> (+0.35%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd0dce...b6e1066. Read the comment docs.


How is Today change?

I want show listing style today but other day like today.
I changed this veriable but didn't work
cursorTimeValue  = ?

I can list today. If a user selects a past date. I should show that day as the same day.

I'm sorry.
At the beginning of my design, I did not consider the situation or requirement of multiple consecutive days together. If you still need this library, I suggest using the viewpager to display it separately every day, or imitating this library to achieve your ideas.

thank you


Move iree/iree.natvis to runtime/.

I also considered runtime/src/iree/, but there are other files in the top level runtime/ folder like pyproject.toml. If Python gets special treatment, so can C/C++? :D

iree_copts.cmake needs to be updated (it's what attaches the file to the binary)

iree_copts.cmake needs to be updated (it's what attaches the file to the binary)

Ah. Nice catch, thanks.


How to reconnect socket with cookie after page refresh ?

Hi,
How to automatically connect the socket using the accessToken in the cookie after refreshing the page? I use version 1 of feathers-authentication.
It would be practical to be able to:
app.io.use(authentication.socket.authenticate());

Right now you have to call feathersClient.authenticate() to make this happen.  Sockets are flagged as authenticated from the server side once they pass validation.

It's perfectly fine

Finally I created this socket.io middleware: https://gist.github.com/bertho-zero/5cdeabb77be98bc159b1e5d75c6af429
It is used like this:
app.io.use(socketAuth(app));

If I remove this line (gist#L17) I have an error from here: https://github.com/feathersjs/feathers-authentication/blob/master/src/socket/handler.js#L38


fix(stmt): evict & unbound schema stmt query

fix evict & unbound schema stmt query to avoid blank detail page
add evict stmt tips

Another issue that can cause blank detail page is #982. PTAL, thanks~

/cc @baurine @breeswish
PTAL, Thanks~

Updated, PTAL~ @breeswish


PublicSuffixDatabase Cause ANR

PublicSuffixDatabase.get().getEffectiveTldPlusOne
in this method，if readTheListUninterruptibly faild that will throw a exception
when call this method next, it will cause anr, because it always await.
it should reset the listRead when throw IllegalStateException

Thanks for the report, It's a bug we should fix, not sure of the right change to make.
But a couple of questions

I'm surprised it is causing an ANR, since it's presumably doing that blocking call on the main thread.  Can you provide a stacktrace?

Can you explain why it's failing? This is hopefully lower priority since it signals a problem with your app. Or is there some reason it's happening in normal conditions?

1、stacktrace is not convenient to provide。But you can easily reproduce this Anr。
In first read，you can make "PublicSuffixDatabase.class.getResourceAsStream(PUBLIC_SUFFIX_RESOURCE)" to return null，then the second call the "getEffectiveTldPlusOne" will cause Anr。
2、About the reason for the failure，google make a experiment about dynamic-feature，it may cause the read failure，we have many cases。
By the way, regardless of the reason for the read failure，it should reset the 'listRead' when throw IllegalStateException？

Thanks for the report, It's a bug we should fix, not sure of the right change to make.
But a couple of questions

I'm surprised it is causing an ANR, since it's presumably doing that blocking call on the main thread.  Can you provide a stacktrace?
Can you explain why it's failing? This is hopefully lower priority since it signals a problem with your app. Or is there some reason it's happening in normal conditions?

1、stacktrace is not convenient to provide。But you can easily reproduce this Anr。
In first read，you can make "PublicSuffixDatabase.class.getResourceAsStream(PUBLIC_SUFFIX_RESOURCE)" to return null，then the second call the "getEffectiveTldPlusOne" will cause Anr。
2、About the reason for the failure，google make a experiment about dynamic-feature，it may cause the read failure，we have many cases。
By the way, regardless of the reason for the read failure，it should reset the 'listRead' when throw IllegalStateException？

Thanks for the report, It's a bug we should fix, not sure of the right change to make.
But a couple of questions

I'm surprised it is causing an ANR, since it's presumably doing that blocking call on the main thread.  Can you provide a stacktrace?
Can you explain why it's failing? This is hopefully lower priority since it signals a problem with your app. Or is there some reason it's happening in normal conditions?

add a message，we use the old version(java), in the readList method，
    InputStream resource = PublicSuffixDatabase.class.getResourceAsStream(PUBLIC_SUFFIX_RESOURCE);     if (resource == null) return;
it return when the resource is null, but the readCompleteLatch is not countdown，so the second call will block。
But I see the kotlin version seems that there is no such problem。
In your commit，if read fail，it seems not to read the resource anymore?

@sim0124 Yep - I'm assuming a read is permanently failed.  So I countdown the latch, so it is considered complete.  But it already throws when it can't read.
There is no point doing the I/O repeatedly if it's failing.  failing cheap, instead of expensive.

@sim0124 Yep - I'm assuming a read is permanently failed. So I countdown the latch, so it is considered complete. But it already throws when it can't read.
There is no point doing the I/O repeatedly if it's failing. failing cheap, instead of expensive.

But in that google dynamic-feature experiment, we found that it read fail at some time..,not permanently failed...
That's why I mention retry，lol

That doesn't sound healthy? Are OkHttp classes ending up in a different binary than the public suffix data file?

About the reason for the failure，google make a experiment about dynamic-feature，it may cause the read failure，we have many cases。

It wasn't clear from this.  I'm not sure we want to support this file not being present initially and then appearing.

It wasn't clear from this. I'm not sure we want to support this file not being present initially and then appearing.

We have other solutions, here are just to give you the possible situation～  Looking at this problem from a different angle, retrying or not retrying is ok～

Agreed with @yschimke: if the file is absent we expect it to stay absent. Perhaps we could test to confirm that if it fails once, it fails on all subsequent attempts. (I believe we already have this behaviour.)

We currently hang. The behaviour you want comes in #7827

ok～ thank you so much

@sim0124 That reply was to Jesse, it will fail permanently after the first failure. I'm not sure you are happy with that behaviour.


Create GitHub pages with docs

We need to ensure users can get started with the package as quickly as possible. To make this easy, I'll create a deployment script for a test backend and a number of sample apps.

Created docs on Readme.IO instead.


Startup BP usage function

Created a startup function that will expend BP.  The breakdown is as follows:
Warphole to Like New as described in the ratio parameters (Callsite is using 19 : 1 ratio)
200 + BP %100 is spared for Raining Gold, Treasure, and Pumped up in order.

After much discussion, and also being the reason these WH started, and witnessing tons of them, it seems like we want something closer to 10:1 for WH:LN, then about 40 crit, 10 RG, 1 Treasure, and at most 1 pumped up.  10:1 means we dont worry about the occasionally misused LN, since LN's seem to disappear faster than WH's.

Updated the rulesets to be as stated.  Now to just fix these whitespace issues...


Wrong api level in the url for module direct methods

"https://.azure-devices.net/twins//modules//methods?api-version=2018-06"
using excatly "api-version=2018-06" the https call will not work. The api-version must be "2018-06-30".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58ad27ec-834c-d85d-79f9-ee699019be33
Version Independent ID: b108b7b1-d28d-abed-467d-39a661c8e086
Content: Understand Azure IoT Hub direct methods
Content Source: articles/iot-hub/iot-hub-devguide-direct-methods.md
Service: iot-hub
GitHub Login: @nberdy
Microsoft Alias: rezas

@tmoeltner
Thanks for the feedback! We are currently investigating and will update you shortly.

@tmoeltner Thanks for the feedback! We will update the document.


Use apt 40 char length key

Since apt module displays a warning if not

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Hi,
Due to PE 3.7.x support I'm unable to do this yet since it ships with an older version of pl-apt.


Create macOS configuration variables for triplets

This PR makes a few related changes. Firstly, I set CMAKE_MACOSX_RPATH to ON in the OSX toolchain file. This changes the default behavior for the install name on all dynamic library targets on macOS. Specifically, it sets it so the dylib id's start with @rpath/. This change closes #4376.
In addition, I added a new variable that can be used in the triplets, VCPKG_INSTALL_NAME_DIR. This correlates to the CMake variable CMAKE_INSTALL_NAME_DIR, and sets the default install name for all targets. Using this, users can control the path in the resulting dylib id's if the default of using @rpath won't work for their specific use case.
Lastly, I went ahead and created the variables VCPKG_OSX_DEPLOYMENT_TARGET and VCPKG_OSX_SYSROOT, which correlate to the CMake variables CMAKE_OSX_DEPLOYMENT_TARGET and CMAKE_OSX_SYSROOT respectively. VCPKG_OSX_DEPLOYMENT_TARGET does two things. Firstly, it sets the minimum macOS target version, so libraries built on a newer version of macOS can run on older versions. (This is functionally equivalent to adding -mmacosx-version-min= to the VCPKG_*_FLAGS variables). The second thing it does is change how different installed versions of the macOS SDK are considered. (While SDK's are mostly backwards-compatible, there are reasons to want to use an old SDK version). In addition, VCPKG_OSX_SYSROOT allows you to explicitly set the path to the macOS SDK if you want to specify it directly.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: LRFLEW sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR!
I'm not an OSX expert, so I can't completely evaluate the impact of using @rpath/ in dylibs. However, since it appears that modern CMake prefers it to be enabled, this lends at least some weight to it being "The Right Way" :).
Could you add documentation for these variables to docs/users/triplets.md?

I added the requested documentation to docs/users/triplets.md. Since these are the first platform-specific variables, I decided to create a new sub-heading for them. Let me know if you want any changes to the documentation.


Mark all user-visible strings as translatable in C++

Summary
Many strings that are specified in C++ source files have not been marked as translatable (e.g., by using the QObject::tr method). Slicer core, CTK library, and Slicer extensions source code needs to be improved so that all translatable strings are marked as such.
Evolution of modules marking tasks

[x]  Mark translatable strings in EventBroker module
[x]  Mark translatable strings in Data module
[x]  Mark translatable strings in DataProbe module
[x] Mark translatable strings in BaseQTGUI
[x] Mark translatable strings in BaseQTCore
[x] Mark translatable strings in BaseQTApp
[x] Mark translatable strings in BaseQTCli
[x] Mark translatable strings in Cameras module

remaining issues are now tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/65 and https://github.com/Slicer/SlicerLanguagePacks/issues/64

[x] Mark translatable strings in Colors module

https://github.com/Slicer/SlicerLanguagePacks/issues/59
https://github.com/Slicer/SlicerLanguagePacks/issues/69

[x] Mark translatable strings in CropVolume module

remaining issues are now tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/65 and https://github.com/Slicer/SlicerLanguagePacks/issues/64

[x] Mark translatable strings in Markups module - now tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/37
[x] Mark translatable strings in Models module - remaining issue is tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/69
[x] Mark translatable strings in Plots module - remaining issue is tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/69
[x] Mark translatable strings in Reformat module - remaining issues

https://github.com/Slicer/SlicerLanguagePacks/issues/66
https://github.com/Slicer/SlicerLanguagePacks/issues/69

[x] Mark translatable strings in SceneViews module => now tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/70
[x] Mark translatable strings in Segmentations module
[x] Mark translatable strings in SlicerWelcome module
[x] Mark translatable strings in SubjectHierarchy module - now tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/71
[x] Mark translatable strings in Terminologies module

https://github.com/Slicer/SlicerLanguagePacks/issues/69
https://github.com/Slicer/SlicerLanguagePacks/issues/67

[x] Mark translatable strings in Texts module - remaining issue is tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/69
[x] Mark translatable strings in Transforms module

https://github.com/Slicer/SlicerLanguagePacks/issues/69
https://github.com/Slicer/SlicerLanguagePacks/issues/65

[x] Mark translatable strings in Units module - remaining issue is tracked in https://github.com/Slicer/SlicerLanguagePacks/issues/68
[x] Mark translatable strings in ViewControllers module

https://github.com/Slicer/SlicerLanguagePacks/issues/69
https://github.com/Slicer/SlicerLanguagePacks/issues/66

[x] Mark translatable strings in VolumeRendering module

remaining issue: https://github.com/Slicer/SlicerLanguagePacks/issues/65

[x] Mark translatable strings in Volumes module

Qt seems to recommend two approaches for making tr() function available in non-QObject-based classes:

Option A: Use Q_DECLARE_TR_FUNCTIONS(MyClass) macro (see https://doc-snapshots.qt.io/qt6-6.2/i18n-source-translation.html#translating-non-qt-classes)
Option B: Use QSomeWidget::tr() (see https://doc-snapshots.qt.io/qt6-6.2/i18n-source-translation.html#using-tr-for-all-literal-text)

Probably option A is more clear and consistent - we can use tr() everywhere and only need to add a single line to the non-QObject-based class declaration. Of course, it would need to be tested if it indeed works as we expect.

I was wondering which approach we should use when it's about dealing with numbered arguments present on translatable strings. For example, when we have the following string :
QString("An update is available. Installed: %1. Available : %2.")
        .arg(installedVersion)
        .arg(onServerVersion);

Which translation approach should we consider ?
Option A
tr("An update is available. Installed: %1. Available: %2.")
        .arg(installedVersion)
        .arg(onServerVersion);

Option B
tr("%1 %2 %3. %4 %5.")
        .arg(tr("An update is available."))
        .arg(tr("Installed:"))
        .arg(installedVersion)
        .arg(tr("Available:"))
        .arg(onServerVersion);

Option C
tr("%1 %2. %3 %4.")
        .arg(tr("An update is available. Installed:"))
        .arg(installedVersion)
        .arg(tr("Available:"))
        .arg(onServerVersion);

The first option may be simpler and may offer more flexibility at translation time. It also offers a better context to the translation since the whole sentence is visible. However, the presence of arguments in translatable strings may not be understood by "non-tech" translators and may be mishandled.
For this, I think that, as with the & character, we can specify in the ongoing translation guide what they represent and how to handle them.
Here is another example of such strings where the text in the HTML code has numbered arguments and needs to be translated.

All problems are fixed or tracked in specific issues.


I have added calculator in CSimplify. Please merge this pull request...

@rakshitmehra please share some screenshots of the changes you made.

Good work @rakshitmehra!


kak-lsp: Language server is not configured for filetype ``

Hey there,
I'm facing a weird issue. Whenever I open a file, I get an error saying kak-lsp: Language server is not configured for filetype
I checked what filetype was detected by kakoune via :echo %opt{filetype}  and weirdly enough it correctly reported that on whatever file I tried.
Trying to debug this I ran :lsp-capabilities  but this did not return anything, for whatever reason.
My config is located in .config/kak-lsp/kak-lsp.toml and I installed it via the aur (14.1.0-1) together with kakoune from the official arch mirrors (2022.10.31-1). Plug did not work with kak-lsp because of error 127 which I did not bother to look up or debug.
My kakoune config: kakrc (lines 43-46 were the only way I could get this to work, but it sadly has some drawbacks which is why I want to be able to use the kak-lsp config)
I already tried resetting the kak-lsp config which did not succeed.
Any ideas what I could do here?

Does it work with the default configuration?

I'm facing a weird issue. Whenever I open a file,

Which file? I can't reproduce without specific info

I installed it via the aur (14.1.0-1)

Weird, that should usually be kak-lsp 14.1.0-snapshot.
14.1.0 you can also get from the official repos.

Does it work with the default configuration?

no

Which file? I can't reproduce without specific info
any file. I tried java, I tried c++, and I even tried kakoune files. All were identified correctly.

14.1.0 you can also get from the official repos.

Just tried the github release build and that also didn't work

kak-lsp: Language server is not configured for filetype

oh so I just realized that the weird thing is that it doesn't say what filetype.
Can you please paste the log file that is created by the default config command (/tmp/kak-lsp.log)?

kak-lsp.log
I see. This even includes the file I tried.
What I Just noticed is, that it actually detected java, maybe it it showed <accent> whenever I switched to the debug buffer to inspect this issue? Still weird that it fails to read my java configuration.

the default configuration ignores your config by overriding $HOME. That's what we want here.
Unfortunately, the default config does not support java, please show the log when you open a C file.

the default configuration ignores your config by overriding $HOME. That's what we want here. Unfortunately, the default config does not support java, please show the log when you open a C file.

screenshot
![screenshot-20221225-180750](https://user-images.githubusercontent.com/62404294/209476493-30ebd5be-5c75-42a9-8a24-2af0bde4db78.png)

Appears to be working fine. hmm
kak-lsp.log

seems to be a config issue after all. Now with the kak-lsp log many things make more sense. I thought the debug buffer was all you'd get. Sorry. This is apparently my fault

btw you probably don't want to run in ultra-verbose mode (-vvvv) everyday because that can produce gigabytes of logs when used heavily. Though if you're not passing a log file parameter then it's not stored anywhere so probably fine

oh okay :)
Thanks!


Use bend xsize rather than radius for bend size

Currently, the spiral_external_io function uses the bend radius to determine its size. In the case of euler bends that don't use with_arc_floorplan=True, this is not representative of the bend's actual size. This change determines the size of the bend based on its xsize and cross_section width.

this was failing before
    from functools import partial
    import gdsfactory as gf
    spacing = 3
    bend = partial(gf.c.bend_euler, with_arc_floorplan=False)
    c = gf.c.spiral_external_io(
        bend=bend,
    )
    c.show(show_ports=True)

and now works thanks to your PR :smile:


add unit-test for apis/opts/portbindings.go areas/test

Ⅰ. Describe what this PR did
add the unit test for portbingdings ParsePortBinding() function and ValidatePortBinding() with input cases check.
Ⅱ. Does this pull request fix one issue?
Fix:#1954
Ⅲ. Describe how you did it
When I type <IP_ADDRESS>:8080, I want containerPort to be the same as hostPort.But first input is not used as rawIP.I think there are two ways to enter hostPort:containerPort and rawIP:hostPort.
Ⅳ. Describe how to verify it
add test param <IP_ADDRESS>:21.
run go test portbindings_test.go portbindings.go
Ⅴ. Special notes for reviews
It is better to return a corresponding protocol for a special port.such as 21/ftp 80/http 25/smtp

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Members From address

Can't use a custom domain for the member from address
Reference https://github.com/TryGhost/Ghost/blob/master/core/server/services/members/api.js
line 206 - 224
transporter: {
                sendMail(message) {
                    if (process.env.NODE_ENV !== 'production') {
                        common.logging.warn(message.text);
                    }
                    let msg = Object.assign({
                        subject: 'Signin',
                        forceTextContent: true
                    }, message);
                    const subscriptionSettings = settingsCache.get('members_subscription_settings');

                    if (subscriptionSettings && subscriptionSettings.fromAddress) {
                        let from = `${subscriptionSettings.fromAddress}@${getDomain()}`;
                        msg = Object.assign({from: from}, msg);
                    }

                    return ghostMailer.send(msg);
                }
            },

The from address is set via the database and automatically append the domain. Whereas we have a mail setting in the config which would be better or at least we should remove the  get domain part
I'm happy to fix this but not sure which is best approach

Hi @Jordan-Hall :wave: Could you explain your usecase for using a different domain for the from address? Not really following what you mean by:

we have a mail setting in the config which would be better or at least we should remove the get domain part

Do you want to reuse the same mail setting as for general Ghost mailer or do you just want to have a possibility to provide custom from address for member emails?
We use GitHub for issue/bug tracking mostly. So, I'm gonna close this issue here but happy to continue the discussion on the forum and then possibly reopening it here ;)

@gargol the issue is members always getting getDomain() of the website and the mail-in config doesn't overwrite the from address.
So we have kks.news whereas for emails we use kks.email

Roger :+1:  Think it makes sense to allow setting a custom domain from config or similar mechanism. This is a first time I'm seeing this usecase that's why wanted to go with our standard way of discussing new "features" :)

I just stumbled on this after creating a ticket in the members package: https://github.com/TryGhost/Members/issues/109 I can close it, but I believe this is a Bug and not a feature request. Coupling the email domain to the hosting domain is just wrong.

@the-architect  that was my view but apparently its a feature :/

@the-architect Agree, it's coupling two unrelated concepts - it should be separate.

I'm looking at the code and unlike the rest of the system, it uses settings rather than config. 🤷♂ No offence Ghost architecture seems to be odd :/ You can change the fromAddress in the admin section. Thinking now the best protocol would be to append a new config setting called domain.
This would have breaking change but we could add a deprecated warning to split the from address up. This seems to be the best approach.

@Jordan-Hall Where did you find that in the admin section? Can you do a screenshot?

You can only change the from not the domain. I'll send over a screenshot after. I'll have a solution within the next 48 hours

@piotrkundu  it wont change domain though but here. I think the domain should come from config

Ah, ok. You need to have members enabled first to get it. Yeah I've seen that before. Turn off members and try your config like this:
  "mail": {
    "from"<EMAIL_ADDRESS>    "transport": "DIRECT",
    "options": {}
  },

That worked from me, after wasting 8-10 billable hours :(

@piotrkundu Tried that the from not used for members. it means your limited to the domain of the blog

This feature needs more thought on a proper approach to allow domain modification for non-self-hosted versions of Ghost. It will be reviewed once the issue gets a priority.
For now, the fork from https://github.com/TryGhost/Ghost/pull/11474 and https://github.com/TryGhost/Ghost-Admin/pull/1432 can be used by anybody who needs this feature. Bear in mind it is not a final solution and might get changed.

Just to mention another use case for this: I currently host a blog at www.[blog].com. Because of technical requirements given the infrastructure setup we chose not to use [blog].com. So the emails here must come from<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>which means we also have to configure MX records etc etc to receive replies at that email address. This issue would also be the same for anyone hosting their blog on a subdomain. Emails would come from<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>

Another use case: my blog is [firstname][lastname].com and my email is<EMAIL_ADDRESS>- I'd like emails to come from me because it seems more personal.
I have both domains on my mailgun account and assumed changing the "mailgun domain" setting in the members section would change the from domain, but it doesn't have any effect.
I also found it a bit confusing that there seem to be two sets of email configurations - one for ghost admin and another for members.
That said, it's not a blocker - I still love ghost. ❤

I have both domains on my mailgun account and assumed changing the "mailgun domain" setting in the members section would change the from domain, but it doesn't have any effect.

Changing the mailgun domain to does have an effect. While it doesn't change the "from" address, it changes the domain used to sign the messages which results in the dreaded sent "via" message in gmail and causes messages to get blocked by microsoft's email services and some other providers.
The problem didn't show up in the test messages because I didn't bother to inspect the headers until a number of messages failed delivery. The solution is to make sure your mailgun domain matches the blog domain. I wanted to share this in case anyone else runs into the same problem.


Allow getVariable from string context #2512

getVariable is currently designed to work from the context of an XML node. This enhancement allows getVariable to be called from any context; it also allows somebody to override the context, which could be used to override the language (if that's ever needed).

LGTM


utki cocoapod doesn't have a lib

so long tumbly rabbit hole of despair later. Cocoapods won't work because well CMake. So Duct Tape time. Gets pods, copy pod files to project, remove pods. Add files to project and link libs manually so we don't have to do the "workspace" thing. Only UTKI has no lib just the hpp files. So it won't link and I can't just add the hpp files because they are just hpp files.
Where can I get the ios utki.a from?

The .a should be there in the package. If it is not there, then it is a bug. Let me check.

@oziphantom I've just checked, the package contains .a file:
https://dl.bintray.com/cppfw/cocoapods/utki/1.1.103/utki-1.1.103.zip
Do you use the new cppfw repo, or still the old one, which is igagis?
In case you use old repo, the latest package there is: https://dl.bintray.com/igagiscocoapods/utki/1.1.102/utki-1.1.102.zip
And it also contains the .a file.

hmm not the first time something something has not "downloaded and installed" on this mac. Maybe it is dodgier than I think it is.
Solves the issue though. It actually Links and signs!
I will need to find a way to get "sponsoring" working ;)

So after much toil, and an update the product is now out if you wanted to have a look https://play.google.com/store/apps/details?id=com.symbolicone.ouille
for paying sponsorship doing a $1 month and having everybody take out fees is not ideal, international money fees etc. Do you have a paypal and I can just give you say 3 years in a single hit?

Wow, congratulations!
Very nice to see my software working in released product!
Yes, my paypal is<EMAIL_ADDRESS>Thanks for supporting my work :)!


Add scanTimeout to options

Issue #483: Automatically close the scan window after X ms

To add a new feature, it's best if this can be added for all platforms.
Also, I would prefer to offer a close function, so it can be closed from javascript instead of a native timeout.

I was tried to use javascript timeout by export a close function to cordova.plugin.barcodescanner, and but it is only working on iOS.
On Android, I research and see that it did not have any solutions to close camera window called by startActivityForResult function. So that, I use CountDownTimer on Android also to make it work, I will create new pull request on zxing repo also to support this option.
So, I think use native timeout is better for this case.


The ResultFormat enum used by Restable only includes the json case

When using a Restable we should be able to configure the response body using the resultFormat: ResultFormat variable. Currently we can only enable response bodies that are json decoded. We need to add support for other types.
This is because the ResultFormat enum only has the one .json case

ha! looks as though I half-baked my improvement. From our IRL conversation, the bug isn't so much having to do with your choice of accepted response type header, but rather that when defining a ResopnseType = Raw the accepted response type of application/json is still being sent up.
When Raw, now accepted response header should be sent.

I think also, you changed the default to be application/json right? And there was no way to configure it to be raw since there was no case for .raw in the ResultFormat enum.

Yea, I removed the .raw ResultFormat because it’s redundant. There’s no need for it if the ResponseType is Raw.  The real bug is that the header still gets applied.
A work around for you, for now, is to conform the request in question to Interceptable and, in the intercept method, remove the Accept header.

This is fixed in v0.4.4


meow meow meow meow

https://www.youtube.com/watch?v=9AWCk7HlG4o
Just an upgrade from 0.4.1 to 0.7.2 with a little bit of import cleanup here and there.

👍

👍 woof


[BEAM-9063] migrate docker images to apache - fix postcommit failure

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Go PostCommit

R: @ibzib


Move all SensorArray.add calls out of internal classes

Please start with a use case description for a USER of this enhancement
[Who]  As an app developer
[What] I want exact control of which sensors are added with which runtime settings
[Value] To tailor behaviour and features to my application
Describe the potential solution you'd like
Externalise all adding of sensors outside of Sensor Array and in to application code, including configuration of sensors via their constructors and functions, and not via global configuration variables.
Describe alternatives you've considered
None. There are always cases of needing to customise this functionality.
Additional context
N/A
Relative priority
HIGH - affects ability to test Herald with non-fixed payloads, alter logging behaviour without debug flags, and reduce global configuration variables.

This has been abstracted out in to the App (See AppDelegate in the sample app) in a recent PR.


fix(client/auth): respect accessToken in constructor

Fixes #3065

Nice. See comment on getActiveLogin code path. Feel free to disagree.

Nope, that makes sense to me. Shouldn't bother calling it if we provide an accessToken, totally agree.


host: Prevent multiple attachers to interactive jobs

This means running flynn-host log for a job which has DisableLog set and is already attached now just returns as if there is no log.
I was lead to this by the fact that CI logs are currently around 100MB, with about 70MB of that being the output of the controller backup test because the postgres dump job is still running when the logs are dumped.
Fixes #1697.

LGTM


AC not turning off.

Hello,
Thank you for such a great application. Makes it very easy to set up.
It seems like the off button switches off the AC and then puts it back on Auto, which would require switching off the unit from the SwitchBot app. Not sure if you are aware of this.
Is there any way that this can be solved?
Thank you.

Hello @keithbrf
I faced this issue spot on my HA installation.
It seems to do not appear always, I have to investigate in deep.
I'll do this in next week.

This problem existed in the homebridge plugin, it was resolved by sending first the “setAll” command, then “turnOff” command.
And please update/add the Icon of the service 🙏

Fixed adding "if" on the climate.py file

py

Would you like to send a PR?

Ok, i will check the another Issues, for include the fixes

@keithbrf I release the 0.2.1-beta.1 version. Could you please check if it is working?

@keithbrf please can you test the 0.2.2-beta.2 version?

Hello, it's working now. Thanks!
On Tue, Oct 3, 2023 at 10:32 AM Ivan Suazo @.***> wrote:

@keithbrf https://github.com/keithbrf please can you test the
0.2.2-beta.2 version?
—
Reply to this email directly, view it on GitHub
https://github.com/KiraPC/ha-switchbot-remote/issues/10#issuecomment-1744472336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOQHHS3BBIHKRBYHF4P4BPDX5PETNAVCNFSM6AAAAAA4SPGUBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBUGQ3TEMZTGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Nice @keithbrf ! , feel free to try the new features and add new IR devices types


Cannot sign-out from simulator

Describe the bug
Clicking sign-out from /simulator produces a 404 Not found.
To Reproduce
Steps to reproduce the behavior:

Go to /simulator
Click on your profile on the top right
Click sign-out
See error

Expected behavior
Must sign out similar to how it happens on other pages
Are you working on this issue? (Yes/No)
No

Can I work on this issue?

Can I work on this as my first issue?

Hey @gr455, I think we just open the same issue 😅 #2746

Hey @gr455, I think we just open the same issue sweat_smile #2746

Whoops, I'll close this one. Moved to #2746


upgrade => v1.1.0

After running go get command to install ffuf, the output is

go: github.com/ffuf/ffuf upgrade => v1.1.0

and the package is not installed, how do i rectify that.

Go also stores the source code in a local clone of the git repository. In case go get ... finds a local copy, it will build it without checking upstream.
If you are upgrading, you want to add -u flag to your go get command:
go get -u github.com/ffuf/ffuf

I feel that this issue was resolved, so I'm closing it. In case you disagree, feel free to comment and we can reopen it.


Do I follow JavaScript best practices?

Hi Mr. me,
Great, you have done a good job so far, however, there are some points you need to improve to make your more scalable and professional,

you have used some hardcoded index numbers, which might make a huge issue, when changing the code, instead of that you loop throughout it and some logic for that.

Thanks:)


User unable to submit complaint for review

Submitted via Zendesk.
Complaint has a reviewer assigned, but the status is "Under Investigation". When the user tries to submit the complaint for review, the process fails because the reviewer is not changed.
Two things need to happen:

Fix data for affected complaints (remove reviewer ID).
Figure out why this is happening. (This is the hard part.)

I was able to reproduce the issue by creating a complaint, submitting it for review (requires URL hacking), and then accepting it. This is possible to do, but unlikely since the UI shouldn't present it as an option.
This seems to be a plausible cause because the existing complaints with this issue show them being accepted after being submitted for review:

I can update the "Accept" method to prevent changes if it has already been submitted for review, and also hide the "Accept" button on the details page.


What's the problem

root@XS4325421825:/var/uuu# metame -i ups.exe -o s.exe
[INFO] Opening file with r2
[INFO] Analyzing functions with r2
Traceback (most recent call last):
File "/usr/local/bin/metame", line 5, in
metame.main()
File "/usr/local/lib/python2.7/dist-packages/metame/init.py", line 20, in main
patches = r.iterate_fcn()
File "/usr/local/lib/python2.7/dist-packages/metame/r2parser.py", line 34, in iterate_fcn
arch = x86handler.X86Handler(self.bits, self.debug, self.force)
File "/usr/local/lib/python2.7/dist-packages/metame/x86handler.py", line 73, in init
ks_mode = KS_MODE_32 if self.bits == 32 else KS_MODE_64
NameError: global name 'KS_MODE_32' is not defined
root@XS4325421825:/var/uuu# metame --help
THE File is winx86

from the doc extension, the program might work exclusively on windot https://github.com/a0rtega/metame?tab=readme-ov-file#usage

ah no you forgot to install keyston dependency


Booting via PXE fails with pxe is not a valid platform

Description
Booting a bare metal server with PXE fails when trying alpha/beta releases with this error:
[FAILED] Failed to start Ignition (fetch-offline).
[    3.809217] ignition[201]: invalid value "pxe" for flag -platform: pxe is not a valid platform
See 'systemctl status ignition-fetch-offline.service' for details.

Impact
Unable to test alpha/beta releases on bare metal. I'm interested in testing Systemd-sysext which appears to require flatcar version > 3185.0.0.
Environment and steps to reproduce
Environment is bare metal (not qemu) following directions here. Basic PXE server setup, chain loading iPXE via tftp.  Here's the iPXE script I'm using:
#!ipxe

kernel http://beta.release.flatcar-linux.net/amd64-usr/current/flatcar_production_pxe.vmlinuz initrd=flatcar_production_pxe_image.cpio.gz flatcar.first_boot=1 console=ttyS0,115200n8 ignition.config.url=http://myserver/ignition.cfg
initrd http://beta.release.flatcar-linux.net/amd64-usr/current/flatcar_production_pxe_image.cpio.gz
boot

And here's a snip of the PXE boot log:
>>Start PXE over IPv4.
  Station IP address is 10.x.x.x

  Server IP address is 10.x.x.x
  NBP filename is
  NBP filesize is 218080 Bytes
 Downloading NBP file...

  Succeed to download NBP file.
iPXE initialising devices...ok

iPXE 1.20.1+ (gc70b) -- Open Source Network Boot Firmware -- http://ipxe.org
Features: DNS HTTP HTTPS iSCSI TFTP VLAN AoE EFI Menu
Configuring (net0 xxx)... ok
http://beta.release.flatcar-linux.net/amd64-usr/current/flatcar_production_pxe.vmlinuz... ok
http://beta.release.flatcar-linux.net/amd64-usr/current/flatcar_production_pxe_image.cpio.gz... ok
EFI stub: Loaded initrd from command line option
[    0.000000] microcode: microcode updated early to revision 0x71a, date = 2020-03-24
[    0.000000] Linux version 5.15.37-flatcar<EMAIL_ADDRESS>(x86_64-cros-linux-gnu-gcc (Gentoo Hardened 10.3.0-r2 p3) 10.3.0, GNU ld (Gen2
[    0.000000] Command line: flatcar_production_pxe.vmlinuz initrd=flatcar_production_pxe_image.cpio.gz flatcar.first_boot=1 console=ttyS0,115200n8 ignition.ca
[    0.000000] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers'
...
...
Welcome to dracut-053 (Initramfs)!

[    4.681631] systemd[1]: No hostname configured, using default hostname.
[    4.689126] systemd[1]: Hostname set to <localhost>.
....
[FAILED] Failed to start Ignition (fetch-offline).
[    3.809217] ignition[201]: invalid value "pxe" for flag -platform: pxe is not a valid platform
See 'systemctl status ignition-fetch-offline.service' for details.
[    3.852986] ignition[201]: Usage of /usr/bin/ignition:
[DEPEND] Dependency failed for Ignition Complete.
[    3.869090] ignition[201]:   -config-cache string
...
...
[    6.368624] device-mapper: uevent: version 1.0.3
[    6.373962] device-mapper: ioctl: 4.45.0-ioctl (2021-03-22) initialised<EMAIL_ADDRESS>Press Enter for emergency shell or wait 5 minutes for reboot.

Generating "/run/initramfs/rdsosPress Enter for maintenance
(or press Control-D to continue):
:/root#

Additional information
FWIW, I'm able to boot the stable release of flatcar just fine (v3139.2.1). This only fails on the alpha/beta releases. Thanks in advance for any help/guidance.

Hi @aebruno thanks for the report. The issue has been fixed last week, it has been raised directly from our Matrix channel conversation.
Here's the PR: https://github.com/flatcar-linux/bootengine/pull/45 and it should be available in the next set of beta / alpha releases.
In the meantime, you can explicitly define the OEM id to metal and it should boot as expected:
- kernel http://beta.release.flatcar-linux.net/amd64-usr/current/flatcar_production_pxe.vmlinuz initrd=flatcar_production_pxe_image.cpio.gz flatcar.first_boot=1 console=ttyS0,115200n8 ignition.config.url=http://myserver/ignition.cfg
+ kernel http://beta.release.flatcar-linux.net/amd64-usr/current/flatcar_production_pxe.vmlinuz initrd=flatcar_production_pxe_image.cpio.gz flatcar.first_boot=1 console=ttyS0,115200n8 ignition.config.url=http://myserver/ignition.cfg flatcar.oem.id=metal

Let us know how it goes. :)

@tormath1 Thanks for the reply. I can confirm this works great. Appreciate the help!


DEV: update black config to include doc

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 91.122%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
232488

Relevant Lines:
255140

💛  - Coveralls


Add node_ref and id to Button component

I'm attempting to implement tooltips and dropdown buttons (these are both in an old branch that I'm trying to bring up to date).
As a first step, both of these features need a NodeRef to the underlying <a> or <button> of the Button component they're attached to, in order to set up event handlers, ARIA attributes, and positioning the elements with popper-rs.
I've also added id here for completeness.

Looks fine to me!


SQL to Cypher conversion

Some query tools cannot handle Cypher and expect an SQL statement to pass thru the JDBC connection. Therefor a SQL to Cypher connversion would be helpful. This should support at least simple SQL statements where tables, columns, joins and where clauses are converted to a Cypher/Neo4j equivalent.
It comes from the old Larus project
See also the original issue

Handled by the BI Connector: https://neo4j.com/bi-connector/


FS-465 Improving config doc

Added an example to use config algebra along with case classy library.
It resolves #465

Looks like we may need to update the CI script?
ERROR:  Error installing jekyll:
	The last version of ruby_dep (~> 1.2) to support your Ruby & RubyGems was 1.3.1. Try installing it with `gem install ruby_dep -v 1.3.1` and then running the current command again
	ruby_dep requires Ruby version >= 2.2.5, ~> 2.2. The current ruby version is 2.2.0.

Yes, it seems. I'll update CI script as part of this pull request

On it!


using fastadpter.select(position) to set default selected items,  but their colors are not set?

Hi mike,
I just found fastAdapter.select() that seems to allow me to set certain items as default selected. But how can I turn the default selected items to red ? I already have               UIUtils.setBackground(thisViewHolder.layout, FastAdapterUIUtils.getSelectableBackground(context, Color.RED, true)); in place but it isn't working.
List<Integer> selectedPositions = new ArrayList<>();
fastAdapter.withOnBindViewHolderListener(new FastAdapter.OnBindViewHolderListener() {
     @Override
      public void onBindViewHolder(RecyclerView.ViewHolder viewHolder, int position) {
          if (viewHolder instanceof ItemModel.ViewHolder) {
              ItemModel.ViewHolder thisViewHolder = (ItemModel.ViewHolder) viewHolder;
              ItemModel thisItemAdapter = itemAdapter.getItem(position);
              ItemAttribute row = thisItemAdapter.getModel();

              UIUtils.setBackground(thisViewHolder.layout, FastAdapterUIUtils.getSelectableBackground(context, Color.RED, true));
              if(row.name.contains("something")){
                   selectedPositions.add(position);
              }
           }
      }
});

for(Integer selectedPosition:selectedPositions){
    fastadapter.select(selectedPosition);
}

@stonecold123 if the background does not change color via states and you require a method to change the background you might have to change the behavior to call the update via this:
https://github.com/mikepenz/FastAdapter/blob/develop/library/src/main/java/com/mikepenz/fastadapter/FastAdapter.java#L169
FastAdapter.withSelectWithItemUpdate(true)

Thanks. One more question. If I have a headeradapter wrap around the fastadapter, Do I need to +1 in fasteradapter.select(position)?

Thanks,mike. But I'm still getting problems. My example is a little tricky. I have to get the default selected items' positions first in withOnBindViewHolderListener before executingfastAdapter.select().
I tried the following
     @Override
      public void onBindViewHolder(RecyclerView.ViewHolder viewHolder, int position) {
               .............
               UIUtils.setBackground(thisViewHolder.layout, FastAdapterUIUtils.getSelectableBackground(context, Color.RED, true));
              if(row.name.contains("something")){
                   fastadapter.add(position);
              }
      }

But it gave me java.lang.IllegalStateException: Cannot call this method while RecyclerView is computing a layout or scrolling
If I put it outside the listener:
List<Integer> selectedPositions = new ArrayList<>();
fastAdapter.withOnBindViewHolderListener(new FastAdapter.OnBindViewHolderListener(){
             ......
             if(row.name.contains("something")){
                   selectedPositions.add(position);
              }
}

for(Integer selectedPosition:selectedPositions){
    fastadapter.select(selectedPosition);
}

The fastadapter.select(position) will run before withOnBindViewHolderListener returns selectedPosition.

@stonecold123 one question. why do you do all of this in the onBindViewHolder and not in the bindView method of your item, where it should go to?

@mikepenz, okay I have moved the code back to bindView. Is fastadapter.select(position) always called before bindView? My problem is that the default selected items are dynamic. I need to get their positions in bindView before calling fastadapter.select(position)

@stonecold123 bindView is always called when an item get's into the visible range or the notifyAdapterItemChanged was called. If you have enabled it select will trigger an notifyAdapterItemChanged.
You should use the identifier for those items, so you can get their positions easily.

Solved!
Your suggestion leads me to this:
for(Model data:collection){
   boolean defaultSelected = false;
   if(data.item.contains('default_select')){
       defaultSelected = true;
   }
   itemAdapter.add(new ItemModel(data).withSetSelected(defaultSelected));
}

withSetSelected is too late if it's in bindView. The color won't change accordingly.

@stonecold123 great ;)
withSetSelected just changes the property of the item. This does NOT yet trigger the bindView then. To inform the Adapter that the item has changed you have to notify him that an element was updated.


AVRO-3984 [C++] Improve code generated for unions

What is the purpose of the change
AVRO-3984
This pull request should improve the code generated by avrogencpp for union types. The improvements are:
Getter return a reference
Previously the getters for a union branch returned a value:
std::map<std::string, float > get_map() const;

This lead to a complete copy of the map, which may be really expensive depending on the use case.
In this pull request the getter return a reference instead, which allows the user to choose if a copy should be done.
const std::map<std::string, float >& get_map() const;

Additionally a getter is created, that returns a mutable reference. This can be useful if a value needs to be added to a map or array.
std::map<std::string, int32_t >& get_map();

Setters can take a r-value reference
Currently the setter of a union takes a reference to the value that should be set. This forces the user to copy the value here.
void set_map(const std::map<std::string, int32_t >& v);

With this pull request a alternative overload is provided that takes a r-value reference. Now copies can be avoided, since the cheaper move assignment is called.
void set_map(std::map<std::string, int32_t >&& v);

Additional Branch enum for each union type
Currently the idx() method is available to check which branch of a union is set.
size_t idx() const { return idx_; }

The issue is that the user needs to know which size_t value matches to which branch. This might lead to issues if values are inserted in the middle of a union and the indices change.
To avoid such issues a enum is generated that maps the branch types to the index. For a union of null, map and float this will look like this:
enum class Branch: size_t {
    null = 0,
    map = 1,
    float_ = 2,
};

The user can then cast the value return by idx() to this enum and write a switch case statement
const auto myunion_branch = static_cast<testgen::RootRecord::myunion_t::Branch>(decoded_record.myunion.idx());
switch (myunion_branch) {
    case testgen::RootRecord::myunion_t::Branch::null:
        std::cout << "null" << std::endl;
        break;
    case testgen::RootRecord::myunion_t::Branch::map:
        std::cout << "map" << std::endl;
        break;
    case testgen::RootRecord::myunion_t::Branch::float_:
        std::cout << "float: " << decoded_record.myunion.get_float() << std::endl;
        break;
}

Verifying this change
I added unit tests for the new generated functions and enum class. Also existing test still pass.
Documentation

Does this pull request introduce a new feature? no

the setters and getters are changed in a way that should be backwards compatible, so no new feature i think
i would not consider the new enum a real feature

If yes, how is the feature documented? -

@mkmkme @Gerrit0

@mkmkme @Gerrit0

Sorry I'm on a holiday right now and will be available from Monday

i would not consider the new enum a real feature

I would! It means I can get rid of the enums that are manually maintained alongside the avro file today. I think the release note is sufficient documentation though, anyone new to using avro will already end up looking at the generated header and see it.

@mkmkme @Gerrit0 There was no activity on this pull request lately, is there anything that i still need to do?

Thank you, @hwse !
And @mkmkme & @Gerrit0 for the reviews!


DO NOT MERGE debugging failing test with CI

Coverage decreased (-42.06%) to 41.176% when pulling 91101818d2928f55dfaa10a7658e4d99ef06587e on bochaco:fix-segv-crypto-test into a6f98916384056434bc7cbae5b0361a3093c3425 on maidsafe:master.

Coverage decreased (-41.9%) to 41.292% when pulling 576f15c94dab68a520318bdb71acf12576fc2c44 on bochaco:fix-segv-crypto-test into a6f98916384056434bc7cbae5b0361a3093c3425 on maidsafe:master.

Coverage decreased (-43.7%) to 39.573% when pulling a31da7253571c4ee45d873451d1ece7ff3d56111 on bochaco:fix-segv-crypto-test into a6f98916384056434bc7cbae5b0361a3093c3425 on maidsafe:master.

Coverage decreased (-43.7%) to 39.573% when pulling a31da7253571c4ee45d873451d1ece7ff3d56111 on bochaco:fix-segv-crypto-test into a6f98916384056434bc7cbae5b0361a3093c3425 on maidsafe:master.

Coverage increased (+0.6%) to 83.805% when pulling 43380defe59d23dda1ae8828054ecba7a59efc64 on bochaco:fix-segv-crypto-test into eea78bf583af9b4bae6fd1baf5e8008eaf094641 on maidsafe:master.

Coverage increased (+0.6%) to 83.805% when pulling 43380defe59d23dda1ae8828054ecba7a59efc64 on bochaco:fix-segv-crypto-test into eea78bf583af9b4bae6fd1baf5e8008eaf094641 on maidsafe:master.


Related Work: Monetising Resources on a SoLiD Pod Using Blockchain Transactions (ESWC Demo)

Hi,
I wanted to share our work on monetising web resources using SoLiD Pods and an Ethereum Blockchain.
It is the result of a student seminar on the topic of Semantic Web and Linked Data.
We presented the prototype as a demo at ESWC.
I don't know if you would like to include it on the list of recent work or not.
In any case, we appreciate any discussion, comments or remarks. :-)
Cheers
Christoph

Abstract.
Our demo showcases a system that allows users to provide access to web resources in exchange for payments via the blockchain. The system enables users to create offers for their resources or buy access rights for resources belonging to other users. Access rights can be granted only for a limited amount of time. We built our system as SoLiD Pods and Apps: We developed two server modules for SoLiD Pods that automatically (1) grant access for valid payments via the blockchain and (2) remove expired access rights. On top, we developed a SoLiD App that allows to offer resources, browse and request offered resources, and make payments via the blockchain.

Resource
URI

Teaser (1 min)
https://www.youtube.com/watch?v=sqIeYRTrkEg

Demo Website
http://people.aifb.kit.edu/co1683/2021/eswc-demo-solibra/

Code
https://github.com/bright-fox/SolidBlockchain

Paper
http://people.aifb.kit.edu/co1683/2021/eswc-demo-solibra/solibra.pdf

Wow, great! Yes, please create a PR to add yourself to the list!
On page 3 of http://people.aifb.kit.edu/co1683/2021/eswc-demo-solibra/solibra.pdf you say "Our approach uses Web Access Control (WAC)" - are you also specifically using the acl:agentClass acl:PayingAgent predicate proposed in https://github.com/solid/webmonetization/issues/7?

Will do!
Oh cool, I did not know that there was a consensus on the 402 and acl:PayingAgent. Is that already implement in NSS?
The student seminar took place in the winter semester and ended in February. Back then, very limited information on how things should work were available, so we implemented a workaround without fiddeling with NSS too much.  You opened #7 in March, so no, in the demo, we do not use 402. We just used the standard NSS (at that time).
To advertise any payables (purchasable resources), we defined a folder where the corresponding offers are accessible.
I think, one could link to those offers in a 402 response without any issues. With that, all the corresponding payment information are discoverable from the resource itself (without any additional knowledge about folder structure...)


bugfix: 修复部分国际化和体验问题

Codecov Report

Merging #1099 (dab7bec) into v2.6.x_develop (6c95bb8) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           v2.6.x_develop    #1099      +/-   ##
==================================================
- Coverage           38.73%   38.73%   -0.01%
==================================================
  Files                 290      290
  Lines               19314    19315       +1
==================================================
  Hits                 7481     7481
- Misses              11833    11834       +1

see 1 file with indirect coverage changes


Dev

Why re-set the status when it is already set before throwing the error ?

In case we want or need to put another code for an error which isn't catched by the two ifs


stats: 2.11.21 -> 2.11.22

Things done
https://github.com/exelban/stats/releases/tag/v2.11.22

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 369001

x86_64-darwin

:white_check_mark: 1 package built:

stats

aarch64-darwin

:white_check_mark: 1 package built:

stats


[Bug]  Don't understand how to do the iOS step 4. Running to an error

🐛 Bug
Steps to reproduce the behavior:
I am novice hobby dev. Trying to build MLC iOS app with local LLM from source. Steps 1-3 done.
When i proceed to Step 4, I open Xcode project and open ./ios/MLCChat.xcodeproj using Xcode. I have an Apple Developer Account and used Xcode to build simple stuff couple times (never deployed anything to App Store and don't have paid Dev Account).
Once opened XCode, I push "play" (run) - I receive an error:
"Build failed"

Library not found for -lmodel_iphone
Linker command failed with exit code 1 (use -v to see invocation)

Maybe I should've done "Ensure that all the necessary dependencies and configurations are correctly set up in the Xcode project", but I don't understand what that means. I only opened the ./ios/MLCChat.xcodeproj using Xcode and pushed "run" the project
Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA): Mac M1 2020
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...): Mac M1 2020 trying to build an iPhone app
How you installed MLC-LLM (conda, source): I used pip3 for steps 1-3 in iOS instruction, I don't have conda
How you installed TVM-Unity (pip, source): pip install --pre --force-reinstall mlc-ai-nightly mlc-chat-nightly -f https://mlc.ai/wheels
Python version: 3.11

Please assist, I may be just not understanding what should be done at step 4, but I just don't understand what the documentation implies.

Please make sure you have done step3 https://mlc.ai/mlc-llm/docs/deploy/ios.html#step-3-build-auxiliary-components and check
>>> ls ./build/lib/
libmlc_llm.a         # A lightweight interface to interact with LLM, tokenizer, and TVM Unity runtime
libmodel_iphone.a    # The compiled model lib
libsentencepiece.a   # SentencePiece tokenizer
libtokenizers_cpp.a  # Huggingface tokenizer
libtvm_runtime.a     # TVM Unity runtime

After I run "./prepare_libs.sh" in ./ios i got this message:

rustup target add aarch64-apple-ios
info: component 'rust-std' for target 'aarch64-apple-ios' is up to date
mkdir -p build/
cd build/
cmake ../.. -DCMAKE_BUILD_TYPE=Release -DCMAKE_SYSTEM_NAME=iOS -DCMAKE_SYSTEM_VERSION=14.0 -DCMAKE_OSX_SYSROOT=iphoneos -DCMAKE_OSX_ARCHITECTURES=arm64 -DCMAKE_OSX_DEPLOYMENT_TARGET=14.0 -DCMAKE_BUILD_WITH_INSTALL_NAME_DIR=ON -DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON -DCMAKE_INSTALL_PREFIX=. -DCMAKE_CXX_FLAGS=-O3 -DMLC_LLM_INSTALL_STATIC_LIB=ON -DUSE_METAL=ON
-- TVM_HOME: 3rdparty/tvm
-- Forbidding undefined symbols in shared library, using -Wl,-undefined,error on platform iOS
-- Didn't find the path to CCACHE, disabling ccache
-- VTA build with VTA_HW_PATH=/Users/leszekmielnikow/Coding/mlc-llm/3rdparty/tvm/3rdparty/vta-hw
-- Build VTA runtime with target: sim
-- Build with Metal support
-- Build with contrib.random
-- Build with contrib.sort
-- Build with contrib.hybriddump
-- Git found: /opt/homebrew/bin/git
-- Found TVM_GIT_COMMIT_HASH=206661b4aecb362dd5bccfba4de9013f8175cf20
-- Found TVM_GIT_COMMIT_TIME=2023-06-17 14:36:49 -0400
-- Building with TVM Map...
-- Build with thread support...
-- system-nameiOS
-- VERSION: 0.2.00
-- Configuring done (0.7s)
-- Generating done (0.2s)
-- Build files have been written to: /Users/leszekmielnikow/Coding/mlc-llm/ios/build
make mlc_llm_static
[ 45%] Built target sentencepiece-static
[ 45%] Built target mlc_llm_objs
[ 54%] Built target tvm_libinfo_objs
[100%] Built target tvm_runtime_objs
[100%] Built target tvm_runtime
[100%] Built target tokenizers_c
[100%] Built target tokenizer_cpp_objs
[100%] Built target tokenizers_cpp
[100%] Built target mlc_llm_static
cmake --build . --target install --config release -j
Install the project...
-- Install configuration: "Release"
-- Installing: /Users/leszekmielnikow/Coding/mlc-llm/ios/build/lib/libmlc_llm.a
-- Installing: /Users/leszekmielnikow/Coding/mlc-llm/ios/build/lib/libtokenizers_cpp.a
-- Installing: /Users/leszekmielnikow/Coding/mlc-llm/ios/build/lib/libsentencepiece.a
-- Installing: /Users/leszekmielnikow/Coding/mlc-llm/ios/build/lib/libtvm_runtime.a
-- Up-to-date: /Users/leszekmielnikow/Coding/mlc-llm/ios/build/lib/libtokenizers_c.a
cd ..
rm -rf MLCSwift/tvm_home
ln -s ../../3rdparty/tvm MLCSwift/tvm_home
python prepare_model_lib.py
./prepare_libs.sh: line 28: python: command not found

Im particularly worried about last row: "./prepare_libs.sh: line 28: python: command not found"
Is it ok and if not, how to fix it?

That seems to mean that you don't have python, which is an issue, please make sure you follow step 1 https://mlc.ai/mlc-llm/docs/deploy/ios.html#step-1-install-build-dependencies to install tvm unity (which have python)

I definetely have python and ran it multiple times. Maybe the issue is that I use python 3.11 and pip3?

I think it could due to the fact that prepare_libs.sh uses bash, and you setup your python in zsh
as a result line 28: python: command not found"

Fixed, changed for zsh and also changed python to python3

You will need to select a real target(iphone, or My Mac(build for iPad)) instead of simulator.

Can you please tell me how to do that?
Sorry, im just starting ios dev journey and really struggling with a lot of these setup issues.

Click on the top bar, that allows you to select a target, pick iphone(you need to plugin your iphone), or My Mac(designed for iPad) if you have a M1/M2 device

@LexiestLeszek please let us know if ^ helps to resolve the issue

You need to  set sigining & capabilities, select automatically manage signing, change team to your apple dev account team. and change the bundle identifier likely

hi, sorry for delay, it still isn't working and I switched to use BERT in my project :(

Likely you need an apple dev account, and change the team to your personal team per above image

Once I'll have some time, probably next week, I'll try again and will return to you, I really need an LLM in my ios app

Yay, it runs on my mac locally as an MCL chat. Thanks!
but I after i did most of the step 4 to add it to my own app, Import MLCSwift doesn't work for some reason. Can I ask why didn't you decided to create a model in *.mlmodel format and one class for it? Kinda like HF did with GPT-2 for swift

The process requires a new iphone and not on simulator (due to architecture choice).
In this case we are not leveraging coreml but uses the mlc runtime and directly generate metal shader

hi, sorry for delay, it still isn't working and I switched to use BERT in my project :(

hello, I would like to ask if you have supported bert for mlc-llm yourself, because it seems that there is no support for bert now.

hi, sorry for delay, it still isn't working and I switched to use BERT in my project :(

hello, I would like to ask if you have supported bert for mlc-llm yourself, because it seems that there is no support for bert now.

Hi. Apple supports bert by default: https://developer.apple.com/documentation/coreml/model_integration_samples/finding_answers_to_questions_in_a_text_document


Dataset: Flow and Boundary Condition

The train.tfrecords I think does not have the flow conditions stored in the boundarys and only has the geometry info.  Am I Missing out on something on how to add flow condition to the network?

That is correct, the flow conditions are not input to the network but they are kept consistent through the dataset. I have since played around with adding flow conditions with some success.


Cannot create ospi instance for stm32h7b0

I'm trying to use stm32h7b0's octospi peripheral as the following:
#[embassy_executor::main]
async fn main(_spawner: Spawner) {
    let ospi_config = ospi::Config::default();

    let ospi = Ospi::new_quadspi(
        p.OCTOSPI1,
        p.PA3,
        p.PC9,
        p.PD12,
        p.PE2,
        p.PD13,
        p.PB6,
        p.MDMA,
        ospi_config,
    );
}

But the compiler reports all the pins are not impl for OCTOSPI1. I checked the stm32-data-generated, it seems that the pins are defined in OCTOSPIM peripheral, but not OCTOSPI1 and OCTOSPI2:
https://github.com/embassy-rs/stm32-data-generated/blob/e30c7694016fa9a326f153fff84dedb0c02b8676/data/chips/STM32H7B0VB.json#L4147-L4235
However, Ospi::new_quadspi doesn't accept p.OCTOSPIM as the peri. Is there any method to fix it?
---- Attached: parts of the compiler error
error[E0277]: the trait bound `PA3: embassy_stm32::ospi::SckPin<embassy_stm32::peripherals::OCTOSPI1>` is not satisfied
   --> src/main.rs:114:20
    |
114 |       let mut ospi = Ospi::new_quadspi(
    |  ____________________^
115 | |         p.OCTOSPI1,
116 | |         p.PA3,
117 | |         p.PC9,
...   |
123 | |         ospi_config,
124 | |     );
    | |_____^ the trait `embassy_stm32::ospi::SckPin<embassy_stm32::peripherals::OCTOSPI1>` is not implemented for `PA3`
    |
note: required by a bound in `Ospi::<'d, T, embassy_stm32::mode::Async>::new_quadspi`
   --> C:\Users\haobo\.cargo\git\checkouts\embassy-9312dcb0ed774b29\b0172bb\embassy-stm32\src\ospi\mod.rs:785:39
    |
783 |     pub fn new_quadspi(
    |            ----------- required by a bound in this associated function
784 |         peri: impl Peripheral<P = T> + 'd,
785 |         sck: impl Peripheral<P = impl SckPin<T>> + 'd,
    |                                       ^^^^^^^^^ required by this bound in `Ospi::<'d, T, Async>::new_quadspi`

error[E0277]: the trait bound `PC9: embassy_stm32::ospi::D0Pin<embassy_stm32::peripherals::OCTOSPI1>` is not satisfied
   --> src/main.rs:114:20
    |
114 |       let mut ospi = Ospi::new_quadspi(
    |  ____________________^
115 | |         p.OCTOSPI1,
116 | |         p.PA3,
117 | |         p.PC9,
...   |
123 | |         ospi_config,
124 | |     );
    | |_____^ the trait `embassy_stm32::ospi::D0Pin<embassy_stm32::peripherals::OCTOSPI1>` is not implemented for `PC9`
    |
note: required by a bound in `Ospi::<'d, T, embassy_stm32::mode::Async>::new_quadspi`
   --> C:\Users\haobo\.cargo\git\checkouts\embassy-9312dcb0ed774b29\b0172bb\embassy-stm32\src\ospi\mod.rs:786:38
    |
783 |     pub fn new_quadspi(
    |            ----------- required by a bound in this associated function
...
786 |         d0: impl Peripheral<P = impl D0Pin<T>> + 'd,
    |                                      ^^^^^^^^ required by this bound in `Ospi::<'d, T, Async>::new_quadspi`

error[E0277]: the trait bound `PD12: embassy_stm32::ospi::D1Pin<embassy_stm32::peripherals::OCTOSPI1>` is not satisfied
   --> src/main.rs:114:20
    |
114 |       let mut ospi = Ospi::new_quadspi(
    |  ____________________^
115 | |         p.OCTOSPI1,
116 | |         p.PA3,
117 | |         p.PC9,
...   |
123 | |         ospi_config,
124 | |     );
    | |_____^ the trait `embassy_stm32::ospi::D1Pin<embassy_stm32::peripherals::OCTOSPI1>` is not implemented for `PD12`
    |
note: required by a bound in `Ospi::<'d, T, embassy_stm32::mode::Async>::new_quadspi`
   --> C:\Users\haobo\.cargo\git\checkouts\embassy-9312dcb0ed774b29\b0172bb\embassy-stm32\src\ospi\mod.rs:787:38

OCTOSPIM is a new peripheral that sits on top of OSPI1 and OSPI2 and does some kind of pin muxing. So, fixing this requires adding support in embassy-stm32 for configuring the OCTOSPIM I think.

OCTOSPIM is a new peripheral that sits on top of OSPI1 and OSPI2 and does some kind of pin muxing. So, fixing this requires adding support in embassy-stm32 for configuring the OCTOSPIM I think.

Is there any reference about doing this type of configuring? I'd like to fix it if possible

check the Reference Manual for your chip, it explains how OCTOSPIM works.

check the Reference Manual for your chip, it explains how OCTOSPIM works.

Should I implement a separate peripheral ospim, or just update current ospi?


 dependency

@hanfei1991
Would it be possible to create the "c-client" only with a dependency to "grpc"  (e.g. to void "Poco")?

Well, Is there a better way to print log ?

https://github.com/amrayn/easyloggingpp ?

Well, Is there a better way to print log ?

@hanfei1991 Do we use Poco for logging only?
I assume the problem with Poco dependency is that it might conflict with user application's Poco.
For logging, in Java community most project written based on the Facade(e.g. slf4j) and the real runtime set the implementation. @gggin can your alternative choice avoid library link but only headers?
Otherwise #63 can resolve this issue if the concern is system-wise pre-installed library requirement.

PR https://github.com/tikv/client-c/pull/84 may ease this problem. It works for both system-wide pre-installed poco, and bundled poco in an outer project.


[FEATURE] Get conversation meta return application_type

Is your feature request related to a problem?
current get memory api https://opensearch.org/docs/latest/ml-commons-plugin/api/memory-apis/get-memory/ will return response like below, it miss application_type field.
{
  "memory_id": "gW8Aa40BfUsSoeNTvOKI",
  "create_time": "2024-02-02T18:07:06.887061463Z",
  "updated_time": "2024-02-02T19:01:32.121444968Z",
  "name": "Conversation for a RAG pipeline",
  "user": "admin"
}

mapping of system index .plugins-ml-memory-meta
{
  ".plugins-ml-memory-meta": {
    "mappings": {
      "_meta": {
        "schema_version": 1
      },
      "properties": {
        "application_type": {
          "type": "keyword"
        },
        "create_time": {
          "type": "date",
          "format": "strict_date_time||epoch_millis"
        },
        "name": {
          "type": "text"
        },
        "updated_time": {
          "type": "date",
          "format": "strict_date_time||epoch_millis"
        },
        "user": {
          "type": "keyword"
        }
      }
    }
  }
}

What solution would you like?
A clear and concise description of what you want to happen.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

@Zhangxunmt want to confirm with you does this application_type not return by intention? is there a specific reason or we just miss it?

This is expected. Not a bug. Already discussed this issue in other threads.


Visual studio supported versions

The visual studio versions mentioned to associate test methods are visual studio 2017 and earlier. We have upgraded to visual studio 2019 was wondering if it's officially supported for test plan association and run.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b6c92a2-2f5c-e34e-f285-3e1a2a02604b
Version Independent ID: 6f31f4c2-94ac-20eb-da01-e1d47f041945
Content: Run automated tests from test plans - Azure Test Plans
Content Source: docs/test/run-automated-tests-from-test-hub.md
Product: devops
Technology: devops-test
GitHub Login: @steved0x
Microsoft Alias: sdanie

@Abutu Thanks for your question. While we look into whether we need to update the docs wrt VS2019, consider these resources:

Azure DevOps Services
Azure DevOps Support Bot
Azure DevOps on Stack Overflow


No types or goals inside matches

Description
In the following definition, only the Nats outside the match seem to carry metadata
example : Nat → Nat
  | 0 => 0
  | n + 1 => by exact n

Expected behaviour
We should have type hover on 0/n/... and goals on by
Environment information

Operating System: Linux
Lean version: nightly-03-02
LeanInk version: https://github.com/Kha/LeanInk/tree/main
Alectryon version: https://github.com/insightmind/alectryon/tree/typeid

Additional Notes
Perhaps some unexpected order in the info tree?
[Elab.info] command @ ⟨3, 0⟩-⟨5, 23⟩ @ Lean.Elab.Command.elabDeclaration
  Nat → Nat : Type @ ⟨3, 10⟩-⟨3, 19⟩ @ Lean.Elab.Term.elabArrow
    Nat : Type @ ⟨3, 10⟩-⟨3, 13⟩ @ Lean.Elab.Term.elabIdent
      [.] `Nat : some Sort.{?_uniq.2} @ ⟨3, 10⟩-⟨3, 13⟩
      Nat : Type @ ⟨3, 10⟩-⟨3, 13⟩
    Nat : Type @ ⟨3, 16⟩-⟨3, 19⟩ @ Lean.Elab.Term.elabIdent
      [.] `Nat : some Sort.{?_uniq.3} @ ⟨3, 16⟩-⟨3, 19⟩
      Nat : Type @ ⟨3, 16⟩-⟨3, 19⟩
  fun x =>
    _example.match_1 (fun x => Nat) x (fun _ => 0) fun n =>
      n : <failed-to-infer-type> @ ⟨4, 2⟩†-⟨5, 23⟩ @ Lean.Elab.Term.elabExplicit
    fun x =>
      _example.match_1 (fun x => Nat) x (fun _ => 0) fun n =>
        n : <failed-to-infer-type> @ ⟨4, 2⟩†-⟨5, 23⟩ @ Lean.Elab.Term.elabFun
      Nat : Type @ ⟨4, 2⟩†-⟨5, 23⟩† @ Lean.Elab.Term.elabHole
      x (isBinder := true) : Nat @ ⟨4, 2⟩†-⟨5, 23⟩†
      _example.match_1 (fun x => Nat) x (fun _ => 0) fun n =>
        n : <failed-to-infer-type> @ ⟨4, 2⟩†-⟨5, 23⟩ @ Lean.Elab.Term.elabMatch
        x : Nat @ ⟨4, 2⟩†-⟨5, 23⟩†
        0 : Nat @ ⟨4, 4⟩-⟨4, 5⟩ @ Lean.Elab.Term.elabNumLit
        0 : Nat @ ⟨4, 9⟩-⟨4, 10⟩ @ Lean.Elab.Term.elabNumLit
        [.] `n : none @ ⟨5, 4⟩-⟨5, 5⟩
        n + 1 : Nat @ ⟨4, 2⟩†-⟨5, 9⟩ @ Lean.Elab.Term.BinOp.elabBinOp
          n : Nat @ ⟨5, 4⟩-⟨5, 5⟩ @ Lean.Elab.Term.elabIdent
            n : Nat @ ⟨5, 4⟩-⟨5, 5⟩
          1 : Nat @ ⟨5, 8⟩-⟨5, 9⟩ @ Lean.Elab.Term.elabNumLit
        Tactic @ ⟨5, 13⟩-⟨5, 23⟩
        (Term.byTactic "by" (Tactic.tacticSeq (Tactic.tacticSeq1Indented [(group (Tactic.exact "exact" `n) [])])))
        before
        n : Nat
        ⊢ Nat
        after no goals
          Tactic @ ⟨5, 16⟩-⟨5, 23⟩ @ Lean.Elab.Tactic.evalTacticSeq
          (Tactic.tacticSeq (Tactic.tacticSeq1Indented [(group (Tactic.exact "exact" `n) [])]))
          before
          n : Nat
          ⊢ Nat
          after no goals
            Tactic @ ⟨5, 16⟩-⟨5, 23⟩ @ Lean.Elab.Tactic.evalTacticSeq1Indented
            (Tactic.tacticSeq1Indented [(group (Tactic.exact "exact" `n) [])])
            before
            n : Nat
            ⊢ Nat
            after no goals
              Tactic @ ⟨5, 16⟩-⟨5, 23⟩ @ Lean.Elab.Tactic.evalExact
              (Tactic.exact "exact" `n)
              before
              n : Nat
              ⊢ Nat
              after no goals
                n : Nat @ ⟨5, 22⟩-⟨5, 23⟩ @ Lean.Elab.Term.elabIdent
                  n : Nat @ ⟨5, 22⟩-⟨5, 23⟩
  _example (isBinder := true) : Nat → Nat @ ⟨3, 0⟩-⟨3, 7⟩

I have implemented a fix for this in commit 9f285ade1dd9f6913c7f228ce48bc85fd7228b03.
In addition to that I added this example as a test case.
Can you check if the fix also works in your environment, and if any information is still missing?

Works great, thanks!


TTNN leaky relu - incomplete documentation

For TTNN leaky_relu op:
The documentation does not cover supported data types (BFLOAT16/BFLOAT8_B) neither the supported layouts (ROW_MAJOR/TILE). In practice, its seems that it does support BFLOAT8_B type, but layout ROW_MAJOR is not supported (TILE supported).

Fix for this in PR #8050

Will revisit this task and update it after migration task

Merged to main. Hence closing this issue.