[SPARK-10641][WIP][SQL] Add Skewness and Kurtosis Support

Implementing skewness and kurtosis support based on following algorithm:
https://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Higher-order_statistics

Can one of the admins verify this patch?

A few notes:

I wrote this implementation before stddev was merged, and hence I ended up with a slightly different implementation. The differences are mostly syntactical (the algorithms for computing second moment are the same), except for how the subclasses are implemented. Once we figure out the best way to implement the subclasses, I will merge the implementations to remove the overlap
(https://issues.apache.org/jira/browse/SPARK-10953)[SPARK-10953] Calls for benchmarking codegen vs scala implementations of univariate stats. The results of that may affect this PR.
I did not implement the skewness and kurtosis functions using the old way with AggregateFunction1, since I think that will be removed. I can implement this separately if needed.

@sethah, are you working on this? My suggestion is to implement skewness and kurtosis in a single aggregate function that implements ImperativeAggregate based on the discussion in SPARK-10953, but do not change existing implementation of standard deviation and variance. This makes the PR simpler and easier to review and merge.

@mengxr I am working on it, and I have incorporated changes from the note you posted on the Jira - thanks for that! I pushed some changes. I had already changed the existing implementation of stddev unfortunately, but I can revert those changes so that the PR is a bit smaller. I was thinking that since variance hasn't been merged yet, that I could include it in the PR, but if you think it's best to leave it out I can do that as well.
I tested the imperative versions vs the codegen versions I had before and they are significantly faster. I will work on getting the changes for stddev reverted so that it will be ready for review.

@sethah Besides inline comments, we can also think about how to simplify the class inheritance. It would be better if we don't need to touch InternalRow in subclasses. Also, Variance is the same as VarianceSamp, shall we make one inherit another with a different prettyName?

add to whitelist

@mengxr I think having VarianceSamp inherit from Variance will be a fine solution. I'm not clear on why it is better not to touch InternalRow in the subclasses, but if we must avoid it, one solution could be
def eval(buffer: InternalRow): Any = this match {
      case _: VariancePop => { }
      case _: Variance => { }
      case _: Skewness => { }
      case _: Kurtosis => { }

Merged build triggered.

Merged build started.

Test build #43961 has started for PR 9003 at commit b180a28.

Test build #43961 has finished for PR 9003 at commit b180a28.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * case class Stddev(child: Expression) extends CentralMomentAgg(child) \n  * case class StddevSamp(child: Expression) extends CentralMomentAgg(child) \n  * case class StddevPop(child: Expression) extends CentralMomentAgg(child) \n  * case class Variance(child: Expression) extends CentralMomentAgg(child) \n  * case class VarianceSamp(child: Expression) extends CentralMomentAgg(child) \n  * case class VariancePop(child: Expression) extends CentralMomentAgg(child) \n  * case class Skewness(child: Expression) extends CentralMomentAgg(child) \n  * case class Kurtosis(child: Expression) extends CentralMomentAgg(child) \n  * abstract class CentralMomentAgg1(child: Expression)\n  * case class Kurtosis(child: Expression) extends CentralMomentAgg1(child) \n  * case class Skewness(child: Expression) extends CentralMomentAgg1(child) \n  * case class Variance(child: Expression) extends CentralMomentAgg1(child) \n  * case class VariancePop(child: Expression) extends CentralMomentAgg1(child) \n  * case class VarianceSamp(child: Expression) extends CentralMomentAgg1(child) \n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43961/
Test FAILed.

@sethah The storage of InternalRow is an implicit contract. Exposing InternalRow to subclasses makes the code harder to understand. For example, to confirm the following code, one needs to go back to the implementation of CentralMomentAgg.
val M0 = buffer.getDouble(mutableAggBufferOffset)
val M2 = buffer.getDouble(mutableAggBufferOffset + 2)
val M4 = buffer.getDouble(mutableAggBufferOffset + 4)

I suggest adding an abstract method to CentralMomemtAgg called Double getStatistic(n: Double, mean: Double, moments: Array[Double]) and implement eval in CentralMomentAgg:
override final def eval(buffer: InternalRow): Any = {
  val n = buffer.getDouble(offset)
  val mean = buffer.getDouble(offset + 1)
  val moments = Array.ofDim(maxMomemt)
  moments[0] = 1.0
  moments[1] = 0.0
  // fill in other moments up to maxMoment
  getStatistic(n, mean, moments)
}

Then we can hide the storage of InternalRow from subclasses.

Merged build triggered.

Merged build started.

Test build #44039 has started for PR 9003 at commit 4ae234e.

Test build #44039 has finished for PR 9003 at commit 4ae234e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44039/
Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #44046 has started for PR 9003 at commit 62c515c.

@mengxr Addressed all comments and rearranged the class inheritances for case classes. I made another abstract class SecondMoment which all Variance classes inherit from - I think this will make the addition of the StdDev classes very simple.
Items still to be addressed:

I have not implemented using the AggregateFunction1 interface since I believe it will be removed. Right now, I have added placeholders that just copy the code for Average so that the current code will compile. I'm not sure if I need to implement this or if we can just wait until the AggregateFunction1 interface is removed.
I need to add tolerancing to the checkAnswer function in SQL test suite because aggregate stats do not result in exact answers for the test data (e.g. 0.0 != 5e-17). I will work on this soon.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44045/
Test FAILed.

Test build #44046 has finished for PR 9003 at commit 62c515c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * abstract class SecondMoment(child: Expression) extends CentralMomentAgg(child) \n  * case class Variance(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VarianceSamp(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VariancePop(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Skewness(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression, mutableAggBufferOffset: Int = 0,\n  * abstract class CentralMomentAgg1(child: Expression)\n  * case class Kurtosis(child: Expression) extends CentralMomentAgg1(child) \n  * case class Skewness(child: Expression) extends CentralMomentAgg1(child) \n  * case class Variance(child: Expression) extends CentralMomentAgg1(child) \n  * case class VariancePop(child: Expression) extends CentralMomentAgg1(child) \n  * case class VarianceSamp(child: Expression) extends CentralMomentAgg1(child) \n

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44046/
Test FAILed.

Merged build finished. Test FAILed.

Seth, no need to implement the old interface, simply put a placeholder for resolving it is sufficient, which will go away when this code path is removed.
here is an example
case class Range(child: Expression) extends UnaryExpression with AggregateExpression {

override def nullable: Boolean = false
override def dataType: DoubleType.type = DoubleType
override def foldable: Boolean = false
override def toString: String = s"RANGE($child)"
+}

Build triggered.

Build started.

Test build #44119 has started for PR 9003 at commit 1594aba.

Test build #44119 has finished for PR 9003 at commit 1594aba.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * abstract class SecondMoment(child: Expression) extends CentralMomentAgg(child) \n  * case class Variance(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VarianceSamp(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VariancePop(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Skewness(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression, mutableAggBufferOffset: Int = 0,\n  * abstract class CentralMomentAgg1(child: Expression)\n  * case class Kurtosis(child: Expression) extends CentralMomentAgg1(child) \n  * case class Skewness(child: Expression) extends CentralMomentAgg1(child) \n  * case class Variance(child: Expression) extends CentralMomentAgg1(child) \n  * case class VariancePop(child: Expression) extends CentralMomentAgg1(child) \n  * case class VarianceSamp(child: Expression) extends CentralMomentAgg1(child) \n

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44119/
Test FAILed.

Build finished. Test FAILed.

Build triggered.

Build started.

Test build #44164 has started for PR 9003 at commit 2c9046f.

Test build #44164 has finished for PR 9003 at commit 2c9046f.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * abstract class SecondMoment(child: Expression) extends CentralMomentAgg(child) \n  * case class Variance(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VarianceSamp(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VariancePop(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Skewness(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Skewness(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Variance(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VariancePop(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VarianceSamp(child: Expression) extends UnaryExpression with AggregateExpression \n

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44164/
Test FAILed.

Build triggered.

Build started.

Test build #44165 has started for PR 9003 at commit e0c5c88.

Test build #44165 has finished for PR 9003 at commit e0c5c88.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * abstract class SecondMoment(child: Expression) extends CentralMomentAgg(child) \n  * case class Variance(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VarianceSamp(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VariancePop(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Skewness(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Skewness(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Variance(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VariancePop(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VarianceSamp(child: Expression) extends UnaryExpression with AggregateExpression \n

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44165/
Test FAILed.

Build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #44179 has started for PR 9003 at commit 3ef2faa.

Test build #44179 has finished for PR 9003 at commit 3ef2faa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * abstract class SecondMoment(child: Expression) extends CentralMomentAgg(child) \n  * case class Variance(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VarianceSamp(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class VariancePop(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Skewness(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression, mutableAggBufferOffset: Int = 0,\n  * case class Kurtosis(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Skewness(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Variance(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VariancePop(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VarianceSamp(child: Expression) extends UnaryExpression with AggregateExpression \n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44179/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44234 has started for PR 9003 at commit fd3f4d6.

LGTM except minor inline comments. Ping @yhuai for a final pass.

Test build #44234 has finished for PR 9003 at commit fd3f4d6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44234/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #44267 has started for PR 9003 at commit cf8a14b.

Merged build triggered.

Merged build started.

Test build #44272 has started for PR 9003 at commit b86386a.

Test build #44267 has finished for PR 9003 at commit cf8a14b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * case class Variance(child: Expression,\n  * case class VarianceSamp(child: Expression,\n  * case class VariancePop(child: Expression,\n  * case class Skewness(child: Expression,\n  * case class Kurtosis(child: Expression,\n  * case class Kurtosis(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Skewness(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Variance(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VariancePop(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VarianceSamp(child: Expression) extends UnaryExpression with AggregateExpression \n

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44267/
Test FAILed.

Merged build finished. Test FAILed.

Test build #44272 has finished for PR 9003 at commit b86386a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44272/
Test FAILed.

@sethah It seems that VARIANCE in HIVE returns the population variance. It is the same in MySQL: https://dev.mysql.com/doc/refman/5.0/en/group-by-functions.html#function_variance. So let's keep the same behavior. Then it is a little awkward that stddev is sample variance in our implementation. HIVE doesn't have stddev, while MySQL uses population stddev for stddev. I think it is more important to be compatible with existing SQL engines. We can address the stddev in a follow-up PR.

@mengxr Corrected variance to yield the population variance. Tests should pass now.

Merged build triggered.

Merged build started.

Test build #44366 has started for PR 9003 at commit 3045e3b.

Test build #44366 has finished for PR 9003 at commit 3045e3b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * case class Variance(child: Expression,\n  * case class VarianceSamp(child: Expression,\n  * case class VariancePop(child: Expression,\n  * case class Skewness(child: Expression,\n  * case class Kurtosis(child: Expression,\n  * case class Kurtosis(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Skewness(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Variance(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VariancePop(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VarianceSamp(child: Expression) extends UnaryExpression with AggregateExpression \n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44366/
Test FAILed.

I guess this is still failing HiveComparisonTest due to small error in the variance.
[info]   !== HIVE - 1 row(s) ==                                            == CATALYST - 1 row(s) ==
[info]   !500	130091	260.182	0	498<PHONE_NUMBER>0752384	20428.072876000006   500	130091	260.182	0	498<PHONE_NUMBER>0752384	20428.07287599999 (HiveComparisonTest.scala:433)
abs(20428.072876000006 - 20428.07287599999) = 1.4552e-11
Not sure if we need to change the test?

Had an offline discussion with @yhuai. We can remove fetch_aggregate from whitelist. We already tested all the functions there in SQL queries. We can create a new JIRA to add it back and handle small numerical differences, but it should be orthogonal to this PR.

Merged build triggered.

Merged build started.

Test build #44595 has started for PR 9003 at commit ff363cc.

Test build #44595 has finished for PR 9003 at commit ff363cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * case class Variance(child: Expression,\n  * case class VarianceSamp(child: Expression,\n  * case class VariancePop(child: Expression,\n  * case class Skewness(child: Expression,\n  * case class Kurtosis(child: Expression,\n  * case class Kurtosis(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Skewness(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class Variance(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VariancePop(child: Expression) extends UnaryExpression with AggregateExpression \n  * case class VarianceSamp(child: Expression) extends UnaryExpression with AggregateExpression \n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44595/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #44611 has started for PR 9003 at commit f49ce5c.

Test build #44611 has finished for PR 9003 at commit f49ce5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * abstract class CentralMomentAgg(child: Expression) extends ImperativeAggregate with Serializable \n  * case class Variance(child: Expression,\n  * case class VarianceSamp(child: Expression,\n  * case class VariancePop(child: Expression,\n  * case class Skewness(child: Expression,\n  * case class Kurtosis(child: Expression,\n  * case class Kurtosis(child: Expression) extends UnaryExpression with AggregateExpression1 \n  * case class Skewness(child: Expression) extends UnaryExpression with AggregateExpression1 \n  * case class Variance(child: Expression) extends UnaryExpression with AggregateExpression1 \n  * case class VariancePop(child: Expression) extends UnaryExpression with AggregateExpression1 \n  * case class VarianceSamp(child: Expression) extends UnaryExpression with AggregateExpression1 \n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44611/
Test PASSed.

Merge into master. Thanks! @JihongMA @sethah Could you send a PR to replace Stddev implementation using CentralMomentAgg? I ran the following and the difference is significant:
val df = sqlContext.range(100000000)
df.select(var_samp("id")).show();
df.select(stddev_samp("id")).show()

Thanks @mengxr , I will send a PR for Stddev.


MINGW: Add missing directories to searched paths for mingw installs

This adds the usr/bin paths for MINGW_DEFAULT_PATHS. Without these paths xgettext is not found on my system.
Contributor Checklist:

[ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
[x] I have updated CHANGES.txt (and read the README.rst)
[ ] I have updated the appropriate documentation

Seems reasonable to me. Don't have an appropriate platform to check on. We have ongoing problems "guessing" paths of things on Windows, where they don't go into standard locations.

Hmmm, this has broken something in the Python 3.6 Windows build (which is provisioned with VS 2017 and Windows Server 2016).  Sometimes these are "not our fault", but should be investigated - the change in question shouldn't be able to have this effect.
https://ci.appveyor.com/project/SCons/scons/builds/47778467/job/yjs4sxhu9130rfex

Maybe this is the moment to reconcile the problem mentioned here:
https://github.com/SCons/scons/blob/e141cd3288ece58340a1a9e5d99a8c4f810366a9/SCons/Tool/mingw.py#L44
Namely that there's a list of search paths, used for slightly differing purposes, kept in two places, one in the platform code, one in the tool.

msys64\mingw64\bin would work as well. The binary is both in msys64\mingw64\bin and msys64\usr\bin. So updating the list to the one in Tool/mingw.py would work.

Merged! Thanks for the PR!!


functions predeploy error: Command terminated with non-zero exit code 2

I am trying to deploy the firebase function with this command
firebase deploy or firebase deploy --only functions
and predeploy error occurs which shown in image

Expected behavior
 function deployed

Actual behavior
  Error occured

How can I solve this error ? Can anyone give the solution or idea to solve this problem ? Thanks

Solved


can't access https://api.bintray.com/packages/jetbrains/intellij-plugin-service/intellij-plugin-verifier/versions/_latest (403)

@tbm98, thanks for reporting. The issue was caused by the Bintray outage: http://status.sdkman.io/incidents/fch98s3l5z3r?u=r7g886z3jjdm
It's back online again. Anyway, we've switched to the Space Packages with 890c09f commit, so since the next release, we'll not depend on Bintray regarding the Plugin Verifier.

Thank you :D


Stream filter migration used pipeline name instead of UUID

To truly address this we are going to add 'DocRef' as a type to the Stroom Query API


fix individual PRs being created that belong in the group

fixes #8234
I think the situation is:

A group PR exists with a subset of dependencies
During the next scheduled run, Dependabot kicks off a group rebase and a normal scheduled job
The scheduled job adds all of the dependencies in the existing PR to the handled group

It falls back into the individual PR logic and begins processing dependencies that should be in the group, but happen to not be at this time because there were no updates when the job that created it ran
One of the dependencies that isn't in the group yet but should be has an update, so an individual PR is created for it

The rebase job creates a PR which supersedes the previous grouped PR because it added the new dependency to it
The individual PR also gets superseded because a newer PR was created that contained a superset of its dependencies (1 in this case)

The complication here is if update-types is used, we are assuming it belongs in this group. Otherwise we'd have to create a checker and see if it should belong in it based on the versions available at the time the job is run.

Hi! #8234 is happening to us quite a bit - I don't suppose you know when you might have a chance to revisit this PR? :-)


Added GetComment to get comment context for a specific comment id

Definitely give this a good look over. First time messing with serialization stuff in Dart. The two unit tests I added passed.

Looks good!


Fix readme links

Fixes #1049
We refactored docs but did not update all the links in README. This PR cleans up the hyperlinks in the README

Thank you @caleb-johnson !

I should have caught this in the initial PR :)
This is fine to merge since it isn't a feature?

yes, let's merge it!


Issues in Bernstein-Vazirani

Describe the Issue
1a

The bit strings in are not expressed in the standard Qiskit order.
The notation for strings in is strange.
There is mention

1b

The use of 𝑥=1,2,… refers to the number represented by a string. In 1a we only referred to the string itself. Is there any need to refer to the number?
Reference to the 'hidden integer', despite other mentions being as 'hidden string'.
Oracle is not explained.
Hidden string is called a in the discussion of the classical method, and s elsewhere.

Expected Solution
I have fixed the issues in the fork for my course (see here). Perhaps some elements (or all) could be used in the textbook.

I believe this is fixed in a7ff6935a46ec250d773f893c38bcc5c066f3033


Support page banner for pages living in another library (and optionally inside folder)

There are no current plans to work on the page transformation UI. The preferred option for doing page transformation is using PnP PowerShell or .Net. Check out the guidance at https://aka.ms/sppnp-pagetransformation.
This issue will be closed but can be re-opened if we restart the work on the page transformation UI.


Multi-tower support on each GPU in MirroredStrategy and estimator

System information

TensorFlow version (you are using): 1.12
Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
Feature:
Add an argument like num_towers_per_gpu  in tf.contrib.distribute.MirroredStrategy to enable multi-tower computation on each GPU.
Current state:
Current tf.contrib.distribute.MirroredStrategy's design is one GPU one tower. It does not support mult-tower on one GPU. It has args devices, num_gpus, num_gpus_per_worker, cross_tower_ops, prefetch_on_device, auto_shard_dataset. We can only set the number of GPUs, and the mirrored strategy will assign one tower to each GPU.
Will this change the current api? How?
Yes. It will add a new argument like num_towers_per_gpu to tf.contrib.distribute.MirroredStrategy.
Who will benefit with this feature?
This feature can make it available to assign multiple towers on each GPU. It can maximize GPU utilization.
Any Other info.

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.

@ZhouYuChen,
Sorry for the delayed response. In the Tensorflow Version 2.x, since we use TF Keras predominantly and don't use Estimators much, can you please let us know if this Feature is still relevant? Thanks!

@rmothukuru
It is not relevant any more. Thanks!


fix(Toast): duration set to 0

🔗 Linked issue
Resolves #2665
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Toast's duration is disabled if the value is less or equal to 0
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

@sandros94 Can I close this since https://github.com/unovue/radix-vue/pull/1429 has been merged?

@sandros94 Can I close this since https://github.com/unovue/radix-vue/pull/1429 has been merged?

Yes, I didn't see the notification!


plasma 6

hey there,
thanks for your your with this applet.
Unfortunately the applet is not more so usefull without qt6 update.
can please update it? thanks

Changes for KF6 are done, you can test the changes in the Qt6 branch. I still want to make some minor changes before making a new official release.

@dschopf  thanks a lot for your work


Remaining time column sort lexicographically instead of using time sorting

Transmission Version:2.84 (14307), RPC: 15, WEB Control: 0.6 Beta(20130913) [as avail on qnap nas]
this is an example of the ordering when sorting on the remaining time column (real data, just exstracted):
12h 58m 1s
13m 4s
14d 3h 48m 48s
15h 41m 37s
that means instead of sorting on time (like the number of seconds) it sorts lexicographically, (so 12h is lower than 13m because 2 < 3), which is not the correct ordering you want

the same still applies for "WEB Control: 1.0 Beta(20141010)"

#46 Fixed by balonik.


I3: 4.21.1 -> 4.22, i3-gaps: drop

Description of changes
i3 has been updated to version 4.22, this version at long last merges the i3-gaps fork, which has been maintained in parallel for years. The former maintainer of i3-gaps has asked that package maintainers replace it with i3, as it will no longer be updated. i3-gaps users can safely move to upstream i3 without any changes in behavior, so I've replaced the i3-gaps package with an alias to i3.

Full release notes: https://github.com/i3/i3/blob/4.22/RELEASE-NOTES-4.22
Things done
i3 updated to 4.22, i3-gaps removed and replaced with an alias to i3 so peoples' configs aren't broken.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This should also affect the module documentation and removed module assertion for the i3 module, but I'm not sure whether or not a separate PR is warranted.

i3-gaps is still used in the polybar package which is now broken if aliases are disabled


Amp\Parallel\Worker\Internal\TaskSuccess is not serializabe

After I locally changed my amphp/parallel with https://github.com/amphp/parallel/pull/102 I see the following stacktrace:
string(298) "Uncaught Amp\Parallel\Sync\SerializationException in worker with message "The given data of type Amp\Parallel\Worker\Internal\TaskSuccess cannot be sent because it is not serializable." and code "0
"; use Amp\Parallel\Worker\TaskFailureException::getOriginalTrace() for the stack trace in the worker"
string(4086) "#0 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\parallel\lib\Sync\ChannelledStream.php(51): Amp\Parallel\Sync\ChannelParser->encode(Object(Amp\Parallel\Worker\Internal\TaskSuccess))
#1 [internal function](0): Amp\Parallel\Sync\ChannelledStream->Amp\Parallel\Sync\{closure}()
#2 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Coroutine.php(60): Generator->current()
#3 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\functions.php(66): Amp\Coroutine->__construct(Object(Generator))
#4 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\parallel\lib\Sync\ChannelledStream.php(55): Amp\call(Closure(C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\parallel\lib\Sync\ChannelledStream.php:49))
#5 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\parallel\lib\Sync\ChannelledSocket.php(47): Amp\Parallel\Sync\ChannelledStream->send(Object(Amp\Parallel\Worker\Internal\TaskSuccess))
#6 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\parallel\lib\Worker\TaskRunner.php(55): Amp\Parallel\Sync\ChannelledSocket->send(Object(Amp\Parallel\Worker\Internal\TaskSuccess))
#7 [internal function](0): Amp\Parallel\Worker\TaskRunner->execute()
#8 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Coroutine.php(105): Generator->send(Object(PhpCsFixer\Linter\TokenizerLintingResult))
#9 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Internal\Placeholder.php(130): Amp\Coroutine->Amp\{closure}(null, Object(Amp\Parallel\Worker\Internal\Job))
#10 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Coroutine.php(110): Amp\Coroutine->resolve(Object(Amp\Parallel\Worker\Internal\Job))
#11 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Internal\Placeholder.php(130): Amp\Coroutine->Amp\{closure}(null, " 1╔  O:32:"Amp\Parallel\Worker\Internal\Job":2:{s:36:" Amp\Parallel\Worker\Internal\
Job id";s:2:"cn";s:38:" Amp\Parallel\Worker\Internal\Job task";O:36:"PhpCsFixer\Linter\PooledLintFileTask":1:{s:42:" PhpCsFixer\Linter\PooledLintFileTask path";s:56:"C:\xampp7.1.4\htdocs\redaxo\redaxo\src\core\
lib\list.php";}}")
#12 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Deferred.php(45): class@anonymous C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Deferred.php0EE102D7->resolve(" 1╔  O:32:"Amp\Parallel\Worker\
Internal\Job":2:{s:36:" Amp\Parallel\Worker\Internal\Job id";s:2:"cn";s:38:" Amp\Parallel\Worker\Internal\Job task";O:36:"PhpCsFixer\Linter\PooledLintFileTask":1:{s:42:" PhpCsFixer\Linter\PooledLintFileTask pat
h";s:56:"C:\xampp7.1.4\htdocs\redaxo\redaxo\src\core\lib\list.php";}}")
#13 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\byte-stream\lib\ResourceInputStream.php(101): Amp\Deferred->resolve(" 1╔  O:32:"Amp\Parallel\Worker\Internal\Job":2:{s:36:" Amp\Parallel\Worker\Internal\Job id
";s:2:"cn";s:38:" Amp\Parallel\Worker\Internal\Job task";O:36:"PhpCsFixer\Linter\PooledLintFileTask":1:{s:42:" PhpCsFixer\Linter\PooledLintFileTask path";s:56:"C:\xampp7.1.4\htdocs\redaxo\redaxo\src\core\lib\li
st.php";}}")
#14 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Loop\NativeDriver.php(192): Amp\ByteStream\ResourceInputStream::Amp\ByteStream\{closure}("a", Resource(stream), null)
#15 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Loop\NativeDriver.php(97): Amp\Loop\NativeDriver->selectStreams(Array([Resource(stream)]), Array([]), -0.001)
#16 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Loop\Driver.php(134): Amp\Loop\NativeDriver->dispatch(true)
#17 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Loop\Driver.php(72): Amp\Loop\Driver->tick()
#18 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\Loop.php(84): Amp\Loop\Driver->run()
#19 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\functions.php(191): Amp\Loop::run(Closure(C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\amp\lib\functions.php:184))
#20 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\parallel\lib\Context\Internal\process-runner.php(98): Amp\Promise\wait(Object(Amp\Coroutine))
#21 C:\xampp7.1.4\htdocs\PHP-CS-Fixer\vendor\amphp\parallel\lib\Context\Internal\process-runner.php(116): Amp\Parallel\Context\Internal\{closure}()"

Do I read it correctly and the Exception is telling me that Amp\Parallel\Worker\Internal\TaskSuccess is not serializable..?
tested on Windows10x64
$ php -v
PHP 7.3.0 (cli) (built: Dec  6 2018 02:17:00) ( ZTS MSVC15 (Visual C++ 2017) x86 )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with blackfire v1.24.1~win-x32-zts73, https://blackfire.io, by Blackfire

"amphp/parallel": "^1.3",

TaskSuccess couldn't be serialized because the value given to the constructor could not be serialized. TaskSuccess is an internal construct for TaskRunner.

Would it make sense that TaskSuccess itself would throw when $result passed to it is not serializable?
That way the cause of the error would not be wrapped within TaskSuccess and there might be more obvious... wdyt?

I am playing arround with a few more existing projects in which I need/try to implant some async stuff within otherwise sync apps.
After doing some refactorings I get again and again to the topic of not serializable tasks/task-results, because e.g. the existing logic which I refactored passed Exceptions or SplFileInfo or similar objects arround.
In a first naive implementation I just refactored things like people are used to in sync context. I learn the hard way that a lot of php-src builtin stuff is not serializable by playing with it :-).
this made me think.. I guess it could make sense/would be helpful if e.g. amp would have a phpstan extension which would point me to my mistakes.. the current trial & error with huge stacktraces is rather painful and not efficient.

@staabm Sounds like a useful addition, do you want to open a separate issue about plugins for static analysis tools?
Do we still need better exception messages for non-serializable types?

Do we still need better exception messages for non-serializable types?

AFAIR amp improved on this front.

Sounds like a useful addition, do you want to open a separate issue about plugins for static analysis tools?

Opened a new issue on the amp repos

Thanks! I've transferred the issue to amphp/parallel, because it only affects amphp/parallel. https://github.com/amphp/parallel/issues/113


Attribute names in filters are still case-sensitive

When processing the filter parameter, attribute names are looked up in a case-sensitive way. For example if I query /scim/Users?filter=emails%20co%20nhumble it works, but /scim/Users?filter=Emails%20co%20nhumble gives an invalid filter error.
The operators are properly case-insensitive, but the attribute names are not.

Thanks. This should be fixed in V2 by #38 which, once reviewed & merged, will get back-ported to V1. We have some people off sick right now so it might take a day or three - please bear with us!

2.1.3 is now pushed - https://rubygems.org/gems/scimitar

1.3.3 back-port done - https://rubygems.org/gems/scimitar/versions/1.3.3


Version 6 is not installed

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v6 (for Elasticsearch 6.x)
====
I execute command
docker-compose up -d --build
But i got error
Step 23/28 : RUN go get gopkg.in/olivere/elastic.v6  ---> Running in 51279699b16d Removing intermediate container 51279699b16d  ---> 7ee7009f0dab Step 24/28 : RUN go get github.com/mailru/easyjson  ---> Running in 8e0e46af8e25 Removing intermediate container 8e0e46af8e25  ---> 576078d57fa8 Step 25/28 : RUN go install ./...  ---> Running in fb3b52ec19f7 ../../olivere/elastic/client.go:24:2: cannot find package "github.com/olivere/elastic/v7/config" in any of: 	/usr/local/go/src/github.com/olivere/elastic/v7/config (from $GOROOT) 	/go/src/github.com/olivere/elastic/v7/config (from $GOPATH) ../../olivere/elastic/bulk.go:15:2: cannot find package "github.com/olivere/elastic/v7/uritemplates" in any of: 	/usr/local/go/src/github.com/olivere/elastic/v7/uritemplates (from $GOROOT) 	/go/src/github.com/olivere/elastic/v7/uritemplates (from $GOPATH) ERROR: Service 'pusher' failed to build: The command '/bin/sh -c go install ./...' returned a non-zero code: 1
What`s wrong?

The import path is wrong. See here.

I install the package for version 6.
Why should I install version 7 packages?
github.com/olivere/elastic/v7/uritemplates
github.com/olivere/elastic/v7/config


WIP: Py3 fixup

I'll push changes here that make the test suite pass with 2.7 and 3.6.
The goal is to make the existing suite pass and then merge to master so all subsequent work and future tests are tested with both versions.

Passes with 2.7 and 3.6 now (fontval not tested because not installed). Please review and pull :)

#1108

https://travis-ci.org/googlefonts/fontbakery/builds/366217212
___________________________________ summary ____________________________________
  py27: commands succeeded
ERROR:   py36: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError("Failed to get version_info for python3.6: ERROR: ld.so: object 'prebuilt/custom_freetype/lib/libfreetype.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.\npyenv: python3.6: command not found\nERROR: ld.so: object 'prebuilt/custom_freetype/lib/libfreetype.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.\nERROR: ld.so: object 'prebuilt/custom_freetype/lib/libfreetype.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.\n\nThe `python3.6' command exists in these Python versions:\n  3.6\n  3.6.3\n\n", None)

Yes. This makes tests pass on 2 and 3 and sets up tox to test both by
default.
This means that all future/tests will be toxed in both, which saves double
efforts to port to py3 later.

Dayum. Fix soon.
Can you please add Travis to the check status on PRs? So it won't get lost.

Please try editing .travis.yml adding this:
language: python
  python:
    - "2.7"
    - "3.6"

This was merged together with my additional fixes to Travis at PR #1787
Thanks, @madig !


Create result extracts

Predecessors:

[ ] #17

Tasks:

[x] generate extracts for result:

[x] embedd result in few staves

[ ] highlight result

[ ] add ties between notes

remove ties from extract rendering (problems with ties from one to following line)

[ ] Revise pattern highlighting

Highlight only notes from pattern, instead of all notes inside the measure.


[RNAdam-67] Branch defuse.

Resolves #67. Removes defuse algorithms from the RNAdam core until they are ready for use. Defuse has been moved to a topic branch.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/RNAdam-prb/75/
Test PASSed.


Does the plugin support Dreame L20 Ultra

Time to upgrade my long served roborock, Dreame L20 seems to get better review those days so would like to give a try - I understand it can also connect to Mi Home but not sure our plugin still support it?

Unfortunately, the Dreame series uses a different set of methods and it's not implemented in this plugin yet :/

That's a pity but thanks for your reply!


60 set up codecov

New Feature:

integrated codecov to this repo

added codecov badge to README.md

Bugs on badge display. Working on it...


Fix broken link

I found broken link.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, @matsumana !


[Supplier] Initial slashing implementation

Summary
This PR introduces the initial implementation of Supplier slashing:

Adjusts proof parameters to align with the probabilistic proofs paper.
Adds comments on potential follow-up improvements and adjustments.
Implements Supplier slashing for invalid or missing proofs.
Unstakes a Supplier whose stake falls below the minimum due to slashing.

~1300LOC is auto-generated code
Issue
To enable permissionless demand, the protocol must discourage the submission of false or invalid claims.
As part of this, Suppliers should be penalized for failing to comply with the C&P life cycle rules.

#758

Type of change
Select one or more from the following:

[x] New feature, functionality or library
[x] Consensus breaking; add the consensus-breaking label if so. See #791 for details
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[ ] Documentation: make docusaurus_start; only needed if you make doc changes
[x] Unit Tests: make go_develop_and_test
[x] LocalNet E2E Tests: make test_e2e
[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

[x] I have tested my changes using the available tooling
[x] I have commented my code
[x] I have performed a self-review of my own code; both comments & source code
[ ] I create and reference any new tickets, if applicable
[x] I have left TODOs throughout the codebase, if applicable

@Olshansk
I added an unexpected change due to a conflict (cyclic dependency) resulting from merging main into this branch.
The ComputeUnitsToTokenMultiplier is now moved to the shared module to resolve a conflict.
The conflict itself is due to main using ProofRequirementForClaim from the proof module.
While in this branch, ProofRequirementForClaim needs the ComputeUnitsToTokenMultiplier (from tokenomics module) to check against the ProofRequirementThreshold which results in a cyclic dependency.


CANNOT OPEN APPS INSTALLED IN CHINESE

Apps with English names can open correctly, but when I try to open apps with Chinese names, nothing is done.
I have also tried renaming the apps but to no avail and the function run(LS) does not list the app either.

Hello, there...
Tell me following things to counter this issue

What version of windows you're using
Some examples of chinese apps

After renaming the app names, have you tried (update) function or (default) function, if not try and tell me what appears. It will be nice if you share review with screenshots.


Add RWS functionality

Since we've got a parachain slot the first most wanted functionality will be RWS and subscriptions.
One can stake some amount of XRT to make a subscription available. Then one must buy the subscription and put addresses to send transactions.
robonomics-interface must provide at least a way to send RWS transactions (see rws in extrinsics)
The steps are following:

Stake some XRT to issue subscriptions Extrinsics -> staking -> bond

Check there are available subscriptions Chain state -> rws -> auctionQueue()

Make a bid Extrinsics -> rws -> bid

Add devices Extrinsics -> rws -> setDevice (try an account without balance)

Try send an extrinsic from the device Extrinsics -> rws -> call

The least functionality must be rws->call implementation in the library

Implemented in PR #18


ldap connection problem behind a firewall

I've got the following problem to connect to LDAP-Server behind a firewall.
After first start everything works fine. After a while the authentication doesn't work anymore.
Between the server and the ldap server there is a firewall closing the ldap connection after a time of no data transfer.
In the error.log file i'll see this messages:

2014/07/28 09:02:10 [info] 14109#0: http_auth_ldap:
ldap_result() failed (-1: Can't contact LDAP server)

and some time before

2014/07/28 09:00:31 [info] 8020#0: http_auth_ldap:
Request timed out (state=1) (110: Connection timed out)

NGINX Version:

nginx -V
nginx version: nginx/1.6.0
TLS SNI support enabled
configure arguments: --prefix=/opt/nginx-1.6.0
            --with-http_ssl_module
            --with-http_gzip_static_module
            --with-http_stub_status_module
            --with-cc-opt=-Wno-error
            --add-module=/tmp/nginx/nginx-auth-ldap-master/

NGINX-Config:

http {
  ldap_server ldap1 {
    url ldaps://ldapserver.domain.com/DC=domain,DC=com?sAMAccountName?
                  sub?(objectClass=person);
      binddn "CN=ldap-user,OU=Users,DC=domain,DC=com";
      group_attribute uniquemember;
      group_attribute_is_dn on;
      binddn_passwd password;
      require valid_user;

    }
    auth_ldap_cache_enabled on;
    auth_ldap_cache_expiration_time 10000;
    auth_ldap_cache_size 1000;
}
    server {
                listen       <IP_ADDRESS>:80;
                server_name  nginx.domain.com;
                rewrite ^ https://nginx.domain.com/ permanent;
           }
    server {
                listen       <IP_ADDRESS>:443;
                server_name  nginx.domain.com;
                root /www/nginx

                satisfy any;

                allow <IP_ADDRESS>/16;
                allow <IP_ADDRESS>;

                # LDAP authentication
                auth_ldap "LDAP-Auth";
                auth_ldap_servers ldap1;

                # SSL
                ssl on;
                ssl_protocols        SSLv3 TLSv1;
                ssl_ciphers          HIGH:!ADH:!MD5;

                ssl_certificate       /certs/nginx.domain.com.crt;
                ssl_certificate_key   /certs/nginx.domain.com.key;

                error_page 404 /404.html;
                access_log  /logs/nginx/access.log main;
                error_log   /logs/nginx/error.log;
                rewrite_log on;
            }

I submitted a patch for issue #80 so you can have proper error messages in the logs and diagnose the issue yourself.


How to make a drive that will not save back to the original location?

How to make a drive that will not save back to the original location? I would like to make a copy of the original location but not wish to save it back. Thanks.

In /usr/local/bin/log2zram, comment out the call to mergeOverlay so that it looks like:
# mergeOverlay >>${ZLOG} 2>&1 || exit 1

It uses a mergeOverlay tool https://github.com/kmxz/overlayfs-tools which as far as I know is the only tool for overlayfs.
Apart from https://github.com/https://github.com/amir73il/overlayfs/wiki/Snapshots-HOWTO/overlayfs/wiki/Snapshots-HOWTO
So as roger said systemctl edit zram-config and stop the ExecStop=/usr/local/bin/zram-config stop from being run by editing it.
I guess create a snapshot that you can mount elsewhere but apart from knowing of its existence that is the limit of my snapshot knowledge.
I was always hoping amir73il was going to do a merge down from lastest snapshot so you could rotate down through a history.
I would have a read and see if it will provide what you need.
Fork the project or just copy and maybe create a merge elsewhere version?


"the trait bound ... is not satisfied" should point at the offending field

Compiling this code:
#[derive(Document)]
struct Foo {
  bar: Bar,
}

struct Bar;

... will throw the trait bound ... is not satisfied at Document - it'd be nice if we pointed out bar: Bar instead, as does e.g. Serde.

Closing as inactionable; Serde's example yields a pretty nice error message, because Serde generates self.bar.serialize(...) underneath, which the compiler simply pretty-prints in a nice way.


Create Book.md

Hi @ingridbruch-epam
Please let me know if you need someone on the Glue team to review this PR and I'll show you how to assign.
All the best,
James.


Perma Crashes after Char Created.

crash-2024-03-18-19-05-39.log
Steps to reproduce
After Char got created, ill can set my points, and when it normally goes out of the vault the game crashes.
Environment

OS: Windows 11
RTX 3080 / 32GB RAM / AMD Ryzen 7800x3d

Contact:
Please list your discord name if you are in our discord:
TimeZzToK1LL
Sorry for Bad English

Have you made an exception with your antivirus?

crash-2024-03-18-19-05-39-AUTOSCAN.md

I got no ant virus, or is Firewall exception what this mean ? ^^

Please make sure you are saying yes to this prompt and not clicking through without reviewing.

crash-2024-03-18-19-36-48.log


Scaling large yRange values

I'm using react-vis 1.7.4
My yRange is [199740, 200400] and I'm just getting a wall of bars w/ no relative difference because everything is being scaled compared to a yRange of [0, 200400]
https://www.webpackbin.com/bins/-Ksoencaj2nvtlGMdKtA
How to fix this? I tried declaring the yRange but that just made the entire graph disappear.
Thanks for your help...

Hey @Falieson
You need to modify your example just a little bit to make it work. First you need to be using yDomain, not yRange. domain refers to the scope of the values that are coming in, and range refers to the pixels being output. Secondly there is a weird quirk with modifying where the barChart "starts", in that you need to provide a "baseValue". So all told your chart should look like this
 return (
      <XYPlot
        height={480}
        xType='time'
        width={500}
yDomain={[yRange.min, yRange.max]}
yBaseValue={yRange.min}
      >
        <HorizontalGridLines />
        <VerticalBarSeries data={xyData} />
        <XAxis />
        <YAxis />
      </XYPlot>
    )

That said, I'm a frequent contributor of this library and that took me quite a while to figure out. I going to open a PR to remove the baseValue property because it seems like it is redundant to domain.

Should now be resolved in 1.7.5!

Thank you!


Move comments to a Conversation tab

User testing found that the Comments section interfered with the UI too
much, and people didn't know what it was for.
Also, when saving a comment does the guide get saved or not? This is
confusing for the user.

LGTM


Convention to support more file extensions

Add .html.sbn extension; Add .cs.sbn with csharp support.

Please note that I'm not sure if this is the right way. I just played with it and tested once locally. Perhaps there is a simpler and better way to support more extensions.

My apologize, I was not getting notifications for this repo. I have changed quite a few files today, so I won't be able to merge it. Feel free to make a PR again, sorry!


Add Grpc support for the Inference Batcher API

/kind feature
Describe the solution you'd like
Grpc is way faster than Rest see for example. It would be nice to have support for Grpc for the Inference Batcher API.

/assign


multi-language abstract?

have a front piece that invites people to translate.

README_es , check the knitr github repo.

Done.


add a couple of VFile related modules

https://github.com/sindresorhus/vfile-to-eslint
https://github.com/sindresorhus/vfile-reporter-pretty

Current coverage is 100% (diff: 100%)

No coverage report found for master at f3d1305.

Powered by Codecov. Last update f3d1305...912cb6a


Getting false on isSupported function

Hi,
I am getting false value after configure all the thing in android
Do the changes in AndroidMenifest.xml

Added app_restrictions.xml

<restriction
    android:key="downloadOnCellular"
    android:title="@string/download_on_cell_title"
    android:restrictionType="bool"
    android:description="@string/download_on_cell_description"
    android:defaultValue="true" />

Can anybody help me using version 1.0.5

Hi,
getManifestRestrictions() is working in the place of getApplicationRestrictions()
Could you please let me know what is the issue?

Working going to close it.

MobileDeviceManager.isSupported() false response

@manoj2166 how you solve it?


Test failing after adding maven-repair to repository

Failed tests:
  TestAbstractStep.testGetPomOnProjectWithSubModule:116
Expected: is "/tmp/test_get_pom_project_with_submodule2531020899353941363/repairnator/repairnator/pom.xml"
     but: was "/tmp/test_get_pom_project_with_submodule2531020899353941363/repairnator/maven-repair/pom.xml"

This test most likely fails because we now effectively have two projects, each with submodules and it simply finds the first one, rather than continue looking.
I would claim that this is most likely not a problem and that a solution would be to simply @Ignore the test while maven-repair remains in the repo.

per our discussion, getPom should throw an exception if there are several matching pom.xml in the repo. In addition, we could create a method getPoms() which returns a list of subpoms in fixed, alphabetical order.

per our discussion, getPom should throw an exception if there are several matching pom.xml in the repo.

@monperrus but I think that if this is done, repairnator will not consider multi-module projects anymore, since they have more than one pom.xml. My point is: the implementation to solve the issue can't be simply counting pom.xml files in the repo and throwing an exception if there is more than one. I think that is necessary to do an analysis on folder depth, starting from the root. If the root has one pom, this is the good one. Otherwise, the pom.xml should be searched in the first folder level, and then counting them, etc.

Agreed with Fernanda. Actually for me the test was good but should have contained a specific commit ID to checkout.
So I'd say that now we should have to test:

the same one with a  checkout of a commit before adding maven-repair
a new one with a checkout of latest commit, with an assert on maven-repair/pom.xml: it's the first one in alphabetical order, so it's good.

My 2 cents.


Plugins on macOS High Sierra doesn't recognize that npm is installed

$ which npm
/usr/local/bin/npm
$ npm --version
5.6.0

Terminus Version 1.0.0-alpha.44 (1.0.0-alpha.44.283) was installed via dmg.

related to #10?

indeed it is.


New Diacritics Component for Inputs

Displays a list of vocabularies that a user can select and then click on buttons to enter special characters into the input field.
Note Only the InputLiteral component is currently supported, the InputLookup based components will not work with the current strategy.

Fixes #1805

Another gotcha. Steps to reproduce:

Open an Abbreviated title.
Click +Add.
Click A-umlat to open the keyboard.
Select a character set and click on some characters.
Click X to close the keyboard.
Click Edit next to the entered characters.
Click inside the input box.
Click A-umlat to open the keyboad.

Expected result:
The keyboard opens.
Actual result:
It exits edit mode (the characters are blue and the input is cleared).

Tiny tweaks and a gotcha.
Steps to reproduce:
1. Open an Abbreviated title.

2. Click +Add.

3. Click A-umlat to open the keyboard.

4. Select the character set and enter some characters.

5. Click X to close the keyboard.

6. Click Edit next to the characters.

7. Click A-umlat to open the keyboard.

8. Enter some more characters.

9. Click X to close the keyboard.

Expected result:
Characters appear in blue and input is cleared.
Actual result:
Characters appear in blue and input contains the originally entered characters.

This is now fixed with the latest commit.

Verified that is fixed.


Note about Copay / Bitcore and BIP45 and lexicographic ordering

Bitcore lexicographically sorts the public keys before generating the multisig address.
Compare
bitcoin-qt testnet multisig 2N8oVq7BpYdVSUwgsyg7vv546K3wkUzbi5E
bitcore testnet multisig 2N2uX2sR1BtcJVNyCJAfHTWqZh4TWwRdze3
Bitcoin-qt does not reorder public keys lexicographically, but bitcore does.
A note should be added on the page about this to avoid confusion. Possibly also an option to automatically show which order corresponds to the lexicographic ordering.

See https://github.com/iancoleman/multisig/commit/d7884f85b1367d25d795a4f2227b8c1af7687788


Async Project Structure Doc

Hi,
Thank you for the document page, I've found it very help. I am stuck on making "getClient" async/await. Anyway someone can show an example of final index.js file in the db folder from : https://node-postgres.com/guides/project-structure with the logging and route example written in async/await? in other words, update this example : https://node-postgres.com/guides/async-express with "getClient." Thanks in advance!

Thanks for your feedback! I'll update the docs tonight.


Automatically figure out which driver to use

If it’s v1.8 or v1.9, Flexvolume Plugin would be deployed.
No configuration needed for 1.8 (because we can detect the location using an alpha API).
User will need to set the FLEXVOLUME_DIR manually in the yaml file for 1.9.
If it’s v1.10+, CSI would be deployed. No configuration needed.
The choice can be overridden in the command line.
If CSI driver has been chosen, the built-in Longhorn provisioner must be disabled.
If user choose to override the default choice, he will need to
provide additional command line parameter to longhorn manager in
addition to the longhorn driver deployer.

Test on v1.10+
# kubectl version --short
Server Version: v1.10.1

# kubectl get all -n longhorn-system
NAME                                          READY     STATUS    RESTARTS   AGE
pod/csi-attacher-0                            1/1       Running   0          1m
pod/csi-provisioner-0                         1/1       Running   0          1m
pod/engine-image-ei-57b85e25-mp4r5            1/1       Running   0          1m
pod/longhorn-csi-plugin-6859d                 2/2       Running   3          1m
pod/longhorn-driver-deployer-866f9d5b-897v5   1/1       Running   0          1m
pod/longhorn-manager-6vf48                    1/1       Running   0          1m
pod/longhorn-ui-786d545fb6-b2gch              1/1       Running   0          1m
...
...

# integration test
+ py.test -v . -x -s -k test_csi --enable-csi-test
============================= test session starts ==============================
platform linux2 -- Python 2.7.14, pytest-2.9.2, py-1.5.4, pluggy-0.3.1 -- /usr/local/bin/python
cachedir: .cache
rootdir: /integration/tests, inifile:
collecting ... collected 22 items

test_csi.py::test_csi_volume_mount PASSED
test_csi.py::test_csi_volume_io PASSED

Test on v1.8
# kubectl version --short
Server Version: v1.8.12-gke.1

# kubectl get all -n longhorn-system
NAME                                           READY     STATUS    RESTARTS   AGE
po/engine-image-ei-57b85e25-9lnmw              1/1       Running   0          1m
po/engine-image-ei-57b85e25-ktqkl              1/1       Running   0          1m
po/longhorn-driver-deployer-59846ff8bc-7kt96   1/1       Running   0          1m
po/longhorn-flexvolume-driver-674z2            1/1       Running   0          32s
po/longhorn-flexvolume-driver-ddqtq            1/1       Running   0          32s
po/longhorn-manager-tstvq                      1/1       Running   0          1m
po/longhorn-manager-wbjsp                      1/1       Running   0          1m
po/longhorn-ui-85bc5b8f8f-fbbw6                1/1       Running   0          1m
...
...

# integration test
+ py.test -v . -x -s -k test_flexvolume
============================= test session starts ==============================
platform linux2 -- Python 2.7.14, pytest-2.9.2, py-1.5.4, pluggy-0.3.1 -- /usr/local/bin/python
cachedir: .cache
rootdir: /integration/tests, inifile:
collecting ... collected 22 items

test_flexvolume.py::test_dynamic_volume_mount PASSED
test_flexvolume.py::test_dynamic_volume_params PASSED
test_flexvolume.py::test_dynamic_volume_io PASSED
test_flexvolume.py::test_static_volume_mount PASSED
test_flexvolume.py::test_static_volume_io PASSED

If it can be merged, then we should update the images and yaml files, just refer to:
# RBAC
https://github.com/niusmallnan/longhorn-csi/blob/master/deploy/longhorn/longhorn.yaml#L12-L40

# driver-deployer
https://github.com/niusmallnan/longhorn-csi/blob/master/deploy/longhorn/longhorn.yaml#L291-L336

LGTM. But we have a test failure for test_csi.py::test_csi_volume_io on one cluster. @TehTotalPwnage is working on it.
Error message:
        pod_name = 'volume-csi-io-test-2'
        create_pod(api, pod_name, csi_pvc_name)
        wait_pod_ready(api, pod_name)

        read_command = [
            '/bin/sh',
            '-c',
            'cat /data/test']
        resp = stream(
            api.connect_get_namespaced_pod_exec, pod_name, 'default',
            command=read_command,
            stderr=True, stdin=False,
            stdout=True, tty=False)
>       assert resp == test_content
E       assert "cat: can't o...r directory\n" == 'longhorn'
E         - cat: can't open '/data/test': No such file or directory
E         + longhorn

I cannot reproduce this in other two clusters, so I will go ahead and merge this PR first.
If there is a real issue, we will fix it later.


Pull Requests!

Add some notes about starting clean

Sorry I didn't get to this sooner! Pull Request ought to be reviewed by collaborators before being merged in. Thanks for writing this talk, @gnarf !


Updated "Oracle Autonomous Database Shared" to the new name "Oracle A…

…utonomous Database Serverless"
Edited the software components names and the development or build time services and libraries.
Other minor edits.

@rhondaday You need to sign the Oracle Contributor Agreement, links in the PR above on how to do that.

Hi Andy,
I'm totally lost. Can we zoom?
Rhonda Day
User Assistance Developer
Database Documentation

From: Andy Tael @.>
Sent: Wednesday, June 28, 2023 11:49 AM
To: oracle/microservices-datadriven @.>
Cc: Rhonda Day @.>; Mention @.>
Subject: [External] : Re: [oracle/microservices-datadriven] Updated "Oracle Autonomous Database Shared" to the new name "Oracle A… (PR #682)
@rhondadayhttps://urldefense.com/v3/__https://github.com/rhondaday__;!!ACWV5N9M2RV99hQ!JaY2ylmxysTBQWAXeU8vWe6lGodfhAdf5ym28EKXU9iywvuy4wEZwvddtSjJFf5-EL2WNdOnH6BncglkHW9MNucHoQ$ You need to sign the Oracle Contributor Agreement, links in the PR above on how to do that.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/oracle/microservices-datadriven/pull/682*issuecomment-1611682497__;Iw!!ACWV5N9M2RV99hQ!JaY2ylmxysTBQWAXeU8vWe6lGodfhAdf5ym28EKXU9iywvuy4wEZwvddtSjJFf5-EL2WNdOnH6BncglkHW9DiLJXtg$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A6NDSWW5C7B5LGHWWYQAJHLXNRG75ANCNFSM6AAAAAAZXIJAUU__;!!ACWV5N9M2RV99hQ!JaY2ylmxysTBQWAXeU8vWe6lGodfhAdf5ym28EKXU9iywvuy4wEZwvddtSjJFf5-EL2WNdOnH6BncglkHW-XnUpcdQ$.
You are receiving this because you were mentioned.Message ID: @.***>


Support 1.6.14

Tests pass on 1.6.14 so not much reason not to support it for the time being. Please do make a git tag :smile:

Docs won't generate on 1.6.14 unless uses of addr are replaced with unsafeAddr. Isn't that feature deprecated?

Ugh more work is required, seemed so easy to add 1.6.14 support.

If it's not a deprecated feature, unsafeAddr can be used in place of addr. If not, a few when blocks can be used.

Yea I knew how to fix it of course, I just didnt want to have to go through and do it :stuck_out_tongue:

The only things that need to be updated now are the README to remove the inaccurate bit about 2.0.0 support, and runnableExamples, the latter of which could have comments explaining unsafeAddr being required pre-2.0.0


New Artifact: windows-certificate-from-keyvault

Added a new artifact to install a certificate from an Azure Key Vault

@gregpakes,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

I recently ran into a need for this, too. Any chance this might be merged?


Autogen suddenly asks for (OpenAI)API-key, whereas I'm using Azure OpenAI

Hi,
I was testing with some scripts yesterday and everything works fine. Now I upgraded Autogen and my scripts suddenly ask for the OpenAI key. I'm probably missing something here, but can't find it. Don't want to use the openai.api_key but the azure one. Thanks for your input!
--- error ---
raise openai.error.AuthenticationError(
openai.error.AuthenticationError: No API key provided. You can set your API key in code using 'openai.api_key = ', or you can set the environment variable OPENAI_API_KEY=). If your API key is stored in a file, you can point the openai module at it with 'openai.api_key_path = '. You can generate API keys in the OpenAI web interface. See https://platform.openai.com/account/api-keys for details.
---example script, OAI_CONFIG_LIST contains only Azure Open AI entries ---
import autogen
config_list = autogen.config_list_from_json(
"OAI_CONFIG_LIST",
file_location=".",
filter_dict={
"model": {
"gpt-4"
}
}
)
Setting parameters for the assistant agent
llm_config={
"request_timeout": 600,
"seed": 42,
"config_list": config_list,
"temperature": 0,
}
Creating an instance of AssistantAgent
assistant = autogen.AssistantAgent(
name="assistant",
llm_config=llm_config,
)
Creating an instance of UserProxyAgent
user_proxy = autogen.UserProxyAgent(
name="user_proxy",
human_input_mode="TERMINATE",
max_consecutive_auto_reply=10,
is_termination_msg=lambda x: x.get("content", "").rstrip().endswith("TERMINATE"),
code_execution_config={"work_dir": "web"},
llm_config=llm_config,
system_message="""Reply TERMINATE if the task has been solved at full satisfaction.
Otherwise, reply CONTINUE, or the reason why the task is not solved yet."""
)
--- my OAI_CONFIG_LIST, not changed since working version, yesterday ---
[
{
"model": "gpt-4",
"api_key": "",
"api_base": "",
"api_type": "azure",
"api_version": "2023-07-01-preview"
}
]

Thanks for the detailed report. I have a few follow-up questions:

Did you upgrade pyautogen, or pull the latest from github? We've pushed a few changes recently, and I want to rule them in-or-out as causes.
If you did upgrade pyautogen, does the console show any warnings? We added a bunch more logging in the recent pushes

Thanks,

I have almost same issue:     raise self.handle_error_response( openai.error.InvalidRequestError: The API deployment for this resource does not exist. If you created the deployment within the last 5 minutes, please wait a moment andocale=fr_FR https://www.

I have almost same issue: raise self.handle_error_response( openai.error.InvalidRequestError: The API deployment for this resource does not exist. If you created the deployment within the last 5 minutes, please wait a moment andocale=fr_FR https://www.

Does the same config work when you use openai.ChatCompletion.create directly?

Hello, same problem.
I just starting today. I m only using OPEN AI
[autogen.oai.completion: 10-12 23:03:57] {216} INFO - retrying in 10 seconds... Traceback (most recent call last):   File "C:\Python311\Lib\site-packages\openai\api_requestor.py", line 606, in request_raw     result = _thread_context.session.request(              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Python311\Lib\site-packages\requests\sessions.py", line 575, in request     prep = self.prepare_request(req)            ^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Python311\Lib\site-packages\requests\sessions.py", line 486, in prepare_request     p.prepare(   File "C:\Python311\Lib\site-packages\requests\models.py", line 368, in prepare     self.prepare_url(url, params)   File "C:\Python311\Lib\site-packages\requests\models.py", line 439, in prepare_url     raise MissingSchema( requests.exceptions.MissingSchema: Invalid URL '<your Azure OpenAI API base here>/openai/deployments/gpt-35-turbo/chat/completions?api-version=2023-07-01-preview': No scheme supplied. Perhaps you meant https://<your Azure OpenAI API base here>/openai/deployments/gpt-35-turbo/chat/completions?api-version=2023-07-01-preview?

Hello, same problem. I just starting today. I m only using OPEN AI
[autogen.oai.completion: 10-12 23:03:57] {216} INFO - retrying in 10 seconds... Traceback (most recent call last): File "C:\Python311\Lib\site-packages\openai\api_requestor.py", line 606, in request_raw result = _thread_context.session.request( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Python311\Lib\site-packages\requests\sessions.py", line 575, in request prep = self.prepare_request(req) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Python311\Lib\site-packages\requests\sessions.py", line 486, in prepare_request p.prepare( File "C:\Python311\Lib\site-packages\requests\models.py", line 368, in prepare self.prepare_url(url, params) File "C:\Python311\Lib\site-packages\requests\models.py", line 439, in prepare_url raise MissingSchema( requests.exceptions.MissingSchema: Invalid URL '<your Azure OpenAI API base here>/openai/deployments/gpt-35-turbo/chat/completions?api-version=2023-07-01-preview': No scheme supplied. Perhaps you meant https://<your Azure OpenAI API base here>/openai/deployments/gpt-35-turbo/chat/completions?api-version=2023-07-01-preview?

It looks that api_base is missing in the config.

same issue with me,
I just very simple config:
config_list = [
Azure OpenAI API endpoint for gpt-3.5-turbo
{
    'model': 'gpt-3.5-turbo',
    'api_key': 'somekey',
}

]
config_list = [
Azure OpenAI API endpoint for gpt-3.5-turbo
{
    'model': 'gpt-3.5-turbo',
    'api_key': 'sk-key',
}

]
llm_config={
    "config_list": config_list,  # a list of OpenAI API configurations
    "seed": 42,  # seed for caching and reproducibility
    "temperature": 0,
},

then create a coder:
create an AssistantAgent named "coder"
coder = autogen.AssistantAgent(
name="coder",
llm_config = llm_config
)
it is not working!
try to print the config of coder: print(coder.llm_config), it show the default config :  {'model': 'gpt-4'}

I change the config list to
config_list = [
{
'model': 'gpt-3.5-turbo',
'api_key': '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',
'api_base': 'https://api.openai.com/v1/chat/completions',
'api_type': 'azure',
'api_version': '2023-06-01-preview',
}
]
Still not work for me

I noticed that you originally included your public key in your email update, which is now removed—good call for security reasons.
It seems you're not entirely clear on how to integrate Azure with OpenAI. Specifically, your 'api_base' URL is pointing to OpenAI's website, which won't work. Instead, it should point to your Azure OpenAI resource, formatted like https://{your-resource-name}.openai.azure.com/openai/....
For further clarification, consult Microsoft Azure's OpenAI documentation: [Azure OpenAI Reference]https://learn.microsoft.com/en-us/azure/ai-services/openai/reference

Hi I fix my issue,
just change the code to llm_config=llm_config1, when you instance of AssistantAgent.
maybe it is because python version,  that llm_config=llm_config do not work. you have to define the dict by different name.

I have debugged it. the main issue was Azure OpenAI deployment. I changed to a new instance then with new instance and new key previous code without any change worked perfectly.


add unauthenticated special role for unauthenticated users

That would allow to configure individual books to be publicly viewable or even editable (not sure about drafts, as there is no real user identity and garbage drafts could accumulate). But at least view should be selectable to allow public viewing in a single book.
Why use the role system for this? It adds not another mechanism into the authentication system, but builds on the existing one.
It also allows the removal of the public-viewing setting, which currently also acts as a second authorization information source. With an unauthenticated role it just means view for the unauthenticated user role and could be managed from the role settings page together with all other authorization settings.

Hi @squiddle, Thanks for the suggestion. This should be fairly simple since that's exactly how the public permissions are currently handled! The system just hides the public role from any view.
If you view the roles table in your database you'll see a public role. Changing the hidden value from 1 to 0 will make it show up. Things do get funky when trying to edit as a public member though since they're not technically a user.

Hey @ssddanbrown , any idea if this enhancement is gonna be on the next release?

@riorii Yes, it will be. Although next release may not be for a small while.


Conversion to tflite fails for a specific network

I applied QAT to a model and the final conversion to tflite fails with the following error messages:
torch.jit._trace.TracingCheckError: Tracing failed sanity checks!
ERROR: Tensor-valued Constant nodes differed in value across invocations. This often indicates that the tracer has encountered untraceable code.
Node:
%data_1 : Tensor = prim::Constantvalue= # out-2022-01-17-08-27-39/detector_qat.py:259:0
Source Location:
out-2022-01-17-08-27-39/detector_qat.py(259): forward
/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py(709): _slow_forward
/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py(725): _call_impl
/usr/local/lib/python3.6/dist-packages/torch/jit/_trace.py(940): trace_module
/usr/local/lib/python3.6/dist-packages/torch/jit/_trace.py(742): trace
/usr/local/lib/python3.6/dist-packages/TinyNeuralNetwork-0.1.0+e35ef92faba445830bb6156c916b1e838801c07e-py3.6.egg/tinynn/converter/base.py(97): init_jit_graph
/usr/local/lib/python3.6/dist-packages/TinyNeuralNetwork-0.1.0+e35ef92faba445830bb6156c916b1e838801c07e-py3.6.egg/tinynn/converter/base.py(281): convert
main.py(133): main
main.py(193):
Comparison exception:   promoteTypes with quantized numbers is not handled yet; figure out what the correct rules should be, offending types: QUInt8 Float
Please refer to the attachment. Thanks.
test.zip

It's a known issue that in some legacy versions of PyTorch, the following code won't be traced.
class Model(nn.Module):
    def forward(self, x):
        // ...
        cat_10 = self.float_functional_simple_9.cat([getitem_15, backbone_stage3_5_branch_main_7], 1)
        data_9 = cat_10.data
        size_9 = data_9.size()
        // ...

but it will work when you write like this.
```py
class Model(nn.Module):
    def forward(self, x):
        // ...
        cat_10 = self.float_functional_simple_9.cat([getitem_15, backbone_stage3_5_branch_main_7], 1)
        size_9 = cat_10.size()
        // ...

We will work on our code generator and tracer to get rid of the .data calls.

@liamsun2019 We pushed a fix for the issue and the given model can be converted locally. Would you please try to remove the existing model description file and try again?

Big thanks. I will try it out ASAP.

I'll close this one for now. If you disagree, please feel free to reopen it.

No problem，thanks.

The converted tflite model cannot pass benchmark test:
./linux_x86-64_benchmark_model --graph=qat_model.tflite
STARTING!
Log parameter values verbosely: [0]
Graph: [qat_model.tflite]
Loaded model qat_model.tflite
ERROR: tensorflow/lite/kernels/concatenation.cc:179 t->params.scale != output->params.scale (3 !=<PHONE_NUMBER>)
ERROR: Node number 12 (CONCATENATION) failed to prepare.
Failed to allocate tensors!
Benchmarking failed.
Similar errors happen when doing inference with the tflite model if invoking interpreter.allocate_tensors()

@liamsun2019 This is because of something else. I've discussed with you through online messages. Next time, please open a new issue for that. Thanks.


_draw() function called twice on start for TileMap node

Godot version
4.0 beta 7
System information
Windows 10
Issue description
_draw() Function in TileMap node loops 2 time after applied the TileSet
Steps to reproduce
apply TileSet in TileMap node  then create a script in TileMap and write _draw() with loop for example
func _draw():
for i in 10:
print(i)
result[
0
1
2
3
4
5
6
7
8
9
0
1
2
3
4
5
6
7
8
9]
Minimal reproduction project
DrawReport.zip

Hmm, there's no reason this function would be called twice, we don't even call queue_redraw on a TileMap since it uses internal child canvas items to render things (with direct calls to the RenderingServer API). Even if it's not a big issue I guess, this should not happen.

thank you for replying This is probably my first report in 4.0 I just found the bug during the testing connection between Astar points also thank you for correcting the tile sentence that is very embarrassing.

I did a little debugging on this issue. So it seems that the double draw call is caused by the TileMap recreating its internals upon entering the tree:
https://github.com/godotengine/godot/blob/829d49b0110edc7bf283c7cca30cddb967bccb70/scene/2d/tile_map.cpp#L494-L497
As a part of that process it also queues an update to dirty quadrants, which then tries to recompute the rect cache. The rect cache recomputation is an operation that can potentially alter the boundaries of our TileMap, and thus it calls the item_rect_changed() function:
https://github.com/godotengine/godot/blob/829d49b0110edc7bf283c7cca30cddb967bccb70/scene/2d/tile_map.cpp#L998-L1002
That function then queues a redraw by default:
https://github.com/godotengine/godot/blob/829d49b0110edc7bf283c7cca30cddb967bccb70/scene/main/canvas_item.cpp#L446-L451
The problem is, because the dirty quadrant update call is deferred, it only occurs after the first draw call that is a part of entering scene tree is done. Because of that, a new redraw gets queued.
A solution I thought of is to check if the rect actually changed and pass that to the item_rect_changed()  function, so that it does not queue a redraw. I will make a pull request with that solution soon.


sample-cluster: create single simple node cluster

this commit adds new command which will create
single node cluster based on configuration of
rook/ceph yaml files using go embed. This command
assumes that kubernetes cluster is already there.

[x]  Complete CI testing

fixes: #95

As I think more about this feature, perhaps it is better to hold it for a while to understand the use case. While it is a very convenient idea, I'm not really sure who will use it. So maybe it is best to focus on other features first and think about this some more...

okay, I'm skipping this feature for now and all the requested changes 😄


Calling toggle() requires two clicks for initial open

I create several widgets using a loop and a switch statement - when you first click on a tile, it does nothing. The second click then initiates the expansion. From there, the expansion/collapse works as expected. Any suggestions to get this working correctly on first click? (using Flutter for web btw)
for (var a = 0; a < menuOptions.length; a++) {

      Widget w;
      //late ExpandedTileController expandedTileController;

      switch (menuOptions[a].type) {
        case "section":

          ExpandedTileController expandedTileController = ExpandedTileController();

        w = ExpandedTile(
          theme: const ExpandedTileThemeData(

          ),
          title: Text(menuOptions[a].name),
          controller: expandedTileController,
          content: Container(width: 100, height: 100, color: Colors.blue),
          onTap: () {
            print(expandedTileController.isExpanded);
            expandedTileController.toggle();
          }
        );

I am absolutely sorry for the late reply, There have been a few updates regarding the issue, and I added a listview builder for this use-case. could you give it a try and report back? Thank you for your contribution!


Uncaught TypeError: Cannot read property 'screenPositionForMouseEvent' of null

[Enter steps to reproduce below:]

Saving PHP files

Atom Version: 1.0.19
System: Mac OS X 10.10.5
Thrown From: atom-autocomplete-php package, v0.13.2
Stack Trace
Uncaught TypeError: Cannot read property 'screenPositionForMouseEvent' of null
At /Users/jasonmccallister/.atom/packages/atom-autocomplete-php/lib/tooltip/abstract-provider.coffee:85

TypeError: Cannot read property 'screenPositionForMouseEvent' of null
    at /Users/jasonmccallister/.atom/packages/atom-autocomplete-php/lib/tooltip/abstract-provider.coffee:85:74

Commands
     -2:18.9.0 core:backspace (atom-text-editor.editor.is-focused)
     -2:18.3.0 core:save (atom-text-editor.editor.is-focused)
     -1:17.9.0 core:copy (atom-text-editor.editor.is-focused)
     -1:17.4.0 core:close (atom-text-editor.editor.is-focused)
     -1:12.1.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -1:12.1.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:11.7.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -1:11.7.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:11.4.0 core:paste (atom-text-editor.editor.is-focused)
  2x -1:10.7.0 core:save (atom-text-editor.editor.is-focused)
     -0:23.1.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -0:23.1.0 editor:newline (atom-text-editor.editor.is-focused)
     -0:19.2.0 core:move-right (atom-text-editor.editor.is-focused)
     -0:12.4.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:12.1.0 core:save (atom-text-editor.editor.is-focused)
  5x -0:02.4.0 core:close (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "projectHome": "~/Code",
    "disabledPackages": [
      "background-tips",
      "php-composer-completion",
      "craft-twig",
      "highlight-line",
      "language-expressionengine",
      "php-cs-fixer",
      "linter",
      "linter-php",
      "linter-phpcs"
    ],
    "destroyEmptyPanes": false,
    "openEmptyEditorOnStart": false,
    "themes": [
      "nucleus-dark-ui",
      "one-dark-syntax"
    ],
    "excludeVcsIgnoredPaths": false
  },
  "atom-autocomplete-php": {
    "binPhp": "/usr/bin/php"
  }
}

Installed Packages
# User
atom-autocomplete-php, v0.13.2
atom-beautify, v0.28.14
craft-snippets, v0.6.0
docblockr, v0.7.3
docs-snippets, v0.8.0
file-icons, v1.6.9
filesize, v0.2.0
nucleus-dark-ui, v0.5.8
php-twig, v4.0.0
tabs-to-spaces, v0.11.1
tool-bar, v0.1.9
tool-bar-main, v0.0.8

# Dev
No dev packages

@Peekmo I think this can be closed, I haven't had the issue since the pull request was merged.