Use usize rather than Option<usize> to represent Limit::skipand Limit::offset

Signed-off-by: remzi<EMAIL_ADDRESS>Which issue does this PR close?

Closes #3369.
Rationale for this change

skip = None and skip = Some(0) are equivalent, so we don't need both of them and the Optional type here is redundant. We use usize as the type of skip so that skip = None and skip = Some(0) can be simplified to skip = 0
What changes are included in this PR?

Are there any user-facing changes?
Yes.

Mark this as draft as I only update the logical plan so far.

Codecov Report

Merging #3374 (0187046) into master (d16457a) will decrease coverage by 0.00%.
The diff coverage is 91.07%.

@@            Coverage Diff             @@
##           master    #3374      +/-   ##
==========================================
- Coverage   85.58%   85.58%   -0.01%
==========================================
  Files         296      296
  Lines       54175    54158      -17
==========================================
- Hits        46364    46349      -15
+ Misses       7811     7809       -2

Impacted Files
Coverage Δ

datafusion/core/src/execution/context.rs
78.94% <ø> (ø)

...afusion/core/src/physical_optimizer/repartition.rs
100.00% <ø> (ø)

datafusion/core/tests/dataframe_functions.rs
100.00% <ø> (ø)

datafusion/core/tests/sql/explain_analyze.rs
83.87% <ø> (ø)

datafusion/expr/src/logical_plan/plan.rs
77.28% <0.00%> (-0.17%)
:arrow_down:

datafusion/proto/src/logical_plan.rs
17.88% <0.00%> (+0.07%)
:arrow_up:

datafusion/sql/src/planner.rs
81.66% <61.53%> (-0.02%)
:arrow_down:

datafusion/core/src/physical_plan/limit.rs
91.18% <84.61%> (-0.19%)
:arrow_down:

datafusion/core/src/dataframe.rs
89.21% <100.00%> (+0.19%)
:arrow_up:

datafusion/core/src/physical_plan/planner.rs
77.44% <100.00%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

😂Look like my review is late, new a PR for it


On Phantom Wallet connected getting error ON  Web3Auth.SeResult  Argument Out Of range Indx and count must refer to the same location within the string

Describe the bug
after devnet phantom wallet connect redirected tback to the app  getting above error

Thanks for reporting. Fixed with https://github.com/magicblock-labs/Solana.Unity-SDK/commit/695981a6fe264706c03234a5ba58b46b62e4b196


Fix tile id on save directives (cherry pick from GEOPY-1530)

GEOPY-1556

replaced by https://github.com/MiraGeoscience/simpeg-drivers/pull/37 (renamed branch)


BiometricType FaceID not showing instead of FingerPrint.

Hello I was using Flutter Local_auth and It seems like on some devices like OnePlus 6 and 7, I enrolled both Face and Finger Print, however When using the Authorization does allow me to use Fingerprint only, in the other hand when I tested on my Samsung S22 Ultra the Auth does allow me to use both.
Is there a way to change from fingerprint to faceID  instead?

Details of specific biometric methods are managed by the OS+device; the plugin can't control the specific method using the available OS APIs.
Closing as this isn't something that can be implemented.

Details of specific biometric methods are managed by the OS+device; the plugin can't control the specific method using the available OS APIs.
Closing as this isn't something that can be implemented.


[W09H01] Add tests for PinguTrip.onTheWay (task 6)

Add two tests:

Point is on the way
Point is not on the way

LGTM but i would add another test with several elements in the stream

Are there cases where these tests are passing but the Artemis tests not? For the H01 tasks there are no hidden tests so when the public tests are passing, is everything fine.

I self had the issue that it work with an 2 element Stream but not with a bigger stream

I self had the issue that it worked with an 2 element Stream but not with a bigger stream

But have you passed the Artemis tests with your first implementation?

No only after i discovered the bug and fixed the bug it passed the tests

No only after i discovered the bug and fixed the bug it passed the tests

Ok, thanks for the feedback. Then I will add another test 👍

@Benn1x I have added another test in https://github.com/MaximilianAnzinger/pgdp2223-tests/pull/214/commits/846398c0762f92babb75f50dd11e833b90a72e16 👍


Run yarn all to update dist folder

Following to @lavigne958 change the dist folder hasn't been re-generated. Hence the action was still using the old code.
Likely we should add a contributor guide mentioning that or better let an action do this for us !

Hello jbwatenbergscality,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Status report is not available.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

/approve

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

The following options are set: approve

In the queue
The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.
The changeset will be merged in:

:heavy_check_mark: development/3.1

The following branches will NOT be impacted:

development/1.0
development/2.0
development/3.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.
The following options are set: approve


Any update for this project?

Sorry, I've been busy lately and will keep improving the demo

Sorry, I've been busy lately and will keep improving the demo

Damn. This is a really interesting project. Why was it stopped?


White space after footer

Hello,
There is a white space after the footer for the contact page (https://easystat.be/contact/):

I don't have the same issue with other pages (for instance, https://easystat.be/rdv/):

Any idea how I could fix this by removing the white space?
The repo is available at https://github.com/AntoineSoetewey/easystat.
Thanks in advance for your help!
Regards,
Antoine

I Think it is happening only in your site. Because you added this part https://github.com/StaticMania/portio-hugo/blob/ccae0510631bc00e477fa2438cdcd38022eaf5c9/layouts/contact/list.html#L41
inside your header tag. This make code look weird.
There are lots of way to fix it.
If you want a quick fix, add style="display: none;" in https://github.com/StaticMania/portio-hugo/blob/ccae0510631bc00e477fa2438cdcd38022eaf5c9/layouts/contact/list.html#L7
Code will be...
<div class="animate-shape" style="display: none;">

BTW This is not a good solution


Lack of simple distribution mechanism

Something similar to SDKMAN! - curl -s "https://get.nemtoolchain.io" | bash.

Related to #55.


[SQL] [SPARK-8064] Fixes HiveSparkSubmitSuite for Hive 1.2.1 upgrade

This is a fork of PR #7191 authored by @steveloughran.  This PR fixes HiveSparkSubmitSuite test failures.
Hive 0.14.0+ adds time suffixes (s, ms, and d, etc.) to the original default values of a bunch of HiveConf options that define various timeouts (see [HIVE-5799] 2). This fails HiveContext initialization when we are connecting to a lower version of Hive (e.g., 0.12.0 in HiveSparkSubmitSuite), because these options are expected to be integral values in lower versions of Hive.
This PR enumerates all such options and converts their values to corresponding Long values according to their output time unit before passing them to the metastore Hive client of lower versions.
Please refer to [this failed Jenkins build] 1 for more details about the failed test case.

Enumerating all time ConfVars looks a little bit awkward, but I couldn't figure out a smarter way :(

Merged build triggered.

Merged build started.

Test build #39427 has started for   PR 7868 at commit e4556c1.

@steveloughran Changing default values of these ConfVars breaks backwards-compatibility. Is it worth a Hive JIRA ticket?

Merged build triggered.

Merged build started.

Test build #39428 has started for   PR 7868 at commit 6a92bb0.

Test build #39427 has finished for   PR 7868 at commit e4556c1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #39428 has finished for   PR 7868 at commit 6a92bb0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Closing this since it's merged into PR #7191.


Add ITK_DEFAULT_COPY_AND_MOVE and replace "manually" defaulted copy and move member function declarations

Aims to address issue #4645 "Defaulting copy constructor, copy assignment, move constructor, and move
assignment functions", reported by Jon Haitz Legarreta Gorroño (@jhlegarreta).

Let's rebase after https://github.com/InsightSoftwareConsortium/ITK/pull/4659 to get green CI.


added styling and sample for partners page

@lornajane - I added some styling and a sample. LMK if you have any thoughts and feel free to continue to iterate.


Export JavaDocs to website on new release

Just like we had JavaDocs published for the V1's, we should do for V2's.
https://pi4j.com/1.4/apidocs/index.html

@eitch you think we can somehow push JavaDocs from release builds to the website repository?


git get commit causes error fatal: Remote branch  not found in upstream origin

I did not have a look at the log closely since git commands would work anyway, but I still get the error warning fatal: Remote branch 2dd50b6 not found in upstream origin I did install the latest version including the  i18n-related bug fix. When I would run git get -v b1f6c1c4/git-get 2dd50b I would get the following:

6
OCWD=/Users/mohammadeglil/desktop
FORCE=''
FORCE_DIR=''
OUTPUT=/Users/mohammadeglil/desktop/git-get
DEF_OUTPUT=YES
PRESERVE=''
TAG=''
TAG_FILE=''
GITHUB=REPO
GH_REPO=b1f6c1c4/git-get
REPO=git@github.com:b1f6c1c4/git-get.git
BRANCH=2dd50b6
DIR=''
BASENAME=git-get
PREV_TAGS=''
WORK_DIR=/private/var/folders/41/1n8hp4_n7j523xwflsx1kpq80000gn/T/tmp.4Qr9N2hF
git clone --bare --progress --branch 2dd50b6 --depth 1 --no-tags git@github.com:b1f6c1c4/git-get.git git-get/.git
Cloning into bare repository 'git-get/.git'...
warning: Could not find remote branch 2dd50b6 to clone.
fatal: Remote branch 2dd50b6 not found in upstream origin
git clone --mirror --filter tree:0 --progress git@github.com:b1f6c1c4/git-get.git git-get/.git
Cloning into bare repository 'git-get/.git'...
remote: Enumerating objects: 151, done.
remote: Counting objects: 100% (48/48), done.
remote: Compressing objects: 100% (48/48), done.
remote: Total 151 (delta 0), reused 48 (delta 0), pack-reused 103
Receiving objects: 100% (151/151), 24.76 KiB | 1.65 MiB/s, done.
Resolving deltas: 100% (15/15), done.
Got SHA1: 2dd50b6425c7d79f4695aa69d05467e1a00fc20f
git reset --hard
remote: Enumerating objects: 2, done.
remote: Total 2 (delta 0), reused 0 (delta 0), pack-reused 2
Receiving objects: 100% (2/2), 280 bytes | 280.00 KiB/s, done.
remote: Enumerating objects: 3, done.
remote: Total 3 (delta 0), reused 0 (delta 0), pack-reused 3
Receiving objects: 100% (3/3), 179 bytes | 179.00 KiB/s, done.
Updating files: 100% (6/6), done.
HEAD is now at 2dd50b6 use https
size used in /tmp = 148K	/private/var/folders/41/1n8hp4_n7j523xwflsx1kpq80000gn/T/tmp.4Qr9N2hF
tag = 2dd50b6425c7d79f4695aa69d05467e1a00fc20f

It was the desired behavior prior to commit https://github.com/b1f6c1c4/git-get/commit/dbc92194e9cd9db19553b409978d07e98e8e1aa6. If you upgrade to a newer version of git-get you won't see the error messages.

I did upgrade but the commit dbc9219 is not in the latest release. Would be cool if you would include this commit in your latest release.


expose agent system prompt + give it chat functionality

Ok got a bit carried away here since we're introducing breaking changes.
This PR now includes an overhaul of the model's response typing. We no longer need to extend ModelResponseType and hope that it includes the extended optional type in the payload. I know this may seem overkill but I was running into this problem yesterday. Plus the more we can enforce type strictness the better these things seem to do.
We now perform a merge with ObjectiveComplete so that if a model wants to return an ObjectiveComplete response it must also include any additional fields we've defined.


Validation

Refactor Validation and Function Generation for slegoapp.py
Utilize API keys from the frontend
update environment_setup to include the temp folder
update gitignore as well

revised validation


chore(cxx_extractor): migrate many of the extractor tests to C++

This is part of the effort in removing support for kindex files and the correspondingly obsolete kindex_tool (which also supports kzip files largely for these tests).
Additionally, it's gets rid of some complicated shell machinery.

There remain additional tests to be migrated, but I figured this was a good start.


readMail fails on empty mailbox or if no matching messages are found

If the selected folder (for example INBOX) is empty or no message matches the search pattern, readMail fails after the ESP_MAIL_DEFAULT_TCP_TIMEOUT_SEC timeout of 30 seconds.

Thanks for inform this issue.
The issue was fixed in the latest update.
Please update.

Thanks for inform this issue.
The issue was fixed in the latest update.
Please update.


mocks seem not to work after a page refresh/change

I'm using this module to mock the app while testing it with protractor
as far as I've seen, after I login into the app, and arrive at the home page, mocks are no longer working.
any ideas why ? or how can I reinject the mocks ?
thanks

Same problem for me.
If I run a test on one page in single mode, all tests run fine. But if I run the tests on a suite with page changes, nearly all mocks no longer work.

hm ... I think I got to the bottom of this,
are you switching between applications ?

No, im still on the same app, but for me this config...
capabilities: {
  shardTestFiles: true,
  maxInstances: 1
},

... fixed it.
Found on https://github.com/atecarlos/protractor-http-mock/issues/28#issuecomment-98886092

interesting :)


Mobile - Fix android QR crash

When an android user scans a QR code, the app crashes.

[ ] Action a fix

Note: This is caused by a Xamarin bug. See: https://github.com/xamarin/Xamarin.Forms/issues/14952.
Testing the suggested workaround in the linked issue.

✅ Done! Suggested workaround mentioned above was successfully.
See: https://youtu.be/KBHLwj3_T5c


feat: add persistent launch

Added cleanup after closing the browser
Added closing the browser when Ctrl + C signal is received
Added option to specify directory of user data

@teawinzero Are you willing to push this forward?

Closing due to merge conflicts, sorry this couldn't get merged!


Initial checkin of PublishMessage/Publish

fixes #9512
Motivation
#9512
Modifications
similar to #9512, but errors are fatal, as with normal message handling. (FEEDBACK REQUESTED))
Verifying this change

None of the tests in the Go code exercise this change, and there were no tests for NewOutputMessage either, except for very basic assertions on a producer.

This change added tests and can be verified as follows:

I will need help testing this, because currently there are no integration tests for go pulsar functions in the SDK code. I am still unfamiliar with how they are integration / unit tested at all outside of the module

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not documented) (draft)

feedback CC @freeznet @sijie

This is one possible way this could be implemented, sticking to the standards of Go Pulsar functions by sending the message async and not returning error/messageID to the user.  The other possible route would be like my original suggestion, and then all sends to topics that are not the output topic would be synchronous.

@freeznet @nlu90 Can you review this?

The pr had no activity for 30 days, mark with Stale label.

Closed as the development of the Go client has been permanently moved to https://github.com/apache/pulsar-client-go.

Oops.
But still, there're several conflicts so please feel free to resubmit the patch.


fix typo

fix request.code to response.code

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fleeto
If they are not already assigned, you can assign the PR to them by writing /assign @fleeto in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @zonghaishang. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zonghaishang Please sign the CLA first.

I signed it!

error log:
- ./public/help/faq/general/index.html
  *  External link https://www.apache.org/licenses/LICENSE-2.0.html failed: got a time out (response code 0)

@rootsongjc  please trigger ci again, thanks.

This is not a true error. Please submit a new commit to trigger the CI.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rootsongjc
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS [rootsongjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Use SHELL instruction

Rather than using  RUN powershell -Command each time, specify it once with SHELL:
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue'; $VerbosePreference = 'Continue';"]
Then one can do:
RUN Write-Host "The teacher is being taught"
Or for multiple lines:
# escape=`
RUN Write-Host "Line1"; `
         Write-Host "Line2"

https://docs.docker.com/engine/reference/builder/#shell

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c41307c1-5e43-754f-a1c9-d77af3b140db
Version Independent ID: 61d217a2-31a6-0d89-707e-a079233dd649
Content: Optimize Windows Dockerfiles
Content Source: virtualization/windowscontainers/manage-docker/optimize-windows-dockerfile.md
Service: windows-containers
Product: windows-containers
GitHub Login: @cwilhit

Hey @arcotek-ltd, while the proposed alternate moderates the verbosity of RUN statements, it introduces the need of tracking and reverting back to the parent image's SHELL instruction (which is subject to change between different image tags and versions) resulting an instruction set alike the below.
FROM mcr.microsoft.com/windows/servercore

# customise shell facilitating subsequent commands
SHELL ["PoweShell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

.
.
.

# revert to parent's default shell instruction
SHELL ["PowerShell", "-Command"]

Also taking into the account that the documentation provided is a guideline rather than a strict code of conduct, I personally find it useful to leave the use-case specific optimisation decisions at the hands of the user. Please do feel free to comment on my two cents'.

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Proposed fix on finding CUBLAS lib on Windows.

Hello,
I have found an issue running CUBLAS on windows using your lib. The file libcuda is called cublas64_75. It requires the user to have CUDA 7.5 installed.
We should find a way to abstract the version in the name of the dll.
Hope that helps,

Found this piece of code in a python lib scikit-cuda
(https://github.com/lebedov/scikit-cuda/blob/master/skcuda/cublas.py) Line 25 to 40
This is how they achieved getting the proper installed version of the cublas dll on Windows:
Load library:
_version_list = [7.5, 7.0, 6.5, 6.0, 5.5, 5.0, 4.0]
if 'linux' in sys.platform:
_libcublas_libname_list = ['libcublas.so'] +
['libcublas.so.%s' % v for v in _version_list]
elif sys.platform == 'darwin':
_libcublas_libname_list = ['libcublas.dylib']
elif sys.platform == 'win32':
if sys.maxsize > 2**32:
libcublas_libname_list = ['cublas.dll'] +
['cublas64%s.dll' % int(10v) for v in _version_list]
else:
libcublas_libname_list = ['cublas.dll'] +
['cublas32%s.dll' % int(10v) for v in _version_list]
else:
raise RuntimeError('unsupported platform')
Hope that helps


Read description for changes

Changes Made in the version -

Added Lollipop style Colored Status Bar.
Updated Target API level to 21.
Added a Better, Crispier Icon.
Made some tweaks in code.
Change the sp level of the text from 150sp to 140sp for smaller phones (Moto G)
Added Lollipop tweaks, made smooth.
Removed one .iml file.

For Future Pull Requests (Under Development)  -

Add HD Image, instead of low quality image sending since it is already being done over bluetooth.
Allow Sending File over bluetooth.
Cleaner UI, Better and Crispier icons, textures.
Allow user to accept/deny, file/image transfer.
More to come...

If you no longer make this project, can I proceed with fixing more stuff for this project? If you don't mind.

I'm no longer working on this app, so you may do what you want with it. :)

Thanks a lot :)


Christoph/docs/spec2

What was wrong?
How was it fixed?
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

Codecov Report

Merging #489 (56296c0) into master (68e8235) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 56296c0 differs from pull request most recent head 2adc3e3. Consider uploading reports for the commit 2adc3e3 to get more accurate results

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   87.70%   87.70%
=======================================
  Files          78       78
  Lines        5263     5263
=======================================
  Hits         4616     4616
  Misses        647      647

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e8235...2adc3e3. Read the comment docs.

@g-r-a-n-t This is far from finished but I think it may be good to get the first chunk in before it grows to large.

Looks great. I left a bunch of comments, some of which are suggestions and others are just general thoughts that probably warrant new issues.

Also, I'd be happy to rewrite a bunch of stuff in the data layout section after this gets merged.


Bug/field data field width#1158

Description
Field and data config panel default width
Initials of all the titles should first letter should be in uppercase.
Issues Resolved
https://github.com/opensearch-project/observability/issues/1158
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@abhaypersistent Changes look good, can you please resolve conflicts?

Hi @mengweieric @ps48,
Created New PR  https://github.com/opensearch-project/observability/pull/1265
Thanks!


No Success iPhone 11 Pro Max 13.3

Describe the bug
4.0.1 still has not fixed any issues with jailbreaking my device, 0% success rate. Reboots instantly after tapping jailbreak.
Device (please complete the following information):

iOS Version: 13.3
iOS Device: iPhone12,5
unc0ver Version: 4.0.1

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Logs
https://pastebin.com/suTqiqb3

Also happening to me. Here are the logs:
https://pastebin.com/fiDdnMjP

Same issue here. View the logs on Pastebin here.

Same here


DOCS: Add section about Semaphore in distributed

This requires a minimal version of distributed. Is this something we need/should track somewhere?

What do you think about adding distributed>=2.14.0 to the doc requirements and merging this PR after the release?

Sounds good 👍

I'll restart the documentation build once the distributed 2.14.0 release is out and then merge this PR


A Strange Syntax Error

Why?:
The Code will report a strange Syntax Error, but it will run normally after removing const WORK_SPACE = process.cwd();
Code:
const WORK_SPACE = process.cwd();

export async function test(task){
  console.log(';test')
}

export default async function (task) {
  console.log("index taskr");
  await task.clear('compild');
  await task.start('test');
}

ERROR：
export async function test(task){
^^^^^^
SyntaxError: Unexpected token 'export'
    at new Taskr (D:/xxxxx/xxxxx/node_modules/taskr/lib/taskr.js:21:39)
    at Object.<anonymous> (D:/xxxxx/xxxxx/node_modules/taskr/lib/cli/spawn.js:35:9)
    at Generator.next (<anonymous>)
    at Generator.tryCatcher (D:/xxxxx/xxxxx/node_modules/bluebird/js/release/util.js:16:23)
    at PromiseSpawn._promiseFulfilled (D:/xxxxx/xxxxx/node_modules/bluebird/js/release/generators.js:97:49)

ENV：
node  12.18.3
packages:
"@taskr/clear": "^1.1.0",
"@taskr/esnext": "^1.1.0",
"@taskr/watch": "^1.1.0",
"@vercel/ncc": "^0.27.0",
"node-notifier": "^9.0.0",
"taskr": "^1.1.0",
"typescript": "^4.1.3"

Hi,
Is this the entire file? I think there may be content before/above const WORK_SPACE = process.cwd(); that's affecting this.

Hi,
Is this the entire file? I think there may be content before/above const WORK_SPACE = process.cwd(); that's affecting this.

Yes，this is all.
This is a project that we just initialized.
System: window 10 EE：18363.1316
And:
It seems to be because of the system, but why does this happen?
I can reproduce this error on win10 computer, but not on Mac
There are only two files：
taskfile.js
const WORK_SPACE = process.cwd();

export async function test(task){
  console.log(';test')
}

export default async function (task) {
  console.log("index taskr");
  await task.clear('compild');
  await task.start('test');
}

package.json
{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "build": "taskr",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@taskr/clear": "^1.1.0",
    "@taskr/esnext": "^1.1.0",
    "@taskr/watch": "^1.1.0",
    "taskr": "^1.1.0"
  }
}


version 0.7.0 is missing from bazel central registry

the release page for v0.7.0 indicate that we should be able to install it using:
bazel_dep(name = "rules_zig", version = "0.7.0")

But the latest version in BCR is 0.6.1: https://registry.bazel.build/modules/rules_zig

Yes, it's unfortunately stuck on CI in https://github.com/bazelbuild/bazel-central-registry/pull/3461 due to what looks like an instance of https://github.com/aherrmann/rules_zig/issues/273. I've been trying to reproduce the issue locally to isolate the cause, but so far with no luck.


Unsecure documentation

The documentation website https://dotmenu.natesworks.com along with the parent domain are not configured to use Https, making it harder to access and less credible.

Hi! For me it seems to use https by default but that may not be the case on all browsers I will enforce https right now, thanks for pointing that out!

Should be fixed now!

Fixed


Assert failure in jxl::LowMemoryRenderPipeline::Init

desc
There is a assert failure in libjxl before version 0.6.1 that could cause deny of service attack.
asan output
./lib/jxl/render_pipeline/low_memory_render_pipeline.cc:312: JXL_ASSERT: first_image_dim_stage_ == stages_.size() || i >= first_image_dim_stage_
    #0 0x558c6d05047e in __sanitizer_print_stack_trace /fuzz/fuzzdeps/llvm-project-11.0.0/compiler-rt/lib/asan/asan_stack.cpp:86:3
    #1 0x7fd128ed84b8 in jxl::Abort() /libjxl/SRC/lib/jxl/base/status.h:132:3
    #2 0x7fd12976cc2b in jxl::LowMemoryRenderPipeline::Init() /libjxl/SRC/lib/jxl/render_pipeline/low_memory_render_pipeline.cc:311:9
    #3 0x7fd12978248d in jxl::RenderPipeline::Builder::Finalize(jxl::FrameDimensions) && /libjxl/SRC/lib/jxl/render_pipeline/render_pipeline.cc:91:8
    #4 0x7fd1293a62af in jxl::PassesDecoderState::PreparePipeline(jxl::ImageBundle*, jxl::PassesDecoderState::PipelineOptions) /libjxl/SRC/lib/jxl/dec_cache.cc:198:40
    #5 0x7fd1293c5964 in jxl::FrameDecoder::ProcessSections(jxl::FrameDecoder::SectionInfo const*, unsigned long, jxl::FrameDecoder::SectionStatus*) /libjxl/SRC/lib/jxl/dec_frame.cc:775:5
    #6 0x7fd1295aa44a in jxl::(anonymous namespace)::JxlDecoderProcessCodestream(JxlDecoderStruct*, unsigned char const*, unsigned long) /libjxl/SRC/lib/jxl/decode.cc:1555:27
    #7 0x7fd1295aa44a in HandleBoxes(JxlDecoderStruct*) /libjxl/SRC/lib/jxl/decode.cc:2079:11
    #8 0x7fd1295a25da in JxlDecoderProcessInput /libjxl/SRC/lib/jxl/decode.cc:2251:29
    #9 0x558c6d07ed4a in DecodeJpegXlOneShot(unsigned char const*, unsigned long, std::vector<float, std::allocator<float> >*, unsigned long*, unsigned long*, std::vector<unsigned char, std::allocator<unsigned char> >*) /libjxl/SRC/examples/decode_oneshot.cc:58:31
    #10 0x558c6d080317 in main /libjxl/SRC/examples/decode_oneshot.cc:233:8
    #11 0x7fd12892b082 in __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:308:16
    #12 0x558c6cfa152d in _start (/libjxl/fuzzrun/decode_oneshot+0x1f52d)

[1]    888096 illegal hardware instruction  ./decode_oneshot /tmp/poc /dev/null /dev/null

reproduce

compile libjxl with address sanitizer
run ./decode_oneshot ./poc /dev/null /dev/null

Could you point to the commit where you observe this issue?
You write "before version 0.6.1", but the file mentioned in the asan output in not present at or before version 0.6.1. It is present at current main, but there I cannot reproduce the issue.

I can still reproduce this issue using commit ec093557b0e8f76a48b0a68356d786c664a65660

When I compile with asan and try to decode_oneshot the image poc, I can't trigger the assert failure at https://github.com/libjxl/libjxl/commit/ec093557b0e8f76a48b0a68356d786c664a65660:
~/libjxl ((ec093557…))> ./ci.sh asan
[...]
~/libjxl ((ec093557…))> ./build/decode_oneshot poc /dev/null /dev/null
Decoder error
Error while decoding the jxl file
~/libjxl ((ec093557…))> md5sum poc
032c2ff7b122977ec747ed69c5e65207  poc

So in order to reproduce this, we need more specific info about the system that you are running this on.

When I compile with asan and try to decode_oneshot the image poc, I can't trigger the assert failure at ec09355:
~/libjxl ((ec093557…))> ./ci.sh asan
[...]
~/libjxl ((ec093557…))> ./build/decode_oneshot poc /dev/null /dev/null
Decoder error
Error while decoding the jxl file
~/libjxl ((ec093557…))> md5sum poc
032c2ff7b122977ec747ed69c5e65207  poc

So in order to reproduce this, we need more specific info about the system that you are running this on.

My running environment is ubuntu20.04.

I didn't use ci.sh to compile libjxl.
I used the following commands to compile libjxl.
export CFLAGS=-fsanitize=address
export CXXFLAGS=-fsanitize=address
export LDFLAGS=-fsanitize=address
cmake ../src -DBUILD_TESTING=OFF
make

I still cannot repro this, using the same way you compile libjxl. What compiler/version do you use?

With the other poc.zip, I can now repro this. The failure occurs when the following assert is triggered:
https://github.com/libjxl/libjxl/blob/1354a0612ff4d08307a1366554245f932b49f477/lib/jxl/render_pipeline/low_memory_render_pipeline.cc#L311
with the following values:
stages_.size() == 4
first_image_dim_stage_ == 3
i == 1

Not sure if the illegal hardware instruction triggered in asan is the problem or if the assert is triggered erroneously..
Any thoughts, @veluca93?

Issue was solved by commit aff17c4a57eb1e4d7ef00ea728d33cdb5b2ca9da


Update backend for Puerto Rico

This PR:

Updates the threshold count for PR to 10 (#1621)
Updates the workforce criteria to remove linguistic isolation from the calculation for Puerto Rico. TBH all of this code could be a bit DRYer.

@vim-usds this is the backend pull request for the Puerto Rico updates.


HBASE-24984 WAL corruption due to early DBBs re-use when Durability.A…

…SYNC_WAL is used with multi operation

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

  Would like to get this committed and get this in for 2.3.6 @saintstack pinged for issues in dev@ mail chain.  Multiple times this bug been raised.

Thx all for the reviews, I believe I have addressed all. Will create separate jira for the improvement related to separating out class

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.


PX4 on Pixhawk does not boot after selecting MAVLINK as camera trigger interface

Scenario on Pixhawk hardware:

Select Trigger mode "Time based always on"
Select Triggrer interface "MAVLINK ..."

After powercycle the autopilot does not boot.
Only workaround I found is to flash it with Ardupilot and then back to PX4.
Reproducable on master@3961c46

Closing in favour of https://github.com/PX4/Firmware/issues/6961. Thanks for reporting.


Tech debt upgrade

Coverage remained the same at 83.704% when pulling e7dc28a4d202214bcf6d0260b2506ae6a890e18c on tech-debt-upgrade into 0d5245fc469555693638029a50b8ff6f1809f002 on main.


Require tls for sinks and clustersinks

validator will not accept sinks with non http endpoints.

/retest pull-knative-observability-integration-tests
I saw some weird stuff with "node taint" so I want to make sure it's the code being wrong.

/retest

Oh, I know what's wrong right now. We absolutly must fix on demand creation of docker images.


⚠ Bofrost.at has degraded performance

In 78aaf5c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 850 ms

Resolved: Bofrost.at performance has improved in c4fb0dd.


Player is considered AFK when riding a boat

It seems like the mod thinks a player becomes AFK when riding a boat for some time. This only happens when the player isn't doing anything else besides riding the boat (e.g. left/right clicking).

Thanks for reporting this!
After looking into the issue, it seems to occur because Sessility doesn't check position when determing a player's motility. This is intentional, as there's nothing sent to the server (to my knowledge) that might differentiate whether a player is actively moving by input or being pushed by the environment for properties like position.
For now, one possible option to help mitigate this might be to set the detect-rotation property to true, if not already (available in Sessility version 0.4 or later). This would detect motility when a player rotates their head, which might be enough to stop a player from being considered sessile when rowing a boat for a long time. However, if a player rows a boat in one direction for a long time without rotating their head, this issue would still occur.
In terms of Sessility itself, it might be possible for the server to use the animation state of the boat paddles to determine if a player is moving by input or not, since the paddle state is only true when a player is actively pressing an input key. However, there seems to be a bug in the vanilla client that may introduce false positives if this method of detecting motility is implemented. When a sessile passenger in a boat is moved to be the controller due to the controller exiting the boat, the passenger will sometimes emit a single paddle state packet with a true value, even if no input is pressed on the client. I have yet to discover the cause of this other issue, and will look into it in the future.
Regardless, this feature will likely be implemented in Sessility even with the chance of a false positive, since it is rare for it to occur. However, it likely will only exist as an optional feature, similar to detect-advancement-action or detect-rotation, because it introduces cases where a sessile player could be falsely considered motile.

I have now pushed code that implements detecting motility through the boat paddle state! This should fix situations where sessility is falsely triggered when constantly paddling a boat for a long time without otherwise moving.
You can find the build on its Gradle CI run page, which can be downloaded under "Artifacts". A workaround was also implemented for the possible false positive when a sessile passenger becomes a controller, so this should be safe to use by default. Note that this build also includes one other change to motility messages, but its effect should be negligible if you aren't using formatting codes in your motility messages.
Please let me know if this change solves the problems you were having!

we are using 0.5.1 and boating still marks a player as sessile, even with rotation detection set to true and they are moving their head

Hi @alien-sunset, the changes mentioned above have not yet been included in a full release of Sessility, so the problem is still present in 0.5.1. You can try the development version from the Gradle CI run page containing the change to see if that works for you. Make sure the detect-boat-paddle property is set to true.
Sorry about the confusing configuration file, that is something I do intend to fix in the future! Currently, Sessility uses the same system the vanilla server uses for its server.properties file, so documentation comments are not present. I'll see if I can move away from this or somehow implement documentation into it in the future.

ah that new build works perfectly! thank you  😄


Fix breaking issue with ScriptBaseUrl

The general idea here is this - change the ScriptBaseUrl functionality. If it is provided AND the URL is an absolute URL that starts with cdn.babylonjs.com, change this portion of the URL with the data provided in ScriptBaseURL

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14472/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14472/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14472/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14472/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14472/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14472/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14472/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14472/merge#BCU1XR#0

Just wonder if the urls should be constructed from the constant _DefaultCdnUrl to prevent typos ?

That was the initial thought and this is why it is public, but that would force a dependency on tools right on load.
I guess most depend on tools anyhow, but it can be an optional dependency, whereas this forces it to be a required dependency.
I can make the change, as clean-code wise, it does make sense

It could also be in its own module but I guessed all the one with a url are automatically depending on tools in order to use it so I am not sure it would change anything.


[Support] Fix create-user.sh email validation

What
This required all email addresses to end in a component that was 2-4
characters long. We need to use emails from domains that don't fit this
pattern (the specific example in this case was an address like
user@example.email).
With the introduction of generic top-level domains, there are now many
domains that don't fit this pattern[1], so this commit therefore removes
the upper limit on this component.
[1]https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#ICANN-era_generic_top-level_domains
How to review
Code-review is probably enough. You could test with a long email address against a dev environment.
Who can review
Not me.

LGTM


TestFoundation: fix a double free

No allocation was made to perform the explicit deallocation.  Doing so
causes a double free which the Windows C library caught.

CC: @millenomi

@swift-ci please test

@swift-ci please test Linux platform

@millenomi and I discussed this offline.  This is correct, the memory is owned by the NSValue, not by the consumer, so this is an invalid free.  Going to merge this so that I can make a follow up change - @millenomi caught the fact that we have a lifetime problem here and need to extend the lifetime of the value to ensure that there is no use-after-free.


Fix ContosoUniversity Acceptance Tests

Fixing the ContosoUniversity Acceptances tests
This relates to issue #93

I am going to close this PR and resubmit. The failure in AppVeyor was because Chocolatey.org was unreachable.


Come up with a method to integrate user and records.

Need a way to preserve records if a user is deleted but still have records linked to users.

Using unlinked fields in record model to preserve the last valid team/user name when the foreign key fields refer to nulls.


⚠ Jenkins Plugins Artifactory has degraded performance

In d679851, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1335 ms

Resolved: Jenkins Plugins Artifactory performance has improved in a538461 after 12 minutes.


Portability / Bluetooth

Looked at the code and love that it works so good (as it does).
One thing I have wanted is to get to use the regular DS4 controller hooked up using regular Bluetooth to the Mac and use it wirelessly. I assume that would be possible with your code but it of course needs to be adapted (to hook into Bluetooth events instead). I didn't feel comfortable doing it on my own and haven't gotten the time to dig into the details.
Feels like this is out of the scope for this project but wanted to see what your thoughts are surrounding this and perhaps you could point me in the right direction so I could fix this on my own (feeling a bit noobish towards this code).
Regards,
/Alex

Thanks !
AFAIK, the DS4 controller behaves the same (= listed in IOHID list calls, etc) if paired via BT, it should be seen as an HID by OSX like when plugged via USB.
You probably don't need to spoof DeviceID and ProductId since it should be the same as a USB plugged DS4, but you might want to try spoofing the COMMON_DEVICE_TRANSPORT to return USB instead of whatever that value is when paired via BT ("BT" maybe?, that should be somewhere on apple docs).
That would mean adding "BT DS4" in the filters set by IOHIDManagerSetDeviceMatchingMultiple so that when remoteplay calls list HID, BT DS4 are also returned.
Then make IOHIDDeviceGetProperty always return USB when asking for COMMON_DEVICE_TRANSPORT

Thank you for this project! I am trying to understand your instructions to make the DS4 work connected via Bluetooth, but I am having trouble finding information to complete the change. Can you provide any further help regarding this? I have tried updating the COMMON_DEVICE_TRANSPORT and the SPOOF values, but I am not sure how to troubleshoot.

I'm not sure, I feel like i'd just repeat what i just told above at the time, instead of spoofing a device to be another, you want to make the device be reported as USB instead of bluetooth (and it may very well not work as i never tested it)

Ok. Thank you for your response.
I got it to a point where it spoofs values, using a combination of this project and shockemu, but PS Remote Play doesn't acknowledge the controller.
 Thanks again.

I have gotten to the point where PS Remote Play recognizes that a "valid" controller is connected, but I think I'm not any closer to solving the problem. I think it should have been unnecessary to actually spoof IOHIDDeviceGetReport, but it fails to get a response from the controller. In my research, it appears that Bluetooth HID devices require the asynchronous version of IOHIDDeviceGetReport and IOHIDDeviceSetReport (IOHIDDeviceRegisterInputReportCallback and IOHIDDeviceSetReportWithCallback). This is a bit outside of my capability at the moment, so I am going to give it a rest until I have more time and experience.


Entity None does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method.

Thanks for your great Melcloud solution, with the new throttle it behaves ok for me !
With HA 2024.2.1 and Melcloud V0.3.4
Logger: homeassistant.components.climate
Source: components/climate/init.py:354
Integration: Klimaat (documentation, issues)
First occurred: 17:26:49 (9 occurrences)
Last logged: 17:26:49
Entity None (<class 'custom_components.melcloud_custom.climate.AtaDeviceClimate'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please create a bug report at https://github.com/ollo69/ha-melcloud-custom/issues
Entity None (<class 'custom_components.melcloud_custom.climate.AtaDeviceClimate'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please create a bug report at https://github.com/ollo69/ha-melcloud-custom/issues
Entity None (<class 'custom_components.melcloud_custom.climate.AtaDeviceClimate'>) implements HVACMode(s): off, heat, dry, cool, fan_only, heat_cool and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/ollo69/ha-melcloud-custom/issues

This is due to a change implemented in HA 2024.2 as reported here, to fix this I need to break compatibility with previous HA version. Because there is an elapsed of 1 here to fix this, I will wait for a couple of new mayor HA version before implement this,

Thanks, agree


  These are not of great importance but I feel the change is beneficial if not for style then at least to prevent confusion while contributing.

Thanks for doing this! My Overcommit/Rubocop setup has been a bit broken recently because of https://github.com/brigade/overcommit/issues/315, so I've sadly gotten used to skipping validations.
I really appreciate this change though!

No problem.  I had never used RuboCop or overcommit before so it was a bit confusing.  Apparently it only prevents a commit if one of the files has an error.  This is why running rubocop in the directory produced far more offenses.

Fixed in #79.


[Feature Request]: Scan without RequestAccess

Summary
Currently the Scan method of BleManager is doing a RequestAccess all the time. The problem is it is asking for all bluetooth permissions, location included.
In my case I don't need location I only need scan and connect. But this requirement causes my app to have unnecessary permissions.
And according to the docs we can have the bluetooth without location permission in android 31 and later.
I've created a permission class for MAUI that only requests the ones I want in Android:
https://gist.github.com/salarcode/da8ad2b993e67c602db88a62259d0456
API Changes
Remove RequestAccess from Scan method. (or make it optional)
Intended Use Case
Custom permissions for buetooth.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I certainly update the permission request.  It's been on my todo list for a while.  However, I won't be removing RequestAccess from Scan for a couple of reasons.

iOS essentially asks permissions immediately without RequestAccess getting involved
Too many people just expect things to "work" immediately.

I understand, how about making RequestAccess optional without breaking current behaviour?
for example
IObservable<ScanResult> Scan(ScanConfig? config = null, bool requestAccess = true)

This still doesn't put things inline with iOS behaviour which is why I don't want to take it out.
Why do you want it removed if the permissions are adjusted?

if permissions are adjusted so that we can choose which one want and don't want then yes it solved the problem.

This is already available in v3-alphas and the shiny 2.6 when it is released

Thanks 👍


Tests for riot api requester

Acceptance Criteria

Tests for riot api requester is created

This was done #129 and will be finished in #130


Introduce orderers

Pull Request Test Coverage Report for Build 4

63 of 63 (100.0%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 94.207%

Totals

Change from base Build 3:
0.3%

Covered Lines:
992

Relevant Lines:
1053

💛  - Coveralls


Add LGTM project integration badges to README

Add badges from Looks Good to Me: LGTM
Currently the C# extraction is failing, so there is no code review data available.  The build log can be found here: https://lgtm.com/projects/g/cisagov/cset/logs/languages/lang:csharp
For information on how to fix this please see: https://lgtm.com/help/lgtm/csharp-extraction

@cisagov/team-inl , can I get some love on this review please?

Thanks for the approval @inlguy .  Yeah.  They are a little concerning, but now we know.   Most of them look pretty trivial to fix.
Also, thanks for merging.

No problem.
Barry
<EMAIL_ADDRESS>208-526-7036
From: Mark Feldhousen<EMAIL_ADDRESS>Sent: Thursday, April 18, 2019 1:55 PM
To: cisagov/cset<EMAIL_ADDRESS>Cc: Barry K. Hansen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [cisagov/cset] Add LGTM project integration badges to README (#10)
Thanks for the approval @inlguyhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_inlguy&d=DwMCaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=GmcQIiOv3kgwzUTpaGNc0BCXH984PhD67AywY0EF00M&m=Ea8xmkQMJ2025h_Hhl-2XJpyVqLO94Q_DRFTVjgPEbw&s=r23kHzyO_pe4qSVAzpor6ewDoh7GV6REcW4vFgFmfrY&e= . Yeah. They are a little concerning, but now we know. Most of them look pretty trivial to fix.
Also, thanks for merging.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cisagov_cset_pull_10-23issuecomment-2D484665276&d=DwMCaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=GmcQIiOv3kgwzUTpaGNc0BCXH984PhD67AywY0EF00M&m=Ea8xmkQMJ2025h_Hhl-2XJpyVqLO94Q_DRFTVjgPEbw&s=Nz5d0MXd1FCQA_Q1ApG_TC7iXwrhpq9FIxm_U2Aw0dA&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABGKNBHDUOVNGEQZC5KZLW3PRDGXVANCNFSM4HGN7WSQ&d=DwMCaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=GmcQIiOv3kgwzUTpaGNc0BCXH984PhD67AywY0EF00M&m=Ea8xmkQMJ2025h_Hhl-2XJpyVqLO94Q_DRFTVjgPEbw&s=LsMhFmQDgTTvgSlnFQ6XTgrL7F024T3M5on1aV2ISG8&e=.


What is a "Windows file" in this doc?

Do you mean local file? or do you mean a file created on a Windows OS? or something else? There isn't such as things as a "Windows file".
Please clarify this term.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbec06eb-2341-9186-a24f-adc129642169
Version Independent ID: d32aa975-1187-ede1-e775-a590c0dba458
Content: OPENROWSET (Transact-SQL) - SQL Server
Content Source: docs/t-sql/functions/openrowset-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@SeaDude -- thank you for your feedback.
@MikeRayMSFT -- please look into this issue 3391.  The particular sentence in this article is "Azure SQL Database does not support reading from Windows files.".

With Azure SQL Database, there is no local Windows file system, so it cannot connect to local drives, and it cannot connect to UNC paths; it only supports Azure Blob Storage for BULK INSERT. I recommend changing the text from Azure SQL Database does not support reading from Windows files to Azure SQL Database does not support Windows file paths or UNC paths.
Also, I suggest adding the same note block below the FORMAT = 'CSV' example under Input file format options.

@MikeRayMSFT I am addressing this issue

PR pending


RegExp spaces are added in some cases

for(var c in b)
/aaa/m.test(b[c]);
Becomes:
for(var c in b) / aaa / m.test(b[c]);
or:
if(k)/aaa/m.test(v) && l()
Becomes:
if(k) / aaa / m.test(v) && l()
Which are obviously syntactically wrong.

not only the syntax is compromised, but also the Regular Expression itself.
/aaa/ => / aaa /


OSE system module v 1.1.1  incompatibility with Token Action HUD Core v 2.04

Updating Token Action HUD Core results in the core module plus the system module not being loaded
foundry.js:72076 The installed Token Action HUD system module requires Token Action HUD Core module version 1.5.


axis labels with pixel units get shifted in export

A minimal working example is below:
close all;
xlabel('x','units','pixels')
ylabel('y','units','pixels')
export_fig('test.png')

The result is as follows:

The x and y labels are shifted, when they should remain in the middle of their respective axes.
I am using MATLAB 2015b for Mac and the most recent version of export_fig (as of March 30, 2016).

It works ok on my Windows machine, so I assume that it could either be something specific to Mac, or perhaps to the figure's renderer - try to set the figure and/or export_fig to other renderers and see if this helps.

The painters renderer works well, it's opengl that causes the issue.

Please try to run print('test.png','-dpng') and see whether you see the same problem. In this case this would prove that this is an internal Matlab bug on Mac, and you should report it to MathWorks. Please report here what you find.

Running  print('test.png','-dpng') gives the correct output, so I don't think it's an internal Matlab bug.


Explosives (And possibly flames) mid-lifespan fired by players who join the Zombie team in Infected before they reach their target/detonate will do "team" damage to survivor-team players once they player is switched to Infected

RED player throws dynamite, becomes zombie, remaining dynamite does damage to remaining RED players in vicinity.

Fixed internally


Beta: Typo ES6: Destructuring Function Parameters

ES6: Destructuring Function Parameters
Issue Description
This removes some extra linees and mainly a syntactic sugar.

linees should be lines.
Browser Information

Browser Name, Version: Chrome
Operating System: Mac
Mobile, Desktop, or Tablet: Desktop

Your Code

Screenshot

Good catch! 💯

Hi I'm a first time contributor I'd like to fix that typo if no one's working on it already!

@ading25 Great!
CONTRIBUTING.md can help you get started.
If you have any questions, please come chat with us in the [Contributors Chat] Room(https://gitter.im/FreeCodeCamp/Contributors).
Happy Coding! :1st_place_medal:

I'm looking for the typo and can't seem to find "linees". Could I get some help locating the typo? Thanks!

@ading25 Sorry! Upon looking here it appears to have been fixed in staging and I did not notice!

This is a standard message notifying you that this issue is present in production, but it has been fixed in staging. Because of that, I'm closing this issue. When staging will be pushed to production again, your issue will be resolved.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.


React static tweets is throwing CORS error.

This is a huge error. Looks like the problem is here:
https://github.com/transitive-bullshit/react-static-tweets/blob/master/packages/react-static-tweets/src/twitter.tsx#L30

Wow, from the README of twitter-seach:

NOTE: The hosted version of Twitter Search has unfortunately been disabled due to abuse and excessive Algolia costs.

I wonder if this fetch url can simply be refactored to: https://syndication.twitter.com/tweets.json?ids=${id}? I'm not entirely sure what kind of data https://twitter-search.vercel.app/api/get-tweet-ast/${id} returned

The issue is that my personal Vercel account was disabled due to switching from their legacy plan to a new hobby plan. Apparently some of the usage exceeded Vercel's thresholds even though I only use it for free & open source demos (along with hosting my personal blog).
This is not an issue with react-static-tweets. It is only an issue with the demo and my personal Vercel account.
I'll update this issue once I hear back from Vercel's support team (since they don't allow you to just pay to upgrade personal accounts).

Looks like some static tweets are starting to come back:
https://twitter-search.vercel.app/api/get-tweet-ast/1399843866291978259

I think the recommend way of using this package should be self hosted. react-static-tweet can export a simple api handler function that developers can just import in their next.js API route. Somewhat like this. 👇

import { fetchTweetAst } from 'static-tweets'

export default async function getTweetAstHandler(req, res) {
 const { id } = req.query
 const tweetAst = await fetchTweetAst(id)

 res.status(200).json({ tweetAst })
}

and instead of the package using this hardcoded url "https://twitter-search.vercel.app/api/get-tweet-ast/${id}", it can just point to a relative next.js endpoint '/api/get-ast', which exports the above function.
Switching to self hosted would not require lot of changes, while it would make the package future proof for any such failures. Covid.army was using this package for rendering tweets, and when things broke, our complete functionality was down, I temporary switched to another package, but they were just slow (ofc).

@jaisharx this is already possible. Just override the default fetcher option to TwitterContextProvider:
    <TwitterContextProvider
      value={{
        tweetAstMap: (recordMap as any).tweetAstMap || {},
        swrOptions: {
          fetcher: (id) =>
            fetch(`/api/get-tweet-ast/${id}`).then((r) => r.json())
        }
      }}
    >
      // ...
    </TwitterContextProvider>

We could make this the default, but then the default wouldn't work for everyone out of the box.

The default behavior should be to fetch the tweet ASTs server-side as in our example: https://github.com/transitive-bullshit/react-static-tweets/blob/master/example/pages/index.tsx#L7-L9
The client-side fetching is provided as a convenient fallback, but unless you're relying on your own endpoint, I wouldn't rely on it in production.
If anyone wants to update the docs to better reflect this tradeoff, that'd be awesome.
Thanks :)


[EG] New EG events for June

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-eventgrid


⚠ Bofrost.be has degraded performance

In e609728, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1398 ms

Resolved: Bofrost.be performance has improved in 4b4d688 after 13 minutes.


Adds unit tests

Hey there! This is a work-in-progress, but as part of the CocoaPods Test Jam, I've added some unit tests to AFNetworkActivityLogger.

[x] Add test harness project.
[x] Abstract out NSLog invocations.
[x] Replace equal() matcher with matches() regex matcher (once https://github.com/specta/expecta/pull/144 is merged).
[x] Finish remaining pending tests.
[ ] ~Test NSLog invocation.~
[x] Add Travis CI integration.
[ ] ~Add code coverage metrics.~

So, testing NSLog invocation is actually really hard so I'm leaving it as pending. I'll get Travis + metrics integrated tomorrow.

Also going to leave code coverage to someone else – want to get this in a mergeable state ASAP. Here's a good guide for anyone coming along later.

So this is ready for review. You'll need to enable Travis support on your repository from Travis' UI to get the tests running.

Help getting Travis to run would be :+1: too. Apparently it's still awful.

@kylef Any update on this?

I just turned travis on for this repo. Would you want to retarget this pr to the 3.0.0 branch? Prepping that in conjunction with AFNetworking 3.0

OK, will do.


Handle out-of-bounds accesses in VDCE

It is possible that other optimization will propagate
a value into an OpCompositeExtract or OpVectorShuffle
instruction that is larger than the vector size.
Vector DCE has to be able to handle it.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/4513.

The clang-ubsan bot failure is my bad - I added a new config for this and looks like I didn't get it quite right. I will fix, but we can ignore that bot until I do.


Autodetect modules.

Autodetect available cities instead of writing them into an array.

This is already being done, the list of supported cities in server.py however is a security precaution to not be able to try and request random files from elsewhere on the server.

I'm going to go ahead and close this, not much more to do here.


Update dependencies

This PR updates the dependencies, and removes the broadcast rules for some of the dependency packages.

bors r+

bors r+


Installing kong on Ubuntu 16.04

NOTE: GitHub issues are reserved for bug reports only.
Please read the CONTRIBUTING.md guidelines to learn on which channels you can
seek for help and ask general questions:
https://github.com/Mashape/kong/blob/master/CONTRIBUTING.md#where-to-seek-for-help
Summary
Installing kong on Ubuntu 16.04 doesn't seem to work at all. This is 1st time setup on this Ubuntu box.
Steps To Reproduce
$ sudo apt-get update
$ sudo apt-get install openssl libpcre3 procps perl
$ sudo dpkg -i kong-community-edition-0.11.0.xenial.all.deb
$ kong migrations up -c /etc/kong/kong.conf
$ kong start --v -c /etc/kong/kong.conf
Additional Details & Logs
~$ kong migrations up -c /etc/kong/kong.conf
~$ kong start --v -c /etc/kong/kong.conf

Nothing is logged when I run any kong command.

Kong version (kong-community-edition-0.11.0.xenial.all.deb)
Operating System - Ubuntu 16.04

Snippet from kong.conf -
database = cassandra             # Determines which of PostgreSQL or Cassandra
                                 # this node will use as its datastore.
                                 # Accepted values are `postgres` and
                                 # `cassandra`.

#pg_host = <IP_ADDRESS>             # The PostgreSQL host to connect to.
#pg_port = 5432                  # The port to connect to.
#pg_user = kong                  # The username to authenticate if required.
#pg_password = kong              # The password to authenticate if required.
#pg_database = kong              # The database name to connect to.

#pg_ssl = off                    # Toggles client-server TLS connections
                                 # between Kong and PostgreSQL.

#pg_ssl_verify = off             # Toggles server certificate verification if
                                 # `pg_ssl` is enabled.
                                 # See the `lua_ssl_trusted_certificate`
                                 # setting to specify a certificate authority.

cassandra_contact_points = <IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>  # A comma-separated list of contact
                                       # points to your cluster.

cassandra_port = 9042           # The port on which your nodes are listening
                                 # on. All your nodes and contact points must
                                 # listen on the same port.

cassandra_keyspace = kong       # The keyspace to use in your cluster.

hey @ksachdeva11 did you install the data store (cassandra / postgres) before running migrations ?

Hi @senthil-nathan, yes cassandra is already running on these nodes <IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> . Looks like this issue is specific to version 0.11. I switched to version 0.10 and it working fine following the same steps as I did earlier.

@ksachdeva11 did you run kong migrations up before starting Kong in 0.11.x ? That is now a required step.

@thefosk Yes, I did.

Any updates ?

I'm unable to replicate with the following vagrantfile
# -*- mode: ruby -*-
# vi: set ft=ruby :

Vagrant.configure("2") do |config|
  config.vm.box = "ubuntu/xenial64"
  config.vm.provision "shell", inline: <<-SHELL
    sudo apt-get update
    sudo apt-get install -y openssl libpcre3 procps perl curl
    curl -L "https://bintray.com/kong/kong-community-edition-deb/download_file?file_path=dists%2Fkong-community-edition-0.11.0.xenial.all.deb" -o kong-community-edition-0.11.0.xenial.all.deb
    sudo dpkg -i kong-community-edition-0.11.0.xenial.all.deb
    sudo kong version
    sudo kong health
  SHELL
end

What output do you get when you run kong commands?
Also the following commands might provide more debug information:
whereis kong
echo $PATH
sudo dpkg -l | grep kong

@hutchic I still can't get kong up on Ubuntu 16.04 box.
whereis kong
kong: /etc/kong /usr/local/bin/kong

sudo dpkg -l | grep kong
ii  kong-community-edition             0.11.1                                     all          Kong is a distributed gateway for APIs and Microservices, focused on high performance and reliability.

Sorry, there simply isn't enough information here for us to help you debug this. I would recommend trying a source install of OpenResty <IP_ADDRESS> first, and see if there are any issue specific to NGINX/OpenResty in particular to your platform. I would also test that the resty-cli resty interpreter works once OpenResty is installed.
Now, according to the warning that is included in your issue that you did not remove before posting it, our GH issues are more intended as a channel for bug reports, while this issue is quickly deriving towards a support effort. As such, I will be closing this issue, but I encourage you to consult our other community support channels like Gitter and the mailing list (see README.md) if you wish to get further help.
Thank you for your understanding.


Developer Guidance - please mention .NET Framework 4.8 targeting pack

The Developer Guidance section in the README.md (https://github.com/microsoft/terminal#developer-guidance) should mention that .NET Framework 4.8 targeting pack is required as a prerequisite.
Because it takes long to compile, might annoy someone to realize quite late in the process that they should have installed it.
Thank you :)

Did VS not prompt you to install it automatically? We may have missed updating our vsconfig.
FWIW though, I think that's only used for some test projects. Building Host.EXE (conhost) or CascadiaPackage (the Terminal) shouldn't depend on any .NET anything.

@zadjii-msft I followed the section on building it it using PowerShell, so I did not open Visual Studio to built it.   It is only much later in the build process does it tell you that you need 4.8.

If you'd like, feel free to open a PR to add the note to the docs yourself ☺


Fix to require 1.5 based version of angular types

curious why this is necessary?

@jeff-phillips-18, this fixes npm run build for me, but npm run start throws the following errors:
npm run start

<EMAIL_ADDRESS>start /Users/rhamilto/Git/origin-web-catalog
webpack-dev-server --config config/webpack.dev.js --history-api-fallback --inline --progress --open

10% building modules 1/1 modules 0 active
Project is running at http://localhost:9001/
webpack output is served from http://localhost:9001/
Content not from webpack is served from ./src
404s will fallback to /index.html
10% building modules 2/3 modules 1 active ...lto/Git/origin-web-catalog/app/app.tswebpack: wait until bundle finished: /
10% building modules 2/5 modules 3 active .../webpack-dev-server/client/overlay.jsts-loader: Using<EMAIL_ADDRESS>and /Users/rhamilto/Git/origin-web-catalog/tsconfig.json
chunk    {0} catalogs-app.js, catalogs-app.css, catalogs-app.css (catalogs-app) 5.27 MB {1} [initial] [rendered]
chunk    {1} vendor-bundle.js (vendor-bundle) 0 bytes [entry] [rendered]
ERROR in ./~/origin-web-common/dist/origin-web-common-ui.js
Module not found: Error: Can't resolve 'messenger/build/js/messenger' in '/Users/rhamilto/Git/origin-web-catalog/node_modules/origin-web-common/dist'
@ ./~/origin-web-common/dist/origin-web-common-ui.js 2:16-55
@ ./app/app.ts
@ multi (webpack)-dev-server/client?http://localhost:9001 ./app/app.ts
ERROR in ./~/origin-web-common/dist/origin-web-common.js
Module not found: Error: Can't resolve 'messenger/build/js/messenger' in '/Users/rhamilto/Git/origin-web-catalog/node_modules/origin-web-common/dist'
@ ./~/origin-web-common/dist/origin-web-common.js 2:16-55
@ ./app/app.ts
@ multi (webpack)-dev-server/client?http://localhost:9001 ./app/app.ts
Child html-webpack-plugin for "index.html":
chunk    {0} index.html 569 bytes [entry] [rendered]
Child extract-text-webpack-plugin:
chunk    {0} extract-text-webpack-plugin-output-filename 502 kB [entry] [rendered]
Child extract-text-webpack-plugin:
chunk    {0} extract-text-webpack-plugin-output-filename 500 kB [entry] [rendered]
webpack: Failed to compile.

@jwforres The 1.6 version of Angular requires JQuery 3. Using ^ was pulling a 1.6.x version of the @types/angular which pulled in jqlite which re-defines some of the JQuery 2 settings (such as cssPropertySetter).  We need to keep at angular 1.5 versions.

@rhamilto Looking into that problem now. I can't see where messenger is being used, it is not set as a bower dependency anywhere. If I bower install it all is well, trying to figure out where it is being used.

Yep nevermind, I was reading the ^ like it was the # for some reason :-)

messenger used to be used in common by the old notification service but that dependency was removed when we switched to toasts

@jwforres Yup, and we had an import-loader in webpack for messenger. Removing that loader resolves the issue.

Added commit to fix webpack issue.


Change value of Django parameter DATA_UPLOAD_MAX_MEMORY_SIZE

Problem
I get following error when I try upload file of size over 2.5MB:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/uvicorn/protocols/http/httptools_impl.py", line 426, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/usr/local/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
  File "/app/saleor/asgi/cors_handler.py", line 112, in cors_wrapper
    await application(scope, receive, send_with_origin)
  File "/app/saleor/asgi/gzip_compression.py", line 142, in gzip_compression_wrapper
    await app(scope, receive, send_compressed)
  File "/app/saleor/asgi/health_check.py", line 16, in health_check_wrapper
    await application(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/django/asgi.py", line 83, in sentry_patched_asgi_handler
    return await middleware(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/asgi.py", line 146, in _run_asgi3
    return await self._run_app(scope, receive, send, asgi_version=3)
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/asgi.py", line 241, in _run_app
    raise exc from None
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/asgi.py", line 234, in _run_app
    return await self.app(
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/asgi.py", line 156, in __call__
    request, error_response = self.create_request(scope, body_file)
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/django/asgi.py", line 104, in sentry_patched_create_request
    _ = request.body
  File "/usr/local/lib/python3.9/site-packages/django/http/request.py", line 335, in body
    raise RequestDataTooBig('Request body exceeded settings.DATA_UPLOAD_MAX_MEMORY_SIZE.')
django.core.exceptions.RequestDataTooBig: Request body exceeded settings.DATA_UPLOAD_MAX_MEMORY_SIZE.

1. General Assumptions
Acceptance Criteria
Setting environment variable DATA_UPLOAD_MAX_MEMORY_SIZE should change Django parameter
2. API changes
No API changes
3. Database changes
No database changes
4. UML diagrams
5. To Do list
### Tasks
- [ ] Add DATA_UPLOAD_MAX_MEMORY_SIZE  to saleor/settings.py
- [ ] Add explanation of parameter DATA_UPLOAD_MAX_MEMORY_SIZE  to documentation

6. To Test

Verify uploading larger photos after increased value of DATA_UPLOAD_MAX_MEMORY_SIZE

Reproduced on Saleor 3.19.0-a (master.staging) by trying to upload product image of size 2.7MB. Sentry log: https://saleor.sentry.io/issues/4968485679/events/fd74f4f6a4b94333be09f3f0de958876/

Hi @pawelromanskidajar,
The error was raised because of bug in v1.35 of sentry-sdk. It's working correctly on the main branch. I prepared the PR for fixing 3.19.


[drogon] fix: patch DrogonConfig.cmake.in to find hiredis

In #32694 merge, the Hiredis_FOUND variable was removed mistakenly, which caused cmake/DrogonConfig.cmake.in to be configured improperly. resulting in error in projects that use drogon port with redis feature to be required to find_package(hiredis) in their cmake file before linking to Drogon::Drogon.
In order to fix this, the drogon_config.patch, which was covering similar issue with postgres, was updated to also cover hiredis case.

[x] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@an-tao I would appreciate it, if you would check the patches from #32694 and this merge to see whether it doesn't affect the expected behavior of drogon library.

IMO vcpkg_redis.patch is already too intrusive before this PR, and the use of hiredis config is split over two patch files...

I agree. I've aggregated them into a single deps_redis.patch for now. I don't like it that multiple patches are modifying the same file too.
This PR is just to solve what my last PR broke. this pattern has been repeated a few more times. I'll make a definitive PR to resolve them all so all features could be used in manifest mode, and I'll tidy up the patches in that PR.

All feature tested pass on the following triplets:

x64-windows
x64-windows-static
x86-windows

Thanks for the fix and sorry I missed it!

@BillyONeal sorry I didn't test it thoroughly last time.

No problem!


Changed TGC name to match protocol spec.

Handles https://github.com/Jasig/cas/issues/837

A small change and a huge one at the same time.
+1


Commit 7455351 in dev build 4.2.6242 likely created issues with __ptr32

Version and Platform (required):

Binary Ninja Version: this is a problem on 4.2.6244-dev (c59961a8) and 4.2.6262-dev (5c271eff) but not on 4.2.6228-dev (312c3c99) and 4.1.5902 (f2165c5d)
OS: macOS
OS Version: 15.0
CPU Architecture: M1

Bug Description:
It seems a pointer with the attribute __ptr32 will initially consume 8 bytes of space in a structure and then shrinks down to 4 bytes. This is the case when creating a new structure from C source but not the case when creating a structure with the API StructureBuilder.
Creating a type with the following declaration:
struct Foo {
	void *__ptr32 bar;
};

Will result in a type in the types view that looks like this:
struct Foo
{
    void* __ptr32 bar;
                  ?? ?? ?? ??
};

bar is the correct size, at 4 bytes but Foo is 8 bytes in size with an extra 4 bytes of unused space after bar. Adding the __packed attribute to Foo does fix it in this case but this didn't use to be what happened. It used to be that Foo would be 4 bytes without the __packed attribute.
Creating a type with the following declaration:
struct Foo {
	uint32_t bar;
	void *__ptr32 baz;
};

Will result in a type in the types view that looks like this:
struct Foo
{
    uint32_t bar;
    __offset(0x4);
    void* __ptr32 baz;
};

Foo is the correct size at 8 bytes and bar and baz are at their correct offsets (0 and 4 respectively). However there is this odd __offset(0x4); line in there.
What I'm finding in practice is that larger structures containing __ptr32 pointers are sometimes having the next field after the pointer be deleted and replaced with ?? ?? ?? ??. The field after the deleted field is at the correct offset, which is why I say it seems these types are starting out as consuming 8 bytes in size, resulting in them trashing the next field, but then shrinking down to consume 4 bytes of space.

Does setting the __packed attribute on the type fix the issue?

Does setting the __packed attribute on the type fix the issue?

Like I say, it does fix the issue in the simple case of:
struct __packed Foo {
	void *__ptr32 bar;
};

But if you have__ptr32 fields in the middle of a structure definition it causes problems for the field directly after.
Its probably possible to fix this issue by creating a separate packed structure for each instance of a __ptr32 pointer, containing a single field for hte pointer, and then using that structure for field types in other structures but thats a less than ideal solution for what appears to be a regression.
Like so:
struct Foo __packed {
    void *__ptr32 bar;
};

struct Baz {
    Foo foobar;
};

Ah sorry, missed that

I bet something in the way AdjustedType / AttributedType is handled has different alignment and therefore made the struct larger. Will look into this.

Yep, looks like clang actually handled it fine, and the binja conversion code was missing a call to SetAlignment. Fixed in >=4.2.6269


Cupscale upscales textures completely black.

For some reason whenever I upscale an image in Cupscale it always exports the image completely black. I have no clue why this is happening because I can upscale images just fine with the standalone ESRGAN. The reason I switched to Cupscale was because it would make it way easier to upscale images in multiple directories. Please help me as I have no clue what's going on.

Edit: Don't worry the issue is fixed. If you get this same issue just disable "Half Precision (FP16)" in AI Settings. I think this only happens with GTX 16XX GPUs but don't quote me on that.


Model prototype missing after clone() in combination with bindAll(this).

I've got a case where the model's prototype (or something like that) is missing after model.clone().
Platform
Windows 7
Chrome 16.0.912.77 m and Firefox 9.0.1.
Example
var A = Backbone.Model.extend({
	initialize: function () { _.bindAll(this); },
	hello: function () { console.log("Hello, world!"); }
});
var B = A.extend({
	initialize: function () { _.bindAll(this); }
});

// TypeError: Object [object Object] has no method 'hello'
new B().clone().hello();

If one doesn't bindAll() in B's initialize, the problem goes away.
While writing this report I feel that B#initialize()'s bindAll() messes up B#clone(). Replacing bindAll() with specific bind()s seems to be a solution. Still, maybe this should still be fixed.

Or, if impractical to change, perhaps a warning is appropriate in chapter http://documentcloud.github.com/backbone/#FAQ-this.

Hi @reinierkip!  Thanks for taking the time to write this up.
I'm not able to reproduce the issue you're seeing.  In this fiddle things seem to be working as intended.  Have you extended or modified Backbone in some way?  What version of backbone and underscore are you using?

I just pasted your above example into the console on BackboneJS.org, and it worked fine, printing out:
Hello, world!

... if you're still having a problem with this, please open a ticket with a reproducible test case.


[Removal]: Wobbly Wool Newt part 3 (previous #337)

Hotspot Name
Wobbly Wool Newt
Hotspot b58 Address
11Yx9JyaimtjHNsAXuaSyriBFR6erpcsWR2NkSVU3ygqt3vs8q4
Discord Handle
ArgelTa1#3410
Hotspot Manufacturer
RAK
Removal Reason
Regular hotspot
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Dear Helium support team,
This is my 3nd request regarding this hotspot. Please see link to the 1st request:
https://github.com/helium/denylist/issues/337
Here is the 2nd request:
https://github.com/helium/denylist/issues/1517
My hotspot is regular, please explain what evidence do you need so that this hotspot would be removed from the list.
You had no valid reasons to add it in the 1st place. It was removed and after 15 days got on the list again.
With this miner I have a great view of the city of Sofia, Bulgaria and I would like to keep mining. You have stripped me of 1 month mining rewards already. Please be fair and correct the situation.
The set-up is the following:

RAK V2 miner with upgraded 64GB sd card.
LMR400 white cable about 7-8m long.
The aluminum pole is 2m long above this part of the roof (one story house).
Directional Yagi antenna 6-8dbi on the roof (cheap, I am not sure about the antenna's exact dbi).

You can comment here what you need and also I am available on discord.
Best Regards,
A

Hello, may you please look at this issue?

Don't poison our PRs with your comments and explain how you get this graph:

Hello @CTH-Red-Team-Mapping-Service-P1
Thank you for getting back to me.
I don't understand much from this graph. I use LMR400 7-8 meters cable and some cheap Chinese antenna.
Do you believe that this is too good?
The miner is located in the village of Vakarel, Sofia region. Around 20 km from Sofia, almost open view to the city. The village is around 300m above the city, really good location in my opinion. I soldered the cable myself, there is a lightning arrestor on the antenna and the arrestor has earth cable in the ground.
That was my first miner, I had no knowledge whatsoever, I put 5.8 antenna like RAK, but cheaper version. Then I put this yagi antenna and point it to Sofia, even though it catch signals from Ihtiman as well.
Please ask me direct questions and I will answer them. I have no deep knowledge of RSSI and SNR ratio.
Kindly let me know what I should do to unblock the miner.

@CTH-Red-Team-Mapping-Service-P1
If you mean high SNR, maybe because it's open country there, see the location for yourself: Vakarel, Sofia, real placement.
I can make a video if you'd like.

Hello @CTH-Red-Team-Mapping-Service-P1
Please reply to my message above.
Thank you in advance.

Hello @CTH-Red-Team-Mapping-Service-P1
Please let me know what you need from me to unblock my hotspot?

Hello,
Kindly check the open issue and unblock my hotspot.
Thank you in advance!

Don't poison our PRs with your comments and explain how you get this graph:

I am also in the CTH Discord group and don't like cheaters. But what is so strange about that graph?
The vertical bars on the left are just from 3 hotspots which are in the vicinity of his remote location, which don't move (so the distance stays the same) but does have varying RSSI values. The other hotspots further away which he can witness best will also show similar vertical patterns.
This person has 10 other hotspots in the wallet which also just show normal behavior (not doing great though), so I don't see why he would be cheating with this specific one.
I suggest to remove this hotspot from the denylist and not add it again later.

Hello @Hummer-time Thank you for your response.
Before getting into the denylist this hotspot has been best performing for me due to it's location.
It's remote in a village, which sits about 300m above the city of Sofia and there are few hills in between.
Yes, my other hotspots have not been doing great lately. But it's fine, there are many issues.
I am just waiting for an update on the 11th this month to see how it goes and then I will work on improving my set-ups (like putting them higher, new cables, antennas, etc).

Thank you @Hummer-time and @abhay for removing the hotspot from the denylist! Really appreciate your help and have a great day/night ahead!


Update and test getting started instructions for Android 7

Review Android setup instructions as with the release of Android 7 they have probably changed.

Documenting a few things here:

The latest version of Android SDK via Brew doesn't seem to have a compatible HAXM for OSX:

Emulator setup has changed a bit. We should probably post screenshots.
The view is buggy a bit using Android 7, not sure if this was caused by 7 or always been like this:

Note, the react-native-vector-icons has a gradle build file that specifies version 23 of the SDK.


Add a confirm javascript module

Make it easy to display a [window.confirm](https://developer.mozilla.org/en-US/docs/Web/API/Window
/confirm) dialogue with a custom message when a link is clicked:
Do a thing

Useful as part of:
https://www.pivotaltracker.com/story/show/90529348

As a Specialist Publisher user, I want to avoid accidentally publishing content items I've created so that I don't risk the reputation of the place I work.

cc @jackscotti

thank you for taking care of this. I do not have enough knowledge and experience for reviewing this PR though. Let's wait for someone else. :)


[Feature]: override or remove  a exposed function

Feature description
await page.exposeFunction('onCustomEvent', (data) => {
       console.log(data);
     });

Is there any way to remove or override the exposedfunction 'onCustomEvent'?
PS:in old puppeteer version, this way as bellow works fine.
 this.page._pageBindings.set('onCustomEvent', (data) => {
});

But in new puppeteer version,_pageBindings is not found.

Or is there any other workaround?

tried await page.exposeFunction('onCustomEvent', null); to remove,but  does not work


Crash on reading 3D variable from MPAS

OS Tested: OSX

Load the data set from glade MPAS/FalkoJudt/30km
Add a 3D renderer (Volume, Wireframe, Slice)
Select the variable zxu

Vapor will crash

Stas, isn’t this a duplicate of #1637?
thanks - jc

On Jun 21, 2019, at 3:55 PM, StasJ<EMAIL_ADDRESS>wrote:
OS Tested: OSX
• Load the data set from glade MPAS/FalkoJudt/30km
• Add a 3D renderer (Volume, Wireframe, Slice)
• Select the variable zxu
Vapor will crash
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>

@clyne
That bug pertains to the DVR not supporting unstructured grids, yet it would try to load an unstructured grid.
This bug is unrelated to the DVR and occurs inside the vdc library.


Row component binding

Is there a concept to bind a different row component? I want to create different tables with different row components (one row component per table).
The Text within the row should be highlighted by classbinding.
Is there a different solution to realize this?

Im not sure I follow what you are trying to achieve. Can you give me a real world example?

Of course. I want to set color: red via classNameBindings. The use case is to highlight a specific row depending on the content, for excample if the content is very important.

Ive added the ability to add custom class names in rows, columns and cells, as well as the ability to hide/show rows. Changes have been released to v1.0.0-beta.3 😺 (docs should be updated as well)

Thanks!!


add UTD

@ijlal-gondal I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host utdalllas.edu not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


fix(BUX-218): do not send access key revoked at if it is not revoked

ℹ  depends on changes in bux-models

@dorzepowski @wregulski @vitalibalashka there is a merge conflict that needs to be resolved.

Conflict resolved

Thanks @dorzepowski but looks like you need to run make update or something similar, the go.sum is not liking the bux models new version

Thanks @dorzepowski but looks like you need to run make update or something similar, the go.sum is not liking the bux models new version

@mrz1836 right, I can't do that previously, because v0.2.0 doesn't exist, now it is updated


Imports Message from llmclient

Starts the use of llmclient as centralized lib for llm operations.
This imports Message from llmclient. ~, which the PR is still pending. Check this PR after https://github.com/Future-House/llm-client/pull/12 is merged.~

We decided to keep Message here in theaviary and llmclient will no longer be imported here.
Closing this PR.


Dylan/resettable tcs

Added ResettableBooleanCompletionSource, used it in the LIFOQueuePolicy to avoid allocating unnecessarily.
Renamed various components for clarity and consistency.
Big Concern:

There's a unit test I need. If the resettable task errors, it gets swallowed by a couple layers of async state machines. Stephen helped me work through a bug where the middleware called .Result on the resettable Task twice, causing a hidden error. I tried a couple things, but can't find a way to write a good regression test.

Two Questions:

The ResettableBooleanCompletionSource holds a reference to a LifoQueuePolicy (to return itself for pooling on .GetResult()). This is moderate coupling. Should I remove the coupling (likely passing in an OnGetResult callback), move the awaitable to be part of the LIFOQueuePolicy.cs file, or is it good as is?
LIFOQueuePolicy vs LifoQueuePolicy vs SomeOtherNamePotentially. What's a good mix of clarity vs avoiding weird looking capital letters?

Should I remove the coupling (likely passing in an OnGetResult callback)

I don't think so. I generally don't like decoupling until there are at least 3 unique consumers. The extra abstraction can make it harder to reason about what's really happening, and without multiple consumers you cannot really be sure if it's a good abstraction to begin with.

LIFOQueuePolicy vs LifoQueuePolicy vs SomeOtherNamePotentially. What's a good mix of clarity vs avoiding weird looking capital letters?

@davidfowl would warn you agains trusting me to name things, but I think QueuePolicy and StackPolicy is likely fine.

@DAllanCarr The "using" statement lets the event sources track the duration spent in queue. It starts a new stopwatch, and reads the value when disposing.
If it wasn't a using statement, that pattern would look like:
var timer = ConcurrencyLimiterEventSource.Log.StartQueueTimer();
result = await waitInQueueTask;
ConcurrencyLimiterEventSource.Log.RecordTimeElapsed(timer);

vs
using (ConcurrencyLimiterEventSource.Log.QueueTimer())
{
    result = await waitInQueueTask;
}


intelstack - HTTP Error 402: Payment Required' ???

This is not really an issue, but...
Ho do you avoid HTTP Error 402: Payment Required' ??? for intelstack installation??????
Thank you for sharing your work!

Sorry but I don't know.
I only took a quick look recently and I'm not sure if access is still free or not as company seems to have been acquired.
If you find, please share.


which is CRC-16-CCITT?

How to calculate the well known CRC-16-CCITT with poly = 0x1021?
according to https://www.lammertbies.nl/comm/info/crc-calculation and http://srecord.sourceforge.net/crc16-ccitt.html, we shall get 0xE5CC or 0x29B1 for bytes b"123456789", but I could not manage to get it.
The combination I've tried the combination of poly in [0x8408, 0x1021] and init in [0, !0x1D0F], but with no luck.
  fn digest_crc(init: u16, poly: u16, input: &[u8]) -> u16 {
    use crc::crc16::Hasher16;
    let mut digest = crc::crc16::Digest::new_with_initial(poly, init);
    digest.write(input);
    !digest.sum16()
  }
  let input = b"123456789";
  digest_crc(0, 0x1021, input);
  digest_crc(0, 0x8408, input);
  digest_crc(!0x1D0F, 0x1021, input);
  digest_crc(!0x1D0F, 0x8408, input);

I even tried poly of [0x811, 0x8810] according to this https://en.wikipedia.org/wiki/Cyclic_redundancy_check.

@clouds56 Similar issue, I couldn't get the right combo using crc-rs 1.8.  But crc16 AUG_CCITT matches the 0xE5CC output and CCITT-FALSE matched 0x29B1.
// crc16 = "0.4"

const TEST_CASES : &[(&[u8], u16)] = &[
    (b"123456789", 0xE5CC),
    (&[65], 0x9479),
    (&[3, 5, 11], 1730),
    (&['A' as u8; 256], 0xE938),
];

for &(input, expected) in TEST_CASES.iter() {
    let mut state = crc16::State::<crc16::AUG_CCITT>::new();
    state.update(input);
    assert_eq!(state.get(), expected);
}

assert_eq!(crc16::State::<crc16::CCITT_FALSE>::calculate(b"123456789"), 0x29B1);

@osialr , thanks for the link, according to code in crc16
I think there's 2 way to calculate crc (maybe just like little endian and big endian, while it is about bit order other than byte order),
// (BIT_REVERSE_TABLE[(crc & 0xFF) as usize] << 8) | BIT_REVERSE_TABLE[(crc >> 8) as usize]
crc = ((crc >> 8) | ((msg[i] as u16) << 8)) ^ $table[(crc & 0xff) as usize]

and
crc = ((crc << 8) | (msg[i] as u16)) ^ $table[((crc >> 8) & 0xFF) as usize];

I think it impossible to use this crc crate to get 0xE5CC or 0x29B1 now.

Please see #45 and #48 and help us get traction there. It requires quite an investment and it would be ideal to do it when related pieces are stabilized in Rust.
If you're interested in taking a phased approach and improve compatibility on top current implementation, you're welcome to contribute.

@clouds56 this should be possible with the v2 API. I have a working draft @ https://github.com/mrhooray/crc-rs/pull/55 but it requires Rust beta (for if/loop statements in const_fn).

#55 has been merged. @clouds56 could you check out the latest master?

@mrhooray wdyt about publishing a release candidate 2.0.0-rc.1?

Published 2.0.0-rc.1. There were some timeouts/hiccups - please check.

So, in the end, in crc-v2.1.0, which is the right one for CRC16-CCITT?

Upon a closer look at the catalogue sources, sounds like this is the one:
https://github.com/akhilles/crc-catalog/blob/95b87f3e7d6b411084ed1190ababc10206bc7b81/src/catalog.rs#L60
/* slightly trimmed from rusty details */
CRC_16_IBM_3740 { poly: 0x1021, init: 0xffff, refin: false, refout: false, xorout: 0x0000, check: 0x29b1, residue: 0x0000 };

http://srecord.sourceforge.net/crc16-ccitt.html

This page presents accurate implementations (long-hand and programmed) of the 16-bit CRC-CCITT specification, which is:

Width = 16 bits
Truncated polynomial = 0x1021
Initial value = 0xFFFF
Input data is NOT reflected
Output CRC is NOT reflected
No XOR is performed on the output CRC

Am I right?
In which case, why won't we have an alias for it?

CCITT is confusing because it's commonly misrepresented. You probably want CRC-16/KERMIT if init=0x0000 and CRC-16/IBM-3740 if init=0xffff.
We shouldn't have an alias for CCITT because it's not clear what the "correct" poly and init values are. It's better to use the less ambiguous terms.