Building for deployment

So this is a very basic question but I'm rather new to leveraging yarn in work flows.
I am able to clone, and build and run this repo.   I can navigate through and run the demos like the simple marker demo.
However, how do then build a self contained pack (web pack?) that I can call from a page that is using one of these components that I server from my simple web server.
Any guidance, links for help on how to deploy to servers would be appreciated!

Hi @fils. Indeed this repository uses yarn but I have mostly reverted back to npm these days. It is not really important which tool you use.
As for actual packaging, to have a closer look at how the project in docs directory is set up. It uses Open Web Component to reduce boilerplate needed to build, test and deploy an application. They have pre-built packages for webpack and rollup.
I recommend that you start with their guides and use the npm init @open-wc command to get started if you don't have a project already.
That being said, there is nothing really specific in the map elements which should affect your workflow. You may need polyfills to support some browsers/features in general but otherwise this is just JS code like any other: Import in your code and use in HTML.
Let me know if you have some more questions. I will be happy to help but it sounds like you should focus on web components to get your answers. I recommend the Polymer slack.


Error on iOS : The operation couldn't be completed. (kCLErrorDomain 0.)

Which platform(s) does your issue occur on?

iPhone 6s
iOS 11.3

Please, provide the following version numbers that your issue occurs with:

CLI: 4.0.2
Cross-platform modules: 4.0.1
Runtime(s): 4.0.1
Plugin(s):
"dependencies": {
"@angular/animations": "~5.2.0",
"@angular/common": "~5.2.0",
"@angular/compiler": "~5.2.0",
"@angular/core": "~5.2.0",
"@angular/forms": "~5.2.0",
"@angular/http": "~5.2.0",
"@angular/platform-browser": "~5.2.0",
"@angular/platform-browser-dynamic": "~5.2.0",
"@angular/router": "~5.2.0",
"nativescript-angular": "~5.3.0",
"nativescript-bluetooth": "^1.3.1",
"nativescript-geolocation": "^4.2.6",
"nativescript-insomnia": "^1.2.1",
"nativescript-mapbox": "^4.0.0",
"nativescript-theme-core": "~1.0.4",
"nativescript-ui-sidedrawer": "~4.0.0",
"reflect-metadata": "~0.1.10",
"rxjs": "~5.5.5",
"tns-core-modules": "4.0.1",
"zone.js": "~0.8.18"
},
"devDependencies": {
"@angular/compiler-cli": "~5.2.0",
"@ngtools/webpack": "~1.9.4",
"babel-traverse": "6.4.5",
"babel-types": "6.4.5",
"babylon": "6.4.5",
"clean-webpack-plugin": "~0.1.19",
"codelyzer": "~4.0.2",
"copy-webpack-plugin": "~4.3.0",
"css-loader": "~0.28.7",
"extract-text-webpack-plugin": "~3.0.2",
"lazy": "1.0.11",
"nativescript-dev-sass": "~1.5.0",
"nativescript-dev-typescript": "~0.7.0",
"nativescript-dev-webpack": "~0.10.0",
"nativescript-worker-loader": "~0.8.1",
"raw-loader": "~0.5.1",
"resolve-url-loader": "~2.2.1",
"sass-loader": "~6.0.6",
"tslint": "~5.8.0",
"typescript": "~2.7.2",
"uglifyjs-webpack-plugin": "~1.1.6",
"webpack": "~3.10.0",
"webpack-bundle-analyzer": "^2.9.1",
"webpack-sources": "~1.1.0"
}

Please, tell us how to recreate the issue in as much detail as possible.
When iPhone's Location is lost for some reason.
I was testing the app today in the Sofia Subway, and when I managed to reproduce it twice - when entering inside and throughout half of the route.

The UI becomes unresponsive and I need to restart the app.
Is there any code involved?
 geoLocation.watchLocation(location => {
            this.currentGeoLocation = location;

        }, error => {
            alert(error);
        }, {
            desiredAccuracy: Accuracy.high,
            updateDistance: 10,
            minimumUpdateTime: 1000 * 1,
            updateTime : 5000
        });

I am updating the current location and passing lat and lng to a mapbox (using mapbox plugin) every second to re-center it's position.

There might be places where both gps and wifi services have no signal but we haven't been able to reproduce the same scenario as yours yet.


Profile local storage is not working

Configuring local storage from define profile isn't working correctly.  It looks like make_LocalStorageEmbeddedController from common does nothing.  Maybe this has not be implemented yet?

Same here, looks like helper from profile.py to make local storage dictionary has issues due to LocalStorageEmbeddedController from common being empty.

@tkubica12 we've merged a fix for this issue and it should be available now.


Media Collections

This doesn't make sense anymore since media can add new characters anytime, maybe we can change it to rewards for specific amounts like owning 5/15/25/50 characters from media but then any media with more characters becomes more overpowered than smaller titles, so for now and until I or someone finds a good alternative I'm inclined to close this as not planed.


Minor and debatable: when a detection is selected, also highlight it's type

Is your feature request related to a problem? If so, Please describe.
On a recent dataset, I had problems finding the type of a detection in the type filter panel to change it's color, see below.
Describe the solution you'd like
Also highlight a detection's type, only when selected or possibly when editing, to make it more easy to find the type

This is an interesting idea.  Thanks for explaining the motivation.
I'm not sure if there would be unintended consequences, but I like the idea and think we should try it.


build: Linker error when X extensions are disabled during configure

TL;DR Throws linker errors when building with any of -Dxcursor=disabled, -Dxrandr=disabled or -Dxsync=disabled.
System

OS: Recent Gentoo Linux with 6.6.21 Kernel
Compiler: clang/clang++ 17
Linker: Tested with bfd 2.41.0
Meson: 1.4.0
Desktop: Sway 1.9 (Wayland)

Description
Linking against libX11 seems to be mandatory on Linux. However, commit 580584e896abfa9324e58c0fad39476cb4cc077c made building against libXcursor, libXrandr and libXext optional by allowing users to disable the associated features with -Dxcursor, -Dxrandr and -Dxsync, respectively. However, this does not work as expected (at least) on my Wayland machine, as I see the below output when trying to build with any of these options disabled. It does not matter which of these options is disabled. As long as one of these options is disabled, linker errors occur, failing to find symbols defined in the respective X library (i.e. XSync symbols missing with -Dxsync=disabled, XRR symbols missing with -Dxrandr=disabled and Xcursor symbols missing with -Dxcursor=disabled).
I guess this means that there is still code around somewhere in the codebase that uses those symbols even if the corresponding features are disabled.
Build log
❯ meson setup build -Dbuildtype=debug -Ddocs=disabled -Dtests=enabled -Dcairo=disabled -Dopengl=disabled -Dvulkan=disabled -Dxcursor=disabled -Dxrandr=disabled -Dxsync=disabled --wipe
The Meson build system
Version: 1.4.0
Source dir: /projects/pugl
Build dir: /projects/pugl/build
Build type: native build
Project name: pugl
Project version: 0.5.3
C compiler for the host machine: clang (clang 17.0.6 "clang version 17.0.6")
C linker for the host machine: clang ld.bfd 2.41
Host machine cpu family: x86_64
Host machine cpu: x86_64
C++ compiler for the host machine: clang++ (clang 17.0.6 "clang version 17.0.6")
C++ linker for the host machine: clang++ ld.bfd 2.41
Library dl found: YES
Library X11 found: YES
Library Xcursor skipped: feature xcursor disabled
Library Xrandr skipped: feature xrandr disabled
Library Xext skipped: feature xsync disabled
Compiler for C supports arguments -Wno-reserved-identifier: YES
Library m found: YES
Found pkg-config: YES (/usr/bin/pkg-config) 2.2.0
Dependency GL skipped: feature opengl disabled
Dependency cairo skipped: feature cairo disabled
Dependency vulkan skipped: feature vulkan disabled
Build targets in project: 18
NOTICE: Future-deprecated features used:
 * 0.64.0: {'copy arg in configure_file'}

pugl 0.5.3

  Configuration
    Platform                     : x11
    Cursor support (XCursor)     : NO
    Refresh rate support (XRandR): NO
    Timer support (XSync)        : NO

  Backends
    Cairo                        : NO
    OpenGL                       : NO
    Stub                         : YES
    Vulkan                       : NO

  Components
    Tests                        : YES
    Examples                     : YES
    Documentation                : NO

  Directories
    Install prefix               : /usr/local
    Headers                      : /usr/local/include
    Libraries                    : /usr/local/lib64
    Executables                  : /usr/local/bin

  User defined options
    buildtype                    : debug
    cairo                        : disabled
    docs                         : disabled
    opengl                       : disabled
    tests                        : enabled
    vulkan                       : disabled
    xcursor                      : disabled
    xrandr                       : disabled
    xsync                        : disabled

Found ninja-1.11.1 at /usr/bin/ninja
❯ ninja -C build
ninja: Entering directory `build'
[20/40] Linking target libpugl_x11-0.so.0.5.3
FAILED: libpugl_x11-0.so.0.5.3
clang  -o libpugl_x11-0.so.0.5.3 libpugl_x11-0.so.0.5.3.p/src_common.c.o libpugl_x11-0.so.0.5.3.p/src_internal.c.o libpugl_x11-0.so.0.5.3.p/src_x11.c.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,-soname,libpugl_x11-0.so.0 -Wl,--start-group -lX11 -lm -Wl,--end-group
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: libpugl_x11-0.so.0.5.3.p/src_x11.c.o: in function `initXSync':
/projects/pugl/build/../src/x11.c:127:(.text+0x5e4): undefined reference to `XSyncQueryExtension'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:128:(.text+0x601): undefined reference to `XSyncInitialize'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:129:(.text+0x61a): undefined reference to `XSyncListSystemCounters'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:138:(.text+0x6ac): undefined reference to `XSyncFreeSystemCounterList'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: libpugl_x11-0.so.0.5.3.p/src_x11.c.o: in function `puglRealize':
/projects/pugl/build/../src/x11.c:649:(.text+0x1046): undefined reference to `XRRQueryExtension'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:651:(.text+0x1062): undefined reference to `XRRGetScreenInfo'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:652:(.text+0x1075): undefined reference to `XRRConfigCurrentRate'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:655:(.text+0x109c): undefined reference to `XRRFreeScreenConfigInfo'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: libpugl_x11-0.so.0.5.3.p/src_x11.c.o: in function `puglStartTimer':
/projects/pugl/build/../src/x11.c:1386:(.text+0x212d): undefined reference to `XSyncIntToValue'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:1394:(.text+0x21d2): undefined reference to `XSyncCreateAlarm'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:1401:(.text+0x22a1): undefined reference to `XSyncDestroyAlarm'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: libpugl_x11-0.so.0.5.3.p/src_x11.c.o: in function `puglStopTimer':
/projects/pugl/build/../src/x11.c:1434:(.text+0x249b): undefined reference to `XSyncDestroyAlarm'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: libpugl_x11-0.so.0.5.3.p/src_x11.c.o: in function `defineCursorName':
/projects/pugl/build/../src/x11.c:473:(.text+0x41ea): undefined reference to `XcursorGetTheme'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:480:(.text+0x420d): undefined reference to `XcursorGetDefaultSize'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:481:(.text+0x4220): undefined reference to `XcursorLibraryLoadImage'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:487:(.text+0x4248): undefined reference to `XcursorImageLoadCursor'
/usr/bin/x86_64-pc-linux-gnu-ld.bfd: /projects/pugl/build/../src/x11.c:488:(.text+0x4255): undefined reference to `XcursorImageDestroy'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[21/40] Compiling C++ object test/test_inline_cpp.p/test_inline_cpp.cpp.o
ninja: build stopped: subcommand failed.

Fixed in 55245b9, thanks.


beta png instead

Hi! What do you think about it?

Not sure I want to put beta URLs in something that has different dev timelines than speedtests beta product.


Upgrade Gradle to support M1 nicely

since 7.x Gradle compatibility with M1 looks much better

Done, GAP works without major issues with recent Gradle


[Bug]: Multi-database change subtask work order description needs to be optimized

ODC version
ODC 4.3.0
OB version
No related.
What happened?
Multi-database change subtask work order description needs to be optimized.

What did you expect to happen?
The description of the work order is as follows:
【环境】多库变更 10004 第 2  批 $database_name
How can we reproduce it (as minimally and precisely as possible)?
View the work order description of the multi-database change subtask.
Anything else we need to know?
No response

pass


[common] Let edge wait listener thread to be started.

Let the edge wait listener_thread to be properly started.
This fix occasional hangs when nns_edge_release_handle called.

Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #207. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

We will fix test failure on nnstreamer repo later.


vcs state coloring missing

Do you want me to look into these filetree bugs?

assuming this one was also because you didn't have .git repo in there?


Build error at ImageCompressor.swift file - Cannot find 'RCTResizeMode'  in scope

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.

Here is the diff that solved my problem:
diff --git a/node_modules/react-native-compressor/ios/Compressor-Bridging-Header.h b/node_modules/react-native-compressor/ios/Compressor-Bridging-Header.h
index b85cffd..a2bbf7a 100644
--- a/node_modules/react-native-compressor/ios/Compressor-Bridging-Header.h
+++ b/node_modules/react-native-compressor/ios/Compressor-Bridging-Header.h
@@ -2,5 +2,6 @@
 //  Use this file to import your target's public headers that you would like to expose to Swift.
 //
 #import <React/RCTBridgeModule.h>
+#import <React/RCTResizeMode.h>
 #import <React/RCTEventEmitter.h>
 #import <Foundation/Foundation.h>

This issue body was partially generated by patch-package.

did you find any solution? @danielekpa

Please marge this fixes. I have installed the  latest module but it is still happenig.


AudioBand doesn't start

When installed, AudioBand appears as an option in the taskbar menu, but clicking on it doesn't do anything (except opening an invisible folder "Deskband Host for wpf").
All the files are unblocked, I had a previous version (0.6.1) and i uninstalled it before installing the new one (0.9.2).
This happens on Windows 10 1903
AudioBand.log
EDIT: Apparently some stuff in the registry from the previous version was still hanging, i managed to solve it
EDIT 2: It only worked once and now i can't manage to show it again, probably the version that appeared that single time was the old one

I managed to solve this, but I had to install Audio Band with the .zip, so the problem still remains with the msi installer

The issue is with old settings not properly being updated to the new version. I will get it  fixed. But if you are ok with it and don't mind, you can just delete old settings in %appdata%/AudioBand/audioband.settings and it will recreate default ones the next time it starts.


java8 LocalDateTime is not supported

I found it was the same as issue https://github.com/SQiShER/java-object-diff/issues/118, so I closed this issue


Bookinfo mutual TLS destination rules example

Hello,
I am trying to do the Bookinfo example from Maistra documentation.
Under the section Add default destination rules, for the second case where I did enable mutual TLS: I think the actual oc command lacks.
It is written in the current doc:
destinationrule.networking.istio.io/productpage configured
destinationrule.networking.istio.io/reviews configured
destinationrule.networking.istio.io/ratings configured
destinationrule.networking.istio.io/details configured

Instead of (I assume it should be written):
oc -n ${BOOKINFO_NS} apply -f  https://raw.githubusercontent.com/maistra/istio/maistra-2.0/samples/bookinfo/networking/destination-rule-all-mtls.yaml

# result
destinationrule.networking.istio.io/productpage configured
destinationrule.networking.istio.io/reviews configured
destinationrule.networking.istio.io/ratings configured
destinationrule.networking.istio.io/details configured

I refer to the following repository: https://github.com/maistra/istio/tree/maistra-2.0/samples/bookinfo/networking
In this OpenShift 4.5 Doc, they suggest the following from maistra-1.1:
## If you enabled mutual TLS:

$ oc apply -n bookinfo -f https://raw.githubusercontent.com/Maistra/istio/maistra-1.1/samples/bookinfo/networking/destination-rule-all-mtls.yaml

Note the file destination-rule-all-mtls.yaml is the same for maistra-1.1 and maistra-2.0.

Mutal TLS Maistra Bookinfo example not working ?
However, after I set the destination rules with the mTLS, I can still reach the Bookinfo service/web page trough HTTP.
At this point, I was expecting to reach Bookinfo page trough HTTPS.
What am I missing?
oc -n ${BOOKINFO_NS} apply -f  https://raw.githubusercontent.com/maistra/istio/maistra-2.0/samples/bookinfo/networking/destination-rule-all-mtls.yaml

# result
destinationrule.networking.istio.io/productpage unchanged
destinationrule.networking.istio.io/reviews unchanged
destinationrule.networking.istio.io/ratings unchanged
destinationrule.networking.istio.io/details unchanged

curl -o /dev/null -s -w "%{http_code}\n" http://${GATEWAY_URL}/productpage

# result
200

Sofware version & environment

OKD cluster version: 4.5.0-0.okd-2020-09-04-180756

  Kernel Version:                         5.6.19-300.fc32.x86_64
  OS Image:                               Fedora CoreOS 32.20200629.3.0
  Operating System:                       linux
  Architecture:                           amd64
  Container Runtime Version:              cri-o://1.18.2
  Kubelet Version:                        v1.18.3
  Kube-Proxy Version:                     v1.18.3

Operator name
Version
vendor

Elastic Cloud on Kubernetes
1.2.1
provided by Elastic

Grafana Operator
3.5.0
provided by Red Hat

Community Jaeger Operator
1.19.0
provided by CNCF

Kiali Operator
1.22.0
provided by Kiali

Maistra Service Mesh
1.1.1
provided by Red Hat, Inc.

Other issue in the doc
I also think that there might be a mistake or a bug in how the spec.ressources default values are dealt with. See this other issue about spec.resources.limits for Jaeger.

Following my original Issue post, I found this Medium blog post by Gaurav Agarwal: Kubernetes Services over HTTPS With Istio’s Secure Gateways, and it features the Bookinfo example.
The aim of this Medium post is to explain how to (I quote) Expose your microservices over TLS to the external world.
I think that the Istio (and Maistra) documentation could use a little upgrade on the Bookinfo + TLS example.
Indeed, in the Istio doc, you can find an example with TLS on httpbin; as well as various examples for EGRESS and INGRESS gateways using httbin or sleep.
But it could be good to have an example with Bookinfo where you start to access the Bookinfo web page with HTTP. Then you play with reviews'  (v1, v2, v3...) different versions and destination rules. And then you do the same but over HTTPS instead.


Timeout to skip a file and log it as skipped.

Especially for PST

should be dealt with in a different way


Strongly Typed IProcessor

Any possibility of having a strongly typed version of IProcessor i.e. IProcessor<TInput, TOutput> which would then have Process(row:IRow<TInput>) : output:IRow<TOutput> - this is basically just the prototypical map function in many collection libraries (or select in LINQ).
In the current implementation, things are all stringly typed - so developers will either just put up with that and risk runtime errors, or end up writing wrapper classes around the input IRow and output IUpdateableRow in order to get some strong typing into that.

Thanks for the feedback Isaac. Please note that we currently do not have a row type per se in the type system. However we are having a STRUCT type on the backlog and it could make sense to use it to type the UDOs with that type to mimic the row structures.

Is this closed as "will not fix" or "fixed" or "by design" or... :-)

I am not sure why Saveen closed it. I see it as, but onto the backlog and pending further feedback and investigation :)


fix: 🐛 support percent in edge button tool

Description
support percent in edge button tool
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

请教一下这个问题怎么处理，X6\node_modules@antv\x6-package-json: Command failed.

Is there any example for this


EDIT my POST -> Click on Back button -> Lands on FEEDs page, rather than previously navigated page.

Open "https://staging.fightpandemics.work/"
Login using valid email/pwd
Navigate Profile -> My Profile
EDIT any comment  and after "EDIT or comment" on any Post, click on 'BACK' button

Issue: You will observe that user lands on 'FEED' home page rather that 'My Profile' page from where I navigated.
So actually, BACK button should navigate to the previous page that user navigated, i.e. preserving the history of the user, to user "BACK" button feature.
Refer attached GIF
https://share.getcloudapp.com/X6uoK5NY

@BMariscal @idjevm
while validating this issue, it is not working in STG, hence reopening.
PR# 1067
https://share.getcloudapp.com/NQugBgWx

@rabbi08  it is working on staging when tested in Firefox but not on Chrome. Interesting. Can you check if it's working for you on Firefox?

@BMariscal
I tested in FF, and its not working in FF too including chrome & safari
Please refer below GIF from FF:
https://share.getcloudapp.com/GGuodppd

thanks @rabbi08
I'll use the Window.history object instead since it seems document.referrer doesn't always work.
Thanks for letting me know!

@BMariscal
This issue have been observed again in STG. Hence reopening this same issue, let me know if I should log new one or we should track from here.
Add Post -> https://share.getcloudapp.com/xQuL97BZ
EDIT post -> https://share.getcloudapp.com/kpubyDpP
When user click on 'Back' button, user should be re-directed to previous page visited before.

Closing this issue and opening new one #1398


Raise version for Debian

Debian 11 contains old version 1.1.0 which suffer from https://github.com/prometheus-community/elasticsearch_exporter/issues/516. Are there any plans to raise version to the latest one?

We don't control the version of the package in debian. I assume that's the debian team.


Fix crash on search bar and console widget

fix: replacing useProvider with useStream, avoiding exception "Bad state: Stream has already been listened to." on console.dart
fix: crash on search bar when there aren't results
cleaned code on version_install_button.dart and app_bottom_bar.dart

Awesome @federicoviceconti thank you for the PR

@all-contributors please add @federicoviceconti for bug


IOS Build error

Hello,

This issue occurred while building in IOS Xcode.
Please check the image below.

I judged that this error is related to NatCorder.
There seems to have been an error building an iOS project in Xcode. This error message displays a conflict between the NATCorder and some other components.
NAT Corder is a Unity plug-in that allows you to record video and audio from a Unity app or game. I believe the conflict may be related to version compatibility issues between some other components of the project and NATCorder.

Why did this problem occur, and is there a way to solve this problem?

Only the _NC errors apply to NatCorder.  Delete NatCorder then reimport it by following the setup instructions.

Only the _NC errors apply to NatCorder.  Delete NatCorder then reimport it by following the setup instructions.

Thanks @olokobayusuf , I'll try and thank you for the information. It appears that the error I'm experiencing only applies to NatCorder. I will delete the outdated version of NatCorder in my project and reimport it by following the setup instructions to see if that resolves the issue. Thank you for your help.
I will try this and give you an answer again. Thank you!!!!

Sounds good. Closing this issue, so feel free to reopen a new issue if you face any new errors. I also recommend joining the NatML community on Discord.


Handling nil case of RawSockaddr

Nil case of RawSockaddr should be checked otherwise it gets `nil preference

I signed the CLA!

I signed the CLA with this e-mail<EMAIL_ADDRESS>

Thanks @aslanbekirov for pointing out this issue.
I've created another pull request https://github.com/google/gopacket/pull/366 that fix it.


crtsh takes zerossl in consideration

we have unlimited certs for zerossl, we should only check for letsencrypt domains related

fixed in https://github.com/threefoldtech/js-sdk/commit/4f4188ee4a9bdf72fe4e9e1fcce369aa5e0c0e1b

fixed in https://github.com/threefoldtech/js-sdk/commit/4f4188ee4a9bdf72fe4e9e1fcce369aa5e0c0e1b


Fix find_source_in_db function to accept column name arguments

fixes #49

Here's an example of a test which tests for error raised: https://github.com/astrodbtoolkit/astrodb_utils/blob/a4d65a082c2697ad1cc347b43226dfeddca72dcd/astrodb_utils/tests/test_fits.py#L38


Peer group support in vrf context

Issue Type

[x] Template enhancement
[x] Role enhancement
[ ] Documentation enhancement (avd.sh)

Is your feature request related to a problem? Please describe.
I would like to use peer groups for BGP peerings in a VRF.
Describe the solution you'd like
An update to the tenant vrf model in eos_designs:
tenants:
  < tenant_a >:
    vrfs:
      < tenant_a_vrf_1 >:
        bgp_peer_groups:
          < peer_group_name >:
            remote_as: < remote ASN >
            description: < description >
            password: < encrypted password >
            send_community: < standard | extended | large | all >
            next_hop_self: < true | false >
            maximum_routes: < 0-4294967294 >
            default_originate:
              always: < true | false >
            update_source: < interface >
            bfd: < true | false >
            address_families:
              <address_family>:
                activate: < true | false >
            ebgp_multihop: < 1-255 >
            # Nodes is required to restrict configuration of BGP peer groups to certain nodes in the network.
            nodes: [ < node_1 >, < node_2> ]
            # Next hop settings can be either ipv4 or ipv6 for one neighbor, this will be applied by a uniquely generated route-map per neighbor.
            # Next hop takes precedence over route_map_out.
            set_ipv4_next_hop: < IPv4_address >
            set_ipv6_next_hop: < IPv6_address >
            route_map_out: < route-map name >
            route_map_in: < route-map name >
            local_as: < local BGP ASN >
        bgp_peers:
          < neighbor >:
            peer_group: < peer_group_name >

Describe alternatives you've considered
At the moment I'm using per neighbor configuration. But updating multiple sessions that must have the same settings takes a long time and is error prone. This also makes the VRF tenant yaml more readable.
Additional context
Add any other context or screenshots about the feature request here.

@daanvdsanden this is a great suggestion. As a workaround, you should be able to do add the peer group leveraging custom EOS structured configuration and then reference it in bgp_peers.

@carlbuchmann thanks for the suggestion. That works great for IPv4, for IPv6 you still need to specify the address family per neighbor else the code will also activate the IPv4 address family on the IPv6 peering on a neighbor basis.
I do like the config to be in the Tenant structure, because when the tenant is removed all the config with it will also go away/be cleaned up.
I do have some working templates, which I'm more than willing to share, given the proposed structure is ok. But I need some help or guidance in writing the correct tests with it.

@carlbuchmann do you mean, that we should already now be able to reference an existing peer-group in tenant vrf like this?
bgp_peers:
< neighbor >:
peer_group: < peer_group_name >
Thank you, Karl

@carlbuchmann do you mean, that we should already now be able to reference an existing peer-group in tenant vrf like this?
bgp_peers:
< neighbor >:
peer_group: < peer_group_name >

Yes you can already reference to an existing peer-group.

@daanvdsanden - thank you for confirming! I will update the documentation accordingly. Under the hood the tenant EVPN template passes all input vars for bgp_peers to eos_cli_config_gen but we chose to only document what was tested. Note, that this behavior may change in the future, and we would only pass vars that are documented.
@daanvdsanden - yes I agree that it very practical to also define the peer group in the Tenant construct. We are in the process of refactoring eos_designs, so this is why I have assigned this issue to milestone 2.2.0, to avoid merge conflicts. Once 2.1.0 released, I would be happy to help you with this PR and show you how to add molecule test cases.

@carlbuchmann @daanvdsanden Thank you for your feedback on this. I have just now successfully used it for 8 BGP peerings on my border leafs.


Decoupled z-index states for focus and active buttons

Fixes the inconsistent focus/active state bug in #34106

Closing as stale.


Use undefined to indicate value hasnt been set

Null is a value in the UI, undefined is easier to work with. Use undefined for all augur packages to indicate no value has been set.

i talked to @epheph about this ticket and he said this wouldn't work because undefined is not valid json

well, if it's not valid json then it can't be sent over the wire. so this wouldn't be a good path forward for v1. v2 we can keep in mind the differences between null and undefined, but no systemic change is needed at this time, closing this task


using many profiles

Hello, I have a question: is there a way to map a set of proteins to a set of profiles? Doing this using one by one and converting the output to m8- files adds a lot of overhead.
As I understand you do this during the cluster algorithm. I would have pre-clustered proteins, and I want to map proteins to the cluster, which is the closest.

Are your profiles in the MMseqs2 clusters format? If yes than you can update the cluster database by following the next steps.
(0) search the profiles against the set of new proteins.
(1) use swapresults to get mapping of protein to profile.
(2) use filterdb ... --extract-lines 1 to extract the top hit for each protein.
(3) trim only the first column since the cluster format just has only the sequence identifier. This can be done with fliterdb ... --trim-to-one-column.
(4) swap again to get a profile (cluster) to  protein mapping swapresults.
(5) use mergedbs to combine your old database with your new database.
This is really hardcore mmseqs internal knowledge. We will offer a MMseqs2 tutorial at the ECCB18 if you want to learn more about its internals.

We talked about your problem, this solution won't quite work yet (at least the last step). We will think about something on Monday and update you.

Hi @SilasK, sorry again for the delay.
Could you expand a bit on what you want to achieve?
(1) Do you want to "update" your profiles, by adding new sequences to that profile?
This is a bit tricky, we would need to provide something similar to the cluster updating, but for a search  instead. The tricky part is, that the sequence databases of the profiles and the new sequences have to be merged first, while retaining the profile identifiers.
(2) Do you just want to know what profile this protein should belong to? Step (0) to (2) is already enough for that.
I can look into (1), if this is what you need. I am a bit busy with another paper submission currently, so I might need some time.

Thank you for your response
I’m interested in (2) knowing to which profile each protein belongs.
So I will try steps (0)-(2). Do I still have to put the profiles in a specific format?

What format are they currently in?

I misunderstood your initial post. So the full workflow, would be something like this:
For this small set of profiles you also don't need the swap. You can search directly against the profiles.
Query-side profiles becomes useful for millions of them. The target-side profile search can still handle a few 100k profiles without exploding in memory.
mmseqs createdb queries.fasta queries
mmseqs msa2profile stockholm profiles
mmseqs search queries profiles result tmpDir -k 5
mmseqs filterdb result best --extract-lines 1
mmseqs convertalis queries profiles best best.tsv

See this section in the wiki for more details.

I red trough the section in the doc, but I don’t know how I should use my my targets  (target_1.fasta … target_10000.fasta).

@SilasK could you solve the problem?

Hello @martin-steinegger, not completely.
I would like to find a way to merge different profiles/msa in one database. I realized that one can put multiple msa in one Stockholm formatted file, but I didn't manage to made it work. mmseqs took only the first msa from my Stockholm formatted file. Maybe I have some formatting issues.

Is this the way to go?
Where does mmseqs take the name from, which metadata line?  For now, it names the profile according to the first seq which is not that useful.

For me it

I think I got it working.
I used the GF AC metadata for the name of the profile.

Thanks for letting us know.
@milot-mirdita is this something we should add to the documentation?

It depends on your use case. If your profiles are query centric than you can use mmseqs to create the profiles. Mmseqs alignment is a center star alignment which does not allow gaps in the query sequence.
 mmseqs search query target aln tmp -a
 mmseqs result2profile query target aln prof

If you need a protein family representation than creating profiles from MSAs makes more sense.
  mmseqs search query target aln tmp
  mmseqs createseqfiledb target aln alnseq
  mmseqs apply alnseq alnseqmsa — msaaligner


Update conan 2d20.html

copy / paste works wonders especially when you use the wrong file !!
taken this opportunity to update a lot of the files and fix a few spelling mistakes

You have merge conflicts. I'm 90% sure it's because of the sheet.json files. I had to make changes to them to get them to work, but you don't have those changes. If you copy the text from the version in github and paste it over yours, then make your changes again, I think this will fix the merge conflict.
https://github.com/Roll20/roll20-character-sheets/blob/master/mutant_cronicles_3/sheet.json
https://github.com/Roll20/roll20-character-sheets/blob/master/conan-2d20/sheet.json
https://github.com/Roll20/roll20-character-sheets/blob/master/Infinity-2d20/sheet.json

Ok Phil , the changes to the Json files were just a bit of text explaining about the rollable table that the character sheet needs , will sort that out and submit another pull request
Rob
Sent from my iPad

On 21 Jun 2016, at 00:15, Phil<EMAIL_ADDRESS>wrote:
You have merge conflicts. I'm 90% sure it's because of the sheet.json files. I had to make changes to them to get them to work, but you don't have those changes. If you copy the text from the version in github and paste it over yours, then make your changes again, I think this will fix the merge conflict.
https://github.com/Roll20/roll20-character-sheets/blob/master/mutant_cronicles_3/sheet.json
https://github.com/Roll20/roll20-character-sheets/blob/master/conan-2d20/sheet.json
https://github.com/Roll20/roll20-character-sheets/blob/master/Infinity-2d20/sheet.json
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yeah, the issue was that I had also made changes to those files. When 2 different people make changes to the same file, Git gets confused and that's where the conflicts happen. The changes I made were to fix the JSON formatting. When you have quotes ( " ) in a string that uses quotes "This string has a quote " in it" the json breaks because it sees "This string has a quote " a the whole string and then a bunch of extra text at the end ' in it" ' and breaks. The way to fix this is to "escape" the quotes, or put a backslash in front of it "This string has a quote " in it", this way the JSON knows the " in the middle is part of the string, and not the end. This is what I did for your JSONs. If you take my changes and replace your files with them, then commit, then make your changes that should fix the conflict.


fix(components): scalar button loading state

this pr updates the scalar button component in order to fix the loading state:
before (loading markup always shown)

after
(is chilling)

(is loading)

Looks good! I think we used to have the loading on the side and always show the label (rather than hide the label when we show the loading spinner). But personally I do like it this way, @cameronrohani thoughts?

Looks good! I think we used to have the loading on the side and always show the label (rather than hide the label when we show the loading spinner). But personally I do like it this way, @cameronrohani thoughts?

yes! favored keeping it the same size while making it change state vs being it stretched out but up to discuss if need :)


fix the override reconcile timeout test (#320)

TestOverrideReconcileTimeout is failing on Autopilot cluster, add logic to scale up the Autopilot cluster before creating the pod for test.
Pull in resourcegroup package and update klog version from v2.60.1 to v2.70.1

I believe this should fix the test failure observed here. PTAL
/hold
/cc @xinnywinne
/cc @tiffanny29631
/cc @nan-yu

/lgtm

/unhold


Call mi_thread_done() for multi times when a thread is done

I add printf in mi_thread_done():
#include <unistd.h>
static void _mi_thread_done(mi_heap_t* heap) {
    write(0, "_mi_thread_done run !\n", sizeof("_mi_thread_done run !\n"));
  mi_atomic_decrement_relaxed(&thread_count);
  _mi_stat_decrease(&_mi_stats_main.threads, 1);

  // check thread-id as on Windows shutdown with FLS the main (exit) thread may call this on thread-local heaps...
  if (heap->thread_id != _mi_thread_id()) return;

  // abandon the thread local heap
  if (_mi_heap_done(heap)) return;  // returns true if already ran
}

This two line is added by me.
And for testcase:
#include <pthread.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>

void *p;

void* thread(void *)
{
    p = malloc(1);
    return NULL;
}

int main()
{
    pthread_t pt1, pt2, pt3;
    if (pthread_create(&pt1, NULL, thread, NULL))
        return -1;
    if (pthread_create(&pt2, NULL, thread, NULL))
        return -1;
    if (pthread_create(&pt3, NULL, thread, NULL))
        return -1;
    if (pthread_join(pt1, NULL))
        return -1;
    if (pthread_join(pt2, NULL))
        return -1;
    if (pthread_join(pt3, NULL))
        return -1;
    return 0;
}

Run result:
$ clang test_release.c libmimalloc.a
$ ./a.out
_mi_thread_done run !
_mi_thread_done run !
_mi_thread_done run !
_mi_thread_done run !
_mi_thread_done run !
_mi_thread_done run !
$

each thread run mi_thread_done for twice.
I debug it and find out: when the first time running mi_thread_done(), it will run mi_heap_done() -> _mi_heap_set_default_direct() -> pthread_setspecific().
run pthread_setspecific() in a thread destrucrtor function will let it run the destrucrtor function again !

the global var thread_count in mimalloc will even becomes a negative number

Ha, great -- that was indeed a bug! fixed in the latest dev and dev-slice. Thanks again!


Users without fedoraAdmin role can't upload images; other roles needed

With a fresh install, uid1 can add a Repository Item with model=Image, add Member media of type Image, and node displays image.
With a new user with administrator role (by default, receives all available permissions):

drush user:create administrator<EMAIL_ADDRESS>--password="administrator"
drush user:role:add "administrator" administrator

Add Repository Item with model=Image, add Member media of type Image, Media User=Original file, on "Save", error message "This value should be of the correct primitive type." displays with Alternative text input highlighted (even though Alternative text contains data).
Drupal watchdog reports "The file permissions could not be set on fedora://2019-02/PH17-003.jpg." and "Source image at fedora://2019-02/PH17-003.jpg not found while trying to generate derivative image at fedora://styles/thumbnail/fedora/2019-02/PH17-003.jpg."
web/sites/default/files/2019-02 only contains Service File and Thumbnail Image jpegs from uid1 earlier.
Adding extra role fedoraAdmin to administrator user allows the image upload to proceed.
Sounds like something special is happening for fedoraAdmin role that should available for other roles...?

FYI, if I add Repository Item nodes with Model=Binary, add File media with a .tif file then media is accepted for both uid1 and uid3 (administrator role).

@kayakr yes, this is due to WebAC and the fact that we don't do anything with WebAC yet. So the default policy in Fedora is read-only unless has role fedoraAdmin.
So for the claw-playbook we add the role and add admin to it [1].
So we could define a different default WebAC and apply that, but we haven't...yet.

Maybe we can rig Syn/Fedora to use the authenticated user role instead of fedoraAdmin by default?

That would give every user of Drupal admin rights to your Fedora and the abililty to add/edit/delete. I think altering Syn to accept a configurable "admin" role is better. But also, we could add a default WebAC for the claw-playbook that would allow read-write to all users by default.

Eh... yeah... For vagrant that more permissive default is fine, but for anything else, you're right.  I see we need to make the distinction between a drupal user and a drupal user that can write to fedora for most other situations.  I'm not sure what a better default would be.  Documentation would certainly help in the interim, so I'll toss this on the pile of requested documentation and maybe we can handle it during the sprint.

Suggest the title be renamed "Users without fedoraAdmin role can't upload images" as I think that's the crux of this issue?
Seems like WebAC Authorization Delegate and Web AC Auth Delegate: Example Scenarios  are the adjacent docs, I'm going to give that a try on a local instance.

I faced a reasonably similar issue this morning, in that as an anonymous user I couldn't create images and got the same error message "The file permissions could not be set on fedora://..."
Here's how the situation arose:

As an Editor (I have the fedoraAdmin role) I add a Media entity to a Node and click Save (published = true)
The Media is rendered through a View Mode which formats the Image using a Responsive Image formatter
I now open the page in a private browser session (Anonymous user, without the fedoraAmin role) and try to resize the page to see how the images are going to look on different devices
I see the image that was rendered while I was logged in as an Editor, but as I resize the page none of the other images load
As an Admin I see the log entries with "The file permissions could not be set on fedora://..." for each of the image styles in the responsive image configuration (except for the one I loaded while I was an editor)

The old plain image field stored images at sites/default/files/... but now that I'm using a media entity reference field it is storing the image using uri_scheme: fedora. Is there a way to tell it to store the image styles using uri_scheme: public?
Many thanks!

One way I thought of getting around this - for the case I outlined above is to override ImageStyle and re-route styles to the public uri scheme, if they match any of the styles that are meant for public consumption:
// .module file
use Drupal\Core\Entity\EntityTypeInterface;
use Drupal\dhr_media\Entity\PublicImageStyle;

/**
 * @param EntityTypeInterface[] $entity_types
 */
function dhr_media_entity_type_build(&$entity_types) {
  if (isset($entity_types['image_style'])) {
    $entity_types['image_style']->setClass(PublicImageStyle::class);
  }
}

And, the override:
namespace Drupal\dhr_media\Entity;

use Drupal\image\Entity\ImageStyle;
use Drupal\Core\StreamWrapper\StreamWrapperManager;

class PublicImageStyle extends ImageStyle {

  protected const PUBLIC_IMAGE_STYLES = [
    'dhr_bootstrap_breakpoint_xs',
    'dhr_bootstrap_breakpoint_sm',
    'dhr_bootstrap_breakpoint_md',
    'dhr_bootstrap_breakpoint_lg_xl',
  ];

  /**
   * {@inheritDoc}
   */
  public function buildUri($uri) {
    $uri = parent::buildUri($uri);
    if (in_array($this->id(), self::PUBLIC_IMAGE_STYLES)) {
      $scheme = StreamWrapperManager::getScheme($uri);
      if ($scheme !== 'public') {
        $scheme_pos = strpos($uri, $scheme);
        if ($scheme_pos !== FALSE) {
          $uri = substr_replace($uri, 'public', $scheme_pos, strlen($scheme));
        }
      }
    }
    return $uri;
  }

}


2.0.x make install does not install headers

In the 2.0.x branch, doing a make install does not install the headers anymore.  The headers are installed in the 1.1.x branch.  Looks like commit 6335e666 removed them from Makefile.am.

The secauth branch is migrating to cmake. We'll have a better way of installing headers without having to name each one when that gets merged into 2.0.x.

The 2.0.x cmake toolchain now installs headers. The 2.0.2 release will include this functionality.


test_update.py failing

When I try to run the test suite, but the repository is dirty, or I am some commits ahead of the commit I did python setup.py egg_info --egg-base . , I face an assertion error on the line 101 of test_update.py
# ...
assert __version__ == str(self.pyscaffold_version())
# ...

Usually, the versions diff by a .dirty or .dev<N>... != .dev<N+1>... suffix .
The way I made it work was by running python setup.py egg_info --egg-base . again.
However always running this workaround can be a little bit annoying.
We could include this command in the tox.ini, but is it the best idea?
@FlorianWilhelm, what do you think?

Thanks for the PR! I'll look into the test_update issue with a dirty workspace. I think we can just use the Version object and there is some kind of method that only returns (major, minor, patch). Can I just revert to the original tox.ini after that?

BTW, if you pull from master, make sure you delete all egg files especially the one under src before you do python setup.py egg_info --egg-base . one time.

Thanks @FlorianWilhelm! Should we also discard the dev notes on CONTRIBUTING.rst? Or instead keep the notes there and also add your comment about deleting the egg files (it might me useful)?

After the last changes, the case when the repository is dirty was solved.
However, if the development version is commits ahead, we will also have problems.
After making a commit (changes in tox.ini), and running the test again, I had:
>       assert self.running_version.public == self.pyscaffold_version().public
E       AssertionError: assert '3.1b2.post0.dev1' == '3.1b2.post0.dev2'
E         - 3.1b2.post0.dev1
E         ?                ^
E         + 3.1b2.post0.dev2
E         ?                ^

tests/test_update.py:102: AssertionError

Why should we delete the dev notes? I think it is better to extend them since it helps new developers to become a contributor.
The  self.running_version.public == self.pyscaffold_version().public is expected. One could use .base_version which would result in 3.1 but then it has almost no more information. At that point I only wanted to check that the pytest-virtualenv plugin does not install pyscaffold with the help of PyPI which happened a lot at first. Maybe we should just drop the assert? You could comment it out with a note if you want.

I agree in expanding the notes :)
In the open PR I have created a new troubleshooting section where we can include these kind of information and added the last comments there
If I understood it correctly, running_version will be the version of the source code when the developer did python setup.py egg_info --egg-base . and pyscaffold_version() will be current version of the source code (if the installation using python setup.py develop  behaves well). Would it work if we just compare using <= instead of ==? Is it correct from the conceptual point of view? I will test this approach...

Right! Of course, using <= instead of == should do the trick! I only want to make sure that pytest-virtualenv is not pulling some officially released version von PyPI in the background and <= does that.

I have presented a PR for this in #199. In the end I have changed == to <=, but also included a check to see if PyScaffold installation is editable, trying to capture exactly what you have said.

Thanks a lot! This is even more robust than before. I think we can close this now.


Documentation on Deploying Python functions to Premium

I'm attempting to deploy our Azure Python functions onto Premium for performance/runtime reasons but I'm unable to get it working.
I've followed the guidelines here: https://docs.microsoft.com/en-us/azure/azure-functions/run-functions-from-deployment-package but they seem mostly related to Windows.
I have tried..

Deploying through our existing pipeline which was already utilizing WEBSITE_RUN_FROM_PACKAGE = true. This pipeline still deploys successfully to our Consumption plan.
Manually changing the WEBSITE_RUN_FROM_PACKAGE value to the blob storage location of the package.
Deploying using the Azure CLI command 'func azure functionapp publish'

Regardless when I go to my functions I see this...

Which routes me to the documentation I referenced above. Is there any other documentation to deploying these, or something obvious I'm missing?

Can you check if the app has these 2 app settings
https://docs.microsoft.com/en-us/azure/azure-functions/functions-app-settings#website_contentazurefileconnectionstring
WEBSITE_CONTENTSHARE
WEBSITE_CONTENTAZUREFILECONNECTIONSTRING
If you can share the app name I can also verify the config. (https://github.com/Azure/azure-functions-host/wiki/Sharing-Your-Function-App-name-privately)

I was able to resolve my issues by deploying to EastUS instead of EastUS2. There must have been some sort of support feature missing for this in EastUS2.


fix(MetaflowData): Raise AttributeError on failed __getattr__ access

Python's custom attribute access protocol requires AttributeError to be raised on access failure (docs link). The current implement propagates KeyError from dict, which breaks hasattr() operations on MetaflowData.
This PR checks for key existence and raise the correct exception in MetaflowData.__getattr__.
Fixes #1970.

LGTM. We can merge shortly


TreeDropDown performance boost.

TreeDropDown has very poor performance when dealing with thousands of pages. The main problem is that filtering and applying limits happen only after all pages are loaded which results in terrible performance.  This patch addresses both issues and filters and limits lists before further processing is done.
This patch aims to preserve original functionality. The only exception is that it changes the default children method from AllChildrenIncludingDeleted to AllChildren on TreeDropDownFIeld so we can use DataList instead of ArrayList in the processing.

This change adds a new API so it'll need to go into the 3 branch.

If there are too many pages the processing is simply skipped and user will see "Too many pages" message.

Does this mean the field is completely unusable if there are an arbitrary number of pages?

I'm testing the TreeDropdownField with ~4000 pages. Before, this change the performance was quite poor:

it takes about 25 seconds to create a link in the WYSIWYG editor in the CMS
it takes about 160MB of memory to process such request

It the best case this results in poor performance, in worst case it breaks the application as it hits the memory limit (this depends on your configuration).
After this patch the performance is as follows:

it takes about 5 seconds to create a link in the WYSIWYG editor in the CMS
it takes about 60MB of memory to process such request (which is roughly the same as other requests in the CMS) and the amount of memory no longer increases with addition of new pages

Does this mean the field is completely unusable if there are an arbitrary number of pages?

No, it is the same as SiteTree currently does, when there are too many leafs to show, it'll show a message. A search for a specific page, or a part of it, will limit the amount of results and therefore will return a useful list.

thanks :)

@mfendeksilverstripe I've been looking at merging this work up into master (v4) but there's been quite a big re-write of that work and it looks like it'll be similar in terms of efficiency as to what you have.
The only issue is that the $filteredIDs is not passed into our MarkedSet object and so this information is not acted on...
It's too complex for me to merge this up myself, I'm afraid

@mfendeksilverstripe you're my hero buddy.
Working with a site-tree where one node has > 13,000 children and this performs perfectly.
--
Matt

@hailwood I'm glad you like it :)

@dhensby I would expect SilverStripe 4 to have this case already covered. Link editing in the CMS is a core functionality and it has to work properly even if there are thousands of pages.
The idea behind my changes is not that too complex - I only push filters and limitations before we actually change the DataList into ArrayList. Even if the implementation on SS4 is different the same idea should be used there as well.

@mfendeksilverstripe sure - but the effort to apply it against the diff was too great given my time constraints and context.
Would you have time to look into it in the 4 release?

@dhensby Sure, I'll have a look.

@dhensby I was able to integrate these changes to SS4. Please see following PRs:
https://github.com/silverstripe/silverstripe-framework/pull/7129
https://github.com/silverstripe/silverstripe-cms/pull/1882
https://github.com/silverstripe/silverstripe-lumberjack/pull/57
To get a functional site that has ~4000 pages, you need to have all three components.

thanks so much :)

This change adds a new API so it'll need to go into the 3 branch.

This got merged in to 3.5 and has since made it in to 3.6... was that an accident?

gah :/ yes - it should have gone into 3 and not 3.5 / 3.6 if they had been released :(
Sorry - we can revert it and merge into 3 instead - but it may be a little late for that now...

I don't think this has made it in to a tagged release yet - it's waiting in the 3.5 and 3.6 branch. So from a SemVer perspective it should be possible to revert it without impacting anyone. Will that cause a big mess / be very difficult?

yep, you're right - this can be reverted and moved into 3

Well, it can indeed, but it will cause a mess for the people who use this change and actually profit from it?
Not disagreeing, but a way of applying the patch manually as a backup option would be a good idea maybe?

It's caused a regression as reported by @jonom - it's a new API and so shouldn't make a patch release. People who "rely" on dev branches for their code need to accept that comes with some risk. We can't wrap this in some "backup" option as that's just more semver violations.
If users need this fix they can get it from 3.x-dev or 3.7.x-dev instead of 3.5.x-dev or 3.6.x-dev. I think that's acceptable.
We should aim to investigate the regression a bit more as if it's causing breakages it'll need to be removed from 3.x-dev too :/

we are seeing issues being raised because of this change:

https://github.com/silverstripe/silverstripe-subsites/issues/286
https://github.com/silverstripe/silverstripe-framework/pull/7182

@mfendeksilverstripe do you have any desire to look into the cause of these problems as if there's a regression in the 3.x line when it comes to release 3.7 we'll have to revert this change...


Add ability to interweave/deinterweave ROM pieces

There might be times where we might dump EPROM pieces that need to be interweaved or deinterweave ROMs for comparison. It'd be nice if the tool could do this, and maybe provide a hex output of the first couple bytes after the procedure so we can check the results.

We might want to give the user the ability to choose the ROM size to deinterweave by Megabit.


Is there any way to identify that the wifi is secure or not?

By using this library, Is there any way by which I can identify that each wifi from wifi list is secure or not?

Yeah, I have forked and update the library. You guys can clone the library from here and you'll get one more boolean parameter as secure along with ssid and level.


Analyzers for BOM & consistent line endings?

I regularly encounter two problem when developing cross platform:

Unicode BOM
inconsistent line endings (\n \r \r\n etc.) which are not in multi line strings.

I have not found analyzers for these things. Can & Should they be implemented as analyzers?

They can be implemented as analyzers, it would not even be too hard.
It would be appreciated if you could write up separate issues detailing each of the proposals. For inspiration you can look at all issues marked with the new rule tag.

Note that SA1412 is available for byte order mark (BOM) checking.

I support a consistent line endings rule.


⚠ Fortnite has degraded performance

In 9cba40c, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1630 ms

Resolved: Fortnite performance has improved in 1c3d0ad.


FreeRDP closes second after authentication

Session opens for a split second and then closes.
This is what i got.
[08:27:55:012] [3327:3328] [INFO][com.freerdp.core] - freerdp_connect:freerdp_set_last_error_ex resetting error state
[08:27:55:012] [3327:3328] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[08:27:55:012] [3327:3328] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[08:27:55:012] [3327:3328] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[08:27:56:470] [3327:3328] [INFO][com.freerdp.primitives] - primitives autodetect, using generic
[08:27:56:485] [3327:3328] [INFO][com.freerdp.core] - freerdp_tcp_is_hostname_resolvable:freerdp_set_last_error_ex resetting error state
[08:27:56:485] [3327:3328] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[08:27:57:512] [3327:3328] [ERROR][com.winpr.timezone] - Unable to find a match for unix timezone: /Vienna
[08:27:57:814] [3327:3328] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[08:27:57:814] [3327:3328] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB16
[08:27:57:914] [3327:3328] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem
[08:27:57:956] [3327:3328] [ERROR][com.winpr.library] - LoadLibraryA failed with Error loading shared library /usr/lib/freerdp2/librdpsnd-client-fake.so: No such file or directory
[08:27:57:957] [3327:3328] [WARN][com.freerdp.addin] - Failed to load channel rdpsnd [fake]
[08:27:57:957] [3327:3328] [ERROR][com.freerdp.channels.rdpsnd.client] - [static] Unable to load sound playback subsystem fake because of error 1359
[08:27:57:991] [3327:3328] [ERROR][com.freerdp.core] - [static] rdpsnd_virtual_channel_init_event_ex reported an error. Error was 1359
[08:27:57:991] [3327:3328] [ERROR][com.freerdp.core] - checkChannelErrorEvent() failed - 0
[08:27:57:991] [3327:3328] [INFO][com.freerdp.client.common] - Network disconnect!
[08:27:57:991] [3327:3328] [ERROR][com.freerdp.client.x11] - Failed to check FreeRDP file descriptor

Looks like your package is broken?

I reinstalled it like a thousand times running on Alpine Linux, i cant find the issue here really confusing me.

I ran into the same or at least a similar issue, do apk install freerdp, it seems it's not a required dependency.


bring up to date with upstream branch

Sync with main branch

CLA:
I have read the CLA Document and I hereby sign the CLA
Code of Conduct:
I have read the Code of Conduct and I hereby accept the Terms


Remove wyrm_addons/pygments

Fixes #503

This is not ready for review because I still need to fix things like text and spacing in our own sass

This is ready for review now

Looks pretty good as far as I can see, although the line-height feels a bit too much considering the font size and shape (I'm using macOS, which has Consolas). Previously the line-height was normal (== 1.2), now it is 1.5.
Screenshots below of possible other values. 1.5 looks better to me if the fontsize is a bit larger (14px?), but maybe I'm just nitpicking.

line-height: 1.2 (current value in 0.2.4)

line-height: 1.3

line-height: 1.4

line-height: 1.5 (new value)


produce execute_input message when execute_request is handled

address incomplete protocol implementation to improve experience with nteract components

Nice! For future GitHub archaeologists, here is the related issue in the nteract repo: https://github.com/nteract/nteract/issues/4541


How and to where should ACA-Py Container Images be published?

Currently, container images for ACA-Py are produced from this repo: https://github.com/bcgov/aries-cloudagent-container, and published to Docker Hub here: https://hub.docker.com/r/bcgovimages/aries-cloudagent.
Is it time to:

Put the script/process to create the images into the ACA-Py repo vs. a separate one
Publish the images to a Hyperledger repo vs. a BCGov one?

Opinions welcome on this and any other suggestions on changes to the container image publishing process.
Thanks!

I think the image(s) should be published as part of the ACA-Py release process, and I'm leaning toward the images living in the Hyperledger Docker Hub.  The other option would be publish the images in the ghcr.io repository linked to the project.
@ryjones, Do you have any strong preferences to Hyperledger Docker Hub or ghcr.io?
I also think the image build/publish could be refactored and simplified as a GHA workflow that is triggered on a release.

@WadeBarnes please us github packages. It's free and it works. here is an example of how it works in another Hyperledger project

When this gets done, please update the guidance in PUBLISHING.md (currently describes the aries-cloudagent-container approach).
How do we get people currently using the docker/bcgovimages transitioned over to using the new Hyperledger images?

Also -- this issue should also address #1546 when the update is made.

Images are published here; https://github.com/hyperledger/aries-cloudagent-python/pkgs/container/aries-cloudagent-python
Images are built and published automatically when a GutHub release is created.


Enhancement: Perplexity AI Integration

Contact Details
<EMAIL_ADDRESS>What features would you like to see added?
pls add support for perplexity.ai custom endpoint and api
https://docs.perplexity.ai/docs/getting-started
i want to use these models in Librechat -- Mistral 7B, Llama 13B, Code Llama 34B, Llama 70B, and Replit 3b.
it can be achieve via perplexity api
it will be very helpful feature for users like me
thx in advance
More details
https://docs.perplexity.ai/docs/getting-started
i want to use these models in Librechat -- Mistral 7B, Llama 13B, Code Llama 34B, Llama 70B, and Replit 3b.
it can be achieve via perplexity api
it will be very helpful feature for users like me
thx in advance
Which components are impacted by your request?
Endpoints
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks, I will look into it. Have you tried OpenRouter, it also has access to some of these

ok thx yes i tried that as well but i like perplexity more :)


Linking Godot project in Xcode results in entire project folder in archives

Godot version:
3.2.3 stable xcode 11.3
When exporting for iOS and linking the Godot project in Xcode, the entire project folder is added to the archive that is then uploaded to App Store Connect. This includes any asset sub-folders and the .import folder which may contain no longer valid .stex resources.
a 200mb export (arm64 only) without a linked Godot project becomes a 600mb export using the linked project instructions per the docs.
https://docs.godotengine.org/en/stable/getting_started/workflow/export/exporting_for_ios.html
Minimal reproduction project:
Export a project for ios and link existing Godot project. Create an archive, 'show in finder' and 'show package contents' on  products > application > app.  Compare folder structure and size to an archive created without a linked project.

@tommiemartin what do you want to achieve by linking Godot project to already exported Xcode project?
If you link any folder with create folder reference mode to any Xcode project it will add a copy files build step, which copies entire directory including hidden files and folders. This files also will be treated as bundle files, so they will not be removed or affected by App slicing on archive upload to App Store. This results in increased app size which cannot be affected by App Store upload process. So this behavior is expected.
If the resulting .xcarchive file is 200mb in size, it would probably be sliced to ~30MB for device when uploaded to App Store, but this mostly depends on assets only. For example empty Godot project is 18-20MB in size when installed on device. You can check on-device app size in App Store Connect portal after uploading your .xcarchive.
But as I said files and folders that are treated as bundle files most likely will not be removed.

@naithar thanks for the explanation and yes it behaves how you stated. The problem is this is the suggested way to edit in the Godot editor and build in xcode without additional exports per the link above. My current project is 3d with a 200Mb of assets and this was resulting in the .import and resource folder ending up in the archive which was a lot of unwanted bloat.
As a side note not sure if the apple suggested on-demand resourcing / 'asset tagging' will be implemented going forward but this would also be very useful for asset heavy games.

The problem is this is the suggested way to edit in the Godot editor and build in xcode without additional exports per the link above.

You can also use Import .pck to only import .pck file which contains code and assets to keep Xcode project untouched. But you don't really need editing mode when you upload application to App Store, so it's size shouldn't be affected.

As a side note not sure if the apple suggested on-demand resourcing / 'asset tagging' will be implemented going forward but this would also be very useful for asset heavy games.

Well, you can probably create a correct proposal for this feature to be added into engine.

Yes, simply re-exporting the .pck and overriding the existing one in the xcode project directory is a much cleaner way to handle this. Perhaps we should have a iOS re-export .pck  button next to the android live edit button.

There are some WIP PRs for one-click deploy/live edit for iOS: https://github.com/godotengine/godot/pull/33086.
But I don't think re-export .pck should be at live edit section.

Bunping this issue because to me, this is a major pain when developing to ios and there seems to be no reasonable workaround...

Bumping this issue because to me, this is a major pain when developing to ios and there seems to be no reasonable workaround...

The way I got around this was too keep my project folder clean of any unnecessary files or folders. The biggest one to watch out for it the folder that contains all the .stex files and textures. From what I recall (haven't used the engine in a while) textures remain in this folder even if not referenced anywhere in your project. I sorted by size and removed things I was certain it didn't need. Make sure to make a full project backup before doing this. Deleting a referenced stex file can cause the project to hang while loading. You might have to redo materials if you delete the wrong things here but with adequate cleanup the size will be about the same as the android version.


fix(cli): Fix and clean client modes and fetch presets

i think preset can be moved to node cli args and not inside the primitive crate altogether -- to a clap enum. It would allow clap to show a proper error message when the preset is unknown, with a list of the possible values. Much better UX

also, i dont know what the default impl on ChainConfig means, try to remove it and see if it was useful
(i just dont know why it's there it feels weird)

This PR will be handled by @akhercha from now on

Everything's done, just not sure about the ChainConfig overrides as I said above + this comment:

update the example config file

Wdym? I updated the comments inside but happy to do more. @cchudant


Avoid Visual Feature Using and Collecting for Overlapped Boxes

When the boxes are heavily overlapped the features tend to be of a poor quality. This request introduces the requirement to avoid using such features in comparisons or collecting them to the track for future use.

PR #59


Bump up version to v0.7.1.

Codecov Report

Merging #44 (dd85e25) into main (4d68c08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   96.72%   96.72%
=======================================
  Files          18       18
  Lines         610      610
  Branches       64       64
=======================================
  Hits          590      590
  Misses         20       20

Flag
Coverage Δ

unittests
96.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d68c08...dd85e25. Read the comment docs.


Improve the Email templates

Is your feature request related to a problem? Please describe.
We need to update the mentor acceptance/rejection emails
Describe the solution you'd like
This is the content for mentor acceptance email:
Dear [Mentor Name],
I hope this email finds you in high spirits! I am delighted to inform you that you have been selected as a mentor for ScholarX '23, and we extend our heartfelt congratulations to you!
We received a large number of qualified applicants, and after a thorough review of all candidates, we are thrilled to invite you to accept a place in our program. Your profile stood out amongst the others, and we are confident that you will contribute positively to our program.
We understand that your hard work and dedication have brought you to this moment, and we recognize your exceptional talent, experience and potential in your respective fields. We are excited to have you join our community of learners and scholars.
We look forward to seeing the unique perspective and insights you will bring to the mentees and to the program. We believe that you will flourish in this year's edition of ScholarX, and we are thrilled to be a part of your academic or professional journey.
Once again, congratulations on your selection! We cannot wait to have you on board. We will keep you informed on the next steps, and in the meantime would like to invite you to go through some of the resources that would be useful to thrive as a great mentor in ScholarX '23

This is the template for rejected mentors:
Dear [Mentor Name],
I hope this email finds you well. I wanted to take a moment to thank you for your interest in joining ScholarX '23 as a mentor and for submitting your application. We appreciate the time and effort you put into it.
After careful review of your application and considering all of the candidates, we regret to inform you that we are unable to make you part of the mentor base at this time. We received a large number of qualified applicants, and unfortunately, we could only accept a limited number of Mentors.
We understand that this news may be disappointing, and we encourage you to not be discouraged by this decision. Please know that this does not reflect on your abilities, potential or value as an individual. As you progress ahead on your academic or professional journey, we would be glad to have you as mentor for future ScholarX programs
We appreciate your interest in our program and would like to wish you all the best in your future endeavors. We are grateful for the opportunity to consider you for our program and encourage you to keep pursuing your goals and aspirations.
Thank you again for considering our program and for the time you invested in your application. We hope you find success and fulfillment in your academic and professional pursuits.

Describe alternatives you've considered
Related file: https://github.com/sef-global/scholarx/blob/scholarx-2023/src/main/java/org/sefglobal/scholarx/util/ProgramUtil.java
Additional context
N/A
Are you working on it?
No

will I do this?

Yeah. Go ahead @chirandevinda


Expect to support scrollbar, scrollbar, and toggle of ugui

Expect to support scrollbar, scrollbar, and toggle of ugui

Scrollbar is added to Sample.
Toggle will have to wait a little longer.
https://github.com/kyubuns/AkyuiUnity/blob/main/SampleXd/Public Game UI.xd

Thank you very much for your answer. If dropdown supports the above three basic ugui components, it is almost enough. Thank you again for your open source

Thank you very much for your answer, scrollbar, dropdown, and scrollbar. If these three are supported, the basic ugui basic components are almost implemented. Thank you again for your open source

Thank you very much for your answers, scrollbar, dropdown, and toggle. If these three are supported, the basic ugui basic components are almost implemented. Thank you again for your open source

New Toggle support!
https://github.com/kyubuns/AkyuiUnity/releases/tag/v1.3.5

Dropdown may take some time, so we will move it to Discussions and support it once we have enough votes.
https://github.com/kyubuns/AkyuiUnity/discussions/36

good job!Thank you very much


Aggregate functions

Still Working on it, Don't merge it yet !!!...
Resolves small part of issue #5.

Aggregate functions are finished.
Please review and merge the PR.


[Question/Support] Model Methods..? How to implement this correctly?

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[x] Support request
[ ] Other... Please describe:

From OOP, I'm used to write my model-class like this:
class Person (){
    firstname: String = ''
    lastname: String = ''

    fullname() { return this.firstName + this.lastName }
}

Note the method fullname() lives inside the class.

In Akita my person.model.ts looks like this:
// person.model.ts

export interface Person {
  firstName: string;
  lastName: string;

}

export function createPerson(params: Partial<Person>) {
  return {
    firstName: '',
    lastName: '',
  } as Person;
}

My Question:
In the Akita arkitecture, where is the fullname() method supposed to be?
➡ My main goal is that the method is on the model/entity, and not in some controller. As you probably know, way to often, this logic stuff ends up scattered around in "controllers". I would like to avoid that 🤔🥳

https://datorama.github.io/akita/docs/additional/class/

https://datorama.github.io/akita/docs/additional/class/


Precondition Generation

Design and implement algorithm to generate preconditions for field validator and accessor functions from record type invariant.

(Adding this from the Wiki so we can discuss it here)
For each component in a record type a validation and an accessor function is generated. The preconditions of these functions are derived from the type invariant of the record in the following way:

iterate over the components of the record
for each component determine, if the type invariant refers to any previous component or the current component

if this is not the case, continue with the next component
if it refers to any previous or the current component, replace all relations containing unknown components with True and simplify the expression
if it refers to the length of the current component, replace these relations with relations to the buffer length by adding the offset of the current component

add the resulting expression as body of the validation function and as precondition of the accessor function

if it refers to the current component, replace all relations which are refering to the the current component with True and simplify the expression

add the resulting expression as precondition of the validation function

Works for the Ethernet example, cf. https://github.com/Componolit/RecordFlux/commit/4bfbc324c5ea32a6608cce085a3b666faa10da95


twitter auth Experiment 6

We are getting "TWITTER_RATE_LIMIT_ERROR: 429 Too Many Requests" errors in production.  And none of my newer log lines except "request.path" and being logged, which indicates some sort of bug, or misconfiguration.
It still is working perfectly on my local API server and WebApp server with developer Twitter credentials.
Added config logging to confirm that we are configured correctly.

Hi @SailingSteve we may have maxed out our Twitter API calls for the last 24 hours. I'm not sure what we can do about this in the long run, but for now you can probably shift your focus to another issue unless you have other ideas. I'll post this pull request now. 👍


Core serials differ between launch data and core lookup

disclaimer: might be the same for capsules
example
https://api.spacexdata.com/v2/launches/latest
The core serial is listed as B1032.2 but if you then hit https://api.spacexdata.com/v2/parts/cores/B1032.2
It's incorrect. The serial is actually B1032
If it makes sense to suffix the serial with a .X for number of flights, that could be a separate field.

Looks like the latest launches core serial was a mistake, I haven't been listing the number of reuses in the core serial, since it would make a unique number each time, making it harder to compare against.
We could add a new field for the number of previous flights of the core for each launch, but the data should already be in the detailed core data.

@jakewmeyer ok, Just che

@jakewmeyer ok, just checked and it looks good now. I'll leave the decision about reuse numbers up to you.

I'll go ahead and add it in the core section for each launch, I think it's valuable info to have 👍

flown?

Flown sounds more like a boolean value though, instead of an incremental amount. Maybe flights?

flights is great 👍

Added the field for past and upcoming launches, slight adjustment from flights to flight for clarity 👍


[Identity UI] Consider adding more id or similar attributes

These packaged UI elements are going to need to be style-able using CSS, so maybe it's worth adding more id or class or even just data-xyz attributes to various elements (for example, the sections on the Login page with the user/password and the external providers, or the individual buttons for the providers), and documenting those attributes for designers to work with.
Happy to contribute this if wanted.

We'll happily accept contributions :)

@blowdart What are the chances I can introduce 0-day vulnerabilities by adding HTML attributes? 🙀


[e2e]: go tag main adversarial-asset-binary slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v12.0.59
Run: https://github.com/slsa-framework/example-package/actions/runs/2634044727
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Trigger: push
Branch: v12.0.59
Date: Fri Jul  8 05:21:06 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v12.0.60
Run: https://github.com/slsa-framework/example-package/actions/runs/2639941745
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Trigger: push
Branch: v12.0.60
Date: Sat Jul  9 05:07:47 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v12.0.61
Run: https://github.com/slsa-framework/example-package/actions/runs/2643486169
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Trigger: push
Branch: v12.0.61
Date: Sun Jul 10 05:12:57 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v12.0.62
Run: https://github.com/slsa-framework/example-package/actions/runs/2647399241
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Trigger: push
Branch: v12.0.62
Date: Mon Jul 11 05:21:00 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v12.0.63
Run: https://github.com/slsa-framework/example-package/actions/runs/2654310640
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.adversarial-asset-binary.slsa3.yml
Trigger: push
Branch: v12.0.63
Date: Tue Jul 12 05:32:56 UTC 2022
Tests are passing now. Closing this issue.


Feature Request: If possible reduce required python version to 3.10?

Not sure if there is something specific from Python 3.12 you are looking for but if you could reduce it to require something less than 3.12 it would make it much easier to use!

What makes it difficult to use with 3.12?

What makes it difficult to use with 3.12?

just that we may not be able to fully deploy 3.12, I wish it was something I could easily deploy just not all companies are there yet. For my personal stuff everything is already 3.12. You might be able to work around it with a pre-commit hook as I think they get their own environments but I am not 100% sure about that.

You don't need to deploy it, you just need it on your machine where you'll run this command. If pre-commit can already create Python 3.12 envs on your machine, then you already have 3.12. I don't think I want to commit to more expansive maintenance promises at this time.

I think you miss understood, I don't have the ability to use 3.12 on all our work systems. Shame as 3.10 and 3.12 are very similar so pretty sure there wouldn't have been a lot more maintenance. will check back in with the tool if/when we can roll out 3.12


[EMB-576] improve mirage types

Purpose
A number of improvements to ember-cli-mirage types for better type checking and ergonomics.
Summary of Changes

server.create(modelName, ...) now looks up the modelName in the ModelRegistry and properly types the
return values as ModelInstance<ModelFromTheRegistry> and type checks any model properties passed in. This makes use of a MirageModelRegistry so that mirage-specific properties can be added and merged with the ember-data model.
same as above, but for server.createList
traits now take a type argument (the model they are a trait for) which results in proper typing for afterCreate(model, server) without requiring manual typing of its args.
the afterCreate method of mirage factories is typed similarly to trait's afterCreate
mirage model class methods now take a type argument and their return value will be properly typed. (e.g server.schema.users.find<User>() will return ModelInstance<User>)
lots of cleanup as a result of and to make use of the above

Side Effects
n/a
Feature Flags
n/a
QA Notes
n/a
Ticket
https://openscience.atlassian.net/browse/EMB-576
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[x] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 2505

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.917%

Totals

Change from base Build 2501:
0.0%

Covered Lines:
5510

Relevant Lines:
7141

💛  - Coveralls


Crash when ABPersonCopyImageData returns nil

Hi, we're using your great library, version 0.6.1, and getting a crash from our crash reporting system (Crashlytics) on SwiftAddressBookPerson.swift line 65.
We're getting an EXC_BREAKPOINT which is most probably a swift fatal error, specifically in this case, unwrapping a nil. We got 9 crashes from 7 users after only 3 days in production.. We mainly suspect that ABPersonCopyImageData(internalRecord) returns a nil, but couldn't reproduce. Maybe the ABPersonHasImageData doesn't guarantee that you won't get a nil, and extra protection is needed..
Here is the crash report image from Crashlytics:

Even then the optional unwrapping should take care of the issue. Please make sure you are accessing the address book in a thread safe manner (one instance of SwiftAddressBook may only be used by one thread simultaneously). Dispatch queues were a constant source of random errors during testing in all iterations so far, because the app was executed in parallel to the tests, but the same instance of SwiftAddressBook was used.
Happy to know that this library qualified for your production app! Let me know if you need any other help.

There is a new version now. Please check out the newest version and close if it fixes your issue. I am not sure whether re-checking the image data after ABPersonHasImageData returned false has any effect, but let us hope the best.

By the way: Optional unwrapping should have prevented the issue, but it wasn't optional in the previous version! I already had this issue, but unfortunately my tests didn't catch that regression bug, when I published 0.6.1. I would be glad if you could add a test reproducing a state where ABPersonHasImageData returns true, but copying returns nil, so that future versions can reliably avoid such problems.

Hi, thanks a lot for your quick response! :+1:
We weren't able to reproduce it, just received crash reports regarding the matter..
We'll update to the newest release, and let you know if this bug happens again.

You could catch the error while still producing a report, that would at least prevent a bad customer satisfaction. Also interesting would be if the bug happens on all kinds of devices, with all or just some contacts, everytime on the same contact or just the first time or randomly on accessing the image.

Anything new on this one?

Going to close because there was no news any more.

Hi, sorry for the late reply, since we updated the version the error didn't happen again, thanks a lot!

Never mind :) I am happy that the fix could help you!


Copiers one list 3

Here is "the rest". We make have to break it down....

Mostly good! Lets review some of the comments quickly and get it merged without splitting it in smaller ones.

I'll remove the comments tomorrow.

It will be tough about the node:

I considered composition, but couldnt think of a good way
I considered getting rid of the list, but found no good replacement
Ironically, I think two lists would work. I like that less than implementing two interfaces, though.

Okay, the answer right at the end clinches it. Even if it is "only" Kernel development. My only option is the two list approach. I'm relying on you to reduce it to one list again :)

Then we'll need a list per class...

That is so. Unless you have a better idea, of course...
On the bright side, it was like that before I refactored it to use two interfaces :-).
The stupid thing is that a list is needed only for two reasons:

Must keep track in order to delete the custom thingies
The c functions have a different type to the c++ "convenience" functions.

@basvodde any bright ideas yet? Or a decision on the lesser evil, perhaps?

Done.


trivial typo fixes

This change is

Thanks! @homu r+

:pushpin: Commit 6d4e420 has been approved by kbknapp

:hourglass: Testing commit 6d4e420 with merge e474481...


Removing crd definitions from raw yamls

Removing the crd definitions from raw csp file from 2.1.0 onwards

If anyone will try to install from this folder which one is out , how should we fix for that?

If anyone will try to install from this folder which one is out , how should we fix for that?

So are you saying we don't need this for 2.1.0 release at all for 1.20-1.22 yamls?

from https://github.com/hpe-storage/co-deployments/blob/master/yaml/csi-driver/edge/3par-primera-csp.yaml , we should remove
For K8S 1.20-1.22 yamls has only csi-node crds
Also this is required from 2.1.0 onwards

from https://github.com/hpe-storage/co-deployments/blob/master/yaml/csi-driver/edge/3par-primera-csp.yaml , we should remove For K8S 1.20-1.22 yamls has only csi-node crds Also this is required from 2.1.0 onwards
For manual installation one has to do from kubectl create -f https://raw.githubusercontent.com/hpe-storage/co-deployments/master/helm/charts/hpe-csi-driver/crds/hpevolumeinfos_v2_crd.yaml kubectl create -f https://raw.githubusercontent.com/hpe-storage/co-deployments/master/helm/charts/hpe-csi-driver/crds/hpevolumegroupinfos_v2_crd.yaml kubectl create -f https://raw.githubusercontent.com/hpe-storage/co-deployments/master/helm/charts/hpe-csi-driver/crds/snapshotgroupinfos_v2_crd.yaml kubectl create -f https://raw.githubusercontent.com/hpe-storage/co-deployments/master/helm/charts/hpe-csi-driver/crds/hpereplicated_deviceinfo_v2_crd.yaml

Thanks. Will merge this then


Lifecycled at worker should have a window period

They should not pickup currently queued but not lifecycled, so a delay of like the last 15 mins or so should fix it. We could also skip re life cycling if the field is present.

Good point.


SuperSet as a server for static docs for warehouse documentation

Is your feature request related to a problem? Please describe.
Not really a problem, more of an opportunity.  Users of BI tools can often benefit from access to documentation of how a particular data warehouse is organized (structure, field descriptions, etc).  Hosting this type of documentation for accessibility by BI users is not necessarily a challenging topic, but it is typically an under addressed.
A popular example of data source documentation is the auto-generated docs from dbt.  Other examples might include simple Markdown documents rendered into html.  These sorts of static sites are simple enough to serve from S3, github pages, netlify, etc, but the complexity for most small data teams tends to come from adding an authentication layer.
Describe the solution you'd like
This idea may or may not be outside the scope of what SuperSet seeks to be, but it occurs to me that SuperSet could potentially be a natural platform to host such static documentation alongside charts, dashboards, SQL Lab, etc.
One can imagine the SuperSet configuration including a setting for a directory where any html documents placed within will appear under a new section on the UI.
Describe alternatives you've considered
Obviously static docs can be hosted via multiple different solutions.  The opportunity for co-locating warehouse documentation with the BI tools that rely upon such documentation is simply one of convenience.

Superset does have a static docs site: https://superset.apache.org/
There's obviously room for improvement here as superset is a OSS project. The code for these docs does lives in the codebase, as a gatsby static site, so there's no reason why you couldn't simply host these docs under a subdomain alongside superset.

Interesting consideration.
More generally, I would wish for a closer integration of dbt's models into Superset. A static documentation is a good start, but having descriptions, meta information etc available even in Explore or SQLLab would be most beneficial, in my eyes.
Synchronization of dbt models and Superset' s datasets would be great.
Not trying to steal your thread, just adding some thoughts regarding dbt...

Can be easy to setup and very useful for numerous use cases

Hi @andreamelloncelli,
This is Data Discovery(also called Data Dictionary) area. But the Superset main goal is to provide a BI. Please refer to this link for some solutions: https://medium.com/@torokyle/data-discovery-in-2020-3c907383caa0

My take on this is that we should integrate with data catalog / data dictionaries bidirectionally, through APIs and tooling.
I also really like the idea of making it easy to sync DBT models into Superset datasets. This should be pretty easy today with our APIs, it's a matter of reading DBT's manifest.json file and upserting datasets through the Superset API. That integration can live on a software package of its own, perhaps as a DBT extension, or a standalone thing.


I don't know why it can't download successfully.

D:\Program\mhxz\Webtoon-Downloader\src>python webtoon_downloader.py "https://www.webtoons.com/en/challenge/crawling-dreams/list?title_no=141539"
[21:02:06] WARNING  Creading Directory: Crawling_Dreams                                                                                webtoon_downloader.py:372
Downloading Crawling Dreams from https://www.webtoons.com/en/challenge/crawling-dreams/list?title_no=141539
Traceback (most recent call last):
File "D:\Program\mhxz\Webtoon-Downloader\src\webtoon_downloader.py", line 448, in
main()
File "D:\Program\mhxz\Webtoon-Downloader\src\webtoon_downloader.py", line 445, in main
download_webtoon(series_url, args.start, args.end, args.dest, args.images_format, args.latest, separate)
File "D:\Program\mhxz\Webtoon-Downloader\src\webtoon_downloader.py", line 383, in download_webtoon
chapters_to_download = get_chapters_details(session, viewer_url, start_chapter, end_chapter)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Program\mhxz\Webtoon-Downloader\src\webtoon_downloader.py", line 206, in get_chapters_details
in enumerate(soup.find('div', class_='episode_cont').find_all('li'), start=1)]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'find_all'
D:\Program\mhxz\Webtoon-Downloader\src>py "https://www.webtoons.com/en/challenge/crawling-dreams/list?title_no=141539"
C:\Python\python.exe: can't open file 'D:\Program\mhxz\Webtoon-Downloader\src\https:\www.webtoons.com\en\challenge\crawling-dreams\list?title_no=141539': [Errno 22] Invalid argument

I've got the same problem. Maybe they updated UI ?

我有同样的问题。 也许他们更新了用户界面？

I don't know why, but other webtoon manga can still be downloaded well (except for my network issues and I don't know which folder has missing images). At present, I have found my native language version to replace it, but there are advertisements that are not pure enough, lol

Please try now using latest master or this version https://github.com/Zehina/Webtoon-Downloader/releases/tag/v0.7.1


[Minor] After "--revert" option, the "tcpdump" package shows unmet dependencies

Describe the bug
After an issue during the 1st phase of conversion I used the "--revert" option to revert to the state before starting the conversion. I accidentally found that the optional package tcpdump showed missing dependencies afterwards:
# package-cleanup --problems
Loaded plugins: fastestmirror
Package 14:tcpdump-4.9.2-4.el7_7.1.x86_64 has missing requires of libpcap >= ('14', '1.5.3', '10')
Package 14:tcpdump-4.9.2-4.el7_7.1.x86_64 has missing requires of libpcap.so.1()(64bit)

As that package was not needed, I removed it by "yum remove tcpdump". Afterwards "package-cleanup --problems" showed no more issues.

On further tests this could not be reproduced :-(

Hm, unable to reproduce as well

I was now able to reproduce it:

./centos2alma --start --no-reboot

Repeat the 1st phase: # ./centos2alma --start -no-reboot
Revert: # ./centos2alma --revert

Now on further yum operations we see:
** Found 3 pre-existing rpmdb problem(s), 'yum check' output follows:
plesk-core-18.0-2.centos.7+p<IP_ADDRESS>+t240229.1010.x86_64 has missing requires of psa-phpmyadmin >= ('0', '5.2.1', None)
14:tcpdump-4.9.2-4.el7_7.1.x86_64 has missing requires of libpcap >= ('14', '1.5.3', '10')
14:tcpdump-4.9.2-4.el7_7.1.x86_64 has missing requires of libpcap.so.1()(64bit)
And
package-cleanup --problems
Loaded plugins: fastestmirror
Package 14:tcpdump-4.9.2-4.el7_7.1.x86_64 has missing requires of libpcap >= ('14', '1.5.3', '10')
Package 14:tcpdump-4.9.2-4.el7_7.1.x86_64 has missing requires of libpcap.so.1()(64bit)

Should be fixed in scope of #218.
Please find attached archive with new version of the tool - centos2alma.zip


No validation around slack handle

The enrollment flow displays a view for entering in the Slack handle.  Currently, there isn't any validation around entry.  If left blank the site will eventual fail due to timeout.

wrote 'fixing', but meant 'fixes'