Make auto-replacement optional

This is an alternative to #10 that makes things a little simpler. Now, there is still only one module file, but you can supply ?auto=off to disable the auto-replacement feature.
What do you think about this alternative, @octogonz? Would this work for your SPA use case?

No, this doesn't seem like it helps.
Our websites are built using Docusaurus, probably the most popular documentation system for open source projects.  Docusaurus is pretty complex web application that uses Webpack server-side rendering to create a separate .js file for each documentation page, which are dynamically loaded from a static CDN (without requiring a Node.js server).
What we need is a JavaScript module that can be bundled into a Webpack chunk and wrapped in a React component that will render the DOM nodes during React rendering.
To be clear:

We really do not want to load the emfed bundle from someone else's CDN domain
We'd prefer not to deploy emfed  with its own dedicated URL
In other words, we want a conventional API function that Webpack can bundle, not a magical runtime analysis of import.meta.url

TBH maybe it would be better for me to do the work to reimplement the emfed concept as a proper React component, and then we would also get professional CSS styling instead of global CSS templates.  I just was lazy and hoping to avoid owning the maintenance of Mastodon protocol changes and security scrubbing. 😄

Cool; all that makes sense. If this kind of import.meta trickery is unworkable for bundlers, your original idea to split the two modules is probably the way to go.
While I definitely support a fork (I am obviously not a real frontend developer and I'm sure other people could do better), I'm also interested in iteratively improving this. So I'll probably forge ahead with your module-splitting idea anyway, even if you end up going in a different direction. (If you do end up building something separate, please feel free to steal anything you like from this project!)

TBH maybe it would be better for me to do the work to reimplement the emfed concept as a proper React component, and then we would also get professional CSS styling instead of global CSS templates. I just was lazy and hoping to avoid owning the maintenance of Mastodon protocol changes and security scrubbing.

I went ahead and did this, and it turned out to be a pretty useful exercise.
Here's the result (with screenshots): https://github.com/microsoft/rushstack-websites/pull/204
Given that my case is already using React, the HTML generation simplified greatly. But relying on React probably works against your goal of providing a very tiny bundle.
I also started to think that it's important that the embedded feed to should faithfully reproduce the look & feel of the official Mastodon.  Doing so communicates clearly that it is Mastodon, and probably also gives viewers (false heheh) confidence that the feed is not fake, and also it is probably necessary for good visual appearance if we want to support advanced features like cards.
Is it possible to share anything between our implementations?
Thinking about this possibility, a library like emfed could perhaps be decomposed into several pieces:

A client API that can efficiently fetch the Mastodon feed from the network, with good error handling, and TypeScript typings for the returned objects
A renderer that faithfully recreates the official Mastodon look. It can have parameters (color theme, show "boost" button, etc) but making it extremely flexible seems not too useful, since in practice writing your own renderer is probably easier than restyling someone else's CSS.
For lightweight sites, a premade bundle that can be loaded using a simple <script> tag (as your current implementation). And maybe a free CDN URL for people who don't want to host the bundle themselves.

#3 is probably the least useful piece for my case.
But if #2 could be solved well using your minimal renderer, it could make sense for the React component to wrap that (rather than relying on React for rendering the entire feed). That could work.
Also, if you had a way to extract #1 into its own entry point or a separate NPM package, that could be useful also.

That's awesome! Glad it worked out, and it's also cool that you were able to recreate the "official" Mastodon appearance in your client.
It's a good idea to separate these various layers out. I'm going to abandon the approach prototyped in this PR and explore that separation as a way to make stuff more reusable—and hopefully easier to repurpose for different contexts in general.


Bug: warnings on Build->Test for test_quo.R

What happened?
I expected a clean run when doing Build->Test on the devel branch.

[ ] Please double check that other functions are following deprecation strategy.

Session Information

Reproducible Example
@pharmaverse/admiral
New RStudio project based off admiraldev, switched to devel branch, renv::activate(profile="4.2"), renv::restore(), manually installed admiral.test@devel and ran Build->Test:

These warnings should not occur. In the tests suppress_warning() is missing. However, the tests should be removed anyway because in admiraldev 0.4.0 calling quo_c() should issue an error. I think we need a new admiraldev issue similar to https://github.com/pharmaverse/admiral/issues/1747.

@pharmaverse/admiral can someone see if this is an issue.  it is not showing up in the CI checks

Chat with @bms63 : decided that quo_c should be removed and any call to quo_c should return an error message.
Issue #272 is focused on removing deprecated functions from admiraldev, and this issue is currently being worked on by @zdz2101 . I have asked Zelos if he prefers to have quo_c deprecation to his issue and he handle it or if I should open a new issue and handle it.

@zdz2101 will remove quo_c as part of #272. Closing this issue.


Table: Last column not correctly sized onload

This was discovered in v2 of the Table on Angular 9. We need to verify this is not an issue in Angular11. If it is, we need to fix.
Likely due to data being loaded in async. May need to expose a public 'resize columns' function.

Currently cannot produce in storybook with or without onpush

Currently cannot produce in storybook with or without onpush


bump hermann 0.24 and finagle-thrift 1.4.1

This change rolls in:

latest minor revision of hermann (kafka client)
finagle-thrift 1.4.1 - which contains a concurrency fix

:shipit:


Formatting of lines behind if-statements without brackets

Hi,
I investigated an enjoying bug in terms of the auto formatting in atom. This happens if you call "Auto Ident" or if code becomes pasted into the editor.
In many languages, e.g. Java, Javascript, PHP, ... the following should be formatted as this:
if(somevariable === 3)
   alert(somevariable);
somevariable++;

This is the similar behavior as:
if(somevariable === 3) {
   alert(somevariable);
}
somevariable++;

Atom unfortunately format all lines behind the statements the following way:
if(somevariable === 3)
   alert(somevariable);
   somevariable++;

Hope this can be fixed soon :+1:

I believe this is a duplicate of https://github.com/atom/language-javascript/issues/51

It might be important that this is not only an issue for javascript. PHP, Java and many other languages are using this formatting style as well.


How can I highlight buttons when it's style on

I followed those step from https://github.com/cjwirth/RichEditorView/issues/53 as you mentioned but could not able to achieve that functionality like highlight buttons when it's style on. so please give me brief description. thank you.

Hey! Sorry it's not working for you 🙁
Everything you should need to get it working should already be written out in #53 . Without any specifics of what you have done, or what your code looks like, I have no way of knowing how to get it to work for your project.

Closing for inactivity.


Fix inbound VNET routing classification

Classify inbound packet to VNET instead of using VNI
as VNIs alone may overlap
Signed-off-by: Marian Pritsak<EMAIL_ADDRESS>

Please write a PTF or Pytest test-case to validate the behavior, thanks. Needs #187 (drop behavior) and #193 (PTF support for VXLANS).

I don't think this commit should include a test. It's not even a new table. My primary goal is to get the VNET definition to a steady state, where we don't expect any more changes so that tests that follow won't need to be updated every time.


Enable CentralPackageManagement on Certain Projects MrtCoreManagedTest.csproj and Microsoft.FrameworkUdk.PackageReference.csproj

A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

/azp run


VTS L1 Enhancement - Header file 3.0.0 updates - Device Setting - Display

This task is to consider the latest header file updates and consider if there are any changes in L1 concerning the newest header files available at tag 3.0.0

Compared the display L1 file with https://github.com/rdkcentral/rdk-halif-device_settings/blob/main/include/dsDisplay.h and find no update in interface file.
So closing this issue


Darwin image build: add support for SDK version

I tried a quick search but didn't find an answer... Does the SDK_VERSION variable get read in the built script already?

Yes, it is used by the osxcross build.sh  script invoked during the Docker image creation

@Jacalz sorry about that. Forgot that docker build does not support the --env flag :)
dec308d  fixes, moving to build args.

This worked great for intel mac, thanks for the updates.
It is not happy on M1, but I think that is a separate issue.
#10 230.7 make[1]: Leaving directory '/osxcross/build/p7zip/CPP/7zip/UI/Console'
#10 230.8 ./install.sh /osxcross/target/SDK/tools/bin /osxcross/target/SDK/tools/lib/p7zip /osxcross/target/SDK/tools/man /osxcross/target/SDK/tools/share/doc/p7zip
#10 231.1 - installing /osxcross/target/SDK/tools/bin/7z
#10 231.1 - installing /osxcross/target/SDK/tools/lib/p7zip/7z.so
#10 231.2 - installing /osxcross/target/SDK/tools/lib/p7zip/Codecs
#10 231.2 - installing /osxcross/target/SDK/tools/man/man1/7z.1
#10 231.2 - installing /osxcross/target/SDK/tools/man/man1/7za.1
#10 231.3 - installing /osxcross/target/SDK/tools/man/man1/7zr.1
#10 231.3 - installing /osxcross/target/SDK/tools/share/doc/p7zip/README
#10 231.4 - installing /osxcross/target/SDK/tools/share/doc/p7zip/ChangeLog
#10 231.4 - installing HTML help in /osxcross/target/SDK/tools/share/doc/p7zip/DOC
#10 233.1
#10 233.1 Unpacking /tmp/command_line_tools_for_xcode.dmg ...
#10 233.1 /osxcross/target/SDK/tools/bin/7z x "/tmp/command_line_tools_for_xcode.dmg"  "Command Line Developer Tools/Command Line Tools.pkg"
#10 233.7
#10 233.7 7-Zip [64] 9.38 beta  Copyright (c) 1999-2014 Igor Pavlov  2015-01-03
#10 233.7 p7zip Version 9.38.1 (locale=C,Utf16=off,HugeFiles=on,4 CPUs)
#10 233.7
#10 233.7 Processing archive: /tmp/command_line_tools_for_xcode.dmg
#10 233.7
#10 233.7 Errors:
#10 233.7 Unexpected end of archive
#10 233.7
#10 233.7 CLTools_Executables.pkg/Payload
#10 233.7 Errors:
#10 233.7 There are data after the end of archive
#10 233.7
#10 233.7 Warning:
#10 233.7 /tmp/command_line_tools_for_xcode.dmg
#10 233.7 Can not open the file as [Dmg] archive
#10 233.7 The file is open as [Xar] archive
#10 233.7
#10 233.7
#10 233.7 No files to process
#10 233.7
#10 233.7
#10 233.7 Archives with Errors: 1
#10 233.7
#10 233.7 Open Errors: 2
#10 233.7
#10 233.7 Removing /osxcross/build/tmp_7722 ...
------
executor failed running [/bin/sh -c ./tools/gen_sdk_package_tools_dmg.sh /tmp/command_line_tools_for_xcode.dmg]: exit code: 2
[✗] could not create the docker darwin image: exit status 1
exit status 1


test error for 5.x  api_anomalies_integration_test.go:23: error unpacking anomaly

json: cannot unmarshal number into Go struct field .identity.item_id of type apstra.ObjectId

We should probably cut this code out. This was written for a VMWare integration that is currently not being used anyway.

We'll solve this with #366


How to delete metrics from PostgreSQL

Prometheus offers an option to delete some metrics via their API, however that doesn't impact any data through remote read/write. Is there a way for me to delete metrics through PostgreSQL?
I could not find any documentation on how to do this. Perhaps a section in the design document or Wiki to show how to do metric deletions would be beneficial?

Yes, there are two ways to delete metrics through PostgreSQL/TimescaleDB:

Manually delete data older than (or newer than) a specified time: https://docs.timescale.com/latest/api#drop_chunks

Add a new data retention policy: https://docs.timescale.com/latest/api#add_drop_chunks_policy

I agree re: better documentation. Might be best in this repo. Will chat with the team. Thanks!

Related: Would you prefer the ability to delete metrics via the Connector directly (eg REST API)?
(See #90)

Ability to do it via REST API would probably be beneficial as Prometheus has this feature too.

Split off the API endpoint request separate.
This issue will remain for documentation. We should document:

how to delete a metric
how to delete a metric by time (drop_chunks)
how to schedule data retention
how to delete a series (one and multiple)

The rest API is implemented by #326


chore: enable nitro on production build

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #4585
[x] PR closes #4608
[x] PR closes #4396
[x] currently there is no official pwa modules for nuxt3/bridge, for temporary using this https://github.com/kevinmarrec/nuxt-pwa-module
[x] enable nitro on production build

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

it's happening 🤔👀

why it was canceled 👀

6:27:52 PM: Finished processing build request in 4m38.308200318s

idk why I thought this will speed up build times 🤔

currently there is no official pwa modules for nuxt3/bridge, for temporary using this kevinmarrec/nuxt-pwa-module

let's check on this later one

@preschian ups, conflict 🙈

pay 80 usd

😍 Perfect, I’ve sent the payout
💵 $80 @ 31.54 USD/KSM ~ 2.536 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x531348abb5a06a99b9e338c47eeaa735483b7bf1ba5fb489bd9c7c23edbd51f9
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Add VUI to list

This pull request is for add VUI(Viet Tri University of Industry) to list

@N4mm-Pt First stage of verification passed, official domain is vui.edu.vn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@N4mm-Pt Regrettably, this request has signs of fraud. I have to close it without merging.
It does not mean that something is wrong with the university. The issue is related to a combination of suspicious factors related to the domain itself.
Please feel free to apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for your understanding!


[5.0] IRGen: Mask all spare bits in multi-payload enums when injecting the tag.

Single-payload enum layout unfortunately assumes that constructing the payload case is a no-op, such
as when building Optional.some(x) for a value x. For multi-payload enums, now that we use the unused
spare bits to form extra inhabitants when the enum is in turn wrapped in an Optional or other single-
payload enum, this means we have to zero all of those bits. The spare bits may have been selected from
intra-field or tail padding bytes that are undefined in the underlying payload types. Fixes
rdar://problem/47635801.
This fix is not ABI-impacting.

@swift-ci Please test

@swift-ci Please test

Should be good to go now.

Build failed
Swift Test OS X Platform
Git Sha - 960d8ad8ada58cd09f99221f719cd573537d1aa2

Build failed
Swift Test Linux Platform
Git Sha - 649961e1db440b11b0297b59088bf8459a04e8ca

@phausler Any idea why the 'TestXMLDocument.test_xpath' test might crash on 5.0 but not on master with this change?

no clue; @millenomi do you know of any changes in that area?

@swift-ci Please clean test Linux

Hm, it passed the second time. Hopefully transient?


Input focus should be accessible with keyboard

With 2.0 and Sketch 40.3 i am not able to switch the focus between input fields with my keyboard (TAB switches focus between the dialogs buttons, but ignores the text fields).
Also, the first input field should receive focus when the dialog appears.

Strange, i just got back to work with sketch, used the plugin and the focus-switch and focus-on-show do work.
What does not work now is to switch the focus between all controls. I can only switch forward or backward to the next/previous text fields. It would be much more convenient to be also able to select the dialogs buttons and to have a focus-"carousel".


fix typo

Problem
Incorrect step # in comments of test_optimistic_confirmation_violation_without_tower,  it should be called step 4 now
https://github.com/anza-xyz/agave/blob/master/local-cluster/tests/local_cluster.rs#L3388-L3429
Summary of Changes
fix typo

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.9%. Comparing base (a2579d4) to head (6bfdf16).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #264     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%
=========================================
  Files         837      837
  Lines      226805   226805
=========================================
- Hits       185846   185812     -34
- Misses      40959    40993     +34

All greens on CI, not sure whey automerge didn't work but pushing


Expanded SF types to include MM types.

Resolves #1 and resolves #2.

Nice! Would be nice to have focused PRs though, perhaps all those TODOs are a bit much for all in this PR?

Sure. I won't add more implementations/easy checks here. But the Types are there now, including a bounding box one. Let me know what you think.

After some thought I removed the bounding box type. It had some issues, such as the @generated and it doesn't fit in this package as a concrete implementation. I would like to go for an optional extent method that returns something that adheres to a Rectangle type. The Rect type from GeometryBasics would be a good fit.
I've added the CircularCurve and related types from SQL/MM. Also added a lot of defaults, where we can infer that ourselves. I'm ok with NotImplementedErrors on functions where we ourselves could eventually provide a fallback, things like area.
I've also started adding docstrings and did a split for types and interfaces, as requested by @rafaqz in #2.
Some points that still need to be addressed:

Do we need to AbstractX everywhere? Is a Triangle <: Polygon or <:AbstractPolygon?
I propose a minimal required interface, only geomtype, ncoords, ngeom, getgeom. We can make npoint = ngeom in the case of Points etc. Even Polygons, with exterior and interior(s) can be resolved to nrings (made an example) and thus ngeoms.
getgeom can be an iterator.

Still some work to do, but let me know your thoughts on this direction.

Updated the exports and the Project.toml
Updated the README.md to work with ngeom and getgeom
Removed the primitives.jl for now (not included it), as it needs rethinking
Made a test implementation as test
Made a testing tool to check your implementation

I'd say, barring obvious errors or typos, it's ready to merge. It isn't done yet, as the test suite needs expanding, especially for the default cases, but it's good enough for JuliaCon.


Search: placeholder color too strong in default light theme

Placeholder color is same as input box color which makes it hard to differentiate between the two.

@isidorn @roblourens I might have fixed this with https://github.com/Microsoft/vscode/commit/1dcdaccbcce51e4dd90287c5a5a80535446136d4 already

I think it looks fine now

Yeah it is good now -> verified


Is Patricia3 have a version for Android？

i found one on
https://sourceforge.net/projects/chess-engines-for-android/files/
Is the Patricia3 on this website fake？

Those binaries are real. There's someone on talkchess who goes around making android compiles for every engine he sees, and that's where he puts them.


clock status 00

Hi,
I have flashed this firmware onto an RP2040-Zero board (git clone and make install), but when I connect a target CC2530, I only get
clock status 00

printed over and over on the serial port.
I tested two chinese CC2530 modules, the behavior is the same with both.
How should I proceed with debugging?
I have already checked with an oscilloscope that there is a reset pulse (low for ~150 us), and there is some activity on both DC and DD pins.

Without changing anything else, I programmed the target once using an Elnec BeeProg via ISP. After that, everything started working and this tool can both read and write flash.
It seems like whatever comes pre-programmed in these Chinese modules breaks some assumptions pico_cc_flasher makes. Perhaps there are some readout protection fuses? I haven't studied the CC2530 datasheet yet.
I will keep the other target board unchanged in case you want to investigate this further.

Just happened the same to me on a new cc2531 module. The other 2 I have works without problems, but I flashed them before with a Raspberry PI.
So I'll try to flash this one as well with the RPI and see what happens.

Just for the record, before successfully flashing with BeeProg, I tried CCLoader on ESP8266 (Wemos D1 mini) and it errored out with "Verify failed!". It was doing pretty much the same thing with the chip completely disconnected (I think it just failed a bit sooner). So CCLoader won't work as an alternative method for first flashing.


Crashing in Kubernetes

Trying to use the azure app configuration provider, and the pod is constantly restarting, crashing with the following:
fatal error: concurrent map writes
fatal error: concurrent map writes

goroutine 448 [running]:
runtime.throw({0x17ec360?, 0xc001f5f890?})
        /usr/local/go/src/runtime/panic.go:992 +0x71 fp=0xc002101e20 sp=0xc002101df0 pc=0x437091
runtime.mapassign_faststr(0x15e0400, 0xc001f5f890, {0xc0020b042a, 0x11})
        /usr/local/go/src/runtime/map_faststr.go:295 +0x38b fp=0xc002101e88 sp=0xc002101e20 pc=0x4133cb
azappconfig/provider/providers.(*ConfigurationSettingProvider).CreateKeyValueSettings.func1()
        /workspace/providers/ConfigurationSettingProvider.go:163 +0x208 fp=0xc002101f78 sp=0xc002101e88 pc=0x14946e8
golang.org/x/sync/errgroup.(*Group).Go.func1()
        /go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75 +0x64 fp=0xc002101fe0 sp=0xc002101f78 pc=0x1493024
runtime.goexit()
        /usr/local/go/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc002101fe8 sp=0xc002101fe0 pc=0x466ee1
created by golang.org/x/sync/errgroup.(*Group).Go
        /go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:72 +0xa5

This appears to happen more often as the number of providers grows, which is quickly becoming a problem for out use case

@juniwang @RichardChen820

@aravol can you please share more details of your setup? Did you create multiple Azure App Configuration Kubernetes Provider resources? Do you have them write to the same ConfigMap?

Hi @aravol , do you have key-value pairs refenrencing to Azure KeyVault secrets? It seems that we have a race condition in resolving the keyvault references. Please give us some time to re-pro and fix.
At this moment, I would suggest reducing the number of references if possible to mitigate the race condition.

All providers are writing to separate secrets and configmaps, as the separation is intended to minimize restarts when values change. We're using Stakater Reloader to create automatic restart behaviour when ConfigMaps/Secrets change
There are multiple Key Vault references, as we're separating those values for security. At this point, there are two references key vaults per namespace, although we're aiming to bring that down to one. Bringing down the number of references is not possible at this time.

Thanks, we are working on a fix, please stay tuned. Hopefully a new version will be ready in a few days.

@aravol  Could you try to upgrade to the 1.0.0-preview2 to see if the issue is gone?
helm upgrade azureappconfiguration.kubernetesprovider \
     oci://mcr.microsoft.com/azure-app-configuration/helmchart/kubernetes-provider \
     --version 1.0.0-preview2 \
     --namespace azappconfig-system

That seems to have fixed it for us!


Web: support other encodings than UTF-8

Ideas: https://github.com/microsoft/vscode/pull/79232

Is there any plan for this issue ?

Webpack seems possible for iconv-lite but not without modifications because it seems they do not want to bundle the stream support into the browser (related https://github.com/ashtuchkin/iconv-lite/issues/204). We would need:

to fork iconv-lite and make sufficient changes to include the streams support
export all streams that we actually use from node.js or rewrite our code to be node.js stream agnostic
possibly reduce the size of iconv-lite to only include the encodings we support (I measured ~1MB library size after webpack)

I used the following webpack.config.js:
const path = require('path');
module.exports = {
    entry: 'iconv-lite',
    devtool: 'inline-source-map',
    mode: 'production',
    output: {
        path: path.resolve(__dirname, 'lib'),
        filename: 'iconv-lite-umd.js',
        libraryTarget: 'umd',
        globalObject: 'typeof self !== \'undefined\' ? self : this'
    }
};

Hey, iconv-lite author here. The issue you mentioned should be fixed now (needs some more checking in other environments). As an additional benefit, the Streaming API should work in the browser if 'stream' module is included (or if enabled explicitly). Let me know if you have any questions about enabling it.
I'm trying my best to keep the size to a minimum; in my measurements, with streams, iconv-lite takes ~320Kb minified by webpack (I just used webpack cli with default params). I guess 1Mb is the source map stuff. Would that be small enough for your purposes?

@ashtuchkin thanks a lot for commenting here, I am planning to pick this up soon (coming months) and will report back to you how it goes 👍

Awesome, looking forward to it!

Hello @bpasero!
I am in desperate need of this feature, so I was thinking maybe it is a good opportunity for me to contribute. However currently I have zero knowledge about vscode codebase, so I decided it'd be good to verify it with you before diving in.
Would you be open to this being an outside contribution? Do you think adding this feature is doable for the first time contributor? Would it be possible for you to provide me some guidance as which files/places in the project this relates to?

Thanks for the offer, but not having fully understood yet how to approach this from the VSCode side makes this a bit harder for me to ask for help. I think there are a few steps towards the solution that maybe can be decoupled and worked on individually. I think we need a way to consume iconv-lite in UMD form to make it work both in browser and desktop similar to what we did with https://github.com/microsoft/semver-umd. E.g. have a NPM module we can consume that is the webpacked version of iconv-lite.
One thing not clear to me yet is how to get node.js streams into VSCode web, because we heavily depend on node.js streams for all encoding related things. I am not sold in having to use node.js streams so maybe an alternate solution is to convince iconv-lite to have a very simple API that different stream solutions can be plugged into?
The code for encoding handling lives in nativeTextFileService which only exists in desktop for now.

iconv-lite fully supports webpack (especially the 0.6 version I'm working on right now), so UMD package similar to semver-umd should work great. Before I release 0.6, please use master branch for now if you want to check it out.
As for the streams - iconv-lite internally uses a simplified stream interface for all codecs that is also compatible with Node's StringDecoder class (but doesn't depend on it). Basically the interface is the following:
interface Decoder {
  write(buf: Buffer): string;
  end(): string | undefined;
}

interface Encoder {
  write(str: string): Buffer;
  end(): Buffer | undefined;
}

// usage:
iconv.getDecoder(encoding): Decoder
iconv.getEncoder(encoding): Encoder

I'm wondering if that would help?

Awesome, thank you!
Looks like I have all the puzzle pieces. Will take a deeper look during the weekend. An opportunity to contribute to VSCode (which I have been happily using for 4 years) is very exciting :)

As for the streams - iconv-lite internally uses a simplified stream interface

@ashtuchkin does that mean I can pass in "something" that matches that interface and it will work? I would need this to be exposed from the TypeScript types of iconv-lite to work properly. I think today the type is still a node.js one:
https://github.com/ashtuchkin/iconv-lite/blob/de9c10bc9c424f49f451f34a9b09408f40b0aba7/lib/index.d.ts#L15-L17

I can add these methods to typescript definition, currently they are not there. I was treating them as non-public for the time being (as they are not usually useful for Node.js). I did get requests to make them public before, so it probably makes sense to just do it.
The link you gave is for decodeStream/encodeStream - these are for Node.js streams, you're right. These are not what I was talking about.

does that mean I can pass in "something" that matches that interface and it will work?
It's the other way around: iconv-lite itself provides encoder/decoder objects with this interface and you can wrap it with your stream implementation/helpers to do the conversion.

As an example, I'm wrapping these Encoder/Decoder stream objects with Node.js Transformer class to create Node.js-compatible transformer streams here https://github.com/ashtuchkin/iconv-lite/blob/master/lib/streams.js#L27  (this.conv is the Encoder)

Added methods to .d.ts in the latest master commit.

Hello @bpasero!
I've taken a bit closer look into the source code and am thinking that I would really like to try to contribute this feature. However I totally understand that it is not something small and you might want to do internally inside VSCode team.
So I would kindly ask you to give me a chance here and champion me if it is at all possible. From my side I will try to split the work into smaller chunks to make it easier for you to review it and give your feedback. If at any point in time you will think that this collaboration isn't working for any reason, I'll step down.
Here is my initial plan of how to complete the task:

Combine StringDecoder-like interface from iconv-lite with steam to decouple nativeTextFileService and encoding from node streams. This way I can better understand the whole process and test the whole story working on the code that should actually work.
Create UMD build of iconv-lite.
Move encoding module from node to common.
Reuse my knowledge and possibly code from 1. to make multiple encodings work on the web the same way it works on node.
Possibly write some tests or migrate tests from node side (if any) to be used cross-platform.

How does this sound to you?

Yeah that sounds good to me. The first step of removing node.js streams for all encoding matters and using our own streams VSCode provides that are web supported is a good starting point.
Btw, we use another library jschardet to support "guessing" of encodings. You will probably see that during the process. I am not sure if that one can run in the web as well, I have not looked into it yet. But luckily the use of this library is limited to very few places so the adoption should be much easier compared to iconv-lite.
Timing wise we are entering endgame next week, I will probably not have a lot of time to look into this until the week after next week, but feel free to create a PR for the first step. I even think the second step can be done too. For that purpose though I would go and create a GH repository to host the UMD version of iconv-lite. Does that make sense that MS publishes this module even though you contribute to it?

Timing wise we are entering endgame next week, I will probably not have a lot of time to look into this until the week after next week, but feel free to create a PR for the first step. I even think the second step can be done too.

Good luck with upcoming release then. Seeing this small dot above the gear always makes me happy! Let's see how far I can get with the first step by the time you are done with Thanos :)

Btw, we use another library jschardet to support "guessing" of encodings. You will probably see that during the process. I am not sure if that one can run in the web as well, I have not looked into it yet.

Hopefully it won't be a big deal. Will take a closer look during the process.

For that purpose though I would go and create a (Microsoft owned) GH repository to host the UMD version of iconv-lite. Does that make sense that MS publishes this module even though you contribute to it?

Sure, it absolutely makes sense.

@ashtuchkin do you think you can make exposing getEncoder/getDecoder a patch release for 0.5 already? This will allow the first part of my work to be independent from 0.6 release timeline.

Btw I just created https://github.com/microsoft/iconv-lite-umd

Here is the update for the steps:

I am done with the code, just need to recheck everything and properly open the PR.
Here is the PR https://github.com/microsoft/iconv-lite-umd/pull/1

Thanks, as I said we enter endgame this week so I will only have time to pick this up again the week after, but feel free to open up that PR.

Thanks, as I said we enter endgame this week so I will only have time to pick this up again the week after

My apologies - had no intention to give you any pressure. Guess I was just happy about moving forward and wanted to share :)

Also a tiny jschardet update. It looks like they have a staightforward browser story: https://github.com/aadsm/jschardet#browser 🎉

In the meantime, since I've had more time this weekend, I've decided to reiterate on the plan for the next steps. No need to check it now, just leave it be until after we deal with the first steps.
The general idea is to make changes so that they can be merged and released separately. It will mean that we can roll them out gradually through insiders channel. It also means delaying enabling multi-encoding support in the browser until very last step.

Move encoding.ts to common.

Update all the current places to use iconv-lite-umd instead of iconv-lite
Add jschardet (we can use browser bundle which comes with the original package) and iconv-lite-umd to remote/web/package.json, workbench.html and workbench-dev.html
Not sure how to be with encoding.test.ts - it uses fs, so it'll violate layers rules if moved to common, however it feels like it belongs there and fs is being used only for test purposes

Move EncodingOracle implementation from nativeTextFileService to textFileService

Override it in browserTextFileService so it still enforces utf8

Move all read/write logic that now can be reused across platforms from nativeTextFileService to textFileService

Reuse tests from nativeTextFileService for textFileService, we really don't need them twice for electron and browser now

Enable multiple encodings support for browser

Remove EncodingOracle mock inside browserTextFileService so it inherits it
Allow users to define files.encoding setting
Add encoding button to the status bar
Something else?

@gyzerok I have just released iconv-lite v0.6.0 with proper Electron support and the typescript updates. Let me know if you need anything else.

@ashtuchkin these are really great news! Thank you for release, really appreciate it 😄
Actually you might be able to help me a bit more with reducing the UMD build size.
Full disclosure: I am not well versed in encodings, so most of my knowledge comes from wikipediaing for the purpose of completing this task 😅
In the https://github.com/microsoft/iconv-lite-umd/pull/1 there is a UMD build of iconv-lite. I have excluded utf7, utf32 and cp949. I've also tried excluding other things, but that breaks VSCode. The list of encodings supported by VSCode can be found here.

Do you think there is any other room for reducing the size?
Have you considered making the API so, that consumers can import encodings they need themselves and pass them into the library? Sort of similar to what you've done with the streams.

It looks like the inline source map takes more than half of the size (332kb out of 582kb). I'm wondering if we could put it in a separate file or get rid of it. This leaves us with 250kb of actual code.
I used webpack --display-modules to look inside and there's not much we could strip. Maybe a couple kb here and there (e.g. iconv-lite/lib/streams.js is probably not needed). If you already have Buffer class somewhere, we can exclude buffer module to save 50kb.

Have you considered making the API so, that consumers can import encodings they need themselves and pass them into the library? Sort of similar to what you've done with the streams.
It's an interesting idea, but will probably require a major refactoring. We haven't had a use case with such strict size requirements, so I didn't want to complicate things.

It looks like the inline source map takes more than half of the size (332kb out of 582kb). I'm wondering if we could put it in a separate file or get rid of it. This leaves us with 250kb of actual code.

That's a great discovery!
I was adjusting already existing config from semver-umd module and inline source maps are coming from there. Not sure if it was an oversight or done on purpose. Will ask in the PR, thank you for pointing it out!

@gyzerok @ashtuchkin the changes on master allow to consume iconv-lite without node.js stream dependency, which is great. However we still have a Buffer dependency. Can we change this to a Uint8Array dependency instead to be able to use this without having to shim Buffer?

I guess this is more of a question to Alex, cause it is imported internally. Not sure if there is some way to override it from the outside I am missing.

Looks like https://github.com/ashtuchkin/iconv-lite/issues/235 is already opened for this matter.
I also just reported https://github.com/ashtuchkin/iconv-lite/issues/242. I feel it is a bit strange to have the stream based API talk about string. I would like to avoid having to allocate strings to reduce memory pressure. Not sure how it was before with the node.js streams, but imho everything should only go through Uint8Array

@bpasero meanwhile I am not sure if https://github.com/ashtuchkin/iconv-lite/issues/235 blocks us from proceeding with implementation or I can go ahead even though Buffer shim is currently included. Can you clarify this for me?

@gyzerok yeah makes sense, how would VSCode access this buffer shim? I think iconv-lite-umd should possibly export it as from its index.d.ts?
I want to be careful to only really use it for iconv-lite and not spread it around anywhere else in code, so it can only be used in encoding.ts ideally.

@gyzerok  I think the best is to expose methods from the UMD Module that use Uint8Array and internally forward to iconv-lite as shimmed Buffer

@bpasero

yeah makes sense, how would VSCode access this buffer shim? I think iconv-lite-umd should possibly export it as from its index.d.ts?

Not sure what you are asking here.

I want to be careful to only really use it for iconv-lite and not spread it around anywhere else in code, so it can only be used in encoding.ts ideally.

From types perspective we do not expose any details of the fact that any shim is used, because only VSBuffer goes outside of encoding.ts.

@bpasero both Node.js Buffer and shim buffer extend Uint8Array. And VSBuffer internally refers to the thing it wraps as Uint8Array.
So even if some code will use vsBuffer.buffer it will think of it as Uint8Array which is true.

+1. Also for decoding, I'm 99% sure you can pass Uint8Array instead of Buffer and it'll work fine.

@gyzerok yeah anything really works for me for as long as it stays isolated to encoding.ts, please go ahead as you see fit and I can give feedback from a PR 👍 . I already commented in iconv-lite repo that you can feel free to use VSBuffer helpers if it helps. VSBuffer is our way of supporting both Buffer if available or fallback to Uint8Array.

@ashtuchkin while working further on the implementation I've discovered that there is at least one case, where Uint8Array is not accepted. Here is the code which is responsible: https://github.com/ashtuchkin/iconv-lite/blob/v0.6.0/encodings/internal.js#L48-L59
Internally StringDecoder calls Buffer.toString(encoding) which doesn't work for Uint8Array. Simple test case iconv.decode(Uint8Array.from([...iconv.encode('Lorem ipsum', 'utf16le')]), 'utf16le');
The easy way to fix it would be to change InternalDecoder to be as follows:
function InternalDecoder(options, codec) {
    this.decoder = new StringDecoder(codec.enc);
}

InternalDecoder.prototype.write = function(buf) {
    if (Buffer.isBuffer(buf)) {
        return this.decoder.write(buf);
    }

    return this.decoder.write(Buffer.from(buf));
}

InternalDecoder.prototype.end = function() {
    return this.decoder.end();
}

Do you think this is an acceptable change for iconv-lite?

Is there any plan for this issue ?

pofg

Thanks @gyzerok for driving this from the VSCode side and @ashtuchkin for the iconv-lite side 👍

I would like to also thank everyone envolved:

@LeuisKen for reporting the issue and inspiring me to give it a shot with his own contributions
@bpasero for lying down initial plans and helping me to get this done
@ashtuchkin for being so responsive on iconv-lite side and giving amazing advice on bundle size reduction

Love the open-source community! ❤


issue #83 completed and renamed as issue #83A

expand/collapse menu issue: done
pagination is not working: done
clear the layouts folder: done
clear the Dashboard page: done
Remove Profiles and keep only Myprofile and Logout btn: done
organization Edit update the DB also: done;
Data front end validations: done

Hi @kushaw
regarding pagination, I dont see any pagination in organization.
please let me know what is wrong?
Thanks

The pagination is added and updated in the same issue#83A

Hi @kushaw
as I explained in skype: """
your pagination implementation is not correct
you implemented pagination locally.
indeed we need to do pagination remotely
if you call /api/v1/organization/ you will have 2 field in json data:
1- result
2- pagination
in pagination we have pagination info. something like this:
{
'count': 45,
'current_page': 1,
'first_page': 1,
'last_page': 5,
'next_page': 2,
'next_url': 'http://localhost:8000/api/v1/organization?page=2',
'page_size': 10,
'previous_page': null,
'previous_url': null
}
maybe next_url and previous_url be un-used
but you should use other info to create your pagination buttons link in your table
count = total records
current_page = current page number
first_page = first page number
last_page = last page number
page_size = max size of every page
then you should use this data to create your pagination buttons in UI and bind click events for buttons according this info
FYI, to load data of page number N you should add a parameter called page in end of url: something like this:
http://localhost:8000/api/v1/organization?page=1
http://localhost:8000/api/v1/organization?page=2
...
http://localhost:8000/api/v1/organization?page=N
does this make sense?
then to clear more, you should create pagination buttons according your pagination result of /api/v1/pagination/ api dynamically
Thanks
"""

As we are using the latest technology and tools I recommend to leverage the capabilities of the same
As initially when the page is loading we are loading all the data related to organization and as all the pagination stuff can be handled by front-end JavaScript  recommend the Js approach
I believe that if we use the above said approach it will increase the unnecessary ajax call to the server however the same can be achieved by using JS datatable.
only things we need to take from the database are:
'current_page': 1,
'page_size': 10,
all other functionalities can be achieved by JS in frontend
Please let me know your comments


Changes in the MAINTAINERS file following FFMpeg community policy rel…

…ated to the maintainers' list

As community requested.


Changed year and added version number

@rultor merge

@rultor merge

@kniazkov OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@kniazkov Done! FYI, the full log is here (took me 4min)

@rultor release, tag is 1.0.6

@rultor release, tag is 1.0.6

@kniazkov OK, I will release it now. Please check the progress here

@rultor release, tag is 1.0.6

@kniazkov Done! FYI, the full log is here (took me 6min)


Tinyface

Added tiny face detector port (inference only) of Tiny Face Detector from authors' MatConvNet codes.

@alpha-carinae29 thanks for your helpful comments; I applied them to the source.


[Bug] Test result table does not include results for installed items

Discussed in https://github.com/inventree/InvenTree/discussions/7286

Originally posted by vk2tds May 21, 2024
I have a scenario where I am tracking serial numbers on devices. However, I also track the MAC address and firmware version. I am tracking the MAC and firmware as test results on the Raw PCB. I then add connectors and antistatic bag, creating an OEM PCB. I then add retail packaging to create a Retail PCB
Retail PCB -> OEM PCB -> Raw PCB
When I click on the Retail PCB (or OEM PCB) and go to Test Results, it would be great to see the test results (with numbers) from the Raw PCB. I guess I could build a plug-in that actually copied the results up the chain, but it would be great to see this as core functionality.

Closed: No bug, works as intended.


Can you make vscode to run inside the terminal like vim and neovim.

VSCode Version: next version
OS Version: all os version
Hi there, I love vs code and also Vim.  I also know Vim emulation plugin for vs code is awesome and I satisfied 80% with that plugin. One thing I miss from Vim to vs code + Vim emulation plugin is vs code can not run inside the terminal as like vim or neo vim. Most of the developers love to run their text editor in the terminal or someone like me who love the old school programming way. So Please can you consider my idea or dream to come true. I know this not an issue and sorry for that because I don't know where to send a feedback to reach you.
Thank you, Microsoft Vs Code,
Everyday I love u more than yesterday my dear buddy VS Code.
If you don't like this .. I am So So Sorry  About that ...

@chrisdias any progress on this?


bibtex

Is bibtex working? Can't make it work

Hi, I have the same issue, I had to manually copy the bib file into out folder in order to make it work.


Missing Couchbase.Transactions project

Hi, all the examples reference a missing prj Transactions, that I assume it´s the actual library to handle transactions.
Is transactions actually implemented in the SDK?

nothing?


Re-fork repositories to avoid confusion

@ilwoolyu To avoid confusion, could you delete your project ilwoolyu/GROUPS and re-fork the one hosted in the NIRALUser organization. See https://github.com/NIRALUser/GROUPS
The fork graph currently shows this:

Thanks :pray:

Done.
On Tue, Dec 3, 2019 at 5:30 PM Jean-Christophe Fillion-Robin <
<EMAIL_ADDRESS>wrote:

@ilwoolyu https://github.com/ilwoolyu To avoid confusion, could you
delete your project ilwoolyu/GROUPS and re-fork the one hosted in the
NIRALUser organization. See https://github.com/NIRALUser/GROUPS
The fork graph currently shows this:
[image: image]
https://user-images.githubusercontent.com/219043/70098770-fe428100-15fa-11ea-9121-fcccafd7d69c.png
Thanks 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NIRALUser/GROUPS/issues/27?email_source=notifications&email_token=ACHEZZVWT7R4S7UG3CGLDCLQW3T23A5CNFSM4JVAHJS2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H522TPA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHEZZSVORG2RSZIQCLPGV3QW3T23ANCNFSM4JVAHJSQ
.

Thanks :+1:


macOS: 'select all' (cmd-a) does not work in an input field

Is it an actual bug?
I believe so
Describe the bug
on the mac, when the text cursor is in an input field, the 'select all' (cmd-a) shortcut does not seem to work. works in the linux version (ctrl-a).
To Reproduce
Steps to reproduce the behavior:

cmd-n to create a new task
type s.th. into the input field
do cmd-a and see that nothing happens

Do you see any error entries in sleeks developer tools?
no
Expected behavior
should select all text
Desktop (please complete the following information):

OS: macOs 10.14.6
Version of sleek: 1.0.3
Source: Github

Hi @freder. I don't have a Mac at hand, so can I ask you to check if "select all" is working in this pre-release: https://github.com/ransome1/sleek/releases/tag/v1.0.3

with that one it works 👍

@freder, one thing I got to ask you. In https://github.com/ransome1/sleek/issues/88 we're developing a "Minimize to tray and run in background" function. I can only test it on my Windows VM and my Linux system, but not on MacOS.
If you have some time, it would be of great help if you could give it a try and let me know if it works as you would expect it from Mac application. Feel free to post your feedback in https://github.com/ransome1/sleek/issues/88
It needs to be activated in the settings window.


Add Docker build for the UI

Add a Docker build for the UI and make the necessary preparations. Integration with Docker Compose and GitHub Actions will be done in a follow-up PR. See the commit messages for details.

Esp. @mmurto please also have a look.


Cant test the sample on android

Tried to run the package sample on android, but got this error:

It happened after i pressed "export as static" button.
Couldn't also export as interactive

my flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.16.4, on Microsoft Windows [versao 10.0.22631.2861], locale pt-BR)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[√] Chrome - develop for the web
[X] Visual Studio - develop Windows apps
X Visual Studio not installed; this is necessary to develop Windows apps.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2022.3)
[√] VS Code (version 1.85.1)
[√] Connected device (4 available)
[√] Network resources
! Doctor found issues in 1 category.


css bugs solved and spelling corrected

Before: footer was not placed correctly also a grammatical error in "an web communication" part.
(https://user-images.githubusercontent.com/21218897/38121733-ce53bada-33ee-11e8-96c3-0a8dafe05fe3.png)
Now:

Before:

After: bottom spacing corrected

Before: padding in label "Search Organisation"

After:

@psnmissaka : Please review the changes.


Rename empirical and analytic null methods

From https://github.com/neurostuff/NiMARE/issues/389#issue-740102784:

Probably we should rename the options too, as "empirical" is a bit confusing, IMO. I would suggest calling them "approximate" and "montecarlo", which would intuitively convey to users both that (a) the "approximate" approach doesn't really give the 'correct' answer (because it's biased by the independence assumption), and (b) the "montecarlo" approach is based on resampling and is likely to take a long time. Then the docs could more explicitly lay out the tradeoff, taking pain to emphasize that the "approximate" approach is actually conservative, so if you're willing to accept reduced sensitivity, it makes sense to just always use that.

TL;DR: Rename "empirical" to "montecarlo" and "analytic" to "approximate".

@tyarkoni what should we name the "old" empirical method? I know it will go largely undocumented but it will still need to be accessible and I'd like to have an informative name for it.

Now that #424 has been merged, this is easy enough to do and I plan to tackle it soon.
Pinging @tyarkoni about the best terminology for the old empirical approach.

Now that #424 has been merged, this is easy enough to do and I plan to tackle it soon.
Pinging @tyarkoni about the best terminology for the old empirical approach.


Ikea blinds not being included to HASS via zigbee, even disconnected from its proprietary remote

Technical solution to https://github.com/130s/30y-130s_life/issues/1505.
Issue
As summarized in the title,

zigbee inclusion not occurring.
After first attempts, device disconnected to the proprietary remotes.

Thanks to this page (thesmarthomejourney.com) that verifies the Ikea blind can be included directly to ZHA, I was able to include both Tredansen and Fyrtur directly, control open/close from HASS.
This can be close, but now, same webpage mentions that both the remote and the remote can be connected to ZHA as both trasmits Zigbee.
I'll try connecting them, and potentially change the way I control blinds from HASS because:

I noticed the remote is no longer connected to each blind after I played around with blinds in order to include in ZHA. Not being able to use the remote limits our usecases tremendousbly (e.g. kids and anyone who don't have an access to HASS, anyone who is not tall enough to reach the blind's hardware up/down button, wouldn't be able to up/down the blinds), the remote is a must.
Each blind  connects to HASS may duplicate the connections in the Zigbee topology and simply increases maintenance. Currently at the time of writing the topology is:HASS <--> blind-a
   | <--> blind-b
   :
   | <--> blind-X

If I add the remote at this state, it'd be duplicate and transitive connections (hard to depict by text, but you see the 2 arrows b/w each HASS-blind connection.HASS <--> Remote-a
   | <--> Remote-b
     <-->        | <--> blind-a
     <-->        | <--> blind-b
   :
     <-->        | <--> blind-X

Since a single remote can control up to 4 blinds and I like one remote to control multiple blinds, I'd imagine:HASS <--> Remote-a
                 | <--> blind-a
                 | <--> blind-b
   | <--> Remote-b
                 | <--> blind-c

I haven't noticed HASS is not detecting each blind's state, e.g. how much open it is etc. If that is available, then I may better connect each blind to HASS. But since that seems to be missing (I'm unsure if that's true though), for now I'd go with non-transitive connection.

I'm seeing transitive connection seems difficult or impossible. I'm saying this with the following experiences

ZHA <--> remote connects.
Then after that, the inclusion of the same remote <--> blind doesn't trigger the remote's light turn to red (instead, the light simply doesn't turn on).
Factory reset the same remote then start inclusion process with the same remote <--> same blind turns the remote's light turn to red.

Haven't confirmed yet. I think there's a work to realize the transitive connection. Need to look it up.


Enable GCC for OutputMode.ECMAScript2015

Based on my question on Gitter and @sjrd's reply:

The ES2015 output still deactivates Closure, at the moment. For a long time Closure did not support ES2015 so we had deactivated it. We need to revisit that one of these days.

So the issue is for "revisiting" this topic 😄  Also if anybody can point me to some relevant documentation to read, please do.

That would help https://github.com/scala-js/scala-js/issues/2675

The main issue is to manage to upgrade our dependency on GCC first, to a version that can handle ES 2015. I have a wip branch at https://github.com/scala-js/scala-js/compare/master...sjrd:upgrade-gcc. I don't remember why I go stuck. Feel free to pick it up.
Note that this targets master so Scala.js 1.x. Upgrading GCC in the 0.6.x branch is close to impossible due to the JDK 6 support constraint. In addition, fiddling with the code emitter is much easier in 1.x than in 0.6.x.

Thanks, will take a look


Question: How to write statick plugin packages?

More a question than an issue. I'm looking at adding a plugin to Statick to support MicroFocus Fortify, and wanted to try writing it as a separate module (so it would be, say, pip install statick-fortify-plugin which would depend on statick). Any experience with making this sort of arrangement work with Yapsy? The documentation is a bit lacking, but it looks like the usual approach with Yapsy is to define a plugins dir and drop everything in there (which is doable, but kind of defeats the purpose of pip installing things)

That is a good use case to support. The closest thing we have done is to make a custom plugin in a separate directory that is made available via the --user-paths flag. There is an example at:
https://github.com/tdenewiler/statick/tree/master/examples/navigation/navigation_config/plugins
It is run in example 3 (and 4 and 5):
https://github.com/tdenewiler/statick/blob/master/examples/navigation/navigation_example3.bash
We are still getting used to releasing code, so I'm not sure if we could make that an independent module that is on PyPI. When trying to use the new plugin the --user-paths argument doesn't seem to make sense for installed modules.
If I'm missing the point of what you are asking let me know as I'd be happy to help figure it out. I'm willing to try making an example and adding documentation.

You're correct about what I'm asking. It would be a big refactor, but I'm wondering if something like the setuptools entry_point mechanism might be a better approach to supporting this use case? I believe flake8 uses that approach.

I came across this yapsy feature request and it sounds like exactly what you want to do:
https://sourceforge.net/p/yapsy/feature-requests/11/
I tried to find the example the author was talking about and the closest I got was in their documentation:
http://yapsy.sourceforge.net/#modify-plugin-descriptions-and-detections
There is a method to set the location to look for plugins but the documentation is not very clear to me:
http://yapsy.sourceforge.net/PluginFileLocator.html#yapsy.PluginFileLocator.PluginFileLocator.setPluginPlaces
I'll try to spend some time making a minimal Statick example to see if it is feasible with yapsy.

I'm currently working on adding Fortify support as a plugin, see https://github.com/soartech/statick-fortify. Right now, it works because it tells Python to install everything into statick_tool. It works, but I'm not sure how robust it is - that is, whether it's possible for Python to try to install this into a separate directory.

I don't know how robust yapsy plus setup.py configuration will be either. I think it's worth starting with this approach though. I like what you have started with the Fortify plugin.
I have a working TeX discovery plugin and plan to add tool plugins for lacheck (#40) and chktex (#41). I can make those plugins live in a separate repository and use them to document how to create external plugins for Statick.

I updated the Users Guide to point to your fortify plugin and my tex plugin as examples of how to write Statick plugins that are located in a separate repository and released on PyPI as individual packages.


Misc improvements

[x] refactor globals to constants
[x] force valid values of GetGrids.epsg so geoseries can be reprojected
[x] specify init of Api() in readme.md
[x] docstring at GetGrids.sample() specifying typing for stats (rasterstats module)
[x] specify typing for GetGrids.data_format_code (and docstrings)
[x] silence pyproj warning
[x] Auth.get_token() to internal method Auth._get_token()
[x] Test if samples from WIWB and provided NetCDF have values as expected
[ ] remove __setattr__ from GetGrids, introducing set_geometries and set_ for every property that needs validation when setting
[x] write() -> to_directory()
[x] auth.token_valid naar auth.is_token_valid
[x]  raise FileNotFoundError if directory does not contain valid netcdfs in sample_nc_dir
[x] add sample_netcdfs() with a file-list
[x] join stats list to string at sample.sample_geoseries
[ ] update readme.md with examples sample_nc_dir and to_directory()

For avoiding a custom __repr__ , and making the geometry property init-only we can modify the code as (minimal example):
from dataclasses import dataclass, InitVar, field
from shapely.geometry import Point, Polygon, MultiPolygon
from geopandas import GeoSeries
from typing import Iterable, Union

@dataclass
class GetGrids():
    epsg: int = 28992
    geometries: InitVar[GeoSeries | Iterable[Union[Point, Polygon, MultiPolygon]]]

    _geometries: int = field(init=False,)

    def __post_init__(self, geometries):
        self._geometries = geometries

    @property
    def geometries(self):
        return self._geometries

    def set_geometries(self, geometries):
        self._geometries = geometries
        return geometries

@DanielTollenaar :
Nice, thanks for fixing all these issues! I just tested the main branch, and it works! :)
Some minor last things:

I believe we agreed on renaming GetGrids.run() to GetGrids.download(), didnt we?
I think set_geometries() should return None (only set _geometries). type hint return = -> None. If you dont think so, then let it return return self._geoseries instead of return self.geoseries.
from:

        if geometries is not None:
            geoseries = self._to_geoseries(geometries)
            self._geoseries = geoseries
        else:
            self._geoseries = geometries
        return self.geoseries

to
        if geometries is not None:
            geoseries = self._to_geoseries(geometries)
        self._geoseries = geoseries
        return self._geoseries

the same goes for set_bounds(), let it return None (also type hint)
i find this a bit confusion:

    grids.set_geometries(GEOSERIES)
    a = grids.geometries  # this is None
    b = grids.geoseries   # this is not None

Do you agree? If so, either rename set_geometries() to set_geoseries(), or try to only one of the two. Perhaps you have a better soluation.

@DanielTollenaar : Nice, thanks for fixing all these issues! I just tested the main branch, and it works! :) Some minor last things:

I believe we agreed on renaming GetGrids.run() to GetGrids.download(), didnt we?
I think set_geometries() should return None (only set _geometries). type hint return = -> None. If you dont think so, then let it return self._geoseries instead of return self.geoseries.
from:

        if geometries is not None:
            geoseries = self._to_geoseries(geometries)
            self._geoseries = geoseries
        else:
            self._geoseries = geometries
        return self.geoseries

to
        if geometries is not None:
            geoseries = self._to_geoseries(geometries)
        self._geoseries = geoseries
        return self._geoseries

the same goes for set_bounds(), let it return None (also type hint)
i find this a bit confusion:

    grids.set_geometries(GEOSERIES)
    a = grids.geometries  # this is None
    b = grids.geoseries   # this is not None

Do you agree? If so, either rename set_geometries() to set_geoseries(), or try to use one of the two, or perhaps you have a better solution?

Regarding returns of functions; I agree, though with set_geometries you could argue you won't always get returned what you enter; geometries are converted to geoseries (GeoPandas) and reprojected if provided as geoseries (and projection is not self.epsg)
Regarding geometries vs geoseries. Agree it's confusing, however:

set_geometries accepts a list of geometries ór a geopandas.GeoSeries. Both are geometries, but both aren't geoseries
self.geoseries always returns a pandas.GeoSeries as the list of geometries is converted (and projected) to a geopandas.GeoSeries
Using the InitVar geometries ánd decorated property geometries doesn't work as grids.geometries won't  return the stored GeoSeries but other bogus. Hencewhy I use grids.bbox as decorated property returning grids._bounds.


Add a configuration for defining default service mounts

Allows administrators to define mounts that should be shared with all/subset of services.
Similar feature to coreMounts/coreVolumes in helm chart.

Codecov Report

Merging #904 (79bc83c) into master (003f044) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   74.02%   74.05%   +0.02%
==========================================
  Files         133      133
  Lines       12720    12729       +9
==========================================
+ Hits         9416     9426      +10
+ Misses       3304     3303       -1

Impacted Files
Coverage Δ

assemblyline/odm/models/config.py
99.54% <100.00%> (+<0.01%)
:arrow_up:

assemblyline/datasource/alert.py
84.61% <0.00%> (-3.85%)
:arrow_down:

assemblyline/odm/randomizer.py
95.25% <0.00%> (+0.86%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


storage pkg: ocs adjustments

storage pkg: ocs adjustments

@trewest @kononovn @achuzhoy @cdvultur PTAL

@trewest @kononovn @achuzhoy @cdvultur PTAL

/lgtm


Function to group qubit operators into tensor product basis sets

Hi OpenFermion developers,
I've added a function that groups the terms in a QubitOperator into tensor product basis (TPB) sets, such that all the terms in each TPB set can be measured simultaneously in VQE with the same post rotations. This was shown to improve efficiency for some Hamiltonians in https://arxiv.org/pdf/1704.05018v2.pdf (SI section V(A)), with the improvement depending on the covariance between terms in a set on the specific state prepared (also discussed in https://arxiv.org/pdf/1509.04279v1.pdf section IV B 2 for commuting groups in general). I hope you find it useful and might like to include it - let me know if there's anything I should change.
Thanks,
Oscar

@oscarhiggott thanks for your contribution! As explained by the bot above, please do sign the CLA and then reply on this thread once you've done that. You can let us know if you have any questions.

@babbush and @kevinsung thanks for your help, and I've commited the changes you suggested Kevin. I also signed the CLA. Let me know if there's anything else I should change?

Hi @kevinsung thanks for the suggestions - I've made the changes in commit 1021918ee12a37121f4cc1b1e6fee828a007fc54. I also removed the randomize=False option in commit 7d22693796ee2550c317d1bf1ef809a63c2726a6 - now that we're using numpy.RandomState, my reason for including that option is no longer justified (deterministic behaviour can be achieved by setting a seed without changing the global random state).

Cheers, have removed the whitespace, would you like me to add myself to the readme?

Great, have done, thanks for your help!


Remove 5.5 deprecated compiler options

This removes all of the deprecated options listed in https://github.com/microsoft/TypeScript/issues/51909.
This includes #57525 and #57526. Boy would I like to have stacked PRs. This PR will get smaller with those more up to date.
Like #57525, the options aren't fully removed; we still need to error on them.
Package size report
Overall package size

Before
After
Diff
Diff (percent)

Packed
5.56 MiB
5.55 MiB
-10.02 KiB
-0.18%

Unpacked
30.86 MiB
30.79 MiB
-69.75 KiB
-0.22%

Files

Before
After
Diff
Diff (percent)

lib/tsc.js
5.62 MiB
5.60 MiB
-20.21 KiB
-0.35%

lib/tsserver.js
8.24 MiB
8.22 MiB
-20.32 KiB
-0.24%

lib/typescript.d.ts
584.73 KiB
585.22 KiB
+503.00 B
+0.08%

lib/typescript.js
8.72 MiB
8.70 MiB
-20.96 KiB
-0.23%

lib/typingsInstaller.js
1.68 MiB
1.67 MiB
-8.75 KiB
-0.51%

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@andrewbranch The last two commits remove importsNotUsedAsValues and preserveValueImports, but breaks some auto import tests. Some of them are easy to fix, but others I can't seem to fix. Do you have any suggestions? (The CI will eventually error...)

Theoretically I think this PR is ready, and I'd appreciate review where needed, but I probably won't undraft until #57525 is merged. that or, I can merge the two together and we remove everything in one go.


Feature Request: Minimap of the line author information

Is it possible to include a minimap of line author information at the scroll bar? See figure demonstration below:

Discussion on minimap can also found in this link:
https://forum.obsidian.md/t/minimap-where-am-i-in-this-way-too-long-document/1460/7

Developer of the line authoring info here. I think this is a good idea.
Here seems to be a minimap plugin for codemirror (the editor obsidian uses): https://github.com/replit/codemirror-minimap
I am not sure, how easy/difficult this would be - but maybe someone wants to spend a few hours to hack on this and see how far we get? I think adding simply another config to the settings to enable/disable this should be enough.


Fixes isolate error in Flutter 3.3.0

This is a WIP fix.

We need this PR to be merged and a new version of flutter_isolate to be published: https://github.com/rmawatson/flutter_isolate/pull/118
Breaking change: everyone must now add the following annotation to any method they pass to IsolateHandler as the callback to execute:

@pragma('vm:entry-point')

Background: https://github.com/dart-lang/sdk/issues/49181#issuecomment-1156337511
Will update the documentation before changing this from a draft.

Please, help me out with the background because I can't see clearly. Will a new version come from flutter_isolate? I'd be rather unwilling to refer to a github repo instead of the normal pub.dev. Or is this just a temporary fix that will be overridden shortly? What's the expected timeline?
(.flutter-plugins-dependencies shouldn't be included, this is just a secondary issue.)

Yes we need to wait for a new pub release for flutter_isolate, then we can update this package. Nice spot on flutter-plugins-dependencies --- i will fix that when i update this PR once the flutter_isolate package is published.
For now Ieaving this open so others can use my git dependency as a workaround.

OK, I'll be on the lookout.

By the way, if we need to decorate the entry point from now on, either mention this in the README or, at least, don't let me forget to do so when we finish this operation. :-)

I am using isolate_handler to use Firestore. It is working in debug mode but not working in release mode. Is this the reason? By the way, flutter_isolate fix was merged 7 days ago but not released.

Hi @acoutts & @deakjahn,
Are you able to use update the PR to use the new release of flutter_isolate 2.0.3 is not available?
https://pub.dev/packages/flutter_isolate/versions/2.0.3
https://github.com/rmawatson/flutter_isolate/pull/118

Back from vacation.
Updated MR to use newly published version.
@deakjahn we are ready for a final review / merge now.

There's this single file that says it shouldn't be included at all. Could you remove it? Then I'll merge and publish. Thanks.

@acoutts There's this single file that says it shouldn't be included at all. Could you remove it? Then I'll merge and publish. Thanks.

@acoutts I'd be happy to go on with this. :-)

Done 🙌

is it released?

Yes: https://pub.dev/packages/isolate_handler/changelog


narrow-banner: Update empty title for "pm-with" multiple users.

Instead of using "these people", we use "these users".
Note that the "pm-with" single user case has already been updated to show the user's full name instead of "this person".
Follow up to #23400.

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

The screenshot looks good to me!

Merged, thanks @laurynmm!


fix: hide call stack on migration errors

Fix #574

The failure in the test is relevant:

    # Subtest: throws if migrations directory does not exist
        not ok 1 - test unfinished
          ---
          stack: |
            file://test/cli/migrate.test.mjs:91:1
            async Promise.all (index 0)
          test: throws if migrations directory does not exist
          at:
            line: 91
            column: 1
            file: file://test/cli/migrate.test.mjs
          ...

        1..1
        # failed 1 test
    not ok 4 - throws if migrations directory does not exist # time=1960.946ms

🎉


Schedule events in an optimal way

Schedule the higher priority items first, and then add other items. Find events so that it won't overlap.

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."


[MXNET-1291] solve pylint errors in examples with issue no.12205

Description
solve pylint errors in examples with issue #12205
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@marcoabreu ,
Thanks for the prompt reply. You make me a great progress on participating open source community. (laugh) Thanks again.
Best regards,

Hi @sandeep-krishnamurthy @marcoabreu
I complete the rebase and re-test, I will appreciate if you can help to review/merge, thanks.

Hi @sandeep-krishnamurthy
Thanks for the prompt reply, and CI test passes.


oauth2client.getToken() returns Error: redirect_uri_mismatch

I am implementing the standard authorization code grant flow using the OAuth2 object. I am able to construct the authentication URL, and my redirect URL is getting called with the code={auth_token} once authentication is successful. However, when I try to exchange the code for the access token using the function "getToken(code, callback)," I receive the error
Error: redirect_uri_mismatch
    at Request._callback (/Users/me/projects/dash/node_modules/google-auth-library/lib/transporters.js:81:15)
    at Request.self.callback (/Users/me/projects/dash/node_modules/request/request.js:188:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:194:7)
    at Request.<anonymous> (/Users/me/projects/dash/node_modules/request/request.js:1171:10)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:191:7)
    at IncomingMessage.<anonymous> (/Users/me/projects/dash/node_modules/request/request.js:1091:12)
    at Object.onceWrapper (events.js:293:19)
    at emitNone (events.js:91:20) code: 400 }

In the credentials view of the Developer Console, I have registered callbacks for
http://localhost:4444/oauthcallback
http://localhost:4444/oauthcallback/

I am not sure why getToken should even care about the redirect, as I am expecting it to just return the accessToken data on success. This seems to be a bug in the api client.

SOLVED: The issue was that when I passed the generated auth URL to a meta tag in my html header, Nunjucks was appending a trailing '/' to the URL, which Google's server interpreted as being part of the redirect_uri value (as this param was the last URL param in sequence). I fixed by cleaning the auth URL of any trailing '/' via
oauthurl.replace(/\/$/, '')

You are right to explain it, but it is not still working as the trailing '/' is yet not removed. It is still showing on the google error page.


gnu-cobol: refactor

Description of changes
This is a major refactoring of the gnu-cobol package, which gives us:

Split outputs, allowing for small container images for COBOL
applications.
Tests running (for Linux)
Parallel building
Documentation building
XML and JSON support

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@lovesegfault Can you please outline why you've added all those doc building and preconf dependencies?
Using the official tarball there all those doc and preconf files are already part of the download and just installing them leads to a reproducible result - while rebuilding them changes them depending on the version of the dependencies used. The only exception is the installed html version (which may be added to a tarball if you sent a patch upstream), but also for this you don't need all the preconf steps + dependencies and only part of the added dependencies.


profiles records id is not user id

I'm not sure if this is on purpose or not. On my instance of pocketbase the id of a records in the profiles-collection is not the same as the user id. In the documentation it is written, that update requests can be made with the user id (User Documentation). However I need to use userModel.profile.id in the Dart SDK.
btw: absolutely awesome project!

That is because the users and profiles are 2 different entities. Each user has 1 profile, where the profile is a profiles collection record. By default, only admins and the authorized user owner is allowed to update the profile (this could be changed from the profiles collection API rules), but even if you are authorized as user or admin, you still need to provide the profile id that you want to update, the same as for any other collection record.
The confusion between the users model and profiles collection will be fixed with the upcoming v0.8 release (you could also check this issue - https://github.com/pocketbase/pocketbase/issues/376).


Use protoc path to figure out its install prefix

[x] Have to rebase
[x] Have to ensure this works on macOS + Anaconda

protoc command cannot find libprotobuf.so when I compile bundled protobuf from caffe.


Publish a new version with auto encode and with the table functionality

Duplicate of https://github.com/NielsLeenheer/EscPosEncoder/issues/71

The release of EscPosEncoder 2 is coming...


Remove Tutorial and Add Saving Data manual test

Sorry to say but I think Chen Feng has already done all that this PR does in #280

I think for manual testing, the more the merrier


XLA Check failed: common_utilization <= producer_output_utilization

Description
When trying to run a longer algorithm, the execution fails with an error message without a more precise indication of where in the code the issue occurred:
F external/xla/xla/service/gpu/gpu_performance_model.cc:119] Check failed: common_utilization <= producer_output_utilization (500.867 vs. 500.867)

This error only occurs in some use cases of the algorithm, and slightly changing parameters such as iterations and batch size sometimes permit it.
What jax/jaxlib version are you using?
jax v0.4.9, jaxlib v0.4.9+cuda12.cudnn88
Which accelerator(s) are you using?
GPU
Additional system info
python 3.8
NVIDIA GPU info
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.105.17   Driver Version: 525.105.17   CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+

I am running the code with disabled parallel compilation:
TF_USE_NVLINK_FOR_PARALLEL_COMPILATION=0

Well, that sounds like an XLA bug.
First, can you try with the latest jaxlib release (0.4.16)? The bug may already be fixed, so this is the first thing to try. You will need to update your Python version to 3.9 or newer to do this.
If that doesn't work, can you please provide instructions to reproduce? If it's hard to do that, one way is to provide an HLO dump from XLA, which you can get by setting
XLA_FLAGS=--xla_dump_to=/somewhere and JAX_COMPILER_DETAILED_LOGGING_MIN_OPS=0, running your script, and zip up and attach the output of /somewhere to this issue.

Any updates? Can you share instructions to reproduce?

I upgraded the jax and jaxlib versions, but the error persists.
Unfortunately, I could not track the error to a specific part of the code.
However, I did the steps you described and attached the dump.
xla_dump_part_1.tar.gz
xla_dump_part_2.tar.gz

Hi Peter Hawkins,
Do you have any updates on this issue?
 You can find it here
xladump.tar.gz
Jax version
Jax/Jaxlib: jax-0.4.20 jaxlib-0.4.20+cuda12.cudnn89
System info
Using GPU on an RTX 4090. My code runs successfully on CPU.
Python 3.11.4, installed through anaconda
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 530.30.02              Driver Version: 530.30.02    CUDA Version: 12.1     |
|-----------------------------------------+----------------------+----------------------+

Same problem here. Running on GPU. Any solutions ? Depends on the hyper parameters.

Same issue on CentOS 7. I have tried both the cuda11 and cuda12 pip installations of JAX.
Nvidia-smi:
NVIDIA-SMI 530.30.02              Driver Version: 530.30.02    CUDA Version: 12.1
pip list after installing cuda12:

pip list after installing cuda11:

Error when using JAX in either environment:
2024-02-27 16:32:33.075782: F external/xla/xla/service/gpu/nvptx_compiler.cc:614] Check failed: options.is_autotuning_compilation
Aborted (core dumped)

Any help would be much appreciated.

Any updates on this?
Running into a similar error on A6000 GPU:
F external/xla/xla/service/gpu/model/gpu_performance_model.cc:540] Check failed: common_utilization <= producer_output_utilization (1.4 vs. 1.4)
jax     : 0.4.24
jaxlib : 0.4.24+cuda12.cudnn89
cuda installed via pip wheels

Same error with jax and jaxlib version 0.4.28. I found that replacing one line in my code
return 0.5**(epoch / period) if period else 1

with this
return jax.numpy.where(period, 0.5**(epoch / period), 1)

fixes the error.


[Task]: Basic GAC for modules

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
No response

Read it on Notion
Basic GAC for Packages, Modules, and Module Instances

💡 **TL;DR**
We are going to introduce three new entities and a set of new permissions for them. As a result we are going to add new edges in the hierarchy and lateral graph. The purpose of this document is to validate whether we are covering all the necessary aspects of GAC.

Product Decision

A package is a “new type of an app”. Everyone with access to the apps has access to all types of apps of that workspace (it includes packages).

Background
We are going to introduce three new entities in Appsmith

Package
Module
Module Instance

Package
A package is a container of one or many modules. It’s analogous to an application. A package being published is available to be used by all the applications under the same workspace.

User Persona
Action Description

Package editor
The one who creates and edits a package

Package consumer
The one who installs a package in an app and consumes modules in different pages upon instantiating modules

Module
The module is the reusable element of a package that can be used across apps. A package can contain one or many modules.

User Persona
Action Description

Module editor
The one who creates and edits a module inside a package. The package editor and module editor are the same persona

Module consumer
Package consumers and module consumers are the same personas. They are usually the application developers who use modules upon instantiating them.

Note: App viewers don’t directly interact with the packages used in an app. They won’t be aware of packages being used in an app
Module Instance
The prerequisite of using a module is to instantiate it.

User Persona
Action Description
Future Scope

Module consumer/Package consumer
The user who wants to use a module in an app. The prerequisite of using any module in an app is to instantiate it beforehand. Upon instantiation, the module consumer gets an instance of that module. Multiple instances of a module talk to the same module definition. There are certain properties that can vary from one module instance to another e.g. executeOnLoad, confirmBeforeExecute
One package editor/module editor can consume packages/modules develop by others in his/her package. In that spirit package consumer/module consumer can be app developer or package-developer.

Scope of Changes

💡                                                [AppsmithRole.java](http://AppsmithRole.java) (The highlighted ones)

public enum AppsmithRole {
    ORGANIZATION_ADMIN(ADMINISTRATOR, WORKSPACE_ADMINISTRATOR_DESCRIPTION,
            Set.of(
                    MANAGE_WORKSPACES, WORKSPACE_INVITE_USERS, DELETE_WORKSPACES,
                    WORKSPACE_CREATE_APPLICATION, WORKSPACE_EXPORT_APPLICATIONS, WORKSPACE_DELETE_APPLICATIONS,
                    WORKSPACE_CREATE_DATASOURCE, WORKSPACE_DELETE_DATASOURCES,
                    **WORKSPACE_CREATE_PACKAGE, WORKSPACE_EXPORT_PACKAGES, WORKSPACE_DELETE_PACKAGES**)),
    ORGANIZATION_DEVELOPER(DEVELOPER, WORKSPACE_DEVELOPER_DESCRIPTION,
            Set.of(READ_WORKSPACES, WORKSPACE_MANAGE_DATASOURCES,
                    WORKSPACE_MANAGE_APPLICATIONS, WORKSPACE_READ_APPLICATIONS, WORKSPACE_PUBLISH_APPLICATIONS, WORKSPACE_CREATE_APPLICATION, WORKSPACE_DELETE_APPLICATIONS,
                    **WORKSPACE_CREATE_PACKAGE, WORKSPACE_EXPORT_PACKAGES, WORKSPACE_DELETE_PACKAGES, WORKSPACE_READ_PACKAGES, WORKSPACE_PUBLISH_PACKAGES, WORKSPACE_MANAGE_PACKAGES**,
                    WORKSPACE_INVITE_USERS, WORKSPACE_CREATE_DATASOURCE, WORKSPACE_DELETE_DATASOURCES)),
}

💡                    [AclPermission.java](http://AclPermission.java) (New permissions are mentioned only)

WORKSPACE_CREATE_PACKAGE("create:package", Workspace.class),

WORKSPACE_MANAGE_PACKAGES("manage:workspacePackages", Workspace.class),
WORKSPACE_READ_PACKAGES("read:workspacePackages", Workspace.class),
WORKSPACE_PUBLISH_PACKAGES("publish:workspacePackages", Workspace.class),
WORKSPACE_EXPORT_PACKAGES("export:workspacePackages", Workspace.class),
WORKSPACE_DELETE_PACKAGES("delete:workspacePackages", Workspace.class),

MANAGE_PACKAGES("manage:packages", Package.class),
READ_PACKAGES("read:packages", Package.class),
PUBLISH_PACKAGES("publish:packages", Package.class),
EXPORT_PACKAGES("export:packages", Package.class),
DELETE_PACKAGES("delete:packages", Package.class),

PACKAGE_CREATE_MODULES("create:modules", Package.class),

MANAGE_MODULES("manage:modules", Module.class),
READ_MODULES("read:modules", Module.class),
DELETE_MODULES("delete:modules", Module.class),

MANAGE_MODULE_INSTANCES("manage:moduleInstances", ModuleInstance.class),
READ_MODULE_INSTANCES("read:moduleInstances", ModuleInstance.class),
DELETE_MODULE_INSTANCES("delete:moduleInstances", ModuleInstance.class),

PAGE_CREATE_MODULE_INSTANCES("create:moduleInstances", Page.class),
MODULE_CREATE_MODULE_ACTIONS("create:moduleActions", Module.class),
MODULE_CREATE_MODULE_INSTANCES("create:moduleInstances", Module.class),

💡                     [PolicyGeneratorCE.java](http://PolicyGeneratorCE.java) (Only the new edges are mentioned)

createWorkspacePolicyGraph
lateralGraph.addEdge(MANAGE_WORKSPACES,WORKSPACE_MANAGE_PACKAGES);
lateralGraph.addEdge(MANAGE_WORKSPACES,WORKSPACE_READ_PACKAGES);
lateralGraph.addEdge(MANAGE_WORKSPACES,WORKSPACE_PUBLISH_PACKAGES);

lateralGraph.addEdge(WORKSPACE_CREATE_PACKAGE, WORKSPACE_MANAGE_PACKAGES);
lateralGraph.addEdge(WORKSPACE_CREATE_PACKAGE, WORKSPACE_DELETE_PACKAGES);

lateralGraph.addEdge(WORKSPACE_MANAGE_PACKAGES, WORKSPACE_READ_PACKAGES);
lateralGraph.addEdge(WORKSPACE_MANAGE_PACKAGES, WORKSPACE_PUBLISH_PACKAGES);

lateralGraph.addEdge(WORKSPACE_DELETE_PACKAGES, WORKSPACE_READ_PACKAGES);
lateralGraph.addEdge(WORKSPACE_EXPORT_PACKAGES, WORKSPACE_READ_PACKAGES);

lateralGraph.addEdge(DELETE_WORKSPACES, WORKSPACE_DELETE_PACKAGES);

createDatasourcePolicyGraph
hierarchyGraph.addEdge(WORKSPACE_MANAGE_PACKAGES,MANAGE_DATASOURCES);
hierarchyGraph.addEdge(WORKSPACE_READ_PACKAGES,EXECUTE_DATASOURCES);

createPackagePolicyGraph
hierarchyGraph.addEdge(WORKSPACE_MANAGE_PACKAGES,MANAGE_PACKAGES);
hierarchyGraph.addEdge(WORKSPACE_READ_PACKAGES,READ_PACKAGES);
hierarchyGraph.addEdge(WORKSPACE_PUBLISH_PACKAGES,PUBLISH_PACKAGES);
hierarchyGraph.addEdge(WORKSPACE_EXPORT_PACKAGES,EXPORT_PACKAGES);
hierarchyGraph.addEdge(WORKSPACE_CREATE_APPLICATION,APPLICATION_CREATE_PAGES);
hierarchyGraph.addEdge(WORKSPACE_DELETE_PACKAGES,DELETE_PACKAGES);

// If the user is being given MANAGE_PACKAGES permission, they must also be given READ_PACKAGES perm
lateralGraph.addEdge(MANAGE_PACKAGES,READ_PACKAGES);

createModulePolicyGraph
hierarchyGraph.addEdge(MANAGE_PACKAGES,MANAGE_MODULES);
hierarchyGraph.addEdge(READ_PACKAGES,READ_MODULES);
hierarchyGraph.addEdge(DELETE_PACKAGES,DELETE_MODULES);
hierarchyGraph.addEdge(PACKAGE_CREATE_MODULES,MODULE_CREATE_MODULE_ACTIONS);

lateralGraph.addEdge(MANAGE_MODULES,READ_MODULES);

createPagePolicyGraph
hierarchyGraph.addEdge(*APPLICATION_CREATE_PAGES*, *PAGE_CREATE_MODULE_INSTANCES*);

createActionPolicyGraph
hierarchyGraph.addEdge(MANAGE_PAGES, MANAGE_MODULE_INSTANCES);

hierarchyGraph.addEdge(MANAGE_MODULES,MANAGE_ACTIONS);
hierarchyGraph.addEdge(MANAGE_MODULES,MANAGE_MODULE_INSTANCES);
hierarchyGraph.addEdge(READ_MODULES,EXECUTE_ACTIONS);
hierarchyGraph.addEdge(READ_MODULE_INSTANCES,EXECUTE_ACTIONS);
hierarchyGraph.addEdge(DELETE_MODULES,DELETE_ACTIONS);

lateralGraph.addEdge(MANAGE_MODULES, READ_MODULES);
lateralGraph.addEdge(MANAGE_MODULES, DELETE_MODULES);
lateralGraph.addEdge(MANAGE_MODULE_INSTANCES, READ_MODULE_INSTANCES);
lateralGraph.addEdge(MANAGE_MODULE_INSTANCES, DELETE_MODULE_INSTANCES);

Visualisation
Hierarchy Graph

Lateral Graph

Callouts
How permission groups are created for packages, modules and module instances?
Permission groups are inherited from workspace to packages, packages to modules and page to module instances
Correctness of the list of permissions and edges
Do the above permissions and the edges in both the hierarchy graph and lateral graph will suffice?
Writing migration
Will it be sufficient if we only add the new permissions to the existing default permission groups?
Additional Resources
Create a reusable query from scratch
https://www.figma.com/file/Z0QsSdGOydURn6WIMQ3rHM/Solution-Design?type=design&node-id=670-72379&t=6fpnw9vwheFjgypG-0
Create a reusable query from existing query
https://www.figma.com/file/Z0QsSdGOydURn6WIMQ3rHM/Solution-Design?type=design&node-id=676-84540&t=6fpnw9vwheFjgypG-0

We got Trisha's go-ahead with the approach mentioned in the notion doc.
Ref: Comment on Notion doc
Hence, closing this issue and closing this exploration epic as well.
cc: @dilippitchika @somangshu


Adding ATM9 Resource Pack Depot

Adding ATM9 Resource Pack Depot

The Private distro was slapped up as a quick tool to just download my packs whenever I needed them, From pc to pc etc. I've since started releasing them on Github and Modrinth so the need for the private distro is not even needed anymore. This should give me direct links to point to for each mod.
As for mentioning ATM9 its not even close to time for that. It started out with that but currently mod to mod basis is better. Once I get more in depth with Ad Astra, Allthemodium, The Aether, Blueskies, and some of the other 430+ mods I'll feel more comfortable releasing a Modpack version that has all these packs wrapped into one nice resource pack for easy download/install.
I'll redo my request for addons.conf in the next few days.

I've added all the ones I've uploaded to Github/Modrinth and supplied the links to them.
I will be compiling more over the next few weeks but this should be enough for now, unless there's another way we want me to do this.
I will release an ATM9 Modpack resource pack when I have more confirmation on blocks that are missing/wrong with Ad Astra and Create.

Any update on this? Can this be merged? @TechnicJelle? ^^

Is TysFixes still necessary, or was everything from there merged into BlueMap itself?

I think that's all merged .. it would in theory still apply to older bluemap versions but .. yeah

I also see a few more fixerpacks on Ty's server than are in this list
I seem to remember this PR was a WIP, but I'm not 100% sure anymore what was WIP about it, haha..
Do you remember, @TyBraniff ?

I also see a few more fixerpacks on Ty's server than are in this list I seem to remember this PR was a WIP, but I'm not 100% sure anymore what was WIP about it, haha.. Do you remember, @TyBraniff ?

It was considered WIP because I was finding new blocks as I played. Currently I'm on a break from ATM9. I have made arrangements with another server owner recently to produce a few more bluemap resources packs. I will be starting those hopefully in the next week or so.
Can confirm some of the fixes across my packs are still relavent for 5.0 builds of bluemaps since the server owner I'm working with needed some of my existing packs to fix textures. Notably this was for twilight forest.


Fix preferred encoding computation

Decides which encoding to use depending on both Accept-Encode and the preferred encoding (chooses the preferred one in case brotli and gzip have the same q value)
Uses gzip by default

This will fix #1315

I've measured a lot of brotli vs gzip comparisons, and have always found that with the appropriate settings brotli is faster to compress, decompress and results in smaller filesize at every comparable setting.
It sounds like something is amiss with some setting that would cause gzip to ever win in a fair comparison--it's just an older and less capable algorithm.
What was being measured here?


Consistent min/max zoom support for sources and layers

Some sources support a maxZoom option (e.g. ol.source.XYZ).  Views support a maxZoom option.  It would be consistent for layers to support a maxZoom option (instead of making people calculate minResolution).  In addition, it would be convenient if layers supported a minZoom option (instead of making people calculate maxResolution).  And then it would be nice to add minZoom and maxZoom support to sources where it makes sense.

+1
All layers should support minZoom and maxZoom so we don't have to deal with resolutions.
Moreover, I can't see the "getResolutionForZoom" exposed in the View.
Related question: how do I easily calculate resolution for a given zoom right now?
Thanks!