Error occurs when running "examples/vln_reference_path_follower_example.py"

Habitat-Lab and Habitat-Sim versions
Habitat-Lab: 0.1.7
Habitat-Sim: 0.1.7
❓ Questions and Help
I have installed habitat-lab and habitat-sim on headless machines. I can run examples/shortest_path_follower_example.py successfully. However,when I run examples/vln_reference_path_follower_example.py in habitat-lab folder, it breaks and shows below. I wonder how to solve the issue?
2021-04-06 17:46:13,094 Initializing dataset R2RVLN-v1
2021-04-06 17:46:13,166 initializing sim Sim-v0
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0406 17:46:13.167728  5814 ManagedContainerBase.cpp:19] ManagedContainerBase::convertFilenameToJSON : Filename : default changed to proposed JSON configuration filename : default.scene_dataset_config.json
I0406 17:46:13.184638  5814 AttributesManagerBase.h:283] AttributesManager<T>::createFromJsonOrDefaultInternal  (Dataset) : Proposing JSON name : default.scene_dataset_config.json from original name : default | This file  does not exist.
I0406 17:46:13.184926  5814 AssetAttributesManager.cpp:117] Asset attributes (capsule3DSolid : capsule3DSolid_hemiRings_4_cylRings_1_segments_12_halfLen_0.75_useTexCoords_false_useTangents_false) created and registered.
I0406 17:46:13.185039  5814 AssetAttributesManager.cpp:117] Asset attributes (capsule3DWireframe : capsule3DWireframe_hemiRings_8_cylRings_1_segments_16_halfLen_1) created and registered.
I0406 17:46:13.185156  5814 AssetAttributesManager.cpp:117] Asset attributes (coneSolid : coneSolid_segments_12_halfLen_1.25_rings_1_useTexCoords_false_useTangents_false_capEnd_true) created and registered.
I0406 17:46:13.185235  5814 AssetAttributesManager.cpp:117] Asset attributes (coneWireframe : coneWireframe_segments_32_halfLen_1.25) created and registered.
I0406 17:46:13.185281  5814 AssetAttributesManager.cpp:117] Asset attributes (cubeSolid : cubeSolid) created and registered.
I0406 17:46:13.185315  5814 AssetAttributesManager.cpp:117] Asset attributes (cubeWireframe : cubeWireframe) created and registered.
I0406 17:46:13.185436  5814 AssetAttributesManager.cpp:117] Asset attributes (cylinderSolid : cylinderSolid_rings_1_segments_12_halfLen_1_useTexCoords_false_useTangents_false_capEnds_true) created and registered.
I0406 17:46:13.185531  5814 AssetAttributesManager.cpp:117] Asset attributes (cylinderWireframe : cylinderWireframe_rings_1_segments_32_halfLen_1) created and registered.
I0406 17:46:13.185583  5814 AssetAttributesManager.cpp:117] Asset attributes (icosphereSolid : icosphereSolid_subdivs_1) created and registered.
I0406 17:46:13.185627  5814 AssetAttributesManager.cpp:117] Asset attributes (icosphereWireframe : icosphereWireframe_subdivs_1) created and registered.
I0406 17:46:13.185693  5814 AssetAttributesManager.cpp:117] Asset attributes (uvSphereSolid : uvSphereSolid_rings_8_segments_16_useTexCoords_false_useTangents_false) created and registered.
I0406 17:46:13.185752  5814 AssetAttributesManager.cpp:117] Asset attributes (uvSphereWireframe : uvSphereWireframe_rings_16_segments_32) created and registered.
I0406 17:46:13.185779  5814 AssetAttributesManager.cpp:105] AssetAttributesManager::buildCtorFuncPtrMaps : Built default primitive asset templates : 12
I0406 17:46:13.187259  5814 SceneDatasetAttributesManager.cpp:23] File (default) not found, so new default dataset attributes created and registered.
I0406 17:46:13.187273  5814 MetadataMediator.cpp:47] MetadataMediator::createDataset : Dataset default successfully created.
I0406 17:46:13.234864  5814 AttributesManagerBase.h:283] AttributesManager<T>::createFromJsonOrDefaultInternal  (Physics Manager) : Proposing JSON name : ./data/default.physics_config.json from original name : ./data/default.physics_config.json | This file  does not exist.
I0406 17:46:13.234930  5814 PhysicsAttributesManager.cpp:27] File (./data/default.physics_config.json) not found, so new default physics manager attributes created and registered.
I0406 17:46:13.234944  5814 AbstractObjectAttributesManagerBase.h:175] AbstractObjectAttributesManager<T>::createObject  (Stage) : Making attributes with handle : data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.glb
I0406 17:46:13.234954  5814 ManagedContainerBase.cpp:19] ManagedContainerBase::convertFilenameToJSON : Filename : data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.glb changed to proposed JSON configuration filename : data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.stage_config.json
I0406 17:46:13.234966  5814 AttributesManagerBase.h:283] AttributesManager<T>::createFromJsonOrDefaultInternal  (Stage) : Proposing JSON name : data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.stage_config.json from original name : data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.glb | This file  does not exist.
I0406 17:46:13.235090  5814 AbstractObjectAttributesManagerBase.h:181] AbstractObjectAttributesManager<T>::createObject  (Stage) : Done making attributes with handle : data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.glb
I0406 17:46:13.235097  5814 AbstractObjectAttributesManagerBase.h:188] File (data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.glb) exists but is not a recognized config filename extension, so new default Stage attributes created and registered.
I0406 17:46:13.235116  5814 Simulator.cpp:156] Loading navmesh from data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.navmesh
I0406 17:46:13.271909  5814 Simulator.cpp:158] Loaded.
I0406 17:46:13.279351  5814 SceneGraph.h:93] Created DrawableGroup:
Renderer: PH402 SKU 200/PCIe/SSE2 by NVIDIA Corporation
OpenGL version: 4.6.0 NVIDIA 440.64.00
Using optional features:
    GL_ARB_ES2_compatibility
    GL_ARB_direct_state_access
    GL_ARB_get_texture_sub_image
    GL_ARB_invalidate_subdata
    GL_ARB_multi_bind
    GL_ARB_robustness
    GL_ARB_separate_shader_objects
    GL_ARB_texture_filter_anisotropic
    GL_ARB_texture_storage
    GL_ARB_texture_storage_multisample
    GL_ARB_vertex_array_object
    GL_KHR_debug
Using driver workarounds:
    no-forward-compatible-core-context
    nv-egl-incorrect-gl11-function-pointers
    no-layout-qualifiers-on-old-glsl
    nv-zero-context-profile-mask
    nv-implementation-color-read-format-dsa-broken
    nv-cubemap-inconsistent-compressed-image-size
    nv-cubemap-broken-full-compressed-image-query
    nv-compressed-block-size-in-bits
I0406 17:46:13.528337  5814 ResourceManager.cpp:234] ResourceManager::loadStage : Not loading semantic mesh
I0406 17:46:13.528364  5814 ResourceManager.cpp:262] ResourceManager::loadStage : start load render asset data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.glb.
I0406 17:46:13.528370  5814 ResourceManager.cpp:569] ResourceManager::loadStageInternal : Attempting to load stage data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.glb
I0406 17:46:13.528396  5814 ResourceManager.cpp:1119] Importing Basis files as BC7 for aayBHfsNo7d.glb
W0406 17:46:25.228698  5814 Simulator.cpp:248] :
---
 The active scene does not contain semantic annotations.
---
I0406 17:46:25.511915 5814 simulator.py:213] Loaded navmesh data/scene_datasets/mp3d/aayBHfsNo7d/aayBHfsNo7d.navmesh
2021-04-06 17:46:25,517 Initializing task VLN-v0
Environment creation successful
Agent stepping around inside environment.

Fixed in scope of https://github.com/facebookresearch/habitat-lab/pull/983.


Add 3Dc/BC5/DXN direct DDS upload

This is an implementation for the direct uploading of 3Dc textures. Specifically in this case BC5 which maps to the OpenGL RGTC extension. It checks for the existence of the extension so it should work even on extremely old OpenGL versions.
As a side note I also saw that there is a memcpy that copies the entire texture data which is only necessary for uncompressed loads. I wanted to keep the number of changes small as to facilitate easy merging, but it is something I would like to change as texture uploads are the biggest bottleneck in my application.
Might I ask what C standard you are using, is it C89 or C99? Might it also be useful to set a minimum OpenGL version for the library? Something like OpenGL 3.2 which released 11 years ago or 4.2 from 9 years ago seem like pretty decent targets. Basically any hardware that supports OpenGL and is still in use supports at least OpenGL 3.2 and setting a minimum version can really clean up the codebase. Users requiring older OpenGL versions can always use a release such as 1.20.

Excellent, thanks for your contribution!
A couple of things:
Most of the changes in this PR are formatting changes, I'm guessing that you are using an auto-formatter. Could you please revert those changes? It makes harder to analyse the PR and I prefer to keep the things as they are.
SOIL2 tries to use old C89 for better compatibility with Visual Studio.
To ensure the RGTC support please add a texture that can be loaded in the tests as a quick verification.
As for the OpenGL support, I prefer to keep it this way. There's no real justification to drop support for older versions since some projects still uses old GL contexts for better compatibility (I personally still do this too). Also it's important to point out that SOIL2 support GL ES and WebGL targets.

I created a Clang format file that I think most closely matches your formatting style. Perhaps you can tweak it more to your liking and add it to the repository. This way everybody can work in their preferred formatting style and there will be no issues with formatting being the primary changes as you can just format the code in the old style automatically after you are done.
clang-format.txt
Rename this file to ".clang-format" and put it in the source folder root. Visual Studio (2017+) and many other editors will automatically detect it.

I added a test image which looks like this:

Great, it's looking good!
As for the clang-format, I actually never defined a format, because I kinda changed the format from the original SOIL and at the moment is a mix of different formats, I should set a format and provide the clang format. I'll check the one you shared. Thanks!


Documentation> Custom Items> Link "using your custom type." is navigating to incorrect location

Describe the bug
Link "using your custom type." is navigating to "Async" heading.
To Reproduce
Steps to reproduce the behavior:

Go to https://react-magma.cengage.com/version/2.5.7/api/combobox/#custom_items
Navigate to "Custom Items"
Click on link "using your custom type."
Observe that heading "Custom Items Typescript" is appearing for fraction of seconds
Verify that heading "Async" is appearing after some time

Expected behavior
Link "using your custom type." should navigate to correct location.
Screenshots
https://somup.com/c3n66ZZPFg
Desktop :

OS: [Win 10]
Browser [chrome]
Version [Chrome version: Version 98.0.4758.81 (Official Build) (64-bit)]

could not recreate, please re-test to verify.

The issue is Fixed.
See Screen-cast : http://somup.com/c36IhUv6Hn
Thanks!


Component list not updating in Inspector after update

Version
6.0.2
Browser and OS info
Chrome, macOS Monterey
Steps to reproduce
I was working with the previous version of vue devtools in chrome, then it crashed and I had to reload the extension from the chrome extensions page. I then went back to my app, closed chrome devtools, reloaded the page, opened chrome devtools again, and went to vue devtools. I am now seeing the new version of vue devtools. After clicking through the modal that says what's new, I land on the Inspect tab with the components list. Now is when the components list doesn't change when I navigate pages, open modals, or anything. Using the little "Select component in the page" doesn't work, either. Nothing I click with that updates the components list in vue devtools.
I've tried closing and reopening chrome devtools and  reloading my app. Now the component list is empty.
The app selector only has "No app" as an option, not sure if that is a factor.
What is expected?
The components list to be reactive and update according to app behavior
What is actually happening?
The dev tools component list is "frozen"

Version I put above is 6.0.2 is of the vue devtools extension, according to chrome's manage extension page

Same issue on Brave, and Chrome (using Vue2).

I was going to report the same issue on Chrome 98, but it looks like the underlying issue (at least for me) is that the components (which are registered to a single Vue instance) are now broken out into individual apps.

Admittedly I skipped through the What's New info, so if that change was covered there it's just user error on my part.

Admittedly I skipped through the What's New info, so if that change was covered there it's just user error on my part.

Yup. 🐈

This issue is now fixed with the latest version of vue dev tools. I'd suggest closing this Issue.


SQL queries not traced when using FastAPI with encode/databases

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.39.1
Steps to Reproduce
When using the encode/databases package for async database access in FastAPI, queries are not traced.
Example code:
from typing import List

import databases
from fastapi import FastAPI
from pydantic import BaseModel
import sentry_sdk
import sqlalchemy

DATABASE_URL = "sqlite:///./test.db"
ASYNC_DATABASE_URL = "sqlite+aiosqlite:///./test.db"

sentry_sdk.init(
    dsn="https://....",
    debug=True,
    enable_tracing=True,
    profiles_sample_rate=1.0,
    traces_sample_rate=1.0
)

database = databases.Database(ASYNC_DATABASE_URL)
metadata = sqlalchemy.MetaData()
notes = sqlalchemy.Table(
    "notes",
    metadata,
    sqlalchemy.Column("id", sqlalchemy.Integer, primary_key=True),
    sqlalchemy.Column("text", sqlalchemy.String)
)
engine = sqlalchemy.create_engine(
    DATABASE_URL, connect_args={"check_same_thread": False}
)
metadata.create_all(engine)

app = FastAPI(
    title="SentryTest",
    version="0.0.1"
)

class Note(BaseModel):
    id: int
    text: str

@app.get("/test")
async def test() -> List[Note]:
    query = "SELECT * from notes;"
    return await database.fetch_all(query=query)

Output of pip freeze --all:
aiosqlite==0.19.0
annotated-types==0.6.0
anyio==3.7.1
certifi==2023.11.17
click==8.1.7
databases==0.8.0
exceptiongroup==1.2.0
fastapi==0.105.0
greenlet==3.0.2
h11==0.14.0
httptools==0.6.1
idna==3.6
pip==23.3.1
pydantic==2.5.2
pydantic_core==2.14.5
python-dotenv==1.0.0
PyYAML==6.0.1
sentry-sdk==1.39.1
setuptools==68.2.2
sniffio==1.3.0
SQLAlchemy==1.4.50
starlette==0.27.0
typing_extensions==4.9.0
urllib3==2.1.0
uvicorn==0.24.0.post1
uvloop==0.19.0
watchfiles==0.21.0
websockets==12.0
wheel==0.41.3

Expected Result
The queries should show up in the web interface
Actual Result
The queries do not show in the web interface

Hey @romabysen, thanks for raising this. When you say queries are not traced, do you mean there are no database spans at all, or are they missing some data?
For some background, we don't have an integration for databases yet. As I understand it's using SQLAlchemy under the hood, but if there are no DB spans then this will either need a new integration just for databases, or changing the SQLAlchemy integration, or writing integrations for more async DB drivers outside of asyncpg.

No database spans at all.
Yes, databases is an abstraction on top of SQLAlchemy to make it easier to work with async connections. It is the library the FastAPI documentation uses in the section on async databases and since both FastAPI and SQLAlchemy has integrations I thought it would just work. I guess it does something differently.

We instrumented SQLAlchemy, the Django ORM and asyncpg to create database spans.
As I read encode/database can also use asyncpg as the driver.
What driver are you using @romabysen and can you try if database spans are created when you use the asyncpg driver? This would help us a lot!

I'm using the aiomysql driver. I've also tested with the aiosqlite driver and tracing works fine when using SQLAlchemy's create_async_engine directly but not with databases. I'll give the asyncpg driver a try and let you know the result.

The result is the same with asyncpg. Queries are successfully traced when using create_engine and create_async_engine but not with databases.

Hey @romabysen ! Thanks for letting us know. So I guess we have to look into encode/databases a bit to figure out what is going on.

+1 Also looking for better asyncpg connection pools support


Updated existing Administrator Onboarding Tasks

Overhauled existing Administrator Onboarding Tasks content to provide greater thought leadership and clearer deployment setup guidance and recommendations for System Admins.

@cwarnermm  While Neil is away, I'll cover for him on reviewing this PR for this week's go-live.
In terms of details, they're looking good! Just some high-level questions:
1 - If the intent is to make the admin feel like "going from zero to hero", I wonder how we can convey that on this page? I.e. instead of it feeling like a list of onboarding/setup tasks, how do I feel like a hero by the end of it.
For instance, instead of Integrate with your directory services, perhaps we can frame the section on how the admin can make the users lives easy by automating onboarding and account provisioning for them.
In other words, as an admin, I want to feel like after each step I'm becoming more of a hero after each step of the process.
2 - Propose adding a couple of screenshots to add a visual element, e.g. one for the workspace insights.

This PR will eventually be closed in favour of https://github.com/mattermost/docs/pull/5664

Closing this PR in favor of FY24 H1 initiatives that will help inform next steps on admin onboarding workflows.


Allow access to setLabelsToSkip from Objective-C.

Thanks :+1:
I hope that the next Swift update will prevent the need for these bridging hacks...


WP-1200 Requirements Analysis and Architectural Design

This WP meets the requirements Task-1 of the ITT Special Conditions of Tender [TD04]  (more details in the tasks below):
• R01 refine the relevant use cases and consolidate the BB Component requirements
• R02 perform a state-of-the-art analysis and relevant open source projects to the BB
• R03 initiate online docs for BB architecture, functionalities and standardized interfaces
• R04 specify the BB requirements in a customer-oriented way
• R05 establish Stakeholders and NoR
• R06 contribute to the Reference Architecture Implementation Roadmap for the BB

[ ] #3
[ ] #44
[ ] #45
[ ] #46
[ ] #47
[ ] #48

Created Work Packages as Labels


error show if logout after reload page

Current I got this issue, after login, then reload the page, and next logout. I got below error. If not reload, it works fine. How can I fix it?

It seem's like a bug. I will fix it shortly! Plz wait few hours 😃

Thank you for interest & waiting. I fixed the bug v2.1.1!


Application.get_env deprecation

Application.get_env has been softly deprecated (in module body) starting with Elixir 1.14. Still just a warning, but causes issues with "compile without warnings"
Recommend updating 'geo' version to 3.6 as it changes get_env calls to compile_env.
Tested geo update locally. Compiles and tests pass.

Ohh, interesting. I didn't realize that's how the dependency resolution worked for packages... I assumed it'd take the latest. Yeah, I'll get that updated. 👍

Awesome! Thank you!

Released in v3.6.0 👍


fix(model-datastructure): detect changed children in a node if a child node changes its role

This fixes the case tested by DiffTest.moveChildInsideNode.
The problem was, that when a child node moved inside its parent node, the changed was not propagated to the visitor.
Moving a child inside a node is equivalent to changing the role of the child node in the parent.
DiffTest.moveChildOutsideNode works without the fix and was added for completeness.

Locally, this change makes sense. But I'm not sure about the global implications.

:tada: This PR is included in version 3.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


When the example script was run, it was killed

When I run the following code:
./Examples/Stereo/stereo_human
./Vocabulary/ORBvoc.txt
./Examples/Stereo/config/tartanair.yaml
/.../TartanAir_shibuya/RoadCrossing07
./Evaluation/data/trajectory_output.txt
The following situation occurs:
the system is running offline without multi-threading!!!!!!!!!!!!!!!
Input sensor was set to: Stereo
Loading ORB Vocabulary. This could take a while...
Killed

@sien110
Hi could you try to use gdb to check where the program failed?

I have checked the log files, and it seems that the program was interrupted due to a memory issue. How much memory does this program need to run smoothly?

@haleqiu This was my mistake, the error occurred due to the omission of ORBvoc.txt during compilation.

@sien110 I am glad to hear that you have solved this problem. I will close this issue.
Just out of curiosity, did you forget to add the ORBvoc.txt argument?


Fast switch dashboards?

Description
Any way to fast switch between dashboards? Would be really useful when being on mobile device
Priority
Medium (Would be very useful)

Hey @pl33x
You could just add an app / bookmark that links to the other dasboard. Other than that there is currently nothing like that


is the output file size for both avif and webp the same if it was down-sized from an original image and the quality set to the same value?

Question about an existing feature
What are you trying to achieve?
Trying to find out which format has the best algorithm in storing image data whilst having the highest quality.
Don't different algorithms have different ways of storing image data that results in different file sizes?
Even if I set the quality options to a lower value, both formats still produce the same hash.
When you searched for similar issues, what did you find that might be related?
No issues found related to comparing webp and avif.
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question
const image = sharp(filePath.realPath).rotate();
image.resize({ width: 2048, height: 2048, fit: sharp.fit.inside, withoutEnlargement: true, kernel: sharp.kernel.nearest });
const options = { quality: 100, lossless: false, effort: 0 };
const avif = image.avif(options); const webp = image.webp(options);
await Promise.all([avif.toFile(`${output}.avif`), webp.toFile(`${output}.webp`)]);

Please provide sample image(s) that help explain this question
Both having the same hash also means both are the same size.

If you're generating multiple, varying outputs from the same input at the same time, you'll need to clone the sharp instance to avoid a race condition.
- const avif = image.avif(options); const webp = image.webp(options);
+ const avif = image.clone().avif(options);
+ const webp = image.clone().webp(options);


Wrong imports in generated file

Bug Report
Summary
Wrong imports in generated file.

SDK Version: 3.6.1
Expected behavior: Using the union type or import the union type elements
Actual behavior: Importing the union type and using the single elements

Code occuring the bug
import typia from 'typia'
import { Union } from 'example.types' // Union = A | B
export const check = typia.createIs<Union>()

The error is in the generted file using the command npx typia generate
import typia from 'typia'
import { Union } from 'example.types' // Union = A | B
export const check = (input: any): input is A | B = ... // A | B not found

I'll try it. Please wait until weekend.


Add docs workflow

Exploratory, work in progress. 😁

Thanks @lmars for debugging and fixing the AWS S3 piece! 🎉
In terms of the bits I had worked out, thinking about it further in respect of how we're using Github's exposed default environment variables...
An alternative approach for detecting whether we've been triggered from a pull request or from a push to main is to first inspect GITHUB_EVENT_NAME. If we find pull_request there, then we know that the event data must include a pull request number.
I might push another commit to implement that as I think it's cleaner. Relying on jq returning us null when it can't find a key in the event json feels icky. FYI, @owenpearson.

This is our first end-to-end proof of life in respect of pushing content out to the SDK Team S3 bucket.
I think the only piece that is missing is how we might create a deployment for when the docs are build from the main branch... but I've not fully got my head around where/how that would be applicable, and I've not seen examples of this being done elsewhere (though I've not searched very hard).

Back to the drawing board in respect of environment naming, now that I've seen the results of adding #99 to the mix.
More detail in Slack.

Still some work to do on this pull request... next up is to create a deployment when run against the main branch. That's more difficult to test, clearly, given we're on a pull request against a feature branch while iterating this but I have a few ideas there. I'll carry on tomorrow on this so shall leave this PR in Draft state for now.

ok, I think I've got this to a happy place now. Yet to be proven on the main branch, but we'll find out about that when this pull request lands! 🤞
@owenpearson and I have put a fair bit of thought into environment names:

staging/pull/97/dartdoc for a pull request
staging/main/dartdoc for the main branch

Where:

the staging prefix is the "where" (where sdk.ably.com is our https-accessible staging site)
the middle bit (pull/97 or main) is the "context / what"
the dartdoc suffix is the "which bit"

We're keen to keep the suffixes short, as these environment names are visible from the repository home page (right hand side column). e.g.:

We've also decided to keep a 1:1 relationship between the environment name (beyond the staging prefix) with the remote path we serve at sdk.ably.com. And, of course, this is all also aligned with GitHub-native paths also. Hopefully keeps everything straight and logical.
So, sorry @lmars and @owenpearson, but I need to re-request review from you both please as a lot's changed since you approved this PR in a much earlier state.

Thanks for the re-approves.
@tiholic and @tbedford, I'm keen to respond to any feedback you may have after this pull request has landed as we definitely want to iterate further if there's anything you spot that's awry!
Right now, however, I'm going to land this so we can see if the deployment works on the main branch too. 🤞


Add nix flake check in CI

Noticed when addressing #304

https://github.com/NixOS/nix/issues/6453 ? 🤔
Run nix flake check

evaluating flake...
copying path '/nix/store/1rp9mgpy83k4w11gi58hqfcqhk3nnahp-source' from 'https://cache.nixos.org'...
error:
       … while checking flake output 'packages'

         at /nix/store/hwsdv71bmaqvzbii5viryxc8slw4vr5v-source/lib.nix:73:15:

           72|             {
           73|               ${key} = (attrs.${key} or { })
             |               ^
           74|               // (appendSystem key system ret);

       … while checking the derivation 'packages.x8[6](https://github.com/kachick/dotfiles/actions/runs/6114077316/job/16594875686?pr=305#step:5:7)_64-linux.homeConfigurations'

         at /nix/store/9higzycn3l6h3ra40ki3ckcc8ixvrx5d-source/flake.nix:4[7](https://github.com/kachick/dotfiles/actions/runs/6114077316/job/16594875686?pr=305#step:5:8):9:

           46|
           47|         packages.homeConfigurations =
             |         ^
           4[8](https://github.com/kachick/dotfiles/actions/runs/6114077316/job/16594875686?pr=305#step:5:9)|           {

       error: flake attribute 'packages.x86_64-linux.homeConfigurations' is not a derivation
Error: Process completed with exit code 1.

https://github.com/nix-community/home-manager/issues/1783 🤷♂

https://discourse.nixos.org/t/custom-flake-outputs-for-checks/18877/8 👀

Closing for now


bug: Input with inline label goes off-screen

Type: bug
Platform: all
When I have a form with inline labels, the label goes off-screen when I fill up the text field. Below are screenshots before and after typing text into my browser (300px wide).
I'm using markup specified at http://ionicframework.com/docs/components/#forms-inline-labels which looks like

    Email address
    <input type="email" placeholder="Enter email">

Reproduced here http://codepen.io/mikemintz/pen/LExZYb?editors=101 You have to make the browser window narrow enough to see this. I can reproduce it on an iPhone 5 by loading it directly at http://codepen.io/mikemintz/debug/LExZYb
Also reported on the forum: http://forum.ionicframework.com/t/input-with-inline-label-goes-off-screen/15271

Email address

Try above and also can follow the following tutorial:
http://www.sitepoint.com/position-text-labels-on-forms-using-css/

@pulakb if I put the input field outside the label element, the input no longer appears on the same line with the label text.

@mikemintz Yes I agree but that you can manage using CSS. You can go through the link I have shared above in that direction.

Looks like we may need to change some flex properties.
http://codepen.io/mhartington/pen/zxNMqG

The flex properties fix seems to work wonderfully on smaller screens like the iPhone 4 and 5, but then breaks on the iPhone 6 and 6+.

Hmm, the only solution I could come up with is changing the whole flex property to this.
.item-input input{
  flex: 1 0 65%;
  text-overflow: ellipsis;
}

.input-label {
  flex: 1 0 35%;
}

http://codepen.io/mhartington/pen/gbePEr
But the main reason this happens is that the length of the input and span is larger than the whole list item.
It may be worth looking into switching everything to percent values, but I don't think that will happen with 1.0 coming up soon.
@adamdbradley something to note for post 1.0
@mikemintz if you're not up for writing tweaking some css on your end, you may want to consider stacked labels.
http://ionicframework.com/docs/components/#forms-stacked-labels

fixed in d68ecc16b729ad361a655c1050aa03fe22aef137


support CLion IDE

Somewhat different than intellij, also changing with each revision of the application so this would be a nice place to update once for everyone.  may extend intellij and only add the clion specific items that are not already included in intellij.

You have a few options in this respect.  If you want to extend intellij, you can make a symlink from:
/data/custom/CLion.template → /data/gitignore//Global/JetBrains.gitignore
Then add a patch (which I should really name to extension since that what it does) and add the extended functionality in
/data/patch/CLion.patch

@brendon If you  know of any CLion specific items, please let me know.  I'm going to symlink this JetBrains.

Wrong @brendon. Try @brendon-.

Sorry!
@brendon- ??

Nothing specific any longer actually, I no longer have a current license,
sorry this kind of fell off my radar.
On Jan 29, 2017 6:12 AM, "Joe Blau"<EMAIL_ADDRESS>wrote:
Sorry!
@brendon- https://github.com/brendon- ??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joeblau/gitignore.io/issues/263#issuecomment-275907334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-31nChSCEMJgupZrADjwUK1rbZQvdVks5rXHQzgaJpZM4LCp1Z
.


Create codescan-analysis.yml

closing this as there's no context, issue or feature request.  job is failing.

closing this as there's no context, issue or feature request.  job is failing.


Column selection does not allow left highlighting

VSCode Version: 1.9.1
OS Version: Windows 10.0.14393.693

Steps to Reproduce:

Hold Shift+Alt.
Click and drag the mouse cursor left.
Observe that column selection does not begin highlight properly. Instead, the cursor position moves left instead of selecting to the left.

This functionality works appropriately when moving the cursor right. However, moving it left, it doesn't function at all. Standard click+drag actions allow highlighting to the left. Column selection should also allow left highlighting.

Duplicate of #20087, fixed in latest stable release.


Investigate if /subscription endpoint is used anywhere

Description:
Check what /subscription endpoint is used in Android
And can this call be disabled for now, since we don't show user subs level under My Account

Currently I use this call to get maximum shares per sensor from subscription info. Maybe later we'll need to get some additional info. Initially I wanted to update this once per 24h, but due to mistake it was updating on every sync. I've fixed this and now we won't be poking subscription too often.

Hmm, how max number of shares per sensor is known on iOS @priyonto ? If something different, like discussed today, let's unify the apps to use the same calls in the same pages.

@laurijamsa iOS uses hardcoded share limit now. We actually need to implement this endpoint in that case. I created a card: https://github.com/ruuvi/com.ruuvi.station.ios/issues/1740

Moving to done


Add Standard File Organization Document

Why
As we are moving to MVVM + Clean Architecture, we need to update our file organization.
Acceptance Criteria

Link on Notion for review: https://www.notion.so/nimblehq/Standard-File-Organization-63c00b90a81a4a41b1ae3df73dbf2738


URL.createObjectURL(stream) has been deprecated

Deprecated since Firefox 54 (https://www.fxsitecompat.com/en-CA/docs/2017/url-createobjecturl-stream-has-been-deprecated/)
Not yet deprecated in Chrome (https://crbug.com/591719)
Deprecated in Safari https://bugs.webkit.org/show_bug.cgi?id=167518

// Don't do this
video.src = URL.createObjectURL(stream);

// Do this
video.srcObject = stream;

Also see https://github.com/muaz-khan/RecordRTC/issues/326.

Fixed in v2.0.0 (#170).


Dissallow Chords for Integrated Terminal config option is ignored

Issue Type: Bug
I have "terminal.integrated.allowChords": false in my settings.json file, but when I press ⌘-K, I still see the (⌘-K) was pressed. Waiting for second key of chord... text in the bottom ribbon.
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:33:47.663Z)
OS version: Darwin x64 19.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 x 3200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.18GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

gitlens
eam
10.2.1

dotnet-test-explorer
for
0.7.1

vscode-nuget-package-manager
jmr
1.1.6

vscode-docker
ms-
1.2.0

csharp
ms-
1.21.18

python
ms-
2020.5.80290

cpptools
ms-
0.28.1

sublime-keybindings
ms-
4.0.7

vim
vsc
1.14.4

Not sure if it's relevant and if the OS version above includes all the information you would need, but I'm running macOS Catalina, 10.15.4 (19E266).

This is by design, what the setting actually does is for any keystroke that would normally be routed to the terminal, check if it's a chord and skip the terminal if so. For cmd+k, this would never normally go to the terminal so it just gets handled by VS Code's regular keybinding system.


Deployment of Julia-ipython for web usage

This is perhaps a bit of an umbrella issue. I would like to have julia-ipython be ready for the classes this Fall. With stuff such notebookcloud, hosting such a solution for general use on tryjulia.org through EC2 seems like a possibility. As discussed on the mailing list, the earlier web-repl used to get about 50 trials a day and a few hundred a day whenever there was a mention on hackernews etc.
It would be nice to have a list of all the things that have to be done, so that they can be tracked for such a solution to be taken live in the next few months.
So far, I thought JuliaLang/julia#2775 was a bottleneck, but that has been resolved.

Seems to be closed by JuliaBox.


support vsphere

support vsphere
When I delete a vm resource, I fail, and the error is that the variable is not assigned. The reason is that the configuration has been deleted.

support vsphere
When I delete a vm resource, I fail, and the error is that the variable is not assigned. The reason is that the configuration has been deleted.

Great, thanks for supporting vSphere and enhance the destroy process.
Could you please split this PR to two parts, which will help the review.

support vsphere
When I delete a vm resource, I fail, and the error is that the variable is not assigned. The reason is that the configuration has been deleted.

Great, thanks for supporting vSphere and enhance the destroy process.
Could you please split this PR to two parts, which will help the review.

I will split this!


Disabling Script Editor disables opening scripts in External Editor

Godot version: 3.2
OS/device including version: Win10
Issue description:
Disabling Script Editor in the "Manage Editor Features..." makes it so that the external editor (at least VSCode for me) doesn't work. Which is kinda funny since otherwise you probably don't wanna disable it?
Meaning, it doesn't open anymore when:

opening Godot
try to open scripts for almost anywhere in the editor

Steps to reproduce:

Use a external editor (only tested with VSCode).
Disable the Script Editor using Editor -> Manage Editor Features... -> Uncheck Script Editor
Try to open any script...

After some testing the once that works/not that I found are:
Not

Scene (clicking icon, also Attach Script is no longer available)
FileSystem (both double click and open)
Inspector (New Script doesn't open anything)

Works

Existing Signals in Node (Adding a new signal does change the script on save, but doesn't open/focus it)

Also I am quiet sure, but not fully, that this is not intended. I could understans that all these features are connected to the script editor, so perhaps it disables it too much. Only UI option is enough, since the external editor is the only thing that opens anyway.

What sort of functionality were you looking to get out of disabling the Script Editor?

@BigRed-118 Disabling the script editor is meant to be done for artists or level designers so they can't accidentally make changes to scripts. See this page for detailed rationale.
To answer the original issue, I'm not sure if this is intended behavior or not.

@BigRed-118  @Calinou For the same reason as below (from the page you linked) I think it's a neat way of reducing clutter if you use an external editor, only 2d / 3d views, or the like.
So it's hard to think this is intended, since the external editor does open sometimes and other times times not. In it's current state.

We got requests from single developers working on 2D games that they would like to disable the 3D editor and nodes from the Create dialog. The reasoning is that, if not in use, they just add clutter.

With this feature, they can be simply disabled, adding a small usability boost.

@Calinou Do you know who would be able to answer what the intended behavior should be? If you're disabling script editing it sounds like it could make sense for the external editor to be disabled as well.

I'd prefer if it didn't. And at the moment it only does so half way. You can always disable the external editor by unchecking it, so keeping it seperate would increase the amount of flexibility.
It would make sense however to hide the UI elements to open scripts if both were disabled. This would work in accordance with the intent of removing features not needed by some "designers"not the like, and in educational purposes.

@BigRed-118 I think @reduz is probably the one to ask since he implemented the editor profiles feature. That said, he's often busy so it may take a while for him to respond.

@d0rf3n I'm sorry that I'm having trouble understanding, but doesn't enabling the external editor pretty much give you what you want? Disabling the Script Editor seems to just disable all script editing regardless if an internal or external editor is used. Why does the external editor need to work when Script Editor is disabled? Why can't the Script Editor just stay enabled in that case? If not all scripting gets disabled when Script Editor is disabled that could be an issue.

Closing in favor of https://github.com/godotengine/godot-proposals/issues/2059, as the implementation in that proposal makes more sense. Instead of toggling whether you use an external editor, it makes more sense to switch between the built-in and external editor. Disabling the script editor in the editor features should still prevent using that feature entirely (for artists and level designers).

Closing in favor of https://github.com/godotengine/godot-proposals/issues/2059, as the implementation in that proposal makes more sense. Instead of toggling whether you use an external editor, it makes more sense to switch between the built-in and external editor. Disabling the script editor in the editor features should still prevent using that feature entirely (for artists and level designers).


Lie theory reference

Hello! I have been using jaxlie for a project. It is a great package, thank you for writing it! I’d like to understand the theory better in jaxlie.manifold. Could you link a reference for this? In my problem, I am imaging some 3D model and I would like to use autograd to find the correct rigid body rotation of the model that generated the data.

Thank you for sending these references! This is very helpful.


:art: Namespace uint8_t from the C++ stdlib

Coverage remained the same at 99.864% when pulling 836f1c418947ab5c512d5c913494e60a44c219c3 on alex-weej:patch-1 into cd43600e6fe9f7e03594e6a898ab2b61293d7c58 on nlohmann:develop.

Thanks!


[#5276] Update code analysis to latest VS recommendations - Fix error rules - Part 5

Addresses # 5276
#minor

IMPORTANT!
Note: These changes are being address as part of enabling the .NET Analyzers library in the PR # XXX.

Description
This PR updates and fixes multiple rule errors.
List:

CA1003
CA1012
CA1310
CA1727
CA1813
CA1849
CA2201
CA2251

Specific changes

Replaces event handlers to use the generic EventHandler type, instead of creating a custom one.
Replaces constructor public to private access for abstract classes.
Adds the StringComparison.Ordinal when doing a string comparison.
Updates LoggerMessage.Define template string to use PascalCase placeholders.
Added sealed modifier to Attribute classes.
Updated methods to be called as async, when called from an async method.
Updated exceptions to be specific, instead of a generic Exception, ApplicationException, etc.
Updated the use of String.Compare to String.Equals instead.

Testing
This image shows the CI pipeline successfully running after the changes.

promoted 6250


Bump dependencies to k8s 1.11

Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

Adding wip as I'm looking at updating docker/cli too (and probably before this one to not do a double bump)

Is there a risk that this could cause issues with the version(s) vendored in UCP?

@shin- We're moving to bring ourselves inline with UCP and @vdemeester has made sure that it doesn't break backwards compatibility.

Please rebase 🐯

@silvin-lubecki updated to 1.11.1 :wind_chime:


Telnet Login incorrect on DMWG03LM 1.0.8_0001

just update my DMWG03LM from 1.0.7_0021 to 1.0.8_0001, then I'm not able to connect via Telnet.
I tried username: admin and empty password or password: admin, what I got is 'Login incorrect' while Gateway3 component working fine. any idea?

DMWG03LM never had admin user. It has only root user.

DMWG03LM never had admin user. It has only root user.

So sorry! I goofed.


"useNewCompiler": true > Doesn't recompile files via @include meta.load-css("...");

Hi,
I am surprised that when using the new compiler with the appropriate setting, the error occurs that files included via meta.load-css() are not taken into account for recompiling.
This was a bug in Dart Sass before version 1.58 as stated here:
https://github.com/sass/dart-sass/blob/main/CHANGELOG.md#1580
So actually it should be the other way around, because if I use version 6.0.6 with DartSass 1.62.1, the bug should be fixed with this new compiler - or where is my thinking error? Or does "useNewCompiler" mean something different?
Thanks in advance!

useNewCompiler just uses the new JS API (the compile(...) method, rather than the legacy compiler.renderSync(...)). This extension has never used the inbuilt watcher.
Watching is taken care of by VS Code file change tracking, which triggers my code to compile (if necessary) - which you can see below:
https://github.com/glenn2223/vscode-live-sass-compiler/blob/c37e4e2915b6255362a3a2adc1d9b4ac521b3623/src/extension.ts#L173-L181

Sorry, to clarify: it doesn't error when useNewCompiler is false - but does when it's true?
Could I see the SASS file?

I just created a reduced demo and – regardless of the "useNewCompiler" setting – found that it works there (of course). So it has something to do with the constellations in my project and possibly with the many plugins and settings that interfere with each other. Sorry for the false alarm, so I'm closing this case. Thanks for your engagement!

Thanks for doing the extra digging and confirming the false alarm. Glad you've made progress and hope you can resolve it soon
Feel free to come back to me if you do find any weirdness with the extension as you move forward 😁


Add Clear Search Query Button

Add a clear button at the end of the search input field to clear the search query upon clicking.
The clear button will only appear when the search query is non-empty.
I don't know which tool you are using the build the JS build version so I just modify the javascript in src and dist directories.

Hi @edmondchui,
thanks for the PR. Could you maybe add some e2e tests if you want this feature to be merged with the master? And I use Grunt to build so you would need to execute the build task to build, test and package everything. Could you maybe do this and update the PR?
Thanks and regards,
Guy

Coverage decreased (-1.0%) to 72.881% when pulling 4c35b24f35c15ec8fe063daf001ce1bc32b2df6b on edmondchui:master into 1409b539743d83da896a536bd61657daef9f0b3c on guylabs:master.


Tap> value button

I kind of like the inspector, but I've got a bunch of special views setup in portal, so it would be great if there was a tap> button in all the places that have a def button, so I can send it to other tooling, or even log that value.

Hey, that is a good idea, should be pretty straight forward to implement.
Thanks!


Test latest rewrite of the gear selector

What needs to be tested:
The gear selector was rewritten a few weeks ago. I tested a bunch myself, but I want some more testing before pushing it into a release.
The selector init (https://github.com/Mjolnir64/FNF/blob/dev/FNF_MissionTemplate.VR/client/loadout/selector/fn_selector_init.sqf) is called from the client init after the player's loadout gets assigned: https://github.com/Mjolnir64/FNF/blob/f5d894bd405dc3627b7bdf40bbae66933856d708/FNF_MissionTemplate.VR/client/init/fn_clientInit.sqf#L19
This is how each component of the selector works:

Selectable primary weapons are set via the array 'phx_selector_weapons', which is a part of the weapon sets. This array is a 2d array, with each element containing an array with at least a weapon class, but can also contain up to 2 magazine classes, which are the magazines used for the weapon. If no magazines are specified, the system will use whatever magazines the player spawned with, so weapons with compatible magazines don't need to have magazines listed in the selector array. By default, the following roles are not allowed to switch weapons: AR, MG, Marksman, Pilot. Main thing to test here is to make sure the player isn't able to duplicate ammo or weapons.

Reference:
https://github.com/Mjolnir64/FNF/blob/dev/FNF_MissionTemplate.VR/client/loadout/selector/fn_selector_init.sqf
and
https://github.com/Mjolnir64/FNF/blob/f5d894bd405dc3627b7bdf40bbae66933856d708/FNF_MissionTemplate.VR/client/loadout/weapons/base/WEST.sqf#L16

Selector weapons function:
https://github.com/Mjolnir64/FNF/blob/f5d894bd405dc3627b7bdf40bbae66933856d708/FNF_MissionTemplate.VR/client/loadout/selector/fn_selector_weapons.sqf

Selectable optics are set via the array 'phx_selector_optics' and 'phx_selector_magOptics' when magnified optics are allowed (phx_selector_magOptics gets appended to phx_selector_optics) here: https://github.com/Mjolnir64/FNF/blob/f5d894bd405dc3627b7bdf40bbae66933856d708/FNF_MissionTemplate.VR/client/loadout/fn_initLoadout.sqf#L60-L61

If an optic within 'phx_selector_optics' is compatible with the player's primary weapon, they will be able to select it.
Selector optics function:
https://github.com/Mjolnir64/FNF/blob/f5d894bd405dc3627b7bdf40bbae66933856d708/FNF_MissionTemplate.VR/client/loadout/selector/fn_selector_optics.sqf

Combat Engineer selectable charges are set via the array 'phx_selector_explosives' here: https://github.com/Mjolnir64/FNF/blob/f5d894bd405dc3627b7bdf40bbae66933856d708/FNF_MissionTemplate.VR/client/loadout/fn_initLoadout.sqf#L62-L67

'phx_selector_explosives ' is a 2d array with each element containing a selectable charge loadout. The first element of each of those arrays is a text description of the loadout, with any further elements being the charge class and number to add.
The selector first checks if the player has all of the items contained within their old charge loadout (tracked with the variable 'phx_selector_currentExplosives') before switching charge loadouts. This is to prevent duping. Like with the weapon selector, main thing to test here is item duping.
Selector charge function:
https://github.com/Mjolnir64/FNF/blob/f5d894bd405dc3627b7bdf40bbae66933856d708/FNF_MissionTemplate.VR/client/loadout/selector/fn_selector_charges.sqf
Expected behavior of the test:
Players should be able to switch their weapon, optic and charge loadout (if CE) without being able to duplicate any items. Local testing is sufficient for this.

tested in dedicated prior to deployment to check for duplication, functionality issues. none found.
successfully deployed


Small object detection

@Robert-JunWang Hello, thanks for your great work! I want to use this network to detect the small objects in a drone dataset. The images are about 1400px1080px, and the objects are only 50px50px.  The training mbox_loss maintains at 4 or 5 after 20000 iterations, the detection accuracy is only 30%. Is there any suggestions to modify the network or is there any tricks during training phase? Please help me, thank you~

Small object detection is a challenging task for any detection algorithm. In my view, to improve the performance of small object detection is mainly to improve the quality of the feature map used to detect small objects. My first suggestion is to use at least a 38x38 feature map to detect small objects instead of 19x19 feature map used in the original paper. In addition, increasing the resolution of the input image is definitely a big contribution to the performance of the small object detection. Our latest model is specifically designed to be more efficient for high-resolution input. It achieves a pretty good accuracy on the drone image dataset. This model may be open sourced early next year.

Small object detection is a challenging task for any detection algorithm. In my view, to improve the performance of small object detection is mainly to improve the quality of the feature map used to detect small objects. My first suggestion is to use at least a 38x38 feature map to detect small objects instead of 19x19 feature map used in the original paper. In addition, increasing the resolution of the input image is definitely a big contribution to the performance of the small object detection. Our latest model is specifically designed to be more efficient for high-resolution input. It achieves a pretty good accuracy on the drone image dataset. This model may be open sourced early next year.

How to change the feature map from 19x19 to 38x38?

Small object detection is a challenging task for any detection algorithm. In my view, to improve the performance of small object detection is mainly to improve the quality of the feature map used to detect small objects. My first suggestion is to use at least a 38x38 feature map to detect small objects instead of 19x19 feature map used in the original paper. In addition, increasing the resolution of the input image is definitely a big contribution to the performance of the small object detection. Our latest model is specifically designed to be more efficient for high-resolution input. It achieves a pretty good accuracy on the drone image dataset. This model may be open sourced early next year.

Is it open sourced ye?

Small object detection is a challenging task for any detection algorithm. In my view, to improve the performance of small object detection is mainly to improve the quality of the feature map used to detect small objects. My first suggestion is to use at least a 38x38 feature map to detect small objects instead of 19x19 feature map used in the original paper. In addition, increasing the resolution of the input image is definitely a big contribution to the performance of the small object detection. Our latest model is specifically designed to be more efficient for high-resolution input. It achieves a pretty good accuracy on the drone image dataset. This model may be open sourced early next year.

@Robert-JunWang Any update about the model? will be so thankful, if you can provide it


--cfg_path issue

trying to run it on colab. i am using the default.yaml file.  running using the following command.
!python3 "/content/smart-contracts-vulnerabilities-main/main.py" --cfg_path "/content/smart-contracts-vulnerabilities-main/src/config/experiments/default.yaml"
its giving me the following error:
usage: main.py
[-h]
cfg_path
main.py: error: unrecognized arguments: --cfg_path
i have tried giving the path without quotes (""). but its still giving me argument error as 'unrecognized arguments'.

Hi!
Thanks for pointing this out.
It appears that there's an error in our readme, cfg_path is actually passed to the script as a positional argument so the correct way to run the code  on colab is
!python3 "/content/smart-contracts-vulnerabilities-main/main.py" "/content/smart-contracts-vulnerabilities-main/src/config/experiments/default.yaml"
I'll fix the readme asap.


Mirror unloading of units to starting

First trigger stop then unload the unit in a separate loop. This mimics
how we start the units in the first place.
Also unify the logging for the 2 operations.
Signed-off-by: Miek Gieben<EMAIL_ADDRESS>

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

@pires commented on this pull request.
I'm arguing for the current DeletePod behavior to stay as is and for CreatePod
to change instead as I don't see the need for adding yet another iteration, and
another array allocation and dynamic growth, for an array that is already being
iterated upon.

that won't work, as Before unit (init containers) don't get scheduled correctly.

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

@pires commented on this pull request.
I'm arguing for the current DeletePod behavior to stay as is and for CreatePod
to change instead as I don't see the need for adding yet another iteration, and
another array allocation and dynamic growth, for an array that is already being
iterated upon.

that won't work, as Before unit (init containers) don't get scheduled correctly.

Can you develop further what problem you are observing?

Can you develop further what problem you are observing?

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

Can you develop further what problem you are observing?

init container are references by the main ones with an 'After:', it the unit isn't loaded
stuff didn't work - so this when developing this feature - loading and then TriggerStart
solved this problem

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

Can you develop further what problem you are observing?

init container are references by the main ones with an 'After:', it the unit isn't loaded
stuff didn't work - so this when developing this feature - loading and then TriggerStart
solved this problem

Are you saying the Load is asynchronous and not really assuring that a unit was indeed loaded?
This doesn't seem to be deterministic behavior and we are just lucky that in between iterating the two lists there's enough time for the dependency units to actually be loaded. And I'm sorry to say, I don't like it. Worst-case scenario, we should verify if all units are loaded before triggering them.

Are you saying the Load is asynchronous and not really assuring that a unit was indeed loaded?
This doesn't seem to be deterministic behavior and we are just lucky that in between iterating the two lists there's enough time for the dependency units to actually be loaded. And I'm sorry to say, I don't like it. Worst-case scenario, we should verify if all units are loaded before triggering them.

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

Are you saying the Load is asynchronous and not really assuring that a unit was
indeed loaded?

Well, if you have before/after and thus depend on other units, it can't synchronous?

This doesn't seem to be deterministic behavior and we are just lucky that in
between iterating the two lists there's enough time for the dependency units to
actually be loaded. And I'm sorry to say, I don't like it. Worst-case scenario,
we should verify if all units are loaded before triggering them.

We also don't have enough evidence for this. All I can say is that I hit a snag, did this
and now it works (with the little testing that went into it)

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

Are you saying the Load is asynchronous and not really assuring that a unit was
indeed loaded?

Well, if you have before/after and thus depend on other units, it can't synchronous?

This doesn't seem to be deterministic behavior and we are just lucky that in
between iterating the two lists there's enough time for the dependency units to
actually be loaded. And I'm sorry to say, I don't like it. Worst-case scenario,
we should verify if all units are loaded before triggering them.

We also don't have enough evidence for this. All I can say is that I hit a snag, did this
and now it works (with the little testing that went into it)

For instance, iterating the two arrays is not guaranteed to be ordered so what happens when one triggers a unit that depends on another one that hasn't been triggered?

For instance, iterating the two arrays is not guaranteed to be ordered so what happens when one triggers a unit that depends on another one that hasn't been triggered?

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

For instance, iterating the two arrays is not guaranteed to be ordered so what
happens when one triggers a unit that depends on another one that hasn't been
triggered?

They all need to be loaded, actually triggering doesn't matter here, because the
'After:' dependency has been seen by systemd. So that unit referenced in 'After' will be
done first.
You just can't load and trigger at the same time (or at least in the same loop), because
that dep can't be established.
/Miek
--
Miek Gieben

[ Quoting<EMAIL_ADDRESS>in "Re: [virtual-kubelet/systemk] Mirro..." ]

For instance, iterating the two arrays is not guaranteed to be ordered so what
happens when one triggers a unit that depends on another one that hasn't been
triggered?

They all need to be loaded, actually triggering doesn't matter here, because the
'After:' dependency has been seen by systemd. So that unit referenced in 'After' will be
done first.
You just can't load and trigger at the same time (or at least in the same loop), because
that dep can't be established.
/Miek
--
Miek Gieben

Ah, that's so obvious it hurts. Sorry!

Ah, that's so obvious it hurts. Sorry!


Fix resolving ZK hostname upon starting

What changes were proposed in this pull request?
Change ZK hostname to <IP_ADDRESS> on each instance so it is able to resolve itself in case there is a delay in kube-router DNS propagation. Otherwise, after few attempts, ZK stops attempting to resolve its own host and doesn't work properly.
I posted more details in this issue: https://github.com/confluentinc/cp-helm-charts/issues/205#issuecomment-447001502
How was this patch tested?
Tested on our QA and stage environments using helm install. At least one more person had luck with this fix (refer to the above issue).

@qshao-pivotal @srolija is it possible that this is not yet on https://confluentinc.github.io/cp-helm-charts/ ?

My zookeeper cluster can resolve the hostnames after a particular startup time but  I have one more issue now.
I checked the connectivity between two pods and everything seemed fine
[2019-03-10 14:56:41,523] WARN Cannot open channel to 1 at election address kafka-cp-zookeeper-0.kafka-cp-zookeeper-headless.kafka/<IP_ADDRESS>:3888 (org.apache.zookeeper.server.quorum.QuorumCnxManager)
java.net.SocketTimeoutException: connect timed out
	at java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
	at java.net.Socket.connect(Socket.java:589)
	at org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:558)
	at org.apache.zookeeper.server.quorum.QuorumCnxManager.toSend(QuorumCnxManager.java:534)
	at org.apache.zookeeper.server.quorum.FastLeaderElection$Messenger$WorkerSender.process(FastLeaderElection.java:454)
	at org.apache.zookeeper.server.quorum.FastLeaderElection$Messenger$WorkerSender.run(FastLeaderElection.java:435)
	at java.lang.Thread.run(Thread.java:748)
[2019-03-10 14:56:41,524] INFO Resolved hostname: kafka-cp-zookeeper-0.kafka-cp-zookeeper-headless.kafka to address: kafka-cp-zookeeper-0.kafka-cp-zookeeper-headless.kafka/<IP_ADDRESS> (org.apache.zookeeper.server.quorum.QuorumPeer)
[2019-03-10 14:56:41,525] INFO Notification: 1 (message format version), 2 (n.leader), 0x0 (n.zxid), 0x1 (n.round), LOOKING (n.state), 2 (n.sid), 0x0 (n.peerEpoch) LOOKING (my state) (org.apache.zookeeper.server.quorum.FastLeaderElection)
[2019-03-10 14:56:46,525] WARN Cannot open channel to 1 at election address kafka-cp-zookeeper-0.kafka-cp-zookeeper-headless.kafka/<IP_ADDRESS>:3888 (org.apache.zookeeper.server.quorum.QuorumCnxManager)
java.net.SocketTimeoutException: connect timed out
	at java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
	at java.net.Socket.connect(Socket.java:589)
	at org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:558)
	at org.apache.zookeeper.server.quorum.QuorumCnxManager.connectAll(QuorumCnxManager.java:610)
	at org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader(FastLeaderElection.java:838)
	at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:957)

It is on the master, however, it doesn't seem to be on any tagged release yet (latest seems to be 5.0.1-1): https://github.com/confluentinc/cp-helm-charts/blob/v5.0.1-1/charts/cp-zookeeper/templates/statefulset.yaml

@gAmUssA could we have a minor/patch release? we are using the charts from https://confluentinc.github.io/cp-helm-charts/
cc @qshao-pivotal @yangxi @nixsticks @coughman


feat: gh pages deploy

This change will automatically push to the gh-pages branch when a tag is created
Next steps for you @iambumblehead

[ ] go in settings and select gh-pages branch for github pages deploy
[ ] check tht storybook is deployed and working
[ ] let's decide if we want to restore master as the main branch

will involve deleting master and recreating it from develop

[ ] make gh-pages a  protected branch

links

https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site

@lwhiteley I've been busy but will come back to contribute this evening or tomorrow at the latest

thank you @lwhiteley I've followed your directions and the storybook page is live

this stackoverflow answer shows the way I would move 'develop' to 'master' if I were doing it...

yea you can go ahead and replace the master branch


Document pod lifecycle when using EnvFrom

Pods do not start with missing ConfigMaps or Secrets
Pods do not start with missing keys in ConfigMaps or Secrets
Pods start with invalid keys when referring to entire ConfigMaps or
Secrets.  An event documents the skipped keys from said resource.

This change is

We need to wait until https://github.com/kubernetes/kubernetes/pull/42642 is merged

Code has been merged.

@fraenkel FYI, the merge conflict is because we have been migrating the content to a new structure and moved /docs/user-guide/secrets/index.md to /docs/concepts/configuration/secret.md. If you apply your changes there, that should resolve the conflict.

@pmorie Can you take a look? Thx

@pmorie @chenopis Back ticks added.

@fraenkel Thanks!


Office League - Game summary does not show rating points for live game

The game summary page is updated live while the game is played, but it does not show the rating points for the players and teams at the end, until the page is reloaded.

Recommend to set this for all future games. Set ranking og player data on gamestorrage.


technical drawing of machined part motor shaft does not specify width of the flat rectangle

see https://github.com/open-dynamic-robot-initiative/open_robot_actuator_hardware/blob/master/mechanics/actuator_module_v1/drawings/motor_shaft.PDF
the flat rectangle:

length is 4.50mm
depth into the cylinder is (3.99 - 3.40)/2 = 0.295mm
distance from cylinder top is 1.50mm
But I don't see the width of it. What value is it？

i saw the step files


Specifically exclude the word tax from the "Thank You" Regex

Because this is just silly:

@SaintPeter that regex needs fixing https://github.com/dcsan/gitterbot/issues/142

@abhisekp I like your proposed Regex.  Give us a PR, please.

My proposed regex has a minor flaw. Sometimes it doesn't work well with a particular way of thanking as tested in [GitterBotX/playground?at=560a]. It needs to be re-written with proper regex. I'll update it with a better regex and file a PR or if anyone else is interested could take it.

@abhisekp I think it's a great project for you.
Note:  It may be easiest to just try to permute the list of possible "thank you" variants and add them like:
/\b(thx|thanks|thank|tx)\b/
rather than trying to get fancy.  It may not catch all possible "thank you", but it becomes a LOT easier to maintain.  If someone comes up with a new variant, they can just add it to the |ed list.
Here is a quick first pass:
https://regex101.com/r/hH5cN7/30
The only thing I'm not sure about is ignoring stuff inside the triple backtick blocks.  I'm thinking maybe a separate regex could be run to remove those blocks before testing with this regex?

I had a go at it and added a few more tests, https://regex101.com/r/hH5cN7/31


THRIFT-5166: Add support for using WebSockets as a server transport.

Client: d

Add support for using WebSockets as a server transport. I have manually tested it with the nodejs library (bundled for the browser by Webpack) using the binary, compact and JSON protocols. I am opening the pull request now for the purposes of getting feedback before I proceed farther.

[X] Did you create an Apache Jira ticket?  (not required for trivial changes)
[X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[X] Did you squash your changes to a single commit?  (not required, but preferred)
[X] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

Would be super awesome if we could integrate this into the automated tests.


[question] Write on full buffer

From docs:

Streams are essentially “always” writable. The only time they aren’t is when their respective write buffers are full.

If I understand correct: this code is used when buffer are NOT full and if buffers are full this code is used to schedule the writes, and this code are writing them

How can I simulate such a situation ? I am really curious to test this behavior.
What are the advantages to use such an implementation ? Why not just loop fwrite()

You test this by writing large chunks of data to a stream, in particular > 128 KiB (depends on internal buffer sizes, but 128 KiB turned our to always be enough).
E.g. you create a socket pair and write > 128 KB onto it without reading from it.
The code in case there's no full buffer is about reducing latency. Otherwise we have to wait until the next tick for sending the data. You will in particular notice that on servers with a high load.

Thank you @bwoebi, I have done some tests, and get another question :)
example:

client fwrite() 128 bytes of data to stream
server don't fread() them

in this case client's fwrite() will succeed, and there are no way to detect if server fread() them ?
P.S: I suppose that's why we always have server confirmations in classic client <-> server topology

Correct.
You still have to consider, even if you'd rely on a TCP confirmation, it still doesn't mean that a server actually processed something, it just means that the kernel (or if we move that to userspace: the application) has received it. But that deosn't contain any meaningful information for us: we want to know whether a client processed something. So, yes.

@bwoebi Thank you, this was very informative, I think we can close this.


Initial jupyter notebook example & folder creation

Description of proposed changes
Adding a multi-variable xarray dataset example with a pytorch data loader as a jupyter notebook
Fixes #
Does not fix anything

Closed after chatting with @maxrjones in 3D space @ pangeo hackathon


https://github.com/jnwhiteh/vim-golang don't work anymore, change for https://github.com/fatih/vim-go

I think you should change golang package for https://github.com/fatih/vim-go

Already fixed 👍


⚠ DCATD has degraded performance

In 5265932, DCATD ($SITE_URL_DCATD) experienced degraded performance:

HTTP code: 200
Response time: 13095 ms

Resolved: DCATD performance has improved in 19704ad after 8 minutes.


attempt 3 to fix tab/line issue

Pull Request
This PR is for a

[ ] New Publication(s)
[x] Correction

For the following list(s):

[ ] ancientmetagenome-anthropogenic (README)
[ ] ancientmetagenome-environmental (README, ask @thedir-team-dirt for advice)
[ ] ancientmetagenome-hostassociated (README, ask @thedir-team-bugparty for advice)
[x] ancientsinglegenome-hostassociated (README)

New Publication
Publication Information
This pull request is to add samples from the following publication(s):
This is to close
Checklist

[ ] Publication is published (preprints currently not accepted)?
[ ] Checked the publication is not already in the database?
[ ] Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
[ ] Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
[ ] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
[ ] (If applicable) Made a separate PR to add new categories to controlled lists (stored unnder /assets/enums, e.g. material or archive)? If so:
[ ] Changelog is updated to include the publication under 'Added'?

If you do not know how to check errors in failed validation checks, expand here

Press 'details' next to the failed check.
Expand the test ancient <list> line with the red X next to it.
Scroll to the bottom of the log, and look for a DatasetValidationError (usually the last line).
Read the error, and fix accordingly. Check the README for a given list for more guidance. If in doubt, ask!

Correction
This PR is for

[ ] ancientmetagenome-hostassociated
[x] ancientsinglegenome-hostassociated
[ ] ancientmetagenome-environmental
[ ] ancientmetagenome-anthropogenic

Reference
This pull request is to correct samples from the following publication(s): Susat2020
This is to close <!-- write hashtag and the corresponding issue number here, #267
Description
The issue is:

Checklist

[x] Checked the corrected entries follow conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
[x] Changelog is updated to include the publication under 'Changed'?

:tada: looks good now. Last thing is to update the CHANGELOG.md file (make sure it's for the next release, not the already made one!), and then I think we are good to go.


Added setting for no override the runserver command

Runserver command of mezzanine doesn't should override the runserver command if I don't want, If I have already a media configuration, I don't need a custom runserver.
I added a setting for no override the runserver command.

Sorry I forgot to give feedback - I just don't think this warrants a setting to be honest, if you really want you can hack it out in your own project.


iOS: Back button titles should be restored

While I look the cleaner look of not having them, I keep feeling lost. Best to stick with convention in this case.

I'm kinda bummed about this one, but I'm getting over it.


[ENH] :sparkles: Applications can have self-managed groups

I added some tests and tested locally, it's working with SugoiTestService config


main.cpp

eosc  pamameter limit  not work

eosc  pamameter limit  not work

This was fixed via DAWN-245.


Code block not recognized as one if there is trailing space on the closing fence

Describe the bug
Ref https://github.com/helix-editor/helix/issues/9678
Code example
'''c
'''
int i = 0;

Replace the single quotes with backticks and int i = 0 will be highlighted as C.
Expected behavior

According to https://github.github.com/gfm/#fenced-code-blocks, trailing whitespace are ignored on the closing code fence.
Actual behavior
Closing fence is not recognized.

For the record, this parser implements CommonMark Spec, with only some GFM extensions (that are optional but enabled by default). I would prefer to stay strict on this (and similar "softenings" of restrictions that make parsing easier).

But CommonMark also specifies that whitespace after closing fences are to be ignored, so this should be fixed. PR welcome!

I can confirm that this also happens when the closing fence is followed immediately by EOF.

I can confirm that this also happens when the closing fence is followed immediately by EOF. That's an easier scenario to catch than trailing whitespace, so I might open a PR for that case specifically.

If that's easy, a fix there would be awesome, because I think that's probably a more common scenario than trailing whitespace, though obviously both would be nice to have

I would think both should be a fairly easy fix, no? I might be missing something, but could just check for end of file or space in addition to \r and \n in https://github.com/tree-sitter-grammars/tree-sitter-markdown/blob/7fe453beacecf02c86f7736439f238f5bb8b5c9b/tree-sitter-markdown/src/scanner.c#L418


BUG: Unhandled error FirebaseFunctionsError: The principal (user or service account) lacks IAM permission "cloudtasks.tasks.create" for the resource

Hi,
I found I think a bug related to "Extension instance ID" length
Right after the installation of the extension, when it succeeds with "Full Index existing documents?" enabled, "Processing" is never-ending.
In "Error Reporting" in GCP I can see
Unhandled error FirebaseFunctionsError: The principal (user or service account) lacks IAM permission "cloudtasks.tasks.create" for the resource "[...]/ext-firestore-algolia-search-ingredients-executeFullIndexOperation" (or the resource may not exist).

at process.processTicksAndRejections ( node:internal/process/task_queues:95 )

Seen in CloudFunction "ext-firestore-algolia-search-ingredients-qmnu-executeFullIndexO"
And when I am checking the "Cloud Tasks" Queues I see that the name of the queue was truncated to "ext-firestore-algolia-search-ingredients-qmnu-executeFullIndexO"
For the "Extension instance ID" I used: firestore-algolia-search-ingredients-qmnu
"Solution"
When I just uninstalled the extension, installed it one more time but with a shorter "Extension instance ID" everything works fine.

I also stumbled upon the exact same issue. In my case, the trigger URL and the queue id were both truncated to 63 characters, which looks the same as the OP above. However, the extension was still calling the full URL.
If 63 characters is the maximum, then the extention should not allow entering more than that. Otherwise, it should not truncate the URL.

I also stumbled upon the exact same issue. In my case, the trigger URL and the queue id were both truncated to 63 characters, which looks the same as the OP above. However, the extension was still calling the full URL.
If 63 characters is the maximum, then the extention should not allow entering more than that. Otherwise, it should not truncate the URL.

Thanks this works for me


[#125881031]brief filtering template: put page heading, marketplace-paragraph in a 2/3 column as it should be

as per ralph's request.
Story https://www.pivotaltracker.com/story/show/125881031

👍


Change logs folder name to avoid confusing it with proper logs document

Fixes #47
Tried to run tests with Xcode, they crash in one same place. LoggerStoreTests, testRemoveAllMessages, storeMessage function
Tried to run tests with script, script misses destinations input, somehow.
It would be cool to have some guide on contributing, or at least on running known scripts in the process.

Thanks! Yeah, this should fix an issue. I'm going to merge it as is, but I'll might give a bit more thought before I push the release. I'm thinking maybe it's worth just getting rid of this parent folder entirely.

I think I'm going to rename the folder to com.github.kean.logger. It's going to fix the problem, but it's going to continue using reverse DNS notation - I want to make sure there are no conflicts.


Normal text is too dark.

Title.  It didn't start out this dark and I've no idea what changed.  Running the most recent version of the extension on Firefox 119.0.1 under Kubuntu 20.04LTS, non-snap version.

As you can see, totally unreadable, even in a completely dark room.

First off, thank you for submitting! I apologize for the unpleasant UI.
Secondly, I suspect the js script is not running on your browser or it cannot find the elements it's looking for in the DOM.
Is it like this for all your Wiki pages?
I can confirm it works for me, but I will need to investigate this. Please be patient as I'm having a busy life right now :)

You had me at "script not running in your browser".  I use an extension that pretty much blocks java.  Added wikipedia to the whitelist, done deal.  Thanks and sorry to bother you for something so trivial.


[improve][broker] PIP-192: Make unload and transfer admin API functional

PIP-192: https://github.com/apache/pulsar/issues/16691
Motivation
Currently, the unload and transfer admin API still uses the old logic when enabling the ExtensibleLoadManager,
we need to publish the message to ServiceUnitStateChannel, and wait for its response.
Modifications
This PR added a UnloadManager  to handle the duplicate unload request and return a CompletableFuture to the caller, so we can know when the unload operation is finished.
The unload and transfer admin API also been fixed, now we can support do unload when using ExtensibleLoadManager.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/Demogorgon314/pulsar/pull/11

Waiting for https://github.com/apache/pulsar/pull/19525 merge.

@Technoboy- Ping. Please take a look at this PR, thinks!


Add disc golf page link to POI panel

If 1 in disc_golf column in points_of_interest table, display link to Disc Golf web page in "More Information" list. Put in alpha order among other activity links.
Disc Golf

Available on staging for review.
https://github.com/smartchicago/trailsy/commit/4e9fb0ca8644d92b48b008e5a23c5ec496b90605

Good to go.

In production https://github.com/smartchicago/trailsy/commit/d92a30fdd57eb6d2e507f6b05593d196eb20fcb0


[ID-1266] Upgrade sam-client to latest

Ticket: https://broadworkbench.atlassian.net/browse/ID-1266
Related PR: https://github.com/DataBiosphere/terra-workspace-manager/pull/1724
I'm updating WSM to the latest sam-client (for the new action managed identities API); but because of amalgamation I also need to update LZ-service (since the LZ-library pulls in the Sam client).

Actually I found a way to make the sam-client change backwards compatible, so this may not be needed (for the WSM PR, it still is probably good to keep things up to date anyway).

Going to close this as it's not strictly necessary for my WSM change anymore, and I want to reduce moving parts.


Fix regression bug with application title no longer grayed out.

Fixes #631
Description of the changes:

Move back the VisualStateManager node to the root XAML element to fix visual states of the titlebar.

How changes were validated:

Manually

Any chance that you can explain for myself (and the rest of our readers here)?

Of course!
The attached property VisualStateManager.VisualStateGroups can only be attached to the root XAML node of the control's content to work with VisualStateManager::GoToState(...),  else it won't work (hard to detect because it won't crash the app or display an error/warning at compilation time).
The previous change added an additional grid (BackgroundElement) moving by accident the VisualStateManager out of the root node and making VisualStateManager::GoToState ineffective.
.

Thanks @rudyhuyn.

The attached property VisualStateManager.VisualStateGroups can only be attached to the root
XAML node of the control's content to work with VisualStateManager::GoToState(...),  else it won't
work (hard to detect because it won't crash the app or display an error/warning at compilation
time).

That was what I figured based on your change.  Thanks for the confirmation.  I then found corresponding documentation to support that statement as well:
https://docs.microsoft.com/en-us/uwp/api/Windows.UI.Xaml.VisualStateManager#remarks

Control authors or app developers add VisualStateGroup object elements to the root element of a
control template definition in XAML, using the VisualStateManager.VisualStateGroups attached
property.

But then I'm trying to understand other places where it appears to not be on the root XAML node of the control.  Take for example,, the TitleContentControl:
https://github.com/microsoft/calculator/blob/24d997dd00534938cb880722108a0f85ae4c3611/src/Calculator/Views/Calculator.xaml#L928-L944
Here we have a Grid which contains a Border, and the VisualStateMananger.VisualStateGroups is on the Border as opposed to the Grid element which should in theory be considered the root node.
I think your change here is completely right, no doubt.  I'm just trying to wrap my head around some inconsistent usage (as far as I can tell) of VSM then within the project (although, as far as I can tell, this is the only other example in the project besides the one in this PR where VSM isn't attached to the root node).
Thoughts?

Here we have a Grid which contains a Border, and the VisualStateMananger.VisualStateGroups is on the Border as opposed to the Grid element which should in theory be considered the root node.

Even if the Border is a X(A)ML descendant of the Grid, they are not related and are part of 2 different XAML tree structure because the ContentTemplate has its own XAML tree structure.
The Grid is a content of the Page, and is part of its visual tree.
The Border isn't part of the visual tree but part of a template definition describing a Button and is the root node of this definition. (defined in Grid Resources).
So the definition is still correct: the VisualStateManager is attached to the root element of a control template.

Ah.  Good catch.  I completely missed that there was a ControlTemplate embedded within the ContentControl there.  Thanks for looking into all of this.


Unity Package Version

Hi,
I converted the repository to a Unity Package which should allow people to stay on the latest commit more easily (even if the the library probably is super stable at this point).
Would be great if you would accept this PR since otherwise I'd need to maintain a fork. =)
I tried to change as little as possible but I needed to come up with a package name and chose com.unity.keijiro.shader.noise since you employed by Unity Technologies, right?
Feel free to tell me into what you'd like to change the package name and I'll adjust the PR.
Or do it yourself. The following files would need to be altered:

package.json
Demo/HLSL|GLSL/NoiseTest.shader (the include paths)
Demo/Unity.Keijiro.Shader.Noise.Demo.asmdef (filename as well as the name stored in the asset)

I addition I moved the NoiseTest shaders into the Hidden category to not clutter the material shader selection list.
To test the package simply create a new Unity Project with 2018.4 and above and clone the PR into the Packages folder of that project.
Best,
Micha

closed due to conflicting changes


Add remark command

This implement the Remark Command as instructed in Developer Guide.
Usage:
remark INDEX r/"Some remark"
This will update the remark of the person at INDEX returned from the latest filtered list to be "Some remark", regardless of the person already has a remark. If "Some remark" is blank, the command would simply replace the remark with blank.
Remark also can't be created when adding, and can't be edited by the edit command.

seems to be very counter intuitive to just pick one of the person's attributes and for a change disallow changing it by edit command. How can this approach be justified? I would also wonder whether we really need remarks while we have tags that can serve similar or identical role.

in case it would be needed later, we can access it from closed


Support Privacy Manifest

while I understand that your SDK is not singled out on Apple's list, my reading of the new requirements]" applies to app submissions as a whole, meaning that if CodeScanner does not provide a privacy manifest, the app submission will be rejected.

I'm getting emails back from Apple about this because your library is not compliant.
ITMS-91053: Missing API declaration - Your app’s code in the “YourApp” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryUserDefaults. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.

I'm facing with this issue too. could you please help us apply Manifest for this library asap, many thank ^^

@benMohamed  Have you looked through the CodeScanner code to see if you can identify which APIs you think it's using that needs to be reported? I read through the list of APIs that trigger the requirement from the link you included, and then I looked through all the code in this repo and was unable to readily find any use of offending APIs. The message you shared from Apple seems to indicate use of UserDefaults, but I don't see any use of that API in this repo. Are we sure this email is solely a result of your use of the CodeScanner dependency and not specific to your app?
I was hoping to help out by contributing the necessary privacy manifest, but I'm honestly not sure what would need to be in it after reviewing the guidelines and the code or if it's even necessary for this project. Paul indicated in #123 that this project does not need it.

@david-hosier At this point very few people – myself included – really seem to understand what's going on. If you think this project needs one, and you're willing to contribute it, please go for it!

@twostraws I opened this PR https://github.com/twostraws/CodeScanner/pull/138 to fix that issue.

Fixed and released!


Unable to Focus on Charts View Using External Keyboard on iOS

We have customers who rely solely on keyboard navigation. Our app permits interaction with the legend and bars on the BarChartView via touch. However, these UI elements are not accessible via keyboard but can be accessed when VoiceOver is enabled. The same issue is present in the demo app as well. Kindly advise if there's a step I might have overlooked to enable keyboard support, or if the library itself lacks keyboard accessibility. Thank you.

Is any update on this issue ?


posting an html form within wordpress site to rails app using devise for authentication

Hey all,
I created an html form within a wordpress site, which represents a login screen:

Email

Password

Keep me logged in

So that contains pretty much all the parameters devise contains, except the authenticity token is blank here, because I believe devise generates a random string during every session, and of course thats not possible to do within wordpress. I was also unable to log in via curl:
curl -d 'remote=true&commit="Sign<EMAIL_ADDRESS>http://localhost:3000/users/sign_in
What that would do is just send a response back the unauthenticated line in devise.en.yml. And I believe it's because the authenticity_token there is wrong, because I just copied a string that wasnt generated.
So if I am unable to generate an authenticity token through a wordpress webform, how then can I send post data to devise and have it redirect to the home page of my rails application? In other words, I am trying to get from the login form of  a wordpress site to the home page of a rails application through devise application.
thanks for response

You need to disable protect_from_forgery from your application controller. That's all on Rails. Also, please use the mailing list for questions.