.dockerignore ! pattern results in slow builds on large contexts

I have a huge project. I want to include only files like package.json and requirements.txt in the build context. To do that, I tried adding a .dockerignore that excludes * and includes specific files (!foo/requirements.txt).
If I try to use * in .dockerignore and ! to include specific files, it takes a really long time (if the context directory is large).
> du -sh .
1.1G . # this is in a BIG context

> cat empty.dock
FROM ubuntu

> cat .dockerignore
*
!foo/requirements.txt

> docker build -f empty.dock .
# HANGS for a really long time
Sending build context... etc etc

Now, if I remove the included file !foo/bar.txt from .dockerignore, then it's super fast!
> cat .dockerignore
*

> docker build -f empty.dock .
Sending build context... etc etc # INSTANT! :D

Any idea what's up?

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Here's my docker version info:
~/Work/ent-docker docker version                                                                                master!

Containers: 9
 Running: 0
 Paused: 0
 Stopped: 9
Images: 96
Server Version: 1.10.1
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 145
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 4.1.17-boot2docker
Operating System: Boot2Docker 1.10.1 (TCL 6.4.1); master : b03e158 - Thu Feb 11 22:34:01 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 3
Total Memory: 4.433 GiB
Name: default
ID: CSQF:QSAQ:Y2DP:MRLC:FPH5:6QJZ:D4CA:GREI:IJYB:CPQC:ZKSQ:SBAJ
Debug mode (server): true
 File Descriptors: 10
 Goroutines: 24
 System Time: 2016-02-19T01:08:13.945945686Z
 EventsListeners: 0
 Init SHA1:
 Init Path: /usr/local/bin/docker
 Docker Root Dir: /mnt/sda1/var/lib/docker
Labels:
 provider=virtualbox

I'm running virtualbox on OSX.

So, in my own project, I've circumvented this problem by using the following .dockerignore:
*/*/*

This makes my builds run really fast. It seems that it's the ! logic that's slowing things down.

I think I know what's going on here. I think when we have a "!dir/file" we end up checking all nested dirs no matter what - instead of just what's under "dir/".  Still investigating and checking on a fix....

@cricklet I think I have a fix for this - would you be willing to test it out for me before I submit the PR?

Sure thing. I can test it out on Tuesday (going camping till then)
On Fri, Feb 19, 2016, 11:18 AM Doug Davis<EMAIL_ADDRESS>wrote:

@cricklet https://github.com/cricklet I think I have a fix for this -
would you be willing to test it out for me before I submit the PR?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/20470#issuecomment-186366086.

@cricklet any chance you could grab my branch and give this a try?

Will try it tonight at the latest!

Hmm... struggling to set it up on my home computer. Will try and check it out on my work machine tomorrow or day after.

@cricklet any update? I can provide a binary for you if you let me know your OS.

Ah yes, that would be great. I spent an hour or so yesterday getting a
docker development environment set up (i.e. the whole docker inside a
docker thing). I ended up getting some weird configuration problems that I
wasn't able to figure out.
A binary would be muuch easier :) I'm on a Mac: OS X 10.10.5 (14F27)
On Fri, Feb 26, 2016 at 10:07 AM Doug Davis<EMAIL_ADDRESS>wrote:

@cricklet https://github.com/cricklet any update? I can provide a
binary for you if you let me know your OS.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/20470#issuecomment-189401238.

@cricklet try the version here:  http://soaphub.org/docker/docker

@cricklet any luck with the binary I uploaded?

> docker build -f console.dock .
(this completely hangs)
^C
> ~/Work/docker ~/Downloads/docker build -f console.dock .
Sending build context to Docker daemon  29.7 kB
Error response from daemon: client is newer than server (client API version: 1.23, server API version: 1.22)
>

I'm not sure how to upgrade my server to 1.23...
However, it does seem like the actual problem is solved-- the build context is successfully sent (and is small, as expected).

@cricklet you can override the API version that the client uses through the DOCKER_API_VERSION environment var, for example;
DOCKER_API_VERSION=v1.22 docker version

ok let me submit the PR then!


Label and Annotation key validation does not allow the "/" char, resulting in label with truncated key

Setup

Rancher version: v2.9.3
Rancher UI Extensions:
Browser type & version: Mozilla Firefox 132.0.1

Describe the bug
In the Registration creation component of the Elemental UI extension it is not possible to add Label and Annotation templates with keys having the "/" character.
In particular as soon as the "/" char is typed in the key field, the row disappears from the UI.
Moreover, if the resource is created, the resulting resource (looking at the yaml) will contain the templates label/annotation with the key (which will be anyway truncated with what was typed in till the UI row disappeared).
See attached video.
To Reproduce

Add a Label/Annotation with a key containing "/"  (e.g., elemental.cattle.io/InternalIP).
Result
Row disappear while typing, but label is present with a truncated label key in the created resource
Expected Result

The Label and Annotation rows do not disappear from the UI when keys are valid.
The labels key validation should match the Kubernetes label keys syntax: see https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set .
Screenshots
Video:
https://github.com/user-attachments/assets/cbe1cb93-b748-4ff8-aef2-7e577ce87f62
Additional context

After checking with @aalves08, he suggested to track here the issue as the component used in the Elemental UI belongs here.

I've noticed this on other use cases of the label and annotation component, but it's when focus is removed from the key input that the row is removed. Looking at the yaml the key is added (with empty string)

I don't think that this is directly related to #11226, but it's something to look out for; we previously modified input on every keypress in the yaml editor and we could be doing something similar here.


CI: add 2.7

Coverage decreased (-24.3%) to 65.714% when pulling eb5820360341ae2cecd7094515fc4d189b7381a3 on olleolleolle:patch-1 into 8aae6e5726f3bc4175784716267c22f3c5ba5a49 on socketry:master.


Laravel 5.3 Logout MethodNotAllowed Fix

In Laravel 5.3 Logout route is "POST" instead of "GET".  Updated the code based on  @taylorotwell sample code.
https://github.com/laravel/framework/blob/7d116dc5a008e69c97f864af79ac46ab6a8d5895/src/Illuminate/Auth/Console/stubs/make/views/layouts/app.stub
Replaced link with a form.

Sorry I don't understan why i have to add submit button. At the URL you provide the button is no used. Maybe I miss something?


DNS challenge ClouDNS produces an error

Error: Command failed: certbot certonly --config "/etc/letsencrypt.ini" --cert-name "npm-57" --agree-tos --email<EMAIL_ADDRESS>--domains "infologie.net" --authenticator dns-cloudns --dns-cloudns-credentials "/etc/letsencrypt/credentials/credentials-57"
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Encountered exception during recovery: dns.resolver.LifetimeTimeout: The resolution lifetime expired after 5.402 seconds: Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.
An unexpected error occurred:
dns.resolver.LifetimeTimeout: The resolution lifetime expired after 5.402 seconds: Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.
at ChildProcess.exithandler (node:child_process:402:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1100:16)
at Socket. (node:internal/child_process:458:11)
at Socket.emit (node:events:513:28)
at Pipe. (node:net:301:12)

This bug has been happening for hald a year. Best to revert back to at least 2.9.14 and just freeze it.

I have the same issue, I tried with the version 2.9.14 but it still fails. I have a pihole and unbound as my dns with docker, can it be the cause of the dns fail? I have the duckdns ip pointing to an internal ip (where my nginx instance is running)
The errors that I get are:
With the latest version:
Error: Command failed: certbot certonly --config "/etc/letsencrypt.ini" --work-dir "/tmp/letsencrypt-lib" --logs-dir "/tmp/letsencrypt-log" --cert-name "npm-15" --agree-tos --email<EMAIL_ADDRESS>--domains "*****.duckdns.org" --authenticator dns-duckdns --dns-duckdns-credentials "/etc/letsencrypt/credentials/credentials-15" --dns-duckdns-propagation-seconds 120
Saving debug log to /tmp/letsencrypt-log/letsencrypt.log
The resolution lifetime expired after 5.402 seconds: Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /tmp/letsencrypt-log/letsencrypt.log or re-run Certbot with -v for more details.
at ChildProcess.exithandler (node:child_process:402:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1100:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)

With the 2.9.14 version:
Error: Command failed: certbot certonly --config "/etc/letsencrypt.ini" --cert-name "npm-18" --agree-tos --email<EMAIL_ADDRESS>--domains ".**.duckdns.org,***duckdns.org" --authenticator dns-duckdns --dns-duckdns-credentials "/etc/letsencrypt/credentials/credentials-18" --dns-duckdns-propagation-seconds 120
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Trying to detect encoding from a tiny portion of (2) byte(s).
Trying to detect encoding from a tiny portion of (2) byte(s).
The resolution lifetime expired after 5.402 seconds: Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.
at ChildProcess.exithandler (node:child_process:397:12)
at ChildProcess.emit (node:events:390:28)
at maybeClose (node:internal/child_process:1064:16)
at Socket. (node:internal/child_process:450:11)
at Socket.emit (node:events:390:28)
at Pipe. (node:net:687:12)

I have the same issue, I tried with the version 2.9.14 but it still fails. I have a pihole and unbound as my dns with docker, can it be the cause of the dns fail? I have the duckdns ip pointing to an internal ip (where my nginx instance is running)
The errors that I get are:
With the latest version:
Error: Command failed: certbot certonly --config "/etc/letsencrypt.ini" --work-dir "/tmp/letsencrypt-lib" --logs-dir "/tmp/letsencrypt-log" --cert-name "npm-15" --agree-tos --email<EMAIL_ADDRESS>--domains "*****.duckdns.org" --authenticator dns-duckdns --dns-duckdns-credentials "/etc/letsencrypt/credentials/credentials-15" --dns-duckdns-propagation-seconds 120
Saving debug log to /tmp/letsencrypt-log/letsencrypt.log
The resolution lifetime expired after 5.402 seconds: Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.
Ask for help or search for solutions at https://community.letsencrypt.org/. See the logfile /tmp/letsencrypt-log/letsencrypt.log or re-run Certbot with -v for more details.
at ChildProcess.exithandler (node:child_process:402:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1100:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
With the 2.9.14 version:
Error: Command failed: certbot certonly --config "/etc/letsencrypt.ini" --cert-name "npm-18" --agree-tos --email<EMAIL_ADDRESS>--domains ".**.duckdns.org,***duckdns.org" --authenticator dns-duckdns --dns-duckdns-credentials "/etc/letsencrypt/credentials/credentials-18" --dns-duckdns-propagation-seconds 120
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Trying to detect encoding from a tiny portion of (2) byte(s).
Trying to detect encoding from a tiny portion of (2) byte(s).
The resolution lifetime expired after 5.402 seconds: Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.; Server <IP_ADDRESS> UDP port 53 answered The DNS operation timed out.
Ask for help or search for solutions at https://community.letsencrypt.org/. See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.
at ChildProcess.exithandler (node:child_process:397:12)
at ChildProcess.emit (node:events:390:28)
at maybeClose (node:internal/child_process:1064:16)
at Socket. (node:internal/child_process:450:11)
at Socket.emit (node:events:390:28)
at Pipe. (node:net:687:12)


Clean up npm scripts and start running tests

NPM script clean up
Since the repo started, we've had a single NPM script that ran on postinstall. All this did was run the VS Code install script and then launch tsc. Now, postinstall just runs the VS Code install script. The idea here is that install should really just lay down dependencies, not compile code. Compilation is split off into a separate script.
Here are the new npm scripts:

postinstall: As described above, this now just runs the VS Code install script after npm install.
compile: Runs the VS Code compile script to transpile TypeScript to JavaScript. Run this with npm run compile.
watch: Runs the VS Code compile script with the '-watch' flag to transpile TypeScript to JavaScript, and then watch for file changes and incrementally compile. Run this with npm run watch.
test: Runs the tests with Mocha. Note: This will only run tests that are already transpiled to JavaScript. Run with npm test.

Unit tests

Unit tests can be written in the 'test' folder. See 'test/sanity.tests.ts' for an example.
The launch.json has been updated to allow debugging of unit tests with the "Launch Tests" configuration.
The "test" task is now configured so that you can use the "Tasks: Run Test Task" command in VS Code.

Fixing some settings

Whitespace is a bit out of control. I've made an executable decision that the repo should have spaces with an indent size of 4. This is now added to the settings.json.
The 'out' folder is now excluded in settings.json so you won't see it show up in your directory tree.
The 'node_modules' folder is now excluded from search. This has been bothering me for awhile.

cc @gregg-miskelly, @chuckries
I'm not intending to merge this until after we ship 1.4, but wanted to get this out there to get your thoughts.

typings folder doesn't need to be in source control?

Whitespace is a bit out of control. I've made an executable decision that the repo should have spaces with an indent size of 4. This is now added to the settings.json.

I suggest adding an .editorconfig file too (info)

I also vote for chai.js as the assert library of choice (if a vote is possible 😄 ). It has a solid ecosystem around it  (helpers and libraries, etc) and enables to use both assert, should and expect type of syntax.

typings folder shouldn't be in source control - you can add typings install to the postinstall and include the typings.json?

I was following the model of VS Code itself, which includes the typings folder, and Go extension, which also includes the typings folder. At the very least, the typings folder is needed to provide links to VS Code's typings which are deeper within node_modules. Note that VS Code's extension scaffolding support also creates a typings folder: https://code.visualstudio.com/docs/extensions/example-hello-world.

I suggest adding an .editorconfig

Good idea -- will do!

I also vote for chai.js as the assert library of choice (if a vote is possible :smile: ). It has a solid ecosystem around it (helpers and libraries, etc) and enables to use both assert, should and expect type of syntax.

Yup, I was planning to use chai as well.

Is it possible to have tsc run automatically as part of the f5 scenario for the extension? I know the newly proposed npm run watch will handle this, but I have often forgotten to start tsc -w and have been bitten by stale code several times.

It's certainly possible. We just need a gulp task that does the compilation. I actually went down that path for awhile, but it requires further refactoring. The problem is that our gulpfile.js depends on compilation already having loaded because it expects coreclr-debug and omnisharp modules to already be present.

How are folks feeling about this? Shall I merge?

@DustinCampbell LGTM


Is there any plan to provide pretrained weights of Mip-NeRF 360 that can replicate the paper results?

Hi,
Seems like it need to take a lot of time to replicate the paper results if training from scratch.
It will be better if you can provide some pretrained weights.
Thanks.

Do you mean the optimized NeRF parameters for each individual scene? No, we have no plan to release those models.
Note that NeRF models do not have a traditional "training" step --- when NeRF is applied to a set of images, its weights are randomly initialized and then optimized with those images using gradient descent. There is no "pretraining".

Do you mean the optimized NeRF parameters for each individual scene? No, we have no plan to release those models.
Note that NeRF models do not have a traditional "training" step --- when NeRF is applied to a set of images, its weights are randomly initialized and then optimized with those images using gradient descent. There is no "pretraining".

OK, thanks for your reply.


Hyprcursor misalignment

Hyprland Version
 System/Version info
Hyprland, built from branch main at commit 30c5911718c02e0215bf0006faa6aa229558a501 dirty (renderer: minor fixups for misaligned surface rendering offsets).
Date: Sun Mar 17 21:08:59 2024
Tag: v0.37.1-9-g30c59117

flags: (if any)

System Information:
System name: Linux
Node name: arch-pc-nvme
Release: 6.8.1-zen1-1-zen
Version: #1 ZEN SMP PREEMPT_DYNAMIC Sat, 16 Mar 2024 17:15:23 +0000

GPU information:
08:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Cezanne [Radeon Vega Series / Radeon Vega Mobile Series] [1002:1638] (rev c9) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Bug or Regression?
Bug
Description
Using slightly modified default config.
When enable_hyprcursor = true:

cursor jumps a few pixels when moving cursor from and onto ags;
cursor jumps a few pixels when moving cursor from and onto url bar in Steam (from the top).

When enable_hyprcursor = false, then only Steam bug persists. I think Steam renders hyprcursor there regardless of set option.
How to reproduce
Move cursor slowly between elements that do and don't support hyprcursor.
Crash reports, logs, images, videos
https://github.com/hyprwm/Hyprland/assets/32937947/e55a0fb6-103a-4839-a635-cdac2fe468da

This is not really a bug with hyprcursor; it's most likely a slightly different hotspot between the hyprcursor theme and the xcursor theme.
Steam never renders a hyprcursor
ags is gtk which doesn't support server-side cursors and thus also never renders a hyprcursor.

ags is gtk which doesn't support server-side cursors

Yeah, I understand, I never claimed that it does.

Steam never renders a hyprcursor

If so, I'm really confused about Steam's behavior.
https://github.com/hyprwm/Hyprland/assets/32937947/2b29cb0c-d48f-4ce6-b28e-3cdd4c270d88

can't really explain that. My guess is the embedded CEF could use xcursor differently than the gtk client


Compilations pre-set options

Make the propositions for pre-set options here.

the ones we have are:
CONFIG_64BIT=y
CONFIG_DEBUG_INFO=n
CONFIG_GCOV_PROFILE_ALL=n
CONFIG_KASAN=n
CONFIG_UBSAN_SANITIZE_ALL=n
CONFIG_RELOCATABLE=n
CONFIG_XFS_DEBUG=n
CONFIG_AIC7XXX_BUILD_FIRMWARE=n
CONFIG_AIC79XX_BUILD_FIRMWARE=n
CONFIG_WANXL_BUILD_FIRMWARE=n

New list:
CONFIG_64BIT=y
CONFIG_DEBUG_INFO=n
CONFIG_DEBUG_INFO_SPLIT=n
CONFIG_UBSAN_SANITIZE_ALL=n
CONFIG_GCOV_PROFILE_ALL=n
CONFIG_DEBUG_INFO_REDUCED=n
CONFIG_RANDOMIZE_BASE=n
CONFIG_X86_NEED_RELOCS=n
CONFIG_KASAN_OUTLINE=n
CONFIG_UBSAN_ALIGNMENT=n
CONFIG_USB_SERIAL_OPTICON=n
CONFIG_KASAN=n
CONFIG_KCOV_INSTRUMENT_ALL=n
CONFIG_XFS_DEBUG=n
CONFIG_MAXSMP=n
CONFIG_FW_LOADER_USER_HELPER=n
CONFIG_STRICT_MODULE_RWX=n
CONFIG_AIC7XXX_BUILD_FIRMWARE=n
CONFIG_AIC79XX_BUILD_FIRMWARE=n
CONFIG_WANXL_BUILD_FIRMWARE=n
notes:

based on machine learning results (top 15)
I've reviewed all documentation about options, all make absolutely sense since they all have an influence on sizes (more to come)
there are more but it's already interesting to see the effect

Do i update the docker image and the IGRIDA image right now ?

Yes, please

Done!

On it

added

The story continues -- I've tried to include:
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_OPTIMIZE_INLINING=y
CONFIG_SLOB=y
these options are from tinyconfig but are not identified by the learning (for some reasons that are out of the scope of this issue).


Regular expression problem.

Jerryscript's regular expression not support positive/negative assert, em:

/(?<=\?)[^#]+/

JerryScript supports the positive and negative assertions in RegExp objects. Your testcase is not a valid assertion pattern.

JerryScript supports the positive and negative assertions in RegExp objects. Your testcase is not a valid assertion pattern.

My testcase is ok, i had test it in node.js env.
node.js em:

var url =  @'http://test.com?name=tom';
var quary = url.match(/(?<=\?)[^#]+/);
   @@@console.log(quary);

It can only write as below in jerry:

var url = 'http://test.com?name=tom';
var quary = url.match(/\?[^#]+/);
query = query ? query[0].splice(1) : null;
console.log(quary);

We have lookahead/lookbehind and positive/negative assertions in regexps. ES5 only supports lookahead and your pattern has lookbehind.

Thank you. I look forward to your realization of lookbehind model.

We have lookahead/lookbehind and positive/negative assertions in regexps. ES5 only supports lookahead and your pattern has lookbehind.

@zherczeg Does that mean that the script with this regex pattern should work if the engine is built with ES2015 profile? (<-- "We have ... lookbehind" + "ES5 only supports lookahead" + "your pattern has lookbehind")

Lookbehind is introduced in ES2018:
https://www.ecma-international.org/ecma-262/9.0/#prod-Assertion
Was not in ES2017:
https://www.ecma-international.org/ecma-262/8.0/#prod-Assertion
So only ES2018 compatible engines should support it.

I've edited the issue title to be more to the point. I'm also marking the issue as a feature request but closing it at the same time as ES8/9 is out of scope for the project for now. We should get full ES6 support landed first.


Slippage setting allows invalid numbers

Describe the bug
When filling the slippage field, it only accepts values between 0 and 100 (correctly). However, if the user sets a value outside of this range and then changes the "Infinite approval" toggle to the off position, the "Apply" button becomes available to click on and save changes.
To Reproduce
Steps to reproduce the behavior:

Go to https://amarok-testnet.coinhippo.io/
Click on Settings
Set slippage to a value higher than 100
Turn off infinite approval
See error

Expected behavior
The "Apply" button should never become available with an invalid slippage tolerance number.
Give an error message when the value is invalid.
Have warnings for too low/high slippage.
Screenshots
https://discord.com/channels/454734546869551114/1037575162637320222/1037581803747291137

fixed in new ui


Repository with main branch is not updated

My repository report is not refreshed correctly.
The branch is main.
Clicking on one of the files links present on the report I am redirected to Github, but Github says:

Indeed all the links to the files in the report use the master branch instead for main.

ˋmasterˋ branch repositories seem to be affected, too. Refresh fails. Sadly, goreportcard seems to degenerate...

@TheDiveO please try again, we just deployed a fix.

Yes, that fixed the refresh problem for my repository/ies. Thank you!

Seems to be still a problem for me?  https://goreportcard.com/report/github.com/synfinatic/aws-sso-cli

@synfinatic we're experimenting with using https://proxy.golang.org for downloading modules. The latest version we get from there is v1.2.3:
https://proxy.golang.org/github.com/synfinatic/aws-sso-cli/@latest
We still need to do some UI work to display what version of the module we checked.

Ah, that would explain it!  And yes, indicating what version you're analyzing would be helpful.  I was expecting you would be pulling HEAD from main/default branch.

@synfinatic module version is displayed on the page now 👍  https://goreportcard.com/report/github.com/synfinatic/aws-sso-cli

@alimoli the GitHub links now point to the latest module version. For example https://github.com/limoli/kid/blob/v1.0.0/common.go#L1.


🚧 Dev ➾ Determine why yargs is not returning what's expected

🔗 Epic|Feature Link
No response
🚥 Definition of Done

[ ] 🎯 Planning and Design
[ ] 🏎 Dev Implementation Complete
[ ] ♾ PR Merged
[ ] 🏆 Product Acceptance

🧰 Work Description
In the CLI, we parse arguments from the CLI twice.

In our first run, we configure a yargs instance that is aware of all global options and tasks. We then parse against this yargs configuration to determine whether a global task was involved. If so, we execute that task and end the process.
In our second run, we have determined that a global task isn't to be executed. The ephemeral state is loaded so that we can configure a new yargs instance that is aware of all plugin provided tasks. We then parse against this yargs configuration to determine whether a plugin-provided task was requested.

However, there was a problem found during the internal-tasks-refactor work (#1613 ) in the second run of parsing.
Yargs is used to parse CLI arguments into commands, positional arguments, and option flags.
After yargs parses the CLI arguments, an object representing all options is returned. The command (or in Taqueria terminology, the "task") being invoked is stored in the '_' property. If you were to execute the 'generate types' task, then ')' would be set to ["generate", "types"].
In the first pass of parsing arguments, the '' property is set to as what we would expect: ["generate", "types"]
In the second pass of parsing, the '' property is truncated for some reason: ["generate"]
Note, this is also present in main, and seems to have existed for a while, but only manifested in the internal-tasks-refactor work. The reason being is that the logic of the tasks refactor branch utilizes the '_' property to determine what task is being invoked. In main, we utilize yargs command handlers, which fork execution outside of the main execution pipeline.
To get around this at the moment, we just copy the '_' property from the initial pass of parsing arguments to the object resulting from the second pass of parsing. See here: https://github.com/ecadlabs/taqueria/blob/refactor-internal-tasks/cli.ts#L1125
✅ To Do

[ ] Determine why the second call to parseArgs returns an object with the '_' array truncated
[ ] Apply a better solution

⚖ Acceptance Criteria
We should know why parsing using yargs behaves this way, and remove any hacks that force things to work.
🔭 Scope
Forking yargs.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

What is the status of this?

This is an exisiting issue, but its mitigated by the hack implemented above. For that reason, I'll consider this low priority.


Add the action 'Refresh' for Disks node

Storage Explorer Version: 1.10.0
Platform/OS: Windows 10
Architecture: x64
Commit: f06deb7a6
Regression From: Not a regression
Steps to reproduce:

Select 'Disks' -> Check its context menu.

Expect Experience:
The action 'Refresh' displays well.
Actual Experience:
No 'Refresh' action displays.

Fix merged into master


[1.20.1] Going from Spectator to Creative makes you unable to fly.

Title ^
Tested with just MC 1.20.1, Forge 47.1.3 & Apothic Attributes (v1.1.3) + Placebo (v8.3.7).
- Gbergz

This is currently being discussed at https://github.com/Shadows-of-Fire/Apotheosis/issues/995


Create Clear Title

Please create a clear title in an h1 tag to improve understanding, such as: 'Navigate to the Project Directory, Contact Information, and License Details.

Please create a clear title in an h1 tag to improve understanding, such as: 'Navigate to the Project Directory, Contact Information, and License Details.

can you please specify so we can proceed!

create Navigate to the Project Directory, Contact Information, and License Details these title in h1 tag

I wolud like to solve this issue

@Ankitaghavate  I would like solve this issue

I want to work on this issue

please assign it to me

I want to work on this issue can you assign me


Date Picker - selectorIcon Prop not displaying Icon

NextUI Version
<EMAIL_ADDRESS>Describe the bug
I've designated Heroicons' Calendar Days icon as my Date Picker Selector Icon, but when loading the component, no icon appears. See code below.
<DatePicker               className="text-orange-500 font-light text-sm "               label=""               defaultValue={now(getLocalTimeZone())}               granularity="day"               isRequired               hideTimeZone               selectorIcon={<CalendarDaysIcon />}               popoverProps={{                 placement: "bottom",                 shouldFlip: false,                 backdrop: "opaque",               }}             />
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Implement  component with custom selectorIcon prop.
Expected behavior
Expected to see Heroicons CalendarDays icon as my custom selectorIcon. Instead, saw no icon at all.
Screenshots or Videos

Operating System Version
macOS
Browser
Chrome

can you share your CalendarDaysIcon as well

@hectarescraps  on the  heroicons website copying jsx or svg both copies svg code (I don't know if it is a bug on their part)
I used this code and it works completely fine
  <DatePicker  selectorIcon={<Image src="/calendar.svg" alt="calendar" width={20} height={20} />}  />

Thank you so much @abhinandan-verma - got it working on my end as well now. Closing.


first cut of upgrade-csi-client.md

Codecov Report
Base: 46.69% // Head: 46.44% // Decreases project coverage by -0.24% :warning:

Coverage data is based on head (fb1f93a) compared to base (b80e312).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   46.69%   46.44%   -0.25%
==========================================
  Files          27       27
  Lines        2844     2857      +13
==========================================
- Hits         1328     1327       -1
- Misses       1417     1431      +14
  Partials       99       99

Impacted Files
Coverage Δ

pkg/controller/pod_driver.go
45.51% <0.00%> (-0.69%)
:arrow_down:

pkg/controller/reconciler.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

translation complete, RFC @xiaogaozi


vapi_runtime>=2.5.0 error

I cloned this repo as mentioned in the Readme.md

sdk package version:
pip3 list | grep v
ubuntu-drivers-common (0.0.0)
unity-scope-colourlovers (0.1)
unity-scope-devhelp (0.1)
unity-scope-gdrive (0.7)
unity-scope-virtualbox (0.1)

python version:
python --version
Python 3.4.3

Steps or code snippet to reproduce
sudo pip3 install --upgrade --force-reinstall -r requirements.txt --extra-index-url file://pwd/lib
When I ran the above command with the original requirements.txt file, it stopped at vapi-client-bindings, saying that no distributions at all found.
So in the requirements.txt file, I removed all the version constraints. Now it installs its 2.5.0 version, but gives the same error for vapi-runtime.
Actual behavior
Downloading/unpacking pyVmomi>=6.7 (from -r requirements.txt (line 1))
  Downloading pyvmomi-6.7.0-py2.py3-none-any.whl (249kB): 249kB downloaded
Downloading/unpacking suds-jurko (from -r requirements.txt (line 2))
  Downloading suds-jurko-0.6.tar.bz2 (143kB): 143kB downloaded
  Running setup.py (path:/tmp/pip_build_root/suds-jurko/setup.py) egg_info for package suds-jurko
Downloading/unpacking tabulate (from -r requirements.txt (line 3))
  Downloading tabulate-0.8.2.tar.gz (45kB): 45kB downloaded
  Running setup.py (path:/tmp/pip_build_root/tabulate/setup.py) egg_info for package tabulate
Downloading/unpacking vapi-client-bindings (from -r requirements.txt (line 4))
  Downloading vapi_client_bindings-2.5.0.tar.gz (159kB): 159kB downloaded
  Running setup.py (path:/tmp/pip_build_root/vapi-client-bindings/setup.py) egg_info for package vapi-client-bindings
Downloading/unpacking vmc-client-bindings (from -r requirements.txt (line 5))
Downloading/unpacking vapi-vmc-client (from -r requirements.txt (line 6))
Downloading/unpacking nsx-policy-python-sdk (from -r requirements.txt (line 7))
Downloading/unpacking vmc-app-python-sdk (from -r requirements.txt (line 8))
Downloading/unpacking six>=1.7.3 (from pyVmomi>=6.7->-r requirements.txt (line 1))
  Downloading six-1.11.0-py2.py3-none-any.whl
Downloading/unpacking requests>=2.3.0 (from pyVmomi>=6.7->-r requirements.txt (line 1))
  Downloading requests-2.18.4-py2.py3-none-any.whl (88kB): 88kB downloaded
Downloading/unpacking setuptools (from vapi-client-bindings->-r requirements.txt (line 4))
  Downloading setuptools-39.2.0-py2.py3-none-any.whl (567kB): 567kB downloaded
Downloading/unpacking vapi_runtime>=2.5.0 (from vapi-client-bindings->-r requirements.txt (line 4))
  Could not find any downloads that satisfy the requirement vapi_runtime>=2.5.0 (from vapi-client-bindings->-r requirements.txt (line 4))
Cleaning up...
No distributions at all found for vapi_runtime>=2.5.0 (from vapi-client-bindings->-r requirements.txt (line 4))
Storing debug log for failure in /home/policybat/.pip/pip.log

@meetdash Windows file path is different from linux/mac. Can you try:
pip install --upgrade --force-reinstall -r requirements.txt --extra-index-url file:%CD%\lib

this I tried on Ubuntu 14.04

@meetdash Is it working for you now? Can we close this issue?

Yes


Add an actionButton property to the SourceControl api

Refs: #110882
This proposal adds a new actionButton property to the SourceControl object, to allow SCM extensions to contribute a large "cta" style button to a repository.
Here is the proposed api addition:
export interface SourceControl {
	actionButton?: Command;
}

This is currenty being used by the built-in Git extension to provide the "Publish Changes" or "Sync Changes" button when there are unpublished or unpushed commits.

@lszomoru is there any plan for this to become available in the stable API?
I'd like to use it in the DVC Extension for VS Code. Some high level details about the extension can be found at https://github.com/microsoft/vscode-discussions/discussions/54.

@mattseddon, thanks for the interest in the Action Button. The last two milestones we evolved the shape of the property in order to accommodate the "Commit" action button. I think that soon we will reach a phase where we can look at finalising the API.

Any update on this becoming stable?

+1 to get this API

@lszomoru  if I'd like to go the hard way (e.g. copy/pasting some code from the git, git-base extensions) would it be possible to add that button? Or, implementing a custom "Sidebar" is the only way?

@vasilev-alex, I do not believe that taking code from the git or git-base extension will get you there. In case your extension is using a Webview, you could use the Webview UI Toolkit.

@vasilev-alex if you are prepared to tolerate the constraints imposed on extensions that used proposed API (i.e. can't publish on Marketplace, and even after install from VSIX require a command-line argument to be specified each time or alternatively added to argv.json) then I recommend this route.
@lszomoru I sincerely hope this proposed API isn't going to follow the example of several others which have languished in proposed state for many years, often with no refinement occurring during that time, and giving IMO an unfair advantage to certain "blessed" extensions that are permitted to use them without having to overcome the constraints mentioned above.
Are there specific reasons for not finalizing this one?

Thinking out loud here, I wonder what the answer would be if someone with a subscription asked GitHub Copilot what it'll take to get a proposed API finalized.

@gjsjohnmurray, thanks for the continued feedback. The proposal for the action button has evolved since its inception (ex: added description, and secondary actions). One aspect that we still have to decide on before finalization is what's the best approach for defining secondary action (ex: code vs. menu with static contributions).

I would prefer secondary actions to be contributed by code. Having to predefine options in settings.json is a significant restriction the UX our Deltanji SCM extension can provide. Deltanji provides highly configurable workflow, so when we build our extension we cannot know which transfer routes a Deltanji site will want to offer to its devs.
Of course, if our longstanding wish for dynamic (sub)menu support were granted then it would probably be fine for secondary actions to be implemented as a menu.


Does your implementation require activation in the final layers?

does it work with logits or no?

Hi sarmientoj24,
Yes, the way the loss functions are written assume the model has a softmax activation as its final layer.
Best,
Michael


Limit to 2 decimals for wallet balance in wallet lists

Suggestion to improve balance readability in wallet lists.
Added a parameter in readableCrypto function so that we can control the decimals we want.

We have it set to 8 on purpose for crypto currencies. Fiat currencies will be displayed with 2 decimals.

I understand that crypto needs more decimals @faustbrian but my goal here was to round the balance amount to less decimals to improve readability.
It's just for the balance lists and not for transaction details : for example when I see the top wallets list here

Do I need to know that Bittrex has 10 960 108,33652244 ?
Or could it just be 10 960 108,33 ?
Got no problem if this is not accepted, just explaining my point here 😅


Cache node_modules on appveyor and disable npm progress bar

Since @fscherwi beat me to Travis, this just caches node_modules on AppVeyor. It should speed up the build quite a bit.

I also disabled the spinner and progress bar on npm to make the output look a lot nicer. I can enable the http logging so you can still see what's going on, if you like.

Same as my comment in #361, I think caching node_modules is a bad idea. It is a lot more tempting for AppVeyor since it is so slow, but probably still not worth the risks.
I'm confused by the second commit. If I review the AppVeyor output from your PR, and others like it, they seem identical. What am I missing?

@jamestalmage: Huh, AppVeyor must have changed it. Never mind.
Although, I think we should cache node_modules on AppVeyor, because npm on AV is a lot slower, and any dependency mess ups will be caught by travis.

I think we should cache node_modules on AppVeyor, because npm on AV is a lot slower, and any dependency mess ups will be caught by travis.

That is a tempting thought. However, it doesn't seem the build is actually any faster between your first and second commit, should it be?

@jamestalmage: No. It should be faster between this branch and master.

For your first commit there wouldn't have been a cache yet, so it should have been slow. Check the build history, discounting hung builds - this PR takes about the same amount of time to build.

Hmm... I guess never mind then. (Although that's awful strange).

Although that's awful strange

I don't know. If I had to guess, I would bet AppVeyor proxies the npm repository, so installs happen very fast.

Yeah, Probably.

The slowest part about AppVeyor is that your builds are always queued for a long time before starting. AppVeyor probably deprioritize free plans.


Add poddisruptionbudget to kubectl delete command

Fixes #946

This change is

@a-robinson, do we need to explain this particular resource in any way, or is adding it to the delete command enough?

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9134f26c7f0ef6dfc51078ce6b1ce943a6617203/


Google login

Add passport for Google login

possible as a future development, but not for our final project


Refactor storage of blobs into more manageable chunks

Test artifacts are stored on the frontend in a single table with each artifact a single row. This has worked fine for small tests, but this will hemorrhage with larger data sets as it's being stored in a single blob.
Current schema:
CREATE TABLE test_artifacts (test_id timeuuid, artifact_type text, description text, artifact blob, PRIMARY KEY (test_id, artifact_type));

Current update path:
UPDATE test_artifacts SET description = ?, artifact = ? WHERE test_id = ? AND artifact_type = ?;

I propose that we chunk out the blobs into 10MB (configurable?) chunks. This will fix two foreseeable issues:

Cassandra timeouts and commit log segment size issues.
Timeouts in the websocket code where it's waiting for Cassandra.

Necessary changes:

model.py:update_test_artifact - should be made to accept a portion of the file and a segment number. The DB table should have some metadata that records the current accumulated SHA of the data so that we can verify the chunks. As new data is stored, this SHA accumulator should be updated. There should be an additional field that indicates the the file is completely stored in the DB. This field should be referenced each time we display the file in the frontend (the file should never appear if it is not 100% complete.)

client code - the client currently sends the entire test artifact in one session. If it fails to upload entirely, the next time it reconnects it will try again from the beginning. This should be made so that it sends it in chunks (same chunk size as DB.) If the upload is aborted, the upload should resume after the last successful chunk. The client should calculate the SHA of the data up to that chunk and send it to the server so that it can validate it is in sync before resuming.

Some stats as of today:

6885 blobs
Average size: 3.8MB
Biggest size: 208MB (not including ones that failed to upload due to size)


Feature request: Call an external program whenever a node is connecting or leaving

Why
MagicDNS is not exactly doing what I really need without a lot of hacks on my DNS servers. In a number of cases it would be easier to just update a "real" name server or use a completely different mechanism.
Information could be scraped from logs but that's inefficient. A special peer could be crafted to serve as bridge to external tools but that seems to be the completely wrong direction.
Description
Please add a simple mechanism that will call an external tool
The path to the tool should be configurable (and calls should only be made if it has been configured) and should send "event" (e. g. "client is ready"/"client has closed the connection"), account, client name and IP address(es). The exit code of the subprocess can be safely ignored. It's not your problem.

Ideally this would also support url to be able to call a webhook and not run a program (kind of like the webhooks on tailscale.com)

I think that webhooks would be a neat feature, I do not think we want to open the can of worms that is executing things outside of the go binary.
We dont really have this on our roadmap, but if someone wants to write up a design suggestion, we would be more than happy to help review and come with feedback.

We dont really have this on our roadmap, but if someone wants to write up a design suggestion, we would be more than happy to help review and come with feedback.

I believe I put my immediate need in my original request: I need to remotely update a DNS server because MagicDNS is breaking things on my end. That's why I am interested in the events "link up" and "link down" (assuming that you will never reassign IP addresses on the fly while connections are active.
I can certainly see other useful events (e. g. "account added", "node added", or "deleted").
Personally I would leave parsing the stuff to the consumer and keep the configuration part on your side as simple as possible. One hook per consumer and you either provide whatever you want as  JSON and drop it off in front of the feet of the consumer(s) or you put all data into the URI itself and the consumer has to take that apart.
The only one who is able to judge which is easiest to implement is you. If you need to know which events the users would like to see it might be best to enable discussions and put it there.

This is a feature of Tailscale and seems to be very useful. I too have problems with MagicDNS and the concept of hooks on specific actions would be extremely beneficial.
Tailscale implementation: https://tailscale.com/blog/webhooks/

+1

In theory this could already be done by following the headscale log. It would be if headscale supported emitting events to something like NATS

Would also like to have events emitted, whether as webhooks or as another mechanism doesn't really matter to me.
In the meantime, a hacky solution might be to use something like headscale nodes list -o json on a timer to dump status information in a machine-readable state.


Container does not have the cap_net_raw+p capability or setuid? capabilities.

I have deployed the container on to GKE cluster as a sidecar, here is the yaml file.
apiVersion: apps/v1
kind: Deployment
metadata:
    name: nginx-netshoot
    labels:
        app: nginx-netshoot
spec:
  replicas: 1
  selector:
    matchLabels:
        app: nginx-netshoot
  template:
      metadata:
       labels:
          app: nginx-netshoot
      spec:
            containers:
            - name: nginx
              image: nginxinc/nginx-unprivileged
              ports:
                  - containerPort: 80
              securityContext:
                runAsNonRoot: true
                runAsUser: 100
                seccompProfile:
                  type: RuntimeDefault
                allowPrivilegeEscalation: false
                capabilities:
                  drop:
                  - NET_RAW
            - name: netshoot
              image: nicolaka/netshoot
              command: ["/bin/bash"]
              args: ["-c", "while true; do ping localhost; sleep 60;done"]
              securityContext:
                runAsNonRoot: true
                runAsUser: 100
                seccompProfile:
                  type: RuntimeDefault
                allowPrivilegeEscalation: false
                capabilities:
                  drop:
                  - NET_RAW
                  - NET_ADMIN

when I check the logs of the container,
I get the following,
ping: socktype: SOCK_RAW
ping: socket: Operation not permitted
ping: => missing cap_net_raw+p capability or setuid?
ping: socktype: SOCK_RAW
ping: socket: Operation not permitted
ping: => missing cap_net_raw+p capability or setuid?

Any ideas on how to overcome this, it looks like it needs packages of libcap/libcap_dev and also tcpdump command gives operation not permitted exception.

Looks like the YAML you posted above drops those capabilities?
capabilities:
  drop:
  - NET_RAW
  - NET_ADMIN

@thaJeztah I have the cis security policies enforced on the cluster is there a workaround to not remove the capabilities and have the tcpdump or ping work?

It may depend on the runtime you're using. Docker 20.10 changed the net.ipv4.ping_group_range sysctl to allow using ping without CAP_NET_RAW (see https://github.com/moby/moby/pull/41030).
I think containerd 1.6 also uses that now (see https://github.com/containerd/containerd/pull/6170), and there's a related discussion in k8s; https://github.com/kubernetes/kubernetes/issues/102612
On a version without that patch (or a runtime that doesn't set this), it will fail with the error you're seeing;
docker run -it --rm --cap-drop CAP_NET_ADMIN --cap-drop CAP_NET_RAW --user=100 --sysctl net.ipv4.ping_group_range="0<PHONE_NUMBER>" nicolaka/netshoot sh -c 'while true; do ping localhost; sleep 60; done'
ping: socktype: SOCK_RAW
ping: socket: Operation not permitted
ping: => missing cap_net_raw+p capability or setuid?

If you change the option (--sysctl net.ipv4.ping_group_range="0<PHONE_NUMBER>" on docker run), it works:
docker run -it --rm --cap-drop CAP_NET_ADMIN --cap-drop CAP_NET_RAW --user=100 --sysctl net.ipv4.ping_group_range="0<PHONE_NUMBER>" nicolaka/netshoot sh -c 'while true; do ping localhost; sleep 60; done'
PING localhost (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.022 ms
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=2 ttl=64 time=0.076 ms
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=3 ttl=64 time=0.109 ms
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=4 ttl=64 time=0.178 ms

(Not exactly sure what the corresponding options are in kubernetes yaml)

@thaJeztah okay, thank you! I will close this issue now


Deployment creation failure

Readiness Checklist

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed
[x] I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

Current Behavior

When trying to create ES and observability clusters using the elastic ec TF provider in ES Cloud SaaS, I am getting following error:
Error: failed creating deployment: 2 errors occurred: * api error: deployment_alias.alias_unavailable: This alias is not available. * set "request_id" to "<64 symbol hash string>" to recreate the deployment resources
## Terraform definition

Steps to Reproduce

Context

I am trying to create a new ES cluster using existing configuration from already created deployments.
Possible Solution

I guess issue is related to those code blocks:
https://github.com/elastic/terraform-provider-ec/blob/2ee0f61c5d63fdb63a7185f39a6434f531a50735/ec/ecresource/deploymentresource/schema.go
https://github.com/elastic/terraform-provider-ec/blob/9438c65eda962409493de4ae55be6953bdebd952/ec/ecresource/deploymentresource/create.go
Your Environment

Version used: TF 1.3.0; ES 8.6.2
Running against Elastic Cloud SaaS or Elastic Cloud Enterprise and version:Elastic Cloud SaaS
Environment name and version (e.g. Go 1.9):
Server type and version:AWS based EC2
Operating System and version:
Link to your project:

@Lagoran This error indicates that the generated alias for this deployment has already been taken. Try either re-naming your deployment or setting the alias to something unique.
For example, the Configuring an SSO provider guide appends a 6 character random string to the deployment alias.


Uploading a new image for a team member triggers an "email already in use" error

Issue Summary
See title
Steps to Reproduce

Install Ghost from the ground up (so no upgrades, no reinstall, no existing data)
Use an email address that has no gravatar attached to it to sign up
Once you're in admin, go to Team members and click into your account
Click on the "edit picture" placeholder
upload an image and click "save" in the modal
observe the red bar about email on top
try to click "save" in top right corner
observe the second red bar about email on top
be sad because your changes weren't saved

I don't expect an unchanged email to trigger the error.
I would love to try to reproduce these steps on master, but I can't get Ghost started. Any help would be appreciated about that...
Technical details:

Ghost lts branch (last commit at the moment: https://github.com/TryGhost/Ghost/commit/e11feea1be47a586830dd99bf585f914ab508573)
node 6.9.2
npm 3.10.9
yarn 0.19.1
macOS 10.12.3
Chrome Version 56.0.2924.87 (64-bit)
sqlite (whatever comes out of the box with this version)

Potentially related: https://github.com/TryGhost/Ghost/issues/6491

@javorszky Thanks for your report.
I will push a fix tomorrow 👍

Fixed in #7987 and #7986(lts)


Primary key field in Swagger for v2 REST GET operations does not appear

When using the Swagger API to test a v2 REST GET. query, the required primary key field does not appear and therefore I cannot test the API through swagger.

EDIT - Ignore this. The field shows up when you press the "Try It Out" button. The UI still seems misleading though. he other fields are not editable before you press the Try It Out button, but they are still visible. I suggest that the primary key fields also be visible, but disabled.

This is an artifact of how swagger renders its UI and not something we have control over.


Server Start Arguments from Server Template not used in Dynamic Server instance.

Dears,
We noticed the following issue on our environment, which we were able to reproduce :
We have a wdt model describing a server template including Start Arguments as such :
topology:   ServerTemplate:     cluster-template:       SingleSignOnServices:         [...]       ServerStart:         Arguments: "-Xmx2048m"
When we spin up the cluster based on the model, the server start arguments seems to be present in the server start arguments of the cluster. We can see it in the WebLogic Admin Console (Home > Summary of Server Templates > cluster-template > Configuration > Server Start) and in the config.xml of our domain :
<?xml version='1.0' encoding='UTF-8'?> <domain [...]>   <name>test-env01</name>   <domain-version><IP_ADDRESS>.0</domain-version>   <security-configuration>     <name>test-env01</name>     [...]   </security-configuration>   <server>     <name>admin-server</name>     <listen-port>8001</listen-port>     <listen-address>test-env01-admin-server</listen-address>     <network-access-point>       <name>internal-t3</name>       <listen-address>localhost</listen-address>       <listen-port>8001</listen-port>     </network-access-point>     <server-life-cycle-timeout-val>30</server-life-cycle-timeout-val>     <startup-timeout>0</startup-timeout>   </server>   <server-template>     <name>cluster-template</name>     <ssl>       <name>cluster-template</name>       <enabled>false</enabled>       <listen-port>8100</listen-port>     </ssl>     <cluster>test-env01-cluster</cluster>     <server-start>       <name>NO_NAME_0</name>       <arguments>-Xmx2048m</arguments>     </server-start> [...]
However, the properties is not available in the managed server issued from the template. It is defined in the config.xml as follow :
  <cluster>     <name>test-env01-cluster</name>     <cluster-address>test-env01-cluster-test-env01-cluster</cluster-address>     <cluster-messaging-mode>unicast</cluster-messaging-mode>     <frontend-host>cluster.test-env01.ui.k8s.local.com</frontend-host>     <frontend-http-port>80</frontend-http-port>     <jta-cluster>       <timeout-seconds>66</timeout-seconds>     </jta-cluster>     <dynamic-servers>       <name>NO_NAME_0</name>       <server-template>cluster-template</server-template>       <maximum-dynamic-server-count>1</maximum-dynamic-server-count>       <calculated-listen-ports>false</calculated-listen-ports>       <server-name-prefix>managed-server-</server-name-prefix>       <dynamic-cluster-size>1</dynamic-cluster-size>       <max-dynamic-cluster-size>1</max-dynamic-cluster-size>     </dynamic-servers>   </cluster>
The .out and .log files does not display the start Arguments at the startup and the properties (we have others than the Xmx) are not available from our app deployed on the managed server.
In the admin console, there is no tab for the server start arguments.
Could you please advise on this issue?
Regards.

In WKO environment, since the managed server is not started by the admin server via the nodemanager,  the server-start arguments are ignored.
However, you can control it in the domain resource YAML using environment variable in the server pod.
https://oracle.github.io/weblogic-kubernetes-operator/managing-domains/domain-resource/#jvm-memory-and-java-option-environment-variables
kubectl explain domain.spec.serverPod.env   or kubectl explain domain.spec.adminServer.serverPod.env

Closing issue as Works As Designed


:sparkles: check variants data before update

Description

illumina_top allele is now tracked at variant level, so a location could be checked against it before updating locations.
Related Issue

closes #56
Motivation and Context

This PR enforce the same illumina_top allele while adding a new location. Location is then updated if newer that the value actually present in the database
How Has This Been Tested?

changes were tested by CI and by loading variants into database
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change which improve code itself)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Coverage increased (+0.04%) to 91.933% when pulling 0b8c91bb6b72c3be7079d539e930c3c01fb76ee5 on issue-56 into 2f58e6f61a95ff491bbd2115e2a08edca9e1ab0e on devel.


[ios11] Pages without ion-header

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[X ] 3.x
[ X] 4.x
I'm submitting a ...  (check one with "x")
[ X] feature request
Current behavior:
In pages where I don't want to use display ion-header I just used to not add the element in the html pages. With ionic-angular 3.7.1 it turns out that if I don't specify this element, some pixels (20px I guess) will be added in any case, like if a missing status bar/navbar had to be displayed.
Expected behavior:
If ion-header is not specified in the html pages, then no spaces should be added respectively no status/navbar should be displayed.
Steps to reproduce:
In an html pages, don't specify ion-header
Related code:
<!--ion-header>No header </ion-header-->
<ion-content fullscreen="true" no-bounce>
   Super
</ion-content>

Workaround
As temporary workaround I did the following:
1-Add an empty ion-header
<ion-header></ion-header>
<ion-content fullscreen="true" no-bounce>
   Super
</ion-content>

2-Set the header as not displayed in css
my-component {
    ion-header {
       display: none;
    }
}

Other information:
cli packages:
@ionic/cli-utils  : 1.12.0
ionic (Ionic CLI) : 3.12.0

global packages:
cordova (Cordova CLI) : 7.0.1
Gulp CLI              : CLI version 3.9.1 Local version 3.9.1

local packages:
@ionic/app-scripts : 3.0.0
Cordova Platforms  : android 6.3.0 ios 4.5.1
Ionic Framework    : ionic-angular 3.7.1

System:
Android SDK Tools : 26.1.1
ios-deploy        : 1.9.2
ios-sim           : 5.0.13
Node              : v8.5.0
npm               : 5.3.0
OS                : macOS Sierra
Xcode             : Xcode 9.0 Build version 9A235

Misc:
backend : legacy

Screenshot
You could find a screenshot of the problem in the forum: https://forum.ionicframework.com/t/white-space-between-header-and-content/106733/11

This should be fixed in the latest nighlty
Mid scroll here:

npm i<EMAIL_ADDRESS>

@mhartington could confirm, looks good! thx


how to fix bootstrap responsive mobile menu open delay?

At the first time the bootstrap responsive mobile menu open has a stuck in the middle of the page for a while then dropping down. And also rest of the time has a delay when menu dropping down, at the same time menu close works well without any delay.
I have tried with
.collapsing{
  height: 0 !important;
  opacity: 0;
}

but still open take delay when compare with closing
DEMO: http://codepen.io/anon/pen/MwMvmv

Question update
In the normal stage menu element seems like this

It toggle class collapse to collapsing and also calculate menu height  add that height in to inline css style="height:250px;"

after collapse completed inline css backed and class switch to collapse in"

Actually I just need to bypass the collapsing and inline css of menu height

As this is not an issue with Bootstrap itself, but with the specific additional implementation you've got running on top of it, we recommend asking on StackOverflow - see https://github.com/twbs/bootstrap/blob/master/CONTRIBUTING.md#using-the-issue-tracker

This is a legit issue with bootstrap and not with a specific implementation.

.collapsing {
-webkit-transition: height .5s ease;
-o-transition: height .5s ease;
transition: height .5s ease;
}


Files crashes when attempting to access unmounted ISO

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Ensure that there is ISO mounted via Windows Explorer.
"Eject" said ISO from Windows Explorer
Attempt to view file contents from ISO mount path in Files under Drives

Expected behavior
ISO should be removed dynamically when Ejected from Windows E
debug.txt
xplorer or options to 'Eject' media via Drives in Files.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS Version: [e.g. Windows 10 1903 18362.175]
App version: [v0.11.0]

Additional context
Add any other context about the problem here. Does this problem occur again after restarting the app?
Log file
Please post the log file here so that we can understand your problem better. You can access it from Settings->About->Open log location.

This is basically the sames issue as #2190
@yaichenbaum Could you assign me please, I can modify my initial solution for the #2190 to handle a wider range of exceptions.


Update create-index-transact-sql.md

@sarafpradeep : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.


Added MacBook Pro device

Hey there,
you created an awesome collection of beautiful device. Well done. I had a need for exactly what you created and a little more. In addition to the mobile devices I needed a representation of a desktop device, therefore I created a MacBook Pro (ish) style in the sense of this library.
In contrast to the existing devices the MacBook doesn't respect the screen dimensions of the original, for an obvious reason: you cannot display a pixel-perfect MacBook on a MacBook. Nonetheless, it may be of use for someone out there.
Cheers
Klaus

@ping @ping @ping @ping @ping @ping @ping

Hey guys, we'll get this sorted over the weekend. Very useful frame

@marcj + @iKlaus apologies for the delay, we'll get this sorted asap, thank you so much for contributing

can this be merged? Is there somewhere that has the html for this? Thanks!

@timmyg commented on Aug 25, 2015, 5:51 PM EDT:

can this be merged? Is there somewhere that has the html for this? Thanks!

The HTML for this is in the diff.

@iKlaus Could you rebase with less of the white space changes you've made? Using git commit --interactive can help.  Thanks for doing that!

Thanks @iKlaus! I merged this in along with a few tweaks to make it look a bit more like the new Retina Macbook Pro

You are welcome. Glad you like it and finally merged it :) Thanks for your tweaks. Looks really neat :+1:


Line doesnt move properly upon scroll

Hey man, great library here!
Was wondering if there was a way to make it such that, when someone vertically scrolls the page, the line moves properly and doesnt stay fixed on the page?
Would be very helpful! Let me know if you need more info

Also not an issue, but how do I replicate the basic animation I had with LeaderLine? I see you changed some field names, but passing animation: true no longer works. I assume its still enabled, could you let me know what to pass?

hello @yhbk12,
Thanks for reporting that, because it's indeed an implementation bug from my part, but I'm glad you found a workaround.
It will be fixed in a next version.
But just to mention, you only need the code to be just like:
dash:{
    length:10,
    gap:3,
    animation:{duration:500},
},

other fields are not required, easing should be in the animation object.
I'm happy to here that you liked this project, hope there are not other bugs.
Have a nice day.

@AhmedAyachi here's a video showing what I mean. Basically if the page vertically scrolls, the lines are fixed on the screen, they're not dynamic enough to move as the page moves.
Is there any way to make the lines dynamically move when the page moves?
https://share.vidyard.com/watch/UKApB5nSZpN3oBxCGcKrbJ?

@AhmedAyachi any updates here? Thank you

@yhbk12, couple questions,
is the zoom what causing the lines to become improperly positioned ?
where are you inserting the lines, body or custom parent ?

@AhmedAyachi do you wanna do a quick video call and I can show you?

Will be much quicker, if youre free that'd be great!
https://meet.google.com/jqq-wxam-ezw

not right now unfortunately, but I can meet you tomorrow if you're free

Yes lets do that. What time works best?

Fyi this is similar to the issue I have -- https://github.com/anseki/leader-line/issues/13#issue-329405560

did you check the parent prop ?

That fixed it!! Thanks man you're a legend 🙏

@yhbk12 , That's the whole point of this repo hhhh,
I'm happy I fixed your problem, happy coding

Great, sounds good. Thank you for the excellent package 🔥


[incubator/druid] placing proto descriptor

I am trying to use druid-protobuf-extensions with reading the instruction here. To use the proto extension, we need to place a proto descriptor file somewhere that is accessible from the Overlord (or Coordinator?). Is there a good way to do this with the helm chart? Or do we need to enable overlord to mount configmap to read the descriptor file?

Maybe it is necessary to support a generic way to mount customer files into containers.
Now you can build a new image with office druid base image and your descriptor file.😰

Now you can build a new image with office druid base image and your descriptor file.

Thanks! I was searching for an easy and dynamic way to add/change descriptors but it seems this is the only option I should do :(


iced_wgpu: don't query Wayland on macos

After https://github.com/pop-os/iced/pull/138 was merged, iced with the feature wgpu set, no longer compiles on macos.
After some digging it turns out this was due to some wayland dependencies brought in by that PR.
This is a suggested fix to that problem, by changing the conditional compilation attributes added to exclude macos.

I only did a very basic test. It started with me noticing that cosmic-term failed to build. Then I tracked it down to a dependency added here. I boiled it down # to a failure when running cargo build --features wgpu in the root. Then I figured out the commit, and replaced the cfg checks added there. Finally I ran cargo build --features wgpu again, and this time it worked.


Make transaction() take an immutable &Connection

Previously we were requiring the caller to pass in a &mut Connection
even though in the Transaction structure we were storing the
Connection as an immutable reference.  Since we're not mutating the
Connection, requiring this mutable reference only creates problems
for callers.

See #285

Hi @gwenn; thanks for the pointer to the earlier ticket.  To summarize, by marking the Connection taken by the Transaction constructor as mutable, we prevent at compile time any attempt to open nested or concurrent transactions on the same connection.  SQLite does not support nested transactions, so attempting to do this would be an error at runtime.
  Unfortunately it does make certain factorings of code tricky.
I'd suggest we add a comment over the constructor to hopefully make more clear to the next interested reader what is going on.  See #322.

It's worth noting that this doesn't actually prevent nested transactions. You can always bypass it with execute_batch, which doesn't require mut.
It does prevent a number of refactorings though, and IMO makes the API more difficult to work with.

https://github.com/jgallagher/rusqlite/pull/285#issuecomment-308510303

But we can make Rust rejects nested transactions at compile time.

Or more precisely, we can make Rust rejects nested programmatic Transaction at compile time.


Search for both email and user_id to get a segment_id

Closes INTS-294
Description Of Changes
Includes the option to also collect the segment ID via email instead of the user_id
I'm unclear if there is any issue with running dual read requests, assuming the returned values are consolidated if (as in our test case) the segment_id is returned for both
Code Changes

[ ] add a read request that also queries the email attribute of a segment user profile

Steps to Confirm

[ ] validate the test postman request also returns when querying by email

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

Steve and I talked about this a bit this am, and I wanted to capture some of that discussion here!
It does look like it may be a better bet to use the 'email' as our identity rather than setting up two read requests that return the same value (the 'segment id') by email or by user_id. One of the concerns is that other customers could end up needing to use the user_id rather than email owing to their own use of Segment, otoh, using email would be super consistent with our overall flow =). We could also add this flexibility later if it is needed.
We set up a local saas_config.toml for Steve and tried running the tests for segment but while we managed to get past a few of the errors, we may need to look further to isolate and resolve these errors.

Hey Steve, thanks for adding the new endpoint! I just updated the formatting for how you specify a list of read requests, take a look. As for your question about deduplicating results, yes, if a user if found by both user_id and email lookups, we will still only send one segment_id to the downstream collections. This is a recent introduction so I'm glad we got it just in time for this 😄

Thank you for this @galvana !! Your change makes perfect sense for the list formatting - thanks for pushing it 💙


Should min_kmer_covg be per sample in pandora compare?

min_kmer_covg is almost always set to the expected depth coverage / 10 of the first sample: https://github.com/rmcolq/pandora/blob/c16c1fac48ccdf98e0719ea003492c3fd2ec9034/src/compare_main.cpp#L415-L416 (unless the expected depth coverage of the first sample is < 10, in which min_kmer_covg will then become 0, and then we will try for the second sample and so on, but let's ignore this).
Eventually, this min_kmer_covg is used to compute the gaps of coverage of a sample in a VCF record: https://github.com/rmcolq/pandora/blob/c16c1fac48ccdf98e0719ea003492c3fd2ec9034/src/localPRG.cpp#L1648-L1649 , which impacts on the genotyping. Thus, the coverage of the first sample is impacting on the genotyping of all samples.
In our current experiments, this is not an issue as all samples are subsampled to the the exact same coverage, but this could be an issue when having several samples with different coverages (although none of them exceeds max_covg).
Logging this for a later fix.

I guess what was raised before was the error rate. No impact in our current experiments I guess, as all samples input to pandora are downsampled to the exact same coverage


#10548: Support tile layout for width/height-sharded concat

Ticket
#10548
Problem description
Change kernel to support concat on both width and height-sharded tensors in tile layout. The kernel supports the following cases:

Height-sharded width concat in row-major/tile layout
Width-sharded height concat in row-major/tile layout

This is based on #13737 and need to wait for it to merge first
What's changed

Rename and change s2s_rm_concat_multi_core to s2s_concat_multi_core to support tile layout besides the row-major layout
Rename reader_s2s_rm_tensor_concat.cpp to reader_s2s_tensor_concat.cpp

Checklist

[x] Post commit CI passes https://github.com/tenstorrent/tt-metal/actions/runs/11396048642
[ ] Blackhole Post commit (if applicable)
[x] Model regression CI testing passes (if applicable) https://github.com/tenstorrent/tt-metal/actions/runs/11396057538
[ ] Device performance regression CI testing passes (if applicable) https://github.com/tenstorrent/tt-metal/actions/runs/11396055725
[x] New/Existing tests provide coverage for changes

Device performance regression (https://github.com/tenstorrent/tt-metal/actions/runs/11396055725) is failing with:
AssertionError: Some model(s) AVG DEVICE KERNEL SAMPLES/S are faster than expected, see above for details. {'AVG DEVICE KERNEL SAMPLES/S': [('ttnn_distilbert8_distilbert-base-uncased-distilled-squad', 90.4624, 20.394), ('ttnn_functional_ttnn_vgg11_1_', 270.5544, 108.871), ('ttnn_functional_ttnn_vgg16_1_', 195.0345, 95.378)]}

However it is currently also happening on the main branch: https://github.com/tenstorrent/tt-metal/actions/runs/11399044245/job/31717674624#step:9:2739

Device performance regression (https://github.com/tenstorrent/tt-metal/actions/runs/11396055725) is failing with:
AssertionError: Some model(s) AVG DEVICE KERNEL SAMPLES/S are faster than expected, see above for details. {'AVG DEVICE KERNEL SAMPLES/S': [('ttnn_distilbert8_distilbert-base-uncased-distilled-squad', 90.4624, 20.394), ('ttnn_functional_ttnn_vgg11_1_', 270.5544, 108.871), ('ttnn_functional_ttnn_vgg16_1_', 195.0345, 95.378)]}

However it is currently also happening on the main branch: https://github.com/tenstorrent/tt-metal/actions/runs/11399044245/job/31717674624#step:9:2739

Yeah this was actually me, perf numbers have improved on a bunch of models but I didn't update them with my change since we fail on very big improvements too (to prevent the numbers from getting stale).

Hi @ayerofieiev-tt , this is another kernel ramp-up task that needs a code owner review and merge. Thanks!


feat(*): add contract versions

Is there a chance we can document the what features we have to specify for each type of contract/version? The new TS types complain a lot about the different combos and it's pretty hard to figure out which one to use; the docs do not specify anything about it.
Thanks!


Nextjs not updating new code with PM2 reload

Describe the bug
I would like to utilise the 0 downtime deploy with the pm2 reload function.
For that I switched from running
pm2 stop hpssr; pm2 delete hpssr; pm2 start ecosystem.config.js
to run
pm2 reload ecosystem.config.js
The output I get is
[PM2] Applying action reloadProcessId on app [hpssr](ids: 0,1)
[PM2] [hpssr](0) ✓
[PM2] [hpssr](1) ✓

But I dont see the new code changes.
While there is a new build and BUILD_ID the page is still loaded with the old BUILD_ID (while with the other command it would update to the new BUILD_ID)
To Reproduce
Try to update an existing running app and restart it with pm2 reload all
This also happens with
pm2 stop all; pm2 start all;
pm2 restart;

The only way I manage to get the new BUILD_ID is by deleting the current running processes with
pm2 delete all
Expected behavior
The app should reload with the new BUILD_ID
System information

Ubunutu 14 aws server
Version of Next.js: 5.0.1

Additional context
I also opened a ticket in the pm2 project but I believe it to be an issue that relates to next&pm2
https://github.com/Unitech/pm2/issues/3677
Thanks for your help!!!

Next.js is just a Node.js application. When Next.js is started the BUILD_ID is read. It's up to the user to make sure the app is restarted correctly after building.

@timneutkens but other apps works just fine with pm2 so its probably not an issue on their end as well... I can see it restart the servers but I for some reason it will not grab the new build_id


[FEATURE] Starting eww with a different config path without restarting it.

Description of the requested feature
Basically i want to use the -c flag without restarting eww
Proposed configuration syntax
idk
Additional context
no

Just make it a one liner or bash function or smth? You'd hvae to run eww reload anyway

this has two possible implementations:

make it possible to run multiple eww daemons. That should definitely be done regardless of the other option, and would pretty much only require the eww daemon socket file to be specific to the provided config file - running another one when another config file is selected.
make a daemonless mode that immediately opens a single window and nothing more. This would be a bit harder to implement, but also provide a lot of value both for debugging, development and widget-development.

Nr. 1 I'll definitely implement, Nr. 2 maybe in the future

it is now possible to run different configurations simultaneously, running multiple daemons is now possible by passing different --config flags to the daemon and other commands. Thus this can be closed!


Added property comment on Windows group.

Signed-off-by: Kapil Chouhan<EMAIL_ADDRESS>Description

Added a property comment to allow user to add a comment of a windows group
Added a method net_local_group_set_info for set a comment of windows group by using NetLocalGroupSetInfo
Added test cases
Ensured chef-style on the code changes made

Issues Resolved
Fixes MSYS-897: Allow setting the comment/description on a Windows group
Check List

[x] New functionality includes tests
[x] All tests pass
[x] RELEASE_NOTES.md has been updated if required (not required for bugfixes, required for API changes)
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

@stuartpreston any objection to this?

TravisCI problems are known issues under investigation.


extra space in the list at end

every time at the end of the list there is space according to max height adjust.
if max height increase space also increasing. I m currently using version 3.2.1

@rahulkjose fixed in v4.5.0


Fix Apple Icon width in Readme

Adds width="17" to match height="17" to Apple icon image.
Before:

After:

I can't reproduce the issue; the icons appear to be square in Edge, Firefox, and Chrome.


372 deprecated lifecycle callbacks

It's possible that the datepicker could have been changed to not cause an extra render with componentDidUpdate but it was the easiest and shortest way to remove the deprecated callbacks without touching too much of the other code.

Coverage decreased (-0.06%) to 81.822% when pulling 1ef3b0185429fe1f7a19457b37b488ac2379ddc5 on ivarni:372-deprecated-lifecycle-callbacks into 77058e360333ccbe86157ac3e8204a4ada8d8f1a on SpareBank1:develop.

Note that I did not fix ffe-account-selector-react, it went into a loop when I tried and I don't really want to rewrite the entire thing so I'll leave that up to someone else.


Alzheimer detection and its model deployment

I am interested in this work in GSSoC'22.Could you please assign this to me.

hi , i am currently  doing by betech degree in data science ,  i have worked on machine learning models to predict  heart disease and various other ml beginner projects . I am interested in this project  as a GSSoC 24 contributor . Could you please assign this to me

I am a GSSoC'24 contributor and a machine learning engineer, could you please assign me this issue


changing subscriptionsByTopic?

according to this discussion I'm trying to store only clientId in Qlobber instead of {clientId, qos, topic} object.
The only barrier here is persistence subscriptionsByTopic which is returning those objects in enqueueOffline, however only a list of clientIds would suffice.
I trace down for any access to that object, and here it is, only the removeSharp filter!
What does that do? can we remove that check? or can we run that check against  packet.topic?
This is the only blocker to switch Qlobber to clientId values @mcollina

The removeSharp functionality must stay in, as the $SYS  topic is not matched by #. It can be moved somewhere else.
I think this change is more articulated than what you describe, because the same object goes into https://github.com/mcollina/aedes-persistence/blob/master/persistence.js#L170. It does not use the topic and QoS either.

It does not use the topic and QoS either.

Yes, we can change outgoingEnqueue spec for the first argument.

It can be moved somewhere else

I'm not sure where we can move it @mcollina

I'm not sure where we can move it

I tend to agree, but if we can't move it we can't make this change. If you are subscribing with #, $SYS topics should not be enqueued.

@mcollina  let me ask:
Do $SYS topics ever need to be enqueued?
If not, why not to check packets topic is a SYS instead of checking on Qlobber's client topic.

Do $SYS topics ever need to be enqueued?

I assume so. Mosquitto enqueues them.

I believe we can think to drop support for qos>0 subscriptions on $SYS topics.
A stateful $SYS subscriber means not a good idea to me... Broker should not be responsible for offline storage of $SYS messages. they can be huge also.

I think that is needed to support the mosquitto bridge protocol.
Another idea is to block offline storage of messages from a # subscription, so a full # subscription can only do QoS 0. I think that's more reasonable, even if we want to break from the MQTT spec.

Another idea is to block offline storage of messages from a # subscription, so a full # subscription can only do QoS 0. I think that's more reasonable, even if we want to break from the MQTT spec.

That would need a change to handleSubscribe, yes?

That would need a change to handleSubscribe, yes?

Yes.
cc @GavinDmello what do you think?

I also referenced the discussion topic about storing values inside Qlobber, which I was against, until @davedoesdev can provide us with a new fast built-in dedup Qlobber. (as fast as QlobberDedup) so we can remove codes like this

@mcollina Could we just remove # from qlobber when he subscribes on a $SYS topic and vice versa  ? So at a time we can't subscribe to both.
I'm not sure if blocking offline storage for # would be right.
I'm 👍 for the QlobberDedup idea.
QosQlobber in the example I linked to is nearly the same as QlobberDedup. They both inherit from Qlobber but QosQlobber uses Maps and QlobberDedup uses Sets.

I added to the benchmarks an example Qlobber (like QlobberQos in https://github.com/davedoesdev/qlobber/issues/9) but which stores its values in a Map.  See https://github.com/davedoesdev/qlobber/blob/custom-qlobber-example/bench/options/_mapval.js
Results are below:
Running "exec:bench-check" (exec) task

  add_match_remove x20,000
  ┌──────────────┬────────────┬──────────────┬──────────┐
  │              │ total (ms) │ average (ns) │ diff (%) │
  ├──────────────┼────────────┼──────────────┼──────────┤
  │ check        │     12,658 │      632,918 │        - │
  │ check-dedup  │     14,054 │      702,697 │       11 │
  │ check-mapval │     14,454 │      722,702 │       14 │
  └──────────────┴────────────┴──────────────┴──────────┘

  match x20,000
  ┌──────────────┬────────────┬──────────────┬──────────┐
  │              │ total (ms) │ average (ns) │ diff (%) │
  ├──────────────┼────────────┼──────────────┼──────────┤
  │ check        │      6,532 │      326,605 │        - │
  │ check-dedup  │      7,196 │      359,803 │       10 │
  │ check-mapval │      7,308 │      365,418 │       12 │
  └──────────────┴────────────┴──────────────┴──────────┘

do you have a dataset to benchmark?

I'll do a bench and let you know 👍

@davedoesdev based on your bench, will QosQlobber perform badly on wildcard topic publishes? (match-many)
And can you add another bench like match-add where a topic is checked before adding, then added if not exists. (this will only be meaningful for default Qlobber)

Adding 2878969 topics @davedoesdev

Qlobber
time
heap

Qlobber
100886.361ms
3052.9MB

QlobberDedup
114514.373ms
3525.1MB

MapValQlobber
185898.631ms
3608.9MB

I think the best trade of is QlobberDedup, with single clientId values. With should do something to # topic handling @mcollina @GavinDmello

@mcollina Could we just remove # from qlobber when he subscribes on a $SYS topic and vice versa ? So at a time we can't subscribe to both.
I'm not sure if blocking offline storage for # would be right.

I do not think this will work, because qlobber will report # as matching $SYS. But if we can make it work 👍 . We can just refuse the current subscription, not the previous one.

@behrad do you have the program for those benchmarks? I'd like to add it to the qlobber tests and see if I can improve things (although it might just be Map overhead).

I do not think this will work, because qlobber will report # as matching $SYS. But if we can make it work 👍 . We can just refuse the current subscription, not the previous one.

I thought of removing any subscription with # from Qlobber and persistence when the client subscribes with a $SYS topic and vice versa, but rejecting the subscription also works.
Let's document the behaviour though

Is there anything I can do with Qlobber? I think MapValQlobber is a reasonable approach and doesn't require changing core. It seems Map has quite a bit more overhead than Set here.

I ran aedes with Redis persistence under my real-world load yesterday and unfortunately the hot path which was sticking cpu to 100% was https://github.com/mcollina/aedes-cached-persistence/blob/master/index.js#L45 as I expected.
This is no good for me, QlobberDedup helped me out in mosca, however in aedes we have the issue of keeping objects of subscriptions instead of clientIds in qlobber, only to do # handling!
I will try both QLobberDedup (with clientId) and MapVal again under my real load, and let you know about the results. I believe we should go either way...
next step is sharing a single cached-persistence process to factor all processing out inside a single shared one. (don't know if that even gets a bottleneck) but currently the publish-the-sub-receive-all-add-to-process is the scalability barrier, since a few tens of client connects per second is generating a huge CPU on all nodes of aedes all by executing Qlobber.add for the same each client.
@mcollina @davedoesdev

@behrad Are you still adding many entries with the same topic?

I also have another idea.
What if I added a test() method to Qlobber (and QlobberDedup)? Instead of collating all the matches, it would just check if one matches and return a boolean. The equality test could be a method, overridable for custom equality.

I've published qlobber version 0.12.2 which has a test(topic, val) which allows you to check whether a value is matched by a topic, without having to retrieve the whole match.
It seems to make a big difference:
  match_search_many x1
  ┌─────────┬────────────┬────────────────┬──────────┐
  │         │ total (ms) │   average (ns) │ diff (%) │
  ├─────────┼────────────┼────────────────┼──────────┤
  │ default │      1,743 │  1,743,358,885 │        - │
  │ dedup   │     11,237 │ 11,237,454,297 │      545 │
  │ mapval  │     33,800 │ 33,799,947,637 │    1,839 │
  └─────────┴────────────┴────────────────┴──────────┘

  test_many x1
  ┌─────────┬────────────┬──────────────┬──────────┐
  │         │ total (ms) │ average (ns) │ diff (%) │
  ├─────────┼────────────┼──────────────┼──────────┤
  │ default │          3 │    3,208,711 │        - │
  │ dedup   │          3 │    3,310,317 │        3 │
  │ mapval  │          3 │    3,312,106 │        3 │
  └─────────┴────────────┴──────────────┴──────────┘

match_search_many searches for values by matching first then going through the results.
test_many calls test() to do the same.

If you change https://github.com/mcollina/aedes-cached-persistence/blob/master/index.js#L45 to call test().
You'll probably have to derive a custom Qlobber from QlobberDedup and override test_values to provide an equality function.

You'll probably have to derive a custom Qlobber from QlobberDedup and override test_values to provide an equality function

then the bottleneck would be moved into test_values , since the implementation should iterate over a Set of objects to see whose clientId matches. Am I right @davedoesdev ?
Any fast data structure with direct access based on clientId would help, wouldn't?

@behrad correct. But is it possible to customise the derived Qlobber to store indexed by clientId? Possibly a two tier structure by clientId and subscription?
I'm going to take a look at the aedes code but won't be for a couple of days.

I am still on storing only clientId string in Qlobber and some how handling # topics...
Storing subscription object is creating performance/complexity issues

It would help to have a self-contained test we could benchmark outside aedes which replicates the issue.

I'll try to create one, yes!
What about storing a hash string like clientId,topic,qos inside QlobberDedup @davedoesdev ?
considering that e.g. , is a separator that won't be used inside clientId and topic
matcher.add('foo/#', 'test1,foo/#,1') !?

@behrad Have we considered strigifying  ?

Didn't get it @GavinDmello ?

What is it that needs looking up? What if you stored multiple chained hash tables e.g.
test1 -> foo/# -> 1 ?

I meant instead of creating a custom hash, why not just insert json strings into Qlobberdedup.
There would be some overhead parsing and stringifying but we can avoid using seperators

It would help to have a self-contained test we could benchmark outside aedes which replicates the issue.

In real world load, each aedes instance is restoring subs on whole client connects on the cluster (many more than joining/new clients that are adding new subscriptions).
So a tons of .add calls will not add since qlobber contains the sub from the aedes _setup @ startup.
Now @davedoesdev What dya propose in such scenario?
DedupQlobber.add
DedupQlobber.test + DedupQlobber.add
DedupQlobber.match + DedupQlobber.add
Qlobber.test + Qlobber.add
Qlobber.match + Qlobber.add
...
Again, considering that in most of cases, sub already exists and aedes won't add new subs inside trie. So i believe this is the hottest path.

What is it that needs looking up? What if you stored multiple chained hash tables e.g.

This is a good choice, Using QlobberDedup with clientId strings + storing a hash table inside aedes-cached-persistence as a side lookup to trie, If I'm getting you right?
this way we can take most of QlobberDedup, and also don't change aedes persistence API (we would be able to augment clientId with topic/qos (looking up the side hash table) when returning out. this looks more feasible/performant that the stringify or concat-hash that I proposed @GavinDmello , huh?

What is it that needs looking up?

sub trie matching would work only based on clientId as mosca @davedoesdev
The only change in aedes related, is that aedes is returning the whole subscription (original topic is needed inside callers above). Client original subscribed topic will then be checked inside aedes router to ensure we are not routing a $SYS topic to a # topic!
I want you to fix me if not guys @GavinDmello @mcollina

@behrad @mcollina I'm keen to make a test case and benchmark in Qlobber. Could what aedes requires be put into such? I can try to guess and paste here if you like, but again it won't be immediately.

Why not to marking new/restore subs when publishing $SYS, then cluster nodes would be able to only call QlobberDedup.add for new subs! restore subs should be already added upon _setup. Is this ok @mcollina @GavinDmello ?

This is my BIG issue now under production, since we have multiple wildcard topics with 1.5 million clients. (3.5 million subscriptions)
I will consider switching to QlobberDedup, and using an external hash table to store subscriptions (I hope the memory overhead be affordable)
I will also take my optimization above into consideration in a new PR.


repositories not loaded

I have grant api and read_user of my gitlab account, but my repositories not loaded

This is a confirmed issue and was fixed in this PR


Drop in accuracy on resumt

I am running this code on a server that has a time limit of one day per job. So, I need to resume the code. I see a drop in accuracy when the training is resuming.
Could you please comment on what might be causing such drops?

which algorithm you observe the performance drop after resume?

FixMatch. Not sure any other have this issue.

Can you provide the log file for training (and resume in training) for more information?

Hi @ShuvenduRoy, I'm not part of the TorchSSL team.
But I found a small bug when saving the model #64. I am not sure if this is the cause of the problem. If you want, you can take a check.


Support annotation that allow annotated property to be used when reading and writing Enum to DB

Do you have any plans to support specific property of Enum to be used as DB input/output values instead of Enum.name()?
Since there is no predefined feature support(like annotation), each developer who wants to these feature have to implement it by themselves.
Because property name of App layer should not affect attribute name of DB layer and vice versa, I think a lot of people might want this feature.
Although I've include it in EnumTypeHandler, it would be also good to be provided as another builtin EnumTypeHandler, or make it as an example.

Not like this.
If your enums implement an interface like this, you may be able to write/register a universal type handler.
public interface DbCode {
  int getDbCode();
}

Please see test case in this directory.

I see. It was already possible by interface inheritance and MappedType without changing defaultEnumTypeHandler.


In 3. Scan Image section of drawer, get access to phone's camera

https://user-images.githubusercontent.com/93662806/196027085-2837462b-54a6-4c14-8361-ac57cb567df3.mp4
Open Camera on Tap of 3. Scan Image (MENTIONED IN TODO)  in lib/Drawer.dart file

Hii @Soham-Chakraborty-8455 , the attached clip intrigued me about the project, could you specify how I can contribute to this project?

The video shows the drawer page. Once the container named '3. Scan Image' is clicked/tapped, the phone's camera should pop up and start scanning the skin. In other words, I want the phone camera to startup once the '3. Scan Image' is pressed

hey, I am interested in this issue. Could you assign it to me?

Sure

Sure


Provide a link for a guidance to how to know the tenant ID when running forgetme tool

Provide a link for a guidance to how to know the tenant ID when running forgetme tool. [1]
[1] https://docs.wso2.com/display/IS550/Removing+References+to+Deleted+User+Identities#RemovingReferencestoDeletedUserIdentities-Changingdefaultconfigurationsofthetool
sh forgetme.sh -U ushaniten -T ushani.com -TID 1

Added a tip on how the delete-event.log can be used to get info on deleted users when a user wants to run the tool to anonymize identities of a particular deleted user. Also linked off to [1] for  more details on tracking user deletion.
[1] https://docs.wso2.com/display/IS550/Configuring+Users#ConfiguringUsers-deleteEvent


Add validation on input

Fix bug #35

Also fixes #37

Fix #38 - allow window and sub-window to be moved around the screen or to a different screen

Address  #39 - Add Browser Picker to Windows Start Menu :)

Thanks!