[Spark-19535][ML] RecommendForAllUsers RecommendForAllItems for ALS on Dataframe

What changes were proposed in this pull request?
This is a simple implementation of RecommendForAllUsers & RecommendForAllItems for the Dataframe version of ALS. It uses Dataframe operations (not a wrapper on the RDD implementation). Haven't benchmarked against a wrapper, but unit test examples do work.
How was this patch tested?
Unit tests
$ build/sbt
> mllib/testOnly *ALSSuite -- -z "recommendFor"
> mllib/testOnly

Test build #73540 has started for PR 17090 at commit 707bc6b.

Test build #73543 has started for PR 17090 at commit 832b066.

Test build #73543 has finished for PR 17090 at commit 832b066.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73543/
Test PASSed.

Merged build finished. Test PASSed.

Test build #73553 has started for PR 17090 at commit ebd2604.

Test build #73553 has finished for PR 17090 at commit ebd2604.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73553/
Test PASSed.

Merged build finished. Test PASSed.

cc @MLnick

the same as  https://github.com/apache/spark/pull/12574 ?

@hhbyyh  This is different from https://github.com/apache/spark/pull/12574 since it sidesteps the ongoing design discussions about input and output schema.  Eventually, I'd like us to proceed with https://github.com/apache/spark/pull/12574 but only after we've figured out the right workflow for using these methods in a Pipeline with tuning.

#12574 is a comprehensive solution that also intends to support cross-validation as well as recommending for a subset (or any arbitrary set) of users/items. So it solves SPARK-10802 and SPARK-10802 at the same time.
That PR is in fully working state. I'm a little surprised to see work done on this rather than deciding on the input/output schema stuff...

By the way I have been doing performance testing in support of #12574 and results are pretty much ready.

I'd been following the long discussions about a transform-based solution, but those had not seemed to have converged to a clear design.    (Keep in mind that the code freeze is scheduled to happen in a day or two: http://spark.apache.org/versioning-policy.html )

For performance tests, I've been using the MovieLens ml-latest dataset here. It has 24,404,096 ratings with 259,137 users and 39,443 movies.
So it's not enormous but "recommend all" does a lot of work - generating 1,631,206,099 predicted ratings raw before the top-k.
Some quick tests for the existing recommendProductsForUsers gives 306 sec.
scala> spark.time { oldModel.recommendProductsForUsers(k).count }
Time taken: 306512 ms
res11: Long = 259137

As part of my performance testing I've tried a few approaches roughly similar to this PR, but using Window and filter rather than this top-k aggregator (which is a neat idea).
At first I thought this PR was really good:
scala> spark.time { newModel.recommendForAllUsers(k).count }
Time taken: 151504 ms
res3: Long = 259137

151 sec seems fast!
But then I tried this:
scala> spark.time { newModel.recommendForAllUsers(k).show }
+------+--------------------+
|userId|     recommendations|
+------+--------------------+
| 35982|[[131382,15.53116...|
| 67782|[[131382,29.72169...|
| 82672|[[132954,12.19152...|
|155042|[[148954,16.09084...|
|167532|[[118942,13.94282...|
|168802|[[27212,11.881494...|
|216112|[[109159,25.46359...|
|243392|[[153010,9.85302]...|
|255132|[[131382,15.50626...|
|255362|[[131382,10.08476...|
| 17389|[[152711,16.09958...|
|120899|[[156956,12.61003...|
|213089|[[82055,13.293286...|
|253769|[[152711,16.57459...|
|258129|[[152711,22.50499...|
| 24347|[[152711,12.31282...|
| 35947|[[153184,11.04110...|
|103357|[[132954,13.26898...|
|130557|[[118942,14.00168...|
|156017|[[153010,12.24449...|
+------+--------------------+
only showing top 20 rows

Time taken: 672524 ms

672 sec, over 2x slower than mllib impl.
Not sure why count is fast relative to show (maybe Spark SQL is not doing all the actual compute, while for show it does need to?).

@jkbradley do we propose to add further methods to support recommending for all users (or items) in an input DF? like recommendForAllUsers(dataset: DataFrame, num: Int)?

@MLnick Thanks for showing those comparison numbers.  If your implementation is faster, then I'm happy going with it.  I do wonder if we might hit scalability issues with RDDs which we would not hit with DataFrames, so it'd be worth revisiting a DF-based implementation later on.
In terms of the API, my main worry about https://github.com/apache/spark/pull/12574 is that I haven't seen a full design of how ALS would be plugged into cross validator.  I still don't see how CV could handle ALS unless we specialized it for recommendation.  It was this uncertainty which made me comment on https://issues.apache.org/jira/browse/SPARK-13857 to recommend we go ahead and merge basic recommendAll methods, while continuing to figure out a good design for tuning.
Feel free to push back, but I would really like to see a sketch of how ALS could plug into tuning.  I haven't spent the time to do a literature review on how tuning is generally done for recommendation, especially on the best ways to split the data into folds.

further methods to support recommending for all users (or items) in an input DF? like recommendForAllUsers(dataset: DataFrame, num: Int)

I do think this sounds useful, but I'm focused on feature parity w.r.t. the RDD-based API right now.  It'd be nice to add later, though that could be via your proposed transform-based API.

Fitting into the CV / evaluator is actually fairly straightforward. It's just that the semantics of transform for top-k recommendation must fit into whatever we decide on for RankingEvaluator, so they are closely linked. (In other words, they must be compatible). Once the semantics (basically output schema for transform) are decided it's quite simple.
It was discussed on the JIRA here and here.
I haven't had a chance to refine it yet but I have a view on the best approach now (basically to fit in with the design of SPARK-14409 and in particular the basic version of #16618). I think that design / schema is more "DataFrame-like".
In any event - I'm not against having the convenience methods for recommend-all here. I support it. Ultimately the transform approach is mostly for fitting into Pipelines & cross-validation. transform could call into these convenience methods (though it will need a DataFrame-based input version).

The performance of #12574 is not better than the existing mllib recommend-all - since it wraps the functionality it's roughly on par.

I should note that I've found the performance of "recommend all" to be very dependent on number of partitions since it controls the memory consumption per task (which can easily explode in the blocked mllib version) vs the CPU utilization & amount of shuffle data.
For example, the default mllib results above use 192*192 = 36,864 partitions (due to cross-join). So it does prevent dying due to exploding memory & GC but is slower than using fewer partitions. However, too few partitions and it dies.
I actually just realised that the defaults for mllib for user/item blocks - which in turn controls the partitions for the factors - is defaultParallelism (192 for my setup), while for ml it is 10. Hence we need to create a like-for-like comparison.
(Side note - it's not ideal actually that the num blocks drives the recommend-all partitions - because the optimal settings for training ALS are unlikely to be optimal for batch recommend-all prediction).
Anyway some results of quick tests on my setup:
Firstly, to match mllib defaults:
mllib with 192*192: 323 sec
scala> spark.time { oldModel.recommendProductsForUsers(k).foreach(_ => Unit)  }
Time taken: 323367 ms

ml with 192*192: 427 sec
scala> val newModel = newAls.setNumUserBlocks(192).setNumItemBlocks(192).fit(ratings)
scala> spark.time { newModel.recommendForAllUsers(k).foreach(_ => Unit) }
Time taken: 427174 ms

So this PR is 30% slower - which is actually pretty decent given it's not using blocked BLAS operators.
Note I didn't use netlib native BLAS, which could make a large difference when using level 3 BLAS in the blocked mllib version.
Secondly, to match ml defaults:
mllib with 10*10: 1654 sec
scala> val oldModel = OldALS.train(oldRatings, rank, iter, lambda, 10)
scala> spark.time { oldModel.recommendProductsForUsers(k).foreach(_ => Unit)  }
Time taken: 1654951 ms

ml with 10*10: 438 sec
scala> val newModel = newAls.fit(ratings)
scala> spark.time { newModel.recommendForAllUsers(k).foreach(_ => Unit) }
Time taken: 438328 ms

In this case, the mllib version blows up with memory & GC dominating runtime, and this PR is over 3x faster (though it varies a lot: 600 sec above, 438 sec here, etc).
Finally, middle of the road case:
mllib with 96*96: 175 sec
scala> spark.time { oldModel.recommendProductsForUsers(k).foreach(_ => Unit)  }
Time taken: 175880 ms

ml with 96*96: 181 sec
scala> spark.time { newModel.recommendForAllUsers(k).foreach(_ => Unit) }
Time taken: 181494 ms

So a few % slower. Again pretty good actually considering it's not a blocked implementation. Still room to be optimized.
After running these I tested against a blocked version using DataFrame (to more or less match the current mllib version) and it's much faster in the 192*192 case, a bit slower in 96*96 case and also blows up in the 10*10 case. Again, really dependent on partitioning...
So the performance here is not too bad. The positive is it should avoid completely exploding. As I mentioned above I tried a similar DataFrame-based version using Window & filter and performance was terrible. It will be interesting to see if native BLAS adds anything.

Finally, I've done some work related to SPARK-11968 and have a potential solution that seems to be pretty good. In this case it should be more than 3x faster than the best runtime here.

@MLnick Thanks a lot for the detailed tests!  I really appreciate it.  In this case, are you OK with the approach in the current PR (pending reviews)?
One thing we should confirm is what you think of the input/output schema for these methods.  It'd be nice to have the schema match what you think best for the transform-based recommendAll.
Re: design: I saw the discussions in https://issues.apache.org/jira/browse/SPARK-13857 but I didn't see a clear statement of pros & cons leading to a design decision.  I'm sorry about not having time to get involved with the discussions, but I'd like to help out as useful in the coming months.

The output in https://github.com/apache/spark/pull/12574/ looks like a DataFrame with Row(srcCol: Int, "recommendations": Array[(Int, Float)]) so I think this PR as is matches the output type - @MLnick to confirm. Will make the suggested changes from everyone. Thanks a lot for the performance testing @MLnick! Really neat to see.

Test build #73623 has started for PR 17090 at commit 41a11e7.

Test build #73624 has started for PR 17090 at commit 4ac586a.

Test build #73628 has started for PR 17090 at commit ef93575.

Test build #73623 has finished for PR 17090 at commit 41a11e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73623/
Test PASSed.

Merged build finished. Test PASSed.

Test build #73624 has finished for PR 17090 at commit 4ac586a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73624/
Test PASSed.

Test build #73628 has finished for PR 17090 at commit ef93575.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73628/
Test PASSed.

Isn't deciding on the output schema for these methods essentially the same as deciding on transform semantics in #12574 (apart from the issue of how, or if, to have transform generate the "ground truth" items)?
So in a way I'm not certain this "circumvents" the discussion around transform semantics / fitting into cross-validation & pipelines but rather makes an implicit decision on it. If this is set here, it would be rather awkward to have any future transform based recommend all functionality with a different output schema.
My default choice in #12574 was to match the form of the existing mllib methods. That is the same as here, and matches the format for the existing RankingMetrics in mllib. So from that perspective it is the "easiest" choice.
It's not necessarily the "best" choice - I go into the other option in detail on #12574 and the related JIRA. Ideally it should match up with the expected input schema for a new RankingEvaluator (not strictly necessary but definitely preferable).
My concern here is that we make a quick decision implicitly due to time constraints and are stuck with it down the line as it is exposed in the public API.

It could also be I'm overthinking things - and we can mould the RankingEvaluator to accept both types of input - the array version: (Array(predictions), Array(labels)) or the "exploded" version: (label, prediction).
In which case it doesn't really matter what call we make here, as long as we're consistent with it later.

It's a good point about making an implicit decision.  We could deprecate these methods in favor of transform-based ones in the future---we have done this in the past---but it does push the long-term decision in a clear direction.
My hesitation about transform is not just about the schema.  It's also because I'm still unclear how we could plug ALS into tuning without having tuning specifically understand ALS (knowing about users, items, etc.).  I'll add my thoughts on the JIRA.

Test build #73787 has started for PR 17090 at commit b0680db.

Test build #73787 has finished for PR 17090 at commit b0680db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73787/
Test PASSed.

Merged build finished. Test PASSed.

Test build #73866 has started for PR 17090 at commit 6a7e3d1.

Test build #73866 has finished for PR 17090 at commit 6a7e3d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73866/
Test PASSed.

LGTM
Any other comments before we merge?

I'll merge this with master now
Thanks @sueann  and @MLnick for feedback.  I'll prioritize helping with your work on transform, metrics, and tuning for ALS next.

@jkbradley I've put my updated proposal for ranking evaluation on SPARK-14409 comments.
It's different from this schema (and from the mllib recommend all return types). I've detailed the reasoning in the JIRA.
I would have preferred a more explicit discussion & decision on the schema before merging this, but now that it's merged we should at least consider how (or if) to deal with the schema difference assuming the above proposal proceeds.

@MLnick  OK I think I misunderstood some of your comments above then.  I see the proposal in SPARK-14409 differs from this PR, so I agree it'd be nice to resolve it.  We can make changes to this PR's schema as long as it happens soon.
Here are the pros of each as I see them:

Nested schema (as in this PR): [user, Array((item, rating))]

Easy to work with both nested & flattened schema (df.select("recommendations.item"))  (AFAIK there's no simple way to zip and nest the 2 columns when starting with the flattened schema.)

Flattened schema (as in SPARK-14409): [user, Array(item), Array(rating)]

More efficient to store in Row-based formats like Avro

I'm not sure if there's a performance difference in the formats when stored in Tungsten Rows.  I think not, but that'd be good to know.

I commented further on the JIRA.
Sorry if my other comments here and on JIRA were unclear. But the proposed schema for input to RankingEvaluator is:
Schema 1
+------+-------+------+----------+
|userId|movieId|rating|prediction|
+------+-------+------+----------+
|   230|    318|   5.0| 4.2403245|
|   230|   3424|   4.0|      null|
|   230|  81191|  null|  4.317455|
+------+-------+------+----------+

You will notice that rating and prediction columns can be null. This is by design. There are three cases shown above:

1st row indicates a (user-item) pair that occurs in both the ground-truth set and the top-k predictions;
2nd row indicates a (user-item) pair that occurs in the ground-truth set, but not in the top-k predictions;
3rd row indicates a (user-item) pair that occurs in the top-k predictions, but not in the ground-truth set.

Note for reference, the input to the current mllib RankingMetrics is:
Schema 2
RDD[(true labels array, predicted labels array)],
i.e.
RDD of ([318, 3424, 7139,...], [81191, 93040, 31...])

(So actually neither of the above schemas are easily compatible with the return schema here - but I think it is not really necessary to match the mllib.RankingMetrics format)
ALS cross-validation
My proposal for fitting ALS into cross-validation is the ALSModel.transform will output a DF of Schema 1 - only when the parameters k and recommendFor are appropriately set, and the input DF contains both user and item columns. In practice, this scenario will occur during cross-validation only.
So what I am saying is that ALS itself (not the evaluator) must know how to return the correct DataFrame output from transform such that it can be used in a cross-validation as input to the RankingEvaluator.
Concretely:
val als = new ALS().setRecommendFor("user").setK(10)
val validator = new TrainValidationSplit()
  .setEvaluator(new RankingEvaluator().setK(10))
  .setEstimator(als)
  .setEstimatorParamMaps(...)
val bestModel = validator.fit(ratings)

So while it is complex under the hood - to users it's simply a case of setting 2 params and the rest is as normal.
Now, we have the best model selected by cross-validation. We can make recommendations using these convenience methods (I think it will need a cast):
val recommendations = bestModel.asInstanceOf[ALSModel].recommendItemsforUsers(10)

Alternatively, the transform version looks like this:
val usersDF = ...
+------+
|userId|
+------+
|     1|
|     2|
|     3|
+------+
val recommendations = bestModel.transform(usersDF)

So the questions:

should we support the above transform-based recommendations? Or only support it for cross-validation purposes as a special case?
if we do, what should the output schema of the above transform version look like? It must certainly match the output of recommendX methods.

The options are:
(1) The schema in this PR:
Pros: as you mention above - also more "compact"
Cons: doesn't match up so closely with the transform "cross-validation" schema above
(2) The schema below. It is basically an "exploded" version of option (1)
+------+-------+----------+
|userId|movieId|prediction|
+------+-------+----------+
|     1|      1|       4.3|
|     1|      5|       3.2|
|     1|      9|       2.1|
+------+-------+----------+

Pros*: matches more closely with the cross-validation / evaluator input format. Perhaps slightly more "dataframe-like".
Cons: less compact; lose ordering?; may require more munging to save to external data stores etc.
Anyway sorry for hijacking this PR discussion - but as I think you can see, the evaluator / ALS transform interplay is a bit subtle and requires some thought to get the right approach.

Thanks @MLnick for the explanation.  This is what I'd understood from your similar description on the JIRA, but definitely more in-depth.  (It might be good to copy to JIRA, or even a design doc at this point.)
As I'd said, I haven't done a literature review on this, so it's hard for me to judge what schema evaluators should be given.  I see some implicit decisions, such as evaluators using implicit ratings (using rows missing either a label or a prediction) and us not computing predictions for all (user,item) pairs with labels.
However, assuming the schema you've selected is best for evaluation, then I think this highlights 2 distinct needs for top K: (a) a user-friendly API (this PR) and (b) an evaluator-friendly API (your design).  For (a), many users have requested recommendForAll* methods matching the RDD-based equivalents, and this schema provides top K recommendations in an analogous and friendly schema.  If evaluator needs a less user-friendly schema, that's OK, but then I think it should be considered an internal/dev schema which can differ from the user-friendly version.
What do you think?

Good point for copying some detail to JIRA, will do that.

As for the API - I'm ok with having the "user-facing" version differ from the transform version. Though it may lead to some confusion. In this case, it's probably best to have transform only work for the cross-validation / evaluator setting and to make it clear in future how it all works and fits together, with appropriate doc, user guide and examples.


Fix double start of node.

bors r+

We can merge this for the presentation, but in the future, we need to make this more portable - the failure now is that this POSIX stuff is not going to build on Windows.

bors retry


Less flashy design for shapes in shapes layer

🚀 Feature
Maybe we could make the shapes rendering in Shapes layer a bit less flashy and sleaker.
A few ideas:

make the lines a bit thiner
choose less flashy colors (blue and orange defaults...)
at least make the shapes more transparent

Motivation
Shapes now have good defaults for development,
but when it comes to actual usage with real images,
it seems that the shape defaults are now too strong
compared to the data. Having softer colors, more transparency,
and thiner lines could make it more about the data and
annotation, and make it look less than a clone of Keynote or
Illustrator...

These aren't actually the defaults, these are just the colors used in the add_shapes.py example.
Happy to change both the example and the defaults though (which are as follows edge_width=1, edge_color='black', face_color='white', opacity=0.7).
In general more "scientific" examples would be a good thing I think

@royerloic i agree less flashy shapes are preferable. For transparency im not sure. Current transparency also seems okay at first sight. maybe we can come up with some basic adaptive approach? What do you think?

As noted above this example doesn't actually show the defaults, which are less flashy. We've now got more examples and tutorials on how to change this stuff here - http://napari.org/tutorials/shapes.html
We can always improve those examples / make them more scientific as we go


Fix segment's count to recognize dimensions properly

This makes me pretty unhappy since this code is brought in via pods, but
they seemed to have EOL'd the 2.0.x train and 3.0 (currently master on
github) isn't released.
Alternate suggestions welcome

@mikekatz please review/share my sadness

I'm not sure I understand what this is fixing. Shouldn't the result be the same as before? Also I'd hate to add additional work on top of the sadness, but we should either see if we can override this class in our own code, or fork the pod and point to that in our podfile, otherwise the next pod install will wipe out the change, right?

@mikekatz we heard back from segment and they said it's not getting fixed, but they have AN EXCITING MOBILE PRESS RELEASE coming, so I'm gonna go ahead and merge it. Their next SDK is in version "3.0.2-alpha." so I'm hoping this won't be there for more than a few weeks


Add a homepage

add a google search like homepage.

Done https://github.com/moficodes/bee-travels/pull/9


RLException: [view_hlds_laser.launch] Cannot launch the program

So I followed the steps as given in the documentation:

Installed ROS first on my Ubuntu 16.04 64-bit
I compiled and installed the https://github.com/ROBOTIS-GIT/hls_lfcd_lds_driver.git, as well as executed the following commands
sudo apt-get install ros-kinetic-hls-lfcd-lds-driver
sudo chmod a+rw /dev/ttyUSB0

None of these steps had issues and ran successfully. However when I try to run
roslaunch hls_lfcd_lds_driver hlds_laser.launch
or
roslaunch hls_lfcd_lds_driver view_hlds_laser.launch
it says
RLException: [view_hlds_laser.launch] is neither a launch file in package [hls_lfcd_lds_driver] nor is [hls_lfcd_lds_driver] a launch file name The traceback for the exception was written to the log file
Not sure what's happening. Any ideas?
Thanks
Anshul

If there is a problem, I recommend that you download the source code and compile it like below.
$ cd ~/catkin_ws/src
$ git clone https://github.com/ROBOTIS-GIT/hls_lfcd_lds_driver.git
$ cd ~/catkin_ws && catkin_make
$ sudo chmod a+rw /dev/ttyUSB0
$ roslaunch hls_lfcd_lds_driver view_hlds_laser.launch

This issue will be closed since there was no actions for a while.
You can reopen this issue to show this issue to the users whenever.


help output for sites:delete repeats command

Describe the bug
The output for sites:delete --help repeats netlify command.
To Reproduce

netlify sites:delete --help
See output below with duplicate netlify command name:

USAGE
  $ netlify netlify sites:delete {site-id}

Additional context
$ netlify --version
netlify-cli/2.68.4 linux-x64 node-v10.15.3

Hi @mheffner, thank you for opening this.
I'm getting:
Delete a site

USAGE
  $ netlify netlify sites:delete {site-id}

ARGUMENTS
  SITEID  Site ID to delete.

OPTIONS
  -f, --force                                                  delete without prompting (useful for CI)
  --debug                                                      Print debugging information
  --httpProxy=httpProxy                                        Proxy server address to route requests through.
  --httpProxyCertificateFilename=httpProxyCertificateFilename  Certificate file to use when connecting using a proxy server

DESCRIPTION
  This command will permanently delete the site on Netlify. Use with caution.

EXAMPLE
  netlify sites:delete 1234-3262-1211

What is the output you're expecting to see?

@erezrokah Under "USAGE" it seems like we should only print "netlify" once. For example, this is the USAGE output for "sites:list":
USAGE
  $ netlify sites:list

Oh, didn't even notice that, thanks


filetype: add cfg support

Close #19
This patch adds:

support for the cfg filetype
a new global option header_cfg_comment_char: comment character for
cfg's filetype. If not set, it defaults to #.

It looks smooth, thanks!

Hum I forgot to update CHANGELOG.md as well as README.md. Should i submit another PR for that as it's now merged ?

It's not problem. You can make PR for these too


Update import statements for missing 'account'

Name 'account' does not exist in azure.mgmt.datalake.store. Updating code sample import statements.

Hi @akarloff, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@akarloff : Thanks for your contribution to the Azure documentation! The author, @nitinme, has been notified to review your proposed change.

@akarloff - Thanks for the catch

#sign-off


Use new Next router and layout system once available

Next is adding much better support for nested layouts in pages, loading states using React 18's Suspense, and error boundaries in Next 13, initially beta. We should jump on the train as soon as we can. It will allow us to clean up/remove the createPage function and simplify/improve our loading/error states.
https://nextjs.org/blog/next-12-3#new-router-and-layouts-update

This might affect large portions of the application, but the benefits might not be too great. Simplifying this part of the application might help newer contributors contribute more quickly.


Discovery fix

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Link/LinkConfirmation.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkConfirmResponse.cs  1
- src/In.ProjectEKA.HipService/Link/LinkPatientRequest.cs  1

Clones added
============
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  7
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/DiscoveryContextModelSnapshot.cs  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Link/LinkConfirmation.cs  1
- src/In.ProjectEKA.HipService/Link/LinkPatientRequest.cs  1
- src/In.ProjectEKA.HipService/Gateway/Model/GatewayLinkConfirmResponse.cs  1
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  1

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Link/LinkControllerTest.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  7
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/DiscoveryContextModelSnapshot.cs  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.cs  1

Clones added
============
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/DiscoveryContextModelSnapshot.cs  3
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.cs  1
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  1

Clones added
============
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/DiscoveryContextModelSnapshot.cs  3
- src/In.ProjectEKA.HipService/Discovery/Database/Migrations/20200526172717_RenamingRequestID.Designer.cs  7

See the complete overview on Codacy


[PE-D][Tester A] Same item is not collated together for an order for a single business owner

Issue
The same item is not collated together for an order for a single business owner.
Steps to Reproduce
First, we add an order with 20 Table.

Type and send addo n/John Doe p/98765432<EMAIL_ADDRESS>a/311, Clementi Ave 2, #02-25 .
Type and send i/ Table q/20.
Type and send done.

The UI is as shown below:

Update the Table quantity to 20 (same as before, so there should ideally be no change in the user interface. it is important to reproduce the bug by making sure the quantity is exactly the same as the quantity in the existing order, for example editing the quantity here to 30 would not lead you to reproduce the bug): edito 1 i/Table q/20 . However, the Table item is now duplicated.

Now, we try to update the Table quantity to 50, but only the first Table item is updated: edito 1 i/Table q/50

Labels: type.FunctionalityBug severity.Medium
original: EmilyOng/ped#11

TODO
Check implementation detail for edit orders. System should also check if current order has any items with similar item name input.


Added my Github username

I neglected to add that in my original PR. My apologies for the additional PR!

I'll merge in the latest.


Please actually README

Rework the README to better introduce the project and docs to a newcomer.

I think I've responded to all feedback- this is ready for another look.


Fix peer visiblity in SceneReplicationInterface._update_sync_visibility

If there are 2 or more peers and the synchronizer is visible to the first peer, then the second peer won't be check. Because the local variable is_visible has changed by first peer.

@Faless

Could you amend the commit message to reference the multiplayer part? E.g. Fix MultiplayerSynchronizer peer visibility? So it's easier to understand in the long Godot history.

@Faless
done

Thanks!


Introduced djangoCMS 3.4 compatibility

👍

Coverage increased (+3.7%) to 80.792% when pulling 472670d287832bc8f986a8d37ee907892a5c1b96 on feature/djangocms-34 into 4a8dc597943394ede74662a4b98bf24b3f4aca7d on master.

Coverage increased (+4.5%) to 81.579% when pulling 0fa50c4a1719d9bb0fa932727d9653a5cb6d87e2 on feature/djangocms-34 into 4a8dc597943394ede74662a4b98bf24b3f4aca7d on master.

Coverage increased (+4.5%) to 81.579% when pulling 0fa50c4a1719d9bb0fa932727d9653a5cb6d87e2 on feature/djangocms-34 into 4a8dc597943394ede74662a4b98bf24b3f4aca7d on master.

Coverage increased (+4.5%) to 81.579% when pulling 0fa50c4a1719d9bb0fa932727d9653a5cb6d87e2 on feature/djangocms-34 into 4a8dc597943394ede74662a4b98bf24b3f4aca7d on master.


REST API to push new passwords

Create a REST API to push new passwords so it can be integrated with CLI tools such as AD User Manager.
Ideally it would take in a POST request containing the following params:

Password
Days until expiry
Views until expiry
Allow viewers to delete before expiration

Then it returns the URL to retrieve the password so that it can be printed onscreen or copied to the clipboard.

Looks like this is already implemented in the new version actually... https://github.com/pglombardo/PasswordPusher/wiki/Password-API

Implemented in v2


System.InvalidOperationException

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
WinGet
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce

Open PowerToys Run using the shortcut keys
Type in "Mi"

✔ Expected Behavior
Show results starting with/containing "Mi"
❌ Actual Behavior
An error message will appear saying "Something went wrong".
Other Software
No response

/dup #18166

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know on #18166!


ResponseCompression will fail to modify headers if using PipeWriter.

When working on https://github.com/aspnet/AspNetCore/pull/7110, we recognized that ResponseCompression tries to modify headers before first write: https://github.com/aspnet/AspNetCore/blob/master/src/Middleware/ResponseCompression/src/BodyWrapperStream.cs#L201. This will not work if someone calls response.StartAsync (aka they are using pipes) when writing the response.
A few ideas for fixing this:

Make OnWrite occur in OnStarting rather than on first write
Make an internal feature that would be called before StartAsync() (same thing as OnStarting callbacks, just internal)

I tried making response.OnStarting() call OnWrite(). The only issue that occurs is if there isn't a response body, the response is "compressed", which causes a few tests to fail. Not sure how big of a deal that is.

#7110 will fix it now. We are going to shim the IHttpResponseStartFeature and call OnWrite first.


Can you create one for DSA in cpp?

Other
This will help alot of beginners to contribute who study DSA in cpp
Additional information
No response

ok I will create one more on C++

I can contribute to the one in C++

@ananya0504 I haven't created a website for c++ yet,
you can contribute in java if you want


-m (minLength) option removed from hts_QWindowTrim, but does not exist in hts_CutTrim

Commit 86c939a9095bc19c6053efd689da7635dbd001ce removes the option from hts_QWindowTrim, because we're now supposed to use hts_CutTrim instead, but hts_CutTrim does not have a minLength option, so we can now no longer filter by minimum length with the pipeline?

Hi @marade, there is now a new tool called hts_LengthFilter (https://github.com/s4hts/HTStream/tree/master/hts_LengthFilter) to take care of this step.

Ah good. Thanks for the assistance.

No problem, thanks for feedback!
The idea is that all length filtering can be handled by a single tool, so that statistics for this type of filtering are in the same place instead of spread across many different tools.


Fix documentation

Currently we aren't even building new docs.

product documentation:
As soon as the UI is in the final stage:

screenshots from the different forms and adding explanation to the different buttons to explain the functionality
record screencast as soon as all the functionalities are implemented so the user can get an idea how the websites works

From Spyros' message in Teams I understood that he and Katha are actually creating the video? I will ask him.

@chronark @JuliaSte seems like everything is fixed. Can I close this issue?

yes, I think so. Unless @chronark there's anything from your side why it needs to remain open.


Add support for: certspotter.com

curl -s "https://certspotter.com/api/v0/certs?domain=google.com"

For the use of certspotter third party sites, it is available.


Gradle package

Migration of https://github.com/michaellavelle/spring-data-dynamodb/issues/70

This library can be included in a gradle project by adding the following to the root build.gradle file. As of this writing there are releases hosted on Maven Central for versions 4.3.1, 4.3.0, 4.2.3, 4.2.0, and 1.0.5. The README.md could be updated to describe how to add the project as a gradle dependency.
repositories {
mavenCentral()
}
dependencies {
compile group: 'com.github.derjust',
name: 'spring-data-dynamodb',
version: '4.2.3'
}

Thanks for the details.
README.md got an update


Syncing to blockchain

Hi,
I created a lightning node on Digital Ocean and created the wallet on my i-Phone but it does not sync to the block chain. I am very sorry if this is not the forum to mention this problem but I am not sure where else to go.
Can someone please help
Regards
Wesley

Hey Wesley.
You can download Zap iOS that comes with a Lightning node inside the app. All the syncing can be done on your phone. If you head over to https://www.zaphq.io/download/ and download our Zap iOS / Mainnet / TestFlight app, that will allow you to test this feature

I have download the Mainet but it is the same as testnet🤷🏻♀

I have download the Mainet but it is the same as testnet🤷🏻♀


OVDB-96: CMake Memory Allocators

Add support for Jemalloc and TBB malloc and enable Jemalloc by default.
This seems to build for me on Linux and Windows fine. @jmlait - a quote from your chapter in "Multithreading for Visual Effects":

On platforms where linking to jemalloc is not practical, we resort to tbb::malloc_proxy.

Can you expand on this? Are there any platforms that you'd suggest we make TBB malloc the default? Also curious to know if there is any configuration in which Houdini is shipped without using Jemalloc?

When building for Houdini or Maya will this prefer the version of jemalloc or tbbmalloc that ships with the app?  If not, should it?

When building for Houdini or Maya will this prefer the version of jemalloc or tbbmalloc that ships with the app? If not, should it?

Yes, it should. I just added a change which sets the Jemalloc library directory path in OpenVDBHoudiniSetup.cmake so it will now prefer to pick it up from the Houdini install. TBB malloc was already being picked up from the Houdini install if USE_TBBMALLOC was set to on.
I also updated Circle CI to only install jemalloc for non-Houdini builds as well, just to be sure it doesn't fall back to the pre-installed version. I don't know about Maya.

This looks great, thanks @danrbailey. Do we have any more specific advice for choosing a mem allocator with vdb aside from "use a concurrent one" - i.e. none vs je vs tbb? Not part of this PR, but it would be great to run some tests and get some numbers out so we can support the recommendation.

This looks great, thanks @danrbailey. Do we have any more specific advice for choosing a mem allocator with vdb aside from "use a concurrent one" - i.e. none vs je vs tbb? Not part of this PR, but it would be great to run some tests and get some numbers out so we can support the recommendation.

I happen to have some benchmarks I ran recently. I did a very simple test case where I was comparing a vector of around 100 million or so "512 float" buffers to mimic the data storage in OpenVDB and attempt to isolate allocator performance (run across 24 logical cores):

Allocator
Allocate (seconds)
Deallocate (seconds)

glibc malloc (serial)
22.6
24.6

glibc malloc (parallel)
90.0
12.9

tbb malloc (serial)
8.33
31.5

tbb malloc (parallel)
2.73
15.4

je malloc (serial)
2.21
1.64

je malloc (parallel)
1.15
0.37

I haven't looked at any tuning, in particular jemalloc offers options to balance memory usage vs performance.
I think what surprised me most was how much the deallocation time varied. I ran an additional test with jemalloc allocating in serial and then deallocating in parallel (related to OVDB-93) and the deallocation time remained the same as the serial one. I'm still trying to understand what causes this. Right now, we always deserialize .vdb files in serial, so this is an interesting aspect to consider regarding how we do IO.

I happen to have some benchmarks I ran recently. I did a very simple test case where I was comparing a vector of around 100 million or so "512 float" buffers to mimic the data storage in OpenVDB and attempt to isolate allocator performance (run across 24 logical cores):

This is really interesting, thanks! Maybe even worth adding to the documentation, though perhaps we should do some more vdb specific testing first. Either way this definitely seems like enough of a reason to continue to default to jemalloc

Can you expand on this? Are there any platforms that you'd suggest we make TBB malloc the default? Also curious to know if there is any configuration in which Houdini is shipped without using Jemalloc?

JE Malloc is only used on Linux.   Windows uses tbb_malloc.  It is very hard to inject into the windows runtime to replace the system allocator.  TBB actually has to do some very suspicious binary hacking at the machine code level to replace the base allocator.  (And it is a patch that windows updates sometimes breaks...)  We've not managed to get such a patch for Windows.
We're also still running jemalloc 3.6.0.  I've tried several times to move up to 5.0, 5.1, and 5.2.  The problem is that the 5.X series uses lots of address space.  I've got nothing against this personally, it is a wise way to get faster performance with no significant cost (other than TLB allocation).  But users will freak out and submit bugs if the VIRT column of top goes to 128GB, even if it is only using 20GB of actual physical RAM.

I think I've addressed all the feedback now, let me know if there's anything else outstanding in this implementation.

I've just tried to run this on MacOS against Houdini 17.0.506 and immediately get the following error:
vdb_test(65605,0x1177d65c0) malloc: *** malloc_zone_unregister() failed for 0x7fff95729000
The last address doesn't seem to change.

I've just tried to run vdb_test on MacOS against Houdini 17.0.506 and immediately get the following error:
vdb_test(65605,0x1177d65c0) malloc: *** malloc_zone_unregister() failed for 0x7fff95729000
The last address doesn't seem to change.
Seems like a related issue here: facebook/rocksdb#1616 jemalloc/jemalloc#420
and the solution they went with: rust-lang/jemalloc#15

Thanks for highlighting this - I think the simplest solution is to default to using tbbmalloc on Mac, which would leave just Linux on jemalloc by default. I'll give that a go and verify that fixes this issue.

I've pushed a change to use TBB malloc on Mac and that seems to be working correctly now.

Re-tested on mac, looks good


Chocolatey package include license and verification

I forgot in #550 to add the VERIFICATION.txt and LICENSE.txt files, sorry about that.
That is why the 1.1.25 package failed validation on chocolatey.org.
Feel free to adjust the wording in the verification file.
For more information on why these are required see:
https://docs.chocolatey.org/en-us/community-repository/moderation/package-validator/rules/cpmr0005
https://docs.chocolatey.org/en-us/community-repository/moderation/package-validator/rules/cpmr0006

Perfect, thank you!
To be honest, it's a good thing that the Chocolatey package for the last release failed: I had to pull the release, and couldn't find a good way of unmarking a particular release on Chocolatey.

To be honest, it's a good thing that the Chocolatey package for the last release failed: I had to pull the release, and couldn't find a good way of unmarking a particular release on Chocolatey.

Since the testing failed, and assuming you don't re-push a fixed package it will automatically get rejected in a couple of weeks. Or you can ask for it to be manually rejected by adding a review comment.
If the testing had passed, and the package is trusted, (which synctrayzor is), then it would get shown to people, but you could have manually unlisted it by clicking the delete package button and then unlisting.


feat(tutorial): complete step 1

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@ASEIDEL77 Looks great 💯 ! I've recorded your completion of step 1.
And thanks for your help with hands-on facilitation! 🎉


Move critical info pages about CC licenses and legal tools from wiki to main website

We have several important pages that are fundamental to how our legal tools operate, that at the present are hosted on the wiki and not on the main website. This is problematic because their presence on the wiki suggests they are not official interpretations or documentation regarding how the licenses are to be interpreted, the status of tools, and similar. Ideally, we have one or more pages from which all of this important information can be found, including information about translations, ported licenses, retired licenses, the license version page, the page that explains the differences between all of the licenses, and all of the FAQs for the licenses and the public domain tools.
I volunteer to assist with this effort, but it likely involves the Comms team (and most absolutely the Tech team).

A


Generalize to workers

Codecov Report

Merging #19 (008ae20) into main (fc64b0a) will decrease coverage by 8.49%.
The diff coverage is 80.08%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   96.50%   88.02%   -8.49%
==========================================
  Files          20       28       +8
  Lines         686      935     +249
==========================================
+ Hits          662      823     +161
- Misses         24      112      +88

Files Changed
Coverage Δ

src/Autodiff/autodiff_unwrap.jl
100.00% <ø> (ø)

src/FerriteAssembly.jl
100.00% <ø> (ø)

src/ItemBuffers/FaceBuffer.jl
0.00% <0.00%> (ø)

src/Utils/scaling.jl
100.00% <ø> (ø)

src/Utils/utils.jl
100.00% <ø> (ø)

src/DomainBuffers.jl
71.73% <71.73%> (ø)

src/Multithreading/TaskChunks.jl
73.33% <73.33%> (ø)

src/setup.jl
81.25% <80.64%> (-14.28%)
:arrow_down:

src/LoadHandler/FerritePR495.jl
85.29% <85.29%> (ø)

src/ItemBuffers/CellBuffer.jl
96.07% <94.28%> (ø)

... and 13 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


File Manager

Task: https://github.com/AlreadyBored/nodejs-assignments/blob/main/assignments/file-manager/assignment.md
Completed 2022-06-11 / Deadline 2022-06-12 23:59:00 +0300
Score: 100%

If command arguments contain spaces they should be quoted using single or double quotes, e.g.
> cp './Downloads/file with spaces.jpg' ./Desktop

# or

> rn "./My Documents/todo.txt" "thigs to ignore.txt"

Basic Scope

General

[x] +6 Application accepts username and prints proper message -+10 Application exits if user pressed ctrl+c or sent .exit command and proper message is printed
Operations fail
[x] +20 Attempts to perform an operation on a non-existent file or work on a non-existent path result in the operation fail
[x] +10 Operation fail doesn't crash application
Navigation & working directory operations implemented properly
[x] +10 Go upper from current directory
[x] +10 Go to dedicated folder from current directory
[x] +10 List all files and folders in current directory

Basic operations with files implemented properly

[x] +10 Read file and print it's content in console
[x] +10 Create empty file
[x] +10 Rename file
[x] +10 Copy file
[x] +10 Move file
[x] +10 Delete file

Operating system info (prints following information in console) implemented properly

[x] +6 Get EOL (default system End-Of-Line)
[x] +10 Get host machine CPUs info (overall amount of CPUS plus model and clock rate (in GHz) for each of them)
[x] +6 Get home directory
[x] +6 Get current system user name (Do not confuse with the username that is set when the application starts)
[x] +6 Get CPU architecture for which Node.js binary has compiled

Hash calculation implemented properly

[x] +20 Calculate hash for file

Compress and decompress operations

[x] +20 Compress file (using Brotli algorithm)
[x] +20 Decompress file (using Brotli algorithm)

Advanced Scope

[x] +50 All files operations with reading/writing should be performed using Streams API
[x] +20 Codebase is written in ESM modules instead of CommonJS
[x] +20 Codebase is separated (at least 7 modules)

Sorry forgot to make repo public
https://github.com/TSepron/File-Manager/pull/1
now ok


Add explanation for canonical form different uses for 'simple' and 'full' canonical forms.

created by @dimus at https://gitlab.com/gogna/gnparser/-/issues/44
Related to https://github.com/GlobalNamesArchitecture/gnparser/issues/480

Not an issue but a question.  I want to correctly explain the origin of the term "canonical name" before using it in a text.
AFAIK, canonical means "according to laws or rules". But here the word is used in other sense (just obviating the authorship, year and other annotations ... and keeping latin name and epithets).
A "canon*" word search of IAPT nomenclatural code, returns only one entry. And it refers to religious canonizations of authors (see art. 60C.4.d).
So what is the origin of the expression "canonical form/name" applied in the sense used here?

I see it used in TNRS (2013) for the first time.
gnparser (2017) paper explains a little more (We refer to the form of the scientific name without authority or annotations as the “canonical form”).
It is also defined in globalnames glossary: "The canonical name is comprised of the latinized elements of a scientific name."

But none of them is citing where the term came from (I mean, who made the decision of calling that "canonical name" for the first time).
Was the term applied in this sense to biological names, somewhere else before that TNRS paper?
Thanks!

I am not sure who came with the canonical name term first. Paddy Patterson defines it like
Canonicalization. Canonicalization, the removal of spurious elements from name-strings
to leave the Latinized elements
in
Patterson D, Mozzherin D, Shorthouse D, Thessen A (2016) Challenges with using names to link digital biodiversity information. Biodiversity Data Journal 4: e8080.
doi:10.3897/BDJ.4.e8080


Unexpected behaviour

Auto focus not working
Keyboard open without reason in the next page

Pinput(                 androidSmsAutofillMethod:                     AndroidSmsAutofillMethod.smsRetrieverApi,                 controller: otpController,                 autofocus: true,                 length: 6,                 autofillHints: const [AutofillHints.oneTimeCode],                 defaultPinTheme: defaultPinTheme,                 focusedPinTheme: focusedPinTheme,                 submittedPinTheme: submittedPinTheme,                 validator: (value) {                   if (value!.length != 6) {                     return "Invalid OTP";                   } else {                     return null;                   }                 },                 pinputAutovalidateMode: PinputAutovalidateMode.onSubmit,                 showCursor: true,                 onCompleted: (pin) => handleSubmit(context),                 onSubmitted: (value) => handleSubmit(context),               )
untitled.webm

Hey @swarupbhc, could you provide the result of the flutter --version command? Is Pinput child of the StatelessWidget?

On Tue, 7 Mar 2023 at 6:56 PM, Tornike @.***> wrote:

Hey @swarupbhc https://github.com/swarupbhc, could you provide the
result of the flutter --version command? Is Pinput child of the
StatelessWidget?
—
Reply to this email directly, view it on GitHub
https://github.com/Tkko/Flutter_Pinput/issues/129#issuecomment-1458170056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANGUNGZWZPYWNACN3AZN2CLW24ZRBANCNFSM6AAAAAAVROJFMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Flutter version - 3.7.6 stable.
Yes it’s hookconsumerwidget (StatelessWidget)

If you are passing the controller it Pinput should be inside the StatefullWidget, because you have to dispose the contoller.
Try to replace hookconsumerwidget and let me know if it works

Closing the issue for now, feel free to reopen if needed.


@fumari/json-schema-to-typescript cyclic reference bug

To Reproduce
Since issues are disabled on fuma-nama/json-schema-to-typescript, I'll post this here.
I'm having a similar issues to here with<EMAIL_ADDRESS>The resulting OpenAPI JSON fails to be parsed and results in a maximum call stack size exceeded error when there are cyclic references like the one below:
"Butler_API_Entities_Project": {
  "type": "object",
  "properties": {
    "slug": {
      "type": "string"
    },
    "owner": {
      "type": "string"
    },
    "parent_project": {
      "$ref": "#/components/schemas/Butler_API_Entities_Project"
    },
    "name": {
      "type": "string",
      "description": "Project Name"
    },
  },
}

As you can see the parent_project property doesn't have any other fields, but the cyclic reference still rbeaks the build with the "max call stack size exceeded" error :thinking:
I'm using:
"fumadocs-core": "14.4.0",
"fumadocs-mdx": "11.1.1",
"fumadocs-openapi": "^5.5.10",
"fumadocs-twoslash": "^2.0.1",
"fumadocs-ui": "14.4.0",

There is a simliar issue in the parent repository to your fork that yuo might be aware of here.
Current vs. Expected behavior
Parse openapi spec JSON successfully
Provide environment information
Node.js v22.10.0

Operating System:
  Platform: linux
  Arch: x64
  Version: #1-NixOS SMP PREEMPT_DYNAMIC Fri Nov  1 01:02:44 UTC 2024
  Available memory (MB): 32026
  Available CPU cores: 12
Binaries:
  Node: 22.10.0
  npm: 10.9.0
  Yarn: N/A
  pnpm: 9.3.0
Relevant Packages:
  next: 15.0.3 // Latest available version is detected (15.0.3).
  eslint-config-next: N/A
  react: 18.3.1
  react-dom: 18.3.1
  typescript: N/A
Next.js Config:
  output: N/A

I've worked around it so far by just dropping self-referencing properties in the effected entities before passing the json file to fumadocs-openapi's generateFiles as input.
delete swaggerContent.components.schemas.Butler_API_Entities_Project.properties.parentProject

Which area(s) are affected? (Select all that apply)
Integrations (e.g OpenAPI, Typescript DocsGen)
Additional context
No response

Didn't have much time to work on the fork, I will look into that later.

Also if you don't mind, you can disable it as a temporary fix:
export const openapi = createOpenAPI({
  generateTypeScriptSchema: false,
});

As the linked issue said

I cannot seem to reproduce the problem, make sure to upgrade to `5.7.4 and provide more details (e.g. the OpenAPI schema or a GitHub repo)

Note it could also be a problem when sampling example response.
For example, if you made parent_project a required field, it will be forced to create parent_project for every new sampled parent_project, causing a similar problem. In this case, it has to be optional.

I've bumped to 5.7.5 and I'm still seeing the same result. Unfortunately the parent_project field doesn't seem to be listed as required either. For example, the whole Butler_API_Entities_Project schema:
{
  type: 'object',
  properties: {
    slug: { type: 'string' },
    owner: { type: 'string' },
    parent_project: { '$ref': '#/components/schemas/Butler_API_Entities_Project' },
    name: { type: 'string', description: 'Project Name' },
    description: { type: 'string', description: 'Project Description' },
    repository_id: { type: 'string', description: 'Repository' },
    code_repository_id: { type: 'string', description: 'Code Repository ID' },
    created_at: { type: 'string' },
    updated_at: { type: 'string' }
  },
  description: 'Butler_API_Entities_Project model'
}

Could you provide a reproduction?

thanks for the info! I think I've found the problem now,  json-schema-to-typescript relies on $ref property but Fumadocs OpenAPI always use a dereferenced schema for everything, need some refactoring but will fix that soon

To fix it, you can add title to the schemas, which will work better as the latest fix will infer it from ref id, resulting a type name like interface Butler_API_Entities_Project

What do you mean by "add title to the schemas" exactly?

{
  type: 'object',
  title: 'Project',
  properties: {
    slug: { type: 'string' },
    owner: { type: 'string' },
    parent_project: { '$ref': '#/components/schemas/Butler_API_Entities_Project' },
    name: { type: 'string', description: 'Project Name' },
    description: { type: 'string', description: 'Project Description' },
    repository_id: { type: 'string', description: 'Repository' },
    code_repository_id: { type: 'string', description: 'Code Repository ID' },
    created_at: { type: 'string' },
    updated_at: { type: 'string' }
  },
  description: 'Butler_API_Entities_Project model'
}

Ahh okay gotcha. Not sure why exactly that works, but it did the trick haha
https://gitbutler-docs-git-ndom91-fumadocs-openapi-fix-gitbutler.vercel.app/api-reference/user#get-user

Because title is  used as an id to detect cyclic references when the schema is dereferenced, going to release the fix together with OpenAPI 3.1 support.


[5.0] Update SqlServerProcessor.php

Correction from the bug https://github.com/laravel/framework/issues/8740

We'll need more verification from SqlServer uses that this doesn't break their code.

I changed this file in my project and it worked very well, I've been tested in two versions of sql server. Sql server 2012 and sql server 2004.
I tryed to insert in a table without trigger and worked very well to!
I hope this file can be changed, because the bug is not in laravel, but in PDO linux driver. The PDO driver from microsoft it works fine, but only in windows.

Closing due to lack of community feedback.

Changes Unknown when pulling 41dd63289f14410116afea91c845c71933b6da10 on andersonef:patch-1 into ** on laravel:5.0**.


UIShell - Header: Incorrect hamburger icon

Hi,
Our UX team is pointing that the hamburger icon that is used here is incorrect, it should be one with the 4 lines like this:

Thanks.

This should be an easy change ... would you like to contribute the fix @dsuwirya?

@cal-smith, I'd love to, but seems to be a lot of steps I need to do in order to contribute ? or is there any much easier/shorter step to be able to contribute ? thanks.

@cal-smith, another question, is there any reason why you're not using icon from @carbon/icons-angular and using the svg directly here ?

I'd love to, but seems to be a lot of steps I need to do in order to contribute ?

The quickstart is only 4 or 5 short steps 🙂 I encourage you to give it a try! (no pressure though!) https://github.com/IBM/carbon-components-angular#quickstart

is there any reason why you're not using icon from @carbon/icons-angular and using the svg directly here ?

In short - no. The component was written before that icon was available, for the updated we'd definitely want to switch to the one provided by @carbon/icons-angular


Tab not showing hidden directories with globdots enabled

Hi!
After updating to v0.5.0, tab completion doesn't show hidden directories. I tested with v0.4.3 and it works as expected.
Minimal .zshrc:
setopt globdots
source ~/.zsh/zsh-autosuggestions/zsh-autosuggestions.zsh

Hi @hectorhuertas, are you using setopt autocd? Can you post an example of what you have typed into the buffer when tab completion fails? This may be a dup of #379.

@ericfreese I've updated the issue with more details. autocd doesn't seem to make a difference. However, adding ZSH_AUTOSUGGEST_IGNORE_WIDGETS+=(expand-or-complete) to .zshrc as #379 suggests fixes the problem. Feel free to close this one if you think it's duped.

Merged that PR. Closing this issue. Let me know if you're still seeing the issue on develop branch.

Tried with the develop branch and it works great. Thanks!


Add .NET Core to the API

Here's the Github Repository
https://github.com/dotnet/core

Thanks, that's a great suggestions.
What do you think the slug should be? Maybe dotnet, as in https://verse.pawelad.xyz/projects/dotnet?

Hi, Yeah! That would be great.

Sorry for the late reply, I'll try to find some time for this on the weekend.


test task call processing

don't merge

Add a test for this change to the regression suite as well, please.


[meta] Add Robin Kertels to LICENSE file

As suggested by Misyl on Discord

I'll merge after we merge D3D8, so save Jeff the pain of rebasing for a license change :-)

Finally 🎉 🐦 🎉

can u rebase

done


clear references to classic editor

          > I vote for redirecting “/classic-editor” to “/editor” and renaming “/advanced-editor.md” to just “/editor.md" - @byemc

me too, ill send a PR in
Originally posted by @lxjv in https://github.com/neatnik/omg.lol/issues/611#issuecomment-1445381061

Probably should track here until someone gets around to that (too busy procrastinating, sorry)

Maybe /classic-editor could show something like
The classic web editor has been shut down. Please use the new [web editor](/editor) instead.

/classic-editor now redirects to /editor, so I think we're good now.

waiting for the omg.lol “bring back classic editor” chrome extension for some reasonSent from my iPhoneOn 26 Feb 2023, at 17:12, Adam Newbold @.***> wrote:
/classic-editor now redirects to /editor, so I think we're good now.
—Reply to this email directly, view it on GitHub, orYou are receiving this because you authored the thread.Message ID: @.***>


Multiplayer connectivity issues re: Data Serializers

After an extensive conversation with Gigaherz and modifying my own mod (which used a custom data serializer):

Registering it statically in the static init of the entity class can cause a race condition where the serializer isn't properly registered, resulting in people suffering from difficulty connecting to servers, especially when they're connecting to near a swampy area.
I'm really looking forward to playing around with this mod, unfortunately I've had to remove it from the server for now.

Thanks again for your help!
I've handled the situation by replacing the long with a string since looking back at it, it wasn't really worth adding a whole new data serializer for that and string is just the easiest to implement.
(I know that a new data serializer would've been the cleanest way to do that, but I really don't want to get more bugs into this just for one small class.)


Publish to npm?

Until this is included in core, and until people move to the latest version of RN, can you publish a new version so we can use the latest changes?

+1

+1

+1

I published the latest code to<EMAIL_ADDRESS>


Enable querying of multiple genes in Bgee API

Description:
This pull request adds the ability to query multiple genes at once using the Bgee API. I've updated the bgee_expression function and adjusted the tests and documentation accordingly.
Issue:
Fixes #163
Additional Notes:
I also noticed that the Bgee API allows additional parameters for filtering. Please let me know if you'd like me to add more arguments to further enhance the functionality.

Hi Katerina, thank you so much! I'll merge this into dev soon so it can be part of the next release (and I'll add you as a co-developer to the docs). If you could incorporate the additional arguments that would be awesome! Please make sure to also update the arguments in the main.py file for use from the terminal. :)


bib failed to build out config.toml with customizations.filesystem.mountpoint

step 1 create one config.toml with customization.filesystem as below:

[root@xx tmt]# cat /var/lib/libvirt/images/config.toml
[[customizations.filesystem]]
mountpoint = "/"
minsize = "10 GiB"

[[customizations.filesystem]]
mountpoint = "/var/data"
minsize = "20 GiB"

step 2 , run bib to generate image, but throw error as below:
(92lts-p3-ve) [xx]# sudo podman run --rm -it --privileged --pull=newer --security-opt label=type:unconfined_t -v /var/lib/libvirt/images/output:/output -v /var/lib/libvirt/images/config.toml:/config.toml   -v /var/lib/libvirt/images/auth.json:/run/containers/0/auth.json  quay.io/centos-bootc/bootc-image-builder:latest  --type vhd --tls-verify=false  --config /config.toml  quay.io/fedora/fedora-bootc:latest  --rootfs xfs
Generating manifest manifest-vhd.json
2024/09/24 09:08:34 error: cannot build manifest: cannot read config: cannot decode "/config.toml": unknown keys found: [customizations.filesystem.mountpoint customizations.filesystem.minsize customizations.filesystem.mountpoint customizations.filesystem.minsize]

I can reproduce and know what the issue is, it's a regression from https://github.com/osbuild/bootc-image-builder/pull/549 - it's not yet clear what the best fix but I'm on it

The underlying issue is https://github.com/osbuild/images/pull/951 - this needs some tweaking/thinking, we should probably do a quicker fix (by disabling the meta.Undecoded() check) short term as this is a rather big regression :/
Thanks for catching/reporting this!


Implement a basic test suite with rspec + factory_bot

This is far from complete, but I wanted to submit now to get some other eyes and feedback on this so far.

Added rspec and factory_bot
Basic factories
Simple model tests: factories are valid, required associations are present, required fields are present
Controller tests for GET projects#index and GET projects#show but nothing else yet

A good test suite will make it a lot easier for others to contribute if they don't have to worry about breaking anything.
Next steps

Setup CI -- any preference? Circle, something else?
Test everything else
Cleanup the jank

This is awesome. Will look over it tmr. @OrlandoLee @adrianthedev if you want to check it out please give it a go!

I switched from test::unit/minitest to rspec, so I also removed the test/ scaffolds in favor of spec/. We can do system tests w/ rspec, I agree would be great to add

I've added more scaffold and TODO tests, and implemented tests for everything in AdminController
I've also gotten the build working on CircleCI: https://circleci.com/gh/jamiew/covid-volunteers/tree/rspec
I'd venture this is good enough to merge, since any tests are better than no tests.


ISSUE:

Added Login and SignIn links in header in components/Header

Pull request merged

This is an automated message from devgallery.io [BOT].

Thank you for your contribution! Your pull request has been merged and your name has been added to the List of Contributors in README.md.
Please leave a star if you enjoyed working on this project.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects here.


vue create doesn't allow upper-case letters

In v3.0, I tried to create a project with name "VueApp" like below:
vue create VueApp

It complains: "Invalid project name". But name "vueapp" goes without an error. Also, vue ui allows capital letters; I was able to create a project with name "VueApp".

Yes, I have this problem too please check this I should use client-app instead of ClientApp. it is ridiculous.
After creating I should transfer the whole project to a new folder I want.

https://github.com/vuejs/vue-cli/issues/2547#issuecomment-422382882

It would be nice to make it possible to have a project directory with Camel Case name.


Added Jadwiga Lublin

Hello, please add High School in Lublin to authorized domains.

@wojtokuba Pull request merged. Thank you!


BWM support.

If you have  Hardcore trees on vanilla trees spawn with a 'stump'. Currently these being broken don't trigger the tree falling. Would it be possible to add support for this?

I guess they aren't considered logs...hmm


FailMasterPromotionIfSQLThreadNotUpToDate not working in coMaster setup

I've been trying to use "FailMasterPromotionIfSQLThreadNotUpToDate": true and wondering why it is not working like I expected.
It looks like that config option is only checked in the checkAndRecoverDeadMaster function, and not in checkAndRecoverDeadCoMaster. We use coMaster replication, so mystery solved, I think.
I'd be happy to open a PR adding check for FailMasterPromotionIfSQLThreadNotUpToDate to checkAndRecoverDeadCoMaster function, but before doing so: is there a reason for this behavior and I'm just not seeing it?

There is no intended reason. I'm happy for a PR.


Gradientiser- a  CSS gradient generator web app

Hey Eddie,
I am Nirbhay Parmar, I attended your live workshop on Girlscript foundation's YouTube channel, and today I am selected as a participant in Girlscript summer of code 2021. Thank you for
your workshop.
This is the link to my repo- Gradientiser
Check it live here.
And i also want to know that is my project is worth it as open-source or i should say is useful to anyone because there are many websites out there having lot more features then my project.
Please give your opinion on the usefulness of this project.

Thank you for sharing 👍 . I will review on a live stream / video soon 🤓

Make it open source 🚀

It is already open source. I have also added MIT license to it.

Reviewed on live stream https://youtu.be/MrS_jAJ8l0o
Looks good 👍 , some thoughts
repo

screenshot in the readme would be great
use repo description near live demo link
recommend being consistent with file naming conventions, some have - some are camelcase
suggest having a code of conduct, more info found in insights tab https://github.com/Nirbhayparmar/gradientiser-BgGenerator/community
using issues will help get more people involved in your project

live demo

have the text with a background because with some colours it is difficult to read
code to be in a code block would be much clearer

Thank you so much @eddiejaoude for reviewing my project and also thanks for your suggestions. Surely work upon this.


More control over ansible-galaxy flags / args

Usually I keep the roles dir for my own, and resolve dependencies to role-deps, e.g. like that:
$ rm -rf role-deps
$ ansible-galaxy install -r requirements.yml -p role-deps -f -vvv

Would be nice if molecule would give more control over the ansible-galaxy flags / args, so we have more control where the dependencies are resolved.
Another example would be adding the --ignore-certs flag, which is kind of mandatory to make galaxy work behind a proxy, etc..

Wondering: are there maybe some specific ANSIBLE_GALAXY_* env vars that we could pass in via raw_env_vars in the meantime?

At least galaxy's --ignore-certs can be controlled via an env var:
https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py#L297
For the -p flag in ansible-galaxy install (= roles path where they are downloaded to) I don't see a specific env var though

For the -p flag in ansible-galaxy install (= roles path where they are downloaded to) I don't see a specific env var though

You can specify that in your requirements.yml.
- src: https://github.com/geerlingguy/ansible-role-nfs
  version: 9c09e8e
  name: geerlingguy.nfs
  path: roles/

@retr0h yes, I tried that, but looks like the path setting is ignored. This is Ansible <IP_ADDRESS>.
My requirements.yml says "role-deps":
- name: timezone
  src: yatesr.timezone
  path: role-deps/

Still they are downloaded to "roles":
...
--> Installing role dependencies ...
- downloading role 'timezone', owned by yatesr
- downloading role from https://github.com/yatesr/ansible-timezone/archive/1.0.0.tar.gz
- extracting timezone to ./roles/timezone
- timezone was installed successfully
--> Starting Ansible Run ...
...

looks like this was removed with Ansible 2.0... :-/
https://github.com/ansible/ansible/issues/13563#issuecomment-165482301

One more thing I noticed:
ansible:
  raw_env_vars:
    ANSIBLE_GALAXY_IGNORE: True

This config is not effective for ansible-galaxy, only for ansible-playbook
However, ANSIBLE_GALAXY_IGNORE=True molecule test correctly passes the env and makes it work behind a proxy


optimize optimize the data type of table information_schema.rowsets

Proposed changes
Issue Number: close #xxx
The original data type of column CREATION_TIME and NEWEST_WRITE_TIMESTAMP in table information_schema.rowsets is bigint, which is not read friendly，change to DATETIME is more reasonable, and we can use time range to filter data more easily:
select * from information_schema.rowsets where CREATION_TIME > '2024-05-10 00:00:00'

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run p0

run p0

run buildall

run buildall

run feut

run cloud

run performance

run cloud_p0

run performance

run p0

run buildall

run performance

run performance


Bug Report: Show Distance on Name Plates

Show Distance on Name Plates check box does not work. Will send an error in logs.
This is in version: V<IP_ADDRESS>

Ya, nameplate stuff in ClientStructs needs to be updated for patch 6.3.  It's being worked on, but there were a lot of changes to the game with this patch, and nameplates tend to be lower priority I think than the dependencies of more widely-used plugins.  One of the CS maintainers said that he'd look into it even though he's on vacation, so I'm certainly not going to complain.
Anyway, sorry for the trouble, but at this point, nameplates should probably just be assumed broken after patches, since those structs seem to change half the time.

ClientStructs has been updated, and nameplates work again.


Remove GUI section

This removes GUI resources and structure from the
code base, as this is being migrated and restructured to a different repository (and going in a different design direction)
Closes #75

Going to merge this one myself as it's a very simple change (deleted files only)


Only highlight funLoc for document highlight

Motivation

The current document highlight highlights way too much of the screen when you
put your cursor anywhere inside a method.
Test plan

before

after

There the fact that this didn't cause any tests to fail is a little surprising. It does look like there are two test files that were added in https://github.com/sorbet/sorbet/pull/2105 when the document highlight feature was added, but both of those tests only use the existing def/usage assertions that things like jump-to-def and find-all-refs use.
That's probably why this feature hasn't been graduated out of the experimental features, and I don't really want to change that right now. I just want https://sorbet.run examples to not suffer from this bug.


Introduced SwiftLint #trivial

Replaces #642
Issue ref: #394
Integrates SwiftLint into DangerBot.
You may want to append a ?w=1 to the end of the files-changed url to exclude whitespace-only changes.
Should be good to go -- failing due to no changes to CHANGELOG.md. I don't believe white space is enough reason to add to the change log.

Thanks @heshamsalman ! 💯

Why was this closed?

ah i see #681


Make reference.conf

This is Marco's idea, I believe, and this is here to ensure that the good idea is not forgotton...
Is this change below still in the works?
"One thing I would like to do is to store all the config defaults in a file called reference.conf instead of hardcoding them in EidosSystem. This would allow us to use variables even in the defaults. An explanation of the utility of a reference.conf can be found here: https://github.com/lightbend/config#standard-behavior    Basically, scala-config reads the variables from several sources, each with lowest priority, and leaves reference.conf as the last option, which is intended to be the library defaults."
Becky just made a very nice Ontology cache, but part of it involves duplicating code like
val unOntologyPath: String = getArgString("EidosSystem.unOntologyPath", Option("/org/clulab/wm/eidos/ontologies/un_ontology.yml"))
which your proposal will make unnecessary.  So, it might be nice to add this in the nearer future.  I'm going to at least add a note to the PR as a reminder.

is this closed with PR #428 ?

Yes.


How to handle jobs that return values?

Sorry in advance if this is already documented somewhere, can't find it yet.
I have functions that return values, and I'm struggling to see how to factor that into the way you schedule and run jobs with this library.
Example, a function called getData() that does a API get request, and returns a variable called data
Then a function called processData(data) that takes the data and does something with it.
In my example, I'd like to only run getData() once every 48 hours, but I need to run processData(data) every hour. (The reason for this is that the data feed via API doesn't refresh very often, so I don't need to call it every hour).
I see the syntax for defining the scheduling parameters be:
schedule.every(48).hours.do(getData)
schedule.every(1).hours.do(processData)

but how do I handle the data variable returned by getData()
All the examples I've found so far with schedule are jobs that don't return values.
If I need my jobs to share data with each other, maybe I need to use global variables?
Any help much appreciated, thanks.

One way to get around of this is the function access the outer scope (such as the global scope)
getData could access a variable to update it's value, and processData could do the same to read this value. With a 'wrapper' of any kind (a dict, list or class), you can do this with less chance of messing with references.
See an example:
`import schedule
class Wrapper:
value = None
data = Wrapper()
def getData():
print("Getting new data...")
data.value = 'the new data'
def processData():
print("I'm processing... current value:")
print(data.value)
schedule.every(8).seconds.do(getData)
schedule.every(5).seconds.do(processData)`

yup, this type of wrapper worked for me and it is a good thing to have. I have significantly more complex scenario with, rpc, statemachine, scheduler, and multi processing but at the end I got result of operation finally back to caller ...
thanks for the hint ...


Installation error callback() can only be called once.

I'm getting the following error when running sudo npm i -g preact-cli. I've also tried different node / npm  versions with no luck (I was getting #73).
/usr/bin/preact -> /usr/lib/node_modules/preact-cli/lib/index.js

><EMAIL_ADDRESS>install /usr/lib/node_modules/preact-cli/node_modules/fsevents
> node install

><EMAIL_ADDRESS>postinstall /usr/lib/node_modules/preact-cli/node_modules/simplehttp2server
> node lib/install.js

/usr/lib/node_modules/preact-cli/node_modules/each-async/node_modules/onetime/index.js:15
				throw new Error(fnName + ' can only be called once.');
				^

Error: callback() can only be called once.
    at onetime (/usr/lib/node_modules/preact-cli/node_modules/each-async/node_modules/onetime/index.js:15:11)
    at /usr/lib/node_modules/preact-cli/node_modules/download/index.js:156:5
    at ConcatStream.<anonymous> (/usr/lib/node_modules/preact-cli/node_modules/concat-stream/index.js:36:43)
    at emitNone (events.js:110:20)
    at ConcatStream.emit (events.js:207:7)
    at finishMaybe (/usr/lib/node_modules/preact-cli/node_modules/readable-stream/lib/_stream_writable.js:607:14)
    at endWritable (/usr/lib/node_modules/preact-cli/node_modules/readable-stream/lib/_stream_writable.js:615:3)
    at ConcatStream.Writable.end (/usr/lib/node_modules/preact-cli/node_modules/readable-stream/lib/_stream_writable.js:571:41)
    at DuplexWrapper.onend (/usr/lib/node_modules/preact-cli/node_modules/readable-stream/lib/_stream_readable.js:570:10)
    at Object.onceWrapper (events.js:314:30)

Tested on the latest versions of node (8.1.3) and npm (5.0.4).
I'm running Arch Linux.

It actually belongs to GoogleChrome/simplehttp2server#31, but I'd leave this open for a while, maybe someone has an idea or maybe it's an environment related issue.

I'm having the same problem in Arch Linux too.

I also had this problem, it's a permissions problem somehow.
So i fixed it by changing my global modules folder to be in my home folder, so do not need to use sudo
https://docs.npmjs.com/getting-started/fixing-npm-permissions

I confirm, that resolves the issue :+1:

I run the npm via sudo - the problem still there.
I am running Ubuntu Mate 17.04

@joelchu Try to install without sudo...
Just type npm i -g preact-cli is ok.
Env: npm: v5.3.0, node: v8.5.0

witthout sudo it won't even run.
Because I am not changing the folder permission just because of node.js
so it's stock option.
Why can't they just do standard stuff. angular react don't have problem with standard cli installation.

Running with sudo gives callback() error
Running without sudo gives EACCES error

Had this issue with WSL on one of my work laptops and Option 2 from https://docs.npmjs.com/getting-started/fixing-npm-permissions fixed it for me.

I still getting errors even I run with sudo. When I try running with sudo -s and It worked.


Add AutomationProperties page

Description

This PR will add a page containing samples around AutomationProperties, which are useful (and needed) to write accessible XAML.
Motivation and Context

Closes #199
How Has This Been Tested?

Tested manually by starting application.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

The only thing we may want to change is the category where AutomationProperties show up. Right now this page is in Basic Input, which doesn't seem quite right. Maybe Status and Info or Styles would make a better home?

This was something I though about too. My though was that accessible UI should be a basic duty for developers and nothing that should be seen as "special" or optional. But since it is not an input, I think "Status and Info" or "Styles" are better. I would think, "Status and Info" might be the best choice. I can update the PR with the best fitting category if you want.
On a different thought, could we even create a new category "Accessibility" for more sample pages to come?

On a different thought, could we even create a new category "Accessibility" for more sample pages to come?

Yes, that's also a good option that would further elevate Accessibility and hopefully draw more attention to the topic. Having only one page in a category isn't great, but maybe that will motivate us to add more pages 😊

For now I move it into the "Status and Info" for now. Having a category with only one element in it feels a bit weird, but if you think we should do this with this PR I would be happy to do that :)


Use contexts in place of builder prop drilling

Many places in the application use prop drilling to pass the values, we need to change this to make use of Context API
To explore one such example view ToolbarItem component


Update Rocket dependency to version 0.2.0

I'm trying to use this library with Rocket, so I updated the dependency to version 0.2.0.

Thanks, didn't realize Rocket 0.2 was released already.
Is there a way to declare support for both versions 0.1 and 0.2 simultaneously? That should ease the transition path for those still on Rocket 0.1.

I think <=1.2 should work, per http://doc.crates.io/specifying-dependencies.html

I'd prefer >= 0.1.2, < 0.3 instead since that keeps the lower bound

Changed to lfairy's suggestion.

Looks good, thanks!

Released as 0.16.1.

Thanks, I'll start using this then 👍


Use hyphens for urls consistently throughout the site

Slugs have started using hyphens, other links can follow suit

@remomueller Would you mind doing this together Monday morning? It looks like there are a few deprecated routes we can get rid of, but it would be nice to discuss the intricacies of using routes in rails!


Google Pay button breaks with a stack trace when buttonType = (anything other than 'buy')

Describe the bug
Sorry I'm not sure if this is the right repo to report this but it's the closest I can find.
We use the Google Pay React button library in our project. Today we received reports our checkout was broken. Upon investigation we discovered that the "buttonType" property is causing an issue.
If a site specifies a buttonType that is anything other than "buy", pay.js will throw an exception and cause an error. In our situation the page became stuck and unresponsive. Once I removed this property and allowed the default, it worked again.
I can reproduce this on the Google demo site.
To Reproduce

Go to 'https://developers.google.com/pay/api/web/guides/resources/customize'
Observe a Google Pay button is shown
Click the "buttonType" and select some other value than "buy"
Observe the button disappears and a stack trace is shown in the developer console

In this stack trace example I changed the buttonType to "donate" and it seems it is trying (and failing) to read a property of that string value.
pay.js:275 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'donate')
    at m.pa (pay.js:275:150)
    at m.pa (pay.js:286:382)
    at l.<anonymous> (index.umd.min.js:15:4764)
    at Generator.next (<anonymous>)
    at index.umd.min.js:15:692
    at new Promise (<anonymous>)
    at e (index.umd.min.js:15:437)
    at l.updateElement (index.umd.min.js:15:4150)
    at l.configure (index.umd.min.js:15:2849)
    at index.umd.min.js:15:8645

Expected behavior
It works as we would expect
Component information:
At least the pay.js component.
Environment:
Reproduced on Chrome for Windows, Chrome for Android and Chrome for iOS.

I have the same issue ! there is a problem inside pay.js

Same issue, reverting to logo-only for now but since 11pm last night we've not been able to take GPay payments because of the button not rendering with 'donate' or 'pay'. We haven't done a release, this appears to be an issue with externally-hosted pay.js.

Same here, the only options that work for me are buy, plain, short and long

Same here.

Same here
Is there a way to catch the error and hide the button?

Same for us, is there any way to load some exact version of pay.js?

Same here.  If I revert button type to "buy" as mentioned above then it works although we prefer the "pay" option

The Google demo site is working again, I assume the underlying issue was fixed?


darwin.linux-builder: set NIX_PATH nixpkgs to pkgs.path

Description of changes
When using the darwin linux builder on macOS, the $NIX_PATH is not set inside of the virtual machine, meaning nix-shell and others fail. Setting the nix.nixPath like this, would fix that.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

It's not meant to be used interactively - just a remote builder. It does not need to evaluate anything, so it doesn't need any NIX_PATH, registry or whatsoever.
Storage is also scarce, especially because the VM disk has a limit, so I'm not eager to spoil it with files that aren't going to be used most of the time.
Perhaps we should replace the global nix installation by a command that only allows store protocol forwarding.
Don't get me wrong, I would quite like to have a VM management module in NixOS and nix-darwin, but this is not that. It could be implemented on top of such a general module, but not the other way around.
VM management would involve support for multiple VMs, a focus on allow arbitrary configurations, defaults that are closer to NixOS defaults, and generally more nice things. It may or may not be built on libvirt.
When approached this way, there will be no conflict between these two use cases, because the remote builder module can use the general module and configure its own optimizations to achieve its goal of being a lightweight, single purpose VM.

Let's keep the builder fast and light, and solve the VM management problem separately, so that we can do a better job.

Perhaps there's something we can re-use to implement https://github.com/Mic92/nixos-shell on Darwin instead


Collection addOrUpdate

Would be nice to have an addOrUpdate() method on the collection. It would look at the id attribute to decide whether to trigger a set on the existing model, or an add on the collection.

I'de really like this feature to be implemented by default too. @dalyons solution seems great.

This is a great feature -- and we should make it easy for you to implement it in your app ... but Backbone shouldn't have it built-in by default.


Simplify SyntaxEditor Footer 📂 🛠

Describe the bug
Currently, the syntaxEditor Footer is too crowded. So we need to change the UI for the same.
To Reproduce
Clear steps describing how to reproduce the issue.

Go to 'https://syntaxmeets.vercel.app/'
Click on 'Create/Join Room'
Scroll down to view SyntaxEditor Footer

Screenshots

@kothariji You can assign this issue to me, I am willing to optimize the footer design as per our discussion from issue #112

@amaan-ahmad sure, I will send you a prototype design for the same. And if you feel like you can do that, I will assign it to you 🙌

Sure @kothariji
Do send me design once ready. I am up for doing it also do check PR #112
I've provided a updated footer pic there.

Hello @kothariji , I would like to work on this issue. If there is no one working on it, Can you assign it to me ?

I am interested to do this. Kindly assign me to proceed.
If assigned 3 days of time is needed to complete this issue.

Hey @kothariji is there any update about this issue?

I would like to complete this issue.

can i work on this issue

please assign me this

I would like to work on this, will you assign me?

@kothariji Can i work on this. Please assign me this issue.

⚠⚠⚠ THIS ISSUE IS CURRENTLY ON HOLD  ⚠⚠⚠


Actually filter paths

My previous commit had some issues wrt filtering.
Sorry for the trouble.
This is supposed to fix that issue.

I tested on the emulator and LGTM


AKS Access and Identity concept docs are not ordered in a way that presents useful information first

Currently, the Access and Identity in AKS concept documentation opens with several long, wordy tables listing granular Azure permissions before discussing much of the actual concepts. It's useful information, but likely not the first thing a user is looking for, and buries the high-level concepts of RBAC (Azure vs Kubernetes), authentication, etc.
The doc might be more approachable and less overwhelming if those granular permission tables were farther down the page, and the high level overviews of concepts were placed earlier.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92b18eba-07a5-dbbf-b697-0264e326f4d4
Version Independent ID: 8c025ef6-38a6-eca5-7729-8f040fbbbe10
Content: Concepts - Access and identity in Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/concepts-identity.md
Service: container-service
GitHub Login: @palma21
Microsoft Alias: jpalma

@lee0c  Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Thank you for the feedback.
We've added a task to our backlog and will prioritize accordingly.
#please-close


Feature/rebuild fully tested

Description
The current iteration of the cookbook does not expose all the common parts of a rule and has used -m comment while match does not prefix with the -m.
This commit totally rewrites the cookbook and is still a work in progress, opening for comments and thoughts
This will also migrate the cookbook to github actions for testing
Things still to do:

Have resource to handle the install of iptables (default recipe)
Have a resource to clear the rules (disabled recipe)
See if we can use the cli instead of a rewrite to disk and reload as a better option (Parsing issues maybe)
Write some other resources which are wrappers on iptables_rule, such as a iptables_tcp_rule which will add properties for the options the tcp matcher provides
Update the readme with all this documentation (What would your thoughts be on having a documentation folder similar to sous-chefs with each resources documented individually?)

Issues Resolved
[List any existing issues this PR resolves]
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

@tas50 will write some docs around this tomorrow if I get time,
What is odd is that while dokken and kitchen pass on my local they do not pass on github actions (Local is fedora) so I am just leaving centos-8 for now, we also have unit tests for this
Documentation plans are:

Changelog
Upgrading notes
Resources documented individually

I have restored as well travis for now (Note, travis also only ran delivery so there has never been testing on this cookbook for kitchen/integration testing)

@tas50 ready for a review on this one, will sort out resources for the other recipes if this goes ahead

@tas50 this is all ready for review, note I tried to get deprecated_property_alias 'target', 'Jump', 'The target property was renamed jump in 7.0.0 and will be removed in 8.0.0' but it blew up so if you can take a look inside iptables_rule I would appreciate it

Notes to self, set deprecated_property_alias 'target', 'jump', 'The target property was renamed jump in 7.0.0 and will be removed in 8.0.0'  ... jump should be lower case
Get more testing in this!

I'm ok with retaining the history. It's huge, but this way we don't squash out valuable information later. Thanks for doing all this @Xorima.


Change user guide from pdf to web link

Is your feature request related to a problem? Please describe.
We give a download link for user guide into LNB.
It is always frustrated when release new feature, hard to give recent information to user.
Describe the solution you'd like
So, I change this to web link which is updated regularly.
Additional context
It will link to https://metatron.app/index.php/documents/

@metatron-app/design
T Map 오픈시에 요청에 따라 별도 브랜치를 통해서 급하게 제공한 내용인데요.
T Map 외 정규 브랜치에도 해당 내용 적용을 해도 되는지 검토 부탁드립니다.

@alchan-lee 진행해주세요.