Cannot empty hasMany related model

Hello, thanks for your great work on this plugin!
I'm facing a problem when I try to update related models.
I have a User model defined like so:
export default class User extends Model {
  static entity = 'users';

  static fields() {
    return {
      id: this.increment(),
      skills: this.hasMany(Skill, '$userId'),
    };
  }
...

and the related Skill model defined like:
export default class Skill extends Model {
  static entity = 'skills';

  static primaryKey = ['$userId', 'id'];

  static fields() {
    return {
      id: this.increment(),
      $userId: this.attr(0),
    };
  }
...

At some point in the application, I update the skills of a user like so:
User.update({
  data: data, // <-- this is the data coming from the response of a REST endpoint with the updated skills
  create: ['skills'],
});

This works fine as long as I just add / remove one or more skills but it doesn't do anything when data.skills is []. The skills entities stay the same.
Am I missing something?
Many thanks,

HI thank you for the report!
Your desired behavior is to have empty Skills after inserting data.skills of [] right? Hmmm...
I haven't tested this, but maybe it is because the empty field is not present after the data normalization by normalizr. I found this issue so it looks like I'm correct.
https://github.com/paularmstrong/normalizr/issues/290
Hmmm... If that is the reason, not sure how to solve this one... Maybe it's time to build our own normalizer functionality...

Thanks for looking into it. Yes I believe you're right. It seems like there are quite a few issues related to this in the normalizr project and it seems like it's just ignored if the value is falsy :(
As a workaround, I'm deleting the related skills by hand in the success method of my REST call like this:
.then(({ data }) => {
  User.update({
    data: data,
    create: ['skills'],
  });
  if (data.skills.length === 0) {
    Skill.delete((skill) => skill.$userId === user.id);
  }
});

It's not ideal but does the job for now... 🤷♂

Yeah, let me keep this issue open and try to find out some solution for this. I could come up with;
Implement our own normalizer functionality. It could be a good idea since there're lots of features in Normalizr where Vuex ORM doesn't use.
Add some extra option to delete all records. A bit cumbersome, though it will be more flexible after all. Something like deleteIfEmpty.


TRUS-4347: Ensuring that headings, answers, labels etc. are stored in…

… mongo as keys and parseable strings.


[enhancement] add ngrx

I'm submitting a ...  (check one with "x")
[ ] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[x ] feature request

Current behavior
This project does not have any (transient) state management solution.
Expected/desired behavior
ngrx v4.x could be introduced.
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?
 Recently, I was asked about the compability of @ngx-config/core with ngrx v4.x (https://github.com/ngx-config/core/issues/18), and I think introducing ngrx to this project will both answer the compability issues as well as managing the state.
Please tell us about your environment:

Angular version: 2.0.X

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

Node (for AoT issues): node --version =

This would be pretty cool indeed

@dr1ss I think within two weeks, we'll be there.. Soon I'll upload a list of tasks, and everybody will be able to track the status.

@dr1ss done, have a look when u have time and feel free to make your comments

Also, closes https://github.com/fulls1z3/ngx-config/issues/18


Canvas renderer has strange visual issues

How to reproduce

Leaflet version I'm using: Whatever version http://leaflet.github.io/Leaflet.draw/docs/examples/full.html is using
Leaflet Draw version I'm using: ^
Browser (with version) I'm using: Chrome
OS/Platform (with version) I'm using: Windows 10

What behaviour I'm expecting and which behaviour I'm seeing
I'm expecting behavior like the first half of this gif. When I change the renderer to L.canvas() there are strange visual issues with the canvas.

Minimal example reproducing the issue

I just visited the main example page and edited the map options via the console

Oh wow, that's an interesting one.
I'll tag this, but I'm not sure what's going on at first glance.

Yeah I'm not sure it's a leaflet-draw problem. It's quite possible that this is a leaflet issue.

Ok. I have a workaround solution that works for me. The reason I'm using canvas in the first place is because I'm drawing tens of thousands of features on a the map and svg performance is an issue with that kind of load. Canvas handles this much better. But for my use case a user is not going to be drawing anywhere near that number of polygons on the map so it's fine to use the svg renderer. Due to how shapeOptions are passed into the corresponding native leaflet shape (eg https://github.com/Leaflet/Leaflet.draw/blob/master/src/draw/handler/Draw.Rectangle.js#L38) You can just set the renderer in shape options.
new L.Control.Draw({
      draw: {
        rectangle: {
          shapeOptions: {
            renderer: L.svg()
          }
        }
      }
    }));

I do have one remaining question though. Is it possible to set a shapeOption for every shape type so as to avoid code like this?
new L.Control.Draw({
      draw: {
        rectangle: {
          shapeOptions: {
            renderer: L.svg()
          }
        },
        polyline: {
          shapeOptions: {
            renderer: L.svg()
          }
        },
        polygon: {
          shapeOptions: {
            renderer: L.svg()
          }
        }
        ...etc
      }
    }));

Answering my own question...
    const shapeOptions = {
      renderer: L.svg(),
      color: 'orange',
      opacity: 1,
    };
    this._map.addControl(new L.Control.Draw({
      edit: {
        featureGroup: drawnItems,
        poly : {
          allowIntersection : false
        }
      },
      draw: {
        polyline: {
          shapeOptions: {...shapeOptions}
        },
        polygon : {
          allowIntersection: false,
          showArea:true,
          shapeOptions: {...shapeOptions}
        },
        circle: {
          shapeOptions: {...shapeOptions}
        },
        rectangle: {
          shapeOptions: {...shapeOptions}
        },
      },
    }));

https://github.com/Leaflet/Leaflet/issues/5145
I think that's the same issue but with a pure Leaflet implementation.


[magnum-plugins] cmake configure failure

Host Environment

OS: Windows 10
Compiler: Visual Studio 2019 Community - Version 16.9.4

To Reproduce
Steps to reproduce the behavior:
./vcpkg install --head magnum-plugins[pngimporter]:x64-windows
Failure logs
PS C:\Programming\projects\personal\vcpkg-issue\build> cmake .. -DCMAKE_TOOLCHAIN_FILE=C:\Programming\vcpkg\scripts\buildsystems\vcpkg.cmake
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19042.
-- Found Corrade: C:/Programming/vcpkg/installed/x64-windows/include
-- Found Corrade: C:/Programming/vcpkg/installed/x64-windows/include  found components: Containers rc Utility
-- Found Magnum: C:/Programming/vcpkg/installed/x64-windows/include  found components: GL Sdl2Application
-- Found Corrade: C:/Programming/vcpkg/installed/x64-windows/include  found components: Containers rc Utility PluginManager
-- Found Magnum: C:/Programming/vcpkg/installed/x64-windows/include  found components: Trade
-- Found ZLIB: optimized;C:/Programming/vcpkg/installed/x64-windows/lib/zlib.lib;debug;C:/Programming/vcpkg/installed/x64-windows/debug/lib/zlibd.lib (found version "1.2.11")
-- Found PNG: optimized;C:/Programming/vcpkg/installed/x64-windows/lib/libpng16.lib;debug;C:/Programming/vcpkg/installed/x64-windows/debug/lib/libpng16d.lib (found version "1.6.37")
CMake Error at C:/Program Files/CMake/share/cmake-3.20/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find MagnumPlugins (missing: PngImporter)

      Reason given by package: PngImporter is not built by default. Make sure you enabled WITH_PNGIMPORTER when building Magnum Plugins.

Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.20/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  C:/Programming/vcpkg/installed/x64-windows/share/cmake/MagnumPlugins/FindMagnumPlugins.cmake:523 (find_package_handle_standard_args)
  C:/Programming/vcpkg/installed/x64-windows/share/cmake/MagnumPlugins/MagnumPluginsConfig.cmake:26 (include)
  C:/Programming/vcpkg/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  CMakeLists.txt:7 (find_package)

-- Configuring incomplete, errors occurred!

Additional context
CMakeLists.txt

Hi @sbrkopac
Thanks for posting this issue.
There are several questions that need to make it clear:

I noticed you used --head to build the port, I'm not sure how you build it successfully with this option.
Since I failed to build it on my local with --head.

You used find_package(MagnumPlugins REQUIRED PngImporter) in your CMakeLists.txt. The usage seems not correct.
I checked there are no usage for magnum-plugins in vcpkg. Where do you get the usage info?

Hi @NancyLi1013
You might need corrade and magnum as head installs as well:
.\vcpkg install --head corrade[*]:x64-windows
.\vcpkg install --head magnum[*]:x64-windows
I follow the documentation outlined in two places:
Building Plugins
Loading and using plugins

Thanks for your information. I will try this again later.

Sorry for the long delay. Confirmed this is a bug, I will look into it and try to fix this soon.

This is due to PngImporter.lib is removed from /lib/magnum/importers and debug/lib/magnum-d/importers. We can see the related codes here:
https://github.com/microsoft/vcpkg/blob/master/ports/magnum-plugins/portfile.cmake
set(VCPKG_POLICY_EMPTY_INCLUDE_FOLDER enabled)
    # On windows, plugins are "Modules" that cannot be linked as shared
    # libraries, but are meant to be loaded at runtime.
    # While this is handled adequately through the CMake project, the auto-magic
    # linking with visual studio might try to link the import libs anyway.
    #
    # We delete the import libraries here to avoid the auto-magic linking
    # for plugins which are loaded at runtime.
    if(WIN32)
        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/lib/magnum)
        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/lib/magnum-d)
    endif()

@Squareys can you help take a look?
Thanks.

@NancyLi1013 Hey, sorry, somehow I missed the @ there.
The plugins are not meant to be used statically through vcpkg. Instead the .dll files are copied during the DLL dependency search after CMake configure with the magnum_deploy.ps script.
Head builds should be fine, but I'm currently experiencing some issues here aswell (a patch on the magnum port is not applying, but the affected code hasn't changed for 6+ months). Currently looking into that.

I fixed the build of magnum/magnum-plugins in https://github.com/microsoft/vcpkg/pull/19435

Thanks for Squareys' reply and fix. @sbrkopac According to the comment in magnum-plugins's portfile.cmake and Squareys' reply,  plugins are "Modules" that cannot be linked as libraries, but are meant to be [loaded at runtime]. (https://doc.magnum.graphics/magnum/plugins.html#plugins-loading).
    # On windows, plugins are "Modules" that cannot be linked as shared
    # libraries, but are meant to be loaded at runtime.
    # While this is handled adequately through the CMake project, the auto-magic
    # linking with visual studio might try to link the import libs anyway.
    #
    # We delete the import libraries here to avoid the auto-magic linking
    # for plugins which are loaded at runtime.

The plugins are not meant to be used statically through vcpkg. Instead the .dll files are copied during the DLL dependency search after CMake configure with the magnum_deploy.ps script. (This means rather than going through linking and find_package, you load the plugin at runtime).

@Squareys Does this issue resolved?

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


Update something about CI

[ ] GitHub CI templates (Market)
[ ] Gitlab CI templates (Links)

Hey! Love the look of your site :) I was just wondering if there was any particular reason as to why Gatsby is missing in your list of SSG's in https://sosiristseng.github.io/posts/devops/ssg/ (or maybe you just hadn't heard of it)? I find it gives me the least amount of headache, but I have to say your site is tempting me to take a look at Hugo

Hi @Pocket-titan thank you for taking your time to look at my random notes. 😁

why Gatsby is missing in your list

Actually, I've heard of Gatsby.js but I have almost zero JS programming knowledge so I did not mention it. 😅 And again this site is just a bunch of random notes for my future self so I may add it to my list when I find it useful.

your site is tempting me to take a look at Hugo

Yes, please check out the Hugo CodeIT theme, you'll love it.


Distill DefaultHinter down to history suggestions

Focus the functionality of the DefaultHinter on providing fish/zsh-style history autosuggestions
Simplifies hinter and drastically reduces the number of allocations per Hinter::handle call

(Show content after cursor when completing)
Place the hint obligatory behind the line content
Simplify hinter internals/capabilities
Remove HistoryCompleter (was never pub)
Fix doctest Reedline::with_hinter
Add configurable character threshold for Hinter

Left allocation flamegraph for main, right for this branch
See the reduction in allocations for not copying the history elements.

Yeah this looks a lot simpler


project clone operation is taking too long to clone a repository

When looking at logs on minikube with dwo/next I have this output:
2021/06/07 07:34:12 Read DevWorkspace at /devworkspace-metadata/flattened.devworkspace.yaml
2021/06/07 07:34:12 Cloning project spring-petclinic to spring-petclinic
Enumerating objects: 8606, done.
Counting objects: 100% (5/5), done.
Compressing objects: 100% (4/4), done.
Total 8606 (delta 0), reused 4 (delta 0), pack-reused 8601
2021/06/07 07:34:37 Cloned project spring-petclinic to spring-petclinic
2021/06/07 07:34:37 Setting up remotes for project spring-petclinic
2021/06/07 07:34:37 Fetched remote origin at https://github.com/che-samples/spring-petclinic
2021/06/07 07:34:37 Creating branch devfilev2 to track remote branch devfilev2 from

25seconds ? to clone the project
If I go inside the container and do a clone, it's taking almost a couple of seconds
bash-5.0 /projects $ date; git clone --branch devfilev2 https://github.com/che-samples/spring-petclinic /projects/petclinic-cli; date
Mon Jun  7 07:40:49 UTC 2021
Cloning into '/projects/petclinic-cli'...
remote: Enumerating objects: 8606, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 8606 (delta 0), reused 4 (delta 0), pack-reused 8601
Receiving objects: 100% (8606/8606), 7.28 MiB | 6.21 MiB/s, done.
Resolving deltas: 100% (3269/3269), done.
Mon Jun  7 07:40:51 UTC 2021

when I tried to do the same I faced project clone crashed, probably with OOMKilled

I don't know if it is related to cpuRequest/cpuLimit etc. Usually it's related but I have not investigated the issue but I reproduced it on rhpds cluster as well. (Slow clone during project-clone operation)

AFAICT this is fixed by increasing the CPU limit


[Feature Request] Bubbler visual bobble

The bubbler entity looks pretty awkward when it's not hidden because it just hangs in midair, would be nice to give it the visual bob that entities like refills have to make it so the sprite isn't completely static.

fixed in 1.37.8


[Question] Where to find source code of Microsoft.AspNetCore.Authentication.AuthenticationOptions?

Sorry if this is a very basic question but I am still learning how to browse the source code on github and I spent few hours trying to look for the source of the AuthenticationOptions class.
Cannot find it in AspNetCore/src/Security/Authentication/Core/src/ where I was expecting it to be.
Thanks in advance!

It is located here:
AspNetCore/src/Http/Authentication.Abstractions/src/AuthenticationOptions.cs

@wutever0 pro-tip, you can press 't' to search for a file name on github:

You can also use https://source.dot.net/

Thank you guys very useful tips!


jenkins: Use sudo for tests

Jenkins now uses a non-root user for its agents, so we will need to use
sudo for some commands.
Stolen from osbuild/osbuild-composer#581, big thanks to @major!

urllib3.exceptions.MaxRetryError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /api/status (Caused by ProtocolError('Connection aborted.', ConnectionRefusedError(111, 'Connection refused')))

Not sure what to do about this, but it looks unrelated to this PR. So I think we can merge this.

May 04 08:35:26 ci-fedora32-3 osbuild-composer[308718]: 2020/05/04 08:35:26 cannot read state: error reading db file state: unexpected target name
Please, give a minute, I will investigate.

Found the cause, I will merge this and create a new PR.

urllib3.exceptions.MaxRetryError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /api/status (Caused by ProtocolError('Connection aborted.', ConnectionRefusedError(111, 'Connection refused')))

Not sure what to do about this, but it looks unrelated to this PR. So I think we can merge this.

I have an uneasy feeling merging PRs with :x:, not if it is avoidable.

I have an uneasy feeling merging PRs with x, not if it is avoidable.

Very much agreed.

Me too, but I'm basically porting fixes from osbuild-composer repo and I want 1:1 mapping with them for a future reference.


set_authority() implemented

Can we write a test for this method?

Can we write a test for this method?

Could you will be able to write a test if I provide my test data?

Can we write a test for this method?

Could you will be able to write a test if I provide my test data?

Could you make sure the CI pass? @kuznetsov-m I'm okay with merging this one..


binaries download

Hi, could you guys give me a built image (.bin file) for ADL RVP (MEC1521)? Currently , I don't have enough environments to download and build source code .
Thanks.

Cannot fulfill this request


Design Enhancements for Article Card

Description:
This pull request enhances the styling of the article card component for improved visual appeal and user experience.

Changes Made:

Updated the CSS for the article card component to include a fixed height for consistent card sizes.
Improved the shadow effect on the card’s outer border for a more pronounced appearance.
Modified button styling for better visual impact with updated colors and shadow effects.
Ensured responsiveness across different screen sizes, including adjustments for font sizes and padding.

Checklist:

Tested the changes locally to ensure consistent card size and improved visual effects.
2 .Verified responsiveness on various devices and screen sizes.
Ensured all styles adhere to project standards and conventions.

Thank you!

Hi @AACHAL2303PATIL,
Thank you for your PR. Can you design the card content like the one attached here (use icons...)

For now, do keep everything left aligned as it is, no caps for title, even the button or if you want you can use the same style as the button in the form. Let me know if there's something you don't understand.

Hi @AACHAL2303PATIL,
Are you still working on this?


Remove legacy SASI support after 22.03 release

As discussed in https://github.com/akuker/RASCSI/issues/660 there does not appear to be much interest in SASI support. Serious bugs (segfaults) have not been noticed for 5 months, i.e. nobody used SASI drives with the RaSCSI versions released in the last 5 months. Or at least nobody had any interest in reporting these bugs, or in testing the SASI emulation.
In addition, the fact that the SCSI controller is a subclass of the SASI controller makes it hard to extend the SCSI code in order to address existing tickets, or to add new functionality. For SASI, on the other hand, not no features can be expected. There are a lot of other issues with the SASI code that makes it a maintenance burden, as one can see from existing and old tickets.
This is why after the 22.03 release SASI support should be removed.

I have a possible use case for SASI support -- the Acorn Domesday system uses it to communicate with the Laserdisc drive.
My aim is to have RaSCSI pick off the Laserdisc commands and send them to a framestore (or more likely a full-fat Pi) to play the audio and video streams and still-frames.
My use case could be accommodated with a branch or fork if needs be -- it is currently a speculative development, but I thought it worth a mention as others may have their use cases.

@philpem Hi. Can you please add a link to a documentation (with the SASI commands it uses) of this drive? Any suggestions how to decouple the current SASI code (in particular the controller) from the SCSI code?
As mentioned in my initial comment the SASI code has been broken for about half a year. Maybe you can indicate why you have not updated (at least that is what I assume) for such a long time?

The VP415 operating manual is here: https://www.domesday86.com/wp-content/uploads/2017/01/Philips-VP415-Operating-Instructions.pdf -- the "F-code" commands are used to program the player, and the following chapter explains how to send them over SCSI.
The Domesday86 project has more information on the player, including:
Other VP415 documentation and internals: https://www.domesday86.com/?page_id=316
The BeebSCSI controller, including an implementation of the VP415 commands: https://www.domesday86.com/?page_id=689
It appears that I was mistaken about these being SASI drives -- I must have been thinking about the earlier Acorn Winchester Host Adapter, which uses an Adaptec or Xebec SASI-to-MFM bridge controller.
I have only recently discovered this project, so you are sadly mistaken -- I have never worked on the SASI code. In any case, it seems like I need SCSI, not SASI.
If anyone wanted to work on SASI, there is a description of it in the CDC Wren II Interface Specification: http://bitsavers.trailing-edge.com/pdf/cdc/discs/wren/77738148B_Interface_Specification_for_WREN_II-SCSI_SASI_SUBSET_94151_198511.pdf
But it seems from my limited research that it would mostly be useful for the Japanese X68000 machines.

Just to note, there's going to be a bit of concerted effort about to take place to make this work with a victor 9000 which used a Xebec S1410 - so please don't lose the SASI stuff!

@drdpj Any idea why nobody who is interested in SASI has used any RaSCSI release for more than half a year? Since that time SASI was definitely broken. Maybe you can indicate why you have not used any RaSCSI version since 21.10?

Because people have only just started getting these machines working (up
until very recently it was very hard to make floppy images for them), and
now we can get them booted it's an opportunity to look at mass storage.
Scsi2sd isn't an open system, but this is. Retro communities take time to
start adopting bits of hardware - removing functionality would seem to be
something of a retrograde step for these things, usually expanding
usefulness to futher platforms is the route they take (eg, flashfloppy).
Personally speaking, I'm waiting for my rascsi adapters to materialise from
the far east and will start to poke at it properly when those arrive.
Fozztexx has already started. Also worth noting that raspberry pis are hard
to source at a sensible price at the moment, so that delays adoption.
On Tue, 22 Mar 2022, 07:43 Uwe Seimet, @.***> wrote:

@drdpj https://github.com/drdpj Any idea why nobody who is interested
in SASI has used any RaSCSI release for more than half a year? Since that
time SASI was definitely broken. Maybe you can indicate why you have not
used any RaSCSI version since 21.10?
—
Reply to this email directly, view it on GitHub
https://github.com/akuker/RASCSI/issues/729#issuecomment-1074835544, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PHDCGNIQQ3LGXLBTITVBF2ZBANCNFSM5QBJF6KA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drdpj SCSI2SD is pure SCSI, not SASI, isn't it? So it would not qualify for SASI anyway. Please correct me if I am wrong. Which SASI hardware are you using? You can probably help with testing RaSCSI wrt to SASI? Up to now nobody else has been interested in that.
Would you be willing to work on the SASI code, in order to decouple it from the SCSI code? The problem with the SASI code is that it interferes with the further development of the SCSI code.

@uweseimet SCSI2SD does do quite a bit of SASI, and works where some very early SASI/SCSIesque drives were used (I use one in an SJ Research MDFS, and they've also been used in Acorn Filestores) - big list here: https://www.codesrc.com/mediawiki/index.php/SCSI2SD_V5_Compatibility
I was working with Michael M to try and get it to emulate the Xebec controller properly (that's the PDF I linked) so it would work in the Victor 9000 (that's my particular use case for this, and it's very picky), but as it's a closed project the testing was a very to-and-fro thing taking a long time and eventually it reached a dead end. I would very happily help test the SASI code on my system, and also to develop it further. Decoupling I might not be so useful (I've got Java experience, not so much C++), but I can certainly help think about how best to decouple it although actually following through on that myself might be trickier!  It seems that both SCSI and SASI should be subclasses of "controller" rather than SCSI being a subclass of SASI.

@drdpj Do you have time to test the SASI code of the upcoming 22.03 release, i.e. the current develop branch? Looks as if the release is stalling, so there may still be enough time for testing. In general, somebody regularly testing the SASI develop code would be important.

@uweseimet yes - although I'm not sure when my adapters will turn up! The buffers are currently stuck in customs and the cards are somewhere in China. I also strongly suspect that the Xebec is a special case of SASI. However, if it behaves on the victor - which I know is quite picky - it should behave with other things that are using that same Xebec controller.

@drdpj Well, if you have a special case of SASI it might not work with RaSCSI without any changes to the existing code. Looks as if you may have no choice but to get more familiar with C++ ;-). All in all, somebody would have to maintain the code.

:D - I expect it may well need some changes, so at some stage I'm going to have to get my hands dirty with C++! Thing about SASI is it's not quite a uniform standard so far as I can tell, and there were a number of slightly different implementations. Things very much firmed up with SCSI.

@drdpj Any news? You are still the only one who has expressed interest in SASI support.

There is a fork that is working that fozztexx has done but I don't know if
it's resulted in a pull request?
d.
On Tue, 26 Apr 2022, 11:46 Uwe Seimet, @.***> wrote:

@drdpj https://github.com/drdpj Any news? You are still the only one
who has expressed interest in SASI support.
—
Reply to this email directly, view it on GitHub
https://github.com/akuker/RASCSI/issues/729#issuecomment-1109642756, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PFB3WAVRWU3ZHJSR23VG7CP7ANCNFSM5QBJF6KA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drdpj I'm afraid I don't know which fork you are talking about. Why should there be a pull request? What you you mean with "fork that is working"? Are there any issues with the current RaSCSI development branch?

I would have hoped there'd be a pull request to bring the fixes back into
the main source. This fork: https://github.com/FozzTexx/RASCSI/tree/Victor9k
has fixed issues with SASI support in the main branch and got it working
with machines that expect the Xebec SASI controller.
On Tue, 26 Apr 2022 at 11:52, Uwe Seimet @.***> wrote:

@drdpj https://github.com/drdpj I'm afraid I don't know which fork you
are talking about. Why should there be a pull request? What you you mean
with "fork that is working"? Are there any issues with the current RaSCSI
development branch?
—
Reply to this email directly, view it on GitHub
https://github.com/akuker/RASCSI/issues/729#issuecomment-1109648090, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PGBSPRRTUHIKUBXMX3VG7DHFANCNFSM5QBJF6KA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drdpj There is no related PR ...

I can create one? I've just merged the changes in with the master branch on
my own fork?  Which branch should I request a merge with?
d.
On Tue, 26 Apr 2022 at 11:59, Uwe Seimet @.***> wrote:

@drdpj https://github.com/drdpj There is no related PR ...
—
Reply to this email directly, view it on GitHub
https://github.com/akuker/RASCSI/issues/729#issuecomment-1109654123, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PFJQLGRG7HZSWYPOZ3VG7EALANCNFSM5QBJF6KA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drdpj Please first create a ticket that describes the bug/issue your changes are going to fix. Your PR has to be raised against the develop branch, not the master branch. So before creating the PR please ensure that your changes refer to the develop branch, and that the changes have successfully been tested. Note that the SASI code also may affect the SCSI code, i.e. testing with SCSI devices may also be required.

They're not my changes so I'll do my best to describe. I think a memory
leak was fixed with the SASI emulation too - but I couldn't say where.
On Tue, 26 Apr 2022 at 12:24, Uwe Seimet @.***> wrote:

@drdpj https://github.com/drdpj Please first create a ticket that
describes the bug/issue your changes are going to fix. Your PR has to be
raised against the develop branch, not the master branch. So before
creating the PR please ensure that your changes refer to the develop
branch, and that the changes have successfully been tested. Note that the
SASI code also may affect the SCSI code, i.e. testing with SCSI devices may
also be required.
—
Reply to this email directly, view it on GitHub
https://github.com/akuker/RASCSI/issues/729#issuecomment-1109676480, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PHNK5FPFOSR5RHA42LVG7G7HANCNFSM5QBJF6KA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drdpj Well, if you raise a PR you would have to know the details and you need to be able to address any issues with the PR. If you are not familiar with the changes IMHO a PR does not make much sense.

Agreed, so I shall try and get the person who made the changes to issue one.
On Tue, 26 Apr 2022 at 12:31, Uwe Seimet @.***> wrote:

@drdpj https://github.com/drdpj Well, if you raise a PR you would have
to know the details and you need to be able to address any issues with the
PR. If you are not familiar with the changes IMHO a PR does not make much
sense.
—
Reply to this email directly, view it on GitHub
https://github.com/akuker/RASCSI/issues/729#issuecomment-1109682404, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PHN7SIP7MDUKW3TA4LVG7HYDANCNFSM5QBJF6KA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drdpj Yes, this would be be. We need a proper ticket and PR against the develop branch, and the changes must have been tested against the develop branch. And it would be very good to test first whether any changes are needed at all, because the develop branch already contains numerous bugfixes related to SASI.

@uweseimet A stable release has been tagged and released now, so deprecating SASI should be considered for the roadmap of the next stable release I think!

@rdmark The changes for this ticket may also affect the web interface. You can verify this in the sasi_removal branch, where the SASI device type has been removed from the protobuf interface. I recommend that you check whether your Python code relies on this type to be present. In general, clients should be able to cope with a type not being present anymore, i.e. except for being re-compiled against the modified protobuf interface no further action should be necessary. In particular, if a client manages configuration data, the client should not break when loading invalid configurations, e.g. configurations still containing unsupported device types.

@uweseimet Works fine on my system.

@Pacjunk Thank you for your feedback. As soon as @akuker or @rdmark have approved https://github.com/akuker/RASCSI/pull/806 we can continue with the SCSI level changes.

Summary the most important changes:

Removed the SASI controller code
New controller management. There is a new controller base class AbstractController and a class ControllerManager managing the controller lifecycle. The lifecycle management was removed from rasci.cpp and is covered by unit tests.
New device management. The DeviceFactory manages the device lifecycle instead of rascsi.cpp. The new code is covered by unit tests.
The lifecycle managment uses C++ collections with variable size instead of arrays with hard-coded sizes.
The ScsiController method contains most of what was previously contained in scsidev_ctrl.cpp plus the code from sasidev_ctrl.cpp that was relevant for SCSI.
scsi_command_util contains helper methods used for identical SCSI command implementations of more than one device
Devices know their controllers, so that the controller instance does not need to be passed to each SCSI command. This change helps to decouple the devices from the controller. The phase_handler interface is also part of this decoupling.
Use scsi_command_exception for propagating SCSI command execution errors, This resolves issues with the previous error handling, which was based on return values and often on magic numbers.
Removed legacy SCSI error codes, all errors are now encoded by sense_key::, asc:: and status::.
Fixed various warnings reported with -Wextra, -Weffc++ and -Wpedantic.
Use constructor member initialization lists (recommended for ISO C++)
Consistently use new/delete instead of malloc/free (recommended for ISO C++), resulting in better type safety and error handling
Replaced variable sized arrays on the stack (violates ISO C++ and can cause a stack overflow)
Replaced NULL by nullptr (recommended for C++), resulting in better type safety
Use more const member functions in order to avoid side effects
The format device page can now also be changed for hard disk drives (Fujitsu M2624S supports this, for instance), not just for MOs.
Better encapsulation, updated access specifiers in many places
Removed unused methods and method arguments
Fixed a number of TODOs
Added/updated unit tests for a lot of non-legacy classes
Makefile support for creating HTML coverage reports with lcov/genhtml


Add Modern Masters 2015

Full list has now been spoiled:
http://magic.wizards.com/en/articles/archive/card-image-gallery/modernmasters2015edition

fixed by #115


using vulkan gpu in webui

hello
'''
python3.10 shark/examples/shark_inference/stable_diffusion/main.py --precision=fp16 --device=vulkan --prompt="tajmahal, oil on canvas, sunflowers, 4k, uhd"
You can replace vulkan with cpu to run on your CPU or with cuda to run on CUDA devices. If you have multiple vulkan devices you can address them with --device=vulkan://1 etc
'''
by this command I succefully generate image using my rx 6850m ,but when I using web-ui, its still using CPU to running.
so what I can do for these command...
thx
PS C:\Users\nod\SHARK\web> python index.py

Can you please attach the output of your vulkaninfo ?

sorry about long time to reply，
and now i have no time to get it in the short term...so you can close it ...


Add default return to getShared function

Just allows
Inertia::getShared('some-key', 'A default value');

similar to
Session::get('some-key', 'A default value');

Happy to merge this. Curious though, did you actually have a use-case for this? I mostly have getShared() for internal purposes (testing).

Hey @reinink,
Yes so I have a custom facade for Inertia with a few methods for doing flash notifications so I can just do
Inertia::successNotification('User Created!');
return Redirect::back();

or
Inertia::successNotification('Welcome to the application!', false);
Inertia::render('Welcome');

This is implemented via the following
<?php

namespace App\Facades;

use Inertia\Inertia as InertiaFacade;
use Illuminate\Support\Facades\Session;

class Inertia extends InertiaFacade
{
    public static function flashImmediate($type, $message)
    {
        $flash   = static::getShared('flash-immediate') ?? [];
        $flash[] = [
            'type'    => $type,
            'message' => $message
        ];

        InertiaFacade::share('flash-immediate', $flash);
    }

    public static function flashDelayed($type, $message)
    {
        $flash   = Session::get('flash', []);
        $flash[] = [
            'type'    => $type,
            'message' => $message
        ];

        Session::flash('flash', $flash);
    }

    public static function flash($type, $message, $immediate = false)
    {
        $immediate ? static::flashImmediate($type, $message) : static::flashDelayed($type, $message);
    }

    public static function successNotification($message, $immediate = false)
    {
        static::flash('success', $message, $immediate);
    }

    public static function infoNotification($message, $immediate = false)
    {
        static::flash('info', $message, $immediate);
    }

    public static function warningNotification($message, $immediate = false)
    {
        static::flash('warning', $message, $immediate);
    }

    public static function errorNotification($message, $immediate = false)
    {
        static::flash('error', $message, $immediate);
    }
}

And then in the service provider I share a DataProvider (see #118 for details on those)
Inertia::share((new InertiaSharedDataProvider())->toArray());

<?php

namespace App\Http\DataProviders;

use App\Models\User;
use App\Facades\Inertia;
use App\Models\Organisation;
use Illuminate\Support\ViewErrorBag;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Session;

class InertiaSharedDataProvider extends DataProvider
{

    public function errors(): array
    {
        return Session::get('errors', new ViewErrorBag)->getBag('default')->getMessages();
    }

    public function flash(): array
    {
        return array_merge(Inertia::getShared('flash-immediate') ?? [], Session::get('flash', []));
    }

   //... other stuff

}

While I could do this other ways, such as having a custom store for the notifications, or using one of the many available flash notification packages, I figured I might as well just use intertia's built in store.
So long story short, it's just so I can swap out the static::getShared('flash-immediate') ?? [] to static::getShared('flash-immediate', [])

So, you're really using this for flash messages...that's cool. Have you seen how I've done this in the Ping CRM demo app? I just use Laravel's built-in flash features.
For example:
// Controller
return Redirect::route('users')->with('success', 'User created.');

And then I share this with my client-side app like this:
// AppServiceProvider
Inertia::share([
    'flash' => function () {
        return [
            'success' => Session::get('success'),
            'error' => Session::get('error'),
        ];
    },
}

I have yes, I use pingcrm as a goto for a lot of things :+1:
I believe the only usecase it doesn't cover is the immediate notifications which is what I use the shared data for,
the standard flash notifications do actually go through the session flash data (and so your ->with example would still work).
Inertia::successNotification('Welcome to the application!', true);
Inertia::render('Welcome');

Released: https://inertiajs.com/releases/inertia-laravel-0.4.1


feat(dpg): resolve ambiguous methods with existing codes

add clone method in Paramter, MethodSignature and LowLevelClientMethod to clone the object and make parameters required
add MethodAmbiguityResolver which will detect and resolve ambiguous method
add new logic in the constructor of LowLevelClient to detect and resolve ambigous LowLevelClientMethod
add test cases
a minor refectoring

resolve #2204
Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

I tried on the MetricsAdvisor, and there are more ambiguous methods found under MetricsAdvisorAdministrationClient.

The test case location is a little bit confusing. In my opinion, it should be in the HLC folder.

The test case location is a little bit confusing. In my opinion, it should be in the HLC folder.

I tend not to be restricted in HLC, since theoretically the SourceInputModel will include any code file except for those under Generated folder. If you check the MetricsAdvisor, the HLC clients are located at the project root folder. Besides, as I mentioned before, developers could have written customization codes. So here I just put the existing codes where the Roslyn can find and parse.

I mean, for example, the namespace should not end with _LowLevel and the project name should not end with _LowLevel. In my understanding, our functionality is: starting from HLC, we generate such LLC. So it seems the test project should start from "without LLC".

Could mgmt plane borrow this when we need overload? For instance, for optional bag. And this should help us to automatically resolve breaking changes.

Could mgmt plane borrow this when we need overload? For instance, for optional bag. And this should help us to automatically resolve breaking changes.

I think these are two cases:

The case we're currently resolving in DPG is to check if I add a new method, will it have some ambiguity with the old one? Both methods will exist.
In your case, it sounds like I want to replace the old method with the new one, will it have breaking change?

I think the algorithm for those two cases is different.

The test case location is a little bit confusing. In my opinion, it should be in the HLC folder.

I tend not to be restricted in HLC, since theoretically the SourceInputModel will include any code file except for those under Generated folder. If you check the MetricsAdvisor, the HLC clients are located at the project root folder. Besides, as I mentioned before, developers could have written customization codes. So here I just put the existing codes where the Roslyn can find and parse.

I mean, for example, the namespace should not end with _LowLevel and the project name should not end with _LowLevel. In my understanding, our functionality is: starting from HLC, we generate such LLC. So it seems the test project should start from "without LLC".

The project name is derived from the folder name by the \eng\Generate.ps1. I prefer the -LowLevel suffix because it describes the scenario of test cases, e.g. test ambiguity resolution during llc code gen. HLC client is just part of the assumption in the test cases.


remove numberOfVidsIn method

🙇 Thank you to @cal2195 for the good cleanup & improvement in https://github.com/whyboris/Video-Hub-App/pull/58 -- we can now safely remove this method 🎉
The method was basically a duplicate of getVideoPathsAndNames but it returned only the number of files. It was infinitesimally faster but the time 'savings' are not worth the repetition of code 👍

@cal2195 -- I suspect you might even have permission to merge a pull request. If so, feel free to merge this one upon your approval 😉


WIP: BSP fixes

A small collection of changes from when testing splitting the BSPs out into separate repos.

I've left this with just the changes that I think are uncontroversial so we can get these minor doc/packaging fixes in place for the BSPs


fix(popover): prevent scrollbar

What I did

hide the dialog before the popover animates open and after it animates closed
Add a demo to illustrate the solution

Testing Instructions

https://deploy-preview-2730--patternfly-elements.netlify.app/components/popover/demo/edge-of-viewport/ and set the viewport width so that the popover is at the far edge. For me, that was 1190 pixels wide.
Observe that there is not horizontal scrollbar
confirm that opening and closing the popover in various ways works as expected
repeat step 3 for the other demo files

Notes to Reviewers

Closes #2648

Tested locally as mentioned in the testing instructions.
The horizontal scroll bar issue is now resolved.


Learn about debit card ambitions with Nitya

Had a very useful conversation on Tue 02 Nov, ping me if you'd like to chat about this.


Minimum requirements (Maven)

I have read the requirement maven 3.1.+ but the code looks like 3.0.X would be ok...but the pom states the dependency to maven-project uses 3.0-alpha-2, maven-plugin-api uses 3.2.2..the question is why not using consistently version 3.0 ? Any special reason for this?
If you like to force using a particular maven version this should be done by using maven-enforcer-pugin?

Ok will look into this.

The requirements for 3.1.x + is because we use the eclipse Aether see here.
For the versions for maven plugins, we aim to use the latest. Currently this is:
<maven.compiler.plugin.version>3.3</maven.compiler.plugin.version>
<maven.project.version>3.0-alpha-2</maven.project.version>
<maven.plugin.plugin.version>3.4</maven.plugin.plugin.version>
<maven.plugin.api.version>3.3.9</maven.plugin.api.version>
<maven.plugin.annotations.version>3.4</maven.plugin.annotations.version>

This works fine with maven version 3.1.x+ as stated in the documentation.


Should not ng-repeat terminate when its parent is removed from DOM?

Actual Behavior:

What is the issue? * When an outer element containing ng-repeat is removed from DOM ng-repeat still continues
What is the expected behavior? It expected that it will terminate as it is not needed there anymore, while its backing array still can be in use by other application parts/components

CodePen (or steps to reproduce the issue): *

CodePen Demo which shows your issue: here
Details: There is an array of two elements containing a sequence of two sequential numbers, it is updated every second, older element is removed and next ordinal one is inserted. These numbers are wrapped into dummy directive, used to just count its invocations. Also there is a button to remove container element. And  a counter of directive invocations. After removing container from DOM we still can see that directive is invoked every a second.

Need to say however that if we will equip a container element with ng-if then all works as expected. So what is the difference between ng-if and straight element removal? (I mean behavioral difference, not how the gears do work internally)
Angular Versions: *

Angular Version:1.5.7 (also 1.5.8)

Additional Information:

Browser Type: * Chromium, Firefox
Browser Version: * 52.0.2743.116, 49.0
OS: * Ubuntu 16.04 (64-bit)
Stack Traces: --

The reason why this happens, is that ngRepeat will set up a watcher on its containing scope (the scope that contains the ngRepeat). When you "manually" remove parts of the DOM you are responsible for destroying any unnecessary scopes/watchers.
ngIf (and all built-in structural directives, such as ngSwitch, ngView, ngInclude etc) take care of that automatically.
--
So, unless you have very specific requirements (in which case you have to take care of cleaning up yourself), you should use one of the built-in structural directives.

@gkalpak , like as I said before, I understand how the gears do work internally.
IMHO, independently of removal method a directive have to stop.
now lets suppose that I have very specific requirements, and ready take care of its removal. How do I stop ng-repeat directive then? for me it is a kind of black box and I have not control of it at all...

Since ngRepeat (like other directives) creates its own scope bindings internally, there is no way to unbind from the outside. Therefore, the recommended way is to provide it a new scope to bind to, and then destroy that scope when you want to remove the directive. (That is also the reason why ngIf and similar directives create child scopes.)


[BUILD] A lot of undefined references

Environment
Operating System: Ubuntu 22.04
Version / Commit SHA: OpenVDB 10.0.0
CMake Version: 3.22.1
Compiler: C++ 17
Describe the problem
A lot of undefined references, some of them are listed in the screenshot below.

To Reproduce
Steps to reproduce the behavior:

Installing OpenVDB dependencies (tbb, boost, openEXR, cmake).
Build openVDB using the given guidance. I always use sudo on the installation, and the file is seems to be successfully installed without error.
Trying the helloWorld code in the following

Creating a makefile to run the helloworld code as follows.

The error occurs.

Thank you for your help.

Same problem in mine. Can anyone help us? Thanks a lot1


fix(runtime-dom): clear setTimeOut

fix #2482

Thanks for the PR. A cleaner fix is to simply never invoke the stale callbacks, see eaf8a67c


[SPARK-35083][FOLLOW-UP][CORE] Add migration guide for the remote scheduler pool files support

What changes were proposed in this pull request?

Add remote scheduler pool files support to the migration guide.
Why are the changes needed?

To highlight this useful support.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Pass exiting tests.

Test build #142643 has started for PR 33785 at commit 11505a9.

Test build #142643 has finished for PR 33785 at commit 11505a9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142643/

Thanks, merging to master/3.2

wait isn't this an improvement?

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47144/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47144/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47144/

@HyukjinKwon sorry I didn't notice that. I was trying to cut RC1 today...
Let me revert this one.


Falsely catching standard libraries (pdb)

When running the following script
import superimport

import pdb; pdb.set_trace

I get the following message from superimport
ERROR: superimport : missing python module: pdb; pdb
Trying try to install automatcially
WARNING:root:Package was not found in the reverse index, trying pypi.
WARNING:root:Failed to install pdb; pdb automatically

However, pbd is part of the Python standard library. Is this expected?

When running the following script
import pdb; pdb.set_trace

This usage patten is not supported at the moment.
If you use :
import pdb
pdb.set_trace

it should work.
one needs to implement this here:
https://github.com/probml/superimport/blob/b220882659a10d8e7dc584b925ccc432f4fa26b9/superimport/superimport.py#L81-L90


Display titles of option groups in swift build --help

Recent versions of ArgumentParser support visual grouping of options specified with @OptionGroup property wrapper when title argument is provided. Let's do it for swift build to make its --help output cleaner.
Help output before:
OVERVIEW: Build sources into binary products

SEE ALSO: swift run, swift package, swift test

USAGE: swift build <options>

OPTIONS:
  --package-path <package-path>
                          Specify the package path to operate on (default current directory). This changes the
                          working directory before any other operation
<multiple ungrouped options skipped>

Help output after:
OVERVIEW: Build sources into binary products

SEE ALSO: swift run, swift package, swift test

USAGE: swift build <options>

GLOBAL OPTIONS:
  --package-path <package-path>
                          Specify the package path to operate on (default current directory). This changes the
                          working directory before any other operation
<multiple global options skipped>

BUILD OPTIONS:
  --build-tests           Build both source and test targets
  --show-bin-path         Print the binary output path
  --print-manifest-job-graph
                          Write the command graph for the build manifest as a graphviz file
  --target <target>       Build the specified target
  --product <product>     Build the specified product

OPTIONS:
  --version               Show the version.
  -h, -help, --help       Show help information.

@swift-ci smoke test

I've tried breaking up GlobalOptions into logical subgroups as you describe, but that's blocked by https://github.com/apple/swift-argument-parser/issues/558

cc @bitjammer for input on desired UX

Some specific comments on what I can see based on the description:

The idea of cascading, global options should be reconsidered in the future. Not something to solve here, however:
Instead of calling the group "GLOBAL", I'd recommend something like "GENERAL". Although subcommands are good, users shouldn't have to contend with the idea of command "hierarchy" in swiftpm tools with respect to the options.
I probably wouldn't consider --show-bin-path a build option. It's really almost a kind of subcommand or mode change, and a general one. Same with --print-manifest-job-graph.

Personally, I'd like to sit down and make more fundamental changes to the usage of the swiftpm tools. That includes cleaning up how these "global" options cascade down to other commands, or what is or isn't a subcommand, such as swift-package-registry and swift-package-collection. I don't have very strong feelings about this change one way or the other in light of that, but I think I agree with Boris here overall.
One thought here from my work on the command line interfaces so far is that some options are much more common than others. Consider sorting options by their apparent frequency within groups as possible. Another thought: if we really must draw boxes around options, they should be task-oriented as much as possible. If there is only one task achievable by the tool, the groupings become somewhat arbitrary as Boris said. I don't have a better answer for this at this time as I haven't had the time to review all of the options again in detail. I hope that helps!


schedule openSUSE Leap 15.4 Continous Rebuild

Related Ticket : https://progress.opensuse.org/issues/120243

https://github.com/os-autoinst/opensuse-jobgroups/pull/280 is related

@DeepthiYV feel free to merge when you feel its ready


Code Coverage reports should report tests as having coverage

I only updated the tests in https://github.com/meltano/meltano/pull/6407#issuecomment-1184910358 , test coverage being impacted on files outside of the tests/ folder makes sense, but me impacting tests/* doesn't make any sense to me.

Code Coverage probably shouldn't look at the tests directory? But it's almost like all other files should be checked for their total coverage as I could botch a fixture or something and reduce coverage in unexpected ways. Maybe this is already being checked?

For what it's worth, I recently found & removed some dead code from the tests because it was reported as uncovered. Using coverage stats to help ensure that we run all of the test code that we've got may be beneficial.

For what it's worth, I recently found & removed some dead code from the tests because it was reported as uncovered. Using coverage stats to help ensure that we run all of the test code that we've got may be beneficial.

Extra information seems ok (maybe as it can overwelm me but I understand folks who are in the code base all the time wanting it, as I am at the moment), but the failure here https://github.com/meltano/meltano/pull/6407/checks?check_run_id=7325652363 doesn't to me

Thank you!


ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

On LibAIO is possible to retrieve the I/O completion
events without using io_getevents sys-calls by reading
the user-space ring buffer used by the kernel to store them.
This commit include another optimization to avoid
calling a method to obtain the buffers address, saving
safepoint polls, a method call and implicit instance
checks performed.

I am merging this so I can cherry-pick using some git-magic into the new native project.


Deployment: Add Terraform deployment to ACA

Alongside the existing option to deploy to ACA using bicep, add the ability to deploy to ACA using Terraform

add bicep and scripts
update docs

Adding additional notes here to validate the requirements.
Currently there are two bicep scripts:
base.bicep deploys the following into a resource group...

container registry
keyvault
storage account

main.bicep then refers to these resources, and deploys...

log analysitcs
app insights
managed identity
container app env
container app storage
several keys to KV
the container app

The sequence of steps for a deployment are:

deployment is kicked off by running make deploy-aca
this calls ./scripts/deploy-aca.sh
deploy-aca.sh in turn, invokes the following scripts:

deploy-aca-base.sh
docker-build-and-push.sh
deploy-aca-infra.sh

Finally, deploy-aca.sh tests the deployment by calling deploy-aca-test.sh and logs from the ACA are shown by calling deploy-aca-show-logs.sh

So, given this, I believe the sequence of tasks related to this issue are:

Create a "switch" to allow a developer to choose between Bicep and Terraform. Suggest env var SIMULATOR_DEPLOY_METHOD with values bicep and terraform as values, and bicep as the default
Rename deploy-aca-base.sh to deploy-aca-base-bicep.sh
Rename deploy-aca-infra.sh to deploy-aca-infra-bicep.sh
Create subfolder of ./infra as  ./infra/bicep and move the above two files into this location
Create subfolder of ./infra as  ./infra/terraform
two new files called deploy-aca-base-terraform.sh and deploy-aca-infra-bicep.sh would be added to the ./scripts folder, next to their bash equivalents.
Modify deploy-aca.sh to inspect SIMULATOR_DEPLOY_METHOD and then call the correct bash scripts.
Test that the bicep deployment continues to work when  SIMULATOR_DEPLOY_METHOD=bicep, or when the env var is not set, and that the terraform deployment fails when SIMULATOR_DEPLOY_METHOD=terraform (due to the bash scripts being empty at this stage)
the terraform scripts need to be authored and tested manually. A set of .tf files would be added to ./infra/terraform
the bash scripts deploy-aca-base-terraform.sh and deploy-aca-infra-bicep.sh would need to be authored

Does this sequence of tasks look right to you @stuartleeks?
Additional Questions/Notes:

The deployment scripts pass "values" to each other via the output JSON file. I don't see why this should be a problem, but is there any difference between the JSON output from the bicep deployment vs a terraform deployment?
Will we then test both of these deployment mechanisms in the CI builds?

Do we think it might be better to put the terraform and bicep specific bash files into the same folder structure as the terraform and bicep scripts?
e.g. something like...
.
└── infra
    ├── bicep
    │   ├── base.bicep
    │   ├── main.bicep
    │   └── scripts
    │       ├── deploy-aca-base-bicep.sh
    │       └── deploy-aca-infra-bicep.sh
    └── terraform
        ├── base.tf
        ├── main.tf
        └── scripts
            ├── deploy-aca-base-terraform.sh
            └── deploy-aca-infra-terraform.sh

For the Terraform deployment, we may not need the base/infra split that bicep has because we can use localexec etc in the Terraform

Yep. I'd not given much thought to the .tf files needed, so consider those as just illustations.

@stuartleeks  please assign me

Closed by #60


Handle cancelled recv

if you've set a RCVTIMEO on a socket and cancel a pending recv's future, later pyzmq will try to re-set the recv's future when data is available causing an error.  pyzmq should either watch for the future being done and cancel setting it, or check before setting the future of the recv if it's aready "done"

Do you have a test case? The RCVTIMEO code checks future.done(), which should be enough, but maybe there's one missing that I don't see.

see
handle: <Handle _AsyncSocket._deserialize.<locals>._chain(<Future finis...aaaaq\x04sb.'>) at /Users/amohr/dev/third_party/pyzmq/zmq/eventloop/future.py:171>
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.2_2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/events.py", line 125, in _run
    self._callback(*self._args)
  File "/Users/amohr/dev/third_party/pyzmq/zmq/eventloop/future.py", line 181, in _chain
    f.set_result(loaded)
  File "/usr/local/Cellar/python3/3.5.2_2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/futures.py", line 329, in set_result
    raise InvalidStateError('{}: {!r}'.format(self._state, self))
asyncio.futures.InvalidStateError: CANCELLED: <Future cancelled>

I see the issue, you're not checking for cancelled

I'll submit a patch, btw, could you put something on your page comparing pyzmq to aiozmq.  What are the differences?

ok, created PR which will cancel the recv future if it hasn't completed already.  This should correctly propagate cancels


entropy of a tensor

can we have feature enhancement that we can compute the entropy of a tensor, the similar way that we can do it for mean, std, etc?

So you want a feature that normalizes the tensor by its entropy, is that right?
Or do you want a function that computes the entropy of a tensor?

I would like  a tensor that compute the entropy of tensor. well, saying that, it is good if that function can compute the entropy in different ways, meaning that we can define a dimension and compute the entropy based on that, e.g. channel wise, etc
I think as soon as we can compute the entropy, normalizing it should not be too difficult, right?

I believe this would be more suited to maybe pytorch/contrib, as it is not really vision-specific. Can you maybe open an issue there?

sure :)


DMA ip are missing

I have a script that generate static configuration using cubemx files. I want to use the files from this github repository instead to avoid cubemx installation, but files like DMA-STM32dmaModes.xml are missing, and i need them to find correct DMA stream/channel for a given peripheral.

You can download the whole database via this update URL.


Return Count of JSON candidates

Hi,
Your JSON parser works great for a webservice I created that returns addresses from a GIS database, but I was wondering if there is a way to get the count of all of the 'address candidates' that are in the JSON response?  Perhaps it is already there and I have missed it??
Here is a typical response my webservice returns.  It would be nice just do a json.Count (or similar) to know how many addresses were returned (in the case below, 19).
{"spatialReference":{"wkid":26917,"latestWkid":26917},"candidates":[{"address":"1669 Nash Road Condominium, Clarington","location":{"x":677723.68326790119,"y":4864528.5515185883},"score":95.879999999999995,"attributes":{"Score":95.879999999999995,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"","City":"Clarington"},"extent":{"xmin":677523.68326790119,"ymin":4864328.5515185883,"xmax":677923.68326790119,"ymax":4864728.5515185883}},{"address":"1669 Nash Road, Condominium G-18, Clarington","location":{"x":677710.06050503487,"y":4864523.5129624596},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-18","City":"Clarington"},"extent":{"xmin":677510.06050503487,"ymin":4864323.5129624596,"xmax":677910.06050503487,"ymax":4864723.5129624596}},{"address":"1669 Nash Road, Condominium G-17, Clarington","location":{"x":677711.18018417433,"y":4864519.9673118507},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-17","City":"Clarington"},"extent":{"xmin":677511.18018417433,"ymin":4864319.9673118507,"xmax":677911.18018417433,"ymax":4864719.9673118507}},{"address":"1669 Nash Road, Condominium G-16, Clarington","location":{"x":677712.48647650424,"y":4864516.2350480519},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-16","City":"Clarington"},"extent":{"xmin":677512.48647650424,"ymin":4864316.2350480519,"xmax":677912.48647650424,"ymax":4864716.2350480519}},{"address":"1669 Nash Road, Condominium G-15, Clarington","location":{"x":677713.97938202368,"y":4864512.5027842531},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-15","City":"Clarington"},"extent":{"xmin":677513.97938202368,"ymin":4864312.5027842531,"xmax":677913.97938202368,"ymax":4864712.5027842531}},{"address":"1669 Nash Road, Condominium G-14, Clarington","location":{"x":677715.09906116361,"y":4864509.1437468333},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-14","City":"Clarington"},"extent":{"xmin":677515.09906116361,"ymin":4864309.1437468333,"xmax":677915.09906116361,"ymax":4864709.1437468333}},{"address":"1669 Nash Road, Condominium G-13, Clarington","location":{"x":677716.59196668305,"y":4864505.9713226045},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-13","City":"Clarington"},"extent":{"xmin":677516.59196668305,"ymin":4864305.9713226045,"xmax":677916.59196668305,"ymax":4864705.9713226045}},{"address":"1669 Nash Road, Condominium G-12, Clarington","location":{"x":677721.4439096218,"y":4864507.6508413143},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-12","City":"Clarington"},"extent":{"xmin":677521.4439096218,"ymin":4864307.6508413143,"xmax":677921.4439096218,"ymax":4864707.6508413143}},{"address":"1669 Nash Road, Condominium G-11, Clarington","location":{"x":677725.36278661061,"y":4864509.1437468333},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-11","City":"Clarington"},"extent":{"xmin":677525.36278661061,"ymin":4864309.1437468333,"xmax":677925.36278661061,"ymax":4864709.1437468333}},{"address":"1669 Nash Road, Condominium G-10, Clarington","location":{"x":677729.6548899794,"y":4864510.4500391632},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-10","City":"Clarington"},"extent":{"xmin":677529.6548899794,"ymin":4864310.4500391632,"xmax":677929.6548899794,"ymax":4864710.4500391632}},{"address":"1669 Nash Road, Condominium G-9, Clarington","location":{"x":677734.13360653818,"y":4864512.1295578731},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-9","City":"Clarington"},"extent":{"xmin":677534.13360653818,"ymin":4864312.1295578731,"xmax":677934.13360653818,"ymax":4864712.1295578731}},{"address":"1669 Nash Road, Condominium G-8, Clarington","location":{"x":677738.05248352746,"y":4864513.8090765821},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-8","City":"Clarington"},"extent":{"xmin":677538.05248352746,"ymin":4864313.8090765821,"xmax":677938.05248352746,"ymax":4864713.8090765821}},{"address":"1669 Nash Road, Condominium G-1, Clarington","location":{"x":677738.79893628694,"y":4864534.709753857},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-1","City":"Clarington"},"extent":{"xmin":677538.79893628694,"ymin":4864334.709753857,"xmax":677938.79893628694,"ymax":4864734.709753857}},{"address":"1669 Nash Road, Condominium G-2, Clarington","location":{"x":677740.10522861686,"y":4864530.9774900582},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-2","City":"Clarington"},"extent":{"xmin":677540.10522861686,"ymin":4864330.9774900582,"xmax":677940.10522861686,"ymax":4864730.9774900582}},{"address":"1669 Nash Road, Condominium G-3, Clarington","location":{"x":677741.41152094631,"y":4864527.4318394484},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-3","City":"Clarington"},"extent":{"xmin":677541.41152094631,"ymin":4864327.4318394484,"xmax":677941.41152094631,"ymax":4864727.4318394484}},{"address":"1669 Nash Road, Condominium G-7, Clarington","location":{"x":677742.15797370626,"y":4864515.301982102},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-7","City":"Clarington"},"extent":{"xmin":677542.15797370626,"ymin":4864315.301982102,"xmax":677942.15797370626,"ymax":4864715.301982102}},{"address":"1669 Nash Road, Condominium G-4, Clarington","location":{"x":677742.53120008623,"y":4864524.0728020296},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-4","City":"Clarington"},"extent":{"xmin":677542.53120008623,"ymin":4864324.0728020296,"xmax":677942.53120008623,"ymax":4864724.0728020296}},{"address":"1669 Nash Road, Condominium G-5, Clarington","location":{"x":677743.83749241568,"y":4864520.7137646107},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-5","City":"Clarington"},"extent":{"xmin":677543.83749241568,"ymin":4864320.7137646107,"xmax":677943.83749241568,"ymax":4864720.7137646107}},{"address":"1669 Nash Road, Condominium G-6, Clarington","location":{"x":677745.51701112557,"y":4864516.4216612419},"score":91.760000000000005,"attributes":{"Score":91.760000000000005,"AddNum":"1669","StName":"Nash","StType":"Road","StDir":"","SubAddType":"Condominium","SubAddUnit":"G-6","City":"Clarington"},"extent":{"xmin":677545.51701112557,"ymin":4864316.4216612419,"xmax":677945.51701112557,"ymax":4864716.4216612419}}]}

You can try jsonObjects("candidates").Count, where jsonObjects are returned objects from calling JsonConverter.ParseJson(jsontext).

Amazing!!  I was trying that before but the intellisense never activated on the .count so I didn't even bother to test it.
Thanks for responding!!


Number input doesn't accept keyboard input

Expected Behavior
Can we accept input from the keyboard, but limit the input to just numbers. Will it feel broken if you try to type a character like 'a' and nothing happens? If you have a keyboard should it pop up the soft numberpad at all?
Actual Behavior
If you click into number input field (e.g. move 1 step), you cannot use the keyboard to enter a value. You still need to click buttons on the soft numberpad
Steps to Reproduce
On a device with a keyboard

drag out a move block
Click in the number field to popup the soft numberpad
try to type a number - nothing happens.

Device and Operating System
Chromebook

SJR-169


Fix typo and Improve log messages for better clarity

It requires some typo cleanup and adding and deleting logs to remove broken windows.

@inhogog2 Could you please clarify the issue a bit further to help understand it better?

@inhogog2 Could you please clarify the issue a bit further to help understand it better?

Hi @ronaksingh27  You can use tools like Go vet, gofmt, and golint and check for typos / minor errors etc


[Bug]: It seems that RPG Manager forces to full width window tab

Check for existing bug reports before submitting.

[X] I searched for existing Bug Reports and found no similar reports.

Expected Behavior
Line width size to be adjustable (any rpg manager note), just as when sidebar opens and tab resizes.
Current behaviour
I cant adjust line width (any rpg manager note), because RPGM is somehow interfering with Lie Width Slider plugin, or viceversa.
Reproduction

Install Line Width Slider
Install RPGM
Adjusting lie width doesnt work anymore

Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version Check
1.4.16
Plugin Version
4.1.4
Confirmation

[X] I have disabled all other plugins and the issue still persists.

Possible solution
Please fix RPGM forcing full width window tab, or make it compatible with "Line Width Slider" plugin.

Same issue here when using the Minimal Theme. Any changes to line width made in the Minimal Theme Settings plugin are not having any effect until I disable RPG Manager.

this is being discussed in #311 and I will try and update the plugin when I find a suitable solution

Fixed in 4.1.5 by adding a new setting to toggle the full width


Classical Controllers Enhancement

[ ] Single phase controllers (resonant)
[ ] Model Predictive Control
[ ] GPU integration

@SeptimusBoshoff, how is the status here?


RunLayerContext to understand forward/backward

RunLayerContext must be able to differentiate the function calls of forward and backward.
This is required to limit the access of temporary variables requested for only forward operation in backward operation.

:octocat: cibot: Thank you for posting issue #1397. The person in charge will reply soon.


Libre 2: unsupported sensor: unknown

Hi,
Using Libre 2 EU sensors. Never had problem before but the last batch of sensors I got are not recognized by the app.
The error message does not give much insight.
How can I help debug? Also curious not seing more reports about this issue. Something changed in the latest sensors ?

Hi @enodr same problem for me. I have been using Libre 2 EU sensors for months without any issues, the latest one gives me the same unsupported sensor issue.
How can we help?

I can confirm the fix works perfectly with the new sensors. Marking as closed for me.


The extension doesn't fold nested blocks

Hi,
first of all thanks for providing this extension. The current folding in VSCode is unbearable.
However I found this extension only folds the top level of the code.
I attached two screenshots, one with the extension turned on, one with the extension turned off.
You can see without the extension there is an incorrect fold at the #endif And when folding the entire function it stops at the #ifdef

But with the extension turned on you can't fold the inner for loop anymore. And if the #ifdef/#endif block is not on the first line you can fold that block either.

Hello, thanks for the submitted issue.
To be clear you would like to have also fold controls within function blocks only with keyword + bracket (if{}, else{}, for{}, ...) or generally for all bracket sets within a function?

I think for all brackets would be best. Before I switched to VS code I used notepad++ and I think the folding there is implemented great.
Anything that has a opening and closing character (like {}, (), [], /* */) or statement (like #if #endif) can be folded.

Alright, i think the options
cfold.provide.withinFunction
cfold.withinFunction.minLines

would be suitable for this case.

Okay i pushed a new version. I hope it's okay that it only folds brackets ({}) within functions (everything else behaves like before).
The reason for only providing brackets is it may require an extra logic and possibly more precise folding ranges on vs-code side with columns.

Thanks. Works great now. Obviously more folds like #if #endif inside of functions would be better. But this is already a big help compared to the standard vscode folding.


Support connection to aepp opened over file:/// protocol

on sdk side it was implemented in https://github.com/aeternity/aepp-sdk-js/pull/1900
Opening over file:// needed for fresh developers or to run something super decentralized. I consider this not an important case.
Steps to implement:

update SDK (not released yet);
update your content script with 'null' check;
add file:///* to your webmanifest;
ensure that SW works with the reproduction.

All needed materials you can find in the abore PR.

https://github.com/aeternity/aepp-sdk-js/releases/tag/v13.2.2 🎉


Add OptionSets

Some options control whether the response is associated with the context of multiple messages, and some control the response strategy. I don’t understand the specific function and purpose of each option, but the lack of some options will cause inconsistencies between ReEdgeGPT and the web version of Edge

Well it's my fault, I forgot to add  pull_request_target on GitHub Actions.


DateTime fields are returned in local time rather than UTC

Looking at the API docs for twitter it states that the datetime values are returned in UTC, therefore I was expecting Tweetinvi to return these values in UTC, however they are returned in Local time.
Is this by design or unexpected? I can not see anything in the documentation to state either way.
Example:
Twitter Date
Tue Jul 19 09:24:53 +0000 2016
From DateTime.ParseExact:
{19/07/2016 10:24:53}
THIS HAS CONVERTED TO LOCAL TIME (BST)!
Thanks

There isn't any conversion being done in API specifically.
Can you show your code what you're trying? I feel like you're using DateTime parse method properly which is converting it to your time zone.

I was asking what is the expected behaviour of the datetime properties in
tweetinvi, such as the tweet.created_at property. I had set my expectations
based on the Twitter API docs that stated these properties were returned in
UTC.
However when I used these values returned by tweetinvi they are being
converted to local time, this I wasn't expecting.
I have looked at the code for tweetinvi and seen you are using
ParesDateExact and can see this is returning a local time.
So my question really is this behaviour by design? Are you wanting to
return the datetime as local time? If so then I need to change my code to
convert back to UTC as that is the format I need.
Thanks
Phil
On 28 Jul 2016 7:39 p.m., "Muhammad Haseeb Asif"<EMAIL_ADDRESS>wrote:

There isn't any conversion being done in API specifically.
Can you show your code what you're trying? I feel like you're using
DateTime parse method properly which is converting it to your time zone.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/linvi/tweetinvi/issues/305#issuecomment-235986379,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARt10ubBQnd72l2k7Glxx5y-7hXAONttks5qaPdxgaJpZM4JXH4h
.

The DateTime are effectively returned in local time. The reason is that most developers do not read the Twitter documentation and usually expect such behaviour.
Just use .ToUniversalTime() to solve your problem.

OK thanks for clarifying, just wanted to be sure before I changed my code
to handle it.
Thanks for the great library :).
On 29 July 2016 at 09:49, linvi<EMAIL_ADDRESS>wrote:

The DateTime are effectively returned in local time. The reason is that
most developers do not read the Twitter documentation and usually expect
such behaviour.
Just use .ToUniversalTime() to solve your problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/linvi/tweetinvi/issues/305#issuecomment-236128006,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARt10pHe9dNfUhryqy-Wih9Xk6UKQ1HSks5qab6AgaJpZM4JXH4h
.


Suggestion: Collections still return plain js document(s)

Great work, beautiful design, love it so much.
Through reading the documentation, I find that almost all functionalities are implemented as separate parts, only one thing, Collections now return a transformed doc(Astro class instance) by default. I think this is not so good. By NOT changing this with Collections, it can be a complete and clean extension  to old low level meteor-mongo mechanism, giving developers a clear line to choose which level they are working in, and, make it better compatible with other projects (especially for which is migrating)

Ha-ha, exactly the same thing I asked yesterday to be implemented. The clean way to choose, when to call model and when the collection. Plus non-breaking previous publications.

I've implemented mechanism to turn off transformation globally by setting Astro.config.disableTransform = true;. It will appear in the next published version of Astronomy. So I'm closing this for now :)

@jagi Awesome, thank you!


Add stash mapping changes to v2.1.0 changelog

This is a rebased and tweaked version of #3094

@bjlittle @pp-mo @kaedonkers Same with this one; it's only little so it'd be nice to get it merged today.

@tv3141 And again, I have rebased this and pushed to master myself to avoid complications.  Please let me know if this is not OK.


fields_for inside of a fields_for not rendering

Hey!
Been loving the gem! But I've run into a bit of a strange situation.
Top level view:
<%= form_for @foo, html: { multipart: true }, layout: :basic do |f| %>

      <%= f.fields_for :bar, fieldset: false do |builder| %>

            <!-- this partial expects the variable to be named 'builder' -->
            <%= render partial: 'bar/fields_for',
                       locals: {builder: builder} %>

        <% end %>

      <% end %>

<% end %>

in bar/fields_for:
<%= builder.fields_for :yat, fieldset: false do |_builder| %>

    <%= render partial: 'yat/table_form', locals: { builder: _builder } %>

  <% end %>

The oddity that I am seeing is that the second fields_for doesn't actually render anything. The models are setup properly to accept_nested_attributes_for and have the proper belongs_to and has_many relationships setup.
Even if I change the bar/fields_for file to this:
<%= builder.fields_for :yat, fieldset: false do |_builder| %>

    BH IS AWESOME

  <% end %>

I still get nothing.
Am I missing something? Any help would be really appreciated!
<3

@KMontag42 Hello and thanks for stopping by!
I'll try to replicate the bug and come back with some feedback.

@claudiofullscreen any ideas? spent a bit of time trying to sort this one out but wasn't able to find anything conclusive.


Avoid having to specify GLSLANG_REPO_ROOT when running CMAKE

This change will download the glslangValidator binary automatically, avoiding external dependencies upon a separate glslang repo.  Build.md doc updated with these instructions, along with how to set a location manually if a different glslangValidator version is wanted (for some crazy reason).
Note: The only glslang component currently used in this repo is glslangValidator, used to compile the two dinky shaders in cube and cubepp.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pushed to Master.


code about ReasonNet

<EMAIL_ADDRESS>

@chenxinhe1 Did you get the source code of ReasonNet?

@thunguyenth 您好，没有哦，如果您有的话，恳请共享一下，拜谢

@thunguyenth 您好，没有哦，如果您有的话，恳请共享一下，拜谢

Hi @chenxinhe1, I'm sorry. I also wanted to ask for the code.

Same question. May I get the source code of reasonnet?

I want to get the reasoner source code too. May I ask for this?


World and player Stop rendering when messing with toggles

Describe the bug
When swapping between states on the  "player_fade_out_enabled": true, config option sometimes the world and player will stop rendering. when I disabled the mod the world rendered again but the character did not come back
Reproduce
Steps to reproduce the behavior:

Go to config option  "player_fade_out_enabled": true,
set to false
return to the game and swap quickly between perspectives
disable mod with keybind
reenable mod with keybind
broken af

Expected behavior
I would be able to see the world and player after executing these steps
Additional context
I am playing with distant horizons as well

Playing with version 2.0.7 on MC 1.19.2
Disconnecting and relogging did not return the player, disabling the config option and enabling the mod did not return functionality or player visibility.
restarting the game returned player view but reenabling the mod resulted in the same non render issue with a persistent lack of player view after disabled the mod