issue with (closed) PR #405

Note: for general support questions, please use the mailing list<EMAIL_ADDRESS>This repository's issues are intended for feature requests and bug reports.
When using intel compiler with "-devel" option (which, among other, check for consistent arguments of S/R calls),
file cost_gencost_moc.F fails to compile. Apparently (to be confirmed) due to calls to S/R MDS_READVEC_LOC..
Tests that did failed over night:

Adjoint experiment "global_oce_biogeo_bling" here:
http://mitgcm.org/testing/results/2021_02/tr_svante-ifcAdm_20210215_0/summary.txt
fwd experiments "global_oce_cs32" and "global_oce_llc90" here:
http://mitgcm.org/testing/results/2021_02/tr_engaging-ifcMpi_20210215_0/summary.txt

Might be easy to fix with only minor changes (checking now).

Perhaps a fix is to call MDS_READVEC_LOC the exact same way as it is in cost_gencost_boxmean. MOC now has:
_RL gencost_mskTemporal

...

call MDS_READVEC_LOC(fname0,cost_iprec,ioUnit,'RL',
     &          1, gencost_mskTemporal, dummyRS, 0, 0, irec, myThid )

boxmean:
_RL tmpVar(1)
_RL gencost_mskTemporal

...

call MDS_READVEC_LOC(tempfile,cost_iprec,ioUnit,'RL',
     &      1, tmpVar, dummyRS, 0, 0, iRec, myThid )
       gencost_mskTemporal = tmpVar(1)

I can confirm, that I can compile but not run with ifort on ollie for "global_oce_biogeo_bling" even without "-devel", with this traceback:
=> output from running in global_oce_biogeo_bling/run :
> mitgcmuv_ad<PHONE_NUMBER>774A9C  Unknown               Unknown  Unknown
> libpthread-2.17.s  00007F8C868586D0  Unknown               Unknown  Unknown
> mitgcmuv_ad<PHONE_NUMBER>19C899  mds_write_tape_          1879  mdsio_write_tape.f
> mitgcmuv_ad<PHONE_NUMBER>DE590F  adwrite_                 4326  adread_adwrite.f
> mitgcmuv_ad<PHONE_NUMBER>D39150  adthe_main_loop_          699  the_main_loop_ad.f
> mitgcmuv_ad<PHONE_NUMBER>765256  the_model_main_          2987  the_model_main.f
> mitgcmuv_ad<PHONE_NUMBER>579977  MAIN__                   3673  main.f
> mitgcmuv_ad<PHONE_NUMBER>403E9E  Unknown               Unknown  Unknown
> libc-2.17.so       00007F8C8629A445  __libc_start_main     Unknown  Unknown
> mitgcmuv_ad<PHONE_NUMBER>403DA9  Unknown               Unknown  Unknown

This happens during writing tapelev3_2_the_main_loop_storedynvars3d, here:
https://github.com/MITgcm/MITgcm/blob/bd16afdcdefcbc67ac6c141b9a1d59a84f529014/pkg/mdsio/mdsio_write_tape.F#L93
It's really odd, I had thought that I had tested this, but apparently only with gfortran (which still works fine).

I am going to make a new PR with @timothyas 's suggestion (it also the fix I had in mind): it's not a major modification and it
looks like it's fixing the forward tests (global_oce_cs32 & global_oce_llc90). And will go back to adjoint experiment "global_oce_biogeo_bling" after that.

sorry, false alarm at my end. y sMegmentation fault was due to no enough memory, an "ulimit -s unlimited" fixed it. I cannot reproduce the error anymore.

I checked that I can compile and run ADM test experiment "global_oce_biogeo_bling" with intel compiler and -devel.


Transition Doesn't Work on Chrome 115

Vue version
3.3.4
Link to minimal reproduction
https://play.vuejs.org/#eNpVkEFuwyAQRa8yZZNWqkPVpUui9g5ZsqFonKBiQDCmiizfvRBQlK7gD/89jVjZVwj7vCAbmUg6mkCQkJZwlM7MwUeCFSJOsMEU/Qy7Ut1JJ532LpXqxf/CoRaeKS74Ip3gzVL4EgjnYBVhSQDieyHyDj61NfrnIFmnn+op2fHkz2eLgrdaQ05RuWTI9FwmAfJgpk4X6oLWesHrwuWV/wMEf1igxERXW6/7PKAjjIPSZDK+3iYWVcY+gbXa6O4awQelDV3hPQGqhB/SbVV5N9XfefSQb47OjfDWkPI/tyXY9gczJYXq
Steps to reproduce

Open the Playground
Click Toggle

What is expected?
disappear slowly
What is actually happening?
disappear immediately
System Info
No response
Any additional comments?
This is a browser compat problem, Chrome Canary/Chromium has changed the default value of animation-duration in the latest version.
Related

https://github.com/w3c/csswg-drafts/issues/6530
https://github.com/chromium/chromium/commit/9f26d474dc4b87e705dc8a2e1ab2632c87dc1eb7

To temporarily workaround this, prepend the stylesheet with:
* {
  transition-duration: 0s;
  animation-duration: 0s;
}

In the latest discussion it was decided to keep the default value of 0s due to compatibility issues
https://github.com/w3c/csswg-drafts/issues/6530#issuecomment-1581661556
However, the development version of Google Chrome in version 116 has not been modified yet.

keep the default value of 0s

If I understand correctly, the default value is still changed to auto but getComputedStyle will return 0s.

keep the default value of 0s

If I understand correctly, the default value is still changed to auto but getComputedStyle will return 0s.

yes 😂

@yyx990803 96c76facb7de37fc241ccd55e121fd60a49a1452 won't fix this issue. auto doesn't equal to 0. The specific value will be calculated by browser.

I think zz is right

AFAIK auto is only meant for group animations and scroll animations, and is considered to be same as 0 for "normal animations", which is currently what Vue transitions are used for.
The actual use case for auto is still yet to be implemented by the browser, and we can consider how to properly support those cases if they can also be used with Vue's transition system. But until then, this is what is needed to avoid the auto value breaking all existing Vue transition usage.

fixed via https://chromium-review.googlesource.com/c/chromium/src/+/4607459


v2.2.1

Codecov Report

Merging #224 (29ac7d2) into master (55bc529) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines          218       218
  Branches        29        29
=========================================
  Hits           218       218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bc529...29ac7d2. Read the comment docs.


Issues while configuring

I followed the instructions mentioned in the README. Still not able to get it to work. From the video, it seems that we are checking page from file system rather than AEM instance. Is that right?
My expectation was that any page/component running on AEM would auto-reload when I make change to the html file like it is happening in the video

Hi,
yes, you're right, the configuration doesn't support auto-reloading of the browser (known as Browser Sync), and it also doesn't automatically push changes into AEM (AEM Sync). It only watches file changes to run the Webpack bundling process. Browser Sync and AEM Sync don't work by default. There are various ways to implement it, and I found that different people and projects have different preferences, so I didn't want to make it part of the project by default.
Here are a few options you can check out:

Webpack plugin on NPM https://www.npmjs.com/package/aem-sync-webpack-plugin
AEM Brackets extension https://docs.adobe.com/docs/en/aem/6-3/develop/dev-tools/aem-brackets.html?wcmmode=disabled
AEM Front (developed by me) combines AEM Sync with Browser Sync https://kevinw.de/aem-front/

Thanks for superquick @kevinweber. If this project it not pushing to AEM and no browser sync.. and it seems that I have to statically include JS/CSS in the HTML, why is this called aem-weback-example.. Other than the folder structure, what other thing is AEM like..?

Valid question. Let's discuss this.
We just published a blog post describing some concepts we thought about when setting up Webpack in AEM. The post answers a few questions that are implemented in AEM Webpack Example, namely:

Where to put the Webpack configuration in AEM? Here we also suggest three ways for using those output files. One of those ways suggests the use of AEM's clientlibs (as opposed to referencing the bundled JS/CSS file in HTML directly/statically).
How to run Webpack using Maven? That's AEM-specific because most Webpack projects are not part of a project that uses Maven.
Where to put JavaScript files? That's AEM-specific as well because it considers Adobe's component-based project structure.

Read the post: http://www.infielddigital.com/blog/webpack-in-aem/
What other ways do you imagine for integrating Webpack into AEM?

One thing to keep in mind is how AEM deals with some of the "reserved words" so using webpack to make bundles (that might use require and default syntax) might cause issues. How are you guys handling that?

@Aourin I'm not sure what you mean by that. We haven't had issues with clientlibs related to Webpack. Can you give an example and explain how you are handling this?


Can't scroll schedule in android webview

For example, opening from facebook

It works fine for me. Anyone else with this problem?

It works fine for me on WebView created on Slack in a Android M. Please specify where is the problem

It happens in chromium mobile 51 (2009) which I assume it's like the default browser for me. No problems in chrome for mobile


Add final notebook: rioxarray, planetary computer

cc @aguspesce @isamarcortes

Hey Scott! I looked over your notebook and it's a lot of good stuff! I wonder if we will get to finish it all on Monday. If we don't, we can finish it on Wednesday! Very excited for your class :)


proposal: cmd/vet: detect homograph attacks

A homograph attack is an attack that exploits the visual similarity of two glyphs. Traditionally, this has been used in phishing attacks to trick a user into visiting a malicious domain that looks identical to the real domain. However, homographs can also be used to sneak malicious source code past review. This is possible in any language that supports Unicode source code.
Here is a simple example of a homograph attack in Go source code:
package main

import (
	"log"
	"os"
)

func main() {
	log.SetFlags(0)
	f, err := os.Create("test")
	if err != nil {
		log.Fatal(err)
	}
	f.Close()
	if _, еrr := f.Write([]byte("data")); err != nil {
		log.Fatal(еrr)
	}
}

(Playground link)
The expected output is write test: file already closed, but the actual program prints nothing.  This happens because e and е are homographs, and thus err and еrr refer to different variables. This example is not very threatening, but it should demonstrate that sophisticated attacks could be constructed using this mechanism.
In my analysis, strings are the most likely vector for a homograph attack. For example, a homograph could be inserted in a switch statement over runes or strings, such that a particular case branch would never be taken. A homograph could also be used in an import  path, although sites like GitHub seem to do a good job of preventing users from registering names or repos that contain homographs. Finally, as in the example above, homographs could be inserted in variable names where scoping rules make the duplication difficult to detect.
I propose that go vet make a "best effort" to detect homograph attacks. This is a bit nuanced because there are many valid reasons to include Unicode characters in source code; distinguishing malicious homographs from harmless ones is probably impossible in general. However, I believe that a few simple heuristics can catch the vast majority of viable attacks. For example, go vet could flag identifiers that mix ASCII with known homographs.
I have already developed a simple tool for this purpose here, though it is currently too strict to be used in projects that contain harmless homographs. Perhaps an external tool is sufficient, but adding it to go vet increases the chance that a security-conscious project will be protected from such attacks. At any rate, I recommend that open-source projects at Google run any publicly-submitted patches through a homograph detector.

How do you suggest your tool could be made free from false positives? That should happen before inclusion in vet is considered.

You could make this slightly less prone to false positives if you collect two sets, one of plain identifiers, the other of homograph-containing identifiers mapped to their apparent strings, and if those two sets overlap, that's suspicious.
Homographs attacks in strings (targeting file names or URLs, for example) are more problematic because strings can be broken up, for example "goo"+"gle" and "g00g"+"1e" (using not-a-real-homograph for clarity) to defeat the simple set-matching.  Even reporting all such strings and requiring a //vet:homograph comment to note permitted cases is still vulnerable to trickier string constructions  in arrays of bytes, etc.  We could go down the rabbit-hole of flow-analysis (if the string can be copied to a filename context or a URL context, care a lot more about its provenance), and perhaps we should.

@mvdan is it a requirement that go vet be free from false positives? The docstring says:

Vet uses heuristics that do not guarantee all reports are genuine problems

There are also quite a few issues on the tracker about vet false positives, e.g. #11843, in which Rob says:

The shadow code is marked experimental. It has too many false positives to be enabled by default, so this is not entirely unexpected, but don't expect a fix soon. The right way to detect shadowing without flow analysis is elusive.

To me this suggests that go vet may contain false-positive code, although particularly sensitive checks should not be enabled by default. Of course, the tool should strive to keep false positives to a minimum. I will have to think about some strategies for this.
As far as I can tell, if go vet reports a false positive, it's always possible to refactor the code such that the logic is identical but go vet is silent. If a homograph check is added, I would want it to meet that standard. For example, @dr2chase suggested comparing plain identifiers to homograph-containing identifiers. If this check returns a false positive, it should be trivial to rename your identifiers such that go vet stops complaining. I would hope that most projects that use go vet allow it to twist their arm a little rather than disable it, even for small sections of code.
For projects that can afford to do so, my recommendation is to ban homographs from appearing anywhere in their source code (except for comments). This is what my glyphcheck currently enforces.

is it a requirement that go vet be free from false positives?

I believe there has been a push recently to make vet (with no flags) free from false positives, and to get it running on the Go codebase (standard library and toolchain).
I assume you want this check to be in the group that would be run by default, and not in the group that have to be enabled explicitly due to false positives.

For context re vet with no false positives: https://github.com/golang/go/issues/18084
Rob's comment that you referenced predates this proposal and effort.

I think a good place to start would be the overlap check that @dr2chase suggested, and a check for mixing ASCII and homographs in string literals (including import paths). This should catch the majority of viable attacks, and both checks can be circumvented by refactoring if needed. I will update glyphcheck with these changes and run it on the standard library to see how many false positives are flagged.

That sounds like a good idea. To find false positives, on top of the Go source code itself, you could use @rsc's corpus of well-known Go code: https://github.com/rsc/corpus

If I may ask a naive question, what is the threat model here, and how will vet address that threat?
If the concern is import paths, it might be better for go get to reject such import paths.
If the concern is variable names, where will that code come from such that vet is a relevant factor in helping to catch it?
If the concern is strings containing urls and user-provided data, maybe it would be better to have good library support for detecting these, say in net/url or a golang.org/x/text package.

If the concern is strings containing urls and user-provided data, maybe it would be better to have good library support for detecting these, say in net/url or a golang.org/x/text package.

https://godoc.org/golang.org/x/text/secure/precis#Profile.Compare

Using the new detection rules, the standard library contains only one string literal that gets flagged: "μs" in the time package.
The corpus contains 39 files with false positives, mostly in Unicode-heavy packages such as golang.org/x/text/language/display. Example: "afarabkhazianuavestanínafrikaansakanamháricuaragonésárabeasamésaváricuay"
There are also some packages where homographs are mixed with explicit escape sequences. Example from golang.org/x/text/currency: "\x00\x02Kz\x01$\x02A$\x02KM\x03৳\x02Bs\x02R$\x01P\x03р.\x03CA$\x04CN¥"
Most of the other false-positives are foreign-language names that contain accented characters. Example from github.com/spf13/hugo: Preserve taxonomy names as written ("Gérard Depardieu" vs "gerard-depardieu").
I did not detect any variable names that contain a mix of ASCII and homographs.
These results show that most packages containing false-positives contain a lot of false positives, so the maintainers of those packages would probably want disable homograph checking. This shouldn't incur much of a security risk as long as these packages contain mostly text and little logic.
However, there are definitely some cases where false-positives would be annoying, such as hugo. A better strategy is needed for these packages.
@josharian:

If the concern is import paths, it might be better for go get to reject such import paths.

This seems reasonable to me. Since import paths are typically domain names, we could employ the same strategies used to thwart the IDN homograph attack. Non-URL import paths probably aren't a threat.

If the concern is variable names, where will that code come from such that vet is a relevant factor in helping to catch it?

The attack scenario is code submitted via pull request to an open-source project, either by an anonymous user or a compromised team member. Running vet on all pull requests would detect the attack.

If the concern is strings containing urls and user-provided data, maybe it would be better to have good library support for detecting these, say in net/url or a golang.org/x/text package.

I definitely support runtime detection of malicious strings, but it's a separate problem. In fact, it's probably a more important problem to address, since users are much more numerous than developers.

See also #20209.  TL;DR, I think we should solve this in code review tools, not the language.

Blocked on #20209.

Unicode® Technical Standard #39 UNICODE SECURITY MECHANISMS
FYI.

Oops, sorry, I didn't see the status is Hold. Forwarding to 20209...


unable to add specific image tag using jib instead of latest

Description of the issue:
when i am using jib maven plugin to push my app to ECR repo , its adding the image in ECR as below.
<awsid>.dkr.ecr.us-east-2.amazonaws.com/test/testrepo:latest
But  i want to attach my application name and specific version to the image. is there any way i can achieve this. is it a bug in jib?
i am getting error while attaching the app name and version to image :
The repository with name 'test/testrepo/myapp' does not exist in the registry
i am using below configurations in pom.xml

com.google.cloud.tools
jib-maven-plugin
1.3.0
			<configuration>

				<from>
					<image>openjdk:8u212-b04-jre-slim</image>
				</from>
				<container>
					<mainclass>test</mainclass>

				</container>

				<to>
					<image><awsid>.dkr.ecr.us-east-2.amazonaws.com/test/testrepo</image>

				</to>

			</configuration>

			<executions>
				<execution>
					<phase>package</phase>
					<goals>
						<goal>build</goal>
					</goals>
				</execution>
			</executions>
		</plugin>

Expected behavior:
i want my application image should be pushed as <awsid>.dkr.ecr.us-east-2.amazonaws.com/test/testrepo/myapp:<version>
Steps to reproduce:

Environment:
jib-maven-plugin Configuration:
PASTE YOUR pom.xml CONFIGURATION HERE

jib-gradle-plugin Configuration:
PASTE YOUR build.gradle CONFIGURATION HERE

Log output:
Additional Information:

Hi @murali474,
This should work.
The repository with name 'test/testrepo/myapp' does not exist in the registry

The error message above might be true. Since you said you can push test/testrepo:latest, why don't you try test/testrepo:sometag instead of test/testrepo/myapp:sometag?

test/testrepo:sometag this way its working

Yeah, then I think the error message is right, and I think test/testrepo/myapp:latest will fail too. I don't think the tag string is the issue here. Maybe you should create the new repository test/testrepo/myapp somehow first? (I don't know ECR much.)

I understood that i need to create ECR repo as namespace/app then it will work

Yeah, then I think the error message is right, and I think test/testrepo/myapp:latest will fail too. I don't think the tag string is the issue here. Maybe you should create the new repository test/testrepo/myapp somehow first? (I don't know ECR much.)

Ah, I see. So, in the case of test/testrepo/myapp, looks like ECR either

doesn't support the format test/testrepo/myapp with 2+ slashes; or
test/testrepo as a whole (i.e., including the first slash) will be considered a namespace.

I will close the issue, as this is resolved. Feel free to re-open if you have more feedback on this issue.


Add support for denylist of file extensions

Ignore png,css,ttf.., etc files.

https://github.com/gbrls/kurl/commit/e75b1f54104d4ee81973ad367d8f7b9a85417a23


Animated bus

Summary of changes
Asana Ticket: Add updated animated bus image

I'm not sure how many of the Green Line -related tests rebasing this branch would fix, but it looks like there are plenty of error page-related tests to update as well!

test/site_web/controllers/helpers_test.exs:21
test/site_web/controllers/helpers_test.exs:386
test/site_web/views/error_view_test.exs:14
test/site_web/views/error_view_test.exs:19
test/site_web/views/error_view_test.exs:24
test/site_web/views/error_view_test.exs:40
test/site_web/controllers/fare_controller_test.exs:29

🥲 we made it.  all tests updated.


hie fails to compile mutually recursive modules

With mutually recursive modules, e.g.

# ------------- ModuleA.hs ---------------------------
module ModuleA where

import {-# SOURCE #-} ModuleB

newtype A = A Int
# -------------ModuleB.hs ---------------------------

module ModuleB where

import ModuleA

foo :: Int
foo = 34

# ------------ModuleB.hs-boot----------------------------
module ModuleB where

-- import ModuleA (A)

foo :: Int
#---------------------------------------------------------

hie reports error when working with moduleA, and stops to provide diagnostics:

/private/var/folders/j8/1wn_n3g12171_ly1q141dr28507kn_/T/ghc-mod32137/ModuleA32136-3.hs:3:23: error:
Can't find /private/var/folders/j8/1wn_n3g12171_ly1q141dr28507kn_/T/ghc-mod32137/ModuleB32136-2.hs-boot

stack builds the project successfuly.
hie version:
Version <IP_ADDRESS>, Git revision 726c37e52ac25e034ec25118eb1bea4dedb03aba (2457 commits) x86_64 ghc-8.6.3
Version <IP_ADDRESS>, Git revision d049fdfeef422933912c66245a50904ee98f86d0 x86_64 ghc-8.6.2
OS: Mac OS Sierra

@mpickering , does your new hie-bios deal with this properly?

Yes it does but not perfectly. GHC has a lot of hs-boot files so I needed to deal with it.

Ok, so I think it is best to use this as a requirement on hie-bios, rather than try to fix it with the current setup.


Trivy Operator Parser additionalVulnerabilityReportFields

This feature allows adding Target, Class, PackagePath and PackageType already managed in trivy reports
related to:
trivy-operator additionalVulnerabilityReportFields
  # -- additionalVulnerabilityReportFields is a comma separated list of additional fields which
  # can be added to the VulnerabilityReport. Supported parameters: Description, Links, CVSS, Target, Class, PackagePath and PackageType
  additionalVulnerabilityReportFields: ""

@manuel-sommer Would you like please to review this PR again,
Thx


Create FlatLink

Lagde FlatLink komponent
Screenshots:

Should the disabled attribute be set as well?

Should the disabled attribute be set as well?

FlatLinks are a-elements, and they don't have a disabled attribute unfortunately. That's why i had to create a withDisabled function to put disabled into the config if needed.

Aha! Didn't know that. Looks good then!


[5.3] Lazily Associate a SILRemarkStreamer with an LLVMContext

Cherry-pick #31167 to 5.3 because the refactoring that broke this went in before the branch date.

@swift-ci test and merge

Builder died
@swift-ci test macOS

⛵


ImportError: cannot import name GlobalAveragePooling2D

I got the following error
Using TensorFlow backend.
Traceback (most recent call last):
File "ssd.py", line 9, in
from keras.layers import GlobalAveragePooling2D
ImportError: cannot import name GlobalAveragePooling2D

Solved after I updated Keras.


WIP: Add completion for keywords

PR Summary
Adds completion for language keywords like "switch", "break", etc.
I originally thought this would take a lot of effort, but I thought of a simple solution of simply trying to insert the various keyword categories into the text and see if they are parsed as keywords, though there are some special cases where I try to properly analyze the Asts.
For the tooltips, I'd appreciate it if someone from the documentation team like @sdwheeler could look them over to see if they can improve them.
WIP: Because I still plan to add the namedblock keywords (param, begin, process, etc.) and I also need to add tests.

PR Context
Fixes https://github.com/PowerShell/PowerShell/issues/10221
Fixes https://github.com/PowerShell/PowerShell/issues/7891

PR Checklist

[X] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[X] Summarized changes
[X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[X] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[X] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[X] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Thanks @sdwheeler you are right that those using statements are not currently supported but I'm assuming/hoping that this PR: https://github.com/PowerShell/PowerShell/pull/16734 which adds those features will get merged in the near future.

The working group discussed this and likes the concept. The code reviewer should consider whether this should be an experimental feature.


ES6 modules not supported in Node.js yet

node.js implementation should use ES5 modules still no?

It compiles to CommonJS module format. I just pulled down the package to test and it works fine in Node without any sort of transpilation.

I changed from "esnext" to "commonjs" in /tsconfig.json of my current project to fix the issue ... do I understand the probleme correctly ?


Fix typo

Fixes https://github.com/MicrosoftDocs/feedback/issues/1629
Please validate this is correct

@mairaw : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[BUG] Backup fails to complete due to timeout causing duplicate backups

Describe the bug
Scheduled backup to S3 results in multiple copies of each individual backup in S3.  Furthermore, automatic cleanup appears to be broken.
To Reproduce
Steps to reproduce the behavior:
Prerequisite: Configure S3 Backups

Create a volume in Longhorn
Configure snapshots twice a day, retaining 1 (not necessary).
Configure backups twice a day, retaining 4.

Expected behavior
1 snapshot is retained (this works)
Each backup results in one backup
4 backups are retained and any older backups are cleaned up.
Actual behavior
1 snapshot is retained
Each backup results in 4 backups
Old backups are not cleaned up
Log & Screenshot

(I cleaned up many of the older backups)
Support Bundle
Environment:

Longhorn version: v1.1.0
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: kubeadm, v1.19.7

Number of management node in the cluster: 3
Number of worker node in the cluster: 6 total, 3 with replicas

Node config

OS type and version: Ubuntu 20.04.1 LTS
CPU per node: 8
Memory per node: 16GB
Disk type(e.g. SSD/NVMe): NVMe (Samsung 970 Evo Plus)
Network bandwidth between the nodes: 1Gbps

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Baremetal
Number of Longhorn volumes in the cluster: 15

Do your backups even complete effectively?
I also have this issue since a week but i think it is due to some backups suddenly starting crashing (cleanup not being kicked off afterwards, or cleanup causes crashing?)
2021-03-01 02:02:00
time="2021-03-01T01:02:00Z" level=info msg="Running recurring backup for volume pvc-1129530a-ceb8-4c33-9072-47144695729a"
2021-03-01 02:01:24
time="2021-03-01T01:01:24Z" level=fatal msg="Error taking snapshot: failed to complete backupAndCleanup for pvc-1129530a-ceb8-4c33-9072-47144695729a: Post \"http://longhorn-backend:9500/v1/volumes/pvc-1129530a-ceb8-4c33-9072-47144695729a?action=snapshotCreate\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"
2021-03-01 02:01:24
time="2021-03-01T01:01:24Z" level=info msg="Handling volume detachment for volume pvc-1129530a-ceb8-4c33-9072-47144695729a"
2021-03-01 02:01:14
time="2021-03-01T01:01:14Z" level=info msg="Running recurring backup for volume pvc-1129530a-ceb8-4c33-9072-47144695729a"
2021-03-01 02:00:57
time="2021-03-01T01:00:57Z" level=fatal msg="Error taking snapshot: failed to complete backupAndCleanup for pvc-1129530a-ceb8-4c33-9072-47144695729a: Post \"http://longhorn-backend:9500/v1/volumes/pvc-1129530a-ceb8-4c33-9072-47144695729a?action=snapshotCreate\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"
2021-03-01 02:00:57
time="2021-03-01T01:00:57Z" level=info msg="Handling volume detachment for volume pvc-1129530a-ceb8-4c33-9072-47144695729a"
2021-03-01 02:00:47
time="2021-03-01T01:00:47Z" level=info msg="Running recurring backup for volume pvc-1129530a-ceb8-4c33-9072-47144695729a"
2021-03-01 02:00:36
time="2021-03-01T01:00:36Z" level=fatal msg="Error taking snapshot: failed to complete backupAndCleanup for pvc-1129530a-ceb8-4c33-9072-47144695729a: Post \"http://longhorn-backend:9500/v1/volumes/pvc-1129530a-ceb8-4c33-9072-47144695729a?action=snapshotCreate\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"
2021-03-01 02:00:36
time="2021-03-01T01:00:36Z" level=info msg="Handling volume detachment for volume pvc-1129530a-ceb8-4c33-9072-47144695729a"
2021-03-01 02:00:26
time="2021-03-01T01:00:26Z" level=info msg="Running recurring backup for volume pvc-1129530a-ceb8-4c33-9072-47144695729a"

I am guessing the timeout will mark the job as failed.
Even though the backup is actually running and will complete successfully.
Thanks for reporting we will look into this.

I am guessing the timeout will mark the job as failed.
Even though the backup is actually running and will complete successfully.
Thanks for reporting we will look into this.

keep in mind that the logfile i posted might not be related to the problem of @tyzbit .
it does however seems to be a 'possible' scenario.
@tyzbit do you see failed backjobs ? (kubectl get job )

I cannot find the root cause. The related backup pods as well as some old replica manager pods are gone, and the info in the longhorn manager is insufficient. This bug maybe not related to the snapshot/backup timeout. There is no timeout error for all snapshot creation and backup creation. And the interval between 2 snapshot creations or backup creations is less than 1 minute, which is the timeout that triggers https://github.com/longhorn/longhorn/issues/2029. I guess the recurring backup pods may get crashed quickly due to some unknown reasons.
I do find some weird logs in the support bundle but I don't think it's the cause:

There are some snapshot deletion failure logs during the last 4 backup creations. These errors should block the backup creation job rather than duplicate backups.  So that we can check if the pod succeeded, or failed due to some reason.

similar problem here but i receive a very odd behaviour.
number of volumes: 3
cluster created via kubeadm, running on raspberry pi's (arm64)
backup policy: twice a day, retain 4
backup to S3: backblaze
volume 1 created 8 days ago (size 5Gi, actual size ~750MB) has each backup showing up multiple times. in contrast to @tyzbit i don't see a pattern here. sometimes it's showing up as 2 backups, sometimes as 3 and sometimes as 4. i didn't observe more than that. overall i have 41 backups since 8 days. without retention settings, this should max out at 16, with the retain option set it should no be more than 4.
volume 1 created 5 days ago (size 128Mi, actual size ~44MB) has a completely different behaviour to volume 1 with retention working (i only have 4 backups showing) but each backup is duplicated. that said, i have 2 backups of time X and 2 backups of time Y, totalling to 4 backups as per the retain option.
volume 3 created 43 mins ago (just before the backup schedule started, size 128Mi, actual size ~26MB) and should only have 1 backup existing at all. however, it shows this backup 3 times, so i see 3 backups at the same time.
i also saw 2 jobs getting killed by kubernetes due to backoff (Job has reached the specified backoff limit) which belong to exactly those volumes where the backups show up multiple times.
from this observation it looks like backups are done successfully but afterwards, when the cleanup happens, the jobs fail (no logs left due to kubernetes terminating the pod). looking at the volume sizes i'm not sure if a timeout can happen as the last volume is very small and shows the same problem.

Just as an update, I pruned my volumes down to 10 volumes total and scheduled a backup on the problematic volume which completed successfully with only one backup saved.  I am also going to upgrade to 2.5GbE tomorrow which should put me in spec for the recommended network throughput for 10 volumes.

Regarding the question https://github.com/longhorn/longhorn/issues/2278#issuecomment-791173613, when we failed to delete a snapshot, we return nil and continue to take the backup here:
https://github.com/longhorn/longhorn-manager/blob/f6ff18666ea238c4eec4bfdce9612796da1a0701/app/volume.go#L297
I think this is intended behavior , not a bug  because we would rather have extra backup than missing backup.
For the reason why deleting snapshot fail, it is because of volume is rebuilding. For why the volume is rebuilding, it is likely because of the network not being fast enough. This is confirmed by https://github.com/longhorn/longhorn/issues/2278#issuecomment-804913204

I believe I spoke too soon.  When I did a manual backup it completed successfully however I re-enabled scheduled backups and the issue is back with 3 backups for every backup.

I upgraded to 2.5GbE between the nodes as well, which puts me in spec for recommended bandwidth with respect to the number of volumes I have.
One thing I don't think has been brought up is guaranteed engine CPU - I discovered I'm currently at 0.5 for 10 volumes (I thought I had increased this).  I will increase this to 1.0 and will report back my results.

Increasing the guaranteed CPU to 1.0 had little effect; my cluster has a good amount of spare CPU per node so Longhorn would have had more CPU when it needed it.
I actually happened to catch the backup run about 5 minutes after it started and it looks like two backups are started basically at once

Backup configuration

Here are the logs from the 2 minutes when those backups started.  I knew the backup failed and thats why a second one was created, but I didn't realize those events happened in less than a minute.  That doesn't seem like very long to wait for the backup to finish.

2021-03-29 03:50:50 | pvc-77903a7e-7c93-4522-8f72-6e9c5c8dff7e-c-xy9ruf-c | cameraman | pvc-77903a7e-7c93-4522-8f72-6e9c5c8dff7e-c-xy9ruf-c-161698r5nnc | time="2021-03-29T03:50:50Z" level=fatal msg="Error taking snapshot: failed to complete backupAndCleanup for pvc-77903a7e-7c93-4522-8f72-6e9c5c8dff7e: Post "http://longhorn-backend:9500/v1/volumes/pvc-77903a7e-7c93-4522-8f72-6e9c5c8dff7e?action=snapshotBackup\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"

Found some backup failure caused by the timeout. Need to check how long the timeout is and how the timeout can be triggered in v1.1.0 & v1.1.1.

Just want to close the loop on this and confirm that by updating to 1.1.2 backups are working as expected.  Good work!


Automating initialisation of baremetal for self-hosted-runners

Current Behavior

Currently we are

Doing baremetal initialisation manually by going to the equinix UI.
Doing the setup by manually SSHing and creating users, installing dependencies etc.

The instructions are mentioned here
Desired Behavior

Ideally both these tasks should be automated, using the equinix APIs and tools like terraform
Implementation

We can use tools like terraform and use existing terraform support for equinix APIs to achieve this.
https://github.com/equinix/terraform-provider-equinix
https://github.com/equinix/cloud-provider-equinix-metal
https://github.com/machulav/ec2-github-runner#example
Acceptance Tests

Successful action runs with complete automation would solve this issue
Additional Comments
@leecalcote @gyohuangxin would creating a runner on demand (i.e. after starting a workflow) mean that the self-hosted-runner in itself would not be needed? Given we have to register a self-hosted-runner to a repository first.
https://docs.github.com/en/actions/hosting-your-own-runners/adding-self-hosted-runners

Contributor Guide

Thank you for open this issue @hershd23

@leecalcote @gyohuangxin would creating a runner on demand (i.e. after starting a workflow) mean that the self-hosted-runner in itself would not be needed? Given we have to register a self-hosted-runner to a repository first.

I think it's not exactly correct. If we follow this way: https://github.com/machulav/ec2-github-runner#example.  It uses a github-runner to create a self-hosted runner on demand, but we still need to register this self-hosted runner to github repository to receive the job from our github action. It can be implemented with self-hosted REST API: https://docs.github.com/en/rest/reference/actions#self-hosted-runners
Therefore, in my opinion, our example of benchmark workflow on self-hosted runner will look like below:
name: Configurable Benchmark Test
on:
  workflow_dispatch:
    inputs:
      profile_name:
        description: "performance profile to use"
        required: false
      profile_filename:
        description: "test configuration file"
        required: false
      service_mesh:
        type: choice
        required: false
        description: "service mesh being tested"
        options:
          - istio
          - linkerd
      load_generator:
        type: choice
        required: false
        description: "load generator to run tests with"
        options:
          - fortio
          - wrk2
          - nighthawk

jobs:
  start-runner:
    name: Start self-hosted CNCF CIL runner
    runs-on: ubuntu-latest
    outputs:
      label: ${{ steps.start-cil-runner.outputs.label }}
      cil-instance-id: ${{ steps.start-cil-runner.outputs.cil-instance-id }}
    steps:
      - name: Configure CNCF CIL credentials
        ......
      - name: Start CNCF CIL runner
        id: start-cil-runner
        uses: layer5io/meshery-smp-action
        with:
          mode: start
          github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
          cil-image-id: ubuntu-20.04
          cil-instance-type: c3.small.x86
          user-data-scripts: ....
          ......
  register-runner:
  	name: Register the self-hosted runner to github repo
  	runs-on: ubuntu-latest
  	steps:
  	......
  run-benchmarks:
    name: Run the configurable benchmarks on the runner
    needs:
      - start-runner # required to start the main job when the runner is ready
      - register-runner # required to register-runner
    runs-on: ${{ needs.start-runner.outputs.label }} # run the job on the newly created runner
    steps:
      - name: Setup Kubernetes
      	......
      - name: Checkout Code
        ......
      - name: Install Service Mesh and Deploy Application
        ......
      - name: Run Benchmark Tests
        ......

  stop-runner:
    name: Stop self-hosted runner
    needs:
      - start-runner # required to get output from the start-runner job
      - run-benchmarks # required to wait when the main job is done
    runs-on: ubuntu-latest
    if: ${{ always() }} # required to stop the runner even if the error happened in the previous jobs
    steps:
      - name: Configure CNCF CIL credentials
      	......
      - name: Stop CNCF CIL runner
      	......

@leecalcote @navendu-pottekkat Do you have any comments on above workflow design?

@gyohuangxin This sounds good to me. The workflow looks straightforward.

Hmm right @gyohuangxin.
I wasn't so sure that it was possible to register a runner at runtime. Your flow makes a lot of sense.

I wasn't so sure that it was possible to register a runner at runtime. Your flow makes a lot of sense.

I looked at the workflow to run aws github runner, the answer is yes.  The workflow for registering a runner via API will be:

Get registration token from github api:  https://github.com/machulav/ec2-github-runner/blob/c34ba2df3363ebde9d19fdbc341e03d02267284d/src/index.js#L13
Start the machine with a userdata script which contains self-hosted runner registration steps. This script will be executed as soon as the machine starts, and it will use above registration token to register the self-hosted runner.
https://github.com/machulav/ec2-github-runner/blob/c34ba2df3363ebde9d19fdbc341e03d02267284d/src/aws.js#L6

I'm testing it on CNCF CIL runner and will raise a PR later.

I raise a PR to automate the initialization of on-demand self-hosted CNCF CIL runner.
With this workflow, the CNCF CIL machine can be created and registered as the self-hosted runner to run benchmarks on. After the benchmarks done, the machine will be stopped and removed.
You can see the workflow and details from https://github.com/gyohuangxin/meshery-smp-action/actions/runs/1897832766.
I still have some issues on the installation of dependences, so I made it a draft PR. But any comments are welcome.


Update schema to 2.3.0

This PR updates the schema to match TensorFlow version 2.3.0

Thank you for updating v2.3.0! @lgeiger
I am sorry that shrub is not public yet (planning to make public in coming two months). I am merging this now and check if we can remove the shrub==0.0.2 ping later.
If everything looks good, we can expect to see v2.3.0 via pip soon :)
Thank you.


example contains(array, "") seems to be unsupported

Had to debug, seems that contains(steps.changed-files.outputs.files, "package-lock.json") is (no longer?) supported by the runner engine, it works with contains(steps.changed-files.outputs.files, 'package-lock.json')

that's weird .. thanks for reporting! I'll update the readme


Map and WeakMap object support

Fairly robust type and edge-case support, but the Array support is shaky at time of writing.

Just learned that $ must have some significance to either GitHub or git itself; the commit messages referencing prepare$Map, etc, have all been stripped clean of that context.

Resolves #14 ( Support Map )


adding docsPluginId parameter for  navbar

show how to use the docsPluginId parameter to show multiple instances of  Docs in navbar items

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[-] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[-] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
improve docs as I need help with it through Discourse which could have been avoided by this little bit

Hi,
thx for reviewing the PR .
Reading it again I admit is not ideal but I still see the documentation in this specific being ideal either 😃 .
Without support from the discord channel I might would still be lost.
The main issue I have is that, that the examples not stay consistent through the entire page  https://docusaurus.io/docs/docs-multi-instance.
In the beginning, the use case is Mobile SDKs documentation than it is switched to Product & Community. At the very end it is switched to Mobile SDKs documentation again. If only Product & Community would the use case, all would be more self explaining.
I agree that this does not perfectly fit for the "Versioned and unversioned" but I'm sure we would find a solution here.
If the document could be read in single flow without switching the use case, it could be fully self-explaining may would have saved from asking around in the chat.
I addition, I had to read https://docusaurus.io/docs/api/themes/configuration#navbar-doc-link-docId where I find 1:1 docsPluginId but another slight difference in regard to the Document ID, what is called here docID.
If you are in the middle of something and not using an app frequently such little details could become quite big obstacle.
In the latter case, If

docId
string
Required
The ID of the doc that this item links to.

reference to https://docusaurus.io/docs/next/create-doc#document-id things become clearer to average user as me, as there not any open end. You can read in one flow.
I hope it is understandable, I have simply written it down from my soul.

I'm ok to make this doc page more consistent. But please open a good PR to improve it.

will do

I'm not sure to understand what's your confusion between docId and docsPluginId:
can imaging 😆 will try to explain it differently


python311Packages.fritzconnection: 1.13.1 -> 1.13.2

Diff: https://github.com/kbr/fritzconnection/compare/refs/tags/1.13.1...1.13.2
Changelog: https://fritzconnection.readthedocs.io/en/1.13.2/sources/version_history.html
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255925 run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.fritz

5 packages built:

home-assistant-component-tests.fritzbox_callmonitor
python310Packages.fritzconnection
python310Packages.fritzconnection.dist
python311Packages.fritzconnection
python311Packages.fritzconnection.dist

1 package failed to build:

home-assistant-component-tests.fritz

That also fails on master.


Add swipe gestures to enable it to play in mobile

For now, only the desktop version works. Mobile version to be implemented using swipe gestures

can do so but will need time till tommorow ,cuz broh you have defined movement in different files for different game   modes@SubhamKarmakar24 ,
if you can wait then assign it to me i can work on that when i'm free
Anyway it is really cool.💙💙

can do so but will need time till tommorow ,cuz broh you have defined movement in different files for different game modes@SubhamKarmakar24 ,
if you can wait then assign it to me i can work on that when i'm free
Anyway it is really cool.💙💙

Yeah, take your time. You can change one file and we will wait for the issue #3 to be resolved so that it works for all game modes

@SubhamKarmakar24  Hello broh, i have made changes in the limitless1.html page,as i told you earlier there is seperate script for every game mode,so i will have to make changes in all of em,
kinda busy with homework now, would work with rest of pages tommorow.
So should i make a pr for the work till now?

here is the pr i made,
solution

here is the pr i made,
solution

If you plan to add touch controls for the last 2 modes, let me know. The different game modes have been combined

My classes are going on so little busy, i will make a pr soon
and thanks for merging sir

My classes are going on so little busy, i will make a pr soon
and thanks for merging sir

Yeah. Take time. Everyone's busy with the online classes these days : )


Two Questions Regarding CMN model source code

Have read the paper and the source code, found two curious points.

In the paper, the memory representation directly uses (equals to) the GRU's internal states. But in the code, it seems the memory representation goes through another GRU cell.
As you can see below, the "ownHistoryRNNOutput" are already the hidden states from the GRU cell, they are however further fed into the "self.memoryGRUown", which doesn't accord with the descriptions in the paper.

input_rnn_outputs_own, final_state = tf.nn.dynamic_rnn(self.memoryGRUown, ownHistoryRNNOutput, dtype=tf.float32)
output_rnn_outputs_own, final_state = tf.nn.dynamic_rnn(self.memoryGRUown, ownHistoryRNNOutput, dtype=tf.float32)
So which one is correct?

In the same part of the code which we can see above, it seems the "input_rnn_outputs_own" and "output_rnn_outputs_own" share the same GRUCell (I didn't find any scope definition),  therefore should have the same values. This also doens't accord with the descriptions in the paper, which uses two different GRU cells, M and M'.

Could anyone explain them to me? Or I misunderstood somewhere?

Hi @PeterPanUnderhill ,
First of all, thank you for your interest in our work in conv-emotion.
Let me clarify that the results in our CMN paper are based on the exact architecture written in the paper.
The repository here is a reimplementation based on our format of the ICON model, which induced some changes, such as the ones you mentioned above. The extra GRU in the memory representation is influenced by the DGIM module in ICON. We also experimented with reducing parameters by tying the weights of the input and output GRUs. These changes didn't provide significant differences in our original CMN results. However, we encourage you to try the other versions as well. Hope this helps!

u

Hi @devamanyu , thanks for you quick and detailed reply.
Now I understand this is not the exact implementation of CMN, and it explains the difference between the paper and the source code. I thought I was missing something either in the paper or in the code, it's good to know that I didn't misunderstand. Since there's no significant difference in the results of the two models, I will first try with this version :)
By the way, cool work with emotion recognition from conversations. I have read many papers from your group and will keep following your progress.
Thanks again for the explanation!

Thanks @PeterPanUnderhill. As you are interested in this topic, please take a look at this paper - https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=8764449


#433 - Changed links in menu

https://github.com/cucumber/docs.cucumber.io/issues/433

Removed API Docs and 3rd Party Tools
Added 10 Minute Tutorial and Guides

I don't know if this is correct but it seemed to work locally for me.

You can preview your changes by clicking "Details" after "netlify/cucumber/deploy-preview — Deploy preview ready!" above. (Just in case you want to preview your changes for a next PR).

If anyone with more Front end knowledge wants to have a look, please do. Otherwise I'll merge in 24 hrs.

Thanks @helenjoscott!


span('week') option to start week on Sunday instead of Monday

arrow.utcnow().span('week') starts on Monday and ends on Sunday. I would like an option to start the week on Sunday and end on Saturday.

I am interested in working on this issue, will look further into by next week or so

We could use https://docs.python.org/3.8/library/calendar.html#calendar.Calendar for this.

I am interested in working on this, can I look into it?

Can we work on this?

Hey @oakt, if you’d like to contribute this change, PRs are welcome :).

@jadchaar
Can I take this?


How Long To Train COCO?

Right now I am using the COCO dataset instead of Pascal VOC. COCO has a lot more images so I'm not sure how long this is supposed to take. I am using an Nvidia RTX 2070 Super GPU for training with a batch size of 8. All other parameters are left as default. After 2 and a half hours I am at iteration 31,000 with the loss typically being about 6.0. Is there a point when I can expect this to finish? I couldn't find in the code how many epochs this is supposed to run for so I'm not sure how many iterations to expect. Is it the case that I am expected to just stop the training at some point otherwise it will just continue training forever? I appreciate any advice.

In general, if I say, you should see the loss if the loss is not improving after 2-3 epochs max. Then you can stop the training and change some hyperparameters such as batch size, learning rate etc. Then, again continue training you might improve.


Change size dialog bug (gfx)

Every change size dialog is shaking up and down and does not show changes until closed and reopened.
Android 5.1.1 (Stock)
Screen: 480x854
Build: 1st one in F-Droid repo

A video of the issue would be very helpful, this sounds like it will be hard to debug.

I'll try to make one today.

I have experienced this bug long times ago, it is the problem of the ConstrainLayout and the MaterialDialog , now it seems ok cause I switched to RelativeLayout.


rolloff cannot be zero in this repo

Error while rolloff is setted to zero in function rcFilterTaps() or rrcFilterTaps.

Where is that function?


Message Type Clarificiation

There is a lack of clarity regarding the difference between a channel message and a post message.  At first I thought perhaps channel messages was a combined count of post and reply, but that does not add up when looking at the totals shown in my environment. (If it IS a combined count and there is just an issue with my reporting, I think that should be clarified since so many other metrics are stand alone and since there would then obvious be an opportunity for the numbers not to add up, leading to confusion.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2758a3d6-c646-dcb0-2a31-c7b9b84e780b
Version Independent ID: 8704c9fe-f8b0-82d2-bd83-3fd1a9ad638d
Content: Microsoft Teams user activity report - Microsoft Teams
Content Source: Teams/teams-analytics-and-reports/user-activity-report.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@KazuyDarklight Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Real traders best chatroom since 2017, It’s turned $1.1M in the last 5 Months, Join with 7k+ active traders & Improve your trading performance. Join our trading chatroom today https://discord.gg/sC3sw4s

Is there already an explanation about this question?
we have the same one.

Hi @KazuyDarklight, thank you for your feedback.
I experienced the same behaviour:

@LanaChin Could you kindly help us to find an explanation for this? Thanks!

@LanaChin Hi Lana could you please help on this issue?

Looking into this

@LanaChin Wondering if there is an update here? Thanks!

Btw: What exactly means if the Display Name shows as - -?

Btw: What exactly means if the Display Name shows as - -?

It's an user that's removed from ur tenant

Thanks boyday94. But (at least from the view I have on different tenants) there are too many such entries for small time periods (e.g. 30 days), that I believe, that this is the only reason. How do you think about?
For example, I have here my Dev-Tenant with Contoso installed. Never changed User Accounts but still see, the most active user is the "--". For this case, it could be, that the activities were triggered via Microsoft Graph API.

I've pinged the PM for guidance on channel/reply/post messages.

@LanaChin  @KazuyDarklight Channel messages does include post and reply message types.  In the definition of Post messages it qualifies as "unique post messages", whereas, the Channel Message definition says only "unique messages" and this implies it includes all of the messages, both the posts and also the replies.  Similarly, for Reply Messages, it is qualified as "unique reply messages".
As per definition
•	Channel messages is the number of

unique messages

that the user posted in a team chat during the specified time period.
•	Reply messages is the number of

unique reply messages

that the user posted in a team channel during the specified time period.
•	Post messages is the number of

unique post messages

that the user posted in a team channel during the specified time period.
It's helpful to include the "Reply Message" definition above.  Now, from these definitions we can derive that Channel Messages will include the unique count of all the messages, including the Post  and Reply Messages.  If you are not seeing that and have a specific example, please share back here in this thread.  In meantime, we appreciate the question and will consider this question as we work to enhance our docs.

Thank you @quentinhurdazure! Closing this issue.


Adding a custom field fails with "An unexpected error"

Hi,
First, great work! I've been playing around, and i seem to be unable to add a custom field from the Chrome extension(can't try it from the Web Vault because, like in #24 , objects aren't visible), it fails with "An unexpected error occurred" in the interface, and the following in the logs(running with docker-compose with one nginx, one bitwarden-go and one bitwarden-web with @leonghui 's containers):
                                                                                bw_back_1  | 2018/03/17 16:57:51 XXX is trying to edit his data                                                                                bw_back_1  | 2018/03/17 16:57:51 Cipher decode errorjson: cannot unmarshal array into Go struct field newCipher.fields of type string
nginx      | 2018/03/17 16:57:51 [error] 7#7: *768 upstream prematurely closed connection while reading response header from upstream, client: XXX.XXX.XXX, server: mybw.com, request: "PUT /api/ciphers/6 HTTP/2.0", upstream: "http://<IP_ADDRESS>:8000/api/ciphers/6", host: "mybw.com:8000"

And it seems the reason is at https://github.com/VictorNine/bitwarden-go/blob/master/internal/api/api.go#L172
Are custom fields supported?
Cheers,
Adrian

That's right these are not supported yet

I have implemented custom fields and Notes (at the moment only strings). So if you want to try it, you can use my forks master branch.
I plan to submit a pull request in the next time, but as I have done major changes it is hard to make my branch compatible with VictorNines.


chore: upgrade dependencies

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.08% :tada:

Comparison is base (d90e6b2) 92.97% compared to head (60b3a8c) 93.06%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
+ Coverage   92.97%   93.06%   +0.08%
==========================================
  Files           1        1
  Lines         242      245       +3
  Branches       51       49       -2
==========================================
+ Hits          225      228       +3
  Misses         17       17

Files Changed
Coverage Δ

src/index.ts
93.06% <100.00%> (+0.08%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wrong usage of Polymer.RenderStatus.afterNextRender in the upgrade guide

Description
In the upgrade guide Polymer.RenderStatus.afterNextRender gets used with a function as its first parameter
attached: function() {
  Polymer.RenderStatus.afterNextRender(function() {
     // measure something
  }.bind(this))
}

however this throws an error. The method definition expects the first parameter to be an element (thisArg of the function) source code
Steps to Reproduce

Create any element
Add Polymer.RenderStatus.afterNextRender with a function as first parameter

Versions

Polymer: v1.7.0

@Pupix Yup, the correct usage supposed to be like this:
attached: function () {
  const ensureThisElemRendered = this;
  Polymer.RenderStatus.afterNextRender(ensureThisElemRendered, function runAfterRender() { ... })
}

cc @arthurevans

Oops. Right you are. (Although @motss I think the first argument is simply the this argument to pass to the callback.)

@kevinpschaaf @arthurevans  changing the afterNextRender input signature makes it impossible to write hybrid elements that work in 1.x and 2.x.

@valdrinkoshi I think there's already a fix in the works: https://github.com/Polymer/polymer/pull/4323

This has been fixed in https://www.polymer-project.org/2.0/docs/upgrade#callback-contracts-have-changed


Option to remove play button

Can we add option to remove play button?

I surely hope so!
Actually, those buttons are added there and there is even an issue on VSCode repo talking about making them optional.
https://github.com/Microsoft/vscode/issues/38333
I believe it's already there, we could think of a way we could do it ourselves (from within this plugins)

Microsoft/vscode#38333 was closed (completed) and the only thing they did was adding a new config (keyboard.touchbar.enabled) to completely disable the Touch Bar support.
É bucha... 🤦♂

I've also been looking for a way to do this. I don't find the default touchbar buttons on VSCode useful.

yup, still waiting for a way to do that! It would be great, we would have much more space to deal with, right?!

Landed in VSCode via https://github.com/microsoft/vscode/pull/70174


feat: add autocomplete for cluster set command

Description:
kurtosis cluster set has no autocomplete; had a go at adding this.
I wasn't 100% sure how to test, but what I did was use the __complete command then compare its output to the similar context set command:
√ kurtosis % ./cli/cli/scripts/launch-cli.sh __complete context set ""
cloud-<hash>
default
:36
Completion ended with directive: ShellCompDirectiveNoFileComp, ShellCompDirectiveKeepOrder
√ kurtosis % ./cli/cli/scripts/launch-cli.sh __complete cluster set ""
docker
k3d-k3s-default
minikube
:36
Completion ended with directive: ShellCompDirectiveNoFileComp, ShellCompDirectiveKeepOrder

I'm not sure how to test this for real, i.e. hitting tab in my shell to see autocomplete results.  Maybe some config needed on my side?
Is this change user facing?
YES
References (if applicable):

Update on testing: the local build at ./cli/cli/dist/cli_darwin_arm64/kurtosis will let you test autocomplete properly


WIP: add store and part of the state

Consider using our customize error handler instead of default one


[AVM Module Issue]: Update the RecoveryService/Vault module  to use the latest API

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/recovery-services/vault
(Optional) Module Version
No response
Description
RSV created by this module are missing the monitoringSettings part which drives the alerts coming from Azure Monitor (the default setting when creating RSV from the portal) instead of from classic method. Because of this, the Deploy RV Backup Health Monitoring Alerts AMBA-ALZ policy, which is a modify policy, is failing to remediate.
We have got 2 issues in AMBA-ALZ pattern:

https://github.com/Azure/azure-monitor-baseline-alerts/issues/374
https://github.com/Azure/azure-monitor-baseline-alerts/issues/348

Thanks.
(Optional) Correlation Id
No response

Hello @Azure/avm-core-team-technical-bicep ,
is there any news on this one?
Thanks,
Bruno.

Hey @Brunoga-MS,
please excuse there has not yet been a reply. I can only assume the notification got lost on @alexanderojala.
That being said - @alexanderojala, please triage the issue at your earliest convenience (i.e., check if it makes sense - which I guess it does, and give an estimate when you may or may not be able to implement the requested changes). Thanks :) 💪

Hey @Brunoga-MS,
regarding the monitoringSettings I can see that the module has a parameter for that and that the property is set accordingly. Could you elaboration what may be missing? Is it really just the API version and the setting will magically start working once it is updated?
If so - I linked a PR @alexanderojala is already working on (#3821) that should address the issue.

PR is linked


CMake + Windows support + CI/CD

Hi,
Like I mentioned in #14 here is my current PR for all the changes I brought to your great project:

cmake is now the build system generator to replace autoconf, simply because cmake works universally. Also started adding (some of the) test rules, because to port them all requires a lot of changes and I wasn't sure you'd be comfortable to adding that many changes all at once.
made the library fully Windows compatible (which is the main reason for switching to cmake)
integration to GH Actions for CI + CD purposes: it will automatically test the bins generated (only asmline and run so far) and if successful will generate artifacts for both windows (header, lib, dll and pdb) and linux (headers and .so) : see https://github.com/hugsy/AssemblyLine/actions/runs/1894958934 for an example . Pretty sure macos-latest can be added to generate artifacts for macos too without trouble.
fixed a logic bug in tokenizer.c (with the use of strtok) found by sanitizer

Great project, super useful! The only useful alternative was keystone-engine, but this is way lighter and easier to embed.
Cheers,

Hi,
that looks wonderful! Thank you very much!
We are happy to move to cmake if we can get included:

man pages (does windows have an equivalent?)
make install (or at least some documentation on how to install, and what the dependencies are, we are rather un-familiar with cmake, (make install does not work, and cmake --install . --prefix /tmp )
make check to go through the test directory and check if asmline emits the same binary code as nasm would.

nice2have: the tap files, which are typically used during development to check where / which instruction is different to nasm's
nice2have: the eaf files, which are test-cases, where we 'expect assmeblyline to fail' -- on invalid input (rather than silently ignoring/assembling something)

pc installation file, for dependent projects to be able to specify required versions

👋
AFAIK the closest that Windows has to a man page is Get-Help command for Powershell so we can add a PS1 script that would be the equivalent of asmline and hit the dll directly.
Pretty much everything (like the make check and make install) that is/was on autoconf can be ported to cmake, it is made for that. I didn't do an exhaustive job in case you weren't interested in merging it :D
I'm not sure what the pc is for though.

Install added by 33f6f2d

cmake --install . --prefix /whereever/assemblyline  will work

Test added by 070cd98

Simply do cmake .. && make && cd test && ctest

I'm not sure what the pc is for though.

The high level idea is that you can require versions of dependent libraries in your third party library/tool.
So I have another tool foo and it needs libassemblyline but requires it to be version 1.2.0 or later, because it uses its newest features.
Then, I can specify in my project that as a dependency at compile-time. Using autotools that would be something like
PKG_CHECK_MODULES([LIBASSEMBLYLINE], [assemblyline >= 1.2.0])

more info here
Do you know if there a cmake equivalent / alternative (preferably, I could still use it from foo, based on autotools, but that is probably rather tricky...)?

AFAIK the closest that Windows has to a man page is Get-Help command for Powershell so we can add a PS1 script that would be the equivalent of asmline and hit the dll directly.

So, you mean an alias from Get-Help asmline to asmline --help ? But that would not necessarily get the information on how to use libassemblyline.dll, right?
re install:

can we specify, that only the api-header is copied assemblyline.h and not all the internal ones, as they should not be considered stable?
the installation copies to lib/libAssemblyLine.so. As unix is case-sensitive, we need to change that all lower-case. Secondly, it does not create the confusing, but necessary links.$ ls -l /usr/lib/libassem*
lrwxrwxrwx 1 root root    24 Feb 28 12:50 /usr/lib/libassemblyline.so -> libassemblyline.so.1.2.1
lrwxrwxrwx 1 root root    24 Feb 28 12:50 /usr/lib/libassemblyline.so.1 -> libassemblyline.so.1.2.1
-rwxr-xr-x 1 root root 67416 Feb 28 12:50 /usr/lib/libassemblyline.so.1.2.1

which are needed for the dynamic linker to link against the correct current version. This is described in the autotools here. As far as I could see, that is now in project(AssemblyLine LANGUAGES C VERSION 1.2.0) (d46c2298fe3fd1082bb40753a32a60f2cec80731) -- Does that refer to the Major.Minor.Patch (semver) or to the Current.Age.Revision? And does cmake generate the 'correct other' ?

Test added by 070cd98
* Simply do `cmake .. && make && cd test && ctest`

well, as also your commit message states, tests are not built by default. Looking at the CI yaml, I tried CMAKE_FLAGS='-DBUILD_TEST=ON' cmake .. && make but that also does not create the test-dir. :/

Hey!

The high level idea is that you can require versions of dependent libraries in your third party library/tool.

Ah yes no problem, I forgot about the pkg-config file (my focus was initially for Windows :smile:) . But here again, cmake can generate one very easily. I will add it.

Do you know if there a cmake equivalent / alternative (preferably, I could still use it from foo, based on autotools, but that is probably rather tricky...)?

cmake is really flexible. What you seem to describe is called a custom target in the cmake lingo and you can find tons of resources on how to create one (for instance this one doesn't look bad for intro).

can we specify, that only the api-header is copied assemblyline.h and not all the internal ones, as they should not be considered stable?

Totally, cmake uses a system a private/public interface allowing to define what's meant to be public or not. But if we wanna go simple for this project, we can do that by simply updating the line to mention to install only assemblyline.h
https://github.com/hugsy/AssemblyLine/blob/a15ca3f4a0dd0d82bfad9e65c972f80d24d14717/src/CMakeLists.txt#L88

the installation copies to lib/libAssemblyLine.so. As unix is case-sensitive, we need to change that all lower-case. Secondly, it does not create the confusing, but necessary links.

It's all feasible easily, by creating a POST_BUILD custom command, we can create as many symlinks we want.

Does that refer to the Major.Minor.Patch (semver)

Yes, those will autogen by cmake and expose to the build system (which can also be exposed to the source being compiled): see https://cmake.org/cmake/help/latest/command/project.html#options

The high level idea is that you can require versions of dependent libraries in your third party library/tool.

Yes it is created, you can verify on Github Actions: see https://github.com/hugsy/AssemblyLine/runs/5368746701?check_suite_focus=true#step:11:100249
Hope this helps.
Cheers

Hi,

generating pkg-config: nice! We need this file to be copied to INSTALLDIR/lib/pkgconfig/assemblyline.pc(now my dependent-autotools-project can do what it used to do - wonderful)
custom targets. I'm not sure, if that is what I mean. looking a bit more into cmake documentation, I think I want something like target_link_libraries(MyLib -lassemblyline) if I have another project, which needs to be linked to assemblyline. However, I want to specify that I need to link to it only if it has a specific (minimal) version. Something like target_link_libraries(MyLib -lassemblyline>1.2.0) which should error out, if only version 1.1.0 of assemblyline is installed. (Autotools use that pkg-config file for that).

But if we wanna go simple for this project, we can do that by simply updating the line to mention to install only assemblyline.h

yes, lets do that and only install assemblyline.h

It's all feasible easily, by creating a POST_BUILD custom command, we can create as many symlinks we want.

Lets not create them ourselves.
This seems to be what this thread is about. I see that in the src/CMakeLists.txt the library is already SHARED, but the set_target_properties is not used. When I try to just copy-n-paste (replacing ${PLUGIN_NAME} with AssemblyLine that in there, the installation creates the following links:
# joel in /tmp/hugsy/build on git:main x [10:46:49]
$ ll ../install/lib
drwxr-xr-x 2 joel joel   100 Mar  2 10:46 ./
drwxr-xr-x 6 joel joel   120 Mar  2 10:46 ../
lrwxrwxrwx 1 joel joel    25 Mar  2 10:46 libAssemblyLine.so -> libAssemblyLine.so.PREFIX*
-rwxr-xr-x 1 joel joel 82240 Mar  2 10:46 libAssemblyLine.so...*
lrwxrwxrwx 1 joel joel    21 Mar  2 10:46 libAssemblyLine.so.PREFIX -> libAssemblyLine.so...*

So I'd assume those version Variables are not populated correctly. Can you advice how to set them from the PROJECT_VERSION defined in the root-CMakeLists.txt:6 ? Important here, is that if calculates them correctly (-> to current/age/revision as mentioned earlier (I remember finding some formulas somewhere, with disgusting m4-replacemet macros etc)).
And lastly, for the tests (which env-vars do I need to let cmake generate the test-dir?), I can't see where asmline -p is called (that's what it looks like on the CI-run). Also, is this output compared for correctness against nasm?

Something like target_link_libraries(MyLib -lassemblyline>1.2.0) which should error out, if only version 1.1.0 of assemblyline is installed. (Autotools use that pkg-config file for that).

You don't really have to worry about that with cmake, as long as yours are correctly created: if your project is used as an internal submodule (like I do now), all the caller has to do is check WhateverLib_VERSION constant.
If called externally, find_package does exactly that (including from pkgconfig).

So I'd assume those version Variables are not populated correctly. Can you advice how to set them from the PROJECT_VERSION defined in the root-CMakeLists.txt:6 ?

You're correct, using set_target_properties( ... SOVERSION ...) is the way to go. Here something like htis is enough:
set_target_properties(AssemblyLine PROPERTIES
                                 VERSION ${PROJECT_VERSION}
                                 SOVERSION ${PROJECT_VERSION_MAJOR})

Because we set the VERSION of project()  correctly.
$ cmake ~/code/AssemblyLine -DBUILD_TEST=ON && make -j4 && cmake --install . --prefix /tmp/assemblyline
-- The C compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
[...]
$ ls -l /tmp/assemblyline/lib
lrwxrwxrwx  20 hugsy  1 Mar 19:20 libAssemblyLine.so -> libAssemblyLine.so.1
lrwxrwxrwx  24 hugsy  1 Mar 19:20 libAssemblyLine.so.1 -> libAssemblyLine.so.1.2.0
.rw-r--r-- 83k hugsy  1 Mar 19:20 libAssemblyLine.so.1.2.0

Is that what you want?

And lastly, for the tests (which env-vars do I need to let cmake generate the test-dir?), I can't see where asmline -p is called (that's what it looks like on the CI-run).

That's really up to you (and that's kindda why it's hard for me to do stuff, because you may not like them the way I do, so I go step-by-step). But with the implementation I made, yes cmake created the stub to make your build system create the test directory so you have nothing to do.

Also, is this output compared for correctness against nasm?

Currently no, how do you want this to be done exactly? You can use ctest and match the output using cmake, I like this approach but at the end it's up to you. The cmake tutorial details well how you can create an intermediate function to match the output from a regexp.
If you confirm the target property like I mention above, let me know, and I'll send the modification (along with the rule for install of assemblyline.h ).
Cheers

You don't really have to worry about that with cmake, as long as yours are correctly created:

Ah yes, you're right. Not for now. If I would be converting my dependent project to cmake, then I'd need to worry.

Is that what you want?

Yes, That is Perfect!

Currently no, how do you want this to be done exactly?

Hmmm. So what we need is assemblyline to create correct assembly. For that, we usually check against nasm on the same input. But, we have some constructs, which are incompatible (i.e. assemblyline emits semantically equivalent code, which differs from nasm) For the general case, (equivalent to nasm) we just had the test-files, assemble them with both programs, convert them to the same hex-format and run diff. This is the essence of the scripts here and here. The former compiles the entire file and checks for equivalence, the latter uses the TAP-Protocol, and checks line by line; that is slower, but easier to see, which single instruction may still be problematic.
From your link, however, I understand that one would need to write the expected output into the CMakeLists.txt file. The benefit of that would be, that we can check also the nasm-incompatible code. And we should be able to create such a file (to get all the existing tests sorted) with a couple scripts, I guess.
I'm also happy to introduce some frameworks to have the code tested, or to write this in c-files, too and / or run the code to see if the expected happens (I'm pretty sure, that would be a bit overkill for this PR).
What I don't want, is that we merge all this (your) great work at the cost of abandoning the (correctness-)testing.
@daviduwu9 , what do you think / prefer - so we (you, @daviduwu9) want to experiment with different approaches and then come back for a decision? Or does @hugsy have a solid idea to get this solved, now knowing the requirements? I'm pretty happy with whatever, at this point.
Does this

If you confirm the target property like I mention above, let me know, and I'll send the modification (along with the rule for install of assemblyline.h ).

refer to this

Totally, cmake uses a system a private/public interface allowing to define what's meant to be public or not. But if we wanna go simple for this project, we can do that by simply updating the line to mention to install only assemblyline.h
https://github.com/hugsy/AssemblyLine/blob/a15ca3f4a0dd0d82bfad9e65c972f80d24d14717/src/CMakeLists.txt#L88

?
Then, I'm not sure what you want me to confirm.

I had a little bit of time so I went ahead and try a new approach for testing, let me know what you think: basically this removes the need of external tool, we let the compiler generate the bytecode, that we can compare with that of asmline lib at runtime of test. This also allows to be fully integrated with any build system (although msvc doesn't support x64 inline __asm__). The new file is pure C, small and easy to read (IMHO) for being modified in the future.
The source is here and it works great on my host:

[...]

I do like the fact to just rely on cc, and then compare that to our lib. I do not like, that we compare byte-by-byte, because we don't know which instruction is problematic.
I am thinking of using asm_get_code and asm_assemble_str in a loop.
What do we think about the above code ? @hugsy @daviduwu9  (plus an #include <string.h> at the top of cause)
This way we check instruction by instruction and can fail accordingly.
NOTE: this code is untested, has probably off-by-one errors, I'm not sure about strtok_r; and the variables and gotos can probably be done a bit more clever, but I am just brain-stoming in C pretty much :thinking:

Yes that's not a problem at all, I can update the code now, also make it a bit cleaner too.

Could we put the logic of checking into some file, which we include, and then have a c file, which then defines CODE with the code we want to check?
like check_add.c with
/* each test file only changes this*/
#define CODE "add rax, rbx\n" \
"add al, 0x01\n"\

/* rest is than copy-n-paste boilerplate */

#include "test_common.c" // implements compare_asmline_cc
__attribute__((noinline, section("mytest"), naked)) void
test(void)
{
    __asm__(CODE);
}

int main(){
char * code = CODE;
compare_asmline_cc(&code, &test);
}

Maybe I'm a bit in 'make-a-wishland now, but we could maybe even put all the boilerplate in a file and let the test runnercat`them together into a temporary file, which is then run.
My intention to split that is, that otherwise we'd have one crazy large c file with all the tests in one string eventually.

Done, now it'll display a comprehensible error message like this (note: the following was faked for demo purpose - the debug lines won't show either)

Could we put the logic of checking into some file, which we include, and then have a c file, which then defines CODE with the code we want to check?

Yup, a shell script (simple sed script would be enough) can generate the C from cmake and have it compiled.

You can check out c200b34 I think that's what you had in mind.
Simply put: we use cmake to generate compilable code from the test cases located in test/inc/. This way we can convert the test/*asm quickly to usable C files and have all the test cases preserved, and robustly executed. Let me know if you're ok with that and I will finish the transition of the *.asm files to that format.
Cheers,

Ah ... because of the .gitignore, hold on

Nice I'm doing
rm -rf build
mkdir build && cd build
cmake .. -DBUILD_TEST=ON
make -j
cd test && ctest -N

and it outputs
Test project /tmp/hugsy/build/test
  Test #1: check_chunk_counting
  Test #2: invalid
  Test #3: jump
  Test #4: memory_reallocation
  Test #5: optimization_disabled
  Test #6: run
  Test #7: vector_operations

which is what I like seeing: no failed tests. But It does not seem to run the compare_asm.c right?
I also changed src/instructions.c to create invalid code for adc. And the ctest -N still runs fine.
But then also test/CMakeLists.txt:17 clearly states compile_asm.c.
Am I calling it incorrectly?

Yup, ctest doesn't apply to those.
Is this approach ok for you? Just to know if I should finish it (because this PR is getting quite long now 😁)

yes, I love it! how would I call them ?

Ok, I've sent you what I've got so far. The big issue I'm facing now is that you chose to support the nasm syntax which defines more than just respecting the intel abi (instruction mangling, macro definitions, etc.) and those cannot be understood by anything else than ... nasm. So currently the build fails because gcc/clang see those instructions as invalid and therefore cannot compile some test binaries.
There's no easy solution for me to that because it's an implementation choice. What could be done right now is disregarding those nasm edge cases and only test the real intel abi. And later find a solution for adding tests to those cases.
Please feel free to read the code, I added some comments hoping they'll help. If you have question, let me know.
Cheers,

No problem. Feel free to close this PR if you prefer.
I'll keep working on it in my fork.
Cheers


[release-v0.59.x] Fix isolated workspaces ignored when using StepTemplate

This is an manual cherry-pick of #8272
/assign @afrittoli @chitrangpatel
Isolated workspaces are now correctly set when using in conjuction with StepTemplate

/kind bug


trouble to understand latent space

Hi all,
Please, I am struggling to understand how the latent space is used in your code.
I would like to know how MRI patches are related to the latent space to synthesize the pseudo-CT. If one can consider that the distribution used to initialize the filters can be considered as the latent space.
Thank you in advance for your understanding.

I'm confused what you mean, can you please specify it?

Please for more precision, I put it on the graph attached
scheme.pptx

Since we want to generate CT images with a one to one correspondance, we do not add any noise in the input, so the second graph in your ppt is more accurate

Thank You a lot, I understand now.

@hnbonsou  Roger's explanation is exactly what we mean. In addition, if it is one-to-more reflection, we can add some noise along with the input source image.

@ginobilinie Thanks a lot for this clarification. I will through that.


List all API namespaces in CLI args

Motivation
CLI api.rest.api option was not in sync with new namespaces.
Description
This approach enforces with Typescript that all existing yargs will always be aware of all existing API namespaces.

Maybe it would be better to introduce ApiNamespace enum, which can be single source of truth and also enforce proper types here https://github.com/ChainSafe/lodestar/blob/master/packages/api/src/interface.ts#L10

You can't derive an enum from object keys. The goal of this approach is that the ApiNamespaces derive from the shape of the Api interface. Then Typescript enforces that the namespace matches exactly the key with it associated routes group

Maybe it would be better to introduce ApiNamespace enum, which can be single source of truth and also enforce proper types here https://github.com/ChainSafe/lodestar/blob/master/packages/api/src/interface.ts#L10

You can't derive an enum from object keys. The goal of this approach is that the ApiNamespaces derive from the shape of the Api interface. Then Typescript enforces that the namespace matches exactly the key with it associated routes group.
Using an enum is the previous approach. And we forgot all the time to declare new namespaces. Here the code won't compile if you forget.

Hmm but if you declare Api as
export type Api : Record<ApiNamespaceEnum, something> = {
  ...
}

and

const allNamespacesObj: {[K in keyof Api]: true} = Object.values(ApiNamespaceEnum).reduce((o,n) => {o[n]=true}, {})

everything should be typesafe and enforced while we also have single source of truth(enum), right?

everything should be typesafe and enforced while we also have single source of truth(enum), right?

Right but with that approach you can't associate different types to each property. All properties of Api would have the same routes which is not what we want.


s.youtube.com

Why isn't this domain removed? It's not just any tracker and having it on the list by default will cause problems for most people and that's really ridiculous. Why?

This issue has been discussed previously, and Steven Black has decided not to remove it.
Thank you


java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference

Describe the bug
Failed to handle method call
E/MethodChannel#af-api(32515): java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference
To Reproduce
Steps to reproduce the behavior:

initialize appsflyerSdk
generate deep link using generateInviteLink() method
here is whole erroe log: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference

Expected behavior
should generate deep link for my app
Screenshots

Desktop (please complete the following information):

OS: Macos Venture 13.1
IDE: android studio(Jellyfish | 2023.3.1) , android emulator(android 14)
Version [e.g. 22]

Additional context
I have declair appsflyerSdk in main.dart file before runApp(). Using its instance for generating deeplink for my application throws this error while generating deeplink.
Here is my flutter doctor -v commad respose:
macmini3@macmini3s-Mini ~ % flutter doctor -v
[✓] Flutter (Channel stable, 3.16.4, on macOS 14.2.1 23C71 darwin-arm64, locale
en-US)
• Flutter version 3.16.4 on channel stable at
/Users/macmini3/development/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 2e9cb0aa71 (9 weeks ago), 2023-12-11 14:35:13 -0700
• Engine revision 54a7145303
• Dart version 3.2.3
• DevTools version 2.28.4
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/macmini3/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/macmini3/Library/Android/sdk
• Java binary at: /Applications/Android
Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
17.0.7+0-17.0.7b1000.6-10550314)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15C65
• CocoaPods version 1.15.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.7+0-17.0.7b1000.6-10550314)
[✓] VS Code (version 1.86.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.42.0
[✓] Connected device (3 available)
• iPhone 15 Pro Max (mobile) • F776AE18-4237-4A5C-972D-3910C417F98C • ios
• com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
• macOS (desktop)            • macos                                •
darwin-arm64   • macOS 14.2.1 23C71 darwin-arm64
• Chrome (web)               • chrome                               •
web-javascript • Google Chrome 121.0.6167.160
[✓] Network resources
• All expected network resources are available.
• No issues found!

I'm experiencing similar bug in version 6.14.2 that was previously fixed in 6.11.3 https://github.com/AppsFlyerSDK/appsflyer-flutter-plugin/issues/109. Could this be a regression? Any insight or further investigation would be appreciated. Thank you!

I'm also experiencing the similar issue in Version 6.13.2+1. Should I revert to Version 6.11.3? Please suggest.

Is there any update with this issue?:)

Suspected to be the same issue.
          Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'void i10.l.a(i10.l$d, java.lang.Object, java.lang.String)' on a null object reference
       at io.flutter.plugin.common.MethodChannel.invokeMethod(MethodChannel.java:12)
       at com.appsflyer.appsflyersdk.AppsflyerSdkPlugin$5$1.run(AppsflyerSdkPlugin.java:12)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:230)
       at android.os.Looper.loop(Looper.java:319)
       at android.app.ActivityThread.main(ActivityThread.java:8893)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

[!] Flutter (Channel [user-branch], 3.19.6, on macOS 14.5 23F79 darwin-arm64, locale en-US)
    ! Flutter version 3.19.6 on channel [user-branch] at /Users/anglemiku/Documents/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
    • Framework revision 54e66469a9 (2 months ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1
    • Pub download mirror https://pub.dev
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/anglemiku/Library/Android/sdk
    • Platform android-34, build-tools 33.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.90.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • angle’s iPhone (mobile) • 00008030-000965040A98402E • ios            • iOS 17.5.1 21F90
    • macOS (desktop)         • macos                     • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)            • chrome                    • web-javascript • Google Chrome 126.0.6478.127

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

appsflyer_sdk: ^6.14.3