chat commands: add bird's egg sacrifices kc

This adds a chat command to track the kc of bird's eggs sacrificed at the shrine in the woodcutting guild.
Discussion: https://github.com/runelite/runelite/discussions/18230

Thanks for the feedback, updated code accordingly.
In-game screenshot:

I'm not 100% certain but with 1 egg offered it may say `You have made <col=ff0000>one offering.

If you can get some offering debug messages from the game and add a test case for them that would be good.

@umer-rs good call! You were right.

@Adam- test case added. Sorry for not doing that in the first place.

Thanks for merging! :)


Fixes #34, adding options.ligthness to diff (Diff swallows black color i...

Adds visibility to image differences by boosting light with a +25 value.
Processes options.lightness from imagediff.diff so the lightness boost can be easily changed.

Examples of tests with screenshots in #34.

I will bring some changes to this, as it is contains feature request as well. I will also test it the alpha image from http://humblesoftware.github.io/js-imagediff/. Another pull request will follow.


Model as Date when format is used

I made this plunkr
https://plnkr.co/edit/yOoXEdAeVqUvlElVN32Q?p=preview
if I put a Date object, it shoudn't return the date object back?
the displayed value should be the formatted and the internal value should be the date correct?

It returns date object back with toString function overwritten.
https://plnkr.co/edit/FNSFdcRfx5HeCDgjySGJ?p=preview


The [algorithm] attribute should produce class="algorithm" in the output

If I write:

<dfn>some algorithm</dfn> must do the following steps:

step 1

step 1.1

I should get the same formatting I'd get if I'd used
.
The stylesheet already supports this with a
	ol.algorithm ol:not(.algorithm),
	.algorithm > ol ol:not(.algorithm) {

selector.

I want that style. :(
The specs I've worked on generally have followed the following pattern:

Should |block| be considered an algorithm?

Given an element (|block|), the following algorithm returns
"`Algorithm`" or "`Not Algorithm`".

1.  If |block| is algorithmic enough, return "`Algorithm`".

2.  Return "`Not Algorithm.`"

The algorithm is implicitly ended by the next h* of the right level. It would be nice if we could somehow support this kind of syntax as well. I'd prefer not to add wrapper elements to the source just for styling...

@jyasskin Done. The algorithm attribute now causes the generation of an algorithm class on the element.
@mikewest That's just a little bit too magic for me; I'm not sure that I want to automatically assume that all OLs inside of an algorithm section are the algorithm steps.  That said, I just added a feature I've been planning for a while: you can manually specify the list container for markdown lists.  Like:

	1. first
	2. second

This will use the OL you specified, rather than generating one automatically. So you'll be able to wrap your list accordingly, and won't have an extraneous wrapper element cluttering things.  Same applies to your example, @jyasskin.

@tabatkins, any idea why the
s in https://github.com/heycam/webidl/pull/180/files#diff-ec9cfa5f3f35ec1f84feb2e59686c34dR7572 aren't causing class="algorithm" in https://api.csswg.org/bikeshed/?url=https://raw.githubusercontent.com/jyasskin/webidl/9392a5d2343bd42f62fecb088bddcd3bc8604b01/index.bs#es-to-open-dictionary?
@tobie


Encrypted messages are in format m4a and are silently not processed

The code checks for audio/ogg before decoding, so audio/m4a is ignored.
I'm going to submit a PR for this.

Actually I got it wrong: some messages are ogg and some are m4a but the problem with the encrypted messages is that the content_type is application/octet-stream.
The event mimetype is correct though, so using that one works.

@remoremorali , I'm facing an issue with encrypted audio message not processed at all, so I guess it's exactly the issue you are mentioning.
Did you have a chance to submit a PR? If not, would you mind advising on the code place to make the changes?

I figured out pull request is there and already merged (https://github.com/hibobmaster/matrix-stt-bot/pull/3).
@hibobmaster , could you please, help me to understand if encrypted rooms ever worked for you? I have only Element clients and bot just doesn't get triggered on audio messages in encrypted rooms.
I have encryption configured and working, non-encrypted rooms also works fine.

I've changed events to listen to as broad range as possible:
        # setup event callbacks
        self.client.add_event_callback(
            self.message_callback,
            (
                RoomMessageAudio,
                RoomEncryptedAudio,
                RoomMessage,
                RoomMessageUnknown,
                RoomEncryptedMedia,
                UnknownEncryptedEvent,
                Event,
            ),
        )

But it still doesn't work - I'm running the code under the debugger and it just not executing this code for encrypted rooms.
One more thing that concerns me, it's that bot never 'read' those messages - it's like something prevents it from getting those messages ever touch the code.
... and one more thing... it's not only with encrypted channels - it's with any channels, except for default's '#discuss'. The bot joining all those rooms, but never get the messages.

@alexander-potemkin You should import E2EE room keys follow the readme.
And here's a guide about how to login via access_token and make it work in E2EE room. https://github.com/hibobmaster/matrix-stt-bot/issues/4#issuecomment-1840398688


RStudio multi-window refresh issue

Describe the bug
With two RStudio tabs open, the tabs periodically refresh themselves.
See teams thread for recording of the behavior.

@dyf I think this is in the wrong repo, no?


When mask step is removed, roi panel and annotations are still present

Shouldn't they be removed?

The goal was to be able also to annotate the original image rather than the mask. Currently ROIs are somehow independent and not related to a specific processed image once created. I guess this could evolve if we go in the pipeline direction.


How can i add  a 'cancel' button to KVNProgress

i like this HUD, but i found a question, how can i add a cancel button??

For now, there is no possibility to do this. You can:

fork this repository to implement this by your side
or you can use the new tapBlock property of the KVNConfiguration object to precise whatever action block you want to be executed when the HUD is tapped by the user. This is available since this commit 07a107b14d8cf5570bdec376703c0ac4b05c2fc8 and in the new Cocoapods version 1.2.7 (Example in the README.md) ;)


How to handle missing/duplicate field names in Spanner?

In spanner the returned data can have missing/empty field names.
db.execute("SELECT 1").rows.to_a #=> [{:""=>1}]

The first question is how to handle multiple missing/empty field names. The results are returned in Ruby hashes, and Hash does not allow duplicate field names, so the empty string symbol (:"") used for both columns is overridden.
db.execute("SELECT 1, 2").rows.to_a #=> [{:""=>2}]

The second question is a variation on the first. How do we handle duplicate field names. For example:
db.execute("SELECT 1 AS count, 2 AS count").rows.to_a #=> [{:count=>2}]

/cc @vkedia

My first impulse to the first question is to replace missing/empty field names with a default name that includes the column position. For example:
db.execute("SELECT 1, 2").rows.to_a #=> [{:_col_0=>1, :_col_1=>2}]

But, this doesn't address the second question, since only the empty field names would be changed.
One options is to find all duplicates, and append a count to them:
db.execute("SELECT 1, 2, 3 AS count, 4 AS count").rows.to_a
#=> [{:""=>2, :_1=>2, :count=>3, :count_1=>4}]

A variation on this is to modify all filed names that have a duplicate, not just the duplicate fields:
db.execute("SELECT 1, 2, 3 AS count, 4 AS count").rows.to_a
#=> [{:_0=>2, :_1=>2, :count_0=>3, :count_1=>4}]

The returned field names would also be modified, so the names would match up. Currently, we have:
db.execute("SELECT 1, 'hello'").types #=> {:""=>:STRING}

So we need some way to differentiate the field names.
db.execute("SELECT 1, 'hello'").types #=> {:_0=>:INT64, :_1=>:STRING}

One possible solution is return a Hash that has values by name and position. The duplicate names would be squashed just like it is now:
db.execute("SELECT 1, 2, 3, 4").rows.to_a
#=> [{:""=>4, 0=>1, 1=>2, 2=>3, 3=>4}]

db.execute("SELECT 1 AS count, 2 AS count, 3 AS count, 4 AS count").rows.to_a
#=> [{:count=>4, 0=>1, 1=>2, 2=>3, 3=>4}]

We can also add additional type methods to allow retrieving both the type names and type values as arrays:
results = db.execute("SELECT 1, 2, 3, 4")
results.types #=> {:""=>: INT64}
results.type_names #=> [:"", :"", :"", :""]
results.type_values #=> [:INT64, :INT64, :INT64, :INT64]

results.rows.to_a #=> [{:"=>4, 0=>1, 1=>2, 2=>3, 3=>4}]

Yet another possible solution is to add a flag to control whether the results are returned as hashes or a deeply nested arrays.
hash_results = db.execute "SELECT 1, 2, 3, 4"
hash_results.types #=> {:""=>: INT64}
hash_results.rows.to_a #=> [{:""=>4}]

# Make a second query since #rows enumerator can only be called once
array_results = db.execute "SELECT 1, 2, 3, 4"
array_results.types array: true #=> [[:""=> :INT64], [:""=> :INT64], [:""=> :INT64], [:""=> :INT64]]
array_results.rows(array: true).to_a #=> [[[:""=>1], [:""=>2], [:""=>3], [:""=>4]]]

That last option is exactly what the current code is doing, minus the last step that converts the deeply nested array of pairs into a Hash. The row as an array of pairs looks like this:
row = [[:"", 1], [:"", 2], [:"", 3], [:"", 4]]

And when we convert that row of pairs into an Hash we get this:
row = [[:"", 1], [:"", 2], [:"", 3], [:"", 4]]
Hash[row] #=> {:""=>4}

This was resolved in #1461.


local config healthcheck

Describe what this PR does / why we need it
add the health check exist in version < 1.5.1, 2.0.0 as an option.
we use the health check for k8s readnessprobe, find out that the new implement in version >= 1.5.1,2.0.0 make the status down because of unstable network, and the deployments restart.
applicaion works fine once get the configs from the nacos server, so i think there should have a switch to close the health check, and add back the old implement as an option with which the status will be up after the applicaion store the configuration in local cache.
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Why not use the spring boot actuator for k8s probe？and check health with /actuator/health endpoint. Actually, Nacos's status cannot indicate the application status.

@echooymxq this health check is one of the status of /actuator/health, the application status is down when it is down.

@illlight I got it. I don't think we should distinguish remote or local caches check health. As long as the NacosPropertySourceLocator can locate PropertySource, the Nacos status should be UP.

And i agree with you this point that we should add a property to decide whether to enable nacos health, eg:spring.cloud.nacos.config.health.enabled.

@echooymxq That's it. And I also add the local config check just copy from the implement in version 1.5.0  which checks the configuration could be read and not empty.

The local config health check will not be enabled by default, or I can add it as an self defined health indicator.

hope spring.cloud.nacos.config.health.enabled  add soon

In my opinion, we just need revert the previous logic and add the spring.cloud.nacos.config.health.enabled property, NacosLocalConfigHealthIndicator is not necessary. @fangjian0423 what do you think?

In my opinion, we just need revert the previous logic and add the spring.cloud.nacos.config.health.enabled property, NacosLocalConfigHealthIndicator is not necessary. @fangjian0423 what do you think?

I agreed with your opinion,  @illlight just remain the addion of NacosConfigHealthIndicator

@mercyblitz done

@illlight I found this make things complicated.Just keep it will be ok.

Actually,I'm tangled here. If you followed my recommendation last night, then you only need to pay attention to status, and don't care about the details when unit testing.

@illlight Can squash all your commits for one commit?

@echooymxq ok

@echooymxq I think both implementation are ok, what i really need is a switch, we can add a self-defined healch check to fit real scenarios.

@echooymxq I think both implementation are ok, what i really need is a switch, we can add a self-defined healch check to fit real scenarios.

If just so, we use with @ConditionalOnMissingBean and provide a default implement with configService.getServerStatus().

@echooymxq That's fine, I hope it will be released in next version.

@illlight  This can be done by modify your's pull request again. revert the NacosConfigHealthIndicator code, just use configService.getServerStatus() to check health, And add @ConditionalOnMissingBean support. Thanks.

@echooymxq as your wish

@illlight we also need support spring.cloud.nacos.config.health.enabled, And add some description to additional-spring-configuration-metadata.json.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


iOS 7 support?

Will Bond (and/or ReactiveKit) work on iOS 7?
I am talking about installation via CocoaSeeds - https://github.com/devxoul/CocoaSeeds

Hmm, looking at it. You have to specifies files. Problem is that Bond has both iOS and OSX source files in its root sources directory so the matching pattern would be complex.
I think that getting ReactiveKit to work with it would be simpler as it does not contain OSX files.

I have big iOS project that needs to support iOS 7 as it represents a lot of targeted users and I really, I mean I REALLY would like to use Bonds or ReactiveKits observables and UI extensions. I would use ReactiveCocoa, but to be honest it seems too complicated for simple things like reacting to value change in model.

And actually I wanted to know if it will work with iOS7 without any troubles.

I've investigated CocoaSeeds further. Their idea of stripping project file and using only sources will not work with Bond or ReactiveKit. Project files contain necessary compiler information and parameters without which frameworks won't compile well. It's not that easy.
Also, the code would probably work on iOS7 because frameworks are not relying on any often changing APIs, but I cannot provide any official support.
It's unfortunate that iOS 7 represents a lot of targeted users for you. Looking at Mixpanel stats, there is less than 5% of devices that are on pre-iOS8 version globally. In few months when you're done with the app it will be even less.
If you really want to use Bond or ReactiveKit the easiest way would be to fork them, lower the deployment target to iOS7 and use the fork with either plain Git submodules or with Carthage.


bug report for the installation on Windows 10

Specs

Leon version: 1.0.0-beta.3
OS (or browser) version: Windows 10.0.18363.720
Node.js version: 12.16.1 (x64)
Complete "npm run check" output:
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>preinstall: node scripts/setup/preinstall.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\Utilisateur\AppData\Roaming\npm-cache_logs\2020-03-16T00_09_04_066Z-debug.log

(if using Docker) Complete "npm run docker:check" output:
(optional) Leon package version:

I tried to "npm install" leon from the unzipped file and I obtained this. Do you have any idea of how I could solve this problem ?
I also tried with the most recent version of leon and had the same problem.

I started from scratch,
forked repo,
install npm latest LTS (12.16.1),
execute 'npm install',
had an error because of missing pipenv
execute pip install pipenv
execute npm install again
`
λ npm run check

<EMAIL_ADDRESS>check c:\Users\Utilisateur\Documents\repository\leon
babel-node scripts/run-check.js

⠋
.: CHECKING :.
➡ C:\Windows\system32\cmd.exe /q /s /c "node --version"
✔ v12.16.1
➡ C:\Windows\system32\cmd.exe /q /s /c "npm --version"
✔ 6.13.4
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv --version"
✔ pipenv, version 2018.11.26
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv --where"
✔ C:\Users\Utilisateur\Documents\repository\leon\bridges\python
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv run python --version"
✔ Python 3.8.1
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv run python bridges/python/main.py scripts/assets/query-object.json"
✔ {"package": "leon", "module": "randomnumber", "action": "run", "lang": "en", "input": "Give me a random number", "entities": [], "output": {"type": "end", "codes": ["success"], "speech": 92, "options": {}}}
➡ Classifier state
✔ Found and valid
➡ Amazon Polly TTS
❗ Amazon Polly TTS is not yet configured
➡ Google Cloud TTS/STT
❗ Google Cloud TTS/STT is not yet configured
➡ Watson TTS
❗ Watson TTS is not yet configured
➡ Offline TTS
❗ Cannot find bin/flite/flite. You can setup the offline TTS by running: "npm run setup:offline-tts"
➡ Watson STT
❗ Watson STT is not yet configured
➡ Offline STT
❗ Cannot find bin/deepspeech/lm.binary. You can setup the offline STT by running: "npm run setup:offline-stt"

.: REPORT :.
➡ Here is the diagnosis about your current setup
✔ Run
✔ Run modules
✔ Reply you by texting
❗ Amazon Polly text-to-speech
❗ Google Cloud text-to-speech
❗ Watson text-to-speech
❗ Offline text-to-speech
❗ Google Cloud speech-to-text
❗ Watson speech-to-text
❗ Offline speech-to-text
✔ Hooray! Leon can run correctly
➡ If you have some yellow warnings, it is all good. It means some entities are not yet configured
`
Everything seems fine;
Do you have python ?

Thank you very much everything worked perfectly !
Le sam. 21 mars 2020 à 19:44, Thomas Deville-Duc<EMAIL_ADDRESS>a écrit :

I started from scratch,
forked repo,
install npm latest LTS (12.16.1),
execute 'npm install',
had an error because of missing pipenv
execute pip install pipenv
execute npm install again
`
λ npm run check
<EMAIL_ADDRESS>check c:\Users\Utilisateur\Documents\repository\leon
babel-node scripts/run-check.js
⠋
.: CHECKING :.
➡ C:\Windows\system32\cmd.exe /q /s /c "node --version"
✔ v12.16.1
➡ C:\Windows\system32\cmd.exe /q /s /c "npm --version"
✔ 6.13.4
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv --version"
✔ pipenv, version 2018.11.26
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv --where"
✔ C:\Users\Utilisateur\Documents\repository\leon\bridges\python
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv run python --version"
✔ Python 3.8.1
➡ C:\Windows\system32\cmd.exe /q /s /c "pipenv run python
bridges/python/main.py scripts/assets/query-object.json"
✔ {"package": "leon", "module": "randomnumber", "action": "run", "lang":
"en", "input": "Give me a random number", "entities": [], "output":
{"type": "end", "codes": ["success"], "speech": 92, "options": {}}}
➡ Classifier state
✔ Found and valid
➡ Amazon Polly TTS
❗ Amazon Polly TTS is not yet configured
➡ Google Cloud TTS/STT
❗ Google Cloud TTS/STT is not yet configured
➡ Watson TTS
❗ Watson TTS is not yet configured
➡ Offline TTS
❗ Cannot find bin/flite/flite. You can setup the offline TTS by running:
"npm run setup:offline-tts"
➡ Watson STT
❗ Watson STT is not yet configured
➡ Offline STT
❗ Cannot find bin/deepspeech/lm.binary. You can setup the offline STT by
running: "npm run setup:offline-stt"
.: REPORT :.
➡ Here is the diagnosis about your current setup
✔ Run
✔ Run modules
✔ Reply you by texting
❗ Amazon Polly text-to-speech
❗ Google Cloud text-to-speech
❗ Watson text-to-speech
❗ Offline text-to-speech
❗ Google Cloud speech-to-text
❗ Watson speech-to-text
❗ Offline speech-to-text
✔ Hooray! Leon can run correctly
➡ If you have some yellow warnings, it is all good. It means some entities
are not yet configured
`
Everything seems fine;
Do you have python ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/leon-ai/leon/issues/171#issuecomment-602085631, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2V3B7AEPTXJEULRIVPC73RIUDHVANCNFSM4LLQ443Q
.

Did you do something special to make it work ?
Please close issue if everything is ok for you

I just installed pipenv as you advised me to. and everything worked properly.
I close the issue thanks.


Clean up custom objective function demos

Both our fraud and lead scoring notebooks try to go through examples where optimizing for custom objectives introduces a better performing model for the use case. However, the actual outputted results no longer better in the case of FraudCost (https://evalml.featurelabs.com/en/stable/demos/fraud.html#Why-optimize-for-a-problem-specific-objective?) and different than what's written for lead scoring.
We should investigate: what happened that now fraud cost produces the same results regardless of optimizing for an objective? What changed about our search that we are no longer performing better?
EDIT: Cost benefit matrix is also showing the same score :thinking:

This issue tracks updating the lead scoring and fraud demos so that we aren't claiming something untrue.
Lead scoring demo currently claims

When we optimize for AUC, we can see that the AUC score from this pipeline is better than the AUC score from the pipeline optimized for lead scoring. However, the revenue per lead gained was only $7 per lead when optimized for AUC and was $45 when optimized for lead scoring. As a result, we would gain up to 6x the amount of revenue if we optimized for lead scoring.

However this doesn't match the current numbers.

Closing since I fixed the documentation with PR 2139


combineSagas utility funciton

At the moment we have to do something like
export default function* root() {
    yield [
        fork(saga1),
        fork(saga2),
        fork(saga3),
        fork(saga4)
    ];
}

Would be great to have combineSagas just like redux's combineReducers.
Use it like
export default rootSaga = combineSagas({
    saga1,
    saga2,
    ...
});

combineReducers has for purpose to combine multiple reducers into different state slices. Sagas do not store state into the Redux Store so I think the analogy do not make much sens.
From your example it seems the purpose of combineSagas is to take out some (not so much IMO) boilerplate of forking mulitple tasks at startup. You can just write a helper function for that
function startSagas(...sagas) {
  return function* rootSaga() {
    yield sagas.map(saga => fork(saga))
  }
}

// usage
export default rootSaga = startSagas(saga1, saga2, ...)

I was more aware of the project structural similarities. I'd have "reduces" folder, contains different reducers, and in index.js it would be something like:
import { combineReducers } from 'redux';
import firstReducer from './firstReducer';
import secondReducer from './secondReducer';
import thirdReducer from './thirdReducer';

const rootReducer = combineReducers({
    firstReducer,
    secondReducer,
    thirdReducer
});

export default rootReducer;

I've tried to find a way to sort of "combine" all different sagas into a single rootSaga, so that it can be passed into createSagaMiddleware. Couldn't find it on docs, but in examples it had a pattern. And the "sagas" folder is very similar to "reducers" - having different sagas, and an index.js that exports rootSaga.
import { fork } from 'redux-saga/effects';
import firstSaga from './firstSaga';
import secondSaga from './secondSaga';
import thirdSaga from './thirdSaga';

export default function* rootSaga() {
    yield [
        fork(firstSaga),
        fork(secondSaga),
        fork(thirdSaga),
    ];
}

Just with weird syntax for someone just starting up with redux-saga like me.
Agreed that it's only very little boilerplate, but at least a mention of creating rootSaga in docs would be great.

You can hand in many sagas into the middleware, not only one. So there is no need to combine them like you do, is there?
createSagaMiddleware(firstSaga, secondSaga, thirdSaga) should be the same as
export default rootSagas = [
  firstSaga, secondSaga, thirdSaga
]
createSagaMiddleware(...rootSagas)

Whats the yield and fork doing in your code?

Saw the pattern in the most of examples. Not clear the differences / pros and cons of two ways.

@yjcxy12 see #160

Hi, I was just searching how to combine redux sagas
and found this discussion useful.
I didn't understand why I should fork for these combinations.
I'd like to leave my helper functions here.
I've just written them and hasn't been tested enough.
Correct me if I'm wrong.
Thanks.
//notesSagas.js
import foldersSaga from './folders'
import notesSaga from './notes'
export default [
	foldersSaga,
	notesSaga,
]
//or export default foldersSaga

//rootSaga.js
import {sagas as notesSagas} from '~/notesSagas'

/**
 * @param {(generator|generator[])}
 */
function* combine(sagas){
	yield Array.isArray(sagas)
		? sagas.map(saga=>saga())
		: [sagas()]
}

/**
 * @param {...generators}
 */
function* apply(...sagas){
	yield Array.isArray(sagas)
		? sagas.map(saga=>combine(saga))
		: [combine(sagas)]
}

/**
 * @param {...generators}
 */
function combineSagas(...sagas){
	return function*(){
		yield apply(...sagas)
	}
}

export default combineSagas(
	notesSagas
)

/*
export default function* rootSaga() {
	// yield [
	// 	combine(notesSagas),
	// 	combine(otherSagas),
	// ]

	yield apply(
		notesSagas
		,otherSagas
	)
}
*/

//configureStore.js
import sagas from '../rootSaga'
...
sagaMiddleware.run(sagas)
...

So basically what you trying to achieve is a deepFlatMap for arrays of arrays of generators and run each of them within saga?

I didn't think about deep nesting. But maybe it could be achieved using such functions.
In short, I have a big module per url route with own sagas not related with other pages.
I want to see which sagas take part in the lifecircle of particular module.
I can add and remove sagas inside separated module without touching rootSaga. I only mount module bundle to rootSaga once.
And entire bundle can be a simle saga as well. Not only arrays of sagas. But in general my bundles are arrays.

So in general I would advise you to use smth like flatMapDeep:
yield flatMapDeep(bundledSagas, fork)
I think this is exactly what you need, if not please specify your requirements stricter and I'll try to adjust my advice accordingly :)

I'm starting to use redux-saga,
and decided to organize my sagas by topic in different files,
I was looking also for a way to include all my sagas at once,
I came up with this code
import * as groupOne from 'app/saga/groupOne'
import * as groupTwo from 'app/saga/groupTwo'
// grupOne and Two are exporting several watcher sagas

import { map } from 'ramda'

const combinedSagas = {
  ...groupOne,
  ...groupTwo,
}
export default function* rootSaga() {
  yield map(key => combinedSagas[key](), Object.keys(combinedSagas))
}

Do you see any downside to this approach ?
would I get any benefit from using fork ?
Thanks.

@alfonsodev the downside is that you create iterators here, they will have different identities with each run, so its harder to test. You are also yielding an array, which is deprecated now - you should wrap that array in all effect.
Idiomatic way of using redux-saga is to yield effects (description object) only, although yielding promises and iterators is allowed.


Unable to add Nuget package FastReport.OpenSource to .NET 8 project

Is your feature request related to a problem? Please describe.
When I try to add the Nuget package FastReport.OpenSource to my .NET 8 project, I get a lot of Version conflicts. Here is the output:
Severity	Code	Description	Project	File	Line	Suppression State
Error	NU1107	Version conflict detected for Microsoft.CodeAnalysis.Common. Install/reference Microsoft.CodeAnalysis.Common 4.5.0 directly to project SimManager to resolve this issue.
SimManager -> Microsoft.EntityFrameworkCore.Design 8.0.0 -> Microsoft.CodeAnalysis.CSharp.Workspaces 4.5.0 -> Microsoft.CodeAnalysis.Common (= 4.5.0)
SimManager -> FastReport.OpenSource 2024.1.7 -> FastReport.Compat 2024.1.0 -> Microsoft.CodeAnalysis.VisualBasic 3.3.1 -> Microsoft.CodeAnalysis.Common (= 3.3.1).	SimManager	C:\Users\Jared\source\VoyagerPlatform\SimManager\SimManager.csproj	1
Describe the solution you'd like
Support the latest development and keep up with Microsoft.
Describe alternatives you've considered
Other reporting frameworks.
Additional context
Add any other context or screenshots about the feature request here.

The same thing happened to me, I just updated the packages and it worked normally

If you're encountering this issue, update your packages.


Repository addon is automatically installed by daemon in background

I specifically chosen to install elementum from zip file in order to not have the repository addon installed but it seems elementum daemon downloads generates and installs it by itself.
warning <general>: Repository add-on repository.elementumorg uses plain HTTP for add-on downloads in path http://<IP_ADDRESS>:65223/ - this is insecure and will make y
our Kodi installation vulnerable to attacks if enabled!

I know that warning is for localhost but nobody asked me and overall it feels quite invasive.

@9p6 JFYI: new version will have a setting for that https://github.com/elgatito/plugin.video.elementum/commit/05c490b975f504f025d89534da29bcf6e6261186
although, personally i do not see much value it this. e.g. if you want to disable updates - you can do with or without repo.
but vast majority of users needs auto update, thus they need repo.

in order to not have the repository addon installed

can you please describe why this can be useful/important?

I found Elementum disappointing and I'm no longer interested in it. I didn't like the fact that it made changes to my system and created another addon. I also didn't like the repo addon in itself - it had some dynamic stuff in it, wtf is that? I also didn't like that Elementum opened so many ports and autostarted HTTP server and showed me some shitty messages on reboot. I don't want any of this stuff. Long story short I just deleted and moved on.


Fix Tensorflow package check

What does this PR do?
This fixes the _is_package_available  function. As it is it will fail for all TF variants since even if they are installed since it will fail to get the metadata under the same name. Further down in this utils file there is code to check which variant (intel, rocm, etc) and get the metadata with the proper name, but it will never get that far because this updated version of _is_package_available` will always be False.

should this also be an upstream fix ?

should this also be an upstream fix ?

Yes. I'll open an PR.

looks like this is not needed along with the IFU. closing


ZipOutputStream Missing Close method in UWP

Steps to reproduce

Create a UWP project, in my case it is a Xamarin UWP project but it should not matter)
Create an instance of ZipOutputStream
Write some zip entries to a file
Flush and Finish methods exists but no Close method on ZipOutputStream

Expected behavior
Tell us what should happen
The generated zipped file should be a valid file without corruption.
Actual behavior
Tell us what happens instead
On Android, the generated file is zipped and I can unzip it without any issue and that is because on Android, ZipOutputStream has Close method.
However, my UWP project creates a corrupted zip archive because it is not closed properly as UWP version of ZipOutputStream is missing the Close method.  Attempt to open the generated zip file says that the file is corrupted because of unexpected end of data.
The tool tip shows Close method and if I hover over it, it says following:
MySolution.Droid - Available
MySolution.UWP - Not Available

If I use Close method, it fails to compile with message "ZipOutputStream  does not contain definition of Close and no extension method with first parameter of type ZipOutputStream exists."
Here is code sample
public Task MakeArchive(string fileFilter = "*", bool topLevelOnly = false)
{
    return Task.Run(() =>
    {
      	var directoryContents = Directory.EnumerateFileSystemEntries(...);

      	FileStream fileStream;
      	ZipOutputStream zipStream;

      	try
      	{
        		fileStream = new FileStream(path, FileMode.CreateNew, FileAccess.Write);
        		zipStream = new ZipOutputStream(fileStream);
      	}
      	catch (Exception e)
      	{
        		...
        		return;
      	}

      	foreach (var fileName in directoryContents)
      	{
        		var zipEntry = new ZipEntry(fileName);
        		var fileInfo = new FileInfo(fileName);

        		zipEntry.DateTime = fileInfo.LastWriteTime;
        		zipEntry.Size = fileInfo.Length;

        		zipStream.PutNextEntry(zipEntry);
        		WriteZipEntry(zipStream, fileName);
        		zipStream.CloseEntry();
      	}

      	zipStream.Flush();
      	zipStream.Close(); //Error - Not available under UWP
      	zipStream.Finish();

      	...
    });
}

Version of SharpZipLib
<IP_ADDRESS>
Obtained from (place an x between the brackets for all that apply)

[ ] Compiled from source
branch: _______
commit: _______
[ ] Downloaded DLL from GitHub
[ ] Downloaded DLL from SourceForge
[ ] Downloaded DLL from _______
[ ] DLL included as part of
Package installed using:
[x] NuGet
[ ] MyGet
[ ] Chocolatey

Wrapping creating of ZipOutputStream in using statement solves this issue.  It can be closed

Wrapping creating of ZipOutputStream in using statement solves this issue.  It can be closed


Refactor project 3 (as needed)

@esagara, pry yourself away from ILENE for a few minutes and accept the invite to this Github team.

I will try to run the scrape this week to make sure it still works as written, but it shouldn't need too many changes. I may add some other stuff such as caching (not a big leap I don't think). So unless we want to point it at another url, it should not be a heavy lift.

Ugh more malformed html on the BLS page. We need to either figure out how to address it or find a different url for the example. Could be a good lesson in dealing with the unexpected as this page seems to have problems of different flavors over time. See below for block of bad html - Lincoln is missing the opening
 tag which seems to be placed before the row for the United States entry.

United States
   5.5

1
Lincoln, NE Metropolitan Statistical Area
   2.1

2
Fargo, ND-MN Metropolitan Statistical Area
   2.2

Eric, malformed HTML could be a separate class altogether. It's a good discussion, but probably out of the scope of this class. How much trouble would it be to scrape a different URL?

How goes it? Do you need a hand with anything?

Tomorrow, we'll be exactly two weeks out from PyCAR. What's the good word, @esagara? Any luck with this yet?

Ok refactored project 3 to point to a new url - box office rankings. Also reworked the readme to match the changes I made.

#win


add version to base image

If version is not specified docker uses the latest image for base container thus pulling ubuntu:18.04 which is not supported

Hi @Modest-as , i didn't add the Dockerfile and don't personally use Docket so thanks for the contribution.


Update Composer dependencies (2024-07-26-00-18)

Visual regression test passed!
View the visual regression test report


using php Named parameter in routes

Laravel Version
11.6.0
PHP Version
8.3.9
Database Driver & Version
No response
Description
When using php 8 named parameters in Route facade in our routing the bug appears and our routing config is not working as expected.
Steps To Reproduce
The first isssue is when your are using a middleware static method call on your Route facade

and this is the produced bug.

second one is when you are using other static methods like prefix & also the chained method calls like as

and this is the second produced bug. route prefix and naming is replaced by 1 instead of app and application

Seems you sent in a PR so let's see how it goes. Thanks


Firebase missing DSYMs files - Xcode 15.3

Description
Hi
I have some issues with DSYMs files
In my Firebase console, I have a lot of missing, in the screen 3 versions should have had automatic upload via a script, but it is missing.

I also updated the script as per the guide

https://firebase.google.com/docs/crashlytics/get-deobfuscated-reports?platform=ios#check-input-files-setup

This is my config

Inside the Firebase Script:

Do you have any idea?
Thanks
Reproducing the issue
No response
Firebase SDK Version
10.24
Xcode Version
15.3
Installation Method
Swift Package Manager
Firebase Product(s)
Crashlytics
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Hi @salvatoreboemia, you may try the troubleshooting steps indicated on our docs here regarding the missing dSYMs. If the issue persists, please file a ticket through our support channel so the team could check your project. Thanks.

Hi @salvatoreboemia, you may try the troubleshooting steps indicated on our docs here regarding the missing dSYMs. If the issue persists, please file a ticket through our support channel so the team could check your project. Thanks.

I'm using this command
mdfind -name .dSYM | while read -r line; do dwarfdump -u "$line"; done
and I got correctly all DSYM file, the script is the one posted before.
But still missing file on Firebase console.
I will proceed to open a ticket
thanks

Hello, @salvatoreboemia
Do you resolve this issue, I got the same one. Could you help me share your solution with me?
Thanks.


[CARBONDATA-2829][CARBONDATA-2832] Fix creating merge index on older V1 V2 store

Block merge index creation for the old store V1 V2 versions

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done
Manual Testing

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6171/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7791/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6516/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6176/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6520/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7796/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7798/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6522/


Do not forcibly enable/disable SSL

Like pam_password and the legacy PAM authentication plugin before it, pam_interactive forcibly enables SSL to protect potentially sensitive information being sent from the client to the server (e.g. PAM passwords). The Authentication Working Group decreed in March 2024 that the plugin shall allow for an "insecure" mode. From the minutes, found here: https://github.com/irods-contrib/irods_working_group_authentication/blob/main/20240326-minutes.md

This can be avoided by just using SSL all the time / manually but the plugin needs to enforce this before we release
Or we just yell loudly to the admin that the system is not SSL-enabled
Default is SSL - active option to disable SSL

So, rather than enabling SSL when it is not already being used, the plugin will use whatever the client and server have agreed to use in their communications. If SSL is required, SSL will be used. If SSL is refused, SSL will not be used. However, when a non-SSL connection uses the plugin, it shall log warning messages very annoyingly to alert the administrator that PAM information is being sent over the network in the clear.
We could even create an option to enforce or not enforce SSL, but this would need to be explicitly and intentionally set by the administrator such that they are knowingly running the system in an insecure manner.
Bonus note: The "This can be avoided" note seen above is referring to the bug which has been fixed here: #16

insecure_mode has been added so that SSL is allowed to be disabled while using the plugin. Left lots of notes and warning messages about it so that it is clear that we highly discourage its use in production.


V2 and Rhino 6 (Invalid JSON)

There seems to be a bug that prevents the plugin from working properly on RH6, even when .net framework 4.7.2 is installed.
Will look into it, soon...

Fixed on Windows in 2.0.1
On Mac I'm unable to resolve the issue, as such I've added a check and notification message for RH6 on Mac

Mac issues on RH6 is properly solved in 2.0.3


how to conditionally insert a null or FK value?

Hi all.
I have a mysql table with an optional foreign key that I'm trying to insert into.  I can't figure out a way how to code the insert when I need to insert a NULL, if there foreign key relationship is not there and set the foreign key column to a value if the relation is there.
The only way I've found this to work is to do an INSERT, following by a conditional UPDATE - setting the foreign key column.  Obviously, this isn't efficient.
With a stock 'insert_into' does anyone have any hints on how I might do this?
Thanks!

Hi,
You can use value_or_null:
sqlpp::value_or_null(7); // gets interpreted as 7
sqlpp::value_or_null<sqlpp::integral>(sqlpp::null); // gets interpreted as "integral" NULL

Or you can use tvin (stands for "trivial value is null"):
sqlpp::tvin(7); // gets interpreted as 7
sqlpp::tvin(0); // gets interpreted as NULL
sqlpp::tvin("seven"); // gets interpreted as 'seven'
sqlpp::tvin(""); // gets interpreted as NULL

(I am thinking about deprecating tvin, though, it is too implicit)
Or you use case_when:
sqlpp::case_when(condition).then(7).else_(sqlpp::null); // interpreted as SQL case expression

My recommendation is value_or.
Best,
Roland

Excellent.  Thanks!


Cannot convert Rational to float

from symengine import Rational
x = Rational(2,3)
print(float(x))

raises a TypeError.
The best workaround I found so far is float(x.n().real_part()).

Unfortunately the fix (or some other recent change) seems to destroy my work-around (see https://github.com/neurophysik/jitcdde/issues/17). More specifically, sympy.Float(42).real_part does not exist (only sympy.Float(42).real).
Can you either make a release (that allows me to pinpoint the version requirements) or implement a real_part attribute for Floats for backwards compatibility? Since everything is hardcoded, I can not monkey-patch this either.

That fix should be backwards compatible. Which version of symengine are you using?

That fix should be backwards compatible. Which version of symengine are you using?

I am comparing a version I pulled a few minutes ago from GitHub and the latest pre-release from PyPI (0.3.1.dev1). What I need something that converts any of SymEngine’s non-complex number types (Integer, Rational, Float, …) to a Python float and works in both of these versions (or a new release/pre-release).
Suppose x is my SymEngine number (e.g., x=symengine.Rational(2,3)). In the current version, I can just use float(x), but that does not work in the pre-release. In the pre-release I can use float(x.n().real_part()) but that does not work in the current version (“'RealDouble' object has no attribute 'real_part'”); the closest I can get is float(x.n().real).

@Wrzlprmft is the issue that you are trying to make your code work with multiple versions of symengine?
Could one have a check based on a version of symengine and do what works for each? I understand that's not ideal, but at least it's some way forward.

@Wrzlprmft, use float(x.n(real=True)) which should work in both versions.

@Wrzlprmft is the issue that you are trying to make your code work with multiple versions of symengine?

Correct. Alternatively, I can deal with this using explicitly requiring a version, but that would require a release.

Could one have a check based on a version of symengine and do what works for each? I understand that's not ideal, but at least it's some way forward.

sympy.__version__ returns 0.3.1.dev1 in both cases, so that wouldn’t work. What I could do is to catch the exception, but I see no easy way to avoid catching some real problems due to faulty user input or similar. Anyway:

@Wrzlprmft, use float(x.n(real=True)) which should work in both versions.

Indeed. That solves my problem. Thank you.

@Wrzlprmft perfect, I am glad it's solved. Sorry about the inconvenience.


API 2.0  BC_OAS.js is not available on page for download

Hi,
Browsing the documentation you are referencing to an API 2.0, but this page still  references in the download section only  to v1.0. When will be available the link to download v2.0?
Thanks in advance
Genís

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f73b29a3-942d-079d-08bf-4ab67ec213ee
Version Independent ID: f236c724-5fb1-dbc2-b12e-ceb49e901af7
Content: OpenAPI Specification - Dynamics NAV
Content Source: dynamics-nav/api-reference/v2.0/dynamics-open-api.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

This is an issue for us also. Is the 2.0 spec going to be available any time soon?


Don't escalate privileges in task wait for admin account creation

Fixes #10

set become: false for the task that waits for Admin account creation as we do not need escalated privileges for this

Oo this is good, I'm about to hit that task


kaizen: Prepare for release 1.2.0

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.73%. Comparing base (20480ea) to head (f5ab5c5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   96.73%   96.73%
=======================================
  Files          18       18
  Lines        1837     1837
=======================================
  Hits         1777     1777
  Misses         34       34
  Partials       26       26

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Next PR should fix that benchmark issue.


Adding toaster to make it more appealing

When clicking on the login, logout, or signup button, a toaster notification will appear.
I can help you implement this feature. I would be grateful if you could assign me this issue under the GSSoC-ext and Hacktoberfest labels. I am looking forward to working on this issue.

@ChandraST12 go ahead.
It'll be good if you use Toastify.
Also make sure you make the toasts theme-friendly.

merged


docs: Cluster-wide debugging tool documentation

Update docs to add a section about the cluster-wide debugging tool.
Fix some nitpicks in existing documentation; Simplify the content.

Signed-off-by: Ashwin Paranjpe<EMAIL_ADDRESS>Summary of changes:
Fixes: https://github.com/cilium/cilium/issues/2349

Hmm, missed some things will go through again.

@scanf Fixed the rendering issues. Please review.


use after free reported by ASAN

I ran example/linux/virtualization with ASAN enabled (sed -i '.bak' 's/FLAGS: /&-fsanitize=address /g' *.go), and the example program segfaulted with:
=================================
==53567==ERROR: AddressSanitizer: heap-use-after-free on address 0x60600002ae11 at pc 0x0000042115b5 bp 0x7ffeefbff7d0 sp 0x7ffeefbfef90
READ of size 37 at 0x60600002ae11 thread T0
    #0 0x42115b4 in wrap_strlen+0x184 (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x155b4)
    #1 0x7fff20691598 in _dispatch_strdup_if_mutable+0x11 (libdispatch.dylib:x86_64+0x2598)
    #2 0x7fff2069750c in _dispatch_lane_create_with_target+0x154 (libdispatch.dylib:x86_64+0x850c)
    #3 0x40adb5b in _cgo_a012ac8bb423_Cfunc_makeDispatchQueue+0x4b (virtualization:x86_64+0x40adb5b)
    #4 0x40635e3 in runtime.asmcgocall.abi0+0x63 (virtualization:x86_64+0x40635e3)

0x60600002ae11 is located 17 bytes inside of 64-byte region [0x60600002ae00,0x60600002ae40)
freed by thread T0 here:
    #0 0x4241096 in __sanitizer_mz_free+0x86 (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x45096)
    #1 0x7fff209ffade in _CFRelease+0x478 (CoreFoundation:x86_64h+0x14bade)
    #2 0x7fff206fa20e in AutoreleasePoolPage::releaseUntil(objc_object**)+0xa6 (libobjc.A.dylib:x86_64h+0x2620e)
    #3 0x7fff206dce2f in objc_autoreleasePoolPop+0xa0 (libobjc.A.dylib:x86_64h+0x8e2f)
    #4 0x40ac29e in _cgo_a012ac8bb423_Cfunc_getUUID+0xae (virtualization:x86_64+0x40ac29e)
    #5 0x40635e3 in runtime.asmcgocall.abi0+0x63 (virtualization:x86_64+0x40635e3)

previously allocated by thread T0 here:
    #0 0x4240dc2 in __sanitizer_mz_calloc+0x92 (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x44dc2)
    #1 0x7fff2067dff3 in _malloc_zone_calloc+0x3a (libsystem_malloc.dylib:x86_64+0x1bff3)
    #2 0x7fff208b7e61 in _CFRuntimeCreateInstance+0x125 (CoreFoundation:x86_64h+0x3e61)
    #3 0x7fff208b756b in __CFStringCreateImmutableFunnel3+0x76b (CoreFoundation:x86_64h+0x356b)
    #4 0x7fff208c3805 in CFStringCreateWithBytes+0x1a (CoreFoundation:x86_64h+0xf805)
    #5 0x7fff216890bd in +[NSString stringWithUTF8String:]+0x43 (Foundation:x86_64+0x250bd)
    #6 0x7fff21689ce6 in -[__NSConcreteUUID UUIDString]+0x40 (Foundation:x86_64+0x25ce6)
    #7 0x40ac26c in _cgo_a012ac8bb423_Cfunc_getUUID+0x7c (virtualization:x86_64+0x40ac26c)
    #8 0x40635e3 in runtime.asmcgocall.abi0+0x63 (virtualization:x86_64+0x40635e3)

SUMMARY: AddressSanitizer: heap-use-after-free (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x155b4) in wrap_strlen+0x184

SIGABRT: abort
PC=0x7fff2080d91e m=0 sigcode=0
signal arrived during cgo execution

goroutine 1 [syscall]:
runtime.cgocall(0x40adb10, 0xc000143d10)
	/usr/local/Cellar/go/1.18.4/libexec/src/runtime/cgocall.go:157 +0x5c fp=0xc000143ce8 sp=0xc000143cb0 pc=0x40085dc
github.com/Code-Hex/vz/v2._Cfunc_makeDispatchQueue(0x60600002ae11)
	_cgo_gotypes.go:386 +0x49 fp=0xc000143d10 sp=0xc000143ce8 pc=0x40a2189
github.com/Code-Hex/vz/v2.NewVirtualMachine(0x40fd2f0?)
	/Users/teuf/code/vz/virtualization.go:105 +0x45 fp=0xc000143d88 sp=0xc000143d10 pc=0x40a6a25
main.main()
	/Users/teuf/code/vz/example/linux/main.go:121 +0x626 fp=0xc000143f80 sp=0xc000143d88 pc=0x40a8306
runtime.main()
	/usr/local/Cellar/go/1.18.4/libexec/src/runtime/proc.go:250 +0x212 fp=0xc000143fe0 sp=0xc000143f80 pc=0x4038932
runtime.goexit()
	/usr/local/Cellar/go/1.18.4/libexec/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc000143fe8 sp=0xc000143fe0 pc=0x4063901

I can workaround the problem with the change below, but I'm not familiar enough with go/objc memory handling in order to send a proper fix:
commit 2f29e7d6d904e45275f8ef5d3eaec4a7d07d291f
Author: Christophe Fergeau<EMAIL_ADDRESS>Date:   Sat Sep 10 13:24:56 2022 +0200

    hack: remove autoreleasepool to hack around use after free

diff --git a/objcutil.go b/objcutil.go
index e214be0..a93ad2b 100644
--- a/objcutil.go
+++ b/objcutil.go
@@ -111,10 +111,10 @@ void* getNSArrayItem(void *ptr, int i)
 const char *getUUID()
 {
 	const char *ret;
-	@autoreleasepool {
+	//@autoreleasepool {
 		NSString *uuid = [[NSUUID UUID] UUIDString];
 		ret = [uuid UTF8String];
-	}
+	//}
 	return ret;
 }
 */

Thanks!
Exactly, We should not use release for NSUUID class https://developer.apple.com/documentation/foundation/nsuuid?language=objc

See https://github.com/Code-Hex/vz/pull/46#issuecomment-1252257553 for a reproducer and a fix for this issue.

https://github.com/Code-Hex/vz/pull/52 has a test case to reproduce this
test: Add basic VirtualMachine unit test + test: Add 'test-asan' Makefile rule
It also has a fix for this: Fix use after free in getUUID()

Sure. Check later

@cfergeau why didn't you send PR like this diff?
commit 2f29e7d6d904e45275f8ef5d3eaec4a7d07d291f
Author: Christophe Fergeau<EMAIL_ADDRESS>Date:   Sat Sep 10 13:24:56 2022 +0200

    hack: remove autoreleasepool to hack around use after free

diff --git a/objcutil.go b/objcutil.go
index e214be0..a93ad2b 100644
--- a/objcutil.go
+++ b/objcutil.go
@@ -111,10 +111,10 @@ void* getNSArrayItem(void *ptr, int i)
 const char *getUUID()
 {
 	const char *ret;
-	@autoreleasepool {
+	//@autoreleasepool {
 		NSString *uuid = [[NSUUID UUID] UUIDString];
 		ret = [uuid UTF8String];
-	}
+	//}
 	return ret;
 }
 */

I agree with crc should use own fork repository :+1:

@cfergeau No I said for only NSUUID.
This code is followed my comment. https://github.com/Code-Hex/vz/issues/47#issuecomment-1250234069

Oops, I'm mixing up issues ^^
I tried to address it with https://github.com/Code-Hex/vz/pull/52/commits/eae871eb2c35f07eeff8fc226da262a637a5fca0 in order to keep the autoreleasepool as I was worried about memory leaks. If it's better to remove the autoreleasepool, I can make that change.


[OSPO Book] Content and Copy edits to PR "Final Review for chapter 4"

Copy edits to improve readability, and adding content to empty table cells.
Signed-off-by: Alice Sowerby<EMAIL_ADDRESS>AnaJS: Including the contributors that participated in the content creation of this PR: https://github.com/todogroup/ospology/pull/500 and which are also included in this PR
These are changes that came from the final review during Chapter 4 meeting. During the call and the next two weeks, the changes were included using this docfor chapter intro and this doc for activity table
Contributors in this PR:

Alice Sowerby
Cornelius Schumacher
Gergely Csatari
Ana Jiménez
Ulises Gascon
Jan van den Berg

These people are also acknowledged in the OSPO Book contributors section.

@alice-sowerby Great work Alice! Thank you!
PS: I've included in the description of this PR the details from the now duplicated PR here: https://github.com/todogroup/ospology/pull/500

@koozz @anajsana my understanding was that we wouldn't add emojis without an overall design from the designers?

@koozz @anajsana my understanding was that we wouldn't add emojis without an overall design from the designers?

That's OK 👍

@koozz @anajsana my understanding was that we wouldn't add emojis without an overall design from the designers?

Correct. But this might take time, so I'd suggest merging this and keeping the emoji. and then take care of replacing the emojis for the official icons, once this is ready

@alice-sowerby besides changing emoji to custom icons open issue: Do you think this PR is ready to be merged? Are there any blockers on my end?

@anajsana I think it's good to go!


Explain rationale behind normalizing per-country's labels from 0-1

Normalization per country:

Random forest does not need normalization but for our case, the consolidated survey data is not sampled from a single population (country). The model trained from sample data from one population (country) is likely not able to predict well when tested with samples from another population.
Normalization helps by attempting to correct country-specific feature quirks by fixing the allowable range of values:

PH samples having generally higher nightlights luminosity and road count

Evident for lower wealth income quintiles
When normalized, each country will have its own baseline

Reference: Chi, G. et al. (2022) “Microestimates of wealth for all low- and middle-income countries,” Proceedings of the National Academy of Sciences, 119(3). Available at: https://doi.org/10.1073/pnas.2113658119.

-Wealth estimation for low and middle income countries using DHS: 135 countries

Used StandardScaler per country: All input features are normalized by subtracting the country-specific mean and dividing by the country-specific SD

Explore: outlier detection methods per country

Next step: normalize each feature per country along with the wealth index (as documented by issue #112)


Broken links in economic_curves

@open-source-modelling github.com/qnity doesn't seem to exist anymore. Shouldn't the links be updated?

close due to PR


Add docker support

Left some comments on the dockerfile, could you also remove the line regarding the maintainer?

Hi @toschneck, thanks for the PR! There are a few unaddressed review comments, are you still interested in pushing this forwards?

Hi @ronjouch, unfortunately I had in past weeks no time for that because of my vacation. But yes, I'm still interested, I will take a look at this, hopefully this or next week. Is this ok for you guys?

Hi @ronjouch, unfortunately I had in past weeks no time for that because of my vacation. But yes, I'm still interested, I will take a look at this, hopefully this or next week. Is this ok for you guys?

@toschneck sure! Was asking as part of a big issues/pulls triage. Thanks for your contribution 👍

This PR was inadvertently closed due to us getting rid of the old development branch (we came back to merging on good'ol master). Changing base branch to master and reopening.
@toschneck when you find the time to work on that, a rebase will be welcome :)

@ronjouch I would have done this anyway, so it's fine. I will try to find time this week

@ronjouch I updated the Dockerfile:

use alpine image
make installation chacheless
use user 1000 for build
download osx & linux electron installation during build time, to get a "read-to-use" image.

TODOs:

To build windows apps are currently not possible, because of non 64-bit version of node-rcedit, see https://github.com/electron/node-rcedit/issues/22. Also there is currently no 32-bit alpine package for wine, what possible solve this issue to. One possibility would be to use Ubuntu again, what do you think about this?
Also you can setup an automated build on dockerhub. Because I don't have enough access rights on the github repo, only one of you guys can do this. Then you also can update the Docker usage passage in the README.md.

I'll add it to dockerhub after this is merged! @toschneck

@jiahaog updated the PR :wink:

@toschneck Awesome, tried it out and it works great. Thanks so much! :1st_place_medal:

Cooooooo. @toschneck thanks for initiative, and thanks for keeping up with the PR :) 👍

your welcome! Glad to can contribute some helpfull stuff to your great project!

@toschneck
A possible workaround is to directly use the docker wine image provided by electron-builder.
If you don't want to, you could use directly a 32bits alpine image but some others projects heavily rely on the 64 bits for binaries distribution (nsis support in electron-builder)...


Support pprof format natively

The pyroscope ecosystem is around Go pprof. I think it makes sense that the agent would be able to emit pprof natively in order to improve data flows that would operate on the canonical form. It can make them simpler and more efficient. For example:

it will make writing tools in different languages easier with the oss pprof support, as I only see async-profiler java jfr2pprof (which you use in JPProf) and your Go server parser for JFR. I have a node app (unfortunately) where I need to simulate some pyroscope api and I would like to receive pprof
apply a more efficient format early
provide flexibility to tradeoff parse performance overhead across the pipeline depending on the use case, for example offload large scale parse work to the distributed data plane where it may be more negligible.

I think this should be complementary to an agent capability https://github.com/grafana/agent/issues/4716

Yes please I think the best we could do is actually send using the new API so all in for doing a pprof conversion.


"OR" filter not working for OneToOne-related models

Describe the bug
When running a query including an "OR" filter the filter gets passed as "AND" (according to the query shown in the Django Debug Toolbar)
Django Model
class SomeBaseModel(models.Model):
     some_base_attr = models.CharField(...)
    ...

class SomeModel(SomeBaseModel):
    some_other_attr = models.FloatField(...)
    ...

Types
@type(models.SomeBaseModel, filters=filters.SomeBaseFilter)
class SomeBaseNode(relay.Node):
    some_base_attr: auto
    ...

@type(models.SomeModel, filters=filters.SomeFilter)
class SomeNode(SomeBaseNode):
    some_other_attr: auto
    ...

Query
{
  someQuery(filters: {
    id: {exact: "U29tZU5vZGU6MjMwNg=="}
    OR: {id: {exact: "U29tZU5vZGU6MjI3NA=="}}
  }) {
    edges {
      node {
        id
      }
    }
  }
}

I guess it has to do with the build_filter_kwargs function in filters.py. Trying to figure out how the function works, but, unfortunately, it's a bit complicated ;)
System Information

Operating system: Ubuntu 20.04.6 LTS
Strawberry version (if applicable):

strawberry-graphql: version 0.215.1
strawberry-graphql-django: 0.25.0

I played a bit around and the real problem seems to be that the build_filter_kwargs function in filters.py relies on the fields order of filters.__strawberry_definition__.fields. More precisely, the logical fields AND,OR, and NOT fields necessarily need to be the last fields. This order is not guaranteed, since subclassing another Filter (see SomeFilter in my bug report above) will append its fields AFTER the logical fields and filter_kwargs will be an empty Q()-object when entering line 226 of filters.py.
By extending line 183 from
for f in filters.__strawberry_definition__.fields:

to
if filters.__strawberry_definition__.fields:
        filters.__strawberry_definition__.fields.sort(key=lambda x: x.name, reverse=True)

for f in filters.__strawberry_definition__.fields:

seems to fix the problem. Unfortunately, I have no idea if sorting the fields inplace will impact any other code...

Hi @TWeidi ,
Hrm, that's really interesting!
Would you like to try to open a PR for this?
Also, I would not sort the fields inplace, but instead just call sorted() which returns a copy of it. i.e.
for f in sorted(filters.__strawberry_definition__.fields, key=lambda x: x.name, reverse=True):

Hi @bellini666,
sure, I can do that. Do you want me to add a dedicated test case or are you fine with the existing one ('test_or')?

sure, I can do that. Do you want me to add a dedicated test case or are you fine with the existing one ('test_or')?

If you can it would be awesome! I mean, the current tests did not catch this issue, so it would be nice to have something that would have caught it

Fixed by https://github.com/strawberry-graphql/strawberry-django/pull/478


Change Size

modern wooden desk
modern bedside table
modern cupboard with glass doors

Tested sizes for Android

That's irrationally much. In real the drawers and cabinets couldn't just physically contain so lots of items. Inventory sizes should be proportionate with the sizes of their storages. Besides that, the player inventory is 8x4 slots, you for some reason changed to 16x2.
Also, I already increased for you the wardrobe size to 8x6 since you requested about that: dad6f0e1e1705e171570fbc0ce564428f9861771


Fix for issue #218

Since the container is now running as a non-root user, the HTTPS port number on line 26 of the Dockerfile will need to be increased (e.g. to 8443). But where is this port number configured? In nginx/default.conf we can see the server only listens on port 8080.

@AaronChelvan could you elaborate the issue that you are facing with https?
isn't it working after uncommenting lines in docker-compose here https://github.com/Visual-Regression-Tracker/Visual-Regression-Tracker/blob/master/docker-compose.yml#L7 and changes in .env to http protocol in urls?

Sorry, my mistake - nginx can listen on low port numbers so we don't need to change port 443 to 8443. And yes, HTTPS works when I uncomment those lines. No issues from me.

*I meant that there's no issue with HTTPS. But can we still get these changes merged for running as a non-root user?

@AaronChelvan sorry, didn't get your point
could you elaborate what is the problem running it as root?

We are running VRT within Kubernetes. To minimise the security risk, we want to run all containers with the least amount of privileges required. When I tried to run this frontend container as with a non-0 UID, I was getting the errors that I described here:  https://github.com/Visual-Regression-Tracker/Visual-Regression-Tracker/issues/218
So this PR changes the ownership of some files & directories so that the container can run as non-root.

@AaronChelvan thanks for explanation
I invited you as collaborator
please, re-create PR from organisation feature branch (this is fixing failing tests due to secure restriction)
do we need the same for backend project?
could you share you k8s config for VRT as example for other people?

Recreated the PR: https://github.com/Visual-Regression-Tracker/frontend/pull/197
The backend project seems to work fine when running the container with a non-root UID & GID
Sure, I can open another PR for a k8s configuration example. Where would be the best place to put these files?

@AaronChelvan could you add some example on wiki?
let me know if you need additional permission for it
https://github.com/Visual-Regression-Tracker/Visual-Regression-Tracker/wiki

Added some information here: https://github.com/Visual-Regression-Tracker/Visual-Regression-Tracker/wiki/Kubernetes-Configuration-Example

@AaronChelvan looks awesome, thank you for contribution!


Increase MaxFrameLen to 16 MB

EigenDA current limit for Holesky (their documentation is currently outdated but the limit seems to be set to 16 MB based on the updated tests from this PR).

Tested on Holesky with EigenDA as AltDA.


Issue with iframe width not scaling on iPhone

Hi there,
Ran into an issue where the iframe width won't scale on the iPhone (height works though), there's a test case here: http://bit.ly/1GJNHuM
The first iframe is the one not working, the second iframe includes a page from the same domain as where the iframe resides, the scaling there works as expected across the board.
What could be causing this problem?

Could you please put some simple content in those iFrames.

Just checking, you mean something simpler than the content they now contain or are they empty for you?

Yes just enough hamlet to recreate the issue.

Sorry for the late reply, turns out the site that was in the iFrame had a point where the horizontal scrollbar became visible, this also became the exact width of the iFrame on Safari/iPhone. Now that the "iFramed" site is corrected and responsive everything works as expected. Thanks for a great library!

Thanks for the update.


Phase 2

Before you submit, please check that:

[ ] You labeled the PR with appropriate labels, if any.
[ ] You mentioned a related issue if this PR related to it, e.g. Fixes #22 or Related #17.
[ ] You performed a self-review of your own code
[ ] You commented on code, particularly in hard-to-understand areas
[ ] You asked any particular reviewer to review. If you aren't sure, ask.
[ ] Your PR adheres to our CONTRIBUTION GUIDELINES

After you've read this notice feel free to remove it.
✄ -----------------------------------------------------------------------------
What does this PR do?
A clear and concise description of what the PR aims to accomplish.
Description of Task to be completed?
How should this be manually tested?
A clear and concise description of how the changes can be tested.
Any background context you want to provide?
Screenshots(optional)
If applicable, add screenshots to help to explain the problem/solution.
Additional context(optional)
Add any other context if any.

Next steps:

Create an index page for showing all the modules.
Add compiler to the learning interface for module 2 & 3. Keep frontend validation logic for module-1 the same. Question to ask: How to go about implementing validation logic for every chapter within modules 2 & 3? Mock for reference: https://www.figma.com/file/sukJaz6yhGEVcqHF9HNZLz/BUIDL-Labs---Project---Cryptoverse-Wars-Abhinav-Pandey?node-id=0%3A1
Writing content for overview pages for modules 2 & 3.

@manangouhari  Let me know if I am missing something.

Next steps:
1. Create an index page for showing all the modules + linking everything from start to finish.

2. Add compiler to the learning interface for module 2 & 3. Keep frontend validation logic for module-1 the same. Question to ask: How to go about implementing validation logic for every chapter within modules 2 & 3? Mock for reference: https://www.figma.com/file/sukJaz6yhGEVcqHF9HNZLz/BUIDL-Labs---Project---Cryptoverse-Wars-Abhinav-Pandey?node-id=0%3A1

3. Writing content for overview pages for modules 2 & 3.

@manangouhari Let me know if I am missing something.

Do we have a design for the index page?

Do we have a design for the index page?

No. You can refer cryptozombies curriculum   design for inspiration.

TODO:

Add content for a general overview of the lesson.
Dynamically updating the header title of the learning interface according to the module.

TODO:
* Add content for a general overview of the lesson.

* Dynamically updating the header title of the learning interface according to the module.

Have done the needful. Please review and let me know if there's something I missed.


Lab-13-deploy-automation-runbook-rebuild-indexes: outdated screenshot add firewall rule

Module: 06
Lab/Demo: 13
Task: Connect to an existing Azure SQL Database
Step: 03-04
Description of issue
Outdated screenshot and process to add the firewall exception:

Thanks for your submission.
The module [Manage Azure PaaS resources using automated methods] is on the queue to be released, including a new lab profile and instructions for this lab.


drawerLockMode not supported

According to the latest 3.0 documentation, drawerLockMode is still documented as supported when in fact it is not. We should either update the docs or update the source code to actually support it. And this should also be documented as a breaking change in the release notes (actually happened as of react-navigation-drawer version 0.5.0 which was part of react-navigation 2.x)

Actually the above changes breaks animation for the stack navigator due to re-rendering. However I did find a workaround which allows me to accomplish what I wanted with the drawerMode
Settings: {
      screen: SettingsNavigator,
      navigationOptions: ({ navigation }: any): any => {
        if (navigation.state.index > 0) {
// drawerLockMode is a no-op, but `minSwipeDistance` = 10000 effectively disables the gesture
          return { drawerLockMode: 'locked-closed', minSwipeDistance: 10000 }
        }
        return {}
      },
    },

@jhaankit yes i did. And it didn't work because of this

@tonyxiao  It should work. Try doing as same as example.
Step 1: Create a Stack navigator
const FeedStack = createStackNavigator({
  FeedHome: FeedScreen,
  Details: DetailsScreen,
});

Step 2: Create a Drawer navigator
const DrawerNavigator = createDrawerNavigator({
  Feed: FeedStack
});

Step 3: return drawerLockMode on stack navigationOptions. The drawer lock will be applicable for FeedStack stack only.
FeedStack.navigationOptions = () => {
   return { drawerLockMode: 'locked-closed' }
}

A minimal example can be found here:
https://github.com/abn-volk/drawerLockMode. In the example, various methods are used to set the drawerLockMode to locked-closed, but the drawer is not locked.
Here's the same example but with react-navigation v2: https://github.com/abn-volk/drawerLockMode/tree/v2. The only change is the removal of createAppContainer. Everything works.
I've tried to use Snack but it doesn't work, so I've published the examples here: https://exp.host/@jibi/drawerLockMode (for v3) and https://exp.host/@jibi/drawerLockMode-v2 (for v2).

thanks for the report @tonyxiao 👋 i will investigate it

this is fixed now, if you clear your yarn.lock and reinstall react-navigation you'll get<EMAIL_ADDRESS>with the fix

Ok, this is the way it's working for me now.
  FeedStack: {
    screen: FeedHome,
    navigationOptions: ({ navigation }: { navigation: any }) => ({
      drawerLockMode: navigation.state.index > 0 ? 'locked-closed' : 'unlocked',
    })
  }
};

I do not see a navigation.state.index in my navigation object. I tried what I have right now and it still doesn't lock the drawer. Is there a solution to lock a specific route? I have the latest version of react-navigation and the react-navigation-drawer. The actual source code can be found here. Thanks!

Module
Version

npm
6.4.0

react-navigation
3.3.0

react-navigation-drawer
1.2.0

node
8.11.3

react-native
0.58.3

react-native-gesture-handler
1.0.15

const Stack = createStackNavigator(
  {
    Main: {
      screen: ExtendStack,
      navigationOptions: {
        header: props => <CustomHeader {...props} />
      }
    },
    Test: {
      screen: Reader,
      navigationOptions: ({navigation}) => ({
        // does not work here
        // neither does
        drawerLockMode: navigation.state.routeName == "Test" ? 'locked-closed' : 'unlocked'
      }),
    }
  }
);

class ExtendHeader extends React.Component {
  static router = Stack.router;
  render() {
    const { navigation } = this.props;
    return <Stack navigation={navigation} screenProps={navigation.state.params} />;
  }
}

const HomeScreenRouter = createDrawerNavigator(
  {
    MyLibrary: { screen: HomeScreen },
    Sources: { screen: Sources },
    Manga: { screen: ExtendHeader }
  },
  {
    contentComponent: props => <SideBar {...props} />,
  }
);

@lee-aaron U have to put that code ( navigationOptions: ({navigation}) => ... ) in screens inside createDrawerNavigator({...})


Add MIT LICENSE file loved by lawyers everywhere

Fixes #6

Coverage decreased (-0.3%) to 98.026% when pulling 30a3d2967ea3e5b25e720e5a79b23d8691f9e2f2 on johnjbarton:patch-1 into bdf563343ff76e88402e1ab0b5040515b71502b5 on Rob--W:master.

done

Thanks.


[Question] Parse csv file from stream

I'm uploading a .csv file that i want to process before i save on disk (IFormFile). Is it possible to parse it without saving it first on disk?
Thanks for the great library!

As long as you can convert your data into an IEnumerable<string> or string it is possible:

https://github.com/bytefish/TinyCsvParser/blob/a127113d1415ca1f284e73c61fc1f1bb2c9b9df6/TinyCsvParser/TinyCsvParser/CsvParserExtensions.cs#L30

The CSV Parser itself takes an IEnumerable<Row> at the moment. If you have an IEnumerable<string>, then simply do a Select to a Row and omit the line number if you don't have it.

https://github.com/bytefish/TinyCsvParser/blob/master/TinyCsvParser/TinyCsvParser/CsvParser.cs#L24

Let me know, if this solves the problem.

That's great, thank you. I actually went for a very similar implementation that seems to work very well (no tests performed yet, but my csv files will always be less than 50MB in size and used only once/twice a day so memory will not be an issue).
var result = csvParser.ReadFromStream(csvReaderOptions, batchFile.OpenReadStream()).ToList();
public static ParallelQuery<CsvMappingResult<TEntity>> ReadFromStream<TEntity>(this CsvParser<TEntity> csvParser, CsvReaderOptions csvReaderOptions, Stream fileStream)
            where TEntity : class, new()
        {
            if (fileStream.Length == 0)
            {
                throw new ArgumentNullException(nameof(fileStream));
            }

            string content;
            using (var reader = new StreamReader(fileStream))
            {
                content = reader.ReadToEnd();
            }

            var lines = content
                .Split(csvReaderOptions.NewLine, StringSplitOptions.None)
                .Select((line, index) => new Row(index, line));

            return csvParser.Parse(lines);
        }


Add support for invalid char in file

Add support for file invalid char

API change check
API changes are not detected in this pull request.

@EmmaZhu I'd thought that we fixed the issue in codegen and core to support xmlIsMsText: true so that the workaround of conversion in storage code is no longer needed.  Somehow that fix doesn't work for you?

@jeremymeng , the content and attribute is passed from XML correctly. This PR is to decode the directory name or file name from the passed content. This way the input file name would be the same with the one gotten from listing.

@EmmaZhu got it. thanks for the explanation!


Lab3 submission

Me and Haardhik created the SMS header and implementation files. So far, we've focused our attention on the Accumulation Table and Filter Table logic. Note that we haven't attempted to build our implementation; we're merging this PR for a lab submission to show that we're working on the project and making progress.
This is merging changes into lab3-submission, which is not the main branch, so there is no impact on anyone hit-cloning...
Haardhik,
Could you review the implementation files below? Just FYI, I merged our code together. I thought this was the best mix of our ideas. Again, note that I haven't attempted to build this code. I'm just PRing for the lab submission (to show we're on track).
If not approved, let me know what specifically to fix!

Disregard.
Ignore this PR, I didn't realize it was a request to merge into the main branch...
My changes should already be in the lab3-submission branch.


feat:Add an autocomplete feature for input content history in the que…

…stion box, allowing for the selection of historical prompts in the initial state.

There are confections with latest main branch


Calling the individual classes in MainActivity

Please as a beginner android, I'm confused as to how to link those classes written with the main activity. Will I need to call some specific methods too when  calling the RegistrationIntentService class in the main activity?
Thanks

The issues tab isn't really a place for these types of technical troubleshooting questions. You can post here if you'd like and if anyone wants to help then they can respond there. Otherwise, you would likely find more luck posting on stackoverflow. Thanks for your understanding.


Implement shortcut feature in MojWykop app

Description
I've added a possibility to use an Android Shortcut in Wykop app.

I created a special class to dispatch a shortcut intent;
I prepared special icons which are compatible with Material Design Standard
All icons are an in.PNG extension, but I decresed these size by special web tool - tinypng.com

Thanks a lot for the PR. Code LGTM, but I'll wait for @Kroguc 's opinion on this feature.

Thanks a lot!


feat: Use friendly verbose and colorish

closes #959
closes #812
This PR proposes to:

use a default logger that does not show any information by default
introduce a --verbose option for the CLI or verbose parameter for the functions
a decorator that register a rich handler depending of the verbose parameter
introduce a rich console with cyan/orange colors (as the default skore theme) for showing the pertinent information.

TODO:

[x] add a test to check if logger_context is behaving as expected.
[x] add tests at the CLI level commands.

It would currently look like.
Terminal

Notebook

VS code

Documentation website

So I switch from a decorator that was implicitly consuming verbose to a context manager that explicitly consume the verbose parameter. The former has a bug and was too much magical at my test. The context manager is much nicer in this regard.

@thomass-dev This last run will be fun for you :). In addition of the issue with the coverage (I maybe need to merge main), I segfault in Windows ;)

@thomass-dev I leave to you to merge this? 🙏


Ignore order of the properties in hdbtable definition

Currently the table creation is possible when the properties in the hdbtable definition have a particular order defined in the Antlr grammar file. It is supposed to be possible to create table no matter the properties order.

Fixed with


Master not working with sources

With the latest master, I'm unable to use sources:
sources:
    - name: bibo
      tables:
        - name: orders

Gives the following error:
root@f425d97e576a:/dbtlake# dbt docs generate
Running with dbt=0.17.0-rc2
* Deprecation Warning: dbt v0.17.0 introduces a new config format for the
dbt_project.yml file. Support for the existing version 1 format will be removed
in a future release of dbt. The following packages are currently configured with
config version 1:
 - dbtlake

For upgrading instructions, consult the documentation:
  https://docs.getdbt.com/docs/guides/migration-guide/upgrading-to-0-17-0
Found 8 models, 0 tests, 0 snapshots, 0 analyses, 151 macros, 1 operation, 0 seed files, 10 sources

08:53:54 | Concurrency: 8 threads (target='dev')
08:53:54 |
Encountered an error:
Runtime Error
  Runtime Error in model src_logistical_configuration_data (models/staging/bibo/src_logistical_configuration_data.sql)
    Error while parsing relation logistical_configuration_data_incremental_raw:
        identifier: orders
        schema: bibo
        database: fokko
    On Spark, database should not be set. Use the schema config to set a custom schema/database for this relation.

I have to dive into this, but just want to let you all know.

Thanks for this find @Fokko. This is definitely an unintended consequence of the work we did in #83, and we'll need to fix it before releasing 0.17.0.


Allow using custom choice button container

Is your feature request related to a problem? Please describe.
Currently (v1.2.5), choice buttons are arranged in a vertical layout. This is a good default choice, as it will usually allow for more choices to fit on the screen at once, but there might be scenarios (especially for simple "yes/no"-style choices) where it would be desirable to use a horizontal layout instead.
Describe the solution you'd like
Allow the user to specify custom containers for choice buttons, similar to how they can currently supply custom choice buttons (#247).
Describe alternatives you've considered
A simpler interface could instead ask whether the layout be horizontal or vertical, as these are likely the most common options people would use. The UI could then update based on the selection (e.g. 'vertical separation' would become 'horizontal separation' if the user switches to a horizontal layout). This approach has the benefit of being simpler to use at the cost of less flexibility.
Additional context
I discovered Dialogic recently and so far it's quite amazing. It's taken me very little time to replicate my existing dialogue system that I wrote from scratch, and the Dialogic-based solution is generally much more flexible and powerful. However, in my game, my simple yes/no choices are displayed horizontally, and so far I have been unable to figure out whether this is possible in Dialogic (my conclusion so far is that it is not).
Here's an example of a popular game (Hollow Knight) that uses horizontal choice buttons in its dialogue system:

I will see if I can implement more customization to the options since it seems like a highly requested feature. Thanks for the detailed issue 🙌🏻

Made a commit: https://github.com/coppolaemilio/dialogic/commit/6d365abb7ed4827f4a279cc6b25da9ce2ff16e69
If you get the latest version from main you should be able to select the orientation ( vertical or horizontal).
Let me know if that works! More settings will be added later 😅

The choice buttons don't seem to be visible on the current project I was using to test this out (at commit 6d365abb7ed4827f4a279cc6b25da9ce2ff16e69), though they are still functional (i.e. I can use the arrow keys to select choices and it behaves accordingly; I just can't see the choice buttons themselves).
However I was able to see that it's now possible to use horizontal choice button layouts on a completely fresh project at that same commit, so I guess something went wrong when my original test project updated to the new version of dialogic. I'll continue investigating that.
Thanks for adding this functionality! Looking forward to the additional settings.

The problems I ran into above are a good example of why it might be desirable from the user's viewpoint to be able to set custom choice button containers; they could set the padding, alignment, position on screen (e.g. center-top instead of center) themselves.
Depending on what additional settings you plan to add, this may not end up being strictly necessary in a lot of cases, but just thought I'd point it out.

Pushed another fix to the element not being centered after resizing the window. So they should remain centered as I change the resolution. Let me know if it works on your end!
I believe that after adding some more positioning options for the buttons we won't need to add anything else.
You can always clone the Dialog.tscn and modify the type of container for the options, but it is my goal that this won't be necessary.

Happy to report that the horizontal option now correctly aligns my custom choice buttons centered horizontally, though interestingly enough the vertical option behaves differently now (the buttons are the width of the screen now instead the fixed width I had them at before; this happens even if I tick 'fixed button size' in the Choice Buttons section of the theme editor).

@fmenozzi I added more options (anchor and offset) and I can't really reproduce the fixed button size bug. I'm going to close it for now, but feel free to open again if needed 👍🏻

Thanks a lot! The new options are a welcome addition, and I think the current HEAD doesn't have that fixed button size issue anymore.


Change "pre" to "partner"

Would be simpler to communicate.

Having second thoughts on this. Releases Ag3.1-Ag3.5 are currently in a pre-release state, primarily because they are incomplete (no CNV or haplotype data yet). Maybe "pre" is fine.


fix: ginko versions in e2e tests

Type of change:

[ ] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches
[ ] Documentation
[ ] Refactor
[ ] Chore
[x] CI/CD or Tests

What this PR does / why we need it:
This is solving issue with hardcoded version of Ginkgo module. There is strict dependency between tests in go using ginkgo package and local Ginkgo binary used for those tests. Currently after each update in dependencies CI start failing with log:
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.12.0
  Mismatched package versions found:
    2.12.1 used by e2e

  Ginkgo will continue to attempt to run but you may see errors (including flag
  parsing errors) and should either update your go.mod or your version of the
  Ginkgo CLI to match.

  To install the matching version of the CLI run
    go install github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file.  Alternatively you can use
    go run github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file to invoke the matching version of the
  Ginkgo CLI.

  If you are attempting to test multiple packages that each have a different
  version of the Ginkgo library with a single Ginkgo CLI that is currently
  unsupported.

This PR should fetch a correct version from e2e tests go.mod file and then install it in correct version.
Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

It should be working correctly (locally tested and it is ok), but we will see when workflows will run what are results

Codecov Report

Merging #1983 (6619c62) into master (bca0d1d) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 6619c62 differs from pull request most recent head d19d016. Consider uploading reports for the commit d19d016 to get more accurate results

@@           Coverage Diff           @@
##           master    #1983   +/-   ##
=======================================
  Coverage   36.87%   36.87%
=======================================
  Files          93       93
  Lines        7851     7851
=======================================
  Hits         2895     2895
  Misses       4568     4568
  Partials      388      388

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add sarif file existence to outputs

closes: #85

ref: https://github.com/RamanaReddy0M/workflow-test/actions/runs/9892374605/job/27324884390


[FEATURE] Git\Mercurial Branch Creation

We are working according to gitflow methology, and therefore we must create a new branch for each release.
I suggest to implement the following mechanism:
Adding two new parameters:

"branch" - a flag that tells if a branch should be created (similar to "tag" or "commit"). This flag will require the presence of the commit flag.
"branch_name" - a string parameter that describes the desired name of the branch (similar to "tag_name").

I think many users will benefit from this feature. As a side note, I have not problem implementing it :)

Sorry, this is outside of the scope of this project.
Bumpversion aims to bump versions, not to become a second gitflow implementation.


Cleanups

Minor cleanup to the crates.

Fixes: https://github.com/rust-vmm/vhost-device/issues/227


Build out examples with working colab notebooks

Would be nice to mirror the TF2 doc style of colab notebooks being first-class tutorials.
I think it's also a good idea to require colab notebooks for new contributions in order to showcase their benefits and best practices. Certainly won't be possible/necessary for everything.

Closing this as we'll create specific example requests in the coming days.


Add getMonoid for Ord

Following https://github.com/gcanti/fp-ts/pull/1046, I think it would be semantically consistent to add a Monoid<Ord> instance, with empty returning an Ord instance which always considers compared elements equal (Js now guarantees to not to change order of elements in such a case - "no sorting applied" - sorting in js is now guaranteed to be stable). Besides consistency with sortBy implementation which can now take empty array of ords as input (and then performs "no sorting at all" - data remains untouched) it honestly... makes sortBy unnecessary (because we can now always build a specific Ord first, using fold), which leaves us with nice, terse and consistent interface for sorting, made of one function only - sort itself.

Thanks for this PR @vicrac

Js now guarantees to not to change order of elements in such a case - "no sorting applied" - sorting in js is now guaranteed to be stable

Actually it doesn't matter, fromCompare(() => 0) is the monoidal unit whether sorting is stable or not


WIP Configurable memoize / variadic dependencies / pass props to selector

Work in progress experiments to address issues #7 , #20 , #27.

Updated API section of README


Error unknown shorthand flag: 'q' in -q when running ./vendor/bin/sail

Sail Version: 1.14.6
Laravel Version: 9.1.8
PHP Version: 8.2.0-dev
OS: macOS 10.13.6

Description:
When I run ./vendor/bin/sail up, error messesage displays
unknown shorthand flag: 'q' in -q
Command "compose up" not available in current context (default)

Steps To Reproduce:
Type following commands as instruction in terminal
$ curl -s "https://laravel.build/example-app" | bash
$ cd example-app
$ ./vendor/bin/sail up

When I run
./vendor/bin/sail --no-cache

It shows error
Command "compose ps" not available in current context (default)
unknown flag: --no-cache

It's sail build --no-cache.

$ ./vendor/bin/sail build --no-cache

Error:
Command "compose ps" not available in current context (default)
unknown flag: --no-cache

Does it relate to version of  Docker? My  Docker  version is <IP_ADDRESS>, running  on  MacOSX  10.13.6

Are you sure that's your docker version? Mine is 20.10.12

Here is mine
Docker Engine version: 19.03.13
Compose version: 1.27.4
Docker Desktop for Mac version: <IP_ADDRESS>

Seems you're on an older version. Try upgrading please.

Thanks. I will buy new Mac.


Implement default return

Closes https://github.com/liquid-rust/flux/issues/110

sweet!

I took the liberty of merging as I just hit something that would benefit from this! Thanks and apologies!

but that's the best part. It's like unwrapping someone else's present


Add C FFI bindings to Rust port

As noted in #22, this allows trivial usage from any language supporting a C FFI.

Perfect! Even better with the readme addition. Will merge this then you can add the new version to the crates.io package.
As a sidenote, if you'd be willing to add my github to the crate as well, then I can update it in tandem with any future changes to the repo side.
In any case, thanks again!

As a sidenote, if you'd be willing to add my github to the crate as well, then I can update it in tandem with any future changes to the repo side.

Absolutely, I've sent you an invite on crates.io!


Install python3 modules in docker

Hello, guys
I followed the instructions and used c-kernel with docker.  But I'd like to use numpy & matplotlib in kernel python3. How could I install these modules in docker ?

Your question is related to docker expertise, not this library.  You'll have to install them from the shell of your docker container.


Get Sprint Goals via Wiql

Is there a way to get Sprint Goals via Wiql?

You are right. I dropped the Goals approach entirely and added a custom field to a work item instead.

suggest closing this item


How to reproduce fine tuning EN-RO with mbart?

❓ Questions and Help
I followed the fine-tuning example described in here: https://github.com/pytorch/fairseq/blob/master/examples/mbart/README.md
However I didn't manage to reproduce the results described in the paper for EN-RO translation.
How to reproduce fine tuning with mbart?

Can you clarify where did you get the data and how did you preprocess it for training in more detail? Did you use anything else for preparaing data than:

https://github.com/pytorch/fairseq/blob/master/examples/mbart/README.md#bpe-data-1
https://github.com/pytorch/fairseq/blob/master/examples/mbart/README.md#preprocess-data

What setup did you use for training? Did you use 256 Nvidia V100 GPUs (32GB)? How would it be possible to reproduce this with 8 Nvidia V100 GPUs (16GB)? How would the learning rate and batch size need to be changed?

Code
Code from here: https://github.com/pytorch/fairseq/blob/master/examples/mbart/README.md
Modified training script only with these changes:
--memory-efficient-fp16
--max-sentences 8
--required-batch-size-multiple 8
What have you tried?
Trained with described setup and got BLEU of 2.3 only.
What's your environment?

fairseq Version (master - from commit 57526c63433c0b1c997fc91c0881867532567266):
PyTorch Version (1.4.0)
OS (Ubuntu 18.04):
How you installed fairseq (pip install --editable ., https://github.com/pytorch/fairseq/commit/57526c63433c0b1c997fc91c0881867532567266):
Python version: 3.6.6
CUDA/cuDNN version: 10.0/7
GPU models and configuration: aws 8xV100

CC @ngoyal2707

You should find #1758 useful (it’d be nice if they updated the documentation here).

Thanks @mjpost
I found that issue really useful and that's how I validated the fine-tuned model.
However the question remains, how to reproduce fine-tuning results for en-ro translation? (Meaning training the base model (mbart.CC25) on en-ro data)

cc @ngoyal2707, could you please synthesize the discussion in #1758 and update the README?


Dispatch: Add E-Mail placeholders to frontend

Add placeholders for craftsman & their issue statistics to personalize E-Mail.
Similar to #365, but the placeholders are defined by the user.

Historically has not worked well from a usability perspective