[Dubbo-Nacos-NamingService] fix dubbo create nacos multiple identical NamingService

What is the purpose of the change
fix dubbo create nacos multiple identical NamingService
more detail: in issue #6988
https://github.com/apache/dubbo/issues/6988
Brief changelog

change NacosRegistryFactory createRegistryCacheKey method
remove the timestamp from url as registry cache key

Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #6989 (a905e0e) into master (3fc2d10) will decrease coverage by 0.63%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...a905e0e. Read the comment docs.


Sortable items jump in flexbox container

https://www.loom.com/share/371fae83e98046ed98d4fffe277d27a2
From what I can tell, any items that should change "columns" during drag have a correct y position, but keep their old x position until the drag ends.
Parent div styles:
  display: flex;
  flex-wrap: wrap;
  flex-direction: column;
  align-content: flex-start;
  background: #eee;
  padding: .5rem;
  height: 100%;
  max-height: 30rem;

I would be using grid layout, but it doesn't seem to support this layout.
(FWIW I got here via this issue from another lib).
Not sure if this is supported by dnd-kit, but I'd love it if it was. I'm happy to make a code sandbox if that would be helpful!

What sorting strategy are you using? Do share a codesandbox if you can.

@clauderic was just about to comment--I worked on a sandbox but was unable to reproduce
https://codesandbox.io/s/dndkit-sortable-image-grid-forked-yt4rv
Sorry for the bother--will circle back if I find something later

Ok, looks like it happens with verticalListSortingStrategy but not rectSortingStrategy. Thanks for the tip, I've got at least a temporary fix :)

That's an intentional limitation, as its name implies, verticalListSortingStrategy is optimized to only support single column vertical lists.
Your layout is a grid so you indeed need to use rectSortingStrategy.

Fair enough, thanks @clauderic


Importing changes "Journal" to "The Journal"

I'm using Zotero 5.0.89 and Better BibTeX 5.2.47.
Report ID: REJZ4MUU-euc
Full Bib(La)TeX item that I imported:
This is the bib file (to be unzipped first): articles.bib.zip
These are its contents:
@Article{id1,
  author  = {Family Name, First Name},
  title   = {Title},
  journal = {Journal},
  year    = {2020},
  volume  = {1},
  number  = {2},
  pages   = {3},
}

@Article{id2,
  author  = {Family Name, First Name},
  title   = {Title},
  journal = {Journal of Abcde Research},
  year    = {2020},
  volume  = {1},
  number  = {2},
  pages   = {3},
}

@Article{id3,
  author  = {Family Name, First Name},
  title   = {Title},
  journal = {Abcde},
  year    = {2020},
  volume  = {1},
  number  = {2},
  pages   = {3},
}

Expected behavior:
All of the above journal names should be imported as-is.
Actual behavior:
If the journal name is "Journal" (id1 above), it is converted in Zotero to "The Journal" (as can be seen from below screenshot). This is not the case in the two other examples.
Screenshot

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>15 ("update testcase for #1601")
Install in Zotero by downloading test build <IP_ADDRESS>15, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

6915 should fix it. I had an error (mapping "Journal" to "The Journal") in the unabbreviation lists I import from JabRef.

Thank you!! I confirm this is now fixed. :clap: :tada:

Thanks, a new release has been scheduled.


Add CacheMaintainer class to perform pending cache maintenance every minute

Description
Adds a CacheMaintainer class that takes in a generic Guava cache and calls cleanUp periodically (every minute). This will perform any pending maintenance (such as evicting expired entries) which was previously only performed when the cache was accessed. The maintenance thread is created whenever a NativeMemoryCache or QuantizationStateCache is instantiated or rebuilt and can be shut down with either class's close method. Relevant logic for cleanup was added to some testing base classes.
Related Issues
Resolves #2239
Check List

[X] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[X] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owenhalpert The changes look good in general. What I'd be interested in is testing under load for a resource constrained system - can you verify if this adds to the latency or impact the performance in any way?
We did implement a force evict before writes with #2015. Can you also enable this feature flag and run the above tests to ensure it behaves well?

@kotwanikunal I've completed the benchmarking on a single node cluster limited to 3GB of memory.
Before benchmarking my code, I validated the CacheMaintainer was actually running by inspecting the OpenSearch process status in the Docker container and found that after about a minute, the RssAnon value would decrease by about 0.5gb without any interference on my part, signaling the maintainer successfully cleaned up the expired entries. This is aligned with what I saw on the standard maintenance on the clean code (which I triggered manually by accessing the cache).
Results below:

Performance Summary for Resource-Constrained Testing (3GB Memory Limit)
Run 1: Clean 2.18 code

Indexing:

p50 latency: 16.96 ms
p90 latency: 32.47 ms

Search:

p50 latency: 330.48 ms
p90 latency: 437.78 ms

Run 2: Clean 2.18 code, Force evict ON

Indexing:

p50 latency: 17.27 ms
p90 latency 33.82 ms

Search:

p50 latency 337.43 ms
p90 latency 428.70 ms

Run 3: PR changes added, Force evict ON:

Indexing:

p50 latency: 16.89 ms
p90 latency: 32.24 ms

Search:

p50 latency: 341.38 ms
p90 latency: 414.06 ms

Run 4: PR changes added, Force evict OFF:

Indexing:

p50 latency: 17.43 ms
p90 latency: 34.63 ms

Search:

p50 latency: 346.83 ms
p90 latency: 430.04 ms

This suggests there is no significant impact on latency with my code changes. I've included the full results of these test runs here:
https://gist.github.com/owenhalpert/05ad4f5ae9577f717f2c59f2039d52e4


Platform: add RichEdit to modulemap

Add RichEdit to the module map file for WinSDK.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test


The import package sort adjustment in the go file.

…pkg/yurthub-first

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement
What this PR does / why we need it:
The order of the go file import package is not standardized.
Which issue(s) this PR fixes:

Fixes #587
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm
/approve


save mesh covered by texture as png file

hello
I tend to save my mesh, that covered by texture, as a png file.
here is my code to load texture on obj file:
from vedo import *

mesh = Mesh("data/10055_Gray_Wolf_v1_L3.obj",)

mesh.texture("data/10055_Gray_Wolf_Diffuse_v1.jpg", scale=0.1)

mesh.show()

Any help, Please.
I prefer to save png without background.

Just add
settings.screenshotTransparentBackground = True
# ...
mesh.show().screenshot('mypicture.png')

That's very nice.
but I currently work with servers, and I cannot run show mesh and screenshot. (just accessing with ssh)
is there any other solution?

Try offscreen mode, eg:
import vedo
mesh = vedo.Sphere()
plt = vedo.Plotter(offscreen=True, bg='lightblue', bg2='blue3')
plt += mesh
plt.show().screenshot()

Many thanks, but I cannot show anything on the server as I told you before.
Is there any way?

this will not show anything just dump a file named screenshot.png.

Thank again.
it works on my local system but on the server; I got Aborted (core dumped).
anyway, I will find the solution.

@ganjbakhshali  "it works on my local system but on the server; I got Aborted (core dumped)."

I just leave this library and work with bpy lib

@ganjbakhshali "it works on my local system but on the server; I got Aborted (core dumped)." how do you solved?

I hope this will wok for you too:
https://github.com/marcomusy/vedo/discussions/621#discussioncomment-2481423

@ganjbakhshali "it works on my local system but on the server; I got Aborted (core dumped)." how do you solved?

I hope this will wok for you too: #621 (comment)

@marcomusy  thank you  for ur reply
Could you show it in detail?

Please try:

install libgl1-mesa and xvfb:

 sudo apt-get install libgl1-mesa-dev libgl1-mesa-glx  xvfb

execute on startup:

#!/bin/bash
#
set -x
export DISPLAY=:99.0
Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
sleep 3
set +x
exec "$@"

save the bash script above as  /etc/rc.local (or any other file to be called) and use chmod +x to make it executable.

plt = vedo.Plotter(offscreen=True)
plt += vedo.Cube()
plt.show()
plt.screenshot(filename)

I will test it and let you know about the result.
Thanks again.


Invoke-RestMethod doesn't include automatic ContentType value when not using POST method

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
When using a POST, ContentType is automatically set to application/x-www-form-urlencoded
 invoke-restmethod https://webhook.site/6a5097af-3644-4462-9d92-d910088d2f4d -Method POST -Body @{ Test = "test" }

When using other methods, it is not. It is blank.
 invoke-restmethod https://webhook.site/6a5097af-3644-4462-9d92-d910088d2f4d -Method PUT -Body @{ Test = "test" }

Expected behavior
I would expect that the content type would default to form encoded for all request methods (or at least for PUT).

Actual behavior
It is only set to form encoded for POST.

Error details
No errors.

Environment data
Name                           Value
----                           -----
PSVersion                      7.2.0-rc.1
PSEdition                      Core
GitCommitId                    7.2.0-rc.1
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

### Visuals

_No response_

@CarloToso I think yes but first we should look that is difference POST and PUT (maybe an RFC block this?) and what is behavior other utilities.

Curl doesn't add any Content-Type for POST and PUT

Search returns follow description:

The difference between POST and PUT is that PUT requests are idempotent. That is, calling the same PUT request multiple times will always produce the same result. In contrast, calling a POST request repeatedly have side effects of creating the same resource multiple times.

Based on this, I think we should PUT must works as POST and we should add ContentType in PUT.
First, though, I would look at the implementation/workings of HttpClient and our web cmdlets to understand the source of the problem - either we add the ContentType ourselves or it's the HttpClientHandler that does it.

If -Headers and -ContentType are not set and  -Method is not POST or PUT --> No content type else "application/x-www-form-urlencoded"
Currently ContentType is set by:

FillRequestStream (from -Headers or -ContentType or "application/x-www-form-urlencoded")
GetMultipartStreamContent ("application/octet-stream")

ContentType has the precedence if both -Headers and -ContenType are present.
HttpClient gets the content type from the request.Content that often is ByteArrayContent that has no content type.


Multiple instances

Hi guys
I'm trying to create multiple instances to upload multiple files, but on different inputs, all with allowMultiple: false
They will all be directed to a single server, where I use the FilePond Server PHP
I'm using FilePond with jQuery.
I think I need to use a repeating structure, because there will be multiple inputs. I've already tried it this way:
//  $.fn.filepond.registerPlugin() ..... ;

$('.filepond').each(function(index, element) {
    $(this).filepond({
        server: {
            url: "my_base....",
            method: 'POST',
            process: './',
            revert: './',
            onerror: (response) => response.data,
            onload: function(response) {
                return JSON.parse(response).id // added
            },
        },
    });
});

They are instantiated but files are not received on the server. On the server side, I imagine it's all right because I've already done it in another way where I instantiated in a singular way, the files were received but when I upload more than one file and submit to the server, only one of them goes to /uploads, the rest remains in /temp, when I do it this way:
//  $.fn.filepond.registerPlugin() ..... ;

$.fn.filepond.setDefaults({
    server: {
        url: "my_base....",
        method: 'POST',
        process: './',
        revert: './',
    },
});

$('.filepond').filepond();

How can I get all these files on the server at once with different inputs?

If you use the first method, do you see the files in your browser developer tools network tab?

Yes, by placing the FilePond:addfile method to listen for the event, it indicates that it received both files. But it doesn't move the files to the /temp folder as it should, unlike the second method I exemplified does [however, it only transfers one file to the /upload folder when submitted, and the other remains in /temp].

Parte dos meus inputs que são gerados:

Please check the network tab → select the POST request → scroll down and you should be able to see the post contents

Uma das requisições de arquivo enviadas ao servidor:

Header:

O servidor me retorna uma página vazia.

You can clearly see the data being sent to the server.
Your server gets the file under field name 1_img_71 so that field name should be configured on your server as well

Okay, but before using that name on my server, wouldn't FilePond need to save the files in /temp [before form submission] and move to /upload [after form submission]?
This is part of the content uploaded to the server after submission [when uploaded to / submitted.php].
It seems to be incomplete, without the file data:

As you've set the server property it will indeed upload to temp folder, and then server should return unique id for file, and on submit the unique id's will be posted.

I found the error. I wasn't using name="filepond[]" in the inputs. I haven't implemented this before because I didn't think it was necessary as I used allowMultiple: false and also only wanted one file for each input.
The input looked like this:
 <input type="file" class="filepond" name="filepond[]">

While I was analyzing my problem, I found an unhandled object in submit.php that does not generate errors but returns an alert in PHP. Soon I will do a PR explaining better.
Thank you for your attention and for the excellent project! Hug


Cannot import yt_dlp from python scripts

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2023.01.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
yt_dlp fails to import from python scripts as of latest update, but not from python shell.  Manjaro, installed globally via pip.
$ python
Python 3.10.9 (main, Dec 19 2022, 17:35:49) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import yt_dlp as yt
>>> yt
<module 'yt_dlp' from '/usr/lib/python3.10/site-packages/yt_dlp/__init__.py'>
>>>
$ python3 what.py
Traceback (most recent call last):
  File "<script directory>/what.py", line 1, in <module>
    import yt_dlp as yt
  File "/usr/lib/python3.10/site-packages/yt_dlp/__init__.py", line 19, in <module>
    from .downloader.external import get_external_downloader
  File "/usr/lib/python3.10/site-packages/yt_dlp/downloader/__init__.py", line 26, in <module>
    from .external import FFmpegFD, get_external_downloader
  File "/usr/lib/python3.10/site-packages/yt_dlp/downloader/external.py", line 12, in <module>
    from ..postprocessor.ffmpeg import EXT_TO_OUT_FORMATS, FFmpegPostProcessor
  File "/usr/lib/python3.10/site-packages/yt_dlp/postprocessor/__init__.py", line 38, in <module>
    _PLUGIN_CLASSES = load_plugins('postprocessor', 'PP')
  File "/usr/lib/python3.10/site-packages/yt_dlp/plugins.py", line 135, in load_plugins
    for finder, module_name, _ in iter_modules(name):
  File "/usr/lib/python3.10/site-packages/yt_dlp/plugins.py", line 119, in iter_modules
    pkg = importlib.import_module(fullname)
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1002, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 945, in _find_spec
  File "/usr/lib/python3.10/site-packages/yt_dlp/plugins.py", line 96, in find_spec
    search_locations = self.search_locations(fullname)
  File "/usr/lib/python3.10/site-packages/yt_dlp/plugins.py", line 88, in search_locations
    if parts in dirs_in_zip(path):
  File "/usr/lib/python3.10/site-packages/yt_dlp/plugins.py", line 37, in dirs_in_zip
    with ZipFile(archive) as zip:
  File "/usr/lib/python3.10/zipfile.py", line 1249, in __init__
    self.fp = io.open(file, filemode)
IsADirectoryError: [Errno 21] Is a directory: '<script directory>'
$ cat what.py
import yt_dlp as yt

$

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU']
[debug] User config "<home>/.config/yt-dlp/config": ['--embed-thumbnail', '--add-metadata', '--all-subs', '--embed-subs', '-i']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.06 [6becd25] (pip)
[debug] Python 3.10.9 (CPython x86_64 64bit) - Linux-6.1.11-1-MANJARO-x86_64-with-glibc2.37 (OpenSSL 3.0.8 7 Feb 2023, glibc 2.37)
[debug] exe versions: ffmpeg 5.1.2 (setts), ffprobe 5.1.2, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.12.07, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Loaded 1760 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.06, Current version: 2023.01.06
yt-dlp is up to date (2023.01.06)

Dup of https://github.com/yt-dlp/yt-dlp/issues/6205


Security Considerations with External Messaging

I'd like us to consider the possible issues that could arise with supporting onMessageExternal. We currently do any sort of check on the port.sender property, meaning any other extension or website script could send messages straight to the background store.
What are the possible implications of this? Should we include something in the package to run validation on an external connection? Should we even support external messaging?
I feel like the support for external messaging was a bit premature, honestly (my bad). I feel like we could have solved #47 by simply suggesting listeners in the background page the push the messages to store.dispatch after the sender has been checked.
Maybe we can solve this by adding an option of senderIds which is an array of allowed external sender ids. We could also have an allowExternal boolean which sets up external listeners.

@vhmth @paulius005

Will look into this tonight - waiting for link expanding on GH to land in Loom first. :-)

@vhmth Oh please ignore everything I've ever tagged you in until that's done :P Thank you so much for adding that!

https://www.useloom.com/share/620cdc80f73b11e6bca7777543759035

@tshaddix I like the idea of allowExternal over using senderIds since those can be found fairly easily by just inspecting the code.
If support is continued for onMessageExternal, I would say a README mention of the externally_connectable manifest.json file option found here: https://developer.chrome.com/extensions/manifest/externally_connectable would be a good move to keep the possible security issues top of mind for people using react-chrome-redux.

@paulius005 fully agree that a note in the README about externally_connectable is a good move.

@vhmth @paulius005 Embedded Loom vids look soooooo slick.
Great call with externally_connectable! I was not aware of that property. That makes me feel a lot better.
I proposed senderIds as a way to explicitly declare where external connections can come from as it allows a dev to take confidence in how open their extension is. I'm not worried about the ids being available through inspection (extension/app ids are not secret anyways) as the security comes from checking the message sender property to make sure it is allowed.
This is actually how chome suggest doing it here:
// For simple requests:
chrome.runtime.onMessageExternal.addListener(
  function(request, sender, sendResponse) {
    if (sender.id == blacklistedExtension)
      return;  // don't allow this extension access
    else if (request.getTargetData)
      sendResponse({targetData: targetData});
    else if (request.activateLasers) {
      var success = activateLasers();
      sendResponse({activateLasers: success});
    }
  });
});

Your right, however, that this only solves extension/app connections. This doesn't help in the realm of website connections, however...
I think a simple security fix would be to move forward with @vhmth's suggestion of allowExternal and cross the bridge of explicit app/extension id declaration when we come to it.

I completely agree with doing the simple thing first and leveraging allowExternal for now as a step in the right direction. They're both things that should be leveraged by the user actually. :-) Good call.

Glad you like the Loom videos! :-)

@vhmth Love the loom videos :)
Cool, so I've re-labled this as an enhancement so we can make sure to put it on our roadmap of todos


Additional broken domains

Further to #97 there are additional broken TLDs:

[ ] .in
[ ] .info

Cc:  @talarini

For the record I ended up starting my fork in which I fixed all the Afilias based whois parsers (.ME, .ORG, .INFO, .PRO, .BZ, .GI, .LC, .MN, .SC, .VC, .AG, .IN, .AERO, .ASIA, .MOBI, .POST, .XXX) in e2b84e73f43ef692e834c2d151f5c7e50b384eae. So people who need this can use my fork:
gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser


net: tcp: Correctly handle overlapped TCP retransmits

Describe the bug
When a fast re-transmit overlaps with data that is already received, the stack does not accept the new incoming data to create one contiguous data stream and acknowledge out of order packets as well.
To reproduce the bug, take the updated test from:
https://github.com/zephyrproject-rtos/zephyr/pull/47115/commits/5885b790dc6f71b0bb89a15b0edf443607f786e9
Take the test example:
static struct out_of_order_check_struct out_of_order_check_list[] = {
{ 30, 10, 0, 0}, /* First packet will be out-of-order /
{ 20, 10, 0, 0},
{ 10, 10, 0, 0},
{ 0,  10, 40, 0}, / First sequence complete /
{ 60, 10, 40, 0},
{ 70, 10, 40, 0},
{ 40, 20, 80, 0}, / Some bigger data */
};
And replace the 20 in the last line to 25:
static struct out_of_order_check_struct out_of_order_check_list[] = {
{ 30, 10, 0, 0}, /* First packet will be out-of-order /
{ 20, 10, 0, 0},
{ 10, 10, 0, 0},
{ 0,  10, 40, 0}, / First sequence complete /
{ 60, 10, 40, 0},
{ 70, 10, 40, 0},
{ 40, 25, 80, 0}, / Some bigger data */
};
Next run the test using ./scripts/twister -T tests/net/tcp -p qemu_x86
With in that situation, the last 15 bytes are not acknowledged although they are properly received.
Expected behavior
The duplicate data should simply discard and constructed into a contiguous stream.
Impact
Although PR https://github.com/zephyrproject-rtos/zephyr/pull/47115 implement fast re-transmit and reception for out of order reception to work, in practice it's benefit might be limited.
Environment (please complete the following information):

OS: Linux

@jukkar: FYI

Should be fixed by https://github.com/zephyrproject-rtos/zephyr/pull/47115


Multiple signature at the end of the file after calling buffer_hunk_stage many times.

Description
As title.

nvim --version output:NVIM v0.8.0-dev+112-g13520aae1
Build type: Release
LuaJIT 2.1.0-beta3

Operating system: macOS 12.3.1

The Authorship Code Lens feature needs a bit more love from my end, I had previously turned this feature off by default, for a temporary fix please turn it off for the time being, I should get to it soon!
   authorship_code_lens = {
      enabled = false,
    },

Thanks!


Channelencypt

Please help to review the updates to add generation of Media Stream Encryption Secret and Seed.

Closing this old PR


.Net core hosting sample on Centos 7

Hi,
I am trying a sample for .NET core 2.2 hosting based on the samples provided for CoreClrHost. The sample program provided by MS works on my setup.
However, when I build my own, I am running into some issues and getting core dump. I can't figure out what mistake I am doing.
I have a small repro sample. How can I share it on this forum?
Thanks,

Attaching a small repro sample
Bootstrap.zip

I have resolved the issue, which was due to an uninitialized variable. My bad, apologies to anyone who started looking into this.


Do control-controls support "Consolidated control findings"?

Thanks for this useful software.
Do control-controls support "Consolidated control findings"?
ref. Impact of consolidation on ASFF fields and values - AWS Security Hub
In an environment where Consolidated control findings are "On",
ProductFields.StandardsArn is removed and replaced with Compliance.AssociatedStandards.
This is probably why standards.<standard>.findings.<control_id>.<target_arn>.status and note doesn't work.
e.g. https://github.com/pepabo/control-controls/blob/main/sechub/plan.go#L168

@htnosm Thank you for your contribution!
control-controls does not support Consolidated control findings. Also, I do not have any knowledge about it.
Sorry, please wait for a while.


Gradio does not work, stuck on uploading forever.

I installed Video-LLaMA on two machines, one on Google Cloud with 4 A100s and one on my person Ubuntu PC with a 4090.
I downloaded:
git clone https://huggingface.co/DAMO-NLP-SG/Video-LLaMA-2-7B-Finetuned
My config file looks as follows:
  llama_model: "Video-LLaMA-2-7B-Finetuned/llama-2-7b-chat-hf"
  imagebind_ckpt_path: "Video-LLaMA-2-7B-Finetuned/"
  ckpt: 'Video-LLaMA-2-7B-Finetuned/VL_LLaMA_2_7B_Finetuned.pth'   # you can use our pretrained ckpt from https://huggingface.co/DAMO-NLP-SG/Video-LLaMA-2-13B-Pretrained/
  ckpt_2:  'Video-LLaMA-2-7B-Finetuned/AL_LLaMA_2_7B_Finetuned.pth'

On both computers, it doesn't work. There's no logs when I'm uploading the file as well.
I tried multiple different jpeg, png, and mp4 files as well.

Solved with
pip install gradio==3.37.0


Problems Rendering HeroCards after issue #4249

Ever since receiving the error described in issue #4249, tables that were rendering fine and continue to render fine on the web based client are seeing the first column become squished.
Good:

Bad:

Code:
`            var rcard = new HeroCard();
            rcard.Title = $"Welcome {turnContext.Activity.From.Name}";
            rcard.Text = $"
" +
                $"
" +
                $"Command	" +
                $"Function	" +
                $"
" +
                $"
!r	Make a new lab request
" +
                $"

" +
                $"
!	List of previous requests
" +
                $"

" +
                $"
| Text |	If you are not in conversation, type your question and it will be logged in as a free form request and answered on a first come first served basis.
" +
                $"

" +
                $"

" +
                $"
" +
                $"Command	" +
                $"Function	" +
                $"
" +
                $"
!who	List of current conversations and the person with whom you are conversing. Allows user to select another conversation. (Used by Techs)
" +
                $"

" +
                $"
!punt	Return an accepted job to the queue, preferably to @mention another tech to continue request. (Used by Techs)
" +
                $"

" +
                $"
!group	Move this request to the web based group queue.  This effectively closes the job within this tool but transfers all information to group tool.(Used by Techs)
" +
                $"

" +
                $"
!greet:	Everything following the colon (:) will become your new greeting when you accept a job. (Used by Techs)
" +
                $"

" +
                $"
!exit	Exit the current conversation.  If you have other conversations open, the next will be made active. (Used by Techs)

";
            rcard.Buttons = new List<CardAction>() { };

            rcard.Buttons.Add(new CardAction
            {
                Type = ActionTypes.OpenUrl,
                Title = "Watch Video",
                Value = "https://bobscupofsoup.com/Help.mp4?csf=1&web=1&e=U3dbqf"
            });`

Workaround found:
rcard.Text = $"
" +                 $" <colgroup>" +                 $"<col span = \"1\" style = \"width: 22%;\">" +                 $"<col span = \"1\" style = \"width: 78%;\">" +                 $"</colgroup>" +                 $"
" +                 $"
" +                 $"Command	" +                 $"Function	" +                 $"
" +                 $"
!r	Make a new lab request
" +                 $"

" +                 $"
!	List of previous requests
" +                 $"

" +                 $"
| Text |	If you are not in conversation, type your question and it will be logged in as a free form request and answered on a first come first served basis.
" +                 $"

" +                 $"
!cancel	Cancel current request.
" +                 $"

" +                 $"

" +                 $"<colgroup>" +                 $"<col span = \"1\" style = \"width: 22%;\">" +                 $"<col span = \"1\" style = \"width: 78%;\">" +                 $"</colgroup>" +                 $"
" +                 $"
" +                 $"Command	" +                 $"Function	" +                 $"
" +                 $"
!who	List of current conversations and the person with whom you are conversing. Allows user to select another conversation. (Used by Techs)
" +                 $"

" +                 $"
!punt	Return an accepted job to the queue, preferably to @mention another tech to continue request. (Used by Techs)
" +                 $"

" +                 $"
!group	Move this request to the web based group queue.  This effectively closes the job within this tool but transfers all information to group tool.(Used by Techs)
" +                 $"

" +                 $"
!greet:	Everything following the colon (:) will become your new greeting when you accept a job. (Used by Techs)
" +                 $"

" +                 $"
!exit	Exit the current conversation.  If you have other conversations open, the next will be made active. (Used by Techs)

";

@rchardin - Looks like your issue has resolved, shall we close the bug?


mssql_schema_permission bug

When mssql_schema_permission depends on the user (which should be created before), I get an error that schema and database must belong to the same database.
If I create a plan with mssql_sql_user only, apply it, and then create the next one (which wants to create mssql_sql_user only), there is no error.
Configuration:
data "mssql_schema" "schema" {
  name        = "schDataLake"
  database_id = data.mssql_database.database.id

  lifecycle {
    postcondition {
      condition     = self.id != null
      error_message = "Schema must exist"
    }
  }
}

resource "mssql_sql_user" "user" {
  name        = local.dl_user
  database_id = data.mssql_database.database.id
  login_id    = data.mssql_sql_login.login.id
}

resource "mssql_schema_permission" "schema_permission" {
  schema_id    = data.mssql_schema.schema.id
  principal_id = mssql_sql_user.user.id
  permission   = "SELECT"

  depends_on = [
    mssql_sql_user.user
   ]
}

Output:
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform planned the following actions, but then encountered a problem:

  # mssql_sql_user.user will be created
  + resource "mssql_sql_user" "user" {
      + database_id = "56"
      + id          = (known after apply)
      + login_id    = "0x010600000000006400000000000000008875E4B7A6B3064D8F72C34AC9869B0A"
      + name        = "bg_test"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
╷
│ Error: Schema and Principal must belong to the same DB
│
│   with mssql_schema_permission.schema_permission,
│   on main.tf line 75, in resource "mssql_schema_permission" "schema_permission":
│   75: resource "mssql_schema_permission" "schema_permission" {
│
│ schema_id points to DB with ID 56 while principal_id points to DB with ID 0
╵

Also hitting his issue at the moment. Would you have time to look at this @tkielar-pgs? Since this really breaks our entire flow.

Any update on this? Hit the same....


Update test workflow

Description
Update test workflow to use  pinned version of OSD 2.5.0
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.5@68bfa49). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@          Coverage Diff           @@
##             2.5     #475   +/-   ##
======================================
  Coverage       ?   15.53%
======================================
  Files          ?      111
  Lines          ?     2962
  Branches       ?      458
======================================
  Hits           ?      460
  Misses         ?     2463
  Partials       ?       39

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix incomplete dates when STRICT_PARSING is True

Add check to only try to parse complete dates if the date string has at least 6 digits.
Fix cases when it's impossible to guess the date
Ex:
Date: 11117
Possible dates: 11/01/17 or 01/11/17 or 11/11/07
So I suggest a minimum length of 6 to parse complete dates.
Closes #356

Looking at the removed tests, I think we would be removing support for some valid use cases.
I wonder if, with a more convoluted solution, we could drop support for unclear scenarios while maintaining support for other cases where less than 6 digits are used but there is only 1 possible date or 1 of the possible dates is the obvious choice.

Hi @Gallaecio , I investigated a bit more to find an alternative approach and I have a suggestion.
The thing is that _no_spaces_parser class tries so many date formats that it almost always get an complete date, even if it doesnt look like correct.
My best guess would be limit no_spaces to parse only the given DATE_ORDER, currently it priorizes the order given but it tries all other combinations. For example:

dp.parse('2011', settings={'STRICT_PARSING': True, 'DATE_ORDER': 'DMY'})
values tried = ['%d%m%Y', '%d%m%y', '%d%m%Y%H%M%S.%f', '%d%m%Y%H%M%S', '%d%m%Y%H%M', '%d%m%Y%H', '%d%m%y%H%M%S.%f', '%d%m%y%H%M%S', '%d%m%y%H%M', '%d%m%y%H', '%Y%m%d', '%Y%d%m', '%m%Y%d', '%m%d%Y', '%d%Y%m', '%y%m%d', '%y%d%m', '%m%y%d', '%m%d%y', '%d%y%m', '%Y%m%d%H%M%S.%f', '%Y%m%d%H%M%S', '%Y%m%d%H%M', '%Y%m%d%H', '%Y%d%m%H%M%S.%f', '%Y%d%m%H%M%S', '%Y%d%m%H%M', '%Y%d%m%H', '%m%Y%d%H%M%S.%f', '%m%Y%d%H%M%S', '%m%Y%d%H%M', '%m%Y%d%H', '%m%d%Y%H%M%S.%f', '%m%d%Y%H%M%S', '%m%d%Y%H%M', '%m%d%Y%H', '%d%Y%m%H%M%S.%f', '%d%Y%m%H%M%S', '%d%Y%m%H%M', '%d%Y%m%H', '%y%m%d%H%M%S.%f', '%y%m%d%H%M%S', '%y%m%d%H%M', '%y%m%d%H', '%y%d%m%H%M%S.%f', '%y%d%m%H%M%S', '%y%d%m%H%M', '%y%d%m%H', '%m%y%d%H%M%S.%f', '%m%y%d%H%M%S', '%m%y%d%H%M', '%m%y%d%H', '%m%d%y%H%M%S.%f', '%m%d%y%H%M%S', '%m%d%y%H%M', '%m%d%y%H', '%d%y%m%H%M%S.%f', '%d%y%m%H%M%S', '%d%y%m%H%M', '%d%y%m%H', '%H%M%S.%f', '%H%M%S', '%H%M', '%H']

result = datetime.datetime(2020, 1, 1, 0, 0)
IMHO, if DATE_ORDER is specified, it should only try with the given order. For example, the command above would try:

dp.parse('2011', settings={'STRICT_PARSING': True, 'DATE_ORDER': 'DMY'})
values tried: ['%d%m%Y', '%d%m%y', '%d%m%Y%H%M%S.%f', '%d%m%Y%H%M%S', '%d%m%Y%H%M', '%d%m%Y%H', '%d%m%y%H%M%S.%f', '%d%m%y%H%M%S', '%d%m%y%H%M', '%d%m%y%H']

result = None
This would fix STRICT_PARSING bug if DATE_ORDER is specified, and I'd go for using the default order if STRICT_PARSING = True and no order is specified.

Sounds good to me.

Codecov Report

Merging #515 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
- Coverage   95.01%   94.94%   -0.08%
==========================================
  Files         302      302
  Lines        2466     2471       +5
==========================================
+ Hits         2343     2346       +3
- Misses        123      125       +2

Impacted Files
Coverage Δ

dateparser/parser.py
97.51% <100%> (-0.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6322545...e0215f5. Read the comment docs.

Codecov Report

Merging #515 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
- Coverage   95.01%   94.94%   -0.08%
==========================================
  Files         302      302
  Lines        2466     2471       +5
==========================================
+ Hits         2343     2346       +3
- Misses        123      125       +2

Impacted Files
Coverage Δ

dateparser/parser.py
97.51% <100%> (-0.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6322545...e0215f5. Read the comment docs.

I was about to merge this, but after merging master it stops working... Could you check it?

I was about to merge this, but after merging master it stops working... Could you check it?
I think that what is happening is that when trying with other locales that have another default order (i.e.: "zh" that has "YMD") it's parsed badly again:
>>> dateparser.parse('2017', settings={'STRICT_PARSING': True})
2020-01-07 00:00:00

>>> dateparser.parse('2017', settings={'STRICT_PARSING': True}, locales=['en'])
None

>>> dateparser.parse('2017', settings={'STRICT_PARSING': True}, locales=['zh'])
2020-01-07 00:00:00

Yes, sure I'll check it

It seems that DATE_ORDER was fixed on master and now it updates according to the locates parameter.
For example, the result with ribeiro-fix-complete-dates branch:
>>> dateparser.parse('2017', settings={'STRICT_PARSING': True}, locales=['en'])
--> DATE_ORDER = %m%d%y
>>>
>>> dateparser.parse('2017', settings={'STRICT_PARSING': True}, locales=['zh'])
--> DATE_ORDER = %y%m%d
datetime.datetime(2020, 1, 7, 0, 0)

The strptime method allows months and days with no leading zero, so it can consider 2017 as datetime(2020, 1, 7, 0, 0) depending on DATE_ORDER value. There are some tests with 5 digits dates, so probably those 4 digits like 2017 should also be considered valid cases.
tests/test_parser.py
test_date_are_parsed_in_order_supplied
...
        param(
            date_string=u"18216",
            expected_date=datetime(2018, 2, 16),
            date_order='YMD',
            expected_period='day',
        ),

        param(
            date_string=u"14271",
            expected_date=datetime(2014, 1, 27),
            date_order='YDM',
            expected_period='day',
        ),

        param(
            date_string=u"21813",
            expected_date=datetime(2018, 2, 13),
            date_order='MYD',
            expected_period='day',
        ),

One of the issues on master is that it tries to parse non space dates with all possible date formats, including different date order, but prioritizing the date order provided as parameter. Fox example, if DATE_ORDER is set to'DMY, it will prioritize DMY dates, but will try also other combinations like MDY, YMD, etc... This might lead to undesired matches when the input is an incomplete date, as it tries all possible combinations of date formats, it almost always matches a date (even if its incorrect).
We can see on master, the same test with locales=['en'] parses 2017 as YMD even if DATE_ORDER = MDY
>>> dateparser.parse('2017', settings={'STRICT_PARSING': True}, locales=['en'])
--> DATE_ORDERr = '%m%d%y'
datetime.datetime(2020, 1, 7, 0, 0)

This PR implements a filter method that, when STRICT_PARSING is true, it filters the date formats attribute keeping only those that comply with DATE_ORDER. It helps with those overmatches, but does not solve all the cases, since there are cases that a 4 digit number could be a valid complete date.
Another option to handle cases like this could be a new parameter to define the minimum date length when STRICT_PARSING is True, in this case the user can change it according to their needs.
But yeah, by default I think probably it should keep parsing those 4 digits date. What do you think @noviluni  ?

@serhii73 noticed https://github.com/scrapinghub/dateparser/issues/356 might have addressed this issue, and indeed looks like that to me.
>>> import dateparser
>>> dateparser.parse("2011", settings={"STRICT_PARSING": True})
>>> dateparser.parse("2017", settings={"STRICT_PARSING": True})
>>>


Add DSL for conditional installation

I might have a Brewfile with cask 'java'. Problem is, I want to be able to use this on systems which may already have Java installed from somewhere other than brew cask.
Perhaps it'd be nice to have an API like:
cask 'java', unless: "/usr/libexec/java_home --failfast"

that will only install Java if that command fails. If the cask is already installed it should still upgrade it.

If we remove the $SAFE setting in DSL#process, then this is already supported. In that case, you can just do:
cask 'java' unless system "/usr/libexec/java_home --failfast"

Personally I'm fine to remove $SAFE . It doesn't guarantee safety and seems to restrict the function in Brewfile as shown in your case.

Yeh, good idea. I'll have a look/think.


documentation CI should only run on merge

currently the documentation is built upon every commit. It should only build upon merge to the main branch.

Could we just move it to a different YAML file? (that's how we do it in the tasks: https://github.com/fractal-analytics-platform/fractal-tasks-core/tree/main/.github/workflows)
In this way it'd be simple to specify the relevant on: section.

(but I don't know if it makes things more complex for combining jobs together, because at the moment tests is needed by coverage, and coverage is needed by docs)

See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-when-a-pull-request-merges-1, and

Note: More than one activity type triggers this event. For information about each activity type, see "Webhook events and payloads." By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened. To trigger workflows by different activity types, use the types keyword. For more information, see "Workflow syntax for GitHub Actions."

Closed with #399


Update extensions 2020-06-25

ocis-proxy 0.4.0
ocis-migration 0.2.0
ocis-phoenix 0.8.0
[x] REQUIRES: https://github.com/owncloud/ocis-reva/pull/261
[ ] REQUIRES: ocis-reva release
[ ] update ocis-reva as well

more to come later / separately

what?!
+ make vet
go vet github.com/owncloud/ocis/cmd/ocis github.com/owncloud/ocis/pkg/command github.com/owncloud/ocis/pkg/config github.com/owncloud/ocis/pkg/flagset github.com/owncloud/ocis/pkg/register github.com/owncloud/ocis/pkg/runtime github.com/owncloud/ocis/pkg/tracing github.com/owncloud/ocis/pkg/version
# github.com/cs3org/reva/internal/grpc/services/appprovider
/srv/app/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200529120551-4f2d9c85d3c9/internal/grpc/services/appprovider/appprovider.go:97:54: req.ResourceInfo undefined (type *"github.com/cs3org/go-cs3apis/cs3/app/provider/v1beta1".OpenRequest has no field or method ResourceInfo)
# github.com/cs3org/reva/internal/grpc/services/gateway
/srv/app/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200529120551-4f2d9c85d3c9/internal/grpc/services/gateway/appprovider.go:35:45: req.ResourceInfo undefined (type *"github.com/cs3org/go-cs3apis/cs3/app/provider/v1beta1".OpenRequest has no field or method ResourceInfo)
make: *** [Makefile:75: vet] Error 2

probably not updatable until we get ocis-reva as well I guess

added ocis-phoenix 0.8.0
also added ocis-reva from master, needs to be updated to a stable version after release

I've cherry-picked https://github.com/owncloud/ocis/pull/337 to get faster results.
Added ocis-reva 0.7.0 and squashed that bit.
If CI is green we can move forward. Let's hope the Phoenix tests pass now.

more EOS fixing needed it seems https://github.com/owncloud/ocis/pull/338

The same sort of upload errors are happening in https://cloud.drone.io/owncloud/ocis/737/4/8
Timed out while waiting for element <#files-upload-progress> to not be visible for 20000 milliseconds. - expected "not visible" but got: "visible" (20032ms)
undefined    ✖ failed
      Timed out while waiting for element <#files-upload-progress> to not be visible for 20000 milliseconds. - expected "not visible" but got: "visible" (20032ms)

The upload progress bar does not seem to go away. After 20 seconds it is still there???
I raised PR #342 to update the commit Ids for the test infrastructure to be used from core and phoenix against current OCIS master. That will demonstrate that the very latest test scenarios pass OK. Then the conclusion is that some new dependency change in this PR is causing trouble.


New country map not found Docker Error

I am running the last superset version with docker, and added a new country map according to the guide here: https://superset.incubator.apache.org/visualization.html#need-to-add-a-new-country
However the docker logs show the following 404 error:
superset_1  | 2019-09-23 11:57:13,944:INFO:werkzeug:<IP_ADDRESS> - - [23/Sep/2019 11:57:13] "GET /superset/explore/undefined HTTP/1.1" 404 -
I can see the file inside the live container via docker exec.
Why is superset not finding the new map? Isn't superset built live and every time docker-compose up is executed?
Dockerfile:
FROM python:3.6-jessie

RUN useradd --user-group --create-home --no-log-init --shell /bin/bash superset

# Configure environment
ENV LANG=C.UTF-8 \
    LC_ALL=C.UTF-8

RUN apt-get update -y

# Install dependencies to fix `curl https support error` and `elaying package configuration warning`
RUN apt-get install -y apt-transport-https apt-utils

# Install superset dependencies
# https://superset.incubator.apache.org/installation.html#os-dependencies
RUN apt-get install -y build-essential libssl-dev \
    libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev

# Install extra useful tool for development
RUN apt-get install -y vim less postgresql-client redis-tools

# Install nodejs for custom build
# https://superset.incubator.apache.org/installation.html#making-your-own-build
# https://nodejs.org/en/download/package-manager/
RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - \
    && apt-get install -y nodejs

WORKDIR /home/superset

COPY requirements.txt .
COPY requirements-dev.txt .
COPY contrib/docker/requirements-extra.txt .

COPY contrib/docker/docker-entrypoint.sh /entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]

HEALTHCHECK CMD ["curl", "-f", "http://localhost:8088/health"]

EXPOSE 8088

yml file:
version: '2'
services:
  redis:
    image: redis:3.2
    restart: unless-stopped
    ports:
      - "<IP_ADDRESS>:6379:6379"
    volumes:
      - redis:/data

  postgres:
    image: postgres:10
    restart: unless-stopped
    environment:
      POSTGRES_DB: superset
      POSTGRES_PASSWORD: superset
      POSTGRES_USER: superset
    ports:
      - "<IP_ADDRESS>:5432:5432"
    volumes:
      - postgres:/var/lib/postgresql/data

  superset:
    build:
      context: ../../
      dockerfile: contrib/docker/Dockerfile
    restart: unless-stopped
    environment:
      POSTGRES_DB: superset
      POSTGRES_USER: superset
      POSTGRES_PASSWORD: superset
      POSTGRES_HOST: postgres
      POSTGRES_PORT: 5432
      REDIS_HOST: redis
      REDIS_PORT: 6379
      # If using production, comment development volume below
      #SUPERSET_ENV: production
      SUPERSET_ENV: development
#      PYTHONUNBUFFERED: 1
    user: root:root
    ports:
      - 8088:8088
    depends_on:
      - postgres
      - redis
    volumes:
      # this is needed to communicate with the postgres and redis services
      - ./superset_config.py:/home/superset/superset/superset_config.py
      # this is needed for development, remove with SUPERSET_ENV=production
      - ../../superset:/home/superset/superset

volumes:
  postgres:
    external: false
  redis:
    external: false

What I've tried:
Removed volumes and build superset again.
docker-compose build --no-cache
add --force-recreate tag when rebuilding

@dpgaspar

Hi @klazaj - I don't see anything obviously wrong with your setup, can you share the content of superset/assets/src/explore/controls.jsx? Did you add your new country file to the configuration?

Hi @willbarrett, I resolved the issue but forgot to close it, sorry about that. In the new version of Superset, CountryMap is converted into a plugin. I had to change the directory of CountryMap, so that it pointed to the visualizations folder, and not the node_modules. The documentation might need to be updated here https://superset.incubator.apache.org/visualization.html#need-to-add-a-new-country


Import errors with absolute paths from test directory to src.

ISSUE
After taking a look at issue #64 I was surprised to still see many questions about imports. I am currently facing the this horrible issue. My tests used to work and then I changed my repo around and now my imports are not working properly.
● Test suite failed to run
/Users/marcuswhelan/MyWork/binary-type-tree/__tests__/bTreeUtils.spec.ts:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){require('ts-jest').install();import { defaultCheckKeyEquality, getRandomArray, defaultCompareKeysFunction, defaultCheckValueEquality } from "../src";
                                                                                ^^^^^^
SyntaxError: Unexpected token import

  at transformAndBuildScript (node_modules/jest-runtime/build/transform.js:320:12)
  at handle (node_modules/worker-farm/lib/child/index.js:41:8)
  at process.<anonymous> (node_modules/worker-farm/lib/child/index.js:47:3)
  at emitTwo (events.js:106:13)

Expected
Before I would compile my tests and everything worked fine. However I was having issues with having my tests directory compile into the outDir and this is not what I wanted so I created a new tsconfig.jest.json file to handle jest. It should compile the tests and then fill the coverage folder.
This is not the smallest repo
The code was passing 100% before the tsconfig changes. So really the only issue is with the tsconfigs and or the package.json file.
binary-type-tree
version 1.0.1 -> 1.0.3 do not install with lib folder. version 1.0.4 does but is not recognizing some public methods on an abstract class Node toJSON in particular.
I worked to fix this by running more tests and was having issues with the compiler options so worked this project into its current state and now this is happening. still on 1.0.4. but many commits since the 1.0.4 launch. But all had passing tests.

@marcusjwhelan try setting allowSyntheticDefaultImports to true. I've sent a PR with this

@kulshekhar ahh. yes that seems to be the culprit. I seem to now bet receiving this issue though. Not particularly bad but it is clutter.
Test Suites: 3 passed, 3 total
Tests:       30 passed, 30 total
Snapshots:   0 total
Time:        10.139s
Ran all test suites.
Error: Could not find source map for: "/Users/marcuswhelan/MyWork/binary-type-tree/src/index.ts"
at CoverageTransformer.addFileCoverage (/Users/marcuswhelan/MyWork/binary-type-tree/node_modules/remap-istanbul/lib/CoverageTransformer.js:169:17)
at /Users/marcuswhelan/MyWork/binary-type-tree/node_modules/remap-istanbul/lib/CoverageTransformer.js:295:14
at Array.forEach (native)
at CoverageTransformer.addCoverage (/Users/marcuswhelan/MyWork/binary-type-tree/node_modules/remap-istanbul/lib/CoverageTransformer.js:293:24)
at /Users/marcuswhelan/MyWork/binary-type-tree/node_modules/remap-istanbul/lib/remap.js:51:13
at Array.forEach (native)
at remap (/Users/marcuswhelan/MyWork/binary-type-tree/node_modules/remap-istanbul/lib/remap.js:50:16)
at processResult (/Users/marcuswhelan/MyWork/binary-type-tree/node_modules/ts-jest/dist/coverageprocessor.js:66:29)
at source.getTestPaths.then.then.then.runResults (/Users/marcuswhelan/MyWork/binary-type-tree/node_modules/jest/node_modules/jest-cli/build/runJest.js:110:58)
at process._tickCallback (internal/process/next_tick.js:103:7)

I didn't see this issue when running the test after the fix so I'm not sure what's going on. It might be worthwhile to create a travis config for your repo

@kulshekhar oh hmm. It must be my IDE. I am using webstorms jest IDE support. I also ran it with npm and it does not have this output. Sadly I have never worked with any travis configs and am not sure how to get started. I am looking though.

When you set allowSyntheticDefaultImports or target as es6, you're expecting the output from typescript to be processed by another processor (mostly babel). This causes coverage to break.
So, if your target is es6 or if  you allow synthetic default imports, coverage will break.
If you want coverage, the target needs to be es5.
I'm looking at ways to fix this but, at the moment, this is how it unfortunately is

Ah. Okay. I will make sure to watch the repo to see if this does get fixed. You would think that ES6 would be easy to transpile, with its imports/export system being almost identical to TypeScript.

For absolute path in jest you can use babel https://github.com/tleunen/babel-plugin-module-resolver
https://medium.com/@sherryhsu/how-to-change-relative-paths-to-absolute-paths-for-imports-32ba6cce18a5
And for 'src/pages/ActivityHistory/ActivityChart/utils' in babel.config.js:
plugins: [
['module-resolver', {
src: ['.'],
alias: {
src: './src',
},
}],
],


Make 'branch' configurable in config-file for pull

Hi,
it looks like defining the "branch" in the config file is right now only possible for the push command.
Would be awesome if this could be set also for pull commands in the config-file.
Thanks

hi @eloo-abi thanks for the suggestion, definitely makes sense to have it. it's not super trivial as the logic for pull and push is not the same, but I opened an internal ticket, hopefully it will be picked up soon.

hi @eloo-abi this feature should now be included in the v2.34 of the cli.


fix import paths

Import fails on fetching all packages currently:
go get github.com/agoussia/godes/...
(compare with go get github.com/agoussia/godes).

(¬‿¬) go get github.com/agoussia/godes/...
package godes: unrecognized import path "godes" (import path does not begin with hostname)
After this PR this works as expected.

just talk to me directly at<EMAIL_ADDRESS>


Resource does not work with Bitbucket >7.0

Today our pipelines broke without any change to our PR builds. It turns out that our on-prem Bitbucket Server was updated to 7.2.x. It looks like this resource is not compatible with Bitbucket 7.2+.
The following error occurs during the GET step:
Cloning into '/tmp/build/get'...
fatal: Couldn't find remote ref refs/pull-requests/24/merge

Screenshot:

Googling around for the error, the assumption arises that this might also effect Bitbucket Server 7.0/7.1, but I am not sure about this.
This is a nasty one, as this affects a lot of pipelines…

The problem might be related with the following line in the {{IN}} script:
https://github.com/mmb/concourse-bitbucket-pullrequest-resource/blob/d28370100891e330c57da1f93333a51a7181cf7c/assets/in#L68
Listing all refs in the given repository via {{git ls-remote}} only shows a ref:
c10913bff4e91a511685a29d28e98ce06e44eeaf	refs/pull-requests/24/from

Please note that its suffixed with /from whereas the resource is searching for /merge.

I did some further investigation and it looks like the whole world was beaten by this one. The relating information can be found here:

https://community.atlassian.com/t5/Bitbucket-questions/Difference-of-refs-pull-requests-lt-ID-gt-merge-and-refs-pull/qaq-p/772142
https://jira.atlassian.com/browse/BSERV-12284
https://github.com/jenkinsci/bitbucket-branch-source-plugin/issues/287

It turns out that the internal Git refs everyone is relying on is only internal API of Bitbucket which has been removed in Bitbucket 7.0. As stated by Atlassian, this is not going to come back and the REST API should be used for that matter.
I tried to work around by using the following Bitbucket plugin for eagerly updating the refs: https://github.com/Cyanoth/Bitbucket-EagerPR-Updates
Unfortunately this updates the /from ref, so this is no help with this resource:
https://github.com/Cyanoth/Bitbucket-EagerPR-Updates/issues/2
So it looks like the only chance we have is to modify the in script to use the API.
I looked into the source, but my Git knowledge is not that deep, so I do not fully understand what is going on in lines 68-120.
In the end, what is used is the source_commit and target_commit values. There is a old pending PR in this repo for using the REST API for the check script that already creates the meta data for these commits in the check step. The PR needs some refresh but might already provide what is needed to fix this one.
If there are any other solutions or workarounds to this one, please share 'em.

Any updates on this one? I'm trying to setup a pipeline in combination with this resource but I'm getting blocked by this issue.

We found another fork of this resource that seems to be maintained lately. It still has the same problems. We did a initial PR on that that fixes some of the problems and is working for us, but is not final:

https://github.com/emerald-squad/concourse-bitbucket-pullrequest-resource
https://github.com/ewerk/concourse-bitbucket-pullrequest-resource

We also had to install the plugin because in the out script refs/pull-request/*/from is still used and does not get created by Bitbucket until you look at the PR diff for the first time.
I´ll try to fix that also in the resource, but cannot give any timeline by now.

Hi @holgerstolzenberg, thanks for replying. This is the first time I'm checking again. Did you manage to fix the resource in the fork by any chance?

No not finally. At emeraldsquad, there is a pending code review for our PR that is missing a final comment.
It stillt might be useful to merge all the stuff to this repo as your resource has the highest download rates at Dockerhub.
Maybe we can get some pace on here?

We have recently run into similar issues with the pullrequest refs. There are race conditions where sometimes the ref isn't there by the time Concourse checks. We also have issues with bitbucket mirrors not having all the refs. Bitbucket admins and Atlassian claim this is an internal API and it sounds like they've finally removed it.
I also started working on some changes to use the API instead of ls-remote with pullrequest refs in this branch:
https://github.com/mmb/concourse-bitbucket-pullrequest-resource/tree/list-prs-api
The main issue I'm seeing is a lot of this resource is based on the concept of a "merge" ref and that doesn't seem to exist in the API.
We set "rebuild_when_target_changed" to false so we don't need the merge refs but other use cases might. I'll work on it but I wanted to get some community feedback about making this resource use only what is available in the REST API, which could mean removal of some features.

This might be of interest for you if you want to continue this effort:
https://www.atlassian.com/blog/announcements/journey-to-cloud
i.e. Atlassian pulls the plug on server licences, drags customers to the cloud

@mmb Is this fixed or is there a workaround for this ?


When using KeePass auto-fill, the dot character is misbehaving.

The entry contains a regular dot . characters but when using auto-fill, this character is misbehaving and appears to be a combining character with the character just before it.

KeePass is using the Win32 VkKeyScanEx function to lookup the corresponding key on the keyboard layout. The . dot character is U+002e and is defined multiple times in the keyboard layout.

First defined here as a dead-key trigger for the dot above diacritical mark.
Then here at its normal location.
And a third time here for the numeric keypad.

It seems that the first occurrence is found and therefore used instead of the expected normal position.

The only duplicate characters that double as dead-key triggers are the following:

dot below, replaced by non combining FULL STOP (U+002E)
inverted breve, replaced by non combining DEGREE SIGN (U+00B0)
short solidus overlay, replaced by SOLIDUS (U+002F)
short stroke overlay, replaced by non combining HYPHEN - MINUS (U+002D)
comma below, replaced by non combining (U+002C)

First of all, thanks @springcomp for this layout which I use with stickers on a traditional AZERTY.
Prior to the AFNOR version, I used a custom AZERTY in which (among other things) I had changed the decimal character from "." to ",".
If I open the KLC on this repository and change just that, the resulting keyboard reintroduces the bug with KeePass and the dots. From the content of the KLC I see that the fix requires some keys to be declared after all the others. And I suppose Microsoft Keyboard Layout Creator re-sorts everything when we open the file manually (confirmed at least when doing a save + compare).
I could try to install all the prerequisites or setup a dev environnement with docker and try to understand how to create the setup without KLC but do you think, since you already ship 2 layouts (Standard + Numérique), that you could add a variant of Standard, for users with a NumPad and set the decimal separator to ","? (Package would contain "Standard", "Numérique" & "Comma")
That would be awesome.

@kevin-frugier Thanks for your feedback.
Yes this is a good idea.
One one hand, I like the idea to have the , comma as the decimal separator.
One the other hand, I would not like to deviate from the standard too much to improve the chance for this layout to become the official de facto layout for the NF Z71-300 standard.
However, as shown by #78 you could have created a pull request with your changes and taken advantage of AppVeyor to produce the resulting artifacts. In fact, I have just done that for you.
Please, download the resulting setup program from AppVeyor and tell me if that is OK for you.
Please, be aware that those artifacts will be automatically deleted in six months as per AppVeyor retention policy.

Thank you very much @springcomp. Tested and approved. I understand why you don’t want to deviate too much from the standard and I didn’t know this repo was so automated that I could have done it myself. Thx again

@kevin-frugier, following changes #80, I updated this PR to produce a new compatible release.
You can find the built artifacts from the CI server.

@kevin-frugier, following changes #82, I updated this PR to produce a new compatible release.
You can download the build artifacts from the CI server.

@kevin-frugier, following changes #85, I updated this PR to produce a new compatible release.
You can download the build artifacts from the CI server.

This is the worst change you could do and only for 1 person asking for it…
Physical keyboards you can buy have the DOT on that key and now we can't use it as it should be used. I bought mine on LDLC and I didn't print my own stickers.
You need to type a date? Forget that key.
You need to type a phone number? Forget that key.
Excel, calculator, … are used to the dot. This is really useless to me. This change is clearly for someone using numbers in a way they shouldn't use it.
I tried to download an old release but I still get the coma. I'll try to find another NF Z71-300 with default layout.

@Pierrounator What's will all the rage and down votes all over the place?!
Which variant are you using?
With current driver (KBFRZ71_amd64 on its own) I have the following behavior on a French system with a "."  is produced
Excel with standard FR regional settings "," is produced
Excel with US regional settings "." is produced

Français - AZERTY NF Z71-300 (Numérique)
(supposed to be used only for non-physical num pads if we follow the documentation)

Notepad: "," is produced
Excel with standard FR regional settings "," is produced
Excel with US regional settings "." is produced

For some odd reason the "Français - AZERTY NF Z71-300" classic variant no longer produces the "," on its own but that should be what you expect anyway so why are you unhappy?
As for the initial choice of the comma as decimal separator for applications not "regional settings aware", we can re-discuss that with @springcomp if needed. The goal of AZERTY NF Z71-300 is to be able to type in "french" without counting on softwares to replace mistakes (like it was the case for "œ" and others in the past). The virtual key code for the key is (VK_)DECIMAL so it's meant to be used to type a decimal separator. We got used to something else because standard layouts/keyboard manufacturers were racists :D A good showcase for me is "Are you able to type a french text with french numbers (amounts) in raw notepad?".
(as per your examples, IP adresses indeed use dots, regular and standardized date and phone numbers formats don't)
If you follow the thread back to my initial request, you would see I only requested for a custom variant. So when we understand the status of the current version (with the mismatch between the 2 variants) we can then potentially move the comma stuff to an explicit variant hence giving more choice to the user.

Well I was upset yes because I use NF Z71-300 everyday at home and at work and when I got a new computer at work I couldn't type phone numbers (because we put dots to make it readable), IPs and numbers anymore with that key. I work in an hospital for TV, WiFi, Phone, … and I use that dot key like 200 times a day.
I installed the NF Z71-300 tuesday on W11 with your PowerShell command and then on Notepad, … it was producing the coma and not the dot.
I uninstalled it and downloaded the previous version (1.8) and it was still producing the coma. But today I saw it was producing the dot (thank god). I thought you forced an update or something like that.
I've never seen the Numérique option… So I'm not sure what you're talking about.
I'm still convinced this key should stay as a dot. Yes, in France we are told to use the coma for the numbers. But if you do some programmation, … the coma will produce an error. If you really need to put a coma to make it pretty, you still have the coma key under the letters.
For example, in javascript doing let = 1,34; is wrong.
For the phone numbers, I know we shouldn't use the dots but to save customers phone numbers it's easier to read <IP_ADDRESS>.89 instead of<PHONE_NUMBER>.
And as I said, the manufactured Azerty+ keyboard has a dot printed on this key. (https://www.ldlc.com/fiche/PB00544268.html)
Btw thank you for that keyboard layout. I use it since many years and I was happy to find the perfect mix between AZERTY and BÉPO. I was about to switch to BÉPO but I knew I wouldn't be able to use it at work since it's too much different. At least, they let me use this AZERTY+ and my coworkers are not fully lost if they have to use my keyboard

Just to be sure.
There is no configuration or any other ways to get back the dot on the numpad since this commit ? Because it's very unconvenient to have a comma here :S
Thank you anyway for this layout I now use everywhere :)

@Rehvaro, #78 showed that you could submit a PR and produce a build for your own consumption.
In fact, I did just that for you.
Please, download the resulting artifacts and enjoy your own, very private, version of the layout 😉.

Oh Thank you !
Sorry, I only know the basics of GIT, and don't use github very often.
I suppose this PR and the corresponding artifacts will not updates with futur commits of the main branch, so in case I want to update I will just have to make a PR like this to have the newer version but just with this tiny difference ? Or am I wrong ? ^^
Thank you

@Rehvaro  that’s exactly right !


DNS query timeout on a TCP OpenVPN under certain conditions

Summary
TCP VPN tunnel is created, remote IPs are accessible, VPN DNS server is accessible but some specific DNS queries time out
Steps to reproduce
Unfortunately we can only reproduce the issue on a VPN endpoint that is ran by a third party not under our control. In our internal test VPN server everything works fine.
The minimal set of steps we use to reproduce the issue are:

Connect to this specific TCP VPN
Open a dig / nslookup tool like Deep Dig [https://itunes.apple.com/app/deep-dig/id1290406765]
Perform some dns queries

What is the current bug behavior?
DNS query times out
What is the expected correct behavior?
DNS query results should appear after a few seconds
Relevant logs and/or screenshots
Possible fixes suggested remediation
We tried to collect as much information as we could to narrow down the problem. What we found out so far is:

When connecting using the official OpenVPN client the DNS lookup always works fine
When we connect to our own test VPN server the DNS lookup always works fine (both servers run Open VPN 2.4)
When we perform an A query for some domains, we always get the expected result...
...For some other domains, we always get a failure
...For a specific domain, we get one success for every 5 failures or so
When we perform a query for a VPN IP, it always works
When we specify any parameter to dig, it always works (examples: +tcp, +notcp, +vc, +novc, +ignore, +time)

We recompiled the code (from master) with some extra logging, and we verified that the DNS response packets do arrive and are read and decrypted correctly by the library on SessionProxy.handleDataPackets(). However, Deep Dig and other client apps (like the web browser) are not able to successfully resolve the domain.
Assignees and labels
~ios11

After some more experimentation we did in the last few days, we have more info:
We have configured a separate DNS forwarded (dnsmasq) for the VPN connection just to temporarily circumvent the issue described above. After that we were able to resolve all domains and navigate using the web browser.
The problem now is that we can load only resources up to 1kB of data (html pages, css, js and images).  Resources bigger than 1kB just don't arrive to the web browser (it keeps waiting for the http response forever)
Thanks


Update overview.md

Fixed grammar typo; "is" -> "are"

@collinsherman - thank you for your contribution.
#sign-off


Any time a $ is typed as the first character, it throws

Better exception handling that's less obvious plz.
Typing in currency shouldn't spam the chat with errors

writing a utility to allow for a reaction to delete the message has been in the back of my mind. This is an excellent usecase


sqlx has same dependencies with and without macros feature

Create an empty project: cargo init --bin foo
Depend on sqlx with minimal features: `sqlx = { version = "0.4", default-features = false, features = ["runtime-async-std-native-tls"] }
cargo tree > dependencies0
Add the macros feature sqlx = { version = "0.4", default-features = false, features = ["runtime-async-std-native-tls", "macros"] }
cargo tree > dependencies1
diff dependencies0 dependencies1 shows the files are the same

It is surprising to me that the dependencies are the same. I expected less dependencies without the feature as these kind of features are usually used to reduce compilation time.

Duplicate of #955

Duplicate of #955


Double Dispose() of ZipWritingStream

Hello!
I've noticed that ZipWritingStream on Dispose method call will produce a new ZipEntry.
But it doesn't have protection against subsequent Dispose call. For example:
using (var stream = zipWriter.WriteToStream(FileNameHeader, new ZipWriterEntryOptions()))
using (var streamWriter = new StreamWriter(stream))
{
   ...
}

it will call dispose for ZipWritingStream two times and produce two zip entries in the archive.
I didn't checked it for other streams (non-zip) but they also could be affected by this issue.
Regards!

Good find.  Any chance for a pull request? :)

Sure https://github.com/adamhathcock/sharpcompress/pull/295

Thanks!


How to set custom hostname in (@ServerSettings) parameter

The default host name is <IP_ADDRESS>. How to change this option, for example on localhost (<IP_ADDRESS>) ?

Hello @azanorth ,
Actually, it can be changed with the httpPort option:
@ServerSettings({
    httpPort: '<IP_ADDRESS>:8080',
    httpsPort: '<IP_ADDRESS>:8081',
})

See you,
Romain

Hmm, it's easy, thank you very much, I wish you a nice day

You too ! thank you :)


Custom content in tooltip

Is your feature request related to a problem? Please describe.
More often than not, the standard tooltip does not have space for all the information the designers want in it
Describe the solution you'd like
To have a flexible tooltip (in addition or as a property) to the one we have today
Describe alternatives you've considered
Can make one ourselves, or use another package
Additional context
From what we have in design for instance

It sounds to me like you are describing the popover component, which can be used as a tooltip with any content. Is there a reason you cannot use this? If so are there any improvements we can do to the popover component?

Yes, that should do the trick. Thank you!


Can't start the app.js anymore (syntaxError)

Hello,
Yesterday everything worked fine, and this morning lauching node app.js throw this error :
\loop-website\app.js:509
                }
                ^
SyntaxError: missing ) after argument list
    at createScript (vm.js:53:10)
    at Object.runInThisContext (vm.js:95:10)
    at Module._compile (module.js:543:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:425:7)
    at startup (bootstrap_node.js:146:9)

I really have no idea how to solve this issue

This feels like a syntax error, not an Apostrophe issue .. please follow up with code samples in the StackOverflow thread you've created.

Just to further clarify, this is a syntax error in app.js, which is your
file. Try a javascript linting tool like eshint or just check that line of
code.
On Wed, Aug 23, 2017 at 7:30 AM, Stuart Romanek<EMAIL_ADDRESS>wrote:

Closed #982 https://github.com/punkave/apostrophe/issues/982.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe/issues/982#event-1217643302, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAB9ffBTSaj7CQN5-WjUpYgJc5LHtZzTks5sbA1RgaJpZM4O_xan
.

--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

Hello,
I don't understand what happens, but it works when I launch the node app.js using git GUI and not the windows cmd


Not work with pjsip users.

Good project, but not work with pjsip users.

Work in progress...

@dagmoller - Do you have any update on this? Or even a WIP branch that other could contribute to.


Update links

Changed Links: sc-cluster-broker-server and sc-cluster-state-server

@bicho Thanks :)


Add ability to import/export workflows

And probably add a note on the weird format, how it's meant to compress the data for Melvor's 8 kB limit etc.
Should just be a Swal modal with a <textarea>

Already hitting the 8kb limit with a single workflow so having export/import would be great.
I actually can't finish the workflow due to the limit, which is just a mine essence to X amount then create X amount of runes with jump back to beginning. I do make use of And/Or triggers to check rune amount OR out of essence - I assume that trigger takes up more space.
Some sort of templatized step might help with the limit since essentially every step in this sort of workflow is the same.

I was gonna say that's one hell of a workflow, but then I only have 3 relatively tiny ones that that's already 2147 bytes when in storage

JSON
[{"name":"Fire God Dungeon","rm":false,"steps":[["actions","trigger"],[[[["opts","id","action"],[[{"set":1},null,"ActionWorkflows:equipSet"],[{},null,"ActionWorkflows:activatePrayers"]]],{"opts":{"mob":"melvorF:FireGuard"},"id":"ActionWorkflows:mobID","action":null}],[[["opts","id","action"],[[{"set":2},null,"ActionWorkflows:equipSet"]]],{"opts":{"mob":"melvorF:FireGolem"},"id":"ActionWorkflows:mobID","action":null}],[[["opts","id","action"],[[{"prayers":["melvorF:Rigour"]},null,"ActionWorkflows:activatePrayers"]]],{"opts":{"mob":"melvorF:Pyra"},"id":"ActionWorkflows:mobID","action":null}],[[["opts","id","action"],[[{"set":1},null,"ActionWorkflows:equipSet"],[{"prayers":["melvorF:Augury"]},null,"ActionWorkflows:activatePrayers"]]],{"opts":{"mob":"melvorF:Ignis"},"id":"ActionWorkflows:mobID","action":null}],[[["opts","id","action"],[[{"set":2},null,"ActionWorkflows:equipSet"],[{"prayers":["melvorF:Rigour","melvorF:Sharp_Vision"]},null,"ActionWorkflows:activatePrayers"]]],{"opts":{"mob":"melvorF:Ragnar"},"id":"ActionWorkflows:mobID","action":null}]]]},{"name":"Rokken","rm":false,"steps":[["actions","trigger"],[[[["opts","id","action"],[[{"prayers":["melvorF:Protect_from_Ranged","melvorF:Piety"]},null,"ActionWorkflows:activatePrayers"]]],{"opts":{"match":"=","atk":"melvorF:ShockwaveEnemy"},"id":"ActionWorkflows:enemyAtk","action":null}],[[["opts","id","action"],[[{"prayers":["melvorF:Piety"]},null,"ActionWorkflows:activatePrayers"],[{"idx":0},null,"ActionWorkflows:setStepIdx"]]],{"opts":{"match":"!=","atk":"melvorF:ShockwaveEnemy"},"id":"ActionWorkflows:enemyAtk","action":null}]]]},{"name":"Umbora","rm":false,"steps":[["actions","trigger"],[[[["opts","id","action"],[[{"prayers":["melvorF:Augury","melvorF:Protect_from_Melee"]},null,"ActionWorkflows:activatePrayers"]]],{"opts":{"match":"=","atk":"melvorF:RapidOnslaught"},"id":"ActionWorkflows:enemyAtk","action":null}],[[["opts","id","action"],[[{"prayers":["melvorF:Augury"]},null,"ActionWorkflows:activatePrayers"],[{"idx":0},null,"ActionWorkflows:setStepIdx"]]],{"opts":{"match":"!=","atk":"melvorF:RapidOnslaught"},"id":"ActionWorkflows:enemyAtk","action":null}]]]}]

Screenshots

I'll have a look at this on Sunday - gonna be travelling over the weekend so won't have time in the next couple of days. I think this bumps #43 up the priority list as well - if this is how easy it is to hit Melvor's limit then I think having mods define entire workflows might end up being the way to go - the fire god dungeon workflow, for example, then  wouldn't take up nearly as much space and would only need a few inputs like which equipment sets to use. If we're still consistently hitting size limits afterwards then I might need to think about storing workflows somewhere outside mod.io.
Using mod namespaces for action/trigger IDs felt nice and convenient too (allows me to reuse a bunch of the game's code for mod logic), but ends up with quite a bit of space wastage too..

For reference, here's a screenshot of the workflow. I can't add the "and/or" to the first set of runes due to size. The and/or is "if rune qty >= 1000000 OR essence qty <= 0" - that way it doesn't get stuck if I run out of essences and the last step jumps back to mining essences. All steps past the first three would essentially be the same, just different parameters.
Screenshot
![wkflow](https://user-images.githubusercontent.com/3178267/206762707-bc7df3ee-efb6-42cf-80cd-fbc967e4eff0.jpg)


Fixed #30220 -- Headless browser mode for selenium test

Both Chrome and Firefox support a new headless mode now. Besides
being faster, it also is more reliable as well as convenient since
there are no windows popping up.

buildbot, test on selenium.

buildbot, test on selenium.

buildbot, test on selenium.

buildbot, test on bionic.

buildbot, test on selenium.

could you check the flake8 issue when you back to this?

@auvipy there was none, it just crashed, I will rebase

buildbot, test on selenium.

@auvipy done :)

I've looked it through and tested it, works fine on my box! I'll leave it to @carltongibson for a final review (do we need release notes?).

Okay. Thanks both. I’ll give this a run just as soon as I recover from DjangoCon. 🙂
I think a mention in the release notes is justified. This is a cool addition.

hey @carltongibson, I hope you have recovered and all is well. I added a release note. Just amend any changes you want to make to the wording. best joe

Super @codingjoe. Let us just get 2.2.1 out the way and we'll give this the last once-over and pull it in. Great effort!

buildbot, test on selenium.

hm... our build system is far from stable it seems

buildbot, test on selenium.

buildbot, test on selenium.

Hrmpf, something is wonky with the trigger, jenkins says:
Bad configured project pull-requests-selenium - GitHub project property is not defined. Can't setup GitHub trigger for job pull-requests-selenium

Tim, from the ticket:

Jenkins uses xfvb-run to run the tests headlessly

Yeah that is all installed and well but the triggers seem to be broken

I am testing on https://github.com/django/django/pull/11367

buildbot, test on selenium.

buildbot, test on selenium.

Ok, they seem to work again.

@codingjoe Thanks for this PR :+1: I pushed minor edits.

buildbot, test on selenium.

buildbot, test on selenium.

buildbot, test on selenium.


Upgrade odh-elyra 3.16.6 that includes pod toleration, label and anno…

Upgrade odh-elyra 3.16.6 that includes pod toleration, label, and annotation

Description
This brings in the changes based on: https://github.com/opendatahub-io/elyra/releases/tag/3.16.6
How Has This Been Tested?

Executed in the PR in odh-elyra.
Test it based on below:

Setup a cluster with notebook images
set the DSP instance
Set the GPU for testing toleration
Test the toleration by including the value.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Thanks for the review :100:


fix: allow testing any issuer

What kind of change does this PR introduce?
This PR updates the JWT verification code so that if the user has specified multiple allowed issuers, the verification works properly.
Fixes: #32

I tested this and it works as advertised and also does not cause any issues with existing usage.

@fenix-hub I'm not sure we can do that here, since that would mean that all claims are PackedStringArray. The purpose of this change is to account for the specific JWTClaims.Public.ISSUER claim being either a String or a PackedStringArray, since JWTBaseBuilder has this:
func with_issuer(issuer: String) -> JWTBaseBuilder:
	add_claim(JWTClaims.Public.ISSUER, issuer)
	return self

and JWTVerifierBuilder has this:
func with_any_of_issuers(issuers: PackedStringArray) -> JWTVerifierBuilder:
	add_claim(JWTClaims.Public.ISSUER, issuers)
	return self

In truth, verifying against multiple possible issuers seems like an edge or maybe even corner case to me, and should probably be pushed off to the application instead of being in the implementation. What I mean by that is that our verification code in this implementation should verify an issuer string against an issuer claim string when needed, otherwise, it would be up to the application using this implementation to check against multiple possible allowed values.
I think that is an issue for another time though, and is relevant to the discussion we recently started.

I admit I didn't really understand why this code was here, I just tested that it worked with both a single and multiple issuers (String or Array) and that it didn't break existing functionality.
I think I agree with that this feature might not even belong in the library. If someone has an unusual requirement (allow one of many issuers) then they can just not validate the issuer and then check it in the decoded JWT output after it is verified.
In theory someone will be putting any number of "payloads" or "claims" (as far as I know they are the same in the token itself) into the JWT, and will need to do their own checking post-verification that they exist.
I noticed that the Python JWT library mentioned elsewhere has an option to also verify that a given "claim" exists regardless of what the content is. This one on the other hand only lets me check a claim with a specific value. How would I know, for instance, what user ID to check for before decoding the JWT?
However, again, I'm not sure it is highly valuable for a library to let me make arbitrary checks on the contents when I am going to have to process the contents later anyway.
For the JWT spec I believe that there are "registered claims", like the issuer, expiration, etc. and it makes sense to include those as part of the library, but everything else is probably an exercise for code written and run against the decoded value later by the developer, not this library.
TL;DR: I agree that this is probably a feature that we don't even need, but since it was apparently already here, it is good for it to work. I would reveres my position if the RFC indicates that the issuer "registered claim" is supposed to allow one or many entries.


Object Browser crashes the node editor

Although it is suggested to only use GUI/GUILayout Elements inside a node, it may prove truly useful to  have EditorGUI elements as well such as ObjectField(...). This, of course, is incompatible with runtime editing but it should not prevent unity editor to benefit from EditorGUI capabilities. Some may use this framework purely to create sequence of actions (my case), and never provide a runtime editor.
The control itself works and appear correctly inside the node. Drag'n'Drop function as well. But if you choose to reference object by using the native object browser: The editor goes out of control, loose current edited canvas because of the implemented exception catcher.
Any idea why?

After clicking on the bullseye :

Hey Salepate!
This is a (more or less widely) known problem within editor programming in unity, unfortunately.
This should be fixed since a few months now, though. So please make sure you're using the latest version:)
If you want to check yourself, you can look into Editor/Node_Editor/NodeEditorWindow.cs, in the GUI function you'll find the try-catch-block around the drawing function. What should catch all errors that are emmitted actually causes errors itself when using any picker field (ObjectField, ColorField, EnumField, etc.). For some reason those builtin fields cause the GUI to crash when called from within a try-catch block.
I've found somewhat of a solution for this by only catching UnityExceptions, not the whole palette of System.Exception's. As I said I changed that in an (older) commit to only catch UnityExceptions but you can change that yourself if it's not yet set.
It may alse be caused from a try-catch block you've set yourself of course, so please check that, too.
Anyway, that should fix it hopefully!

Hi,
I do use the latest version of this framework (freshly cloned today) in a newly created project, mainly for testing purpose. I do see that all exceptions are being caught currently (I am using the master branch by the way). I'll try by only catching UnityExceptions see if that fix the problem.
Thank you anyway
Regards,

Oups, sorry then. Seems I forgot to merge that:/
Thanks for making me aware!

I committed a hotfix for this bcba068
That should do it:)

Thank you for the quick response!
Good framework by the way!

No problem;) If you have suggestions, just drop by here on GitHub!


Update README.md

Fixes some writing issues.

Some of the changes don't seem right, so please @mdo @patrickhlauke have a look.

This is fine as-is.


OAuth client_id should be read from config.json

OAuth client_id should be read from config.json instead at:
https://github.com/GoogleChrome/gulliver/blob/master/public/js/gulliver.js#L100

gulliver.js is read from the frontend, and we're not publishing config.json. Looks like the best would be writing the client_id to gulliver.js in build time?

True, could we add it to the template generation?

Hum. Should be possible to generate the .js from a template. Any input on this, @ithinkihaveacat. I added an issue for the build system on #89

I think we should generate a file like config.js which we arrange to load at some point and make available at e.g. document.config. So then gulliver.js could get the client_id from document.config.client_id--I don't think any values should be interpolated into the middle of the file that's mostly code, that's a bit weird.

Re client_id configuration, see #104.

I think #104 fixes this well enough, will close this. (Please re-open if you disagree.)


Is it possible to have a fenced block be parsed?

When having this:
* a
* b ~[](b.jpg)
* c

the image in the list block is parsed.
But in this case:
```
This is a test ~[](test.jpg).
```

the image is not rendered.
I have written an extension for some specific stuff (*...* becomes <b class="artist">...</b>) and getting to know Parsedown a bit better under the hood, but I am not seeing why a list block renders the contents but a code block does not.
I have already tried changing the pre into div and even the code into div as well, but that still does not parse the contents of the block.
How can I tell my extension to parse the contents of a fenced block? Or should I use a different type of block for this?
Thanks!

code blocks are ment to be taken as is and nothing inside them will be threated as markdown. thats the whole point of a code block ;)

You're right, but symantically there is a difference between a fenced block and a code block. I was talking about a fenced block.
I solved this by creating an extension to make a fenced block that does not other than adding a wrapper DIV with a class, so I can target it using CSS and JS. I decided to use a triple period for this:
 ... gallery
 ![](image1.jpg)
 ![](image2.jpg)
 ![](image3.jpg)
 ...

Seems to work! I forced it to be a true fenced block, so blank lines do not end it (as is the case with a quote).

Might be nice to add that option to parsedown-extra ?
You could add a pull request over there.
I'm interested to see how robust your implementation is...

Good idea. I'll do some more testing before I add a pull request, though. ;)

This seems to work but I need some more test cases, see if I can break it...
    protected function blockFencedCode($Line)
    {
        // $pattern = '/^(['.$Line['text'][0].']{3,})[ ]*([\w-]+)?[ ]*$/'; // works only on a single class name
        $pattern = '/^(['.$Line['text'][0].']{3,})[ ]*(.+)?$/'; // everything after the fence is the class
        if (preg_match($pattern, $Line['text'], $matches)) {
            $Element = array(
                'name' => 'code',
                'text' => '',
            );

            $blockName = 'pre';

            if (isset($matches[2])) {
                // removed this from the Parsedown way, since DPRP doesn't have language blocks
                //$class = 'language-'.$matches[2];
                $class = $matches[2];

                $Element['attributes'] = array(
                    'class' => $class,
                );

                // when a class is given, the block is a DIV and not a CODE block
                $blockName = 'div';
                $Element['name'] = 'div';
            }

            $Block = array(
                'char' => $Line['text'][0],
                'element' => array(
                    'name' => $blockName,
                    'handler' => 'element',
                    'text' => $Element,
                ),
            );

            return $Block;
        }
    }

When using just three backticks it will parse into a PRE tag, but with one or more class names, it is a DIV with those class names.

Ah pity, the contents are not parsed...

Oops, I think this should belong in the Parsedown Extra section...

@jerry1970 You can create a repo for the extension and add it here: https://github.com/erusev/parsedown/wiki/Extensions-and-Related-Libraries
I think Parsedown Extra is mostly meant to conform to Markdown Extra.

Damn, I didn't even know about that, silly me...


CV section

If from markdown-cv, Repo has been forked, set it up as per instructions here
otherwise good to put a version of the one you did last

Section containing a little on what you did, like "the academic me"

nah, no CV on blog


Add logs flags

Out of curiosity, what do you need this for?
I am not against merging it, but I am just wondering what is the use-case over a standard redirection?

It makes the output a bit more clean in my opinion and I use it mainly to filter the SBI calls at the moment :)


error[CE0001]: Enum repr casting causes "expression NonHirLiteral"

The following code
#[repr(u16)]
pub enum ProtocolVersion {
    Mls10 = 1,
}

pub fn enum_repr() {
    const __Mls10: u16 = ProtocolVersion::Mls10 as u16;
}

fails with the following error
error[CE0001]: Diagnostics.Context.ThirImport: something is not implemented yet.
               expression NonHirLiteral
   --> src/lib.rs:178:26
    |
178 |     const __Mls10: u16 = ProtocolVersion::Mls10 as u16;
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Mmh, I had no idea what could create a NonHirLiteral, thanks for finding one 😅
Should be pretty easy to fix though.


License file is not included in the react and react-dom NPM packages

Please add these files with full license text to the NPM distribution packages. Unfortunately, from the legal standpoint, simply specifying the name of the license is not enough, because it's unclear where to get the EXACT (legally binding) text of that license. This is a major roadblock on our way to using the module, seriously.
Thanks a lot for the great code, and thanks in advance for fixing this blocker.

As usual, a PR is welcome.

I see now @Pashokus is a troll, sending this issue to many other repos.