Upload to coveralls.io only if github.repository == 'HazyResearch/fonduer'

This will close #391 .

Please see the step is skipped on a forked repository.
https://github.com/HiromuHota/fonduer/actions/runs/75405791.

This PR fails.
https://github.com/HazyResearch/fonduer/actions/runs/75436780

coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

The "Upload to coveralls.io" step runs because this PR is against 'HazyResearch/fonduer'
But, this PR fails because a token for coveralls is not available.

@lukehsiao any idea?

Not sure. The configuration sets the env var, and the secret is in the repo:

This might be due to the secret not being passed correctly?
https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets

Yes, it is clearly mentioned in https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#using-encrypted-secrets-in-a-workflow that

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Or maybe "Coveralls GitHub Action" works better.
https://github.com/marketplace/actions/coveralls-github-action

"Coveralls GitHub Action" only supports LCOV file (lcov.info), while coverage.py, used by Fonduer, generates .coverage.
https://github.com/coverallsapp/github-action/issues/30

Hmmm, I'm fine with switching to codecov, there is no particular reason we are using coveralls.

I think codecov is easier solution here.

Let's fix this now. We can discuss if we should switch to codecov in a different issue/pr.

Before doing the switch give that one a try, I've just built a coveralls action that works for pull requests https://github.com/marketplace/actions/coveralls-python


Does not work in Laravel 5.4

The binding of the router in the serviceprovider does not work in Laravel 5.4

in /vendor/lanin/laravel-hashids/src/UseHashidsRouter change to:
    /**
     * Get the route dispatcher callback.
     *
     * @return \Closure
     */
    protected function dispatchToRouter()
    {
        $this->router = $this->app['router'];

        $this->router->middlewarePriority = $this->middlewarePriority;

        foreach ($this->middlewareGroups as $key => $middleware) {
            $this->router->middlewareGroup($key, $middleware);
        }

        foreach ($this->routeMiddleware as $key => $middleware) {
            $this->router->middleware($key, $middleware);
        }

        return parent::dispatchToRouter();
    }

in \vendor\lanin\laravel-hashids\src\HashidsServiceProvider.php change to:
       /**
	 * Register the router instance.
	 *
	 * @return void
	 */
	protected function registerRouter()
	{
		$this->app->singleton('router', function ($app) {
            return new Router($app['events'], $app);
        });
	}

        /**
	 * Register new UrlGenerator.
	 */
	protected function registerUrlGenerator()
	{
		$this->app->singleton('url', function ($app) {
			$routes = $app['router']->getRoutes();

			// The URL generator needs the route collection that exists on the router.
			// Keep in mind this is an object, so we're passing by references here
			// and all the registered routes will be available to the generator.
			$app->instance('routes', $routes);

			$url = new UrlGenerator(
				$routes, $app->rebinding(
					'request', $this->requestRebinder()
				)
			);

			$url->setSessionResolver(function () {
				return $this->app['session'];
			});

			// If the route collection is "rebound", for example, when the routes stay
			// cached for the application, we will need to rebind the routes on the
			// URL generator instance so it has the latest version of the routes.
			$app->rebinding('routes', function ($app, $routes) {
				$app['url']->setRoutes($routes);
			});

			return $url;
		});
	}

Should fix it I think


reloaded after waiting running job is done.

Hi,
When I save file, watch waits till the process exits and then reload.
It reloaded immediately before, but after updating this problem has began showing.
code I use to reload is cargo watch -x run -i files
Thank you.

Seems to be needed more investigation, Sorry


Gremlin traversal ctor

need to verify that functional tests (specifically flow tests) pass

ok to test

add to whitelist

Failed due to the below, @safchain I need your assistance to understand why:
?   	github.com/skydive-project/skydive/version	[no test files]
Error: exit status 2
make: *** [Makefile:245: test] Error 2
go2xunit -input $WORKSPACE/unit-tests.log -output $WORKSPACE/tests.xml
error: 129: package build failed: FAIL	github.com/skydive-project/skydive/gremlin/traversal [build failed]
sed -i 's/\x1b\[[0-9;]*m//g' $WORKSPACE/tests.xml
Recording test results
Build step 'Publish JUnit test result report' changed build result to UNSTABLE
[Cobertura] Publishing Cobertura coverage report...

[Cobertura] No coverage results were found using the pattern 'cover.out.xml' relative to '/var/lib/jenkins/workspace/skydive-unit-tests'.  Did you enter a pattern relative to the correct directory?  Did you generate the XML report(s) for Cobertura?

[Cobertura] Skipped cobertura reports.

Setting status of 282b34bd36c0f2ae7a1b1be7d7a69c11712ba683 to ERROR with url http://ci.skydive.network:8080/job/skydive-unit-tests/55/ and message: 'Build finished. '
Using context: skydive-unit-tests
Setting status of 282b34bd36c0f2ae7a1b1be7d7a69c11712ba683 to ERROR with url http://ci-logs.skydive.network/skydive-unit-tests/builds/55/log.html and message: ' '
Using context: skydive-unit-tests
Finished: UNSTABLE

reading the logs I can see that there are explicit syntax error.

you can run them locally. make test

@hunchback
# github.com/skydive-project/skydive/gremlin/traversal
gremlin/traversal/metrics_test.go:50:33: too many arguments in call to NewMetricsTraversalStep
	have (*traversal.GraphTraversal, map[string][]common.Metric, nil)
	want (*traversal.GraphTraversal, map[string][]common.Metric)
gremlin/traversal/metrics_test.go:54:32: too many arguments in call to NewMetricsTraversalStep
	have (*traversal.GraphTraversal, map[string][]common.Metric, nil)
	want (*traversal.GraphTraversal, map[string][]common.Metric)
gremlin/traversal/metrics_test.go:618:33: too many arguments in call to NewMetricsTraversalStep
	have (*traversal.GraphTraversal, map[string][]common.Metric, nil)
	want (*traversal.GraphTraversal, map[string][]common.Metric)

and:
FAIL	github.com/skydive-project/skydive/gremlin/traversal [build failed]


Close DBtranaction resource wherever it has been used

We will need to close the Dbtransaction resource wherever it has been used in the project as per advice from pull request #27

Closed by merging issue #33


WIP master <- develop

Merge the develop branch into the master branch and deploy

Build log
Preview build with this PR (38e02a9bdc89b6803c6e38e7d89a906309664c10)

more info:cloud: Storage Free space   2.92 GiB    19.50%:open_file_folder: 61.47 MiB  CI_WORK/GitHubActions/roki-web

Build log
Preview build with this PR (a42d4e4e26781d759d07c0d607c2c7ac3332072c)

more info:cloud: Storage Free space   2.76 GiB    18.37%:open_file_folder: 61.47 MiB  CI_WORK/GitHubActions/roki-web


Can't run via mono on Ubuntu Mint

I followed the Linux installation instructions, but when I actually try to run the program, I get this:
mono MultiMiner-4.0.4.exe
Cannot open assembly 'MultiMiner-4.0.4.exe': File does not contain a valid CIL image.

I downloaded the MultiMiner-4.0.4.exe file from the latest release, I believe that was the correct one.
My Linux distro info:
DISTRIB_ID=LinuxMint
DISTRIB_RELEASE=18.1
DISTRIB_CODENAME=serena
DISTRIB_DESCRIPTION="Linux Mint 18.1 Serena"
NAME="Linux Mint"
VERSION="18.1 (Serena)"
ID=linuxmint
ID_LIKE=ubuntu
PRETTY_NAME="Linux Mint 18.1"
VERSION_ID="18.1"
HOME_URL="http://www.linuxmint.com/"
SUPPORT_URL="http://forums.linuxmint.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/linuxmint/"
VERSION_CODENAME=serena
UBUNTU_CODENAME=xenial

Nevermind, I was supposed to download the archive and run the MultiMiner-4.0.4.exe inside that one. Sorry for the unneeded issue!


Block public access to S3 state buckets

Summary
Currently, when Terraspace creates an S3 bucket to hold state files, it does not configure the bucket to block all public access.

The state files are still protected, because they can only be read by owner.  Nevertheless definitively blocking all public access to the bucket is strongly suggested for defense in depth.
Motivation
This feature improves Terraspace security.
Guide-level explanation
When Terraspace automatically creates an S3 bucket for remote state, it ensures that bucket is protected against public access.
Reference-level explanation
This proposal adds a Public Access Block to the S3 bucket configuration.

Terraform aws_s3_bucket_public_access_block documentation
CloudFormation PublicAccessBlockConfiguration documentation
"Configuring block public access settings for your S3 buckets" AWS documentation

Drawbacks
There is no drawback.
Unresolved Questions
No unresolved questions.

@tongueroo If you can point me in the right direction, I will submit a PR to implement this feature request.  Where in the code does it create the S3 state bucket?

Looks like the state bucket is created by the AWS plugin over in this repo: https://github.com/boltops-tools/terraspace_plugin_aws

Yup. You found it. 👍 Looked and it's actually 2 repos that would have to be updated.

https://github.com/boltops-tools/terraspace_plugin_aws
https://github.com/boltops-tools/s3-secure

Code trace:
terraspace_plugin_aws:

Where the secure settings are applied https://github.com/boltops-tools/terraspace_plugin_aws/blob/master/lib/terraspace_plugin_aws/interfaces/backend/bucket.rb#L13
The secure method calls another lib https://github.com/boltops-tools/terraspace_plugin_aws/blob/master/lib/terraspace_plugin_aws/interfaces/backend/bucket/secure.rb

That other lib is s3_secure:

So would add class and method. Something like PublicAccess#block to https://github.com/boltops-tools/s3-secure/tree/master/lib/s3_secure
Then the terraspace_plugin_aws would be able to call that new class and method.

It's a few steps. No sweat either way of course. 😄  Appreciate it if you get to it. Otherwise, hope to get to it in time. ⏱ Thanks!

Docs: https://terraspace.cloud/docs/plugins/aws/

Awesome!
On Wed, Dec 29, 2021, 22:20 Tung Nguyen @.***> wrote:

Closed #161 https://github.com/boltops-tools/terraspace/issues/161 via
boltops-tools/terraspace_plugin_aws#15
https://github.com/boltops-tools/terraspace_plugin_aws/pull/15.
—
Reply to this email directly, view it on GitHub
https://github.com/boltops-tools/terraspace/issues/161#event-5826601489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANTAWSQ737S4PHKY6NYFLUTPFZFANCNFSM5JW3BU3A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Errors in README.md in the src directory

Filenames in usage of download_data.py and generate_data.py do not have valid file extensions.

Parameter names are wrong in usage for download_data.py. Only inputs should be the url and complete path of the csv which we want to write.

There is no script called generate_data.py, it should instead be split_train_test.py

Usage for generate_figs.py does not have ‘python’ command

Typo in usage of fit_cancer_prediction.py

Moreover, some libraries are needed to be added in the yml file.

Done!


Content views edit

there is a bug with the "show full content" button. if you activate the edit mode, the whole content is visible in the code editor, but if you switch between the tab (response, request,...) then the redux state will change to showFullContent=false.
the second commit removes the content  view selector, because if you modify a content without saving it you cannot use the server side content views correctly.

Awesome, this looks great. 👍


Using Kubernetes to orchestrate arbitrary infrastructure

@qcaas-nhs-sjt , your comment about k8s being an orchestration platform and containers are just one of many things it can orchestrate raises all kinds of interesting possibilities.
I have been looking at https://kubevirt.io/ as an example of using k8s to control VMs for instance.
When combined with JupyterHub's architecture, this may be one way to deliver:
a. A secure VDI wrapper solution to JupyterHub's browser-based tools as discussed here - https://discourse.jupyter.org/t/run-linux-desktop-apps-in-mybinder-org-your-jupyterhub/11964/11
b. Provision Windows VMs on-demand using JupyterHub as described here by @manics - https://github.com/manics/jupyterhub-virtualdesktopspawner and https://github.com/manics/jupyter-guacamole
If this proves to be a good solution, it can potentially be a replacement for AVD and we can provide access to any private resources (e.g OHDSI, DataSHIELD, etc.) through this.
Can we please add this to our roadmap and discuss when we meet next?
It will be good to work with @manics who knows JupyterHub really well and is part of the UK society for research software engineering.
@m1p1h , if you are not already a member you should sign up - https://society-rse.org/

This looks very interesting.
We are using JupyterHub's Z2JH at the core of our analytics environment and we have battle-tested it at LTH for a few years now.
From a user experience POV, it will be good to keep all the functionality of Z2JH (see architecture) and use a modified KubeSpawner to spawn arbitrary resources - example of provisioning EC2 instance here. KubeSpawner in turn uses the kubernetes API anyway.
@manics, it will be good to get your thoughts on this.

This sounds cool, and should be doable! I'm very keen to see a production Kubernetes hosted TRE, especially one that can provide Windows desktops. The idea of JupyterHub as a generic resource manager has come up in HPC discussions before. Happy to chat if you want!
I've tried KubeVirt before but couldn't get it to work. I thought it was an abstraction over public cloud APIs for managing VMs, but it actually uses KVM so if you're running it on the cloud you end up with a nested VM.
Crossplane is worth a look if you haven't seen it before https://docs.crossplane.io/latest/getting-started/introduction/
I discoveted it over the holidays, it provides K8s custom resource definitions for many public cloud resources- superficially souds similar to the custom operators @qcaas-nhs-sjt mentioned except that someone else has done the work :smile:
On the plus side it's an official CNCF project https://www.cncf.io/projects/crossplane/, on the minus side it's in incubation so there's not yet a guarantee that it'll exist long term. It seems to be an autogenerated wrapper around some the cloud Terraform providers, so has pretty comprehensive coverage of the main cloud resources.
The big advantage of using CRDs is that KubeSpawner needs to be extended to handle arbitrary K8s manifests with some templating, whereas procedural code to bring up an instance and configure it's networking has to be rewritten for every cloud and resource type. Perhaps there's even a case to be made for making KubeSpawner use K8s manifest templates only even for standard pod and volume definitions, so it almost becomes "HelmSpawner" but with Jinja2 style templating?

@manics good catch, I was not aware of crossplane, the concept looks relatively sound, though my only worry is that they use a similar solution in terraform for talking to the azurerm API's and despite this terraform has difficulties keeping up with all the new functionalities & parameters. As crossplane is trying to be all things to all people it will require a lot of maintenance from the community to keep on top the changes. Still that said I think a proof of concept would be valuable in this instance.
We also need to consider the security aspects of such a controller, if not applied carefully, such a controller could be misused to create exploits which could leave us exposed. We cannot rely on the IAM security of azure alone to manage this because of the level of which it would run. For example it is likely that our solution will have to provision a virtual machine, and extensions to configure tools or even just to allow the virtual machine to join an active directory domain, etc. IAM will only know that it is creating an extension, it will not really care about what that extension is doing. If such an extension were to be defined that would install malicious code onto existing servers then all of the information on these servers could be transferred out through a back door. We would therefore need to create a very strict set of IAM controls, azure policies, and resource based kubernetes RBAC. We'd also likely want to split out the workers for this from the rest of the cluster so that they would have to run on their own nodes with their own special sets of permissions so that other resources couldn't access these.
On the flip side our own custom controllers would allow us to be a lot more targetted about which resource types we were offering up and to focus in on the functionality that we're actually using which would be a lot less up-keep and wouldn't then be so reliant on this existing community. Regarding the time taken to write such controllers, I'm not overly worried I've written many such controllers in the past and once you've got a working template it doesn't tend to take much to build them, so the main part of it will be building up the base template. From a security aspect, as the custom controllers would only be able to do the things we've programmed the risk is much lower. (Though obviously we'll still need appropriate RBAC)
Regardless of whether we can use crossplane or have to write our own controllers I think that the truly time consuming part will be to define a truly secure environment and all the components & extensions that are needed to make this work properly and to get the security elements in place that allow us to provision it with minimal access rights. There are many different moving parts that need to be considered, not least of all the challenges of building such a thing inside of an NHS environment which has unique challenges

All good points! I'm approaching this from the perspective of wanting the flexibility to extend a TRE to encompass arbitrary approved cloud services, where it's helpful to not need to deploy code for every change. Regardless, if all cloud resources are managed via CRDs the changes to KubeSpawner would be the same.

Linking to lsc-sde/lsc-sde#37

@m1p1h bringing this discussion to your attention. Especially the discussion regarding using Kubernetes to orchestrate everything vs doing this through JupyterHub and KubeSpawner.
https://github.com/kubevirt/kubevirt looks really interesting. A full VM-based environment will be useful for some of the more complex use cases that require tools that are not easily containerised (yet).
Related to #57.
@qcaas-nhs-sjt shall we meet with @manics for a brainstorming session and see if we can come up with a design that we could possibly work together on.

@m1p1h bringing this discussion to your attention. Especially the discussion regarding using Kubernetes to orchestrate everything vs doing this through JupyterHub and KubeSpawner.
https://github.com/kubevirt/kubevirt looks really interesting. A full VM-based environment will be useful for some of the more complex use cases that require tools that are not easily containerised (yet).
Related to #57.
@qcaas-nhs-sjt shall we meet with @manics for a brainstorming session and see if we can come up with a design that we could possibly work together on.

Yeah I think that would be useful, however I'm not convinced that kubevirt is the right solution, as I understand it, it uses nested virtualization to provision the virtual machines, this adds many complexities I think can be avoided and it means that network access control becomes very difficult, not to mention that a large portion of the azure estate does not allow nested virtualization.
The cross-plane idea might be a better one, or even just building custom operators for each aspect of the system. This would allow us to not only create the VM but the network it sits upon within the azure/aws/gcp estate, we would have custom operators for each provider to convert our workspace definitions into the relevant resources in crossplane to facilitate the system.
In my mind this would work in a similar way to azure's TRE, so the workspace definition would be extended to include details needed to spin up a virtual network and virtual machines. The operator would detect this and convert this definition into the CRD definitions in crossplane, crossplane would implement these.
flowchart TB
AWMS[Workspace Management Portal] --> |1. Creates workspace |API((k8s API))
--> |2. Triggers Operator Action| AWMSO[AWMS-to-Crossplane-Azure Operator]  --> |3. Writes converted crossplane definition| API
--> |4. Triggers Operator Action| Crossplane[Crossplane Operator]
--> |5. Creates/updates the resources based on the crossplane definition| Azure[Azure Graph API]
Crossplane --> |6. Updates status of crossplane resource|API

As this is a microservice architecture you could swap out the Azure AWMS-to-crossplane operator for another operator for another cloud provider such as AWS:
flowchart TB
AWMS[Workspace Management Portal] --> |1. Creates workspace |API((k8s API))
--> |2. Triggers Operator Action| AWMSO[AWMS-to-Crossplane-AWS Operator]  --> |3. Writes converted crossplane definition| API
--> |4. Triggers Operator Action| Crossplane[Crossplane Operator]
--> |5. Creates/updates the resources based on the crossplane definition| AWS[AWS API]
Crossplane --> |6. Updates status of crossplane resource|API

or GCP:
flowchart TB
AWMS[Workspace Management Portal] --> |1. Creates workspace |API((k8s API))
--> |2. Triggers Operator Action| AWMSO[AWMS-to-Crossplane-GCP Operator]  --> |3. Writes converted crossplane definition| API
--> |4. Triggers Operator Action| Crossplane[Crossplane Operator]
--> |5. Creates/updates the resources based on the crossplane definition| GCP[GCP API]
Crossplane --> |6. Updates status of crossplane resource|API

or even kubevirt:
flowchart TB
AWMS[Workspace Management Portal] --> |1. Creates workspace |API((k8s API))
--> |2. Triggers Operator Action| AWMSO[AWMS-to-KubeVirt Operator]  --> |3. Writes converted crossplane definition| API
--> |4. Triggers Operator Action| KubeVirt[KubeVirt Operator] --> |5. Updates status of crossplane resource|API

This of course all assumes that CrossPlane works how we need it to, I would recommend that we do a proof-of-concept to prove that this works in the way we would like. Worst case scenario we cut out the middleman and have our operators talk directly to azure/aws/gcp

flowchart TB
AWMS[Workspace Management Portal] --> |1. Creates workspace |API((k8s API))
--> |2. Triggers Operator Action| AWMSO[Azure AWMS Operator]  --> |3. Creates required resources in azure| Azure[Azure Graph API]
AWMSO --> |4. Updates status of crossplane resource|API

Happy to chat! I can't do Fridays and I've got limited availability this/next week but should be able to fit something in.
My thoughts on Kubevirt are similar to @qcaas-nhs-sjt
though I haven't looked at it recently.
It could be worth looking at https://github.com/SwissDataScienceCenter/amalthea for ideas. It's a standalone project to manage jupyter-servers using CRDs.

@manics sounds good
Please could you drop me an email on<EMAIL_ADDRESS>with your availability and we will try to get something setup
Many thanks


US ID4: As a player, I want to add other players to my friends list, such that I can directly check out their statistics.

[ ] The friend list can be accessed and edited (remove or add friends).

[ ] By typing in a search field, I can search for other players.

[ ] With one click I can add a player to my friends list.

[ ] On the friends list page, I can see all players added to my friends list.

[ ] On the friends list page, I can click on a certain player and get redirected to their profile page.

[ ] A scoreboard for the player’s friends' points is displayed    .

proposed additional tasks:
Backend:
the server jeeps track of all players and allows searching by name/id
A firendlist can be edited
what's up with the scoreboard of the firend? Does it display for everyone? Wouldn't it make more sense if you could just visit the profile?

Friendlist hemmer jo killed, drum würdi die US au schlüsse als not planned


Stop hiding exception raised by composer

Previously, errors from Composer were suppressed, which made it difficult for users to understand what caused the issue. With this change, we will now display all the errors without hiding them. This allows users to identify and investigate potential problems more easily.

I was surprised to see you went after this by raising rather than logging the error...
Did you see my comment in https://github.com/dependabot/dependabot-core/pull/6290#issuecomment-1535218293 ?

The skeleton of where you're going on this looks great! Just need a few details tweaked and then this should be good to go...


Fix proof checker when team link map is stale

Part two, https://github.com/keybase/client/pull/8499 only fixed some cases.
The deal is that the linkMap attached to proofs is put created when only partway through the team chain. So it's missing newer seqnos.
For example:
DA and DB are devices for U, DB will be revoked. T1 is team T's seqno 1.
Events:

Create (T1) (by DA)
Add-member (T2) (by DB)
Add-member (T3) (by DA)
Revoke DB (U2)

When checking there's a proof requirement that: T2 happened before U2
At the hashmeta when U2 happened, T was at T3. The problem was that the linkmap for this proof only went up to T2 because that's when it was added. Even though at the point when the proof checker is running, T3 has been processed. The fix is to give the checker the latest linkmap right before it checks.
Test coming up.

added test


Y-Axis

Is it possible to set the Y-Axis scale? Would be nice.

I haven’t thought about that.
What would be the usage scenario?

For instance, say I'm logging a temperature sensor:

Everything happens on the top of the screen.
Now if I change https://github.com/yhur/arduplot/blob/764e67a893401835fd53c481c18336e966a339fc/src/arduplot/plotserialdata.py#L100 to plt.axis([0, width, 23, 26]) it becomes a lot more useful:

Obviously the min and max values would have to be configurable using command line options, just like the width parameter.

Awesome!
The added benefit is that if you don't supply ymin and ymax, it autoscales even nicer then it did before.


Is this repo still a mirror?

The link in the description leads to a blank page.

It is a mirror, but the real repository is private.


Compilation error: Timezone.h: No such file or directory

Hi,
I wanted to built the clock with this code, but I run in to a error "Compilation error: Timezone.h: No such file or directory". Should I just create this file? Should I add something to it? Or should I just "comment" this line out of the code?
Thanks for any response,
M.

I am so so sorry. I forgot to install the libreries. Now everything works fine without any problem.


Correct PyCon date to be today

Did you mean "RocPy"?

No.

I think you're mistaken, PyCon was in April.

@Nolski please check http://us.pycon.org/2015/schedule for PyCon's schedule.


Attendance Feature Parity

[ ] Eboard Members may take attendance
[ ] Members may view their attendance

Is this considered feature parity? I don't think members can view rich attendance reports now.

I definitely think we should still do it.

It's on your home page

Whoops. Got it confused with something else then.

I guess I'll start with this page.

Did a quick mockup of the attendance form: https://csh.mybalsamiq.com/projects/csh-eval/Attendance Form

I'm not sure I like the scrollable list of attendees. Maybe move the submit/clear buttons and attendance count above the list?
Also, I'd like to have the quorum indicated somehow. Whatever calls you need to do that just let us know.

Also what's the Add another meeting... link do?

how slow would autocomplete be if it required you to get a list of all members?

Would the full list be provided by the template at first load?

@harlanhaskins that would probably make sense

Autocomplete would be a good use case for the API call that just returns a list of all members with their username and common name.

And the Add another meeting... would be useful for double meetings that have the same attendees (R&D and Imps is a classic).

Buttons can be moved above the attendance list, and list can be made not scrollable. No problem.
@sdemos is correct about the "Add Another Meeting..." link.
The autocomplete in WebDrink (admin user search) is via AJAX, only slow on the first letter (larger result). Might as well pre-load it for any page that will definitely need it. We can use the native HTML5  element (no Safari support), or something like jQuery UI autocomplete.
Speaking of plugins, the datepicker will use something like Bootstrap daterangepicker.

@sdemos I think we will want that API call, but if we know we're going to need the info there's no sense in waiting for a call
I think we need to figure out approving attendance at some point in the near future. It would be nice if anyone could take attendance and a director would just need to approve it


update distribution dependency

Signed-off-by: David Lawrence<EMAIL_ADDRESS>(github: endophage)

I think this may need the registry/client package vendor-ed in too - right now I think we just have client/auth and other subpackages

Other than the above, LGTM!


TTS Not Working with Fatewalker Update

I seem to remember having this issue with another FFXIV patch or two but my TTS alerts from the Cactbot don't seem to work and I don't think I've changed anything with my ACT settings or plugins. Triggernometry and Custom Triggers' TTS plays but Cactbot's do not.
 (Source: , Line: 0)
[12/6/2021 3:50:18 PM] Info: Found enmity memory for 6.0.

Please let me know if there's any additional information I can provide. It's turned on, and was turned on before this update, but (agian), I'm having deja vu and can't remember how I might've fixed this before. I know that I've tried going to my ACT configuration and tried with or without "Use ACT for text-to-speech" and, while using ACT for TTS breaks Triggernometry for me, it doesn't fix Cactbot. Likewise, I've considered Windows API vs WMP API but seem to remember a reason I switched to Windows API, this may be how I fixed this issue before or it may have had a detrimental effect on Triggernometry's functioning.

I have tried freshly installing Cactbot with no luck, unfortunately.
Before and after my new install, I tried adding the test.html and checking "/echo tts:test" and it didn't work either time.


Reliably throw an UnsupportedOperationException for known-incorrect erasure.

The CI doesn't want to start. :confused:


Extension does not work after initial installation fails with

On initial setup the extension fails (from an exported working build) based on ed5e573cc293df77bc4768aff36212a34aa5eb44

https://developer.chrome.com/docs/extensions/reference/scripting/#runtime-functions
it expect func as argument
this is where it happens in our code base:
https://github.com/inblockio/VerifyPage/blob/ed5e573cc293df77bc4768aff36212a34aa5eb44/src/verifier.ts#L109
Please provide more information, currently we can't reproduce.
Please provide OS and Browser names/versions.

He mentioned to use brave.

Attempting to repro. Flying blind without more debugging info.

Chromium changed from function to func last April with https://github.com/chromium/chromium/commit/1f6eb205f66d2d75b61490a2f5b74fb15c4e2825. The only public instance I can see of someone hitting this occurs in https://github.com/GoogleChrome/developer.chrome.com/issues/839 where the user hit an edge case using Brave 1.23.75 (Chromium: 90.0.4430.93) and Chrome 90.0.4430.93 and 91.0.4472.77. It may be possible to add backwards compatibility by changing func to function, though the later is a reserved word, and Chrome source code suggests function will be removed in the future. My suggestion is to ask the user to update their browser or, at a minimum, provide additional debugging information (OS, OS vers, Brower, Browser version).

Chromium changed from function to func last April with https://github.com/chromium/chromium/commit/1f6eb205f66d2d75b61490a2f5b74fb15c4e2825. The only public instance I can see of someone hitting this occurs in https://github.com/GoogleChrome/developer.chrome.com/issues/839 where the user hit an edge case using Brave 1.23.75 (Chromium: 90.0.4430.93) and Chrome 90.0.4430.93 and 91.0.4472.77.
It may be possible to add backwards compatibility by changing func to function, though the later is a reserved word, and Chrome source code suggests function will be removed in the future. My suggestion is to ask the user to update their browser or, at a minimum, provide additional debugging information (OS, OS vers, Brower, Browser version).

Chromium stable release on Debian...


Concerns about rancher cluster high availability

Before creating this issue I've read an Google Group topic that didn't cleared out my doubts.
I've tried rancher a couple of months ago but it seems it had a lot of improvements since then that made me wondering if we could use it...
I remember that my first concern was related with cluster agents high availability. Since agents are working on top of an URL for cluster joining, does the cluster goes faulty if node who has rancher/server running goes down and for some reason they need to reboot?
I've read somewhere that you also have some kind of internal service discovery, is it also scalable?

If you have a single rancher/server and it goes down then you can no longer manage the hosts and containers, but the existing containers on those hosts and the overlay network between them continue working.  Things like rescheduling containers when a host fails will not happen while the server is gone.
It is possible to do a multi-nose setup.  We plan to make this easier, and eventually fully managed/automatic, but it's possible today: http://docs.rancher.com/rancher/installing-rancher/installing-server/multi-nodes/
Service discovery is a DNS server that runs in the Network Agent on each host and answers queries from the containers on that host using a local copy of the answers (or a recursive server if not found).  rancher/server pushes updates to the answers down to the agents but is not involved in answering a particular query.

I am still having the "unregister_netdevice: waiting for lo to become free. Usage count = 1" issue when I stop/remove/re-add a Rancher agent. And the only solution is to clean the iptables and reboot the machine ;-(
Containers are still working hopefully, but docker is not responding.

You really should put a big confirm popup when user wants to restart "Network agent" container ;-)

@ebuildy this is a bug in the Linux kernel that Rancher seems to easily trigger.  If it doesn't get fixed soon in Linux upstream we will start investigating a work around.  Sorry about that.  What we've seen is it's better to stop the agent and then delete it.  Don't do both at the same time.

More context https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1403152

Just by curiosity, how Rancher triggers this bug?
Except that, Rancher is really a good product, I love the scheduler with services, the fact that we can open logs/console for any container in a few clicks and the help of the team ... we should open an issue "Thanks you guys" ;-)

I honestly don't really know why Rancher triggers it as I don't fully understand what is the root issue in the kernel.  What we suspect is just that the network agent takes advantage of a heavy amount of Linux networking features that we do more than the normal container.  For example creating interfaces, arp proxying, iptables, ebtables, and IPSec.

@vincent99 thanks for your answer!
Does rancher/agent retries connection to rancher/server after a failure attempt?

Yes it should try to reconnect every 5 seconds or so.

@cusspvz Please re-open if you have more questions, but it looks as if they have been answered.


 key not work with Lazygit inside Neovim

I'm using 0.4.3 branch .
Currently, Lazygit has  key to exit/return inside itself.
But if I use it inside neovim, seems that  key will switch neovim to  mode, not returning for Lazygit.
Is there any solution?
Thanks for your work!!

Thanks for using the plugin! I'm able to use ESC to in lazygit in neovim though, and it exits lazygit as expected. Do you have a tnoremap somewhere in your init.vim that maps escape to return to normal mode?

For what it is worth, I have something like the following in my init.vim:
function s:AddTerminalNavigation()

    echom &filetype
    if &filetype ==# ''
        tnoremap <buffer> <silent> <c-h> <c-\><c-n>:TmuxNavigateLeft<cr>
        tnoremap <buffer> <silent> <c-j> <c-\><c-n>:TmuxNavigateDown<cr>
        tnoremap <buffer> <silent> <c-k> <c-\><c-n>:TmuxNavigateUp<cr>
        tnoremap <buffer> <silent> <c-l> <c-\><c-n>:TmuxNavigateRight<cr>
        tnoremap <Esc> <C-\><C-n>
        tnoremap <C-v><Esc> <Esc>
    endif

endfunction

augroup TerminalNavigation
    autocmd!
    autocmd TermEnter * call s:AddTerminalNavigation()
augroup END

This adds the above keybindings to a terminal buffer when you open it, if the filetype is an empty string. Most vim plugin terminal buffers that do something specific set the name of the terminal buffer to be the name of the terminal application itself. lazygit.vim does this as well. So this won't interfere with with any similar keybindings by lazygit.

You can also add the following to the if block
        tnoremap <Esc> <C-\><C-n>
        tnoremap <C-v><Esc> <Esc>

I go back and forth on whether I want to use <Esc> in a normal terminal.

Feel free to reopen in case if you have any questions regarding this.

@kdheepak using your suggestion make's my neovim ESC and TmuxNavigation keybinds not work when using toggleterm terminal, do you have a workaround for this? Sorry, im a noob. I understood that you have set the keybinds for terminals that don't have a filetype, but in the case of toggleterm it is the same as lazygit.

Hmm, why wouldn't it work? Using <C-\><C-n> in the terminal in neovim will go from insert to normal mode. Can you try it in a native neovim terminal? If it is a toggleterm issue, can you ask on the toggleterm repo?

@kdheepak what is the easiest way to close LazyGit window? only Esc not working.
Currently, I'm using Esc + :q

Just hitting q works for me. Does that work for you?

Awesome, thanks! maybe you could add it to Menu, cuz this option is not obvious)

Hmm I have the opposite problem, hitting escape closes lazygit so how do you go "back"? Like when you are in the commits?

Hmm I have the opposite problem, hitting escape closes lazygit so how do you go "back"? Like when you are in the commits?

Have you managed to do something for this? @amritk
I'm having the same problem and it is bugging me :rofl:

Yea I just deleted the keymap for escape in the terminal. The downside is I can't hit escape to close them anymore but oh well 🤷

I ended up doing this FWIW: https://github.com/SimonBrandner/dotfiles/commit/a29de2c408d6157760bbfe815a8b49bcb7f8f230


s3 config file not being created

Hi there.
I'm using the docker image of exhibitor, but I don't think that should matter. I've created an EC2 instance with the role to my S3 bucket.
I launch exhibitor
I set the s3 bucket
I both tried the EC2 instance with the IAM role, and also passing the creds in directly
I'm not seeing anything created in the s3 bucket.  I don't see any errors int he UI log or from the console. Where else can I debug this?
Thanks for any help.

User error, I had -c file earlier in the arg list and it took precedence over s3.


Include default http port 80 if not set in URL (URL redirection HTTP 302)

Please add support for default http port if not set in URL (especially wit URL redirection HTTP 302) :
D: Preset 1 found in .ini file
D: Remember preset 1
D: Connect to new host kiraka.akacast.akamaistream.net:80/7/285/119443/v1/gnl.akacast.akamaistream.net
D: Stop client
D: Slash in station
D: Connect to preset 1, host kiraka.akacast.akamaistream.net on port 80, extension /7/285/119443/v1/gn
D: Connected to server
D: HTTP/1.0 302 Found
D: Location: http://<IP_ADDRESS>/7/285/119443/v1/gnl.akacast.akamaistream.net/kiraka?akacasthops=1
D:
D: No data input

sorry I was wrong way. D: No data input is not coming from the missing port :-(
My stream are vbr (variable bit rate). If set the bitrate in the  "datamode == INIT" Block to 128 instead of 0 the music is played with gaps.
Line 1639 looks like:
bitrate = 192 ;                                      // Bitrate still unknown

This stream is not a standard Icecast stream.  The "icy-headers" are missing.
The software expect something like:
.
.
D: icy-br:192
D: ice-audio-info: bitrate=192
D: icy-br:192
D: icy-genre:Talk
D: icy-name:Radio 1
D: icy-pub:0
D: icy-url:http://www.radio1.nl
D: icy-metaint:16000
.
.

The stream itself sound very good. There are only a few gaps, not very often. This morning i saw on my squuezebox that the stream delivers cover/station/album art. I think that the problem. Do you have an idea how this pictures are encoded/embedded? Is there a spec available?
I only found: http://wiki.shoutcast.com/wiki/SHOUTcast_2_(Ultravox_2.1)_Protocol_Details
--> Known Message Types -->
class     type        description
....
0x4 	0x0xx 	Station logo (see 'Image Notes' for xx details)
0x4 	0x1xx 	Album art (see 'Image Notes' for xx details)
.....
Where xx is
00 	image/jpeg
01 	image/png
02 	image/bmp
03 	image/gif


Adjusting Scene Anchors Transform

Hello,
I am developing a project in Unity designed for the Meta Quest 3. My query is regarding the process of adjusting the transform properties (position, rotation, scale) of a scene model and how it translates from Unity to the Meta Quest 3 environment.
Specific Questions:
Unity Adjustments: Is it possible to adjust the scene anchors (SceneVolume, ScenePlane) transform properties within Unity which can then be loaded by the Meta Quest 3 device or is the transform adjustments only achievable during the standalone scene setup process on the Meta Quest 3 device itself? In other words, I did a manual adjustment during the setup process and now I want to fine tune the room layout more accuratly in unity. Is this possible? If not any idea for a workaround?
Thank you for your assistance.

Hi @B14ckFox,
What I understand from your question is that you do the manual room layout from the headset and then your application loads the scene. And then you want to update these scene anchors from within your application? (Let me know if I am miss understanding)
Once the elements are loaded in Unity you can interact with them however your application decides. You can apply scale, offset and rotation to the children of the anchors. I think what you would want is to load a prefab for you planes and volumes that have children that can be modified. The root will have the SceneAnchor and will always follow the detected position in the physical room, but the you can fine tune the children to better match your room.
Let me know if that helps or if there is still some questions remaining.

Hi @AlexThiv ,
Okay, I'll try to formulate it a bit differently. So, my current setup involves two different rooms. When I start the session as the host, the scene model with its spatial anchors is loaded. Then, when a client joins this session, the SceneVolume and ScenePlane from the host room are shared over the network with the client. In the current setup, when checking in the Unity Editor for the client, I can only see the scene model data from the host, but not the scene model from the client. Do you have any advice on how to also load the client's scene model with its spatial anchors in the same networking session? When both are loaded, then I can proceed with further processing as you have described.


Onscreen debugging

This branch is particularly helpful for seeing memory usage and messages on the device, both shown onscreen.

Closing this because it is so far out of date and ui has had a lot of changes.
There are some useful snippets in here for displaying memory usage and a message log if we ever need one again.


Official TCP port

We should get an official (default) port while we're at it.

I'm not sure this makes sense, as what we really need is one per application/exporter - which is thousands of ports.

There has to be a default. Traditional vendors will have one endpoint per device/service and they will need something default to sit on. Once again, think SNMP.
Plus, leaving this open will invite bikeshedding during the IETF phase.

Does anyone do SNMP over TCP?  We could just claim 161/tcp. :grin:

Old protocols always got both TCP and UDP; TCP/161 is reserved for SNMP.
These smell vacant, though:
health-polling     1161        tcp    Health Polling
health-polling     1161        udp    Health Polling
ill                1611        tcp    Inter Library Loan           [Niall_Murphy]                                        [Niall_Murphy]
ill                1611        udp    Inter Library Loan           [Niall_Murphy]                                        [Niall_Murphy]

Is it just for a listening port for receiving these messages? Do we need diff ports for different protocols? (Text vs shrug?)

@manolama This would be the polling port, but could also be a receiving port as well.  No need for more than one, as we already use Content negotiation for deciding on protocol encoding.  With text being the default.

The only reason for more than one port may be TLS.

@manolama This would be the polling port, but could also be a receiving port as well. No need for more than one, as we already use Content negotiation for deciding on protocol encoding. With text being the default.

Are we also including the protocol in this standard? Is it wise to force the overhead of HTTP?

The format would be agnostic, however I think it'd be wise to include a recommendation to provide a HTTP endpoint.

I vote also for a default port. It will make pollers configuration easier since application don't have to specify a port if they are using the default. Within the same port it will not be hard to negotiate protocol between HTTP1 and 2 or content format.

Additional thing around HTTP: We need to select a Content-Type


removed advanced_topics folder and updated link pointers

Resolves #3078.

Codecov Report

Merging #3079 (ccd159f) into main (e9edd2a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head ccd159f differs from pull request most recent head 8bb9136. Consider uploading reports for the commit 8bb9136 to get more accurate results

@@           Coverage Diff           @@
##             main    #3079   +/-   ##
=======================================
  Coverage   81.92%   81.92%
=======================================
  Files          55       55
  Lines        6032     6032
=======================================
  Hits         4942     4942
  Misses       1090     1090

Impacted Files
Coverage Δ

flax/linen/recurrent.py
97.79% <ø> (ø)

flax/traverse_util.py
99.01% <ø> (ø)


Refs aren't being forwarded to the Link

Hi, superb plugin and thank you for creating it!
Just a small issue that should be fairly easy to fix but:

There's currently no support for forwardRef making the Link component unusable in certain setups

I am using this awesome plugin alongside the "material-ui" but this issue is causing lots of warnings. there is a very simple fix for this and I try to make a PR for this
sample warning from "material-ui":

Warning: Failed prop type: Invalid prop component supplied to ForwardRef(ButtonBase). Expected an element type that can hold a ref. Did you accidentally provide a plain function component instead? For more information see https://material-ui.com/r/caveat-with-refs-guide


Support for a initial delay

Maybe we can have a initial delay method to load an Ad.
For example:
If initial delay set to 1 day, do not load or show any Ad on the first day of app install..
Let the user explore the app a bit.

Added in ce58f64


Handle FinalizationRegistry

This snapshots the ambient AC state when calling fr.register(), to be restored when invoking the FR's callback on that registered cell.

I also removed our changes of HostMakeJobCallback. First, because it felt awkward to refer to the JobCallback's [[AsyncContextSnapshot]] inside NewPromiseReactionJob and NewPromiseResolveThenableJob. And second, because it actually causes a memory leak with FinalizationRegistry.
The FR calls HostMakeJobCallback (causing it to snapshot) during its constructor to prepare the callback to be used for jobs later on. But that snapshot will never be used, we'll only use the registration time snapshot. So I had to move the snapshotting closer into PerformPromiseThen.

I thought this PR was meant to fix the regression introduced in #41. However, before #41, FinalizationRegistry callbacks were called with the FR construction context, rather than with the context at the time the register method was called. Have we actually discussed which should be the right behavior?
This is actually similar to some events in the web:
const asyncVar = new AsyncContext.Variable();

const image = document.getElementById("image");  // <img id="image">

asyncVar.run("foo", () => {
  image.addEventListener("load", () => {
    console.log(asyncVar.get());
  });
});

asyncVar.run("bar", () => {
  image.src = "./some/image.jpg";
});

Here we have a registration-time context (the registration of the load event, or the FR construction with a callback), and a separate context (the call to register, or the setting of the image's src) which asynchronously triggers the call to the registered callback.
It's not clear to me which of the two is the right behavior, and it clearly ties into the behavior of events in the HTML integration.

I remember this being discussed in Matrix. I believe register time is the correct one. Furthermore it's easy to do FR construction time by simply wrapping the callback.

I remember this being discussed in Matrix. I believe register time is the correct one. Furthermore it's easy to do FR construction time by simply wrapping the callback.

I think I misunderstood you when this was discussed, so I didn't realize there was a difference there wrt the previous behavior.
By the way, the terminology gets confusing here because for events, "registration-time" is the time at which you register the event by e.g. calling addEventListener, which would be equivalent to FR construction. Calling register would be an asynchronous kind of "call-time".

Edit: the other direction is more tricky, requiring to create a snapshot on registration, pass it in the held value, and run from the snapshot in the callback.

Spec-wise it's not more tricky, since the snapshot doesn't need to be held in the FR's [[Cells]]. In the current spec text, HostMakeJobCallback takes the snapshot and stores it alongside the callback, so it could be swapped in CleanupFinalizationRegistry() in the same way it is swapped in NewPromiseReactionJob.

By the way, the terminology gets confusing here because for events, "registration-time" is the time at which you register the event by e.g. calling addEventListener, which would be equivalent to FR construction. Calling register would be an asynchronous kind of "call-time".

Ah yes I meant FR register. It's not the same as addEventListener, but it's not equivalent an async dispatch either. IMO semantically it's more like addEventListener but with the event handler shared and added earlier.

Spec-wise it's not more tricky,

I was strictly taking the POV of the API consumer. It's harder to get the register time semantics manually.

the snapshot doesn't need to be held in the FR's [[Cells]]

I'm confused, if we want FR register time, doesn't the spec need to store the Snapshot in each cell?
I probably should read the PR

the snapshot doesn't need to be held in the FR's [[Cells]]

I'm confused, if we want FR register time, doesn't the spec need to store the Snapshot in each cell? I probably should read the PR

That is right, but I thought by "the other direction" you meant construction time.

I'd rather use the construction-time AsyncContext snapshot here, just for simplicity. Are there any cases that we're aware of where it's important to have the semantics described in this PR?

I think using construction-time is the incorrect choice, because observers like this (and DOM observers like MutationObserver) should be registered in the module scope. If it's in the module scope, the ambient context is just empty, and that's not useful.
I think choosing the context during the call to register is directly analogous to choosing the context when you attach an event listener. Andreu had brought up during last meeting that "registration-time" to him was when you passed the callback, but I think that's incorrect. Registration is when I invoke the method to be notified of a future event, eg fr.register() or el.addEventListener().

Not passing the callback at the time you register is a big difference from addEventListener. I think the consistency arguments can be made in both directions. Is there any actual utility to the semantics of this patch? If not, I really prefer the option which is simpler from an implementation and specification perspective. Note that it is always possible to build a wrapper around FinalizationRegistry which applies the semantics in this patch.
If we can’t come to a conclusion on this thread, let’s discuss this at the next AsyncContext meeting.

because observers like this (and DOM observers like MutationObserver) should be held in the module scope

Other observers batch things anyway (which FinalizationRegistry originally did as well, but was dropped at some point) so having a "registration time" for DOM observers is just a non-possibility anyway.

Other observers batch things anyway (which FinalizationRegistry was originally proposed to do as well, but was dropped at some point) so having a "registration time" for DOM observers is just a non-possibility anyway.

That's interesting. I've always assumed it only batched mutations per-observe calls (so two appendChilds on a subtree observe would only fire once per tick). I didn't all observe calls are invoked at once (so subtree observe and a separate attributes observe would also only fire once).
So it really isn't possible to automatically maintain "registration" time per observe call, and users that need it would have to use a separate WeakMap or something to handle Snapshots. Given that, I'm ok with either approach.

and users that need it would have to use a separate WeakMap

You don't even need to go that far.
class FinalizationRegistryWithSnapshot extends FinalizationRegistry {
  constructor(callback) {
    super(({snapshot, value}) => {
      snapshot.run(callback, value);
    })
  }
  register(target, value, token) {
    return super.register(target, {value, snapshot: new AsyncContext.Snapshot()}, token);
  }
}

In the AsyncContext call today, the group apparently decided on construction-time snapshot semantics. (Please correct me if I'm mistaken.)

You don't even need to go that far.

I was referencing MuationObserver in that comment, which would require a WeakMap to hold a #[element, registration-type] -> Snapshot mapping.

Updated to use creation-time context.


RFC: Better naming convention for interface?

Since we are using dependency injection, we mostly refer to the interface, e.g. Domain\Contracts\Repositories\TaskRepositoryInterface.
I think we can remove the Interface suffix.
Nikola Poša explained more detail in his blog: https://blog.nikolaposa.in.rs/2019/01/06/better-naming-convention/
What do you think?

Thanks for open this issue.
In my opinion i don't find elegant making alias while importing classes, here is an example:
use Domain\Interfaces\Repositories\TaskRepository as TaskRepositoryInterface;

final class TaskRepository implements TaskRepositoryInterface {}

I think we can reduce the naming, folder structure, and no need to use alias import, for example:
Contract/Interface:
namespace Domain\Contracts\Repositories;

interface TaskRepository {}

Infrastructure/Implemetations:
namespace Infrastructure\Repositories;

use Domain\Contracts\Repositories\TaskRepository;

final class DbTaskRepository implements TaskRepository {}

namespace Infrastructure\Repositories;

use Domain\Contracts\Repositories\TaskRepository;

final class RedisTaskRepository implements TaskRepository {}

...
Using in HTTP Request handlers:
namespace Application\Http\RequestHandlers;

use Domain\Contracts\Repositories\TaskRepository;

final class Index
{
    public function __invoke(TaskRepository $taskRepository): array
    {
        //
    }
}

Using in Console Commands:
namespace Application\Console\Commands;

use Domain\Contracts\Repositories\TaskRepository;

final class FooCommand
{
    public function __construct(TaskRepository $taskRepository)
    {
        // ...
    }
}

Our command, request handler refer to TaskRepository, and only the IoC Container know about DbTaskRepository.

@tuanpht question: will there be a *TaskRepository instance for e.g. Db, Redis, ...? I guess the repository shouldn't have to know how those data gets saved - or did I misunderstood something as we have not much informations yet?
BTT: I more like @nunomaduro's approach.

@tutNichts
Db, Redis... is just a example for there may be multiple implementations for an interface.
About

The repository shouldn't have to know how those data gets saved

Yes if you are talking about interface. And we also only refer to interface TaskRepository when we want using it it controller, console command, task queue... The DbTaskRepository is only used once in IoC container:
final class Repositories
{
    /**
     * Injects repositories into the container definitions.
     *
     * @return mixed[]
     */
    public function __invoke(): array
    {
        return [
            TaskRepository::class => DbTaskRepository::class,
        ];
    }
}

I mean we will use Domain\Contracts\Repositories\TaskRepositoryInterface more than Infrastructure\Persistence\Repositories\TaskRepository, so we can remove the meaningless suffix Interface :smiley:

Alright, going with your convention for now: https://github.com/narration/narration/commit/5316be6b25793d9b4079daf66b539b3e4676c202.


[common][flink] Add support for complex types in kafka debezium avro cdc action

Purpose
@umeshdangat has an outstanding PR which was updated after PR by @zhuangchong was merged. That PR: https://github.com/apache/paimon/pull/3323
The above patch allows consuming data from avro data from kafka into paimon but it doesnt support complex avro types. This PR achieves that. The original PR https://github.com/zhuangchong/flink-table-store/pull/1 was pointing to @zhuangchong branch to clearly show the changes only relavant to supporting complex avro types.
This PR fixes the failing E2E tests for PR: https://github.com/apache/paimon/pull/3931
Copying the note from PR: https://github.com/apache/paimon/pull/3931

One issue is CdcSourceRecord contains Map<String, String> thus the current somewhat tedious approach is to deserialize avro complex types into json strings and then read them back from json strings rather than changing CdcSourceRecord Map<String, Object> to support value as Object. It would be a much larger change looking at the code changes needed.
I had to update the DataField to add a method for dataFieldEqualsIgnoreId which already existing in RichEventParser. For nested RowType fields this becomes necessary (coming from nested avro records) as when a DataField.type= RowType we cannot simply do equals on all data fields as they contain Id as well and it fails the equality, although there is no schema change.

@JingsongLi @zhuangchong let us know what you think.
cc: @umeshdangat

Linked issue: close xxx

Tests

API and Format

Documentation

CC @yuzelin to take a reivew~

Thanks @AshishKhatkar


Insurgency Sandstorm Generic Module Template

Push the latest config file. Game.ini still to be built at a later date. Fixed a lot of loose code.

Completely Re-Wrote the Insurgency Sandstorm Generic Module. Added countless amount of enhancments.

Slaps roof of pull request This bad boy can fit so many rewrites in it...
I put my seal of approval on this iteration. :)

Clearly, my seal of approval means squat. Thanks @Greelan for catching the mistake!


Feature: Gesture Handling Enhancement for use with FlatList

Problem
When embedding the VideoPlayer component within a horizontally scrolling FlatList, there is a gesture conflict that arises. Specifically, when attempting to seek in the video (or volume) by dragging the seeker control left or right, the FlatList interprets this gesture as a horizontal scroll, leading to an unintended navigation away from the current video item instead of seeking within the video.
Expected Behavior
The expected behavior is that when interacting with the video player's seeking controls, the FlatList scrolling should be temporarily disabled or the gesture should be captured exclusively by the video player, allowing for a smooth seeking experience without triggering a scroll in the FlatList.
Current Workaround
Still trying to figure this out 😅
Example Snippet
Here is a simplified code snippet demonstrating the setup:
<FlatList
  data={videos}
  horizontal
  renderItem={({ item }) => (
    <View>
      <VideoPlayer
        source={{ uri: item.url }}
        // Other necessary props
      />
    </View>
  )}
/>

@coofzilla Indeed, this is an ugly one... Not sure if I can find a good fix, but perhaps we can workaround it. I'm still looking into it. Will let you know if I find something useful.

@coofzilla What do you think about the following fix? The parentListRef would accept either FlatList or Scrollview refs. Internally, it would call  parentListRef?.current?.setNativeProps({scrollEnabled: boolean}); in order to avoid this issue.
export const VideoList = () => {
  const flatListRef = useRef<FlatList>(null);

  return (
      <FlatList
        ref={flatListRef}
        data={videos}
        horizontal
        renderItem={({ item }) => (
          <View>
            <VideoPlayer
              parentListRef={flatListRef}
              source={{ uri: item.url }}
              // Other necessary props
            />
          </View>
        )}
      />
   )
}

Looks good to me, especially since you've documented the change—this will give developers a clear example to follow when implementing it.
Just to clarify, would this approach work the same way for VideoPlayers inside FlatLists or ScrollViews that are vertical? Essentially, the same snippet you provided, but without horizontal.

Just to clarify, would this approach work the same way for VideoPlayers inside FlatLists or ScrollViews that are vertical? Essentially, the same snippet you provided, but without horizontal.

@coofzilla Yes, I think so. I will update the PR today and you'll be able to test it in ./examples/MyTVProject. If you confirm everything works fine, I'll merge and release a new version with the fix.

@coofzilla The branch is updated. The final implementation is like this:
export const VideoList = () => {
  const flatListRef = useRef<FlatList>(null);
  const [scrollEnabled, setScrollEnabled] = useState<boolean>(true)

  return (
      <FlatList
        ref={flatListRef}
        scrollEnabled={scrollEnabled}
        data={videos}
        horizontal
        renderItem={({ item }) => (
          <View>
              <VideoPlayer
                pan={{
                  parentList: {
                    ref: flatListRef,
                    scrollEnabled: scrollEnabled,
                  },
                }}
                source={{uri: 'https://vjs.zencdn.net/v/oceans.mp4'}}
              />
          </View>
        )}
      />
   )
}

You can test those changes in ./examples/MyTVProject. See https://github.com/LunatiqueCoder/react-native-media-console/blob/master/CONTRIBUTING.md
Let me know if this fixes your issues


Cannot maintain zoom while updating series or options

G'day
Very happy with Blazor-ApexCharts so far!
The one issue I've hit is that I would like to preserve zoom when updating series / options. If I have code like
await _chart!.UpdateOptionsAsync(false, false, false);
await _chart!.ZoomXAsync(_xZoomMin, _xZoomMax);

I can see the chart refresh after UpdateOptionsAsync (drawing the full series) and then again after ZoomXAsync (drawing the zoomed series) which produces an ugly visual flicker
This PR: https://github.com/apexcharts/Blazor-ApexCharts/pull/160 adds a new call UpdateOptionsWithZoomAsync
await _chart!.UpdateOptionsWithZoomAsync(false, false, false, _xZoomMin, _xZoomMax);

This does not cause flickering for me as the zoom happens before the refresh
Note that I have animations disabled
I'm open to a better solution to this problem!

Hello,
Thank you for your contribution!
Related: https://github.com/apexcharts/apexcharts.js/issues/643
I'll look into your PR

Thank joadan that looks great! I'll close my PR

Fixed in v0.9.15-beta


Class specific Macros as opposed to spec

Resurrection is available for all Priest specializations:
256 - Priest: Discipline
257 - Priest: Holy
258 - Priest: Shadow
Currently you must pick a single Priest specialization for each custom macro you add in the specId area.
Is there a way to just have it set to a Class to cover all specs for the /gs command?
Thanks,
Wyt

Thinking out loud into this
if you do a "/gs class" it will add all the macros for that class to the Macro Dialog.  THere is nothing in the macro execution to stop it being used in a different spec.  Its just not an obvious thing.
I'm going to create the ability for a 'classID="1-12"'

I understood that, but I like things compartmentalized. I think you do also...  Adding a class delimiter
is exactly what I was suggesting. Thank-you
Wytmagic

Hey Wytmagic.  This is in and will be in 1.0.3 that goes out tomorrow.
The Spec editor has a toggle that changes from Specialization to make it class specific


Is it fine to not assign a promise to a variable?

I'm trying to get my head around two things:

Xcode is giving me a warning if I don't assign the result of a function that returns a promise. This warning seems not promise specific but if you haven't disabled it it might be for good reasons
My promise are getting deallocated (Pending Promise deallocated! This is usually a bug) and stop executing and I don't get why

For instance, is it fine to do
func getNewToken() -> Promise<Void> {
  return Promise { fulfill, reject in
    guard let token = refreshToken else {
      reject(TokenError.tokenExpired)
      return
    }
    Network.shared.apiRequest( // this returns a promise, but I'm not allocating it's result
      "auth/refreshtoken",
      method: .post,
      data: [ "refreshToken": token.value ])
      .then { payload -> Void in
        try self.setToken(fromPayload: payload)
        fulfill()
    }
  }
}

// somewhere else
getNewToken() // I'm not allocating the promise result either
.then {
  print("token has been refreshed")
}

?

The compiler warning is because an unterminated Promise chain is a chain that doesn't end in catch, and thus has no error handling.
The log warning is what it says, you have an unresolved promise somewhere and you don't want that. It may well be the code sample since the error path is not handled (there is no reject).

Your code could be made more robust anyway:
func getNewToken() -> Promise<Void> {
  guard let token = refreshToken else { return Promise(error: TokenError.tokenExpired) }

  // by always returning promises you ensure that error paths
  // and fulfillment paths are ALWAYS handled

  return firstly {
    return Network.shared.apiRequest("auth/refreshtoken", method: .post, data: [ "refreshToken": token.value ])
  }.then { payload -> Void in
    try self.setToken(fromPayload: payload)
  }
}

By using promises you are ensuring you always handle errors and always handle positive paths too.

Ah excellent good point. I should have taken the warning much more seriously. Thanks a lot for the help!


Fix forwarding of -ld-path to Clang

The Clang linker driver spells this as --ld-path so we can't forward the argument wholesale anymore, since as of #1441 we spell it -ld-path in the Swift Driver.

cc @compnerd @MaxDesiatov worth adding that combining -use-ld and -ld-path should "just work" because one specifies the flavour whereas the other specifies the path. We already test this in testLinking but let me know if I'm missing something — happy to add more tests to cover any edge cases I might not have considered.

ooc do we have any integration tests for this sort of thing? Seems like the exact type of situation that's super easy to accidentally regress but also easy to catch with an integration test.

cc @compnerd @MaxDesiatov worth adding that combining -use-ld and -ld-path should "just work" because one specifies the flavour whereas the other specifies the path. We already test this in testLinking but let me know if I'm missing something — happy to add more tests to cover any edge cases I might not have considered.

Consider this usage:
-ld-path=/usr/bin/ld -use-ld=told

Should that execute /usr/bin/ld.told? Or /usr/bin/ld/told? Perhaps /usr/bin/ldtold?
Path composition is not very clear and I don't see test cases that ensure this is correctly diagnosed and heavy fs checks (which will slow down compilation) to ensure correct handling.

Should that execute /usr/bin/ld.told? Or /usr/bin/ld/told? Perhaps /usr/bin/ldtold?

hmm should we handle that at the Swift Driver level or kick the can down the road to Clang though? iiuc Clang uses the --ld-path directly without combining the -fuse-ld arg, and taking a step back those seems like the semantics required by the Swift SDK linker.path spec too.

@compnerd mind kicking off CI please? I can't since I don't have write perms.

@swift-ci test

@swift-ci test windows

hmm should we handle that at the Swift Driver level or kick the can down the road to Clang though?

How does Clang handle this edge case right now?

@MaxDesiatov @compnerd seems that Clang handles it the same way we currently do, i.e. without combining the flavor into the path:
https://github.com/apple/llvm-project/blob/1af12c15c2ba9b21e0cdf46a65bea7aaaf824def/clang/lib/Driver/ToolChain.cpp#L843-L847

--ld-path= takes precedence over -fuse-ld= and specifies the executable name. -B, COMPILER_PATH and PATH and consulted if the value does not contain a path component separator. -fuse-ld=lld can be used with --ld-path= to inform clang that the binary that --ld-path= points to is lld.

This is somewhat covered by our tests since we assert that -use-ld=foo -ld-path=/bar/baz translates to -fuse-ld=foo --ld-path=/bar/baz and not /bar/baz.foo etc. Open to suggestions on how to strengthen the tests and/or documentation, though I do think this PR is orthogonal to that (and hence worth merging first) because it's a bugfix.

This is somewhat covered by our tests since we assert that -use-ld=foo -ld-path=/bar/baz translates to -fuse-ld=foo --ld-path=/bar/baz and not /bar/baz.foo etc.

Sorry, I couldn't find this test, would you be able to provide a link to the exact line where this is covered?

@MaxDesiatov sure, it's within testLinking — see the asserts for -fuse-ld and --ld-path
https://github.com/apple/swift-driver/blob/fa4a8eae03d683585294233003c3180385556ded/Tests/SwiftDriverTests/SwiftDriverTests.swift#L1686-L1698

🙌 can we cherry-pick this into 5.10? I believe this needs to be fixed there too.


Tellstick doesn’t register state change from wall mounted wall switches

Home Assistant release (hass --version):
0.57.0
Python release (python3 --version):
Python 3.5.3
Component/platform:
tellstick switch
Description of problem:
HASS doesn’t register changes when pushing wall switches. Telldus registers it (checked with tdtool). Debugging doesn’t show anything in the log.
Additional info:
Sensors reporting temperature and humidity get registered. Telldus Duo, not Telldus Live.

I experience the same problem. Worked flawlessly in 0.56.2 but stopped working now when upgrading to 0.57.0.

After some experiments I found the change that's causing this issue, see my comment in PR #10315. @pvizeli did not really explain the change in the PR but it seems to have to do with the hass.io support.


BeansBackpacks is incompatible with ModernFix's Dynamic Resources Feature

Crash on startup with Beans Backpacks, ModernFix, and its Dynamic Resources Feature Enabled
Crash Report:
https://pastebin.com/dsAqe2UP
Log:
https://pastebin.com/s7bv7p6n
BeansBackpacks-fabric-1.20.1-0.1-v2.jar
modernfix-fabric-5.12.1+mc1.20.1.jar
Fabric 0.15.6
Minecraft 1.20.1

modern fix and I are both fighting to redirect the same method. I could choose a different method, but I've already done that to solve another incompatibility. Currently looking into a safe way to inject my code without this issue popping up again.

Fixed in 20.1-0.6-v2 :)


[DOCFIX] Improve POSIX API docs

What changes are proposed in this pull request?
Improve the POSIX API docs to be easier to follow.
Add some performance tuning recommendation

alluxio-bot, merge this please

@Xenorith Please help cherry-pick to 2.8

alluxio-bot, cherry-pick this to branch-2.8 please


⚠ ClamAV has degraded performance

In f555add, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 592 ms

Resolved: ClamAV performance has improved in a830196.


Remove version: taers232c.GAMADV-XTD3 version 6.76.03

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/taers232c/GAMADV-XTD3/releases/download/v6.76.03/gamadv-xtd3-6.76.03-windows-x86_64.msi
OK
(Automated message - build 910)

URL: https://github.com/taers232c/GAMADV-XTD3/releases/download/v6.76.03/gamadv-xtd3-6.76.03-windows-x86_64.msi
OK
(Automated message - build 910)


Please set the first day of the week.

In some countries, the week starts on Monday.
Please allow customization.

Closing this as a duplicate of #32.


Can Exchangeis add a function of structure migration

Can Exchangeis add a function of structure migration

https://github.com/WeBankFinTech/Exchangis/pull/282，这个pr解决了

We don't support the current version of. The latest version is exchangis1.1.1. You can pay attention to it.


Drawn plugin ranges

I have drawn 2 circles with approximately the same size, to see how long I can make a link, however because of the drawn circles not being the same, however because of the earths curvature, the circles are not an exact tool for checking distances.
As you can see in the picture I would be able to make a link from iceland to poland but not from poland to iceland.
So drawing a circle on earth would not be visualized as a circle on the map.

It looks like this functions properly these days.


fix: Radio button triggering on change twice

Description
This PR contains the fix for th design system radio component triggering on change function twice.
Fixes #18026
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=8d16e69

Fixes https://github.com/appsmithorg/appsmith/issues/18026

/ok-to-test sha=980a535

/ok-to-test sha=980a535

The fix looks good. Event handlers are called only once now.
https://www.loom.com/share/0ac1667648e5483ca5eb1e8e61ba5610

/ok-to-test sha=7bd5a55


collision: 3.6.0 -> 3.7.1

Description of changes

Things done
Bump versions (fixes build)

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Oops, didn't see it was already opened. Duplicate of #282286.


README: Add Bazel distribution URI so apt can find it.

Suggested edit to the README in the C++ installation section: In order for apt to install bazel, one needs to add the Bazel distribution URI as a package source (see here).

#106 fixes this


Add sccache to CI

Builds are pretty slow, thought I'd try mozzila/sccache to speed things up.

I think it might be a little faster? It seems to be doing something at the very least:
Compile requests                   1391
Compile requests executed          1191
Cache hits                         1184
Cache hits (C/C++)                  633
Cache hits (Rust)                   551

Should we be running cargo-deny? We're not adding new deps. Also, I'm assuming it's already been failing?


feat(module:color-picker): disable alpha

PR Checklist
Please check if your PR fulfills the following requirements:

[✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[✔] Tests for the changes have been added (for bug fixes / features)
[✔] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Unlike the color picker component in antd, we do not allow disabling alpha.
What is the new behavior?
Implementing an option to disable the alpha channel in the color component.
Does this PR introduce a breaking change?
[ ] Yes
[✔] No

Other information

LGTM. WDYT? @OriginRing

LGTM


Two requests to add in ArkOS

Before submitting your issue or feature request.  DO NOT REQUEST ASSISTANTS FOR PRELOADED IMAGES.  I do not support or condone the use of preloaded ArkOS images.  Preloaded meaning images that come with copyrighted roms preincluded.  Look for support from the creator or supplier of those preloaded images, not from here!  If a ticket is submitted for assistance for such images or if there's an indiciation that a preloaded image is what the support request is for, the issue ticket will be closed with no further response.

This is not the Stock OS that comes with your device, AmberElec, JelOS, or UnOfficialOS.  ArkOS is a different distribution from those systems and will have differing features.  The only somewhat similarity is that they both use EmulationStation as a frontend.  Even with that, the versions of EmulationStation that's used in between ArkOS and these other distributions is different with different capabilities.  If there are features you prefer with the other available distributions, just use those distributions instead.  The choice is yours.
ArkOS is best
Have you reviewed the Frequently Asked Questions section available for your supported device in the wiki?
Yes
If your issue is related to being able to run certain emulators or ports, have you reviewed the Emulators and Ports section available at https://github.com/christianhaitian/arkos/wiki/ArkOS-Emulators-and-Ports-information for needed bios files and supported rom extensions?

Have you reviewed the known issues section available at https://github.com/christianhaitian/arkos/wiki/Known-issues ?
Yeah

Describe the Issue (If applicable)
A clear and concise description of what the bug is.
Not bug
How can the issue be reproduced? (If applicable)

What device are you using?
RG353VS
What version of ArkOS are you on?
22122023
Hello,
I love your ArkOS, even with problem that on Anbernic RG353VS I have to use underclocked file to 1,4 GHz to boot, because every game is working much faster and smoother but I have two suggestions:

On Anbernic I love that I can choose emulator for every game, so if there is problem with one game I can choose other emulator which works.

Scraper in Anbernic works that I can scrape only one game where I am at moment which is fine.

Actually 1) & 2) is related and these are attributes that people could value.
Would be possible to add these functions maybe to menu selections (SELECT press when you are listed on game you want to edit)? It would be awesome feature!
Thanks for ALL you are doing for this software.

Sounds like you haven't referenced the FAQ that's available for ArkOS for your device.

You can change emulators and cores on a per game or per system level following the instructions here: https://github.com/christianhaitian/arkos/wiki/Frequently-Asked-Questions---rg353v#q-how-do-i-change-emulator-cores-in-ArkOS
You can scrape singular games by hitting select on the game, then edit metadata, then select scrape at the bottom of the menu presented.


brew cannot find GCC

Since the most recent update brew is unable to find GCC.
Not sure if anyone else is having this issue.
Error: The following formula:
  node
cannot be installed as a binary package and must be built from source.
Install Clang or brew install gcc

brew doctor also reports that there is no compiler installed, there definitely is...
Setting this some how fixes the issue:
export HOMEBREW_NO_ENV_FILTERING=1

If there is any info I can give to help diagnose the issue and why the env filtering fixes it please let me know.

Thanks for the bug report, Martin. With ENV_FILTERING enabled, brew isn't finding your compiler in $HOMEBREW_PREFIX/bin. I'll look into it.

I believe this bug is fixed by PR https://github.com/Linuxbrew/brew/pull/546.
Thanks for the bug report, Martin.


Prepare move

Prepare to transfer ownership into the slog ecosystem.  Also a small enhancement to add a DefaultLogger type so that you can avoid all mention of stats if you don't want to use them.

Looks good to me. Names seem sensible.

DefaultFormatLogger might be better than DefaultLogger.


Remove ml-commons and neural search from 3.0.0

Description
Ml commons is blocking 3.0 due to https://github.com/opensearch-project/ml-commons/issues/891 hence removing it. Neural depends on ml commons so removing it too
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

All ✅ finally 🪀


Add missing use declaration in Quickstart

Seems like the example code in the quickstart guide is missing an use declaration.
The code fails to compile: error: cannot find macro graphql_value in this scope with rustc 1.48.0 (7eac88abb 2020-11-16)

Thank you!


Quickstart sample cannot build

We can only help you if you are on the latest version. Either use the latest 2.x or 3.x
Please only use the issue tracker for bug reports and/or feature requests. For general security questions, or free or commercial support options do not use the issue tracker and instead see here for more details.
For bug reports,  include the relevant log files related to your issue. See here how to enable logging. Delete this line once you have.
Finally, please keep the issue concise and to the point. If you paste in more code than the text for the issue you are reporting then we will most likely not read it.
Issue / Steps to reproduce the problem
I cloned the IdentityServer4 repo to my local PC and load this solution into Visual Studio 2019 Enterprise Edition:
IdentityServer4\samples\Quickstarts\3_AspNetCoreAndApis\Quickstart.sln
When I do a "Rebuild All" in Visual Studio I get this error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	NETSDK1004	Assets file 'c:\Temp\Zylinc\IdentityServer4\samples\Quickstarts\3_AspNetCoreAndApis\src\IdentityServer\obj\project.assets.json' not found. Run a NuGet package restore to generate this file.	IdentityServer	C:\Program Files\dotnet\sdk\3.1.301\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	234

It would be nice if the QuickStart solution would just compile in VS2019 without any additional steps.
I haven't yet found out how to do a NuGet restore to fix the issue, so I have to quit spending more time on IdentityServer4.
Relevant parts of the log file
<log goes here>

@leastprivilege told ya

Sorry - I can't repro that.
Do you have the right SDK installed per global.json?

I can build everything if I run build.ps1 or build.sh in the root folder.
But if I do a clean git clone of the repo and opens
IdentityServer4\samples\Quickstarts\3_AspNetCoreAndApis\Quickstart.sln
in Visual Studio the solution will not build.
It is a minor issue, but still a bit confusing.

The quickstarts are unrelated to the build. I still can't repro it.

Feel free to close this issue then.


Request GitHub to Red Hat ID linkage

To be a member of the Red Hat CoP GitHub organization, you are required to be a Red Hat employee.
Non-employees are invited to be outside-collaborators (https://github.com/orgs/redhat-cop/outside-collaborators).
To resolve GitHub IDs to Red Hat IDs, we check if we can find you via LDAP.
If you are unsure how to set your GitHub ID within LDAP, see:

https://source.redhat.com/departments/it/it-information-security/wiki/details_about_rover_github_information_security_and_scanning

As we have been unable to resolve your GitHub ID via LDAP, can you please add your GitHub handle to Rover:

[ ] @sbailleu
[x] @sushilsuresh
[ ] @Chetan-07
[x] @berkeragir

@sbailleu @sushilsuresh @Chetan-07 @berkeragir ; if you still work for RH, can you link your github to rover:

https://source.redhat.com/departments/it/it-information-security/wiki/details_about_rover_github_information_security_and_scanning

@garethahealy I don't work for Red Hat any more. Feel free to purge my account 😭

Hello. I also don't work at Red Hat anymore. Feel free remove me from the organization.

@sbailleu @Chetan-07 ; are you still Red Hatters? if so, can you link your GitHub IDs to Rover, as per:

https://source.redhat.com/departments/it/it-information-security/wiki/details_about_rover_github_information_security_and_scanning

looking at linkedin, Chetan-07 has left RH - https://www.linkedin.com/in/cshinde07/


Add to supports with difference column name in database

Special column name;
Scope support;

Fix #4 #5


stitch: Fix bug with multiple identical services

Previously, when multiple identital services were deployed, you would
end up with inconsistent StitchID assignment causing bugs.
A demo of this bug can be found at
https://github.com/PenguinToast/quilt-demo, by first running
spark/run.js, then spark/run2.js. run.js deploys a single Spark
cluster, and run2.js deploys another identical spark cluster. With the
bug, the master container for the second cluster will be assigned the
original StitchID of the first cluster's master, causing all the new
workers to connect to the first cluster's master.
The bug arose from the _refID fields of containers being strings,
causing a container with a _refID of "10" to be assigned a StitchID
before a container with a _refID of "8". We fix this bug by making
_refID a number so that StitchIDs are assigned in the correct order.

Are you going to write an integration test that would have caught this too?
It'd be cool if we had a test that ran the first file, then randomly shuffled the second file.

@kklin I could write an integration test, but I'm not sure what we could randomize and what this test would test for beyond the changes I've already made in the unit tests

It seems like your demo could easily be transformed into an integration test. I feel like it's ok if it doesn't always fail (fails randomly), since eventually an integration run will catch it. Plus that way it could be remove from the commit message, as it seemed a little out of place there.

The reason I'd like an integration test is that your unit test ensures the one failure mode that you debugged never happens. Whereas an integration test would ensure that running one service and then another identical one always works. If this scenario starts failing for a different reason, we'd find out with the integration test and not the unit test.
Ah, ignore the random shuffling comment, I confused myself 😄
BTW, I agree with @mmussomele about linking to the demo. I'd prefer a simple inline example demonstrating the bug as that link might become out of date.

@kklin Added the integration test - could you review it?

@kklin Addressed PR comments

Thanks @PenguinToast, did you see my comment about collapsing the tests into one?

Ah, missed that comment - collapsing the tests would be a little ugly, since we'd have to

Change how quilt-tester so that it chooses the correct spec to run first
Hard-code or somehow pass the test path to the test itself so that it can run the second spec

It's definitely do-able, but some discussion would be needed to figure out the "right" way to do the above two points

Nah, I don't think it's worth the effort. Thanks for looking into it!


ENH: Allow to manange parallelization more fine-grained.

To manage resources in more detail, it would be nice to

mark tasks to run in isolation.
group tasks that should run parallel with a certain number of workers.

There is the option to use @coiled.function now to deploy a single function to a remote cluster.


Fix UG description + UML

Some minor changes

Codecov Report

Merging #210 (1d20790) into master (925c967) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #210   +/-   ##
=========================================
  Coverage     70.60%   70.60%
  Complexity      593      593
=========================================
  Files            85       85
  Lines          1919     1919
  Branches        259      259
=========================================
  Hits           1355     1355
  Misses          445      445
  Partials        119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925c967...1d20790. Read the comment docs.

Should be fine to merge, Small changes


still get http error 400 with the aspnetcore.docs sample project

I followed the instructions for file uploads at this page and after changing several configs, startup.cs files etc, i cannot upload more than a few mg at a time. the page returns a 404 error
I am running the sample locally on iis express. I have 1 32 gb pc.
I am looking to upload DICOM images and they are quite large. Hoping one of these examples will work

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a5cfa38-0e6c-4346-dafc-84ea5c513fcf
Version Independent ID: c6787f0f-3e9a-6efb-0e6e-5ccb957d3f4a
Content: Upload files in ASP.NET Core
Content Source: aspnetcore/mvc/models/file-uploads.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Potential bugs in the ASP.NET Core framework and product feedback can be reported at dotnet/aspnetcore issues (include full repro steps and cross-link to a repro project in GH when appropriate). For Visual Studio, use the Report a Problem gesture or Suggest a Feature gesture within VS, which open internal issues for the VS team. For Visual Studio Code, you can open an issue at microsoft/vscode issues.


Dealing With Turnover

Should be able to answer the following:

Is there any point of companies trying to to keep their employees?

Perks are the main motivations, but are they enough?

Turnover is a fact . Accept it and deal with it

What are the available tools to deal with it?
Types/methods of trainings, types of project docs?
Any best practices?
Deprecated info (i.e. prior to design decisions)?
Graded/Scaled training (overview, entry, sub-specialty etc)?

Trying to apply common practices/processes (good for a single company but not all companies use the same. However, having a dev pool is a good idea i.e. to train them, have them ready in the pool, and assign them to projects on-demand)

Research Completed. Findings will be presented on Master Thesis Document.