Add Covid Vaccination Coverage from RKI

Good evening guys,
first of all: Thanks a lot for that great adapter! I use the adapter a lot in different scenarios.
I just figured out that RKI also provides Covid Vaccination Coverage for all german federal states:
https://www.rki.de/DE/Content/InfAZ/N/Neuartiges_Coronavirus/Daten/Impfquoten-Tab.html
As far as I understand, RKI always provides "data from yesterday" (absolut and delta). Would be great to include that information as new datapoints to country and federl states of germany.
Best regards,
David

hi, thanks :)
as far as I can see this data ist not available by API ?

Can you extract the data using an appropriate RegEX-Pattern?
Or otherwise, maybe I can find another website providing the information with matching api.

Can you extract the data using an appropriate RegEX-Pattern?
Or otherwise, maybe I can find another website providing the information with matching api.

right now, this data is only available as an Excel, so no possibility of using RegEx. As an interim, i'll provide this data with a script but first need to see how that Excel will look like next days. Have a look at the forum, i'll announce it there. first draft looks good already

@winnyschuster
the easiest  why i guess would be this parser  Module to read and parse the xls just as json and have It handled as current json objects in the adapter.
https://www.npmjs.com/package/xls-parser

Hmm I found one for all countries and will implement it soon!
but no separation for DE sorry just country level

Thanks a lot for your effort. Looking forward to test the new feature soon.

i checked the API data, not relevant info found except the medicine data.
Adding the xls part just for Germany is not really adding value, as soon a country wide API is available we can look at it


Downloading just the first URL in a file on OSX (and maybe Linux)

TXT files containing more URLs are not correctly parsed on OSX (and maybe Linux).
When I try to download more URLs, just the first is correctly inferred and, after it has finished, the others are ignored.
The reason is linked to this function:
function readFileToArray(path) {
path = path.substr(1,path.length-2);
return fs.readFileSync(path).toString('utf-8').split('\r\n');
}
Files created on Linux and OSX don't use \r\n but just \n. I had to remote the \r it in order to make it work. I assume Windows version don't have this problem.
BTW, thanks for the amazing software.

This function was added by last my commit. Thanks for notifying. I'll do new pull request to fix it :)


Migrate file empty

Migrate not work
I do migrate my project but output is empty
exports.up = function(knex) {

};

exports.down = function(knex) {

};

You need to write the migration files yourself. There's no automatic migration file genwration.

Ah .. why ?
I have an idea how to write it
I need some time to write automatic migration
It might need modification from you as I don't know much about jsonSchema

Because it is impossible to implement well. The model doesn't describe the schema well enough, and it is impossible to create automatic migrations except for very very simple cases. As soon as you write anything more complex or use any features of the relational database, you need to write the migrations by hand anyway.
Objection doesn't implement automatic migrations by choice. If you need stuff like that, objection is not the tool you should be using.


Fix has_many through association

Fix has_many association with through issue introduced by #2446.
See #2446 for more details.
Issue fixed: #2474

Thanks @mshibuya for your work.


Allow a maximum column width to be specified

Previously, the column size would hit a hard cap at 500 pixels.  We would like to have columns that are wider than this, so I've made it a prop.

Hmm.  Installing this locally, it doesn't seem to work quite yet.  I'll investigate further.


Add guards in methods to prevent runtime errors and point to trouble shooting docs

[ ] Create trouble shooting examples that can be linked to
[ ] Add guards in methods pointing to those trouble-shooting docs

@PWKad is this still needed?

More of a nice to have no need to leave it around


IAR support for ethernet library

#if defined (__ICCARM__)
t->def.stack_pointer = (uint32_t*)malloc(stacksize);
#else
t->def.stack_pointer = (unsigned char*)malloc(stacksize);
 #endif

t->def.stack_pointer is of type uint32_t *. In GCC assigning pointer of a different type generates a warning. IAR's compiler does not allow it and generates an error. I had to correct it so IAR can compile the code.

Means , that GCC generators warning and we should fix that

Ok I did not want to change any of your code. So should I make a 2nd commit?
Replacing:
#if defined (__ICCARM__)
t->def.stack_pointer = (uint32_t*)malloc(stacksize);
#else
t->def.stack_pointer = (unsigned char*)malloc(stacksize);
#endif

With:
t->def.stack_pointer = (uint32_t*)malloc(stacksize);

Yes, it was changed in the declaration of stack pointer but not in ethernet.


terminal accessible view opens unexpectedly

create a terminal
quickly, use alt+f1
🐛 the terminal accessible view opens, dynamic prompt data is shown

https://github.com/microsoft/vscode/assets/29464607/642185d6-5c3f-4aca-868f-6a9bec14bca6

this is because the terminal's help dialog and buffer provider are using the same ID, since that was derived from the accessibility verbosity setting key. so we'll have to use the ID instead.
so this condition would be true
https://github.com/microsoft/vscode/blob/2418c9d41d9be6cfdaead5947ef2ad4ebffe4830/src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts#L97-L99


TreeExplainer.save throws AttributeError: 'TreeEnsemble' object has no attribute 'save'

Sorry if I'm missing something, but TreeExplainer.save doesn't seem to work:
import shap
import xgboost as xgb
from sklearn.datasets import load_iris

print(xgb.__version__)
print(shap.__version__)

dtrain = xgb.DMatrix(*load_iris(return_X_y=True))
model = xgb.train({}, dtrain)
exp = shap.TreeExplainer(model)

with open("TreeExplainer", "wb") as out_file:
    exp.save(out_file)

When I run this code, I get:
1.4.2
0.39.0
Traceback (most recent call last):
  File "a.py", line 13, in <module>
    exp.save(out_file)
  File "/Users/foo/.pyenv/versions/miniconda3-4.7.12/envs/bar/lib/python3.7/site-packages/shap/explainers/_explainer.py", line 398, in save
    s.save("model", self.model, model_saver)
  File "/Users/foo/.pyenv/versions/miniconda3-4.7.12/envs/bar/lib/python3.7/site-packages/shap/_serializable.py", line 87, in save
    if len(inspect.getfullargspec(value.save)[0]) == 3: # backward compat for MLflow, can remove 4/1/2021
AttributeError: 'TreeEnsemble' object has no attribute 'save'

cc @slundberg

Yeah, I run into the exact same issue...trying pickle but the online hosting "Gradio" won't allow to load it.

Same problem here too but with a LightGBM model.

Encountered the same issue.
Using shap 0.40.0, xgb 1.5.0, saving and loading the explainer like:
explainer = shap.Explainer(model, x)
explainer.save(
    open(explainer_path, "wb"),
    model_saver="auto",
    masker_saver="auto")
explainer = shap.Explainer.load(
    open(explainer_path, "rb"),
    model_loader="auto",
    masker_loader="auto"
)

And got printed result and the error message:
loaded_name model
loaded_name masker
loaded_name data
loaded_name max_samples
loaded_name clustering
loaded_name link
venv/lib/python3.9/site-packages/shap/explainers/_tree.py", line 979, in __init__
    raise Exception("Model type not yet supported by TreeExplainer: " + str(type(model)))
Exception: Model type not yet supported by TreeExplainer: <class 'shap.explainers._tree.TreeEnsemble'>

The default setting: instantiate=True will cause shap.Explainer.load to call Serializable._instantiate_load.
That leads to shap.explainers._tree.TreeEnsemble type to pass into the initialization of itself which expect the model to be type of various tree-based models.
I've also tried loading directly using:
explainer = pickle.load(open(explainer_path, "rb"))
print(explainer)

And I got <class 'shap.explainers._tree.Tree'> which is not an instantiated object.

Has there been any movement on this?
I've tried various combinations of masker loaders but still keep arriving at
  File "<ipython-input-7-77f26fcf401a>", line 2, in <module>     explainer2 = shap.TreeExplainer.load(open(self.fname_shapley_explainer, 'rb'),   File "/Users/dtemple/Repositories/ai-kato/venv/lib/python3.9/site-packages/shap/explainers/_explainer.py", line 432, in load     return cls._instantiated_load(in_file, model_loader=model_loader, masker_loader=masker_loader)   File "/Users/dtemple/Repositories/ai-kato/venv/lib/python3.9/site-packages/shap/_serializable.py", line 45, in _instantiated_load     constructor_args = obj_type.load(in_file, instantiate=False, **kwargs)   File "/Users/dtemple/Repositories/ai-kato/venv/lib/python3.9/site-packages/shap/explainers/_explainer.py", line 438, in load     kwargs["link"] = s.load("link")   File "/Users/dtemple/Repositories/ai-kato/venv/lib/python3.9/site-packages/shap/_serializable.py", line 165, in __exit__     self._load_data_value()   File "/Users/dtemple/Repositories/ai-kato/venv/lib/python3.9/site-packages/shap/_serializable.py", line 204, in _load_data_value     raise ValueError(f"Unsupported encoder type found: {encoder_name}") ValueError: Unsupported encoder type found: masker

Hi everyone,
I was just wondering if this issue has been resolved? I am getting the same error when logging the explainer using mlflow in Databricks.
I have shap==0.41.0 and mlflow==2.1.1.
Best regards,
Nader

Working solution
Hi everyone,
I was facing the same issue. But I was able to work around this using joblib's dump and load methods.
`with open(save_path + 'object_name', 'wb') as f:
jbl.dump(explainer, f)
with open(save_path + 'object_name', 'rb') as f:
loaded_explainer = jbl.load(f)
`
Hope this helps.
Regards,
Aditya


[Autonomous Development Platform] API Review

USE ISSUE #7483

Meeting updated by Jess Treiser
Service Name: Autonomous Development Platform
Review Created By: Jess Treiser
Review Date: 12/7/2022 7:00 PM PT
PR: https://github.com/Azure/azure-rest-api-specs/pull/9634
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description:
Detailed meeting information and documents provided can be accessed here

Meeting updated by Jess Treiser
Service Name: Autonomous Development Platform
Review Created By: Jess Treiser
Review Date: 12/7/2022 7:00 PM PT
PR: https://github.com/Azure/azure-rest-api-specs/pull/9634
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: Continue reviewing ADP ingestion & measurement APIs
Detailed meeting information and documents provided can be accessed here

Duplicate: https://github.com/Azure/azure-rest-api-specs-pr/issues/7483

Cancelled by: Jess Treiser


Ressource pack overides for 3D ladder ?

Nevermind, i am blind, fastest issue closer in the west, there is the option already, thank you for your work !


Use Classes to represent info

Currently, the bot returns the info directly from the JSON response obtained from the API. It will be very useful (and better from the point of view of coding style) to create custom classes to interact with the info when we need them.

Currently working on it on branch "classes"

Done and merged.


Path to static files in theme

Hey! Nice plugin! The content is being compressed, but the themes static files are not. Is there a way to specify paths?

my bad.

Thanks John! I see that you already closed the ticket, but what was happening? Was it skipping images and fonts?
Please let me know what you were seeing. Perhaps the plugin documentation can be improved. =)


[New game]: Timber terry

🎮 Game Request
Help Timber Terry as a bear chases him up a tree. Guide him to safety while saving any innocent bird nests hidden at the end of the branches. Your bird friend, Jimmy, will aid you in finding bird nests... but not all of them. Make sure to chop down the tree at the end and rid the forest of that scary bear.
Point down the features
Game points will be awarded as function of time elapsed
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @S-ishita !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @S-ishita ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


lxd: 4.12 -> 4.13

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

LGTM. Evaluates fine. I did not test a real deployment though.

Evaluates fine on NixOS.

We have ofborg for that which evals a bit more restrictive than your local nixos.


Debt Collector Name Page

Change type of page only field is Company name instead of full person name.

Changed text box to be company only.


dockerfile improvements

Dockerfile.ubi: only build CUDA targets from sm_75
Dockerfile.ubi: get rid cuda-devel stage, use cuda 12.5
Dockerfile.ubi: strip all installed libraries
Dockerfile.ubi: remove useless installs
Dockerfile.ubi: get rid of outdated comment

/hold

:angry: :anger: :rage:

In my testing, I kept cuda-devel and cuda-base separate. The difference was that cuda-devel added nvcc and nvtx. They are small compared to torch. But it saved a several MB on the final image.


Possible specification error for SXL 1.0.14, objects S0205-S0208

For all objects, S0205-S0208, the value field (vehicles, speed, e.t.c.) the text states that each value should be separated by a colon, but the example value shows a comma (for example for the vehicles field, the example shows [0-65535, ...])
Which is correct?
And please update the documentation to avoid the ambiguity.

I think this can be closed?

I think this issue can be closed since it was fixed in 1.0.15.


pipenv support

current using pipenv install PyPortfolioOpt would result in 'Not Found' error

Hi,
Thanks for the suggestion. I'm currently not familiar with pipenv. From a quick read on the internet, it seems that all I need to do is provide a pipfile in the repo? If that's the only thing, I'm happy to support pipenv.
Best,
Robert

possibly, I haven't published a package of Python myself, but from the reading pipenv would download packages from PyPI, so it probably just needs some extra setup
https://github.com/pypa/pipenv/issues/1288


Introduce cupy.available

Currently, chainer.cuda.available is True even if there is no available CUDA device (by setting CUDA_VISIBLE_DEVICES=-1).
In order to avoid that, this PR introduces cupy.available which takes account of device availability.
(Corresponding issue in PyTorch: https://github.com/pytorch/pytorch/issues/306)

Fixed.

It seems calling runtime.getDeviceCount() in the module-level code of cupy/cuda/__init__.py causes problem in multi-process environment.
I fixed it by deferring the call with a function (cupy.is_available()) insted of a flag (cupy.available).

Perhaps chainer.cuda.available should also be deferred. That would be a compatibility-breaking change.

LGTM!


how to Share a Tweet through Direct Messages?

how to Share a Tweet through Direct Messages?

share one page to people via DM private. send url to someone ,there is only url. But Share the page to people .there is some webpage description. Cannot send DM to people to be some description? How ?

Sharing the tweet link https://twitter.com/{username}/status/{tweetid} will show a nicely formatted tweet in the recipient's DM list.
Please be careful automating DMs. It's easy to annoy and spam people with automated DMs.


Update kodi after torrent or nzb download?

I think that should be handled by the client.  Nzb search does add a category so if you using a post progress script it can update your media center.


Now create new Project Membership

refs #170
I want to create new Project membership.
var membership = new Redmine.Net.Api.Types.ProjectMembership();
membership.Project = IdentifiableName.Create<IdentifiableName>(1);

But the Project is a protected member
https://github.com/zapadi/redmine-net-api/blob/master/src/redmine-net-api/Types/ProjectMembership.cs#L46
How can I create a new project membership?

I'm afraid that you have to go through the project to create a new project membership

@zapadi I'm sorry but I don't know how this helps.
When I load a project
var project = redmineManager.GetObject<Project>(projectId.Id.ToString(), null);

I get a object of https://github.com/zapadi/redmine-net-api/blob/master/src/redmine-net-api/Types/Project.cs. But there is no possibility to add a membership.


feat(swc): enable bytecheck

Description:
Second attempt to enable bytecheck. This PR does not have cersioned struct yet, just enabling bytecheck whereever possible. Also it is for the ast only yet, so transformmetadata and other might need this later.
PR seems to passing all the ci, but as we've experienced before there might be some unexpected outcome with release. Maybe better to hold this until clear https://github.com/swc-project/swc/issues/7238, then land as separate release.

@kdy1 Resolved conflict, I think we can land this now (which.. requires another bump for swc_core and @swc/core probably though)

@kdy1 thoughts on this? I think this is now ready to go in.

I agree, but I'm curious if this is a breaking change of swc_core

I may wrong, but I guess not? This PR enables repr and bytecheck, however does not enable versioned struct we attempted previously (https://github.com/swc-project/swc/pull/5062/commits/1f3eba7f240b5d08e4688be450d5c00e6e38c2b1#diff-ef22f81d236ee08fd2bed74657c8eddc2dbef9f02f454a25941daa453b0ab2e0R173) so unless anyone explicitly relies on some of repr-based struct layout, it would work (again, I guess though)


0.0.5

Better test coverage
Apply PEP8
Resume lost Redislite process on restart, interrupted exit

Coverage increased (+24.03%) to 97.895% when pulling 9c3bad2521c746c37ac34954e3ca5fd3fb48553b on 0.0.5 into a778262ac759d85eaab98f1be6ee01ce7e30d2d0 on master.


Building of Maven artifacts [HPPC-12]

Issue: HPPC-12 (migrated from JIRA), created by Stanisław Osiński (@stanislawosinski), resolved Mar 12 2010

Comment by Dawid Weiss (@dweiss) (migrated from JIRA)
In trunk.


[FEATURE] Character Sheets for Elders

Are there any plans for sheets for Elder kindreds of lower than 8th generation? Maximum of dots for traits like Attributes and Disciplines are 5 at the moment. Or am I blind to how I can set up traits higher than 5?

Try add a lower number than 8 in the generation field on the sheet and the amount of dots available should update automatically

I must be blind. I cannot find the field for Generation.

Description tab, 6th box to the right

I guess this means I should move generation to the front page :)

I'm not seeing it there either.

Which sheet are you on?

Omg, a bug a sneaked it's way in the last release when creating new characters. I will look at it right away and get it fixed

I'll keep an eye out for the update and let you know if it's all good. :)

Ah, nevermind, its not a bug. But kinda unclear. Just fill in the clan field! I should really not hide this if the clan field is empty

If you fill in the field on the top., the sire and generation field appears. I will remove so they actually always are there in the next release I do.

Alright. Filling out the Clan field unlocks the other two. Thanks.


Loading BERTScore

Hi,
I was testing loading bertscore with evaluate and saw this following error.
>>> import evaluate
>>> metric = evaluate.load("bertscore")
Couldn't find a directory or a metric named 'bertscore' in this version. It was picked from the master branch on github instead.

Looks a bit mystic to me. Perhaps you have some insights :)
Thank you!

Indeed, it is just a warning - it's a bug we hoped to fix with the release. I'll report once it is fixed.


[Q] Cannot get TSDuck to demux, get tables

So I have a live TS stream running, and my application is able to capture raw TS packets at some interval. What I'm trying to do is feed these TS packets to TSDuck so that it can demux these packets. At some later time I want to be able to see what Tables and PIDs where "detected" from the captured samples.
This seems very similar to what tsTSScanner code is doing; however I do not seem to get call backs on handleTable
I believe it is registered demux class.
Here is the simplified code:
#include "tsduck.h"

#include "mydata.h"
/* snippit of mydata.h
  ...
  const uint32_t mydata_size = 32000;
  uint8_t mydata_raw[mydata_size][188] = {
    {0x47, 0x00, 0x6C, 0xFC, 0xD2, 0x3E, 0x22, ... },
    {0x47, 0x00, 0x00, 0x8F, 0xBF, 0xDB, 0xCF, ... },
    ...
  };
*/

class MyClass : private ts::TableHandlerInterface {
  public:
    MyClass();

    void parse(uint8_t* buf);

  private:
    ts::DuckContext   _duck;
    ts::SectionDemux  _dmux;
    ts::TSPacket      _packet;

   virtual void handleTable(ts::SectionDemux&, const ts::BinaryTable&) override;
};

MyClass::MyClass() :
    _duck(),
    _dmux(_duck, this)
{
  // Collect PAT, SDT, NIT
  _dmux.addPID(ts::PID_PAT);
  _dmux.addPID(ts::PID_SDT);
  _dmux.addPID(ts::PID_NIT);
}

void MyClass::handleTable(ts::SectionDemux&, const ts::BinaryTable& table) {
  std::cout << "MyClass handleTable Called" << std::endl;
}

void MyClass::parse(uint8_t* buf) {

  std::stringstream sstream;
  sstream.write((const char*)buf, 188);

  if (_packet.read(sstream, true)) {
    _dmux.feedPacket(_packet);
  }
}

int main() {

  std::cout << "ENTER" << std::endl;

  MyClass p;

  for (int i = 0; i < mydata_size; ++i) {
    p.parse(mydata_raw[i]);
  }

  std::cout << "EXIT" << std::endl;
  return 0;
}

When I print the info on _packet I see they are valid. When I print the status of _dmux I get:
Invalid TS packets: 0
TS packets discontinuities: 0
Scrambled TS packets: 4,570
Invalid section lengths: 0
Truncated sections: 0
Invalid section index: 0
Invalid unchanged section version: 0
Corrupted sections (bad CRC): 0
Next sections (not yet applicable): 0

This leads me to believe they are getting into the demux... but not sure why handleTable is not called. I should have enough packets to have a complete table filled... any help, ideas would be good..

Hi @ankitp86
Did you try to store your binary data in a file and run tstables on it?
This is typically the same as what you do.
Does it display some tables?
BTW, no need to make simple things complicated:
void MyClass::parse(uint8_t* buf) {
  _dmux.feedPacket(*reinterpret_cast<ts::TSPacket*>(buf));
}


[Event Request] Codeunit 87 "Blanket Sales Order to Order" - OnCheckAvailabilityOnBeforeInitSalesLineOutstanding

Hi, would it be possible to get an OnCheckAvailabilityOnBeforeInitSalesLineOutstanding event in codeunit 87 (Blanket Sales Order to Order), like this:
local procedure CheckAvailability(BlanketOrderSalesHeader: Record "Sales Header")
    var
        ATOLink: Record "Assemble-to-Order Link";
    begin
        with BlanketOrderSalesLine do begin
            SetRange("Document Type", BlanketOrderSalesHeader."Document Type");
            SetRange("Document No.", BlanketOrderSalesHeader."No.");
            SetRange(Type, Type::Item);
            SetFilter("No.", '<>%1', '');
            if FindSet then
                repeat
                    if "Qty. to Ship" > 0 then begin
                        SalesLine := BlanketOrderSalesLine;
                        ResetQuantityFields(SalesLine);
                        SalesLine.Quantity := "Qty. to Ship";
                        SalesLine."Quantity (Base)" := Round(SalesLine.Quantity * SalesLine."Qty. per Unit of Measure", UOMMgt.QtyRndPrecision);
                        SalesLine."Qty. to Ship" := SalesLine.Quantity;
                        SalesLine."Qty. to Ship (Base)" := SalesLine."Quantity (Base)";
                        OnCheckAvailabilityOnBeforeInitSalesLineOutstanding(SalesLine, BlanketOrderSalesLine) // New Event
                        SalesLine.InitOutstanding;
                        if ATOLink.AsmExistsForSalesLine(BlanketOrderSalesLine) then begin
                            SalesLine."Qty. to Assemble to Order" := SalesLine.Quantity;
                            SalesLine."Qty. to Asm. to Order (Base)" := SalesLine."Quantity (Base)";
                            SalesLine."Outstanding Quantity" -= SalesLine."Qty. to Assemble to Order";
                            SalesLine."Outstanding Qty. (Base)" -= SalesLine."Qty. to Asm. to Order (Base)";
                        end;

                        if not HideValidationDialog then
                            CheckSalesLineItemAvailability(BlanketOrderSalesHeader);
                    end;
                until Next() = 0;
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCheckAvailabilityOnBeforeInitSalesLineOutstanding(var SalesLine: Record "Sales Line"; BlanketOrderSalesLine: Record "Sales Line")
    begin
    end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


fix(deps): update dependency antlr4ts to v0.5.0-alpha.8565fd2b (dev)

This PR contains the following updates:

Package
Type
Update
Change

antlr4ts
dependencies
patch
0.5.0-alpha.3 -> 0.5.0-alpha.8565fd2b

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.


Feature/filter metrics v3.2

This adds support for measuring time for the entire request processing, and the request and response filtering steps, in addition to the current measurement of the time used by the request method itself. In addition, support is added for letting users specify the clock to be used.
No extra metrics are added for methods with @Timed annotations that specify an explicit name, as it's not really clear what those extra metrics should be named, and it seems wrong to add attributes to the @Timed annotation for jersey-specific concepts. Ideas for how to add the extra metrics for explicitly named methods welcome!
Corresponding PR for master: #1119

This looks like an interesting addition, could you explain your use case? Do you have several filters which take a lot of time to process? Or do you want to measure Jersey's overhead along with the method?

Sure! I'm working on some services related to handling of case folders for the Norwegian Tax Authority. This involves some rather complex data structures that can contain highly sensitive information in several places.
One of the cases where filter metrics is valuable is in an application that handles modification requests for cases. If we get a simple operation (e.g. adding a comment) on a complicated case, a filter we have for preprocessing the case to find all information that may be relevant for an authorisation decision so that we in a later stage can make an informed decision, can easily take more time than the operation itself. We also have other filters that make HTTP calls to a third-party service, so including or not including the request filter stage in the metric for the endpoint makes a big difference - our consumers care about the response time for the request as a whole, and monitoring just the time spent by the request method isn't enough.

Was that explanation enough? Is there anything else that we can do to progress on this feature?

I will look at it more one more time tomorrow and if it's OK will make a new 3.2.5 release.

Thank you very much for the contribution! The feature looks very useful and the implementation seems backward compatible and don't create a big performance penalty.

I've decided to go with this change only for 4.0.0 and keep the 3.2 branch only for bugfixes.


Add error monitoring section to privacy policy

Is there anything else we need to use sentry in a GdpR compliant way?

@mclrc I mean as long as we dont store any data with which a person can be identified we should be good to go.

@mclrc What does the dynamic privacy policy date solve or why did you choose to implement it?

@johan-t I implemented a dynamic blocking popup in the app that checks the confirmed and most recent privacy policy versions and forces users to accept the new one before using the app. this means we don't need to ship app updates (and have them pushed out to all users, + reviewed) before we change something that requires a change to the privacy policy.


How Does This Work

Hi. I'd like to use this. Unfortunately I cannot find any info on how to configure this exactly.
The below does not work with a locally running unsecured Trino:
      {
        "name": "Trino",
        "driver": "Trino Driver",
        "server": "http://localhost:8080",
        "username": "user"
      }

This only gives:
Error selecting connection Request failed with status code 401, {"code":-1,"data":{"driver":"Trino Driver","driverOptions":{}}}

Could someone please assist?

Works by setting user instead of username.


chore: docs dir

Also, maybe a docs/SECURITY.md file would be interesting to commit
It is about security policies, which you might easily be way more familiar than me with

Also, maybe a docs/SECURITY.md file would be interesting to feat
It is about security policies, which you might easily be way more familiar than me with

Yup I have a task for it, just need to get around to it. Probably after i get openscap scans working
https://github.com/secureblue/secureblue/issues/521

Ohkay, 2 days late lmao


What am I doing wrong with waitFor and dispatcherID?

Not sure if this is very McFly related but here we go, I have two stores and I do something like:
case ActionTypes.SOME_ACTION: //User clicks
     mcFly.dispatcher.waitFor([SecondStore.dispatcherID]);
     _elements = {};
     break;

And my other store, for the same action, it does:
case ActionTypes.SOME_ACTION: //User clicks
     Object.assign(_myElements, FirstStore.getElements());
     break;

In the component that I am using them, I require them like:
var SecondStore = require('../stores/SecondStore');
var FirstStore = require('../stores/FirstStore');

The error I am getting is:
Error: Invariant Violation: Dispatcher.waitFor(...): `undefined` does not map to a registered callback.
So basically, SecondStore.dispatcherID is undefined. But, if I require them like:
var FirstStore = require('../stores/FirstStore');
var SecondStore = require('../stores/SecondStore');

I get:
    at Object.ID_2 ```

Which tells me that FirstStore.getElements() is not defined.

What am I missing? I cannot access to FirstStore from SecondStore and to SecondStore from the FirstStore? Am I creating a circular dependency ? The thing is that if in the first example, instead of using ```mcFly.dispatcher.waitFor([SecondStore.dispatcherID]);``` I use the id directly ```mcFly.dispatcher.waitFor(["ID_2"])```;, then works as expected. Can I retrieve the dispatcherID in some other way? something like ```mcFly.dispatcher.ids["SecondStore"]``` ?

---
Edit: Oh... maybe it is related to: https://facebook.github.io/react/blog/2014/07/30/flux-actions-and-the-dispatcher.html#why-we-need-a-dispatcher

> Problems arise, however, if we have circular dependencies. That is, if Store A needs to wait for Store B, and Store B needs to wait for Store A, we could wind up in an endless loop. The dispatcher now available in the Flux repo protects against this by throwing an informative error to alert the developer that this problem has occurred. The developer can then create a third store and resolve the circular dependency.

If that is... I'd be nice to see the warning.

Yeah, I think you have a circular dependency.  The first problem you have is how you'll require the stores.  You can get around the require problem with a dynamic, inline require (in some build systems, at least), but this is pretty hacky.
You can just console log the value of SecondStore in FirstStore, and the value of FirstStore in SecondStore.  If one of them comes back as an empty object, {}, then your build system is choking on the circular dependency.
The warning is there for situation where you have actually done the hacky require, and now you have set up a circular dependency for a particular action type.
In either case, the answer is always goes 2 to 3 or 2 to 1.  That is, when you have two stores in circular dependency, you need to either create a new store to resolve it, or create a resolution down in the view layer (3 entities, not 2).  Alternatively you can combine the stores into a single store.  (1 entity, not 2).

Yea, in this case, there was no warning though so I had to debug it a bit. I feel that the option 2 to 1 would be simpler in this case (merging the data when the user clicks).
Thanks for answering :)


Connection Resets repeatedly

This error show up after every few files downloaded. I've run the script ~20 times to complete the download. What's the problem? And is there a fix?
I'm running the command on Ubuntu 16.04 with python 2.7.

@itsdpm i will check & fix ASAP.


Undo/redo

Undo/redo for text editing when using the keyboard.

A new private UndoRedo widget saves a stack of recent TextEditingValues, and provides the current state after undo/redo operations.
Currently does not hook up to 3 finger swipe to undo/redo on iOS, but we should in the future.  I think this might be possible even inside of UndoRedo by adding a gesture detector there...  https://github.com/flutter/flutter/issues/34749
The throttling behavior is kind of a "best fit" of all of our platforms.  It seems like there are very subtle differences between how all of these platforms do this (see https://github.com/flutter/flutter/issues/24222#issuecomment-868930150).  I'll keep an eye out if users want different per-platform behavior or if they want control over it themselves, but for now hopefully mine is good enough that most users won't notice a difference.
Fixes https://github.com/flutter/flutter/issues/24222

@chunhtai About your ideas:

Undo/redo from right click and the system menu.  This should work out nicely thanks to Actions/Intents, you should be able to Actions.invoke the UndoTextIntent or RedoTextIntent.
I hadn't thought about that.  I just tried turning on VoiceOver on my Mac and playing around with TextEdit and with a Flutter app.  In TextEdit, it doesn't verbally say "undo" when I cmd+z, it speaks the text nearest to the cursor.  On the Flutter app, it speaks the letter nearest the cursor (unrelated to undo/redo, that seems like a bug, do you know if we have an issue for that?).  Let me know if there's anything else I can check or that we should change for this PR.

it speaks the text nearest to the cursor. On the Flutter app, it speaks the letter nearest the cursor (unrelated to undo/redo, that seems like a bug, do you know if we have an issue for that?). Let me know if there's anything else I can check or that we should change for this PR.

It is probably treats it as text changes, if you type a character, it will pronounce that character, if you delete a character, it will pronounce that character with a deeper tone.  If you try on a native text field, does it pronounce redo/undo?

Is it possible to somehow disable/override your undo work? I like it, just some people already have their own undo solution, so I'm afraid it can be a breaking change.

@chunhtai No, it never said "undo" or "redo" on native.

@chunhtai No, it never said "undo" or "redo" on native.

oh great! then we don't need to worry about it.

@bernaferrari Good point, thanks for bringing that up.  If I make my actions overridable, you could disable it like this:
Actions(
  actions: {
    UndoTextIntent: DoNothingAction(),
    RedoTextIntent: DoNothingAction(),
  },
  child: ...
)

You could put this near the root of your application so that it will apply to all EditableTexts in your app.
I could also add a parameter to EditableText and TextField, etc. but maybe it's best just to disable it with Actions like this.

That could somehow work. In my app I have a custom undo implementation (which right now doesn't work inside a TextField, lol) but that could be handy eventually.


ECS private registry support design

Pull Request Checklist

[ ] Testing

N/A, design doc

[ ] Docs

Documents feature design

[ ] Title and Description

"feat" prefix
addresses #1698

[ ] Sensitive Modules (requires 2 PR approvers)

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Oh oops. Didn't mean to approve yet :)

@rix0rrr @SoManyHs  Updated doc to reflect feedback. Please let me know if you have any additional comments (including new name for "DockerHubImage"). Thanks!

@rix0rrr updated per feedback re: abstracting render func & limiting credendials property access.


build: Perform build in GitHub Actions

Following up from comment https://github.com/intlify/bundle-tools/pull/160#issuecomment-1210493313: This performs a build to ensure the correctness of every commit and pull request.

Thanks!


dynamic_modules: Move abi.h into hdrs

cc @mathetake

i think this is correct anyway - ive had to do similar with other targets when running clang-tidy in the past - but i was hoping it would resolve the repeated clang-tidy errors that this file is throwing - sadly, it didnt


Live weather as overlay on the map

Weather data on the map

actual weather
wind direction
humidity

Maybe integrate weather maps from OpenWeatherMap (https://openweathermap.org/api/weathermaps). There are some interesting weather layers (Clouds, Precipitation, Sea level pressure, Wind speed, Temperature) and compatible with OpenLayers. Free up to 60 calls/minute and 1,000,000 calls/month.

Another and simpler solution would be to integrate Wetter-Alarm. Wetter-Alarm is a Swiss weather app that is officially supported by many building insurance companies. With a GET request to the following URLs, weather alarms and a weather map (as GeoJSON) can be called up. Everything should be free so far.
Weather alarms for all of Switzerland: https://sta.my.wetteralarm.ch/v7/alarms/meteo.json
Weather map of the whole of Switzerland: https://sta.my.wetteralarm.ch/v7/maps/meteo.geojson

The sta gives me back test data.
Just remove it and use these links:

https://my.wetteralarm.ch/v7/alarms/meteo.json
https://my.wetteralarm.ch/v7/maps/meteo.geojson


Add ObservableStateMachineTrigger to R3.Unity

Added "ObservableStateMachineTrigger" that existed in UniRx.
The implementation is almost a copy of the UniRx side.

StateMachineBehaviour cannot emit OnCompleted because it cannot detect the end of the StateMachineBehaviour.
However, I am afraid that implementing IDisposable in StateMachineBehaviour may be inconvenient.
Is it unnecessary to implement termination?

It's a unique system in terms of how it's used, so I think it's fine as it is!


European Patent Office

The EPO has ~2 terabytes of patent applications in a variety of European languages.

This would be a good addition.


pmdarima fails frequently with "initial MA coefficients are not invertible" where R succeeds

I'm fitting a very simple model for the taylor series from R's forecast library, and trying to reproduce it with pmdarima:
If I do this:
Arima(taylor, order=c(0,0,1), lambda = NULL)
and this:
arima.ARIMA(order=(0,0,1), trace=1, seasonal=False, transparams=True, with_intercept=True).fit(taylor)
I get the exact same model. And the same works if I use order (0,0,1).
However, if I try order (1,0,1) R fits it nicely, while pmdarima fails with: ValueError: The computed initial MA coefficients are not invertible.
Why is that? Is there something not implemented in the pmdarima impl? or am I missing something in the way I execute it?
It's also frequently failing with initial AR coefficients are not stationary where R does not (can open a separate bug for reproducing this if needed)

I'll look into it. Keep in mind the ARIMA implementation itself uses statsmodels under the hood. Perhaps you could start sleuthing there. I've got several issues to dig through in my (limited) spare time, so any investigation you can do on your own always makes the maintainer's life easier.

ok, I made some progress, but still confused.
apparently this has to do with an old issue that deals with differences in approach between R stats package and python statsmodels package: https://github.com/statsmodels/statsmodels/issues/1155/ , also https://github.com/statsmodels/statsmodels/issues/5629 and others.
ARIMA models require stationarity of AR terms, and invertibility of MA terms. This can be tested by making sure the inverse roots (1/r) of the AR and MA lag operator polynoms are all within the unit circle.
The R implementation somehow knows to enforce these constraints on its fitted model, but it can be borderline (almost outside the unit circle). In my case:
> 1/forecast:::arroots(fit2)$roots
[1] 0.9813966+0i
> 1/forecast:::maroots(fit2)$roots
[1] -0.7123106+0i

and you can see that the AR term is almost not-stationary (which means that the model's predictions won't be good). I gathered that in such cases the method statsmodels uses to estimate the starting parameters fails instead of generating this unstable model.
But that still doesn't explain why in this model the AR term is the problematic one, while the error message talks about the MA term...

Awesome sleuthing! Thanks for taking a look into this. Chad Fulton had a suggestion on one of the threads:

In particular, you can pass your own starting parameters, for example setting the "bad' values to zeros.

In fact, the SARIMAX model in statsmodels seems like it will do this automatically. However, pmdarima only uses a SARIMAX if the seasonal order is non-None. I can force a SARIMAX to fit in this fashion by zeroing out the seasonal order:
>>> model = arima.ARIMA(order=(1,0,1), seasonal_order=(0, 0, 0, 0), transparams=True, with_intercept=True).fit(taylor)
/anaconda3/envs/pmdenv/lib/python3.6/site-packages/statsmodels/tsa/statespace/sarimax.py:949: UserWarning: Non-stationary starting autoregressive parameters found. Using zeros as starting parameters.
  warn('Non-stationary starting autoregressive parameters'
/anaconda3/envs/pmdenv/lib/python3.6/site-packages/statsmodels/tsa/statespace/sarimax.py:961: UserWarning: Non-invertible starting MA parameters found. Using zeros as starting parameters.
  warn('Non-invertible starting MA parameters found.'
/anaconda3/envs/pmdenv/lib/python3.6/site-packages/statsmodels/base/model.py:512: ConvergenceWarning: Maximum Likelihood optimization failed to converge. Check mle_retvals
  "Check mle_retvals", ConvergenceWarning)
>>> model
ARIMA(callback=None, disp=0, maxiter=None, method=None, order=(1, 0, 1),
   out_of_sample_size=0, scoring='mse', scoring_args=None,
   seasonal_order=(0, 0, 0, 0), solver='lbfgs', start_params=None,
   suppress_warnings=False, transparams=True, trend=None,
   with_intercept=True)
>>> model.predict(5)
array([22454.91502187, 22460.22253038, 22465.5125742 , 22470.78521078,
       22476.04049741])

And when I inspect the inverted roots, I get virtually the same results as in R:
>>> 1/model.arroots()
array([0.99670944])
>>> 1/model.maroots()
array([-0.7028633])

also, how can you force a SARIMAX on auto_arima?

wow great! got perfect match between the 2 libraries when I use the seasonal_order=(0, 0, 0, 0) trick, and also make sure to sync the with_intercept=False with the include.drift=FALSE which is the default for forecast:::Arima.
thanks so much, go ahead and close - just one last question: should there any indication for the model being borderline and junky in the confints or the s.e for the arima terms? or is the only way to detect that this happened is by checking the roots of the polynoms?

I suppose you could try to force it like this:
>>> arima.auto_arima(taylor, seasonal=True, transparams=True, with_intercept=False, start_P=0, D=0, start_Q=0, m=0, max_P=0, max_Q=0)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/taylor.smith/Documents/Personal/pmdarima/pmdarima/arima/auto.py", line 238, in auto_arima
    raise ValueError('m must be a positive integer (> 0)')
ValueError: m must be a positive integer (> 0)

but there's a check I have for values of m... I could back out the check for positive m if D is set (since no test of seasonality will occur), but I kinda think it's better not to. Now that we know a model can be forced with the pmdarima.ARIMA class directly, it feels dangerous to allow a backdoor into the pmdarima.auto_arima, since someone could accidentally get a bad model as a result of their grid search. I like the idea of consenting adults are allowed to directly create their own bad model, but I want to avoid it coming back in the auto_arima results.
As far as whether to warn for borderline unstable models, I think statsmodels does a really good job of blowing up the stack if you even get close to a bad set of parameters. The amount of effort you have to go through to force one of those models and the plethora of HessianInversionWarnings might be enough 😁


Do you have migration guidance (ngrx infrastructure -> ngrx-data)?

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Hello,
Would you be so kind and let me know if you have migration guidance
from a project with classic ngrx infrastructure towards this awesome library of yours.
Do they coexist? - or I need 2 different "sandboxes"
Thank you!
p.s. this library is something I was waiting for since I've added 3rd model to our project :)

Sorry I don't and I probably won't get to it. I'm too busy using it. :)
But it you want to write one I'd be happy to reference it.


Can this dependency be found in npm? Npm cannot found this version

As I use a fork of React Native Agora uikit it uses old agora-react-native-rtm from AgoraIO, but not updated from 2 years ago. I've found this, but I cannot use this dependency

@elenitaex5 This repo is not publish yet, we will publish it in the feature, you can use it by tag:
npm install<EMAIL_ADDRESS>


Better navigation

This adds the flutter/navigation plugin and sends a back button to a flutter app when mouse button 4 is pressed.

Nice work as usual.


feat(tfmigrate-plan): support testing with Conftest

Close #511

https://github.com/suzuki-shunsuke/tfaction/actions/runs/3052180101

https://github.com/suzuki-shunsuke/tfaction/actions/runs/3052309294/jobs/4921546521


On SceneRecorder, use the same parsing method as the decorators to en…

…sure that it accounts for properties serialized with different names.
Related forum issue: https://forum.babylonjs.com/t/scenerecorder-not-applying-every-change/19120/9

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13626/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13626/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13626/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13626/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13626/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13626/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13626/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13626/merge#BCU1XR#0


Incorrect digest when xml contains xml:lang

When you have an xml:lang attribute in your xml the calculated digest is wrong. E.g:
<library>
    <book>
        <name xml:lang="en">Harry Potter</name>
    </book>
</library>

The error works both ways, if you validate using xml-crypto itself it returns true.
Reproduction

Go to xml-crypto/example.
node example.js
xmlsec1 --verify --id-attr:Id book --pubkey-cert-pem client_public.pem result.xml. Note that it succeeds.
Add xml:lang="en" on the name tag.
node example.js
xmlsec1 --verify --id-attr:Id book --pubkey-cert-pem client_public.pem result.xmll. Note that it outputs an error:

func=xmlSecOpenSSLEvpDigestVerify:file=digests.c:line=229:obj=sha1:subj=unknown:error=12:invalid data:data and digest do not match
FAIL
SignedInfo References (ok/all): 0/1
Manifests References (ok/all): 0/0
Error: failed to verify file "result.xml"

thanks @marklagendijk for your contribution.
I'm also not sure what the spec means. the spec here https://www.w3.org/TR/xml-exc-c14n/ says:

implementations of this specification only render attributes from the "XML" namespace (e.g., xml:lang, xml:space, and xml:base) when they are in the subset being serialized;

based on this I believe the attribute with the xml prefix should be serialized in the example you gave.
of course sometimes most implementations behave different than the standard in which case if might be ok for us to adjust too. what do you think? any idea how common this is?
cc @bjrmatos

is there some online exc14n service? we can compare the output produced by an online service or a script in another lang (php, c#, java)

@yaronn the part of the spec you quoted talks about the attributes themselves, not about their namespace.
The question is whether you need to explicitly define the xml namespace. As I understand it you should not do this, because this namespace is a reserved namespace which is bound by default, and should not be explicitly defined.
I am quite sure that my fix is according to spec, or at least according to all implementations of the spec. I have tested this with several implementations:

xmlsec as mentioned in this issue.
Python my implementation replaced a Python script which signed some xml which it send to a third party. I'm not sure if this used a native Python module or some other module.
Some third party. The third party which my script communicated with did not accept the digest, until I applied this fix. I'm not sure what implementation they use. Possibly .NET.
Some xml editor. A colleague of mine had some fancy XML editor which was also able to check signatures. Only after applying my fix, it accepted the digest.

I think this is enough proof to apply this fix.

interesting, didn't know about the xml namespace is reserved (makes sense)
LGTM!

@marklagendijk - makes sense, thanks for the research & fix!
@bjrmatos I think we can merge this and publish a version together with #98.

published in v0.8.3! thnks @marklagendijk


Custom tool &  openai-functions agent

How can I pass custom tool into openai-functions?
  const executor = await initializeAgentExecutorWithOptions(
      [new DynamicStructuredTool({ name: 'test', description: 'test', funs: () => 'test' })],
      new ChatOpenAI({ temperature: 0, modelName: 'gpt-3.5-turbo-0613' }),
      {
        agentType: "openai-functions",
        verbose: true,
        maxIterations: 3
      }
   );

return 400 error from open ai. However
    const executor = await initializeAgentExecutorWithOptions(
      [new Calculator()],
      new ChatOpenAI({ temperature: 0, modelName: 'gpt-3.5-turbo-0613' }),
      {
        agentType: "openai-functions",
        verbose: true,
        maxIterations: 3
      }
    );

works fine

I think you will have to specify a Zod schema as one of the options, and your function should accept input that matches the schema. See here: https://js.langchain.com/docs/api/tools/interfaces/DynamicStructuredToolInput#schema
Example schema:
import { z } from "zod";

const schema = z.object({
  num1: z
    .number()
    .int()
    .nonnegative()
    .describe("Description goes here..."),
  num2: ...,
});

Example function:
const func = (input: z.input<schema>) => {
  return input.num1 + input.num2;
}

I tried this.. still the same problem

Were you able to get this working?

DynamicStructuredTool probably needs to be updated to support openai-functions. Instead, you can manually define a subclass of StructuredTool like so:
class Test extends StructuredTool {
  get lc_namespace() {
    return [...super.lc_namespace, "test"];
  }

  name = "test";
  description = "A test tool";

  schema = z.object({
    arg1: z
      .number()
      .describe("First argument"),
    arg2: z
      .string()
      .describe(
        "Second argument"
      ),
  });

  async _call(input: z.input<this["schema"]>) {
    // Tool logic goes here...
  }
}


Consider opt-in to strong mode

Strong mode is supported in the new iojs and EG seems to do a lot of the optimisations by default anyway so it would be nice to be able to opt-in (or perhaps make it the default)?

Ah, yeah, that would be cool! I would have to make some adjustments, though. Since originally I compiled to ES5, optional and rest arguments in EG functions do not compile to ES6 optional/rest arguments, but use arguments instead (this would be a good thing to fix). Also, some object declarations (not the simple ones) build an empty object and then accumulate properties on it (which I think strong mode disallows?) I will keep this in mind, still.

Discussed in gitter but repeating here for posterity.
Strong mode does allow a long-handed way to dynamically add properties:
Object.defineProperty(obj, 'a', { value: 'This property was added dynamically!' });


Module hangs if it imports an errored module

ResolveExternalModuleDependencies has no problem today resolving against a module that has already been determined to be in an error state.  In this case, it has already notified its dependents at the time of its failure, and no further notification will occur.  As a result, the module hangs if we do not handle this scenario.
This fix addresses the issue by not proceeding if the module being imported is already in an error state.  The error is passed upward.

Hi @AtOMiCNebula, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jeff Weiner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@boingoing @akroshg Baby's first ChakraCore change! ;)

Could you create a native unittest for this?
this PR  #1803 has added native unittests to craft such scenario.

LGTM

@boingoing @AtOMiCNebula Is this PR waiting on anything? Can we get that test added and merge this in? (At this point this should probably go into release/1.4 so the PR will need to be retargeted.)

I let this one get super stale, sorry!  I hope to be able to revisit this in the not too distant future; I'll close this PR for now, and open a new PR after rebasing the change onto a more recent master. :)

Thanks @AtOMiCNebula! Looking forward to the update!


Add files via upload

Is this just spam? I am going to close this PR because it looks likes spam, if it is not, you are welcome to reopen and tell me.


kubevirt: 0.56.1 -> 0.57.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/kubevirt/versions.
meta.description for kubevirt is: "Client tool to use advanced features such as console access"
meta.homepage for kubevirt is: "https://kubevirt.io/"
meta.changelog for kubevirt is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.57.0 with grep in /nix/store/6x6cg649f6bwc97bj0qqzbp3cmrjzic4-kubevirt-0.57.0
found 0.57.0 in filename of file in /nix/store/6x6cg649f6bwc97bj0qqzbp3cmrjzic4-kubevirt-0.57.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
kubevirt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6x6cg649f6bwc97bj0qqzbp3cmrjzic4-kubevirt-0.57.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kubevirt https://github.com/r-ryantm/nixpkgs/archive/9fd75b45a0e47f72c04c24ca1d8b730d90d3606b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6x6cg649f6bwc97bj0qqzbp3cmrjzic4-kubevirt-0.57.0
ls -la /nix/store/6x6cg649f6bwc97bj0qqzbp3cmrjzic4-kubevirt-0.57.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kubevirt

Maintainer pings
cc @haslersn for testing.

Result of nixpkgs-review pr 192208 run on x86_64-linux 1

1 package built:

kubevirt


Unable to generate API documentation

This http://[server_ip]/doc/?doc=api_indexroute (from the help LS documentation) results in the following exception visible in plain HTML;
### Uncaught exception (HTTP: 404) ### Exception: No such documentation file. in /var/www/libresignage/public/doc/index.php:38 Stack trace: #0 {main}

When I try to generate the doxygen docs (with; make doxygen-docs) I get the following error:
...
Running dot for graph 331/332
Running dot for graph 332/332
Patching output file 1/155
error: problems opening map file /root/libresignage/original/LibreSignage/doxygen_docs/html/classlibresignage_1_1api_1_1APIException__inherit__graph.map for inclusion in the docs!
If you installed Graphviz/dot after a previous failing run,
try deleting the output directory and rerun doxygen.
error: problems opening map file /root/libresignage/original/LibreSignage/doxygen_docs/html/classlibresignage_1_1api_1_1APIException__coll__graph.map for inclusion in the docs!
If you installed Graphviz/dot after a previous failing run,
try deleting the output directory and rerun doxygen.
Patching output file 2/155
error: problem writing FIG 0 figure!
lookup cache used 2793/65536 hits=10793 misses=2857
finished...

Ubuntu 18.04 with eerotal/LibreSignage:latest clean install

The API index documentation page was removed but I forgot to remove the link from the documentation index page. That's already fixed in the next major release though.
Please try installing graphviz by running sudo apt install graphviz to see if that fixes the error that you got while generating the Doxygen docs.

Running sudo apt install graphviz fixed my error.


Remove usage of handle based UM APIs

There is still some code (test code, netsh) which uses handle based APIs. Since the fd based APIs are now implemented, the caller code should be changed to use fd based APIs. Once the handle based APIs are no longer used, they can be deleted.

not blocking any planned work. just cleanup.

Remining APIs include:

[ ] ebpf_api_load_program - used by netsh helper
[ ] ebpf_api_create_map - used by common_tests.cpp
[ ] ebpf_api_get_next_program - no implementation, only present in a header file
[ ] ebpf_api_pin_object - used by netsh helper and common_tests.cpp
[ ] ebpf_api_get_pinned_map - used by common_tests.cpp
[ ] ebpf_api_link_program - used by netsh helper and tests\end_to_end\helpers.h
[ ] ebpf_api_unlink_program - used by tests\end_to_end\helpers.h
[ ] ebpf_api_close_handle - used by netsh helper, common_tests.cpp, and tests\end_to_end\helpers.h


Add Endpoint data to invoke parameters

Some cluster logic requires details from the endpoint and later also access to other clusters on the endpoint. This PR introduces this in a minimalistic way - it will get refactored once again when new API is fully in place. But it also helps the use for GroupsCluster and allows in parallel Cluster logic development (e.g. Lighting control for onoff or scenes) - even with a refactoring later.

@Apollon77 I wonder if you can roll this, #123, #100, #131, and #134 into a single PR.  Each looks ok on their own, but would be more effective to test/review all as one fully functional PR to help avoid regressions during merge.


Atom with Electron 1.6.9+ causes dev tools to pause during autocomplete

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Electron upgrade to 1.6.9+ causes dev tools to pause during autocomplete
Steps to Reproduce

Open Atom off master currently
Open dev tools
go to sources and click pause

type in something to auto complete.

Expected behavior: [What you expect to happen]
Atom doesn't pause when using dev tools in console while being paused
Actual behavior: [What actually happens]
Atom seems to pause a lot while typing and autocompleting.
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
Atom    : 1.23.0-dev-c9c495792
Electron: 1.6.14
Chrome  : 56.0.2924.87
Node    : 7.4.0
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
/cc @Ben3eeE @nathansobo

going back versions I see this in atom 1.18.0 that has Electron 1.3.15
On 1.15.0 of Atom this doesn't occur with Electron 1.3.13

@ungb IT would be helpful to build Atom 1.15 with Electron 1.3.15 (it will probably just work) and see if it was the Electron bump that caused it. What about Atom 1.16 and 1.17?

1.15 with Electron 1.3.15 is not slow.
1.16 with Electron 1.3.13 is not slow.
Working on checking 1.17

Closed via https://github.com/atom/atom/commit/3f0f72ad0b3d33490a02ddcf25c4ed49b5a1f75e