PizzaBot - Quitting a form throws exception

I was facing issue in my bot where quitting the form throws System.ArgumentNullException exception.
Checked it with PizzaBot Sample and the same issue is present. This seems to be happening after the latest release. Has the way to handle quit changed?

It does throw FormCancelledException. But it goes through and throws InvalidNextException because next is null in var next = await leaf.PollAsync(this, context); in L220 Fiber.cs and consequently ArgumentNullException from SetField.cs L55 CheckNull<T>
I completely forgot to put stack dump when reporting the issue. Sorry for that.
Message from Emulator:
{
  "message": "An error has occurred.",
  "exceptionMessage": "Value cannot be null.\r\nParameter name: wait",
  "exceptionType": "System.ArgumentNullException",
  "stackTrace": "   at Microsoft.Bot.Builder.Internals.Fibers.Wait`2.Microsoft.Bot.Builder.Internals.Fibers.IAwaiter<T>.GetResult() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Fibers\\Wait.cs:line 325\r\n   at Microsoft.Bot.Builder.Dialogs.Chain.LoopDialog`1.<ResumeAsync>d__3.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\Chain.cs:line 549\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Internals.DialogTask.ThunkResume`1.<Rest>d__4.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\DialogTask.cs:line 118\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at Microsoft.Bot.Builder.Internals.Fibers.Wait`2.<Microsoft-Bot-Builder-Internals-Fibers-IWait<C>-PollAsync>d__19.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Fibers\\Wait.cs:line 246\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at Microsoft.Bot.Builder.Internals.Fibers.Frame`1.<Microsoft-Bot-Builder-Internals-Fibers-IFrameLoop<C>-PollAsync>d__7.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Fibers\\Fiber.cs:line 114\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at Microsoft.Bot.Builder.Internals.Fibers.Fiber`1.<Microsoft-Bot-Builder-Internals-Fibers-IFiberLoop<C>-PollAsync>d__13.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Fibers\\Fiber.cs:line 233\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Internals.DialogTask.<Microsoft-Bot-Builder-Dialogs-Internals-IPostToBot-PostAsync>d__20`1.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\DialogTask.cs:line 246\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Internals.ReactiveDialogTask.<Microsoft-Bot-Builder-Dialogs-Internals-IPostToBot-PostAsync>d__5`1.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\DialogTask.cs:line 288\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Internals.LocalizedDialogTask.<Microsoft-Bot-Builder-Dialogs-Internals-IPostToBot-PostAsync>d__2`1.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\DialogTask.cs:line 343\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Internals.ScoringDialogTask`1.<Microsoft-Bot-Builder-Dialogs-Internals-IPostToBot-PostAsync>d__6`1.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\Scorable.cs:line 143\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Internals.PersistentDialogTask.<Microsoft-Bot-Builder-Dialogs-Internals-IPostToBot-PostAsync>d__5`1.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\DialogTask.cs:line 367\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at Microsoft.Bot.Builder.Dialogs.Internals.PersistentDialogTask.<Microsoft-Bot-Builder-Dialogs-Internals-IPostToBot-PostAsync>d__5`1.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\DialogTask.cs:line 372\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Conversation.<SendAsync>d__4.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\Conversation.cs:line 111\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at Microsoft.Bot.Builder.Dialogs.Conversation.<SendAsync>d__2.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Library\\Dialogs\\Conversation.cs:line 82\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at Microsoft.Bot.Sample.PizzaBot.MessagesController.<Post>d__2.MoveNext() in D:\\Experiment\\BotBuilder-master\\BotBuilder\\CSharp\\Samples\\PizzaBot\\Controllers\\MessagesController.cs:line 52\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at System.Threading.Tasks.TaskHelpersExtensions.<CastToObject>d__3`1.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at System.Web.Http.Controllers.ApiControllerActionInvoker.<InvokeActionAsyncCore>d__0.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at System.Web.Http.Controllers.ActionFilterResult.<ExecuteAsync>d__2.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at System.Web.Http.Filters.AuthorizationFilterAttribute.<ExecuteAuthorizationFilterAsyncCore>d__2.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__1.MoveNext()"
}

StackTrace from this.fail in IAwaiter<T>.GetResult() in Wait.cs
   at Microsoft.Bot.Builder.Internals.Fibers.SetField.CheckNull[T](String name, T value) in D:\Experiment\BotBuilder-master\BotBuilder\CSharp\Library\Fibers\SetField.cs:line 55
   at Microsoft.Bot.Builder.Internals.Fibers.SetField.NotNull[T](T& field, String name, T value) in D:\Experiment\BotBuilder-master\BotBuilder\CSharp\Library\Fibers\SetField.cs:line 47
   at Microsoft.Bot.Builder.Internals.Fibers.InvalidWaitException..ctor(String message, IWait wait) in D:\Experiment\BotBuilder-master\BotBuilder\CSharp\Library\Fibers\Exceptions.cs:line 49
   at Microsoft.Bot.Builder.Internals.Fibers.InvalidNextException..ctor(IWait wait) in D:\Experiment\BotBuilder-master\BotBuilder\CSharp\Library\Fibers\Exceptions.cs:line 112
   at Microsoft.Bot.Builder.Internals.Fibers.Fiber`1.<Microsoft-Bot-Builder-Internals-Fibers-IFiberLoop<C>-PollAsync>d__13.MoveNext() in D:\Experiment\BotBuilder-master\BotBuilder\CSharp\Library\Fibers\Fiber.cs:line 225

Hope this helps.

Most likely this is because you do not handle an exception when chaining using a form with Chain.DefaultIfException.  The next step in the chain gets the FormCanceledException and rightly throws an exception because there is no value.  I do see we did not update the documentation, so I will add this.  Please reopen if this does not address your problem.

@chrimc62 I tried the following three line in Pizza Sample and none of it worked. What am I doing wrong? Also is it possible to update the Pizza sample to demonstrate the correct usage.
//return Chain.From(() => new PizzaOrderDialog(BuildForm)).DefaultIfException<PizzaOrder, FormCanceledException<PizzaOrder>>();
//return Chain.From(() => new PizzaOrderDialog(BuildForm)).DefaultIfException<PizzaOrder, FormCanceledException>();
return Chain.From(() => new PizzaOrderDialog(BuildForm)).DefaultIfException<PizzaOrder>();

@chrimc62 I am very sorry for this but it is now working. Exception is now getting swallowed. I dont know why it was not working last week.


Make room for two articles in Trending Topics dropdown (so, fewer topics)

I think this is self-explanatory, but let me know if you need to discuss or have me mock up

This is updated on our working branch


Merge changes from newBatchOperationContext

I'm using a batchOperationContext to import a big data set. It works but I don't know why objects from one entity are saved on disk but not on memory. I'm trying to re-fetch from disk but can't make it work.
Right now the only thing that works is creating a new batchOperationContext and fetching the entity there but this seems to be overkill.
Any ideas? How are changes from batchOperationContext merged into main context? Any way to reset main context and re-fetch from disk?

Changes that occur in a batchOperationContext are not ever merged into the main context by the CoreDataStack. This is also intentional. You can read more about this in our blog post introducing the stack: Introducing the Big Nerd Ranch Core Data Stack Here is the relevant excerpt regarding this.

The changes could be propagated across contexts using the same pattern described in shared persistent store coordinator pattern using mergeChangesFromContextDidSaveNotification(). However, since this pattern is built for performance, it’s preferable to simply listen for the NSManagedObjectContextDidSaveNotification and re-perform your fetch request on the main queue context stack. This will be considerably faster than trying to merge thousands of objects between the two stacks.

You can see an example of inserting objects in a batchOperationContext and then refetching them in our unit tests. BatchOperationContextTests

Thanks for the quick reply @rcedwards , my issue was that I was downloading some data on main queue and after that some big import with duplicated data. That data already in memory didn't refresh from disk. Removed data duplication and not works as expected. Again, thanks.


Instructions for Two-fer excercise ambiguous

The instruction has the line: "If your friend likes cookies, and is named..." but the tests only check for the names and there's no input for whether that friend "likes" cookies or not. Either the instruction needs to be modified for specifying that there's no check for "liking the cookie or the tests have to be modified to check for both "liking" and the "name".

Please provide feedback on the instructions here:
https://github.com/exercism/problem-specifications/issues


[clang-tidy][cfg] Remove an alias from the extreme profile

It seems like that bugprone-narrowing-conversions check is the same as
the cppcoreguidelines-narrowing-conversions check.
Check this:
https://github.com/llvm/llvm-project/blob/c63522e6ba7782c335043893ae7cbd37eca24fe5/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp#L136-L137
It seems like both of these checks were included in the extreme
profile, thus each of these reports were duplicated basically.
Hereby I'm proposing to keep only one of them in the profile to
workaround this issue.
According to Compiler Explorer, clang-tidy reports these issues only
once, with the [check,alias,alias...] schema, thus it does the right
thing. However, PR #3238 introduced a logic that splits these reports
into individual reports.
I'm not sure if that is the right way of dealing with check aliases, but
we definitely need something more robust than including/excluding checks
from profiles.

@dkrupp


Demo URLs broken in docs

Commit: b6e5b8e
Steps to reproduce

Visit https://docs.higlass.io/track_types.html#d-heatmap
Click a link under the "Demo" heading of the 1D Heatmap section.

Observed behavior

403 Forbidden

Expected behavior

A 1D heatmap example from docs/examples/viewconfs loads

It seems that the HTML files in docs/examples are not included in the docs build directory _build


comment :: inconsistency bindcraft.py vs bindcraft.slurm

Hello.
bindccraft.py can be run without specfying settings_filter nor settings_advanced and will use, in this case, the following defaults
settings_filters/default_filters.json
settings_advanced/default_4stage_multimer.json
while bindcraft.slurm have hard requirement for both. well sort off, as if not provided thoses values are transferd to bindcraft.py as empty ones.

Good catch, thank you! Will be fixed in the next version


Avoid unnecessary releases

Q
A

Issue Type
Feature Request

Deployer Version
6.3.0

Local Machine OS
All

Remote Machine OS
All

Description
Each time I run dep deploy ..., the deployer will immediately work, and this is how it suppose to be, but sometimes I don't have any changes in my code, and if I run dep deploy ... a new unnecessary release will be created.
For example:
I use at command to run deployer every day at midnight:
at midnight dep deploy prod

Deployer has to skip the deployment if no changes were made into the git repo.
Solution
Whenever deployer finishes, a new file contains the last commit id will be created/updated in .dep folder.
The next time we deploy, deployer has to check if the current commit id matches the existing saved one, if so then it will skip the deployment.
I will work on this if accepted.

Nice idea

Howdy!
In versoin 6.4.7, this new "feature" will break deployment, if you don't have set any repository-URL because you're doing e.G. a deploy via CI by running composer + rsync to push the code to server.
This command should only run if repository is set: https://github.com/deployphp/deployer/blob/v6.4.7/recipe/deploy/prepare.php#L43-L45

@Chrico You just need to set the check_remote_head as follows:
# your ci deploy file.
set('check_remote_head', false)

check_remote_head is false by default. The problem is this line: https://github.com/deployphp/deployer/blob/v6.4.7/recipe/deploy/prepare.php#L45  which runs even if the repository  is not set.
Additonally it could be possible, that the server has no access to the repo itself. So you should probably use runLocally instead of run here as well.

@Chrico You are right, I'll look into that. Thanks.

I dot this. :) See 85aae9fd681028c28b27a5e118d4cd3422484c8d

Usage:
require 'recipe/deploy/check_remote.php';
after('deploy:prepare', 'deploy:check_remote');

trim was added at #628, but I think this is incorrect.


Block users

Hey @shelcia can you explain what we have to done in this issue, so that I can work on that.

Have an option to block user (add boolean maybe)

hey I would like to work on this issue. can you assign it to me under kwoc?
And do we need to add block button in the profile page or on the post   and whether it's a two way thing like both the blocked user and current user can't see each other's post?

I want to work on this @shelcia can you assign this to me

@shelcia I want to work on this issue can you please assign this to me


[Kaggle Bug]: can't install sd_dreambooth_extension

Is there an existing issue for this?

[X] I have searched the existing issues and checked the recent builds/commits

Are you using the latest version of the colab notebook?

[X] Yes, i am using the latest version from the repo

Which colab notebook did you use?
using latest stable-diffusion-webui-kaggle
Which repo branch did the colab you use comes from ?
v2.0
Which tunnel did you use ?
--share (Gradio Tunnel)
What happened?
I try to install sd_dreambooth_extension via GUI / git clone both fail.
Console logs
Restarting UI...
[AddNet] Updating model hashes...
0it [00:00, ?it/s]
Error loading script: api.py
Traceback (most recent call last):
  File "/kaggle/working/stable-diffusion-webui/modules/scripts.py", line 229, in load_scripts
    script_module = script_loading.load_module(scriptfile.path)
  File "/kaggle/working/stable-diffusion-webui/modules/script_loading.py", line 11, in load_module
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/kaggle/working/stable-diffusion-webui/extensions/sd_dreambooth_extension/scripts/api.py", line 25, in <module>
    from extensions.sd_dreambooth_extension.dreambooth.diff_to_sd import compile_checkpoint
  File "/kaggle/working/stable-diffusion-webui/extensions/sd_dreambooth_extension/dreambooth/diff_to_sd.py", line 16, in <module>
    from diffusers import DiffusionPipeline
ModuleNotFoundError: No module named 'diffusers'

Error loading script: dreambooth.py
Traceback (most recent call last):
  File "/kaggle/working/stable-diffusion-webui/modules/scripts.py", line 229, in load_scripts
    script_module = script_loading.load_module(scriptfile.path)
  File "/kaggle/working/stable-diffusion-webui/modules/script_loading.py", line 11, in load_module
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/kaggle/working/stable-diffusion-webui/extensions/sd_dreambooth_extension/scripts/dreambooth.py", line 13, in <module>
    from diffusers.utils import logging as dl
ModuleNotFoundError: No module named 'diffusers'

Error loading script: main.py
Traceback (most recent call last):
  File "/kaggle/working/stable-diffusion-webui/modules/scripts.py", line 229, in load_scripts
    script_module = script_loading.load_module(scriptfile.path)
  File "/kaggle/working/stable-diffusion-webui/modules/script_loading.py", line 11, in load_module
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/kaggle/working/stable-diffusion-webui/extensions/sd_dreambooth_extension/scripts/main.py", line 8, in <module>
    from extensions.sd_dreambooth_extension.dreambooth.db_webhook import save_and_test_webhook
  File "/kaggle/working/stable-diffusion-webui/extensions/sd_dreambooth_extension/dreambooth/db_webhook.py", line 9, in <module>
    import discord_webhook
ModuleNotFoundError: No module named 'discord_webhook'

Hi @Asmedeus998 👋 I am preparing to support this plugin https://github.com/ddPn08/kohya-sd-scripts-webui
I will look at sd_dreambooth_extension for an alternative
please join this https://discord.gg/pdh69hs8cX discord from https://github.com/d8ahazard/sd_dreambooth_extension/wiki
you will see a google-colab channel people trying like you and tell us if it works 🥳


Attack on small enemies like skeever or goblins

When attacking skeever or goblins it does this animation that doesn't kill them

I believe I have this fixed for the next version, but I will need to extensively test with a large amount of small animals to ensure the issue is gone before I mark this fixed :)

This issue is fixed by removing zxlice's Backstab and Parry (caused the issue for NPCs other than Skeever, just not as often) and disabling Creature killmoves in Violens MCM.


FastTab in "Item Card" always Collapsed - BC OnPremise 19.0

On opening "Item Card" page: "Planning" "Item Tracking" and "Warehouse" FastTabs are always Collapsed, Eventhough the FastTabs were Expanded before closing the page.
Other FastTabs save the state (Collapsed/Expanded) when closing and opening the "Item Card", but it seems these 3 FastTabs dont.

This was discussed on Yammer. It'll be because they have conditional visibility. This doesn't seem related to AL extensibility in any case.

can you please elaborate, why does these 3 fasttabs have conditional visibility? can we overwrite this conditional visibility?

I don't know; I didn't develop the base application... You could probably override the Visible property in an extension, but it might be the case that having an explicitly set value, even if constant (instead of conditional), would defeat the user's last remembered expand/collapse state.
The Yammer thread I mentioned is here. MS quoted the internal reference 417407
https://www.yammer.com/dynamicsnavdev/#/Threads/show?threadId=1512967933386752
Anyway, to me (as Just Another User) it does seem like a platform issue, rather than one for extensibility in AL or the base apps.

when you say Platform issue, you mean i should post this issue in another place?
its odd when you have a page with 9 fasttabs, where 6 of these fasttabs saves the last state of the user expand/collapse, while the other 3 doesn't? i think all fasttabs should behave the same

Hi @Michel-up.
I've checked our internal issue and it is marked as fixed. So, the fix is available in 19.6 or 20.1. Please verify when you will be updated. I'll close your request for now, feel free to open a new one if something will be wrong.


[Languages] Dart List Datatype Methods

Topic Suggestion
[Languages] Dart List Datatype Methods
Key takeaways

Clear understanding of all the methods available in the dart for its List data type
Practical examples that are applicable during programming on a project
Hub of all methods available.

Article quality
While working on a mobile application project  I came across the need to check out what method to apply to a List in dart. I looked up the methods dart programming language has for its List data type, I could not find a singular hub where all the methods are explained with simplicity and clear example codes. They are a handful of recently added methods to the dart List and one source I came across was written as far back as 2019, was not up to date, and did not explain the functions of the methods in a clear simple way.
References
https://api.dart.dev/stable/2.15.1/dart-core/List-class.html
https://medium.com/flutter-community/useful-list-methods-in-dart-6e173cac803d

Concepts on List data types are well-covered in numerous tutorials and documentations. Therefore, this topic will not be of much value. Feel free to suggest another topic. Thanks

Concepts on List data types are well-covered in numerous tutorials and documentations. Therefore, this topic will not be of much value. Feel free to suggest another topic. Thanks

The topic is List Data type in Dart programming Language ( The language used in flutter applications ) and not just any language. There are few in-depth resources on this topic. If you check around. The available ones are not all that in-depth and do not cover all the recently added methods. Dart has a lot of methods that you cannot find online as I myself tried searching for a quick description while working on a project. This is a topic lacking on the internet.


Failure Image

Can we show failure image If image url is not valid ?

Hi, not currently, but I don't see a reason why I wouldn't be able to add this.
A feature request, I will definitely try supporting this.
Alternatively, if you are in a fix and would want to support this in  your app ASAP, you can scrape through the android fresco and SDWebImage documentation.
You can  easily expose the API in the module.
Thanks,
Sumeet


chore: change default api url value

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

When using any node version above 16, the cookie was not being persisted across browser refreshes. Changing "http://localhost:1337" -> "http://<IP_ADDRESS>:1337" fixed this issue. Refer to this issue: https://github.com/nuxt-modules/strapi/issues/229
Resolves: #229
Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

As a note, when using an oauth provider, this does imply changing the Callback URL and setting the HOST to <IP_ADDRESS> in your Strapi config.

Thanks. I think ppl would know to do that, I may be wrong tho..
Do you think it should be mentioned in the docs?

Hey.
I changed the host already to <IP_ADDRESS>, because my cookies were getting cleared, but the issue persists.
The URL is getting overwritten, then rewritten back from localhost to <IP_ADDRESS>
Video: https://share.cleanshot.com/JphHZDtB
Also got a hydration mismatch.

But it seems like a better option

@benjamincanac Yes, it works. I update strapi to 4.15.4 & Nuxt to 3.8.2 on Node v18.18.1
The URL in my .env is STRAPI_URL=http://localhost:1337 and it keeps the cookie in place event after a refresh. So the user stays logged in.
Good job 👍🏽

@BayBreezy  just checking. I've upgraded my strapi instance and nuxt to match yours. I'm still having the same issue. On your .env file, under a dev, prod environment that url will need to be what ever the strapi hosting URL is. I'm assuming you have changed that and tested ok?


[AIRFLOW-3319] - KubernetsExecutor: Need in try_number in  labels if getting them later

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3319
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

The _labels_to_key function attempts to use the try_number from the k8 labels, however no such label is applied to the pod resulting in an exception.
Modify pod executor to add this label to fix.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes flake8

Codecov Report

Merging #4163 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4163      +/-   ##
==========================================
- Coverage   77.68%   77.66%   -0.02%
==========================================
  Files         199      199
  Lines       16273    16273
==========================================
- Hits        12641    12638       -3
- Misses       3632     3635       +3

Impacted Files
Coverage Δ

airflow/jobs.py
77.09% <0%> (-0.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ee34c...588e292. Read the comment docs.

@kaxil - Would it be possible to get this in for the 1.10.2 release?  1.10.1 is completely broken for us when using the Kubernetes Executor.

@kppullin Definitely. @dlamblin Can you review this one?

@verdan Does this fix look right to you?
I know you created a branch https://github.com/apache/incubator-airflow/compare/master...vardancse:k8s_pod?expand=1
@wyndhblb Tests that cover this to avoid this breaking again in the future please!

@vardancse ^

I have experienced some error related to what this PR is trying to fix. Let me test this fix, I hope this can be reviewed and merged.

@kaxil we don't use this executor ourselves so I wouldn't be testing it, but okay I have only one real review comment about the try in a try.


Fixed a typo

Changed "projekt" to "project"

There are additional typos, but I'm going to close this PR so other's can complete the assignment.


ARROW-13136: [C++] Add coalesce function

Hmm, this has some Valgrind errors - taking a look.

@github-actions crossbow submit conda-cpp-valgrind

@github-actions crossbow submit test-conda-cpp-valgrind

@bkietz do you have time to review this? Do we want to add a benchmark here?

Performance is fairly meh. perf shows a decent amount of time spent in CopyValues/CopyOneValue just re-examining the Datum variant, calling Buffer::data(), etc.
-------------------------------------------------------------------------------------
Benchmark                           Time             CPU   Iterations UserCounters...
-------------------------------------------------------------------------------------
CoalesceBench64/1048576/0    19254992 ns     19255104 ns           37 bytes_per_second=1.62295G/s
CoalesceBench64/1048576/99   19281752 ns     19281409 ns           37 bytes_per_second=1.62058G/s

Trying an approach based on VisitSetBitRunsVoid may be beneficial, and/or manually hoisting the scalar-vs-array detection and having separate CopyScalarValues and CopyArrayValues.

Alright, this buys us ~50% more performance by specializing the common case
--------------------------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations UserCounters...
--------------------------------------------------------------------------------------------
CoalesceBench64/1048576/0           13335778 ns     13335766 ns           52 bytes_per_second=2.34332G/s
CoalesceBench64/1048576/99          13562011 ns     13561826 ns           51 bytes_per_second=2.30404G/s
CoalesceNonNullBench64/1048576/0    13552482 ns     13552397 ns           48 bytes_per_second=2.30587G/s
CoalesceNonNullBench64/1048576/99   13572235 ns     13572002 ns           51 bytes_per_second=2.30232G/s

Trying an approach based on VisitSetBitRunsVoid

IIUC this would require a varargs version of OptionalBitBlockCounter or Bitmap::VisitWords, which would probably be generally useful as varargs compute functions continue to proliferate

Basically, there was a lot of overhead from the fallback loop of "for offset in range(block size), if bit is set, copy one element" because 1) the 'copy one element' function used CopyBitmap which has a ton of overhead for copying one bit and 2) unboxing the array every time was costly when done in a loop like that (e.g. the profiler showed that even Buffer::data()'s check for whether the buffer is on-CPU was hot). But now I've specialized things to avoid most of that overhead.
The reason why I wanted something like VisitSetBitRunsVoid was to go a step further and always try to perform block copies instead of falling back to one-element-at-a-time-copies. But yes, then it needs to be able to combine two bitmaps with AndNot (we want runs of bits where !output_valid & input_valid)

I would kind of prefer to get all these kernels merged and consolidated before I start trying to microoptimize them, though, given they've been around for a while and all use similar helper code (that's now starting to diverge slightly once I look at optimizing).

@ursabot please benchmark lang=C++

Broke up the main function a bit.

Rebased (wow, that was more painful than I wanted it to be)

Rebased again to fix the conflict with the make_struct change.


Add the ability to append and prepend middleware priority from the application builder

This is a follow-up PR for #52897 that adds two methods to the application builder, allowing for easy access to the add middleware after/before methods on the kernel.
Using the examples from the previous PR, the methods would be accessible like so:
return Application::configure(basePath: dirname(__DIR__))
    ->withRouting(
        web: __DIR__.'/../routes/web.php',
        commands: __DIR__.'/../routes/console.php',
        health: '/up',
    )
    ->withMiddleware(function (Middleware $middleware) {
        $middleware->appendPriority(
		    \Illuminate\Routing\Middleware\ValidateSignature::class,
		    [
		        \Illuminate\Cookie\Middleware\EncryptCookies::class,
		        \Illuminate\Contracts\Auth\Middleware\AuthenticatesRequests::class,
		    ],
		);

		$middleware->prependPriority(
		    \Illuminate\Routing\Middleware\ValidateSignature::class,
		    [
		        \Illuminate\Cookie\Middleware\EncryptCookies::class,
		        \Illuminate\Contracts\Auth\Middleware\AuthenticatesRequests::class,
		    ],
		);
    })
    ->withExceptions(function (Exceptions $exceptions) {
        //
    })->create();

They map as follows:

Middleware::appendPriority() -> Kernel::addToMiddlewarePriorityAfter()
Middleware::prependPriority() -> Kernel::addToMiddlewarePriorityBefore

Can the signature be something like:
$middleware->appendToPriorityList(after: $middlewareToPutTheNewMiddlewareAfter, append: $theMiddlewareToAppend);
$middleware->prependToPriorityList(before: $middlewareToPutTheNewMiddlewareBefore, prepend: $theMiddlewareToPrepend);

Please mark as ready for review when the requested changes have been made.

Hey there! I'm not sure if the parameter names match what I mentioned?

Hey there! I'm not sure if the parameter names match what I mentioned?

Oh sorry, I had assumed they were just to illustrate as the names are quite long. No worries, I'll update that now.

Hey there! I'm not sure if the parameter names match what I mentioned?

All done!

Sorry, I mean the actual parameter names, which are here:

Sorry, I mean the actual parameter names, which are here:

Ah, that makes so much more sense. Sorry, that's on me, my head is all over the place today!


Add authorization to register method

Description
Issue scenario:
if the user keep the page open (skipping the mount method that check for authorization), and keep submitting the form, it will work because there is no authorization check on the register method.
Functional changes

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

Isn't the form button disabled after it is clicked the first time, that is Livewire behaviour I think?

Either way I think this is an OK change since someone could trigger it from JS

whoops


[Question]: AssertionError: The task name:document_intelligence is not in Taskflow list, please check your task name.

请提出你的问题
调用paddlenlp时报错

AssertionError                            Traceback (most recent call last)
Cell In[6], line 4
1 from pprint import pprint
2 from paddlenlp import Taskflow
----> 4 docprompt = Taskflow("document_intelligence")
5 # pprint(docprompt([{"doc": "./paddleNLP的安装.png", "prompt": ["paddleNLP的安装需要哪些包?", "怎么验证paddleNLP的安装?", "在安装过程中还需要注意什么其他问题？"]}]))
File ~/miniconda3/lib/python3.8/site-packages/paddlenlp/taskflow/taskflow.py:289, in Taskflow.init(self, task, model, mode, device_id, **kwargs)
288 def init(self, task, model=None, mode=None, device_id=0, **kwargs):
--> 289     assert task in TASKS, "The task name:{} is not in Taskflow list, please check your task name.".format(
290         task)
291     self.task = task
293     if self.task in ["word_segmentation", "ner"]:
AssertionError: The task name:document_intelligence is not in Taskflow list, please check your task name.

is this problem solved? i have a similar problem, the error is "The task name:feature_extraction is not in Taskflow list, please check your task name."

is this problem solved? i have a similar problem, the error is "The task name:feature_extraction is not in Taskflow list, please check your task name."

The problem has been solved. My suggestion is that for specific tasks, it is best to find the corresponding specific project on the official website of paddle, which has detailed environmental dependency installation. This is the website: https://aistudio.baidu.com/aistudio/projectoverview/public/1?kw=UIE&order=2&topic=5


Update windbg release notes for version 1.2407.24003

@lzybkr - Looks good to me. Let me know if this is ready to go live, and I will publish.

Thanks for fixing my links @DOMARS - this is good to publish now.


Weird results when used in combination with Vue

When linting a .vue file I get errors which don't seem to be related with the line they're displayed on. Also the console shows the following warning:
SublimeLinter: WARNING: Reported line '19' is not within the code we're linting.
Maybe the linter reports problems from multiple files or `line_col_base` is not set correctly.

Is it possible to use tslint within Sublime within Vue files?

Hi @HeleenE,
afaik tslint cannot lint whole vue files. Maybe there is a plugin for that?

@kaste that's to bad! I've been trying to get it up and running, but not having much succes. Is there a way to tell SublimeLinter/tslint to only lint the code in the <script> tags?

Probably, take a look at http://www.sublimelinter.com/en/stable/linter_settings.html#selector
It usually depends on how good the Vue syntax definition is.

With these settings it seems to only report errors within the script tags, but they still don't correspond with the code and I still get the error in the console. Any ideas?

Have you tried turning on debug in the SublimeLinter settings? It should print the raw output from tslint. Does tslint actually lint across files?

You probably need to set up TSLint in a way that it can deal with the vue files. IIRC TSLint usually is pretty lame in combination with partial code snippets, i.e. without a project so it can build type info.
In any case, since the maintainers here don't use TS in combination with Vue a lot, we need at least a whole lot more debug info to work with, an example project/file, and probably someone who knows how all of this is supposed to work in the first place. As it is, this issue is not actionable, so I'm closing it until further notice.


Prisma should return time as XX:XX:XX instead of full datetime string

Bug description
postgres DB setup a column as the following:
start_time       DateTime      @db.Time
The value stored is "08:00:00". When DB data was downloaded as a CSV it shows: "08:00:00"
When queried using prisma client, it returns: "1970-01-01T08:00:00.000Z" instead of the expected "08:00:00"
Am I wrong in assuming this?
How to reproduce

Expected behavior
prisma query result should show: "08:00:00"
Prisma information

Environment & setup

OS: Mac OS
Database:PostgreSQL
Node.js version: v16.8.0

Prisma Version
prisma                  : 3.3.0
@prisma/client          : 3.2.1

This is currently expected behavior of Prisma. Here is a feature request issue that suggest changing that: https://github.com/prisma/prisma/issues/5769

In the meantime, a workaround for this is to use a custom resolver / definition.
In my case, I use the old nexus plugin (nexus-plugin-prisma@0.35.0), and write a custom resolver for the model definition, like this:
// definition resolver helpers
const getTimeOnly = (dt) => {
  if(typeof dt?.getMinutes !== "function" || typeof dt?.getHours !== "function") return '';
  const hours = dt.getUTCHours(), minutes = dt.getUTCMinutes()
  const hoursString = (hours < 10 ? '0' : '') + hours;
  const minutesString = (minutes < 10 ? '0' : '') + minutes;
  return `1970-01-01T${hoursString}:${minutesString}:00`;
}

// definition resolvers
export const seTimeOnlyModel = (t, fieldName: string) => {
  t.field(fieldName, {
    type: "DateTime",
    resolve(root, args, ctx) {
        return getTimeOnly(root[fieldName]);
      }
  })
}

Basically, the root object already returns the date as a javascript Date object, so I am simply converting it to a date string absent the timezone information. Instead of a date object you now get the date string. You could return whatever string you wanted, with or without the date information.
Hope that's helpful!


nc_def_var_extra() error checking not appropriate for how it is called...

nc_def_var_extra() is called by nc_def_var_deflate(), nc_def_var_chunking(), etc.
It checks errors incorrectly. It assumes that all parameters are present, when only a subset ever are. So the checks don't work.
For example, this code should not succeed, but it does:
         /* Create a netcdf-4 file. */
         if (nc_create(FILE_NAME, mode, &ncid)) ERR;
         if (nc_def_dim(ncid, DIM8_NAME, TEST_VAL_42, &dimids[0])) ERR;
         if (nc_def_var(ncid, VAR_NAME8, NC_INT, NDIMS6, dimids, &varid)) ERR;

         /* Set the var to contiguous. */
         if (nc_def_var_chunking(ncid, varid, NC_CONTIGUOUS, NULL)) ERR;

         /* Now defalte can't be set. */
         if (nc_def_var_deflate(ncid, varid, 0, 1, 4)) ERR;

         if (nc_close(ncid)) ERR;

nc_def_var_extra() checks for this condition like this:
   /* Can't turn on contiguous and deflate/fletcher32/szip. */
   if (contiguous)
      if ((*contiguous != NC_CHUNKED && deflate) ||
          (*contiguous != NC_CHUNKED && fletcher32))
         return NC_EINVAL;

This check does not work because first contiguous is set, then deflate in a separate call. So in the call from nc_def_var_deflate(), the contiguous pointer is NULL so the check is not run.
(What ends up happening with the code above is that def_var_deflate() silently changes the contiguous setting to chunked when it turns on deflation. Instead it should return an NC_EINVAL error.)
I will clean this up.

It seems to me that the code you reference:
if (contiguous)
if ((*contiguous != NC_CHUNKED && deflate) ||
(*contiguous != NC_CHUNKED && fletcher32))
return NC_EINVAL;
must check also that chunking was set by looking at var->chunking and/or var->contiguous.

Yes it must check the var settings not the parameters. There is no way to pass the contiguous and fletcher32 parameters together for example, one is in nc_def_var_chunking() and the other is in nc_def_var_fletcher().

OK, now I see that it's not possible for nc_def_var_extra() to check this unless we are will to impose an order on the calling of def_var_chunking and def_var_deflate, which we are not.
Consider this (working) test code from ncdump tst_special_atts.c:
   /* Specify chunking for var2, note only uses CHUNK1 and CHUNK2.
      Also, specify using a checksum for this variable. */
   if (nc_def_var_chunking(ncid, var2id, NC_CHUNKED, chunksizes)) ERR;
   if (nc_def_var_fletcher32(ncid, var2id, NC_FLETCHER32)) ERR;
   if (nc_def_var_endian(ncid, var2id, NC_ENDIAN_BIG)) ERR;

   /* Use compression but no shuffle for var3, also set to big endian */
   if (nc_def_var_deflate(ncid, var3id, NC_NOSHUFFLE, COMPRESS, DEFLATE_LEVEL)) ERR;
   if (nc_def_var_chunking(ncid, var3id, NC_CHUNKED, chunksizes)) ERR;
   if (nc_def_var_endian(ncid, var3id, NC_ENDIAN_LITTLE)) ERR;

In the first case, chunking is turned on before fletcher32.
In the second case, chunking is set after deflate is set. (This causes deflate to turn on chunking silently.)
If I now check that chunking is set before deflate, the second set of code does not work. It demands that I call nc_def_var_chunking() before calling nc_def_var_deflate() or nc_def_var_fletcher32(). The reason is that vars are contiguous by default.
OK, so this can't be checked. I will add some notes to the documentation and we will call it a feature.

As I have documented and tested this, I see that it was my original intention for this code, that NC_CHUNKED would be automatically turned on in certain cases.
But as I look at the code, I don't know of proper default chunksizes are computed if fletcher32 or the shuffle filter are turned on. (They are computed properly when deflate is turned on.) I will add some more tests for this...

I think we have to undo one of  your previous assumptions.
Since filter setting and such require chunking,
I think that they must fail if, when e.g. nc_def_var_deflate is called,
chunking has not been set. This means that we do indeed force
an order on nc_def_var_XXX functions.  But not sure that is any worse
than requiring the dimensions be set for a variable before chunking is set.

If I understand you correctly, you are proposing that we return an error (NC_EINVAL) if I set deflate with nc_def_var_deflate(), without first setting chunking by calling nc_def_var_chunking(). Is that correct? And this would also apply to nc_def_var_fletcher32() and nc_def_var_filter(). (But it does not apply to nc_def_var_endian().)
I am certainly willing, and this would be very easy to implement in code.
But is it wise? I get the attraction - it makes logical sense. But for the last 10 years, this has not been necessary, and if we make it necessary now, then we may break some user code. And really, it is also not a big problem to leave it the way it is, document it, and just move on with life. ;-) It does not cause a lot of contortions in the code to just assume that if you want deflate, you also want chunked data.
IMO chunked vs. contiguous is not really a user feature like compression is. The user cares about compression. because he or she can see that. But chunked vs. contiguous seems like more of an internal HDF5 implementation detail. If I want compression, I want compression, and do whatever is necessary to give it to me. Similarly for checksums. This is the reasoning for the current functioning.
(In some ways it would be easier to switch the default to chunked and not contiguous, but we really can't change that now.)
I suggest we accept the current behavior, document it, and make sure it works reasonably well.
However, if you and @WardF  feel differently, I certainly don't feel very strongly about it. So think it over, discuss, and let me know. I will make it do whatever the group consensus is.

All good points. But remember that chunking also has significant performance
consequences and the "correct" chunk spec can only be determined by the dataset creator.
The net effect of leaving things like they are (or were) is that the required checks
must occur at nc_enddef. So the error message is delayed.

After our experience with changing expected behaviors with 4.5.0 (and subsequent reversions) I’m loathe to make changes that might impact people’s workflows.  It would be great I’d deflate took, as an argument, a token or some such generated when chunking was specified. That’s just a means to an end I suppose. Since they would be getting errors without setting chunking already I am torn on this.  But I guess that’s not the case, chunking with default values is turned on.
For now I think we could leave this issue open to revisit in the future and come back to it after 4.6? In the meantime perhaps we can continue to use the extant workflow that works for people. That way we won’t have to rush 4.7 for the sake of fixing workflows.

OK, for now I will thoroughly document the existing behavior, and make sure it is working correctly.
After 4.6.0 is released, if someone has an idea on how to move this forward usefully, I will let them suggest it. I believe we are stuck with the current behavior, but am willing to do anything that you two guys can agree on.

BTW @DennisHeimbigner not sure what you mean by:

the required checks
must occur at nc_enddef

When deflate is turned on, chunking is turned on, and default chunk sizes are determined. This all happens in nc_def_var_extra(), not in nc_enddef().
Once concern I have is that while fletcher32 and shuffle will also change the data to chunked, I don't see, through code inspection, where they call the function that sets the default chunk sizes. So what the heck chunksizes do they use? I will look into this and see...

OK, what happens is that nc4_find_default_chunksizes2() is called in NC4_def_var(), even though contiguous is the default storage. As a result, when nc_def_var_fletcher32() or nc_def_var_deflate() with shuffle is called, and the storage is switched to chunked, then there are already sensible chunksizes available.
I will add some test code to confirm this, then (finally!) close this ticket.


voodoojs.com not working

http://www.voodoojs.com/
return ERR_NAME_NOT_RESOLVED.

:+1:

I lost the domain last year :( Was switching jobs and moving cities, and just dropped the ball on the renewal. Sorry all. When I noticed, I reached out to the owner Ivan (https://who.is/whois/voodoojs.com)  to make him an offer, but he is intent on not giving it up, and also not using it.
My plan is to get a new domain up for a v2 release. No definitely timeline, maybe early next year.

I lost the domain :( Was switching jobs and moving cities, and just dropped the ball on the renewal. Sorry all. When I noticed, I reached out to the owner Ivan (https://who.is/whois/voodoojs.com) to make him an offer, but he is intent on not giving it up, and also apparently not using it.
My plan is to get a new domain up for a v2 release. No definitely timeline, maybe early next year.

I was wondering if you got into some terrible car crash or something.  Glad to see you're still alive there @brentongunning  !  Hahah.  Bummer on the domain issue.  I'd love to see this project continue.  Cheers man.

Yeah man, happy to see that this project is alive, you should setup gh-pages branch and have it hosted on voodoo.github.io
—
Leon
On Thu, Nov 19, 2015 at 3:54 PM, Sean Novak<EMAIL_ADDRESS>wrote:

I was wondering if you got into some terrible car crash or something.  Glad to see you're still alive there @brentongunning  !  Hahah.  Bummer on the domain issue.  I'd love to see this project continue.  Cheers man.
Reply to this email directly or view it on GitHub:
https://github.com/brentongunning/voodoo.js/issues/95#issuecomment-158062399

@snovak Haha, thanks man. The project had to take a back seat to everything else for a while, but there's still a ton I want to do! Promise I'll carve out more time in 2016.
@LeonFedotov That's a great suggestion! Let me try that.

@snovak Haha, thanks man. The project had to take a back seat to everything else for a while, but there's still a ton I want to do! Promise I'll carve out more time in 2016.
@LeonFedotov That's a great suggestion! Let me try that.

@snovak Haha, thanks man. The project had to take a back seat to everything else for a while, but there's still a ton I want to do! Promise I'll carve out more time in 2016.
@LeonFedotov That's a great suggestion! Let me try that.

Amazing!


Feature/fast euclidian recommend

Implemented ranking via implicit for Euclidean distance (relevant for DSSM model)

In doc string for ImplicitRanker: Ranker for DOT and COSINE similarity (need to add EUCLIDIAN)


New package: Boeing.config-file-validator version 1.7.1

Pull request has been created with komac v2.4.1 :rocket:
Microsoft Reviewers: Open in CodeFlow

Verify:


fix default timezone to JST.

Timezone of Json data is JST, but program expect UTC.
change default timezon to JST(when unmarshaled, Timezone should be JST)

qiita api's date support timezone, like below. no need to fix. close this issue
"created_at":"2018-02-15T00:50:56+09:00"

https://qiita.com/api/v2/items?page=1&per_page=1


long runtime of even fail hydrogen atom

Everything was working fine. Until suddenly even a simple print('example') line didn't even run anymore with hydrogen. I use the atom editor.
See attached a screenshot. Hopefully someone can help me out :)

It is continuously showing that icon next to print(pay).

Could you open atom in dev mode (View --> Developer --> Open in Dev Mode...) and post a screenshot of the dev console (View --> Developer --> View Dev Console...) after running the command?

Hi Igeiger, Thanks for the quick response. What is the difference with dev mode? I've done what you said, but couldn't find the view you meant called View Dev Console (see screenshot).

Oh I'm sorry I meant Toggle Developer Tools

ah oke, I've run the code in the first screenshot I posted and did what you said resulting in this:

@lgeiger  or anyone else who knows how to solve this issue?

You next need to open the console so we can see the errors:

Indeed very useful to learn how to debug this way. Above you can see the error I found. Could someone explain this error and tell me how to solve it?

This is what I found on Stackoverflow: http://stackoverflow.com/questions/9768444/possible-eventemitter-memory-leak-detected
It says that I've to run this line:
process.setMaxListeners(0);
However, I am new to Python/Atom so if this is the solution, where should I run this line then? Once I run this line in Atom I get this error:
Traceback (most recent call last):
  File "/Users/***/Documents/Pyhton/Project/test.py", line 1, in <module>
    process.setMaxListeners(0)
NameError: name 'process' is not defined

The error doesn't seem to come from Hydrogen directly.
Is it also there if Hydrogen isn't running? Which version of Atom are you using?

I am using version 1.12.9 and it happens only with hydrogen. For example this line of code:
x = 1
print(x)
Then it keeps on running showing that icon in the first screenshot I posted saying that Python 3 is busy.
However, when I look at the console in dev mode, then it doesn't show an error, but the program just doesn't run. Only a couple of warnings (see screenshot):

This way I can't continue working in python so would be appreciated if anyone can help me to find the solution :)

Could you expand the Hydrogen logs like this?

In particular Hydrogen ResultView: Add result and the logs after that are interesting.

Here it is:

Thanks, everything looks normal here.
Please check that you haven't disabled Use Shadow DOM under Settings > Editor. This option should be enabled and was removed in Atom 1.13.

I guess you mean atom > preferences > editor. I don't even see the option Use Shadow DOM there...   so what can I do to get hydrogen running?

Could you try updating Atom to the latest version?

I am using the latest version already. Checked for it, but Atom itself says so.

Atom 1.13 is the latest stable version: https://github.com/atom/atom/releases/tag/v1.13.0

@orijjsjje
Does this issue only happy when you execute code that invokes input?
If so, does Hydrogen show a window prompting for an input?
Does the dev console log show any messages about the input?

@lgeiger found out that installing 13.1.1 doesn't solve the issue. Restarting the kernel does temporarily.
@n-riesco yes only when it invokes input and yes it shows that window, once I press enter the issue of endless runtime occurs. Here above you can see in the screenshots what the dev console communicates. Would be great if you could help me solving this.

@orijjsjje I just tried your original example multiple times and don't encounter this issue.
You said everything worked fine in the past. Have you changed your python environment in between?

@orijjsjje I'll close this for now, feel free to reply if you are still having trouble.


Omnisharp stuck at "Starting..."

I'm following these steps to use a new c# app in VS Code.

install VS Code
ext install c#
mkdir dotnetnew
cd dotnetnew
dotnet new
dotnet restore
Open the project in VS Code

But at this point Omnisharp in the bottom right gets stuck on "Starting.." and never changes.  The only thing I see in the Omnisharp Log window is:
[INFO] Starting OmniSharp at 'c:\Users\...\dotnetnew'...

Notes

This issue only occurs on my work machine; my personal machine works fine.
I've tried reinstalling VS Code and omnisharp
If I press F5 the application begins to debug with no messages, and then just hangs as well.
If i open a command prompt in my project.json root I can execute dotnet run and the application will run correctly.

The same is happening to me too.
Strange is that it's working at home but not on my work machine.
Could it be a proxy issue? That's the only difference between work and home machines

I too have vs code setup through a proxy at work.

Same issue here with VS Code Insider and C# v1.0.11, i think issue #339 is not resolved yet?

Hi, could you try the latest extension on the marketplace (1.1.5)? This should work much better and that version should properly support proxies when downloading OmniSharp.

This does look like it fixed my issue, thanks.

Awesome! Thanks for verifying!

Sorry for the delay! It's working for me too. Awesome!
Thanks!!


Websockets implementation for scaling, moving and rotating objects

Hello @salgum1114,
I am trying to implement websockets to scale, move and rotate objects using websockets.
Something like: https://fabricjs-collaboration.herokuapp.com/fabric
Please find the attachment for my implementation.
wb.zip
Please suggest where I am doing wrong.
Thanks!

Hi @ranajeex
I have not tried it, but I'll test it and let you know.

@ranajeex
I saw and developed the example you gave me.
Is this what you are trying to do?

The code looks like this.
server.ts
import WebSocket from 'ws';

const wss = new WebSocket.Server({ port: 80 });

wss.broadcast = function broadcast(data) {
    wss.clients.forEach(function each(client) {
        if (client.readyState === WebSocket.OPEN) {
            client.send(data);
        }
    });
};

wss.on('connection', (ws: WebSocket) => {
    console.log('Connected Client');
    ws.on('message', function incoming(data) {
        // Broadcast to everyone else.
        console.log('Received', data);
        wss.clients.forEach(function each(client) {
            if (client !== ws && client.readyState === WebSocket.OPEN) {
                client.send(data);
            }
        });
    });
});

ImageMapEditor.js
...code...
componentDidMount() {
    this.showLoading(true);
    import('./Descriptors.json').then((descriptors) => {
        this.setState({
            descriptors,
        }, () => {
            this.showLoading(false);
        });
    });
    this.resizeSensor = new ResizeSensor(this.container, () => {
        const { canvasRect: currentCanvasRect } = this.state;
        const canvasRect = Object.assign({}, currentCanvasRect, {
            width: this.container.clientWidth,
            height: this.container.clientHeight,
        });
        this.setState({
            canvasRect,
        });
    });
    this.setState({
        canvasRect: {
            width: this.container.clientWidth,
            height: this.container.clientHeight,
        },
        selectedItem: null,
    });
    this.websocket = new WebSocket('ws://localhost');
    this.websocket.onopen = (e) => {
        this.id = uuid();
        console.log('Opened websocket', e.type);
    };
    this.websocket.onmessage = (e) => {
        const data = JSON.parse(e.data);
        const { type, target } = data;
        if (type === 'add') {
            this.canvasRef.handlers.add(target, false, true, false);
        } else if (type === 'modified') {
            const findObj = this.canvasRef.handlers.findById(target.id);
            this.canvasRef.handlers.setByPartial(findObj, target);
        }
        console.log('Received message', data);
    };
}

canvasHandlers = {
    ...code...
    onAdd: (target) => {
        if (!this.state.editing) {
            this.changeEditing(true);
        }
        if (target.type === 'activeSelection') {
            this.canvasHandlers.onSelect(null);
            return;
        }
        this.canvasRef.handlers.select(target);
        this.websocket.send(JSON.stringify({
            id: this.id,
            type: 'add',
            target: target.toObject(propertiesToInclude),
        }));
    },
    ...code...
    onModified: debounce((target) => {
        if (!this.state.editing) {
            this.changeEditing(true);
        }
        if (target
        && target.id
        && target.id !== 'workarea'
        && target.type !== 'activeSelection') {
            this.canvasRef.transactionHandlers.save(target, 'modified');
            this.setState({
                selectedItem: target,
            });
            this.websocket.send(JSON.stringify({
                id: this.id,
                type: 'modified',
                target: target.toObject(propertiesToInclude),
            }));
            return;
        }
        this.setState({
            selectedItem: null,
        });
    }, 300),
    ...code....
}
...code...

Based on this code I think you can do the real time drawing you want.

@salgum1114
Thanks for the code.
I will check the same and get back to you if any issue.

Yes this is exactly what i am trying to do.
I have tried your sample but I ended up with some error:
`Uncaught Error: ws does not work in the browser.  Browser clients must use the native WebSocket object
at new push../node_modules/ws/browser.js.module.exports (browser.js:4)
at ProxyComponent.componentDidMount (ImageMapEditor.js:129)
at ProxyComponent.componentDidMount (react-hot-loader.development.js:572)
at commitLifeCycles (react-dom.development.js:17334)
at commitAllLifeCycles (react-dom.development.js:18736)
at HTMLUnknownElement.callCallback (react-dom.development.js:149)
at Object.invokeGuardedCallbackDev (react-dom.development.js:199)
at invokeGuardedCallback (react-dom.development.js:256)
at commitRoot (react-dom.development.js:18948)
at react-dom.development.js:20418
error @ react-hot-loader.development.js:175
componentDidCatch @ react-hot-loader.development.js:1564
notifySubscribers @ react-hot-loader.development.js:582
callback @ react-dom.development.js:18095
callCallback @ react-dom.development.js:16433
commitUpdateEffects @ react-dom.development.js:16472
commitUpdateQueue @ react-dom.development.js:16460
commitLifeCycles @ react-dom.development.js:17364
commitAllLifeCycles @ react-dom.development.js:18736
callCallback @ react-dom.development.js:149
invokeGuardedCallbackDev @ react-dom.development.js:199
invokeGuardedCallback @ react-dom.development.js:256
commitRoot @ react-dom.development.js:18948
(anonymous) @ react-dom.development.js:20418
unstable_runWithPriority @ scheduler.development.js:255
completeRoot @ react-dom.development.js:20417
performWorkOnRoot @ react-dom.development.js:20346
performWork @ react-dom.development.js:20254
performSyncWork @ react-dom.development.js:20228
interactiveUpdates$1 @ react-dom.development.js:20495
interactiveUpdates @ react-dom.development.js:2170
dispatchInteractiveEvent @ react-dom.development.js:4882
react-dom.development.js:17117 The above error occurred in the  component:
in ImageMapHeaderToolbar (created by ImageMapEditor)
in div (created by ImageMapEditor)
in div (created by ImageMapEditor)
in div (created by ImageMapEditor)
in section (created by BasicLayout)
in BasicLayout (created by Context.Consumer)
in Adapter (created by Container)
in section (created by BasicLayout)
in BasicLayout (created by Context.Consumer)
in Adapter (created by Container)
in div (created by Context.Consumer)
in div (created by Context.Consumer)
in Spin (created by Container)
in Container (created by ImageMapEditor)
in ImageMapEditor (created by App)
in div (created by App)
in div (created by App)
in div (created by App)
in App
in AppContainer
in Provider
React will try to recreate this component tree from scratch using the error boundary you provided, AppContainer.
logCapturedError @ react-dom.development.js:17117
logError @ react-dom.development.js:17153
callback @ react-dom.development.js:18094
callCallback @ react-dom.development.js:16433
commitUpdateEffects @ react-dom.development.js:16472
commitUpdateQueue @ react-dom.development.js:16460
commitLifeCycles @ react-dom.development.js:17364
commitAllLifeCycles @ react-dom.development.js:18736
callCallback @ react-dom.development.js:149
invokeGuardedCallbackDev @ react-dom.development.js:199
invokeGuardedCallback @ react-dom.development.js:256
commitRoot @ react-dom.development.js:18948
(anonymous) @ react-dom.development.js:20418
unstable_runWithPriority @ scheduler.development.js:255
completeRoot @ react-dom.development.js:20417
performWorkOnRoot @ react-dom.development.js:20346
performWork @ react-dom.development.js:20254
performSyncWork @ react-dom.development.js:20228
interactiveUpdates$1 @ react-dom.development.js:20495
interactiveUpdates @ react-dom.development.js:2170
dispatchInteractiveEvent @ react-dom.development.js:4882
react-hot-loader.development.js:175 TypeError: Cannot read property 'canvas' of undefined
at ProxyComponent.detachEventListener (ImageMapHeaderToolbar.js:98)
at ProxyComponent.componentWillUnmount (ImageMapHeaderToolbar.js:76)
at ProxyComponent.componentWillUnmount (react-hot-loader.development.js:572)
at callComponentWillUnmountWithTimer (react-dom.development.js:17169)
at HTMLUnknownElement.callCallback (react-dom.development.js:149)
at Object.invokeGuardedCallbackDev (react-dom.development.js:199)
at invokeGuardedCallback (react-dom.development.js:256)
at safelyCallComponentWillUnmount (react-dom.development.js:17176)
at commitUnmount (react-dom.development.js:17553)
at commitNestedUnmounts (react-dom.development.js:17584)
error @ react-hot-loader.development.js:175
componentDidCatch @ react-hot-loader.development.js:1564
notifySubscribers @ react-hot-loader.development.js:582
callback @ react-dom.development.js:18095
callCallback @ react-dom.development.js:16433
commitUpdateEffects @ react-dom.development.js:16472
commitUpdateQueue @ react-dom.development.js:16460
commitLifeCycles @ react-dom.development.js:17364
commitAllLifeCycles @ react-dom.development.js:18736
callCallback @ react-dom.development.js:149
invokeGuardedCallbackDev @ react-dom.development.js:199
invokeGuardedCallback @ react-dom.development.js:256
commitRoot @ react-dom.development.js:18948
(anonymous) @ react-dom.development.js:20418
unstable_runWithPriority @ scheduler.development.js:255
completeRoot @ react-dom.development.js:20417
performWorkOnRoot @ react-dom.development.js:20346
performWork @ react-dom.development.js:20254
performSyncWork @ react-dom.development.js:20228
interactiveUpdates$1 @ react-dom.development.js:20495
interactiveUpdates @ react-dom.development.js:2170
dispatchInteractiveEvent @ react-dom.development.js:4882
react-dom.development.js:17117 The above error occurred in the  component:
in ImageMapFooterToolbar (created by ImageMapEditor)
in div (created by ImageMapEditor)
in div (created by ImageMapEditor)
in div (created by ImageMapEditor)
in section (created by BasicLayout)
in BasicLayout (created by Context.Consumer)
in Adapter (created by Container)
in section (created by BasicLayout)
in BasicLayout (created by Context.Consumer)
in Adapter (created by Container)
in div (created by Context.Consumer)
in div (created by Context.Consumer)
in Spin (created by Container)
in Container (created by ImageMapEditor)
in ImageMapEditor (created by App)
in div (created by App)
in div (created by App)
in div (created by App)
in App
in AppContainer
in Provider
React will try to recreate this component tree from scratch using the error boundary you provided, AppContainer.
logCapturedError @ react-dom.development.js:17117
logError @ react-dom.development.js:17153
callback @ react-dom.development.js:18094
callCallback @ react-dom.development.js:16433
commitUpdateEffects @ react-dom.development.js:16472
commitUpdateQueue @ react-dom.development.js:16460
commitLifeCycles @ react-dom.development.js:17364
commitAllLifeCycles @ react-dom.development.js:18736
callCallback @ react-dom.development.js:149
invokeGuardedCallbackDev @ react-dom.development.js:199
invokeGuardedCallback @ react-dom.development.js:256
commitRoot @ react-dom.development.js:18948
(anonymous) @ react-dom.development.js:20418
unstable_runWithPriority @ scheduler.development.js:255
completeRoot @ react-dom.development.js:20417
performWorkOnRoot @ react-dom.development.js:20346
performWork @ react-dom.development.js:20254
performSyncWork @ react-dom.development.js:20228
interactiveUpdates$1 @ react-dom.development.js:20495
interactiveUpdates @ react-dom.development.js:2170
dispatchInteractiveEvent @ react-dom.development.js:4882
react-hot-loader.development.js:175 TypeError: Cannot read property 'canvas' of undefined
at ProxyComponent.detachEventListener (ImageMapFooterToolbar.js:46)
at ProxyComponent.componentWillUnmount (ImageMapFooterToolbar.js:27)
at ProxyComponent.componentWillUnmount (react-hot-loader.development.js:572)
at callComponentWillUnmountWithTimer (react-dom.development.js:17169)
at HTMLUnknownElement.callCallback (react-dom.development.js:149)
at Object.invokeGuardedCallbackDev (react-dom.development.js:199)
at invokeGuardedCallback (react-dom.development.js:256)
at safelyCallComponentWillUnmount (react-dom.development.js:17176)
at commitUnmount (react-dom.development.js:17553)
at commitNestedUnmounts (react-dom.development.js:17584)
error @ react-hot-loader.development.js:175
componentDidCatch @ react-hot-loader.development.js:1564
notifySubscribers @ react-hot-loader.development.js:582
callback @ react-dom.development.js:18095
callCallback @ react-dom.development.js:16433
commitUpdateEffects @ react-dom.development.js:16472
commitUpdateQueue @ react-dom.development.js:16460
commitLifeCycles @ react-dom.development.js:17364
commitAllLifeCycles @ react-dom.development.js:18736
callCallback @ react-dom.development.js:149
invokeGuardedCallbackDev @ react-dom.development.js:199
invokeGuardedCallback @ react-dom.development.js:256
commitRoot @ react-dom.development.js:18948
(anonymous) @ react-dom.development.js:20418
unstable_runWithPriority @ scheduler.development.js:255
completeRoot @ react-dom.development.js:20417
performWorkOnRoot @ react-dom.development.js:20346
performWork @ react-dom.development.js:20254
performSyncWork @ react-dom.development.js:20228
interactiveUpdates$1 @ react-dom.development.js:20495
interactiveUpdates @ react-dom.development.js:2170
dispatchInteractiveEvent @ react-dom.development.js:4882
react-dom.development.js:506 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application.  This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
in Timer (created by ImageMapHeaderToolbar)
in div (created by FlexBox)
in FlexBox (created by ImageMapHeaderToolbar)
in div (created by FlexBox)
in FlexBox (created by ImageMapHeaderToolbar)
in ImageMapHeaderToolbar (created by ImageMapEditor)
in div (created by ImageMapEditor)
in div (created by ImageMapEditor)
in div (created by ImageMapEditor)
in section (created by BasicLayout)
in BasicLayout (created by Context.Consumer)
in Adapter (created by Container)
in section (created by BasicLayout)
in BasicLayout (created by Context.Consumer)
in Adapter (created by Container)
in div (created by Context.Consumer)
in div (created by Context.Consumer)
in Spin (created by Container)
in Container (created by ImageMapEditor)
in ImageMapEditor (created by App)
in div (created by App)
in div (created by App)
in div (created by App)
in App
`

@salgum1114
How you started server.ts?
Anything else have to do apart from suggestions?

@ranajeex
Of course you have to run server.ts individually.
I don't know the error you write.

@salgum1114,
Now its working for me.
Thanks for the help :)


mork-borg: update enemy defense prompt

Changes / Comments

update to weapon roll prompt to be more clear

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Error running on ubuntu

Hello, I'm having issues running this on my laptop. Runs fine on my desktop ubuntu though.
Here's the error:
cheneric@SURFACE-6BBFBSB:~/ptc-acc-gen$ ./makeaccounts.sh
ptc-acc-gen v2.5.0 hotfix r1 by Sébastien Vercammen and Frost The Fox (and Github contribs)
Creating account 31 of 50
fs.js:549
return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
^
Error: ENOENT: no such file or directory, open './accounts.csv'
at Error (native)
at Object.fs.openSync (fs.js:549:18)
at Object.fs.readFileSync (fs.js:397:15)
at Object. (/home/cheneric/ptc-acc-gen/PogoPlayer/pogo.js:6:16)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)
at startup (node.js:139:18)
at node.js:974:3
Find the generated accounts in PogoPlayer/accounts.csv

@teknicsrx7 I've tried that, but I get the same error.


Rework on click listeners (fixes #50)

Awesome, thank you so much! Thanks for updating the README and all that.

@daniel-stoneuk Oops, I broke the Dynamic UI item in Demo by adding new item before it... You should update the position number. Or should I provide PR to fix that?

I'll quickly change that. Cheers.


Block launcher won't open

Phone model:oppo A33f
Android version:5.1.1

Keeps closing after I open it needs to be fixed asap

Every time it try it shut down my phone


custom: still push v3 images to reg-aws

recent change made the image push part happen only for v4. we want it back for v3 too.

@sosiouxme QE provided me a new token which I will try it out today then I think we can merge this once the new token works.

ref: https://github.com/openshift/aos-cd-jobs/pull/2421

/lgtm


Update read-only.js

Added check to see if body is empty to prevent sql error 'syntax error at or near "WHERE"'

@ mrfelton I wonder if these are valid tests? If we're only updating readonly model attributes, shouldn't we return a 403? Can I amend the test?


Empty line after "/" delimiter causes migration to fail

Which version and edition of Flyway are you using?
6.0.6
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using (type & version)?
Oracle 18.3
Which operating system are you using?
Windows
What did you do?
Ran migration (note the trailing newline after /):
DECLARE

  id INTEGER;

BEGIN

    SELECT 1 INTO id FROM DUAL;

END;

/

What did you expect to see?
Migration succeeds.
What did you see instead?
Migration fails with:
SQL State  : 65000
Error Code : 6550
Message    : ORA-06550: line 6, column 1:
PLS-00103: Encountered the symbol "/" The symbol "/" was ignored.

Upon further investigation, the issue only seems to happen when CRLF line-endings are used.

This is a regression which was introduced in Flyway 6.0.2 by https://github.com/flyway/flyway/commit/a16b14fe893587d6fcc274979fefb15612623797.


support a list of unsafe commands

Thanks for this awesome plugin.
I was wondering a KUBECTL_UNSAFE_COMMANDS variable can be supported.
The need I have is to only block delete command, and I do not want to keep my list up to date anytime a new command is added to kubectl

Definitely!

@alaypatel07  can you confirm it works as expected. Then I will publish the new version?

@rumstead thanks for the quick turnaround, I will test it and get back to you.

Hi @rumstead https://github.com/rumstead/kubectl-safe/pull/24#pullrequestreview-1010935594 added my verification to the PRR. Before you cut a new release, can you please look at #25 and let me know what you think? Thanks!


Fix telemetry cleanup

Nullpointer can happen as during cluster cleanup, machine user deletion happens outside of telemetry context (as it was moved out in a more common module)

closing as it should go to rc-2.12


Update to .NET Core Preview8.

Updated EventHorizon.Blazor.Interop version.

Codecov Report

Merging #25 into main will decrease coverage by 98.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #25       +/-   ##
==========================================
- Coverage   98.83%   0.00%   -98.84%
==========================================
  Files          72      72
  Lines        2926    2926
  Branches      253     253
==========================================
- Hits         2892       0     -2892
- Misses         19    2926     +2907
+ Partials       15       0       -15

Impacted Files
Coverage Δ

...zor.TypeScript.Interop.Generator/GenerateSource.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...zor.TypeScript.Interop.Generator/Rules/IsGetter.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...zor.TypeScript.Interop.Generator/Rules/IsSetter.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...zor.TypeScript.Interop.Generator/Rules/IsStatic.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...or.TypeScript.Interop.Generator/Model/Constants.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...r.TypeScript.Interop.Generator/Rules/IsReadonly.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...r.TypeScript.Interop.Generator/Rules/IsVoidType.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...r.TypeScript.Interop.Generator/StringExtensions.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

....TypeScript.Interop.Generator/GenerateClassShim.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

....TypeScript.Interop.Generator/Rules/IsInterface.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e85bd...57f0e7d. Read the comment docs.


Add Firefox OS in the list.

Release notes for all versions - https://developer.mozilla.org/en-US/Firefox_OS/Releases

:+1:

I would like to work on this. Would someone tell me how to proceed and assign this to me?

the problem: caniuse works with browsers stats (http://gs.statcounter.com/ datas are used), and Firefox OS not appear in stats

Firefox OS is based on Gecko. Like,

Firefox OS 1.2 - Gecko 26
Firefox OS 2.0 - Gecko 32

So, whatever works in Firefox 26 works exactly as it is on Firefox OS 1.2.

Yeah, Firefox OS support seems close enough to the browser that it doesn't seem worth adding by itself.


Nerfs Gatfruit & reduces its spawn probability

About the PR
-Yield is about 40 times lower (combination of loss of repeatable harvest, yield from 2->1, maturation from 5->50)
-Spawn probability reduced 70%
Closes https://github.com/space-wizards/space-station-14/issues/6591

Uhhhh I fucked up, it looks like this reverted some other things that weren't conflicted


Add navigation support

This commit adds navigation support using this new Godot 4.3 feature.
Fixes #14.

TODO

[ ] Update CHANGELOG
[ ] Update README to indicate Godot 4.3 requirement, new features (and maybe disparity to Godot 3 version)
[ ] Tag & create release
[ ] Submit new version to Asset Library


chore: release main

:robot: I have created a release beep boop
0.1.0
0.1.0 (2024-06-15)
Miscellaneous Chores

release 0.1.0 (f94579a)

0.1.0
0.1.0 (2024-06-15)
Miscellaneous Chores

release 0.1.0 (f94579a)

0.1.0
0.1.0 (2024-06-15)
Miscellaneous Chores

release 0.1.0 (f94579a)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/hansetag/iceberg-catalog/releases/tag/v0.1.0 :sunflower:


Error message not getting captured

need to refactor all samples to [catch.error]

batchJobPath builder must take all params as string if not this error triggers


Add Github Action

Simple PR which adds black as Github action

Thanks for the PR - added it here after resolving conflicts:
https://github.com/defog-ai/defog-python/tree/main/.github/workflows


Change update frequency to 15 minutes

Price table gets updated once per day, updating it every minute is ~pointless.
Refreshing it at HA start and then every 15 minutes seems sufficient.

Actually it is already refreshed every 1h:
https://github.com/PiotrMachowski/Home-Assistant-custom-components-TGE/blob/master/custom_components/tge/update_coordinator.py#L28


CSV output error

Hello,
The CSV output of the module is actually a csv reader object. If trying to iterate through it it will return each character of a line, not the fields.
The problem seems to be at the line 275 of alphavantage.py:
csv_response = csv.reader(url_response)
In order for the reader to work correctly, the line should be:
csv_response = csv.reader(url_response.splitlines())
Reproducing the issue:
#!/usr/bin/env python
from alpha_vantage.timeseries import TimeSeries
ts = TimeSeries(key='API_KEY', retries=3, output_format='csv')
data_m15, meta_data_m15 = ts.get_intraday(symbol='GE', interval='15min', outputsize='full')
print meta_data_m15
print data_m15
for line in data_m15:
    print line

Output:
None
<_csv.reader object at 0x287b4b0>
['t']
['i']
['m']
['e']
['s']
['t']
['a']
['m']
['p']
['', '']
['o']
['p']
['e']
['n']
['', '']
['h']
['i']
['g']
['h']
['', '']
['l']
['o']
['w']
['', '']
['c']
['l']
['o']
['s']
['e']
['', '']
['v']
['o']
['l']
['u']
['m']
['e']
[]
[]

Output with the suggested change:
None
['timestamp', 'open', 'high', 'low', 'close', 'volume']
...

Thanks for the great work you did on the module.

Hi @onefarad, thanks for the issue. Do you feel like trying a PR? I mean I can fix it myself but if you want you can do the PR :)

Hi Romel,
It's ok, I'll try it. Gotta start somewhere. :)
One more issue I found is that when a CSV retrieval fails, the server will send actually a JSON. Example output for a symbol that does not exist:
{
    "Error Message": "Invalid API call. Please retry or visit the documentation (https://www.alphavantage.co/documentation/) for TIME_SERIES_INTRADAY."
}

Probably will have to add some error checking (if the answer is json and not csv) in that area and raising an exception.

Yes you can check the alphavantage.py

Yep, good work! If you want to give it a try at handling the error messages you are welcome to give it a try. I did not write any unittests for the csv part of the library. Maybe I find time to improve on that later.
Thanks :D

I'll have a look at error handling when I'll get some time. :) Want also to add to the documentation the CSV usage.


Project Work Issue

Issue for Listing all sub issues for the project work.
#7 Creating Data Pipeline
#8 Data Report
#9 Automated testing
#10 Github actions added
#11 Analysis report added
#12  Add license

Now that the README.md is updated and the license is added, this project is finished.


Include more platforms in count-lines availability

The CountLines executable is failing to build on non-macOS platforms, as seen here, due to missing availability annotations before using FileHandle.AsyncBytes.lines. This change adds the missing availability to match.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

@swift-ci Please test