constraintlayout vs flexbox-layout

hi guys,
how does flexbox layout fit with constraintlayout ? we are looking to build interfaces inspired by the flexbox way of working.
we are unsure of how both these libraries fit with each other. Both are "google recommended". Constraintlayout is even part of "best practices" - https://developer.android.com/training/constraint-layout/index.html
what is even more puzzling is that flexbox-layout does not build on top of constraintlayout. if there was some info on how an end-user should think about using both of these.... that would be awesome.

The simple answer is you can use the appropriate one depending on your use case.
I think ConstraintLayout can cover most of the use cases and boosts your productivity with the new layout editor, also there should be performance advantage by reducing the view hierarchy.
But there are still some use cases where FlexboxLayout can be used more effectively. For example:

The case where you want to put views sequentially and put a view in a new line if not enough space is left while the width may be changed (due to a device factor, orientation changes or the window resizing in the multi window mode) like this one or this one

Scrollable view. As in this issue, the integration of FlexboxLayout with RecyclerView is under development. It offers the same functionality in a scrollable view. That use case is useful for a google photo like app or a news like app (where you want to put various widths of views)

what is even more puzzling is that flexbox-layout does not build on top of constraintlayout.

Is this happening in your project?
FlexboxLayout should build on top of ConstraintLayout since both layouts are just classes that extend ViewGroup like other layouts (e.g. LinearLayout, RelativeLayout). So if it doesn't build, it's an issue, please file that, then I can fix it.

By the way this is not an issue with the FlexboxLayout, so GitHub issue is not the right place to discuss is. Let me close this.

@thagikura hi - i dont want to reopen this issue, but where else do we discuss enhancements and usecases ? I googled a lot but did not find any other resource/forum/slack-channel/google-group. So I apologize in advance for the comments.

@sandys please file an GitHub issue for the enhancements. For the discussion, I think you can expect opinions from others by creating a thread in other community sites (like Reddit, Hacker News). Or if it's just a question, you can ask me on twitter.
Does that answer your question?


Add support for AIX

Add support for AIX. Currently disto returns the following for a AIX 7.2:
{
    "codename": "",
    "id": "aix",
    "like": "",
    "version": "2",
    "version_parts": {
        "build_number": "",
        "major": "2",
        "minor": ""
    }
}

Source could be cmd oslevel:
$ oslevel
<IP_ADDRESS>

7 --> major
2 --> minor

Can you share the release file?

As far as I know there is no release file on AIX.

There must be something.. lsb.. something.. otherwise how would distro know that it's aix?

It seems that this information was gathered from uname -rs:
$ uname -rs
AIX 2

Hey @jokurz, would it be possible to read these version components from a file instead of calling oslevel ? Thanks 🙇

@HorlogeSkynet - I am not aware of such a file. I would fully understand if you will not support AIX as the platform might not be the first choice for python development.

@jokurz thanks for your fast feedback ! We'll do our best to support (and maintain) what distro should.
I was asking about a specific "release" file, as sourcing such would be faster than calling another external program. Do you know a substitute for Linux strace command that you could run against oslevel to see what it does ? Bye 👋

@HorlogeSkynet, while I agree that a file would be nicer, I think that we can simply try to execute oslevel as a last resort (assuming nothing else is found, e.g. release file, uname, etc..).
If that's the case, it won't cost anything, as oslevel will indeed only run when no other option is available (supposedly, only on AIX, AFAIK).

@nir0s Unless I'm missing something here, I don't think it would be that easy as uname -rs output is definitely working (see https://github.com/python-distro/distro/issues/241#issuecomment-494372838) 🙄

@nir0s @jokurz So it looks like we could be doing something like that in version method (naive pseudo-code here, implementation must be tougher and tests being written of course) :
    def version(self, pretty: bool = False, best: bool = False) -> str:
        versions = [
            # current existing candidates list...
        ]
        if sys.platform.startswith('aix'):
            versions.insert(0, check_output("oslevel"))

@jokurz Homework chores if you don't mind :

verify that somehow we cannot retrieve oslevel output another way ;
check whether passing a specific flag to oslevel would be relevant in our case, according to AIX's terminology (manual).

Thanks, bye 👋

@HorlogeSkynet, sounds good. However, while I don't know AIX, it doesn't make sense to me that there isn't a file with that info? Does AIX have a magical way of storing this info that we can't read?

Closing here, please see #311.
An official review is expected from you @nir0s, but I'd be interested from yours too @jokurz. Bye :wave:


Return type of Enumerable#sum and #product for union elements

Enumerable(T)#sum and #product usually use the element type (T) as the type of the sum/product unless specified.
This is usually a good default but raises the question what should happen when the element type is not a single type, but a union?
Turns out, the implementations picks the first type in the union (note: order of types in a union is lexicographic by the type name):
typeof([1_i8, 2_i16].sum) # => Int8

I think this is quite unexpected and can lead to surprising behaviour: For example [1_i16, 12345678_i32].sum raises an overflow error when the result would fit perfectly into Int32.
If the implementation picks one type from the union, I figure it should rather be the biggest type of the union. For number types this might be relatively easy, but not without issues (e.g. when combinging signed and unsigned types of the same width). And there would be no way this could work for custom types. I don't have a real use cases for math operations on unions outside of Number, but there is probably some with related values types.
In my opinion, it would probably be best to not automatically pick a type if there are multiple options. It's better to make this a compile time error instead of running into weird overflows at runtime because the sum type is smaller than expected.
It's trivial to specify the desired target type by passing an initial value in that type.
For example:
[1_i16, 12345678_i32].sum(0_i32) # => 12345679

Of course this would be a breaking change. But IMO that's acceptable because it corrects a confusing behaviour. This is a rarely used feature anyway, so impact should be minimal.
This repo doesn't seem to use this and test-ecosystem doesn't show anything breaking either: https://github.com/crystal-lang/test-ecosystem/actions/runs/12285549227/job/34286237286
This issue was originally reported at https://fosstodon.org/<EMAIL_ADDRESS>

@straight-shoota I have a fix along with a couple of tests (see https://github.com/rvprasad/crystal) but I am facing one issue: how do I test for compiler errors in automated tests?
I tried using assert_macro_error but it did not work as expected, i.e., it expected a TypeException at runtime while Macros#raise does not trips the compiler.

assert_macro is specifically for testing errors in macro expansion. This error is triggered from a macro expression, but it happens in the context of semantic analysis of the non-macro code. The spec helper for this is assert_error.
You can use it like this:
assert_error <<-CRYSTAL, "does support Union types"
        require "prelude"
        [1_i8, 2_i16].sum
      CRYSTAL

Thanks.  That worked!


Replaced device.localcredential instances with devicelocalcredential

Based on feedback from Muchen Ji (MMD team) replaced device.localcredential instances with devicelocalcredential Also fixed a typo on the manual consent URL for multi-tenant: = should be & (same as single tenant ID essentially)

@robinharwood, @Xelu86
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I reviewed this.   The changes look fine from a technical perspective.  Thanks - Jay

#sign-off

#sign-off


List only the resources in the current namespace for deletecollection request for Shootstates

How to categorize this PR?

/area quality
/area security
/kind bug
What this PR does / why we need it:
The DELETECOLLECTION sends a request with an empty resource name. We then try to list the resources and check if all of them have the deletion confirmation annotation. But while listing, we were not using the namespace in the request, so it was trying to look for all resources in all namespaces in the current namespace. This caused errors like,
panic: shootstates.core.gardener.cloud "Unknown" is forbidden: 5 errors occurred:
	* shootstates.core.gardener.cloud "bazz" not found
	* shootstates.core.gardener.cloud "foo" not found
	* shootstates.core.gardener.cloud "bar" not found

This PR fixes this issue by listing only the resources in the namespace of the request.
Which issue(s) this PR fixes:
Fixes #7776
Special notes for your reviewer:
Release note:

A bug causing KCM to fail to clean up shootstate resources is now fixed.

/assign

Thanks @shafeeqes 👏🏻
/lgtm
/approve

Shall we include this PR also in the milestone? @oliver-goetz

sounds like a plan 👍
/milestone v1.69


Feature_Request

the window section that appears at the beginning can be also closed by clicking outside of the window or clicking exit button
I will add JavaScript functionalities so that this feature can be added to this site
I have good knowledge of JavaScript

Hey @apu52 please add level to this issue and assign this to me as a GSSoC contributor

Hi @Ramben0909 ,
I have assigned this issue to you, please start working on it and get it done in 2-3 days.
Regards
Project Mentor


treat auth.User when AUTH_USER_MODEL is specified for another

你好!
When AUTH_USER_MODEL is defined for another model, Django doesn't create auth_user table during migration. But auth.User exists in app_models. Because the migrations have information of auth.User. So it should be dropped.

Thank you for your pull request @jbking.
Can you add a test to your pull request?

Check the test. Thanks.


Typescript Support

Hey,
Just a question. I kind of see typescript as one of those "bleeding-edge" tools that this repository can really get to working with it. What do you guys think? Maybe we need support for Typescript, maybe making this universal example implement everything in typescript and then add the ts-loader for webpack.
Also, as a personal opinion, typescript is super powerful with its type definitions and can really help to scale a good app.

#632 related, typescript seems even heftier than flow from what I've read

Yea. As of right now, typescript is a lot more powerful than what Flow can accomplish. Give that expressive power to Redux and you can really get something going :)

Out of curiosity: What is the status of Typescript? Can it keep up with modern babel plugins like react transform? Does it support the latest features of ES6 and React?

Typescript is pretty mature right now. It is currently more ES6-7 compliant than FlowType. It can compile jsx files (essential it calls them .tsx files, but works the same).

Any plans to do this?


staboard-operator cannot pull images from ECR

What steps did you take and what happened:
Install starboard-operator based on 0.10rc2
the rbac section in the values file is as follows:
    rbac:
      create: true
    serviceAccount:
      # Specifies whether a service account should be created.
      create: true
      annotations:
        eks.amazonaws.com/role-arn: arn:aws:iam::XXX
      # name specifies the name of the k8s Service Account. If not set and create is
      # true, a name is generated using the fullname template.
      name: ""

Can see vulnerability reports being generated in all namespaces for public images but not for private images hosted in ECR
Seems the annations are appended in the sa, but still it doesn't work
The iam policy has been created based on the following link
https://docs.aws.amazon.com/AmazonECR/latest/userguide/ecr_managed_policies.html#AmazonEC2ContainerRegistryReadOnly
What did you expect to happen:
see vulnerabilitry reports for images hosted in private ECR
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Starboard version: 0.10-rc2
Kubernetes version: EKS 1.18

Please find below an error log from the operator
{"level":"error","ts":1617114523.1388361,"logger":"controller-runtime.manager.controller.job","msg":"Reconciler error","reconciler group":"batch","reconciler kind":"Job","name":"scan-vulnerabilityreport-cfd764765","namespace":"starboard-operator","error":"json: cannot unmarshal number into Go value of type []trivy.ScanReport","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/home/runner/go/pkg/mod/github.com/go-logr/zapr@v0.2.0/zapr.go:132\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.7.2/pkg/internal/controller/controller.go:267\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.7.2/pkg/internal/controller/controller.go:235\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.1\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.7.2/pkg/internal/controller/controller.go:198\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:99"}

@steevi
Hi steevi !!
I used the eksctl command to create a service account, did you create it here?
https://aquasecurity.github.io/starboard/v0.10.1/integrations/managed-registries/
My Environment:

Starboard version: 0.10.1
Kubernetes version: EKS 1.19

Closing as Starboard only supports scanning K8s workloads that run private container images with imagePullSecrets. ECR and other managed registries typically authorize service accounts or cluster nodes (with custom annotations or other means) to pull down images without explicitly creating imagPullSecrets.
To scan any type of registry without extensive configuration or permissions we are considering Trivy file system scanner. See #818 for more details.


Mention how "private protected" works with InternalsVisibleTo

It is not clear based on this page whether or not InternalsVisibleTo works with "private protected" members

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee5e6972-0f7a-8bb7-9f5a-0ba75909f9d8
Version Independent ID: 618c0361-38a0-4d6f-f46a-881db2e4b399
Content: private protected - C# Reference
Content Source: docs/csharp/language-reference/keywords/private-protected.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @sputier
Microsoft Alias: wiwagn

Thanks for writing this @mstefarov
I'll have to look this up. I've added it to our next sprint.


Support for summary silently dropped

The README still says:

summary: the package summary/description. If not present, package.description is used.

However, PR #46 removed support for this and was included in release v0.9.0, but no mention of this was made in the release notes and the README was not updated.
Worse, using summary doesn't cause an error or warning, it just doesn't have the desired effect.
I only found this because rpmlint complains about my description being too long even though I set summary to a shorter text.

Also, unless I am doing something wrong, it seems that setting [package.metadata.generate-rpm].description does not override [package].description.

Oh, it is just a degrade bug caused by typo.

Thanks @cat-in-136 for the quick response!


Am I the only one who is experiencing problem about Permission to index.json file?

I executed streamlit_vector with .cmd and here is my error message.
"PermissionError: [Errno 13] Permission denied: './index.json'"
I tried everything with the permission setting of index.json file and it's not working.
Can anyone help me please?

@dglee-rbrain you can try using chmod -R 775 to change the permissions of entire folders.
Not sure why you are hitting that issue though. It might also depend where you are running g the code on your computer, and your operating system

@dglee-rbrain you can try using chmod -R 775 to change the permissions of entire folders.
Not sure why you are hitting that issue though. It might also depend where you are running g the code on your computer, and your operating system

Thank you. It worked when I changed working directory closer to .py file

Perfect!


Checker nvcc: use makeprgBuild and add config file support

The nvcc checker is currently not using the makeprgBuild function and thus does not allow users to set compiler arguments within vim configs. There is also no support for config files.
This pull request adds support for both.
I am not an experienced vimscript user and help as well as a code review would be most welcome, although most of this is copied from other checkers...

This would have been better handled by the syntastic#c#GetLocList() framework, but the special case of headers doesn't allow that.  How ugly.  Anyway, your patch discards the use of g:syntastic_cuda_arch, which would introduce a pointless backward incompatibility.  Please try commit f9eca22 instead.

Thank you! This is what I wanted and I think I learned a lot from your changes :-)
However, do you see a possibility to remove the dummy file (.syntastic_dummy.cu) afterwards? It doesn't feel right to clutter the directory.
Oh and correct me if I am wrong but the way it is set up now there is either the possibility for a configuration of arguments within the config file or within a vim config.
Since 'args': syntastic#c#ReadConfig(g:syntastic_cuda_config_file) will be overridden by let g:syntastic_cuda_nvcc_args = ....
I personally would like to specify some global arguments (like '--std=c++11') in my ".vimrc" and some local arguments (like include paths) in the config file.

do you see a possibility to remove the dummy file (.syntastic_dummy.cu) afterwards?

Sorry, but no.  Running rm automatically is always problematic, I don't want to go there.  Run a cleanup job from cron if you must.

the way it is set up now there is either the possibility for a configuration of arguments within the config file or within a vim config.

Yes, this is intentional.  Use args if you have a few options.  Switch to a config file if you need more.  Use autocmds to switch config files if you need different sets of options for different files.   Or is that to problematic due to different platforms?
Combining config file and arguments from the .vimrc works for gcc/clang, but I didn't figure out where in the code the combination actually happens. I just saw it in the debug output.

Would creating it in a temp directory be an option?

You're trying to solve a non-problem.  Like I said, you have options to solve it on your side.

Combining config file and arguments from the .vimrc works for gcc/clang, but I didn't figure out where in the code the combination actually happens.

gcc / clang use the syntastic#c#GetLocList() framework.

I am sorry to bother you again about this...
I still see the order in which arguments are overridden as a problem: If one starts out using args and later realizes that more options are required, thus creating a config file within the project folder, the config file will be ignored.
On the one hand this may lead to confusion and on the other hand I feel that local options (or in general options specified closer to the source) should not be overridden by global ones.
I don't know if it is currently possible to override the global (.vimrc) options if makeprgBuild is used. However, appending the options from the config file to args_before would resolve both these concerns and furthermore enable the workflow I was mentioning before (and already use with gcc / clang).

I still see the order in which arguments are overridden as a problem

Then feel free to fork nvcc.vim, rename the checker to something else, change it to suit your needs, and maintain it as an external checker.  It's easy.

I don't know if it is currently possible to override the global (.vimrc) options if makeprgBuild is used.

As noted in the manual, buffer-local variables b:syntastic_cuda_nvcc_args will override g:syntastic_cuda_nvcc_args.

However, prepending the options from the config file to args_after would resolve both these concerns and furthermore enable the workflow I was mentioning before

So would adding extra options to g:syntastic_cuda_nvcc_args_after instead of g:syntastic_cuda_nvcc_args.

As noted in the manual, buffer-local variables b:syntastic_cuda_nvcc_args will override g:syntastic_cuda_nvcc_args.

I meant from within the checker (overriding the g:syntastic_cuda_nvcc_args with the options from the config file).

So would adding extra options to g:syntastic_cuda_nvcc_args_after instead of g:syntastic_cuda_nvcc_args.

I guess you mean g:syntastic_cuda_nvcc_post_args (since  g:syntastic_cuda_nvcc_args_after is internal to the checker) yes that could work.


[hotrod] Bump jquery to 3.7.0

Short description of the changes

Copy latest version of jquery into hotrod web_assets
Small fix to rebuild_ui script to pull the latest tags

tested manually, no issues


icons: update to support new design tokens

Is your feature request related to a problem? Please describe.
The following code is restricted to only support the legacy Auro design tokens
https://github.com/AlaskaAirlines/Icons/blob/299db99da3d80b2462565daf7dcf94652bab35ee/src/data/icons.json#L8-L9
Describe the solution you'd like
Update token references to use new naming convention
Describe alternatives you've considered
none
Additional context
none
Exit criteria
This issue can be closed once the icon build supports the new token names.

This issue has been brought back as there was a need to revert the commit that changed the in-line CSS in the icons.

https://github.com/AlaskaAirlines/auro-icon/issues/94


[AlertIcon] typescript error

Description
typescript error
CodeSandbox/Snack link
No response
Steps to reproduce

gluestack-ui Version
0.1.38
Platform

[ ] Expo
[ ] React Native CLI
[ ] Next
[ ] Web
[X] Android
[X] iOS

Other Platform
No response
Additional Information
No response

And size prop is an optional props in previous version

+1 Also happens for the variant and space props of Button and HStack for me.

@BooYeu Thanks for reporting this. This issue is fixed in the latest version.
Can you please try updating @gluestack-ui/themed and @gluestack-style/react to the latest?

@BooYeu Thanks for reporting this. This issue is fixed in the latest version. Can you please try updating @gluestack-ui/themed and @gluestack-style/react to the latest?

Hi @BooYeu  This issue still persist even after updating to latest version.

### Please note that this bug is mark open!!

Hey @dg0005, It's working for me. Can you provide repo where issue exist?

Hey @Viraj-10, please have a look on below attached screenshot.

Hey @dg0005, It's working for me. Can you provide repo where issue exi

Hey @Viraj-10, please have a look on below attached screenshot.

Hi @Viraj-10,  by any chance did u go through the above screenshots??


11 remove clones

complete remake of the library with more efficiency

current version of this PR does not solve the original problem, but the library is fully operational and much better than before

roadmap for this PR is:

optimize
create docs
add feature with eq-float support

documentation should be finished (unless adding more examples), I'm gonna check it off now

It appears that the clone issue is unsolvable with this current library model. I think I might just have to merge this and finish it later if I can find a fix.


Add example for ipython-mode

I am planning to add an example with ipython-mode (https://github.com/JuliaLang/julia/pull/46474) after Julia v1.9.0 release.

Sounds great.
What should I do before doing that?
From my understanding I have to update the code below in replay function:
https://github.com/AtelierArith/Replay.jl/blob/86c3f4a2ab7f1ed82db6fe3dbfa5075739f68467/src/Replay.jl#L142-L196
This code (I wrote this one year ago) displays a hard-coded prompt that users could change. I need to read code in julia/stdlib/REPL module to figure out what Julia's REPL does.

The feature is renamed to numbered_prompt.
https://github.com/JuliaLang/julia/pull/49314


fix(common): Fix response filter when plain/text

Information

Type
Breaking change

Fix
No

:tada: This PR is included in version 6.24.1 :tada:
The release is available on:

v6.24.1
GitHub release

Your semantic-release bot :package::rocket:


Can I copy part of your message to the Firefox reviewers?

I'm helping out on Selenium IDE and we just got the axe and your guys message really wraps up our situation too pretty well, so I want to copy part of that segment for our Readme as well.
How best can I copy that sentence and give you guys attribution? You seem like a cool group and I'd like to do this right :)

Hey guys, I gave thanks in the commit message and changed the language to be unique. I hope this is sufficient. I'm just trying to deal with the mo hammer. Please let me know if there is anything else I could do to say thanks.

More than sufficient. Glad we could help.


Failed to parse an AXML (Instagram)

I got an Instagram app from apk pure for testing: https://apkpure.com/instagram-android/com.instagram.android/variant/<IP_ADDRESS>.3-APK
axmldecoder failed with this error:
'assertion failed: `(left == right)`
 left: `Some("http://schemas.amazon.com/apk/res/android")`,
 right: `None`', github.com-1ecc6299db9ec823/axmldecoder-0.4.0/src/xml.rs:101:9

as you can see this line: https://github.com/Ayrx/axmldecoder/blob/master/src/xml.rs#L101

@grubeli Thanks for the report! Can you see if a70f72ab149246d35e4344e995e13b47ad028c22 fixes the issue for you? I've tested it but would be good to get confirmation.

works! thanks.


BulkOperationBuilder: Call insert_one rather than deprecated insert

Currently, using mongomock, with a recent PyMongo we get:
site-packages/mongomock/collection.py:266: DeprecationWarning: insert is deprecated. Use insert_one or insert_many instead.     self.collection.insert(doc)
This PR tries to remove the warning.

Perfect, thanks!

Thanks for the quick review and merge !


Custom hotkeys

Is your feature request related to a problem? Please describe.

Unwanted hotkeys can be a problem see #1515.
Describe the solution you'd like

I would like for the client to have a list of shortcuts, if none is found the default shortcuts are filled in. Hotkeys would be categorized by scope (this decides where the shortcut is registered and where it works). Each shortcut would need to contain the scope, key_sequence and action. These would be stored in a list in the settings.json file. All widgets would have to have a list of defined  actions, for example for a split that could be:

change_channel
close
open_popup
open_search
etc.

Describe alternatives you've considered

Not doing it and sticking to hard-coded shortcuts.
Additional context

Example hotkey:
{
  "scope": "split",
  "key_sequence": "Ctrl+L",
  "action": "clear"
}

I'm posting this because I didn't find the feature request, sorry if there is one for this already
Possible implementation

Create a new controller for keybinds. That would store the currently registered actions and the scopes they belong in.
1. Create a Action struct that would hold information about a particular keybind: the scope of it, the action name, the function connected to it and possibly the default key combo (this could be put in a separate file to make changing default hotkeys easier, but it would make adding new ones harder)
2. The controller should save actions with the functions they are connected to.
Find every single keybind in the program. Note: My list is probably incomplete
Replace with appropriate calls to the controller.

Here is a list of shortcuts' definitions:
Split.cpp
    // Initialize chat widget-wide hotkeys
    // CTRL+W: Close Split
    createShortcut(this, "CTRL+W", &Split::deleteFromContainer);

    // CTRL+R: Change Channel
    createShortcut(this, "CTRL+R", &Split::changeChannel);

    // CTRL+F: Search
    createShortcut(this, "CTRL+F", &Split::showSearch);

    // F5: reload emotes
    createShortcut(this, "F5", &Split::reloadChannelAndSubscriberEmotes);

    // F10
    createShortcut(this, "F10", [] {
        auto *popup = new DebugPopup;
        popup->setAttribute(Qt::WA_DeleteOnClose);
        popup->show();
    });

Window.cpp
    // Window::addDebugStuff
    createWindowShortcut(this, "F6", [=] {
        const auto &messages = miscMessages;
        static int index = 0;
        auto app = getApp();
        const auto &msg = messages[index++ % messages.size()];
        app->twitch.server->addFakeMessage(msg);
    });

    createWindowShortcut(this, "F7", [=] {
        const auto &messages = cheerMessages;
        static int index = 0;
        const auto &msg = messages[index++ % messages.size()];
        getApp()->twitch.server->addFakeMessage(msg);
    });

    createWindowShortcut(this, "F8", [=] {
        const auto &messages = linkMessages;
        static int index = 0;
        auto app = getApp();
        const auto &msg = messages[index++ % messages.size()];
        app->twitch.server->addFakeMessage(msg);
    });

    createWindowShortcut(this, "F9", [=] {
        auto *dialog = new WelcomeDialog();
        dialog->setAttribute(Qt::WA_DeleteOnClose);
        dialog->show();
    });

    // window::addshortcuts

    // Open settings
    createWindowShortcut(this, "CTRL+P", [] { SettingsDialog::showDialog(); });

    // Switch tab
    createWindowShortcut(this, "CTRL+T", [this] {
        this->notebook_->getOrAddSelectedPage()->appendNewSplit(true);
    });

    // CTRL + 1-8 to open corresponding tab.
    for (auto i = 0; i < 8; i++)
    {
        char hotkey[7];
        std::sprintf(hotkey, "CTRL+%d", i + 1);
        const auto openTab = [this, i] { this->notebook_->selectIndex(i); };
        createWindowShortcut(this, hotkey, openTab);
    }

    createWindowShortcut(this, "CTRL+9",
                         [this] { this->notebook_->selectLastTab(); });

    createWindowShortcut(this, "CTRL+TAB",
                         [this] { this->notebook_->selectNextTab(); });
    createWindowShortcut(this, "CTRL+SHIFT+TAB",
                         [this] { this->notebook_->selectPreviousTab(); });

    // Zoom in
    {
        auto s = new QShortcut(QKeySequence::ZoomIn, this);
        s->setContext(Qt::WindowShortcut);
        QObject::connect(s, &QShortcut::activated, this, [] {
            getSettings()->setClampedUiScale(
                getSettings()->getClampedUiScale() + 0.1f);
        });
    }

    // Zoom out
    {
        auto s = new QShortcut(QKeySequence::ZoomOut, this);
        s->setContext(Qt::WindowShortcut);
        QObject::connect(s, &QShortcut::activated, this, [] {
            getSettings()->setClampedUiScale(
                getSettings()->getClampedUiScale() - 0.1f);
        });
    }

    // New tab
    createWindowShortcut(this, "CTRL+SHIFT+T",
                         [this] { this->notebook_->addPage(true); });

    // Close tab
    createWindowShortcut(this, "CTRL+SHIFT+W",
                         [this] { this->notebook_->removeCurrentPage(); });

    // Reopen last closed split
    createWindowShortcut(this, "CTRL+G", [this] {
        if (ClosedSplits::empty())
        {
            return;
        }
        ClosedSplits::SplitInfo si = ClosedSplits::pop();
        SplitContainer *splitContainer{nullptr};
        if (si.tab)
        {
            splitContainer = dynamic_cast<SplitContainer *>(si.tab->page);
        }
        if (!splitContainer)
        {
            splitContainer = this->notebook_->getOrAddSelectedPage();
        }
        this->notebook_->select(splitContainer);
        Split *split = new Split(splitContainer);
        split->setChannel(
            getApp()->twitch.server->getOrAddChannel(si.channelName));
        splitContainer->appendSplit(split);
    });

    createWindowShortcut(this, "CTRL+H", [this] {
        getSettings()->hideSimilar.setValue(!getSettings()->hideSimilar);
        getApp()->windows->forceLayoutChannelViews();
    });

    // Window::addMenuBar

    // Window menu.
    QMenu *windowMenu = mainMenu->addMenu(QString("Window"));

    QAction *nextTab = windowMenu->addAction(QString("Select next tab"));
    nextTab->setShortcuts({QKeySequence("Meta+Tab")});
    connect(nextTab, &QAction::triggered, this,
            [=] { this->notebook_->selectNextTab(); });

    QAction *prevTab = windowMenu->addAction(QString("Select previous tab"));
    prevTab->setShortcuts({QKeySequence("Meta+Shift+Tab")});
    connect(prevTab, &QAction::triggered, this,
            [=] { this->notebook_->selectPreviousTab(); });

EmotePopup.cpp
    // constructor

    createWindowShortcut(this, "CTRL+Tab", [=] { notebook->selectNextTab(); });
    createWindowShortcut(this, "CTRL+Shift+Tab",
                         [=] { notebook->selectPreviousTab(); });

A couple of non-obvious actions:

split_input.undo
split_input.redo
split_input.copy
split_input.paste
split_input.delete Deletes the selection
split_input.select_all
split_input.clear Clears the input box

Actions could also be triggered by commands and such.

I would like to add arguments to this proposal. Action arguments could be a list of strings that tell the actions the specifics of what to do.
Example:
{
  "scope": "tab",
  "key_sequence": "Alt+H",
  "action": "focus",
  "arguments": [
    "left"
  ]
}

Hey, got curious and started looking at custom keybinds... i'd like to be able to open the current tab in streamlink, either with a "keybind", or, sending a message in that chat (obviously the message would be totally truncated - was thinking more along the lines of a chatterino command?)
Regardless i'd like to see this feature, and I could even offer help, i've had a look at the source to see if i can fudge a simple solution for what i want but, i got hungry and gave up...

:)

also: keybinding to clear messages

also: open viewer list

Also: Open in web browser/player/streamlink

Also: turn on/off/toggle streamer mode.

Also: turn on/off/toggle streamer mode.

Also: quit application, some platforms don't have a global keybind for this

Also: quit application, some platforms don't have a global keybind for this

Also: change tab locations in notebook.

  Is it possible to make a hotkey to open s stream in streamlink?

 Is it possible to make a hotkey to open s stream in streamlink?

@haltdev You can add a hotkey that does this by clicking the Add button in the Hotkeys panel and select the "Split" category and select the "Open Stream in Streamlink" action.
You may need the Nightly version if you are running a release that doesn't have this feature

Thank you @MrAuro ! I needed the Nightly build - all I was seeing in Settings was "Keybindings" and it wouldn't let me change any of them.  Thanks for your help!

Hi, I'm not sure if this is the right place to ask this, but hopefully it's not too wrong either
I was wondering how to set up custom hotkeys for the ban/unban/timeout buttons in the popout window, so that I can use my 1-12 keyboard/mouse buttons. It appears to be possible, but I have very low understanding of how programming/coding works, despite looking through pages here to try and figure it by myself. If it is something I have to figure out by myself still, I would appreciate if someone could point me in the right direction with some steps.
If this is relevant, I do have the latest Nightly build.
(screenshot attached to clarify which buttons I'm talking about)

I was wondering how to set up custom hotkeys for the ban/unban/timeout buttons in the popout window, so that I can use my 1-12 keyboard/mouse buttons.

@Buggy12345 This isn't yet possible. Thanks for the no-so-intended reminder on adding this feature!

Is there any way to have hotkeys globally so I can use them without having the windows being active? I pretty much have to have chatty and chatterino on at the same as as this one feature is missing.

Is there any way to have hotkeys globally so I can use them without having the windows being active? I pretty much have to have chatty and chatterino on at the same as as this one feature is missing.

I use AutoHotKey for this. If Chatterino is open, my hot key will open the current tab in Streamlink. If chatterino is not open, the hot key will launch chaterrtino and open the current tab in streamlink. I have the hot key mapped to a stream deck button.


"All required parameters must be populated in order to send to server" - comment added in wrong classes

I see these code comments in emitted Python code "All required parameters must be populated in order to send to server". They are not in my TypeSpec files, so this is coming from the auto-gen tool. However, looks like they get inserted into all classes (TypeSpec "models") regardless if they are associated with HTTP request payload or response payload. I don't expect to see them inserted in class associated with response payload.
How do I control where this comment is inserted (or how do I disable this completely)?
My Python client library is here: https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/ai/azure-ai-inference
My TypeSpec files are here (topic branch): https://github.com/Azure/azure-rest-api-specs/tree/dargilco/ai-model-inference/specification/ai/ModelClient
Thanks,
Darren

But I must say it's a bit odd that the emitter adds code comments... My expectation is that the developer controls all code comments, and they all originate from what's written in TypeSpec files. My suggestion is to remove this completely. Do emitters in other programming languages add a similar comment?

Also note that I define some models in TypeSpec related to response from the service, that are not used by auto-gen code. They are used by hand-written code. How is the auto-gen tool going to know how these models are used, and only to apply the added code comments to models related to service requests?


systemd-stage-1: Improve test-instrumentation output

Description of changes
All this does is make the output of systemd-stage-1 in nixos tests match the style of stage 2 systemd. Much easier to work with when debugging tests.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@SuperSandro2000 that's how you use the checkboxes btw


An unintrusive menu-bar to help make features discoverable.

Why
When I first stumbled onto this editor, I didn't know that it supported saving and opening files. It was only on reading the initial document that you could find that out. That is not much intuitive.
How
I'm creating a bottom bar that has some buttons like:

Save
Open
Toggle Split View Mode as requested in #5
More as ideas come.

Thing is, I won't add new features, just ways to discover them easily. Like minor CSS tweaks as in #5 and already existing functionality like saving and link-sharing.
Time Plan
This should be a small contribution. I'll be done by 25th June, if all goes right. Requesting suggestions.

Implemented and merged.


Simplified pipeline creation with Makefile

This is awesome, thanks so much for sharing. Can you please sign our CLA?
Thanks again!

CLA has been signed. Since this is just a docs change I'm going to merge without waiting for CI to pass. CI doesn't check anything that this touches anyways.


SMS blocklist

It's not possible to block an incoming SMS, however, we could make it so that we do not respond, essentially blackholing it.

The user that needed this feature was able to get Twilio to block the number.  We will still put this feature out there since it's pretty much done anyway.  It could be helpful.

this has been released in 4.2.1


fix: Added sensitive field in output "primary" in mssql module

This PR is to fix the issue mentioned in https://github.com/terraform-google-modules/terraform-google-sql-db/issues/364
Buganizer issue : (b/259913713): EXT: MSSQL output - We need to add sensitive = true for output "primary" on mssql module
Added sensitive field in output "primary" in mssql module, because google_sql_database_instance contains some sensitive fields.
Successfully passed docker_test_lint

@ravisiddhu
Thanks for the PR! 🚀✅ Lint checks have passed.

@ravisiddhu no blockers to merge but our expectation is that these modules are used within root modules and not directly consumed. Consumers have full control over root modules to adjust the sensitivity of outputs

@ravisiddhu
Thanks for the PR! 🚀✅ Lint checks have passed.


[Mesos] migrating configuration file to new norm

What does this PR do?
Migrates Mesos Master and Mesos Slave configuration file to the new norm.
Introduce the tags parameter since it should be supported
Open question
What does the tasks parameter does Mesos slave integration?

@zippolyte what's the tasks parameter in mesos slave iintegration configuration file?

Couldn't find much. Looks like it's only to specify the tasks for which you want to send metrics


nh: 3.5.10 -> 3.5.13

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for nh is: Yet another nix cli helper
meta.homepage for nh is: https://github.com/viperML/nh
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.5.13 with grep in /nix/store/2q5ppjlz4245k4nixx9kpli8l84qsrb1-nh-3.5.13
found 3.5.13 in filename of file in /nix/store/2q5ppjlz4245k4nixx9kpli8l84qsrb1-nh-3.5.13

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

nh

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2q5ppjlz4245k4nixx9kpli8l84qsrb1-nh-3.5.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nh https://github.com/r-ryantm/nixpkgs/archive/2980c6217b0d0726e9d0040178a6adb8cb596738.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2980c6217b0d0726e9d0040178a6adb8cb596738#nh

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2q5ppjlz4245k4nixx9kpli8l84qsrb1-nh-3.5.13
ls -la /nix/store/2q5ppjlz4245k4nixx9kpli8l84qsrb1-nh-3.5.13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

nh

Maintainer pings
cc @drupol @viperML for testing.

lgtm


[BugFix] use schema deserialize chunk.

rpc returned chunk not have full meta info.
What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_be_unittest

run starrocks_admit_test

run starrocks_admit_test


steps 1-5, small changes before deciding behavior

Steps 1-5 of the direct messages project. Set up the base for the message recipient functionality.

Closed wrong pull request


Fix fetching of eslint with older npm versions

Just referencing https doesn't work with older versions of npm.
See example where it fails with npm v1.4.6 here: https://travis-ci.org/watson/async-state/builds/81012276
Using the git+https scheme instead should fix it.

:+1:

2.1.1

@Flet you should add @watson as collaborator/npm-owner

Done and done! :+1:

Cross-posting for visibility...
Thanks for your help @watson – I've added you as a GitHub collaborator and npm owner :+1:
Also, eslint 1.5.0 was published earlier today, so I've removed the git dependency entirely, as promised. Sorry for the trouble, everyone.


User Story

This will be the reason behind the creation for the website and what problems we are trying to solve.

As a user I will use this site as a comprehensive gaming log, for past, present and future games in my collection.
The user is able to log in and be presented with the option of choosing to browse for a new game or log their past games.
The user is able to log past games played or currently in progress. The site will be able to recognize the game's genre and possible platforms.
The user is able to search for new games by genre and platform.
The user is presented with price options for the new games, and if they choose to add that to their backlog library.


(3.0.50) CTL-S is not properly bound in method list browser from list references

Not expected:

CTL-F is not bound eitther ... looks like all of the bindings are lost?

Should be fixed in 3.0.51. The accelerator keys are not at all straightforward in Dolphin. Removal of a high-level menu recently removed the ctrl bindings even though the bindings were specified in the presenter.
I've  looked into writing tests that simulate the ctrl keys so they don't get lost in the future, but so far successful tests have eluded me. Will continue to try.

Only verified these two in 3.0.51 so


[textanalytics] adjust failing tests

model no longer detects fake routing number

API change check
API changes are not detected in this pull request.


Use cockpit's PatternFly CSS with some css updates for composer

This takes updates made in https://github.com/weldr/cockpit-composer/pull/700 and adds a few miscellaneous css updates in the context of Composer custom css updates.
There were a couple of items provided in the cockpit css that didn't have sufficient color contrast. I updated those here, but it might be worth checking if these are used in cockpit, and if the color contrast issues are present there as well.
.fields-status-pf {

  color: #8b8d8f;
  margin-bottom: 15px;
}

I updated this in composer to var(--pf-global--Color--200);
.label-info {

  background-color: #73bcf7;
}

I updated this in composer to var(--pf-global--link--Color)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9258d84). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #725   +/-   ##
=========================================
  Coverage          ?   78.13%
=========================================
  Files             ?       66
  Lines             ?     3343
  Branches          ?      703
=========================================
  Hits              ?     2612
  Misses            ?      731
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9258d84...b3c3c7a. Read the comment docs.

Many thanks, @jgiardino! As this and the original PR #700 are identical now, I copied your comment to #700 (as that has more history), and close this one.


Neurobagel can search IDPs

Context
Rolling out nipoppy to collaborators
Why

So we can find IDPs

Outcomes

[x] The Neurobagel data model understands IDPs
[x] A user who has used Nipoppy to generate IDPs can tell Neurobagel about them with no additional manual tasks (other than running tools)
[x] A user can search for subjects processed with a given pipeline and version
[x] There exists a list (vocabulary) of standardized pipeline names that nipoppy knows about (each with their known version names)

What
Nipoppy:

[x] Create or get examples of the nipoppy imaging bagel format for testing
[ ] Get a copy of the imaging bagel validation schema from Nipoppy
[x] Create vocabulary repo with one file per pipeline

Neurobagel:

[x] https://github.com/neurobagel/neurobagel_examples/issues/33
[x] https://github.com/neurobagel/bagel-cli/issues/342
[x] https://github.com/neurobagel/bagel-cli/issues/262
[x] https://github.com/neurobagel/api/issues/341
[x] neurobagel/recipes#88
[x] neurobagel/api#344
[x] https://github.com/neurobagel/federation-api/issues/113
[x] https://github.com/neurobagel/federation-api/issues/117
[x] https://github.com/neurobagel/query-tool/issues/282
[x] neurobagel/documentation#230
[x] Re-release:

[x] f-API
[x] n-API
[x] query tool
[x] CLI

[ ]  https://github.com/neurobagel/bagel-cli/issues/352

Closing as all key issues have been addressed; we will address https://github.com/neurobagel/bagel-cli/issues/352 separately as it is currently blocked by https://github.com/neurobagel/bagel-cli/issues/180.


Page needs updating for C++20

There's multiple instances on this page where it says the u8 prefix maps onto char / std::string, such as in the comments in the first code block. It needs to be updated to say that if you have MSVC set to C++20 mode, u8 maps to char8_t / std::u8string instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ebb90bf-a25a-cb4c-56d0-d46cc341d14b
Version Independent ID: e709e8b2-2a41-f66b-26cd-762a631817cc
Content: String and character literals (C++)
Content Source: docs/cpp/string-and-character-literals-cpp.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

Fixed some time ago, but I forgot to close the issue.


Less claustrophobic clipart experience

Given the amount of icons and the amount of scrolling needed to go through the list I think the clipart UI should be updated a little. I played a little with the page and with 3 simple changes I was able to achieve this:

I moved canvas.form-image-preview into <label for="_frm-iconform-source"> and updated these CSS styles:
.form-image-preview {
    /* max-height: 135px; */
    max-width: 135px;
    margin-top: 20px;
}
.form-image-clipart-list {
    width: 570px;
    height: 250px;
}

To see in context why I opened this issue, consider a wider-than-your-body sized monitor (#firstworldproblems):

At this point I think a larger scale redesign is needed :-/ The Asset Studio UI (and build system) is REALLY outdated.

This should be updated soon in the next version.

Assuming this is already live, the problem still stands: now icon picker is 5x3 instead of 4x3, I'm still feeling claustrophobic. There's a huge amount of screen space wasted:

This is a fairly standard size monitor: 1920x1080, I had this size at all companies I worked for in the past 7 years and at home. I believe any IT professional having a smaller screen size is severely limiting themselves in efficiency.

OK, will reopen.. one option is to make the left pane resizable.

If I were you an option I would try is to make left and right navigation drawers: one for input, and one for output configuration. The benefits:

plenty o'space for icons
no scrolling required to access properties
wastes less space on large screens, but still usable on small ones
everything is visible at once
adapts well for different screen sizes (css breakpoints);
combine with min/max width and percentages for width for maximum effect
a nice resizing experience may require complex JavaScript code, drawers are mostly CSS-only; except toggling the class to show/fix/hide

Take a look at https://regex101.com/ for an example: resize the window horizontally and observe.


anim-controller: fix transitions sorting / minimize code duplication

A sort function doesn't act on true/false, so this never sorted anything (copy/paste test for F12/DevTools):
transitions = [
  {priority: 10},
  {priority: 50},
  {priority: 1},
  {priority: 2},
  {priority: 100},
  {priority: 3},
];
transitions.sort(function (a, b) {
    return a.priority < b.priority;
});
console.log(transitions.map(_ => _.priority));

Result: [10, 50, 1, 2, 100, 3] (its fixable by replacing < with -)
And then priority sorting is used in multiple places, so this PR reduces the code size/repetition of the same sorting function by just reusing functions (imo saving time and hopefully less bugs)
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

LGTM. However, @mvaligursky and @ellthompson should approve before merging since this affects both animation and graphics subsystems.

I looks great, but I would not mind some simple test of this in the test/core folder


Tag forty-second group of mods

Successor to #7596.
As of partway through this PR, we have exhausted the list of untagged non-frozen non-erroring modules with download counts! Which means everything on GitHub and SpaceDock.

#rebuild


Create printingDigitsAsFizzBuzz.py

This is my way of FizzBuzz in Python.

I don't think this is an actual solution to FizzBuzz :/
closing this for now


Develop a logo for Notary

Since Notary has been formally invited for a project proposal to CNCF (https://github.com/cncf/toc/pull/38) I figure we would help you out a bit with a logo while that process happens in parallel.
I've spoken with @endophage about this already and will kick around some ideas.

@ecordell @HuKeping I hadn't gotten around to emailing you the good news yet, as note above, we passed the first hurdle in the CNCF submission process!
I sent @caniszczyk a few seal/stamp based inspirations for logos. If any of the other maintainers are interested in being involved in the logo design, I'll add you to the email chain. Otherwise I'll share whatever shortlist we come up with.

Cooooooooooooooooooooooooooooooool!
From: David Lawrence<EMAIL_ADDRESS>Sent: 2017年7月12日 5:25
To: docker/notary<EMAIL_ADDRESS>Cc: hukeping<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [docker/notary] Develop a logo for Notary (#1189)
@ecordellhttps://github.com/ecordell @HuKepinghttps://github.com/hukeping I hadn't gotten around to emailing you the good news yet, as note above, we passed the first hurdle in the CNCF submission process!
I sent @caniszczykhttps://github.com/caniszczyk a few seal/stamp based inspirations for logos. If any of the other maintainers are interested in being involved in the logo design, I'll add you to the email chain. Otherwise I'll share whatever shortlist we come up with.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/docker/notary/issues/1189#issuecomment-314576692, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJf03Q20Zhm3GzikZ5T9InEx3ayjuQ4_ks5sM-gfgaJpZM4OUzeM.

@endophage I reached out to LF Design, they suggested to work with 99designs first to generate logo ideas and then they can refine it if necessary.
Here's a first poll with some ideas: https://99designs.com/contests/poll/ks4pfg
Please rate them :)

I think #33 by hantoko is a little complicated.  I prefer a simple one.

Here's another poll to help iterate on designs cc: @endophage et al

@caniszczyk I think you omitted the link by accident?

@endophage ooops, sorry, should be here: https://99designs.com/contests/poll/uzjnyl
Please reach out to all the Notary devs and have them vote so we can close this out :)

Notary logo can be found in github.com/theupdateframework/artwork


fix(deps): update images to latest

This PR contains the following updates:

Package
Update
Change

icr.io/ext/sysdig/cluster-shield
minor
1.5.0 -> 1.6.0

icr.io/ext/sysdig/kspm-analyzer
patch
1.44.17 -> 1.44.18

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline


Ensure order of new Field etc

Currently, new Field instances are initiated in C-order (Python default). Change this to F and benchmark it.
Check if the same is the case in the Model initiation.

Wrong thinking. The instances are initiated as 1D arrays, so the order does not matter. fx, fy, and fz are then returned as 'F'-ordered 3D arrays.


Doesn't recognize async def

In the following code:
from myapp import myfunction

async def test_myfunction(test_client, app):
    a = await myfunction(test_client, app)

isort (4.2.5) tries to remove a newline. Are async def recognized by isort?

This is fixed in the just released to PYPI 4.2.8 release.
Thanks!
~Timothy

:+1: it works, thank you!

This is broken again in isort 4.2.15.

@meisenberg I've added an additional test case with the exact usage asked about in this issue, and it passes against 4.2.15 - what is the exact case you are running into, as this is indeed fixed in 4.2.15?
Thanks!
~Timothy

Apologies, I can't reproduce now; I must have had a different version of the package installed than I thought.


Field selector for finding unscheduled pods: "DesiredState.Host=" or "CurrentState.Host="?

Whats the correct field selector for finding unscheduled pods?
We support "DesiredState.Host=" currently, but if I understand correctly, it should be "CurrentState.Host=".
@lavalamp ?

@bgrant0607 has a strong opinion, IIRC, the scheduler should look at & set only desired state. probably not worth changing this for v1beta1/2 apis.

It should be PodSpec in v1beta3, but we need to actually set that field when we bind the pod. Fixing it for v1beta3 should fix it for v1beta1/2.

(Yes--my "set" referred to writing a binding, of course.)

More complete list of steps:

Write PodSpec.Host when binding
Run fit predicates wherever PodSpec.Host can be set: create, update, binding
Kubelet watches PodSpec.Host (rather than boundPods)
Scheduler watches PodSpec.Host

There are 2 things:
The field that we check internally and the field selector specified by the user.
Right now, the field that we check internally is pod.Status.Host.
The field selector specified by the user is "DesiredState.Host" in v1beta1,2 and Status.Host in v1beta3.
Based on the replies here, it seems that we want the scheduler to look at the spec and not the status.
Hence, the scheduler should query for:
/v1beta1/pods?fields=DesiredState.Host!= and
/v1beta3/pods?fields=Spec.Host!=
and we should be looking at the Spec.Host field internally
Is that correct?

Yes, but the other steps I mentioned are prerequisites for this change.

ok. Thanks for the explanation.
@bgrant0607 : Can you assign this an appropriate priority?

This is confusing enough, an important enough API (e.g., for integration with Mesos and YARN), and closely enough related to other goals (v1beta3, elimination of bound pods, elimination of pod cache) that I think it's P1.

I'll work on it.

xref https://github.com/mesosphere/kubernetes-mesos/issues/168

@bgrant0607 Can you tell us more about implementation step:
"Run fit predicates wherever PodSpec.Host can be set: create, update, binding"
The other steps are already addressed by our PRs, but we are not sure what this one means. It is some kind of feasibility for binding? If yes, where it is/should be checked?

We removed hostPort conflict checking in #4619. The problem was that it was applied when updating BoundPods, which we were trying to remove.
We do plan to replicate apiserver and support multiple, workload- and/or user-specific schedulers. However, unlike Omega, I don't think we should enforce invariants at the storage layer.
We added conflict checking to Kubelet in #5019. In general, the intent is that Kubelet should do admission control and be the final arbiter to ensure its own invariants and to ensure QoS of the running pods under dynamically varying load.
Other than host ports, I don't know that any of the other fit predicates are urgently needed. We should look at the scheduler's fit predicates, though, and decide which ones, if any, should be enforced by Kubelet:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/plugin/pkg/scheduler/algorithmprovider/defaults/defaults.go#L35
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/scheduler/predicates.go
The resource and node-selector predicates are obvious candidates.
Ideally, though, pods that failed the fit predicates wouldn't reach Kubelet often, so we should do "best effort" checking earlier. Where exactly is TBD. It can't go into validation, for reasons discussed in #2457.

@davidopp

@jszczepkowski or @nikhiljindal can you summarize what remains to be done for this issue?

@davidopp Take a look at #5501 if you like.

Can you explain how #5501 is related to this issue? Brian listed four things here
https://github.com/GoogleCloudPlatform/kubernetes/issues/5207#issuecomment-77969711
but that doesn't seem to correspond to any of them (I may be missing something though).

https://github.com/GoogleCloudPlatform/kubernetes/issues/5207#issuecomment-78613182

@davidopp Out of four steps listed, three are already done. The only step missing is running fit predicates on kubelet. There is an open PR for it #5501, on which I'm working on: resource predicates is already implemented and I'm now working on node selector.

OK, thanks, please make sure to close this issue when you finish #5501.


Mount /dev/shm for shared memory files

What would you like to be added:
This is how it should look like:
    volumeMounts:
    - mountPath: /dev/shm
      name: dshm

But this memory size is unknown.
Why is this needed:
Accelerate model loading and model inference.
Completion requirements:
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

/kind feature


Duration reported is always truncated to < 1000ms

We observed that we never saw a trace duration longer than 1 second.  We know we have longer running traces so we knew something was up.
In HoneycombExporter.GenerateEvent line 65  you can see the problem:
ev.Data.Add("duration_ms", activity.Duration.Milliseconds);

Duration is a TimeSpan.  TimeSpan.Milliseconds returns the milliseconds portion of the timespan but will always be in the range of 0-999.  The code should be using Timespan.TotalMilliseconds to get the full duration expressed as milliseconds.

@joshclark please see #14

Your sunset description makes it sound like this project just isn't needed anymore, but its more than that.  With this bug, the project just doesn't work (unless all your traces are less than a second).  If you are not going to fix a bug that pretty much makes this project worthless, you might as well just archive it and be done.

Thanks for letting us know about the bug. As you can see, this project did not receive much TLC, and will be archived soon. There were a non-zero number of artifact downloads (most likely CI pipelines), so we wanted to extend some grace to folks that may have picked it up (even if it doesn't work as expected).
If you're looking for an OpenTelemetry instrumentation solution, either the OG opentelemetry-dotnet or the Honeycomb distro are viable options.

Closing as per #20


Different circle colour for specific date

Currently if calendarHaveEvent returns YES the dayDotColor is set to indicate an event.
I'm trying to make it so Instead of a dot its a circle indicating an event.
That was easy as I just needed to change the size of the dotView in JTCalendarDayView.m configureConstraintsForSubviews.
But my issue is I still only have one instance of the dotView therefore only one colour for the indicator to play around with.
Is there a way in calendarHaveEvent if the event is on a certain date set my dotView to colour1,  or if the event is on another date i specify set the dotView to colour2?

No sorry, you currently cannot. This week I will release a new release fully customisable but it's a full rewrite of the current code.

I just release a new version.
Check the Example project.


⚠ Bofrost.de has degraded performance

In 9b8088a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1097 ms

Resolved: Bofrost.de performance has improved in 6862084 after 310 days, 19 hours, 51 minutes.


Add LoRa Radio Support

For Zephyr to be effective in Industrial settings,  its going to need some form of LPWA (low power wide area) connectivity to be supported [1].
Others have expressed interest in seeing LoRa added to Zephyr already[2],  so can it please be added to the "Future" bucket on the product roadmap to signal to interested parties that the project would welcome contributions in this area? [3]
Once there is work started,  we should also consider having Zephyr become a LoRA Alliance Institutional member [4].
[1]https://www.mckinsey.com/global-themes/internet-of-things/our-insights/the-future-of-connectivity-enabling-the-internet-of-things
[2] https://github.com/zephyrproject-rtos/zephyr/issues/4569
[3] https://docs.google.com/presentation/d/1HA3Y9g4hQxsbUiCG37GvQjqF6vcKACSbKYV3d2Pswpk/edit#slide=id.g225d77f801_0_0
[4] https://www.lora-alliance.org/become-a-member

LoRa support is added by #18998


Use Map. Not sure if this would be better.

(btw I'm fine with this in case it wasn't clear!! I have no opinion whether it is better or not.)

Well, now the stack no longer overflows, so we have no strong reasons to go for or against this PR...

This will be merged along with #151.


hello，is there a bug here?

in fun _dispatchBinary, when recv a pong packet, and there is a payload data in pong packet, else if (ws.opcode == wsheader_type::PONG)
{
//nothing here?
}


fix: fix output of apply command + fix crash when only overlay is provided

Hey @ndimares is it possible to get this one  merged? 👀
Just come across the fact that output of openapi-overlay apply doesn't end up outputting the applied spec, which would be expected!


Initialization of two nn.Modules (e.g. generator and discriminator)

Dear DeepSpeed-Team,
first of all thank you for your effort, I was very excited to hear about this approach.
I am currently trying to realize a GAN which requires me to initialize two networks, I tried the following without success:
generator_engine, _, _, __ = deepspeed.initialize(args=args,
                                                  model=self.generator,
                                                  model_parameters=filter(
                                                      lambda p: p.requires_grad,
                                                      self.generator.parameters()),
                                                  training_data=data)
discriminator_engine, _, data_loader, __ = deepspeed.initialize(args=args,
                                                                model=self.discriminator,
                                                                model_parameters=filter(
                                                                    lambda p: p.requires_grad,
                                                                    self.discriminator.parameters()),
                                                                training_data=data)

Executing this, I get the following:

DeepSpeed info: version=0.1.0, git-hash=6d60206, git-branch=master
File "/home/deepspeed/Code/identification/generative/CPGAN/orchestrator_msggan_deepspeed.py", line 253, in train
training_data=data)
File "/usr/local/lib/python3.6/dist-packages/deepspeed/init.py", line 95, in initialize
Traceback (most recent call last):
File "identification/generative/CPGAN/train_deepspeed.py", line 186, in
collate_fn=collate_fn)
File "/usr/local/lib/python3.6/dist-packages/deepspeed/pt/deepspeed_light.py", line 123, in init
dist.init_process_group(backend="nccl")
File "/usr/local/lib/python3.6/dist-packages/torch/distributed/distributed_c10d.py", line 372, in init_process_group
main()
File "identification/generative/CPGAN/train_deepspeed.py", line 179, in main
raise RuntimeError("trying to initialize the default process group "
RuntimeError: trying to initialize the default process group twice!
save_every_n_steps=args.save_every_n_steps)
File "/home/deepspeed/Code/identification/generative/CPGAN/orchestrator_msggan_deepspeed.py", line 253, in train
training_data=data)
File "/usr/local/lib/python3.6/dist-packages/deepspeed/init.py", line 95, in initialize
collate_fn=collate_fn)
File "/usr/local/lib/python3.6/dist-packages/deepspeed/pt/deepspeed_light.py", line 123, in init
dist.init_process_group(backend="nccl")
File "/usr/local/lib/python3.6/dist-packages/torch/distributed/distributed_c10d.py", line 372, in init_process_group
raise RuntimeError("trying to initialize the default process group "
RuntimeError: trying to initialize the default process group twice!

It would be nice to get a pointer on how to tackle such a situation, especially since it is a very common use case.
Kind regards

Hello, thank you for your interest in DeepSpeed!
That error message is due to the default process group of torch.distributed being initialized twice. To fix this for now, you can add dist_init_required=False to the second call of deepspeed.initialize().
Removing this inconvenience is on our roadmap and hope to get to it soon. We are also very happy to accept PRs :-).

@ShadenSmith Is there a way to initialize multiple models at once, and get multiple objects to do "forward" with?


CASSANDRA-17769 (trunk) Remove usages of Path#toFile() in the snapshot apparatus

https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-17769-trunk

Committed in https://github.com/apache/cassandra/commit/ea03af460511442e771ddd704d92568a63557686


Investigate API Gateway (Kong) for throttling

Confirm that Kong will work for our needs. And volume is acceptable.
Can we provide QOS for important clients? Yes, but confirm with Data BC
Plan B:
3 Scale by Red Hat

@ConradBoydElliottGustafson is this something we need to consider for a future sprint

Yes, we should consider it for a future sprint. Documented and moved over to Trello: https://trello.com/c/2NBbBXt5


Security has been added

The developers finally added security to the api
kinda embarrassing that it took them this long to add security.
it will now give you a 403 Forbidden error

So does this make this useless?

Im currently uploading a .tar archive to mediafire as a backup incase their security obsoletes the script. I don't think their security is all that useful/good, but i have yet to take a look at it, so im going to just upload a backup of the images to mediafire.
https://www.mediafire.com/file/8ddaiou56u56i7y/MKBSD.tar/file
It's a tar archive because i don't trust compression when it comes to images.

Im currently uploading a .tar archive to mediafire as a backup incase their security obsoletes the script. I don't think their security is all that useful/good, but i have yet to take a look at it, so im going to just upload a backup of the images to mediafire. https://www.mediafire.com/file/8ddaiou56u56i7y/MKBSD.tar/file It's a tar archive because i don't trust compression when it comes to images.

100% there security probs will be weak, someone's fork has the whole .json

100% there security probs will be weak, someone's fork has the whole .json
Having the whole .json won't do much as new images get added, though, which is the main issue.
With more image drops, it'll just get more out of date.

Having the whole .json won't do much as new images get added, though, which is the main issue. With more image drops, it'll just get more out of date.

Fair point

So does this make this useless?

As of right now yes

So does this make this useless?

As of right now yes

I have used a JSON in my fork. In there are all the Links to the CDN, which is currently working.

I have used a JSON in my fork. In there are all the Links to the CDN, which is currently working.

The problem is with new wallpapers that get added, wonder if we can get the token


reCAPTCHA v3: Add option to hide the badge

That option is present when v2 is selected but not v3, even though it should be the same implementation (basically insert <style>.grecaptcha-badge{display:none;!important}</style> in the page) and it seems it's allowed (no mention of v2 or v3 in the answer to "I'd like to hide the reCAPTCHA badge. What is allowed?")
Let me know if you'd be interested in a PR!

Added in 1.1.2


Type Error (critical)

When using the field I cannot save any entry due to this error:
tde\craft\geoaddress\services\GeoAddressService::getCoordsByAddress(): Argument #2 ($country) must be of type string, null given, called in path-to-project/app/vendor/tde/craftplugin-geoaddress/src/fields/GeoAddressField.php on line 72

I am using a valid Google Maps key, which I entered in the plugin settings.
Craft 4.5.9
Plugin 2.0.0

Hi, is it possible you forgot to use step 5?
5. Copy and rename the file geoaddress-sample.php to [your craft directory]/config/geoaddress.php and modify it to include only those countries you want enabled.

Hello @jeffreyschmitz87 ,
thank you for your immidiate reply 👍
I did not read step 5 as a requirement, more like „if you want to restrict the possible countries, do that”. Maybe you could clarify that in the README.
So I can now save entries with that field and I tested different adresses but none of them worked.

The address that you see in the Screenshot is from a local movie theatre:
Name: Filmpalast Köln
Address: Hohenzollernring 22
Zip: 50672
City: Köln
Link in Google Maps: https://maps.app.goo.gl/DF8KQhsGmcJAiLqo7
But none of my input generates coordinates. I did add a valid Google Maps API key in the plugin settings. I am running on HTTP. Any ideas?
Thanks again 🙏

I've just updated the README.md file which hopefully clarifies that step 5 is required. I've also just tested your address on one of our websites and the coordinates are being generated. Is it possible to switch to a HTTPS - environment and test it again?