MatAutocompleteList: StringValue is not refreshed

Hi,
Great work!
steps to reproduce:
go to https://www.matblazor.com/AutocompleteList
scroll till Item Template Sample
Click on Select Car box
Select (Click on)  Volkswagen Polo =>   StringValue = Volkswagen Polo.   OK
Edit string value  in select car box  so yo get Volkswagen
again select (Click on ) Volkswagen Polo => StringValue remains Volkswagen. Wrong
Expected behavior : StringValue in select car box must be Volkswagen Polo

This is because Value property setter exits prematurely if you select the same item again (which you technically do in your example) See code below:
public TItem Value
        {
            get { return _value; }
            set
            {
                if (EqualValues(value, _value))
                {
                    return;
                }

                _value = value;
                StringValue = EqualValues(Value, default(TItem)) ? string.Empty : ComputeStringValue(Value);
                ValueChanged.InvokeAsync(_value);
            }
        }

I think it makes sense to always update the string value given a valid selection, even if it's the same. (I don't think we should call ValueChanged but atleast update string). Labeling this as a bug and we'll see.


Update instance heart beat time that receive from jam metric service.

#358

Coverage decreased (-0.06%) to 15.694% when pulling b671d634205728cd5633b4ec43e46ce00ff0234e on feature/358 into 2169b11208dc9089219350f63e6b1966491a9cf6 on master.

Coverage decreased (-0.06%) to 15.687% when pulling def9953522724290f78817e4e4efc76dcab23d47 on feature/358 into 65cd3d7582b79288f290724e7e3c075d3ef2b94e on master.


Take advantage of new async infrastructure

Now that we have support for async in the simulator, we should do proper thread management throughout.

This is basically what became the ResourceRegistry.


Bug: Feature Flag Rule Conditions Values and Context Key Variables cannot have Falsy values

Expected Behaviour
Rule Conditions allow users to evaluate context attributes against values and actions defined in Rule Conditions.
The condition can easily be pivoted on a certain value in the context evaluating to falsy values. Consider the following example -
Context-
{
   "is_paid": 0,
}

Feature Flag -
{
  "sales_offer": {
    "default": false,
    "rules": {
      "unpaid_users": {
        "when_match": true,
        "conditions": [ {"action": "EQUALS", "key": "is_paid", "value": 0} ]
      }
   }
}

The values attribute should be able to accept any value except null
The condition should also honor any value for context key variable.
Current Behaviour
Definition - Falsy Values
In python, the following values evaluate to False in boolean context - these are known as falsy values.
empty_list = []
empty_string = ""
zero = 0
false_boolean = False

Falsy Values in Condition value
The values attribute in conditions cannot accept any of the falsy values, some of which are essential to framing conditions in practical use-cases.
If any of the falsy values are present in the condition - the utility throws the error below
File ~/venv/lib/python3.8/site-packages/aws_lambda_powertools/utilities/feature_flags/schema.py:330, in ConditionsValidator.validate_condition_value(condition, rule_name)
    328 value = condition.get(CONDITION_VALUE, "")
    329 if not value:
--> 330     raise SchemaValidationError(f"'value' key must not be empty, rule={rule_name}")
    331 action = condition.get(CONDITION_ACTION, "")
    333 # time actions need to be parsed to make sure date and time format is valid and timezone is recognized

SchemaValidationError: 'value' key must not be empty, rule=unpaid_users

Falsy Values in context value
The conditions simply return evaluate to false if the value for the key passed in context is falsy. These are also extremely essential to framing conditions in practical use-cases.
Example -

🚨 The condition below will evaluate to False even if the context value (0) is NOT EQUAL to condition value (1) 🚨

{
  "sales_offer": {
    "default": false,
    "rules": {
      "unpaid_users": {
        "when_match": true,
        "conditions": [ {"action": "NOT_EQUALS", "key": "is_paid", "value": 1} ]
      }
   }
}

Code snippet
Falsy Values in Condition value
// context.json

{
  "is_paid": 0
}

// features.json

{
  "sales_offer": {
    "default": false,
    "rules": {
      "unpaid_users": {
        "when_match": true,
        "conditions": [ {"action": "EQUALS", "key": "is_paid", "value": 0} ]
      }
   }
}

from aws_lambda_powertools.utilities.feature_flags import FeatureFlags, AppConfigStore

app_config = AppConfigStore(
    environment="dev",
    application="product-catalogue",
    name="features"
)

feature_flags = FeatureFlags(store=app_config)

def lambda_handler(event, context):
    # Get customer's tier from incoming request
    ctx = { "is_paid": 2 } # 1: Standard Plan | 2: Advanced Plan
    is_unpaid: bool = feature_flags.evaluate(name="sales_offer", context=ctx, default=True)

Falsy Values in Context key value
// context.json

{
  "is_paid": 0
}

// features.json

{
  "sales_offer": {
    "default": false,
    "rules": {
      "unpaid_users": {
        "when_match": true,
        "conditions": [ {"action": "NOT_EQUALS", "key": "is_paid", "value": 1} ]
      }
   }
}

from aws_lambda_powertools.utilities.feature_flags import FeatureFlags, AppConfigStore

app_config = AppConfigStore(
    environment="dev",
    application="product-catalogue",
    name="features"
)

feature_flags = FeatureFlags(store=app_config)

def lambda_handler(event, context):
    # Get customer's tier from incoming request
    ctx = { "is_paid": 2 } # 1: Standard Plan | 2: Advanced Plan
    is_unpaid: bool = feature_flags.evaluate(name="sales_offer", context=ctx, default=True)

Possible Solution
Falsy Values in condition value
Instead of
https://github.com/awslabs/aws-lambda-powertools-python/blob/f2435070d53aba8fced2901380438cc6015c6f49/aws_lambda_powertools/utilities/feature_flags/schema.py#L328-L330
suggest
value = condition.get(CONDITION_VALUE, None)
if value is None:
  raise SchemaValidationError(f"'value' key must not be null, rule={rule_name}")

Falsy Values in context key value
Instead of
https://github.com/awslabs/aws-lambda-powertools-python/blob/f2435070d53aba8fced2901380438cc6015c6f49/aws_lambda_powertools/utilities/feature_flags/feature_flags.py#L49-L51
suggest
def _match_by_action(self, action: str, condition_value: Any, context_value: Any) -> bool:
  if context_value is None:
    return False

Steps to Reproduce
Shared code snippet should reproduce the issue
AWS Lambda Powertools for Python version
latest
AWS Lambda function runtime
3.6
Packaging format used
PyPi
Debugging logs
No response

@ajwad-shaikh thanks for finding this.
@heitorlessa  I took the liberty of opening a PR with a fix and two tests.
I dont think the change in the feature_flags.py is required, as it has already passed schema validation, so i deleted this line entirely.
see https://github.com/awslabs/aws-lambda-powertools-python/pull/2052

Looking into it... and thanks a lot @ran-isenberg for the swift PR

I must say I'm impressed with the quality of this bug report @ajwad-shaikh - THANK YOU for the lengths in which you took to describe not only the problem concisely, but also potential solutions to it regardless of the complexity.
We'll revert quickly with a patch release once we're confident with the fix!


Create Data Protection Act.mdx

Spoke about 8 principles and gave context on DPA.

This is great! Thank you 🎉


Display and Update Work Item Details [#298] - Fetch and display work item states from core

https://github.com/almighty/almighty-core/issues/298
Create a WorkItemState service which talks to core and retrieves the list of WI state.
The UI needs to display this list of work item states.

This is resolved in PR - https://github.com/almighty/almighty-ui/pull/103


Section navigation

@soniaturcotte to investigate how a step-by-step navigation would be handled across different use cases  and use findings from Public Advice mobile research to inform design decisions


Better determination of when Runtime Analysis is marked as complete

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/396
This PR updates the status check of the "Runtime Analysis" step.
Setting "investigated findings" is now only set to true if it originates from user action in the webview and happens after the user opened an AppMap in the current project.
The VSCode plugin scopes the "user navigates to Runtime Analysis" to workspace folders, but we can't do this because there's just one panel per project. It was discussed and decided to just keep a flag per project.
Because the updated check requires read access in a background thread, I refactored the update to use a single (non-blocking) ReadAction in a background thread instead of up to four different ReadActions for a single update of the four items. This is now a clearer flow and should also be faster.
The labels are now updated after indexing finished, i.e. when a new project is opened for the first time the green checkmarks may appear a bit later than before.
Testing
This PR needs manual testing because user webview interaction triggers the update.

:tada: This PR is included in version 0.53.0 :tada:
The release is available on:

v0.53.0
GitHub release

Your semantic-release bot :package::rocket:


Provide Plug support

Hey @alex-shamshurin, are you referring to junegunn/vim-plug?

Yes!

I'm actually using that right now to install it! I left it out of the readme because I didn't want to list all plugin managers for vim 😅
Here's my snippet: https://github.com/hhsnopek/dotfiles/blob/master/.nvimrc#L32
" Generic vim-plug usage (not my snippet)
Plug 'hhsnopek/vim-sugarss'

Of course I did it but it did not include autoload dir or plugin dir and I thought it's not for Plug

Oh, it contains a ftdetect directory that'll resolve the files - is it not loading for you?

It hangs on 'Cloning git...' via PlugInstall, but git clone `works fine via console.

Just tried it, works (NVIM v0.2.2, macOS 10.13.1)

This is because of Windows cmd. Plug cannot get status of git operation whether it done or not


How can I edit config file to run training?

Hi again,
I am running the command for training: python nprf_drmm.py --fold 5 1
Then I am supposing to modify the config file: model/nprf_drmm_config.py, but how can I config this file. I modify the variable parent_path to parent_path = '/home/dexter/NPRF/model' (home directory), but it doesn't work.
Could you please help me out.
Thanks.

The "parent_path" is the parent path for your data but not the home directory. You can ignore it anyway as long as your data path configuration is right.
Did you prepare the data for training? If not, please find the related functions in the "utils" folder and generate the data first.
relevance_params = {'res_file': '',
'qrels_file': '',
'docnolist_file': '',
'output_file': ,,}
create_relevance(**relevance_params)
# get the topk tf-idf terms for each document
topk_params = {
'df_file': '',         # the data format of each line is: term \t df \t cf (cf is not used)
'corpus_file': '', # the data format of each line is: docno \t doclen \t term1 term2 ...
'output_file': '',
'nb_docs': ,
'topk': ,

}
topk_term(**topk_params)
get the idf for topk terms
doc_idf_params = {
'relevance_file': '' ,
'df_file': '' ,
'document_file': '' , # the output file from above function
'output_file': 'topk.idf.pkl',
'rerank_topk':  60,
'doc_topk_term':  30,
'nb_doc': 25205179
}
parse_idf_for_document(**doc_idf_params)
get similarity matrix, kernel and histogram features
kernel_mu_list = kernal_mus(11, True)
kernel_sigma_list = kernel_sigmas(11, 0.5, True)
sim_params = {
'relevance_file': '',
'topic_file': '',
'corpus_file': '',
'topk_corpus_file': '',
'embedding_file': '',
'stop_file': '', # not used actually
'sim_output_path': '',
'kernel_output_path': '',
'kernel_mu_list': kernel_mu_list,
'kernel_sigma_list': kernel_sigma_list,
'topk_supervised': 40,
'd2d': True,
'test': False
}
hist_params = {
'relevance_file':  '',
'text_max_len': ,
'hist_size': ,
'sim_path': ,
'hist_path': ,
'd2d': True
}
sim_mat_and_kernel_d2d(**sim_params)
hist_d2d(**hist_params)

Excuse me!
Could you please specify in details how to prepare data for training. As you can see in README.MD, you just mention about utils.py file and some functions. I think I and others can not understand and follow to complete running training your model.
I think your instructions will really help.
Thank you.

You meant data preparation like this?
https://github.com/NTMC-Community/MatchZoo

Two quick questions : Do you have TREC robust04 or disk12 data? Have you retrieve a result file for those queries and download the qrels files from TREC website？

No, I dont have, so I need to download them?
No, I did not. Its my first time running an IR model.

Sorry for if silly questions.

Please be familiar with IR first, e.g. index, retrieval, evaluation. Running some traditional (non-neural) IR experiments will also do help. This repo is not for anyone to learn IR from scratch.

Ok I will try running again and ask you later. Thanks for your help

No, I dont have, so I need to download them?
No, I did not. Its my first time running an IR model.

Sorry for if silly questions.

Did you find the data set? Can you share the data set or link？


add model stacking

model stacking is a method for model ensembling

@bowni
To understand stacking I first read the section on stacking from this article
I also watched this video which helped me understand how it works when one aggregate the outputs of several models with a meta model.
Finally I used the code from
this kaggle tuturial

@Thomas-Galtier in the above thread could you "Resolve conversation" when the comment is taken care of or obsolete? It will help getting a better visibility on what is left to review / update!

[ ] Training on train data instead of val dat
[ ]  Investigate log of first experiments, duration of computation, number of epochs...


Documentation

PGPainless provides JUnit documentation already, however this might not be sufficient.
I thought about creating some tutorial-style documentation similar to readthedocs.io.
What do you think?

Check out https://pgpainless.rtfd.io ;)


API-9 compatibility

Added usage of nineoldandroids in order to extend compatibility to
pre-Honeycomb

LGTM. Thank you!

I forgot the ViewHelper import in FadePageTransformer.java. I don't know if it's added automatically.

Yep, my Android Studio added it automatically.
Anyway, I've this when I try to compile:
Error:(38, 29) No resource found that matches the given name (at 'style' with value '?attr/borderlessButtonStyle').

Does it work for you locally?

Ooops I forgot AppCompat dependecy. Try to merge the new pull request. Everything should work now :)
https://github.com/PaoloRotolo/AppIntro/pull/51


Contact form integration

Contact form integration release

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


python-utils 3.6.0 is triggering an attribute error

This is being triggered through a particular version of awswrangler, however, I'd like to confirm with you whether or not this attribute does/does not exist in 3.6.0. Please see the error here:

AttributeError                            Traceback (most recent call last)
 in
----> 1 import awswrangler
/opt/conda/lib/python3.8/site-packages/awswrangler/init.py in
8 import logging as _logging
9
---> 10 from awswrangler import (  # noqa
11     athena,
12     catalog,
/opt/conda/lib/python3.8/site-packages/awswrangler/opensearch/init.py in
3 from awswrangler.opensearch._read import search, search_by_sql
4 from awswrangler.opensearch._utils import connect
----> 5 from awswrangler.opensearch._write import create_index, delete_index, index_csv, index_df, index_documents, index_json
6
7 all = [
/opt/conda/lib/python3.8/site-packages/awswrangler/opensearch/_write.py in
9 import boto3
10 import pandas as pd
---> 11 import progressbar
12 from jsonpath_ng import parse
13 from jsonpath_ng.exceptions import JsonPathParserError
/opt/conda/lib/python3.8/site-packages/progressbar/init.py in
1 from datetime import date
2
----> 3 from .utils import (
4     len_color,
5     streams
/opt/conda/lib/python3.8/site-packages/progressbar/utils.py in
7 import logging
8 import datetime
----> 9 from python_utils.time import timedelta_to_seconds, epoch, format_time
10 from python_utils.converters import scale_1024
11 from python_utils.terminal import get_terminal_size
/opt/conda/lib/python3.8/site-packages/python_utils/init.py in
----> 1 from . import (
2     aio,
3     compat,
4     converters,
5     decorators,
/opt/conda/lib/python3.8/site-packages/python_utils/decorators.py in
6 T = types.TypeVar('T')
7 TC = types.TypeVar('TC', bound=types.Container[types.Any])
----> 8 P = types.ParamSpec('P')
9
10
AttributeError: module 'python_utils.types' has no attribute 'ParamSpec'

The latest version of python utils requires the typing extensions package, can you verify whether you have that installed?
It should have been installed automatically so it could be a bug

@wolph Seems like it did install the typing extensions package. I have typing-extensions v<IP_ADDRESS>

You could revert to any version before 3.6.0. I believe it might be due to a too old version of typing-extensions. It seems that there were changes regarding ParamSpec in version 4.1.0 and 4.2.0: https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-410-february-12-2022
I would suggest trying to update to a newer version of typing-extensions instead since this update greatly improves the type hints for this package.

@wolph Thanks for your response. I will try updating the typing-extensions package and let you know how it works out.

I've done some testing and it seems that any version beyond <IP_ADDRESS> should work. But I would recommend updating to the latest available version since newer versions of typing-extensions generally only improve things :)
I've created a new release with stricter requirements to fix the issue


Option for adding modules in init-drupal

Motivation:
It would be great if one would be able to add any composer packages, modules while creating a Drupal codebase.

FYI @hussainweb

@subhojit777 +1 to this. I want this from quite some time. I am wondering how best to add this option. Two straight-forward choices are as a list of names as arguments or a new option.
As argument:
init-drupal axl/test admin_toolbar search_api search_api_solr:"^4.0"

OR as an option:
init-drupal axl/test -m admin_toolbar -m search_api -m search_api_solr:"^4.0"

OR is there a better alternative?

IMO the second one looks more concise.

@subhojit777, the second option is longer and you have to type more. How is more concise?

well.. I was thinking about the specific flag -m for adding the packages, hence, a self-understandable command for adding the packages.
Although the first option looks good too, but I usually check the flags while using a command. I usually don't worry how long it is.. (I use repititive search) I think this is always going to be user's preference :)
I think we can finalize anyone and later make modifications :)


HTML code tag on the same line with starting code block breaks everything

Noticed strange behavior of parser while testing with this fixture
Try to parse text under Code and Syntax Highlighting section
http://i.imgur.com/7JWC4Cv.png
It happens when you have starting <code> and ``` on the same line.
If you separate it by newline everything will be fine
I saved this bad section on my google drive also:
https://docs.google.com/document/d/1AU-BEsR4bUnSXFtkuJfCylOaBrLmadCk7tqEzAThfS4/edit?usp=sharing

Thanks @DoumanAsh
You are correct, the bug is verified. (can see in demo page here)
I will post a fix as soon as possible.

Glad to hear. I'm planning to replace marked in my simple client-side parser with Snowdown :)

Please note that markdown code symbols are missing inside of html <code>.
Please check after fix that it will be corrected too :)

@DoumanAsh

Please note that markdown code symbols are missing inside of html .

What do you mean?

See this example
Note that there are <code> blocks inside another <code> blocks.
At least in case of Github and marked markdown is not parsed inside html <code> block.
But i'm not sure what is right behavior though

@DoumanAsh I thought that was the issue you were talking about.

Sorry, there are actually two issues :)
First
Second
In these cases parser has different misbehavior

Both are consequence of the same issue that is the fact that GitHub code blocks insede HTML Code blocks get parsed by markdown engine while they shouldn't.

Should be fixed now

Looks great! Thanks

Should we close issue then?

Since it is fixed on develop branch i'm closing issue. No sense in leaving it opened?


enhancement(clients/qbit): better handling of post-injection verification

With lots of torrents, qbit can sometimes be slow to respond. 3s should catch pretty much all cases but added a failsafe.

I don't love the idea of an unconditional 3 second delay. If you look at rTorrent it uses an exponential backoff approach - what would you think of that?

I'll switch that

Also, what is the purpose of waiting and checking for the torrent - is it just to make sure?
Qbit is very weird when things are added, just to be safe. Previously at a 1s wait I've had a few that threw the error.


dev-arm: This commit fixes a typo in the ARM ldaddalx instruction

The acquire-release flavor of the ldadd instruction should read ldaddalx (eg. ldaddalb/ldaddalh) according to specification. However, this is currently noted as ldadd"la"x (eg. ldaddlab/ldaddlah).
Issue: https://github.com/gem5/gem5/issues/1224
Change-Id: Ib932fa0e572207729c923c27f24c34cc21dff0e5

Thanks for this fix! One minor thing though: this commit/PR should be tagged as arch-arm rather than dev-arm. Would you mind force-pushing the change? Kind Regards
Giacomo


feat: maxHeartBeats in technical debts metrics

Adds set_option .*maxHeartBeats to the list of technical debt metrics tracked by the weekly report.
Zulip discussion

bors d+

bors r+

bors r+

maintainer merge

bors merge


Website is down

Hi,
Tried to access the website, isn’t working :(

@cwaltken-edrans the website still seems to be down

Sorry, there were some issues with the Cloudflare set-up. The site should come back up as soon as Cloudflare issues a new cert for it.

Similarly, the links for the Windows 64 and 32 bit downloads go to 404 pages.
https://github.com/gophergala2016/goad/releases/download/v1.3.0/goad-gopher-gala-windows-x86-64.zip


feat: add phalcon 5.2.2 release

update phalcon with release 5.2.2

:tada: This PR is included in version 1.148.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Find and Replace text in c

Find and Replace Text
Description:
We need to write a function to replace the first found occurrence
in the input with the given replacement text.
Details:
Header:
src/include/string_replace.h
Source file:
src/string_replace.c
Test file:
tests/string_replace.test.cpp
Signature:
char* string_replace_first_occurence(const char* text, const char* replacement, const char* input);

Restriction:

Do not use any builtin string functions.
Only allowed to use memory functions ex: malloc, calloc, etc.

Note:
See Contribution Guide for more details.
Let me know if you are unable to write the tests, I will do that for you.
Also if you want any help let me know 😉.

can anyone please explain what actually we have to do for resolve this issue

@sachin-vinod  make a function to replace a given sequence of a text and replace it with another given text.
for example:
input: Hello World
to find: World
replacement text: Universe
result: Hello Universe
let me know if you want further help. thanks for being interested. 🥰

i want to work on this issue

sure go ahead

Check out this function i wrote up...


upgrade kafka client to 2.0.0

solves #289

When will this be merged?
It currently looks like input plugin kafka is not usable with kafka 2 at logstash 6.4

Note: This drops Java 7 support. Should that should be documented somewhere?

I believe logstash also officially doesn’t support java 7. Probably not a good idea to be on Java 7.

Yeah, I haven't been following ELK products closely enough to know the JVM support levels, but does seem latest installation docs say required Java8, so nevermind! 👍

@robbavey ready for review again 👍

nice catch, that file should actually be deleted from git as it's auto generated during rake vendor, but I'll leave that out of this PR


V4 does not await async functions in Node.js properly.

Tested the same code on v3 and v4. Works on v3, but when we run it on v4 looks like the runtime does not awaits the async code execution properly.

Hi @Ayzrian I moved this to the Node.js-specific repo. Can you give a little more information: for example what specific version of v4 are you on? And could you post either logs from running the function or some sample code demonstrating the issue?

Hey, @ejizba I have tracked down the issue. It is related to https://github.com/microsoft/ApplicationInsights-node.js/blob/c59867afb06625116854f492078e8148a8348d08/AutoCollection/AzureFunctionsHook.ts this logic was introduced in v2.4.0 three days ago when I started to see this issue.
The root cause is in this PR https://github.com/microsoft/ApplicationInsights-node.js/pull/1044
File AzureFunctionsHook.ts, they call originalCallback on line 52 but do not handle a case when the callback could have returned a promise. That lead to problem of function core tools thinking that the execution finished while the actually function code is still running.
@hectorhdzg does it makes sense to you? If yes, can we fix that, please? I can reproduce the issue when using 2.4.0 version of app insights package, but if I downgrade all works.

If it matters here is the code to reproduce the issue.

const appInsights = require('applicationinsights');

appInsights.setup().start();

module.exports = async function (context, req) {
    context.log('JavaScript HTTP trigger function processed a request.');

    await new Promise((res) => setTimeout(() => {
        const name = (req.query.name || (req.body && req.body.name));
        const responseMessage = name
          ? "Hello, " + name + ". This HTTP triggered function executed successfully."
          : "This HTTP triggered function executed successfully. Pass a name in the query string or in the request body for a personalized response.";

        context.res = {
            // status: 200, /* Defaults to 200 */
            body: responseMessage
        };

        res();
    }, 1000))

    context.log.info('Finished function execution.')
}

Run it with<EMAIL_ADDRESS>and you will see something like this in the logs
[2023-01-14T19:40:15.868Z] Executing 'Functions.HttpTrigger' (Reason='This function was programmatically called via the host APIs.', Id=84b1950d-84c4-487a-81ac-632cad8c3e00)
[2023-01-14T19:40:15.908Z] JavaScript HTTP trigger function processed a request.
[2023-01-14T19:40:15.943Z] Executed 'Functions.HttpTrigger' (Succeeded, Id=84b1950d-84c4-487a-81ac-632cad8c3e00, Duration=87ms)
[2023-01-14T19:40:16.800Z] Executing 'Functions.HttpTrigger' (Reason='This function was programmatically called via the host APIs.', Id=f9c282bc-0e0e-477d-ad33-3a1ed11357b0)
[2023-01-14T19:40:16.805Z] JavaScript HTTP trigger function processed a request.
[2023-01-14T19:40:16.805Z] Executed 'Functions.HttpTrigger' (Succeeded, Id=f9c282bc-0e0e-477d-ad33-3a1ed11357b0, Duration=6ms)
[2023-01-14T19:40:16.904Z] Warning: Unexpected call to 'log' on the context object after function execution has completed. Please check for asynchronous calls that are not awaited or calls to 'done' made before function execution completes. Function name: HttpTrigger. Invocation Id: 84b1950d-84c4-487a-81ac-632cad8c3e00. Learn more: https://go.microsoft.com/fwlink/?linkid=2097909
[2023-01-14T19:40:17.805Z] Warning: Unexpected call to 'log' on the context object after function execution has completed. Please check for asynchronous calls that are not awaited or calls to 'done' made before function execution completes. Function name: HttpTrigger. Invocation Id: f9c282bc-0e0e-477d-ad33-3a1ed11357b0. Learn more: https://go.microsoft.com/fwlink/?linkid=2097909
While with 2.3.6 for example it looks good.
[2023-01-14T19:41:37.571Z] Executing 'Functions.HttpTrigger' (Reason='This function was programmatically called via the host APIs.', Id=cf11f23e-7f0c-4eee-a8b7-82def2c18dfd)
[2023-01-14T19:41:37.605Z] JavaScript HTTP trigger function processed a request.
[2023-01-14T19:41:38.608Z] Finished function execution.
[2023-01-14T19:41:38.664Z] Executed 'Functions.HttpTrigger' (Succeeded, Id=cf11f23e-7f0c-4eee-a8b7-82def2c18dfd, Duration=1104ms)

Hi @chuanqisun we don't have much more to say on this issue, @Ayzrian pretty much said everything already!
The issue is in v2.4.0 of the applicationinsights package and the only mitigation at the moment is to downgrade to v2.3.6. I recommend you follow this issue for further updates: https://github.com/microsoft/ApplicationInsights-node.js/issues/1063 from the app insights team

sorry @ejizba, I was confused by which repo contains the actual root cause code. I should have noticed your external tag. I will post an update there. Thanks!

Closing as the applicationinsights package released v2.4.1 a few days ago to address this bug. Thanks for reporting and all the details @Ayzrian!


Promote environment vars to global recognition in launch.json and parse them before plugin launch

Setting environment variables in a run/debug configuration is hit or miss. Some plugins support an env element, others do not. This is frustrating and can lead to days of lost time when the developers of an otherwise excellent plugin forget to provide this facility. Modern containerized apps and CI/CD is heavily dependent on environment variables, debugging these components can be difficult without the settings.
I'll advocate that the idiomatic env tuple array should be supported at the global level and also at the configuration level. These would be merged and set before a configuration is launched. This would be forward and backward compatible with the existing plugin universe, if a plugin didn't know the env key was overloaded, it would merely overwrite the environment passed in with the variables it found in the configuration it was launched with. In other words, plugin use of the env key becomes superfluous but not harmful. For plugins that don't already support the env key, the environment they were passed would have the proper environment defined already.
I can't think of any reasons that this would not be beneficial.

Sorry, this just isn't possible.  Please file issues on debug extensions when you notice that one doesn't provide this functionality, I agree that it's generally pretty basic and useful.

From that perspective, it's too late- me asking an extension author to implement something isn't much different than you asking them to implement something (you might think it is but it isn't)
But I have to ask... how many different debug adapters are you using? Because your phrasing makes it sound like it must be a large number

Thanks Rob, I appreciate your response. I understand these decisions are difficult and are based on a context that an outsider is unlikely to grasp.
The number of DAs we are using is not huge, but environment variables have become a critical aspect of modern CI/CD. I'm more focused on the risk aspect that such large-scale omissions present to teams. Don't want to completely FUD this up, but plugins like Google Cloud Code are closed source and there's nothing we can do there. For the task at hand (debugging a large stack of containers via automation of Delve connections with Skaffold), there's really no way to do this except with IDE support and GCC doesn't support setting environment in VSC (although they do in IntelliJ).
I've resorted to launching VSC from the command line with the required environment set. It does indeed work, this solution would have absolutely fixed it.
Of course it's impossible for either of us to know what the exact proportion of DAs this would similarly work for, but it's not a breaking change as you seem to suggest. It simply wouldn't have any effect for DAs that somehow prune the environment when they sub launch and would be superfluous for DAs that allow an env element already and don't prune the environment.
Because of this backward compatibility, plugin authors moving forward could choose to inherit the provided environment and simply stop supporting their locally defined one. This would have the effect of a proper migration and unification over time.
Do you agree with what I am saying here?

I'm telling you that it's not really possible for vscode to have reliable control over the environment variables that end up in a debuggee, either on a per-DA or per-launch basis. You've found a case where it works, that's good. It wouldn't work well for DAs that use the DebugAdapterDescriptorFactory (DAs running in the EH, or spawned from the same environment, not by vscode). It wouldn't work at all for models where one DA controls multiple debug sessions. I won't try to implement something as a built-in vscode feature that can't work reliably.


Pass INVALID_OFFICE_ID through on errors

If a user does this
https://cwms-data.usace.army.mil/cwms-data/timeseries?name=OMA.Temp-Water.Inst.1Hour.0.Best-NWDM&office=NWDW&unit=EN
They get this error
{"message":"System Error","incidentIdentifier":"-897878052613553257","details":{}}

Which is very cryptic.
In the actual logs I see this:
Msg = ORA-20010: INVALID_OFFICE_ID: "NWDW" is not a valid CWMS office id

The correct URL / OFFICE would be
https://cwms-data.usace.army.mil/cwms-data/timeseries?name=OMA.Temp-Water.Inst.1Hour.0.Best-NWDM&office=NWDM&unit=EN
I.e. NWDM not NWDW - it's a mistake I made and another user made as well.
This could be said for other errors, but i'll just pop in as we find them!
Solution
A vague
{"error": "Invalid office id: <office-id>"}

is more helpful!

If the returned value is included it must be passed through the sanitizer. However, I do think it would be good to include, sometime you need the error message AND text for your brain to finally read the letters correctly.


create Sentence Transformer models

Hi Everyone,
Download  and create  a model from Hugginface works like a charm, but the problem is when we are trying to create a transformer model like: jinaai/jina-embeddings-v2-base-en or all-MiniLM-L6-v2.bin, we are not able to create  amodel to be used for example in langchain like:
  ollama = OllamaEmbeddings(base_url=ollama_url,
                              model="jina-embeddings-v2-base-en",
                              temperature=0.0)

How we can include new Sentence Transformer model to be used by ollama when embeddings?
Many thanks
Antonio

Up


The plugin share_extend is built using an older version of the Android plugin API

Hi! Thank you for your good job.
I try to use your plugin in embeded flutter module and have a warning above:
The plugin share_extend is built using an older version of the Android plugin API which assumes that it's running in a full-Flutter environment. It may have undefined behaviors when Flutter is integrated into an existing app as a module.
The plugin can be updated to the v2 Android Plugin APIs by following https://flutter.dev/go/android-plugin-migration.
Can you do it upgrade?

@ra-develop  Thanks for the suggestion. Please try the new version 1.1.8 that I added the support of Android Embedding V2 API.


Pull Request notify service objects

Adds PR notify service objects
Implements notify when a pull request is submitted.

Pull Request Test Coverage Report for Build 250

45 of 45 (100.0%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 92.568%

Totals

Change from base Build 246:
0.1%

Covered Lines:
1694

Relevant Lines:
1830

💛  - Coveralls


Creating a dynamic map with datetime range

import holoviews as hv
import pandas as pd
hv.extension('bokeh')

def timeline(time):
    return hv.VLine(time)

vline = hv.DynamicMap(timeline, kdims=['time']).redim.range(time=(pd.datetime(1999, 5, 1), pd.datetime(1999, 6, 1)))
vline

doesn't seem to work
but if I change it from datetime to integer
vline = hv.DynamicMap(timeline, kdims=['time']).redim.range(time=(0, 50))
That works.

While it would be relatively straightforward to make this work by casting the datetimes to integers, there is currently no way for it to format the date correctly in the slider. So I'll have to assign this to a later release.

Moving this to Panel since that is now responsible for widget handling.


合并到本地

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
Always follow the contribution guidelines when submitting a pull request.

与线上内容进行同步


Add chat mode for finetuned models using Adapter.

To chat with the finetuned model interactively using:
python chat/adapter.py
The default parameters:
- model path: out/adapter/alpaca/lit_model_adapter_finetuned.pth
- model type: stabilityai/stablelm-base-alpha-3b
- finetune data: alpaca
- finetune tech: Adapter
Test success on NVIDIA DGX-A100.

This is a separate script added to the ./chat/ folder, won't affect the other script logic.


Dev

Fixed The Activity Functions for isolated worker
Removing the entity approach
added Parallel Processing of Chunks and sending them also

Classes Modified/Added

GetChunkDataActivity
SendChunkToRelayActivity
IntegrationGatewayFileSendOrchestrator (renaming)
IntegrationGatewayProcessorFileSenderTrigger(renaming)


E2504 Property VirtualName should be of type ephemeral(n)

Description of issue.
In the latest version of cfn-linter, we are seeing these errors:
E2504 Property VirtualName should be of type ephemeral(n) for Resources/MasterServer/Properties/BlockDeviceMappings/10/VirtualName
aws-parallelcluster.cfn.json:1767:13
E2504 Property VirtualName should be of type ephemeral(n) for Resources/MasterServer/Properties/BlockDeviceMappings/11/VirtualName
aws-parallelcluster.cfn.json:1771:13
...
E2504 Property VirtualName should be of type ephemeral(n) for Resources/MasterServer/Properties/BlockDeviceMappings/23/VirtualName
aws-parallelcluster.cfn.json:1819:13

This error is only an issue for double digits ephemeral drives, which would be valid according to the docs: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/block-device-mapping-concepts.html
Here is an example of block device entries in our cfn template:
            {
              "DeviceName": "/dev/xvdbj",
              "VirtualName": "ephemeral9"
            },
            {
              "DeviceName": "/dev/xvdbk",
              "VirtualName": "ephemeral10"
            },
            {
              "DeviceName": "/dev/xvdbl",
              "VirtualName": "ephemeral11"
            },

Any idea on this issue?
Thanks!

[Instance store volumes] The virtual device: ephemeral[0-23]. Note that the number and size of available instance store volumes for your instance varies by instance type.
Going to increase the regex to look for 0-23 going forward.  PR incoming.

#1260 this is done.


fix #80344

https://github.com/microsoft/vscode/issues/80344

Fix looks good and it works on my machine -> approved


FerAggDSet - aggregation dataset Python object

Reported by karl smith on 12 May 2016 19:03 UTC
Create Python object representing an aggregation of datasets.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2412

Modified by karl.smith on 12 May 2016 19:03 UTC

Comment by karl.smith on 17 May 2016 22:26 UTC
FerAggDSet, subclass of FerDSet, added with the signature:
    FerAggDSet(name, dsets, along='T', title='', warn=True, hide=False)
        Aggregates the given list of datasets along the given axis using the
        Ferret "DEFINE DATA /AGGREGATE" command.  Creates a FerVar for each data
        variable in common among these datasets, and assigns it as an attribute
        of this class instance using the variable name.
            name (string): Ferret name for this aggregated dataset
            dsets (sequence of strings and/or FerDSets): datasets to aggregate.
                A string will be interpreted as a filename for creating a FerDSet.
            along ('T', 'E', 'F'): axis along which to aggregate the datasets
            title (string): title for the dataset for plots and listing;
                if not given, the Ferret name for the dataset will be used
            warn (bool): issue warning messages about variables not in common among
                all member datasets (either not present or not using the same grid)
            hide (bool): hide the member datasets in standard Ferret listings
                such as with pyferret.showdata()

Most of the functionality of FerAggDSet is inherited from FerDSet.  The two new methods getdsetnames() and getdsets() return a list of the dataset names or the FerDSet objects, repectively.
Usage example (snippets from bench/testferaggdsets.py):
>>> dsetnames = ['./ens2.nc', './ens3.nc', './ens4.nc']('./ens1.nc',)

>>> fourfiles = pyferret.FerAggDSet('fourfiles', dsetnames, along='E')
           *** NOTE: Variable "AIRT" excluded from aggregate: Not found in all member datasets

>>> fourfiles.show()
     currently SET data sets:
    5> fourfiles  (default)  Ensemble aggregation
 name     title                             I         J         K         L         M         N
 SST      SST_IN                           1:10      1:9       ...       1:12      1:4       ...

>>> fourfiles.getdsetnames()
['ens2.nc', 'ens3.nc', 'ens4.nc']('ens1.nc',)

>>> fourfiles.getdsets()
[using dataset name 'ens1.nc' and variables ['AIRT', 'SST'](FerDSet('./ens1.nc')),
 FerDSet('./ens2.nc') using dataset name 'ens2.nc' and variables [
 FerDSet('./ens3.nc') using dataset name 'ens3.nc' and variables ['SST']('SST'],),
 FerDSet('./ens4.nc') using dataset name 'ens4.nc' and variables ['SST']]

>>> fourfiles.SST.showgrid()
    GRID (G006)  Ensemble Aggregetion Grid
 name       axis              # pts   start                end                 subset
 COADSX116_125 LONGITUDE       10mr   109W                 91W                 full
 COADSY52_60 LATITUDE           9 r   13N                  29N                 full
 normal    Z
 TIME      TIME                12mr   16-JAN 06:00         16-DEC 01:20        full
 ENSEMBLE  E (realization)      4 r   1                    4                   full
 normal    F


ParameterNumberCheck: consider functions in abstracts

Hm, I guess this can be refactored using ExprUtils.walkFile()...

Hm, it seems there are a lot more checks with the same issue, so don't merge yet..

@adireddy What's resources/config.json for? It doesn't appear to be used for the self-check in build.hxml.

Well, this PR certainly got a little bigger than originally intended...
I refactored the tests to use a new forEachField() method added to Check.hx. This makes sure that both the abstract and class fields are covered and also removes quite a bit of redundant code.
I also added a mechanism to easily test both the abstract and the class case. This required rewriting a few assertEquals() to assertMsg() calls (which is probably nicer anyway).

Great :+1:
resources/config.json is no longer used.

So that can be removed?
I also just noticed that there is no test for CyclomaticComplexityCheck, so I hope that's still working correctly.

I removed resources/config.json. I am going to do a quick test in my project.

all good :+1:
Also added a basic test for CyclomaticComplexityCheck.

Shouldn't we keep config.json as an example for new users? Maybe rename it to sample-config.json.

good point, so we need to keep it up to date with all the changes.


Supported 1.20.x

Now it supported 1.20.x.
But there still a little issues:

I removed(by using code comments) an event because I don't know why it not run.
Maybe you should update gradle version to 8.6 or updated because I don't know how to update it. I only tested it on my local.

Thanks for your work. I'll be taking a look soon.


With missing if defined in sub query

hi maybe im not doing something wrong but i have complicated query with with defined in sub query, and compiled query is missing with part
minimal changed docs example
var activePosts = new Query("Comments")
    .Select("PostId")
    .SelectRaw("count(1) as Count")
    .GroupBy("PostId")
    .HavingRaw("count(1) > 100");

var queryWith = new Query("ActivePosts")
    .With("ActivePosts", activePosts) // now you can consider ActivePosts as a regular table in the database
    .Join("ActivePosts", "ActivePosts.PostId", "Posts.Id");

var query = new Query().From(queryWith);

result :
SELECT   * FROM   (     SELECT       *     FROM       [ActivePosts]       INNER JOIN [ActivePosts] ON [ActivePosts].[PostId] = [Posts].[Id]   )
WITH "ActivePosts" as  is missing

Here the From will not conserve the inner With, using an outer With will do.
This example should work.
var activePosts = new Query("Comments")
    .Select("PostId")
    .SelectRaw("count(1) as Count")
    .GroupBy("PostId")
    .HavingRaw("count(1) > 100");

var queryWith = new Query("ActivePosts")
    .With("ActivePosts", activePosts) // now you can consider ActivePosts as a regular table in the database
    .Join("ActivePosts", "ActivePosts.PostId", "Posts.Id");

var query = new Query().With("sub", queryWith).From("sub");

yes this worked, thanks


auto_focus option not working

I'm currently using AstroNvim Version v2.4.2.
My issue is that the auto_focus option doesn't do anything. I still have to call RustHoverActions twice for it to focus in the hover window.
I configured the rust-tools plugin using the official AstroNvim Documentation and added the tools.hover_actions.auto_focus to true.
Here is a snippet of my config (config.plugins.init)
  -- Configure plugins
  plugins = {
    init = {
      {
        "simrat39/rust-tools.nvim",
        after = { "mason-lspconfig.nvim" }, -- make sure to load after mason-lspconfig
        config = function()
          require("rust-tools").setup {
            server = astronvim.lsp.server_settings "rust_analyzer", -- get the server settings and built in capabilities/on_attach
            opts = {
              tools = {
                hover_actions = { auto_focus = true },
              },
            }
          }
        end,
      },

Did I forget anything in the setup process ?

I'm getting the same in neovim 0.8

same here in neovim 0.8

Is there any guaranteed reproduction? Seems to work fine for me

Natively, to configure auto_focus, you wanna move tools outside of your opts:
require("rust-tools").setup({
  ...
  tools = {
    hover_actions = {
      auto_focus = true,
    },
  },
})

Perhaps AstroNvim is not respecting this structure?


Host on Heroku

As the Heroku app has been created, add the heroku remote to repo, periodically merge master to it and push.
Even try creating a local branch for heroku postgres database.

Tried to do it but external requests didn't work on Heroku.


Sentry bundle breaks doctrine migrations.

Environment
PHP 8.0
Symfony 5.2
Doctrine Migrations 3.1
sentry-symfony 4.1
Steps to Reproduce
Having the above combination completely breaks the Doctrine migrations unless we add to each migrations a method indicating that the migration is not transactional.
Doctrine had this issue before (https://github.com/doctrine/migrations/issues/1104) but they fixed it with this check:
https://github.com/doctrine/migrations/blob/96c64fa17477e503da8245f14541d70d7ae76091/lib/Doctrine/Migrations/Tools/TransactionHelper.php#L39
However, sentry decorates the connection with:
Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriverConnection
which is obviously not a PDO instance, so the aforementioned check fails and we get a nasty error:
In TracingDriverConnection.php line 163:

  [PDOException]
  There is no active transaction

Expected Result
Well obviously I expect migrations to work with and without the sentry bundle :)
Actual Result
In TracingDriverConnection.php line 163:

  [PDOException]
  There is no active transaction

I think there is nothing we can do here for the moment, since the check done in the Doctrine repo is clearly intended to work only for PDO-based drivers. @greg0ire is there any reason for that check to be like that? Maybe we could make the inTransaction method part of the Doctrine\DBAL\Driver\Connection interface so that the check in TransactionHelper does not have to care whether or not the connection is a PDO connection, but it just has to ask whether the transaction is active or not. Each driver connection can then report back either true or false based on specific conditions. Otherwise, any attempt to wrap the driver's connection will cause the same issue we're having here

I think the reason was we needed a fix that would not require bumping our dependency on the DBAL, but you are right about inTransaction() possibly being the right API: https://github.com/doctrine/dbal/pull/4544#issuecomment-799596645

Understood. Do you think it would be feasible to implement this API in both version 2.x and 3.x? And do you think there would be anyone in the Doctrine team interested in doing this?

Do you think it would be feasible to implement this API in both version 2.x and 3.x?

Feasible, sure, but I think you and I both know it will not be accepted: https://github.com/doctrine/dbal/issues/4495

And do you think there would be anyone in the Doctrine team interested in doing this?

Maybe Sergei will? I will open a new issue so that we can investigate this is indeed doable.

Feasible, sure, but I think you and I both know it will not be accepted

I completely forgot we already had this discussion for another thing 😅 I'm not sure what falls under the "upgrade path" category mentioned in that PR, but I see unfeasible to stick with that reason until the ORM does not support DBAL 3.x

Issue opened at https://github.com/doctrine/dbal/issues/4616

but I see unfeasible to stick with that reason until the ORM does not support DBAL 3.x

let's see how things look once it's implemented in 3.x? It will still probably be useful in the future.

Yea, having it in 3.x would already be a great starting point. However,  our bundle and any other code that wraps the driver connection is not working properly with doctrine/migrations as of now and since I bet it will take a bit until things get implemented in the DBAL maybe we could implement a workaround until that time?

I suppose you could copy/paste TransactionHelper in this bundle?

Wait actually it will? You could use it here: https://github.com/getsentry/sentry-symfony/blob/107f60cd87073a25b960a2ce8483e0b5cbb46d41/src/Tracing/Doctrine/DBAL/TracingDriverConnection.php#L153

Yes, however I'm wondering if it would be safe to do such change because we would change the behaviour of the commit() method of the connection, wouldn't we?

Ah right you want to do that only in the context of migrations somehow, is that the issue?

Ah right you want to do that only in the context of migrations somehow, is that the issue?

Yes. In reality, the only thing we care about is that with or without this bundle things must work the same, of course. Instrumentation of the DBAL for tracing purposes should be transparent to the user and should not affect the behaviour of the application. The issue at the moment appears in the context of migrations, but to be honest I didn't test what happens if I try to execute a DDL SQL statement using the DBAL directly. My concern is that while the migrations, thanks to the usage of that helper, silently "swallow the error" (or don't make it happen), the DBAL instead would throw the exception due to the fact that there is no similar mechanism in that package. As a consequence of this, we have two distinct behaviour, and if I use the helper inside the driver connection then I'm changing the behaviour not only in the context of migrations but also of all the rest of the usages of the DBAL. Does it makes sense?

You could do that by inspecting the stack trace but ewww…

Yes, that's a possibility, although since the driver connection is a critical code path I think it's better to not do these kind of operations there that are costly and may affect performances more than what we already do for logging the data for the distributed tracing feature.

even if you had inTransaction at your disposal, it would change that particular issue, would it

What I was thinking is that in the doctrine/migrations package the condition could be changed to check whether the object instance implements the inTransaction method. That would basically be a poor-man version of the check based on the interface, until we have it at least, and would allow us here to add such method to the connection class which in turn will be used to determine whether the transaction is active. If in the future the DBAL will formalize the need for this method then such method would then be officially used not only in the context of the migrations but also from the DBAL itself and this fact would be completely independent from the usage of this bundle

What I was thinking is that in the doctrine/migrations package the condition could be changed to check whether the object instance implements the inTransaction method.

Sounds good. Can you send a PR?

Sure, I will do it asap 👍

Downgrading sentry-symfony to 4.0.3 has temporarily fixed this for me.

Downgrading to :
"sentry/sentry-symfony": "<4.0.9",
works

You can also set sentry.tracing.dbal.enabled: false or sentry.tracing.enabled: false to disable tracing for the DBAL or completely and avoid downgrading

You can also set sentry.tracing.dbal.enabled: false or sentry.tracing.enabled: false to disable tracing for the DBAL or completely and avoid downgrading

sure thing if you don't use tracing, it makes sense

Same issue here. Looking forward to a fix! :+1:

Would really like to use the tracing in general, is there an easy way to just disable the tracing programatically for the fixtures only?

For the record, this should fix it downstream: https://github.com/theofidry/AliceDataFixtures/pull/174

Does anyone know what happening with this? Is there a workaround that doesn't involve sacrificing doctrine tracing?

Right so I missed the part on the doctrine/migrations thread about adding isTransactional() { return false; } to migrations, that fixed my immediate problem

This also breaks database migrations in Contao. Due to the decoration of the database connection, doctrine can no longer extract the correct database server version - which will then lead to wrong information about the platform and thus wrong schema diffs in Doctrine\DBAL\Schema\Comparator::compare.
Specifically Doctrine\DBAL\Connection::getServerVersion will always return null with the current version of symfony/sentry-symfony installed, because this condition will always evaluate to false, since the decorated connection does not implement ServerInfoAwareConnection anymore (while the regular connection would).

forward the call to the decorated connection accordingly (or return null otherwise)

I tried to do this yesterday, just to find out that the return type is not marked as nullable according to the DocBlock. Instead, apparently, once you implement the interface you have to either return a value or throw an exception, which may cause issues because only specific drivers implement it and therefore are able to give back the server version. As a consequence of this, I started working on yet another decorator which implements the ServerInfoAwareConnection interface and that will wrap the instrumented connection if the original connection was implementing the aforementioned interface. Work is not finished yet, will try to find some time in the next couple of days to see if it can work

I can confirm that we can now use the new latest Sentry version by adding this line to the doctrine_migrations config file:
doctrine_migrations:
    transactional: false

doctrine_migrations:     transactional: false
did not work for us, we had to disable DB SQL Logging via
tracing:     dbal:          enabled: false
in our sentry.yaml to get the migrations working again.
Otherwise we'll get the "PDOException There is no active transaction" when running doctrine migrations migrate.
Transactional is set to false in doctrine_migrations.yaml.
We are using
sentry/sentry-symfony 4.2.9
doctrine/doctrine-bundle 2.6.3
doctrine/doctrine-migrations-bundle 3.2.2
So this still seems to be a problem.


Non-English Rules

About the PR
Adds some clarification to the Non-English rules.
Why / Balance
Admin consensus.
Media

This is entirely a contrived question (so feel free to ignore), but how would something like a "ß" (German Eszett) be handled under the new 3.4?

This is entirely a contrived question (so feel free to ignore), but how would something like a "ß" (German Eszett) be handled under the new 3.4?

It's English readable enough to be fine, I'd say.


Metadata forms 6: attach MF to Orgs, Envs and Datasets

Feature or Bugfix

Feature

Detail

MF now can be attached to Orgs, Envs and Datasets id user has edit permissions
Everyone, who has read access, can view attached MFs
Attached MF ca be deleted
NO edit yet
cascade delete MF => MF field => Attached MF => Attached MF Fields

Relates

#1065

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

https://github.com/user-attachments/assets/c60e4b04-8dff-445b-9d6f-bf771ef4870a

Testing in AWS:

[ ] Fail to Attach Form if Required Field Not Populated
[ ] Populate Field Values Free Form + Drop Down possible Values
[ ] Attach Form to Org
[ ] Attach Form to Env
[ ] Attach Form to Dataset
[ ] Shared Dataset Cannot Delete (only READ)
[ ] Read + Delete Attached Form to Org as OrgAdmin
[ ] Read + Delete Attached Form to Env as EnvAdmin
[ ] Read + Delete Attached Form to Dataset as DatasetAdmin

Other comments:

For boolean values it looks like it is defaulted to False value but when you first fill in a form it is null and need to click to true and click again to false to actually populate as false and not null

When providing availableForms to attach to an entity, for an Organization I can select and attach a form with visibility of Environment. Similarly for Environment I can attach for Dataset visibility. While I think Global and Team may apply to all - I don't think all of the above forms should be given as options depending on entity type and visibility of form

Other comments:
* For boolean values it looks like it is defaulted to `False` value but when you first fill in a form it is `null` and need to click to `true` and click again to `false` to actually populate as `false` and not `null`... UPDATE - I actually am not able to specify a value of false (i.e. checkbox deselected) for a required boolean value, can we confirm if that is possible?

* When providing `availableForms` to attach to an entity, for an Organization I can select and attach a form with visibility of Environment. Similarly for Environment I can attach for Dataset visibility. While I think Global and Team may apply to all - I don't think all of the above forms should be given as options depending on entity type and visibility of form

From my pov I think these 2 pending comments and the comment on editability of attached forms are what remains. Then I think PR looks good

@noah-paige

Boolean values are now 'false' explicitly by default
Added filter on visibility

After testing on the latest changes:
For attaching to Organization (PROBLEM - Env Visibility Forms still show)

Get all Global or Team related Forms
Get all Forms related to the Current Organization
NO Env Forms (Still Showing Env Forms)

For attaching to Environemnt (GOOD)

Get all Global or Team related Forms
Get all Forms related to the Parent Organization or Current Environment

For attaching to Dataset (GOOD)

Get all Global or Team related Forms
Get all Forms related to the Parent Organization or Parent Environment

As a User Listing Forms on MF View (GOOD)

Get all Global or Team related Forms
Get all Forms Related to All of User's Envs or Orgs

nit: For Admins do we need a separate way of handling this case?

For instance when we do something like list Envs we do not handle da_admins separately and show all in query_user_environments()
I get the idea of Admin should see all but it is not consistent with how we handle other queries in backend

As an enhancement idea would it make sense to use some type of registry (similar to how we do with GlossaryRegistry or FeedRegistry) OR some type of Interface/ abstract class (like with DatasetServiceInterface or  SharesProcessorInterface) for MF Forms
Thinking as we continue to add attachable Entity Types that conditions and custom logic for each entity could get cumbersome and really is specific to each entity type rather than specific to MF Forms
May involve moving MF Forms to core to avoid circular deps but something to consider I think for future

I thinks, on next step I will revise the access resolvement slightly differently.
I want to add 'target entity types' to MF, so e.g. a MF can be only attached to Dataset and other only to the Org.

Changes look good! Last thing is around who can edit MF Forms attached to entities
https://github.com/data-dot-all/dataall/pull/1495#discussion_r1729267045
I think we should have it so only EnvAdmins can edit the Attached Forms on their Env and same with OrgAdmins with their Orgs - do you disagree?

@noah-paige I'm not sure about it.
Right now, whoever view Env and Org is allowed to press 'Edit' and change it's name. e.g., which is also metadata, so to speak. So, why should we restrict access to MFs, if person can change name of the entity?

@noah-paige I'm not sure about it. Right now, whoever view Env and Org is allowed to press 'Edit' and change it's name. e.g., which is also metadata, so to speak. So, why should we restrict access to MFs, if person can change name of the entity?

@SofiaSazonova yes I see the same that anyone can access the EnvironmentEditForm but if a non EnvAdmin attempted to execute updateEnvironment they would be restricted because of the following decorator in EnvironmentService:
@ResourcePolicyService.has_resource_permission(environment_permissions.UPDATE_ENVIRONMENT)
def update_environment(uri, data=None):

Only Env Admins are given UPDATE_ENVIRONMENT permissions - so while maybe we should fix the FE conditional rendering to prevent even showing the Edit button, I do not believe any person can change name of entity or make any updates unless they are the EnvAdmin team.
The same should be the case for Organization Updates as well
I think we should also add some permission checks for any person who tries to create_attached_metadata_form or delete_attached_metadata_form to ensure the user is admin for the entity they are trying to attach form to

@noah-paige Sure.
Then I will change the frontend for Env and Org Views as well

Hi @SofiaSazonova - coming back to restricting attached MF forms shown to a user, I have the following set up:
1 Dataset w/ 3 Attached Metadata Forms:

1 Form w/ Global Visibility
1 Form w/ Team Visibility of Datset Owner
1 Form w/ Org Visibility that Dataset is in

This dataset is shared with another Team (GroupB) in another Environment (a part of a separate Org in data.all). Meaning Group B should not be able to see 2 out of the 3 attached forms
When GroupB user navigates to shared Dataset View and clicks on Metadata Tab, we get the error:
An error occurred (UnauthorizedOperation) when calling GET METADATA FORM LIST operation: User XXXXX can not view organization ORG_URI

coming from def get_target_orgs_and_envs(...) when called as part of def list_attached_forms(...)

@noah-paige my last commit should resolve this error

I think, I solved it a bit easier:
Admins see all (if we are not restricted by entity, when list attached forms or possible forms)
Non Admins:

If you are owner, you can see the form
If you are not owner:
2.1. Filter by the team
2.2. Filter by the orgs
2.3. Filter by the envs

I do believe it may make easier for both testing and implementation purposes if we split up the GQL Operations:

(1) ListMetadataForms - lists Metadata Forms to populate Metadata Form View page (working as expected currently)
(2) listAttachedMetadataForms - takes in resource URI, finds user's resource entities (Env + Org), query all attached forms for this resource filtered by what User can see
(3) listAvailableMetadataForms - takes in resource URI, finds target resource entities (Env + Org), query all available MF Forms filtered by what is already attached

About deletion of entities and connected MFs -- I want to leave it for a separate PR. There are a lot of things to consider there.

(3) If i have a MF Form created with visibility of EnvA I can attach that form to EnvA as well as all of its child datastets (same for Org visibility forms too and attachable to homeEntity Org)

Yes, I thinks, it's the case. Again, in future I want to add 'target entity type', so we can restrict it, if needed
(1), (2) --  This is a good call. I will consider it.
But I prefer to deal with all the deletions in separate PR

(3) If i have a MF Form created with visibility of EnvA I can attach that form to EnvA as well as all of its child datastets (same for Org visibility forms too and attachable to homeEntity Org)

Yes, I thinks, it's the case. Again, in future I want to add 'target entity type', so we can restrict it, if needed
(1), (2) -- This is a good call. I will consider it. But I prefer to deal with all the deletions in separate PR

We can leave for a future PR - however do you see any risks with (1) and (2) as it is currently implemented along with create and delete attached MF forms not having a decorator for has_resource_permissions checks or similar permissions checks? I know restricted on FE but restrict directly on BE


Scrolling causes a noticeable stutter on Docusaurus v2 websites

🐛 Bug Report

Scrolling causes a noticeable stutter on Docusaurus v2 websites

To Reproduce

Go to the docs section on the Docusaurus v2 website
Scroll to the top of the page
Attempt to scroll further upwards

Expected behavior
Docusaurus v1

Maximum CPU Usage: 22.0%

Timers

5 × setTimeout

Events

44 × scroll

Actual Behavior
Docusaurus v2

Maximum CPU Usage: 96.1%

Events

160 × wheel
42 × scroll
7 × message
3 × mousemove
2 × pointermove

Observers

889 × IntersectionObserver

Your Environment

Public site url: https://v2.docusaurus.io
Docusaurus version used: 2.0.0-alpha.72
Environment name and version: Safari 14.0.3 (146<IP_ADDRESS>.6)
Operating system and version: macOS 10.14.6

i'm going to work on this


Notify speaking while muted

Notify the user when she/he is speaking but muted.

Replaced by #346.


Update golang.org/x/crypto commit hash to a769d52

This PR contains the following updates:

Package
Type
Update
Change

golang.org/x/crypto
require
digest
75b2880 -> a769d52

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you check the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: go.sum
Command failed: go get -d ./...
/bin/sh: 1: go: not found


What should these actually be returning

in src/DataService/DataService.php L793
    /**
     * Creates an entity under the specified realm. The realm must be set in the context.
     *
     * @param IPPIntuitEntity $entity Entity to Create.
     * @return IPPIntuitEntity Returns the created version of the entity.
     * @throws IdsException
     */
    public function Add($entity)
    {
        ........
        return $this->sendRequestParseResponseBodyAndHandleHttpError($entity, $uri, $httpsPostBody, DataService::ADD);
    }

in src/DataService/DataService.php L635
        /**
     *  Using the @entity and @uri to generate Request.
     *  Response will parsed. It will store any Error Code in 3xx to 5xx level.
     *
     * @param ...
     * @return null|string
     */
    private function sendRequestParseResponseBodyAndHandleHttpError($entity, $uri, $httpsPostBody, $CALLINGMETHOD, $boundaryString = null, $email = null)
    {...}

The Add method is returning Boolean FALSE.  Add says it's only returning IPPIntuitEntity, the method it's directly returning says it's only returning null or string.  What are my actual options here?

@GameCharmer : Did you pass the Entity which is of the type IPPIntuitEntity to Add method? The Add method of the DataService object should return IPPIntuitEntity of the entity that was created.
Take a look at the Samples folder if you haven't already :
https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/master/src/_Samples/ItemCreation.php

@abisalehalliprasan I passed it the result from Invoice::create()  I'm betting I have the wrong CustomerRef value and Invoice::create is just returning false.  Either way, do you think I should put together a pull request to fix the doc blocks?

If you pass the request paylaod to the create method of the Invoice facade as shown below :
//Add a new Invoice
$theResourceObj = Invoice::create([
    "Line" => [
        [
            "Amount" => 100.00,
            "DetailType" => "SalesItemLineDetail",
            "SalesItemLineDetail" => [
                "ItemRef" => [
                    "value" => 1,
                    "name" => "Services"
                ]
            ]
        ]
    ],
    "CustomerRef"=> [
        "value"=> 0
    ]
]);

print "The resource object is : " . PHP_EOL . print_r($theResourceObj) . PHP_EOL;

Output:
(
    [Deposit] =>
    [AllowIPNPayment] =>
    [AllowOnlinePayment] =>
    [AllowOnlineCreditCardPayment] =>
    [AllowOnlineACHPayment] =>
    [EInvoiceStatus] =>
    [ECloudStatusTimeStamp] =>
    [invoiceStatus] =>
    [callToAction] =>
    [invoiceStatusLog] =>
    [InvoiceEx] =>
    [LessCIS] =>
    [InvoiceLink] =>
    [PaymentDetailsMessage] =>
    [ConvenienceFeeDetail] =>
    [InvoiceLinkSecurityCode] =>
    [InvoiceLinkExpiryDate] =>
    [AutoDocNumber] =>
    [CustomerRef] => QuickBooksOnline\API\Data\IPPReferenceType Object
        (
            [name] =>
            [type] =>
            [value] => 0
        )

    [CustomerMemo] =>
    [BillAddr] =>
    [ShipAddr] =>
    [FreeFormAddress] =>
    [ShipFromAddr] =>
    [RemitToRef] =>
    [ClassRef] =>
    [SalesTermRef] =>
    [DueDate] =>
    [SalesRepRef] =>
    [PONumber] =>
    [FOB] =>
    [ShipMethodRef] =>
    [ShipDate] =>
    [TrackingNum] =>
    [GlobalTaxCalculation] =>
    [TotalAmt] =>
    [HomeTotalAmt] =>
    [ApplyTaxAfterDiscount] =>
    [TemplateRef] =>
    [PrintStatus] =>
    [EmailStatus] =>
    [BillEmail] =>
    [BillEmailCc] =>
    [BillEmailBcc] =>
    [ARAccountRef] =>
    [Balance] =>
    [HomeBalance] =>
    [FinanceCharge] =>
    [PaymentMethodRef] =>
    [PaymentRefNum] =>
    [PaymentType] =>
    [CheckPayment] =>
    [CreditCardPayment] =>
    [DepositToAccountRef] =>
    [DeliveryInfo] =>
    [DiscountRate] =>
    [DiscountAmt] =>
    [GovtTxnRefIdentifier] =>
    [TaxExemptionRef] =>
    [DocNumber] =>
    [TxnDate] =>
    [DepartmentRef] =>
    [CurrencyRef] =>
    [ExchangeRate] =>
    [PrivateNote] =>
    [TxnStatus] =>
    [LinkedTxn] =>
    [Line] => Array
        (
            [0] => QuickBooksOnline\API\Data\IPPLine Object
                (
                    [Id] =>
                    [LineNum] =>
                    [Description] =>
                    [Amount] => 100
                    [Received] =>
                    [LinkedTxn] =>
                    [DetailType] => QuickBooksOnline\API\Data\IPPLineDetailTypeEnum Object
                        (
                            [value] => SalesItemLineDetail
                        )

                    [PaymentLineDetail] =>
                    [DiscountLineDetail] =>
                    [TaxLineDetail] =>
                    [SalesItemLineDetail] => QuickBooksOnline\API\Data\IPPSalesItemLineDetail Object
                        (
                            [ServiceDate] =>
                            [TaxInclusiveAmt] =>
                            [DiscountRate] =>
                            [DiscountAmt] =>
                            [SalesItemLineDetailEx] =>
                            [ItemRef] => QuickBooksOnline\API\Data\IPPReferenceType Object
                                (
                                    [name] => Services
                                    [type] =>
                                    [value] => 1
                                )

                            [ClassRef] =>
                            [UnitPrice] =>
                            [RatePercent] =>
                            [PriceLevelRef] =>
                            [MarkupInfo] =>
                            [Qty] =>
                            [UOMRef] =>
                            [ItemAccountRef] =>
                            [InventorySiteRef] =>
                            [TaxCodeRef] =>
                            [TaxClassificationRef] =>
                        )

                    [DescriptionLineDetail] =>
                    [ItemBasedExpenseLineDetail] =>
                    [AccountBasedExpenseLineDetail] =>
                    [ReimburseLineDetail] =>
                    [DepositLineDetail] =>
                    [PurchaseOrderItemLineDetail] =>
                    [SalesOrderItemLineDetail] =>
                    [ItemReceiptLineDetail] =>
                    [JournalEntryLineDetail] =>
                    [GroupLineDetail] =>
                    [SubTotalLineDetail] =>
                    [TDSLineDetail] =>
                    [CustomField] =>
                    [LineEx] =>
                )

        )

    [TxnTaxDetail] =>
    [TxnSource] =>
    [TaxFormType] =>
    [TaxFormNum] =>
    [TransactionLocationType] =>
    [Tag] =>
    [TxnApprovalInfo] =>
    [RecurDataRef] =>
    [RecurringInfo] =>
    [Id] =>
    [SyncToken] =>
    [MetaData] =>
    [CustomField] =>
    [AttachableRef] =>
    [domain] =>
    [status] =>
    [sparse] =>
)
The resource object is :
1

If you do not pass a valid CustomerRef for Creating Invoice the exception SDK is throwing is :
Fatal error: Uncaught QuickBooksOnline\API\Exception\ServiceException: Http Status Code [400]: Request is not made successful. Response Code:[400] with body: [<?xml version="1.0" encoding="UTF-8" standalone="yes"?><IntuitResponse xmlns="http://schema.intuit.com/finance/v3" time="2021-02-04T20:44:45.308-08:00"><Fault type="ValidationFault"><Error code="2500" element="Reference Id"><Message>Invalid Reference Id</Message><Detail>Invalid Reference Id : Names element id 0 not found</Detail></Error></Fault></IntuitResponse>].

Not sure how you are getting a boolean response. If you could post your payload ( make sure to mask any sensitive information ) before creating a PR would help.

@abisalehalliprasan the overarching problem here isn't the data, it's the returned values.  I can't get past code validation when the returns don't line up.  Add says it only returns IPPIntuitEntity , but it returns the result of sendRequestParseResponseBodyAndHandleHttpError, which says it only returns null|string.
The best I can think of here would be to fork and throw exceptions when returns don't line up.

@GameCharmer : Could you create a PR ? and we can take a look at this.

@abisalehalliprasan PR: https://github.com/intuit/QuickBooks-V3-PHP-SDK/pull/394


Fix for issue #25538

Fixes #25538
modified functions associated with writing binding entries that weren't properly returning ERROR messages

This pr addresses the same issue. Was open a few hours before yours
https://github.com/project-chip/connectedhomeip/pull/25549

Issue already fixed

Thanks for noting this.

@HusseinElsherbini for future reference, the changes here did return an error, but not the error the spec calls for...

@bzbarsky-apple thanks for the heads up, I did have one more commit to correct this behavior but its unnecessary now.


patch: add the template's lint rules to the migration script and yq check

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:ef795daef671c309ed78318cc23b6615de8155c2

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:b879a92763fbf4976970b2252dd7abaf45506ba0

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:6923ba0da93fb1701204d6f08335dac2dcddecea

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:6923ba0da93fb1701204d6f08335dac2dcddecea


Seed conditions are not copied to Shoot if parent gardenlet is unavailable

How to categorize this issue?

/area robustness ops-productivity
/kind enhancement
What would you like to be added:
Currently, the gardenlet's shoot care controller copies the Seed conditions over to the Shoot status, if the shoot is registered as a ManagedSeed: https://github.com/gardener/gardener/blob/0320bb0241020ad19a0f0b536d8f490a8feaaf39/pkg/gardenlet/controller/shoot/shoot_care_control.go#L328-L338
However, when the parent gardenlet is unavailable, the shoot conditions can become outdated.
We should either

make sure, that the shoot conditions always provide the same information as the seed conditions (i.e. move the logic to GCM)
or drop copying the seed conditions to shoots entirely

Why is this needed:
If the conditions are not up to date, they don't provide any benefit at all over looking directly at the seed conditions.

Monitoring will be affected by this as well if we decide for option 2.
cc @wyb1 @istvanballok

/assign


Is it possibile to use a plugin based on Draft-js

I am adding the ability to be able to insert the emojis into the editor, there's already a plugin  - "draft-js-emoji-plugin" available, but it's for draft-js only,  if we can have the mui editor to be able to use that plugin, would be very helpful.

There is no support for draft-js-plugins-editor. You can check this example to know how to add emojis or stickers to the editor.


[Blazor] Error is thrown when component has been disposed before invoking a method from the client-side

Related to https://github.com/aspnet/AspNetCore/issues/11641
Describe the bug
There is no tracked object with id '//'. Perhaps the DotNetObjectRef instance was already disposed.

When a component has asynchronous client-side logic, sometimes the disposal occurs prior to the invoke of a server method and the error is thrown. The issue is related to more complex scenarios, but I have isolated it in the simplest reproducible project.
To Reproduce
Repo https://github.com/jivanova/DotNetObjectRef-Error
All steps described there.
Expected behavior
To be able to track whether the instance has been disposed and prevent further triggering of methods.
I have tried to call js dispose function to keep the info that the dotnetinstance has been disposed, but it's not stable solution.

@jivanova Thanks for contacting us.
I don't think there's anything we can do here. The server has full control over the life of the reference. Even if you were to call an "UnsubscribeEvents" method as part of the component disposal there would still be a timeframe in which you could send an interop call and it would go through and fail.
A few alternatives are:

Simply catch the exception. The component is being disposed and it's going to disappear from the UI.
Keep track of the dotnet object references separately from the component lifetime and have the parent notify the underlying object that the component it is associated to is being disposed, notify the javascript client that the reference is no longer valid through js interop so that it does appropriate cleanup and have it perform one last call to the server to make sure the object reference gets finally disposed.


[Issue title here] enhancing the navbar ui

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
i can make the navbar look better by adding material UI and better hover effects
Screenshots

Code of Conduct

[X] I follow Contributing Guidelines of this project.

@Rakesh9100  take a look,if yes then pls assign me

UI enhance issue is already open. Pls work on new other issues @PRITISH212121


Add LayerToggle and LineFitTool

This PR adds the LayerToggle and LineFitTool needed in stage 6. [EDIT:}The LineFitTool has been update to work with plotly viewers

Other than the issue with not updating, the layer toggle looks fine to me at the moment. I'm not sure why it doesn't update as it should attach the relevant callback to the viewer state inside its constructor, but maybe something with the current setup prevents that callback from triggering correctly.
I also feel like we should have the Vue template and the Python together in a folder inside of the components directory, something like below. It just feels strange to me to have the template and Python not be colocated. But maybe @nmearl has a different opinion?
components
+-- layer_toggle
|       LayerToggle.vue
|       layer_toggle.py

...other components

The LineFitTool has be updated to work with plotly viewers.
@Carifio24 I am also not sure why they are split up. Right now I think it does load custom vue_components from  vue_components, which I believe is necessary for us to be able to use things like <mc-radiogroup> in vue files.
but I think this would work regardless of how the directories are structured.
I would be for combining these into 1

Currently, when used with Stage 6
we get this error
Traceback (most recent call last):
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/reacton/core.py", line 1661, in _render
    root_element = el.component.f(*el.args, **el.kwargs)
  File "/Applications/John/github/cosmicds_dev/hubbleds/src/hubbleds/pages/06-prodata/__init__.py", line 69, in Page
    component_state.add_data_by_marker(viewer)
  File "/Applications/John/github/cosmicds_dev/hubbleds/src/hubbleds/pages/06-prodata/component_state.py", line 113, in add_data_by_marker
    viewer.add_data(data)
  File "/Applications/John/github/cosmicds_dev/cosmicds/src/cosmicds/viewers/viewer.py", line 50, in add_data
    return super().add_data(data)
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/glue_jupyter/view.py", line 118, in add_data
    result = super().add_data(data)
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/glue/viewers/common/viewer.py", line 220, in add_data
    layer.update()
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/glue_plotly/viewers/scatter/layer_artist.py", line 254, in update
    self._update_display(force=True, **kwargs)
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/glue_plotly/viewers/scatter/layer_artist.py", line 166, in _update_display
    self._update_zorder()
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/glue_plotly/viewers/scatter/layer_artist.py", line 172, in _update_zorder
    self.view.figure.data = traces
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/plotly/basedatatypes.py", line 717, in __setattr__
    super(BaseFigure, self).__setattr__(prop, value)
  File "/Users/jal194/anaconda3/lib/python3.9/site-packages/plotly/basedatatypes.py", line 1001, in data
    raise ValueError(err_msg)
ValueError: The data property of a figure may only be assigned
a list or tuple that contains a permutation of a subset of itself.
    Received duplicated traces

I just pushed a couple of commits that, together with the new glue-plotly, have things almost working on my end. There's one more issue, which I suspect is an issue on this end, with layer toggle items not controlling the correct layers:
https://github.com/cosmicds/cosmicds/assets/14281631/81f5c187-1f3f-4499-851f-2a74e5844ee1

@Carifio24 I am also not sure why they are split up. Right now I think it does load custom vue_components from vue_components, which I believe is necessary for us to be able to use things like  in vue files.
but I think this would work regardless of how the directories are structured.

@Carifio24, @johnarban, these files are not co-located because they are not technically related. Taking ScaffoldAlert.vue/scaffold_alert.py as an example:

scaffold_alert.py does not implement the ScaffoldAlert.vue in anyway. It basically wraps other .vue files (e.g. the guildelines), which themselves use ScaffoldAlert.vue. So the, in this instance, the distinction is that ScaffoldAlert.vue and scaffold_alert.py do not depend on each other, and are there separate.

The files in vue_components should only be .vue components; these get loaded into Solara and made available in other .vue files, but do not have a python component to them.
Since the layer tool is a python component fundamentally, it should follow the setup described by @Carifio24.

I have fixed the ordering of the layers in the layer toggle, but having it only respect the order of the layers in the viewer state.
I also put the files in the components directory

The reason I am not using the zorder is that if both data sets are not added at the same time before the Layer Toggle is created. The newly added dataset gets zorder = 0 while being later in the layer order.

We discussed this on Slack, but just to leave this here for posterity:
So the zorder issue that we were seeing actually has its roots in the internals of glue - basically, when adding a layer, the layer state is added to viewer.state.layers (which triggers any callbacks on that property) as soon as it's created, but it's only added to the viewer's layer artist container (which is where zorder is initially set) after that. So during the callback execution the zorder won't have been set yet. To work around this, the solution that's now used is to instead hook into the layer artist container event instead so that the zorder has already been set (and the layer state will be inside of viewer.state.layers).


Allow to mark devices or bridged devices as "errornous" in UI for user to check during runtime

follow up issue of issue https://github.com/ioBroker/ioBroker.matter/issues/198
If a iobroker device will be deleted which is used as a iobroker matter device the user will not be informed during runtime. A restart of this iobroker matter device is necessary that it will be detected that the source is not available any more.
steps to reproduce

ioBroker device created and ioBroker Matter Device created on its basis
ioBroker device deleted -> no reaction in the Device tab, not even with F5 (will be followed up in issue tbd)

Think about it, if it is possible, that the user will be informed during runtime of this problem without the need of a restart of the device.
Log
message(6).txt

Please try with next version ... "could" work :-)

matter 0.3.3
@Apollon77
not successfull
Steps to reproduce

ioBroker device Trashdevice4 created and ioBroker Matter Device created on its basis
ioBroker device Trashdevice4 deleted
Check matter tab devices and made page reload
No red icon is visible (not ok 🔴 )

Log
log.txt


Firestore: Serialization fails for classes with non-public parameterless constructors

Hi,
It seems ValueDeserializer uses System.Activator.CreateInstance() to build classes for deserialization. This causes snapshot.ConvertTo<T>() to fail when T does not have a public parameterless constructor.
Since Firestore-related classes are explicitly marked with the [FirestoreDataAttribute], I don't see any compelling reason not to allow non-public parameterless constructors.
This makes even more sense when taking into consideration that, as per the latest update (beta12), non-public properties marked with the [FirestorePropertyAttribute] have serialization support.

Yes, the intention was to allow private constructors too. Will look into this next week.

This is now available in version 1.0.0-beta13.
I haven't forgotten about #2534, although I didn't spot your comment a couple of days ago - will leave an update now.


Duplicate method; The QuotaUtils one is used.

It seems like this PR duplicated the implementation to QuotaUtils, but didn't remove this implementation
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

@afshing -- can you link the commit that moved the code in your description?

@afshing -- can you link the commit that moved the code in your description?

Oh! I missed that link. Added now.
@jolshan do you know why the CI is failing? it seems all the tests are passed, but it fails in "Recording test results" step

Hey @afshing -- the place to view the test results is on the tests tab. The default page really only tells you if the workflow is done. -- see
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15066/5/tests
The test results look pretty good so I will let this build finish and double check, but otherwise, this should be good to merge.

@jolshan it seems like the build for JDK 11 passed, and the other three are failed by some unrelated (flaky?) tests.
Should I keep trying the CI pipeline?

Hey @afshing -- unfortunately fully green kafka builds are not super common. But we are working on it! Given your change, I think we are ok to merge.

Given the nature of the change, I merged this as a MINOR commit. But if you plan to contribute more in the future, please consider filing a JIRA ticket and using the name of the ticket (ie KAFKA-XYZ) in the title of the PR.
Thanks for fixing this!


Include type query endpoint info to upgrade guide

Motivation
Which issue does this fix? Fixes #150
Adds the information about types unification for an easier upgrade.
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

pretty please @makma


Python API direct parameter access not working

@stasJ - I don't think I'm experiencing user error but I'm not 100% positive.
To reproduce, run run /glade/p/cisl/vast/vapor/Bugs/3345/3345.py.  This generates initial.tiff which is correct, and zero.tiff which does not seem to have accepted the 0 value for the _constantOpacityTag.
3345.py for reference:
from vapor import session, renderer

path = "/glade/p/cisl/vast/vapor/data/Bugs/3345/"

ses = session.Session()
ses.Load(path + "3345.vs3")

image = ses.GetRenderers()[0]

v = image._params.GetValueDouble("_constantOpacityTag",0.0)
print("initial " + str(v))
ses.Render(path + "initial.tiff")

image._params.SetValueDouble("_constantOpacityTag","Set opacity value",0)
v = image._params.GetValueDouble("_constantOpacityTag",0.0)
print("zero " + str(v))
ses.Render(path + "zero.tiff")

“_constantOpacityTag” is the variable name, not the tag name.

image._params.SetValueDouble("_constantOpacityTag","Set opacity value",0)
should be
image._params.SetValueDouble(RenderParams::_constantOpacityTag,"Set opacity value",0)


Minimize deps for verify-only use cases

Drop explicit getrandom dep
Use default-features = false when depending on risc0-zkvm to get verify-only behavior.
Use rand_core to avoid rand dependency
Drop verify-only feature
Introduce prove feature (enabled by default)

I checked locally and can confirm it works.


Upgrade to hibernate validator 6.0

The upgrade to hibernate validator 6.0 will not be a drop in replacement as some of the classes in dropwizard-validation need to migrate to javax.transaction interfaces.
https://developer.jboss.org/wiki/HibernateValidatorMigrationGuide#jive_content_id_60x

Maybe we do this in a Dropwizard 2.0 that also includes JDBI3?

hibernate-validator 5.4.x has security vulnerability CVE-2017-7536 . Is there any plan to upgrade it in 1.2.x and 1.3.x also?

@debraj-manna Dropwizard 1.2.6 and 1.3.2 are both using Hibernate Validator 5.4.2.Final, which includes a fix for the referenced issue.
https://github.com/hibernate/hibernate-validator/blob/5.4.2.Final/changelog.txt#L8
https://github.com/dropwizard/dropwizard/blob/be9b592857e85dc50a3181b6b5efc23bdbc384d8/dropwizard-bom/pom.xml#L68-L72
https://github.com/dropwizard/dropwizard/blob/f22ae5293ec400e9faafd1cf18944f5ed60b3c0e/dropwizard-bom/pom.xml#L71-L75

Leaving a note here that this is blocked by https://github.com/eclipse-ee4j/jersey/issues/3871 on Jersey side (as per https://github.com/dropwizard/dropwizard/pull/2298 conversation), so that nobody starts working on it prematurely :)

We encountered a pretty significant perf issue with Hibernate 5.4.2 (https://hibernate.atlassian.net/browse/HV-1642) that is confirmed resolved in 6.0. Looking forward to HV 6.x in DropWizard.

The jersey blocked has been merged and is targeted for 2.28.
https://github.com/eclipse-ee4j/jersey/pull/3908

@joschi is this one done now that the jersey upgrade has been completed?

@jplock Yes, indeed. Thanks for keeping track! 👍


[refactor] namespace parent member expression validation into separate helper function

Two slowest rules namespace and no-deprecated used almost same lines of code for validating member expressions. I refactored validation function into separate helper function namespaceValidator. Then, I changed namespace and no-deprecated to use namespaceValidator function.

@azyzz228 this PR will need a rebase, and unfortunately it doesn't seem trivial.