loadRemote return type - remove "| null"

Clear and concise description of the problem
Using a type with loadRemote is a bit difficult, there may be a cleaner way to do this but this is what has worked for me:
 const Widget = lazy(() => {
    const promise = loadRemote('remote/Widget', {
      from: 'runtime',
    }) as unknown as Promise<{ default: typeof WidgetType }>;
    return promise;
 });

The problem seems to be loadRemote returning "Promise<T | null>" instead of just "Promise < T >" which aligns better with React.lazy. The loadRemote signature of the @mf/runtime package is as follows:
export declare function loadRemote<T>(...args: Parameters<FederationHost['loadRemote']>): Promise<T | null>;

I didn't do a lot of testing on the best way to approach typing it, it would be nice to remove "{ default: T }" as well, but I suppose there isn't a good way to know if its the default or a named export? This could be a nice addition to the documentation as well.
Suggested solution
@mf/runtime change return type:
export declare function loadRemote<T>(...args: Parameters<FederationHost['loadRemote']>): Promise<T>;

This would allow it to align better with React.lazy()
Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Will this still work with non-react import usages? What happens if you send a request that doesn't exist? What case makes it return null

Will this still work with non-react import usages? What happens if you send a request that doesn't exist? What case makes it return null

Outside of React I’m not sure, it’s that weird gray area of technically it could be null and React handles it fine but their types are restrictive. I’m wondering if instead of null it should really just throw in the non-existing case?

@ScriptedAlchemy  - I am going to close this one, this syntax is fairly reasonable just for future reference so no change required.
const Widget = lazy(() => {
  return loadRemote<{ default: typeof WidgetType }>('remote/Widget', {
    from: 'runtime',
  }) as Promise<{ default: typeof WidgetType }>;
});


pkg/policy/api: allow ToPorts coupled with ToServices

This functionality is supported in the datapath, because Cilium now supports
CIDR-dependent L4, and ToServices rules are translated into CIDR rules within
Cilium.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>Fixes: #4713

This change is

test-me-please


refactor: renamed to relayService (#1116)

Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for new/updated/fixed functionality.
[ ] I have updated/added dartdoc comments with ///.

Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

Related Issues

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (695db28) 82.70% compared to head (f917a01) 82.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
+ Coverage   82.70%   82.82%   +0.11%
==========================================
  Files         359      244     -115
  Lines        4221     3161    -1060
==========================================
- Hits         3491     2618     -873
+ Misses        730      543     -187

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Match White/Blue White/Blue/Black, etc. in remove_colors

We match 'White' and 'WU' and 'W/U' but not 'White/Blue'.

We should also strip "Penny Dreadful", "pd", and "[pd]" from deck titles.

We're do that but we do fail on "[PD] MONO B CONTROL" for reasons I have not yet investigated.

Fixed the stripping issue. My regex was looking for opening brackets twice instead of open + close. Doh. Test added.

This hasn't come up enough to be worth doing imho.


Settings Item in Navbar

Describe your problem and - if possible - how to reproduce it
On certain pages on screens with a smaller view width (between 957-1099) the settings item in the navbar will appear below the Navbar itself in a new row.
Add a Link to the page with the problem
https://www.freecodecamp.org/settings
https://www.freecodecamp.org/quincylarson
Tell us about your browser and operating system

Browser Name: Google Chrome
Browser Version:  68.0.3440.106 (Official Build) (64-bit)
Operating System: Windows 7

If possible, add a screenshot here

Duplicate of #18154

I think #18154 is a duplicate of #18089


laziness

We decided to move forward and make purenix a lazy language.
The big downside of this is that we will have to be careful when copying (JavaScript) PureScript code, since it is strict.  Our Prelude and other standard libraries will have to be built from the ground up around laziness.
One concern is whether there is some sort of compilation step in purs before the CoreFn output phase that makes use of PureScript being a strict language.  This would cause problems for us.  At some point we should probably ask the PureScript developers if they know of anywhere this could bite us.

copied this over to https://github.com/purenix-org/purenix/issues/3


Make it easier to customize configuration of default middleware

It should be easier to configure default middleware for specific endpoints -- or to just skip all the defaults and setup your own custom middleware for a specific route. For example, there are places where we want to change the JSON body parser limit.

Perhaps related: https://github.com/digitalbazaar/bedrock-express/pull/8

This may help the cause. https://github.com/expressjs/body-parser/issues/245#issuecomment-304408397


[Component] Progress tracker

Testing informations |
-- | --
Risk level ? | ℹ other stacks : moderate (= should be tested by QAA before or after release)
Does this ticket need to be design reviewed ? | yes
Referent designer : | @JeremiasUX
Spec : | figma
Testing checklist : | gsheet
UATs : | confluence
configurator : | confluence


Shadow on card component (update)

Design decision 2020-03-24

Change

Drop shadow height: 0.375 rem (used to be 0.125 rem)
Drop shadow colour: Black (used to be Grey 2)

Also, note that the drop shadow is located 0.375 rem below the card and is not included in the actual card height
Details
https://designlibrary.sebgroup.com/components/card/#specification
Reasoning
There are too many variations because the design has been unspecified. The goal is to align the design of all our components and frameworks.
If this issue is not relevant to you, please comment and close it.
Thank you! :)
/Ulrika

no card implementation in vanilla


Self signed cert generation update

Suggested Openssl command in the readme didn't yield the expected results on macOS and Chrome browser.
This worked well:
openssl req -x509 -out selfsigned.crt -keyout selfsigned.key \   -newkey rsa:2048 -nodes -sha256 \   -subj '/CN=localhost' -extensions EXT -config <( \    printf "[dn]\nCN=localhost\n[req]\ndistinguished_name = dn\n[EXT]\nsubjectAltName=DNS:localhost\nkeyUsage=digitalSignature\nextendedKeyUsage=serverAuth")

Thank you for sharing! I don't have a macOS to confirm this but if it behaves the same under linux and windows it might be the better option.

Confirmed for Linux.

updating readme to include both openssl commands.


Node.ToHtml never writes IProcessingInstructions via IMarkupFormatter.Processing

Bug Report
Prerequisites

[X] Can you reproduce the problem in a MWE?
[X] Are you running the latest version of AngleSharp?
[X] Did you check the FAQs to see if that helps you?
[X] Are you reporting to the correct repository? (there are multiple AngleSharp libraries, e.g., AngleSharp.Css for CSS support)
[X] Did you perform a search in the issues?

For more information, see the CONTRIBUTING guide.
Description
Node.ToHtml works by testing each Node object against various interfaces (IComment, ICharacterData, etc.) to determine how to write it (i.e. which method to call from the provided Markup Formatter object).
The implementation of IProcessingInstruction is class ProcessingInstruction. ProcessingInstruction is a subclass of CharacterData, therefore implements ICharacterData.
Therefore, if a ProcessingInstruction instance is tested against "is IChararacterData", the result will be true.
In the current Master code, "is ICharacterData" is tested BEFORE "is IProcessingInstruction", therefore ProcessingInstructions are treated as ICharacterData objects and the code specifically for IProcessingInstructions (a subsequent branch in the if-else list) is never reached.
The fix is to test for "is IProcessingInstruction" BEFORE testing "is ICharacterData".
The exact same consideration applies for IComment (class Comment is also a subclass of CharacterData), but that test already preceded the ICharacterData test, so there was no issue there.
(This is my first ever PR, please be kind)
Steps to Reproduce

Parse a document that contains processing instructions.
Output the content via ToHtml

(issue occurs irrespective of the markup formatter, if any, passed to ToHtml, since the issue is in Node.ToHtml itself)
Expected behavior:
Processing instructions are rendered as processing instructions
e.g. <?instruction param="value"?>
Actual behavior:
Processing instructions are rendered incompletely, seemingly via Text or LiteralText.
e.g. param="value"
(opening & closing tags, and tag name, missing)
or, if there are no parameters to the processing instruction, there is nothing output at all for the node.
Environment details:
N/A
Possible Solution
Re-order the tests in Node.ToHtml so that "is IProcessingInstruction" is tested before "is ICharacterData".

The fix is to test for "is IProcessingInstruction" BEFORE testing "is ICharacterData".

Sounds good to me - a PR would indeed be appreciated!
Thanks for detecting and writing it altogether. Superb work :beers:!


BUG

The website not works on Firefox browser Linux
OS-vanilla Arch Linux latest
Firefox version - Latest
Please fix the issue of the website

Probably a duplicate of #577 and #576.

Hi @RajrupDasid
Thanks for the report.
This is probably related to https://github.com/toptal/gitignore.io/issues/577 and https://github.com/toptal/gitignore.io/issues/576
A fix has been released.
If you still encounter any problems, please let us know.

@filipechagas Hi sir , Actually I am still facing the issue mentioned above from both normal Firefox and Firefox Developer Edition.
button is acting like false or not taking POST request , from the mentioned browsers .
I am on the latest versions on them

@RajrupDasid Thank you for the feedback! We're looking into that.
I've reopened https://github.com/toptal/gitignore.io/issues/577 and will be posting updates there.

yes thanks it's now working as before making my work smooth thanks team


weighted-clusters: validate that total sum of weights below max int

Commit Message: weighted-clusters: validate that total sum of weights does not exceed max uint32
Additional Description:
Adds additional validation that the sum of weights of weighted clusters in a route does not exceed max uint32.
Risk Level: low - although this is a new validation, previously there was a similar validation when total_weight was used.
Testing: Added unit test
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.
Signed-off-by: Adi Suissa-Peleg<EMAIL_ADDRESS>

cc @markdroth

/lgtm api


[UI] Enhancing the Landing Page

I would like to redesign and refactor the landing page,while improving the layout and fonts.
I would also like to improve the navbar.

As you can see that from the current version lot of improvements can be made.
I would like to work on it.

Hey @itsadi-24 , You can proceed!

Hi @Vignesh025 which one do you prefer,there is little modification left for both,i will proceed as per your choice.

in 1st one the background image will also change with time

The first one is fine, but remove the privacy and terms from the footer.

ok working on it

Hi @Vignesh025 i have made the PR #228


historical map prepare

Hi,how can i make test_map.pt or train_map.pt by myself dataset?

Hi! You need to firstly train and test the model on your dataset just the same as using MapTRv2. Then you can modify some codes using https://github.com/HXMap/HRMapNet/blob/69857f2324328c382d77bfb692f4011dc679cba9/projects/mmdet3d_plugin/hrmap/global_map.py#L244 to save your maps.

my data format is the same as nus-data ,can i use nuscenes data model ckpt to infer myself data and use this interface to make the map.pt and then train mydata by this map.pt?

Currently, we train the model from an empty map for fair comparison with other methods. The map will be constructed gradually during the training for each epoch. Thus you do not need to prepare a map to train your own model.
But of course, for practical usage, this is not an optimal training setting. Train and test with a pre-built map may achieve better performance. For your purpose, I think you can firstly test the model trained by nuscenes data on your own data, if the results are good enough, you can train your own model using this pre-built map. If the results are not good, you can still train from the empty map as our default setting.

yeah,,

How to update one global map with multi gpu training mode? Currentlly each of them create self global map and update it.


/ct jeiReload does not show progress bar

When I execute /ct jeiReload on modpack E2E-E my client screen just freezes and unresponding.
I profiled it with /sparkc command and could see that there is progress bar stepping, but I cant see any actual progress bar on screen.

Is it intended? Is it possible to turn progress bar on?

Thank you for progress bar implementation!


(PUP-10223) Allow node definitions in apply blocks

Previously, we explicitly forbade node definitions in plans entirely as
Bolt didn't know how to interpret them. This changes to allowing node
definitions in apply blocks so that they can be interpreted by Bolt.
When validating node definitions, we now check whether we're in an apply
block and fail if we aren't. Otherwise, we defer to the standard
validator. That validation will fail however, because definitions are
only allowed at the top level. For the intents and purposes of a plan,
an apply block is effectively a top-level construct, as it will be used
as the top-level input to a catalog compilation. Therefore, we now allow
node definitions to be defined directly within apply blocks (but not
nested any deeper than that).
The last piece of the puzzle is to change the plan instantiator to not
treat these node definitions nested within apply blocks as though they
are top-level definitions that would constitute a single file illegaly
making multiple definitions. We now simply remove node definitions from
consideration when checking whether the plan file has multiple
definitions.

CLA signed by all contributors.

@puppetlabs/bolt feel free to merge this when you're ready


add support for xiaomi.sensor_occupy.03

Thanks!

Updated battery sensor and added entities

{
    # https://home.miot-spec.com/spec/xiaomi.sensor_occupy.03
    18051: ["Xiaomi", "Occupancy Sensor", "XMOSB01XS", "xiaomi.sensor_occupy.03"],
    "spec": [
        # main sensors
        BoolConv("occupancy", "binary_sensor", mi="2.p.1078"),#Tested
        BaseConv("illuminance", "sensor", mi="2.p.1005"),#Tested
        # other sensors
        BaseConv("battery", "sensor", mi="3.p.1003"),
        BaseConv("has_someone_duration", "sensor", mi="2.p.1081"),
        BaseConv("no_one_duration", "sensor", mi="2.p.1082"),

    ],
},

Updated battery sensor and added entities
{
    # https://home.miot-spec.com/spec/xiaomi.sensor_occupy.03
    18051: ["Xiaomi", "Occupancy Sensor", "XMOSB01XS", "xiaomi.sensor_occupy.03"],
    "spec": [
        # main sensors
        BoolConv("occupancy", "binary_sensor", mi="2.p.1078"),#Tested
        BaseConv("illuminance", "sensor", mi="2.p.1005"),#Tested
        # other sensors
        BaseConv("battery", "sensor", mi="3.p.1003"),
        BaseConv("has_someone_duration", "sensor", mi="2.p.1081"),
        BaseConv("no_one_duration", "sensor", mi="2.p.1082"),

    ],
},

I also noticed the has_someone_duration and no_one_duration parameters. However, this is because the device is battery-powered and provides Mi Home users with a rough time estimate as a reference. Since HA integrates this device through XiaomiGateway3 and receives real-time status updates, it is entirely possible to calculate a more precise duration by fetching the last_changed attribute of occupancy entity. Therefore, I decided not to include these two parameters initially. As for the battery, I couldn't test it initially due to the low reporting frequency. I later tried adding "sensor" and tested it, and you seem to be correct.

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v4.0.6


[Minor][Core] Cleanup unused vals in DAGScheduler.handleTaskCompletion

What changes were proposed in this pull request?
Cleanup unused vals in DAGScheduler.handleTaskCompletion to reduce the code complexity slightly.
How was this patch tested?
Existing test cases.

cc @cloud-fan

Test build #91023 has started for PR 21406 at commit 567a7ff.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3495/
Test PASSed.

Test build #91023 has finished for PR 21406 at commit 567a7ff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91023/
Test FAILed.

retest this please

Test build #91037 has started for PR 21406 at commit 567a7ff.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3507/
Test PASSed.

Test build #91037 has finished for PR 21406 at commit 567a7ff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91037/
Test FAILed.

retest this please

Test build #91060 has started for PR 21406 at commit 567a7ff.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3519/
Test PASSed.

Test build #91060 has finished for PR 21406 at commit 567a7ff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

thanks, merging to master!


feature(prerelease-type): changing prerelease-type in manifest or from cli does not bump to new status and reset counter.

Problem description:
My product goes through an alpha, beta, rc, release cycle. Fairly standard. I cannot seem to find a way through the config/manifest system to move to the next phase of prerelease. prerelease-type in the manifest seems to just be ignored if the previous prerelease status was not empty
Solution:
When doing a prerelease version bump, the code should check the prerelease-type flag and if it doesn't match the last version, use this new value and reset the counter to zero.
Alternatives:
I've currently been using release-as: to move to the next phase. It works, but it's not automated.

@chingor13 I see this is assigned to you.  We (npm) are using release-please and also have found several issues w/ how release-please approaches pre-releases.  The TLDR is that it's not really following the semver spec, nor is it even using the semver package to affect semver versioning.  This leads to the issue describe here, as well as other issues such as not actually being able to leave pre-release mode once you are in it.
We ended up having to use our own fork with a custom versioning stragtegy in the past.  We're no longer using that fork, but are likely going to have to re-implement that custom strategy in our release-please consumer to ship npm 11 this week.
It'd be great if long-term we could go back to using a versioning strategy that ships with release-please.  I would love to help here if possible.

Using semver itself in the default and prerelease version strategies, with the same bit of logic from the custom strategy I linked above, would fix this bug and the one we're having with being unable to leave pre-release mode.
> semver.inc('1.1.1', 'premajor', 'pre')
'2.0.0-pre.0'
> semver.inc('2.0.0-pre.0', 'prerelease')
'2.0.0-pre.1'
> semver.inc('2.0.0-pre.0', 'major')
'2.0.0'
> semver.inc('2.0.0-pre.0', 'prerelease', 'foo')
'2.0.0-foo.0'

I created a pr with some context regarding the current issues and troubles we've had https://github.com/googleapis/release-please/pull/2451

@jasonbraley to unblock you theoretically you could set "versioning": "prerelease" (undocumented property 😠 ) with the "prereleaseType": "alpha" and it may work, not 100% though.

Also once you're in prerelaese it may not leave 😆

Tried that. No dice. Once a pre-release tag has been created in the git
history, that seems to be the only information it uses in determining the
next increment. Changing the prerelease-type had no effect.
On Wed, Dec 11, 2024, 5:12 PM Reggi @.***> wrote:

@jasonbraley https://github.com/jasonbraley to unblock you
theoretically you could set "versioning": "prerelease" (undocumented
property 😠 ) with the "prereleaseType": "alpha" and it may work, not
100% though.
—
Reply to this email directly, view it on GitHub
https://github.com/googleapis/release-please/issues/2447#issuecomment-2537305311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5AWPBOGBLPYNHQUNCZ23T2FC2EFAVCNFSM6AAAAABS6XPRWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGMYDKMZRGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


dc/78_write_pod

Pull Request Details
What issue does this PR address

Write data to POD and refactoring of related code

Link to associated issue: #78

Checklist
Complete the check-list below to ensure your branch is ready for PR.
Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

[x] Screenshots included in linked issue
[x] Changes adhere to the team style and coding guideline
[x] No confidential information
[x] No duplicated content
[ ] No lint check errors related to your changes (make prep or flutter analyze lib)
[ ] Pre-exisiting lint errors noted: [HERE]
[x] Tested on at least one device

[ ] Android Phone
[ ] Android Emulator
[ ] Chrome on Android
[ ] Chrome
[ ] iOS
[x] Linux
[ ] MacOS
[ ] Windows

[x] Added 2 reviewers (or 1 for private repositories then they add another)

Finalising
Once PR discussion is complete and 2 reviewers have approved:

[ ] Merge dev into the branch
[ ] Resolve any conflicts
[ ] Add one line summary into CHANGELOG.md
[ ] Bump appropriate version number in pubspec.yaml
[ ] Push to git repository and review
[ ] Merge PR into dev

Moving from dev to dc/78 I now get the following error in my app:
ERROR: lib/home.dart:81:50: Error: The operator '[]' isn't defined for the class '({String name, String version})'.
ERROR: Try correcting the operator to an existing operator, or defining a '[]' operator.
ERROR:                   applicationName: appNameVersion[0].toString(),
ERROR:                                                  ^
ERROR: lib/home.dart:82:53: Error: The operator '[]' isn't defined for the class '({String name, String version})'.
ERROR: Try correcting the operator to an existing operator, or defining a '[]' operator.
ERROR:                   applicationVersion: appNameVersion[1].toString(),
ERROR:                                                     ^

The refactoring of getAppnameVersion in solidpod using Dart Records in this branch means getting app name and version need to be done by:
applicationName: appNameVersion.name,
applicationVersion: appNameVersion.version,


Show date most recently updated

Would be nice to show the date a dataset was most recently updated before clicking it (e.g., by hovering over it).

A dedicated API route for most recent file update times (e.g., archive/version) could be useful for this purpose.


Fix a bug when inputing ingredients

Github converts "\r\n" to "\n" in the uploaded file, hence a bug when parsing the ingredient file

Thanks for your efforts, I will handle the conflicts and merge your PR later.

Thank you! ...I found that I'm still not good at using Github... (@_@)

Me too, but don't worry about it, just keep an eye on it in daily life. Cheers. :-)


Resolved #987 - Add glfwDragWindow function to latest platform structure

Resolved a nice work by @felselva #987 to work on latest platform structure

Add a function glfwDragWindow that starts a drag operation for the specified window. The implementation is done for X11, Windows, and requires tests on Wayland. Patch is related with the issue #923.

example_windows_drag.webm
@elmindreda @felselva

Just tested it on X11 and wayland:
On X11, I first made an error (first time using GLFWs inputs directly and not through Dear ImGui), which resulted in a VERY bad experience for me. Essentially the window stuck to my cursor at random offsets, dragging it along with it erratically (with the mouse cursor being way out of the window area even), and I couldn't do anything to close the window or do anything really, so I had to go into a separate session to kill my window. That was because I did a simple polling implementation (not using a callback) so I called it repeatedly - bad idea. This WILL happen to some devs, and it's bad enough that I would consider some preventative measures.
After I fixed it, it worked wonderfully.
Now on wayland, it didn't work at all. Luckily a quick search lead me on the right path, it needed the serial used in the mouse button event, which is _glfw.wl.serial, not _glfw.wl.pointerEnterSerial. Changing that, it worked fine, HOWEVER, stopping the drag never cleared the mouse button state, so in contrast to X11, on wayland it still thought the mouse button was pressed (glfwGetMouseButton(window, GLFW_MOUSE_BUTTON_LEFT) == GLFW_PRESS) until the next left mouse button press (and needed that, no right click, no key press, nothing else clears that state).
Haven't tested on windows yet, will do in the future.
Thanks for your work on this, hope it gets fixed up and merged soon.

Seems related to https://gitlab.gnome.org/GNOME/mutter/-/issues/2523
Except... I'm on KDE Plasma, so I'm not using mutter.

So unfortunately the suggestions that the mouse leave event should silently set the mouse state to "undefined" with no mouse button release event, is idealistic. E.g. I'm using Dear ImGui and it's input abstraction, which with the GLFW backend, uses the GLFW event subsystem exclusively, without polling the button state, but keeping it's own state with GLFW events.
So it would not notice that the mouse button state changed and internally still thinks it's a drag - disabling things like button hovering feedback, etc.
It needs a GLFW mouse button release event to not become inconsistent. Now we could change the Dear ImGui GLFW backend to support wayland, OR we could be realistic and realise that there are many other abstractions/user code doing the exact same, and simply generate a mouse button release event on mouse leave (and the same for key leave).
This goes against the intention of the wayland protocol, but it seems to work, though I would expect there to be edge cases where it doesn't work. Though looking at above linked issue, the wayland recommended approach might cause edge case issues anyway.
So I suggest we apply diff_realistic and merge this as soon as maybe we get another confirmation that windows works (and I guess a different wayland composer than KWin, might do that myself).
diff_intended.txt
diff_realistic.txt

I tested it on windows, and it worked fine, but had the same issue that event-based systems got stuck in a state - there never was a mouse button up event for the header drag. In contrast to wayland, I found no documentation or event that tells the app to discard the state either, so I just send a button down event right when the window starts being dragged. That is not optimal and prevents any application from knowing if it is still being dragged, but I have not found a better way. And it does work.
Unfortunately on windows the docking to monitor sides/corners doesn't work automatically, so the lack of easy resizing the window is very apparent, so I disabled the custom header on windows. On X11+wayland, although my windows can't be resized yet, they can be docked, and it's usable enough that for now, I am enabling the custom header.
One big downside to any custom header is that when the program is freezing / being debugged, the header buttons don't work anymore, which means you can't close the window that way.
diff_win_realistic.txt

Here's my program using GLFW+Dear ImGui for a WIP custom header (no custom icons yet). This branch made the custom header possible, so I suggest merging it.

Hi @Seneral
A huge thanks to your review this in detail.
This PR was made sometime back. I was in need for drag feature on my linux x11 ubuntu Imgui app, and didnt have wayland to try then, Let me go through your comments and I will integrate the suggested changes and update.
This is a nice function i still use, I hope this gets merged soon

@envyen Most ist just reasoning why I made the changes for the maintainers, and most importantly, what potential side effects they have. But for the purposes of the feature, applying the diff like that should be fine.
Did you implement custom resizing as well? Any hints on existing cross-platform solutions like this for that in glfw?

@envyen any looking at the changes? Trying to get this merged soon (hopefully)

@Seneral, The changes are sensible and I have added the diff
Regrettably, I couldn't update this in time, and couldn't be merged before the 3.3.9 release.

All good, maybe next release. But thank you for keeping this updated, I aim to have a resize-focused PR as well.
Though, it's still missing one line for the button release behaviour on windows (added that later, in the last diff I posted).
Apart from that (and more platforms than "just" windows, X11, wayland), the only thing missing here is, afaik, support for snapping the window to the sides on windows.

Updated

Though, it's still missing one line for the button release behaviour on windows (added that later, in the last diff I posted).


gorm.Model doesn't work

Hi, I'm just playing around with gorm, and I made a type that embedded gorm.Model; according to the docs, it is a shorthand way to define common fields ID, CreatedAt, UpdatedAt, DeletedAt.
Indeed, it does generate them in the table:
+------------+--------------------------+---------------------------------------------------------+
| Column     | Type                     | Modifiers                                               |
|------------+--------------------------+---------------------------------------------------------|
| id         | integer                  | not null default nextval('card_id_seq'::regclass) |
| created_at | timestamp with time zone |                                                         |
| updated_at | timestamp with time zone |                                                         |
| deleted_at | timestamp with time zone |

But it does not query correctly
2015-07-17 17:41:27 UTC [517-2] user@host STATEMENT:  SELECT  * FROM "cards"  WHERE ("cards".deleted_at IS NULL OR "cards".deleted_at <= '0001-01-02') ORDER BY created desc
2015-07-17 17:43:00 UTC [517-3] user@host ERROR:  column "created" does not exist at character 122

Seems like a simple fix.  I can try to send a PR.

Sorry, my fault entirely, the clause was added in the the code.  I thought that bit was auto-generated from gorm.  Closing.


Physical back button close app from nested FlowBuilder (the first is to manage pages at same level)

Describe the bug
I'm trying  to manage nested flow builders starting from a Drawer. If I press physical back button from nested page (NEWS DETAILS for example) the app closes.
                 ROOT PAGE (with drawer)
              /            |           \
             HOME         NEWS        SETTINGS
                           |
                        DETAILS
                           |
                        ANOTHER

The solution can be use IndexedStack for pages of root level, but I will want use FlowBuilder for experiment.
To Reproduce
Steps to reproduce the behavior:

Open the drawer
Tap on "NEWS"
Tap on FAB to go on next page
Press physical back button

Expected behavior
The navigator pop back to previous page.

Flutter Doctor
[✓] Flutter (Channel dev, 1.23.0-7.0.pre, on Mac OS X 10.15.6 19G2021 x86_64, locale it-IT)
    • Flutter version 1.23.0-7.0.pre at **/master
    • Framework revision db6e2d8aa5 (9 weeks ago), 2020-09-25 06:47:03 -0400
    • Engine revision 3a73d073c8
    • Dart version 2.11.0 (build 2.11.0-161.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /**/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Volumes/Samsung_X5/Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.8.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Ultimate Edition (version 2020.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin installed
    • Dart plugin version 202.8070

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • Pixel 2 XL (mobile) • 711KPWQ0617241 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)     • macos          • darwin-x64     • Mac OS X 10.15.6 19G2021 x86_64
    • Web Server (web)    • web-server     • web-javascript • Flutter Tools
    • Chrome (web)        • chrome         • web-javascript • Google Chrome 87.0.4280.67

! Doctor found issues in 1 category.

Additional context
I have simplified the example to a minimum
Here the code

Hi @giandifra 👋
Thanks for opening an issue!
I believe the underlying issue is https://github.com/flutter/flutter/issues/47088. I'll try to look into a fix for the underlying issue as soon as I can 👍

This has been fixed on Android in #14 (v0.0.1-dev.10) but still requires flutter/flutter#47088 to be fixed for iOS.

I'm trying the example that i posted here (same posted above) but i still the same result:

I navigate to NEWS with drawer and to next with FAB
I press physical back button (Android)
The app closes

The authentication flow example work fine (Android test)

Seems to work for me 🤔

This is pretty strange!
What Flutter SDK are you using?

Im using the latest stable (1.22.4)

I was on Flutter master 1.23.0-7.0.pre
I tried on Flutter stable 1.22.0 and 1.22.4 and I have same results.
I tested on Pixel 2XL (Android 11)

@giandifra are you still able to reproduce this using the latest version of flow_builder?

I'll try today! :)

Ops, I still on

I was on Flutter master 1.23.0-7.0.pre
I tried on Flutter stable 1.22.0 and 1.22.4 and I have same results.
I tested on Pixel 2XL (Android 11)

I tested with same result.
Flutter Sdk: 1.26.0-8.0.pre
Device: Pixel 2XL (Android 11)
flow_builder: 0.0.1

@giandifra can you confirm whether or not the issue has been resolved in v0.0.2? Thanks!

@giandifra can you confirm whether or not the issue has been resolved in v0.0.2? Thanks!

Yes it's working! Thanks


Flood fill

Hi, i'd like to contribute with a flood fill algorithm, would that fit within the project?

Sure, contributions are more than welcome. Simply create a new package within the project, something like "paint" for example, as there might be new functions we can add under that category.

Looks good so far, thanks for adding tests one time. Will review it in a second.

I just merged your pull request with the fixes and added an example image to the README.


Deprecate weights_save_path from the Trainer constructor

What does this PR do?
Fixes https://github.com/PyTorchLightning/pytorch-lightning/issues/11768
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Could someone please rerun TPU tests and enable auto merge?

Could someone please rerun TPU tests and enable auto merge?


Use new rank view everywhere the old annotate_with_rank call was used.

This should fix #507, as well as simplifying some code to no longer need rank_replays.py.

Unfortunately it's pretty much a wash for now. A view is basically just a query that the database pretends is a table. It didn't feel worse to me locally. I planned to click around on staging to see how it felt.
In the medium term what we should probably do is use a "materialized view" here:
https://www.postgresql.org/docs/current/rules-materializedviews.html
These are views that postgres saves to a table. The big caveat is that the table can then go stale and you have to go tell postgres whenever it should be updated. But this is a classic materialized view problem, since it's a small table with a big input and not that much information.
It'll be much easier to switch to a materialized view now that we have a regular view, so I figure this is still a step in the right direction. And it does fix the front page bug.


use docker to run nimbus (framework) and supervisor

This is an initial pass at streamlining the building and running of the framework by way of docker.
Other minor changes include:

update storm version to 0.9.4
use slf4j

In general, can you please merge nicely  with @tnachen 's changes in this pull request: https://github.com/mesos/storm/pull/34
i.e., he also messed with the building logic, and it seems to conflict with what you've done here, so can you please rebase on top of his change, and then adjust accordingly?

I found some more problems with cluster.xml that need to be delt with - will submit a new pull request asap.

@tysonnorris : cool -- I honestly am pretty ignorant about docker, so I'm not sure I actually grok what's being done here, but I wanna catch up.  Regarding formatting:  I don't use autoformatters, I don't believe in them.


DHT11

Hi!
Is this firmware works with the DHT11 module and the sonoff basic modified with dry concact?
Thanks!

This is design to control a switched relay over a Wifi connection. So no this will not work in your scenario


Issues saving/loading state_dicts from checkpoint using PyTorch Lightning

Hi! For a project I am working on, I created a PyTorch LightningModule that contains a CLIP model as well as a linear layer and finetuned it on my own data. This may not have been the most ideal setup, but nonetheless I was able to get accuracies in the high 90s when first doing this. However, I saved a checkpoint using trainer.save_checkpoint(...), which when I load back in and test on the same data, only gets guessing accuracy, as if the model had never been trained at all. This wrapper approach I'm using has worked for other similar setups, like using torchvision ResNet models inside a LightningModule with an extra linear layer attached, so I feel like it could be a CLIP-specific issue with how I'm handling things.
Here is an abbreviated version of what my LightningModule looks like:
class ClipWrapper(pl.LightningModule):
    def __init__(self, model, preprocess, num_features, num_classes, lr=1e-8):
        super(ClipWrapper, self).__init__()
        self.save_hyperparameters()

        self.lr = lr
        self.feature_size = num_features
        self.preprocess = preprocess

        self.clipmodel = model
        self.ff_head = nn.Linear(self.feature_size, num_classes)

    ...

    def forward(self, x):
        encodings = self.clipmodel.encode_image(x)
        logits = self.ff_head(encodings.float())
        return logits

And when I look at the state_dict saved by pytorch lightning (i.e. when I print out ckpt['state_dict'].keys()) I'm seeing the parameters that start with clipmodel. as well as the parameters for my extra linear layer, ff_head.weight and ff_head.bias. However, neither of these methods of trying to load in the checkpoint work; they both run just fine, but afterwards the model is still getting only guessing accuracy.
## method 1
newmodel = ClipWrapper.load_from_checkpoint("saved.ckpt")
model.eval()

## method 2
# this is the same code I used to initialize the model when it was trained:
clipmodel, preprocess = clip.load("ViT-B/32")
clip.model.convert_weights(clipmodel)
model = clipwrapper.ClipWrapper(clipmodel, preprocess, n_features, n_classes, lr=learning_rate)

# then i load in the checkpoint and just update the state_dict
ckpt = th.load("saved.ckpt")
model.load_state_dict(ckpt['state_dict'])
model.eval()

I was in an interactive session and was able to figure out that while some of the states were changing after loading in a checkpoint, a subset of the clipmodel.visual.transformer.resblocks parameters were becoming new values that weren't in the initial model or the checkpoint (unless I'm mistaken, I might be confusing myself at this point). Is there something about state_dicts with CLIP that I'm missing, like parts of the model becoming reinstantiated when the model is being loaded in? It could be that I was saving my checkpoint wrong, but I honestly don't know how else to do it other than using torch.save to directly save the model.state_dict(), which I feel like would net the same results, right?
Apologies for the stream-of-consciousness type of post, but let me know if there's any more information I can provide. It's probably just an issue on my end as I'm quite new to training large models, but I just want to check here in case anybody else has had a similar issue.

There were actually a couple interacting issues -- first is that I was able to get it working when I directly saved the state_dict during training (torch.save(model.state_dict(), PATH)) instead of using PyTorch's Trainer.save_checkpoint(). At that point I was able to properly load the model. The second issue was that I was using the Lightning Trainer.predict() function and hadn't overridden the predict_step() method in my ClipWrapper class. Pretty surprising to me that it wasn't actually throwing any errors in that case, but at least I figured it out! Hope this helps if anyone else has a similar issue (although this was more me being new to PyTorch Lightning).


client.receive should be mappable to an event type or other interesting filtering. Look into this.

client.receive should be mappable to an event type or other interesting filtering. Look into this.
Originally posted by @n3wscott in https://github.com/cloudevents/sdk-go/pull/42

Duplicate of #112


Pinniped Supervisor - interactively authenticate once per day/week/month

Is your feature request related to a problem? Please describe.
I'm always frustrated when I've to copy the Auth-Code manually cause I'm a Safari User.
Describe the solution you'd like
I want a Configuration Option for the Supervisor Session Lifetime. It would be Nice, if we could Configure the Supervisor to ask once a week for interactively authentication.
Describe alternatives you've considered
if Safari would do the interactive authentication in the background, then the problem would not be a problem. That Problem is described in #998 .

Hi @0hlov3 thanks for opening this issue.
This feature is on our roadmap, but has security implications since longer lived credentials are inherently more risky.
A few things that need to be implemented first before we can offer this functionality:

Signing key rotation
mTLS binding of credentials
#866
#975 (I think this is the last item for the IDP refresh epic - these are already done: #340 #861 #862 #863 #881 #887)
... I am probably forgetting something ...

All of these items are on our roadmap 😄

A possible workaround would be to create a file called open and put it in /some/other/bin:
#!/bin/bash

/usr/bin/open -a '/Applications/Google Chrome.app' $*

And edit your kubeconfig
...
      command: /full/path/to/pinniped
      env:
      - name: PATH
        value: /some/other/bin
      installHint: The pinniped CLI does not appear to be installed.  See https://get.pinniped.dev/cli
...

Basically this overrides the open binary that will be used by that particular kubeconfig by setting a custom PATH.  This allows you to use a different browser for pinniped logins without changing the default browser you use.  Of course you would have to be logged in to your IDP in the other browser (Chrome in this example), but that may be less inconvenient than manually copy-pasting.

I would love to see this feature added for session length. For certain scenarios and for security I would like to limit the session to even say short as 10 mins for certain users. Will be following your roadmap and hope to see this feature added!

A possible workaround for Safari on macOS would be to create a file called open and put it in /some/other/bin:
#!/bin/bash

/usr/bin/open -a '/Applications/Google Chrome.app' $*

And edit your kubeconfig
...
      command: /full/path/to/pinniped
      env:
      - name: PATH
        value: /some/other/bin
      installHint: The pinniped CLI does not appear to be installed.  See https://get.pinniped.dev/cli
...

Basically this overrides the open binary that will be used by that particular kubeconfig by setting a custom PATH. This allows you to use a different browser for pinniped logins without changing the default browser you use. Of course you would have to be logged in to your IDP in the other browser (Chrome in this example), but that may be less inconvenient than manually copy-pasting.

This solution works for us. Thank you! :)

I would love to see this feature added for session length. For certain scenarios and for security I would like to limit the session to even say short as 10 mins for certain users. Will be following your roadmap and hope to see this feature added!

@CYB3RV4D3R if you are using an OIDC IDP, you can usually configure the length of the refresh token.  Pinniped will honor this - if that refresh token stops working, the user's pinniped session will expire with it.


Automation and Nuclear not working

Hello,
With the 0.17.67 update, we got a new model for the chemical plant and the heat modules.
Unfortunately this prevents the automation and nuclear module from loading as the old graphics are just no longer there to load.
Hope this can be solved quickly, but reverting back to 0.17.66 can be done as a temp solution.

Fixed here:
https://mods.factorio.com/mod/5dim_core/discussion/5d8489badd97a5000debc286

Did you change the filename to the new name in the code?

No,
Reprogrammation of the chemical plant is needed for the mod
I added old png in the mod file and changed all paths


Simple AABB collision detection and resolution

References used for implementation:

Video: Arbitrary Rectangle Collision Detection & Resolution - Complete! - by javidx9
Code: OneLoneCoder_PGE_Rectangles.cpp - by @Javidx9
Post: Celeste and TowerFall Physics - by Maddy Thorson
Post: Thinking Parallel, Part I: Collision Detection on the GPU - by Tero Karras
Forum: Game Development StackExchange

Simple collision detection and resolution are working.
Obs:

Collisions are not being resolved in order yet. The approach on how to deal with this have been discussed in Doraku/DefaultEcs#121 and will be implemented in #7.


[BUG] UnicodeDecodeError: 'charmap'

Describe the bug
I can not run even the most simple example, due to UnicodeDecodeError.
To Reproduce
Steps to reproduce the behavior:

Absolutely virgin install of a virtual environment:
python -m venv .venv

Install Geography package:
pip install geograpy3

As the pypi package suggests, I enter the command:
geograpy-nltk
Here I get an error:
geograpy-nltk : The term 'geograpy-nltk' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
again.
At line:1 char:1

geograpy-nltk

  + CategoryInfo          : ObjectNotFound: (geograpy-nltk:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException

I run the rest of the provided commands:
git clone https://github.com/somnathrakshit/geograpy3
cd geograpy3
scripts/install

I use the example provided:
import geograpy
url = 'https://en.wikipedia.org/wiki/2012_Summer_Olympics_torch_relay'
places = geograpy.get_geoPlace_context(url=url)

I get an error:
Traceback (most recent call last):
File "c:\Users\Balázs\PycharmProjects\Geograpy package test\main.py", line 3, in
places = geograpy.get_geoPlace_context(url=url)
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy_init_.py", line 24, in get_geoPlace_context
places=get_place_context(url, text, labels=Labels.geo, debug=debug)
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy_init_.py", line 46, in get_place_context
pc = PlaceContext(places)
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy\places.py", line 32, in init
self.setAll()
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy\places.py", line 90, in setAll
self.set_other()
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy\places.py", line 206, in set_other
self.other = [p for p in self.places if unused(p)]
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy\places.py", line 206, in
self.other = [p for p in self.places if unused(p)]
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy\places.py", line 204, in unused
return all(self.correct_country_misspelling(place_name) not in l for l in places)
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy\places.py", line 204, in
return all(self.correct_country_misspelling(place_name) not in l for l in places)
File "C:\Users\Balázs\PycharmProjects\Geograpy package test.venv\lib\site-packages\geograpy\locator.py", line 1105, in correct_country_misspelling
for row in reader:
File "C:\Python310\lib\encodings\cp1250.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x83 in position 49: character maps to
Expected behavior
I think I followed all the steps as described on https://pypi.org/project/geograpy3/, but not even the most basic code works
Environment (please complete the following information):

OS: [Windows 11]
Python Version [3.10.5]

I am sorry to here that you are having so much trouble with the Windows/pyCHARM and python environment. This is unfortunately quite common. Alle the errors you are reporting are indicators of that environment giving you trouble.
There is only so much the geograpy team can do about this.
Your first problem is that the script that is being installed by pip install is not in your path. This might happen if your python and pip environment are not in sync or generally there is some kind of misconfiguation. You might want to try a linux environment for better being able to debug this situation. E.g. on linux there is a "which" command which will show you where a script has been installed. That geograpy-nltk is not in your PATH and not found is the first issue.
Please also provide your full "main.py" so that we could check what the problem might be. The cp1250 issues shows that there is something wrong with the string handling/decoding which is typical for the windows environment using https://en.wikipedia.org/wiki/Windows-1250 instead of UTF-8.

Hello Wolfgang,
Thank you for your email.
Is there a way to install the geograpy-nltk manually somehow? Seems like the pip command does not install this, I would give it a manual try.
Meanwhile about the main.py, I attempted to run this code:
import geograpy
url = 'https://en.wikipedia.org/wiki/2012_Summer_Olympics_torch_relay'
places = geograpy.get_geoPlace_context(url=url)
Thirdly, sure, thank you for the suggestion, I will try to replicate the same on Linux and will keep you posted.

@srancsik You should be able to install the package manually by downloading the source code and building from source.
Also, I see that you have created a virtual env for python. Did you also activate it using source <env_name>/bin/activate? I say this since I have seen lots of cases where users have forgotten to activate the newly created virtual env.
Lastly, in case you need it, here are the steps to add Python to your Windows PATH: https://www.makeuseof.com/python-windows-path/


Add SVG logo to base template

Add the planetary logo to the top left corner of all admin pages. For an example, see https://planetary.pro/admin

I think we could use some left and maybe top padding on narrow width devices. I'm going to go ahead and click approve though as that should be a pretty simple change!

Great point.  Added the same padding to the side as to the top, and merged.


Issue with Sitecore JSS: Cannot read properties of undefined (reading 'route')

I am encountering an issue with Sitecore JSS while working on my new app which is using NextJS 13 (Disconnected mode). After creating the app using the JSS CLI and starting it, I am facing the following error:
    at NormalModePlugin.exec (webpack-internal:///./src/lib/page-props-factory/plugins/normal-mode.ts:39:36)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async eval (webpack-internal:///./src/lib/page-props-factory/index.ts:26:24)
    at async eval (webpack-internal:///./src/lib/page-props-factory/index.ts:25:21)
    at async eval (webpack-internal:///./src/lib/page-props-factory/index.ts:25:21)
    at async SitecorePagePropsFactory.create (webpack-internal:///./src/lib/page-props-factory/index.ts:24:27)
    at async getServerSideProps (webpack-internal:///./src/pages/[[...path]].tsx:79:17) {
  digest: undefined
}
  37 |     );
  38 |
> 39 |     if (!props.layoutData.sitecore.route) {
     |                                   ^
  40 |       // A missing route value signifies an invalid path, so set notFound.
  41 |       // Our page routes will return this in getStatic/ServerSideProps,
  42 |       // which will trigger our custom 404 page with proper 404 status code.

From the error message, it seems that the props.layoutData.sitecore.route is undefined, leading to a TypeError. I believe this issue might be related to a bug on the Sitecore JSS side or some misconfiguration in my app.
Things I have already checked:
Verified the route configuration in Sitecore.
Reviewed my code for any issues with data fetching or usage.

To Reproduce
1) Create a new app using the JSS CLI.
2) Start the application.
3) Observe the error in the console.

Expected Behavior
The application should start without any errors, and the props.layoutData.sitecore.route object should be populated with the expected data.
Possible Fix
No response
Provide environment information

Sitecore Version: 10
JSS Version: ^21.1.1
Browser Name and version: Firefox, Chorme
Operating System and version (desktop or mobile): Mac OS
Node version: 16.20.0
NextJs version: 13.1.6

(Connected mode) this error occur whenever we use general link field and we are providing an internal link to it, rather than you need to use an general link with search in your Sitecore instance.

@HermonSolomon I couldn't reproduce this issue using the latest version, if you can provide more details (in case you have any customizations), feel free to reopen the issue


Compare “world ready” shaper to generic shaper?

Can you please describe your issue in a little more detail? 😉

Yes, InDesign has multiple shapers, maybe your script can compare their results

Now I get it. I found a property in InDesign DOM. If I am right it is new since InDesign 2020 and you can change the shaper with it. (Adobe shaping engine vs. HarfBuzz)
I still need to find a proper place and how to test it.

 I think it's also changable via UI by the way, so users are likely to come across it. And for many languages it's required, for some of my fonts too even for Latin (as the default shaper doesn't have mult sub support!!)

I added an option to change the shaping engine. If you want you can test the script:
Branch Develop or download here
openTypeFeatures_v2-1.zip

Shaping Engine
Set Lipika (default) or Harfbuzz as the shaping engine for Latin and Indic script
in Adobe World-Ready Composer. The property is applied to the active document.
After activation (only) the selected text will be recomposed. Available for InDesign
2020+ only.

Or can you tell me a character combination to test this?

@RolandDreger https://github.com/ctrlcctrlv/FRBAmericanCursive/issues/14#issuecomment-986088089 "Performances Report" in any of the FRBAC v1 fonts (v2 will have the same bug so it's immaterial for you to test v1 or v2 for this, the v2 bug fix is just adding docs telling people to enable World-Ready Shaper)

I think the problem is that InDesign uses Harfbuzz only in the World Ready Composer. When it is set, Harfbuzz can be used for certain fonts, as I understand it.
However, when I use the Word Ready Composer, the faulty rendering does not occur and change the shaping engine via script has no effect.

@RolandDreger I understand the issue's cause quite well.
The normal Adobe iD shaper does not support OpenType GSUB Type 2 (Multiple Substitution).
I require GSUB 2 to do that trick. The lookup is essentially…
lookup Fina {
    …
    sub s by s.low tail.low;
    …
} Fina;

If you don't get a tail, you never get the final transition to s.low. My tails are also removable—again via a Mult Sub (with 0 replacement values, fun hack @simoncozens added to fontTools that is supported in CoreText, MS DW and HarfBuzz), that occurs after the addition of the tail, it doesn't work by preventing the tail removal, but rather looks like…
sub tail.low by NULL;
sub tail.lowwide by NULL;
sub tail.high by NULL;

Anyway, my font will never work right with Adobe's broken non-compliant shaper, so I was thinking it'd be a good test for you to have an example of such a font.

@RolandDreger Thanks, fixed in e048fcf10583d6f27111d2a504fd31a1a94d1120!
(I'm only adding this comment because otherwise it looks like you closed issue without fixing/adding feature, which is not the case. 🙇♂)


Endless Searching - Ability to manually enter IP would be nice.

My subnet is a touch larger than the average (<IP_ADDRESS>) so most scanning tools take a decade to work on it, and the build window in MRTK is no different.
It would be nice if I could cancel the search and manually enter the IP of my HoloLens.

I don't think the IP scanning is even enabled.

Currently it's only usb

I saw your PR that fixed searching. Thanks!

Been this is kinda a duplicate of #1020. Could you close this and add your comment there?


Regenerate tests_recording/test_data/ and update docs

I've been trying to make make check_in_container_regenerate_data work for me (because of #1074), but with no luck.
When I try make check_in_container_regenerate_data locally I see some problems with tokens so I checked the code and AFAICT we don't use GITHUB_TOKEN and PAGURE_TOKEN anymore so I changed the Makefile to mount my ~/.config/ into the test container.
But I still see ogr.exceptions.PagureAPIException: Pagure API returned an error when calling 'https://src.fedoraproject.org/api/0/fork': Invalid or expired token. even the obfuscated token from logs looks like the one which I confirmed is valid and works.
@lachmanfrantisek ideas?
I also see
E   subprocess.CalledProcessError: Command 'cd /tmp/packit_tmp/tests_recording.test_api.ProposeUpdate.test_version_change_mocked.yaml/static_tmp_1;git commit -m 'test change' python-requre.spec;git tag -a 0.5.0 -m 'my version 0.5.0'' returned non-zero exit status 128.
------- Captured stderr call -------------
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/packit_tmp/tests_recording.test_api.ProposeUpdate.test_version_change_exception.yaml/static_tmp_1'
error: pathspec 'python-requre.spec' did not match any file(s) known to git
fatal: tag '0.5.0' already exists

which I failed to debug.
@jscotka ideas?

I also see
:

which I failed to debug.
@jscotka ideas?

Can you try increasing the version in the test-case to the one above the current version?

I also see
:

which I failed to debug.
@jscotka ideas?

Can you try increasing the version in the test-case to the one above the current version?

error: pathspec 'python-requre.spec' did not match any file(s) known to git

that's right, there's no  python-requre.spec anywhere

error: pathspec 'python-requre.spec' did not match any file(s) known to git

that's right, there's no  python-requre.spec anywhere

oh, so there's another README.md hidden (nothing links to it from CONTRIBUTING.md) in tests_recording/ and it suggests to run pytest directly instead of in the test-container.
I've just tried and can see the same failures as in the container.

oh, so there's another README.md hidden (nothing links to it from CONTRIBUTING.md) in tests_recording/ and it suggests to run pytest directly instead of in the test-container.
I've just tried and can see the same failures as in the container.

error: pathspec 'python-requre.spec' did not match any file(s) known to git

that's right, there's no python-requre.spec anywhere
EDIT: @jscotka is it possible that you forgot to actually add the fedora/python-requre.spec in 3839902 ?

requre spec is in the master branch in fedora subdir: https://github.com/packit/requre/blob/master/fedora/python-requre.spec

error: pathspec 'python-requre.spec' did not match any file(s) known to git

that's right, there's no python-requre.spec anywhere
EDIT: @jscotka is it possible that you forgot to actually add the fedora/python-requre.spec in 3839902 ?

requre spec is in the master branch in fedora subdir: https://github.com/packit/requre/blob/master/fedora/python-requre.spec

requre spec is in the master branch in fedora subdir

@jscotka Aha, I was checking this repo, not requre. I see it now, thanks. I've just filled https://github.com/packit/requre/pull/144 which is needed to successfully run tests in tests_recording/.

Can you try increasing the version in the test-case to the one above the current version (the real, released version)?

@lachmanfrantisek problem should be fixed with https://github.com/packit/requre/pull/144 Thanks for help!
Please review this PR, thanks!

requre spec is in the master branch in fedora subdir

@jscotka Aha, I was checking this repo, not requre. I see it now, thanks. I've just filled https://github.com/packit/requre/pull/144 which is needed to successfully run tests in tests_recording/.

Can you try increasing the version in the test-case to the one above the current version (the real, released version)?

@lachmanfrantisek problem should be fixed with https://github.com/packit/requre/pull/144 Thanks for help!
Please review this PR, thanks!

I moved the regeneration commit directly into https://github.com/packit/packit/pull/1074 where I actually need it.
This PR is now only about the documentation.
Please review.

I moved the regeneration commit directly into https://github.com/packit/packit/pull/1074 where I actually need it.
This PR is now only about the documentation.
Please review.


Update everything, remove deprecated stuff from updates, make Travis builds less flaky, and update storage sample

@samtstern Please don't merge yet, I want to do a wee bit of testing with Facebook.

@samtstern If everything looks good to you, both Facebook login and the storage permission stuff work great so this should be good to merge once the Travis build passes.

@samtstern Urgh. It should be fixed in https://github.com/firebase/FirebaseUI-Android/pull/559/commits/f501d20f45320abb64cc9be3a970f6306666cb26 though!

@SUPERCILEX the manifest placeholders may not be working in the Robolectric tests, the tests are unhappy again.

@samtstern Yeah, I noticed. I thought tests ran in debug mode, but I guess not. I think I'll just have to copy the manifest for the tests.

@samtstern I figured it out: ./gradlew check runs testReleaseUnitTest. Now I just have to remove that task from check and we should be good.

@samtstern It's working locally, will push and we should be good to go hopefully.

Merging.  In the future we should see if we can get release tests running.

@samtstern Totally agree with you, created https://github.com/facebook/facebook-android-sdk/pull/494 to address this issue.


Fix pull request labeler

As the title.
I believe a mix of wrong labels (because of capitalization), bad syntax (negation in github is !), and useless triggers broken this workflow.
Feedback is appreciated.
Reference: https://github.com/pyansys/pymapdl/actions/runs/2206989769

It looks like the syntax error is solved now. I think the action is waiting for a PR to be opened or reopened, @germa89. If you want, we can open a draft one to better debug this.

I guess we shall merge this first, in order to test it properly.


Convert a dRep extended vkey to a non-extended one:

cardano-cli conway key non-extended-key --extended-verification-key-file test.drep.vkey --verification-key-file /dev/stdout

Command failed: key non-extended-key  Error: Invalid key.

Originally posted by @gitmachtl in https://github.com/input-output-hk/cardano-cli/issues/352#issuecomment-1753622844

@CarlosLopezDeLara> in this case, the original extended drep key should be created as follows right?
cabal run cardano-cli -- conway governance drep key-gen \
--verification-key-file drep.vkey \
--signing-key-file drep.skey

@smelc no need for cardano-cli to generate extended drep keys. they are coming into play if derived from the new path 1852'/1815'/acc'/3/idx'. typically from 3rd party tools like cardano-signer, spo-scripts, cardano-address, cardano-hw-cli.

@smelc, as @gitmachtl rightly pointed out, extended keys typically come from Hierarchical deterministic (HD) key generation tools, so the cli doesn't generete them, just supports them.

@gitmachtl, @CarlosLopezDeLara> OK I see, thanks for the explanations :+1:
As a first step, for this very specific issue, could one of you provide me with an example extended key (in your example Carlos the test.drep.vkey file)? Just so that I see if I can reproduce the issue locally, which will help me navigate what I need to do.

@smelc you can simply copy the test key below and paste it into a textfile:
{
  "type": "DRepExtendedVerificationKey_ed25519_bip32",
  "description": "Delegate Representative Verification Key",
  "cborHex": "5840b0cd9e6e3e274f4f38f55ef274af123cf4600ac0c58294399b7e076175262553dde8b75f847f2b7e61a8748627292a06d739c8ba8e78ac83e666030d1093fb3e"
}

i have uploaded you the same file here if needed

Investigating this this morning. The offending code starts with the parser at https://github.com/input-output-hk/cardano-cli/blob/main/cardano-cli/src/Cardano/CLI/Legacy/Run/Key.hs#L53 then goes on with https://github.com/input-output-hk/cardano-cli/blob/main/cardano-cli/src/Cardano/CLI/EraBased/Run/Key.hs#L138. Finally it calls https://github.com/input-output-hk/cardano-cli/blob/main/cardano-cli/src/Cardano/CLI/Types/Key.hs#L251 at which point it goes to code in cardano-api.

Going into cardano-api, we find our friend deserializeAnyVerificationKey in cardano-api/internal/Cardano/Api/DeserialiseAnyOf.hs#L299 and finally we find in cardano-api/internal/Cardano/Api/Keys/Shelley.hs#L1493 that there is no Extended version of DRepKey, which is likely the crux of the problem.
I know need to figure out how it's formally defined, so that I can add the corresponding code.

@ryun1 @CarlosLopezDeLara i think we had this in a pr from you. also its in the cip-conway-keys: https://github.com/Ryun1/CIPs/blob/conway-keys/CIP-conway-keys/README.md


Format "last woken" time prettily

What crate(s) in this repo are involved in the problem?
tokio-console
What is the issue?
Tokio console has nice prettily formatted times when UTF-8 support is turned on.
The times use only a small number of decimal places and are colour coded depending on the multiplier (seconds, milliseconds, etc.).
However, in the Task detail screen in the Waker panel, there is a time for "last woken" which does not have this formatting. It is not color-coded and it generally displays far too many decimal places.
How can the bug be reproduced?
Enter the task detail screen for a task that has been woken at least once. Look at the Waker panel, specifically the "last woken" value.
See screenshot for details and a comparison of the pretty vs. non-pretty times:

Logs, error output, etc
No response
Versions
tokio-console: 0.1.10 (and also the main branch at the time of writing).
Possible solution
Change the formatting of the value for "last woken":
https://github.com/tokio-rs/console/blob/28a27fcfeb3a0838e1f5f2d17a6fa18b3f33c508/tokio-console/src/view/task.rs#L208
See the value for the "total time" field in the Task panel for an example of how to format the time prettily:
https://github.com/tokio-rs/console/blob/28a27fcfeb3a0838e1f5f2d17a6fa18b3f33c508/tokio-console/src/view/task.rs#L183

I can take this one on

Hi @hds. I created #529 to address this. Do you mind taking a look?

@yerke Yes,looks good, It might not get merged until Monday though.


Adds Reviews to Page

Allows users to add reviews to the page.
Adds some style aspects: CSS on the comments and in the white background. Adds a form to the page, which allows users to write reviews and add it to the page. Also adds the user's name.

thanks for all the great comments!!! it's very helpful :)


Add child / recursive example

(Sorry, this isn't really an "issue")
Is there any chance you could add some examples of the nested scope / Spawner::recurse functionality?

There's a very minimal example in the documentation but it probably doesn't really explain what it's good for. Many potential examples are better served by Spawner::join, which is just a thin wrapper around recurse. I would be glad to provide an example, but it might take me some time to think of one which is both not contrived and sufficiently helpful.
Lack of useful documentation is definitely a valid issue :)


Having text highlight warning issue if navigate to blade file from any .php file

This error keep showing after I open a blade file after any php file, Models, Controllers. My treesitter blade settings are all following the latest in the Neovim discussion setup. Anyone having this issue as well?

found the solution and the root cause here


Fix pykube cert handling for Python versions < 3.5

Requests v2.12 has just been pushed to pypi.
This is the first version that contains urllib3 >= 1.18, which contains the fix https://github.com/shazow/urllib3/issues/258 adding support for IP Subject Alternate Names.
This fixes https://github.com/kelproject/pykube/issues/29 (which though closed, didn't actually have a proper resolution, until the urllib3 fix percolated into requests).

This will also fix #41

Fixed the tests, should be good for review now.

Is there a release that contains this fix?


Terminal style is different on other Monitor

If I start vs code initially on my monitor, not the screen of my MacBook (MacBook is closed), the first opened terminal looks different (first img).
If I start vs code on the screen of my MacBooks without a monitor connected everything works fine.

Originally posted by @Pascal-Klinkenbergh in https://github.com/microsoft/vscode/issues/125087#issuecomment-860263004

This likely has to do with the setting terminal.integrated.gpuAcceleration. Experiment w that and let me know

I tested with and without the monitor and came the the following conclusion:
Behaves the same with and without monitor. But is hard to see on MacBook.
terminal.integrated.gpuAcceleration=off
Behaves the same for all created terminals:

terminal.integrated.gpuAcceleration=on
Also behaves the same for all created terminals:

terminal.integrated.gpuAcceleration=auto
Background colour is different for the first and all other terminals created afterwards.
The first created terminal has a darker background. All other terminal created after that have the correct background but different font settings.
on monitor:
first terminal:

all other terminals:

on Macbook
first terminal: (hard to see, but via color picker visible)

all other terminals: (correct background)

Having the same issue on Mac Mini M1 - on both of connected monitors.

I believe this is fixed with https://github.com/microsoft/vscode/issues/127645, let me know if you still see it on Insiders and include the version


Losing Internet mid Export Template download crashes Godot

Godot version
3.4.1.stable
System information
Windows 10
Issue description
If you "turn off" the Internet whilst the "Export Template Manager" is downloading it crashes Godot
Steps to reproduce
Open Export Template Manager
Click "Download and Install"
"Lose" Internet.
"Losing" Internet is simply unplugging ethernet/turning off wifi router.
Turning Windows 10 Aeroplane/Flight mode is recognised by Godot as something to manage.
Minimal reproduction project
No response

Turning Windows 10 Aeroplane/Flight mode is recognised by Godot as something to manage.

Does this mean Godot doesn't crash if you enable airplane mode while downloading export templates?

Does this mean Godot doesn't crash if you enable airplane mode while downloading export templates?

Correct, I tested this and Godot appears to timeout in the background then display a message that it will download in the background.
However I just tested this again, i.e. put Windows 10 in "Flight Mode", in the hope of getting a screenshot and it was unable to continue the download, I went to cancel as the message was not appearing and Godot went through a "Not Responding" phase, recovered and showed the message (after it had frozen):


Include version number in release assets

The assets attached to releases currently use the exact same archive names for every release.
Please consider including the version number in the archive name (for example, ruff-0.1.6-aarch64-apple-darwin.tar.gz instead of the current ruff-aarch64-apple-darwin.tar.gz), so it's possible to easily tell archives from different releases apart.

I don't feel opinionated about whether the version numbers should be included in the release assets or not. Do you know of other tools that include the version numbers? Would you be interested in creating a PR that includes the version number in our release assets?

No hard stats to back it up, but in my experience including the version number is the rule (both for source archives and binary archives). A few other tools that include version numbers (the first few that came to mind): ripgrep, hyperfine, fd.
I suppose I could have a go at updating the workflow to include version numbers in archive names.

Closed by https://github.com/astral-sh/ruff/pull/9002. Thank you!


"Add layer" option is hard to reach if list of data is too long

Steps to reproduce:

Add WMS source (epidemico), enter username password
The UI presents a list
Add layer is way down... takes a while to get to it..

What we could do?

Add a button in front of each entry (open for other suggestion as well)

@aashish24
Check out the screenshots in #158.  There is a search field at the top that filters the list.  I bet this will accomplish what you want.

thanks @mgrauer but what happens if your search returns a long list of items as well?

are you saying that you don't want to scroll back up, as a usability issue?  trying to understand the exact problem.

@mgrauer You saw it other day, if you have a long list and you filter, add layer is way far down. I think having a control in front of each entry would be nice but I am open for other options.


Update BrukerTiffImagingInterface for volumetric imaging

Extractor PR: https://github.com/catalystneuro/roiextractors/pull/230

Thanks! Sorry it took me so long to get to this...
The files look good for the most part; some comments about about minor metadata, and some minor remaining questions below
The file bruker_dual_color_with_suite2p.nwb has two devices, one properly named and one default, but the default doesn't seem to be linked to anything
Was this a previous (older) file or is it something that has since been fixed on the most recent version of this branch?
Also in bruker_dual_plane_disjoint.nwb, maybe I missed something, but I couldn't find any distinguishing information between the two disjoint planes (were they different depths?)
Also can you share or point towards an example of the multi-plane but contiguous?

Thank you @CodyCBakerPhD for checking the files!

The file bruker_dual_color_with_suite2p.nwb has two devices, one properly named and one default, but the default doesn't seem to be linked to anything
Was this a previous (older) file or is it something that has since been fixed on the most recent version of this branch?

This was indeed an older version, I re-uploaded stub_dual_color_imaging.nwb which should have 1 properly named device linked to ImagingPlaneCh1 and ImagingPlaneCh2

Also in bruker_dual_plane_disjoint.nwb, maybe I missed something, but I couldn't find any distinguishing information between the two disjoint planes (were they different depths?)

No, you're right. From the XML we know that the first plane "positionCurrent" parameter for the Z axis is -130 and for the second plane it is 130. But now I'm confused whether to interpret it as the first plane is at 130 microns depth and the second is 260.

Also can you share or point towards an example of the multi-plane but contiguous?
Sure, stub_dual_plane_imaging_contiguous.nwb should have a default named TwoPhotonSeries with (100, 512, 512, 2) shape of data in it.

No, you're right. From the XML we know that the first plane "positionCurrent" parameter for the Z axis is -130 and for the second plane it is 130. But now I'm confused whether to interpret it as the first plane is at 130 microns depth and the second is 260.

Based on the appearance of the nice looking contiguous file, I'd say make use of the grid_spacing and field_of_view arguments for the disjoint plane case; simply adjusted for the differences from being non-contiguous
Also can you add a CHANGELOG?

@CodyCBakerPhD files are in bruker/, look for origin_coords and grid_spacing in ImagingPlane, and field_of_view in TwoPhotonSeries

@weiglszonja Thanks so much! These files look amazing
Easily the best imaging files NeuroConv has produced


[pipelineX](es scan) Support ES scan operator

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Fix tests for microformats

It seems that new version of the library for parsing microformats have been updated recently and it causes that three tests does not pass anymore. I did the following here:

I verified why exactly the tests fails.

First of all mf2py seems to trim text in the content, so it means that signs of new line are removed.
Second thing is that in some cases the name property has been removed from output. To be honest I don't understand why it happened, especially that it is not removed every time. Do you think we should care about that and ask them about that?

I believe that we can just use this new version so I fixed all tests.
I fixed the version of library in requirements.txt to 1.1.0.

@Kebniss, you can notice that in tests/test_uniform.py where I had to remove 'name': [''] property because it doesn't appear in the result anymore. And you can also see there that not all empty properties like 'name': [''] have been removed from the output - for instance there is still one in the first item of the expected array. I checked the html and I didn't notice any special difference between these cases, that for the first the property is removed and for the second not.

I see. if it happens only with empty strings it is not be a problem then :)

Thanks @jakubwasikowski!


Kindly document in a prominent place that a sln-file is needed to much of the functionality to work

Is your feature request related to a problem? Please describe.
For several hours, I could not get intellisense working in the C# extension, and there was no helpful setting or error message to the rescue. By pure chance, and after hours of googling, I found that a sln-file may help. After using dotnet new sln and dotnet sln add ...path/to/all/relevant/csproj, intellisense started working!!!
My setup is so that I have a project that uses mostly csproj files, but also two or three dedicated sln files buried in subdirectories. One of these sln-files is exclusively used in CI tests. It points to a sub-project, that is not meant to be built or used in VSCode. This sub-project only works correctly (i.e. can only do a nutget restore) when used inside of our CI system.
I think this additional sln-file may be related to the problem I was having. This is because I'm under the impression that the C# extension tried to load one or more of the sln-files in subdirectories and then failed to correctly index my project(?)
Describe the solution you would like
It would be great if this could be better documented on the front page of the C# extension. Possibly, there could also be better error or logging messages?. I'm not sure which of the following two applies:

A sln-file linking all the csproj-files is mandatory?
No non-working sln-files in subdirectories should exist?

Applicable Scenarios
Describe alternatives you've considered
Additional context

@emmenlau Are you also using the C# DevKit? C# extension on its own shouldn't require a solution file as it will load all the .csproj files in the repo.
We are also trying to make it more apparent when you are working on files outside the open workspace (solution or project files). Would a notification such as the one added in this PR (https://github.com/dotnet/vscode-csharp/pull/7652) have helped you?

@emmenlau Are you also using the C# DevKit?

Yes, actually I'm also using the C# DevKit. Maybe that added to the confusion. With this insight, I think my feature request applies more to C# DevKit than to the C# extension.

We are also trying to make it more apparent when you are working on files outside the open workspace (solution or project files). Would a notification such as the one added in this PR (#7652) have helped you?

This notification would have helped, yes. However, it would only have cut my debugging time from something like 5 hours to maybe 2 or 3 hours. My challenge was, that I would never have assumed for the extension to load a random sln file in a subdirectory. Even more so, because this sln-file is only used by the CI system, and does not even correctly load outside the CI.
In my humble opinion, the auto-loading of sln-files should be a lot more transparent. Something like the following notification message would have greatly helped:
Warning: You have opened a VSCode project, but the C# DevKit extension will only consider C# sources that are referenced from a Solution File (*.sln). There is no Solution File in the root of your project, but multiple solutions files have been detected in sub-folders of your project. Randomly, the first Solution File has been loaded. If this is not what you want, consider the documentation at ...some link to an explanation on how to work with this...

In the linked documentation, I guess multiple questions could/should be addressed:

How to create a new, clean sln-file in the root of the project, so that all C# files are indexed?
Is it supported to work without any sln-file?
How to avoid loading a random sln-file?

Hmm, today I opened a different project, and there is a popup message:

I have not seen this in the other project before. This is actually indeed helpful, albeit it could still better describe the problem.

cc @webreidi - do we have documentation on this for C# Dev Kit?


Provide sample TPK in Web Mercator

The San Francisco sample TPK is currently in WGS84. This looks decidedly odd to anyone used to seeing online maps these days.
Would be great to provide a Web Mercator version.

Close due to inactivity.


False positive in tabs: Line indented incorrectly; expected at least 2 tabs, found 2

Bug Description
It's getting false positives in line indents.
Minimal Code Snippet
		echo do_shortcode( '[my_subcatboxes]' );
		echo do_shortcode( '[my_sticky_posts]' );

For bugs with fixers: How was the code fixed? How did you expect the code to be fixed?
Error Code
Line indented incorrectly; expected at least 2 tabs, found 2 phpcs
Environment

Question
Answer

PHP version
7.3.24

PHP_CodeSniffer version
3.3.1

WPCS version
2.3.0

WPCS install type
Composer global

IDE (if relevant)
VSCode

@davidperezgar Thanks for reporting this, but I'm not sure what you expect.
Two things here:

The issue cannot be reproduced with the code sample you provided. Not with the exact same PHP/PHPCS/WPCS combination as you've listed above, nor with the current develop version of PHPCS/WPCS.
And even if it could be reproduced, this is not an issue which can be solved in the WordPressCS repo as the sniff involved is a sniff from PHP_CodeSniffer itself.
As per the CONTRIBUTING guidelines, issues with PHPCS native sniffs should be reported in that repo.
You can see whether a sniff is from WPCS itself or from elsewhere by running PHPCS with the -s flag to see the error code.

Having said that, I'd strongly recommend you upgrade your PHPCS version before reporting anything upstream as you are using an outdated version. The current version is 3.6.0 and your issue may well be solved already.

Closing for lack of response.
If this is still an issue, please provide the additional information requested and we can reopen the issue.


⚠ Minecraft has degraded performance

In a6bc055, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1248 ms

Resolved: Minecraft performance has improved in a5a977e.


Documentation gives the wrong instruction to activate remote jmx (CASSANDRA-15535)

in order to activate jmx remote, the varaible LOCAL_JMX has to be set to no, the documentation says the opposite. @dineshjoshi

I have committed this change. Please take a look at my comment in the ticket here: https://issues.apache.org/jira/browse/CASSANDRA-15535 For future reference, please don't reuse existing branches or PRs for new fixes. Update your local trunk and create a fresh branch with changes in there.


ISPN-12752 Handle CLI batch errors to be more informative

https://issues.redhat.com/browse/ISPN-12752

LGTM. I discovered another minor bug though ISPN-13095

Thanks @tristantarrant


Replicate Example not working in Chapter 3

While running the following Replicate Example in LangChain:
Here is a simple example for creating an image:
from langchain.llms import Replicate
text2image = Replicate(
model="stability-ai/stable-diffusion:db21e45d3f7023abc2a46ee38a23973f6dce16bb082a930b0c49861f96d1e5bf",
input={"image_dimensions": "512x512"},)
image_url = text2image("a book cover for a book about creating generative ai applications in Python")
I get the following error:
Traceback (most recent call last):
File "C:\Users\Azus\Desktop\GenerativeAI_LangChain\examples\test.py", line 15, in <module>
   image_url = text2image("a book cover for a book about creating generative  ai applications in Python")
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\langchain\llms\base.py", line 825, in __call__
    self.generate(
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\langchain\llms\base.py", line 621, in generate
    output = self._generate_helper(
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\langchain\llms\base.py", line 523, in _generate_helper
    raise e
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\langchain\llms\base.py", line 510, in _generate_helper
    self._generate(
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\langchain\llms\base.py", line 1000, in _generate
    self._call(prompt, stop=stop, run_manager=run_manager, **kwargs)
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\langchain\llms\replicate.py", line 115, in _call
    version = model.versions.get(version_str)
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\replicate\version.py", line 62, in get
    resp = self._client._request(
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\replicate\client.py", line 85, in _request
    _raise_for_status(resp)
  File "C:\Users\Azus\anaconda3\envs\langchain\lib\site-packages\replicate\client.py", line 358, in _raise_for_status
    raise ReplicateError(resp.json()["detail"])
replicate.exceptions.ReplicateError: Not found.

Nevermind i fixed the issue, it seems the model name (the long hash after stability-ai/stable-diffusion: ) needed to be updated, i used the one in the most recent Langchain documentation. Can you close the issue pls.
Thanks

Hi @elmondhir! Thanks for highlighting the issue! Good that you figured it out! Please continue posting - it might help other people who deal with the same problems.

@elmondhir can you please post the code you were talking about. What was the fix? Updated how?

@brzaz228 The code is in chapter 3, in the example for image generation:
`from langchain.llms import Replicate
text2image = Replicate(
model="stability-ai/stable-diffusion:db21e45d3f7023abc2a46ee38a23973f6dce16bb082a930b0c49861f96d1e5bf",
input={"image_dimensions": "512x512"},)
image_url = text2image("a book cover for a book about creating generative ai applications in Python") `
you need to change the long hash after stability-ai/stable-diffusion:

Thanks, @elmondhir!


stack-setup-2: nopie fixes for Arch, Gentoo, and Void Linux

[ ] Give people a bit of time to test before merging

Removes GHC <8.0.2 for all Linux -nopie builds, since those don't work
reliably.
Removes configure-env for all remaining Linux -nopie builds, since
GHC>=8.0.2 autodetects GCCs that support -no-pie (and the
configure-envs interfered with the auto-detection causing it to fail
on some distros)
Patches Linux GHC >= 8.0.2 bindists so that their configure
script detects Gentoo Hardened GCC and adds --no-pie
to linker arguments.
Adds ncurses6 GHC 8.2.2 bindist for Void Linux

Relates to commercialhaskell/stack#3518 commercialhaskell/stack#3636

How can I test it? Currently I use 8.0.2 in a 32-bit fork of Archlinux :) as the original ceased to support 32 bits. And I had to put nopie in config.yaml as Stack detected a non-existent flavour.

@nponeccop Via the setup-info flag - https://docs.haskellstack.org/en/stable/yaml_configuration/#setup-info
I haven't tried it, but this should work:
setup-info: "https://raw.githubusercontent.com/fpco/stackage-content/nopie-fixes-arch-gentoo/stack/stack-setup-2.yaml"

It says "unrecognized fields", so I'm updating my stack (which wasn't that outdated) to see.

The unrecognized fields are actually deprecated fields that only older versions of Stack use (these warnings are only shown if you override the location of the setup-info).  We've never built 32-bit tinfo6 bindists (It's such an uncommon case; I think you're the first person to ask), although we'd be happy to add them to the setup-info metadata if someone provides them.  I'm hoping the GHC release team starts building official tinfo6/ncurses6 bindists soon, given how many distros have upgraded (I think only Debian/Ubuntu

@borsboom nopie flavour works fine for me, see above. So don't bother. I wonder why it doesn't detect that it tries it. I think I have both libtinfo 5 and 6

The current version of Stack will only try the "most specific" bindist and won't fall back to others if it doesn't exist.  That's been improved in the master branch where it'll look for any bindist that should work on your system.

It's with master
stack --version
Version 1.7.0, Git revision 19e3460496f8fd2c462fb35a5825301e5c3c4eb0 (5518 commits) i386 hpack-0.20.0

You need commit acb196788948bab7a01e13cddf6e6cd5b5bf93a0.  I just merged that PR this morning.

Should I try it with this setup info or with the defaults?

Try it with this branch (although I suspect it won't make any difference)
On Dec 29, 2017 1:05 PM, "nponeccop"<EMAIL_ADDRESS>wrote:

Should I try it with this setup info or with the defaults?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fpco/stackage-content/pull/34#issuecomment-354500393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACEGJfoU5iZsTc3ZI-im5ilcnSe_NibCks5tFVP6gaJpZM4RNo6h
.

Having heard no objections, merging this.


feat: replaces noop store with memory store

Table of Contents

Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:

Description
This implements a basic memory store instead of noop.
Motivation and Context

When server-side rendering, having a noop store causes useExperiment calls to fail even if they were made after a emitter.defineVariants call.
How Has This Been Tested?

I've added tests to store.jsx to check if it could set and get items from it. The most important part is to delete window.localStorage and keep it working properly.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hey Gabriel, thank you for this!
There's another PR that it's adding a cookie storage for browsers that do not support window.localstorage: https://github.com/marvelapp/react-ab-test/pull/28
Just thinking about what could be the best way to support every scenario...this could a third fallback option?
Basically when localStorage and and cookieStorage are not available, which would be the case of node.js running without JSDOM, then we could fallback to memoryStorage...what do you think?

I think memoryStorage should be the last fallback option, indeed, since it's not persistent across navigation through pages.
In order to support multiple stores, we could introduce an interface like this (using typescript just to illustrate):
interface IStorage {
  isAvailable(): boolean;
  getItem(key: string): string | nul;
  setItem(key: string, value: string): vold;
}

So we could select storage like this:
const localStorageWrapper = {
  isAvailable() {
    // ...
  }
  getItem(key) { return localStorage.getItem(key) }
  setItem(key, value) { localStorage.setItem(key, value) }
}

const cookieStorageWrapper = {
  // ...
}

const memoryStorageWrapper = {
  values: {},
  isAvailable() { return true },
  getItem(key) { return this.values[key] },
  setItem(key, value) { this.values[key] = value }
}

// Ordered by preference
const storages = [
  localStorageWrapper,
  cookieStorageWrapper,
  memoryStorageWrapper
]

const availableStorage = storages.find((storage) => storage.isAvailable())
export default availableStorage;


[scanner] Exported fields typed interface result in an invalid schema

should interface{} get mapped to object? Currently, it doesn't provide a type so swagger editor lists it as null
CustomData interface{} `json:"custom_data"`
==============
 "custom_data": {
          "x-go-name": "CustomData"
        },

fixed by 74f252d


Add support for bats-file

Hai,
bats-file contains useful functions for testing particular characteristics of files, and noticed this extension didn't support highlighting aspects of it. I think it would useful adding support for those functions. Thoughts?
Edwin

Hi
For sure it would be useful, but I didn't had time to manage that.
Thank you for contributing, I'll gonna take a look.
Best