fix: Attachment - I'm navigated to about:blank after downloading a docx attachment.

Explanation of Change

Fixed Issues
$ https://github.com/Expensify/App/issues/52572
PROPOSAL: https://github.com/Expensify/App/issues/52572#issuecomment-2478266270
Tests

Open a report
Send a docx attachment
Tap on the download icon
Tap on "Download"
In mWeb safari, verify the new tab showing the download option is closed after download is started.
In all other platforms/browsers, verify the download alert is shown in the same tab and download is started.

[x] Verify that no errors appear in the JS console

Offline tests

Need interned connection

QA Steps

Open a report
Send a docx attachment
Tap on the download icon
Tap on "Download"
In mWeb safari, verify the new tab showing the download option is closed after download is started.
In all other platforms/browsers, verify the download alert is shown in the same tab and download is started.

// TODO: These must be filled out, or the issue title must include "[No QA]."

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Krishna2323 Any updates?

Do you have any other update?

Hmm yes, please raise a slack discussion, tag me and internal engineer, ty.

I think it's a bit technical, so let's ask Internal engineer first @Krishna2323


[FLINK-11928][Connectors / FileSystem]Create a Compression string writer for flink-connectors-filesystem

What is the purpose of the change
This pull request is to create a CompressedStringWriter which allows user to use it or its subclass to compressed the stream to filesystem.
Brief change log
(for example:)

A new compressed string writer is created to write compressed stream to file system

Verifying this change
This change added tests and can be verified as follows:

*Manually verified the change by running a compressed streaming job which sinks to HDFS by using 10-node flink on yarn.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented?  JavaDocs

There is a problem with closing operation:
2020-01-11 14:41:02
java.lang.RuntimeException: Exception occurred while processing valve output watermark:
	at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor$ForwardingValveOutputHandler.handleWatermark(StreamOneInputProcessor.java:216)
	at org.apache.flink.streaming.runtime.streamstatus.StatusWatermarkValve.findAndOutputNewMinWatermarkAcrossAlignedChannels(StatusWatermarkValve.java:189)
	at org.apache.flink.streaming.runtime.streamstatus.StatusWatermarkValve.inputWatermark(StatusWatermarkValve.java:111)
	at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processElement(StreamOneInputProcessor.java:169)
	at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:143)
	at org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:279)
	at org.apache.flink.streaming.runtime.tasks.StreamTask.run(StreamTask.java:301)
	at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:406)
	at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:705)
	at org.apache.flink.runtime.taskmanager.Task.run(Task.java:530)
	at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.flink.streaming.runtime.tasks.ExceptionInChainedOperatorException: Could not forward element to next operator
	at org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:654)
	at org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
	at org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
	at org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
	at org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
	at org.apache.flink.streaming.api.operators.TimestampedCollector.collect(TimestampedCollector.java:51)
	at flink.test.job.TestWindowFunction$.apply(TestJob.scala:83)
	at flink.test.job.TestWindowFunction$.apply(TestJob.scala:78)
	at org.apache.flink.streaming.api.scala.function.util.ScalaWindowFunctionWrapper.apply(ScalaWindowFunctionWrapper.scala:44)
	at org.apache.flink.streaming.runtime.operators.windowing.functions.InternalIterableWindowFunction.process(InternalIterableWindowFunction.java:44)
	at org.apache.flink.streaming.runtime.operators.windowing.functions.InternalIterableWindowFunction.process(InternalIterableWindowFunction.java:32)
	at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator.emitWindowContents(WindowOperator.java:549)
	at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator.onEventTime(WindowOperator.java:457)
	at org.apache.flink.streaming.api.operators.InternalTimerServiceImpl.advanceWatermark(InternalTimerServiceImpl.java:276)
	at org.apache.flink.streaming.api.operators.InternalTimeServiceManager.advanceWatermark(InternalTimeServiceManager.java:128)
	at org.apache.flink.streaming.api.operators.AbstractStreamOperator.processWatermark(AbstractStreamOperator.java:784)
	at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor$ForwardingValveOutputHandler.handleWatermark(StreamOneInputProcessor.java:213)
	... 10 more
Caused by: java.lang.IllegalStateException: Writer has already been opened
	at org.apache.flink.streaming.connectors.fs.StreamWriterBase.open(StreamWriterBase.java:69)
	at flink.test.sink.CompressionStringWriter.open(CompressionStringWriter.java:77)
	at org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink.openNewPartFile(BucketingSink.java:588)
	at org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink.invoke(BucketingSink.java:463)
	at org.apache.flink.streaming.api.functions.sink.SinkFunction.invoke(SinkFunction.java:52)
	at org.apache.flink.streaming.api.operators.StreamSink.processElement(StreamSink.java:56)
	at org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
	... 26 more

I had to fixed with (maybe there is a better solution for this):
    @Override
    public void close() throws IOException {
        if (compressedOutputStream != null) {
            compressedOutputStream.finish();
            compressedOutputStream = null;
        }

        try {
            super.close();
        } finally {
            if (compressor != null) {
                CodecPool.returnCompressor(compressor);
                compressor = null;
            }
        }
    }

whats the diference between this and compress format

Hi @ysn2233 , very thanks for the contribution and very sorry for the late response! However, since this PR targets at the compression writer for the BucketingSink and currently we are going to deprecated the BucketingSink with StreamingFileSink, and we also have already have the compression writer for the StreamingFileSink, do you think it is ok for us to first close this PR ?

I'm closing this as the code base has moved on quite a bit. As @gaoyunhaii said we actually want to drop the BucketingSink in the near future. Please re-open this if you feel otherwise and work should continue.


VALUES not returned properly

I have been using alexa together with cl-yacc for a compiler I've been writing. Yacc requires the lexer to return the token type and its value in the form of (VALUES token-type token-value). Thus, in my implementation, the alexa defined lexer emitted values in the form above. Since the last update, alexa fails to return the token value and only the token type is emitted, resulting in the compiler failing to do its job. As a workaround, I set the alexa generated lexer to emit cons cells with the token type and the token value, and a wrapper closure of it is given to the parser, which takes the cons cell and emits it in the VALUES form. All worked without needing this workaround until the last update. Just letting you know, in case it is a bug which you did not know of, and because yacc is mentioned as an example in your README file.

@orestarod Somehow I missed this. Thanks for reporting!


Can't install addon

I'm receiving the following messages when trying to install this addon on a new Hass.io box I'm building:
17-10-09 22:40:57 INFO (SyncWorker_5) [hassio.dock.addon] Start build d89827df/amd64-addon-homebridge:1.0.3
17-10-09 22:40:57 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 422, in start
    resp = yield from self._request_handler(request)
  File "/usr/lib/python3.6/site-packages/aiohttp/web.py", line 306, in _handle
    resp = yield from handler(request)
  File "/usr/lib/python3.6/site-packages/hassio/api/util.py", line 31, in wrap_api
    answer = await method(api, *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/hassio/addons/addon.py", line 466, in install
    if not await self.docker.install(self.last_version):
  File "/usr/lib/python3.6/site-packages/hassio/dock/util.py", line 18, in wrap_api
    return await method(api, *args, **kwargs)
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/hassio/dock/addon.py", line 198, in _install
    return self._build(tag)
  File "/usr/lib/python3.6/site-packages/hassio/dock/addon.py", line 211, in _build
    image = self.docker.images.build(**build_env.get_docker_args(tag))
  File "/usr/lib/python3.6/site-packages/docker/models/images.py", line 175, in build
    raise BuildError(chunk['error'])
docker.errors.BuildError: invalid reference format: repository name must be lowercase

What am I doing wrong?

Just tried to install on Ubuntu, same problem:
17-10-10 17:27:57 INFO (MainThread) [hassio.addons.git] Clone addon https://github.com/hassio-addons/addon-homebridge repository
17-10-10 17:27:57 INFO (MainThread) [hassio.addons] Load addons: 17 all - 1 new - 0 remove
17-10-10 17:28:02 INFO (MainThread) [hassio.addons.git] Pull addon https://github.com/home-assistant/hassio-addons repository
17-10-10 17:28:02 INFO (MainThread) [hassio.addons.git] Pull addon https://github.com/hassio-addons/addon-homebridge repository
17-10-10 17:28:03 INFO (MainThread) [hassio.addons] Load addons: 17 all - 0 new - 0 remove
17-10-10 17:28:06 INFO (MainThread) [hassio.addons.addon] Create Home-Assistant addon data folder /data/addons/data/d89827df_homebridge
17-10-10 17:28:06 INFO (SyncWorker_3) [hassio.dock.addon] Start build d89827df/amd64-addon-homebridge:1.0.3
17-10-10 17:28:06 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 422, in start
    resp = yield from self._request_handler(request)
  File "/usr/lib/python3.6/site-packages/aiohttp/web.py", line 306, in _handle
    resp = yield from handler(request)
  File "/usr/lib/python3.6/site-packages/hassio/api/util.py", line 31, in wrap_api
    answer = await method(api, *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/hassio/addons/addon.py", line 466, in install
    if not await self.docker.install(self.last_version):
  File "/usr/lib/python3.6/site-packages/hassio/dock/util.py", line 18, in wrap_api
    return await method(api, *args, **kwargs)
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/hassio/dock/addon.py", line 198, in _install
    return self._build(tag)
  File "/usr/lib/python3.6/site-packages/hassio/dock/addon.py", line 211, in _build
    image = self.docker.images.build(**build_env.get_docker_args(tag))
  File "/usr/lib/python3.6/site-packages/docker/models/images.py", line 175, in build
    raise BuildError(chunk['error'])
docker.errors.BuildError: invalid reference format: repository name must be lowercase

@frenck What packages do I need to have installed for this addon to work on a Debian amd64?

You have added https://github.com/hassio-addons/addon-homebridge as the add-on repository.
Please remove it and use https://github.com/hassio-addons/repository, as stated in the documentation of this add-on.

Oops!

Hehe don’t worry, stuff happens :)


Scan cannot find simulators in Xcode 16.0

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I've created a new Xcode project and added the following code to my Fastfile:
default_platform(:ios)

platform :ios do
  lane :test do
    scan(
      project: "FastlaneTest.xcodeproj",
      devices: ["iPhone 16 Pro"]
    )
  end
end

When I run the test lane against Xcode 16.0, I get the following error output:
[14:32:30]: Ignoring 'iPhone 16 Pro', couldn't find matching simulator
[14:32:30]: Couldn't find any matching simulators for '["iPhone 16 Pro"]' - falling back to default simulator

I've tracked this issue down to a version mismatch between the SDK version and the simulator version in Xcode 16.0:

The default_os_version method retrieves the SDK version and passes it to DeviceManager.runtime_build_os_versions. This method attempts to match the SDK version (22A3362) with the simulator version (22A3351), but fails because the versions do not match.
https://github.com/fastlane/fastlane/blob/2de8c8446bfa33d886536f2c1453955e597bbd7d/scan/lib/scan/detect_values.rb#L112
https://github.com/fastlane/fastlane/blob/2de8c8446bfa33d886536f2c1453955e597bbd7d/fastlane_core/lib/fastlane_core/device_manager.rb#L14
Complete output when running fastlane, including the stack trace and command used

 [14:41:48]: ------------------------------
[14:41:48]: --- Step: default_platform ---
[14:41:48]: ------------------------------
[14:41:48]: Driving the lane 'ios test' 🚀
[14:41:48]: ------------------
[14:41:48]: --- Step: scan ---
[14:41:48]: ------------------
[14:41:48]: Resolving Swift Package Manager dependencies...
[14:41:48]: $ xcodebuild -resolvePackageDependencies -scheme FastlaneTest -project FastlaneTest.xcodeproj
[14:41:50]: ▸ Command line invocation:
[14:41:50]: ▸     /Applications/Xcode-16.0.0.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -scheme FastlaneTest -project FastlaneTest.xcodeproj
[14:41:50]: ▸ User defaults from command line:
[14:41:50]: ▸     IDEPackageSupportUseBuiltinSCM = YES
[14:41:50]: ▸ resolved source packages:
[14:41:50]: $ xcodebuild -showBuildSettings -scheme FastlaneTest -project FastlaneTest.xcodeproj 2>&1
nil versions are discouraged and will be deprecated in Rubygems 4
[14:41:52]: Ignoring 'iPhone 16 Pro', couldn't find matching simulator
[14:41:52]: Couldn't find any matching simulators for '["iPhone 16 Pro"]' - falling back to default simulator
[14:41:52]: Found simulator "iPhone 13 Pro (15.5)"
+------------------------------------------------------------------------------------------------------------------------------------------+
|                                                         Summary for scan 2.222.0                                                         |
+------------------------------------------------+-----------------------------------------------------------------------------------------+
| project                                        | FastlaneTest.xcodeproj                                                                  |
| devices                                        | ["iPhone 16 Pro"]                                                                       |
| scheme                                         | FastlaneTest                                                                            |
| skip_detect_devices                            | false                                                                                |
| ensure_devices_found                           | false                                                                                |
| force_quit_simulator                           | false                                                                                |
| reset_simulator                                | false                                                                                |
| disable_slide_to_type                          | true                                                                                |
| reinstall_app                                  | false                                                                                |
| clean                                          | false                                                                                |
| open_report                                    | false                                                                                |
| output_directory                               | ./fastlane/test_output                                                                  |
| output_types                                   | html,junit                                                                              |
| buildlog_path                                  | ~/Library/Logs/scan                                                                     |
| include_simulator_logs                         | false                                                                                |
| xcodebuild_formatter                           | xcbeautify                                                                              |
| output_remove_retry_attempts                   | false                                                                                |
| derived_data_path                              | /Users/felix/Library/Developer/Xcode/DerivedData/FastlaneTest-bwxhtcnapwlereboqpwttbqm  |
|                                                | ursk                                                                                |
| should_zip_build_products                      | false                                                                                |
| output_xctestrun                               | false                                                                                |
| result_bundle                                  | false                                                                                |
| use_clang_report_name                          | false                                                                                |
| disable_concurrent_testing                     | false                                                                                |
| skip_build                                     | false                                                                                |
| slack_use_webhook_configured_username_and_icon | false                                                                                |
| slack_username                                 | fastlane                                                                                |
| slack_icon_url                                 | https://fastlane.tools/assets/img/fastlane_icon.png                                     |
| skip_slack                                     | false                                                                                |
| slack_only_on_failure                          | false                                                                                |
| run_rosetta_simulator                          | false                                                                                |
| xcodebuild_command                             | env NSUnbufferedIO=YES xcodebuild                                                       |
| skip_package_dependencies_resolution           | false                                                                                |
| disable_package_automatic_updates              | false                                                                                |
| use_system_scm                                 | false                                                                                |
| number_of_retries                              | 0                                                                                |
| fail_build                                     | true                                                                                |
| xcode_path                                     | /Applications/Xcode-16.0.0.app                                                          |
+------------------------------------------------+-----------------------------------------------------------------------------------------+
[14:41:52]: Disabling 'Slide to Type' iPhone 13 Pro
[14:41:52]: $ /usr/libexec/PlistBuddy -c "Add :KeyboardContinuousPathEnabled bool false" /Users/felix/Library/Developer/CoreSimulator/Devices/1AAD87BC-67DD-4E68-B81E-823410576F3B/data/Library/Preferences/com.apple.keyboard.ContinuousPath.plist >/dev/null 2>&1
[14:41:52]: $ set -o pipefail && env NSUnbufferedIO=YES xcodebuild -scheme FastlaneTest -project FastlaneTest.xcodeproj -derivedDataPath /Users/felix/Library/Developer/Xcode/DerivedData/FastlaneTest-bwxhtcnapwlereboqpwttbqmursk -destination 'platform=iOS Simulator,id=1AAD87BC-67DD-4E68-B81E-823410576F3B' build test | tee '/Users/felix/Library/Logs/scan/FastlaneTest-FastlaneTest.log' | xcbeautify
[14:41:52]: ▸ Loading...
[14:41:52]: ▸ ----- xcbeautify -----
[14:41:52]: ▸ Version: 2.11.0
[14:41:52]: ▸ ----------------------
[14:41:53]: ▸ 2024-09-19 14:41:53.519 xcodebuild[14556:3364128] Writing error result bundle to /var/folders/ms/lrk4_z852q595bcwwfh0ftcm0000gn/T/ResultBundle_2024-19-09_14-41-0053.xcresult
[14:41:54]: ▸ xcodebuild: error: Unable to find a destination matching the provided destination specifier:
[14:41:54]: ▸           { platform:iOS Simulator, id:1AAD87BC-67DD-4E68-B81E-823410576F3B }
[14:41:54]: ▸   Available destinations for the "FastlaneTest" scheme:
[14:41:54]: ▸           { platform:macOS, arch:arm64, variant:Designed for [iPad,iPhone], id:00006000-001205E42238801E, name:My Mac }
[14:41:54]: ▸           { platform:iOS, arch:arm64, id:00008110-000E182C1E43801E, name:iPad mini }
[14:41:54]: ▸           { platform:iOS, arch:arm64, id:00008101-000674C80E98001E, name:iPhone mini }
[14:41:54]: ▸           { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device }
[14:41:54]: ▸           { platform:iOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-iphonesimulator:placeholder, name:Any iOS Simulator Device }
[14:41:54]: ▸           { platform:iOS Simulator, id:9EBE88EB-B43C-439F-BDF6-C79C43DE51E0, OS:18.0, name:iPad (10th generation) }
[14:41:54]: ▸           { platform:iOS Simulator, id:9EBE88EB-B43C-439F-BDF6-C79C43DE51E0, OS:18.0, name:iPad (10th generation) }
[14:41:54]: ▸           { platform:iOS Simulator, id:5116FFA8-B50F-45EE-A62B-02467FE8C256, OS:18.0, name:iPad Air 11-inch (M2) }
[14:41:54]: ▸           { platform:iOS Simulator, id:5116FFA8-B50F-45EE-A62B-02467FE8C256, OS:18.0, name:iPad Air 11-inch (M2) }
[14:41:54]: ▸           { platform:iOS Simulator, id:BCCD7C77-BF2F-4E2D-89BB-CC32BBF9415C, OS:18.0, name:iPad Air 13-inch (M2) }
[14:41:54]: ▸           { platform:iOS Simulator, id:BCCD7C77-BF2F-4E2D-89BB-CC32BBF9415C, OS:18.0, name:iPad Air 13-inch (M2) }
[14:41:54]: ▸           { platform:iOS Simulator, id:060F47A1-B9D3-4A2F-A0F3-C23975130444, OS:18.0, name:iPad Pro 11-inch (M4) }
[14:41:54]: ▸           { platform:iOS Simulator, id:060F47A1-B9D3-4A2F-A0F3-C23975130444, OS:18.0, name:iPad Pro 11-inch (M4) }
[14:41:54]: ▸           { platform:iOS Simulator, id:D03E4F0B-3741-40E0-9420-5194A78874BB, OS:18.0, name:iPad Pro 13-inch (M4) }
[14:41:54]: ▸           { platform:iOS Simulator, id:D03E4F0B-3741-40E0-9420-5194A78874BB, OS:18.0, name:iPad Pro 13-inch (M4) }
[14:41:54]: ▸           { platform:iOS Simulator, id:7F9C7DEE-5EF9-4A03-AC5D-0453F4AC5D09, OS:18.0, name:iPad mini (6th generation) }
[14:41:54]: ▸           { platform:iOS Simulator, id:7F9C7DEE-5EF9-4A03-AC5D-0453F4AC5D09, OS:18.0, name:iPad mini (6th generation) }
[14:41:54]: ▸           { platform:iOS Simulator, id:DBA85C08-D27A-4DAA-96E2-D1A148D6C632, OS:18.0, name:iPhone 15 }
[14:41:54]: ▸           { platform:iOS Simulator, id:DBA85C08-D27A-4DAA-96E2-D1A148D6C632, OS:18.0, name:iPhone 15 }
[14:41:54]: ▸           { platform:iOS Simulator, id:1AD7239D-81E5-4B3D-9F07-71C1F37931BC, OS:18.0, name:iPhone 15 Plus }
[14:41:54]: ▸           { platform:iOS Simulator, id:1AD7239D-81E5-4B3D-9F07-71C1F37931BC, OS:18.0, name:iPhone 15 Plus }
[14:41:54]: ▸           { platform:iOS Simulator, id:E931629D-1562-4940-85BA-07C2728B9785, OS:18.0, name:iPhone 15 Pro }
[14:41:54]: ▸           { platform:iOS Simulator, id:E931629D-1562-4940-85BA-07C2728B9785, OS:18.0, name:iPhone 15 Pro }
[14:41:54]: ▸           { platform:iOS Simulator, id:E3ABF2B9-D949-4A4F-9FD6-C3A7A640E615, OS:18.0, name:iPhone 15 Pro Max }
[14:41:54]: ▸           { platform:iOS Simulator, id:E3ABF2B9-D949-4A4F-9FD6-C3A7A640E615, OS:18.0, name:iPhone 15 Pro Max }
[14:41:54]: ▸           { platform:iOS Simulator, id:32A021CE-E291-4C21-8A5C-B5C9644282B4, OS:18.0, name:iPhone 16 }
[14:41:54]: ▸           { platform:iOS Simulator, id:32A021CE-E291-4C21-8A5C-B5C9644282B4, OS:18.0, name:iPhone 16 }
[14:41:54]: ▸           { platform:iOS Simulator, id:F9557166-EEE6-4E64-8B48-842899847CDD, OS:18.0, name:iPhone 16 Plus }
[14:41:54]: ▸           { platform:iOS Simulator, id:F9557166-EEE6-4E64-8B48-842899847CDD, OS:18.0, name:iPhone 16 Plus }
[14:41:54]: ▸           { platform:iOS Simulator, id:9B502AE5-5C59-44F6-9B40-5EEFF4B41287, OS:18.0, name:iPhone 16 Pro }
[14:41:54]: ▸           { platform:iOS Simulator, id:9B502AE5-5C59-44F6-9B40-5EEFF4B41287, OS:18.0, name:iPhone 16 Pro }
[14:41:54]: ▸           { platform:iOS Simulator, id:BF669998-6B1B-4787-9673-4326B1C95F5F, OS:18.0, name:iPhone 16 Pro Max }
[14:41:54]: ▸           { platform:iOS Simulator, id:BF669998-6B1B-4787-9673-4326B1C95F5F, OS:18.0, name:iPhone 16 Pro Max }
[14:41:54]: ▸           { platform:iOS Simulator, id:C8A7E6A6-1B85-4BAF-A5CB-A988CD78D570, OS:18.0, name:iPhone SE (3rd generation) }
[14:41:54]: ▸           { platform:iOS Simulator, id:C8A7E6A6-1B85-4BAF-A5CB-A988CD78D570, OS:18.0, name:iPhone SE (3rd generation) }
----- xcbeautify -----
Version: 2.11.0
2024-09-19 14:41:53.519 xcodebuild[14556:3364128] Writing error result bundle to /var/folders/ms/lrk4_z852q595bcwwfh0ftcm0000gn/T/ResultBundle_2024-19-09_14-41-0053.xcresult
xcodebuild: error: Unable to find a destination matching the provided destination specifier:
{ platform:iOS Simulator, id:1AAD87BC-67DD-4E68-B81E-823410576F3B }
    Available destinations for the "FastlaneTest" scheme:
            { platform:macOS, arch:arm64, variant:Designed for [iPad,iPhone], id:00006000-001205E42238801E, name:My Mac }
            { platform:iOS, arch:arm64, id:00008110-000E182C1E43801E, name:iPad mini }
            { platform:iOS, arch:arm64, id:00008101-000674C80E98001E, name:iPhone mini }
            { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device }
            { platform:iOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-iphonesimulator:placeholder, name:Any iOS Simulator Device }
            { platform:iOS Simulator, id:9EBE88EB-B43C-439F-BDF6-C79C43DE51E0, OS:18.0, name:iPad (10th generation) }
            { platform:iOS Simulator, id:9EBE88EB-B43C-439F-BDF6-C79C43DE51E0, OS:18.0, name:iPad (10th generation) }
            { platform:iOS Simulator, id:5116FFA8-B50F-45EE-A62B-02467FE8C256, OS:18.0, name:iPad Air 11-inch (M2) }
            { platform:iOS Simulator, id:5116FFA8-B50F-45EE-A62B-02467FE8C256, OS:18.0, name:iPad Air 11-inch (M2) }
            { platform:iOS Simulator, id:BCCD7C77-BF2F-4E2D-89BB-CC32BBF9415C, OS:18.0, name:iPad Air 13-inch (M2) }
            { platform:iOS Simulator, id:BCCD7C77-BF2F-4E2D-89BB-CC32BBF9415C, OS:18.0, name:iPad Air 13-inch (M2) }
            { platform:iOS Simulator, id:060F47A1-B9D3-4A2F-A0F3-C23975130444, OS:18.0, name:iPad Pro 11-inch (M4) }
            { platform:iOS Simulator, id:060F47A1-B9D3-4A2F-A0F3-C23975130444, OS:18.0, name:iPad Pro 11-inch (M4) }
            { platform:iOS Simulator, id:D03E4F0B-3741-40E0-9420-5194A78874BB, OS:18.0, name:iPad Pro 13-inch (M4) }
            { platform:iOS Simulator, id:D03E4F0B-3741-40E0-9420-5194A78874BB, OS:18.0, name:iPad Pro 13-inch (M4) }
            { platform:iOS Simulator, id:7F9C7DEE-5EF9-4A03-AC5D-0453F4AC5D09, OS:18.0, name:iPad mini (6th generation) }
            { platform:iOS Simulator, id:7F9C7DEE-5EF9-4A03-AC5D-0453F4AC5D09, OS:18.0, name:iPad mini (6th generation) }
            { platform:iOS Simulator, id:DBA85C08-D27A-4DAA-96E2-D1A148D6C632, OS:18.0, name:iPhone 15 }
            { platform:iOS Simulator, id:DBA85C08-D27A-4DAA-96E2-D1A148D6C632, OS:18.0, name:iPhone 15 }
            { platform:iOS Simulator, id:1AD7239D-81E5-4B3D-9F07-71C1F37931BC, OS:18.0, name:iPhone 15 Plus }
            { platform:iOS Simulator, id:1AD7239D-81E5-4B3D-9F07-71C1F37931BC, OS:18.0, name:iPhone 15 Plus }
            { platform:iOS Simulator, id:E931629D-1562-4940-85BA-07C2728B9785, OS:18.0, name:iPhone 15 Pro }
            { platform:iOS Simulator, id:E931629D-1562-4940-85BA-07C2728B9785, OS:18.0, name:iPhone 15 Pro }
            { platform:iOS Simulator, id:E3ABF2B9-D949-4A4F-9FD6-C3A7A640E615, OS:18.0, name:iPhone 15 Pro Max }
            { platform:iOS Simulator, id:E3ABF2B9-D949-4A4F-9FD6-C3A7A640E615, OS:18.0, name:iPhone 15 Pro Max }
            { platform:iOS Simulator, id:32A021CE-E291-4C21-8A5C-B5C9644282B4, OS:18.0, name:iPhone 16 }
            { platform:iOS Simulator, id:32A021CE-E291-4C21-8A5C-B5C9644282B4, OS:18.0, name:iPhone 16 }
            { platform:iOS Simulator, id:F9557166-EEE6-4E64-8B48-842899847CDD, OS:18.0, name:iPhone 16 Plus }
            { platform:iOS Simulator, id:F9557166-EEE6-4E64-8B48-842899847CDD, OS:18.0, name:iPhone 16 Plus }
            { platform:iOS Simulator, id:9B502AE5-5C59-44F6-9B40-5EEFF4B41287, OS:18.0, name:iPhone 16 Pro }
            { platform:iOS Simulator, id:9B502AE5-5C59-44F6-9B40-5EEFF4B41287, OS:18.0, name:iPhone 16 Pro }
            { platform:iOS Simulator, id:BF669998-6B1B-4787-9673-4326B1C95F5F, OS:18.0, name:iPhone 16 Pro Max }
            { platform:iOS Simulator, id:BF669998-6B1B-4787-9673-4326B1C95F5F, OS:18.0, name:iPhone 16 Pro Max }
            { platform:iOS Simulator, id:C8A7E6A6-1B85-4BAF-A5CB-A988CD78D570, OS:18.0, name:iPhone SE (3rd generation) }
            { platform:iOS Simulator, id:C8A7E6A6-1B85-4BAF-A5CB-A988CD78D570, OS:18.0, name:iPhone SE (3rd generation) }

[14:41:54]: Exit status: 70
+------------------------------------------------------------------------------------------------------------------------+
|                                                      Lane Context                                                      |
+------------------------------+-----------------------------------------------------------------------------------------+
| DEFAULT_PLATFORM             | ios                                                                                |
| PLATFORM_NAME                | ios                                                                                |
| LANE_NAME                    | ios test                                                                                |
| SCAN_GENERATED_XCRESULT_PATH |                                                                                |
| SCAN_DERIVED_DATA_PATH       | /Users/felix/Library/Developer/Xcode/DerivedData/FastlaneTest-bwxhtcnapwlereboqpwttbqm  |
|                              | ursk                                                                                |
| SCAN_GENERATED_PLIST_FILES   | []                                                                                |
| SCAN_GENERATED_PLIST_FILE    |                                                                                |
+------------------------------+-----------------------------------------------------------------------------------------+
[14:41:54]: Called from Fastfile at line 5
[14:41:54]: [14:41:54]:     3:      platform :ios do [14:41:54]:     4:        lane :test do [14:41:54]:  => 5:          scan( [14:41:54]:     6:            project: "FastlaneTest.xcodeproj", [14:41:54]:     7:            devices: ["iPhone 16 Pro"] [14:41:54]:
[14:41:54]: Error building/testing the application. See the log above.
+---------------------------------------+
|           fastlane summary            |
+------+------------------+-------------+
| Step | Action           | Time (in s) |
+------+------------------+-------------+
| 1    | default_platform | 0           |
| 💥   | scan             | 5           |
+------+------------------+-------------+
[14:41:54]: fastlane finished with errors
[!] Error building/testing the application. See the log above.

Environment

 ✅ fastlane environment ✅
Stack

Key
Value

OS
15.0

Ruby
3.3.5

Bundler?
true

Git
git version 2.39.5 (Apple Git-154)

Installation Source
/opt/homebrew/lib/ruby/gems/3.3.0/bin/fastlane

Host
macOS 15.0 (24A335)

Ruby Lib Dir
/opt/homebrew/Cellar/ruby/3.3.5/lib

OpenSSL Version
OpenSSL 3.3.1 4 Jun 2024

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode-16.0.0.app/Contents/Developer/

Xcode Version
16.0

Swift Version
6.0

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
`./fastlane/Fastfile`
default_platform(:ios)

platform :ios do
  lane :test do
    scan(
      project: "FastlaneTest.xcodeproj",
      devices: ["iPhone 16 Pro"]
    )
  end
end

`./fastlane/Appfile`
# app_identifier("[[APP_IDENTIFIER]]") # The bundle identifier of your app
# apple_id("[[APPLE_ID]]") # Your Apple Developer Portal username

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.222.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

error_highlight
0.6.0

did_you_mean
1.6.3

syntax_suggest
2.0.0

bundler
2.5.19

pathname
0.3.0

rake
13.2.1

base64
0.2.0

nkf
0.2.0

rexml
3.3.7

CFPropertyList
3.0.7

public_suffix
6.0.1

addressable
2.8.7

artifactory
3.0.17

atomos
0.1.3

aws-eventstream
1.3.0

aws-partitions
1.977.0

aws-sigv4
1.10.0

jmespath
1.6.2

aws-sdk-core
3.206.0

aws-sdk-kms
1.91.0

aws-sdk-s3
1.163.0

babosa
1.0.4

claide
1.1.0

colored
1.2

colored2
3.1.2

highline
2.0.3

commander
4.6.0

declarative
0.0.20

digest-crc
0.6.5

domain_name
0.6.20240107

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.111.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.4.1

faraday-multipart
1.0.4

faraday-net_http
1.0.2

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.3

http-cookie
1.0.7

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.3.1

gh_inspector
1.1.3

jwt
2.9.0

multi_json
1.15.0

os
1.1.4

signet
0.19.0

googleauth
1.8.1

httpclient
2.8.3

mini_mime
1.1.5

trailblazer-option
0.1.2

uber
0.1.0

representable
3.2.0

retriable
3.1.2

google-apis-core
0.11.3

google-apis-androidpublisher_v3
0.54.0

google-apis-playcustomapp_v1
0.13.0

google-cloud-env
1.6.0

google-apis-iamcredentials_v1
0.17.0

google-apis-storage_v1
0.31.0

google-cloud-errors
1.4.0

google-cloud-core
1.7.1

google-cloud-storage
1.47.0

json
2.7.2

mini_magick
4.13.2

naturally
2.2.1

optparse
0.5.0

plist
3.7.1

rubyzip
2.3.2

security
0.1.5

simctl
1.6.10

terminal-notifier
2.0.0

unicode-display_width
2.6.0

terminal-table
3.0.2

tty-screen
0.8.2

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.3.0

xcodeproj
1.25.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

generated on: 2024-09-19

@FelixLisczyk: We had this issue too and was able to resolve it by specifying the OS version as well like this devices: ["iPhone 16 Pro (18.0)"]. Hope this helps you as well, it worked for us :smile:

We've been having this same issue since upgrading to Xcode 16.0 (16A242d) except we generate new simulators with a unique name. Here's an example:
fastlane:
xcrun simctl create 'IOS-TESTS-JOB3-8575 2024-09-20 03:46:50 iPhone-15 iOS-18-0' 'com.apple.CoreSimulator.SimDeviceType.iPhone-15' 'com.apple.CoreSimulator.SimRuntime.iOS-18-0'
Created simulator for com.apple.CoreSimulator.SimDeviceType.iPhone-15 18.0 with id: 60CA4E09-20E2-4924-95EE-B36FF32CAE1B

If then run xcrun simctl list devices on this machine, that new sim is in the list:
IOS-TESTS-JOB3-8575 2024-09-20 03:46:50 iPhone-15 iOS-18-0 (60CA4E09-20E2-4924-95EE-B36FF32CAE1B) (Shutdown)

fastlane however says
Ignoring 'IOS-TESTS-JOB3-8575 2024-09-20 03:46:50 iPhone-15 iOS-18-0', couldn't find matching simulator

We have made no changes to our Fastfile and this exact setup was working perfectly until we upgraded from Xcode 16 RC1 to 16.0. Instantly after, fastlane stopped being able to select a sim that it just created.

@FelixLisczyk: We had this issue too and was able to resolve it by specifying the OS version as well like this devices: ["iPhone 16 Pro (18.0)"]. Hope this helps you as well, it worked for us 😄

Yes, this is likely a better solution than modifying the Fastlane source code. Thank you! 👍
@vercordio Have you tried specifying the iOS version number in your Fastfile, for example, IOS-TESTS-JOB3-8575 2024-09-20 03:46:50 iPhone-15 iOS-18-0 (18.0)?

@FelixLisczyk Yeah we've tried several variations that included the version like (18.0) and the device name without the hyphen, to no avail. Thanks for the suggestion!

For all users of GitHub Actions: it looks like this issue only occurs with macos-14 image version 20240922.1 while with image version 20240918.8 it works fine. Since GitHub just started rolling out image version 20240922.1 an increasing number of our builds is failing.
Looking at the diff between the two image version I cannot find anything that looks like it might trigger a change in behavior though 🤔

specifying the OS version as well like this devices: ["iPhone 16 Pro (18.0)"]

This workaround seems to work here 🎉

I've tracked this issue down to a version mismatch between the SDK version and the simulator version in Xcode 16.0

I guess this issue will just go away then once Xcode 16.1 is released, will it not?

I'm having this issue on fastlane snapshot as well.
Adding (18.0) to the end of the devices string did not work for me. And using Xcode 16.1 beta did not fix it for me either.
Finally the following command failed:
ios_version="\"18.0\"" && \
fastlane_path="/opt/homebrew/lib/ruby/gems/3.3.0/gems/fastlane-2.223.1" && \
sed -i '' "s/Gem::Version.new(FastlaneCore::DeviceManager.runtime_build_os_versions\[runtime_build\])/${ios_version}/" "${fastlane_path}/scan/lib/scan/detect_values.rb"
sed: /opt/homebrew/lib/ruby/gems/3.3.0/gems/fastlane-2.223.1/scan/lib/scan/detect_values.rb: No such file or directory

Any ideas on how to fix this?

I guess this issue will just go away then once Xcode 16.1 is released, will it not?

This issue occurs only when the SDK and simulator versions do not match. It's unclear if this is a one-time problem with Xcode 16.0. We will know more once the final version of Xcode 16.1 is released.

Finally the following command failed:

Please verify the path to your fastlane installation by using the command which fastlane.

@FelixLisczyk
which fastlane
/opt/homebrew/bin/fastlane

So I changed the fastlane path and it still doesn't work:
ios_version="\"18.0\"" && \
fastlane_path="/opt/homebrew/bin/fastlane" && \
sed -i '' "s/Gem::Version.new(FastlaneCore::DeviceManager.runtime_build_os_versions\[runtime_build\])/${ios_version}/" "${fastlane_path}/scan/lib/scan/detect_values.rb"
sed: /opt/homebrew/bin/fastlane/scan/lib/scan/detect_values.rb: Not a directory

Maybe I'm just completely missing something obvious?

I've updated the command to dynamically retrieve the Fastlane path. Could you please test it?
ios_version="\"18.0\"" && \
fastlane_path=$(gem which fastlane | sed 's|/fastlane/lib/fastlane.rb||') && \
sed -i '' "s/Gem::Version.new(FastlaneCore::DeviceManager.runtime_build_os_versions\[runtime_build\])/${ios_version}/" "${fastlane_path}/scan/lib/scan/detect_values.rb"

If it still doesn't work, find the following line in your Fastlane installation and change it to "18.0".
https://github.com/fastlane/fastlane/blob/2de8c8446bfa33d886536f2c1453955e597bbd7d/scan/lib/scan/detect_values.rb#L150

@FelixLisczyk Ok tried that. This is the command that didn't fail:
ios_version="\"18.0\"" && \
fastlane_path="/opt/homebrew/Cellar/fastlane/2.223.1/libexec/gems/fastlane-2.223.1" && \
sed -i '' "s/Gem::Version.new(FastlaneCore::DeviceManager.runtime_build_os_versions\[runtime_build\])/${ios_version}/" "${fastlane_path}/scan/lib/scan/detect_values.rb"

However when running fastlane snapshot still getting an error:
xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ platform:iOS Simulator, OS:18.0, name:iPhone 16 }

Maybe I need to create a new issue for that. But this looked like the same issue as that. Kinda looking like it might be a different issue now.

Yes, this appears to be a separate issue. I only encounter the error message when using the scan utility. There is no error message when using snapshot on my Mac, even without applying the fix.

"iPhone 16 Pro (18.0)"

Great solution, thank you 🙌

@FelixLisczyk: We had this issue too and was able to resolve it by specifying the OS version as well like this devices: ["iPhone 16 Pro (18.0)"]. Hope this helps you as well, it worked for us 😄

Great solution, thank you 🙌.

It seems the problem is gone with the Xcode 16.1 RC, so there's no need to work around it using a specific simulator version.

Can confirm the issue is gone when using Xcode 16.1 for us in combination with macOS 15, no need for workarounds anymore.

I still have that issue even on Xcode 16.1 and with macOS 15. I've tried the devices: ["iPhone 16 Pro (18.0)"] methode and specify it with destination, with the target simulator booted or not, and i still stubble on :
xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ platform:iOS Simulator, id:712833E2-D8B6-4696-8323-5C742D99B530 }


[Update Snap] Push

Checklist
All items in the list below needs to be satisfied.

[ ] Is the summary of the change documented in this ticket?
[ ] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted?
[ ] If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.
[ ] The corresponding pull request in this repo has been merged.

The updated version is<EMAIL_ADDRESS>1.1.12

The changes are here: https://github.com/ethereum-push-notification-service/push-protocol-snaps/tree/fix/take-down-cronjobs

This update disables the snooze feature and changes  some of the API URLs


Translate /docs/reference/setup-tools/kubeadm/kubeadm.md in Korean.

문서를 번역했습니다. 리뷰 부탁드리겠습니다.
from #17355
/language ko

/remove-language en
/remove-language id
/remove-language zh

/assign @daminisatya

/aasign @gochist

/assign @gochist

@reung37 Thank you!

When translating the file in content/en into Korean, please place the file in content/ko directory.
Please match the branch where you added the commit and the base branch to dev-1.16-ko.4. FYI, dev-1.16-ko.4 will be freeze at Nov 04 KST.

If you have any question, feel free to contact me(june.yi) on the K8s slack channel #kubernetes-docs-ko.
/hold


[FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

What is the purpose of the change
Pass undelrying configuration option to SavepointEnvironment to configure IOManager.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@tzulitai could you look at this.

Fixed in
Master: 7934fc04ac098e2143cab9459b216725fe1b8be6
release-1.11: ce10080de0e6c35d60147318381c096cf77ec252
release-1.10: 313051c0ffdacb1bca2d26482bd9bc7036bf9fd2


How do we want to implement mesh stretching (for the cubed sphere mesh)?

While the P4estMesh supports local mesh refinement and AMR, this can be problematic for complex simulations like the baroclinic instability. There, well-balanced errors make the simulation on a vertically non-conforming mesh unusable. Unfortunately, the P4estMesh doesn't support only horizontal refinement (yet?).
A simple way to avoid the problem of non-conforming meshes is to stretch the cubed sphere mesh smoothly towards the area that is to refine. A mapping for this is described here. This mapping is also used by FV3, the dynamical core of the Global Forecast System by the National Weather Service of the United States.

I already implemented this feature for Trixi:

However, now there's the question of how to include this feature in the API. Do we want to write this mapping into the P4estMesh constructor for cubed spheres and add a kwarg to set the stretching factor? Or do we want to allow passing arbitrary functions to transform the cubed sphere? In this case, do we want to add this option to the HOHQMesh constructor as well?

First of all, it's great to see that you're continuing the discussion (and implementation!) on this topic! My initial thought regarding your questions is to implement it in the simplest, probably more specific way (i.e., only for CS meshes), until something similar is needed for general meshes. Once someone has a second application for this kind of stretching, we already have two examples and it might be easier to get the API for general transformations right the first time.

OTOH, StructuredMesh and the structured P4estMesh constructor already support passing arbitrary mappings.

Also, while the stretching itself could be easily added as a kwarg to the constructor (stretch_factor=x), this stretch mapping only stretches the mesh towards the south pole. Then, the sphere has to be rotated to move the refined area to where it should be.

At first sight, I would say that it would be great to pass arbitrary mappings to transform the cubed sphere. Then, the current mapping of course works, but it would be possible to try out other things as well. Mappings are very powerful and cool to play around with (as you have demonstrated quite impressivley with this simulation).


Extend Required enumeration with DisallowDefault

We have a JSON contract that contains a GUID parameter.  This parameter value is required, and must be none empty GUID.
We can use DisallowNulls to cause a deserialization failure when null is provided, but we still need to have manual checks for != Guid.Empty everywhere in order to make sure invalid requests don't get through.
The same applies for other simple types such as int, or enum where non-null isn't enough to indicate validity.
Is there a reason that DisallowDefault doesn't exist?  Is there an easier workaround than manally checking?

You couldn't have DisallowNull and DisallowDefault at the same time. The default value for Guid? is null.

Using a Guid? still just prevents the user from passing in null.  They can still pass in Guid.Empty.
For many scenarios, DisallowDefault should not conflict with DisallowNull.  It's only if you're using DefaultValue attributes that you might want to to be explicit about it.   If this is something that many people end up requiring you could have DisallowNull, DisallowDefault, DisallowNullAndDefault.

My point is DisallowDefault on Guid? would just prevent null. Guid.Empty is not the default value of Guid?
I'm happy with the current functionality. Additional validation can be done either in the property or using serialization events.


Adding time zone to xmltv file

Is your feature request related to a problem? Please describe.
My source xmltv file does not have a time zone added to the start and stop time in the xml. Now the guide of Plex is 1 hour of since it assumes it is UTC (the Netherlands is +1). See more info:
https://forums.plex.tv/t/tv-guide-1-hour-off/536012
xmltv
http://d52255a1.static.ziggozakelijk.nl/xmltv.xml
Describe the solution you'd like
Edit or add a timezone to a channel or source xmltv file. This can be done with something like this:
$xml_ziggo  = simplexml_load_file('http://d52255a1.static.ziggozakelijk.nl/xmltv.xml');

foreach ( $xml_ziggo->programme as $programme ) {
    $programme['start'] = $programme['start'].' -0100';
    $programme['stop'] = $programme['stop'].' -0100';
}
echo $xml_ziggo->asXML();

(source: https://stackoverflow.com/questions/49217566/add-time-offset-in-epg-xmltv-file)

xTeVe reads the "clock" on the device it's installed on...If you change this you are accomplishing the same result.

I downloaded your EPG, it does have start and stop times in it........
 ![image](https://user-images.githubusercontent.com/6390898/73611064-a3e68200-45a3-11ea-94f7-25c77b6caf3e.png)

Yes it is sloppy. I fixed it by running a stript on my server which copies the EPG xml file (once a day) and creates a new one with the time zone ' +0100':
<?php

$xml_ziggo  = simplexml_load_file('http://d52255a1.static.ziggozakelijk.nl/xmltv.xml');

foreach ( $xml_ziggo->programme as $programme ) {
    $programme['start'] = $programme['start'].' +0100';
    $programme['stop'] = $programme['stop'].' +0100';
}

$xml_ziggo->saveXML('/tmp/ZiggoXMLTV.xml');
?>

We discussed it on Discord, might be something we could add to xTeVe like Simple client in Kodi does....
https://cdn.discordapp.com/attachments/465980714278715412/673567316289650698/unknown.png

xTeVe should not have the task of fixing errors that the provider makes. The XMLTV specification stipulates that the time zone must be specified.
http://wiki.xmltv.org/index.php/XMLTVFormat


allow model with tags and animation to be exported

Also possible to export an empty model for mapping purposes, sometimes we need an empty model to use with a script mover made out of brushes or other things.

I'm sure len cannot produce values below 0, so this becomes always-false condition, and effectively only suppresses warning. What's the purpose of this change?


[HIP] Adds support for creating devices

Progress towards #15790

The lastest API doc marks the majority of the context management APIs as deprecated, with some exceptions like hipDevicePrimaryCtxRetain. Not sure that's intentional or just a bug in the doc. Could you ask internally to clarify regarding this aspect? And also regarding primary context management (is it really needed with hipDevicePrimaryCtxRelease doing nothing?) And what is the expected way to manage context in general, with a bunch of APIs deprecated without telling what to use instead?

The lastest API doc marks the majority of the context management APIs as deprecated, with some exceptions like hipDevicePrimaryCtxRetain. Not sure that's intentional or just a bug in the doc. Could you ask internally to clarify regarding this aspect? And also regarding primary context management (is it really needed with hipDevicePrimaryCtxRelease doing nothing?) And what is the expected way to manage context in general, with a bunch of APIs deprecated without telling what to use instead?

You're right that most context API's are deprecated except a handful like hipDevicePrimaryCtxRetain, hipDevicePrimaryCtxRelease (https://docs.amd.com/projects/HIP/en/latest/.doxygen/docBin/html/group___context.html)
As for the reasoning and ways to manage context going forward, the documentation recommends using stream and device APIs.

yeah we don't want the runtime API - it adds extra baggage - sounds like they just want people to use that in HIP land vs actually having deprecated things?

yeah we don't want that, so we'll want to go back to the context ones (they can never remove those, so it's not deprecated in the sense of "don't use these because they won't work/will be removed)

I've replaced the device call with context. I'll follow up internally on these "deprecated" context API calls to make sure they're supported in future releases

yeah we don't want the runtime API - it adds extra baggage - sounds like they just want people to use that in HIP land vs actually having deprecated things?

Per the doc, in HIP there is no clear separation of driver vs runtime APIs. So I suspect we might be seeing the runtime API (in CUDA's sense) overhead in HIP anyway. From the doc it seems Ctx APIs are just sugar over other APIs, but there are always suprises. :) Worth digging into the details and pick folks' brains internally to understand in depth. @nithinsubbiah please make sure this is tracked and investigated.


draft: add Reth node bindings

Motivation

Closes https://github.com/alloy-rs/alloy/issues/1062
Solution

Adds reth node bindings and reth to the Github workflow for tests
PR Checklist

[x] Added Tests
[x] Added Documentation
[ ] Breaking changes

@mattsse I'm running into some issues with reth not closing in a similar way geth and anvil are and I'm not sure whether it is related to the way I'm spawning the binary or how Reth waits for ctrl-c. Is this something you could have a look at?
To run the relevant test: cargo test --package alloy-node-bindings --lib -- nodes::reth::tests::can_launch_reth --show-output

Github workflow for installing Geth and Reth binary is now fixed, cancelled the last workflow because the test doesn't end.


Reenable transitions when getThumbBoundsFn is provided

It looks like this was changed in the partial incorporation of dimsemenov/PhotoSwipe#1455, and is an improvement when the image isn't transitioning back to a thumbnail, but the existing version was better in cases with thumbnails. When a getThumbBoundsFn function is provided, the image doesn't snap back to the centre of the screen, and the transition works just fine.

Hey and thanks for your suggestion. I'll think about it 👍

Duplicate of https://github.com/andi34/PhotoSwipe/issues/6


Add e2e tests for basic Prometheus functionalities.

Our test coverage is really poor, especially in main.go. We just have regression which was easy to find... if we had any test there.
I would propose adding tests using the e2e framework we maintain as Thanos & Cortex maintainers. You can see an example test in Thanos project.
It allows a very quick spin-up of Prometheus in the form of docker container (and needed dependencies if needed) and running all needed APIs etc (e.g Snapshots) and asserting certain expectation (AND Prometheus metric values!). I would also propose a separate e2e test using Github actions as we do in Thanos to make sure it's parallel to the rest of the tests. (:

IMO high priority.

We do have e2e for query log

And they do not have the overhead of docker.

Sure, whatever that will make sense (:  Can you link the e2e tests that you have in mind? I might miss that.
However, docker overhead does not matter and is a small downside vs what it gives. And it gives a huge win - process isolation (no more leaked processes), network isolation and allows to test our docker image build as well. cc @pracucci

https://github.com/prometheus/prometheus/blob/master/cmd/prometheus/query_log_test.go

As part of the bug scrub this appears to be a duplicate of #3689


Add Dominican Republic Spanish (es-do)

It's basically the same as the es locale except for 12-hour clock rather than 24-hour clock.

@Pephers thanks, will merge in next release.

@ichernev Thanks a lot!

Merged in 961e27729f1ccf94c63d1d95c7653e440eababb1


Support timeouts for geohash queries

Looks good, but looks like it has merge conflicts.  Can you resolve these first?

Done


C#: Error_Collection is not generated to C#

We introduced an un-modeled Error structure, Error_Collection.
We currently only generate in Dafny code.
But we should also generate a C# allegory and conversion logic for this.

There is potentially a deeper issue here: the CollectionOfErrors concept, like opaque errors, is not modeled at the Smithy level, so it's hard to know what the idiomatic representation of it is in a given target language.

This has been addressed via https://github.com/smithy-lang/smithy-dafny/pull/262


Remove unnecessary imports in updateHostsFile.py

Title is self-explanatory.

Tested in Python 2.7 and Python 3.5.1.
Awesome.  Thanks @gfyoung!


NavPay on Android Loading Indefinitely at Splash Screen

My Phone is Infinix Hot Note X551, currently running Android 5.1.
Is it probably because my phone's running an uncompatible OS?

Android 5.1 is a reasonably old version. From what i understand the source we forked from should be compatible with Android 4.2 and upwards. We will try to compile with the 4.2 SDK during the next release.

I have the same problem with a Samsung Galaxy S III Neo, Android 4.4.2 Phone.
And it would be very nice if Jellybean users would be able to download it (5-6% of Android users are still using it).


Add nullability specifiers to all 'id responseObject' parameters

This PR is a follow-up to the discussion + PR happening at #4296, and building/running/adding tests appears to be dependent on #4329.
These changes add __nullable specifiers to each location id responseObject appears in a method or closure signature, which should alleviate the Swift-Objc interop issues identified in the first PR referenced above.
I'm relatively new to Objc (mostly work in Swift), so please let me know if this is overkill or misses something big - tried to make the smallest number of changes I could while covering everything.
Once the Podfile update PR goes through I'll rebase to get those changes, make sure the existing tests pass, etc. I wasn't sure the best way to add tests for these changes, since they don't change any logic and are instead compiler-related...I could add some basic request tests made in Swift, potentially? But I'm not sure how one would gracefully fail the test if the changes don't work, since they currently just result in an unhandleable crash.
Opening this now so that once the above PRs are done, this will hopefully be ready shortly thereafter. Looking forward to hearing your thoughts. Thanks!

Hey all, just wanted to check in post-holidays and see if anyone might be available to take a look at this?
Thanks so much!

Hey all, just wanted to check in post-holidays and see if anyone might be available to take a look at this?
Thanks so much!

this fixes a very nasty bug. thank you.

Can you merge in the latest changes from the 2.x branch? Tests are now passing on CI!

@SlaunchaMan just did (still novice working with multiple remotes, but I think it went correctly?).
Fingers crossed for Travis!

Also, thanks for taking this back up! Got sidetracked over the holidays and this ended up pretty far down my backlog.

🎉 Tests are indeed passing on CI!

Thanks for the merge, @SlaunchaMan.
Should I just keep an eye out for a 2.7 release, or are there other things I can do to help?

Thanks, this is released now!


⚠ PrivateHD has degraded performance

In ff693af, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2816 ms

Resolved: PrivateHD performance has improved in 05f6243.


feat: add lastSyncTimestamp to GetInfo rpc endpoint

Motivation
Provide more visibility into hub sync state.
Change Summary
Add lastSyncTimestamp to the GetInfo rpc endpoint.
Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] PR title adheres to the conventional commits standard
[x] PR has a changeset
[ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
[x] PR includes documentation if necessary.
[x] All commits have been signed

PR-Codex overview
This PR introduces a new lastSyncTimestamp field to the HubInfoResponse message in various files for tracking the time of the last successful sync operation.
Detailed summary

Added lastSyncTimestamp field to HubInfoResponse message
Updated message.ts, server.ts, test files, and generated files
Implemented getLastSyncTimestamp method in SyncEngine class

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

At some point we should also update the peers gRPC endpoint to return the peer id per peer. Not related to this PR, just musing

Closing due to age. If this is still relevant let's reopen and rebase. Thanks!


Update to 3.20200123.0

The basics

[ ] I branched from develop
[ ] My pull request is against develop
[ ] My code follows the style guide

The details
Resolves

Proposed Changes

Reason for Changes

Test Coverage

Tested on:

Documentation

Additional Information

Manual merge


[TE] build - cut down CI build time

First attempt for cutting down on frontend build time

same issue lol

Q: How to speed up you Ember build?
A: Disable any and all parallelism


Some shortcuts not working on Mac with external keyboard

VSCode Version: 1.21.2
OS Version: macOS High Sierra 10.13.4

Steps to Reproduce:

Open code
Press OS button + `

Does this issue occur when all extensions are disabled?: Yes
Some more background: I'm using a MacBook Pro with a Logitech MK710 keyboard and mouse combo. The keyboard is mapped successfully with the OS and all system shortcuts works just as well as they do with the laptop's built-in shortcuts.
There are issues with some VSC shortcuts though, for example, i can still use the shortcut for opening a new file, but i the shortcut for opening a new terminal doesn't work (if i use the external keyboard, it works with the built-in keyboard)

@borisyordanov can you follow https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-mac-keybindings please?

Thanks to everyone for trying to help, @alexandrudima was right - the `OS +`` shortcut doesn't work, because it's not the correct shortcut!


Blue selection box not aligned properly in Drafts

There is a gap between the blue selection box and the selected message in the drafts UI. There should be no space at the top or on the left between the blue box and the header bar/message.

@zulipbot claim


Fix leading zeros in parser.etw.core.Guid.str

In the last section of the str method for the Guid class, string padding to the correct hex length is not performed.
If you are comparing a guid which requires zero padding, e.g. *-d312ba227f03, this method will NOT include the 0, causing it to be *-d312ba227f3 (missing zero at the end). If you want to compare string-representations of GUIDs, this code segment will cause you problems.
The fix is simple, in the string-ify operation, simply force the hex character to be printed as exactly two characters, so that zero is always included

Thanks a lot !!!

Thank you for implementing this library! :)


scaleio - libstorage still depends on having scaleio sdc installed

polly exits with status 1 if scaleio sdc isn't installed
# polly service status
● polly.service - polly
   Loaded: loaded (/etc/systemd/system/polly.service; static; vendor preset: disabled)
   Active: inactive (dead)

May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="libstorage.embedded=false"
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="libstorage.executor.disabledownload=false"
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="isilon.datasubnet="
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="scaleio=map[apiVersion:2.0 insecure:true userName:admin password:sCaleIO2016 systemName:scaleio protectio
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="libstorage.integration.volume.operations.create.default.size=16"
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="libstorage.integration.volume.operations.create.default.fstype=ext4"
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="libstorage.logging.stdout="
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="libstorage.logging.httprequests=false"
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="error dialing libStorage service" host="tcp://localhost:7980" inner="exit status 1"
May 23 11:31:11 sol polly[19248]: time="2016-05-23T11:31:11-07:00" level=error msg="service initialization failed" error.host="tcp://localhost:7980" error.inner.Stderr=[]

@akutz This is happens when the Polly (libstorage server/client) is running on a system that has not been installed as an SDC. I wonder if this could be related to https://github.com/emccode/libstorage/issues/151.
This doesn't sound exactly the same, but in terms of the instanceID validation, it could be similar. Are we missing the correct erroring here to get us the right verbosity?

Hi @clintonskitson,
Well, debugging is certainly not enabled here, and that would help. Could someone enable debug logging and reproduce the error?
Please see the libStorage documentation section on adjusting logging or simply set this environment variable - export LIBSTORAGE_LOGGING_LEVEL=debug.

Also, based on the issue filed above, it appears the example is using SystemD to show logging. Can the example be reproduced outside SystemD as SystemD sometimes decides to omit what it considers redundant log information?

Closing out this thread. The updated configuration to address the scenario where clients can be of type integration or controller.
libstorage:
  client:
    type: controller


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 09:24:29 on 2023.04.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 19857
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=19857

Problem has been resolved in 3m 0s at 09:27:29 on 2023.04.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 19857


[mesheryctl] Neither -v or --version returns the CLI version number

Description
-v, --version are global flags that should return the version of mesheryctl. Neither flag returns this information, however, mesheryctl version does.
Expected Behavior
Either flag should return the same information as does mesheryctl version

But sir @leecalcote according to this pr https://github.com/layer5io/meshery/pull/653
mesheryctl -v has output verbatim that of /mesheryctl version.

@leecalcote  sir, should we use -v for version checking which is global used for verbose mode?

@leecalcote sir, I have doubt that do we need to replace mesheryctl version by mesheryctl --version?

@gunjanmimo we could, but supporting all three methods is simple enough and makes it convenient for users who may not recall precisely which command to use.

In the future, it may be the case the the -v is reserved for verbose mode.

ok, sir, I will add both --version and -v option. This will be helpful

But sir @leecalcote i guess -v is already supported as the pr landed by anirudhjain shows
https://github.com/layer5io/meshery/pull/653

@ashiscs Oh, I missed that. The output was hidden in my terminal buffer. In this case, the update that we need here is to remove the help output (see below) and simply display the version info.
~ mesheryctl -v

Client Version: 0.3.11
Server Version: 0.3.11
GitSHA:2f20e18af829df593b94a670fa70c62d80a5344e

Meshery is the service mesh management plane, providing lifecycle, performance, and configuration management of service meshes and their workloads.

Usage:
  mesheryctl [command]

Available Commands:
  cleanup     Clean up Meshery
  help        Help about any command
  logs        Print logs
  pref        Performance testing and benchmarking
  start       Start Meshery
  status      Check Meshery status
  stop        Stop Meshery
  update      Pull new Meshery images from Docker Hub.
  version     Version of mesheryctl

Flags:
      --config string   config file (default location is: $HOME/.meshery/config.yaml)
  -h, --help            help for mesheryctl
  -t, --toggle          Help message for toggle
  -v, --version         Version of mesheryctl

Use "mesheryctl [command] --help" for more information about a command.


Support for minItems,  uniqueItems, etc

Is your feature request related to a problem? Please describe.
These are currently listed under the future section of the README, but it is unclear if there is an existing timeline with some work being done on them, or if there are any ongoing discussions, or identified difficulties regarding  implementing these features.
https://github.com/swaggo/swag/blob/master/README.md#future
Describe the solution you'd like
It would be great to have a more information about when/if these are planned, what any issues might be, and a record of any discussion about how they might be implemented.

Actualy, this is an OpenSource software and most of the developers are contributing if they need the feature and they have some spare time to write the actual implementation. According to this, a fair answer is somehere in the near future.
On the other hand, If you look over all open issues you may notice there are some small bugs that require an urgent fix and everyone is waiting for someone to fix.


Milestones Are not working

Problem Description
Changing the milestones below in ./github/settings.yml has no effect on either existing milestones or new milestones and there are no new milestones created.
# Milestones: define milestones for Issues and Pull Requests
milestones:
  - title: bot-milestone-title
    description: bot-milestone-description
    # The state of the milestone. Either `open` or `closed`
    state: open

What is actually happening
Changing the milestones below in ./github/settings.yml has no effect on either existing milestones or new milestones and there are no new milestones created.
What is the expected behavior
It should have some effect to start with.
Error output, if available

Context
Are you using the hosted instance of probot/settings or running your own?
Yes.
If running your own instance, are you using it with github.com or GitHub Enterprise?
Github Enterprise
Version of probot/settings
latest.
Version of GitHub Enterprise
GitHub Enterprise Server 2.20.0

We are using Github enterprise. and Discover specific information is redacted.
This is what i see in the logs. After seeing this error, i copied the settings.yml from here --> https://github.com/probot/settings/blob/master/README.md
And still see the same issue.
15:01:52.853Z ERROR probot:
| Invalid request.
  |
  | "branch", "enforce_admins", "required_pull_request_reviews", "required_status_checks", "restrictions" are not permitted keys.
  | --
  | HttpError: Invalid request.
  |
  | "branch", "enforce_admins", "required_pull_request_reviews", "required_status_checks", "restrictions" are not permitted keys.

from the error, it looks like the problem is unrelated to milestones, but more likely branch protection. do you have details about branch protection in the same  settings.yml file? if there is a failure before the call to configure milestones, the overall run would be aborted, which would explain why you are not seeing the milestones updates that you expect.

closing since there has been no response to my questions, so i'm assuming the problem has been resolved. please feel free to re-open if there are still issues

We are encountering the same issue with the default configuration from this repository. Any news?

thanks for the feedback @thomasklinger1234. i have not been investigating since it appeared above that an unrelated error was preventing the app from getting to the point of applying the milestone changes.
i've been taking a few steps to enable myself to more easily confirm functionality like this and confirmed in this commit that they are indeed not being added.
now that i know that this is a true problem, i will try to find time to dig in further and understand what is causing the problem

thanks for the feedback @thomasklinger1234. i have not been investigating since it appeared above that an unrelated error was preventing the app from getting to the point of applying the milestone changes.
i've been taking a few steps to enable myself to more easily confirm functionality like this and confirmed in this commit that they are indeed not being added.
now that i know that this is a true problem, i will try to find time to dig in further and understand what is causing the problem

Glad to hear the good news! Thanks for investigating :)


[WIP- do not merge] CR10 -> master

Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues

Fixes #[issue number here]

Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.
Documentation
The set of community facing docs that have been added/modified because of this change

Closed to merge https://github.com/celo-org/celo-monorepo/pull/10690 instead


[feat]: "New Changes" badge on config and properties rows on the service to indicate when data has changed but has not been seen yet.

Prerequisites

[X] I have searched for existing issues that already suggest this feature, without success.

Describe the Feature Request
Display a badge/icon when there is a change in the config or properties page made by another process, and the user has not opened that config or properties page to see it yet.
Describe the Use Case
When this service (A) changes the config/properties of another service (B), It would be useful for a user to be able to identify that the change was made when they navigate to the other service (B).
Describe Preferred Solution
A colorful circular badge (green or red) on the same row as the page that contains the changed data.
This badge would disappear when the user opens the page to view the changed data.
Describe Alternatives
The badge could be placed inside the config page similar to the 'changed' tag displayed when a config is changed during the "Needs Config" process.
Anything else?
No response

This should already be something for config. I'm not sure what a properties "change" would be, or rather, what constitutes "changed but not seen"

If service A makes a change to service B, the user must approve this change beforehand.
If a new version of a service introduces new Config options, these are already displayed as "New", and the user must save the config.
If a new version of a service introduces new Properties, there is no indication, nor is there an easy way to track whether or not he user has seen these new Properties. I do not see much value in building out this infra, as the newly added Properties (or just the fact that new Properties were added) can be included in the release notes. Closing.


Added a link to the Sagemaker post

Instead of maintaining here a separate set of instructions for Sagemaker, we're pointing to the blog post so we just maintain that.

Since these links point back to mongodb.com, I suggest using label which will add the utm codes defined in the configuration.


Organized process needed for verifying FST regression performance

Every time we update the FST for itwêwina (e.g. in #370 and #384), we run the regression tests in the FST repo: https://github.com/UAlbertaALTLab/plains-cree-fsts/blob/91dd870539d7e84599291f1ba859dc59430f31a7/test/run-tests
Since sometimes the changes to the FST can cause these regression tests to fail, we need an organized process by which such deviations are reported to and verified by a linguist.
An example could be the string nipayan getting some unexpected analyses due to spell-relax allowing for prefix-final vowels being dropped before the subsequent morpheme, as well as leaving out the normative hyphen at the morpheme boundary - see below:
hfst-lookup -q ../../src/analyser-gt-desc.hfst
nipayan
nipayan	nipâw+V+AI+Cnj+Prs+1Sg	0.000000
nipayan	nipâw+V+AI+Cnj+Prs+2Sg	0.000000
nipayan	pê-ayâw+V+AI+Ind+Prs+1Sg	0.000000
nipayan	PV/pe+ayâw+V+AI+Ind+Prs+1Sg	0.000000
nipayan	PV/pe+ayâw+V+TI+Ind+Prs+1Sg	0.000000

In the above, the three analyses with the preverb pê- (and the feature PV/pe-) are ones that were not originally specified in the regression tests, but which the FST now outputs, and this behavior is in accordance with the FST design. But it shouldn't be left solely to the developers to figure out whether this is correct behavior or not.
So, should we have a designated linguist or few who are (automatically) notified when regression test deviations are encountered?

@atticusha 👀


Cannot use examples in p5 web editor

Trying to use the examples in the p5 web editor I constantly get an error:
Error: SecurityError: requestDevice() called from cross-origin iframe.
the examples code work fine if I run them locally.

I had the same issue. I think this has to do with increased security from the browser.
You can still run in locally with something like VS Code and run on a local website with the Live Server extension, but it would be great to use it as before.


Fix WAF Table of Contents link

Needs immediate fixing or thousands may contract carpal tunnel from scrolling.

Thank you, there's no telling how many wrists you've saved with this commit.


feat(nargo): Add --exact flag to nargo test

Description

Problem*

Resolves #2271
Summary*

This adds the --exact flag to nargo test which allows us to select tests based on an exact name. I also refactored the code to make it more clear which tests we were selecting and fixed problems with running tests in the vscode plugin inside a workspace (relies on https://github.com/noir-lang/vscode-noir/pull/29)
Documentation

[x] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[x] I will request for and support Dev Rel's help in documenting this PR.

The --exact flag needs to be documented on the nargo test command.
Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Is this going into v0.10.0? Seems that it wasn't automatically added into https://github.com/noir-lang/noir/pull/2039?

Is this going into v0.10.0? Seems that it wasn't automatically added into #2039?

#2039 is only updated when something is merged into master, its represents the current version that we have not released yet


Unexpected behavior in assignment of fixed point variables initialized with a 2D list

The following code produce a result that is not what I expect using 2D lists.
Trying to update an element of my 2D list does not succeed
Equivalent code works correctly in case of 1D list
Is this the expected behavior?
In case it is, what is the suggested way of coding the intended behavior?
>>> y = Fxp(dtype='fxp-s6/2')
>>> y([[1.0,0.25,0.5],[0.25,0.5,0.25]])

>>> y[0][0] = y[0][0]+1.0
>>> y[0][0]
fxp-s6/2(1.0)

The operation is correctly performed, but the assignment is not
>>> y[0][0]+1.0
fxp-s6/2(2.0)

Fxp returns a new Fxp when you do an indexing. So, doing y[i][j] you get a new Fxp with y[i] and then index the last one with j.
When you're getting values there are no problems because you're getting a new object with the value you need, but when you're setting values, concatenated indices will set values over new object and not over original one.
y[1][2] = 3.0
# it's equivalent to:
y_new = y[1]
y_new[2] = 3.0

You should use multiple indexing at the same time (all indices between [ ]), then:
y[0,0] = y[0,0] + 1.0

should work!

I appreciate very much the prompt and clear explanation!
Indeed your suggestion works and it's the best practice also for numpy arrays as I just learned on  https://numpy.org/doc/stable/user/basics.indexing.html
If we compare the behavior of Fxp with numpy arrays, the latter operate differently and the copied object is pointing to the same memory contents. So for a numpy array, creating y_new and assigning a new value would also change the original y
This discrepancy in behavior might be confusing for users, so if technically possible you might evaluate whether to change this in future. Nonetheless your comment solved my issue and made me learn something new on Fxp and numpy arrays indexing. Thanks!

I'm glad I could help you!
You're right about functionality. It's in the development plan to implement the view functionality instead of copy, but it is no quite straight forward. Thanks for do the observation!

I close the issue considering it solved in version 0.4.8.
y[0][0] = y[0][0] + 1.0

Now it's working!


partially fixed the feed. Images still don't appear but will be fixed…

… soon

Looks good Taylor! You can go ahead with merging!


Fixed index.js delimeter logic

Since the code is suggesting using only $ - $ for inline, $$ - $$ for block math syntax,
specific delimiter for $ - $ and $$ - $$ is required, not general escape logic.
also it will fix the issue #2.

Some code optimization and variable name change was done.

I found that 'throwOnError:false' option doesn't actually work on katex. They will still throw an error if the syntax is invalid.
So instead of sending this directly, I fixed this code to catch the error internally, return the original latex token, and log it on the console when throwOnError option is explicitly set to true.

Thanks! Looking this over now!

Writing some unit tests that cover current behaviour, so we can ensure nothing will break here.
I'm excited about the patch for throwOnError. I'm hoping we can get some of those fixes pushed upstream.

According to the new tests (adapted from markdown-it-math), this does fix #2, but it also breaks the following:
Display math self-closes at the end of document
.
$$
1+1 = 2
.
<math><semantics><mrow><mn>1</mn><mo>+</mo><mn>1</mn><mo>=</mo><mn>2</mn></mrow><annotation encoding="application/x-tex">1+1 = 2
</annotation></semantics></math>1+1=2
.

Going to look through the code and see if this is an easy fix.

Okay, I missed that test things.
I had ignored the rules '4 indents are code block' and 'opening $$ tag closes itself if there's no closing $$ tag in the end of any line after', just thinking those are no need to be here, I removed those.
Therefore, in this commit, changes of optimization and new logic of escaping inline $ sign would be vaild.

My inline escaping is based on following regular expression:
(?<!\\)(?:((?<!\$)\$(?!\$)))([^\n\r]+)(?<!\\)(?(1)(?<!\$)\1(?!\$))
If only javascript regexp interpreter has a lookbehind options.

Okay, I think I've got fixes for the broken stuff. Merging. :tada:


Do not optimize regexps with begin/end text anchors inside

I've added another fuzz test and found several issues related to how we optimize regexps when they contain the being/end text anchors inside. In the main version, we always remove being/end text anchors and we treat the regexp like if there were no anchors because of the assumption that any regex is anchored in Prometheus (which is true).
However, removing the begin/end text anchors from inside is not always safe. For example, if we remove the anchor from ^|x, the resulting optimization is different because the empty string in one case is valid, while in the other case it's not.
After some experimentation, I found very difficult to correctly handle all begin/end text anchors, so in this PR I propose to not optimize a regexp if it contains them, unless they're really at tbe begin/end of the whole regexp.
I'm a bit sad with this PR because we may stop optimizing some regexps which were already correctly handled. Alternative, may be keep leaving with the bug in main, assuming customers don't run regexps like the absurd ones written by the fuzzy test.
I've run both fuzzy tests for few minutes and, with the changes in this PR, they don't report any more issue. However, it's also true that with the changes in this PR, a bunch of regexps generated by the fuzzy test are not optimized anymore.

I think we should aim for 100% correctness, so this change LGTM.

However, it's also true that with the changes in this PR, a bunch of regexps generated by the fuzzy test are not optimized anymore.

This surprises me, as fuzzier shouldn't keep trying things that are not interesting. I checked the fuzzier again, and we have statically defined regexs matching on fuzzied values.
I think we need to fuzz the regexps too.
I added this fuzzier:
func FuzzFastRegexMatcher_WithFuzziedRegexpsAndValues(f *testing.F) {
	for _, re := range regexes {
		for _, v := range values {
			f.Add(re, v)
		}
	}

	f.Fuzz(func(t *testing.T, re, val string) {
		m, err := NewFastRegexMatcher(re)
		if err != nil {
			return // Not interesting
		}
		require.Equalf(t, m.re.MatchString(val), m.MatchString(val), "regexp: %s val: %s", m.re.String(), val)
	})
}

And it failed after 3s with:
            	Error:      	Not equal:
            	            	expected: false
            	            	actual  : true
            	Test:       	FuzzFastRegexMatcher_WithFuzziedRegexpsAndValues
            	Messages:   	regexp: ^(?:(?-s:.)*\A0)$ val: 00000000


instance-operator: add label to oauth2 deploy

Description
This PR adds a label to the generation of the oauth2 objects by the instane-operator. This will be used as a selector for the "exam-mode" network policies
How Has This Been Tested?

[X] Unit testing
[X] Staging environment

/deploy-staging

/deploy-staging

/merge

/merge


Delay in navigating through the verses in 1.0

Compared to 0.9 release, there is a delay of at least 4-5 seconds  for each of the verse while navigating through the verses from the top navigation.
v1.0.0 build 1c04778

I second this, in whatever version is on 31.03.20222, it takes up to 10 secs to load a verse.


remove epochs_erm in matchdg

Codecov Report

Merging #188 (c119559) into master (4a13e3e) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   94.81%   95.25%   +0.43%
==========================================
  Files         124      124
  Lines        4149     4148       -1
==========================================
+ Hits         3934     3951      +17
+ Misses        215      197      -18

Flag
Coverage Δ

unittests
95.25% <100.00%> (+0.43%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

domainlab/algos/compos/matchdg_args.py
100.00% <100.00%> (ø)

domainlab/algos/compos/matchdg_ctr_erm.py
95.87% <100.00%> (+1.03%)
:arrow_up:

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Test cases for failing to rebuild with the async daemon

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Jordan466 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@Jordan466 Looks to be the quite the same as https://github.com/JasperFx/marten/pull/1970

@Jordan466 Looks to be the quite the same as #1970

Similar. @Hawxy is trying to demonstrate that the async daemon hangs when it receives a null
These tests are demonstrating that the daemon hangs when CreateEvent<T> uses either an interface or abstract base class.
There are no nulls in this case.

@Jordan466 Thanks for the details, it adds a lot more clarity. Quick note, async daemon unit tests are not included as part of CI due to random flakiness.

Failing test in this PR are included in https://github.com/JasperFx/marten/pull/1970. Closing this one.


Bump beancount-parser version

beancount-parser had been bumped to version 0.1.23 (https://github.com/LaunchPlatform/beancount-parser/commit/c9ec3ba02c00266d549fa830b9ca1bd4bc901b0d), resolving some parsing failures. It would be nice to bump the beancount-black version as well.

done, now latest beancount-black supports and also requires 0.1.23 or above


Improvement: make the colored circles in SiteTree navigation optional

Nice work on this module, works great out of the box.
One thing that would make me even like it more, is to have an option to hide the colored circles in the sitetree with pages.
Would be nice to make this optional by a YML-setting for instance.

Hello @baukezwaan
Thanks for the feed back, yeah we  were actually looking at to create a new report with those warnings. And your suggestion is good to add a flag to switch them on or off via a config.
A question for you, do you think a checkbox field for site config would be much easier than a YML ?
Cheers
Nivanka

I would say a yml-flag would be sufficient.
But if you want to go wild, a permission would be te most configurable option. You can give the groups you like the permission to see the circles...
However, now I think about it... The admin would still see the circles, and no way to hide them. So YML would be more in place for our situation.

@baukezwaan its been 2 years. This this is sorted now on the dev-master