Using EntityFramework 6.2 model store breaks filtering

Version <IP_ADDRESS>

Entity framework 6.2 beta introduces a new feature that caches the compiled models; when using this feature "OnModelCreating" is not called.
From: https://blogs.msdn.microsoft.com/dotnet/2017/05/23/announcing-ef-6-2-beta-1/

I was able to get this to work through some "hacks" to the code, but I am curious as to what you think a full solution should be.
I had to mark DynamicFilterDefinition as public, and [Serializable]. The predicate expression would need to be serialized through another mechanism- perhaps a string and using System.Linq.Dynamic.  The attribute name also needed to be left as just "DynamicFilter" for the following portion to work.
We have a class that inherits from "DbConfiguration" and in the constructor we can call
SetMetadataAnnotationSerializer("DynamicFilter", () => new DynamicFilterSerializer());
See "Non-String Annotations" from https://entityframework.codeplex.com/wikipage?title=Code First Annotations
DynamicFilterSerializer is just a simple wrapper around a binary formatter and base64 string. This will make entityframework rebuild the DynamicFilterDefinition object when it recreates the compiled model from the store.
Finally this allows us to reinitialize the filters through another hack  like so:
public OurContext(string sqlConnectionString) : base(sqlConnectionString)
{
var mb = new DbModelBuilder();
mb.ResetDynamicFilters();
mb.Filter(DELETED_EVENT_FILTER_NAME, (Type e) => e.IsRemoved, false);
mb.Filter(DELETED_TRAIT_FILTER_NAME, (Type t) => t.IsRemoved, false);
mb.Filter(DELETED_RESOURCE_FILTER_NAME, (Type r) => r.IsRemoved, false);
}
OnModelCreating must still exist for when it has to be compiled the first time.
I am willing to do the legwork on this and submit a pull request but am curious as to the approach you would like to see for this before I committed to some code.

Hello @mcnallys ,
Thank you for letting me know.
I will try to check if I can find another solution on my side this weekend.
Best Regards,
Jonathan

Hello @mcnallys ,
I must probably do something wrong. I'm not able to reproduce it and my OnModelCreating is invoked every time.
The compiled model is also in the output directory Z.Lab.Form_Request_CompiledModels+EntityContext.edmx so I guess I don't have everything wrong.
Do you think you could provide me a full example or edit the following one?
using System.Data.Entity;
using System.Data.Entity.Infrastructure;
using System.IO;
using System.Linq;
using System.Windows.Forms;
using EntityFramework.DynamicFilters;

namespace Z.Lab
{
    public partial class Form_Request_CompiledModels : Form
    {
        public enum EnumValue
        {
            None,
            A,
            B,
            C
        }

        public Form_Request_CompiledModels()
        {
            InitializeComponent();

            // CLEAR
            using (var ctx = new EntityContext())
            {
                ctx.EntitySimples.RemoveRange(ctx.EntitySimples);
                ctx.SaveChanges();
            }

            // SEED
            using (var ctx = new EntityContext())
            {
                ctx.EntitySimples.Add(new EntitySimple {ColumnString = "Z", ColumnEnum = EnumValue.None});
                ctx.EntitySimples.Add(new EntitySimple {ColumnString = "z", ColumnEnum = EnumValue.A});
                ctx.EntitySimples.Add(new EntitySimple {ColumnString = "a", ColumnEnum = EnumValue.None});
                ctx.SaveChanges();
            }

            // TEST
            using (var ctx = new EntityContext())
            {
                var list = ctx.EntitySimples.ToList();
            }
        }

        [DbConfigurationType(typeof(MyDbConfiguration))]
        public class EntityContext : DbContext
        {
            public class MyDbConfiguration : DbConfiguration
            {
                public MyDbConfiguration() : base()
                {
                    this.SetModelStore(new DefaultDbModelStore(Directory.GetCurrentDirectory()));
                }
            }

            public EntityContext() : base("CodeFirstEntities")
            {

            }

            public DbSet<EntitySimple> EntitySimples { get; set; }

            protected override void OnModelCreating(DbModelBuilder modelBuilder)
            {
                modelBuilder.Filter("WithEnum", (EntitySimple d) => d.ColumnEnum == EnumValue.None);

                modelBuilder.Types().Configure(x => x.ToTable(GetType().DeclaringType != null ? GetType().DeclaringType.FullName.Replace(".", "_") + "_" + x.ClrType.Name : ""));

                base.OnModelCreating(modelBuilder);
            }
        }

        public class EntitySimple
        {
            public int ID { get; set; }

            public int ColumnInt { get; set; }
            public string ColumnString { get; set; }

            public EnumValue ColumnEnum { get; set; }
        }
    }
}

Best Regards,
Jonathan

Help us to support this library: Donate

Thanks for getting back to me, it seems like you have it implemented correctly. The only difference I see is that we construct ours with a sql connection string. I will take your example code and try it out in the next few days.

I had time to look at your example, if you run the application once and let it create the file it will call onmodelcreating for that run.   Run the application again and you will see the behavior of the model  being created - where onmodelcreating does not get called.

Hello @mcnallys ,
Thank you, I will give another try this weekend.
I did as you instructed and the onmodelcreating was still called every time. Perhaps I'm missing something.
Best Regards,
Jonathan

Help us to support this library: Donate

https://drive.google.com/open?id=1YYGqb2Do0oh8j6tip_AvLKhO4I7beSzE
Download that and place a break point in onmodelcreating,
it will hit a few times for the first run.
Close the application, debug again.  The breakpoint should not hit.

Hello @mcnallys ,
I probably made my test wrong the first time, I can easily reproduce the issue.
Unfortunately, I don't think this request could be made. We have looked a lot at it.
The main problem is EF DynamicFilters is adding some conventions to make the filter work. Since the model is stored already in a file, the OnModelCreating and all custom conventions are no longer required and called.
We tried some solutions but none of them seem to work.
Unfortunately, I believe this library will not be compatible with the DefaultDbModelStore ;(

Help us to support this library: Donate

I had basic support working, for simple one property soft delete cases, full on other linq statements were another matter.  I cannot guarantee a timeline but I can try to get a PR put together that will solve some of it.

Sure ;) It may give us some idea how to more easily support it by inspiring ourself from your solution

Hi @mcnallys did you figure out a more permanent fix? We've hit this issue with caching a large context. Thanks

I have not had time to take a look at getting a cleaner implementation yet. It may be weeks or months before I am able to get back to it.

Do you think you could provide me a war implementation of what you have done so far?
<EMAIL_ADDRESS>It's fine if that's not very clean, at least it will give me a rough idea of how we could do it.
Best Regards,
Jonathan

Help us to support this library: Donate

Slapped together what i have as a war pull request, let me know what other information you need.
Thanks!

any update on this issue?

Hi meywd,
Unfortunately this is not a priority for my company at the moment. I can consult with taking my PR further; the last conversation I had with Jonathan was that implementing this were everyone could use it would be difficult.

@mcnallys Thank you for your effort, we have been using this library for 2 years, and suddenly, after adding a couple of classes to our model, EF decided its enough and we started getting timeouts on our APIs, implementing the model store fixed the performance but now all filters are ignored, the only solution I can think of is removing the library and rebuilding all the queries, which is going to a be a pain

Hello @meywd ,
Do you think you could provide your model at<EMAIL_ADDRESS>Next month, we are supposing to check if there is anything we can do about the initial load. Having more model that takes a long time might always help.
Depending on the investigation, we might re-visit this issue or try to simply make our own Model Store logic that doesn't EF DynamicFilters libraries.

@meywd We use multiple EF models in our solution, is that an option for you?

@JonathanMagnan, Thank you, unfortunately since its not a personal project I can't share it, Although it's not a huge model, around 80-90 entities.
@mcnallys All the entities are related, with many complex queries with multiple joins, I can't separate them without breaking the queries, it would need a redesign

No problem,
We will try with the model that people already submitted us. For example, one of them take 4s before the ToList() on empty tables completed the execution. I guess if we fix this one, we will fix pretty much all others one
As said, we should start next month to look at it. So if you want, if we didn't provide any answer yet, just reply to this thread at the end of April to get a status.

Is there any way to add filters programmatically on demand, even as a hack?

Hello @meywd ,
There is certainly a way, but none that I'm aware at this moment.

We're also running into this issue. This was quite the gotcha! Until this was identified as the issue, it seemed like the filters were only working sometimes. As it turns out, it was only working when/if the persistent store was invalidated.


feat(core): Refactored core codebase & added tests

Refactored codebase to be able to be functional
Added tests to test the functionality of the core codebase (#5)
Included pre-commit for auto-formatting and checking (#6)
Update pyproject.toml by moving torch and numpy to dev-dep

cc: @xiurobert

LGTM overall


backup fails on pvc's "error creating snapshot" in AKS cluster

What steps did you take and what happened:
I followed the exact same steps for two clusters.  One worked and one didn't.  After running all the installation and deployment of the yamls, the first initial backup fails at the steps to backup PersistentVolumeClaims.
ark backup create
Error from backup logs is:
backup=heptio-ark/nexsys-prod error="error creating snapshot: rpc error: code = Unknown desc = azure.BearerAuthorizer#WithAuthorization: Failed to refresh the Token for request to https://management.azure.com/subscriptions/50b308c6-62f8-47a1-8932-663bde48dc53/resourceGroups/MC_eus2-prod-infrastructure-rg_nexsys-eus2-prod-aks_eastus2/providers/Microsoft.Compute/disks/kubernetes-dynamic-pvc-4f21a407-d22c-11e8-827e-12827ba1213e?api-version=2016-04-30-preview: StatusCode=0 -- Original Error: adal: Refresh request failed. Status Code = '401'" group=v1 groupResource=pods logSource="pkg/backup/item_backupper.go:209" name=prometheus-k8s-db-prometheus-k8s-1 namespace=monitoring
What did you expect to happen:
Backup should succeed on the snapshot of the PVC.
The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other pastebin is fine.)

kubectl logs deployment/ark -n heptio-ark
https://gist.github.com/johnjbateman/a0f1492b90756367209c036e6c274bf8

ark backup describe <backupname> or kubectl get backup/<backupname> -n heptio-ark -o yaml
`apiVersion: ark.heptio.com/v1
kind: Backup
metadata:
creationTimestamp: 2018-12-04T15:38:27Z
generation: 1
name: nexsys-prod
namespace: heptio-ark
resourceVersion: "8407075"
selfLink: /apis/ark.heptio.com/v1/namespaces/heptio-ark/backups/nexsys-prod
uid: a498b3ad-f7da-11e8-968f-46fe7194455f
spec:
excludedNamespaces: null
excludedResources: null
hooks:
resources: null
includeClusterResources: null
includedNamespaces:

'*'
includedResources: null
labelSelector: null
storageLocation: ""
ttl: 720h0m0s
volumeSnapshotLocations: null
status:
completionTimestamp: 2018-12-04T15:38:45Z
expiration: 2019-01-03T15:38:27Z
phase: Failed
startTimestamp: 2018-12-04T15:38:27Z
validationErrors: null
version: 1
volumeSnapshotsAttempted: 0
volumeSnapshotsCompleted: 0`

ark backup logs nexsys-prod | grep kubernetes-dynamic-pvc
https://gist.github.com/johnjbateman/e97172e0fbff46dd02c8a402767252a4

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
AKS in Azure
Separate SPN's, Subscriptions, Resource Groups, and Clusters for the backup that worked and that didn't.  But same Tenant.
I have selected the AZURE_RESOURCE_GROUP as the MC_ group and the backup is in that same resource group
The SPN was a contributor to the subscription and it didn't work.  Upgraded to owner of the subscription and that still doesn't work.
Environment:

Ark version (use ark version):

Not Working: Version: v0.10.0 (also tried Version: v0.9.0 and it didn't work)
Working: Version: v0.9.0

Kubernetes version (use kubectl version):

Not Working: Version: 1.11.3
Working: Version: 1.11.2

Kubernetes installer & version: N/A
Cloud provider or hardware configuration: AKS (managed)
OS (e.g. from /etc/os-release): Linux Ubuntu 16.04

These are the steps I followed.  I don't know how I could have typo'd:
AZURE_CLIENT_SECRET=`az ad sp create-for-rbac --name "heptio-ark-prod" --role "Contributor" --query 'password' -o tsv`

AZURE_PRINCIPAL_NAME="heptio-ark-prod"
AZURE_RESOURCE_GROUP=MC_eus2-prod-infrastructure-rg_nexsys-eus2-prod-aks_eastus2

AZURE_STORAGE_KEY=`az storage account keys list \
    --account-name $AZURE_STORAGE_ACCOUNT_ID \
    --resource-group $AZURE_BACKUP_RESOURCE_GROUP \
    --query '[0].value' \
    -o tsv`

AZURE_SUBSCRIPTION_ID=`az account list --query '[?isDefault].id' -o tsv`
AZURE_TENANT_ID=`az account list --query '[?isDefault].tenantId' -o tsv`

# Reset and capture password for service credential
AZURE_CLIENTSECRET=`az ad sp credential reset --name "$AZURE_PRINCIPAL_NAME" --years 0 --query 'password'_ -o tsv`

AZURE_CLIENT_ID=`az ad sp list --display-name "$AZURE_PRINCIPAL_NAME" --query '[0].appId' -o tsv`

kubectl create secret generic cloud-credentials \
    --namespace heptio-ark \
    --from-literal AZURE_SUBSCRIPTION_ID=${AZURE_SUBSCRIPTION_ID} \
    --from-literal AZURE_TENANT_ID=${AZURE_TENANT_ID} \
    --from-literal AZURE_RESOURCE_GROUP=${AZURE_RESOURCE_GROUP} \
    --from-literal AZURE_CLIENT_ID=${AZURE_CLIENT_ID} \
    --from-literal AZURE_CLIENT_SECRET=${AZURE_CLIENT_SECRET} \
    --from-literal AZURE_STORAGE_ACCOUNT_ID=${AZURE_STORAGE_ACCOUNT_ID} \
    --from-literal AZURE_STORAGE_KEY=${AZURE_STORAGE_KEY}

I just saw this:
--query 'password'
Is the word 'password' a literal?  Should that be an actual password?

No, it's correct as 'password' - that tells az that you want it to output just the password from the returned data.

OK, thank you.  I checked the values in the secret, and I see they look fine.  I don't know what else to check:
Name:         cloud-credentials
Namespace:    heptio-ark
Labels:       <none>
Annotations:  <none>

Type:  Opaque

Data
====
AZURE_TENANT_ID:           36 bytes
AZURE_CLIENT_ID:           36 bytes
AZURE_CLIENT_SECRET:       36 bytes
AZURE_RESOURCE_GROUP:      59 bytes
AZURE_STORAGE_ACCOUNT_ID:  15 bytes
AZURE_STORAGE_KEY:         88 bytes
AZURE_SUBSCRIPTION_ID:     36 bytes

I echo'd out the values of those variables and they look right.  for the AZURE_CLIENT_SECRET, where can I verify that?  in Azure AD?

FWIW, a previously reported similar issue: #269.
You wrote above that the subscription is different in the one that's failing. AFAIK, AZURE_SUBSCRIPTION_ID=az account list --query '[?isDefault].id' -o tsv` will always return the same subscription. Can you confirm that you have the subscription correct?

@johnjbateman in https://github.com/heptio/ark/issues/1110#issuecomment-444176578, the first line sets AZURE_CLIENT_SECRET, then later you reset the secret and assign the new value to AZURE_CLIENTSECRET (note missing underscore), then you create the cloud-credentials secret using AZURE_CLIENT_SECRET (which is the original/no longer valid value).
You shouldn't need to reset the secret since the first line will auto-generate it, and store it in AZURE_CLIENT_SECRET.

Yes, that was verified by echoing the value of that variable.  It is correct as to which subscription I am working with now (the one that is not working)

@skriss I will check that right now.

@skriss It was the typo in the variable AZURE_CLIENTSECRET.  Somehow that change got committed to my repo!  This is working now.  Thank you!


Unable to install the add-on on Statamic 2.8.7

I've git cloned the adding in "addons", so I have a "iCal" directory in the "addons" directory.
Here's what happens next :
`➜  git git:(master) ✗ php please addons:refresh
[✗] This command is deprecated. Please use php please update:addons
Adding packages: erin-dalzell/ical, marbles/sitemap
Please wait while dependencies are updated via Composer. This may take a while.
The command "php composer.phar update erin-dalzell/ical marbles/sitemap --prefer-dist --no-dev --optimize-autoloader" failed.
Exit Code: 2(Misuse of shell builtins)
Output:
Error Output:
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- The requested package erin-dalzell/ical could not be found in any version, there may be a typo in the package name.
Potential causes:

A typo in the package name
The package is not available in a stable-enough version according to your minimum-stability setting
see https://getcomposer.org/doc/04-schema.md#minimum-stability for more details.

Read https://getcomposer.org/doc/articles/troubleshooting.md for further common problems.
Running update with --no-dev does not mean require-dev is ignored, it just means the packages will not be installed. If dev requirements are blocking the update you have to resolve those problems.
Dependencies updated!
`
same if I do php please update:addons
Unfortunately, I don't understand addons well enough to understand what's going on.

I could not reproduce, can you please try it with a new installation of Statamic?

Same happens on a fresh 2.8.8 install. I'm running macOS. Can this be an issue of filename case sentitivity?

Ok I'm sorry... My mistake :
I was cloning the whole repo in addons and didn't see that there was two level of directories. It's working now.


Run OpenDevin on Openshift/K8S

Summary
Run OpenDevin on Openshift/K8S. By default we can start with current root entrypoint.sh run but later we can think of running the whole application as non-root user.
Motivation
Getting wide range of integration in K8S/Openshift
Technical Design
We can create PV, PVC, then a POD that run two containers "i.e. Both the app and sandbox containers" if needed.
Alternatives to Consider
Run whole application as non-root user in order not to modify any security settings on OpenShift or K8S.
Additional context
I've tried to deploy it on my OpenShift lab and was able to run an agent with it.

Hi @eng-waleed1. Just to clarify are you asking that OpenDevin should just run permanently on OpenShift and people can access it without setting up locally?
If so, there is already plans to have a cloud hosted version as demo so people can test it out.

Hi @mamoodi , not that what I meant. I just wanted to get opendevin running on any openshift/k8s cluster. currently nothing mentioned about getting it running there or steps provided in case of someone needs to run it there. I hope this clarifies a little bit my point.

Ah yes I understand now. Essentially you want someone to document how to run OpenDevin on Openshift.
It will be hard to document every setup possible for OpenDevin that's why for now the only documentation is for running it locally.
We can leave this open but it's a specific use case and will require a good amount of time.
If you do happen to get it running, feel free to open a PR and add it instructions to somewhere in the documentation so others can use it if they want!

PR created. @mamoodi


[release/0.6] fix: Wrong timeout configuration value

Signed-off-by: OrangeBao<EMAIL_ADDRESS>(cherry picked from commit https://github.com/clusterpedia-io/clusterpedia/pull/494/commits/19a2ec9440c534270d35d4be86954df700f8830c)
Signed-off-by: CoderTh<EMAIL_ADDRESS>What type of PR is this?
/kind bug

What this PR does / why we need it:
pr: https://github.com/clusterpedia-io/clusterpedia/pull/494
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm


针对GeyserExtras 1.21.0-v1.1.4的中文更新

针对GeyserExtras 1.21.0-v1.1.4的中文更新
汉化了绝大部分内容，可以正常开服

会持续更新，看：
https://github.com/MengZe2l/GeyserExtras_CN/
作者赶紧合并(怒)

Do you want to help with translations for GeyserExtras v2.0? I'm planning to add support for other locales/languages soon

Of course, please send me the copy of GeyserExtras v2.0 after development, and I can translate it for you. We have two people developing together, and the other one is @github.com/ning-g-mo

If you would like to you can join my discord here, where other translators for other languges are and I can let you know about any updates for when it comes out: https://discord.gg/QcjC5Ez2Ac

But, I'm sorry, I'm from China, you know, where network management is very strict, and I can't download Discord using VPN, but I can tell you my email address. It's<EMAIL_ADDRESS>You can contact me by email (I like that you can recommend me to enter your Github organization as a translator, and then release the internationalization version directly or do internationalization directly in the plug-in)

I hope you are developing version 2.0, including the lang.Java file or lang.yml file. Please provide a basic template for the English language file, and we will handle the rest of the internationalization (i18n) work. We will fork your repository, translate the necessary files, and submit a pull request after completion. You can then merge the changes into your repository

I'll let you know when locale support is added, but Im not able to work on GeyserExtras for a few weeks so it might take a while, ill let you know about any updates here

I'll let you know when locale support is added, but Im not able to work on GeyserExtras for a few weeks so it might take a while, ill let you know about any updates here

ok, I'll read the information here often, and when it is updated, I will do the translation work

im alright with people reuploading it if it adds languages but i dont support it as in im not making it so proceed at your own risk

as long as people dont impersonate me / make it clear that its not by me and also not make virus jars im alright with that

https://hangar.papermc.io/Guardian1l/GeyserExtras_CN
Curious how it was reuploaded, not against License from what I can see but still, curious

Well, we just added multiple languages for the plug-in, no business, and we shouldn't violate the license

https://hangar.papermc.io/Guardian1l/GeyserExtras_CN
Curious how it was reuploaded, not against License from what I can see but still, curious

MIT has a "including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software "

Thanks for crediting me on the modrinth pages description too, really appreciate it.
Locale support is probably going to be the form of either a JSON or .lang file like how bedrock does their languages
Like I said it will be a few weeks until I can work on it again but when its done I'll let you know

Hi, sorry for the long wait, but the latest build now supports languages. Here is a quick guide on how to make one
You dont have to rush with the translations: they will automatically download the latest ones from this repository when GeyserExtras is booted up.
All languages will be downloaded to GeyserExtras/cache/langs/.
To get started with editing, make sure Geyser/GeyserExtras is closed and then add the language you are translating from here:
https://github.com/GeyserExtras/data/blob/main/langs/language_names_all.json
to GeyserExtras/cache/langs/language_names.json.
I will be using French (fr_FR) as an example.
Original language_names.json:
[
    [ "en_US", "English (United States)" ],
    [ "en_GB", "English (United Kingdom)" ]
]

Edited for French:
[
    [ "en_US", "English (United States)" ],
    [ "en_GB", "English (United Kingdom)" ],
    [ "fr_FR", "Français (France)" ]
]

Then, make a json file based on your language code. You can duplicate the GeyserExtras/cache/langs/en_US.json if you would like, for French you would make a GeyserExtras/cache/langs/fr_FR.json.
Make your edits in this file, and then boot up GeyserMC and Minecraft Bedrock, ensuring on Bedrock that your language is set to the same one you are editing/adding to GeyserMC. Then check the menus and your translations should be applied. Once you are done you can make a pull request on the repository.

OK, we have started the translation work, but I found that you still have some places that are not multilingual. I'll give you a list of words that aren't multilingual later

OK, we have started the translation work, but I found that you still have some places that are not multilingual. I'll give you a list of words that aren't multilingual later


unable to compile due to problems with protobuf version

When I tried to compile Librespot, I got these error messages:

error[E0425]: cannot find value VERSION_2_7_0 in module protobuf
--> protocol/src/authentication.rs:27:49
|
27 | const _PROTOBUF_VERSION_CHECK: () = ::protobuf::VERSION_2_7_0;
|                                                 ^^^^^^^^^^^^^ help: a constant with a similar name exists: VERSION_2_8_0

error[E0425]: cannot find value VERSION_2_7_0  in module protobuf
--> protocol/src/keyexchange.rs:27:49
|
27 | const _PROTOBUF_VERSION_CHECK: () = ::protobuf::VERSION_2_7_0;
|                                                 ^^^^^^^^^^^^^ help: a constant with a similar name exists: VERSION_2_8_0

error[E0425]: cannot find value VERSION_2_7_0  in module protobuf
--> protocol/src/mercury.rs:27:49
|
27 | const _PROTOBUF_VERSION_CHECK: () = ::protobuf::VERSION_2_7_0;
|                                                 ^^^^^^^^^^^^^ help: a constant with a similar name exists: VERSION_2_8_0

error[E0425]: cannot find value VERSION_2_7_0 in module protobuf
--> protocol/src/metadata.rs:27:49
|
27 | const _PROTOBUF_VERSION_CHECK: () = ::protobuf::VERSION_2_7_0;
|                                                 ^^^^^^^^^^^^^ help: a constant with a similar name exists: VERSION_2_8_0

error[E0425]: cannot find value VERSION_2_7_0 in module protobuf
--> protocol/src/pubsub.rs:27:4
|
27 | const _PROTOBUF_VERSION_CHECK: () = ::protobuf::VERSION_2_7_0;
|                                                 ^^^^^^^^^^^^^ help: a constant with a similar name exists: VERSION_2_8_0

error[E0425]: cannot find value VERSION_2_7_0  in module protobuf

--> protocol/src/spirc.rs:27:49
|
27 | const _PROTOBUF_VERSION_CHECK: () = ::protobuf::VERSION_2_7_0;
|                                                 ^^^^^^^^^^^^^ help: a constant with a similar name exists: >VERSION_2_8_0

error: aborting due to 6 previous errors

For more information about this error, try rustc --explain E0425.
error: Could not compile librespot-protocol.
warning: build failed, waiting for other jobs to finish...
error: build failed

I changed the constant in all of these files to "2_8_0" and it seems to work fine. I am no expert though, that's why leave this at "unsolved"
Edit: Could not get the code to be formatted in the right way

We should fix this by specifying an exact version of protobuf and protobuf-codege-pure until #293 is merged.

I get the same error but with 2_8_0 and 2_8_1. #293 works fine for me, I am currently using its branch https://github.com/willstott101/librespot/tree/protobuf-codegen-pure as a workarround.

Closed with #293


Improve documentation and examples for patternplate-transform-resolve-includes

The examples and documentation in the readme of patternplate-transform-resolve-includes are not easily understandable.
A minimum requirement would be to explain how the resolution works.

The entire patternplate-transform-* system has been removed.


Initial implementation of Azure Storage Service Connector

Purpose

Add Azure Storage Service Connector for Ballerina
Fix https://github.com/wso2-enterprise/choreo/issues/2741

Goals

Add Initial implementation of Azure Storage Service connector for Ballerina
Add utilities module
Add azure storage blob service related operations

Approach

This connector will be implemented using Azure Storage Service REST APIs

Release note

add azure storage service connector for ballerina.
add azure storage blobs service

Documentation

https://docs.microsoft.com/en-us/rest/api/storageservices/blob-service-rest-api
https://docs.microsoft.com/en-us/rest/api/storageservices/authorize-with-shared-key
https://docs.microsoft.com/en-us/rest/api/storageservices/delegate-access-with-shared-access-signature

Certification

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Test environment

ballerina SLP8

Learning

https://docs.microsoft.com/en-us/rest/api/storageservices/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@LakshanSS The commit messages and PR heading is not according to the best practices. Please correct them.

[1] https://github.com/ballerina-platform/ballerina-lang/blob/master/CONTRIBUTING.md#submit-your-contribution


Inclusion of the translation into Portuguese of Brazil.

I will let you choose the best translation together, given that I don't speak Portuguese. Tell me when you're done.

@fonsecas72
I agree with you.
If you have any comments, they are welcome.

@keviocastro good job, just fix the missing spaces and missing accents.

@stof believe is completed.
@fonsecas72 you agree?

:+1: @keviocastro

@stof the translation is complete.

Thanks @keviocastro and @fonsecas72.

note that I squashed commits when merging to keep the history clean, but the authorship is preserved: https://github.com/Behat/MinkExtension/commit/ac9e16167eadd687476ea8eec0fbd94a4d1321cb


Occasionally unable to download get_theca

I noticed often times the domain is not responding properly to my curl requests. I tried from two different machines in different locations and networks and all I get is:
* About to connect() to static.bracewel.net port 443 (#0)
*   Trying <IP_ADDRESS>...
* Connected to static.bracewel.net (<IP_ADDRESS>) port 443 (#0)
* Initializing NSS with certpath: sql:/etc/pki/nssdb
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* NSS error -12286 (SSL_ERROR_NO_CYPHER_OVERLAP)
* Cannot communicate securely with peer: no common encryption algorithm(s).
* Error in TLS handshake, trying SSLv3...
> GET /theca/get_theca.sh HTTP/1.1
> User-Agent: curl/7.29.0
> Host: static.bracewel.net
> Accept: */*
>
* Connection died, retrying a fresh connect
* Closing connection 0
* Issue another request to this URL: 'https://static.bracewel.net/theca/get_theca.sh'
* About to connect() to static.bracewel.net port 443 (#1)
*   Trying <IP_ADDRESS>...
* Connected to static.bracewel.net (<IP_ADDRESS>) port 443 (#1)
* TLS disabled due to previous handshake failure
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* NSS error -12286 (SSL_ERROR_NO_CYPHER_OVERLAP)
* Cannot communicate securely with peer: no common encryption algorithm(s).
* Closing connection 1

Other curl requests the script does, like the one to https://static.rust-lang.org/rustup.sh work well. wgetting get_theca works too without a problem, downloading it from the browser works too. Let me know if you need more help.
Tested on:

System 1 (Fedora 21)
curl 7.37.0 (x86_64-redhat-linux-gnu) libcurl/7.37.0 NSS/3.17.4 Basic ECC zlib/1.2.8 libidn/1.28 libssh2/1.4.3 Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp scp sftp smtp smtps telnet tftp  Features: AsynchDNS GSS-Negotiate IDN IPv6 Largefile NTLM NTLM_WB SSL libz Metalink
System 2 (CentOS 7)
curl 7.29.0 (x86_64-redhat-linux-gnu) libcurl/7.29.0 NSS/3.15.4 zlib/1.2.7 libidn/1.28 libssh2/1.4.3 Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp scp sftp smtp smtps telnet tftp  Features: AsynchDNS GSS-Negotiate IDN IPv6 Largefile NTLM NTLM_WB SSL libz

I believe this is due to a typo in a Cloudflare page rule I had that was supposed to disable browser integrity checks on the static subdomain, I seem to have fixed it but if you still see this let me know...

@rolandshoemaker Same result, sorry :/

Are you still seeing this? I've tested it a few times over the last few days on Ubuntu 14.04 and OS X 10.10.2 (with 7.35.0 and 7.37.1 respectively and same common features as you) and not seen any problems so far...


[MINOR] Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-SNAPSHOT

Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-SNAPSHOT as Eagle graduated from incubator and becomes TLP

LGTM

Hi Hao,
Search for "incubating" in entire project gave me 100+ files ( 98 xml files with some 5 test files and other readme's ), wondering if this PR covers all of them.

@haoch Hao, what's the plan of migration? Step by step, or complete it with 1 shot?

@jhsenjaliya good catch, will fix it accordingly.
@anyway1021, this PR will only fix the version-related things in source code, please feel free to clean other steps if any missing in separated PR.

@jhsenjaliya I think i have resolved all "incubating" things, please help review again.

@haoch, found 1 last reference in LICENSE file having text like "Apache Eagle (incubating) Subcomponents:" , otherwise looks good.

@jhsenjaliya fixed as well. If no more problem, I will merge the PR.

Thanks @anyway1021 and @jhsenjaliya for reviewing. The pr has been merged now.


Provide instructions to install pac using winget

Many folks who use CLIs use winget.  Consider providing instructions on how to install using winget.
 winget install Microsoft.PowerAppsCLI

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5446bda4-9257-9a56-ff6b-b62a82b79132
Version Independent ID: 5446bda4-9257-9a56-ff6b-b62a82b79132
Content: Microsoft Power Platform CLI - Power Platform
Content Source: power-platform/developer/cli/introduction.md
Service: power-platform
Sub-service: developer
GitHub Login: @kkanakas
Microsoft Alias: jdaly

Thanks for your comment, @devkeydet. This issue has been assigned to the doc author for review.

Sent email to @kkanakas to make sure he sees this.


SSVM: 'allow from' private IP in other SSVMs if the public IP is in allowed internal sites cidrs

Description
This PR fixes #5678
Normally SSVMs in multiple zones communicate via the public IPs.
In some cases, the public IPs are in the internal allowed sites. There are some routes in SSVMs which causes the communication to use the private IPs. We need to add the private IP of other SSVM to /var/www/html/copy/.htaccess if the public IP is in secstorage.allowed.internal.sites

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
Without this PR, SSVM contains only public IP of another SSVM
root@s-8-VM:~# cat /var/www/html/copy/.htaccess
Options -Indexes
order deny,allow
deny from all
allow from <IP_ADDRESS>

With this PR, it has both private and public IP of another SSVM
root@s-8-VM:~# cat /var/www/html/copy/.htaccess
Options -Indexes
order deny,allow
deny from all
allow from <IP_ADDRESS>
allow from <IP_ADDRESS>

The SSVM has route to all internal allowed sites via private nic, for example (secstorage.allowed.internal.sites=<IP_ADDRESS>/16)
root@s-8-VM:~# ip route
default via <IP_ADDRESS> dev eth2
<IP_ADDRESS> via <IP_ADDRESS> dev eth1
<IP_ADDRESS>/16 via <IP_ADDRESS> dev eth1
<IP_ADDRESS>/20 dev eth1 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS>/20 dev eth2 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS>/16 dev eth0 proto kernel scope link src <IP_ADDRESS>

How Has This Been Tested?

@blueorangutan package

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5658

@blueorangutan test centos7 kvm-centos7 qemuEv keepEnv

@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian Build Failed (tid-6241)

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6059

@blueorangutan test

Trillian test result (tid-6555)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49594 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7288-t6555-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_upgrade_kubernetes_cluster
Failure
499.76
test_kubernetes_clusters.py

@blueorangutan package

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

@blueorangutan package

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6494

@blueorangutan test

[SF] Trillian test result (tid-7116)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45638 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7288-t7116-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_migrate_VM_and_root_volume
Error
77.61
test_vm_life_cycle.py

test_02_migrate_VM_with_two_data_disks
Error
57.44
test_vm_life_cycle.py

verified in a 3-zone env, merging


Redesign upgrade page

Upgrade page

Free trial

Free trial with onboarding

billing onboarding

Some small comments:

Let's make https://zulip.com/help/zulip-cloud-billing open in a new tab.
Let's put a period at the end of the error message ("You must purchase licenses for all active users in your organization (minimum 1)")
If I click "Purchase" and then press "back" in the browser, the number of licenses on the manual lincensing form gets reset. It would be better if it didn't, but it can definitely be left as a follow-up if it's not super easy to fix. Once we have a separate flow for adding a card, we'll want the number to be preserved when you add one, but I don't know if that's related.

We could handle the title better on narrow screens (can be a follow-up):

If I click "Purchase" and then press "back" in the browser, the number of licenses on the manual lincensing form gets reset. It would be better if it didn't, but it can definitely be left as a follow-up if it's not super easy to fix. Once we have a separate flow for adding a card, we'll want the number to be preserved when you add one, but I don't know if that's related.

Started a discusoin for it here but yeah, seems like it would be better to do as a followup.

Pushed to fix everything except 3 as stated in the previous comment.

Added some commits for Billing page tasks in https://github.com/zulip/zulip/issues/27645
Specifically these:

[ ] https://github.com/zulip/zulip/pull/27619#issuecomment-1804186848
[ ]  Would it be easy to show the breakdown of where the charge comes from? In the issue, we had:

Expected charge: $66.70 ($6.67 x 10 users x 1 month)

[ ] Rather than having those big "update" buttons disable when there's no changed values, it'd be cleaner to have them be invisible in that state; that way, the default state of the page doesn't have any extra buttons.

We offer fixed price to some orgs as it appears from the code, so for that case the breakdown of expected charge is not shown.

Hmm, the breakdown doesn't seem to work correctly for month multiplier. Let me check...

Please run ./manage.py populate_billing_realms so that it shows a nice number for annual billing realms.

The last bit of todo for billing page which is to add a dropdown for billing frequency is a big change and needs a separate PR.

OK, here are some proposed text changes:
Successfully updated licenses for current billing period! ->
Number of licenses for the current billing period has been updated.
Successfully updated licenses for next billing period! ->
Number of licenses for the next billing period has been updated.
Successfully cancelled last subscription! ->
Your plan has been canceled and will not renew.
Successfully activated subscription! ->
Your plan has been reactivated and will renew automatically.

I was not able to test the full upgrade flow, but didn't spot any issues otherwise!

A few things seem not super robust:

All the users|user code; I guess ideally we'd be using ICU plurals, but we can't do that without tagging the pages for translation, so it's a bit awkward.
The model of changing the URL to have /?success_message="message" is a bit ugly in terms of putting that in the URL. Not a priority to rework for this month.

I'll apply https://github.com/zulip/zulip/pull/27664#issuecomment-1808527593 and pushed back here; I've marked this to merge as a solid checkpoint once CI passes.


Reenabling building for Android NDK

I found that current android.rake does not comply to Build System Maintainers Guide for NDK (Android's Native Development Kit), and mruby cannot be compiled by recent versions of NDK.
https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Sysroot
I updated android.rake and the corresponding build config files.  With this update, I checked NDK r19 and NDK r25(latest) can build mruby on macOS 12.5 (intel).

Thank you! This kind of update is highly welcome.
By the way, could you rebase before making a pull-request? If it's hard, it's OK though.

OK!  I change it to rebase.

Merged! Thank you!


Add flag autosave

A solution for #123
Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered

Bad idea

Why was this a bad idea? What would be a better solution?


Add workflows sample

Fixes #issue

It's a good idea to open an issue first for discussion.

[ ] I have followed Sample Format Guide
[ ] pom.xml parent set to latest shared-configuration
[ ] Appropriate changes to README are included in PR
[ ] API's need to be enabled to test (tell us)
[ ] Environment Variables need to be set (ask us to set them)
[ ] Tests pass:   mvn clean verify required
[ ] Lint  passes: mvn -P lint checkstyle:check required
[ ] Static Analysis:  mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
[ ] Please merge this PR for me once it is approved.

lgtm after last question is addressed


Log IP and Hostname

I'd like to add this to the Analytics Protocol. If we collect this information it would have to be censored for any anonymized exports.
import socket

hostname = socket.gethostname()
IP = socket.gethostbyname(hostname)

Why does it matter what the user's hostname is? And the IP you get will be a local IP, and not very useful.

You would have to make an HTTP request to fetch the WAN IP.

Yeah - I think this isn't worth it at the moment. If we come up with a compelling reason for this we can look into doing that.


Enter district information for Sudbury.

Hello! Who completed Sudbury? I just want to record that in Editor.

Anoushka worked on it.


Ensure computing MI doesn't allocate

Description of the Change
This PR adds test that ensure that computing mutual information doesn't allocate (and also fixes some allocations).
This PR also adds a new trait, MutualInformationParallelization, to model SIMD separately from the default.
Motivation
This code allocated before, which was the cause of some performance problems.
Possible Drawbacks

Verification Process
The new unit tests verify that there are no allocations in that code.
Applicable Issues

Codecov Report

Merging #8 (57fc82d) into main (f61d0ab) will decrease coverage by 2.00%.
The diff coverage is 95.65%.

@@             Coverage Diff             @@
##              main       #8      +/-   ##
===========================================
- Coverage   100.00%   98.00%   -2.00%
===========================================
  Files            3        3
  Lines           82      100      +18
===========================================
+ Hits            82       98      +16
- Misses           0        2       +2

Impacted Files
Coverage Δ

src/mutual_information.jl
96.55% <95.23%> (-3.45%)
:arrow_down:

src/traits.jl
100.00% <100.00%> (ø)

src/register.jl
100.00% <0.00%> (ø)

src/MutualInformationImageRegistration.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61d0ab...57fc82d. Read the comment docs.

Daniel Wennberg on the Julia Slack made a good suggestion to improve the code here, but I'm opting not to implement it as this package is meant for small data and won't be running on a GPU where this would be performant:
h(p, q) = (p > 0) ? p * log(p / q) : zero(p)
mapreduce(h, +, mi.pxy, mi.px_py; init=zero(eltype(pxy)))


ConfigureJsonSerializer settings won't work for different assembly - Self referencing loop detected errors

Is this a bug report?
Yes

Can you also reproduce the problem with the latest version?
Yes
Environment

Operating system: Windows 10
Visual Studio version: 16.3.10
Dotnet version: 2.2 Core

Steps to Reproduce

I'm trying to send data to a queue. Publishing class is in a different assembly (Class Library)
I added dll reference to main project.
Masstransit Bus is already configured with ConfigureJsonSerializer settings.

Expected Behavior

Should successfully send data to queue.
Actual Behavior

I'm facing circular reference ("Self referencing loop detected") errors. ConfigureJsonSerializer settings seems to be ignored.
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

 Bus.Factory.CreateUsingRabbitMq(configureBus =>
            {
                configureBus.MessageTopology.SetEntityNameFormatter(new AcessoEntityFormatter());
                var host = configureBus.Host(new Uri(QueueSettings.AmqpConnection), config => { });
                configureBus.ConfigureJsonSerializer(settings =>
                {
                    settings.ReferenceLoopHandling = ReferenceLoopHandling.Ignore;
                    return settings;
                });
                configureBus.ReceiveEndpoint(host, QueueSettings.FileReceivedSubscription, configureEndpoint =>
                {
                    configureEndpoint.Consumer<FileReceivedConsumer>(serviceProvider);
                });
            });

Same is #1523
Simple answer, don't create loops in message contracts. If you can't get the JSON settings worked out so that it works, well, I haven't looked at it yet and it isn't on my priority list.


Create a version of ChatQnA example with Zilliz/Milvus as DB

Create a version of ChatQNA example with Zilliz/Milvus as DB
https://github.com/opea-project/GenAIExamples/tree/main/ChatQnA).

The implementation can reference this code example for the interaction with Milvus vector database: https://milvus.io/docs/build-rag-with-milvus.md

/assigntome

Ambarish -<EMAIL_ADDRESS>-   malangi77

Hi,
I am Afzal github user- ard383 , participated in this hackathon
I have worked on Creating a version of ChatQnA for Milvus DB , I am attaching my work for the reference, I am facing the issue at the last step while querying the most of the microservices, attaching the git repo path for the reference https://github.com/ard383/OPEA-ChatQnA-milvusDB.git .

Hi @ard383, thanks for contributing and using Milvus! Could you please share the error message or logs?

Hello @codingjaguar,
I have uploaded the new compose.yaml and setup_env.sh files, along with the error messages, in the same GitHub repository. Please find the links below for complete information:
https://github.com/ard383/OPEA-ChatQnA-milvusDB.git
docker-compose-org.yaml: Link
setup_env-org.sh: Link
docker-compose.logs: Link
docker-curl-response.logs: Link
You can access the repository here: OPEA-ChatQnA-milvusDB.
Your help would be greatly appreciated!

I took a glance at the docker log:
message='Attempt to decode JSON with unexpected mimetype: text/plain; charset=utf-8', url='http://retriever:7000/v1/retrieval'
It seems a problem in the application server logic, doesn't seem related to Milvus. @chickenrae Could you suggest a maintainer of  https://github.com/opea-project/GenAIExamples repo to help take a look?

@mkbhanda Can you help?

@ard383 maybe it is the network problem, you can refer this one https://github.com/langgenius/dify/issues/8562 , and try to  change the uri from the internal format e.g http://localhost:19530 to an external one e.g.http://<IP_ADDRESS>:19530
I'm not sure if this is the reason, just base on experience, but maybe you can try it

@chickenrae
The ChatQnA Example based on Milvus as DB is was enabed in:
https://github.com/opea-project/GenAIExamples/pull/1081
https://github.com/opea-project/GenAIComps/pull/858


Fix TTS voice language

Today it is using the system language to the voice, but if the book is not english it will try to read the book in english.

This probably will fix that if the book has language defined on its metadata.
utterance.voice = AVSpeechSynthesisVoice(language: book.metadata.language)


Use yaml, don't use cache

Don't use docker cache
Use --yaml for all launches since it works with --json

Coverage increased (+0.1%) to 80.028% when pulling 789b1f619d976a41f167c9eb7647d462d284612c on feature/noCache into c67810b31b00c3dc9c287db65dfbd327093bb9c4 on develop.


Compact Layout Assignments Updating Erroneously

We've run into an issue which we can't seem to figure out.  We've got some code that updates a picklist, adds values and re-orders the list alphabetically.  That works well.  Then, we have a block of code, posted below, which goes through the record types and updates them as well.  However, what we are seeing is that while the code works, it is also updating the assignment of Compact Layouts on the object, which poses a problem.  We've gone through the code and can't figure out how to stop this "feature".
// Updating list of record types List < MetadataService.RecordType > TEMPRecordTypelist = new List < MetadataService.RecordType > (); integer maxSize = 10; for(MetadataService.RecordType TEMPrectype : recordTypeList){     TEMPRecordTypelist.add( TEMPrectype );     System.debug('TEMPRecordTypelist:::::::::'+TEMPRecordTypelist);     List<MetadataService.SaveResult> results = service.updateMetadata( TEMPRecordTypelist );       for(MetadataService.SaveResult result : results){         MetadataServiceExamples.handleSaveResults(result);     }     TEMPRecordTypelist.clear(); }
The content of the debug statement is attached.  Also, the reason we found this was when we were auditing the setup log, as you can see in the attached screenshot.

Any idea why this is or how to stop it?
Thank you!
Joseph
debugstatement.txt

Hi @afawcett - this is really a bug that is affecting one of our clients.  I realize this is free of charge so you don't have to support it, but is there anything I can do to have you look at it?  Thank you!

Hi, hope you don't mind me editing your original comment! I just formatted the code as a java code block.
You're reading RecordTypes, manipulating picklistValues and then saving. So far so good. But as you are probably well aware, the RecordType  has other properties, such as fullname, active, description and the eponymous compactLayoutAssignment.
In your debug log, your RecordType looks something like this
RecordType:[
    active=true,
    fullName=Contact.up__Machine,
    compactLayoutAssignment=null,
    // ... some more properties, including the good ol' picklist values
]

And compactLayoutAssignment=null is where the trouble lies. I'm not sure why it's coming back as null on reading the metadata, but saving it as null reverts to 'Inherit from Primary.'
Maybe it's a bug the Metadata API which you would need to raise with Salesforce.
Or maybe the current user doesn't have permission to view that compact layout.
As a workaround, you could explicitly set the compactLayoutAssignment value - but obviously this only helps if you know the correct value for all record types.
I'm going to close this, as I think the problem is part of Salesforce's Metadata API rather than this Apex helper library.

Tip: Run your code from Annonymous Apex and check the debug log after. It seems that in this context you get to see the raw XML requests and responses being sent and received from the Salesforce server. This may yield more insight, it also gives you something you can build into a curl script you can send to Salesforce support (without distracting them needlessly with discussions on Apex wrapping SOAP etc etc).


Added ZS Elektryk

@Tungstenfur Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


Updating and standardizing the license headers

Overview
Updates, adds, and standardizes the license headers across the Toolkit.

@StephenHodgson Conflicts resolved.

@keveleigh should we also do this for the stabilization branch?
You might be able to cherry pick that in.

I'd be happy to see it go into the stabilization branch, since it's a "doc" update rather than a feature update.


[maintenance] Merge main into dev-ja

Describe your changes
General maintenance PR
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[ ] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

This PR doesn’t require technical or literature reviews, so I’ll go ahead and merge it as is.


PowerToys run BG blur

Microsoft PowerToys version
v0.76.2
Installation method
Microsoft Store
Running as admin
None
Area(s) with issue?
PowerToys Run
Steps to reproduce
PowerToys run background blur does not work after some time. Restarting the app solves the issue, but again after some minutes background becomes solid.
✔ Expected Behavior
Background blur

❌ Actual Behavior
background is solid

Other Software
No response

Seeing the samething.  Darkmode doesnt stick neither also not scaling text with windows > Easy access > Make text bigger has no respose to Powertoys.
Win10 19045.3803 .  Scaled to 150, Text size 137, 3840x2160 monitor.

cc: @niels9001

I seem to never have blur on up to date windows 10. transparency effects are enabled. PT is running as admin (v0.76.2)

/dup https://github.com/microsoft/PowerToys/issues/30297


Create WebViewProvider API, allowing webviews to persist across refreshes

Reworked loading and saving tabs so every tab is responsible for its own serialization and deserialization
Split tab ids into id and tabType
Tightened up layout-related types for better TypeScript support
Moved saving and loading layout to web view service
Created web view provider service that handles web view providers specifically. Each provider is distinct from other providers by having a unique webViewType, which is how the contents of webviews is determined

This service is a weird split off from web view service, so I made it internal and not affect extension developers. Seems like a helpful distinction, though. Would love input on any thoughts regarding reworking it. Maybe make a singleton class in web view service? Dunno; not sure it's even worth it right now. Might be best to make an issue if it even warrants it

Reworked addWebView so you provide just a webViewType, layout info, and some options. Then the appropriate WebViewProvider takes care of actually making the web view
onDidAddWebView event no longer carries content or styles so there's not so much unnecessary talk all over the network over webviews
Added a button on the (newly renamed) People webview that opens a new People webview :)

This change is

There is a Convert to draft link button top-right in the reviewers section of the side-bar - hard to spot though.


New kafka reader

This will be a new implementation of a kafka reader based around the node-rdkafka library https://github.com/Blizzard/node-rdkafka from Blizzard.
The model shouldn't be fundamentally different from the old reader.

Reader is setup with the topic and number of partitions
The slicer hands out topic partition assignments to workers
The worker will read a slice of data from the assigned partition and process it.
Only one worker can be reading from a partition at any time
The number of usable workers may be limited by the number of available partitions.
The tricky part will be at what point the slice is considered complete and the offset into the partition gets moved.

If it gets moved early then another worked could read from that offset and begin processing.
But if the current slice fails then the offset will have moved and data would be lost.

In most instances these jobs will be deployed as persistent jobs so recovery of slices won't be an option.

Late moving of the offset will require a separate processor that would be added to the end of the job.

This may also imply there is state shared from the reader through to that processor which may be tricky.

Is the structure of the old reader still valid? https://github.com/terascope/teraslice-kafka

It will end up being fairly similar although there are some details around the way the rdkafka library works with consumers which may actually eliminate the need for the slicer to allocate partitions. Kafka overall has gotten much better around the idea of consumer groups and balancing partitions across them.

Initial implementation is complete. Closing.


Add support for two-factor authentication

Add support for two factor authentication.
Register a callback function to handle two factor authentication requests.
In the callback, generate a command line prompt for a 2FA key.

Stackstrace look like:
Traceback (most recent call last):
  File "/home/ed8/.local/bin/github-pr-stats", line 107, in <module>
    url=githubUrl)
  File "/home/ed8/.local/bin/github-pr-stats", line 70, in authorize
    return gh.authorize(login, password, scopes, note, note_url, client_id, client_secret)
  File "/home/ed8/.local/lib/python2.7/site-packages/github3/github.py", line 118, in authorize
    json = self._json(ses.post(url, data=dumps(data)), 201)
  File "/home/ed8/.local/lib/python2.7/site-packages/github3/models.py", line 86, in _json
    if self._boolean(response, status_code, 404) and response.content:
  File "/home/ed8/.local/lib/python2.7/site-packages/github3/models.py", line 107, in _boolean
    raise GitHubError(response)
github3.models.GitHubError: 401 Must specify two-factor authentication OTP code.

Still got the 2FA error message
env ❯ python2 github-pr-stats --basic my-user https://github.com/org/repo/
Username: my-user
Password:
Enter 2FA code: 366716
Traceback (most recent call last):
  File "github-pr-stats", line 123, in <module>
    url=githubUrl)
  File "github-pr-stats", line 86, in authorize
    return gh.authorize(login, password, scopes, note, note_url, client_id, client_secret)
  File "/home/ed8/.local/lib/python2.7/site-packages/github3/github.py", line 114, in authorize
    json = self._json(self._post(url, data=data), 201)
  File "/home/ed8/.local/lib/python2.7/site-packages/github3/models.py", line 86, in _json
    if self._boolean(response, status_code, 404) and response.content:
  File "/home/ed8/.local/lib/python2.7/site-packages/github3/models.py", line 107, in _boolean
    raise GitHubError(response)
github3.models.GitHubError: 401 Must specify two-factor authentication OTP code.

Go to https://github.com/settings/tokens . Do you see a token called "github-pr-stats"?
If yes, then try deleting the github-pr-stats token from github.
This is what happened. The code in github-pr-stats needs a token. When no token is provided this PR tries to login and create the token. The resulting token is stored in your local git config. When github already has a token, it fails trying to overwrite the existing token.
Alternatively, I could change the name of the token allowing duplicates on github. This could lead to too many tokens being created if you run from multiple machines.
Multiple machines could use the same token. This would have to be a manual task to copy the token onto multiple machines. Github gives you one time access to the token. The second request, and all future requests aren't given access to the token's key.

The version of github.py is out of date. Need to upgrade to github.py 1.2.0.


Fix for windows housekeeping inconsistency

Attempted fix for housekeeping for Win OS - following up on issue #163
Now the windows find function follows the unix find logic.
added an early exit to return files as an empty list if match is empty (targeting the issue from 163)

Can find OS name via this command but it's pretty slow:
systeminfo | findstr /B /C:"OS Name"

Any test cases for this?

We ran the find function with an empty exclude field on both windows 10 and linux to ensure they produced the same result of no files found. They both successfully found no files.


main.d is a mess

Maybe move getopt to a separate module?

getopt.d created.
debugging.d created to house the IRCEvent-faking routines.
main.d had parts of it moved into common.d.
main.d globals moved into an aggregate kameloso.common.Kameloso struct.
common.d had its Bash/terminal parts broken out into bash.d.


[Feature Request] List Repositories with access similar to Gitolite via SSH

Gitea version (or commit ref): N/A
Git version: N/A
Operating system: N/A
Database (use [x]): N/A
Can you reproduce the bug at https://try.gitea.io: N/A
Log gist: N/A

Description
In gitolite, one can ssh directly to the git user and see which repositories they have access to and what level(s) (assuming they're using an authorized keypair).
e.g.:
$ ssh<EMAIL_ADDRESS>PTY allocation request failed on channel 0
hello [REDACTED username], this is<EMAIL_ADDRESS>running gitolite3 3.6.11 on git 2.27.0

 R W	foo
 R W	bar
 R W	baz
 R    	quux
Connection to git.foo.bar closed.

It's generally a much faster and easier way of getting a repository list from the server than via a web interface or API.
Would this be something Gitea would be able to/interested in implementing?
Screenshots
N/A

When you SSH to the server, SSH runs gitea serv key-id which then calls an Web API locally to talk to the Gitea web server...
Have you seen the tea command? (https://gitea.com/gitea/tea)

Instead, currently gitea will display
Hi there, <you login name>! You've successfully authenticated with the key named <your ssh key email>, but Gitea does not provide shell access.
If this is unexpected, please log in with password and setup Gitea under another user.

and then close the SSH connection.
The difference between gitea and the above systems is they listed the repositories but gitea didn't.
Just like @zeripath said, we have tea tool, it could do more. So is this necessary?

@zeripath The problem is then that one needs an additional/external tool rather than any simple SSH client (which, typically, they need in some fashion anyways to use git).

Duplicate of #5124


Set default etcd data dir in Helm values

I don't think we can do this.
That field is used to determine if we should make a v2 backup.
If the field is empty, we skip v2 backup:
https://github.com/giantswarm/etcd-backup-operator/blob/f41344200b95aab3356eb620d7c557c8740f8840/pkg/giantnetes/types.go#L30
And since v2 is disabled on azure and aws this would make the operator to fail


Use sbroker as the default pool

@fishcakez I believe sbroker seems to be a better default, provide better concurrency and performance, regardless if we are using shrinking or not.

I am a bit uncomfortable with the idea of switching from a ~400 line of code default to a 6.5k lines of code (estimate for sbroker 1.0) default. That is a lot of code for pooling, not everyone needs the features provided*. I would choose sbroker every time myself but if someone made that switch on me I would not be thrilled. Whereas defaulting to the simpler poolboy means people can opt-in to more advanced features.

Its approximately 1.5k lines to do dispatch, 1.5k lines to do pool resizing and then maybe 7 features around 500 lines each to reduce upper percentile latency in certain situations. We can probably make all of these features available but I'm unsure how many will be used by 80% of people.

Performance of poolboy pool is now almost inline with sbroker.

We have defaults that seem ok in postgrex so lets go for this. There is A LOT of configuration available that is documented in DBConnection, we will need to point there otherwise it is too much duplication.

We have decided to continue with poolboy because sbroker also brings sasl as a dependency, which brings extra logging behaviour. Moving to sbroker would also break the user code since they need to depend on both sbroker deps and application.


binutils: drop the dtneeded.patch?

Issue description
Nixpkgs appears to patch binutils so that the linker uses the --copy-dt-needed-entries option by default. This seems to have the effect of the linker being able to resolve dependencies via anything in the transitive dependencies chain. While that may work at build time it doesn't seem to work at run time as unless the dependency is declared explicitly Nix / nixpkgs ensures the dynamic loader won't be able to see it.
Conceptually --no-copy-dt-needed-entries behaviour seems closer to what would be the desired behaviour in Nix / nixpkgs. At the same time I don't have a great deal of understanding here so I may well be wrong. Just opening this issue for discussion as I would like to hear others' opinions and clear up my own misunderstandings.
Steps to reproduce
Consider the following test program that references a symbol exported by libgssapi_krb5 shared library:
char gss_krb5_ccache_name ();
int main ()
{
    return gss_krb5_ccache_name ();
    return 0;
}

Build it but don't link it against said library but something that has it in its transitive dependency chain:
$  gcc test.c -o test -Wl,--copy-dt-needed-entries -lldap_r

Observe the compilation succeeding but resulting in a runtime failure:
$ ./test: error while loading shared libraries: libgssapi_krb5.so.2: cannot open shared object file: No such file or directory

Now build the same program using --no-copy-dt-needed-entries linker option:
$ gcc test.c -o test -Wl,--no-copy-dt-needed-entries -lldap_r
/nix/store/ihi9rhwq22y92p9iay1mdvy0lr75wdh2-binutils-2.30/bin/ld: /run/user/1000/cc90p4Wk.o: undefined reference to symbol 'gss_krb5_ccache_name@@gssapi_krb5_2_MIT'
/nix/store/hr82iai25rdkgkgx7n1hv3p311hs1141-libkrb5-1.15.2/lib/libgssapi_krb5.so.2: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

Technical details
Affects binutils on master, reproducer based on staging-next.

Merged https://github.com/NixOS/nixpkgs/pull/51770; in staging-next ATM.


Test report to elastic search porcess  definition

duplicate of https://github.com/zephyrproject-rtos/zephyr/issues/64087


Develop

Codecov Report

Merging #7 (e1e6e61) into main (f157dd9) will decrease coverage by 26.87%.
The diff coverage is 7.07%.

@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
- Coverage   69.73%   42.85%   -26.88%
===========================================
  Files           8        9        +1
  Lines         261      455      +194
===========================================
+ Hits          182      195       +13
- Misses         79      260      +181

Impacted Files
Coverage Δ

infra/src/amqp/client.rs
0.00% <0.00%> (ø)

infra/src/amqp/topology.rs
0.00% <0.00%> (ø)

infra/src/env/configs.rs
33.33% <ø> (ø)

infra/src/logging/mod.rs
93.84% <ø> (ø)

infra/src/otel/tracing.rs
0.00% <ø> (ø)

infra/src/mqtt/client.rs
86.75% <100.00%> (+1.86%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.


Http.HEAD support?

Are there plans to add HEAD calls? I've got a personal project where I use head calls to make "does exist" calls, which should be smaller than normal get calls. It's not a deal-breaker for me, I was just wondering if there were plans to support this call?

implemented in latest beta version
public class MyEndpoint : EndpointWithoutRequest
{
    public override void Configure()
    {
        Verbs(Http.GET, Http.HEAD);
        Routes("/test-head");
        AllowAnonymous();
    }

    public override async Task HandleAsync(CancellationToken ct)
    {
        if (HttpMethod == Http.HEAD)
        {
            await SendHeadersAsync(h =>
            {
                h.ContentLanguage = "en-US";
                h.ContentType = "application/json";
                h.ContentLength = 512;
            });
        }
        else
        {
            await SendAsync(new
            {
                FirstName = "test",
                LastName = "test"
            });
        }
    }
}

Great! THANKS!


[FLINK-29679][table] DESCRIBE statement shows column comment

What is the purpose of the change
DESCRIBE statement print column comment to make results user-friendly, such as help analysts write sql adaptive to corresponding business logics.
Brief change log

use new schema framework to get comment.

Verifying this change
This change added tests and can be verified as follows:
flink-table/flink-sql-client/src/test/resources/sql/table.q
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? yes

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@godfreyhe Thanks for your excelent review! I have refactored toSchema() as you figured.
Question: can we improve the conversion logic of ResolvedSchema to TableSchema ?
Answer: I used to remove rowtime attri during the  conversion from ResolvedSchema to Schema, but this will make about fifty test cases trigger the Calcite exception as follow:
Cannot add expression of different type to set:
set type is RecordType(INTEGER amount, VARCHAR(2147483647) CHARACTER SET "UTF-16LE" currency, TIMESTAMP(3) *ROWTIME* rowtime, TIMESTAMP_LTZ(3) *PROCTIME* NOT NULL proctime, VARCHAR(2147483647) CHARACTER SET "UTF-16LE" NOT NULL currency0, INTEGER rate, TIMESTAMP(3) rowtime0) NOT NULL
expression type is RecordType(INTEGER amount, VARCHAR(2147483647) CHARACTER SET "UTF-16LE" currency, TIMESTAMP(3) *ROWTIME* rowtime, TIMESTAMP_LTZ(3) *PROCTIME* NOT NULL proctime, VARCHAR(2147483647) CHARACTER SET "UTF-16LE" NOT NULL currency0, INTEGER rate, TIMESTAMP(3) *ROWTIME* rowtime0) NOT NULL

@flinkbot run azure


fixed issues [input not defined] && [region not defined] in nexrender-provider-s3 package

thanks for the fixes!


build(prettier): Enforces code format with prettier.

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/cipchk/ng-alain/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Enforces a consistent style by parsing code and re-printing it with its own rules that take the maximum line length into account, wrapping code when necessary.
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

Great!


Pixel Perfect test coverage

We need tests to cover Pixel Perfect functionality:

Add/Remove new layer
Changing opacity/position/scale/lock
Drag and drop

(should be implemented as three separate tests)
Honza

Tests for anonymous content are still missing

Changing opacity/position/scale/lock/invert
Drag and drop
Page reload
add/remove

Honza

The above list requires new API that allows the test to access the backend page (anonymous content).
Honza

Update list of missing tests:

Drag and drop
Page reload
add/remove (anonymous content, update existing tests)

Honza


[sil] Split library into subfolders, while still building as a single library still.

Specifically, I split it into 3 initial categories: IR, Utils, Verifier. I just
did this quickly, we can always split it more later if we want.
I followed the model that we use in SILOptimizer: ./lib/SIL/CMakeLists.txt vends
a macro (sil_register_sources) to the sub-folders that register the sources of
the subdirectory with a global state variable that ./lib/SIL/CMakeLists.txt
defines. Then after including those subdirs, the parent cmake declares the SIL
library. So the output is the same, but we have the flexibility of having
subdirectories to categorize source files.

@swift-ci test


Add negative condition to toggles

It would be useful for some consuming apps (i.e. Odyssey) to know if things like the audio or reduced-motion switchers are in use.
For example, Odyssey will (soon) respect user preference for low-motion by default, but if the reduced-motion switcher is present, use that rather than the system preference.
A test in Odyssey's code might look like:
let prefersReducedMotion = document.body.classList.contains('is-reduced-motion') || window.matchMedia('(prefers-reduced-motion: reduce)').matches;

Unfortunately, this will miss the case where the user has the low motion preference set on the system level but has specifically toggled off reduced motion using the switcher and I don't think there's a way to test for that.

Completed in https://github.com/abcnews/interactive-plugins/pull/6


Dynare

Figure out how to install Dynare on Matlab and Octave.

Matlab dep. notes:
type: rpm-ostree
install:
  - fontconfig
  - freetype
  - gcc # Needed compiler
  - gcc-g++ # Needed compiler # Not installed
  - gfortran # Needed compiler # Not installed
  - libnsl # legacy version of libnsl library # Not installed
  - libva-utils
  # - libva-vdpau-driver
  - libX11-devel # Not installed
  - libxcrypt-compat # provides libcrypt.so.1
  - libXext-devel # Not installed
  - libXi-devel # Not installed
  - libXmu-devel # Not installed
  - libXtst-devel # Not installed
  - vdpauinfo # Not installed


[CORE] [MINOR] Improve the error message of checkpoint RDD verification

What changes were proposed in this pull request?
The original error message is pretty confusing. It is unable to tell which number is number of partitions and which one is the RDD ID. This PR is to improve the checkpoint checking.
How was this patch tested?
N/A

cc @zsxwing

Test build #80124 has started for PR 18796 at commit f7524da.

+1, LGTM.

Test build #80124 has finished for PR 18796 at commit f7524da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80124/
Test PASSed.

LGTM

Thanks! Merging to master


Adding Bulgarian date resources

This commit adds partial support for the Bulgarian language, which can be used to make aria.utils.Date.format return formatted dates in Bulgarian.
cf #1767 for the last added language (date resources only)

@fbasso Thank you for your review!


update controller to use ApplicationController

Made a small tweak to allow the IDP to inherit from the app rather than a clean base controller.
Let me know what you think.

IIRC I specifically didn't inherit from Application controller because it would potentially provide unexpected results. When I've wanted to pull in stuff that other places in the app use, I've inherited from the IDP controller and used that

yes please do not inherit from ApplicationController.
The SamlIdp::Controller is really a controller Concern, and if anything, it should be refactored to follow the pattern here:
http://elegantbrew.tumblr.com/post/70990048275/controller-concerns-in-rails-4

I should also add: as implemented right now, it is possible to use within a Sinatra app:
https://github.com/18F/identity-dashboard/blob/master/spec/support/fake_saml_idp.rb


Update StartDate population on Program Engagement

Critical Changes
Changes
When a new program Engagement record is created with 'Active' status and is associated to a program whose start date is earlier than or equal to today , the Start date on the program engagement record is set to Today.
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Asteroids DoD document to see any additional details for the items below
- [ ] Place holder data is incorporated (Refer to Case Management Sample Data document)
- [ ] Base axe-core JEST test included for any new LWC (No critical violations)
- [ ] CRUD/FLS is enforced in Apex
- [ ] Permission sets are updated to account for CRUD/FLS for new object metadata
- [ ] All modified classes are unit tested (Apex) at 100% coverage
- [ ] UX approval or UX not necessary
- [ ] PR contains draft release notes

[X] Attach work item to the pull request with Lurch **Lurch:attach W-000000 or **Lurch:add
[ ] All acceptance criteria have been met

[X] Developer
[ ] Code Reviewer
[ ] QA

[ ] QE story level testing completed

W-7844135


Content mis-match

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7299ae60-af52-5fcf-cbf7-34bfab0b6d3e
Version Independent ID: b01704d8-aa5e-4585-2a6d-77bdf5df2752
Content: Configure Windows Server Failover Cluster on Azure VMware Solution vSAN - Azure VMware Solution
Content Source: articles/azure-vmware/configure-windows-server-failover-cluster.md
Service: azure-vmware
GitHub Login: @shortpatti
Microsoft Alias: v-patsho

content mis-match

@bhaskarbsingh Can you please elaborate more on the content mismatch, so that we can fix the document accordingly.
Please share details of mis-match.

@bhaskarbsingh Any update on the issue?

@bhaskarbsingh, can you please provide more details for the doc issue?   What do you mean "content mismatch"?

(Typing from phone)  Sorry for the late reply,
In here >
https://docs.microsoft.com/en-us/azure/azure-vmware/configure-windows-server-failover-cluster
(Please reference attached screenshot)  The “Configure Networking” link
(top) is mapped to “Configure windows failover cluster” below.
And Configure Windows failover cluster link take you to the home of
Microsoft Docs.
Hope it helps, I’m from VMware AVS team.
On Fri, Aug 20, 2021 at 22:04 Patricia McPhee @.***>
wrote:

@bhaskarbsingh https://github.com/bhaskarbsingh, can you please provide
more details for the doc issue? What do you mean "content mismatch"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/79850#issuecomment-902678077,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOQLTIKTK4M7ZJN4KS3IIX3T5ZHF3ANCNFSM5CLLCIZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@bhaskarbsingh Thanks for sharing the details.
@shortpatti The issue is related to TOC, please find below screenshot.

@bhaskarbsingh, thanks for catching this; I did see it last week.  I'll make that change this morning.

#please-close
content updated 8/23/2021


Installer improvements

Feature selection, online installer support and merge modules for runtime redistribution

These are now merged but not available in a snapshot yet.  Marking it as fixed even though there are a few more tweaks on the way (but are outside of these items).


Broadcaster 2.3.0 error

Version information

Component
Version

Plugin (/brc status)
2.3.0

Bukkit/Spigot (usually accessible using /version or /about)
patched_1.15.2.jar:git-Paper-374

Bug description
When trying to put any command, it generates an error in console.
Console: https://paste.enginehub.org/c1jXLhg1-
Additional context
Is there anything else that should be taken into account?

Seems like the plugin has been disabled (plugin is disabled).
Please provide your full server log (preferably as an attachment).

2020-07-21-8.log
Sorry for the delay, but there are many logs, I had to find which one was xD
Now I am using a version before 2.3.0, because it works well for me.

Found something interesting:
[04:11:09] [Server thread/INFO]: [Broadcaster] Enabling Broadcaster v2.3.0
[04:11:09] [Server thread/INFO]: [Broadcaster] Startup...
[04:11:09] [Server thread/INFO]: [Broadcaster] Loading configuration...
[04:11:09] [Server thread/ERROR]: [Broadcaster] Failed to load configuration files!
[04:11:09] [Server thread/ERROR]: [Broadcaster] plugins/Broadcaster/json/visit-github.json (No such file or directory)
[04:11:09] [Server thread/INFO]: [Broadcaster] Disabling Broadcaster v2.3.0
[04:11:09] [Server thread/INFO]: [Broadcaster] Shutdown complete.

Seems like the example json file visit-github.json does not exist.
Please check whether you have an entry in your messages.yml file with the Type set to json. As stated in the wiki, the Definition key defines which file should be loaded. You must either remove the entry from the messages.yml file or create the respective json file. Doing so should resolve your issue.
Please try that and report back, thanks!


Add AudioContext to the features that can be searched in caniuse.com.

Add AudioContext to the features that can be searched in caniuse.com.

This issue was imported from Google Moderator
Moderator votes: +12
Issue added by ____ on 2014-07-21
To vote this issue up or down, simply include +1 or -1 in your comment.

Already part of http://caniuse.com/#feat=audio-api


IFrame modal fails on mobile

The iFrame in the modal is not responsive at a mobile resolution.

Any updates? I am having issues with the scrolling of iframe content on mobile...

Any updates?

Closing in favor of #77


Support Python 3.9

Codecov Report

Merging #38 (459cf45) into master (60186bd) will increase coverage by 0.09%.
The diff coverage is 100.00%.

:exclamation: Current head 459cf45 differs from pull request most recent head bed5434. Consider uploading reports for the commit bed5434 to get more accurate results

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   86.20%   86.30%   +0.09%
==========================================
  Files           7        7
  Lines         145      146       +1
==========================================
+ Hits          125      126       +1
  Misses         20       20

Impacted Files
Coverage Δ

manage_fastapi/constants.py
80.00% <100.00%> (+0.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60186bd...bed5434. Read the comment docs.


Travis tests failing due to GPG keys

See failed test run: https://travis-ci.org/github/gchq/gaffer-tools/jobs/767189161
I am going to make a branch to try and resolve these GPG errors

@t92549 Do you know if this was the same error as reported in #417?

If it is not the same error then it could maybe be to do with #883. Either way, it was so long ago and no examples are provided it is hard to tell what this is referencing. I had a look through the past builds in travis and couldn't really see anything much failed due to ui tests.

@t92549 Fine, I will close #417 as it doesn't tell us anything extra.


Add a builder class for TestDruidCoordinatorConfig

Description

Cleans up a mess in the Unit testing world. TestDruidCoordinatorConfig is instantiated all over the place. When we update DruidCoordinatorConfig we shouldn't have to be updating the constructor for the test class in a ton of places if the new config is not applicable to the test. Instead the Builder will just automatically leverage the default. This should make future PRs related to coordinator configs less littered with one line changes to constructors.

Key changed/added classes in this PR

TestDruidCoordinatorConfig

This PR has:

[x] been self-reviewed.
[X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

This PR and several others are failing the packaging check with this message:
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.3:install-node-and-npm (install-node-and-npm) on project druid-console: Could not extract the Node archive: Could not extract archive: '/home/travis/.m2/repository/com/github/eirslett/node/14.19.0/node-14.19.0-linux-x64.tar.gz': EOFException -> [Help 1]

I think #12632 should fix this issue.