JDK Installed (with JavaFX) on Windows By Default

As reported on Reddit: https://www.reddit.com/r/java/comments/jxllez/java_development_on_windows_request_for/gcxf3l3/

This is probably the big one, though it's only indirectly a benefit to developers (which probably need to manage multiple JVMs) it has a big impact on the distribution of JVM applications to end users in the future.
Right now for good distribution on Windows you generally need to package the JVM with your application.
While this isn't overly difficult it makes Java apps seem bigger than they seem (especially if you don't have time to optimise with Java modules to get the size down) and increases friction.

This is not actually that great unless you happen to be targeting the version of the JDK and JavaFX that is included... not to mention you will still have to build or ship runtimes for your Linux and Mac distributions.
I would almost consider this a negative improvement.

You could make AdoptOpenJDK/JRE available in the windows store, that wouldn't be a big thing. JavaFX is a library and should come with the application.

@tbee shouldn't AdoptOpenJDK be the entity responsible for publishing a package to the Windows Store?

Maybe. Someone should do it. And that someone probably has a sense of responsibility / gain for having it in the Microsoft store. Not sure if AdoptOpenJDK has that. Microsoft may have, for promoting the use of the store.


feat(docs): fix bug google chrome < 114 not found

Fix bug chrome driver < 114 not found

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[x] Has associated issue:
[x] Required feature flags:
[x] Changes UI
[x] Includes DB Migration (follow approval process in SIP-59)

[x] Migration is atomic, supports rollback & is backwards-compatible
[x] Confirm DB migration upgrade and downgrade tested
[x] Runtime estimates and downtime expectations provided

[x] Introduces new feature or API
[x] Removes existing feature or API

@hoalongnatsu thanks for this!  I'm going to merge it.  Can I request your review on https://github.com/apache/superset/pull/29315 ?  It looks like a bigger fix to this same problem.  I don't use Chrome in my Superset reporting and could really use input from someone who is familiar with the problem ... which you seem to be.


Portfolio: desktop version

I have designed a portfolio desktop version.

I changed the branch and pushed it to the new branch. I think for that reason it was showing no file changed.

Thank you Alfredbis. You are great and very professional.


Apply / ApplybyID

Test API functions - projectActions.

Closing. Future work: Add apply for a contributor to request to join a flash org.


Update host for Hesan.He3 1.2.5

#163422

Microsoft Reviewers: Open in CodeFlow

[Policy] Reset Labels - Intentionally didn't update manifest version


Add janitza-gridvis to latest

Please add my adapter ioBroker.janitza-gridvis to latest.
This pull request was created by https://www.iobroker.dev 79ffd9b.

RE-CHECK!

@Garfonso Thanks for the hints.
I will check and change them in a fiew days / weeks :-D
here my comments on the first look:
Change to setObjectNotExistsAsync: OK, top. thanks
https://github.com/BenAhrdt/ioBroker.janitza-gridvis/blob/main/admin/jsonConfig.json#L178

I changed the major things

=> I create this value with the cronjob creater in the config. => ????

Ok, ignore my comment. Seems like I misread something.

So now i have to use the words.js?
As discussed in telegram, of course not. But strings that show up in UI should be either translated (if possible) or English.

i have implemented the translation.
so the Adapter will be included?

Re-Review will be done soon

hi,
thank you @Garfonso for the great check!
Here my my review feedback whats left:

when you only have jsonconfig add a globalDependencies for admin >=5.0.0
do you really log partly in a localized way? You can do that ,.. I wish you much fun when you get teh first chinese debug log to research an issue gg thats the reason why logs are usually always english
Is that number in the State ID really unique? What happens in the grid config or such when you delete something ... might get the ID reused? Else you end in total data mix ...

global dependencies will be added.
i will change the logs into english => your write.
the id is unique. if the user deletes a device and creats a new one a used id will not be used again.

Everything should be changed now.
I do some changes i reaction of a beta tester

Is something to do?


SetTag name problem

The "set" tag is backed by a set, but is more than that.
Compared to the old anonymous class impl, this one has some optimization based on the common super class of all its elements, so it can be slightly less performance intensive.
Maybe TypeHeuristicTag? CommonTypeTag? These two names aren't pleasing, need better suggestions.

@i509VCB suggested TypeInlinedTag, which I would take.


KOGITO-6458: Define default authentication method to be used by OpenAPI

@ricardozanini I have added an integration test and updated the README file to expand more on this new functionality.


Any way to record command history?

That is probably something the command you're executing should be capable of doing. e.g. through bash history

This request seems a little out of scope for the goal of this project.
Asciinema and the like is probably what you are looking for (if you're looking for a readily available tool).


we need to check functionality of incomplete form if not complete we need something like a pop up box to show or redirect to login (this is more of a nice to have)


Initial pass at boot autoconfig

Closes #717

Is this meant to eventually replace the DelegatedClientFactory in CAS?

Not quite, as that would be A LOT of work. But if the support here matures enough and gains interest from others to build and support other clients or enhance existing ones for Spring Boot, we could in the future shoot for a replacement.

I'm certainly missing the point, but I was not expected this solution. I thought you would have extracted the properties in a Spring Boot auto configuration class and have delegated the work to the PropertiesConfigFactory.
This factory already supports all the clients. I think it would be a lot easier.

I thought you would have extracted the properties in a Spring Boot auto configuration class and have delegated the work to the PropertiesConfigFactory.

If you meant for this in a CAS context, that would certainly be ideal and perhaps an ultimate goal but I am not going to do that at the moment. I do like the idea and concept in general; At the moment, I do not see a lot of gains from doing so and I would prefer for the change to provide more than just refactoring and code-clean up.
My proposal is a bit different; let's forget CAS for a second:

Spring Boot is a popular platform; many Java developers build apps on top of it.
Pac4j is a solid library for authn/authz; Spring Boot developers would want to use it in their own apps
Let's build support for SB directly in Pac4j to auto-configure clients based on properties using the SB model.
Let's wait and see who might be interested in using, contributing and maintaining this. (...which might be CAS dev, or a few other projects I can think of)
.
.
.
Things are near-perfect, complete and used by the community
Allow systems like CAS to use the native functionality with SB and Pac4j and clean up code there.

This PR, could for example, remain in WIP/Draft mode for quite some time to see if we run into anyone interested in this sort of functionality. We could then point them to this PR and gauge their interest. This PR is likely a good foundation for future development in this area, so long as there are folks interested to maintain, use and contribute to it. Let's find those before we spend more time on this.

I didn't mean it for CAS context. My point is to avoid work by using the PropertiesConfigFactory.
You have the Pac4jConfigurationProperties:
public class Pac4jConfigurationProperties {
    public static final String PREFIX = "pac4j";

    private Saml2Properties saml2 = new Saml2Properties();

    private CasProperties cas = new CasProperties();

Why not turning it into something like this?
public class Pac4jConfigurationProperties {

     private Map<String, String> properties;

Get all the properties, build the PropertiesConfigFactory and call build to get the Config.
We would not add CasClient, FacebookClient, ... as Spring beans but just the Config which has all clients inside it.
As I said, I'm certainly missing the point...

Thanks very much for the notes; let me explain better:

Get all the properties, build the PropertiesConfigFactory and call build to get the Config.

Absolutely. This is quite easy to do and requires the least amount of work. However, some possible issues:

Collecting settings into a general-purpose map/container of some kind does not allow for type-safety at compile and/or runtime.
There is no encapsulation, as one can in theory stuff anything into the map.
Using a general purpose map loses on the ability to use the Spring Metadata Processor/Generator.
Not having dedicates types for settings will, at some point, force developers to inject the map into other components to get direct access to a setting. Which means, they will have to refer to a setting by its String name (key) rather than a well-defined Getter, which makes maintenance very very difficult if we were to remove/rename settings. Such changes are usually invisible.
A general purpose map prevents Spring Boot to run validation events on names/values (i.e. prevent against unknown or badly formatted valued)

So indeed, my approach here requires a lot more work but it's argubly safer. That said, if you feel like we should continue with the factory as proposed, that would be just fine. We should know the alternatives, and then make a decision.

OK. This is very clear. Your approach is indeed safer.
My feeling though is that what you propose is too ambitious and maybe unnecessary in most cases. I would go for the basic implementation only based on the PropertiesConfigFactory.
That said, I prefer to have a real target for a new implementation and I have always had the feeling that the CAS pac4j configuration should be fully delegated to pac4j if possible.
So for you, is the global PropertiesConfigFactory solution unacceptable to be used in CAS for pac4j configuration?

So for you, is the global PropertiesConfigFactory solution unacceptable to be used in CAS for pac4j configuration?

Yes, I'd say so, for all the above reasons and not to mention that moving from "cas.authn.pac4j" as the configuration namespace to something like "pac4j.clients.xyz" is a major breaking change, and one that we wouldn't be able to successfully do without a major release...and perhaps with caution even then.
So for now, I can rework this pull request to be based on the PropertiesConfigFactory and we can then give this some time to brew and collect feedback. With time, things might improve/change for the better one way or another. Would this work?

Sure. Let's do that. Let's start with as basic solution based on the PropertiesConfigFactory and see how where it goes...

Sounds good. Will do.

Closing in favor of https://github.com/pac4j/pac4j/pull/1550


ERROR: CANCEL read_loop, websocket updates loss

Bug description
I'm trying to get kline data via a web socket. Interested in closing candles. I noticed that some of the data is lost, although if you check in parallel through postman, then all updates come there.
Also, my python script periodically throws a CANCEL read_loop error. I think the data loss is related to it.
To Reproduce
Run my simple code:
#!/usr/bin/env python3
import re
import time
import asyncio
from datetime import datetime
from binance import AsyncClient, BinanceSocketManager

async def websocket(client=None, symbol=None):
  bm = BinanceSocketManager(client)
  symbol = symbol.lower()
  ms = bm.multiplex_socket([
    f'{symbol}@kline_1m',
    f'{symbol}@kline_5m',
    f'{symbol}@kline_15m'
  ])
  while True:
    async with ms as stream:
      msg = await stream.recv()
      if msg.get('data').get('k').get('x'):
        interval = re.search(r'kline_(.+)', msg.get('stream')).group(1)
        otime = datetime.fromtimestamp(msg.get('data').get('k').get('t')/1000)
        print(f'{interval} {otime}\n{msg}\n')

async def main():
  client = await AsyncClient.create(testnet=False)
  await asyncio.gather(
    websocket(client=client, symbol='TRBUSDT'),
  )

asyncio.run(main())

Expected behavior
Continuous acquisition of all data from the stream(s) without loss.
Environment:

Python version: 3.11.9
Virtual Env: no
OS: CentOS
python-binance version 1.0.22

I just wrote my simple multiplex socket using pure websockets version 13.1. It works just great, no errors, no data loss.
It turns out that the problem is in python-binance.

Hi @Ramesses3 ,
I was able to reproduce the error. The issue is that the while loop needs to be inside the stream context:
    async with ms as stream:
        while true:

If not the stream will continuously connect and reconnect on each message, and this is whats causing the Cancel read loop log and the probable loss of data

Hi @pcriadoperez ,
Thank you! I'll give it a try.

@carlosmiei thank you one more time. Now it works fine!

@carlosmiei thank you one more time. Now it works fine!


Update vendor for containers/image

Update the vendored commit for containers/image, because the previous version did not include the function ListNames() in transports.  This is needed for #636

@nalind @mrunalp @runcom PTAL

Seems ok if tests pass

LGTM

LGTM


Voucher Request

As a practice member, on my home Screen I would like to raise a voucher request for my assigned credentials.
AC: Given I am a practice member , when I click on my home page, I should be able to raise a voucher request and submit that for approval.
AC: Given I am a practice member , when I click on my home page, I should be able to see Voucher Request screen, where I should be presented with the question "Do you already have a Voucher" ? which is default set to true.
AC: Given I am a practice member , when I select the toggle to false, I should be presented with the another screen, requesting to fill the below information:

Credential Name
Exam Date Time
Status
Proof of Preparation
Reason for not Providing the POP
Upload the appropriate file referred for preparation.

AC: Given I am a practice member ,  on my Voucher Request screen I should also be able to see  "Submit for Approval" and "Cancel" Button.

1/8- To connect with Alok and confirm if this story is good to start

https://github.com/NessDigitalEngineering/salesforce-practice-studio/wiki/Design:-Voucher-Assignment - Can get started with Service Class.
@dipshikanalawadeness

Working as expected.


.Net: BingConnector configurable endpoint

Ability to configure bingconnector uri to support contoso custom search api v7 endpoints.. Right now uri is hard coded in BingConnector:
public async Task SearchAsync(string query, CancellationToken cancellationToken = default(CancellationToken))
{
Uri uri = new Uri("https://api.bing.microsoft.com/v7.0/search?q=" + Uri.EscapeDataString(query) + "&count=1");

This is added in #3357

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.


Update Read.md

Temporary update of Read.md

Thanks @MarinMaksutaj but we are working on a more complete README.

If you need any help I would be very happy to collaborate.
On Aug 24, 2016 8:45 PM, "escudero89"<EMAIL_ADDRESS>wrote:

Thanks @MarinMaksutaj https://github.com/MarinMaksutaj but we are
working on a more complete README.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mercadolibre/javascript-style-guide/pull/4#issuecomment-242168824,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AS_nVbICMXuGIMopryY3_LDnN4iqQrX1ks5qjJFMgaJpZM4Jn2n5
.

Thanks a lot! We'll let you know 😉. Greetings!


Add insertSpaceAfterTypeAssertion Formatting Option to TSServer Protocol

#10402 added a insertSpaceAfterTypeAssertion formatting setting. We'd like this exposed in the TSServer protocol so that users can configure it in VSCode: https://github.com/Microsoft/vscode/issues/10296

Could someone kindly pick this up? It has been a blocker for VScode to autoformat TS appropriately since August last year. Thanks greatly!

Sorry for the delay, fell off my list.

Note that insertSpaceAfterTypeAssertion doesn't work with sintax
(a||b)


Display the env name in the terminal

Hi!
Currently, the env name is not displayed in the terminal as virtualenv does. It's hard to know if an env is activated, on which we are working... This script seems to do the job:
function venv_ps1(){
    test -n "$VIRTUAL_ENV" && echo "($(basename "$VIRTUAL_ENV")) "
}
PS1="$(venv_ps1)$PS1"

From here.

Yes, this is known and documented
Unfortunately, there's no cross platform way to fix this. Automatically modifying the user's configuration file could be a recipe for disaster.
Detecting if the user's prompt doesn't have such information and warn him about it could be an improvement, and a good enough workaround for this issue. I attempted something like that, but unfortunately that's impossible due to the fact that PS1 is not a proper env variable, but it's "magic internal state" (or at least it seems to behave like this):
bash -lc "echo \$PS1"

doesn't echo anything, nor does
echo "echo \$PS1" | bash -l

work
I even tried by supplying a fake tty (maybe the problem is that bash doesn't create the PS1 unless it's a tty)
from subprocess import Popen, PIPE
import pty
import os
import sys
import tty

master, slave = pty.openpty()
p = Popen(['bash', '-l'], stdin=slave, stdout=PIPE, stderr=PIPE)
pin = os.fdopen(master, 'w')
tty.setcbreak(sys.stdin)

pin.write('echo $SHELL\n')
pin.write('echo $PS1\n')
pin.write('exit\n')
print(p.stdout.readline())
print(p.stdout.readline())
print(p.stdout.readline())

For now I'll leave this issue open, in case you have some insights/tips to share, but since this bug cannot be acted upon, I'll otherwise close it in the following days

I have this in my .bashrc:
export PS1="$ "
if [ -n "`pew show`" ]; then
    export PS1="(`pew show`)$PS1"
fi

Hi @ryanhiebert! For me, your solution displays an annoying "pew-show [venv]" when there isn't a venv active. In bash it seems very good to use the "($(basename "$VIRTUAL_ENV")) " solution from @Vayel. Please let me know if I'm missing a good reason to prefer using pew show - thanks!

Oh, sorry about that. I misunderstood what pew show does. My fault. (I re-created pew show in my own version of pew that did what I thought pew show did, but that's not what pew does). So the "($(basename "$VIRTUAL_ENV")) " is a good way to go then.
Sorry for the confusion.

Automatically modifying the user's configuration file could be a recipe for disaster.

I changed idea, upon seeing how tools like opam (and others) handle it
Leaving the choice to the user (and defaulting to not modifying anything, while explaining how to do it manually) seems a good choice.
Also, thanks to the simplified entry points (there's only one now), it's easier/cleaner to add a check for the first-time-setup
So now, when running pew for the first time in a new $WORKON_HOME, it will check if your $SHELL config file includes pew's "shell config" (which loads completions and provides prompt customization)


With Wiki plugin: Warning: filemtime(): stat failed

When using the Wiki plugin https://github.com/funktechno/kanboard-plugin-wiki/, displaying a Wiki page with editions (versions) yields

Warning: filemtime(): stat failed for plugins/Kanext/Skins/itcafe.css in /var/www/app/app/Helper/AssetHelper.php on line 37

I think this issue has been fixed with the newer versions. Can you please confirm?

Yes, this does not happen anymore.


added Imin and Imax to the pin entries

I agree with Leo that "pins" and "authorship" should be free-form but then wouldn't it be better not to signal unknown-fields in a warning?

@areda0 :  That was my comment about free-form fields.  I could go either way, with or without a warning message.  I think you're probably right, and I'd add that the more important thing is to check that certain entries are present---because an IP block should not be considered verifiable or reusable unless it has a designer name and a license, for example.  Those things should probably not be checked as part of writing the markdown output, but rather checked as part of a "precheck" step like we do for Efabless chipIgnite submissions, which would just be another "parameter" like DRC and LVS checks.
Obviously there are many ways to slice this cake.

Hi @areda0, the documentation changes for Imin/Imax are missing in this PR.
Hi @tim, I still think it has a benefit to check against known keys so that the entries are more consistent from IP to IP and to prevent people from inventing different ways to spell the same key (e.g. imax vs Imax). If any important keys are missing we can easily add them. For anything more free-form, there's always the note entry. But I agree that all entries should be written out to the Markdown summary.
I also agree that the function for the Markdown summary is not the right place to check these entries, but neither is a parameter.
This should really be done after the datasheet has been parsed. There is already the right function where this can be added: validate_datasheet in cace_read. If this is alright for you, I can add this to my to-do list, but I would suggest that Ahmed still finishes this PR the way it is currently implemented.

Hi @areda0, is this PR still valid? It's missing documentation changes.

@mole99  please check the latest commit.
I think we need to consider Tim's suggestion from the 1st comment that the pins should be automatically added from the symbol or the Layout. Is that something easily doable?

@areda0 It is not trivial. How would we edit the datasheet, since if we dump the yaml, all structure and comments would be lost? For starter, you could create a separate issue and we can discuss it on thursday.

@mole99 let's wait till we discuss it in more details and then decide whether we wish to create an issue for this one.

Merging after discussion.


fix: start error and update deps

with the origin code, if i run the project, log says
ts=2023-12-14T03:12:33.160907Z caller=level.go:71 level=debug collector=vsphere msg=describe
ts=2023-12-14T03:12:33.161083Z caller=level.go:71 level=debug msg="starting the server"
ts=2023-12-14T03:12:33.161089Z caller=level.go:71 level=debug msg="server stopped"
ts=2023-12-14T03:12:33.161092Z caller=level.go:71 level=error msg="error running exporter" err="no web listen address or systemd socket flag specified"

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jiaxin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


OrderBy does not work for nested collections with LoadStrategy.JOINED

Describe the bug
When loading nested collections using the LoadStrategy.JOINED it only orders by the first collection. For instance:
Project has Collection
Radio has Collection
both radio and option have a property order. When using LoadStrategy.JOINED it creates one query to load all entities and it only orders by the order of Radio. When using LoadStrategy.SELECT_IN it creates multiple queries and it orders by the order of Radio and the order of Option.
To Reproduce
Steps to reproduce the behavior:

Checkout PR xxx
yarn test GHxxxx

Expected behavior
Should sort on both orders.
Versions

Dependency
Version

node
?

typescript
?

mikro-orm
?

your-driver
?

@B4nan please have a look at the fork of @TiesB he build a fix for this: https://github.com/TiesB/mikro-orm/commit/2183bb7486b168fd1ae1f72bb2002f5589c55d84

@B4nan please have a look at the fork of @TiesB he build a fix for this: https://github.com/TiesB/mikro-orm/commit/2183bb7486b168fd1ae1f72bb2002f5589c55d84


Add for property to alert definitions to set violation period to trigger on

Setting the optional for clause in alert definitions causes Prometheus to wait for a certain duration between first encountering a new expression output vector element and counting an alert as firing for this element. In other words, Prometheus will check that the alert continues to be active during each evaluation during the for setting interval before firing the alert.
Note: Elements that are active, but not firing yet, are in the pending state.
Test: Buildkite CI
Explain how you tested your changes here.
Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

I think the following should fire immediately given they are not affected by nodes crashing

NoNewSnarks: a node should start receiving snark work after it restarts and doesn't have to wait till it is synced)
NoNewTransactions: a node should start receiving transactions after it restarts and doesn't have to wait till it is synced)
OldBestTip: this metric is set during catchup
LongFork: We use the max value so 0 because of restarts are ignored

It might not make sense to set wait times for alerts that use metrics set by watchdog itself since each have their own time interval

Coda_watchdog_cluster_crashes is set once every 30 mins
Coda_watchdog_nodes_synced_near_best_tip is set once every hour
Coda_watchdog_nodes_synced is set once every hour
Coda_watchdog_pods_with_no_new_logs is set once every 10 mins
Coda_watchdog_recent_google_bucket_blocks is set once every 30 mins
seeds_reachable once every hour

Suggest setting a 10 min wait time for the following metrics that could get triggered when our seed nodes crash. The wait time is not too long that we'd be late to react to actual issues and long enough (I think) to eliminate any crash related alerts when metrics are set to 0 or restart.

LowFillRate
LowMinWindowDensity
LowPeerCount

Setting wait-time for the following is a lil tricky because they can get triggered when nodes are catching up and there are empty blocks that are in the best tip that may have already been resolved. So we'd have to wait till the restarted node syncs. That would be too long and wasted time if there are new empty blocks. In which case it'd be better to start debugging it asap. So i'd suggest leaving them as is. Would be nice to have a Synced label for these expressions so that we use metrics from synced nodes only

NoTransactionsInSeveralBlocks
`NoCoinbaseInBlocks

!approved-for-mainnet


Remove user from a role for a set amount of time

All right so basically I'd like to know the simplest way of removing a user from a role for a custom amount of time. For example +roleBan <user> <time>. The role ID isn't needed since it will always be the same.
However, this role is self-assignable - how could I make it so it gets removed again if they assign it to themselves again, before the ban period is over?

Seeing as YAGPDB doesn't expose access to role assignment update events, probably programming your own bot functionality... otherwise, that's more of a question for the support server.


Prepare support for Ember Simple Auth 1.0

Ember Simple Auth is working on a 1.0 release.
One of the main reasons I'm looking forward to it is because it has support for Ember 2.0+
There is currently a jj-abrams branch for the 1.0 version development (see https://github.com/simplabs/ember-simple-auth/pull/602)
It would be great if the Auth0 plugin could work with the ESA 1.0 version when it is released.
I know there is at least 1 breaking change:
The namespace for the library changed from simple-auth to ember-simple-auth.
There is a demo application for using ESA 1.0 here https://github.com/simplabs/ember-simple-auth/tree/jj-abrams/tests/dummy

+1

The new ember-simple-auth has been released now, and now this library doesn't work properly any more.

There is a pull-request here #10. If we can get that in, that would be great.

#10 is merged in so this one can be closed


Incorrect ADC Output Data Formatting on EFR32BG22 IADC Peripheral

Describe the bug
The EFR32BG22 MCU's IADC peripheral supports flexible output formatting, allowing configurations for 12-bit, 16-bit, and 20-bit data formats with programmable left or right alignments. The default reset value of the ALIGNMENT register sets the ADC output data to 12-bit right-aligned. However, the default Gecko driver implementation assumes the ADC output data to be 12-bit left-aligned, with no option to cleanly change the data alignment. As a result, EFR32BG22 MCU's (and likely many others as well) return incorrect ADC values due to this assumption.
Workaround
Modify the GECKO_DATA_RES12BIT(DATA) macro to use the correct 12-bit mask without a shift, accommodating the right alignment.
This is the patch for iadc_gecko.c (zephyr\zephyr\drivers\adc\iadc_gecko.c):

Left: Original, Right: Patch
Proposed Fix
Introduce a new child ADC node property to define the ADC output alignment, and apply the correct register configuration, as well as the appropriate shift and masking, based on the selected data format.

Name
Type
Details

zephyr,alignment
string
Legal values: ADC_ALIGN_LEFT, ADC_ALIGN_RIGHT

To Reproduce

Configure the IADC on an EFR32BG22 (e.g., BG22 Thunderboard).
Write a small program to take ADC readings.
Compare the input voltage to the output reading from the ADC and observe incorrect readings.

Expected behavior
The output reading from the ADC should correctly correlate with the input voltage based on the selected alignment.
Impact
This issue causes incorrect ADC values due to misinterpretation of the ADC output data format.
Logs and console output
N/A
Environment

OS: Windows 11
Toolchain: Zephyr SDK 0.16.3
Zephyr Version: v3.5.0

Additional Context
Would this issue warrant spawning a feature request that introduces a more flexible solution, addressing the ADC output alignment configuration for any part, not just for the EFR32BG22? A general feature could provide options for configurable alignment and bit-width across multiple platforms.

When it comes to the bug, it seems to have already been fixed in #67399.
As for the proposal for a more flexible solution: I don't think specifying alignment is sufficient to make it a useful configuration option for users of the driver, as there is nothing to guarantee that the void *buffer used by the API for samples has a certain layout:

The buffer must be of an appropriate size, taking into account the number of selected channels and the ADC resolution used, as well as the number of samplings contained in the sequence.

It seems to me that the API allows drivers to put 12-bit samples into either 16-bit or 32-bit words, or even densely packing them 2 samples per 3 bytes, and that this is all driver-specific. Without also specifying the expected bit width of each sample in the buffer, it's not possible to know what to align the sample to.
Also: DeviceTree is intended to describe the hardware. The alignment of samples within a buffer seems to me to maybe stray too far towards being software configuration rather than hardware configuration, despite technically being a question of "if you dump hardware register state into a buffer without modifying it, what format does it have?". Even if the sample alignment properties of the hardware are exposed and implemented by the driver, the user of the ADC API doesn't really gain anything from it at a generic level. If they know which hardware they're using, they get some more control of the layout of the buffer, but it doesn't transfer between implementations. As such, it might be more appropriate as a Silabs-specific property if it was to be added.
Since the bug on EFR32 was already fixed in 3.6 and 3.5 is EOL, I'm closing this bug report.
@anangl @decsny How do you want to handle the secondary feature request?


Cannot 'go get' this package

It has a dependency on thebotguys/signalr, which is a repository that cannot be found

same story


CUDA version

I installed thudergbm with wheel file thundergbm-0.3.4-py3-win64.whl. And there is an problem in thundergbm.dll. It finds cusparse64_10.dll, but there is only cusparse64_100.dll in CUDA 10.0. So it cause WinError 126. When I search cusparse64_10.dll on Google, it exists in 10.1 only. If you using CUDA 10.1, then I recommend to build file again or to fix README.

Thanks. We will fix the readme file.

Thanks for reminding me.  I have rebuilt the .whl file by using CUDA 10.0.1. You can download the newest file and install it through pip now. Also, I have renamed the .whl file according to PEP 491 in README.md.


[TC Automation] PWX-36703 Add test case

What this PR does / why we need it:
Adds test cases KubevirtVMVolHaIncrease,KubevirtVMVolHaDecrease
Which issue(s) this PR fixes (optional)
Closes # PWx-36703
Special notes for your reviewer:

Closing this PR since these changes have gone in PR


This extension, kubernetes-client, java-generator and sundrio versions: Oh my!

Trying to use the Quarkus Operator SDK together with the kubernetes-client java-generator easily ends up with compile time issues on the sundrio shared dependency.
Rationale:
This extension uses a specific version of sundrio at compile time.
Using sundrio in the same compilation unit requires the user to align the version of the library with the original one from the extension.
E.g.:
here: https://github.com/andreaTP/bink8s/blob/0177a66e4b31225c0b5a91e5694e80a3d3127df4/pom.xml#L21
I'm forced to use the version of sundrio from kubernetes-client 5.12, despite the java-generator only ships and tests with 6.X.
The errors are pretty obscure as you can imagine (missing methods and similar).
Should sundrio be used as a shaded dependency in this project?

How would you go about doing it, though? I don't have a lot of experience with shaded dependencies but have been bitten by them before so I would like to have a clearer idea of what changes would help and how…

@andreaTP do you still think this should be addressed? The dependencies seem to be more or less in control now…

Some time ago I added sundrio to the fabric8 client extended BOM, I think we can close this now.
Thanks for checking on me!


Update the Go version in more places

Use Go 1.22 in Google Cloud Build and a CI job.
/cc @mresvanis

/lgtm

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.63%. Comparing base (fa23a9b) to head (5334d80).
 Consider uploading reports for the commit 0e1583b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   79.09%   71.63%   -7.46%
==========================================
  Files          51       65      +14
  Lines        5109     4474     -635
==========================================
- Hits         4041     3205     -836
- Misses        882     1073     +191
- Partials      186      196      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Review and detail opportunities to better align (and stay aligned with) with ARIA widgets

Source specs: https://www.w3.org/TR/wai-aria-1.1/

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA


Citekeys are different between roam research and local Better BibTeX

If I'm not misunderstand, Zotero-roam uses synced Citation Key column in the local Zotero as the citekey in Roam.
However, in Roam:

In Zotero:

Pin the citation key in Zotero and restart the js plugin works. That's my ignorance ......😂

works for me, thank you


Market quickbar perma linked between all characters after using

I have 1 account with 3 characters, let's just call them A B and C. Let's say A, the main profile which I want to copy, contains a series of items in the market quickbar. After using this tool, while my settings are properly copied over, the market quickbar becomes permanently sync'd between all 3 characters. So for example, let's say on character B I delete everything in the quickbar: it's now deleted also for A and C. If now on C I add an item to the market quickbar, it's also added to A and B. There is no longer any way to maintain separate market quickbars between characters. This doesn't seem to affect things like the notepad or people and places, but I'm wary about other potentially linked settings.
Please note this isn't unique to your app: this same behavior will happen if you manually copy the core_char_xxx.dat files, so I'm not sure if your app is just simply doing just that, or if it has the ability to actually read the binary data and thus come up with some sort of fix/workaround.
If there is a workaround to this issue please let me know. Things seem to work fine otherwise though.
Edit: Actually, this may be a non-issue. I did a test where I nuked all my char profiles to start fresh and the same behavior happened. The market quickbar may just be linked between all chars on an account and thus this may not be a bug/issue at all with the program.

Disregard. This is intended behavior for characters on the same account.


[WFCORE-3606]: Covariant issue when compiling with java 9.

Casting to fix the issue.
Jira: https://issues.jboss.org/browse/WFCORE-3606

I don’t think this is the right fix. What we probably ought to be doing is adding a profile which is activated on JDK9 or higher which sets the release property of the compiler plugin to 8, else we will hit this problem again.

probably better if we just override maven-compiler-plugin for deployment-scanner
and set 8 in it.
we cannot do that globally yet.


Replaces Azure Remote Debug functionality with opening the help page.

See also #1306 (same fix for 2.x branch)

:+1:


Please invite me to the community

Name
Austin Axtell
Additional Context
Hello everyone, I am Austin 👋
I hope to join this GitHub Org of writers and developers! My goal is to share my experiences and learn from others, so we can all grow together. Here's a bit more about me:
👨💻 I work as a Frontend Developer, which I love because it allows me to solve real-world problems with technology.
📚 I'm passionate about learning new things. Whether it's a new programming language or a cooking recipe, I enjoy the challenge of picking up new skills.
🤝 I believe in collaboration and teamwork. I think the best ideas come from diverse perspectives, so I'm eager to hear what everyone has to say.
Thanks for reading, and please don't hesitate to reach out if you want to chat or collaborate on a project!

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is an open source solution for serverless platforms, it is designed for developing solutions and enhancing creators to create their infrastructure 💻 Great to have you in our community ✨ Looking forward to your valuable contributions! 🤓 You can also check our community ✨ Github ✨ LinkedIn 💜 You can also share our community with other folks who want to learn about development, DevOps, tech, and contribute together and with us 👉💜👈


Add Participant metadata Blueprint nodes and events

The Participant metadata that can be changed are

name
avatarURL
externalID

These should be able to be set via a Blueprint node and events to track other participants’ changes.

@GaryMakinDolby The externalID cannot be changed via the C++ SDK. Is this required?

All good, thanks. When C++ SDK is able to change the externalID, we’ll create a new issue here.


Implemented callback mechanism in FlowContainer.

Implemented callback mechanism in FlowContainer.
Use log4j instead of slf4j in FlowContainer.
Added ServerUtils class to refactor common code across AzkabanExecutorServer and FlowContainer.

Pull Request Test Coverage Report for Build 6031

21 of 60 (35.0%)  changed or added relevant lines in 3 files are covered.
18 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 43.695%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-exec-server/src/main/java/azkaban/common/ServerUtils.java
6
7
85.71%

azkaban-exec-server/src/main/java/azkaban/execapp/AzkabanExecutorServer.java
0
1
0.0%

azkaban-exec-server/src/main/java/azkaban/container/FlowContainer.java
15
52
28.85%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractJob.java
2
37.93%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
3
54.64%

azkaban-exec-server/src/main/java/azkaban/container/FlowContainer.java
13
20.94%

Totals

Change from base Build 6028:
0.2%

Covered Lines:
16458

Relevant Lines:
37666

💛  - Coveralls

One general question regarding callback. Whenever flow container finishes or in case of job success or failure how this callback mechanism will be invoked.

Thanks for asking the question.
These callback gets added to FlowRunner and JobRunner as listeners. Every time there is a status change, an event is emitted, the listeners act based on those events.


easy theme added

Description

New theme added
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[ ] I have added tests to cover my changes, and all the new and existing tests pass.

Hey @Titivoot, thanks for contributing!
Can you please add your new file to clean_files.txt in order to lint it?
Another important thing is to add some documentation about your theme, because it is a simple one, you can just resort into adding it to the list of screenshots in our documentation. You can store the screenshot itself in our gh-pages branch :smile:
Let me know if you need any help!

@NoahGorny
Check shell style with shfmt................................................Failed
What am I doing wrong?

@NoahGorny
Check shell style with shfmt................................................Failed
What am I doing wrong?

You need to run shfmt on your code in order to format it, try installing it and use it by running lint_clean_files.sh

@NoahGorny
Ok, I have fixed it, is there anything I need to do?

@NoahGorny
Ok, I have fixed it, is there anything I need to do?

Well done!
The only thing I'm thinking could be useful is to add a screenshot of the theme to the docs. Check out the gh-pages branch and the list of themes page in the docs for reference :smile:

@Titivoot I saw that you indeed opened a PR, good job!!
The only thing that is missing is linking and adding the picture to the docs, this can be done in docs/themes-list/index.rst.  See the other themes and do just like them. Remember that they are sorted alphabetically.
I am impressed by your efforts, keep up the good work!

gentle ping @Titivoot


Cookie Consent removed from Template in 3.0

See https://github.com/aspnet/AspNetCore/issues/10346

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 28d0490e-205f-20a5-ace5-904f4c8ad78f
Version Independent ID: 4a2c8d95-fdd2-fdb1-b61d-802d0a8539c3
Content: General Data Protection Regulation (GDPR) support in ASP.NET Core
Content Source: aspnetcore/security/gdpr.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

GDPR 3.0 update outline

Keep the 2.2 version
The 3.0 version will be only one paragraph, which follows:

The ASP.NET Core 3.0 templates provide a stubbed out privacy page that you can replace with your privacy and cookie use policy.
To enable the cookie consent feature found in the ASP.NET Core 2.2 templates, see the enable cookie consent in 3.0 section. View the 2.2 version of this document for an explanation of the ASP.NET Core 2.2  GDPR support.

@blowdart  can your review my outline proposal to update the GDRP doc for 3.0?

Aye, fine.

Context is out of the box error - so please update


Linking AST, CFG, and PDG

Hello,
Before all, congratulations for your source code and your presentation, it is very very clean and structured. I executed and generated the DOT files. That's excellent !!
I saw that it's possible to generate separately files AST / CFG / PDG... but how to make a merge of the 3? It's possible for me to complete your source code in this goal ? I would like to reproduce a single global graph merged like the Code property Graph defined in this document http://user.informatik.uni-goettingen.de/~krieck/docs/2014-ieeesp.pdf
Thank you in advance for your help

I am pretty familiar with the Code Property Graph (CPG) by Fabian Yamaguchi. At the current moment, there is no link between AST and other Graphs. Although CFG and DDG (Data-dependency of PDG) are already connected. Although I'm planning on implementing this in the near future (in the next 2 to 3 months).
But if you really need it right now, you can help do this sooner. For this, you need to be fairly familiar with programming with Java and ANTLRv4. If you are experienced in these areas, tell me about it and I can give you some hints on how to implement this.

Thank you for your quick answer, I have an experience of many years in Java, but in ANTLR only a small experience. But no problem, I learn quickly and I am extremely motivated, so I can program with it. I can implement what is needed to perform merging very quickly because I need to have result as soon as possible.  So it will be very nice and helpful if you provide me the explanations quickly.
Thank you in advance.

I have to do a more through analysis of the code and the possible solutions for this feature. Meanwhile, you can do some study and learn more about how to program ANTLR applications. This conversion will continue through email.

Ok we cant do that.
I can program ANTLR right now. Don't worry about that.
We can give me your email please ?

Send me a message at s dot m dot ghaffarian at gmail dot com

Hi, any updates on these plans?


Doctor schema

Sir, can I create the schema for the doctor model that will have fields like name, specialisation, experience, education, rating.
Participant under gssoc’22

Hi @ayush25102001  go ahead and happy learning 🚀


Can't install via ansible-galaxy

First of all, I am new to ansible, maybe I'm doing something wrong. When I try to install docker.ubuntu with ansible-galaxy I get the following error.
OS: macOS 10.13.4
Python: 3.6.5 (homebrew)
$ ansible-galaxy install angstwad.docker_ubuntu -p roles/ -vvvv
ansible-galaxy <IP_ADDRESS>
  config file = /Users/okl/src/gitea/ansible/ansible.cfg
  configured module search path = ['/Users/okl/src/gitea/ansible/plugins/modules', '/usr/share/ansible']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible-galaxy
  python version = 3.6.5 (default, Mar 30 2018, 06:41:53) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-9<IP_ADDRESS>)]
Using /Users/okl/src/gitea/ansible/ansible.cfg as config file
Opened /Users/okl/.ansible_galaxy
Processing role angstwad.docker_ubuntu
Opened /Users/okl/.ansible_galaxy
Initial connection to galaxy_server: https://galaxy.ansible.com
Base API: https://galaxy.ansible.com/api/v1
- downloading role 'docker_ubuntu', owned by angstwad
https://galaxy.ansible.com/api/v1/roles/?owner__username=angstwad&name=docker_ubuntu
https://galaxy.ansible.com/api/v1/roles/292/versions/?page_size=50
ERROR! Unexpected Exception, this is probably a bug: '<' not supported between instances of 'int' and 'str'
the full traceback was:

Traceback (most recent call last):
  File "/usr/local/bin/ansible-galaxy", line 106, in <module>
    exit_code = cli.run()
  File "/usr/local/lib/python3.6/site-packages/ansible/cli/galaxy.py", line 150, in run
    self.execute()
  File "/usr/local/lib/python3.6/site-packages/ansible/cli/__init__.py", line 155, in execute
    fn()
  File "/usr/local/lib/python3.6/site-packages/ansible/cli/galaxy.py", line 393, in execute_install
    installed = role.install()
  File "/usr/local/lib/python3.6/site-packages/ansible/galaxy/role.py", line 236, in install
    loose_versions.sort()
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/distutils/version.py", line 52, in __lt__
    c = self._cmp(other)
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/distutils/version.py", line 337, in _cmp
    if self.version < other.version:
TypeError: '<' not supported between instances of 'int' and 'str'

It's because you're using Python 3.6 and because my release versions get compared as str because I have a v in the version, like v3.x.x.  You can either git clone or use Python 2 for now.

Oh, BTW, I definitely want to re-tag the entire repo without the v in the tags, but it's enough work that I just haven't found the time to do it.  I'd gladly take a script from the community that re-tags the whole thing.


Azure DevOps bug tracker should not require project admin

Describe the solution you'd like
To set up ADO for bug tracking, you need to use a project admin account. This is probably not the type of account you want to use for opening bugs. You should be able to use any account for this (even if a project admin account is used for configuration).
Describe alternatives you've considered
Making our bot account a project admin - we don't want to do this though as it poses a security risk.
Additional context
N/A

Thank you for the feature request. I have tagged a colleague who will triage it accordingly, have a great weekend.

Commenting to keep this open.

Commenting to keep this open. Again.

This is still an issue. @winnie any updates?

Still an issue.

Still an issue. And it looks bad that the bot is complaining about it being stale because no one is responding to the issue rather than it being me that isn't responding.

Still an issue.


added reports script and updated tasks.py to work out of box

Will submit PR with doc updates shortly.

Fixes #79


fix: Added IPAssignments type

Does it make sense to introduce an IPAddress.type enum with value IPAssignment if that field doesn't really exist in the API?
We've discussed alternative approaches elsewhere. Some of the fields that would be involved are not included in the spec, but can be seen via metal ip get -o yaml. We can also see these fields were included in packngo: https://github.com/packethost/packngo/blob/master/ip.go#L56-L130

field
apparent purpose

addon
(not documented) appears to be true for all approved elastic IPs, false otherwise

bill
not obvious if only or all reservations would have this as true, but also appears true for approved elastic IPs, false otherwise

state
reserved and non-reserved IPs will say "created" in their success state

requested_by
this field seems to have a User reference (href, id, short_id) with reservations, and is null (but present) otherwise

In terms of identifying that a particular JSON object is an IP reservation or a VRF IP reservation, that is already in place using the type enum as specified in the upstream spec, and I don't think we should change that; the case we are covering with this patch is how to identify that a  particular JSON object that is an IP reservation (or a VRF IP reservation) is not also an IP assignment.
The invalid type workaround was initially chosen because it lines up with how IPReservation and VrfIPReservation are differentiated.  By specifying an invalid value for type, we provide a way for the SDK to know that an IPReservation or VrfIPReservation is not an IPAssignment, without making assumptions about the other properties that are defined for IPAssignment.  Since the type is optional, the JSON for an IP assignment will still match the patched spec; since the type value specified for IPAssignment is not a value the API will return, the JSON for an IP reservation or VRF IP reservation will not match the patched spec.
Requiring the assigned_to property in the IPAssignment schema instead would be more direct, so I'm on board with that.

I'll go ahead and merge this; it's already been tested in metal-cli and we don't have a viable alternative.  We can revisit after #159 is addressed.


Some links in Javadoc are invalid

Because fully qualified names were not used and only class names were used, some links in Javadoc became invalid

This will lead to errors in generating Javadoc pages in the future. Do we have tools to check and resolve this issue during compilation

@laglangyue do you still experience this issue? I couldn't reproduce it from my IDE.

This renders ok, though I'm sure we have javadoc errors to prune.  Closing the issue


fix: common user can not modify name

Signed-off-by: sh1luo<EMAIL_ADDRESS>

@sh1luo demo link?

@sh1luo demo link?

http://<IP_ADDRESS>:8000/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Done by: https://github.com/casdoor/casdoor/commit/b91b4aec913842dc236937aca7d30ee5b37bc0fa instead, closed here.


Need a standard method to cancel ajax-form submission

Currently the method to cancel Ajax forms submission is to call xhr.abort() in the 'beforeSubmit' event, as suggested by "this post". But that leads to an Uncaught InvalidStateError at the code line "xhr.send(postData);" (Failed to execute ‘send’ on xhr, for the object's state is no more OPENED).
On the orther hand, jQuery has a norm method for this: just let the callback at the ‘beforeSubmit’ event return false to prevent erroneous data from actually sending it to the server. That design may be needed for the next releases of Framework7.

This could be good the have

I need it too!

Would be great :)

Great! ☺

How to cancel the previous xhr requests and keep the last one only ?


Docker Secrets

Refactor Docker instructions and docker-compose file to read sensitive variables from Docker Secrets.
https://hub.docker.com/_/nextcloud (section "Docker Secrets") can be used as an examples.

Never mind, this only seems to work with Docker Swarm, which we don't want to depend on.

Secrets can be used with Docker Compose, so it would be great if you could reconsider (Vaultwarden also supports using secrets in this way, for example)

I think this can be closed :smile:


Improve Accounts config options code

The code underneath AccountsClient.ui.config can be improved. The provided options object provided as an argument needs to be validated to make sure the user is setting valid keys and values.
Also, write tests :)

@davidyaha Am I correct in saying that since the introduction of Flow into the codebase, as long as we define a type for the config the check for valid keys will happen automatically in consuming code?

Yeah types will be autocompleted for webstorm or any ide with flow support.
We can add a build step that uses flow check to make sure the accounts packages code is consistent with the typings.
This does not mean we can ignore runtime checks where they are necessary..
And also, any user that does not use flow/ts will have no validation what so ever..

Okay, so we still need to include validation for valid keys in the provided options object.


update readme

Coverage remained the same at 51.147% when pulling 29615c6349d2966b21ebb3fdc3516080ade47ee8 on hainingzhang:master into e1b2ba0e23be35809f04f76d6c9418138a68c0a8 on vmware:master.


Option to pause at the end of each new subtitle

I like to read along with the subtitles at the same time the audio is played but also find the automatic pause useful if in case I need to lookup new words.

Thanks for the feedback. I could see this as another Subtitle Mode option. Do you have an idea for what this new mode might be called?

Perhaps "Hybrid-reading" or "Read-along"?


util: fix tracevol.py to work with dynamic value of volumeNamePrefix

tracevol.py works on static value of volumeNamePrefix, fixed it to work on the dynamic vale of the same.
Signed-off-by: Mudit Agarwal<EMAIL_ADDRESS>Fixes: #1143

/retest ci/centos/containerized-tests

Please restart, it failed here: ssh: Could not resolve hostname n43.dusty.ci.centos.org: Name or service not known

Please restart, it failed here: ssh: Could not resolve hostname n43.dusty.ci.centos.org: Name or service not known

we have an issue with centos CI, centos team is working on it.

/retest ci/centos/containerized-tests


Crash

I just downloaded linux64 version and try to run it with $ ./Atraci.
./Atraci: error while loading shared libraries: libudev.so.0: cannot open shared object file: No such file or directory

I resolved it running:
$ sudo apt-get install libudev1
$ sudo apt-get upgrade
$ sudo apt-get update


HBASE-24225 Backport HBASE-23833 to branch-2.2

…yncwal	 (#1301) (#1535)

Use Reflection to access shaded Hadoop protobuf classes.

(cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0)

Update to improve the code:

Added license.
Added more comments.
Wrap byte array instead of copy to make a ByteString.
Moved all reflection instantiation to static class loading time.

Use LiteralByteString to wrap byte array instead of copying it.

 Open this PR to let it run through precommit.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
2m 34s
Docker failed to build yetus/hbase:d9b4982ad4.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/1567

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1567/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Added tests to verify bug fixes

Hi Abhishek,
Please review these tests that are added to verify few bug fixes.
Tests marked with .fail extension are for the ones that have JIRA's currently open, I will enable them once a fix is in Drill master for such failing tests.
I will schedule a pre-commit test run and share link to pre-commit test run in another email.
Thanks,
Khurram

Thanks for adding these tests @kfaraaz!
+1

Thanks @Agirish  for your review.


Document node versions

Hi there,
At the moment, the app does not start using Node14. That itself probably isn't an issue yet as it is a very new version, however, it would be good to specify what Node versions should be used, probably just by adding engines to the package.json file.
I can do that - I assume we are targeting Node12 as that is what the Docker container is using

Hey,
good catch! I have not used node14 so far.
It would be nice, if you can create a PR with the engines.
We should identify the problem with node14, I assume it is not a big change to adapt.


Installation bug

After following complete instructions getting that error trying to install that package but not worked can you help me to sort out that issue.
D:\wamp64\www\laravel\laravel5-angular-material-starter>gulp && gulp watch
module.js:540
throw err;
^
Error: Cannot find module 'laravel-elixir'
at Function.Module._resolveFilename (module.js:538:15)
at Function.Module._load (module.js:468:25)
at Module.require (module.js:587:17)
at require (internal/module.js:11:18)
at Object. (D:\wamp64\www\laravel\laravel5-angular-material-starter\gulpfile.js:3:16)
at Module._compile (module.js:643:30)
at Object.Module._extensions..js (module.js:654:10)
at Module.load (module.js:556:32)
at tryModuleLoad (module.js:499:12)
at Function.Module._load (module.js:491:3)

Hi @rizwansultan88
I just followed the instructions on the docs and they are working
Are you sure you ran npm install?

Yes I tried npm install and npm update as well but no luck I'm following same you wrote in document both method also tried to install laravel-elixir separately but still no luck.

On my system Operating System Windows 10

That's weird, can you give me your node and npm versions?

npm version 5.6.0
node version 8.9.4

please try manually running npm install laravel-elixir --save-dev

Still no luck
D:\wamp64\www\laravelangular\laravel5-angular-material-starter>npm install laravel-elixir --save-dev

<EMAIL_ADDRESS>install D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-sass
node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node":
HTTP error 404 Not Found
Hint: If github.com is not accessible in your location
try setting a proxy via HTTP_PROXY, e.g.
  export HTTP_PROXY=http://example.com:1234

or configure npm proxy via
  npm config set proxy http://example.com:8080

<EMAIL_ADDRESS>postinstall D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-sass
node scripts/build.js

Building: C:\Program Files\nodejs\node.exe D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-gyp\bin\node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp info it worked if it ends with ok
gyp verb cli [ 'C:\Program Files\nodejs\node.exe',
gyp verb cli   'D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-gyp\bin\node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose',
gyp verb cli   '--libsass_ext=',
gyp verb cli   '--libsass_cflags=',
gyp verb cli   '--libsass_ldflags=',
gyp verb cli   '--libsass_library=' ]
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb check python checking for Python executable "python2" in the PATH
gyp verb which failed Error: not found: python2
gyp verb which failed     at getNotFoundError (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:13:12)
gyp verb which failed     at F (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:68:19)
gyp verb which failed     at E (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:80:29)
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:89:16
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\index.js:42:5
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\windows.js:36:5
gyp verb which failed     at FSReqWrap.oncomplete (fs.js:152:21)
gyp verb which failed  python2 { Error: not found: python2
gyp verb which failed     at getNotFoundError (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:13:12)
gyp verb which failed     at F (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:68:19)
gyp verb which failed     at E (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:80:29)
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:89:16
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\index.js:42:5
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\windows.js:36:5
gyp verb which failed     at FSReqWrap.oncomplete (fs.js:152:21)
gyp verb which failed   stack: 'Error: not found: python2\n    at getNotFoundError (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:13:12)\n    at F (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:68:19)\n    at E (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:80:29)\n    at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:89:16\n    at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\index.js:42:5\n    at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\windows.js:36:5\n    at FSReqWrap.oncomplete (fs.js:152:21)',
gyp verb which failed   code: 'ENOENT' }
gyp verb check python checking for Python executable "python" in the PATH
gyp verb which failed Error: not found: python
gyp verb which failed     at getNotFoundError (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:13:12)
gyp verb which failed     at F (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:68:19)
gyp verb which failed     at E (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:80:29)
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:89:16
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\index.js:42:5
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\windows.js:36:5
gyp verb which failed     at FSReqWrap.oncomplete (fs.js:152:21)
gyp verb which failed  python { Error: not found: python
gyp verb which failed     at getNotFoundError (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:13:12)
gyp verb which failed     at F (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:68:19)
gyp verb which failed     at E (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:80:29)
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:89:16
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\index.js:42:5
gyp verb which failed     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\windows.js:36:5
gyp verb which failed     at FSReqWrap.oncomplete (fs.js:152:21)
gyp verb which failed   stack: 'Error: not found: python\n    at getNotFoundError (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:13:12)\n    at F (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:68:19)\n    at E (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:80:29)\n    at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\which\which.js:89:16\n    at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\index.js:42:5\n    at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\isexe\windows.js:36:5\n    at FSReqWrap.oncomplete (fs.js:152:21)',
gyp verb which failed   code: 'ENOENT' }
gyp verb could not find "python". checking python launcher
gyp verb could not find "python". guessing location
gyp verb ensuring that file exists: C:\Python27\python.exe
gyp ERR! configure error
gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
gyp ERR! stack     at PythonFinder.failNoPython (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-gyp\lib\configure.js:483:19)
gyp ERR! stack     at PythonFinder. (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-gyp\lib\configure.js:508:16)
gyp ERR! stack     at D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\graceful-fs\polyfills.js:284:29
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:152:21)
gyp ERR! System Windows_NT 10.0.10586
gyp ERR! command "C:\Program Files\nodejs\node.exe" "D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd D:\wamp64\www\laravelangular\laravel5-angular-material-starter\node_modules\node-sass
gyp ERR! node -v v8.9.4
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
Build failed with error code: 1
npm WARN<EMAIL_ADDRESS>requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><6.0.0-0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: node scripts/build.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\User\AppData\Roaming\npm-cache_logs\2018-02-06T07_57_35_840Z-debug.log
D:\wamp64\www\laravelangular\laravel5-angular-material-starter>gulp
module.js:540
throw err;
^
Error: Cannot find module 'laravel-elixir'
at Function.Module._resolveFilename (module.js:538:15)
at Function.Module._load (module.js:468:25)
at Module.require (module.js:587:17)
at require (internal/module.js:11:18)
at Object. (D:\wamp64\www\laravelangular\laravel5-angular-material-starter\gulpfile.js:3:16)
at Module._compile (module.js:643:30)
at Object.Module._extensions..js (module.js:654:10)
at Module.load (module.js:556:32)
at tryModuleLoad (module.js:499:12)
at Function.Module._load (module.js:491:3)
D:\wamp64\www\laravelangular\laravel5-angular-material-starter>

Based on this issue, please try running:
rm -rf node_modules
rm package-lock.json
npm cache clean
npm install

Tried but no luck

Have you tried running this using another internet connection or maybe even another laptop?

I tried using another internet connection for sure I will tried it in another laptop and let you know.

Installed in another pc and facing same issues
^

Error: Cannot find module 'laravel-elixir'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (F:\xampp\htdocs\laravelangular\laravel5-angular-material-starter\gulpfile.js:3:16)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)

I fixed it using composer update command without that it neither be worked.

Hi
I have tried all the above solution but it still not working
module.js:540
throw err;
^
Error: Cannot find module 'laravel-elixir'
at Function.Module._resolveFilename (module.js:538:15)
at Function.Module._load (module.js:468:25)
at Module.require (module.js:587:17)
at require (internal/module.js:11:18)
at Object. (C:\laragon\www\chisumo-shop\gulpfile.js:2:14)
at Module._compile (module.js:643:30)
at Object.Module._extensions..js (module.js:654:10)
at Module.load (module.js:556:32)
at tryModuleLoad (module.js:499:12)
at Function.Module._load (module.js:491:3)

@chisumo2016 try to execute composer update  command


Adding macOS support

Aims to solve #1.
So this gets most of the examples running on macOS. ./gradlew runEarthExample and ./gradlew runTextureExample hang without even a window getting displayed. I had a poke around and found that resourcesVfs[path].readBitmap() in ExampleUtils.kt is the culprit. Gut feeling is concurrency issues but I don't know.
Disclaimer: don't know much about Kotlin or macOS native stuff.
This adds the jvm option -XstartOnFirstThread to the example programs. This is needed for things to run under macOS. See this issue for instance. I am guessing you may only want it set for running under macOS.
The main added code does this:
NSWindow *ns_window = glfwGetCocoaWindow(window);
[ns_window.contentView setWantsLayer:YES];
metal_layer = [CAMetalLayer layer];
[ns_window.contentView setLayer:metal_layer];
surface = wgpu_create_surface_from_metal_layer(metal_layer);

I got this snippet here.
I just have a macbook on me right now so I have not tested if things still work on other platforms.

runEarthExample and runTextureExample now work.
System.setProperty("java.awt.headless", "true") was needed. See this issue.

Hello - Thank you for taking on this task! Everything looks good, but as you said we can only provide -XstartOnFirstThread for MacOS. The JVM will crash if you provide it on Windows / Linux. Maybe you can define a variable called extraArgs at the top of the gradle file that is blank on Windows/Linux and -XstartOnFirstThread on Mac? If you have better idea on how to implement this, I am up for it.
For the texture issue, I have no idea. Everything appears to works fine on windows. The examples use a library called Korim so maybe file an issue there? This might be due to the fact that AWT and LWJGL don't play well together (I think Korim uses AWT).
Disclaimer: also don't know much about macOS stuff 😄

I fixed things up so that -XstartOnFirstThread is only added for macOS builds.


Using unconditional pertrained weight to train a conditional model

Hello,
Thank you for your great work!
Have you tried to train the conditional model based on the pertrained weight of the unconditional model? How does it performs?
How much worser would it be than training the conditional model from scratch?
Thank you.

Good evening
Thank you very much for your kind words, I appreciate it.
We did not perform any experiment using a pretrained, unconditional model as a base. Like with other pretrained models, we would need to add extra weights to account for the additional input (the conditioning vector). I am personally interested in personalizing generalized models with additional concepts, which is a closely related topic, so I may try and do some research on this matter in the future.

Thank you for you reply


Does not detect connected device and tries to launch Android Studio which is not installed

I have connected my device and can see with adb devices -l :
List of devices attached
WCB665T87LAA7L6L       device usb:2-2 product:RMX3392 model:RMX3392 device:RE879EL1 transport_id:3

But on running pnpm tauri android dev :

><EMAIL_ADDRESS>tauri /home/john/Desktop/tauri
> tauri "android" "dev"

✔ What external IP should we use for your development server? · <IP_ADDRESS>
Running BeforeDevCommand (`PUBLIC_TAURI_DEV=true pnpm run dev`)

><EMAIL_ADDRESS>dev /home/john/Desktop/tauri
> vite dev

Warn Waiting for your frontend dev server to start on http://<IP_ADDRESS>:5173/...

VITE v4.0.4  ready in 1677 ms

➜  Local:   http://localhost:5173/
➜  Network: http://<IP_ADDRESS>:5173/
Info detected host target triple "x86_64-unknown-linux-gnu"
Error No available Android Emulator detected
Info Opening Android Studio
Error Launch failed: Failed to wait for child process for command "Android Studio" to exit: No such file or directory (os error 2)
^C ELIFECYCLE  Command failed.
ELIFECYCLE  Command failed with exit code 130.

I use Arch linux with pnpm as package manager. I updated the tauri cli and api packages to the `next` version using pnpm.

I have the same problem. Did you find any solution?
tried to install android studio in multiple places changing the JAVA_HOME env variable but still not recognized.
Also tried the standallone installation but its the same... It still asks for android studio. Its driving me insane D:

I used the rust version of cli in every project now.

Ok... seems the npm or node wrapper for this is not quite ready yet. Alpha...still on the early phase right :)). Try use cargo to launch the app. It should launch on your usb connected device. cargo tauri android dev or cargo tauri ios dev

Could you guys give it another try and see if the issue is fixed?

@amrbashir no, it's not fixed in 2.0.0.alpha.20

For those that still have this issue, it was fixed with tauri cli alpha 21


Poor font colour choice

The current choice for font colours makes it difficult to read the text on the site. Either the background or the font colours should be made lighter.

Project is no longer maintained.


Stack using Array

Hey, don't make PR directly . We have to check whether the problem is already there or not .After that we will assign you solve this issue

Hey! don't make PR directly .
We have to check whether the problem is already there or not .
After that we will assign you solve this issue


[WIP] managed/unmanaged unification

Fixes: https://github.com/resin-os/meta-resin/issues/1025

Contributor checklist

[ ] Changes have been tested
[ ] Change-type present on at least one commit
[x] Signed-off-by is present
[x] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

When submitting a review, please pick:

'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@agherzan if I understand correctly, with this PR all resinos builds will now be connected to resinio.
What is the recommendation for resin-os users that don't use resin.io portal: is there an easy path for disabling/removing resinio specific services (openvpn, resinio api calls, ...) ?

Also, what is the meta-resin-common/recipes-core/os-config/ stuff about?
Is this some kind of new way to manage resin.io connectability of resin-os?

Thanks @agherzan for your explanations.
The new way of connecting resin-os at run time with the os-config tool you describe makes a lot of sense to me.
I was not very happy with the way I made my own custom resin-os build to provide custom private ssh keys, and authorized_keys / known_hosts files. That would be great if all these ssh files could be provisioned with the upcoming os-config tool, or if this tool could be easily extended to provide more provisioning capabilities (like adding a .docker/config.json file to be able to pull docker images from an external docker registry).
Also, I was wondering if you also plan to remove the TARGET_REPOSITORY, TARGET_TAG feature that allow us to load a custom docker container instead of the resin_supervisor.  We are using this feature to run our own container as we don't need the resin_supervisor container and the features it provides.

@bbinet That is exactly what I am working on right now. There will not be multiple docker-image providers. Only one: docker-disk.bb. And additional images will be able to get pulled in by a variable called DOCKER_PRELOAD_IMAGES. Ex: DOCKER_PRELOAD_IMAGES = "test:test". It will not replace resin-supervisor, as said above this will always run. But will allow to additionally pull in random images.

@agherzan I'm not very comfortable with this: having resin-supervisor always running is quite intrusive, and it adds an overhead to our device resources.
Why not also keep the TARGET_REPOSITORY, TARGET_TAG feature? For some users, resinos is a great system to run a simple embedded linux + docker container, nothing more, and I think it makes sense to keep this simple use case.

Hi @bbinet . First of all I would like to underline that the supervisor provides a lot of features which are based on user requests. We keep memory and storage footprints of this component as low as possible but including it in the platform enables us to provide more functionality in the future. Even now, it enables the integration with the CLI and provides and abstraction layer that we think makes user experience much better. That being said, we do understand your point of view as well. We still think that once you will start using what supervisor provides, you will understand the potential but for the time being we will try to keep a similar experience as before, having a way in the yocto builds to set this through a custom build configuration. I want to stress out that we might change this in the future if this is proved to be hard to maintain and if it hurts the overall architecture of resin.

Thank you @agherzan.
And of course I understand your concern about maintenance and architecture.

I'm very excited about this. I have been working on something similar to what @bbinet described - rolling my own YOCTO build to inject my supervisor image. I will work on testing this / integrating as soon as it's available.

Great @rquackenbush . It will happen soon enough. We just need to integrate the os-config tool which should come next week.

@rquackenbush Yes, host updates will work as well. The only wrinkle is that being not connected to resinio dashboard, that won't be able to get triggered remotely but only from SSH.

https://github.com/resin-os/resin-yocto-scripts should also be updated now that RESIN_CONNECTABLE and RESIN_CONNECTABLE_ENABLE_SERVICES variables have been removed

Indeed @bbinet .

@agherzan Any news: do you know if this PR will get merged soon?

@bbinet Hi. We started to work on more features to be included in the same PR. We are going to implement the ability to switch in between resin instances using the os-config tool - this being one of the top requests from our users. Sadly this means that the os-config tool will come out as a resin specific tool and will include code that is intended for communication with resin backend. We realise that this breaks the assumption I made above where I stated that ssh keys will be able to get injected with it and because of this, we will bring back the ability to have ssh keys in yocto build system and the bind mounts not shadow the rootfs content.

@agherzan Ok thank you for the update. What do you mean exactly by "switch in between resin instances"?

I mean switch for example from resinio staging to resinio production. Or the other way around. And when resin on premise will be available you will be able to switch to and from onprem instances too. On top of this, the tool will allow disconnecting completely from resinio and reconnecting whenever the user decides.

I understand, thanks

@bbinet - it looks like you have experience running resin.os unmanaged. Do you have any docs / projects / info we could look at for doing the same thing?

@rquackenbush Sorry, I don't have anything public. What issues are you facing?
You should be able to start with unmanaged images using readme from your device resin project (mine is raspberry pi: https://github.com/resin-os/resin-raspberrypi) and meta-resin: https://github.com/resin-os/meta-resin/

Very very solid work. :+1:  to @agherzan and @majorz
The PR needs tons of testing. And i'm wondering a bit about the transition when existing devices bump up their resinOS version.
This feels like a major version bump instead of a minor version bump in the OS?
Some review.
8bc8646e83f commit message needs rewriting to be more clear. I'd recommend
I don't understand the reason there are two folders now? openvpn/files openvpn/openvpn/
Could you please elaborate?
If you are moving the files from openvpn/openvpn to openvpn/files, I'd recommend doing that in a separate commit. This commit is quite all over the place.
30b6042 and c2f86b50 I'd recommend the subjects themselves should read remove deprecated tool instead of this tool will get replaced. Similar to 4a01d87ad87.
After this is merged, the readme.md doc will need overhauling..
2e1fcae30c78 subject line extends a bit.
Your build configuration uses RESIN_CONFIGURABLE* variables. Did you mean to write RESIN_CONNECTIBLE* or configurable?
Also, I'd recommend elaborating the warning message a bit. These were deprecated as managed and unmanaged images are now unified. Not entirely sure if managed/unmanaged/unified make the impact clear enough to anyone who sees this. Perhaps make this message longer and more verbose.
These variables are no longer used. There is only one type of resinOS image built which is unconnected by default. The os-config tool is used to connect the resinOS image to any resin instance e.g. resin.io
56f394927 I read the message and diff several times until I saw that config-json path refers to config-json.path and config-json service refers to config-json.service
1fe2c1f19ab1 will be the first commit message and remain in history for people to refer to. I'd recommend a commit message explaining some history and a bit about how the tool aims to function.
01e7573ff36 consolide consolidate
This commit does two things and has a very long diff.. Would it be possible to split the commit.  separating the supervisor recipe and then consolidate the docker-disk providers.
I haven't actually reviewed the diff as its a bit late in the evening :)
6808c45787 feels strange. Should it be merged with 1fe2c1f19ab1
a8104b210 and aae58d9 . version bumps before PR is merged feels strange

Thanks @ZubairLK . Addressed all the comments and added some more fixes / version bumps.

@agherzan Any ETA for this refactoring to land?

@bbinet There are some supervisor fixes pending:
https://github.com/resin-io/resin-supervisor/issues/676
https://github.com/resin-io/resin-supervisor/issues/675
As far as I am aware at this point, these should be the last items in the queue on which @CameronDiver is currently working.

ok, thanks @agherzan for the status update

As a side note: I tried to pack the os-config executable with UPX, but it did not work for the target architecture.

@majorz this PR includes already UPX compression of the os-config tool.


Side reference pixels not working

Any manually specified side reference pixels in the Coron3Pipeline are not working correctly because the use of side reference pixels for subarrays is not supported by the default JWST pipeline. @JarronL might have some ideas on how to fix this issue, but needs help with implementing it.

@kammerje @AarynnCarter @JarronL - Is this old GitHub issue still required or useful? I think the use of side reference pixels has been addressed by some past PR, potentially #97?


Implement active quest objectives widget

Creates ActiveQuestWidget, which displays the name and objectives of the current active quest.
This ended up way more complicated than I wanted, largely due to handling mission objectives (and greying out completed objectives).  But also in general because I needed custom callbacks on string decoding so couldn't use EncString for most of it.

Other ideas: potentially needs some way to handle long lists of objectives.  A scrollbar (I guess convert it to a window for this?)?  Swap the objective order, as uncompleted objectives are more likely to be lower?  A setting to hide completed objectives?


Patch http.Agent pools

This should properly resolve #61 and https://github.com/othiym23/node-continuation-local-storage/issues/71.

@othiym23 @hayes @matthewloring Anyone care to give this a look? It fixes an issue with http.Agent connection pools not triggering before/after for reused sockets and therefore causing CLS to lose context when the pooling kicks in.

👍
This doesn't work if https://github.com/node-modules/agentkeepalive is used though.  I am trying to understand what that agent brings in addition to http.Agent though.

Seems like agentkeepalive is actually broken on node v5+. It should take a callback rather than returning a socket: https://github.com/nodejs/node/blob/master/lib/_http_agent.js#L149.

Merged and released in 0.6.1.


SpotSparkLDAWrapper performance improvements.

Replaces documentDictionary: Map[String, Int] with DataFrame to avoid .collect().
Also, converting LDA results to DataFrame and joining with documentDictionary: DataFrame to avoid collect, re-parallelization and converting to DF since results are already distributed.
Finally, caching document word count to speed things up.

LGTM

I'm going to keep pushing changes, won't merge for now.

@NathanSegerlind what about ldaAlpha and ldaBeta, do we need to parametrize those two?

okay cool, let me know when you are happy with testing and i'll merge


After adding the very new address at the checkout show addresses for one second

Environment Details

Spartacus: localhost latest develop
Browser: chrome
OS: OSX 10.14.3

Steps to Reproduce
login, delete your addresses if any, add something to cart, go to checkout, click Continue.
Observed Results
The view with addresses blinks for ~1s and then shipping method appears, see video ~19th second:
https://www.youtube.com/watch?v=Q3BB-_rI7MU
Expected Results
Blink shouldn't happen, shipping method should appear immediately.

checked, still occurs

Tested on dev10. Works now. We don't see the newly added address anymore.


V3 is not marked as latest

On marketplace and in the GitHub release page, the latest is still v2, even though v3 exists to tackle outdated dependencies.

Updated, thank you


Latest phenio doesn't include relation-graph tsv

The new release only went up 6 hours ago, so maybe it's something that gets updated in the build later, but I happened to try to download https://github.com/monarch-initiative/phenio/releases/latest/download/phenio-relation-graph.tar.gz and found that it wasn't there.

Whoa! That’s good to know about.


data layout

Arrayfire's data layout is WHCN, so I was assuming flashlight would have the same layout but I found some code like this in CudnnUtils.cpp
  // reverse the arrays and cast to int type
  std::array<int, 4> strides = {(int)afstrides[3],
                                (int)afstrides[2],
                                (int)afstrides[1],
                                (int)afstrides[0]};

What is the data layout of flashlight?
why do you reverse the layout at the last moment before calling cuDNN?
does that mean you also flip padding, stride, and dilation?

Hi,
Arrayfire uses column major layout. So, WHCN layout in arrayfire is same as cuDNN NCHW layout once you get the data pointer for the array. Hope that answers the remaining questions.

@vineelpratap
A couple of followup questions:

what do you mean by column major layout? I am used to thinking of memory as a one dimensional array on the hardware and column-major and row-major is just how we chose to interpret the 1D array. So when we are talking about how elements of a tensor are laid out on the memory, I don't understand what you mean by row or column.

I am trying to read an array from Pytorch into flashlight. Pytorch and cuDNN uses NCHW layout where elements along W dimension are stored consecutively, then you have consecutive rows of W stored along the H dimension, and so on. How would I change the data layout of a Pytorch array to correctly read it into an array fire array?

Array fire is HWCN, not WHCN. I had problems porting layers from Pytorch to Flashlight because we thought Arrayfire was WHCN.
In the comments (source):

tensor is in WHCN order and layout in COLUMN-MAJOR

However, this is not true. Although within flashlight WHCN is equivalent to HWCN as long as you keep it consistent, this becomes a problem when we need to port from another framework such as Pytorch or Tensorflow into Flashlight. We should fix the comment

row-major NCHW is equivalent to column-major WHCN in terms of data layout
one can just simply copy weights from Pytorch's tensor into Flashlight without rearranging the dimensions.

@ThisIsIsaac  - yes, these are both true.

Array fire is HWCN, not WHCN. I had problems porting layers from Pytorch to Flashlight because we thought Arrayfire was WHCN.

I think the original comment is correct - input is WHCN for column-major layout. This actually follows your analysis from above two statements -->
one can simply reuse the Pytorch's input tensor in NCHW format for convolution
Can you give an example for this, otherwise ?

I've been asking for clarifications from AF dev via slack, and this is one of his responses:

Say an image of size WxH and C channels is loaded by ArrayFire, the data on arrayfire's array would be of size [ H W C 1 ] , scanlines sit as rows in ArrayFire array

If you want, I am going to ask my junior dev -- @minty99 -- about a specific example led us to thinking that AF is HWCN

@ThisIsIsaac
Check this example http://arrayfire.org/docs/machine_learning_2kmeans_8cpp-example.htm#a13, seems even loadImage function loads image in WHC format.
array img = loadImage(ASSETS_DIR"/examples/images/vegetable-woman.jpg", true) / 255; // [0-255]
int w = img.dims(0), h = img.dims(1), c = img.dims(2);

My reason to say arrayfire is HWCN is this -
af::array a = af::randn(2, 3);
af::array b = af::randn(2, 5);
af::print("2x3", a);
af::print("2x5", b);

prints
2x3
[2 3 1 1]
   -0.9247     2.5441    -0.3452
    0.1808     0.3516     0.2191

2x5
[2 5 1 1]
   -0.7687    -1.1948    -0.5378     0.9354     0.5787
    0.2413     0.8927     0.2270    -0.7613    -0.6174

If arrayfire is WHCN, this test should print 3-by-2 matrix and 5-by-2 matrix.

@minty99 - We shouldn't use print output to conclude anything about the data layout, since it doesn't show how the underlying raw data is stored in memory. You can try using .host operator to get the raw pointer for the array.
As @tlikhomanenko mentioned, you can try to load a rectangular image and see the dimension of the output. Also, note that height and width makes sense only when you are operating on images, while convolutions can be applies on any other domain.

one can just simply copy weights from Pytorch's tensor into Flashlight without rearranging the dimensions.

Based on this statement above, you can also try using the same input, weight in PyTorch 2D convolution and it should produce the same output. This should also confirm that flashlight using WHCN.

@vineelpratap  Thanks. We are going to copy weights from Pytorch and see if it actually works.