Running macOS guests

It looks like the most common use of vfkit is running GNU/Linux guests, but of course the Virtualization framework also supports running macOS guests and vz can download and run macOS guests from .ipsw files.  Is it possible to run a macOS guest using vfkit (ideally from a .ipsw)?

It is not a use case we (dependent applications; Podman Machine, CRC) have, but nothing that prevents this.

I found this project via Podman actually!
Have you been able to run macOS guests with vfkit? I've tried using .img files built by UTM and the last AGPLv3 build of Tart (0.38.0), but neither seem to actually boot despite vz not throwing an error. It's the same behavior as using an empty disk image.
vfkit \
    --cpus 2 --memory 2048 \
    --bootloader efi,variable-store=efi-variable-store,create \
    --device virtio-blk,path=/Users/foo/.tart/vms/sonoma001/disk.img --device virtio-input,keyboard --device virtio-input,pointing --device virtio-gpu,width=1920,height=1080 --gui
INFO[0000] &{2 2048    {[efi variable-store=efi-variable-store create] true}  [virtio-blk,path=/Users/foo/.tart/vms/sonoma001/disk.img virtio-input,keyboard virtio-input,pointing virtio-gpu,width=1920,height=1080] none://  true}
INFO[0000] boot parameters: &{EFIVariableStorePath:efi-variable-store CreateVariableStore:true}
INFO[0000]
INFO[0000] virtual machine parameters:
INFO[0000] 	vCPUs: 2
INFO[0000] 	memory: 2048 MiB
INFO[0000]
INFO[0000] Adding virtio-blk device (imagePath: /Users/foo/.tart/vms/sonoma001/disk.img)
INFO[0000] Adding virtio-input keyboard device
INFO[0000] Adding virtio-input pointing device
INFO[0000] Adding virtio-gpu device
INFO[0000] virtual machine is running
INFO[0000] waiting for VM to stop
INFO[0000] VM is stopped

^ running vfkit version: 0.5.1
I can get a code signing cert to compile vz with the required entitlements and test building an image with it, but wanted to make sure I'm not doing something obviously wrong first.

It looks like this might not work even when supplying an image that works with other tools because vfkit hasn't implemented VZMacPlatformConfiguration or VZMacOSBootLoader.
If you compare the vz examples for macOS and Linux, you can see the Linux VM uses slightly different calls, like VZGenericPlatformConfiguration.
I could be wrong about all this though 😅

It looks like this might not work even when supplying an image that works with other tools because vfkit hasn't implemented VZMacPlatformConfiguration or VZMacOSBootLoader.
If you compare the vz examples for macOS and Linux, you can see the Linux VM uses slightly different calls, like VZGenericPlatformConfiguration.
I could be wrong about all this though 😅

Yes, a few things are missing in vfkit to run macOS guests, including the ones you mention (haven't checked if there are more :) This would be a nice addition to vfkit, but not something I'm planning to work on soon.
If you want to try to implement this, I'd be happy to help with guidance/suggestions/... if needed.

A few thoughts about this (which might be wrong ;)

I'd tie "macos" vm to a --bootloader macos config option
if this option is set, then we can create a *vz.MacPlatformConfiguration automatically and pass it to the VM
however, this requires the path to several files, so maybe a --runtime-dir option is needed, which I've wanted to have for a while
the graphical device for macos VMs is different from the one for linux VMs
I don't know how to handle installation (haven't looked closely enough to this code)

you can see the Linux VM uses slightly different calls, like VZGenericPlatformConfiguration.

vfkit does not make use of this, I don't know if it should..

you can see the Linux VM uses slightly different calls, like VZGenericPlatformConfiguration.

vfkit does not make use of this, I don't know if it should..

Implementing VZGenericPlatformConfiguration would require dropping macOS 11 support.


chore: release 1.0.0

:robot: I have created a release *beep* *boop*
1.0.0 (2021-06-22)
Features

add addresses command (#160) (03457d9)
add new stamp properties (#165) (4000072)
add filter, sort and limit to stamp list (#165) (4000072)
add upload size warning (#153) (218bd41)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ethersphere/swarm-cli/releases/tag/v1.0.0 :sunflower:


Issue with ColorPicker and Panel3 in React Native

Description
I am experiencing an issue with the ColorPicker component when used with Panel3. Specifically, the ColorPicker scrolls along with the page when it should remain stationary.
Here are the details:
Scrolling Issue: The ColorPicker moves when scrolling within a KeyboardAwareScrollView. I also tried using react-native-gesture-handler's ScrollView but encountered the same problem.
Function Callbacks: We are using two functions, onChange and onComplete. When the scrolling issue occurs, the onComplete function does not get called.
Problems:

The ColorPicker scrolls along with the content when it should remain fixed.
When the ColorPicker scrolls, the onComplete function is not triggered.

I am sharing the problem video for a better understanding.
https://github.com/alabsi91/reanimated-color-picker/assets/13678247/4046ce86-18b3-4194-aa2f-a4098fdd99a1
here is my code:

 <View style={styles.container}>

            <GestureHandlerRootView style={{ paddingBottom: 150 }}>
                <KeyboardAwareScrollView
                    enableOnAndroid
                    bounces={false}
                    showsVerticalScrollIndicator={false}
                    contentContainerStyle={{ paddingBottom: normalize(36) }}
                    keyboardShouldPersistTaps="handled"
                    enableResetScrollToCoords={false}
                >
                    <View style={styles.colorWheelContainer}>
                        <ColorPicker
                            value={defaultColor}
                            thumbInnerStyle={[styles.thumbStyle, thumbStyle]}
                            onChange={onChange}
                            onComplete={(color) => {
                                onComplete(color?.hex)
                            }}
                        >
                            <Panel3 style={[styles.panelStyle, colorWheelStyle]} />
                        </ColorPicker>
                    </View>

                </KeyboardAwareScrollView>
            </GestureHandlerRootView>

        </View>

Steps to reproduce
To reproduce do the same thing which is in the video, Just press press and drag.
https://github.com/alabsi91/reanimated-color-picker/assets/13678247/4ec17c31-ef4d-494a-9c02-dfcb62af9b02
Snack or a link to a repository
No response
Reanimated Color Picker version
3.4.2
React Native version
0.70.10
React Native Reanimated version
2.14.0
React Native Gesture Handler version
2.5.0
Platforms
Android, iOS
JavaScript runtime
JSC
Workflow
React Native (without Expo)
Architecture
Paper (Old Architecture)
Build type
Debug mode

I recommend using the color picker inside a modal as a popup. This is because you are relying on RNGH to decide which gestures to cancel and which to allow. While RNGH scroll view works most of the time, it does not seem to work in your case. However, you can add a new gesture to disable and enable the scroll view, and then attach it to Panel3 see gestures and https://github.com/software-mansion/react-native-gesture-handler/issues/2616


issues/1174

adding proper command warning

Codecov Report

Merging #1206 (f630822) into master (c83abb6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   65.43%   65.43%
=======================================
  Files         185      185
  Lines       19104    19104
  Branches     4092     4092
=======================================
  Hits        12501    12501
  Misses       6603     6603

Files
Coverage Δ

src/components/ZclCommandManager.vue
33.84% <ø> (ø)


Clarify docstrings of .opts and .options

Currently, the docstrings for .opts and .options are identical except for subtly different examples.
These should be clarified to indicate that .options is a more user-friendly version of .opts ... if that is the case. Also, it might be worth mentioning in the docstring the relationship to cell magics.

Also, http://holoviews.org/user_guide/Customizing_Plots.html focuses exclusively on .opts and does not mention .options . @jbednar told me on gitter that holoviews is trying to expose new users to .options rather than .opts so I guess this issue might be expanded beyond docstrings to include updating the Customizing Plots example in the user guide.

As @foobarbecue kindly pointed out:

I just realized I learned about .opts from http://holoviews.org/user_guide/Customizing_Plots.html -- it is very ".opts forward"

We should definitely update this.


WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.>
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

    "react": "15.4.2",
    "react-native": "0.39.2",

What is the problem?
I may guess that you don't like warnings. Setting<EMAIL_ADDRESS>and<EMAIL_ADDRESS>should fix those, however I haven't tested this lib with latest RN versions.
Anyway, it should still work well for you now.


Help using images and assets from SWC libraries

Hello everyone
We are working on a migration project using Apache Royale and the project contains plenty of SWC files that contains JPG and PNG images.
We have been trying to use them directly from the libs but without any success. If we copy the file directly to the source folder it works. But we need to be able to refer and use the images inside the libs.
Attached is an example project we setup showing 4 images (2 from libs and 2 from source folder) and the ones from the libs are not shown, not matter the compiler options we set in the asconfig.json.
using-images-example.zip
We are using VS Code with Apache Royal 0.9.8.

I see things like
                                            <j:Image src="images2/afericao.png"/>

Have you tried
                                            <j:Image src="/images2/afericao.png"/>

Instead?
From: André Thiesen da @.>
Sent: Tuesday, April 27, 2021 10:28 PM
To: @.>
Cc: @.***>
Subject: [apache/royale-asjs] Help using images and assets from SWC libraries (#1106)
Hello everyone
We are working on a migration project using Apache Royale and the project contains plenty of SWC files that contains JPG and PNG images.
We have been trying to use them directly from the libs but without any success. If we copy the file directly to the source folder it works. But we need to be able to refer and use the images inside the libs.
Attached is an example project we setup showing 4 images (2 from libs and 2 from source folder) and the ones from the libs are not shown, not matter the compiler options we set in the asconfig.json.
using-images-example.ziphttps://github.com/apache/royale-asjs/files/6387102/using-images-example.zip
We are using VS Code with Apache Royal 0.9.8.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/apache/royale-asjs/issues/1106, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAQBE7IJ2NVKF24RHJMYLSDTK4F47ANCNFSM43VTXPEA.

Hello @yishayw
In my examples, the images referencing the source folder are working. The libs are not. As follows

I did try putting "/" in from the string but nothing worked afterwards.

It seems that the files from the library are not being extracted when I run the build. Not sure how to ensure they are.

Yes it's not there. here images folder should be present.

Can you send library project also ?

Hello @alinakazi
Here it is
images-swc.zip


[NEW] add subdommen sibguti

Institution/School Name
{Siberian State University of Telecommunications and Information Sciences}
Instiution/School Website
{Website URL}
Email Users
<EMAIL_ADDRESS>Please place an x between the square brackets if yes

[X] Students
[ ] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[X] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

@KaoriEl I am sorry for a delay with processing your request.
Pull request merged. Thank you!


Exporting Multiple Scenes

Describe the bug
If I have multiple scenes in my Blender file (each containing objects), it will fail to export gltf.
To Reproduce
Steps to reproduce the behavior:
Pick one:
A: Create a second scene and add 1 object to each scene, then export gltf.
B: Link two external Blender files, each containing objects, then export gltf.
C: Append two external Blender files, each containing objects, then export gltf.
Expected behavior
It should be one gltf written containing multiple scenes.
Screenshots
If applicable, add screenshots to help explain your problem.
.blend file/ .gltf
http://www.timobuske.de/misc/blender-merged.zip
Version

Windows 10
Blender 2.81

Additional context
Add any other context about the problem here.

Hello,
Using 2.82 + current master of this addon:
A: Seems to work, I can see 2 scenes in gltf export

B: What did you link exactly ? Scenes ? Is this the attached example ?
This will be solved by #950
C: Seems to work, I can see 3 scenes in gltf export (my empty scene + 2 appended scenes

When I tried to export this I got a runtime error:

... but I had an older version of Blender 2.81 beta here. Maybe it's fixed in 2.82?

@donmccurdy Did you try to export the merged.blend from attachment? IIUC, this is the point B.
This will be fixed in PR #950

Hi, indeed with Blender 2.82 using current master it seems not crashing linking scenes.
Thx.

Hmm... For complex scenes still getting a crash for case B and C using latest Blender 2.82 + master.
Maybe I can try to reduce the scenes it to the minimum...
'C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\python\lib\site-packages\extern_draco.dll' exists, draco mesh compression is available 07:48:58 | INFO: Starting glTF 2.0 export Traceback (most recent call last):   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\__init__.py", line 502, in execute     return gltf2_blender_export.save(context, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 41, in save     json, buffer = __export(export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 54, in __export     __gather_gltf(exporter, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 63, in __gather_gltf     active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 37, in gather_gltf2     scenes.append(__gather_scene(blender_scene, export_settings))   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached     result = func(*args)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 56, in __gather_scene     node = gltf2_blender_gather_nodes.gather_node(blender_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 47, in gather_node     node = __gather_node(blender_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached     result = func(*args)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 61, in __gather_node     children=__gather_children(blender_object, blender_scene, export_settings),   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 130, in __gather_children     node = gather_node(child_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 47, in gather_node     node = __gather_node(blender_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached     result = func(*args)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 61, in __gather_node     children=__gather_children(blender_object, blender_scene, export_settings),   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 130, in __gather_children     node = gather_node(child_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 47, in gather_node     node = __gather_node(blender_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached     result = func(*args)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 61, in __gather_node     children=__gather_children(blender_object, blender_scene, export_settings),   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 130, in __gather_children     node = gather_node(child_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 47, in gather_node     node = __gather_node(blender_object, blender_scene, export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached     result = func(*args)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 65, in __gather_node     mesh=__gather_mesh(blender_object, export_settings),   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 321, in __gather_mesh     export_settings)   File "C:\Program Files\Blender Foundation\Blender-282-ewdemo\2.82\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 48, in wrapper_cached     cache_key += (i.name,) ReferenceError: StructRNA of type Mesh has been removed

Are you sure that you are using the last master of this addon ?
This error should be fixed already

Did you try to export the merged.blend from attachment?

I had tested merged.blend in 2.81 beta, yes.

This ticket is quite old, and the original test case is no more available.
I'm going to close it.
If you still have some issue, please create a new ticket!


Helpers to be used with materialize()

I'm not sure if this is beginning to range outside the "small footprint" you're aiming for here, so no pressure to accept this PR.
This PR adds a properties to Event instances that help to unwrap .next elements and .failed errors.
This in turn aids a couple of methods I've been using alongside materialize() in a situation where both my element and my error are of the same type:
func solveEquation(equation: String) -> Signal<Result, Result> {
   /// …
}

func set(equation: String) -> Signal<Result, NoError> {
     return solveEquation(variable: equation)
        .materialize()
        .elements()
}

It's probably of limited utility outside of this circumstance, but I thought I'd offer it up just in case.

Oh, there's no tests - if there's interest in merging this PR, I'll add them.

I think this fits the goal @tonyarnold :) I have found myself in need of these few times too.
Thanks!


Add icon to nuget packages

The suggested size by NuGet is 128*128, which is much less than all the assets.
I pick Small FC and shrink it using system Paint 3D. Other ones containing text will become unreadable in this size.

May want to reconsider the padding at a later point. We'll see how it looks in nuget displays.


Serialization of Type Change Suggestions for Type Violations.

Overview
This PR enables NullAway to serialize information on code locations to resolve the reporting errors if they can be resolved via a type change. This information can be used by other tools such as AutoFixer to have an understanding of the source code, code points where violations occurred, and possible solutions. In the example below, NullAway will report the error:
assigning @Nullable null to @Nonnull bar.
class Foo {
     Object bar = new Object();

     void baz(){
           this.bar = null;
     }
}

This PR enables NullAway to suggest bar type to be @Nullable to resolve the error and creates two output files. errors.tsv where all reporting errors are stored and fixes.tsv where all the type change suggestions are stored.

errors.tsv: Every row represents a reporting error with the format: MESSAGE_TYPE, MESSAGE, ENCLOSING CLASS, ENCLOSING METHOD
For instance: ASSIGN_FIELD_NULLABLE, assigning nullable null to field bar, Foo, baz
fixes.tsv: Every row represents a type change suggestion with the format: LOCATION, MESSAGE_TYPE, ANNOT
For instance: Field bar of Foo, ASSIGN_FIELD_NULLABLE, @Nullable

To activate the feature above the following flags must be passed to NullAway via ErrorProneFlags:
"-XepOpt:NullAway:SerializeFixMetadata=true"
"-XepOpt:NullAway:FixSerializationConfigPath=configpath"

When -XepOpt:NullAway:SerializeFixMetadata=true is observed in the flags, NullAway will look for a file at FixSerializationConfigPath to activate/deactivate serialization features.
Below is the FixMetadataConfigPath format:
<serialization>
    <suggest activation="true" enclosing="true"/>
    <output>
           "outputdir"
    </output>
    <annotation>
        <nullable>javax.annotation.Nullable</nullable>
        <nonnull>javax.annotation.Nonnull</nonnull>
    </annotation>
</serialization>

If -XepOpt:NullAway:SerializeFixMetadata=true is observed, NullAway will serialize all reporting errors to errors.tsv regardless of flag values in FixSerializationConfig.
Finding enclosing method/class for suggested fixes is costly and not always required, they can be controlled using enclosing  attribute in the config file above. If any of the keys in the template config above is not found, the default value will be considered.
Please note, at the places where explicit @Nonnull is observed, NullAway will acknowledge that annotation and will not suggest any type change.
Implementation
All implemented classes reside in the fixserialization package. The goal of this PR is to create SuggestedFixInfo objects which are type change suggestions of elements in the source code. Each of these objects contains a single Location instance and an Annotation . Location instances target an element in the source code. Throughout this PR the only suggested annotation in SuggestedFixInfo instances is @Nullable.
The creation of SuggestedFixInfo objects is implemented through ErrorBuilder. The createErrorDescription signature is changed and now it accepts a fifth argument called nonNullTarget. If this parameter is non-null, the error involved a pseudo-assignment of a @Nullable expression into a @NonNull target, and this parameter is the Symbol for that target.  Whenever ErrorBuilder is asked to create an ErrorDescription object, it also creates a SuggestedFixInfo targeting the parameter nonNullTarget to be @Nullable.

@msridhar @lazaroclapp I believe this is ready for another round of review. Thank you very much.

@msridhar @lazaroclapp I believe this is ready for another round of review. Thank you very much.

I removed the last trace of hard code paths which was in tests, I tired to write fixes in jimfs but since output directory is passed via a string not Path object, I could not convert it correctly. Instead I am writing fixes in TemporaryFolder. Please let me know if that works. With best regards.

Nice to see the change get smaller! Before this PR can be reviewed in detail, I'd like to see the following high-level points addressed, which may require some discussion.
First, in general the name AutoFix is not sufficiently descriptive. This code does not automatically fix anything. I think what it does is serialize information on code locations where NullAway is reporting errors, in cases where those errors could be fixed by adding a @Nullable annotation (either locally, or possibly in a superclass or subclass?). Other tools use this information to automatically patch the code. Is that correct? If so, maybe the NullAway arguments should be -Xep:NullAway:WriteFixMetadata and -Xep:NullAway:FixMetadataOutputDir. And then, rather than having an autofix package for the code, it could be fixserialization. Similar comments apply to a lot of the names used, like the Handler.fix method.
Second, there is almost no documentation for any of the new or modified code, making these changes very difficult to review. As a start, please add top-level Javadoc on every new class and new public method in this PR. Probably we will need further documentation beyond that, which we can work on. For useful guidelines on how to structure documentation in code, see the "Reference Documentation" section in Chapter 10 of Software Engineering at Google.

Thank you very much for your comments @msridhar. Sure, I will add documents to methods and classes as instructed.
Regarding changing names, does this apply to Fix term as well ?

Regarding changing names, does this apply to Fix term as well ?

Yes, maybe that can be SuggestedFixInfo or something like that, to be more informative.

Hi @msridhar @lazaroclapp I believe this is ready for another review. I added all the documentations and it helped me to do some more refactoring :D.

@nimakarimipour can you update the description of this PR so that (1) it is up to date with the latest code and (2) it gives an overview of the code changes, new packages, etc.?

@nimakarimipour can you update the description of this PR so that (1) it is up to date with the latest code and (2) it gives an overview of the code changes, new packages, etc.?

Hi @msridhar, Please find the updated PR description along a brief overview of the implementation.

When -XepOpt:NullAway:WriteFixMetadata=true is observed in the flags, NullAway will look for a explorer.config file at outputdir/explorer.config to activate/deactivate serialization features.

@nimakarimipour I think we want to avoid reading files out of the output directory.  Probably the path to this config file should be passed as a separate option.  @lazaroclapp do you agree?

Sorry, I think FixSerializationConfig is better, to be clear what is
being serialized.
On Jan 7, 2022 at 13:44:58, Nima Karimipour @.***>
wrote:

@.**** commented on this pull request.
In
nullaway/src/main/java/com/uber/nullaway/fixserialization/FixSerializationConfig.java
https://github.com/uber/NullAway/pull/517#discussion_r780546526:

/**

Validates whether @.*** suggestEnabled} is active and the element involved in the error is

accessible and not received in bytecodes.

@param trees Trees object.

@param symbol Symbol of the targeted element to perform type change.

@return true, if the element is accessible and @.*** suggestEnabled} is active.

*/
public boolean canFixElement(Trees trees, Element symbol) {
if (!suggestEnabled) return false;
if (trees == null || symbol == null) return false;
return trees.getPath(symbol) != null;
}

/** Builder class for Config */

79d59c5
https://github.com/uber/NullAway/commit/79d59c5904994a1fcd68618771aa08712d44fc1b
Earlier it got renamed to SerializationConfig. Please let me know if you
want to keep it FixSerializationConfig.
—
Reply to this email directly, view it on GitHub
https://github.com/uber/NullAway/pull/517#discussion_r780546526, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABPEUKWCYASHB4FJSULCI3UU5NFVANCNFSM5KE5NV6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @msridhar, I believe this is ready for another review.

@msridhar I believe this is ready for another review.

Hi @lazaroclapp, I believe this is ready for review, thank you very much.

Hello @msridhar and @lazaroclapp,
I ran the new version on my benchmarks to make sure everything is working and the tool crashed, I fixed the bug and added a test case: e86e2a34a221ac60ea3804d908cc4768f87a2e1c. It seems methods and constructs have different value for ElementKind.
Lazaro, there are a lot of comments on this PR and the GitHub UI is not working really well, for your convenience I rewrote my responses to some of your comments, please find them below:

Side Note on TSV: You mentioned that file names can have tabs inside but this is fine for now, please let me know of you prefer to address it now.
Keeping the config file: In our last meeting we decided to keep the config file, therefore, I did not do anything for this comment.
Make Nullable: You mentioned to make a field @Nullable for a reason which I did not understand, would you please give me more instructions what I have to do ?

I believe this is ready for another review, sorry for the delay, I did not expect it to take this long :)

Doing another pass over the PR right now, but went over the responses to comments first, and they generally look good to me.
Regarding the three questions in the summary:

Side Note on TSV: You mentioned that file names can have tabs inside but this is fine for now, please let me know of you prefer to address it now.

Fine to leave for later. Maybe worth a comment in the code noting the potential issue, but filenames with [TAB] should be rare.

Keeping the config file: In our last meeting we decided to keep the config file, therefore, I did not do anything for this comment.

Agreed!

Make Nullable: You mentioned to make a field (outputdir at FixSerializationConfig) @Nullable for a reason which I did not understand, would you please give me more instructions what I have to do ?

Responded inline. But, basically outputdir is not initialized in the constructor for the builder, so it should be an @Nullable field, and presumably checked to be non-null at build, throwing some sort of exception related to incorrect object construction if it is or just a Preconditions.checkNotNull(...) if this will only ever be used internally within NullAway.

Also you asked why we need to have a control flag on fix serialization, since fix serialization comes with a cost on performance, and in our diagnose phase where we rebuild the project per fix, we do not need to know the list of new fixes at every single build unless we are performing a deep search.

Makes sense to me!

Hello @lazaroclapp, thank you very much for your comments. This is ready for another review, with best regards.

@msridhar and @lazaroclapp Thank you very much for your comments, this was super educating for me.


VIH-9678 Detect duplicate template entries

JIRA link (if applicable)
VIH-9678
Change description

detect duplicate templates and throw meaningful error
update swagger definition, 500 returns strings instead of objects for notifications controller endpoints

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

It all looks like a good improvement. Only question, we're using an in memory dbcontext for testing. Can the test really be considered an 'integration' test if it doesnt physically touch the database it's integrating with? Should it just be a unit test?

Good question. I would say it's both. In this case I am integrating with a data source, albeit the implementation is an in-memory one. I also chose integration because the dbcontext references and other db related tests lived there also.


Local DB setup

Setup local DB as a service using Hive which can be used for caching, user details storage and local settings.

It will be great to have helper methods in the service implementation. So that we can use those methods for redundant stuff. Some basic methods can be setup for now, and we can go on adding new stuff as we proceed.


Develop branch project build

Hello
Is there a possibility to build a project from develop branch?

yes, use the --ref flag.  --ref can be any valid git reference (tag, commit, or branch).


Pagination

Website has started looking messy, so it would be great if we could implement pagination function, so that a user can navigate between pages and each page can show a max of 10 cards.

Hey @Raunak173 can you assign this issue to me

This issue has been assigned to you, can start working on it now!

can I work on this?

Hi @Rahul-Palahwat , I guess this issue is taking longer than expected. Would you still like to work on it or I may proceed with someone else.

Hey @Raunak173 as i have to make it whole in a array...i will be doing this most probably by EOD or by tomorrow morning

All good @Rahul-Palahwat , Do mention the issue number on your pull request.

Hey @Raunak173 , Can you assign this issue to me? As I have already done this thing before, I can complete it by today or tomorrow morning.

@AnantJain05 I am assigning this issue to you.


Specify the stroke-width of the path

Would it be possible to add an option to change the stroke-width attribute of the path element in the SVG?
For my current case I'd like to use a Heroicon but with stroke-width set to 1:
<svg xmlns="http://www.w3.org/2000/svg" class="h-6 w-6" fill="none" viewBox="0 0 24 24" stroke="currentColor">
  <path stroke-linecap="round" stroke-linejoin="round" stroke-width="1" d="M5.121 17.804A13.937 13.937 0 0112 16c2.5 0 4.847.655 6.879 1.804M15 10a3 3 0 11-6 0 3 3 0 016 0zm6 2a9 9 0 11-18 0 9 9 0 0118 0z" />
</svg>

The tag could have an optional attribute so it would be called like:
<Heroicons.Outline.user_circle class="h6 w-6" stroke-width="1" />

Hey, @mveytsman correct me if I'm wrong, but with the recent build this issue is already solved, so it can be closed?
Right now you can pass the stroke-width as assign to the Functional Component and it will affect the SVG.

That's absolutely correct thanks @greven!

This is currently broken, re-opening

@greven width and height were just added to the globals in live view (but this obviously hasn't shipped yet
https://github.com/phoenixframework/phoenix_live_view/commit/feeb5f86d8c4429909816e6f467a49a976cb4084
I think there's still an issue with stroke-width but I havent' tested it enough...

@greven width and height were just added to the globals in live view (but this obviously hasn't shipped yet
https://github.com/phoenixframework/phoenix_live_view/commit/feeb5f86d8c4429909816e6f467a49a976cb4084
I think there's still an issue with stroke-width but I havent' tested it enough...

Oh that's great, missed that, thanks. The amount of warnings I had because of that was a bit unsettling!

Closed in https://github.com/mveytsman/heroicons_elixir/commit/c712f72aa8815c899119092472bf237b9b5f77c3


chore(main): release cyclistsofmsn-client 1.2.0

:robot: I have created a release beep boop
1.2.0 (2024-12-16)
Features

add image description to post list page (fb04199)

Bug Fixes

bump @emotion/react from 11.13.3 to 11.13.5 (d0bad2f)
bump @emotion/styled from 11.13.0 to 11.13.5 (7d21ea5)
bump @mui/icons-material from 6.1.5 to 6.1.6 (8c19032)
bump @mui/icons-material from 6.1.6 to 6.1.9 (257d03c)
bump @mui/material from 6.1.5 to 6.1.6 (4446281)
bump @mui/x-data-grid from 7.18.0 to 7.22.1 (a5c1c86)
bump @mui/x-data-grid from 7.22.1 to 7.23.0 (400820a)
bump @tanstack/react-query from 5.59.16 to 5.62.0 (f34d58c)
bump @tanstack/react-query-devtools from 5.59.16 to 5.62.0 (6a90706)
bump react-error-boundary from 4.0.13 to 4.1.2 (63962f8)
bump react-hook-form from 7.53.0 to 7.53.1 (ccc1982)
bump react-hook-form from 7.53.1 to 7.53.2 (dc8d526)
bump react-router-dom from 6.26.2 to 6.27.0 (02230d6)
bump superagent from 10.1.0 to 10.1.1 (74b7f88)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

cyclistsofmsn-client-v1.2.0
:sunflower:


Anchor "Home Documentation Contributing Blog" line on docs

Summary
When I scroll through a doc page, I quickly loose the line at the top with links to Home, Documentation, Contributing, and Blog.  These should be anchored so they stay visible as I scroll through a documentation page.
DoD

Top bar on doc page stays visible when I scroll through the page

please assign

please finish some of your already assigned issues before starting new ones :)

can I work on this issue?

sure!


Drawing canvas doesn't scale with window

Describe the bug
When the window is resized, the DFD drawing canvas doesn't resize with it.
Expected behaviour
Expected the canvas to size to fill the window (or to have the ability to resize the panes in the window.
Environment

Version: 2.0
Platform: AppImage
OS: RHEL 8.6
Browser: N/A

To Reproduce

Open a threat model
Click into the diagram
Resize the window

Any additional context, screenshots, etc

Can also be reproduced on threatdragon.com (v2.0.1-demo). Suspect issue affects all environments.

thanks @sparticvs , this is a very good point
I have labeled it as something for version 2.0, in the hope that we can sort it for then

not able to work out how to implement this: https://x6.antv.vision/en/docs/api/graph/graph#autoresize
The work around is to close the diagram and open it again - it then resizes for the new window size

Need to document the workaround
attempt to correct this did not work: see 5b5b48b62ccb450dd8fb5d16f94e9c65a8f43c3d

Can I work on this issue

hey @jgadsden! I have tried to implement auto resizing as described in https://x6.antv.vision/en/docs/api/graph/graph#autoresize but haven't been able to. I am still trying to get a way out. Meanwhile I have implemented the window resizing issue that is the core problem as described in this raised issue.
here's what the update does :
https://github.com/OWASP/threat-dragon/assets/94848646/9fa7f9c1-c500-455b-b9c7-c5c33b5453be

thanks @raghav1030 , do you want to provide a pull request for this? Any incremental improvement is appreciated


Should --local be the default?

Now that we have an officially supported "local" development environment, the question begs to be asked - should local mode be the default when you start up? There are plenty of positives -

You don't have to login to start developing
It starts 'instantly' (relatively speaking of course)
In watch mode, it refreshes 'instantly'
It'll 'work' automatically in environments like codespaces/csb/etc (excluding devtools etc)

There are drawbacks too, of course -

Given the chance of implementation drift between miniflare and cloudflare, you want to make sure your code works in production as your developed it, and you maaay miss something in local mode.
This is exacerbated by things like compatibility_date and compatibility_flags
It'll be breaking behaviour from wrangler v1 for commands like kv:namespace, kv:key etc etc, so it may confuse someone who runs the commands and sees nothing happens on their actual production sites

I don't think the drawbacks outweight the positives, but I'd like to put the idea out there for a while, and get feedback before we commit to it. Of course, you will always be able to use both local and, er, 'remote' mode, it's just a question of what the default starting experience should be.

cc @irvinebroque: in https://github.com/cloudflare/wrangler2/issues/29 you said "Specific to Wrangler, to me one if it's absolute biggest selling points is that wrangler dev actually runs code in a Cloudflare Worker, while in development. Live debugging in dev, with code running on a real Cloudflare Worker, is a killer feature." Could you explain why this is so critical? Any specific usecases? wrangler will always support both remote/local modes. but I've been wondering what the default should be; our most requested feature was local development, and it made sense to have that as the first development experience for Pages

Personally, I would like to default to local. Being able to configure Miniflare to persistent (or not persist) things like KV and DO data is fantastic. It picking up on .env and more. It's also just generally much quicker to develop with Miniflare in my opinion and my workflow very much depends on it these days.
There are of course the downsides, for example working with DOs was a pain for quite a while there with Miniflare. Hopefully this drift of implementation and mock is smaller now that Miniflare is official.
It's also super nice sometimes to have code running on the edge before production just to verify that it does indeed work and there's no weirdness with Miniflare. That's when I actually use edge-dev is to make sure things work before a production push.
In my opinion, Miniflare being default makes a lot of sense.

Live debugging in dev, with code running on a real Cloudflare Worker, is a killer feature." Could you explain why this is so critical?

Yep - I know from talking to others that my view isn't consensus, but here's why I think this is the case:

Dev environment matching production 1:1 prevents inconsistencies between the two as the source of bugs. No other modern platform (AFAIK) lets you run code in dev on the literal exact runtime/instance/etc. as production. I think this gets increasingly important with Workers KV, Durable Objects, and any other stateful products built on top of these primitives, and I would explicitly distrust any local shim implementation of these services. Consider a common source of bugs with current production applications at scale - locally in dev, engineers run a local MySQL instance, everything seems like it works, but then when their code runs in production, it's running against a sharded set of Aurora instances fronted by Proxy SQL, ELBs, etc.. Same APIs, but different infrastructure = subtle differences with transaction behavior, etc. I'm sure the current Miniflare implementations of KV/Durable Objects are really excellent, but why not eliminate the surface area altogether? The issues in the node community with Jest and JSDom are IMO instructive examples of the risks of layers of software being built on top of mock implementations. The magic of workers is that we can use the real thing and avoid all of this!
Dev running on workers === easier custom domains in dev, sharable links without localhost. See https://github.com/cloudflare/wrangler/issues/2087#issuecomment-934884722 - anyone building apps that depend on incoming webhooks needs to expose their dev environment at a public URL. If my requests in dev already have to be proxied by ngrok (or cloudflared), why not run on workers instead of localhost? What is localhost giving me, other than a potential source of headaches (for me and for maintaining wrangler). My understanding is that under the hood wrangler dev already spins up a subdomain, and then tunnels it back to localhost via cloudflared, but what I'd want is to just access that public domain directly, and be able to configure it and count on it being static.
Run on a real Worker in dev === use future prod debugging/logging/analytics features in dev. Cloudflare has great built-in tools on the dashboard, with surely lots more on the way. Ex: I can look at my worker's P95 CPU timing on the workers dashboard, look at cache analytics for my domain, request geo routing, etc. This is all stuff that's not always easy to do in dev, and way out of scope for wrangler to provide, beyond wrangler tail. But it doesn't seem crazy to provide these types of tools in development if the code is already running on the same Worker runtime as production. You could do stuff like "visualize a request path through a worker" without having to build anything new into wrangler itself. I think there's tons of greenfield space here to go after "changes that today can only be tested by pushing a change to production". Maybe preview deployments are really where that comes in, but why not shorten the feedback loop even further and put it in dev?

I know the big tradeoff with all of this (today) is local frontend developer experience - hot reloading magic, instant as-you-type editing are hard to implement with wrangler syncing files to a worker. I love this stuff, it's what got me excited about frontend and React ~8 years ago! But I will happily trade that 10/10 times for a dev environment that mirrors production 1:1. Saving hours caused by bugs in prod or chasing down dev/prod inconsistencies > saving ms hot reloading. Dev environments that mirror production will help convince a whole engineering team to move to Workers, not just the frontend nerds who are excited about the edge.

Great feedback, thank you!

Closing this. For 2.0, we're not going to have local as the default. Thanks everyone for the feedback!


test suite incompatible with ava@^1

The throws method in ava@^1 is incompatible with the usage in the test suite. The tests need to be updated, or ava should be pinned to ava@^0

Fixed by https://github.com/sindresorhus/p-some/commit/8981c38245b6db7b134923e08b222cf1599a01ed


Discuss and define initial set of example connections to potential data sources for discovery in general

We have multiple efforts underway to better understand data sources we could use for potential demos/prototypes.
For example: Wikidata (Steven is looking at authority <-> wikidata connections), the Knowledge Panel spreadsheet which includes possibilities for data we may be including.   Tim has worked on bringing Discogs into QA so that is another possibility for information we could bring in/review.
Can we glean some examples from these sources to help define some concrete scenarios where linked data information can be used?
Additionally, for our local institutions data sources, what do we know about them and how can we use this information?
For example: Cornell's digital collections, open access and subscription databases, (article search)? How can we make connections between these sources and the catalog?

The sources for KPAOW were LOC authorities within our catalog system, LOC (id.loc.gov), FAST, Wikidata, DbPedia, and Cornell Digital Collections. A separate issue will be made for data sources for the next phases.


Fix min max time

Min and Max time was not showing when user wants to change temporal boundaries.

Merged build triggered. Test Failed.

Merged build started. Test Failed.

Merged build finished. Test Failed.


removing SolvingMicroDSOPs from HARK

It looks like there is still as SolvingMicroDSOPs directory in the HARK library, with nothing but empty init.py files in it
https://github.com/econ-ark/HARK/tree/master/HARK/SolvingMicroDSOPs
This should be removed

I was wondering the same, is there a reason to keep, maybe any downstream import statement?


Display error for Source Sans Pro w600 in Smallcap headlines

There is a problem in the Source Sans Pro showcase for Smallcap headlines @weight 600 (see screenshot).
The fallback fond (serif) gets rendered.

I'm using
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0

Ah, thanks for that. It seems that Firefox is the only browser that cares about the case of the source file within a @font-face declaration.


nixos/systemd-boot: use unique path for devicetree blob

Description of changes
Fixes #336030
Use the store directory for the devicetree package containing the desired DTB when installing to the ESP. This allows for more than one NixOS generation containing differing DTBs to coexist on the same ESP (similar to how we can have multiple kernels & initrds). This change removes the assumption that the filepath passed to copy_from_file is a file that lives at the toplevel of a nix output path (which prior to the systemd-boot DTB support was the case for the kernel and initrd derivations).

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test systemd-boot.specialisation

@ofborg test systemd-boot.specialisation

@ofborg test systemd-boot.specialisation

@colemickens I realized we can use builtins.storeDir to detect the case where /nix/store is not the store dir, allowing us to not use regex!

@ofborg test systemd-boot.specialisation

There was also a bit of concern about the mixing of pathlib and os.path

I changed to remove pathlib for now to remain consistent with the rest of the script

retested with 05aefd6: seems good to me:

Noticed this problem as well and was about to make a PR with the code I used in my variant of the original systemd-boot devicetree PR to fix the problem when I noticed it had already been fixed here. Thank you.


MacBook Pro Touchbar Start Debugging Button not working (in Python)

Issue Type: Bug
Regardless of what python code I want to start, the "Play" button in the touch bar does not work. I have to hit fn+F5 to start the debugging. However, when I started the process via fn+F5 all the subsequent touchbar buttons work perfectly fine.
It doesn't make a difference if a Breakpoint is set or not.
My launch.json and settings.json have only the default settings.
Does this issue occur when all extensions are disabled?: Yes
VS Code version: Code 1.30.0 (c6e592b2b5770e40a98cb9c2715a8ef89aec3d74, 2018-12-11T22:22:15.793Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz (4 x 3500)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (0.37GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

python
ms-
2018.12.1

Will be fixed in the recovery release later today / tomrrow.
Closing as dupplicate


SimpleScalarSeparateChainingHashTable for fast-path join & grouping

This PR introduces SimpleScalarSeparateChainingHashTable, which is a special, simplified version of SeparateChainingHashTable for scalar (non-composite) keys that have a reversible hash function. It eliminates much of the complexity of key management (including the need to store a key separately at all) and hashing. Using the simplified version in hash-join and aggregation-grouping operations is expected to be faster than using the original SeparateChainingHashTable (although the original, along with LinearOpenAddressingHashTable, is still available as fallbacks for cases where we require their full generality, like string keys or composite keys).
Besides the introduction of the new HashTable class itself, this PR also introduces a couple of other changes that the new implementation depends on:

Hashing logic in TypedValue is changed so that we use our own trivially reversible hash function for simple scalar types instead of relying on std::hash.
Functionality in the base HashTable class that involves management of key storage has been moved to a new helper class HashTableKeyManager. The preexisting HashTable implementations require this functionality and automatically create a HashTableKeyManager object when they are created. The new SimpleScalarSeparateChainingHashTable doesn't require a HashTableKeyManager and thus doesn't create one.

There is probably some additional fast-path tuning that we can do for hash joins generally and for the new SimpleScalarSeparateChainingHashTable specifically, but this is a good first step towards optimizing the common case for joins and grouping operations with simple scalar keys.

Looks quite good @craig-chasseur. Thanks! A few comments to make it easier for someone to browse the code.
Also, did you carry out any performance experiments (say with SSB Q1?). If yes, would be nice to document that here.

I actually don't have a benchmarking setup for SSB. Could we get one of the
students who worked on benchmarking to write a wiki page with step-by-step
instructions for getting benchmark numbers for us? That would be quite
helpful.
On Wed, Jan 20, 2016 at 7:36 PM Jignesh Patel<EMAIL_ADDRESS>wrote:

Looks quite good @craig-chasseur https://github.com/craig-chasseur.
Thanks! A few comments to make it easier for someone to browse the code.
Also, did you carry out any performance experiments (say with SSB Q1?). If
yes, would be nice to document that here.
—
Reply to this email directly or view it on GitHub
https://github.com/pivotalsoftware/quickstep/pull/6#issuecomment-173440638
.

@craig-chasseur @cramja has started a benchmark repo at https://github.com/UWQuickstep/benchmarks
An easier way to run SSB is pull the files from: http://pages.cs.wisc.edu/~jignesh/data/. The tarball there (its large) has raw files for 1 and 10 SF SSB, and the SQL files.

Hey @pateljm, added some explanatory comments as requested. Please take another look.

LTGM. Thanks! Merging now.


Playoutbee ClipID Handling

Hi
If we report back the ClipID number we got from playoutbee, why is +1 added in api.js to the ClipID? If we really want to report back what we got from playoutbee, then this +1 should be avoided as well. Am I wrong?
At the end we report something wrong to companion, if we have no clips, index of ClipID is 0 even if we don't have any clips and the name and Id of the current clip is most probably wrong.
A bug should be reported to playoutbee. IMHO it should be the following way (from playoutbee API):

no clips: ClipID = -1 (--> That's currently not the case)
1 clip: ClipID = 0
larger than 1 clip: ClipID > 0

What do you think?
Regards
André

playout bee V2 is now using unique ID's and indexes so this should be resolved with version 1.9.0 and later


Missing Documentation: Rancher Monitoring requires port 10254

Rancher Monitoring requires that the host firewall be open on port 10254. Prometheus will scrape metrics from this port. However, this port is not correctly documented in the Rancher Docs.
There are two places where this could be documented:

https://docs.ranchermanager.rancher.io/pages-for-subheaders/monitoring-and-alerting , which does not mention port 10254.

The Rancher documentation at Ports for Rancher Launched Kubernetes Clusters using Custom Nodes uses a grid to explain the firewall requirements. In the following section, I'm looking at the "From Worker Plane Nodes", "To Worker Plane Nodes". Note footnote 4 in the box labeled "10254 TCP (4)".

Footnote 4 says:

Local traffic to the node itself (not across nodes).

Users have pointed out this discrepancy in the docs in a couple previous issues, such as:

https://github.com/rancher/rancher-docs/issues/136#issuecomment-1247331477

@stefanlasiewski I started looking into this issue. How should footnote 4 for the table be updated?

Local traffic to the node itself (not across nodes).

Hi @martyav, I would suggest that the documentation should say that for optional features such as Rancher Monitoring, port 10254 between nodes. I'm  not sure how to phrase that concisely.

Yes, I think that may be it.


website: wrong links

Hi there,
I've found a few 404s on golang.org, mostly on some old blog posts and release notes so probably not an issue.
Not sure if anyone wants them fixed, but here you go

http://blog.golang.org/organizing-go-code links to http://golang.org/src/cmd/godoc/

"Godoc is nearly 6000 lines over 16 files"

https://golang.org/doc/go1.4 links to https://golang.org/pkg/crypo/tls/

"through the new CertificateForName function of the Config struct."
Small typo in "crypo" on the "Config" link.

https://golang.org/doc/devel/release.html links to https://golang.org/pkg/exp/gui/

"The GUI-related code from exp/draw is now located in the exp/gui package."
Looks like this package no longer exists, admittedly this is from 2011 so things will have changed since then

https://golang.org/doc/devel/weekly.html links to http://golang.org/doc/devel/roadmap.html

"There is now a public road map, in the repository and online"
This page stopped being updated in 2012, so probably doesn't need to be fixed

https://golang.org/doc/devel/release.html links to https://golang.org/pkg/old/template/

"The original template package is still available as old/template. The old/template package is deprecated and will be removed."
Evidently this happened so doesn't need to be fixed!

doc/go1.4.html has just been fixed.
I'm not sure if we want to fix older release docs. we probably want to
update
the blog post though.

Found another broken link, just above http://golang.org/pkg/math/#MaxFloat32 it links to http://oeis.org/Axxxxxx, which returns a 404.

The oeis link is not broken, it means for you to fill in the xxxxx with the numeric IDs from the comments. For example: http://oeis.org/A002193 for math.Sqrt2

I see, in that case it could do with some explanation.


unable to use wifi and no sound for earphone

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

thank you for replying me. I used the configurator to force io8blablabla.Kext running and the WiFi seems working pretty well with the airportltlwm, while I still don’t know fix the earphone issue

thank you for replying me. I used the configurator to force io8blablabla.Kext running and the WiFi seems working pretty well with the airportltlwm, while I still don’t know fix the earphone issue

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

don‘t know if I am using alc_fix correctly, the earphone only works for the first plug in after reboot, if I remove it and replug it doesn’t work again.

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

don‘t know if I am using alc_fix correctly, the earphone only works for the first plug in after reboot, if I remove it and replug it doesn’t work again.

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

don‘t know if I am using alc_fix correctly, the earphone only works for the first plug in after reboot, if I remove it and replug it doesn’t work again.

Uninstall the previous one using ```
sh uninstall.sh

Then install this [one](https://www.github.com/i3p9/Hackintosh-BigSur-Catalina-OpenCore-Lenovo-T450s-efi/tree/master/Utilities%2Falc_fix_swift) as per instructions i attached in the README.md kf Utilities folder

See if this fixes your issues, it's a new improved one

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

don‘t know if I am using alc_fix correctly, the earphone only works for the first plug in after reboot, if I remove it and replug it doesn’t work again.

Uninstall the previous one using ```
sh uninstall.sh

Then install this [one](https://www.github.com/i3p9/Hackintosh-BigSur-Catalina-OpenCore-Lenovo-T450s-efi/tree/master/Utilities%2Falc_fix_swift) as per instructions i attached in the README.md kf Utilities folder

See if this fixes your issues, it's a new improved one

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

don‘t know if I am using alc_fix correctly, the earphone only works for the first plug in after reboot, if I remove it and replug it doesn’t work again.

Uninstall the previous one using
sh uninstall.sh

Then install this one as per instructions i attached in the README.md of Utilities folder
See if this fixes your issues, it's a new improved one

thanks a lot for the helps. May I ask one more question ?the hidpi thing seems making no change on sharpness,unlike those picture online showing much difference,the only change I could found is that my monitor becomes retina monitor in the setting, is it normal ？

I'm using a ax200 and it seems not working. And also there is no sound when I plug in my earphone. I'm a newbie for opencore, I've been checking these issues online for few days, and none of the methods work.I'll so grateful if anybody can help to solve it.

There is a known issue with the jack. It only works when you put the laptop to sleep and wake it up after every first boot. Try installing the alc_fix in Utilities folder to fix this issue. Although alc_fix seems to be spotty on Big Sur.
For that wifi card i think driver support by itlwm is not very good. It seems to be a proprietary card for oems with proprietary drivers. People have had success with it but most have reported it not working. I suggest you use the stock wifi card or buy a macOS compatible card

don‘t know if I am using alc_fix correctly, the earphone only works for the first plug in after reboot, if I remove it and replug it doesn’t work again.

Uninstall the previous one using
sh uninstall.sh

Then install this one as per instructions i attached in the README.md of Utilities folder
See if this fixes your issues, it's a new improved one

thanks a lot for the helps. May I ask one more question ?the hidpi thing seems making no change on sharpness,unlike those picture online showing much difference,the only change I could found is that my monitor becomes retina monitor in the setting, is it normal ？

Is your monitor high dpi? It's supposed to be a 1440p and a ove monitor to see an increase in sharpness. Or if it's 1080p it should have a DPI of at least 300

Is your monitor high dpi? It's supposed to be a 1440p and a ove monitor to see an increase in sharpness. Or if it's 1080p it should have a DPI of at least 300


FI-2808: DTR Bundle

Summary
Add bundle to support DTR test kit Respiratory Assist Device questionnaire workflow. This includes all the resources necessary for a DTR SMART App to pre-populate the questionnaire.

I ran this through the validator at https://validator.fhir.org/and there are a few issues. I'm not worried about all of them but in general I think we want the files to be as clean as possible

@dehall I fixed all the ones you pointed out. I still get some errors for URLs not resolving. Do you think these matter? I pulled these fixtures from the DRLS reference implementation and am worried that the CQL execution relies on these URLs.

Hm yeah it's worth another look at those. For example the system condition-category ones should probably be replaced with http://terminology.hl7.org/CodeSystem/condition-category

Hm yeah it's worth another look at those. For example the system condition-category ones should probably be replaced with http://terminology.hl7.org/CodeSystem/condition-category

Thanks for the tip on that. I fixed the remaining errors.  Do you think we care about those?

should the fullUrl elements be removed? looks like they don't match the ids of the instances or the put statements and aren't referenced anywhere.
I think the other warnings are fine to ignore at this time

should the fullUrl elements be removed? looks like they don't match the ids of the instances or the put statements and aren't referenced anywhere.
I think the other warnings are fine to ignore at this time

See https://github.com/inferno-framework/inferno-reference-server/pull/155#discussion_r1628361232

should the fullUrl elements be removed? looks like they don't match the ids of the instances or the put statements and aren't referenced anywhere.

I see now that there was originally an error around not having fullUrls. The updated approach still doesn't look great (you're calling something a uuid when it isn't, e.g., pat015), but I think we should move on rather than get this perfect


ENH: Refactor workflow to adopt SDCFlows' new correction workflow

This PR addresses the problem reported in #2210.
Along with the specific changes in SDCFlows, this PR:

Resamples BOLD data in its native space using new SDCFlows' utilities.
Introduces a new IdentityInterface node called bold_final that acts as buffer to reduce LoC and branches when dealing with data with/without fieldmaps (and helpful too for ME-EPI, although this is not fully implemented).
ROIs plot now uses the output of unwarping through a RobustAverage node, therefore fixing one issue reported in #2210.
preproc datasink of BOLD in native space now connected to the bold_final node, which contains HMC'ed + SDC'ed (if fieldmaps found) BOLD in native space. Now, it is matched with the ROIs plot, reducing a little the opportunities for divergence.

This PR DOES NOT solve (or even leaves without implementation):

Resampling into T1w and standard spaces when fieldmap is present - the same error for the bold data reported in #2210 is expected to happen, as the displacements field generated by SDCFlows does not look right all times (nipreps/sdcflows#236)
Mapping of surfaces into EPI
ME-EPI + fieldmaps (still trying to resolve problems with single-echo, will look into this at a later time).

@mgxd I've rebased on master after running black on workflows/bold/base.py, so the diff should be much cleaner now. Some little stylistic changes remained, but now they are just residual changes I don't think will disturb the review process.

This is holding me up a little, so I'll merge.


If the server and route in Kong are in Chinese, but the Prometheus plugin does not support display

UTF-8 support was added in upstream a while ago. I created https://github.com/Kong/kong-plugin-prometheus/pull/146
to backport it.


refactor(ci): Pipeline yml cleanup

Description
Cleans up a few things we had noticed in our yml files.

Some variables (releaseBuildVar, componentDetection) were not used anymore (if anything only printed, but not used for any functional purpose).
Some templates were being referenced just by their filenames, where we've tried to move to absolute paths everywhere for clarity and consistency.
include-policy-check.yml was not included as a PR/CI trigger for many build pipelines that depend on build-npm-package.yml (which in turn depends on include-policy-check.yml).
Change buildNumberInPatch from a string to a boolean, like it could have been from the start, and gave it a default to avoid passing an empty string explicitly in several pipelines. Its value ends up as VERSION_PATCH here, and that flag gets checked against "true". So replacing with a boolean should be fine

Reviewer Guidance
The review process is outlined on this wiki page.
AB#6994

@microsoft-github-policy-service rerun


Drop Column_Type trait and strictly check type shortcut lengths

As per issue flagged on https://scrutinizer-ci.com/g/Pink-Crab/WPDB-Table-Builder/issues/master/files/src/Column_Types.php?orderField=path&order=asc&honorSelectedPaths=0
Fixes

The PinkCrab\Table_Builder\Column_Types should be dropped and the methods added to the Columns class. This trait is only really used to keep the class a little cleaner, but cant really be used on any other class.

Apply strict length checks on Column_Types methods.

if ( $length !== null ) { // not if ( $length )
	$this->length( $length !== null );
}

Retaining the trait, but issues with falsy values is already resolved.
/**
	 * Sets column as datetime with an optional default.
	 *
	 * @since 0.2.0
	 * @param string|null $default
	 * @return Column
	 */
	public function datetime( ?string $default = null ): Column {
		$this->type( 'datetime' );
		if ( $default ) {
			$this->default( $default );
		}
		return $this;
	}


Update emacs2nix and update-melpa.el

Motivation for this change
Emacs packages sourced from GitLab have not been building since they are downloaded using incorrect addresses.  This change uses the GitLab API path for downloading archives.
Things done

Tested changes by running the update-melpa script in the pkgs/applications/editors/emacs-modes directory, checked the output of emacs-geiser/geiser and other known GitLab emacs packages to ensure the warnings about unable to download were removed from the resulting JSON file.  I am not submitting updates to the JSON file as I'm not confident this is the correct procedure for updating it.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/emacs-python-mode-marked-as-broken-cant-rebuild-nixos-config/12674/3

For context, the issue this PR fixes affects the following Emacs packages:
fennel-mode
geiser
geiser-chez
geiser-chibi
geiser-chicken
geiser-gambit
geiser-guile
geiser-mit
geiser-racket
gif-screencast
ligo-mode
mixed-pitch
modus-themes
oer-reveal
org-re-reveal
python-mode
recomplete
spell-fu
undo-fu
undo-fu-session
xref-rst
zotero

Once this is merged, re-running the 'update-melpa' script and merging a PR with the updated 'recipes-archive-melpa.json' will make these packages accessible again.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/371

bump?

At this state, what needs to be done to get this merged?

@kennyballou I wish I knew. I reviewed and approved, and cross-posted into discource's "already reviewed" thread. This is the first nixpkgs PR I've reviewed, so maybe I'm missing something.
It looks like maybe it still needs approval from @adisbladis.

@danieldk pinging you as suggested in discourse. I reviewed and approved this PR 5 days ago and it appears stalled. Can you help move this forward? Thanks!

@mattchrist thanks for pining me! I'll have a look.

Thanks and sorry for the long wait!


CNV-23379: Create Select InstanceTypes section

📝 Description
This PR adds the 'Select InstanceTypes' section to the InstanceTypes form.
🎥 Demo
https://user-images.githubusercontent.com/8544299/212799972-10bc7a41-8f3f-4618-91de-18fc035acdd5.mp4

LGTM
@metalice can you please review again?

/lgtm


Refactor the optimization problem

Do not pass lambdas to problem_t, but implement some pure virtual protected functions instead.
Keep the old interface as a functor_problem_t that implements the problem_t interface.

Maybe implement some model-based problems: e.g. to compute gparam or ginput as the gradient, given a model or possible an accumulator


gdb: custom driver is invalid

Go version
go1.21
GoFrame version
2.7.0
Can this bug be reproduced with the latest release?
Option Yes
What did you do?
package main
import (
	"database/sql"
	"fmt"
	"github.com/gogf/gf/contrib/drivers/mysql/v2"
	"github.com/gogf/gf/v2/database/gdb"
	"github.com/gogf/gf/v2/frame/g"
)

func main() {
	if err := gdb.Register("MyBizDriver", &MyBizDriver{}); err != nil {
		panic(err)
	}
	s, err := g.Model("sys_log").One()
	fmt.Println(s, err)
}

type MyBizDriver struct {
	*mysql.Driver
}

func (d *MyBizDriver) Open(config *gdb.ConfigNode) (db *sql.DB, err error) {
	config.User = "aaaa"  // **bug: 这里就没执行**
	config.Pass = "bbbb"
	return d.Driver.Open(config)
}

func (d *MyBizDriver) decode(s string) string {
	// 执行字段解密处理逻辑
	// ...
	return s
}

config.yaml
database:
  default:
    link: "MyBizDriver:root:123456@tcp(<IP_ADDRESS>:3306)/test"
    timezone: "Asia/Shanghai"
    debug: true

What did you see happen?
The Open function is not executed
What did you expect to see?
The Open function executed

Please refer to the document ORM使用配置，The parameter to this position in your configuration 'MyBizDriver' is the database type, which according to your code should be 'mysql'.
You can find details about Link parsing here:
https://github.com/gogf/gf/blob/c4327f62e7e058773a028e63aad349e6941341cf/database/gdb/gdb_core_config.go#L109-L121

Please refer to the document ORM使用配置，The parameter to this position in your configuration 'MyBizDriver' is the database type, which according to your code should be 'mysql'.
You can find details about Link parsing here:
https://github.com/gogf/gf/blob/c4327f62e7e058773a028e63aad349e6941341cf/database/gdb/gdb_core_config.go#L109-L121

MyBizDriver is custom driver name, doc link: https://goframe.org/pages/viewpage.action?pageId=1114158

It seems that your code does not implement the New() method. During the registration process, this method is called to load the custom object you provide. If the New() method is not overridden, it will load the default contrib/drivers/mysql/mysql.go#New() method, and the Open() method will also use the default contrib/drivers/mysql/mysql_open.go implementation when called.
If you still have problems, here is a working example for reference:
https://github.com/gogf/gf/blob/c4327f62e7e058773a028e63aad349e6941341cf/example/database/mysql/driver-encrypt-decrypt-password/main.go

@freesme greet! It's better to look at the documentation than to see the demo. thank you!


QUIT event may not be read from the event log on slow machines

This would manifest itself as:
   [junit4] ERROR: JVM J0 ended with an exception: Quit event not received from the forked process? This may indicate JVM crash or runner bugs.
   [junit4]     at com.carrotsearch.ant.tasks.junit4.JUnit4.executeSlave(JUnit4.java:1540)